File: misplaced-array-index.cpp

package info (click to toggle)
swiftlang 6.0.3-2
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 2,519,992 kB
  • sloc: cpp: 9,107,863; ansic: 2,040,022; asm: 1,135,751; python: 296,500; objc: 82,456; f90: 60,502; lisp: 34,951; pascal: 19,946; sh: 18,133; perl: 7,482; ml: 4,937; javascript: 4,117; makefile: 3,840; awk: 3,535; xml: 914; fortran: 619; cs: 573; ruby: 573
file content (34 lines) | stat: -rw-r--r-- 1,009 bytes parent folder | download | duplicates (30) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
 
// RUN: %check_clang_tidy %s readability-misplaced-array-index %t

#define ABC  "abc"

struct XY { int *X; int *Y; };

void dostuff(int);

void unusualSyntax(int *P1, struct XY *P2) {
  10[P1] = 0;
  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: confusing array subscript expression, usually the index is inside the []
  // CHECK-FIXES: P1[10] = 0;

  10[P2->X] = 0;
  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: confusing array subscript expression
  // CHECK-FIXES: P2->X[10] = 0;

  dostuff(1["abc"]);
  // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: confusing array subscript expression
  // CHECK-FIXES:  dostuff("abc"[1]);

  dostuff(1[ABC]);
  // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: confusing array subscript expression
  // CHECK-FIXES:  dostuff(ABC[1]);

  dostuff(0[0 + ABC]);
  // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: confusing array subscript expression
  // CHECK-FIXES:  dostuff(0[0 + ABC]);
  // No fixit. Probably the code should be ABC[0]
}

void normalSyntax(int *X) {
  X[10] = 0;
}