1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
|
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
@_spi(Testing) import LSPLogging
import LanguageServerProtocol
import SKTestSupport
import XCTest
import enum PackageLoading.Platform
class DefinitionTests: XCTestCase {
func testJumpToDefinitionAtEndOfIdentifier() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)
let positions = testClient.openDocument(
"""
let 1️⃣foo = 1
_ = foo2️⃣
""",
uri: uri
)
let response = try await testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["2️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(locations, [Location(uri: uri, range: Range(positions["1️⃣"]))])
}
func testJumpToDefinitionIncludesOverrides() async throws {
let project = try await IndexedSingleSwiftFileTestProject(
"""
protocol TestProtocol {
func 1️⃣doThing()
}
struct TestImpl: TestProtocol {
func 2️⃣doThing() { }
}
func anyTestProtocol(value: any TestProtocol) {
value.3️⃣doThing()
}
"""
)
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["3️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(
locations,
[
Location(uri: project.fileURI, range: Range(project.positions["1️⃣"])),
Location(uri: project.fileURI, range: Range(project.positions["2️⃣"])),
]
)
}
func testJumpToDefinitionFiltersByReceiver() async throws {
let project = try await IndexedSingleSwiftFileTestProject(
"""
class A {
func 1️⃣doThing() {}
}
class B: A {}
class C: B {
override func 2️⃣doThing() {}
}
class D: A {
override func doThing() {}
}
func test(value: B) {
value.3️⃣doThing()
}
"""
)
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["3️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(
locations,
[
Location(uri: project.fileURI, range: Range(project.positions["1️⃣"])),
Location(uri: project.fileURI, range: Range(project.positions["2️⃣"])),
]
)
}
func testDynamicJumpToDefinitionInClang() async throws {
let project = try await SwiftPMTestProject(
files: [
"Sources/MyLibrary/include/dummy.h": "",
"test.cpp": """
struct Base {
virtual void 1️⃣doStuff() {}
};
struct Sub: Base {
void 2️⃣doStuff() override {}
};
void test(Base base) {
base.3️⃣doStuff();
}
""",
],
enableBackgroundIndexing: true
)
let (uri, positions) = try project.openDocument("test.cpp")
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["3️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(
locations,
[
Location(uri: uri, range: Range(positions["1️⃣"])),
Location(uri: uri, range: Range(positions["2️⃣"])),
]
)
}
func testJumpToCDefinitionFromSwift() async throws {
let project = try await SwiftPMTestProject(
files: [
"Sources/MyLibrary/include/test.h": """
void myFunc(void);
""",
"Sources/MyLibrary/test.c": """
#include "test.h"
void 1️⃣myFunc(void) {}
""",
"Sources/MySwiftLibrary/main.swift":
"""
import MyLibrary
2️⃣myFunc()
""",
],
manifest: """
let package = Package(
name: "MyLibrary",
targets: [
.target(name: "MyLibrary"),
.target(name: "MySwiftLibrary", dependencies: ["MyLibrary"])
]
)
""",
enableBackgroundIndexing: true
)
let (uri, positions) = try project.openDocument("main.swift")
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["2️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(locations.count, 1)
let location = try XCTUnwrap(locations.first)
XCTAssertEqual(
location,
Location(uri: try project.uri(for: "test.c"), range: Range(try project.position(of: "1️⃣", in: "test.c")))
)
}
func testReportInitializerOnDefinitionForType() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)
let positions = testClient.openDocument(
"""
struct 1️⃣Foo {
2️⃣init() {}
}
_ = 3️⃣Foo()
""",
uri: uri
)
let response = try await testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["3️⃣"])
)
XCTAssertEqual(
response,
.locations([
Location(uri: uri, range: Range(positions["1️⃣"])),
Location(uri: uri, range: Range(positions["2️⃣"])),
])
)
}
func testAmbiguousDefinition() async throws {
// FIXME: This shouldn't have to be an indexed workspace but solver-based cursor info currently fails if the file
// does not exist on disk.
let project = try await IndexedSingleSwiftFileTestProject(
"""
func 1️⃣foo() -> Int { 1 }
func 2️⃣foo() -> String { "" }
func test() {
_ = 3️⃣foo()
}
""",
allowBuildFailure: true
)
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["3️⃣"])
)
XCTAssertEqual(
response,
.locations([
Location(uri: project.fileURI, range: Range(project.positions["1️⃣"])),
Location(uri: project.fileURI, range: Range(project.positions["2️⃣"])),
])
)
}
func testDefinitionOfClassBetweenModulesObjC() async throws {
try SkipUnless.platformIsDarwin("@import in Objective-C is not enabled on non-Darwin")
let project = try await SwiftPMTestProject(
files: [
"LibA/include/LibA.h": """
@interface 1️⃣LibAClass2️⃣
- (void)doSomething;
@end
""",
"LibB/include/dummy.h": "",
"LibB/LibB.m": """
@import LibA;
@interface Test
@end
@implementation Test
- (void)test:(3️⃣LibAClass *)libAClass {
[libAClass doSomething];
}
@end
""",
],
manifest: """
let package = Package(
name: "MyLibrary",
targets: [
.target(name: "LibA"),
.target(name: "LibB", dependencies: ["LibA"]),
]
)
"""
)
let (uri, positions) = try project.openDocument("LibB.m")
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["3️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(locations.count, 1)
let location = try XCTUnwrap(locations.first)
XCTAssertEqual(location, try project.location(from: "1️⃣", to: "2️⃣", in: "LibA.h"))
}
func testDefinitionOfMethodBetweenModulesObjC() async throws {
try SkipUnless.platformIsDarwin("@import in Objective-C is not enabled on non-Darwin")
let project = try await SwiftPMTestProject(
files: [
"LibA/include/LibA.h": """
@interface LibAClass
- (void)1️⃣doSomething2️⃣;
@end
""",
"LibB/include/dummy.h": "",
"LibB/LibB.m": """
@import LibA;
@interface Test
@end
@implementation Test
- (void)test:(LibAClass *)libAClass {
[libAClass 3️⃣doSomething];
}
@end
""",
],
manifest: """
let package = Package(
name: "MyLibrary",
targets: [
.target(name: "LibA"),
.target(name: "LibB", dependencies: ["LibA"]),
]
)
"""
)
let (uri, positions) = try project.openDocument("LibB.m")
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["3️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(locations.count, 1)
let location = try XCTUnwrap(locations.first)
XCTAssertEqual(location, try project.location(from: "1️⃣", to: "2️⃣", in: "LibA.h"))
}
func testDefinitionOfImplicitInitializer() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)
let positions = testClient.openDocument(
"""
class 1️⃣Foo {}
func test() {
2️⃣Foo()
}
""",
uri: uri
)
let response = try await testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(uri), position: positions["2️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(
locations,
[Location(uri: uri, range: Range(positions["1️⃣"]))]
)
}
func testFileDependencyUpdatedWithinSameModule() async throws {
try SkipUnless.longTestsEnabled()
let project = try await SwiftPMTestProject(
files: [
"FileA.swift": "",
"FileB.swift": """
func test() {
1️⃣sayHello()
}
""",
],
enableBackgroundIndexing: true
)
let (bUri, bPositions) = try project.openDocument("FileB.swift")
let beforeChangingFileA = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(bUri), position: bPositions["1️⃣"])
)
XCTAssertNil(beforeChangingFileA)
let updatedAMarkedCode = "func 2️⃣sayHello() {}"
let updatedACode = extractMarkers(updatedAMarkedCode).textWithoutMarkers
let updatedAPositions = DocumentPositions(markedText: updatedAMarkedCode)
let aUri = try project.uri(for: "FileA.swift")
try updatedACode.write(to: try XCTUnwrap(aUri.fileURL), atomically: true, encoding: .utf8)
project.testClient.send(
DidChangeWatchedFilesNotification(changes: [FileEvent(uri: aUri, type: .changed)])
)
// Wait until SourceKit-LSP has handled the `DidChangeWatchedFilesNotification` (which it only does after a delay
// because it debounces these notifications), indicated by it telling us that we should refresh diagnostics.
let diagnosticRefreshRequestReceived = self.expectation(description: "DiagnosticsRefreshRequest received")
project.testClient.handleSingleRequest { (request: DiagnosticsRefreshRequest) in
diagnosticRefreshRequestReceived.fulfill()
return VoidResponse()
}
try await fulfillmentOfOrThrow([diagnosticRefreshRequestReceived])
let afterChangingFileA = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(bUri), position: bPositions["1️⃣"])
)
XCTAssertEqual(
afterChangingFileA,
.locations([Location(uri: aUri, range: Range(updatedAPositions["2️⃣"]))])
)
let afterChange = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(bUri), position: bPositions["1️⃣"])
)
XCTAssertEqual(
afterChange,
.locations([Location(uri: aUri, range: Range(updatedAPositions["2️⃣"]))])
)
}
func testDependentModuleGotBuilt() async throws {
try SkipUnless.longTestsEnabled()
let project = try await SwiftPMTestProject(
files: [
"LibA/LibA.swift": """
public func 1️⃣sayHello() {}
""",
"LibB/LibB.swift": """
import LibA
func test() {
2️⃣sayHello()
}
""",
],
manifest: """
let package = Package(
name: "MyLibrary",
targets: [
.target(name: "LibA"),
.target(name: "LibB", dependencies: ["LibA"]),
]
)
"""
)
let (bUri, bPositions) = try project.openDocument("LibB.swift")
let beforeBuilding = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(bUri), position: bPositions["2️⃣"])
)
XCTAssertNil(beforeBuilding)
try await SwiftPMTestProject.build(at: project.scratchDirectory)
project.testClient.send(
DidChangeWatchedFilesNotification(
changes:
FileManager.default.findFiles(withExtension: "swiftmodule", in: project.scratchDirectory).map {
FileEvent(uri: DocumentURI($0), type: .created)
}
)
)
// Wait until SourceKit-LSP has handled the `DidChangeWatchedFilesNotification` (which it only does after a delay
// because it debounces these notifications), indicated by it telling us that we should refresh diagnostics.
let diagnosticRefreshRequestReceived = self.expectation(description: "DiagnosticsRefreshRequest received")
project.testClient.handleSingleRequest { (request: DiagnosticsRefreshRequest) in
diagnosticRefreshRequestReceived.fulfill()
return VoidResponse()
}
try await fulfillmentOfOrThrow([diagnosticRefreshRequestReceived])
let afterBuilding = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(bUri), position: bPositions["2️⃣"])
)
XCTAssertEqual(
afterBuilding,
.locations([try project.location(from: "1️⃣", to: "1️⃣", in: "LibA.swift")])
)
}
func testIndexBasedDefinitionAfterFileMove() async throws {
let project = try await SwiftPMTestProject(
files: [
"definition.swift": """
class MyClass {
func 1️⃣foo() {}
}
""",
"caller.swift": """
func test(myClass: MyClass) {
myClass.2️⃣foo()
}
""",
],
enableBackgroundIndexing: true
)
let definitionUri = try project.uri(for: "definition.swift")
let (callerUri, callerPositions) = try project.openDocument("caller.swift")
// Validate that we get correct rename results before moving the definition file.
let resultBeforeFileMove = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(callerUri), position: callerPositions["2️⃣"])
)
XCTAssertEqual(
resultBeforeFileMove,
.locations([
Location(uri: definitionUri, range: Range(try project.position(of: "1️⃣", in: "definition.swift")))
])
)
let movedDefinitionUri =
DocumentURI(
definitionUri.fileURL!
.deletingLastPathComponent()
.appendingPathComponent("movedDefinition.swift")
)
try FileManager.default.moveItem(at: XCTUnwrap(definitionUri.fileURL), to: XCTUnwrap(movedDefinitionUri.fileURL))
project.testClient.send(
DidChangeWatchedFilesNotification(changes: [
FileEvent(uri: definitionUri, type: .deleted), FileEvent(uri: movedDefinitionUri, type: .created),
])
)
let resultAfterFileMove = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(callerUri), position: callerPositions["2️⃣"])
)
XCTAssertEqual(
resultAfterFileMove,
.locations([
Location(uri: movedDefinitionUri, range: Range(try project.position(of: "1️⃣", in: "definition.swift")))
])
)
}
func testJumpToDefinitionOnProtocolImplementationJumpsToRequirement() async throws {
let project = try await IndexedSingleSwiftFileTestProject(
"""
protocol TestProtocol {
func 1️⃣doThing()
}
struct TestImpl: TestProtocol {
func 2️⃣do3️⃣Thing() { }
}
"""
)
let definitionFromBaseName = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["2️⃣"])
)
XCTAssertEqual(
definitionFromBaseName,
.locations([Location(uri: project.fileURI, range: Range(project.positions["1️⃣"]))])
)
let definitionFromInsideBaseName = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["3️⃣"])
)
XCTAssertEqual(
definitionFromInsideBaseName,
.locations([Location(uri: project.fileURI, range: Range(project.positions["1️⃣"]))])
)
}
func testJumpToDefinitionOnProtocolImplementationShowsAllFulfilledRequirements() async throws {
let project = try await IndexedSingleSwiftFileTestProject(
"""
protocol TestProtocol {
func 1️⃣doThing()
}
protocol OtherProtocol {
func 2️⃣doThing()
}
struct TestImpl: TestProtocol, OtherProtocol {
func 3️⃣doThing() { }
}
"""
)
let result = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["3️⃣"])
)
XCTAssertEqual(
result,
.locations([
Location(uri: project.fileURI, range: Range(project.positions["1️⃣"])),
Location(uri: project.fileURI, range: Range(project.positions["2️⃣"])),
])
)
}
func testJumpToSatisfiedProtocolRequirementInExtension() async throws {
try await SkipUnless.sourcekitdReportsOverridableFunctionDefinitionsAsDynamic()
let project = try await IndexedSingleSwiftFileTestProject(
"""
protocol TestProtocol {
func 1️⃣doThing()
}
struct TestImpl: TestProtocol {}
extension TestImpl {
func 2️⃣doThing() { }
}
"""
)
let response = try await project.testClient.send(
DefinitionRequest(textDocument: TextDocumentIdentifier(project.fileURI), position: project.positions["1️⃣"])
)
guard case .locations(let locations) = response else {
XCTFail("Expected locations response")
return
}
XCTAssertEqual(locations, [Location(uri: project.fileURI, range: Range(project.positions["2️⃣"]))])
}
}
|