File: AlwaysUseLiteralForEmptyCollectionInit.swift

package info (click to toggle)
swiftlang 6.0.3-2
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 2,519,992 kB
  • sloc: cpp: 9,107,863; ansic: 2,040,022; asm: 1,135,751; python: 296,500; objc: 82,456; f90: 60,502; lisp: 34,951; pascal: 19,946; sh: 18,133; perl: 7,482; ml: 4,937; javascript: 4,117; makefile: 3,840; awk: 3,535; xml: 914; fortran: 619; cs: 573; ruby: 573
file content (209 lines) | stat: -rw-r--r-- 7,275 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//

import Foundation
import SwiftSyntax
import SwiftParser

/// Never use `[<Type>]()` syntax. In call sites that should be replaced with `[]`,
/// for initializations use explicit type combined with empty array literal `let _: [<Type>] = []`
/// Static properties of a type that return that type should not include a reference to their type.
///
/// Lint:  Non-literal empty array initialization will yield a lint error.
/// Format: All invalid use sites would be related with empty literal (with or without explicit type annotation).
@_spi(Rules)
public final class AlwaysUseLiteralForEmptyCollectionInit : SyntaxFormatRule {
  public override class var isOptIn: Bool { return true }

  public override func visit(_ node: PatternBindingSyntax) -> PatternBindingSyntax {
    guard let initializer = node.initializer,
          let type = isRewritable(initializer) else {
      return node
    }

    if let type = type.as(ArrayTypeSyntax.self) {
      return rewrite(node, type: type)
    }

    if let type = type.as(DictionaryTypeSyntax.self) {
      return rewrite(node, type: type)
    }

    return node
  }

  public override func visit(_ param: FunctionParameterSyntax) -> FunctionParameterSyntax {
    guard let initializer = param.defaultValue,
          let type = isRewritable(initializer) else {
      return param
    }

    if let type = type.as(ArrayTypeSyntax.self) {
      return rewrite(param, type: type)
    }

    if let type = type.as(DictionaryTypeSyntax.self) {
      return rewrite(param, type: type)
    }

    return param
  }

  /// Check whether the initializer is `[<Type>]()` and, if so, it could be rewritten to use an empty collection literal.
  /// Return a type of the collection.
  public func isRewritable(_ initializer: InitializerClauseSyntax) -> TypeSyntax? {
    guard let initCall = initializer.value.as(FunctionCallExprSyntax.self),
          initCall.arguments.isEmpty else {
      return nil
    }

    if let arrayLiteral = initCall.calledExpression.as(ArrayExprSyntax.self) {
      return getLiteralType(arrayLiteral)
    }

    if let dictLiteral = initCall.calledExpression.as(DictionaryExprSyntax.self) {
      return getLiteralType(dictLiteral)
    }

    return nil
  }

  private func rewrite(_ node: PatternBindingSyntax,
                       type: ArrayTypeSyntax) -> PatternBindingSyntax {
    var replacement = node

    diagnose(node, type: type)

    if replacement.typeAnnotation == nil {
      // Drop trailing trivia after pattern because ':' has to appear connected to it.
      replacement.pattern = node.pattern.with(\.trailingTrivia, [])
      // Add explicit type annotation: ': [<Type>]`
      replacement.typeAnnotation = .init(type: type.with(\.leadingTrivia, .space)
                                                   .with(\.trailingTrivia, .space))
    }

    let initializer = node.initializer!
    let emptyArrayExpr = ArrayExprSyntax(elements: ArrayElementListSyntax.init([]))

    // Replace initializer call with empty array literal: `[<Type>]()` -> `[]`
    replacement.initializer = initializer.with(\.value, ExprSyntax(emptyArrayExpr))

    return replacement
  }

  private func rewrite(_ node: PatternBindingSyntax,
                       type: DictionaryTypeSyntax) -> PatternBindingSyntax {
    var replacement = node

    diagnose(node, type: type)

    if replacement.typeAnnotation == nil {
      // Drop trailing trivia after pattern because ':' has to appear connected to it.
      replacement.pattern = node.pattern.with(\.trailingTrivia, [])
      // Add explicit type annotation: ': [<Type>]`
      replacement.typeAnnotation = .init(type: type.with(\.leadingTrivia, .space)
                                                   .with(\.trailingTrivia, .space))
    }

    let initializer = node.initializer!
    // Replace initializer call with empty dictionary literal: `[<Type>]()` -> `[]`
    replacement.initializer = initializer.with(\.value, ExprSyntax(getEmptyDictionaryLiteral()))

    return replacement
  }

  private func rewrite(_ param: FunctionParameterSyntax,
                       type: ArrayTypeSyntax) -> FunctionParameterSyntax {
    guard let initializer = param.defaultValue else {
      return param
    }

    emitDiagnostic(replace: "\(initializer.value)", with: "[]", on: initializer.value)
    return param.with(\.defaultValue, initializer.with(\.value, getEmptyArrayLiteral()))
  }

  private func rewrite(_ param: FunctionParameterSyntax,
                       type: DictionaryTypeSyntax) -> FunctionParameterSyntax {
    guard let initializer = param.defaultValue else {
      return param
    }

    emitDiagnostic(replace: "\(initializer.value)", with: "[:]", on: initializer.value)
    return param.with(\.defaultValue, initializer.with(\.value, getEmptyDictionaryLiteral()))
  }

  private func diagnose(_ node: PatternBindingSyntax, type: ArrayTypeSyntax) {
    var withFixIt = "[]"
    if node.typeAnnotation == nil {
      withFixIt = ": \(type) = []"
    }

    let initCall = node.initializer!.value
    emitDiagnostic(replace: "\(initCall)", with: withFixIt, on: initCall)
  }

  private func diagnose(_ node: PatternBindingSyntax, type: DictionaryTypeSyntax) {
    var withFixIt = "[:]"
    if node.typeAnnotation == nil {
      withFixIt = ": \(type) = [:]"
    }

    let initCall = node.initializer!.value
    emitDiagnostic(replace: "\(initCall)", with: withFixIt, on: initCall)
  }

  private func emitDiagnostic(replace: String, with fixIt: String, on: ExprSyntax?) {
    diagnose(.refactorIntoEmptyLiteral(replace: replace, with: fixIt), on: on)
  }

  private func getLiteralType(_ arrayLiteral: ArrayExprSyntax) -> TypeSyntax? {
    guard arrayLiteral.elements.count == 1 else {
      return nil
    }

    var parser = Parser(arrayLiteral.description)
    let elementType = TypeSyntax.parse(from: &parser)

    guard !elementType.hasError, elementType.is(ArrayTypeSyntax.self) else {
      return nil
    }

    return elementType
  }

  private func getLiteralType(_ dictLiteral: DictionaryExprSyntax) -> TypeSyntax? {
    var parser = Parser(dictLiteral.description)
    let elementType = TypeSyntax.parse(from: &parser)

    guard !elementType.hasError, elementType.is(DictionaryTypeSyntax.self) else {
      return nil
    }

    return elementType
  }

  private func getEmptyArrayLiteral() -> ExprSyntax {
    ExprSyntax(ArrayExprSyntax(elements: ArrayElementListSyntax.init([])))
  }

  private func getEmptyDictionaryLiteral() -> ExprSyntax {
    ExprSyntax(DictionaryExprSyntax(content: .colon(.colonToken())))
  }
}

extension Finding.Message {
  fileprivate static func refactorIntoEmptyLiteral(replace: String, with: String)
    -> Finding.Message
  {
    "replace '\(replace)' with '\(with)'"
  }
}