1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572
|
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import SwiftSyntax
/// Imports must be lexicographically ordered and logically grouped at the top of each source file.
/// The order of the import groups is 1) regular imports, 2) declaration imports, and 3) @testable
/// imports. These groups are separated by a single blank line. Blank lines in between the import
/// declarations are removed.
///
/// Lint: If an import appears anywhere other than the beginning of the file it resides in,
/// not lexicographically ordered, or not in the appropriate import group, a lint error is
/// raised.
///
/// Format: Imports will be reordered and grouped at the top of the file.
@_spi(Rules)
public final class OrderedImports: SyntaxFormatRule {
public override func visit(_ node: SourceFileSyntax) -> SourceFileSyntax {
let lines = generateLines(codeBlockItemList: node.statements, context: context)
// Stores the formatted and sorted lines that will be used to reconstruct the list of code block
// items later.
var formattedLines: [Line] = []
var regularImports: [Line] = []
var declImports: [Line] = []
var testableImports: [Line] = []
var codeBlocks: [Line] = []
var fileHeader: [Line] = []
var atStartOfFile = true
var commentBuffer: [Line] = []
func formatAndAppend(linesSection: ArraySlice<Line>) {
codeBlocks.append(contentsOf: commentBuffer)
// Perform linting on the grouping of the imports.
checkGrouping(linesSection)
if let lastLine = fileHeader.last, lastLine.type == .blankLine {
fileHeader.removeLast()
}
regularImports = formatImports(regularImports)
declImports = formatImports(declImports)
testableImports = formatImports(testableImports)
formatCodeblocks(&codeBlocks)
let joined = joinLines(fileHeader, regularImports, declImports, testableImports, codeBlocks)
formattedLines.append(contentsOf: joined)
regularImports = []
declImports = []
testableImports = []
codeBlocks = []
fileHeader = []
commentBuffer = []
}
var lastSliceStartIndex = 0
for (index, line) in lines.enumerated() {
if let syntaxNode = line.syntaxNode,
case .importCodeBlock(_, let sortable) = syntaxNode, !sortable
{
formatAndAppend(linesSection: lines[lastSliceStartIndex..<index])
formattedLines.append(line)
// Insert a blank line after the unsorted import to show that it's a separate "group" from
// the sorted imports.
formattedLines.append(Line())
lastSliceStartIndex = index + 1 // Add 1 to skip the current line.
continue
}
// Capture any leading comments as the file header. It is assumed to be separated from the
// rest of the file by a blank line.
if atStartOfFile {
switch line.type {
case .comment:
commentBuffer.append(line)
continue
case .blankLine:
fileHeader.append(contentsOf: commentBuffer)
fileHeader.append(line)
commentBuffer = []
continue
default:
atStartOfFile = false
}
}
// Separate lines into different categories along with any associated comments.
switch line.type {
case .regularImport:
regularImports.append(contentsOf: commentBuffer)
regularImports.append(line)
commentBuffer = []
case .testableImport:
testableImports.append(contentsOf: commentBuffer)
testableImports.append(line)
commentBuffer = []
case .declImport:
declImports.append(contentsOf: commentBuffer)
declImports.append(line)
commentBuffer = []
case .codeBlock, .blankLine:
codeBlocks.append(contentsOf: commentBuffer)
codeBlocks.append(line)
commentBuffer = []
case .comment:
commentBuffer.append(line)
}
}
if lastSliceStartIndex < lines.endIndex {
formatAndAppend(linesSection: lines[lastSliceStartIndex..<lines.endIndex])
}
var newNode = node
newNode.statements = CodeBlockItemListSyntax(convertToCodeBlockItems(lines: formattedLines))
return newNode
}
/// Raise lint errors if the different import types appear in the wrong order, and if import
/// statements do not appear at the top of the file.
private func checkGrouping<C: Collection>(_ lines: C) where C.Element == Line {
var declGroup = false
var testableGroup = false
var codeGroup = false
for line in lines {
let lineType = line.type
switch lineType {
case .declImport:
declGroup = true
case .testableImport:
testableGroup = true
case .codeBlock:
codeGroup = true
default: ()
}
if codeGroup {
switch lineType {
case .regularImport, .declImport, .testableImport:
diagnose(.placeAtTopOfFile, on: line.firstToken)
default: ()
}
}
if testableGroup {
switch lineType {
case .regularImport, .declImport:
diagnose(
.groupImports(before: lineType, after: LineType.testableImport), on: line.firstToken
)
default: ()
}
}
if declGroup {
switch lineType {
case .regularImport:
diagnose(
.groupImports(before: lineType, after: LineType.declImport), on: line.firstToken
)
default: ()
}
}
}
}
/// Sort the list of import lines lexicographically by the import path name. Any comments above an
/// import lines should be associated with it, and move with the line during sorting. We also emit
/// a linter error if an import line is discovered to be out of order.
private func formatImports(_ imports: [Line]) -> [Line] {
var linesWithLeadingComments: [(import: Line, comments: [Line])] = []
var visitedImports: [String: Int] = [:]
var commentBuffer: [Line] = []
var previousImport: Line? = nil
var diagnosed = false
for line in imports {
switch line.type {
case .regularImport, .declImport, .testableImport:
let fullyQualifiedImport = line.fullyQualifiedImport
// Check for duplicate imports and potentially remove them.
if let previousMatchingImportIndex = visitedImports[fullyQualifiedImport] {
// Even if automatically removing this import is impossible, alert the user that this is a
// duplicate so they can manually fix it.
diagnose(.removeDuplicateImport, on: line.firstToken)
var duplicateLine = linesWithLeadingComments[previousMatchingImportIndex]
// We can combine multiple leading comments, but it's unsafe to combine trailing comments.
// Any extra comments must go on a new line, and would be grouped with the next import.
guard !duplicateLine.import.trailingTrivia.isEmpty && !line.trailingTrivia.isEmpty else {
duplicateLine.comments.append(contentsOf: commentBuffer)
commentBuffer = []
// Keep the Line that has the trailing comment, if there is one.
if !line.trailingTrivia.isEmpty {
duplicateLine.import = line
}
linesWithLeadingComments[previousMatchingImportIndex] = duplicateLine
continue
}
// Otherwise, both lines have trailing trivia so it's not safe to automatically merge
// them. Leave this duplicate import.
}
if let previousImport = previousImport,
line.importName.lexicographicallyPrecedes(previousImport.importName) && !diagnosed
// Only warn to sort imports that shouldn't be removed.
&& visitedImports[fullyQualifiedImport] == nil
{
diagnose(.sortImports, on: line.firstToken)
diagnosed = true // Only emit one of these errors to avoid alert fatigue.
}
// Pack the import line and its associated comments into a tuple.
linesWithLeadingComments.append((line, commentBuffer))
commentBuffer = []
previousImport = line
visitedImports[fullyQualifiedImport] = linesWithLeadingComments.endIndex - 1
case .comment:
commentBuffer.append(line)
default: ()
}
}
linesWithLeadingComments.sort { $0.0.importName.lexicographicallyPrecedes($1.0.importName) }
// Unpack the tuples back into a list of Lines.
var output: [Line] = []
for lineTuple in linesWithLeadingComments {
for comment in lineTuple.1 {
output.append(comment)
}
output.append(lineTuple.0)
}
return output
}
}
/// Remove any leading blank lines from the main code.
fileprivate func formatCodeblocks(_ codeblocks: inout [Line]) {
if let contentIndex = codeblocks.firstIndex(where: { !$0.isBlankLine }) {
codeblocks.removeSubrange(0..<contentIndex)
}
}
/// Join the lists of Line objects into a single list of Lines with a blank line separating them.
fileprivate func joinLines(_ inputLineLists: [Line]...) -> [Line] {
var lineLists = inputLineLists
lineLists.removeAll { $0.isEmpty }
guard lineLists.count > 0 else { return [] }
var output: [Line] = lineLists.first ?? []
for i in 1..<lineLists.count {
let list = lineLists[i]
if list.isEmpty { continue }
output.append(Line())
output += list
}
return output
}
/// This function transforms the statements in a CodeBlockItemListSyntax object into a list of Line
/// objects. Blank lines and standalone comments are represented by their own Line object. Code with
/// a trailing comment are represented together in the same Line.
fileprivate func generateLines(codeBlockItemList: CodeBlockItemListSyntax, context: Context)
-> [Line]
{
var lines: [Line] = []
var currentLine = Line()
func appendNewLine() {
lines.append(currentLine)
currentLine = Line()
}
for block in codeBlockItemList {
for piece in block.leadingTrivia {
switch piece {
// Create new Line objects when we encounter newlines.
case .newlines(let N):
for _ in 0..<N {
appendNewLine()
}
default:
currentLine.leadingTrivia.append(piece) // This will be a standalone comment.
}
}
if block.item.is(ImportDeclSyntax.self) {
// Always create a new `Line` for each import statement, so they can be reordered.
if currentLine.syntaxNode != nil {
appendNewLine()
}
let sortable = context.shouldFormat(OrderedImports.self, node: Syntax(block))
var blockWithoutTrailingTrivia = block
blockWithoutTrailingTrivia.trailingTrivia = []
currentLine.syntaxNode = .importCodeBlock(blockWithoutTrailingTrivia, sortable: sortable)
} else {
if let syntaxNode = currentLine.syntaxNode {
// Multiple code blocks can be merged, as long as there isn't an import statement.
switch syntaxNode {
case .importCodeBlock:
appendNewLine()
currentLine.syntaxNode = .nonImportCodeBlocks([block])
case .nonImportCodeBlocks(let existingCodeBlocks):
currentLine.syntaxNode = .nonImportCodeBlocks(existingCodeBlocks + [block])
}
} else {
currentLine.syntaxNode = .nonImportCodeBlocks([block])
}
}
for piece in block.trailingTrivia {
currentLine.trailingTrivia.append(piece) // This will be a trailing line comment.
}
}
lines.append(currentLine)
return lines
}
/// This function transforms a list of Line objects into a list of CodeBlockItemSyntax objects,
/// replacing the trivia appropriately to ensure comments appear in the right location.
fileprivate func convertToCodeBlockItems(lines: [Line]) -> [CodeBlockItemSyntax] {
var output: [CodeBlockItemSyntax] = []
var pendingLeadingTrivia: [TriviaPiece] = []
for line in lines {
pendingLeadingTrivia += line.leadingTrivia
func append(codeBlockItem: CodeBlockItemSyntax) {
var codeBlockItem = codeBlockItem
codeBlockItem.leadingTrivia = Trivia(pieces: pendingLeadingTrivia)
codeBlockItem.trailingTrivia = Trivia(pieces: line.trailingTrivia)
output.append(codeBlockItem)
pendingLeadingTrivia = []
}
if let syntaxNode = line.syntaxNode {
switch syntaxNode {
case .importCodeBlock(let codeBlock, _):
append(codeBlockItem: codeBlock)
case .nonImportCodeBlocks(let codeBlocks):
codeBlocks.forEach(append(codeBlockItem:))
}
}
// Merge multiple newlines together into a single trivia piece by updating its count.
if let lastPiece = pendingLeadingTrivia.last, case .newlines(let count) = lastPiece {
pendingLeadingTrivia[pendingLeadingTrivia.endIndex - 1] = .newlines(count + 1)
} else {
pendingLeadingTrivia.append(.newlines(1))
}
}
return output
}
public enum LineType: CustomStringConvertible {
case regularImport
case declImport
case testableImport
case codeBlock
case comment
case blankLine
public var description: String {
switch self {
case .regularImport:
return "regular"
case .declImport:
return "declaration"
case .testableImport:
return "testable"
case .codeBlock:
return "code"
case .comment:
return "comment"
case .blankLine:
return "blank line"
}
}
}
/// A Line more or less represents a literal printed line in a source file. A line can be a
/// comment, code, code with a trailing comment, or a blank line. For import statements, a Line will
/// represent a single printed line. Other types of code (e.g. structs and classes) will span
/// multiple literal lines, but can still be represented by a single Line object. This is desireable
/// since we aren't interested in rearranging those types of structures in this rule.
fileprivate class Line {
/// Storage for the different types of AST nodes that can be held by a `Line`.
enum SyntaxNode {
/// A collection of code block items that aren't imports. These types of code blocks aren't
/// reordered and there may be multiple per printed line.
case nonImportCodeBlocks([CodeBlockItemSyntax])
/// A single code block item whose content must be an import decl.
case importCodeBlock(CodeBlockItemSyntax, sortable: Bool)
}
/// Stores line comments. `syntaxNode` need not be defined, since a comment can exist by itself on
/// a line.
var leadingTrivia: [TriviaPiece] = []
/// Stores trailing line comments that follow normal code. `syntaxNode` should be defined.
var trailingTrivia: [TriviaPiece] = []
/// Stores one or more CodeBlockItemSyntax objects from the AST.
var syntaxNode: SyntaxNode?
/// A Line object can represent a blank line if all of its fields are empty.
var isBlankLine: Bool {
return leadingTrivia.isEmpty && trailingTrivia.isEmpty && syntaxNode == nil
}
var type: LineType {
if let syntaxNode = syntaxNode {
switch syntaxNode {
case .nonImportCodeBlocks:
return .codeBlock
case .importCodeBlock(let importCodeBlock, _):
guard let importDecl = importCodeBlock.item.as(ImportDeclSyntax.self) else {
// Invalid `importCodeBlock` - fallback to treating it as a generic code block.
return .codeBlock
}
return importType(of: importDecl)
}
}
if leadingTrivia.contains(where: {
switch $0 {
case .lineComment, .blockComment, .docLineComment, .docBlockComment:
return true
default:
return false
}
}) {
return .comment
}
// There may be some whitespace in the leading trivia, but consider the line to be blank.
return .blankLine
}
/// Returns a fully qualified description of this line's import if it's an import statement,
/// including any attributes, modifiers, the import kind, and the import path. When this line
/// isn't an import statement, returns an empty string.
var fullyQualifiedImport: String {
guard let syntaxNode = syntaxNode, case .importCodeBlock(let importCodeBlock, _) = syntaxNode,
let importDecl = importCodeBlock.item.as(ImportDeclSyntax.self)
else {
return ""
}
// Using the description is a reliable way to include all content from the import, but
// description includes all leading and trailing trivia. It would be unusual to have any
// non-whitespace trivia on the components of the import. Trim off the leading trivia, where
// comments could be, and trim whitespace that might be after the import.
var declForDescription = importDecl
declForDescription.leadingTrivia = []
return declForDescription.description.trimmingCharacters(in: .whitespacesAndNewlines)
}
/// Returns the path that is imported by this line's import statement if it's an import statement.
/// When this line isn't an import statement, returns an empty string.
var importName: String {
guard let syntaxNode = syntaxNode, case .importCodeBlock(let importCodeBlock, _) = syntaxNode,
let importDecl = importCodeBlock.item.as(ImportDeclSyntax.self)
else {
return ""
}
return importDecl.path.description.trimmingCharacters(in: .whitespacesAndNewlines)
}
/// Returns the first `TokenSyntax` in the code block(s) from this Line, or nil when this Line
/// doesn't represent any code blocks (e.g. a comment or blank line).
var firstToken: TokenSyntax? {
guard let syntaxNode = syntaxNode else { return nil }
switch syntaxNode {
case .importCodeBlock(let codeBlock, _):
return codeBlock.firstToken(viewMode: .sourceAccurate)
case .nonImportCodeBlocks(let codeBlocks):
return codeBlocks.first?.firstToken(viewMode: .sourceAccurate)
}
}
/// Returns a `LineType` the represents the type of import from the given import decl.
private func importType(of importDecl: ImportDeclSyntax) -> LineType {
if let attr = importDecl.attributes.firstToken(viewMode: .sourceAccurate),
attr.tokenKind == .atSign,
attr.nextToken(viewMode: .sourceAccurate)?.text == "testable"
{
return .testableImport
}
if importDecl.importKindSpecifier != nil {
return .declImport
}
return .regularImport
}
}
extension Line: CustomDebugStringConvertible {
var debugDescription: String {
var description = ""
if !leadingTrivia.isEmpty {
var newlinesCount = 0
for piece in leadingTrivia {
switch piece {
case .newlines(let count):
newlinesCount += count
default:
if newlinesCount > 0 {
description += "\(newlinesCount) newlines "
newlinesCount = 0
}
description += "\(piece) "
}
}
if newlinesCount > 0 {
description += "\(newlinesCount) newlines "
}
}
if let syntaxNode = syntaxNode {
switch syntaxNode {
case .nonImportCodeBlocks(let codeBlocks):
description += "\(codeBlocks.count) code blocks "
case .importCodeBlock(_, let sortable):
description += "\(sortable ? "sorted" : "unsorted") import \(importName) "
}
}
if !trailingTrivia.isEmpty {
// Trailing trivia should just be comments, so just print each piece.
for piece in trailingTrivia {
description += "\(piece) "
}
}
return description.trimmingCharacters(in: .whitespaces)
}
}
extension Finding.Message {
fileprivate static let placeAtTopOfFile: Finding.Message = "place imports at the top of the file"
fileprivate static func groupImports(before: LineType, after: LineType) -> Finding.Message {
"place \(before) imports before \(after) imports"
}
fileprivate static let removeDuplicateImport: Finding.Message = "remove this duplicate import"
fileprivate static let sortImports: Finding.Message = "sort import statements lexicographically"
}
|