1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835
|
import _SwiftFormatTestSupport
final class CommentTests: PrettyPrintTestCase {
func testDocumentationComments() {
let input =
"""
/// This is a documentation comment
///
/// - Parameters:
/// - param1: Param1 comment
/// - param2: Param2 comment
/// - Returns: The output
func myfun(param1: Int, param2: Double) -> String {
let out = "123"
return out
}
/// A brief doc comment
func myfun() {
let a = 123
let b = "456"
}
public class MyClass {
/// Doc comment
var myVariable: Int
/// Method doc comment
///
/// - Parameters:
/// - param1: Param1 comment
/// - param2: Param2 comment
/// - Returns: The output
func myFun(param1: Int, param2: Int) -> String {
let a = 123
let b = "456"
return b
}
}
"""
let expected =
"""
/// This is a documentation comment
///
/// - Parameters:
/// - param1: Param1 comment
/// - param2: Param2 comment
/// - Returns: The output
func myfun(param1: Int, param2: Double) -> String {
let out = "123"
return out
}
/// A brief doc comment
func myfun() {
let a = 123
let b = "456"
}
public class MyClass {
/// Doc comment
var myVariable: Int
/// Method doc comment
///
/// - Parameters:
/// - param1: Param1 comment
/// - param2: Param2 comment
/// - Returns: The output
func myFun(param1: Int, param2: Int) -> String {
let a = 123
let b = "456"
return b
}
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 55)
}
func testLineComments() {
let input =
"""
// Line Comment0
// Line Comment1
// Line Comment2
let a = 123
let b = "456" // End of line comment
let c = "More content"
// Comment 3
// Comment 4
let reallyLongVariableName = 123 // This comment should not wrap
// and should not combine with this comment
func MyFun() {
// just a comment
}
func MyFun() {
// Comment 1
// Comment 2
let a = 123
let b = 456 // Comment 3
}
func MyFun() {
let c = 789 // Comment 4
// Comment 5
}
let a = myfun(123 // Cmt 7
)
let a = myfun(var1: 123 // Cmt 7
)
guard condition else { return // Cmt 6
}
switch myvar {
case .one, .two, // three
.four:
dostuff()
default: ()
}
let a = 123 + // comment
b + c
let d = 123
// Trailing Comment
"""
let expected =
"""
// Line Comment0
// Line Comment1
// Line Comment2
let a = 123
let b = "456" // End of line comment
let c = "More content"
// Comment 3
// Comment 4
let reallyLongVariableName = 123 // This comment should not wrap
// and should not combine with this comment
func MyFun() {
// just a comment
}
func MyFun() {
// Comment 1
// Comment 2
let a = 123
let b = 456 // Comment 3
}
func MyFun() {
let c = 789 // Comment 4
// Comment 5
}
let a = myfun(
123 // Cmt 7
)
let a = myfun(
var1: 123 // Cmt 7
)
guard condition else {
return // Cmt 6
}
switch myvar {
case .one, .two, // three
.four:
dostuff()
default: ()
}
let a =
123 // comment
+ b + c
let d = 123
// Trailing Comment
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 45)
}
func testContainerLineComments() {
let input =
"""
// Array comment
let a = [456, // small comment
789]
// Dictionary comment
let b = ["abc": 456, // small comment
"def": 789]
// Trailing comment
let c = [123, 456 // small comment
]
// Multiline comment
let d = [123,
// comment line 1
// comment line 2
456
]
/* Array comment */
let a = [456, /* small comment */
789]
/* Dictionary comment */
let b = ["abc": 456, /* small comment */
"def": 789]
"""
let expected =
"""
// Array comment
let a = [
456, // small comment
789,
]
// Dictionary comment
let b = [
"abc": 456, // small comment
"def": 789,
]
// Trailing comment
let c = [
123, 456, // small comment
]
// Multiline comment
let d = [
123,
// comment line 1
// comment line 2
456,
]
/* Array comment */
let a = [
456, /* small comment */
789,
]
/* Dictionary comment */
let b = [
"abc": 456, /* small comment */
"def": 789,
]
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 80)
}
func testDocumentationBlockComments() {
let input =
"""
/** This is a documentation comment
*
* - Parameters:
* - param1: Param1 comment
* - param2: Param2 comment
* - Returns: The output
**/
func myfun(param1: Int, param2: Double) -> String {
let out = "123"
return out
}
/** A brief doc comment **/
func myfun() {
let a = 123
let b = "456"
}
public class MyClass {
/** Doc comment **/
var myVariable: Int
/** Method doc comment
*
* - Parameters:
* - param1: Param1 comment
* - param2: Param2 comment
* - Returns: The output
**/
func myFun(param1: Int, param2: Int) -> String {
let a = 123
let b = "456"
return b
}
}
"""
let expected =
"""
/** This is a documentation comment
*
* - Parameters:
* - param1: Param1 comment
* - param2: Param2 comment
* - Returns: The output
**/
func myfun(param1: Int, param2: Double) -> String {
let out = "123"
return out
}
/** A brief doc comment **/
func myfun() {
let a = 123
let b = "456"
}
public class MyClass {
/** Doc comment **/
var myVariable: Int
/** Method doc comment
*
* - Parameters:
* - param1: Param1 comment
* - param2: Param2 comment
* - Returns: The output
**/
func myFun(param1: Int, param2: Int) -> String {
let a = 123
let b = "456"
return b
}
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 55)
}
func testBlockComments() {
let input =
"""
/* Line Comment1 */
/* Line Comment2 */
let a = 123
let b = "456" /* End of line comment */
let c = "More content"
/* Comment 3
Comment 4 */
let reallyLongVariableName = 123 /* This comment should wrap */
let a = myfun(123 /* Cmt 5 */
)
let a = myfun(var1: 123 /* Cmt 5 */
)
guard condition else { return /* Cmt 6 */
}
let d = 123
/* Trailing Comment */
"""
let expected =
"""
/* Line Comment1 */
/* Line Comment2 */
let a = 123
let b = "456" /* End of line comment */
let c = "More content"
/* Comment 3
Comment 4 */
let reallyLongVariableName =
123 /* This comment should wrap */
let a = myfun(
123 /* Cmt 5 */
)
let a = myfun(
var1: 123 /* Cmt 5 */
)
guard condition else {
return /* Cmt 6 */
}
let d = 123
/* Trailing Comment */
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 45)
}
func testDoesNotInsertExtraNewlinesAfterTrailingComments() {
let input =
"""
struct Foo {
var foo: Int // foo
var bar: Int // bar
}
enum Foo {
case foo
case bar // bar
case baz // baz
case quux
}
"""
let expected =
"""
struct Foo {
var foo: Int // foo
var bar: Int // bar
}
enum Foo {
case foo
case bar // bar
case baz // baz
case quux
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testCommentOnContinuationLine() {
let input =
"""
func foo() {
return true
// comment
&& false
}
func foo() {
return
// comment
false
}
struct Foo {
typealias Bar =
// comment
SomeOtherType
}
"""
assertPrettyPrintEqual(input: input, expected: input + "\n", linelength: 60)
}
func testLineCommentAtEndOfMemberDeclList() {
let input =
"""
enum Foo {
case bar
// This should be indented the same as the previous line
}
"""
let expected =
"""
enum Foo {
case bar
// This should be indented the same as the previous line
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testCommentsAroundIfElseStatements() {
let input =
"""
if foo {
}// Comment about else-if
else // comment about else
if bar {
}
// another comment
else
{
}
"""
let expected =
"""
if foo {
} // Comment about else-if
else // comment about else
if bar {
}
// another comment
else {
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testCommentsMoveAroundOperators() {
let input =
"""
let x = a + // comment about b
b
let x = // comment about RHS
a + b + c
x = a + b +
// comment about c
c
x = a + /* block */
// line 2
b
x = a + // comment 1
// comment 2
b
"""
let expected =
"""
let x =
a // comment about b
+ b
let x = // comment about RHS
a + b + c
x =
a + b
// comment about c
+ c
x =
a
// line 2
+ /* block */ b
x =
a // comment 1
// comment 2
+ b
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testCommentsAllowedInParenthesizedExpressions() {
// There is no group applied outside of single element tuples that don't contain sequence
// expressions, hence the examples with a tuple wrapping `foo()` and a tuple wrapping a
// multiline string don't break before the left paren.
let input =
#"""
let x = (// call foo
foo())
x = (// do some addition
x + y)
x = (
// localize this string?
// second line of comment
// third line of comment
"""
This is a multiline string inside of a multiline
string!
""")
"""#
let expected =
#"""
let x = ( // call foo
foo())
x =
( // do some addition
x + y)
x = (
// localize this string?
// second line of comment
// third line of comment
"""
This is a multiline string inside of a multiline
string!
""")
"""#
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testOperatorOnNewLineWithTrailingLineComment() {
let input =
"""
if next
&& // final is important
// second line about final
final
{
}
"""
let expected =
"""
if next
// final is important
// second line about final
&& final
{
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testOperatorOnSameLineWithTrailingLineComment() {
let input =
"""
if next && // final is important
// second line about final
final
{
}
"""
let expected =
"""
if next // final is important
// second line about final
&& final
{
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testCommentsInIfStatements() {
let input =
"""
if foo.bar && false && // comment about foo.bar
baz && // comment about baz
// comment about next
next
&& // other is important
// second line about other
other &&
// comment about final on a new line
final
{
}
if foo.bar && foo.baz
&& // comment about the next line
// another comment line
next.line
{
}
"""
let expected =
"""
if foo.bar && false // comment about foo.bar
&& baz // comment about baz
// comment about next
&& next
// other is important
// second line about other
&& other
// comment about final on a new line
&& final
{
}
if foo.bar && foo.baz
// comment about the next line
// another comment line
&& next.line
{
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 100)
}
func testTrailingSpacesInComments() {
// Xcode has a commonly enabled setting to delete trailing spaces, which also applies to
// multi-line strings. The trailing spaces are intentionally written using a unicode escape
// sequence to ensure they aren't deleted.
let input = """
/// This is a trailing space documentation comment.\u{0020}\u{0020}\u{0020}\u{0020}\u{0020}
/// This is a leading space documentation comment.
func foo() {
// leading spaces are fine
// trailing spaces should go\u{0020}\u{0020}\u{0020}\u{0020}\u{0020}
let out = "123"
}
/**
* This is a leading space doc block comment
* This is a trailing space doc block comment\u{0020}\u{0020}\u{0020}\u{0020}\u{0020}
*/
func foo() {
/* block comment */ let out = "123"
}
"""
let expected = """
/// This is a trailing space documentation comment.
/// This is a leading space documentation comment.
func foo() {
// leading spaces are fine
// trailing spaces should go
let out = "123"
}
/**
* This is a leading space doc block comment
* This is a trailing space doc block comment
*/
func foo() {
/* block comment */ let out = "123"
}
"""
assertPrettyPrintEqual(input: input, expected: expected, linelength: 60)
}
func testDiagnoseMoveEndOfLineComment() {
assertPrettyPrintEqual(
input: """
import veryveryverylongmodulenameherebecauseitistypical // special sentinel comment
func fooBarBazRunningOutOfIdeas() { 1️⃣// comment that needs to move
if foo { // comment is fine
}
}
""",
expected: """
import veryveryverylongmodulenameherebecauseitistypical // special sentinel comment
func fooBarBazRunningOutOfIdeas() { // comment that needs to move
if foo { // comment is fine
}
}
""",
linelength: 45,
whitespaceOnly: true,
findings: [
FindingSpec("1️⃣", message: "move end-of-line comment that exceeds the line length"),
]
)
}
func testLineWithDocLineComment() {
// none of these should be merged if/when there is comment formatting
let input =
"""
/// Doc line comment
// Line comment
/// Doc line comment
// Line comment
// Another line comment
"""
assertPrettyPrintEqual(input: input, expected: input, linelength: 80)
}
func testNonmergeableComments() {
// none of these should be merged if/when there is comment formatting
let input =
"""
let x = 1 // end of line comment
//
let y = // eol comment
1 // another
+ 2 // and another
"""
assertPrettyPrintEqual(input: input, expected: input, linelength: 80)
}
func testMergeableComments() {
// these examples should be merged and formatted if/when there is comment formatting
let input =
"""
let z =
// one comment
// and another comment
1 + 2
let w = [1, 2, 3]
.foo()
// this comment
// could be merged with this one
.bar()
"""
assertPrettyPrintEqual(input: input, expected: input, linelength: 80)
}
}
|