1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
|
import _SwiftFormatTestSupport
@_spi(Rules) import SwiftFormat
final class NoCasesWithOnlyFallthroughTests: LintOrFormatRuleTestCase {
func testFallthroughCases() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch numbers {
case 1: print("one")
1️⃣case 2: fallthrough
2️⃣case 3: fallthrough
case 4: print("two to four")
3️⃣case 5: fallthrough
case 7: print("five or seven")
default: break
}
switch letters {
4️⃣case "a": fallthrough
5️⃣case "b", "c": fallthrough
case "d": print("abcd")
case "e": print("e")
6️⃣case "f": fallthrough
case "z": print("fz")
default: break
}
switch tokens {
case .comma: print(",")
7️⃣case .rightBrace: fallthrough
8️⃣case .leftBrace: fallthrough
case .braces: print("{}")
case .period: print(".")
case .empty: fallthrough
default: break
}
""",
expected: """
switch numbers {
case 1: print("one")
case 2, 3, 4: print("two to four")
case 5, 7: print("five or seven")
default: break
}
switch letters {
case "a", "b", "c", "d": print("abcd")
case "e": print("e")
case "f", "z": print("fz")
default: break
}
switch tokens {
case .comma: print(",")
case .rightBrace, .leftBrace, .braces: print("{}")
case .period: print(".")
case .empty: fallthrough
default: break
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("3️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("4️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("5️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("6️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("7️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("8️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testFallthroughCasesWithCommentsAreNotCombined() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch numbers {
case 1:
return 0 // This return has an inline comment.
1️⃣case 2: fallthrough
// This case is commented so it should stay.
case 3:
fallthrough
case 4:
// This fallthrough is commented so it should stay.
fallthrough
case 5: fallthrough // This fallthrough is relevant.
2️⃣case 6:
fallthrough
// This case has a descriptive comment.
case 7: print("got here")
}
""",
expected: """
switch numbers {
case 1:
return 0 // This return has an inline comment.
// This case is commented so it should stay.
case 2, 3:
fallthrough
case 4:
// This fallthrough is commented so it should stay.
fallthrough
case 5: fallthrough // This fallthrough is relevant.
// This case has a descriptive comment.
case 6, 7: print("got here")
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testCommentsAroundCombinedCasesStayInPlace() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch numbers {
case 5:
return 42 // This return is important.
1️⃣case 6: fallthrough
// This case has an important comment.
case 7: print("6 to 7")
2️⃣case 8: fallthrough
// This case has an extra leading newline for emphasis.
case 9: print("8 to 9")
}
""",
expected: """
switch numbers {
case 5:
return 42 // This return is important.
// This case has an important comment.
case 6, 7: print("6 to 7")
// This case has an extra leading newline for emphasis.
case 8, 9: print("8 to 9")
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testNestedSwitches() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch x {
1️⃣case 1: fallthrough
2️⃣case 2: fallthrough
case 3:
switch y {
3️⃣case 1: fallthrough
case 2: print(2)
}
case 4:
switch y {
4️⃣case 1: fallthrough
case 2: print(2)
}
}
""",
expected: """
switch x {
case 1, 2, 3:
switch y {
case 1, 2: print(2)
}
case 4:
switch y {
case 1, 2: print(2)
}
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("3️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("4️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testCasesInsideConditionalCompilationBlock() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch x {
case 1: fallthrough
#if FOO
1️⃣case 2: fallthrough
case 3: print(3)
case 4: print(4)
#endif
2️⃣case 5: fallthrough
case 6: print(6)
#if BAR
#if BAZ
case 7: print(7)
case 8: fallthrough
#endif
case 9: fallthrough
#endif
case 10: print(10)
}
""",
expected: """
switch x {
case 1: fallthrough
#if FOO
case 2, 3: print(3)
case 4: print(4)
#endif
case 5, 6: print(6)
#if BAR
#if BAZ
case 7: print(7)
case 8: fallthrough
#endif
case 9: fallthrough
#endif
case 10: print(10)
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testCasesWithWhereClauses() {
// As noted in the rule implementation, the formatted result should include a newline before any
// case items that have `where` clauses if they follow any case items that do not, to avoid
// compiler warnings. This is handled by the pretty printer, not this rule.
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch x {
1️⃣case 1 where y < 0: fallthrough
2️⃣case 2 where y == 0: fallthrough
3️⃣case 3 where y < 0: fallthrough
case 4 where y != 0: print(4)
4️⃣case 5: fallthrough
5️⃣case 6: fallthrough
6️⃣case 7: fallthrough
7️⃣case 8: fallthrough
8️⃣case 9: fallthrough
case 10 where y == 0: print(10)
default: print("?")
}
""",
expected: """
switch x {
case 1 where y < 0, 2 where y == 0, 3 where y < 0, 4 where y != 0: print(4)
case 5, 6, 7, 8, 9, 10 where y == 0: print(10)
default: print("?")
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("3️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("4️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("5️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("6️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("7️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("8️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testCasesWithValueBindingsAreNotMerged() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch x {
1️⃣case .a: fallthrough
case .b: fallthrough
case .c(let x): fallthrough
case .d(let y): fallthrough
2️⃣case .e: fallthrough
case .f: fallthrough
case (let g, let h): fallthrough
3️⃣case .i: fallthrough
case .j?: fallthrough
case let k as K: fallthrough
case .l: break
}
""",
expected: """
switch x {
case .a, .b: fallthrough
case .c(let x): fallthrough
case .d(let y): fallthrough
case .e, .f: fallthrough
case (let g, let h): fallthrough
case .i, .j?: fallthrough
case let k as K: fallthrough
case .l: break
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("2️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
FindingSpec("3️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testFallthroughOnlyCasesAreNotMergedWithDefault() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch x {
1️⃣case .a: fallthrough
case .b: fallthrough
default: print("got here")
}
""",
expected: """
switch x {
case .a, .b: fallthrough
default: print("got here")
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
func testFallthroughOnlyCasesAreNotMergedWithUnknownDefault() {
assertFormatting(
NoCasesWithOnlyFallthrough.self,
input: """
switch x {
1️⃣case .a: fallthrough
case .b: fallthrough
@unknown default: print("got here")
}
""",
expected: """
switch x {
case .a, .b: fallthrough
@unknown default: print("got here")
}
""",
findings: [
FindingSpec("1️⃣", message: "combine this fallthrough-only 'case' and the following 'case' into a single 'case'"),
]
)
}
}
|
