1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655
|
import _SwiftFormatTestSupport
@_spi(Rules) import SwiftFormat
final class OrderedImportsTests: LintOrFormatRuleTestCase {
func testInvalidImportsOrder() {
assertFormatting(
OrderedImports.self,
input: """
import Foundation
// Starts Imports
1️⃣import Core
// Comment with new lines
import UIKit
@testable import SwiftFormat
8️⃣import enum Darwin.D.isatty
// Starts Test
3️⃣@testable import MyModuleUnderTest
// Starts Ind
2️⃣7️⃣import func Darwin.C.isatty
let a = 3
4️⃣5️⃣6️⃣import SwiftSyntax
""",
expected: """
// Starts Imports
import Core
import Foundation
import SwiftSyntax
// Comment with new lines
import UIKit
// Starts Ind
import func Darwin.C.isatty
import enum Darwin.D.isatty
// Starts Test
@testable import MyModuleUnderTest
@testable import SwiftFormat
let a = 3
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
FindingSpec("2️⃣", message: "place declaration imports before testable imports"),
FindingSpec("3️⃣", message: "sort import statements lexicographically"),
FindingSpec("4️⃣", message: "place imports at the top of the file"),
FindingSpec("5️⃣", message: "place regular imports before testable imports"),
FindingSpec("6️⃣", message: "place regular imports before declaration imports"),
FindingSpec("7️⃣", message: "sort import statements lexicographically"),
FindingSpec("8️⃣", message: "place declaration imports before testable imports"),
]
)
}
func testImportsOrderWithoutModuleType() {
assertFormatting(
OrderedImports.self,
input: """
@testable import SwiftFormat
1️⃣import func Darwin.D.isatty
4️⃣@testable import MyModuleUnderTest
2️⃣3️⃣import func Darwin.C.isatty
let a = 3
""",
expected: """
import func Darwin.C.isatty
import func Darwin.D.isatty
@testable import MyModuleUnderTest
@testable import SwiftFormat
let a = 3
""",
findings: [
FindingSpec("1️⃣", message: "place declaration imports before testable imports"),
FindingSpec("2️⃣", message: "place declaration imports before testable imports"),
FindingSpec("3️⃣", message: "sort import statements lexicographically"),
FindingSpec("4️⃣", message: "sort import statements lexicographically"),
]
)
}
func testImportsOrderWithDocComment() {
assertFormatting(
OrderedImports.self,
input: """
/// Test imports with comments.
///
/// Comments at the top of the file
/// should be preserved.
// Line comment for import
// Foundation.
import Foundation
// Line comment for Core
1️⃣import Core
import UIKit
let a = 3
""",
expected: """
/// Test imports with comments.
///
/// Comments at the top of the file
/// should be preserved.
// Line comment for Core
import Core
// Line comment for import
// Foundation.
import Foundation
import UIKit
let a = 3
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
func testValidOrderedImport() {
assertFormatting(
OrderedImports.self,
input: """
import CoreLocation
import MyThirdPartyModule
import SpriteKit
import UIKit
import func Darwin.C.isatty
@testable import MyModuleUnderTest
""",
expected: """
import CoreLocation
import MyThirdPartyModule
import SpriteKit
import UIKit
import func Darwin.C.isatty
@testable import MyModuleUnderTest
""",
findings: []
)
}
func testSeparatedFileHeader() {
assertFormatting(
OrderedImports.self,
input: """
// This is part of the file header.
// So is this.
// Top comment
import Bimport
1️⃣import Aimport
struct MyStruct {
// do stuff
}
2️⃣import HoistMe
""",
expected: """
// This is part of the file header.
// So is this.
import Aimport
// Top comment
import Bimport
import HoistMe
struct MyStruct {
// do stuff
}
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
FindingSpec("2️⃣", message: "place imports at the top of the file"),
]
)
}
func testNonHeaderComment() {
let input =
"""
// Top comment
import Bimport
1️⃣import Aimport
let A = 123
"""
let expected =
"""
import Aimport
// Top comment
import Bimport
let A = 123
"""
assertFormatting(
OrderedImports.self,
input: input,
expected: expected,
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
func testMultipleCodeBlocksPerLine() {
assertFormatting(
OrderedImports.self,
input: """
import A;import Z;1️⃣import D;import C;
foo();bar();baz();quxxe();
""",
expected: """
import A;
import C;
import D;
import Z;
foo();bar();baz();quxxe();
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
func testMultipleCodeBlocksWithImportsPerLine() {
assertFormatting(
OrderedImports.self,
input: """
import A;import Z;1️⃣import D;import C;foo();bar();baz();quxxe();
""",
expected: """
import A;
import C;
import D;
import Z;
foo();bar();baz();quxxe();
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
func testDisableOrderedImports() {
assertFormatting(
OrderedImports.self,
input: """
import C
1️⃣import B
// swift-format-ignore: OrderedImports
import A
let a = 123
2️⃣import func Darwin.C.isatty
// swift-format-ignore
import a
""",
expected: """
import B
import C
// swift-format-ignore: OrderedImports
import A
import func Darwin.C.isatty
let a = 123
// swift-format-ignore
import a
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
FindingSpec("2️⃣", message: "place imports at the top of the file"),
]
)
}
func testDisableOrderedImportsMovingComments() {
assertFormatting(
OrderedImports.self,
input: """
import C // Trailing comment about C
1️⃣import B
// Comment about ignored A
// swift-format-ignore: OrderedImports
import A // trailing comment about ignored A
// Comment about Z
import Z
2️⃣import D
// swift-format-ignore
// Comment about testable testA
@testable import testA
@testable import testZ // trailing comment about testZ
3️⃣@testable import testC
// swift-format-ignore
@testable import testB
// Comment about Bar
import enum Bar
let a = 2
""",
expected: """
import B
import C // Trailing comment about C
// Comment about ignored A
// swift-format-ignore: OrderedImports
import A // trailing comment about ignored A
import D
// Comment about Z
import Z
// swift-format-ignore
// Comment about testable testA
@testable import testA
@testable import testC
@testable import testZ // trailing comment about testZ
// swift-format-ignore
@testable import testB
// Comment about Bar
import enum Bar
let a = 2
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
FindingSpec("2️⃣", message: "sort import statements lexicographically"),
FindingSpec("3️⃣", message: "sort import statements lexicographically"),
]
)
}
func testEmptyFile() {
assertFormatting(
OrderedImports.self,
input: "",
expected: "",
findings: []
)
assertFormatting(
OrderedImports.self,
input: "// test",
expected: "// test",
findings: []
)
}
func testImportsContainingNewlines() {
assertFormatting(
OrderedImports.self,
input: """
import
zeta
1️⃣import Zeta
import
Alpha
import Beta
""",
expected: """
import
Alpha
import Beta
import Zeta
import
zeta
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
func testRemovesDuplicateImports() {
assertFormatting(
OrderedImports.self,
input: """
import CoreLocation
import UIKit
1️⃣import CoreLocation
import ZeeFramework
bar()
""",
expected: """
import CoreLocation
import UIKit
import ZeeFramework
bar()
""",
findings: [
FindingSpec("1️⃣", message: "remove this duplicate import"),
]
)
}
func testDuplicateCommentedImports() {
// Verify that we diagnose redundant imports if they have comments, but don't remove them.
assertFormatting(
OrderedImports.self,
input: """
import AppKit
// CoreLocation is necessary to get location stuff.
import CoreLocation // This import must stay.
// UIKit does UI Stuff?
import UIKit
// This is the second CoreLocation import.
1️⃣import CoreLocation // The 2nd CL import has a comment here too.
// Comment about ZeeFramework.
import ZeeFramework
import foo
// Second comment about ZeeFramework.
2️⃣import ZeeFramework // This one has a trailing comment too.
foo()
""",
expected: """
import AppKit
// CoreLocation is necessary to get location stuff.
import CoreLocation // This import must stay.
// This is the second CoreLocation import.
import CoreLocation // The 2nd CL import has a comment here too.
// UIKit does UI Stuff?
import UIKit
// Comment about ZeeFramework.
// Second comment about ZeeFramework.
import ZeeFramework // This one has a trailing comment too.
import foo
foo()
""",
findings: [
// Even though this import is technically also not sorted, that won't matter if the import
// is removed so there should only be a warning to remove it.
FindingSpec("1️⃣", message: "remove this duplicate import"),
FindingSpec("2️⃣", message: "remove this duplicate import"),
]
)
}
func testDuplicateIgnoredImports() {
assertFormatting(
OrderedImports.self,
input: """
import AppKit
// swift-format-ignore
import CoreLocation
// Second CoreLocation import here.
import CoreLocation
// Comment about ZeeFramework.
import ZeeFramework
// swift-format-ignore
import ZeeFramework // trailing comment
foo()
""",
expected: """
import AppKit
// swift-format-ignore
import CoreLocation
// Second CoreLocation import here.
import CoreLocation
// Comment about ZeeFramework.
import ZeeFramework
// swift-format-ignore
import ZeeFramework // trailing comment
foo()
""",
findings: []
)
}
func testDuplicateAttributedImports() {
assertFormatting(
OrderedImports.self,
input: """
// exported import of bar
@_exported import bar
@_implementationOnly import bar
import bar
import foo
// second import of foo
1️⃣import foo
// imports an enum
import enum Darwin.D.isatty
// this is a dup
2️⃣import enum Darwin.D.isatty
@testable import foo
baz()
""",
expected: """
// exported import of bar
@_exported import bar
@_implementationOnly import bar
import bar
// second import of foo
import foo
// imports an enum
// this is a dup
import enum Darwin.D.isatty
@testable import foo
baz()
""",
findings: [
FindingSpec("1️⃣", message: "remove this duplicate import"),
FindingSpec("2️⃣", message: "remove this duplicate import"),
]
)
}
func testConditionalImports() {
assertFormatting(
OrderedImports.self,
input: """
import Zebras
1️⃣import Apples
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#endif
2️⃣import Aardvarks
foo()
bar()
baz()
""",
expected: """
import Aardvarks
import Apples
import Zebras
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#endif
foo()
bar()
baz()
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
FindingSpec("2️⃣", message: "place imports at the top of the file"),
]
)
}
func testIgnoredConditionalImports() {
assertFormatting(
OrderedImports.self,
input: """
import Zebras
1️⃣import Apples
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#endif
// swift-format-ignore
import Aardvarks
foo()
bar()
baz()
""",
expected: """
import Apples
import Zebras
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#endif
// swift-format-ignore
import Aardvarks
foo()
bar()
baz()
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
func testTrailingCommentsOnTopLevelCodeItems() {
assertFormatting(
OrderedImports.self,
input: """
import Zebras
1️⃣import Apples
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#endif // canImport(Darwin)
foo() // calls the foo
bar() // calls the bar
""",
expected: """
import Apples
import Zebras
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#endif // canImport(Darwin)
foo() // calls the foo
bar() // calls the bar
""",
findings: [
FindingSpec("1️⃣", message: "sort import statements lexicographically"),
]
)
}
}
|