1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419
|
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import SwiftBasicFormat
import SwiftParser
@_spi(Testing) import SwiftRefactor
import SwiftSyntax
import SwiftSyntaxBuilder
import XCTest
import _SwiftSyntaxTestSupport
fileprivate let closurePlaceholder = wrapInPlaceholder("T##closure##() -> Void")
fileprivate let closureWithArgPlaceholder = wrapInPlaceholder(
"T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String"
)
fileprivate let voidPlaceholder = wrapInPlaceholder("T##code##Void")
fileprivate let intPlaceholder = wrapInPlaceholder("T##Int##Int")
fileprivate let stringPlaceholder = wrapInPlaceholder("T##String##String")
final class ExpandEditorPlaceholderTests: XCTestCase {
func testSimple() throws {
try assertRefactorPlaceholder("displayOnly", expected: "displayOnly")
try assertRefactorPlaceholder("T##typed", expected: "typed")
try assertRefactorPlaceholder("T##displayAndType##Int", expected: "Int")
try assertRefactorPlaceholder("T##bothTypes##Int##BetterInt", expected: "BetterInt")
try assertRefactorPlaceholder("T##bothTypesFirstEmpty####BetterInt", expected: "BetterInt")
}
func testEmpty() throws {
try assertRefactorPlaceholder("", expected: "")
try assertRefactorPlaceholder("T##", expected: "")
try assertRefactorPlaceholder("T##displayEmptyType##", expected: "displayEmptyType")
try assertRefactorPlaceholder("T####EmptyDisplay", expected: "EmptyDisplay")
try assertRefactorPlaceholder("T######EmptyTypeAndDisplay", expected: "EmptyTypeAndDisplay")
try assertRefactorPlaceholder("T##bothTypesFirstNotEmpty##Int##", expected: "Int")
try assertRefactorPlaceholder("T##bothTypesEmpty####", expected: "bothTypesEmpty")
}
func testVoidClosure() throws {
let expected = """
{
\(voidPlaceholder)
}
"""
try assertRefactorPlaceholder("T##display##() -> Void", expected: expected)
}
func testTypedReturnClosure() throws {
let expected = """
{
\(intPlaceholder)
}
"""
try assertRefactorPlaceholder("T##display##() -> Int", expected: expected)
}
func testClosureWithArg() throws {
let expected = """
{ arg in
\(intPlaceholder)
}
"""
try assertRefactorPlaceholder("T##display##(arg: String) -> Int", expected: expected)
try assertRefactorPlaceholder("T##display##(_ arg: String) -> Int", expected: expected)
}
func testClosureWithMultipleArgs() throws {
let expected = """
{ arg, arg2 in
\(intPlaceholder)
}
"""
try assertRefactorPlaceholder("T##display##(arg: String, arg2: String) -> Int", expected: expected)
}
func testSimpleComments() throws {
let placeholder = wrapInPlaceholder("simple")
try assertRefactorPlaceholder("/*c1*/\(placeholder)/*c2*/", wrap: false, expected: "/*c1*/simple/*c2*/")
}
func testClosureComments() throws {
let placeholder = wrapInPlaceholder("T##display##(arg: String) -> Int")
let expected = """
/*c1*/{ arg in
\(intPlaceholder)
}/*c2*/
"""
try assertRefactorPlaceholder("/*c1*/\(placeholder)/*c2*/", wrap: false, expected: expected)
}
func testSingleClosureArg() throws {
let baseline = "call(\(closurePlaceholder))"
let expected: String = """
call {
\(voidPlaceholder)
}
"""
try assertRefactorPlaceholderCall(baseline, expected: expected)
}
func testSingleNonClosureArg() throws {
try assertRefactorPlaceholderToken("call(\(intPlaceholder))", expected: "Int")
}
func testTypeForExpansionPreferred() throws {
let placeholder = wrapInPlaceholder("T##closure##BadType##() -> Int")
let baseline = "call(\(placeholder))"
let expected: String = """
call {
\(intPlaceholder)
}
"""
try assertRefactorPlaceholderCall(baseline, expected: expected)
}
func testPlaceholderWithoutExplicitText() throws {
let placeholder = wrapInPlaceholder("T##(Int) -> Void")
let baseline = "call(\(placeholder))"
let int = wrapInPlaceholder("Int")
let expected: String = """
call { \(int) in
\(voidPlaceholder)
}
"""
try assertRefactorPlaceholderCall(baseline, expected: expected)
}
func testMultipleClosureArgs() throws {
let baseline = "call(arg1: \(closurePlaceholder), arg2: \(closurePlaceholder))"
let expected: String = """
call {
\(voidPlaceholder)
} arg2: {
\(voidPlaceholder)
}
"""
try assertRefactorPlaceholderCall(baseline, expected: expected)
try assertRefactorPlaceholderCall(baseline, placeholder: 1, expected: expected)
}
func testNonClosureAfterClosure() throws {
let baseline = "call(arg1: \(closurePlaceholder), arg2: \(intPlaceholder))"
let expected: String = """
{
\(voidPlaceholder)
}
"""
try assertRefactorPlaceholderToken(baseline, expected: expected)
}
func testComments() throws {
let baseline = """
/*c1*/foo/*c2*/(/*c3*/arg/*c4*/: /*c5*/\(closurePlaceholder)/*c6*/,/*c7*/
/*c8*/\(closurePlaceholder)/*c9*/)/*c10*/
"""
// TODO: Should we remove whitespace from the merged trivia? The space
// between c2 and c3 is the one added for the `{`. The space between c4
// and c5 is the space between the `:` and c5 (added by merging the
// colon's trivia since it was removed).
let expected: String = """
/*c1*/foo/*c2*/ /*c3*//*c4*/ /*c5*/{
\(voidPlaceholder)
}/*c6*//*c7*/ _:
/*c8*/{
\(voidPlaceholder)
}/*c9*//*c10*/
"""
try assertRefactorPlaceholderCall(baseline, placeholder: 1, expected: expected)
}
func testExpandEditorPlaceholdersToSingleTrailingClosures() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(arg: \(intPlaceholder), closure: \(closureWithArgPlaceholder))
""",
expected: """
foo(arg: \(intPlaceholder)) { someInt in
\(stringPlaceholder)
}
"""
)
}
func testExpandEditorPlaceholdersToMultipleTrailingClosures() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(arg: \(intPlaceholder), firstClosure: \(closureWithArgPlaceholder), secondClosure: \(closureWithArgPlaceholder))
""",
expected: """
foo(arg: \(intPlaceholder)) { someInt in
\(stringPlaceholder)
} secondClosure: { someInt in
\(stringPlaceholder)
}
"""
)
}
func testExpandEditorPlaceholdersDoesntExpandClosureBeforeNormalArgs() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(pre: \(closurePlaceholder), arg: \(intPlaceholder), closure: \(closureWithArgPlaceholder))
""",
expected: """
foo(pre: \(closurePlaceholder), arg: \(intPlaceholder)) { someInt in
\(stringPlaceholder)
}
"""
)
}
func testCallHasInitialIndentation() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(arg: 1, closure: \(closureWithArgPlaceholder))
""",
expected: """
foo(arg: 1) { someInt in
\(stringPlaceholder)
}
"""
)
}
func testCustomIndentationWidth() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(arg: 1, closure: \(closureWithArgPlaceholder))
""",
expected: """
foo(arg: 1) { someInt in
\(stringPlaceholder)
}
""",
indentationWidth: .spaces(2)
)
}
func testCustomIndentationWidthWithInitialIndentation() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(arg: 1, closure: \(closureWithArgPlaceholder))
""",
expected: """
foo(arg: 1) { someInt in
\(stringPlaceholder)
}
""",
indentationWidth: .spaces(2)
)
}
func testMultilineCall() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(
arg: 1,
closure: \(closureWithArgPlaceholder)
)
""",
expected: """
foo(
arg: 1
) { someInt in
\(stringPlaceholder)
}
"""
)
}
func testMultilineIndentedCall() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(
arg: 1,
closure: \(closureWithArgPlaceholder)
)
""",
expected: """
foo(
arg: 1
) { someInt in
\(stringPlaceholder)
}
"""
)
}
func testMultilineCallWithNoAdditionalArguments() throws {
try assertExpandEditorPlaceholdersToTrailingClosures(
"""
foo(
closure: \(closureWithArgPlaceholder)
)
""",
expected: """
foo { someInt in
\(stringPlaceholder)
}
"""
)
}
}
fileprivate func assertRefactorPlaceholder(
_ placeholder: String,
wrap: Bool = true,
expected: String,
indentationWidth: Trivia? = nil,
file: StaticString = #filePath,
line: UInt = #line
) throws {
let token: TokenSyntax
if wrap {
token = "\(raw: wrapInPlaceholder(placeholder))"
} else {
var parser = Parser(placeholder)
let expr = ExprSyntax.parse(from: &parser)
token = try XCTUnwrap(expr.as(DeclReferenceExprSyntax.self)?.baseName, file: file, line: line)
}
try assertRefactor(
token,
context: ExpandEditorPlaceholder.Context(indentationWidth: indentationWidth),
provider: ExpandEditorPlaceholder.self,
expected: [SourceEdit.replace(token, with: expected)],
file: file,
line: line
)
}
fileprivate func assertRefactorPlaceholderCall(
_ expr: String,
placeholder: Int = 0,
expected: String,
indentationWidth: Trivia? = nil,
file: StaticString = #filePath,
line: UInt = #line
) throws {
var parser = Parser(expr)
let call = try XCTUnwrap(ExprSyntax.parse(from: &parser).as(FunctionCallExprSyntax.self), file: file, line: line)
let arg = call.arguments[call.arguments.index(at: placeholder)]
let token: TokenSyntax = try XCTUnwrap(arg.expression.as(DeclReferenceExprSyntax.self), file: file, line: line)
.baseName
try assertRefactor(
token,
context: ExpandEditorPlaceholder.Context(indentationWidth: indentationWidth),
provider: ExpandEditorPlaceholder.self,
expected: [SourceEdit.replace(call, with: expected)],
file: file,
line: line
)
}
fileprivate func assertRefactorPlaceholderToken(
_ expr: String,
placeholder: Int = 0,
expected: String,
indentationWidth: Trivia? = nil,
file: StaticString = #filePath,
line: UInt = #line
) throws {
var parser = Parser(expr)
let call = try XCTUnwrap(ExprSyntax.parse(from: &parser).as(FunctionCallExprSyntax.self), file: file, line: line)
let arg = call.arguments[call.arguments.index(at: placeholder)]
let token: TokenSyntax = try XCTUnwrap(arg.expression.as(DeclReferenceExprSyntax.self), file: file, line: line)
.baseName
try assertRefactor(
token,
context: ExpandEditorPlaceholder.Context(indentationWidth: indentationWidth),
provider: ExpandEditorPlaceholder.self,
expected: [SourceEdit.replace(token, with: expected)],
file: file,
line: line
)
}
fileprivate func assertExpandEditorPlaceholdersToTrailingClosures(
_ expr: String,
expected: String,
indentationWidth: Trivia? = nil,
file: StaticString = #filePath,
line: UInt = #line
) throws {
var parser = Parser(expr)
let call = try XCTUnwrap(ExprSyntax.parse(from: &parser).as(FunctionCallExprSyntax.self), file: file, line: line)
try assertRefactor(
call,
context: ExpandEditorPlaceholdersToTrailingClosures.Context(indentationWidth: indentationWidth),
provider: ExpandEditorPlaceholdersToTrailingClosures.self,
expected: [SourceEdit.replace(call, with: expected)],
file: file,
line: line
)
}
|