1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402
|
//===--- LoadBorrowImmutabilityChecker.cpp --------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
///
/// \file
///
/// This file defines a verifier that exhaustively validates that there aren't
/// any load_borrows in a SIL module that have in-scope writes to their
/// underlying storage.
///
//===----------------------------------------------------------------------===//
#define DEBUG_TYPE "sil-load-borrow-immutability-checker"
#include "VerifierPrivate.h"
#include "swift/Basic/Debug.h"
#include "swift/Basic/LLVM.h"
#include "swift/Basic/MultiMapCache.h"
#include "swift/SIL/BasicBlockUtils.h"
#include "swift/SIL/LinearLifetimeChecker.h"
#include "swift/SIL/MemAccessUtils.h"
#include "swift/SIL/OwnershipUtils.h"
#include "swift/SIL/PrunedLiveness.h"
#include "swift/SIL/Projection.h"
#include "swift/SIL/SILInstruction.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/ErrorHandling.h"
using namespace swift;
using namespace swift::silverifier;
//===----------------------------------------------------------------------===//
// Write Gatherer
//===----------------------------------------------------------------------===//
namespace {
// Visitor for visitAccessPathUses().
class GatherWritesVisitor : public AccessUseVisitor {
// Result: writes to the AccessPath being visited.
SmallVectorImpl<Operand *> &writeAccumulator;
public:
GatherWritesVisitor(SmallVectorImpl<Operand *> &writes)
: AccessUseVisitor(AccessUseType::Exact,
NestedAccessType::StopAtAccessBegin),
writeAccumulator(writes) {}
bool visitUse(Operand *op, AccessUseType useTy) override;
};
// Functor for MultiMapCache construction.
struct GatherWrites {
const SILFunction *function;
GatherWrites(const SILFunction *function) : function(function) {}
bool operator()(const AccessPath &accessPath,
SmallVectorImpl<Operand *> &writeAccumulator) {
GatherWritesVisitor visitor(writeAccumulator);
return visitAccessPathUses(visitor, accessPath,
const_cast<SILFunction *>(function));
}
};
} // end anonymous namespace
// Filter out recognized uses that do not write to memory.
//
// TODO: Ensure that all of the conditional-write logic below is encapsulated in
// mayWriteToMemory and just call that instead. Possibly add additional
// verification that visitAccessPathUses recognizes all instructions that may
// propagate pointers (even though they don't write).
bool GatherWritesVisitor::visitUse(Operand *op, AccessUseType useTy) {
// If this operand is for a dependent type, then it does not actually access
// the operand's address value. It only uses the metatype defined by the
// operation (e.g. open_existential).
if (op->isTypeDependent()) {
return true;
}
SILInstruction *user = op->getUser();
if (isIncidentalUse(user)) {
return true;
}
switch (user->getKind()) {
// Known reads...
case SILInstructionKind::LoadBorrowInst:
case SILInstructionKind::SelectEnumAddrInst:
case SILInstructionKind::SwitchEnumAddrInst:
case SILInstructionKind::DeallocStackInst:
case SILInstructionKind::DeallocStackRefInst:
case SILInstructionKind::DeallocBoxInst:
case SILInstructionKind::WitnessMethodInst:
case SILInstructionKind::ExistentialMetatypeInst:
case SILInstructionKind::HopToExecutorInst:
case SILInstructionKind::ExtractExecutorInst:
case SILInstructionKind::ValueMetatypeInst:
return true;
// Known writes...
case SILInstructionKind::DestroyAddrInst:
case SILInstructionKind::DestroyValueInst:
case SILInstructionKind::InjectEnumAddrInst:
case SILInstructionKind::StoreInst:
case SILInstructionKind::StoreBorrowInst:
case SILInstructionKind::AssignInst:
case SILInstructionKind::UncheckedTakeEnumDataAddrInst:
case SILInstructionKind::MarkFunctionEscapeInst:
case SILInstructionKind::DeallocRefInst:
case SILInstructionKind::DeallocPartialRefInst:
case SILInstructionKind::IsUniqueInst:
writeAccumulator.push_back(op);
return true;
// Load/Store variations...
#define NEVER_OR_SOMETIMES_LOADABLE_CHECKED_REF_STORAGE(Name, name, NAME) \
case SILInstructionKind::Load##Name##Inst: \
if (cast<Load##Name##Inst>(user)->isTake() == IsTake) { \
writeAccumulator.push_back(op); \
} \
return true; \
\
case SILInstructionKind::Store##Name##Inst: \
writeAccumulator.push_back(op); \
return true;
#include "swift/AST/ReferenceStorage.def"
// Ignored pointer uses...
// Returns are never in scope.
case SILInstructionKind::ReturnInst:
return true;
// Reads that may perform a "take"...
case SILInstructionKind::LoadInst:
if (cast<LoadInst>(user)->getOwnershipQualifier()
== LoadOwnershipQualifier::Take) {
writeAccumulator.push_back(op);
}
return true;
case SILInstructionKind::UnconditionalCheckedCastAddrInst:
return true;
case SILInstructionKind::CheckedCastAddrBranchInst: {
auto *ccbi = cast<CheckedCastAddrBranchInst>(user);
if (ccbi->getConsumptionKind() != CastConsumptionKind::CopyOnSuccess) {
writeAccumulator.push_back(op);
}
return true;
}
// Conditional writes...
case SILInstructionKind::CopyAddrInst:
if (cast<CopyAddrInst>(user)->getDest() == op->get()) {
writeAccumulator.push_back(op);
return true;
}
// This operand is the copy source. Check if it is taken.
if (cast<CopyAddrInst>(user)->isTakeOfSrc()) {
writeAccumulator.push_back(op);
}
return true;
case SILInstructionKind::ExplicitCopyAddrInst:
if (cast<ExplicitCopyAddrInst>(user)->getDest() == op->get()) {
writeAccumulator.push_back(op);
return true;
}
// This operand is the copy source. Check if it is taken.
if (cast<ExplicitCopyAddrInst>(user)->isTakeOfSrc()) {
writeAccumulator.push_back(op);
}
return true;
case SILInstructionKind::MarkUnresolvedMoveAddrInst:
if (cast<MarkUnresolvedMoveAddrInst>(user)->getDest() == op->get()) {
writeAccumulator.push_back(op);
return true;
}
// This operand is the move source, we just return true. This is because
// mark_unresolved_move_addr semantically is treated as a copy_addr of the
// source. The checker determines if we can convert it to a move.
return true;
// If this value is dependent on another, conservatively consider it a write.
//
// FIXME: explain why a mark_dependence effectively writes to storage.
case SILInstructionKind::MarkDependenceInst:
if (cast<MarkDependenceInst>(user)->getValue() == op->get()) {
writeAccumulator.push_back(op);
}
return true;
// Check for mutable existentials.
case SILInstructionKind::OpenExistentialAddrInst:
if (cast<OpenExistentialAddrInst>(user)->getAccessKind()
!= OpenedExistentialAccess::Immutable) {
writeAccumulator.push_back(op);
}
return true;
case SILInstructionKind::BeginAccessInst:
if (cast<BeginAccessInst>(user)->getAccessKind() != SILAccessKind::Read) {
writeAccumulator.push_back(op);
}
return true;
case SILInstructionKind::BuiltinInst:
if (!cast<BuiltinInst>(user)->mayWriteToMemory()) {
return true;
}
writeAccumulator.push_back(op);
return true;
case SILInstructionKind::YieldInst: {
SILYieldInfo info = cast<YieldInst>(user)->getYieldInfoForOperand(*op);
if (info.isIndirectInGuaranteed()) {
return true;
}
if (info.isIndirectMutating() || info.isConsumed()) {
writeAccumulator.push_back(op);
return true;
}
break; // unknown yield convention
}
default:
break;
} // end switch(user->getKind())
// If we have a FullApplySite, see if we use the value as an
// indirect_guaranteed parameter. If we use it as inout, we need
// interprocedural analysis that we do not perform here.
if (auto fas = FullApplySite::isa(user)) {
if (fas.isIndirectResultOperand(*op)) {
writeAccumulator.push_back(op);
return true;
}
auto argConv = fas.getArgumentConvention(*op);
// A box or pointer value may be passed directly. Consider that a write.
if (!argConv.isIndirectConvention()) {
writeAccumulator.push_back(op);
return true;
}
if (argConv == SILArgumentConvention::Indirect_In_Guaranteed) {
return true;
}
if (argConv.isInoutConvention()) {
writeAccumulator.push_back(op);
return true;
}
if (argConv.isOwnedConvention()) {
writeAccumulator.push_back(op);
return true;
}
// Otherwise, be conservative and return that we had a write that we did
// not understand.
llvm::errs() << "Full apply site not understood: " << *user;
return false;
}
if (auto *pa = dyn_cast<PartialApplyInst>(user)) {
auto argConv = ApplySite(user).getArgumentConvention(*op);
if (pa->isOnStack() &&
argConv == SILArgumentConvention::Indirect_In_Guaranteed) {
return true;
}
// For all other conventions, the underlying address could be mutated
writeAccumulator.push_back(op);
return true;
}
// Handle a capture-by-address like a write.
if (auto as = ApplySite::isa(user)) {
writeAccumulator.push_back(op);
return true;
}
// We don't have an inclusive list of all use patterns for non-address
// values. References and pointers can be passed to almost anything that takes
// a value. We assume that visitAccessPathUses has already looked past
// operations that can propagate a reference or pointer, and simply check that
// the leaf use that it returned cannot itself write to memory.
if (!op->get()->getType().isAddress() && !user->mayWriteToMemory()) {
return true;
}
// If we did not recognize the user, print additional error diagnostics and
// return false to force SIL verification to fail.
llvm::errs() << "Function: " << user->getFunction()->getName() << "\n";
llvm::errs() << "Value: " << op->get();
llvm::errs() << "Unknown instruction: " << *user;
return false;
}
//===----------------------------------------------------------------------===//
// Load Borrow Immutability Analysis
//===----------------------------------------------------------------------===//
LoadBorrowImmutabilityAnalysis::LoadBorrowImmutabilityAnalysis(
DeadEndBlocks *deadEndBlocks, const SILFunction *f)
: cache(GatherWrites(f)), deadEndBlocks(deadEndBlocks) {}
// \p address may be an address, pointer, or box type.
bool LoadBorrowImmutabilityAnalysis::isImmutableInScope(
LoadBorrowInst *lbi,
AccessPathWithBase accessPathWithBase) {
auto accessPath = accessPathWithBase.accessPath;
LinearLifetimeChecker checker(deadEndBlocks);
auto writes = cache.get(accessPath);
// Treat None as a write.
if (!writes) {
llvm::errs() << "Failed to find cached writes for: ";
accessPath.getStorage().print(llvm::errs());
return false;
}
BorrowedValue borrowedValue(lbi);
MultiDefPrunedLiveness borrowLiveness(lbi->getFunction());
borrowedValue.computeTransitiveLiveness(borrowLiveness);
// Then for each write...
for (auto *op : *writes) {
auto *write = op->getUser();
// First see if the write is a dead end block. In such a case, just skip it.
if (deadEndBlocks && deadEndBlocks->isDeadEnd(write->getParent())) {
continue;
}
if (borrowLiveness.isWithinBoundary(write)) {
llvm::errs() << "Write: " << *write;
return false;
}
}
// Ok, we are good.
return true;
}
//===----------------------------------------------------------------------===//
// Top Level Entrypoint
//===----------------------------------------------------------------------===//
bool LoadBorrowImmutabilityAnalysis::isImmutable(LoadBorrowInst *lbi) {
auto accessPathWithBase = AccessPathWithBase::compute(lbi->getOperand());
auto accessPath = accessPathWithBase.accessPath;
// Bail on an invalid AccessPath. AccessPath completeness is verified
// independently--it may be invalid in extraordinary situations. When
// AccessPath is valid, we know all its uses are recognizable.
if (!accessPath.isValid()) {
return true;
}
// If we have a let address, then we are already done.
if (accessPath.getStorage().isLetAccess()) {
return true;
}
switch (accessPath.getStorage().getKind()) {
case AccessStorage::Nested: {
// If we have a begin_access and...
auto *bai = cast<BeginAccessInst>(accessPath.getStorage().getValue());
// We do not have a modify, assume we are correct.
if (bai->getAccessKind() != SILAccessKind::Modify) {
return true;
}
// Otherwise, validate that any writes to our begin_access is not when the
// load_borrow's result is live.
//
// TODO: As a separate analysis, verify that the load_borrow scope is always
// nested within the begin_access scope (to ensure no aliasing access).
return isImmutableInScope(lbi, accessPathWithBase);
}
case AccessStorage::Argument: {
auto *arg =
cast<SILFunctionArgument>(accessPath.getStorage().getArgument());
if (arg->hasConvention(SILArgumentConvention::Indirect_In_Guaranteed)) {
return true;
}
return isImmutableInScope(lbi, accessPathWithBase);
}
// FIXME: A yielded address could overlap with another in this function.
case AccessStorage::Yield:
case AccessStorage::Stack:
case AccessStorage::Box:
case AccessStorage::Class:
case AccessStorage::Tail:
case AccessStorage::Global:
case AccessStorage::Unidentified:
return isImmutableInScope(lbi, accessPathWithBase);
}
llvm_unreachable("Covered switch isn't covered?!");
}
|