1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
|
// RUN: %target-swift-frontend -parse-as-library -emit-sil -DNEGATIVES -verify %s
// RUN: %target-swift-frontend -parse-as-library -emit-sil -DNEGATIVES -verify %s -strict-concurrency=targeted
// RUN: %target-swift-frontend -parse-as-library -emit-sil -DNEGATIVES -verify %s -strict-concurrency=complete
// RUN: %target-swift-frontend -parse-as-library -emit-sil -DNEGATIVES -verify %s -strict-concurrency=complete -enable-upcoming-feature RegionBasedIsolation
// RUN: %target-swift-frontend -parse-as-library -emit-sil -enable-actor-data-race-checks -o - %s | %FileCheck %s
// REQUIRES: concurrency
// REQUIRES: asserts
func doSomething() {}
// expected-note @+1 6 {{calls to global function 'requiresMainActor()' from outside of its actor context are implicitly asynchronous}}
@MainActor func requiresMainActor() {}
@MainActor func testNonDefer_positive() {
requiresMainActor()
}
#if NEGATIVES
// expected-note @+1 {{add '@MainActor' to make global function 'testNonDefer_negative()' part of global actor 'MainActor'}}
func testNonDefer_negative() {
// expected-error @+1 {{call to main actor-isolated global function 'requiresMainActor()' in a synchronous nonisolated context}}
requiresMainActor()
}
#endif
@MainActor func testGlobalActor_positive() {
defer {
requiresMainActor()
}
doSomething()
}
// Don't include a data race check at the start of the defer
// CHECK-LABEL: sil private @$s11actor_defer24testGlobalActor_positiveyyF6$deferL_yyF
// CHECK-NEXT: bb0:
// CHECK-NEXT: // function_ref
// CHECK-NEXT: function_ref
// CHECK-NEXT: apply
#if NEGATIVES
// expected-note @+1 {{add '@MainActor' to make global function 'testGlobalActor_negative()' part of global actor 'MainActor'}}
func testGlobalActor_negative() {
defer {
// expected-error @+1 {{call to main actor-isolated global function 'requiresMainActor()' in a synchronous nonisolated context}}
requiresMainActor()
}
doSomething()
}
#endif
@available(SwiftStdlib 5.1, *)
@MainActor func testGlobalActorAsync_positive() async {
defer {
requiresMainActor()
}
doSomething()
}
#if NEGATIVES
// expected-note @+2 {{add '@MainActor' to make global function 'testGlobalActorAsync_negative()' part of global actor 'MainActor'}}
@available(SwiftStdlib 5.1, *)
func testGlobalActorAsync_negative() async {
defer {
// expected-error @+1 {{call to main actor-isolated global function 'requiresMainActor()' in a synchronous nonisolated context}}
requiresMainActor()
}
doSomething()
}
#endif
@available(SwiftStdlib 5.1, *)
actor Actor {
// expected-note @+1 6 {{mutation of this property is only permitted within the actor}}
var actorProperty = 0
func testActor_positive() {
defer {
actorProperty += 1
}
doSomething()
}
func testActor_task_positive() {
Task {
defer { actorProperty += 1 }
doSomething()
}
}
#if NEGATIVES
nonisolated func testActor_negative() {
defer {
// expected-error @+1 {{actor-isolated property 'actorProperty' can not be mutated from a nonisolated context}}
actorProperty += 1
}
doSomething()
}
nonisolated func testActor_task_negative() {
Task {
// expected-error @+1 {{actor-isolated property 'actorProperty' can not be mutated from a nonisolated context}}
defer { actorProperty += 1 }
doSomething()
}
}
@MainActor func testActor_negative_globalActor() {
defer {
// expected-error @+1 {{actor-isolated property 'actorProperty' can not be mutated from the main actor}}
actorProperty += 1
}
doSomething()
}
func testActor_task_negative_globalActor() {
Task { @MainActor in
// expected-error @+1 {{actor-isolated property 'actorProperty' can not be mutated from the main actor}}
defer { actorProperty += 1 }
doSomething()
}
}
#endif
@MainActor func testGlobalActor_positive() {
defer {
requiresMainActor()
}
doSomething()
}
func testGlobalActor_task_positive() {
Task { @MainActor in
defer { requiresMainActor() }
doSomething()
}
}
#if NEGATIVES
func testGlobalActor_negative() {
defer {
// expected-error @+1 {{call to main actor-isolated global function 'requiresMainActor()' in a synchronous actor-isolated context}}
requiresMainActor()
}
doSomething()
}
func testGlobalActor_task_negative() {
Task {
// expected-error @+1 {{call to main actor-isolated global function 'requiresMainActor()' in a synchronous nonisolated context}}
defer { requiresMainActor() }
doSomething()
}
}
#endif
}
@available(SwiftStdlib 5.1, *)
func testIsolatedActor_positive(actor: isolated Actor) {
actor.actorProperty += 1
defer {
actor.actorProperty += 1
}
doSomething()
}
#if NEGATIVES
@available(SwiftStdlib 5.1, *)
func testIsolatedActor_negative(actor: Actor) {
defer {
// expected-error @+1 {{actor-isolated property 'actorProperty' can not be mutated from a nonisolated context}}
actor.actorProperty += 1
}
doSomething()
}
#endif
@available(SwiftStdlib 5.1, *)
func testGlobalActor_inTask_positive() {
Task { @MainActor in
defer { requiresMainActor() }
doSomething()
}
}
#if NEGATIVES
@available(SwiftStdlib 5.1, *)
func testGlobalActor_inTask_negative() {
Task {
// expected-error @+1 {{call to main actor-isolated global function 'requiresMainActor()' in a synchronous nonisolated context}}
defer { requiresMainActor() }
doSomething()
}
}
#endif
@available(SwiftStdlib 5.1, *)
func takeClosureWithIsolatedParam(body: (isolated Actor) -> Void) {}
@available(SwiftStdlib 5.1, *)
func takeClosureWithNotIsolatedParam(body: (Actor) -> Void) {}
@available(SwiftStdlib 5.1, *)
func testIsolatedActor_closure_positive() {
takeClosureWithIsolatedParam { actor in
actor.actorProperty += 1
defer { actor.actorProperty += 1 }
doSomething()
}
}
#if NEGATIVES
@available(SwiftStdlib 5.1, *)
func testIsolatedActor_closure_negative() {
takeClosureWithNotIsolatedParam { actor in
// expected-error @+1 {{actor-isolated property 'actorProperty' can not be mutated from a nonisolated context}}
defer { actor.actorProperty += 1 }
doSomething()
}
}
#endif
|
