1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312
|
// RUN: %target-typecheck-verify-swift
func f0(_ x: inout Int) {}
func f1<T>(_ x: inout T) {}
func f2(_ x: inout X) {}
func f2(_ x: inout Double) {}
class Reftype {
var property: Double { get {} set {} }
}
struct X {
subscript(i: Int) -> Float { get {} set {} }
var property: Double { get {} set {} }
func genuflect() {}
}
struct Y {
subscript(i: Int) -> Float { get {} set {} }
subscript(f: Float) -> Int { get {} set {} }
}
var i : Int
var f : Float
var x : X
var y : Y
func +=(lhs: inout X, rhs : X) {}
prefix operator +++
prefix func +++(rhs: inout X) {}
f0(&i)
f1(&i)
f1(&x[i])
f1(&x.property)
f1(&y[i])
// Missing '&'
f0(i) // expected-error{{passing value of type 'Int' to an inout parameter requires explicit '&'}}{{4-4=&}}
f1(y[i]) // expected-error{{passing value of type 'Float' to an inout parameter requires explicit '&'}} {{4-4=&}}
// Assignment operators
x += x
+++x
var yi = y[i]
// Non-settable lvalues
var non_settable_x : X {
return x
}
struct Z {
var non_settable_x: X { get {} }
var non_settable_reftype: Reftype { get {} }
var settable_x : X
subscript(i: Int) -> Double { get {} }
subscript(_: (i: Int, j: Int)) -> X { get {} }
}
var z : Z
func fz() -> Z {}
func fref() -> Reftype {}
// non-settable var is non-settable:
// - assignment
non_settable_x = x // expected-error{{cannot assign to value: 'non_settable_x' is a get-only property}}
// - inout (mono)
f2(&non_settable_x) // expected-error{{cannot pass immutable value as inout argument: 'non_settable_x' is a get-only property}}
// - inout (generic)
f1(&non_settable_x) // expected-error{{cannot pass immutable value as inout argument: 'non_settable_x' is a get-only property}}
// - inout assignment
non_settable_x += x // expected-error{{left side of mutating operator isn't mutable: 'non_settable_x' is a get-only property}}
+++non_settable_x // expected-error{{cannot pass immutable value to mutating operator: 'non_settable_x' is a get-only property}}
// non-settable property is non-settable:
z.non_settable_x = x // expected-error{{cannot assign to property: 'non_settable_x' is a get-only property}}
f2(&z.non_settable_x) // expected-error{{cannot pass immutable value as inout argument: 'non_settable_x' is a get-only property}}
f1(&z.non_settable_x) // expected-error{{cannot pass immutable value as inout argument: 'non_settable_x' is a get-only property}}
z.non_settable_x += x // expected-error{{left side of mutating operator isn't mutable: 'non_settable_x' is a get-only property}}
+++z.non_settable_x // expected-error{{cannot pass immutable value to mutating operator: 'non_settable_x' is a get-only property}}
// non-settable subscript is non-settable:
z[0] = 0.0 // expected-error{{cannot assign through subscript: subscript is get-only}}
f2(&z[0]) // expected-error{{cannot pass immutable value as inout argument: subscript is get-only}}
f1(&z[0]) // expected-error{{cannot pass immutable value as inout argument: subscript is get-only}}
z[0] += 0.0 // expected-error{{left side of mutating operator isn't mutable: subscript is get-only}}
+++z[0] // expected-error{{cannot convert value of type 'Double' to expected argument type 'X'}}
+++z[(i: 0, j: 0)] // expected-error{{cannot pass immutable value to mutating operator: subscript is get-only}}
// settable property of an rvalue value type is non-settable:
fz().settable_x = x // expected-error{{cannot assign to property: 'fz' returns immutable value}}
f2(&fz().settable_x) // expected-error{{cannot pass immutable value as inout argument: 'fz' returns immutable value}}
f1(&fz().settable_x) // expected-error{{cannot pass immutable value as inout argument: 'fz' returns immutable value}}
fz().settable_x += x // expected-error{{left side of mutating operator isn't mutable: 'fz' returns immutable value}}
+++fz().settable_x // expected-error{{cannot pass immutable value to mutating operator: 'fz' returns immutable value}}
// settable property of an rvalue reference type IS SETTABLE:
fref().property = 0.0
f2(&fref().property)
f1(&fref().property)
fref().property += 0.0
fref().property += 1
// settable property of a non-settable value type is non-settable:
z.non_settable_x.property = 1.0 // expected-error{{cannot assign to property: 'non_settable_x' is a get-only property}}
f2(&z.non_settable_x.property) // expected-error{{cannot pass immutable value as inout argument: 'non_settable_x' is a get-only property}}
f1(&z.non_settable_x.property) // expected-error{{cannot pass immutable value as inout argument: 'non_settable_x' is a get-only property}}
z.non_settable_x.property += 1.0 // expected-error{{left side of mutating operator isn't mutable: 'non_settable_x' is a get-only property}}
+++z.non_settable_x.property // expected-error{{cannot convert value of type 'Double' to expected argument type 'X'}}
// settable property of a non-settable reference type IS SETTABLE:
z.non_settable_reftype.property = 1.0
f2(&z.non_settable_reftype.property)
f1(&z.non_settable_reftype.property)
z.non_settable_reftype.property += 1.0
z.non_settable_reftype.property += 1
// regressions with non-settable subscripts in value contexts
_ = z[0] == 0
var d : Double
d = z[0]
// regressions with subscripts that return generic types
var xs:[X]
_ = xs[0].property
struct A<T> {
subscript(i: Int) -> T { get {} }
}
struct B {
subscript(i: Int) -> Int { get {} }
}
var a:A<B>
_ = a[0][0]
// Instance members of struct metatypes.
struct FooStruct {
func instanceFunc0() {}
}
func testFooStruct() {
FooStruct.instanceFunc0(FooStruct())()
}
// Don't load from explicit lvalues.
func takesInt(_ x: Int) {}
func testInOut(_ arg: inout Int) {
var x : Int
takesInt(&x) // expected-error{{'&' used with non-inout argument of type 'Int'}}
}
// Don't infer inout types.
var ir = &i // expected-error {{'&' may only be used to pass an argument to inout parameter}}
var ir2 = ((&i)) // expected-error {{'&' may only be used to pass an argument to inout parameter}}
// <rdar://problem/17133089>
func takeArrayRef(_ x: inout Array<String>) { }
// rdar://22308291
takeArrayRef(["asdf", "1234"]) // expected-error{{cannot pass immutable value of type '[String]' as inout argument}}
// <rdar://problem/19835413> Reference to value from array changed
func rdar19835413() {
func f1(_ p: UnsafeMutableRawPointer) {}
func f2(_ a: [Int], i: Int, pi: UnsafeMutablePointer<Int>) {
var a = a
f1(&a)
f1(&a[i])
f1(&a[0])
f1(pi)
f1(pi)
}
}
// <rdar://problem/21877598> Crash when accessing stored property without
// setter from constructor
protocol Radish {
var root: Int { get }
}
public struct Kale : Radish {
public let root : Int
public init() {
let _ = Kale().root
self.root = 0
}
}
func testImmutableUnsafePointer(_ p: UnsafePointer<Int>) {
p.pointee = 1 // expected-error {{cannot assign to property: 'pointee' is a get-only property}}
p[0] = 1 // expected-error {{cannot assign through subscript: subscript is get-only}}
}
/// https://github.com/apple/swift/issues/42633
/// Inferring closure param type to `inout` crashes compiler
let _ = { x in f0(x) } // expected-error{{passing value of type 'Int' to an inout parameter requires explicit '&'}} {{19-19=&}}
// <rdar://problem/17245353> Crash with optional closure taking inout
func rdar17245353() {
typealias Fn = (inout Int) -> ()
func getFn() -> Fn? { return nil }
let _: (inout UInt, UInt) -> Void = { $0 += $1 }
}
// <rdar://problem/23131768> Bugs related to closures with inout parameters
func rdar23131768() {
func f(_ g: (inout Int) -> Void) { var a = 1; g(&a); print(a) }
f { $0 += 1 } // Crashes compiler
func f2(_ g: (inout Int) -> Void) { var a = 1; g(&a); print(a) }
f2 { $0 = $0 + 1 } // previously error: Cannot convert value of type '_ -> ()' to expected type '(inout Int) -> Void'
func f3(_ g: (inout Int) -> Void) { var a = 1; g(&a); print(a) }
f3 { (v: inout Int) -> Void in v += 1 }
}
// <rdar://problem/23331567> Swift: Compiler crash related to closures with inout parameter.
func r23331567(_ fn: (_ x: inout Int) -> Void) {
var a = 0
fn(&a)
}
r23331567 { $0 += 1 }
// <rdar://problem/30685195> Compiler crash with invalid assignment
struct G<T> {
subscript(x: Int) -> T { get { } nonmutating set { } }
// expected-note@-1 {{'subscript(_:)' declared here}}
}
func wump<T>(to: T, _ body: (G<T>) -> ()) {}
wump(to: 0, { $0[] = 0 })
// expected-error@-1 {{missing argument for parameter #1 in subscript}}
// https://github.com/apple/swift/issues/56129
extension MutableCollection {
public mutating func writePrefix<I: IteratorProtocol>(from source: inout I)
-> (writtenCount: Int, afterLastWritten: Index)
where I.Element == Element
{
fatalError()
}
public mutating func writePrefix<Source: Collection>(from source: Source)
-> (writtenCount: Int, afterLastWritten: Index, afterLastRead: Source.Index)
where Source.Element == Element
{
fatalError()
}
}
func testWritePrefixIterator() {
var a = Array(0..<10)
var underflow = (1..<10).makeIterator()
var (writtenCount, afterLastWritten) = a.writePrefix(from: underflow) // expected-error {{passing value of type 'IndexingIterator<(Range<Int>)>' to an inout parameter requires explicit '&'}} {{62-62=&}}
}
// rdar://problem/71356981 - wrong error message for state passed as inout with ampersand within parentheses
func look_through_parens_when_checking_inout() {
struct Point {
var x: Int = 0
var y: Int = 0
}
func modifyPoint(_ point: inout Point, _: Int = 42) {}
func modifyPoint(_ point: inout Point, msg: String) {}
func modifyPoint(source: inout Point) {}
var point = Point(x: 0, y: 0)
modifyPoint((&point)) // expected-error {{'&' may only be used to pass an argument to inout parameter}} {{16-17=(}} {{15-16=&}}
modifyPoint(((&point))) // expected-error {{'&' may only be used to pass an argument to inout parameter}} {{17-18=(}} {{15-16=&}}
modifyPoint(source: (&point)) // expected-error {{'&' may only be used to pass an argument to inout parameter}} {{24-25=(}} {{23-24=&}}
modifyPoint(source: ((&point))) // expected-error {{'&' may only be used to pass an argument to inout parameter}} {{25-26=(}} {{23-24=&}}
modifyPoint((&point), 0) // expected-error {{'&' may only be used to pass an argument to inout parameter}} {{16-17=(}} {{15-16=&}}
modifyPoint((&point), msg: "") // expected-error {{'&' may only be used to pass an argument to inout parameter}} {{16-17=(}} {{15-16=&}}
}
// rdar://96631324 - compiler crash while producing diagnostics
func test_incorrect_inout_at_assignment_source() {
class S {
var prop: String = ""
}
func test(s: S) {
let str: String = ""
let val: Int = 0
s.prop = &str // expected-error {{'&' may only be used to pass an argument to inout parameter}}
s.prop = &val // expected-error {{'&' may only be used to pass an argument to inout parameter}}
}
}
// rdar://100369066 - type of expression is ambiguous when `&` is used incorrectly
func test_invalid_inout_with_restrictions(lhs: inout any BinaryInteger, rhs: any BinaryInteger) {
lhs = &rhs // expected-error {{'&' may only be used to pass an argument to inout parameter}}
var other: (any BinaryInteger)? = nil
other = &rhs // expected-error {{'&' may only be used to pass an argument to inout parameter}}
}
|