1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
|
// RUN: %empty-directory(%t)
// RUN: %target-build-swift -swift-version 4 %s -o %t/a.out -enforce-exclusivity=checked -Onone
//
// RUN: %target-codesign %t/a.out
// RUN: %target-run %t/a.out
// REQUIRES: executable_test
// REQUIRES: thread_safe_runtime
// UNSUPPORTED: use_os_stdlib
// Tests for traps at run time when enforcing exclusive access.
import StdlibUnittest
import SwiftPrivateThreadExtras
struct X {
var i = 7
}
/// Calling this function will begin a read access to the variable referred to
/// in the first parameter that lasts for the duration of the call. Any
/// accesses in the closure will therefore be nested inside the outer read.
func readAndPerform<T>(_ _: UnsafePointer<T>, closure: () ->()) {
closure()
}
/// Begin a modify access to the first parameter and call the closure inside it.
func modifyAndPerform<T>(_ _: UnsafeMutablePointer<T>, closure: () ->()) {
closure()
}
/// Begin a modify access to the first parameter and call the escaping closure inside it.
func modifyAndPerformEscaping<T>(_ _: UnsafeMutablePointer<T>, closure: () ->()) {
closure()
}
var globalX = X()
var ExclusiveAccessTestSuite = TestSuite("ExclusiveAccess")
ExclusiveAccessTestSuite.test("Read") {
let l = globalX // no-trap
_blackHole(l)
}
// It is safe for a read access to overlap with a read.
ExclusiveAccessTestSuite.test("ReadInsideRead") {
readAndPerform(&globalX) {
let l = globalX // no-trap
_blackHole(l)
}
}
ExclusiveAccessTestSuite.test("ModifyInsideRead")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a read) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
readAndPerform(&globalX) {
expectCrashLater()
globalX = X()
}
}
ExclusiveAccessTestSuite.test("ReadInsideModify")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a read) started at")
.code
{
modifyAndPerform(&globalX) {
expectCrashLater()
let l = globalX
_blackHole(l)
}
}
ExclusiveAccessTestSuite.test("ModifyInsideModify")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
modifyAndPerform(&globalX) {
expectCrashLater()
globalX.i = 12
}
}
var globalOtherX = X()
// It is safe for two modifications of different variables
// to overlap.
ExclusiveAccessTestSuite.test("ModifyInsideModifyOfOther") {
modifyAndPerform(&globalOtherX) {
globalX.i = 12 // no-trap
}
}
// The access durations for these two modifications do not overlap
ExclusiveAccessTestSuite.test("ModifyFollowedByModify") {
globalX = X()
_blackHole(())
globalX = X() // no-trap
}
ExclusiveAccessTestSuite.test("ClosureCaptureReadRead") {
var x = X()
readAndPerform(&x) {
_blackHole(x.i) // no-trap
}
}
// Test for per-thread enforcement. Don't trap when two different threads
// have overlapping accesses
ExclusiveAccessTestSuite.test("PerThreadEnforcement") {
modifyAndPerform(&globalX) {
let (_, otherThread) = _stdlib_thread_create_block({ (_ : Void) -> () in
globalX.i = 12 // no-trap
return ()
}, ())
_ = _stdlib_thread_join(otherThread!, Void.self)
}
}
// Helpers
func doOne(_ f: () -> ()) { f() }
func doTwo(_ f1: ()->(), _ f2: ()->()) { f1(); f2() }
// No crash.
ExclusiveAccessTestSuite.test("WriteNoescapeWrite") {
var x = 3
let c = { x = 7 }
// Inside may-escape closure `c`: [read] [dynamic]
// Inside never-escape closure: [modify] [dynamic]
doTwo(c, { x = 42 })
_blackHole(x)
}
// No crash.
ExclusiveAccessTestSuite.test("InoutReadEscapeRead") {
var x = 3
let c = { let y = x; _blackHole(y) }
readAndPerform(&x, closure: c)
_blackHole(x)
}
ExclusiveAccessTestSuite.test("InoutReadEscapeWrite")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a read) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
var x = 3
let c = { x = 42 }
expectCrashLater()
readAndPerform(&x, closure: c)
_blackHole(x)
}
ExclusiveAccessTestSuite.test("InoutWriteEscapeRead")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a read) started at")
.code
{
var x = 3
let c = { let y = x; _blackHole(y) }
expectCrashLater()
modifyAndPerform(&x, closure: c)
_blackHole(x)
}
ExclusiveAccessTestSuite.test("InoutWriteEscapeWrite")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
var x = 3
let c = { x = 42 }
expectCrashLater()
modifyAndPerform(&x, closure: c)
_blackHole(x)
}
// No crash.
ExclusiveAccessTestSuite.test("InoutReadNoescapeRead") {
var x = 3
let c = { let y = x; _blackHole(y) }
doOne { readAndPerform(&x, closure: c) }
}
ExclusiveAccessTestSuite.test("InoutReadNoescapeWrite")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a read) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
var x = 3
let c = { x = 7 }
expectCrashLater()
doOne { readAndPerform(&x, closure: c) }
}
ExclusiveAccessTestSuite.test("InoutWriteEscapeReadClosure")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a read) started at")
.code
{
var x = 3
let c = { let y = x; _blackHole(y) }
expectCrashLater()
doOne { modifyAndPerform(&x, closure: c) }
}
ExclusiveAccessTestSuite.test("InoutWriteEscapeWriteClosure")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
var x = 3
let c = { x = 7 }
expectCrashLater()
doOne { modifyAndPerform(&x, closure: c) }
}
class ClassWithStoredProperty {
final var f = 7
}
ExclusiveAccessTestSuite.test("KeyPathInoutDirectWriteClassStoredProp")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
let getF = \ClassWithStoredProperty.f
let c = ClassWithStoredProperty()
expectCrashLater()
modifyAndPerform(&c[keyPath: getF]) {
c.f = 12
}
}
ExclusiveAccessTestSuite.test("KeyPathInoutDirectReadClassStoredProp")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a read) started at")
.code
{
let getF = \ClassWithStoredProperty.f
let c = ClassWithStoredProperty()
expectCrashLater()
modifyAndPerform(&c[keyPath: getF]) {
let x = c.f
_blackHole(x)
}
}
// Unlike inout accesses, read-only inout-to-pointer conversions on key paths for
// final stored-properties do not perform a long-term read access. Instead, they
// materialize a location on the stack, perform an instantaneous read
// from the storage indicated by the key path and write the read value to the
// stack location. The stack location is then passed as the pointer for the
// inout-to-pointer conversion.
//
// This means that there is no conflict between a read-only inout-to-pointer
// conversion of the key path location for a call and an access to the
// the same location within the call.
ExclusiveAccessTestSuite.test("KeyPathReadOnlyInoutToPtrDirectWriteClassStoredProp") {
let getF = \ClassWithStoredProperty.f
let c = ClassWithStoredProperty()
// This performs an instantaneous read
readAndPerform(&c[keyPath: getF]) {
c.f = 12 // no-trap
}
}
ExclusiveAccessTestSuite.test("SequentialKeyPathWritesDontOverlap") {
let getF = \ClassWithStoredProperty.f
let c = ClassWithStoredProperty()
c[keyPath: getF] = 7
c[keyPath: getF] = 8 // no-trap
c[keyPath: getF] += c[keyPath: getF] // no-trap
}
ExclusiveAccessTestSuite.test("KeyPathInoutKeyPathWriteClassStoredProp")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a modification) started at")
.code
{
let getF = \ClassWithStoredProperty.f
let c = ClassWithStoredProperty()
expectCrashLater()
modifyAndPerform(&c[keyPath: getF]) {
c[keyPath: getF] = 12
}
}
ExclusiveAccessTestSuite.test("KeyPathInoutKeyPathReadClassStoredProp")
.skip(.custom(
{ _isFastAssertConfiguration() },
reason: "this trap is not guaranteed to happen in -Ounchecked"))
.crashOutputMatches("Previous access (a modification) started at")
.crashOutputMatches("Current access (a read) started at")
.code
{
let getF = \ClassWithStoredProperty.f
let c = ClassWithStoredProperty()
expectCrashLater()
modifyAndPerform(&c[keyPath: getF]) {
let y = c[keyPath: getF]
_blackHole(y)
}
}
// <rdar://problem/43076947> [Exclusivity] improve diagnostics for
// withoutActuallyEscaping.
ExclusiveAccessTestSuite.test("withoutActuallyEscapingConflict") {
var localVal = 0
let nestedModify = { localVal = 3 }
withoutActuallyEscaping(nestedModify) {
expectCrashLater()
modifyAndPerform(&localVal, closure: $0)
}
}
ExclusiveAccessTestSuite.test("directlyAppliedConflict") {
var localVal = 0
let nestedModify = { localVal = 3 }
expectCrashLater()
_ = {
modifyAndPerform(&localVal, closure: nestedModify)
}()
}
// <rdar://problem/43122715> [Exclusivity] failure to diagnose
// escaping closures called within directly applied noescape closures.
ExclusiveAccessTestSuite.test("directlyAppliedEscapingConflict") {
var localVal = 0
let nestedModify = { localVal = 3 }
expectCrashLater()
_ = {
modifyAndPerformEscaping(&localVal, closure: nestedModify)
}()
}
// rdar://102056143 - recursive locals inside a mutating method
// effectively capture self as inout even if they don't modify
// self. This should not trigger a runtime trap.
struct RecursiveLocalDuringMutation {
var flag: Bool = false
mutating func update() {
func local1(_ done: Bool) -> Bool {
if !done {
return local2()
}
return flag
}
func local2() -> Bool {
return local1(true)
}
flag = !local1(false)
}
}
ExclusiveAccessTestSuite.test("recursiveLocalDuringMutation") {
var v = RecursiveLocalDuringMutation()
v.update()
_blackHole(v.flag)
}
// rdar://102056143 - negative test. Make sure we still catch true
// violations on recursive captures.
struct RecursiveCaptureViolation {
func testBadness() -> Bool {
var flag = false
func local1(_ x: inout Bool) {
if !flag {
x = true
local2()
}
}
func local2() {
local1(&flag)
}
local2()
return flag
}
}
ExclusiveAccessTestSuite.test("recursiveCaptureViolation") {
var s = RecursiveCaptureViolation()
expectCrashLater()
s.testBadness()
_blackHole(s)
}
runAllTests()
|