1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730
|
// RUN: %target-swift-frontend -emit-sil -primary-file %s -o /dev/null -verify
//
// Tests for yield-once diagnostics emitted for generalized accessors.
struct TestNoYield {
var computed: Int {
_read {
} // expected-error {{accessor must yield before returning}}
_modify {
} // expected-error {{accessor must yield before returning}}
}
}
struct TestReturnPathWithoutYield {
var stored: Int
var flag: Bool
var computed: Int {
mutating _read {
if flag { // expected-note {{missing yield when the condition is false}}
yield stored
}
flag = true
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
// Diagnostics should attach a note to the earliest conflicting branch.
if flag { // expected-note {{missing yield when the condition is false}}
yield &stored
}
if !flag {
flag = true
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestIfElseWithoutYield {
var stored: Int
var flag: Bool
var computed: Int {
mutating _read {
if flag { // expected-note {{missing yield when the condition is false}}
yield stored
} else {
flag = true
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
if flag { // expected-note {{missing yield when the condition is true}}
flag = true
} else {
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestNestedIfs {
var stored: Int
var flag: Bool
// Diagnostics should attach a note to the innermost conflicting branch, which
// is the point of first conflict.
var computed: Int {
_read {
if flag {
if stored > 0 { // expected-note {{missing yield when the condition is false}}
yield stored
}
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
if flag {
if stored > 0 { // expected-note {{missing yield when the condition is true}}
} else {
yield &stored
}
}
flag = true
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestMultipleYields {
var stored: Int
var flag: Bool
var computed: Int {
_read {
if flag {
yield stored // expected-note {{previous yield was here}}
}
yield stored // expected-error {{accessor must not yield more than once}}
}
_modify {
yield &stored // expected-note {{previous yield was here}}
if flag {
yield &stored // expected-error {{accessor must not yield more than once}}
}
}
}
}
struct TestMultipleYields2 {
var stored: Int
var flag: Bool
var computed: Int {
_read {
if flag {
yield stored
return
}
yield stored
}
_modify {
if flag {
yield &stored
} else {
yield &stored
}
}
}
}
struct TestConvolutedPaths {
var flag: Bool
var stored : Int
var computed: Int {
_read {
if flag {
yield stored // expected-note {{previous yield was here}}
}
if !flag {
yield stored // expected-error {{accessor must not yield more than once}}
}
}
_modify {
if flag {
yield &stored // expected-note {{previous yield was here}}
}
if !flag {
yield &stored // expected-error {{accessor must not yield more than once}}
}
}
}
}
struct TestYieldInLoops {
var stored: Int
var count: Int
var computed: Int {
_read {
for _ in 0..<count {
yield stored // expected-error {{accessor must not yield more than once}}
// expected-note@-1 {{previous yield was here}}
}
}
_modify {
yield &stored // expected-note {{previous yield was here}}
for _ in 0..<count {
yield &stored // expected-error {{accessor must not yield more than once}}
}
}
}
}
enum CompassPoint {
case north
case south
case east
case west
}
struct TestYieldInSwitch {
var stored: Int
var cp: CompassPoint
var computed: Int {
get { return stored }
_modify {
switch cp {
case .north:
yield &stored
case .south:
stored = 10
case .east:
yield &stored
case .west:
stored = 12 // expected-note {{missing yield in the 'west' case}}
}
cp = .north
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestYieldInSwitchWithFallThrough {
var stored: Int
var cp: CompassPoint
var computed: Int {
_read {
switch cp {
case .north:
fallthrough
case .south:
fallthrough
case .east:
fallthrough
case .west:
yield stored
}
}
_modify {
switch cp {
case .north:
fallthrough
case .south:
yield &stored
case .east:
fallthrough // expected-note {{missing yield in the 'east' case}}
case .west:
stored = 12
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestYieldInSwitchWithoutCaseNames {
var stored: Int
var cp: CompassPoint
var computed: Int {
_read {
switch cp {
case .north:
yield stored
case _:
break // expected-note {{missing yield in this case}}
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
switch cp {
case .north:
yield &stored
case _ where stored < 0: // expected-note {{missing yield in this case}}
stored = 12
case .south:
fallthrough
case .east:
fallthrough
case .west:
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
var computed2: Int {
_read {
switch cp {
case .north:
yield stored
case _ where stored < 0: // expected-note {{missing yield when the condition is false}}
yield stored
default:
break
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
switch cp {
case .north:
yield &stored
case _ where stored < 0: // expected-note {{missing yield in this case}}
break
default:
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
var computed3: Int {
_read {
switch cp {
case .north:
yield stored
case _ where stored < 0: // expected-note {{missing yield in this case}}
break
case .south:
fallthrough
case .east:
yield stored
case .west:
break
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
switch cp {
case .north:
break
case _ where stored < 0: // expected-note {{missing yield when the condition is true}}
break
default:
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestExplicitReturn {
var stored: Int
var flag: Bool
var computed: Int {
mutating _read {
if stored > 0 { // expected-note {{missing yield when the condition is true}}
return
}
if flag {
yield stored
} else {
yield stored
}
flag = true
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
if stored > 0 {
return
}
if stored == 0 { // expected-note {{missing yield when the condition is false}}
if flag {
yield &stored
} else {
yield &stored
}
return
}
flag = true
} // expected-error {{accessor must yield on all paths before returning}}
}
var anotherProp: Int {
mutating _read {
if flag {
stored = 2
}
return; // expected-error {{accessor must yield before returning}}
if !flag { // expected-warning {{code after 'return' will never be executed}}
stored = 3
}
}
}
}
struct TestYieldsInGuards {
var storedOpt: Int?
var defaultStorage: Int
var computed: Int {
_read {
guard let stored = storedOpt else {
yield defaultStorage
return
}
yield stored
}
}
}
struct TestYieldsInGuards2 {
var flag: Bool
var defaultStorage: Int
var computed: Int {
_read {
guard flag else { // expected-note {{missing yield when the condition is false}}
return
}
yield defaultStorage
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
guard flag else { // expected-note {{missing yield when the condition is true}}
yield &defaultStorage
return
}
defaultStorage += 1
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestYieldsInLetPatterns {
var storedOpt: Int?
var defaultStorage: Int
var computed: Int {
_read {
if let stored = storedOpt { // expected-note {{missing yield in the nil case}}
yield stored
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
if var stored = storedOpt { // expected-note {{missing yield in the non-nil case}}
stored += 1
return
}
yield &defaultStorage
} // expected-error {{accessor must yield on all paths before returning}}
}
enum Either<L, R> {
case left(L)
case right(R)
}
var intOrBool: Either<Int, Bool>
var computed2: Int {
_read {
if case .left(let x) = intOrBool { // expected-note {{missing yield in the 'right' case}}
yield x
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
guard let stored = storedOpt else { // expected-note {{missing yield in the non-nil case}}
yield &defaultStorage
return
}
storedOpt = stored + 1
} // expected-error {{accessor must yield on all paths before returning}}
}
var cp: CompassPoint
var computed3: Int {
_read {
if case .north = cp { // expected-note {{missing yield in this case}}
yield 0
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
enum SoftError : Error {
case Ignorable
}
func aThrowingFunction() throws {
throw SoftError.Ignorable
}
struct TestYieldInDoCatch {
var stored: Int
var computed: Int {
_read {
do {
try aThrowingFunction()
yield stored
} catch {
yield stored
}
}
}
}
struct TestYieldInDoCatch2 {
var stored: Int
var computed: Int {
_read {
do {
try aThrowingFunction() // expected-note {{missing yield when error is thrown}}
yield stored
} catch {
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
do {
try aThrowingFunction() // expected-note {{missing yield when error is not thrown}}
}
catch {
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
enum Binary {
case one
case two
}
struct TestMultipleTries {
var stored: Int
var computed: Int {
_read {
do {
try aThrowingFunction()
yield stored // expected-note {{previous yield was here}}
try aThrowingFunction()
yield stored // expected-error {{accessor must not yield more than once}}
} catch {
}
}
_modify {
do {
try aThrowingFunction()
yield &stored
try aThrowingFunction() // expected-note {{missing yield when error is thrown}}
}
catch {
}
} // expected-error {{accessor must yield on all paths before returning}}
}
var flag: Bool
var bin: Binary
var computed2: Int {
_read {
do {
if flag {
try aThrowingFunction()
} else {
try aThrowingFunction() // expected-note {{missing yield when error is thrown}}
}
yield stored
} catch {
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
do {
switch bin {
case .one:
try aThrowingFunction()
yield &stored
case .two:
try aThrowingFunction() // expected-note {{missing yield when error is thrown}}
yield &stored
}
} catch {
}
} // expected-error {{accessor must yield on all paths before returning}}
}
var computed3: Int {
_read {
do {
if flag {
try aThrowingFunction()
} else {
try aThrowingFunction() // expected-note {{missing yield when error is not thrown}}
}
} catch {
yield stored
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
do {
switch bin {
case .one:
try aThrowingFunction()
case .two:
try aThrowingFunction() // expected-note {{missing yield when error is not thrown}}
}
} catch {
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestMultipleCatches {
enum NumError: Error {
case One
case Two
case Three
}
var stored: Int
var computed: Int {
_read {
// This is a very interesting test, where the error is on the try.
// It could have been better if it is on the switch case in the
// error case.
do {
try aThrowingFunction() // expected-note {{missing yield when error is thrown}}
yield stored
} catch NumError.One {
yield stored
} catch NumError.Two {
yield stored
} catch NumError.Three {
} catch {
yield stored
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
do {
try aThrowingFunction() // expected-note {{missing yield when error is not thrown}}
} catch NumError.One {
yield &stored
} catch NumError.Two {
yield &stored
} catch NumError.Three {
} catch {
yield &stored
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
// Test for labeled breaks.
struct TestYieldWithLabeledBreaks {
var stored: Int
var flag: Bool
var bin: Binary
var computed: Int {
_read {
ifstmt: if flag {
switch bin {
case .one:
yield stored
case .two:
break ifstmt // expected-note {{missing yield in the 'two' case}}
}
}
} // expected-error {{accessor must yield on all paths before returning}}
_modify {
loop: while flag {
switch bin {
case .one:
yield &stored // expected-error {{accessor must not yield more than once}}
// expected-note@-1 {{previous yield was here}}
case .two:
break loop
}
}
}
}
}
// Test switches over non-enum values.
struct TestYieldInSwitchWhere {
var stored: Int
var computed: Int {
_read {
switch stored {
case let x where x > 0:
yield stored
case let x where x < 0: // expected-note {{missing yield when the condition is true}}
return
default:
yield 3
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestYieldInSwitchValue {
var stored: Bool
var computed: Int {
_read {
switch stored {
case true:
yield 0
case false:
return // expected-note {{missing yield in the 2nd case}}
}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestYieldInSwitchEnumAddr<T> {
var storedOpt: T?
var computed: T {
_read {
if let stored = storedOpt {
yield stored
} // expected-note {{missing yield in the nil case}}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
// Test checked casts.
struct TestYieldInCheckedCast<T> {
var stored: T
var computed: Int {
_read {
if let x = (stored as? Int) {
yield x
} // expected-note {{missing yield in the nil case}}
} // expected-error {{accessor must yield on all paths before returning}}
}
}
struct TestYieldInForcedUnwrappingt<T> {
var stored: T?
var computed: T {
_read {
yield stored!
}
}
}
|