1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
// REQUIRES: concurrency
// RUN: %empty-directory(%t)
func simpleWithError(completion: @escaping (String?, Error?) -> Void) {}
func simpleWithError() async throws -> String {}
func testPathClassification() async throws {
// Both of these test cases should produce the same refactoring.
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=ELSE-IF-CLASSIFICATION %s
simpleWithError { str, err in
if err == nil {
print("a")
} else if .random() {
print("b")
} else {
print("c")
}
if err != nil {
print("d")
} else if .random() {
print("e")
} else {
print("f")
}
}
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=ELSE-IF-CLASSIFICATION %s
simpleWithError { str, err in
if let str = str {
print("a")
} else if .random() {
print("b")
} else {
print("c")
}
if str == nil {
print("d")
} else if .random() {
print("e")
} else {
print("f")
}
}
// ELSE-IF-CLASSIFICATION: do {
// ELSE-IF-CLASSIFICATION-NEXT: let str = try await simpleWithError()
// ELSE-IF-CLASSIFICATION-NEXT: print("a")
// ELSE-IF-CLASSIFICATION-NEXT: if .random() {
// ELSE-IF-CLASSIFICATION-NEXT: print("e")
// ELSE-IF-CLASSIFICATION-NEXT: } else {
// ELSE-IF-CLASSIFICATION-NEXT: print("f")
// ELSE-IF-CLASSIFICATION-NEXT: }
// ELSE-IF-CLASSIFICATION-NEXT: } catch let err {
// ELSE-IF-CLASSIFICATION-NEXT: if .random() {
// ELSE-IF-CLASSIFICATION-NEXT: print("b")
// ELSE-IF-CLASSIFICATION-NEXT: } else {
// ELSE-IF-CLASSIFICATION-NEXT: print("c")
// ELSE-IF-CLASSIFICATION-NEXT: }
// ELSE-IF-CLASSIFICATION-NEXT: print("d")
// ELSE-IF-CLASSIFICATION-NEXT: }
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=ELSE-IF-CLASSIFICATION2 %s
simpleWithError { str, err in
if err == nil {
print("a")
} else if .random() {
print("b")
}
if .random() {
print("c")
}
if err != nil, .random() {
print("d")
}
}
// Make sure the classification of 'b' into the error block doesn't affect the
// handling of 'c'.
// ELSE-IF-CLASSIFICATION2: do {
// ELSE-IF-CLASSIFICATION2-NEXT: let str = try await simpleWithError()
// ELSE-IF-CLASSIFICATION2-NEXT: print("a")
// ELSE-IF-CLASSIFICATION2-NEXT: if .random() {
// ELSE-IF-CLASSIFICATION2-NEXT: print("c")
// ELSE-IF-CLASSIFICATION2-NEXT: }
// ELSE-IF-CLASSIFICATION2-NEXT: } catch let err {
// ELSE-IF-CLASSIFICATION2-NEXT: if .random() {
// ELSE-IF-CLASSIFICATION2-NEXT: print("b")
// ELSE-IF-CLASSIFICATION2-NEXT: }
// ELSE-IF-CLASSIFICATION2-NEXT: if <#err#> != nil, .random() {
// ELSE-IF-CLASSIFICATION2-NEXT: print("d")
// ELSE-IF-CLASSIFICATION2-NEXT: }
// ELSE-IF-CLASSIFICATION2-NEXT: }
// FIXME: This case is a little tricky: Being in the else block of 'err == nil'
// should allow us to place 'if let str = str' in the failure block. However, this
// is a success condition, so we still place it in the success block. Really what
// we need to do here is check to see if simpleWithError has an existing async
// alternative that still returns optional success values, and allow success
// classification in that case. Otherwise, we'd probably be better off leaving
// the condition unhandled, as it's not clear what the user is doing.
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=ELSE-IF-CLASSIFICATION3 %s
simpleWithError { str, err in
if err == nil {
print("a")
} else if let str = str {
print("b")
} else {
print("c")
}
}
// ELSE-IF-CLASSIFICATION3: do {
// ELSE-IF-CLASSIFICATION3-NEXT: let str = try await simpleWithError()
// ELSE-IF-CLASSIFICATION3-NEXT: print("a")
// ELSE-IF-CLASSIFICATION3-NEXT: print("b")
// ELSE-IF-CLASSIFICATION3-NEXT: } catch let err {
// ELSE-IF-CLASSIFICATION3-NEXT: print("c")
// ELSE-IF-CLASSIFICATION3-NEXT: }
// FIXME: Similar to the case above.
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=ELSE-IF-CLASSIFICATION4 %s
simpleWithError { str, err in
if err == nil {
print("a")
} else if let str = str {
print("b")
} else if .random() {
print("c")
} else {
print("d")
}
}
// ELSE-IF-CLASSIFICATION4: do {
// ELSE-IF-CLASSIFICATION4-NEXT: let str = try await simpleWithError()
// ELSE-IF-CLASSIFICATION4-NEXT: print("a")
// ELSE-IF-CLASSIFICATION4-NEXT: print("b")
// ELSE-IF-CLASSIFICATION4-NEXT: } catch let err {
// ELSE-IF-CLASSIFICATION4-NEXT: if .random() {
// ELSE-IF-CLASSIFICATION4-NEXT: print("c")
// ELSE-IF-CLASSIFICATION4-NEXT: } else {
// ELSE-IF-CLASSIFICATION4-NEXT: print("d")
// ELSE-IF-CLASSIFICATION4-NEXT: }
// ELSE-IF-CLASSIFICATION4-NEXT: }
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=ELSE-IF-CLASSIFICATION5 %s
simpleWithError { str, err in
if let err = err {
print("a")
} else if let str = str {
print("b")
return
} else if .random() {
print("c")
} else {
print("d")
}
}
// ELSE-IF-CLASSIFICATION5: do {
// ELSE-IF-CLASSIFICATION5-NEXT: let str = try await simpleWithError()
// ELSE-IF-CLASSIFICATION5-NEXT: print("b")
// ELSE-IF-CLASSIFICATION5-NEXT: } catch let err {
// ELSE-IF-CLASSIFICATION5-NEXT: print("a")
// ELSE-IF-CLASSIFICATION5-NEXT: if .random() {
// ELSE-IF-CLASSIFICATION5-NEXT: print("c")
// ELSE-IF-CLASSIFICATION5-NEXT: } else {
// ELSE-IF-CLASSIFICATION5-NEXT: print("d")
// ELSE-IF-CLASSIFICATION5-NEXT: }
// ELSE-IF-CLASSIFICATION5-NEXT: }
// Cannot use refactor-check-compiles, as 'err' cannot have its type inferred
// from placeholder.
// RUN: %refactor -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=IF-LET-RETURN-CLASSIFICATION %s
simpleWithError { str, err in
if let str = str {
print("a")
return
}
if .random(), let err = err {
print("b")
} else {
print("c")
}
}
// IF-LET-RETURN-CLASSIFICATION: do {
// IF-LET-RETURN-CLASSIFICATION-NEXT: let str = try await simpleWithError()
// IF-LET-RETURN-CLASSIFICATION-NEXT: print("a")
// IF-LET-RETURN-CLASSIFICATION-NEXT: } catch let err {
// IF-LET-RETURN-CLASSIFICATION-NEXT: if .random(), let err = <#err#> {
// IF-LET-RETURN-CLASSIFICATION-NEXT: print("b")
// IF-LET-RETURN-CLASSIFICATION-NEXT: } else {
// IF-LET-RETURN-CLASSIFICATION-NEXT: print("c")
// IF-LET-RETURN-CLASSIFICATION-NEXT: }
// IF-LET-RETURN-CLASSIFICATION-NEXT: }
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=GUARD-CLASSIFICATION %s
simpleWithError { str, err in
guard let str = str else {
print("a")
return
}
guard err == nil, .random() else {
print("b")
return
}
print("c")
}
// GUARD-CLASSIFICATION: do {
// GUARD-CLASSIFICATION-NEXT: let str = try await simpleWithError()
// GUARD-CLASSIFICATION-NEXT: guard <#err#> == nil, .random() else {
// GUARD-CLASSIFICATION-NEXT: print("b")
// GUARD-CLASSIFICATION-NEXT: <#return#>
// GUARD-CLASSIFICATION-NEXT: }
// GUARD-CLASSIFICATION-NEXT: print("c")
// GUARD-CLASSIFICATION-NEXT: } catch let err {
// GUARD-CLASSIFICATION-NEXT: print("a")
// GUARD-CLASSIFICATION-NEXT: }
// RUN: %refactor-check-compiles -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=SILLY-CLASSIFICATION %s
simpleWithError { str, err in
guard let str = str else { return }
guard let err = err else { return }
print("urr")
}
// In this case we just take whichever guard is last.
// SILLY-CLASSIFICATION: do {
// SILLY-CLASSIFICATION-NEXT: let str = try await simpleWithError()
// SILLY-CLASSIFICATION-NEXT: } catch let err {
// SILLY-CLASSIFICATION-NEXT: print("urr")
// SILLY-CLASSIFICATION-NEXT: }
}
|
