1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246
|
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift open source project
//
// Copyright (c) 2014-2022 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See http://swift.org/LICENSE.txt for license information
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import ArgumentParser
import Basics
import CoreCommands
import Dispatch
import PackageGraph
import PackageModel
import SourceControl
struct DeprecatedAPIDiff: ParsableCommand {
static let configuration = CommandConfiguration(commandName: "experimental-api-diff",
abstract: "Deprecated - use `swift package diagnose-api-breaking-changes` instead",
shouldDisplay: false)
@Argument(parsing: .captureForPassthrough)
var args: [String] = []
func run() throws {
print("`swift package experimental-api-diff` has been renamed to `swift package diagnose-api-breaking-changes`")
throw ExitCode.failure
}
}
struct APIDiff: SwiftCommand {
static let configuration = CommandConfiguration(
commandName: "diagnose-api-breaking-changes",
abstract: "Diagnose API-breaking changes to Swift modules in a package",
discussion: """
The diagnose-api-breaking-changes command can be used to compare the Swift API of \
a package to a baseline revision, diagnosing any breaking changes which have \
been introduced. By default, it compares every Swift module from the baseline \
revision which is part of a library product. For packages with many targets, this \
behavior may be undesirable as the comparison can be slow. \
The `--products` and `--targets` options may be used to restrict the scope of \
the comparison.
""")
@OptionGroup(visibility: .hidden)
var globalOptions: GlobalOptions
@Option(help: """
The path to a text file containing breaking changes which should be ignored by the API comparison. \
Each ignored breaking change in the file should appear on its own line and contain the exact message \
to be ignored (e.g. 'API breakage: func foo() has been removed').
""")
var breakageAllowlistPath: AbsolutePath?
@Argument(help: "The baseline treeish to compare to (e.g. a commit hash, branch name, tag, etc.)")
var treeish: String
@Option(parsing: .upToNextOption,
help: "One or more products to include in the API comparison. If present, only the specified products (and any targets specified using `--targets`) will be compared.")
var products: [String] = []
@Option(parsing: .upToNextOption,
help: "One or more targets to include in the API comparison. If present, only the specified targets (and any products specified using `--products`) will be compared.")
var targets: [String] = []
@Option(name: .customLong("baseline-dir"),
help: "The path to a directory used to store API baseline files. If unspecified, a temporary directory will be used.")
var overrideBaselineDir: AbsolutePath?
@Flag(help: "Regenerate the API baseline, even if an existing one is available.")
var regenerateBaseline: Bool = false
func run(_ swiftCommandState: SwiftCommandState) throws {
let apiDigesterPath = try swiftCommandState.getTargetToolchain().getSwiftAPIDigester()
let apiDigesterTool = SwiftAPIDigester(fileSystem: swiftCommandState.fileSystem, tool: apiDigesterPath)
let packageRoot = try globalOptions.locations.packageDirectory ?? swiftCommandState.getPackageRoot()
let repository = GitRepository(path: packageRoot)
let baselineRevision = try repository.resolveRevision(identifier: treeish)
// We turn build manifest caching off because we need the build plan.
let buildSystem = try swiftCommandState.createBuildSystem(explicitBuildSystem: .native, cacheBuildManifest: false)
let packageGraph = try buildSystem.getPackageGraph()
let modulesToDiff = try determineModulesToDiff(
packageGraph: packageGraph,
observabilityScope: swiftCommandState.observabilityScope
)
// Build the current package.
try buildSystem.build()
// Dump JSON for the baseline package.
let baselineDumper = try APIDigesterBaselineDumper(
baselineRevision: baselineRevision,
packageRoot: swiftCommandState.getPackageRoot(),
productsBuildParameters: try buildSystem.buildPlan.destinationBuildParameters,
toolsBuildParameters: try buildSystem.buildPlan.toolsBuildParameters,
apiDigesterTool: apiDigesterTool,
observabilityScope: swiftCommandState.observabilityScope
)
let baselineDir = try baselineDumper.emitAPIBaseline(
for: modulesToDiff,
at: overrideBaselineDir,
force: regenerateBaseline,
logLevel: swiftCommandState.logLevel,
swiftCommandState: swiftCommandState
)
let results = ThreadSafeArrayStore<SwiftAPIDigester.ComparisonResult>()
let group = DispatchGroup()
let semaphore = DispatchSemaphore(value: Int(try buildSystem.buildPlan.destinationBuildParameters.workers))
var skippedModules: Set<String> = []
for module in modulesToDiff {
let moduleBaselinePath = baselineDir.appending("\(module).json")
guard swiftCommandState.fileSystem.exists(moduleBaselinePath) else {
print("\nSkipping \(module) because it does not exist in the baseline")
skippedModules.insert(module)
continue
}
semaphore.wait()
DispatchQueue.sharedConcurrent.async(group: group) {
do {
if let comparisonResult = try apiDigesterTool.compareAPIToBaseline(
at: moduleBaselinePath,
for: module,
buildPlan: try buildSystem.buildPlan,
except: breakageAllowlistPath
) {
results.append(comparisonResult)
}
} catch {
swiftCommandState.observabilityScope.emit(error: "failed to compare API to baseline", underlyingError: error)
}
semaphore.signal()
}
}
group.wait()
let failedModules = modulesToDiff
.subtracting(skippedModules)
.subtracting(results.map(\.moduleName))
for failedModule in failedModules {
swiftCommandState.observabilityScope.emit(error: "failed to read API digester output for \(failedModule)")
}
for result in results.get() {
try self.printComparisonResult(result, observabilityScope: swiftCommandState.observabilityScope)
}
guard failedModules.isEmpty && results.get().allSatisfy(\.hasNoAPIBreakingChanges) else {
throw ExitCode.failure
}
}
private func determineModulesToDiff(packageGraph: ModulesGraph, observabilityScope: ObservabilityScope) throws -> Set<String> {
var modulesToDiff: Set<String> = []
if products.isEmpty && targets.isEmpty {
modulesToDiff.formUnion(packageGraph.apiDigesterModules)
} else {
for productName in products {
guard let product = packageGraph
.rootPackages
.flatMap(\.products)
.first(where: { $0.name == productName }) else {
observabilityScope.emit(error: "no such product '\(productName)'")
continue
}
guard product.type.isLibrary else {
observabilityScope.emit(error: "'\(productName)' is not a library product")
continue
}
modulesToDiff.formUnion(product.modules.filter { $0.underlying is SwiftModule }.map(\.c99name))
}
for targetName in targets {
guard let target = packageGraph
.rootPackages
.flatMap(\.modules)
.first(where: { $0.name == targetName }) else {
observabilityScope.emit(error: "no such target '\(targetName)'")
continue
}
guard target.type == .library else {
observabilityScope.emit(error: "'\(targetName)' is not a library target")
continue
}
guard target.underlying is SwiftModule else {
observabilityScope.emit(error: "'\(targetName)' is not a Swift language target")
continue
}
modulesToDiff.insert(target.c99name)
}
guard !observabilityScope.errorsReported else {
throw ExitCode.failure
}
}
return modulesToDiff
}
private func printComparisonResult(
_ comparisonResult: SwiftAPIDigester.ComparisonResult,
observabilityScope: ObservabilityScope
) throws {
for diagnostic in comparisonResult.otherDiagnostics {
let metadata = try diagnostic.location.map { location -> ObservabilityMetadata in
var metadata = ObservabilityMetadata()
metadata.fileLocation = .init(
try .init(validating: location.filename),
line: location.line < Int.max ? Int(location.line) : .none
)
return metadata
}
switch diagnostic.level {
case .error, .fatal:
observabilityScope.emit(error: diagnostic.text, metadata: metadata)
case .warning:
observabilityScope.emit(warning: diagnostic.text, metadata: metadata)
case .note:
observabilityScope.emit(info: diagnostic.text, metadata: metadata)
case .remark:
observabilityScope.emit(info: diagnostic.text, metadata: metadata)
case .ignored:
break
}
}
let moduleName = comparisonResult.moduleName
if comparisonResult.apiBreakingChanges.isEmpty {
print("\nNo breaking changes detected in \(moduleName)")
} else {
let count = comparisonResult.apiBreakingChanges.count
print("\n\(count) breaking \(count > 1 ? "changes" : "change") detected in \(moduleName):")
for change in comparisonResult.apiBreakingChanges {
print(" 💔 \(change.text)")
}
}
}
}
|