1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
|
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift open source project
//
// Copyright (c) 2014-2023 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See http://swift.org/LICENSE.txt for license information
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import Basics
import OrderedCollections
import PackageLoading
import PackageModel
import struct TSCBasic.KeyedPair
import func TSCBasic.bestMatch
import func TSCBasic.findCycle
extension ModulesGraph {
/// Load the package graph for the given package path.
public static func load(
root: PackageGraphRoot,
identityResolver: IdentityResolver,
additionalFileRules: [FileRuleDescription] = [],
externalManifests: OrderedCollections.OrderedDictionary<PackageIdentity, (manifest: Manifest, fs: FileSystem)>,
requiredDependencies: [PackageReference] = [],
unsafeAllowedPackages: Set<PackageReference> = [],
binaryArtifacts: [PackageIdentity: [String: BinaryArtifact]],
shouldCreateMultipleTestProducts: Bool = false,
createREPLProduct: Bool = false,
customPlatformsRegistry: PlatformRegistry? = .none,
customXCTestMinimumDeploymentTargets: [PackageModel.Platform: PlatformVersion]? = .none,
testEntryPointPath: AbsolutePath? = nil,
fileSystem: FileSystem,
observabilityScope: ObservabilityScope,
productsFilter: ((Product) -> Bool)? = nil,
modulesFilter: ((Module) -> Bool)? = nil
) throws -> ModulesGraph {
let observabilityScope = observabilityScope.makeChildScope(description: "Loading Package Graph")
// Create a map of the manifests, keyed by their identity.
var manifestMap = externalManifests
// prefer roots
root.manifests.forEach {
manifestMap[$0.key] = ($0.value, fileSystem)
}
// Construct the root root dependencies set.
let rootDependencies = Set(root.dependencies.compactMap{
manifestMap[$0.identity]?.manifest
})
let rootManifestNodes = root.packages.map { identity, package in
GraphLoadingNode(identity: identity, manifest: package.manifest, productFilter: .everything)
}
let rootDependencyNodes = root.dependencies.lazy.compactMap { dependency in
manifestMap[dependency.identity].map {
GraphLoadingNode(
identity: dependency.identity,
manifest: $0.manifest,
productFilter: dependency.productFilter
)
}
}
let inputManifests = (rootManifestNodes + rootDependencyNodes).map {
KeyedPair($0, key: $0.id)
}
// Collect the manifests for which we are going to build packages.
var allNodes = [GraphLoadingNode]()
let nodeSuccessorProvider = { (node: KeyedPair<GraphLoadingNode, PackageIdentity>) in
node.item.requiredDependencies.compactMap { dependency in
manifestMap[dependency.identity].map { manifest, _ in
KeyedPair(
GraphLoadingNode(
identity: dependency.identity,
manifest: manifest,
productFilter: dependency.productFilter
),
key: dependency.identity
)
}
}
}
// Package dependency cycles feature is gated on tools version 6.0.
if !root.manifests.allSatisfy({ $1.toolsVersion >= .v6_0 }) {
if let cycle = findCycle(inputManifests, successors: nodeSuccessorProvider) {
let path = (cycle.path + cycle.cycle).map(\.item.manifest)
observabilityScope.emit(PackageGraphError.dependencyCycleDetected(
path: path, cycle: cycle.cycle[0].item.manifest
))
return try ModulesGraph(
rootPackages: [],
rootDependencies: [],
packages: IdentifiableSet(),
dependencies: requiredDependencies,
binaryArtifacts: binaryArtifacts
)
}
}
// Cycles in dependencies don't matter as long as there are no module cycles between packages.
depthFirstSearch(
inputManifests,
successors: nodeSuccessorProvider
) {
allNodes.append($0.item)
} onDuplicate: { _,_ in
// no de-duplication is required.
}
// sort by identity
allNodes = allNodes.sorted { $0.id < $1.id }
// Create the packages.
var manifestToPackage: [Manifest: Package] = [:]
for node in allNodes {
let nodeObservabilityScope = observabilityScope.makeChildScope(
description: "loading package \(node.identity)",
metadata: .packageMetadata(identity: node.identity, kind: node.manifest.packageKind)
)
let manifest = node.manifest
// Derive the path to the package.
//
// FIXME: Lift this out of the manifest.
let packagePath = manifest.path.parentDirectory
nodeObservabilityScope.trap {
// Create a package from the manifest and sources.
let builder = PackageBuilder(
identity: node.identity,
manifest: manifest,
productFilter: node.productFilter,
path: packagePath,
additionalFileRules: additionalFileRules,
binaryArtifacts: binaryArtifacts[node.identity] ?? [:],
shouldCreateMultipleTestProducts: shouldCreateMultipleTestProducts,
testEntryPointPath: testEntryPointPath,
createREPLProduct: manifest.packageKind.isRoot ? createREPLProduct : false,
fileSystem: fileSystem,
observabilityScope: nodeObservabilityScope
)
let package = try builder.construct()
manifestToPackage[manifest] = package
// Throw if any of the non-root package is empty.
if package.modules.isEmpty // System packages have modules in the package but not the manifest.
&& package.manifest.targets.isEmpty // An unneeded dependency will not have loaded anything from the manifest.
&& !manifest.packageKind.isRoot {
throw PackageGraphError.noModules(package)
}
}
}
let platformVersionProvider: PlatformVersionProvider
if let customXCTestMinimumDeploymentTargets {
platformVersionProvider = .init(implementation: .customXCTestMinimumDeploymentTargets(customXCTestMinimumDeploymentTargets))
} else {
platformVersionProvider = .init(implementation: .minimumDeploymentTargetDefault)
}
// Resolve dependencies and create resolved packages.
let resolvedPackages = try createResolvedPackages(
nodes: allNodes,
identityResolver: identityResolver,
manifestToPackage: manifestToPackage,
rootManifests: root.manifests,
unsafeAllowedPackages: unsafeAllowedPackages,
platformRegistry: customPlatformsRegistry ?? .default,
platformVersionProvider: platformVersionProvider,
fileSystem: fileSystem,
observabilityScope: observabilityScope,
productsFilter: productsFilter,
modulesFilter: modulesFilter
)
let rootPackages = resolvedPackages.filter { root.manifests.values.contains($0.manifest) }
checkAllDependenciesAreUsed(packages: resolvedPackages, rootPackages, observabilityScope: observabilityScope)
return try ModulesGraph(
rootPackages: rootPackages,
rootDependencies: resolvedPackages.filter { rootDependencies.contains($0.manifest) },
packages: resolvedPackages,
dependencies: requiredDependencies,
binaryArtifacts: binaryArtifacts
)
}
}
private func checkAllDependenciesAreUsed(
packages: IdentifiableSet<ResolvedPackage>,
_ rootPackages: [ResolvedPackage],
observabilityScope: ObservabilityScope
) {
for package in rootPackages {
// List all dependency products dependent on by the package modules.
let productDependencies = IdentifiableSet(package.modules.flatMap { module in
return module.dependencies.compactMap { moduleDependency in
switch moduleDependency {
case .product(let product, _):
return product
case .module:
return nil
}
}
})
for dependencyId in package.dependencies {
guard let dependency = packages[dependencyId] else {
observabilityScope.emit(.error("Unknown package: \(dependencyId)"))
return
}
// We continue if the dependency contains executable products to make sure we don't
// warn on a valid use-case for a lone dependency: swift run dependency executables.
guard !dependency.products.contains(where: { $0.type == .executable }) else {
continue
}
// Skip this check if this dependency is a system module because system module packages
// have no products.
//
// FIXME: Do/should we print a warning if a dependency has no products?
if dependency.products.isEmpty && dependency.modules.filter({ $0.type == .systemModule }).count == 1 {
continue
}
// Skip this check if this dependency contains a command plugin product.
if dependency.products.contains(where: \.isCommandPlugin) {
continue
}
// Make sure that any diagnostics we emit below are associated with the package.
let packageDiagnosticsScope = observabilityScope.makeChildScope(
description: "Package Dependency Validation",
metadata: package.underlying.diagnosticsMetadata
)
// Otherwise emit a warning if none of the dependency package's products are used.
let dependencyIsUsed = dependency.products.contains { product in
// Don't compare by product ID, but by product name to make sure both build triples as properties of
// `ResolvedProduct.ID` are allowed.
productDependencies.contains { $0.name == product.name }
}
if !dependencyIsUsed && !observabilityScope.errorsReportedInAnyScope {
packageDiagnosticsScope.emit(.unusedDependency(dependency.identity.description))
}
}
}
}
fileprivate extension ResolvedProduct {
/// Returns true if and only if the product represents a command plugin module.
var isCommandPlugin: Bool {
guard type == .plugin else { return false }
guard let module = underlying.modules.compactMap({ $0 as? PluginModule }).first else { return false }
guard case .command = module.capability else { return false }
return true
}
}
/// Create resolved packages from the loaded packages.
private func createResolvedPackages(
nodes: [GraphLoadingNode],
identityResolver: IdentityResolver,
manifestToPackage: [Manifest: Package],
// FIXME: This shouldn't be needed once <rdar://problem/33693433> is fixed.
rootManifests: [PackageIdentity: Manifest],
unsafeAllowedPackages: Set<PackageReference>,
platformRegistry: PlatformRegistry,
platformVersionProvider: PlatformVersionProvider,
fileSystem: FileSystem,
observabilityScope: ObservabilityScope,
productsFilter: ((Product) -> Bool)?,
modulesFilter: ((Module) -> Bool)?
) throws -> IdentifiableSet<ResolvedPackage> {
// Create package builder objects from the input manifests.
let packageBuilders: [ResolvedPackageBuilder] = nodes.compactMap{ node in
guard let package = manifestToPackage[node.manifest] else {
return nil
}
let isAllowedToVendUnsafeProducts = unsafeAllowedPackages.contains{ $0.identity == package.identity }
let allowedToOverride = rootManifests.values.contains(node.manifest)
return ResolvedPackageBuilder(
package,
productFilter: node.productFilter,
isAllowedToVendUnsafeProducts: isAllowedToVendUnsafeProducts,
allowedToOverride: allowedToOverride,
platformVersionProvider: platformVersionProvider
)
}
// Create a map of package builders keyed by the package identity.
// This is guaranteed to be unique so we can use spm_createDictionary
let packagesByIdentity: [PackageIdentity: ResolvedPackageBuilder] = packageBuilders.spm_createDictionary{
return ($0.package.identity, $0)
}
// Resolve module aliases, if specified, for modules and their dependencies
// across packages. Aliasing will result in module renaming.
let moduleAliasingUsed = try resolveModuleAliases(
packageBuilders: packageBuilders,
observabilityScope: observabilityScope
)
// Scan and validate the dependencies
for packageBuilder in packageBuilders {
let package = packageBuilder.package
let packageObservabilityScope = observabilityScope.makeChildScope(
description: "Validating package dependencies",
metadata: package.diagnosticsMetadata
)
var dependencies = OrderedCollections.OrderedDictionary<PackageIdentity, ResolvedPackageBuilder>()
var dependenciesByNameForModuleDependencyResolution = [String: ResolvedPackageBuilder]()
var dependencyNamesForModuleDependencyResolutionOnly = [PackageIdentity: String]()
// Establish the manifest-declared package dependencies.
package.manifest.dependenciesRequired(for: packageBuilder.productFilter).forEach { dependency in
let dependencyPackageRef = dependency.packageRef
// Otherwise, look it up by its identity.
if let resolvedPackage = packagesByIdentity[dependency.identity] {
// check if this resolved package already listed in the dependencies
// this means that the dependencies share the same identity
// FIXME: this works but the way we find out about this is based on a side effect, need to improve it
guard dependencies[resolvedPackage.package.identity] == nil else {
let error = PackageGraphError.dependencyAlreadySatisfiedByIdentifier(
package: package.identity.description,
dependencyLocation: dependencyPackageRef.locationString,
otherDependencyURL: resolvedPackage.package.manifest.packageLocation,
identity: dependency.identity)
return packageObservabilityScope.emit(error)
}
// check if the resolved package location is the same as the dependency one
// if not, this means that the dependencies share the same identity
// which only allowed when overriding
if resolvedPackage.package.manifest.canonicalPackageLocation != dependencyPackageRef.canonicalLocation && !resolvedPackage.allowedToOverride {
let error = PackageGraphError.dependencyAlreadySatisfiedByIdentifier(
package: package.identity.description,
dependencyLocation: dependencyPackageRef.locationString,
otherDependencyURL: resolvedPackage.package.manifest.packageLocation,
identity: dependency.identity)
// 9/2021 this is currently emitting a warning only to support
// backwards compatibility with older versions of SwiftPM that had too weak of a validation
// we will upgrade this to an error in a few versions to tighten up the validation
if dependency.explicitNameForModuleDependencyResolutionOnly == .none ||
resolvedPackage.package.manifest.displayName == dependency.explicitNameForModuleDependencyResolutionOnly {
packageObservabilityScope.emit(warning: error.description + ". this will be escalated to an error in future versions of SwiftPM.")
} else {
return packageObservabilityScope.emit(error)
}
} else if resolvedPackage.package.manifest.canonicalPackageLocation == dependencyPackageRef.canonicalLocation &&
resolvedPackage.package.manifest.packageLocation != dependencyPackageRef.locationString &&
!resolvedPackage.allowedToOverride {
packageObservabilityScope.emit(info: "dependency on '\(resolvedPackage.package.identity)' is represented by similar locations ('\(resolvedPackage.package.manifest.packageLocation)' and '\(dependencyPackageRef.locationString)') which are treated as the same canonical location '\(dependencyPackageRef.canonicalLocation)'.")
}
// checks if two dependencies have the same explicit name which can cause module based dependency package lookup issue
if let explicitDependencyName = dependency.explicitNameForModuleDependencyResolutionOnly {
if let previouslyResolvedPackage = dependenciesByNameForModuleDependencyResolution[explicitDependencyName] {
let error = PackageGraphError.dependencyAlreadySatisfiedByName(
package: package.identity.description,
dependencyLocation: dependencyPackageRef.locationString,
otherDependencyURL: previouslyResolvedPackage.package.manifest.packageLocation,
name: explicitDependencyName)
return packageObservabilityScope.emit(error)
}
}
// checks if two dependencies have the same implicit (identity based) name which can cause module based dependency package lookup issue
if let previouslyResolvedPackage = dependenciesByNameForModuleDependencyResolution[dependency.identity.description] {
let error = PackageGraphError.dependencyAlreadySatisfiedByName(
package: package.identity.description,
dependencyLocation: dependencyPackageRef.locationString,
otherDependencyURL: previouslyResolvedPackage.package.manifest.packageLocation,
name: dependency.identity.description)
return packageObservabilityScope.emit(error)
}
let nameForModuleDependencyResolution = dependency.explicitNameForModuleDependencyResolutionOnly ?? dependency.identity.description
dependenciesByNameForModuleDependencyResolution[nameForModuleDependencyResolution] = resolvedPackage
dependencyNamesForModuleDependencyResolutionOnly[resolvedPackage.package.identity] = nameForModuleDependencyResolution
dependencies[resolvedPackage.package.identity] = resolvedPackage
}
}
packageBuilder.dependencies = Array(dependencies.values)
packageBuilder.dependencyNamesForModuleDependencyResolutionOnly = dependencyNamesForModuleDependencyResolutionOnly
packageBuilder.defaultLocalization = package.manifest.defaultLocalization
packageBuilder.supportedPlatforms = computePlatforms(
package: package,
platformRegistry: platformRegistry
)
// Create module builders for each module in the package.
let modules: [Module]
if let modulesFilter {
modules = package.modules.filter(modulesFilter)
} else {
modules = package.modules
}
let moduleBuilders = modules.map {
ResolvedModuleBuilder(
packageIdentity: package.identity,
module: $0,
observabilityScope: packageObservabilityScope,
platformVersionProvider: platformVersionProvider
)
}
packageBuilder.modules = moduleBuilders
// Establish dependencies between the modules. A module can only depend on another module present in the same package.
let modulesMap = moduleBuilders.spm_createDictionary({ ($0.module, $0) })
for moduleBuilder in moduleBuilders {
moduleBuilder.dependencies += try moduleBuilder.module.dependencies.compactMap { dependency in
switch dependency {
case .module(let moduleDependency, let conditions):
try moduleBuilder.module.validateDependency(module: moduleDependency)
guard let moduleBuilder = modulesMap[moduleDependency] else {
throw InternalError("unknown target \(moduleDependency.name)")
}
return .module(moduleBuilder, conditions: conditions)
case .product:
return nil
}
}
moduleBuilder.defaultLocalization = packageBuilder.defaultLocalization
moduleBuilder.supportedPlatforms = packageBuilder.supportedPlatforms
}
// Create product builders for each product in the package. A product can only contain a module present in the same package.
let products: [Product]
if let productsFilter {
products = package.products.filter(productsFilter)
} else {
products = package.products
}
packageBuilder.products = try products.map { product in
try ResolvedProductBuilder(product: product, packageBuilder: packageBuilder, moduleBuilders: product.modules.map {
guard let module = modulesMap[$0] else {
throw InternalError("unknown target \($0)")
}
return module
})
}
// add registry metadata if available
if fileSystem.exists(package.path.appending(component: RegistryReleaseMetadataStorage.fileName)) {
packageBuilder.registryMetadata = try RegistryReleaseMetadataStorage.load(
from: package.path.appending(component: RegistryReleaseMetadataStorage.fileName),
fileSystem: fileSystem
)
}
}
let dupProductsChecker = DuplicateProductsChecker(
packageBuilders: packageBuilders,
moduleAliasingUsed: moduleAliasingUsed,
observabilityScope: observabilityScope
)
try dupProductsChecker.run(lookupByProductIDs: moduleAliasingUsed, observabilityScope: observabilityScope)
// The set of all module names.
var allModuleNames = Set<String>()
// Track if multiple modules are found with the same name.
var foundDuplicateModule = false
for packageBuilder in packageBuilders {
for moduleBuilder in packageBuilder.modules {
// Record if we see a duplicate module.
foundDuplicateModule = foundDuplicateModule || !allModuleNames.insert(moduleBuilder.module.name).inserted
}
}
// Do another pass and establish product dependencies of each module.
for packageBuilder in packageBuilders {
let package = packageBuilder.package
let packageObservabilityScope = observabilityScope.makeChildScope(
description: "Validating package targets",
metadata: package.diagnosticsMetadata
)
// Get all implicit system library dependencies in this package.
let implicitSystemLibraryDeps = packageBuilder.dependencies
.flatMap(\.modules)
.filter({
if case let systemLibrary as SystemLibraryModule = $0.module {
return systemLibrary.isImplicit
}
return false
})
let packageDoesNotSupportProductAliases = packageBuilder.package.doesNotSupportProductAliases
let lookupByProductIDs = !packageDoesNotSupportProductAliases && (packageBuilder.package.manifest.disambiguateByProductIDs || moduleAliasingUsed)
// Get all the products from dependencies of this package.
let productDependencies = packageBuilder.dependencies
.flatMap({ (dependency: ResolvedPackageBuilder) -> [ResolvedProductBuilder] in
// Filter out synthesized products such as tests and implicit executables.
// Check if a dependency product is explicitly declared as a product in its package manifest
let manifestProducts = dependency.package.manifest.products.lazy.map { $0.name }
let explicitProducts = dependency.package.products.filter { manifestProducts.contains($0.name) }
let explicitIdsOrNames = Set(explicitProducts.lazy.map({ lookupByProductIDs ? $0.identity : $0.name }))
return dependency.products.filter({ lookupByProductIDs ? explicitIdsOrNames.contains($0.product.identity) : explicitIdsOrNames.contains($0.product.name) })
})
let productDependencyMap: [String: ResolvedProductBuilder]
if lookupByProductIDs {
productDependencyMap = try Dictionary(uniqueKeysWithValues: productDependencies.map {
guard let packageName = packageBuilder.dependencyNamesForModuleDependencyResolutionOnly[$0.packageBuilder.package.identity] else {
throw InternalError("could not determine name for dependency on package '\($0.packageBuilder.package.identity)' from package '\(packageBuilder.package.identity)'")
}
let key = "\(packageName.lowercased())_\($0.product.name)"
return (key, $0)
})
} else {
productDependencyMap = try Dictionary(
productDependencies.map { ($0.product.name, $0) },
uniquingKeysWith: { lhs, _ in
let duplicates = productDependencies.filter { $0.product.name == lhs.product.name }
throw emitDuplicateProductDiagnostic(
productName: lhs.product.name,
packages: duplicates.map(\.packageBuilder.package),
moduleAliasingUsed: moduleAliasingUsed,
observabilityScope: observabilityScope
)
}
)
}
// Establish dependencies in each module.
for moduleBuilder in packageBuilder.modules {
// Directly add all the system module dependencies.
moduleBuilder.dependencies += implicitSystemLibraryDeps.map { .module($0, conditions: []) }
// Establish product dependencies.
for case .product(let productRef, let conditions) in moduleBuilder.module.dependencies {
// Find the product in this package's dependency products.
// Look it up by ID if module aliasing is used, otherwise by name.
let product = lookupByProductIDs ? productDependencyMap[productRef.identity] : productDependencyMap[productRef.name]
guard let product else {
// Only emit a diagnostic if there are no other diagnostics.
// This avoids flooding the diagnostics with product not
// found errors when there are more important errors to
// resolve (like authentication issues).
if !observabilityScope.errorsReportedInAnyScope {
// Emit error if a product (not module) declared in the package is also a productRef (dependency)
let declProductsAsDependency = package.products.filter { product in
lookupByProductIDs ? product.identity == productRef.identity : product.name == productRef.name
}.map {$0.modules}.flatMap{$0}.filter { t in
t.name != productRef.name
}
// Find a product name from the available product dependencies that is most similar to the required product name.
let bestMatchedProductName = bestMatch(for: productRef.name, from: Array(allModuleNames))
var packageContainingBestMatchedProduct: String?
if let bestMatchedProductName, productRef.name == bestMatchedProductName {
let dependentPackages = packageBuilder.dependencies.map(\.package)
for p in dependentPackages where p.modules.contains(where: { $0.name == bestMatchedProductName }) {
packageContainingBestMatchedProduct = p.identity.description
break
}
}
let error = PackageGraphError.productDependencyNotFound(
package: package.identity.description,
moduleName: moduleBuilder.module.name,
dependencyProductName: productRef.name,
dependencyPackageName: productRef.package,
dependencyProductInDecl: !declProductsAsDependency.isEmpty,
similarProductName: bestMatchedProductName,
packageContainingSimilarProduct: packageContainingBestMatchedProduct
)
packageObservabilityScope.emit(error)
}
continue
}
// Starting in 5.2, and module-based dependency, we require module product dependencies to
// explicitly reference the package containing the product, or for the product, package and
// dependency to share the same name. We don't check this in manifest loading for root-packages so
// we can provide a more detailed diagnostic here.
if packageBuilder.package.manifest.toolsVersion >= .v5_2 && productRef.package == nil {
let referencedPackageIdentity = product.packageBuilder.package.identity
guard let referencedPackageDependency = (packageBuilder.package.manifest.dependencies.first { package in
return package.identity == referencedPackageIdentity
}) else {
throw InternalError("dependency reference for \(product.packageBuilder.package.manifest.packageLocation) not found")
}
let referencedPackageName = referencedPackageDependency.nameForModuleDependencyResolutionOnly
if productRef.name != referencedPackageName {
let error = PackageGraphError.productDependencyMissingPackage(
productName: productRef.name,
moduleName: moduleBuilder.module.name,
packageIdentifier: referencedPackageName
)
packageObservabilityScope.emit(error)
}
}
moduleBuilder.dependencies.append(.product(product, conditions: conditions))
}
}
}
// If a module with similar name was encountered before, we emit a diagnostic.
if foundDuplicateModule {
var duplicateModules = [String: [Package]]()
for moduleName in Set(allModuleNames).sorted() {
let packages = packageBuilders
.filter({ $0.modules.contains(where: { $0.module.name == moduleName }) })
.map{ $0.package }
if packages.count > 1 {
duplicateModules[moduleName, default: []].append(contentsOf: packages)
}
}
var potentiallyDuplicatePackages = [Pair: [String]]()
for entry in duplicateModules {
// the duplicate is across exactly two packages
if entry.value.count == 2 {
potentiallyDuplicatePackages[Pair(package1: entry.value[0], package2: entry.value[1]), default: []].append(entry.key)
}
}
var duplicateModulesAddressed = [String]()
for potentiallyDuplicatePackage in potentiallyDuplicatePackages {
// more than three module matches, or all modules in the package match
if potentiallyDuplicatePackage.value.count > 3 ||
(potentiallyDuplicatePackage.value.sorted() == potentiallyDuplicatePackage.key.package1.modules.map({ $0.name }).sorted()
&&
potentiallyDuplicatePackage.value.sorted() == potentiallyDuplicatePackage.key.package2.modules.map({ $0.name }).sorted())
{
switch (potentiallyDuplicatePackage.key.package1.identity.registry, potentiallyDuplicatePackage.key.package2.identity.registry) {
case (.some(let registryIdentity), .none):
observabilityScope.emit(
ModuleError.duplicateModulesScmAndRegistry(
regsitryPackage: registryIdentity,
scmPackage: potentiallyDuplicatePackage.key.package2.identity,
modules: potentiallyDuplicatePackage.value
)
)
case (.none, .some(let registryIdentity)):
observabilityScope.emit(
ModuleError.duplicateModulesScmAndRegistry(
regsitryPackage: registryIdentity,
scmPackage: potentiallyDuplicatePackage.key.package1.identity,
modules: potentiallyDuplicatePackage.value
)
)
default:
observabilityScope.emit(
ModuleError.duplicateModules(
package: potentiallyDuplicatePackage.key.package1.identity,
otherPackage: potentiallyDuplicatePackage.key.package2.identity,
modules: potentiallyDuplicatePackage.value
)
)
}
duplicateModulesAddressed += potentiallyDuplicatePackage.value
}
}
for entry in duplicateModules.filter({ !duplicateModulesAddressed.contains($0.key) }) {
observabilityScope.emit(
ModuleError.duplicateModule(
moduleName: entry.key,
packages: entry.value.map { $0.identity })
)
}
}
do {
let moduleBuilders = packageBuilders.flatMap {
$0.modules.map {
KeyedPair($0, key: $0.module)
}
}
if let cycle = findCycle(moduleBuilders, successors: {
$0.item.dependencies.flatMap {
switch $0 {
case .product(let productBuilder, conditions: _):
return productBuilder.moduleBuilders.map { KeyedPair($0, key: $0.module) }
case .module:
return [] // local modules were checked by PackageBuilder.
}
}
}) {
observabilityScope.emit(
ModuleError.cycleDetected(
(cycle.path.map(\.key.name), cycle.cycle.map(\.key.name))
)
)
return IdentifiableSet()
}
}
return IdentifiableSet(try packageBuilders.map { try $0.construct() })
}
private func emitDuplicateProductDiagnostic(
productName: String,
packages: [Package],
moduleAliasingUsed: Bool,
observabilityScope: ObservabilityScope
) -> PackageGraphError {
if moduleAliasingUsed {
packages.filter { $0.doesNotSupportProductAliases }.forEach {
// Emit an additional warning about product aliasing in case of older tools-versions.
observabilityScope.emit(warning: "product aliasing requires tools-version 5.2 or later, so it is not supported by '\($0.identity.description)'")
}
}
return PackageGraphError.duplicateProduct(
product: productName,
packages: packages
)
}
fileprivate extension Package {
var doesNotSupportProductAliases: Bool {
// We can never use the identity based lookup for older packages because they lack the necessary information.
return self.manifest.toolsVersion < .v5_2
}
}
fileprivate struct Pair: Hashable {
let package1: Package
let package2: Package
static func == (lhs: Pair, rhs: Pair) -> Bool {
return lhs.package1.identity == rhs.package1.identity &&
lhs.package2.identity == rhs.package2.identity
}
public func hash(into hasher: inout Hasher) {
hasher.combine(self.package1.identity)
hasher.combine(self.package2.identity)
}
}
fileprivate extension Product {
var isDefaultLibrary: Bool {
return type == .library(.automatic)
}
}
private class DuplicateProductsChecker {
var packageIDToBuilder = [PackageIdentity: ResolvedPackageBuilder]()
var checkedPkgIDs = [PackageIdentity]()
let moduleAliasingUsed: Bool
let observabilityScope: ObservabilityScope
init(packageBuilders: [ResolvedPackageBuilder], moduleAliasingUsed: Bool, observabilityScope: ObservabilityScope) {
for packageBuilder in packageBuilders {
let pkgID = packageBuilder.package.identity
self.packageIDToBuilder[pkgID] = packageBuilder
}
self.moduleAliasingUsed = moduleAliasingUsed
self.observabilityScope = observabilityScope
}
func run(lookupByProductIDs: Bool = false, observabilityScope: ObservabilityScope) throws {
var productToPkgMap = [String: Set<PackageIdentity>]()
for (pkgID, pkgBuilder) in packageIDToBuilder {
let useProductIDs = pkgBuilder.package.manifest.disambiguateByProductIDs || lookupByProductIDs
let depProductRefs = pkgBuilder.package.modules.map{$0.dependencies}.flatMap{$0}.compactMap{$0.product}
for depRef in depProductRefs {
if let depPkg = depRef.package.map(PackageIdentity.plain) {
if !checkedPkgIDs.contains(depPkg) {
checkedPkgIDs.append(depPkg)
}
let depProductIDs = packageIDToBuilder[depPkg]?.package.products.filter { $0.identity == depRef.identity }.map { useProductIDs && $0.isDefaultLibrary ? $0.identity : $0.name } ?? []
for depID in depProductIDs {
productToPkgMap[depID, default: .init()].insert(depPkg)
}
} else {
let depPkgs = pkgBuilder.dependencies.filter{ $0.products.contains{ $0.product.name == depRef.name }}.map{ $0.package.identity }
productToPkgMap[depRef.name, default: .init()].formUnion(Set(depPkgs))
checkedPkgIDs.append(contentsOf: depPkgs)
}
if !checkedPkgIDs.contains(pkgID) {
checkedPkgIDs.append(pkgID)
}
}
for (depIDOrName, depPkgs) in productToPkgMap.filter({Set($0.value).count > 1}) {
let name = depIDOrName.components(separatedBy: "_").dropFirst().joined(separator: "_")
throw emitDuplicateProductDiagnostic(
productName: name.isEmpty ? depIDOrName : name,
packages: depPkgs.compactMap{ packageIDToBuilder[$0]?.package },
moduleAliasingUsed: self.moduleAliasingUsed,
observabilityScope: self.observabilityScope
)
}
}
// Check packages that exist but are not in a dependency graph
let untrackedPkgs = packageIDToBuilder.filter{ !checkedPkgIDs.contains($0.key) }
for (pkgID, pkgBuilder) in untrackedPkgs {
for product in pkgBuilder.products {
// Check if checking product ID only is safe
let useIDOnly = lookupByProductIDs && product.product.isDefaultLibrary
if !useIDOnly {
// This untracked pkg could have a product name conflicting with a
// product name from another package, but since it's not depended on
// by other packages, keep track of both this product's name and ID
// just in case other packages are < .v5_8
productToPkgMap[product.product.name, default: .init()].insert(pkgID)
}
productToPkgMap[product.product.identity, default: .init()].insert(pkgID)
}
}
let duplicates = productToPkgMap.filter{ $0.value.count > 1 }
for (productName, pkgs) in duplicates {
throw emitDuplicateProductDiagnostic(
productName: productName,
packages: pkgs.compactMap{ packageIDToBuilder[$0]?.package },
moduleAliasingUsed: self.moduleAliasingUsed,
observabilityScope: self.observabilityScope
)
}
}
}
private func computePlatforms(
package: Package,
platformRegistry: PlatformRegistry
) -> [SupportedPlatform] {
// the supported platforms as declared in the manifest
let declaredPlatforms: [SupportedPlatform] = package.manifest.platforms.map { platform in
let declaredPlatform = platformRegistry.platformByName[platform.platformName]
?? PackageModel.Platform.custom(name: platform.platformName, oldestSupportedVersion: platform.version)
return SupportedPlatform(
platform: declaredPlatform,
version: .init(platform.version),
options: platform.options
)
}
return declaredPlatforms.sorted(by: { $0.platform.name < $1.platform.name })
}
// Track and override module aliases specified for modules in a package graph
private func resolveModuleAliases(packageBuilders: [ResolvedPackageBuilder],
observabilityScope: ObservabilityScope) throws -> Bool {
// If there are no module aliases specified, return early
let hasAliases = packageBuilders.contains { $0.package.modules.contains {
$0.dependencies.contains { dep in
if case let .product(prodRef, _) = dep {
return prodRef.moduleAliases != nil
}
return false
}
}
}
guard hasAliases else { return false }
var aliasTracker = ModuleAliasTracker()
for packageBuilder in packageBuilders {
try aliasTracker.addModuleAliases(modules: packageBuilder.package.modules,
package: packageBuilder.package.identity)
}
// Track modules that need module aliases for each package
for packageBuilder in packageBuilders {
for product in packageBuilder.package.products {
aliasTracker.trackModulesPerProduct(product: product,
package: packageBuilder.package.identity)
}
}
// Override module aliases upstream if needed
aliasTracker.propagateAliases(observabilityScope: observabilityScope)
// Validate sources (Swift files only) for modules being aliased.
// Needs to be done after `propagateAliases` since aliases defined
// upstream can be overridden.
for packageBuilder in packageBuilders {
for product in packageBuilder.package.products {
try aliasTracker.validateAndApplyAliases(product: product,
package: packageBuilder.package.identity,
observabilityScope: observabilityScope)
}
}
// Emit diagnostics for any module aliases that did not end up being applied.
aliasTracker.diagnoseUnappliedAliases(observabilityScope: observabilityScope)
return true
}
/// A generic builder for `Resolved` models.
private class ResolvedBuilder<T> {
/// The constructed object, available after the first call to `construct()`.
private var _constructedObject: T?
/// Construct the object with the accumulated data.
///
/// Note that once the object is constructed, future calls to
/// this method will return the same object.
final func construct() throws -> T {
if let _constructedObject {
return _constructedObject
}
let constructedObject = try self.constructImpl()
_constructedObject = constructedObject
return constructedObject
}
/// The object construction implementation.
func constructImpl() throws -> T {
fatalError("Should be implemented by subclasses")
}
}
/// Builder for resolved product.
private final class ResolvedProductBuilder: ResolvedBuilder<ResolvedProduct> {
/// The reference to its package.
unowned let packageBuilder: ResolvedPackageBuilder
/// The product reference.
let product: Product
/// The module builders in the product.
let moduleBuilders: [ResolvedModuleBuilder]
init(product: Product, packageBuilder: ResolvedPackageBuilder, moduleBuilders: [ResolvedModuleBuilder]) {
self.product = product
self.packageBuilder = packageBuilder
self.moduleBuilders = moduleBuilders
}
override func constructImpl() throws -> ResolvedProduct {
return ResolvedProduct(
packageIdentity: packageBuilder.package.identity,
product: product,
modules: IdentifiableSet(try moduleBuilders.map { try $0.construct() })
)
}
}
/// Builder for resolved module.
private final class ResolvedModuleBuilder: ResolvedBuilder<ResolvedModule> {
/// Enumeration to represent module dependencies.
enum Dependency {
/// Dependency to another module, with conditions.
case module(_ module: ResolvedModuleBuilder, conditions: [PackageCondition])
/// Dependency to a product, with conditions.
case product(_ product: ResolvedProductBuilder, conditions: [PackageCondition])
}
/// The reference to its package.
let packageIdentity: PackageIdentity
/// The module reference.
let module: Module
/// The module dependencies of this module.
var dependencies: [Dependency] = []
/// The defaultLocalization for this package
var defaultLocalization: String? = nil
/// The platforms supported by this package.
var supportedPlatforms: [SupportedPlatform] = []
let observabilityScope: ObservabilityScope
let platformVersionProvider: PlatformVersionProvider
init(
packageIdentity: PackageIdentity,
module: Module,
observabilityScope: ObservabilityScope,
platformVersionProvider: PlatformVersionProvider
) {
self.packageIdentity = packageIdentity
self.module = module
self.observabilityScope = observabilityScope
self.platformVersionProvider = platformVersionProvider
}
override func constructImpl() throws -> ResolvedModule {
let diagnosticsEmitter = self.observabilityScope.makeDiagnosticsEmitter() {
var metadata = ObservabilityMetadata()
metadata.moduleName = module.name
return metadata
}
let dependencies = try self.dependencies.map { dependency -> ResolvedModule.Dependency in
switch dependency {
case .module(let moduleBuilder, let conditions):
return .module(try moduleBuilder.construct(), conditions: conditions)
case .product(let productBuilder, let conditions):
try self.module.validateDependency(
product: productBuilder.product,
productPackage: productBuilder.packageBuilder.package.identity
)
let product = try productBuilder.construct()
if !productBuilder.packageBuilder.isAllowedToVendUnsafeProducts {
try product.diagnoseInvalidUseOfUnsafeFlags(diagnosticsEmitter)
}
return .product(product, conditions: conditions)
}
}
return ResolvedModule(
packageIdentity: self.packageIdentity,
underlying: self.module,
dependencies: dependencies,
defaultLocalization: self.defaultLocalization,
supportedPlatforms: self.supportedPlatforms,
platformVersionProvider: self.platformVersionProvider
)
}
}
extension Module {
func validateDependency(module: Module) throws {
if self.type == .plugin && module.type == .library {
throw PackageGraphError.unsupportedPluginDependency(
moduleName: self.name,
dependencyName: module.name,
dependencyType: module.type.rawValue,
dependencyPackage: nil
)
}
}
func validateDependency(product: Product, productPackage: PackageIdentity) throws {
if self.type == .plugin && product.type.isLibrary {
throw PackageGraphError.unsupportedPluginDependency(
moduleName: self.name,
dependencyName: product.name,
dependencyType: product.type.description,
dependencyPackage: productPackage.description
)
}
}
}
/// Builder for resolved package.
private final class ResolvedPackageBuilder: ResolvedBuilder<ResolvedPackage> {
/// The package reference.
let package: Package
/// The product filter applied to the package.
let productFilter: ProductFilter
/// Package can vend unsafe products
let isAllowedToVendUnsafeProducts: Bool
/// Package can be overridden
let allowedToOverride: Bool
/// The modules in the package.
var modules: [ResolvedModuleBuilder] = []
/// The products in this package.
var products: [ResolvedProductBuilder] = []
/// The dependencies of this package.
var dependencies: [ResolvedPackageBuilder] = []
/// Map from package identity to the local name for module dependency resolution that has been given to that package through the dependency declaration.
var dependencyNamesForModuleDependencyResolutionOnly: [PackageIdentity: String] = [:]
/// The defaultLocalization for this package.
var defaultLocalization: String? = nil
/// The platforms supported by this package.
var supportedPlatforms: [SupportedPlatform] = []
/// If the given package's source is a registry release, this provides additional metadata and signature information.
var registryMetadata: RegistryReleaseMetadata?
let platformVersionProvider: PlatformVersionProvider
init(
_ package: Package,
productFilter: ProductFilter,
isAllowedToVendUnsafeProducts: Bool,
allowedToOverride: Bool,
platformVersionProvider: PlatformVersionProvider
) {
self.package = package
self.productFilter = productFilter
self.isAllowedToVendUnsafeProducts = isAllowedToVendUnsafeProducts
self.allowedToOverride = allowedToOverride
self.platformVersionProvider = platformVersionProvider
}
override func constructImpl() throws -> ResolvedPackage {
let products = try self.products.map { try $0.construct() }
var modules = products.reduce(into: IdentifiableSet()) { $0.formUnion($1.modules) }
try modules.formUnion(self.modules.map { try $0.construct() })
return try ResolvedPackage(
underlying: self.package,
defaultLocalization: self.defaultLocalization,
supportedPlatforms: self.supportedPlatforms,
dependencies: self.dependencies.map { $0.package.identity },
modules: modules,
products: products,
registryMetadata: self.registryMetadata,
platformVersionProvider: self.platformVersionProvider
)
}
}
|