1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
|
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift open source project
//
// Copyright (c) 2021-2022 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See http://swift.org/LICENSE.txt for license information
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import Basics
import PackageLoading
import PackageModel
import SPMTestSupport
import XCTest
final class PackageDescription5_7LoadingTests: PackageDescriptionLoadingTests {
override var toolsVersion: ToolsVersion {
.v5_7
}
func testImplicitFoundationImportWorks() async throws {
let content = """
import PackageDescription
_ = FileManager.default
let package = Package(name: "MyPackage")
"""
let observability = ObservabilitySystem.makeForTesting()
let (manifest, validationDiagnostics) = try await loadAndValidateManifest(content, observabilityScope: observability.topScope)
XCTAssertNoDiagnostics(observability.diagnostics)
XCTAssertNoDiagnostics(validationDiagnostics)
XCTAssertEqual(manifest.displayName, "MyPackage")
}
func testRegistryDependencies() async throws {
let content = """
import PackageDescription
let package = Package(
name: "MyPackage",
dependencies: [
.package(id: "x.foo", from: "1.1.1"),
.package(id: "x.bar", exact: "1.1.1"),
.package(id: "x.baz", .upToNextMajor(from: "1.1.1")),
.package(id: "x.qux", .upToNextMinor(from: "1.1.1")),
.package(id: "x.quux", "1.1.1" ..< "3.0.0"),
]
)
"""
let observability = ObservabilitySystem.makeForTesting()
let (manifest, validationDiagnostics) = try await loadAndValidateManifest(content, observabilityScope: observability.topScope)
XCTAssertNoDiagnostics(observability.diagnostics)
XCTAssertNoDiagnostics(validationDiagnostics)
let deps = Dictionary(uniqueKeysWithValues: manifest.dependencies.map{ ($0.identity.description, $0) })
XCTAssertEqual(deps["x.foo"], .registry(identity: "x.foo", requirement: .range("1.1.1" ..< "2.0.0")))
XCTAssertEqual(deps["x.bar"], .registry(identity: "x.bar", requirement: .exact("1.1.1")))
XCTAssertEqual(deps["x.baz"], .registry(identity: "x.baz", requirement: .range("1.1.1" ..< "2.0.0")))
XCTAssertEqual(deps["x.qux"], .registry(identity: "x.qux", requirement: .range("1.1.1" ..< "1.2.0")))
XCTAssertEqual(deps["x.quux"], .registry(identity: "x.quux", requirement: .range("1.1.1" ..< "3.0.0")))
}
func testConditionalTargetDependencies() async throws {
let content = """
import PackageDescription
let package = Package(
name: "Foo",
dependencies: [],
targets: [
.target(name: "Foo", dependencies: [
.target(name: "Bar", condition: .when(platforms: [])),
.target(name: "Baz", condition: .when(platforms: [.linux])),
]),
.target(name: "Bar"),
.target(name: "Baz"),
]
)
"""
let observability = ObservabilitySystem.makeForTesting()
let (manifest, validationDiagnostics) = try await loadAndValidateManifest(content, observabilityScope: observability.topScope)
XCTAssertNoDiagnostics(observability.diagnostics)
XCTAssertNoDiagnostics(validationDiagnostics)
let dependencies = manifest.targets[0].dependencies
XCTAssertEqual(dependencies[0], .target(name: "Bar", condition: .none))
XCTAssertEqual(dependencies[1], .target(name: "Baz", condition: .init(platformNames: ["linux"], config: .none)))
}
func testConditionalTargetDependenciesDeprecation() async throws {
let content = """
import PackageDescription
let package = Package(
name: "Foo",
dependencies: [],
targets: [
.target(name: "Foo", dependencies: [
.target(name: "Bar", condition: .when(platforms: nil))
]),
.target(name: "Bar")
]
)
"""
let observability = ObservabilitySystem.makeForTesting()
await XCTAssertAsyncThrowsError(try await loadAndValidateManifest(content, observabilityScope: observability.topScope), "expected error") { error in
if case ManifestParseError.invalidManifestFormat(let error, _, _) = error {
XCTAssertMatch(error, .contains("when(platforms:)' was obsoleted"))
} else {
XCTFail("unexpected error: \(error)")
}
}
}
func testTargetDeprecatedDependencyCase() async throws {
let content = """
import PackageDescription
let package = Package(
name: "Foo",
dependencies: [
.package(url: "http://localhost/BarPkg", from: "1.1.1"),
],
targets: [
.target(name: "Foo",
dependencies: [
.productItem(name: "Bar", package: "BarPkg", condition: nil),
]),
]
)
"""
let observability = ObservabilitySystem.makeForTesting()
await XCTAssertAsyncThrowsError(try await loadAndValidateManifest(content, observabilityScope: observability.topScope)) { error in
if case ManifestParseError.invalidManifestFormat(let message, _, _) = error {
XCTAssertMatch(message, .contains("error: 'productItem(name:package:condition:)' is unavailable: use .product(name:package:condition) instead."))
} else {
XCTFail("unexpected error: \(error)")
}
}
}
func testPlatforms() async throws {
let content = """
import PackageDescription
let package = Package(
name: "Foo",
platforms: [
.macOS(.v13), .iOS(.v16),
.tvOS(.v16), .watchOS(.v9),
.macCatalyst(.v16), .driverKit(.v22),
]
)
"""
let observability = ObservabilitySystem.makeForTesting()
let (manifest, validationDiagnostics) = try await loadAndValidateManifest(content, observabilityScope: observability.topScope)
XCTAssertNoDiagnostics(observability.diagnostics)
XCTAssertNoDiagnostics(validationDiagnostics)
XCTAssertEqual(manifest.platforms, [
PlatformDescription(name: "macos", version: "13.0"),
PlatformDescription(name: "ios", version: "16.0"),
PlatformDescription(name: "tvos", version: "16.0"),
PlatformDescription(name: "watchos", version: "9.0"),
PlatformDescription(name: "maccatalyst", version: "16.0"),
PlatformDescription(name: "driverkit", version: "22.0"),
])
}
func testImportRestrictions() async throws {
let content = """
import PackageDescription
import BestModule
let package = Package(name: "Foo")
"""
let observability = ObservabilitySystem.makeForTesting()
let manifestLoader = ManifestLoader(toolchain: try UserToolchain.default, importRestrictions: (.v5_7, []))
await XCTAssertAsyncThrowsError(try await loadAndValidateManifest(content, customManifestLoader: manifestLoader, observabilityScope: observability.topScope)) { error in
if case ManifestParseError.importsRestrictedModules(let modules) = error {
XCTAssertEqual(modules.sorted(), ["BestModule", "Foundation"])
} else {
XCTFail("unexpected error: \(error)")
}
}
}
func testTargetDependencyProductInvalidPackage() async throws {
do {
let content = """
import PackageDescription
let package = Package(
name: "Trivial",
products: [],
dependencies: [
.package(id: "org.foo", from: "1.0.0"),
.package(id: "org.bar", from: "1.0.0"),
],
targets: [
.target(
name: "Target1",
dependencies: [.product(name: "product", package: "org.baz")]),
.target(
name: "Target2",
dependencies: ["foos"]),
]
)
"""
let observability = ObservabilitySystem.makeForTesting()
let (_, validationDiagnostics) = try await loadAndValidateManifest(content, observabilityScope: observability.topScope)
XCTAssertNoDiagnostics(observability.diagnostics)
testDiagnostics(validationDiagnostics) { result in
result.checkUnordered(diagnostic: "unknown package 'org.baz' in dependencies of target 'Target1'; valid packages are: 'org.foo', 'org.bar'", severity: .error)
result.checkUnordered(diagnostic: "unknown dependency 'foos' in target 'Target2'; valid dependencies are: 'org.foo', 'org.bar'", severity: .error)
}
}
}
}
|
