1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
@_spi(Rules) import SwiftFormat
import _SwiftFormatTestSupport
final class NoEmptyTrailingClosureParenthesesTests: LintOrFormatRuleTestCase {
func testInvalidEmptyParenTrailingClosure() {
assertFormatting(
NoEmptyTrailingClosureParentheses.self,
input: """
func greetEnthusiastically(_ nameProvider: () -> String) {
// ...
}
func greetApathetically(_ nameProvider: () -> String) {
// ...
}
greetEnthusiastically0️⃣() { "John" }
greetApathetically { "not John" }
func myfunc(cls: MyClass) {
cls.myClosure { $0 }
}
func myfunc(cls: MyClass) {
cls.myBadClosure1️⃣() { $0 }
}
DispatchQueue.main.async2️⃣() {
greetEnthusiastically3️⃣() { "John" }
DispatchQueue.main.async4️⃣() {
greetEnthusiastically5️⃣() { "Willis" }
}
}
DispatchQueue.global.async(inGroup: blah) {
DispatchQueue.main.async6️⃣() {
greetEnthusiastically7️⃣() { "Willis" }
}
DispatchQueue.main.async {
greetEnthusiastically8️⃣() { "Willis" }
}
}
foo(bar🔟() { baz })9️⃣() { blah }
""",
expected: """
func greetEnthusiastically(_ nameProvider: () -> String) {
// ...
}
func greetApathetically(_ nameProvider: () -> String) {
// ...
}
greetEnthusiastically { "John" }
greetApathetically { "not John" }
func myfunc(cls: MyClass) {
cls.myClosure { $0 }
}
func myfunc(cls: MyClass) {
cls.myBadClosure { $0 }
}
DispatchQueue.main.async {
greetEnthusiastically { "John" }
DispatchQueue.main.async {
greetEnthusiastically { "Willis" }
}
}
DispatchQueue.global.async(inGroup: blah) {
DispatchQueue.main.async {
greetEnthusiastically { "Willis" }
}
DispatchQueue.main.async {
greetEnthusiastically { "Willis" }
}
}
foo(bar { baz }) { blah }
""",
findings: [
FindingSpec("0️⃣", message: "remove the empty parentheses following 'greetEnthusiastically'"),
FindingSpec("1️⃣", message: "remove the empty parentheses following 'myBadClosure'"),
FindingSpec("2️⃣", message: "remove the empty parentheses following 'async'"),
FindingSpec("3️⃣", message: "remove the empty parentheses following 'greetEnthusiastically'"),
FindingSpec("4️⃣", message: "remove the empty parentheses following 'async'"),
FindingSpec("5️⃣", message: "remove the empty parentheses following 'greetEnthusiastically'"),
FindingSpec("6️⃣", message: "remove the empty parentheses following 'async'"),
FindingSpec("7️⃣", message: "remove the empty parentheses following 'greetEnthusiastically'"),
FindingSpec("8️⃣", message: "remove the empty parentheses following 'greetEnthusiastically'"),
FindingSpec("9️⃣", message: "remove the empty parentheses following ')'"),
FindingSpec("🔟", message: "remove the empty parentheses following 'bar'"),
]
)
}
func testDoNotRemoveParensContainingOnlyComments() {
assertFormatting(
NoEmptyTrailingClosureParentheses.self,
input: """
greetEnthusiastically(/*oldArg: x*/) { "John" }
greetEnthusiastically(
/*oldArg: x*/
) { "John" }
greetEnthusiastically(
// oldArg: x
) { "John" }
""",
expected: """
greetEnthusiastically(/*oldArg: x*/) { "John" }
greetEnthusiastically(
/*oldArg: x*/
) { "John" }
greetEnthusiastically(
// oldArg: x
) { "John" }
""",
findings: []
)
}
}
|
