File: UseLetInEveryBoundCaseVariable.swift

package info (click to toggle)
swiftlang 6.2.3-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 2,856,264 kB
  • sloc: cpp: 9,995,718; ansic: 2,234,019; asm: 1,092,167; python: 313,940; objc: 82,726; f90: 80,126; lisp: 38,373; pascal: 25,580; sh: 20,378; ml: 5,058; perl: 4,751; makefile: 4,725; awk: 3,535; javascript: 3,018; xml: 918; fortran: 664; cs: 573; ruby: 396
file content (202 lines) | stat: -rw-r--r-- 7,066 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//

import SwiftSyntax

/// Every variable bound in a `case` pattern must have its own `let/var`.
///
/// For example, `case let .identifier(x, y)` is forbidden. Use
/// `case .identifier(let x, let y)` instead.
///
/// Lint: `case let .identifier(...)` will yield a lint error.
///
/// Format: `case let .identifier(x, y)` will be replaced by
/// `case .identifier(let x, let y)`.
@_spi(Rules)
public final class UseLetInEveryBoundCaseVariable: SyntaxFormatRule {
  public override func visit(_ node: MatchingPatternConditionSyntax) -> MatchingPatternConditionSyntax {
    if let (replacement, specifier) = distributeLetVarThroughPattern(node.pattern) {
      diagnose(.useLetInBoundCaseVariables(specifier), on: node.pattern)

      var result = node
      result.pattern = PatternSyntax(replacement)
      return result
    }

    return super.visit(node)
  }

  public override func visit(_ node: SwitchCaseItemSyntax) -> SwitchCaseItemSyntax {
    if let (replacement, specifier) = distributeLetVarThroughPattern(node.pattern) {
      diagnose(.useLetInBoundCaseVariables(specifier), on: node.pattern)

      var result = node
      result.pattern = PatternSyntax(replacement)
      result.leadingTrivia = node.leadingTrivia
      return result
    }

    return super.visit(node)
  }

  public override func visit(_ node: ForStmtSyntax) -> StmtSyntax {
    guard node.caseKeyword != nil else {
      return super.visit(node)
    }

    if let (replacement, specifier) = distributeLetVarThroughPattern(node.pattern) {
      diagnose(.useLetInBoundCaseVariables(specifier), on: node.pattern)

      var result = node
      result.pattern = PatternSyntax(replacement)
      return StmtSyntax(result)
    }

    return super.visit(node)
  }
}

extension UseLetInEveryBoundCaseVariable {
  private enum OptionalPatternKind {
    case chained
    case forced
  }

  /// Wraps the given expression in the optional chaining and/or force
  /// unwrapping expressions, as described by the specified stack.
  private func restoreOptionalChainingAndForcing(
    _ expr: ExprSyntax,
    patternStack: [(OptionalPatternKind, Trivia)]
  ) -> ExprSyntax {
    var patternStack = patternStack
    var result = expr

    // As we unwind the stack, wrap the expression in optional chaining
    // or force unwrap expressions.
    while let (kind, trivia) = patternStack.popLast() {
      if kind == .chained {
        result = ExprSyntax(
          OptionalChainingExprSyntax(
            expression: result,
            trailingTrivia: trivia
          )
        )
      } else {
        result = ExprSyntax(
          ForceUnwrapExprSyntax(
            expression: result,
            trailingTrivia: trivia
          )
        )
      }
    }

    return result
  }

  /// Returns a rewritten version of the given pattern if bindings can be moved
  /// into bound cases.
  ///
  /// - Parameter pattern: The pattern to rewrite.
  /// - Returns: An optional tuple with the rewritten pattern and the binding
  ///   specifier used in `pattern`, for use in the diagnostic. If `pattern`
  ///   doesn't qualify for distributing the binding, then the result is `nil`.
  private func distributeLetVarThroughPattern(
    _ pattern: PatternSyntax
  ) -> (ExpressionPatternSyntax, TokenSyntax)? {
    guard let bindingPattern = pattern.as(ValueBindingPatternSyntax.self),
      let exprPattern = bindingPattern.pattern.as(ExpressionPatternSyntax.self)
    else { return nil }

    // Grab the `let` or `var` used in the binding pattern.
    var specifier = bindingPattern.bindingSpecifier
    specifier.leadingTrivia = []
    let identifierBinder = BindIdentifiersRewriter(bindingSpecifier: specifier)

    // Drill down into any optional patterns that we encounter (e.g., `case let .foo(x)?`).
    var patternStack: [(OptionalPatternKind, Trivia)] = []
    var expression = exprPattern.expression
    while true {
      if let optionalExpr = expression.as(OptionalChainingExprSyntax.self) {
        expression = optionalExpr.expression
        patternStack.append((.chained, optionalExpr.questionMark.trailingTrivia))
      } else if let forcedExpr = expression.as(ForceUnwrapExprSyntax.self) {
        expression = forcedExpr.expression
        patternStack.append((.forced, forcedExpr.exclamationMark.trailingTrivia))
      } else {
        break
      }
    }

    // Enum cases are written as function calls on member access expressions. The arguments
    // are the associated values, so the `let/var` can be distributed into those.
    if var functionCall = expression.as(FunctionCallExprSyntax.self),
      functionCall.calledExpression.is(MemberAccessExprSyntax.self)
    {
      var result = exprPattern
      let newArguments = identifierBinder.rewrite(functionCall.arguments)
      functionCall.arguments = newArguments.as(LabeledExprListSyntax.self)!
      result.expression = restoreOptionalChainingAndForcing(
        ExprSyntax(functionCall),
        patternStack: patternStack
      )
      return (result, specifier)
    }

    // A tuple expression can have the `let/var` distributed into the elements.
    if var tupleExpr = expression.as(TupleExprSyntax.self) {
      var result = exprPattern
      let newElements = identifierBinder.rewrite(tupleExpr.elements)
      tupleExpr.elements = newElements.as(LabeledExprListSyntax.self)!
      result.expression = restoreOptionalChainingAndForcing(
        ExprSyntax(tupleExpr),
        patternStack: patternStack
      )
      return (result, specifier)
    }

    // Otherwise, we're not sure this is a pattern we can distribute through.
    return nil
  }
}

extension Finding.Message {
  fileprivate static func useLetInBoundCaseVariables(
    _ specifier: TokenSyntax
  ) -> Finding.Message {
    "move this '\(specifier.text)' keyword inside the 'case' pattern, before each of the bound variables"
  }
}

/// A syntax rewriter that converts identifier patterns to bindings
/// with the given specifier.
private final class BindIdentifiersRewriter: SyntaxRewriter {
  var bindingSpecifier: TokenSyntax

  init(bindingSpecifier: TokenSyntax) {
    self.bindingSpecifier = bindingSpecifier
  }

  override func visit(_ node: PatternExprSyntax) -> ExprSyntax {
    guard let identifier = node.pattern.as(IdentifierPatternSyntax.self) else {
      return super.visit(node)
    }

    let binding = ValueBindingPatternSyntax(
      bindingSpecifier: bindingSpecifier,
      pattern: identifier
    )
    var result = node
    result.pattern = PatternSyntax(binding)
    return ExprSyntax(result)
  }
}