1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
|
//===-- Sema/NonisolatedNonsendingByDefaultMigration.cpp --------*- C++ -*-===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2025 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
///
/// \file
/// This file implements code migration support for the
/// `NonisolatedNonsendingByDefault` feature.
///
//===----------------------------------------------------------------------===//
#include "NonisolatedNonsendingByDefaultMigration.h"
#include "swift/AST/ASTContext.h"
#include "swift/AST/Decl.h"
#include "swift/AST/DiagnosticsSema.h"
#include "swift/AST/Expr.h"
#include "swift/AST/Module.h"
#include "swift/AST/ParameterList.h"
#include "swift/AST/TypeRepr.h"
#include "swift/Basic/Assertions.h"
#include "swift/Basic/Feature.h"
#include "swift/Basic/TaggedUnion.h"
#include "llvm/ADT/PointerUnion.h"
using namespace swift;
namespace {
class NonisolatedNonsendingByDefaultMigrationTarget {
ASTContext &ctx;
PointerUnion<ValueDecl *, AbstractClosureExpr *, FunctionTypeRepr *> node;
TaggedUnion<ActorIsolation, FunctionTypeIsolation> isolation;
public:
NonisolatedNonsendingByDefaultMigrationTarget(ASTContext &ctx, ValueDecl *decl,
ActorIsolation isolation)
: ctx(ctx), node(decl), isolation(isolation) {}
NonisolatedNonsendingByDefaultMigrationTarget(ASTContext &ctx,
AbstractClosureExpr *closure,
ActorIsolation isolation)
: ctx(ctx), node(closure), isolation(isolation) {}
NonisolatedNonsendingByDefaultMigrationTarget(ASTContext &ctx, FunctionTypeRepr *repr,
FunctionTypeIsolation isolation)
: ctx(ctx), node(repr), isolation(isolation) {}
/// Warns that the behavior of nonisolated async functions will change under
/// `NonisolatedNonsendingByDefault` and suggests `@concurrent` to preserve the current
/// behavior.
void diagnose() const;
};
/// Determine whether the decl represents a test function that is
/// annotated with `@Test` macro from the swift-testing framework.
/// Such functions should be exempt from the migration because their
/// execution is controlled by the framework and the change in
/// behavior doesn't affect them.
static bool isSwiftTestingTestFunction(ValueDecl *decl) {
if (!isa<FuncDecl>(decl))
return false;
return llvm::any_of(decl->getAttrs(), [&decl](DeclAttribute *attr) {
auto customAttr = dyn_cast<CustomAttr>(attr);
if (!customAttr)
return false;
auto *macro = decl->getResolvedMacro(customAttr);
return macro && macro->getBaseIdentifier().is("Test") &&
macro->getParentModule()->getName().is("Testing");
});
}
} // end anonymous namespace
void NonisolatedNonsendingByDefaultMigrationTarget::diagnose() const {
const auto feature = Feature::NonisolatedNonsendingByDefault;
ASSERT(node);
ASSERT(ctx.LangOpts.getFeatureState(feature).isEnabledForMigration());
ValueDecl *decl = nullptr;
ClosureExpr *closure = nullptr;
FunctionTypeRepr *functionRepr = nullptr;
if ((decl = node.dyn_cast<ValueDecl *>())) {
// Diagnose only explicit nodes.
if (decl->isImplicit()) {
return;
}
// Only diagnose declarations from the current module.
if (decl->getModuleContext() != ctx.MainModule) {
return;
}
// `@Test` test-case have special semantics.
if (isSwiftTestingTestFunction(decl)) {
return;
}
// A special declaration that was either synthesized by the compiler
// or a macro expansion.
if (decl->getBaseName().hasDollarPrefix()) {
return;
}
// If the attribute cannot appear on this kind of declaration, we can't
// diagnose it.
if (!DeclAttribute::canAttributeAppearOnDecl(DeclAttrKind::Concurrent,
decl)) {
return;
}
// For storage, make sure we have an explicit getter to diagnose.
if (auto *storageDecl = dyn_cast<AbstractStorageDecl>(decl)) {
if (!storageDecl->getParsedAccessor(AccessorKind::Get)) {
return;
}
}
} else if (auto *anyClosure = node.dyn_cast<AbstractClosureExpr *>()) {
// Diagnose only explicit nodes.
if (anyClosure->isImplicit()) {
return;
}
// The only subclass that can be explicit is this one.
closure = cast<ClosureExpr>(anyClosure);
} else {
functionRepr = node.get<FunctionTypeRepr *>();
}
// The execution behavior changes only for nonisolated functions.
{
bool isNonisolated;
if (functionRepr) {
isNonisolated = isolation.get<FunctionTypeIsolation>().isNonIsolated();
} else {
auto isolation = this->isolation.get<ActorIsolation>();
isNonisolated = isolation.isNonisolated() || isolation.isUnspecified();
}
if (!isNonisolated) {
return;
}
}
// If the intended behavior is specified explicitly, don't diagnose.
{
const DeclAttributes *attrs = nullptr;
if (decl) {
attrs = &decl->getAttrs();
} else if (closure) {
attrs = &closure->getAttrs();
}
if (attrs) {
if (attrs->hasAttribute<ConcurrentAttr>())
return;
if (auto *nonisolated = attrs->getAttribute<NonisolatedAttr>()) {
if (nonisolated->isNonSending())
return;
}
}
}
// The execution behavior changes only for async functions.
{
bool isAsync = false;
if (decl) {
isAsync = decl->isAsync();
} else if (closure) {
isAsync = closure->isBodyAsync();
} else {
isAsync = functionRepr->isAsync();
}
if (!isAsync) {
return;
}
}
const ConcurrentAttr attr(/*implicit=*/true);
const auto featureName = feature.getName();
if (decl) {
// Diagnose the function, but slap the attribute on the storage declaration
// instead if the function is an accessor.
auto *functionDecl = dyn_cast<AbstractFunctionDecl>(decl);
if (!functionDecl) {
auto *storageDecl = cast<AbstractStorageDecl>(decl);
// This whole logic assumes that an 'async' storage declaration only has
// a getter. Yell for an update if this ever changes.
ASSERT(!storageDecl->getAccessor(AccessorKind::Set));
functionDecl = storageDecl->getParsedAccessor(AccessorKind::Get);
}
ctx.Diags
.diagnose(functionDecl->getLoc(),
diag::attr_execution_nonisolated_behavior_will_change_decl,
featureName, functionDecl)
.fixItInsertAttribute(
decl->getAttributeInsertionLoc(/*forModifier=*/false), &attr);
} else if (functionRepr) {
ctx.Diags
.diagnose(
functionRepr->getStartLoc(),
diag::attr_execution_nonisolated_behavior_will_change_typerepr,
featureName)
.fixItInsertAttribute(functionRepr->getStartLoc(), &attr);
} else {
auto diag = ctx.Diags.diagnose(
closure->getLoc(),
diag::attr_execution_nonisolated_behavior_will_change_closure,
featureName);
diag.fixItAddAttribute(&attr, closure);
// The following cases fail to compile together with `@concurrent` in
// Swift 5 or Swift 6 mode due to parser and type checker behaviors:
// 1. - Explicit parameter list
// - Explicit result type
// - No explicit `async` effect
// 2. - Explicit parenthesized parameter list
// - No capture list
// - No explicit result type
// - No explicit effect
//
// Work around these issues by adding inferred effects together with the
// attribute.
// If there's an explicit `async` effect, we're good.
if (closure->getAsyncLoc().isValid()) {
return;
}
auto *params = closure->getParameters();
// FIXME: We need a better way to distinguish an implicit parameter list.
bool hasExplicitParenthesizedParamList =
params->getLParenLoc().isValid() &&
params->getLParenLoc() != closure->getStartLoc();
// If the parameter list is implicit, we're good.
if (!hasExplicitParenthesizedParamList) {
if (params->size() == 0) {
return;
} else if ((*params)[0]->isImplicit()) {
return;
}
}
// At this point we must proceed if there is an explicit result type.
// If there is both no explicit result type and the second case does not
// apply for any other reason, we're good.
if (!closure->hasExplicitResultType() &&
(!hasExplicitParenthesizedParamList ||
closure->getBracketRange().isValid() ||
closure->getThrowsLoc().isValid())) {
return;
}
// Compute the insertion location.
SourceLoc effectsInsertionLoc = closure->getThrowsLoc();
if (effectsInsertionLoc.isInvalid() && closure->hasExplicitResultType()) {
effectsInsertionLoc = closure->getArrowLoc();
}
if (effectsInsertionLoc.isInvalid()) {
effectsInsertionLoc = closure->getInLoc();
}
ASSERT(effectsInsertionLoc);
std::string fixIt = "async ";
if (closure->getThrowsLoc().isInvalid() && closure->isBodyThrowing()) {
fixIt += "throws ";
}
diag.fixItInsert(effectsInsertionLoc, fixIt);
}
}
void swift::warnAboutNewNonisolatedAsyncExecutionBehavior(
ASTContext &ctx, FunctionTypeRepr *repr, FunctionTypeIsolation isolation) {
NonisolatedNonsendingByDefaultMigrationTarget(ctx, repr, isolation).diagnose();
}
void swift::warnAboutNewNonisolatedAsyncExecutionBehavior(
ASTContext &ctx, ValueDecl *decl, ActorIsolation isolation) {
NonisolatedNonsendingByDefaultMigrationTarget(ctx, decl, isolation).diagnose();
}
void swift::warnAboutNewNonisolatedAsyncExecutionBehavior(
ASTContext &ctx, AbstractClosureExpr *closure, ActorIsolation isolation) {
NonisolatedNonsendingByDefaultMigrationTarget(ctx, closure, isolation).diagnose();
}
|