1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
|
From: Daniel Beyer <dabe@deb.ymc.ch>
Date: Fri, 3 Oct 2014 08:51:52 +0200
Subject: Add more tests to '@group tty'
Not all tests using a tty are in @group tty. This should be reported (and
fixed) upstream but needs further investigation:
- There might be more tests needing a tty.
- It could be that some tests in group tty may not need a tty.
Forwarded: no
---
src/Symfony/Component/Process/Tests/AbstractProcessTest.php | 9 +++++++++
.../Component/Process/Tests/SigchildDisabledProcessTest.php | 1 +
2 files changed, 10 insertions(+)
diff --git a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php
index 5689d34..53ac93e 100644
--- a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php
+++ b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php
@@ -332,6 +332,9 @@ abstract class AbstractProcessTest extends \PHPUnit_Framework_TestCase
$this->assertGreaterThan(0, $process->getExitCode());
}
+ /**
+ * @group tty
+ */
public function testTTYCommand()
{
if (defined('PHP_WINDOWS_VERSION_BUILD')) {
@@ -347,6 +350,9 @@ abstract class AbstractProcessTest extends \PHPUnit_Framework_TestCase
$this->assertSame(Process::STATUS_TERMINATED, $process->getStatus());
}
+ /**
+ * @group tty
+ */
public function testTTYCommandExitCode()
{
if (defined('PHP_WINDOWS_VERSION_BUILD')) {
@@ -360,6 +366,9 @@ abstract class AbstractProcessTest extends \PHPUnit_Framework_TestCase
$this->assertTrue($process->isSuccessful());
}
+ /**
+ * @group tty
+ */
public function testTTYInWindowsEnvironment()
{
if (!defined('PHP_WINDOWS_VERSION_BUILD')) {
diff --git a/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php b/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
index f0adb1f..326c7f8 100644
--- a/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
+++ b/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
@@ -170,6 +170,7 @@ class SigchildDisabledProcessTest extends AbstractProcessTest
}
/**
+ * @group tty
* @expectedException \Symfony\Component\Process\Exception\RuntimeException
* @expectedExceptionMessage This PHP has been compiled with --enable-sigchild. You must use setEnhanceSigchildCompatibility() to use this method.
*/
|