File: test_log_message.c

package info (click to toggle)
syslog-ng 4.8.1-6
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 20,456 kB
  • sloc: ansic: 177,631; python: 13,035; cpp: 11,611; makefile: 7,012; sh: 5,147; java: 3,651; xml: 3,344; yacc: 1,377; lex: 599; perl: 193; awk: 190; objc: 162
file content (948 lines) | stat: -rw-r--r-- 31,486 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
/*
 * Copyright (c) 2002-2016 Balabit
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 *
 * As an additional exemption you are allowed to compile & link against the
 * OpenSSL libraries as published by the OpenSSL project. See the file
 * COPYING for details.
 *
 */

#include <criterion/criterion.h>
#include "libtest/msg_parse_lib.h"
#include "libtest/persist_lib.h"

#include "apphook.h"
#include "logpipe.h"
#include "scratch-buffers.h"
#include "rcptid.h"

typedef struct _LogMessageTestParams
{
  LogMessage *message;
  LogMessage *cloned_message;
  NVHandle nv_handle;
  NVHandle sd_handle;
  const gchar *tag_name;
} LogMessageTestParams;

static LogMessage *
_construct_log_message(void)
{
  const gchar *raw_msg = "foo";
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value(msg, LM_V_HOST, raw_msg, -1);
  return msg;
}

static LogMessage *
_construct_merge_base_message(void)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, "base", "basevalue", -1);
  log_msg_set_tag_by_name(msg, "basetag");
  return msg;
}

static LogMessage *
_construct_merged_message(const gchar *name, const gchar *value)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, name, value, -1);
  log_msg_set_tag_by_name(msg, "mergedtag");
  return msg;
}

static void
assert_log_msg_clear_clears_all_properties(LogMessage *message, NVHandle nv_handle,
                                           NVHandle sd_handle, const gchar *tag_name)
{
  message->flags |= LF_LOCAL + LF_UTF8 + LF_INTERNAL + LF_MARK;
  LogPathOptions path_options = LOG_PATH_OPTIONS_INIT;

  log_msg_make_writable(&message, &path_options);
  log_msg_clear(message);

  cr_assert_str_empty(log_msg_get_value(message, nv_handle, NULL),
                      "Message still contains value after log_msg_clear");

  cr_assert_str_empty(log_msg_get_value(message, sd_handle, NULL),
                      "Message still contains sdata value after log_msg_clear");

  cr_assert_null(message->saddr, "Message still contains an saddr after log_msg_clear");
  cr_assert_not(log_msg_is_tag_by_name(message, tag_name),
                "Message still contains a valid tag after log_msg_clear");
  cr_assert((message->flags & LF_LOCAL) == 0, "Message still contains the 'local' flag after log_msg_clear");
  cr_assert((message->flags & LF_UTF8) == 0, "Message still contains the 'utf8' flag after log_msg_clear");
  cr_assert((message->flags & LF_MARK) == 0, "Message still contains the 'mark' flag after log_msg_clear");
  cr_assert((message->flags & LF_INTERNAL) == 0, "Message still contains the 'internal' flag after log_msg_clear");
}

static void
assert_sdata_value_with_seqnum_equals(LogMessage *msg, guint32 seq_num, const gchar *expected)
{
  GString *result = g_string_sized_new(0);

  log_msg_append_format_sdata(msg, result, seq_num);
  cr_assert_str_eq(result->str, expected, "SDATA value does not match, '%s' vs '%s'", expected, result->str);
  g_string_free(result, TRUE);
}

static void
assert_sdata_value_equals(LogMessage *msg, const gchar *expected)
{
  assert_sdata_value_with_seqnum_equals(msg, 0, expected);
}

static LogMessageTestParams *
log_message_test_params_new(void)
{
  LogMessageTestParams *params = g_new0(LogMessageTestParams, 1);

  params->tag_name = "tag";
  params->message = _construct_log_message();

  params->nv_handle = log_msg_get_value_handle("foo");
  params->sd_handle = log_msg_get_value_handle(".SDATA.foo.bar");

  log_msg_set_value(params->message, params->nv_handle, "value", -1);
  log_msg_set_value(params->message, params->sd_handle, "value", -1);
  params->message->saddr = g_sockaddr_inet_new("1.2.3.4", 5050);
  log_msg_set_tag_by_name(params->message, params->tag_name);

  return params;
}

void
log_message_test_params_free(LogMessageTestParams *params)
{
  log_msg_unref(params->message);

  if (params->cloned_message)
    log_msg_unref(params->cloned_message);

  g_free(params);
}

LogMessage *
log_message_test_params_clone_message(LogMessageTestParams *params)
{
  LogPathOptions path_options = LOG_PATH_OPTIONS_INIT;
  params->cloned_message = log_msg_clone_cow(params->message, &path_options);

  return params->cloned_message;
}


void
setup(void)
{
  app_startup();
}

void
teardown(void)
{
  scratch_buffers_explicit_gc();
  deinit_syslogformat_module();
  app_shutdown();
}

TestSuite(log_message, .init = setup, .fini = teardown);

Test(log_message, test_log_message_can_be_created_and_freed)
{
  LogMessage *msg = _construct_log_message();
  log_msg_unref(msg);
}

Test(log_message, test_log_message_can_be_cleared)
{
  LogMessageTestParams *params = log_message_test_params_new();

  log_message_test_params_clone_message(params);

  assert_log_msg_clear_clears_all_properties(params->message, params->nv_handle,
                                             params->sd_handle, params->tag_name);
  assert_log_msg_clear_clears_all_properties(params->cloned_message, params->nv_handle,
                                             params->sd_handle, params->tag_name);

  log_message_test_params_free(params);
}

Test(log_message, test_log_message_clear_sdata_unsets_all_sdata)
{
  LogMessageTestParams *params = log_message_test_params_new();

  log_msg_clear_sdata(params->message);

  cr_assert(params->message->num_sdata == 0);
  cr_assert_str_empty(log_msg_get_value(params->message, params->sd_handle, NULL),
                      "Message still contains sdata value after log_msg_clear_sdata");

  log_message_test_params_free(params);
}

Test(log_message, test_log_msg_clear_handles_cloned_noninline_tags_properly)
{
  LogMessage *msg = _construct_log_message();

  for (gint i = 0; i < 100; i++)
    {
      gchar tag_name[32];

      g_snprintf(tag_name, sizeof(tag_name), "tag%d", i);
      log_msg_set_tag_by_name(msg, tag_name);
    }

  LogPathOptions path_options = LOG_PATH_OPTIONS_INIT;
  LogMessage *cloned = log_msg_clone_cow(msg, &path_options);

  log_msg_clear(cloned);

  for (gint i = 0; i < 100; i++)
    {
      gchar tag_name[32];

      g_snprintf(tag_name, sizeof(tag_name), "tag%d", i);
      cr_assert(log_msg_is_tag_by_name(cloned, tag_name) == FALSE);
    }
  log_msg_unref(cloned);
  log_msg_unref(msg);

}

Test(log_message, test_rcptid_is_automatically_assigned_to_a_newly_created_log_message)
{
  LogMessage *msg;
  PersistState *state = clean_and_create_persist_state_for_test("test_values.persist");
  rcptid_init(state, TRUE);

  msg = log_msg_new_empty();
  cr_assert_eq(msg->rcptid, 1, "rcptid is not automatically set");
  log_msg_unref(msg);

  commit_and_destroy_persist_state(state);
  rcptid_deinit();
}

Test(log_message, test_log_message_merge_with_empty_context)
{
  LogMessageTestParams *params = log_message_test_params_new();
  LogMessage *context[] = {};

  log_message_test_params_clone_message(params);

  log_msg_merge_context(params->message, context, 0);
  assert_log_messages_equal(params->message, params->cloned_message);

  log_message_test_params_free(params);
}

Test(log_message, test_log_message_merge_unset_value)
{
  LogMessage *msg;
  GPtrArray *context = g_ptr_array_sized_new(0);

  msg = _construct_merge_base_message();
  g_ptr_array_add(context, _construct_merged_message("merged", "mergedvalue"));
  log_msg_merge_context(msg, (LogMessage **) context->pdata, context->len);

  assert_log_message_value_by_name(msg, "base", "basevalue");
  assert_log_message_value_by_name(msg, "merged", "mergedvalue");
  g_ptr_array_foreach(context, (GFunc) log_msg_unref, NULL);
  g_ptr_array_free(context, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_log_message_merge_doesnt_overwrite_already_set_values)
{
  LogMessage *msg;
  GPtrArray *context = g_ptr_array_sized_new(0);

  msg = _construct_merge_base_message();
  g_ptr_array_add(context, _construct_merged_message("base", "mergedvalue"));
  log_msg_merge_context(msg, (LogMessage **) context->pdata, context->len);

  assert_log_message_value_by_name(msg, "base", "basevalue");
  g_ptr_array_foreach(context, (GFunc) log_msg_unref, NULL);
  g_ptr_array_free(context, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_log_message_merge_merges_the_closest_value_in_the_context)
{
  LogMessage *msg;
  GPtrArray *context = g_ptr_array_sized_new(0);

  msg = _construct_merge_base_message();
  g_ptr_array_add(context, _construct_merged_message("merged", "mergedvalue1"));
  g_ptr_array_add(context, _construct_merged_message("merged", "mergedvalue2"));
  log_msg_merge_context(msg, (LogMessage **) context->pdata, context->len);

  assert_log_message_value_by_name(msg, "merged", "mergedvalue2");
  g_ptr_array_foreach(context, (GFunc) log_msg_unref, NULL);
  g_ptr_array_free(context, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_log_message_merge_merges_from_all_messages_in_the_context)
{
  LogMessage *msg;
  GPtrArray *context = g_ptr_array_sized_new(0);

  msg = _construct_merge_base_message();
  g_ptr_array_add(context, _construct_merged_message("merged1", "mergedvalue1"));
  g_ptr_array_add(context, _construct_merged_message("merged2", "mergedvalue2"));
  g_ptr_array_add(context, _construct_merged_message("merged3", "mergedvalue3"));
  log_msg_merge_context(msg, (LogMessage **) context->pdata, context->len);

  assert_log_message_value_by_name(msg, "merged1", "mergedvalue1");
  assert_log_message_value_by_name(msg, "merged2", "mergedvalue2");
  assert_log_message_value_by_name(msg, "merged3", "mergedvalue3");
  g_ptr_array_foreach(context, (GFunc) log_msg_unref, NULL);
  g_ptr_array_free(context, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_log_message_merge_leaves_base_tags_intact)
{
  LogMessage *msg;
  GPtrArray *context = g_ptr_array_sized_new(0);

  msg = _construct_merge_base_message();
  g_ptr_array_add(context, _construct_merged_message("merged1", "mergedvalue1"));
  log_msg_merge_context(msg, (LogMessage **) context->pdata, context->len);

  assert_log_message_has_tag(msg, "basetag");
  assert_log_message_doesnt_have_tag(msg, "mergedtag");
  g_ptr_array_foreach(context, (GFunc) log_msg_unref, NULL);
  g_ptr_array_free(context, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_log_msg_set_value_indirect_with_self_referencing_handle_results_in_a_nonindirect_value)
{
  LogMessageTestParams *params = log_message_test_params_new();
  gssize value_len;

  log_msg_set_value_indirect(params->message, params->nv_handle, params->nv_handle, 0, 5);
  cr_assert_str_eq(log_msg_get_value(params->message, params->nv_handle, &value_len), "value",
                   "indirect self-reference value doesn't match");

  log_message_test_params_free(params);
}

Test(log_message, test_log_msg_get_value_with_time_related_macro)
{
  LogMessage *msg;
  gssize value_len;
  NVHandle handle;
  const char *date_value;

  msg = log_msg_new_empty();
  msg->timestamps[LM_TS_STAMP].ut_sec = 1389783444;
  msg->timestamps[LM_TS_STAMP].ut_gmtoff = 3600;

  handle = log_msg_get_value_handle("ISODATE");
  date_value = log_msg_get_value(msg, handle, &value_len);
  cr_assert_str_eq(date_value, "2014-01-15T11:57:24+01:00", "ISODATE macro value does not match! value=%s", date_value);

  log_msg_unref(msg);
}

Test(log_message, test_local_logmsg_created_with_the_right_flags_and_timestamps)
{
  LogMessage *msg = log_msg_new_local();

  gboolean are_equals = unix_time_eq(&msg->timestamps[LM_TS_STAMP], &msg->timestamps[LM_TS_RECVD]);

  cr_assert_neq((msg->flags & LF_LOCAL), 0, "LogMessage created by log_msg_new_local() should have LF_LOCAL flag set");
  cr_assert(are_equals, "The timestamps in a LogMessage created by log_msg_new_local() should be equals");

  log_msg_unref(msg);
}

Test(log_message, test_sdata_sanitization)
{
  LogMessage *msg;
  /* These keys looks strange, but JSON object can be parsed to SDATA,
   * so the key could contain any character, while the specification
   * does not declare any way to encode the keys, just the values.
   * The goal is to have a syntactically valid syslog message.
   *
   * Block names are sanitized with the same function as the keys,
   * thus no need for exhaust testing, added just one case to the end
   * to see if business logic applied. */

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar[0]", "value[0]", -1);
  assert_sdata_value_equals(msg, "[foo bar%5B0%5D=\"value[0\\]\"]");
  log_msg_unref(msg);

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.bácsi", "bácsi", -1);
  assert_sdata_value_equals(msg, "[foo b%C3%A1csi=\"bácsi\"]");
  log_msg_unref(msg);

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.sp ace", "sp ace", -1);
  assert_sdata_value_equals(msg, "[foo sp%20ace=\"sp ace\"]");
  log_msg_unref(msg);

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.eq=al", "eq=al", -1);
  assert_sdata_value_equals(msg, "[foo eq%3Dal=\"eq=al\"]");
  log_msg_unref(msg);

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.quo\"te", "quo\"te", -1);
  assert_sdata_value_equals(msg, "[foo quo%22te=\"quo\\\"te\"]");
  log_msg_unref(msg);

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.fo@o[0].bar", "value", -1);
  assert_sdata_value_equals(msg, "[fo@o%5B0%5D bar=\"value\"]");
  log_msg_unref(msg);
}

Test(log_message, test_sdata_value_is_updated_by_sdata_name_value_pairs)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar1", "value", -1);
  assert_sdata_value_equals(msg, "[foo bar1=\"value\"]");
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar2", "value", -1);
  assert_sdata_value_equals(msg, "[foo bar1=\"value\" bar2=\"value\"]");
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar3", "value", -1);
  assert_sdata_value_equals(msg, "[foo bar1=\"value\" bar2=\"value\" bar3=\"value\"]");
  log_msg_set_value_by_name(msg, ".SDATA.post.value1", "value", -1);
  assert_sdata_value_equals(msg, "[post value1=\"value\"][foo bar1=\"value\" bar2=\"value\" bar3=\"value\"]");
  log_msg_set_value_by_name(msg, ".SDATA.post.value2", "value", -1);
  assert_sdata_value_equals(msg,
                            "[post value1=\"value\" value2=\"value\"][foo bar1=\"value\" bar2=\"value\" bar3=\"value\"]");
  log_msg_unref(msg);
}

Test(log_message, test_sdata_seqnum_adds_meta_sequence_id)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar1", "value", -1);
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar2", "value", -1);
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar3", "value", -1);
  assert_sdata_value_with_seqnum_equals(msg, 5,
                                        "[foo bar1=\"value\" bar2=\"value\" bar3=\"value\"][meta sequenceId=\"5\"]");
  log_msg_set_value_by_name(msg, ".SDATA.meta.foobar", "value", -1);
  assert_sdata_value_with_seqnum_equals(msg, 6,
                                        "[meta sequenceId=\"6\" foobar=\"value\"][foo bar1=\"value\" bar2=\"value\" bar3=\"value\"]");
  log_msg_unref(msg);
}

Test(log_message, test_sdata_value_omits_unset_values)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar1", "value", -1);
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar2", "value", -1);
  log_msg_set_value_by_name(msg, ".SDATA.foo.bar3", "value", -1);
  assert_sdata_value_equals(msg, "[foo bar1=\"value\" bar2=\"value\" bar3=\"value\"]");
  log_msg_unset_value_by_name(msg, ".SDATA.foo.bar2");
  assert_sdata_value_equals(msg, "[foo bar1=\"value\" bar3=\"value\"]");
  log_msg_unset_value_by_name(msg, ".SDATA.foo.bar1");
  log_msg_unset_value_by_name(msg, ".SDATA.foo.bar3");
  assert_sdata_value_equals(msg, "");
  log_msg_unref(msg);
}

Test(log_message, test_value_retains_type_information)
{
  LogMessage *msg;
  LogMessageValueType type;
  const gchar *value;

  msg = log_msg_new_empty();

  /* unset */
  value = log_msg_get_value_by_name_with_type(msg, "nvpair", NULL, &type);
  cr_assert_str_empty(value);
  cr_assert(type == LM_VT_NULL);

  /* set with a specific type */
  log_msg_set_value_by_name_with_type(msg, "nvpair", "value", -1, LM_VT_JSON);
  value = log_msg_get_value_by_name_with_type(msg, "nvpair", NULL, &type);
  cr_assert_str_eq(value, "value");
  cr_assert(type == LM_VT_JSON);

  /* changed with a specific type */
  log_msg_set_value_by_name_with_type(msg, "nvpair", "123", -1, LM_VT_INTEGER);
  value = log_msg_get_value_by_name_with_type(msg, "nvpair", NULL, &type);
  cr_assert_str_eq(value, "123");
  cr_assert(type == LM_VT_INTEGER);

  /* unset becomes string again */
  log_msg_unset_value_by_name(msg, "nvpair");
  value = log_msg_get_value_by_name_with_type(msg, "nvpair", NULL, &type);
  cr_assert_str_empty(value, "value");
  cr_assert(type == LM_VT_NULL);

  log_msg_unref(msg);
}

Test(log_message, test_macro_is_always_a_string)
{
  LogMessage *msg;
  LogMessageValueType type;
  const gchar *value;

  msg = log_msg_new_empty();
  value = log_msg_get_value_by_name_with_type(msg, "FACILITY", NULL, &type);
  cr_assert_str_eq(value, "user");
  cr_assert(type == LM_VT_STRING);

  log_msg_unref(msg);
}

Test(log_message, test_macro_value_is_set_and_is_a_string)
{
  LogMessage *msg;
  LogMessageValueType type;
  const gchar *value;

  msg = log_msg_new_empty();
  value = log_msg_get_value_if_set_with_type(msg, log_msg_get_value_handle("FACILITY"), NULL, &type);
  cr_assert_str_eq(value, "user");
  cr_assert(type == LM_VT_STRING);

  log_msg_unref(msg);
}

Test(log_message, test_set_match_returns_the_same_value_in_get)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_match(msg, 0, "match0", -1);
  assert_log_message_match_value(msg, 0, "match0");
  log_msg_unref(msg);
}

Test(log_message, test_unset_match_returns_null)
{
  LogMessage *msg;

  msg = log_msg_new_empty();

  /* initially, it is unset */
  const gchar *value = log_msg_get_match_if_set_with_type(msg, 0, NULL, NULL);
  cr_assert(value == NULL);

  /* after setting it, it is set */
  log_msg_set_match(msg, 0, "match0", -1);
  value = log_msg_get_match_if_set_with_type(msg, 0, NULL, NULL);
  cr_assert_str_eq(value, "match0");

  /* after unset()-ing, it is unset */
  log_msg_unset_match(msg, 0);
  value = log_msg_get_match_if_set_with_type(msg, 0, NULL, NULL);
  cr_assert(value == NULL);

  log_msg_unref(msg);
}

Test(log_message, test_match_alias_numbered_macros)
{
  LogMessage *msg;

  msg = log_msg_new_empty();

  /* set $0 */
  log_msg_set_match(msg, 0, "match0", -1);

  /* check both get_value and get_match returns the same */
  assert_log_message_match_value(msg, 0, "match0");
  assert_log_message_value_by_name(msg, "0", "match0");

  /* set using set_match() */
  log_msg_set_match(msg, 0, "match0-update1", -1);
  assert_log_message_match_value(msg, 0, "match0-update1");
  assert_log_message_value_by_name(msg, "0", "match0-update1");

  /* set using set_value() */
  log_msg_set_value_by_name(msg, "0", "match0-update2", -1);
  assert_log_message_match_value(msg, 0, "match0-update2");
  assert_log_message_value_by_name(msg, "0", "match0-update2");

  /* unset using unset_match() */
  log_msg_unset_match(msg, 0);
  assert_log_message_value_unset_by_name(msg, "0");

  /* unset using unset_value() */
  log_msg_set_value_by_name(msg, "0", "match0-update3", -1);
  assert_log_message_match_value(msg, 0, "match0-update3");
  log_msg_unset_value_by_name(msg, "0");
  assert_log_message_value_unset_by_name(msg, "0");

  log_msg_set_match(msg, 128, "match128", -1);
  assert_log_message_value_by_name(msg, "128", "match128");
  log_msg_unref(msg);
}

Test(log_message, test_set_match_access_out_of_range_are_ignored)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value(msg, LM_V_MESSAGE, "dummy-value", -1);

  /* set $0 */
  log_msg_set_match(msg, 0, "match0", -1);
  log_msg_set_match(msg, 1, "match1", -1);
  log_msg_set_match(msg, 255, "match255", -1);
  assert_log_message_match_value(msg, 0, "match0");
  assert_log_message_match_value(msg, 1, "match1");
  assert_log_message_match_value(msg, 255, "match255");

  log_msg_set_match(msg, 256, "match256", -1);
  assert_log_message_match_value(msg, 256, "");

  log_msg_set_match_indirect(msg, 256, LM_V_MESSAGE, 0, 1);
  assert_log_message_match_value(msg, 256, "");

  log_msg_set_value_indirect(msg, log_msg_get_value_handle("256"), LM_V_MESSAGE, 0, 5);
  assert_log_message_value_by_name(msg, "256", "dummy");

  log_msg_unref(msg);
}

Test(log_message,
     test_value_that_looks_like_out_of_range_match_behaves_like_a_regular_nv_pair_and_cannot_be_accessed_as_a_match)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_value(msg, LM_V_MESSAGE, "dummy-value", -1);

  log_msg_set_value_indirect(msg, log_msg_get_value_handle("256"), LM_V_MESSAGE, 0, 5);
  assert_log_message_value_by_name(msg, "256", "dummy");
  assert_log_message_match_value(msg, 256, "");

  log_msg_unref(msg);
}

Test(log_message, test_log_message_updates_num_matches_according_to_matches_being_set)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  cr_assert(msg->num_matches == 0);
  log_msg_set_match(msg, 1, "match1", -1);
  cr_assert(msg->num_matches == 2);
  log_msg_set_match(msg, 2, "match2", -1);
  cr_assert(msg->num_matches == 3);
  log_msg_set_match(msg, 3, "match3", -1);
  cr_assert(msg->num_matches == 4);

  log_msg_unref(msg);
}

Test(log_message, test_format_matches_produces_a_list_of_matches_even_if_populated_via_explicit_set)
{
  LogMessage *msg;
  GString *result = g_string_new("");

  msg = log_msg_new_empty();
  log_msg_set_match(msg, 1, "match1", -1);
  log_msg_set_match(msg, 2, "match2", -1);
  log_msg_set_match(msg, 3, "match3", -1);

  log_msg_format_matches(msg, result);
  cr_assert_str_eq(result->str, "match1,match2,match3");

  log_msg_set_match(msg, 4, "match4", -1);
  g_string_truncate(result, 0);
  log_msg_format_matches(msg, result);
  cr_assert_str_eq(result->str, "match1,match2,match3,match4");

  g_string_free(result, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_format_matches_resets_match_values_if_an_out_of_range_element_is_set)
{
  LogMessage *msg;
  GString *result = g_string_new("");

  msg = log_msg_new_empty();
  log_msg_set_match(msg, 1, "match1", -1);
  log_msg_set_match(msg, 2, "match2", -1);
  log_msg_set_match(msg, 3, "match3", -1);
  log_msg_set_match(msg, 4, "match4", -1);
  log_msg_truncate_matches(msg, 4);

  log_msg_format_matches(msg, result);
  /* $4 missing due to num_matches changed */
  cr_assert_str_eq(result->str, "match1,match2,match3");

  /* $4 was set but was not part of the array, setting $7  */
  log_msg_set_match(msg, 7, "match7", -1);

  g_string_truncate(result, 0);
  log_msg_format_matches(msg, result);
  /* match 4 is unset even though it did hold a value before, the other in-between elements are similarly empty */
  cr_assert_str_eq(result->str, "match1,match2,match3,\"\",\"\",\"\",match7");

  /* fill the whole */
  log_msg_set_match(msg, 4, "updated-match4", -1);
  g_string_truncate(result, 0);
  log_msg_format_matches(msg, result);
  /* match 5 still missing as the "whole" was just filled, but that does not include match 5 */
  cr_assert_str_eq(result->str, "match1,match2,match3,updated-match4,\"\",\"\",match7");

  g_string_free(result, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_changing_num_matches_causes_numbered_matches_to_become_undefined)
{
  LogMessage *msg;
  GString *result = g_string_new("");

  msg = log_msg_new_empty();
  log_msg_set_match(msg, 1, "match1", -1);
  log_msg_set_match(msg, 2, "match2", -1);
  log_msg_set_match(msg, 3, "match3", -1);

  cr_assert_eq(msg->num_matches, 4);
  assert_log_message_match_value(msg, 3, "match3");
  log_msg_truncate_matches(msg, 3);
  assert_log_message_match_value(msg, 3, "");

  log_msg_format_matches(msg, result);
  cr_assert_str_eq(result->str, "match1,match2");

  g_string_free(result, TRUE);
  log_msg_unref(msg);
}

Test(log_message, test_clear_matches_call_resets_all_matches_to_unset)
{
  LogMessage *msg;

  msg = log_msg_new_empty();
  log_msg_set_match(msg, 0, "match0", -1);
  log_msg_set_match(msg, 1, "match1", -1);
  log_msg_set_match(msg, 2, "match2", -1);
  log_msg_set_match(msg, 3, "match3", -1);

  cr_assert_eq(msg->num_matches, 4);
  log_msg_clear_matches(msg);
  cr_assert_eq(msg->num_matches, 0);

  assert_log_message_match_value(msg, 0, "");
  assert_log_message_match_value(msg, 1, "");
  assert_log_message_match_value(msg, 2, "");
  assert_log_message_match_value(msg, 3, "");

  log_msg_unref(msg);
}

#define DEFUN_KEY_VALUE(name, key, value, size) \
  gchar name ## _key[size]; \
  gchar name ## _value[size]; \
  name ## _key[size-1] = name ## _value[size-1] = 0; \
  memset(name ## _key, key, sizeof(name ##_key)-1); \
  memset(name ## _value, value, sizeof(name ##_value)-1); \


typedef struct
{
  gssize nvtable_size_old;
  gssize nvtable_size_new;
  gssize msg_size_old;
  gssize msg_size_new;
} sizes_t;

static sizes_t
add_key_value(LogMessage *msg, gchar *key, gchar *value)
{
  sizes_t sizes;
  sizes.msg_size_old = log_msg_get_size(msg);
  sizes.nvtable_size_old = nv_table_get_memory_consumption(msg->payload);
  log_msg_set_value_by_name(msg, key, value, -1);
  sizes.nvtable_size_new = nv_table_get_memory_consumption(msg->payload);
  sizes.msg_size_new = log_msg_get_size(msg);
  return sizes;
}


static void
test_with_sdata(LogMessage *msg, guint32 old_msg_size)
{
  sizes_t sizes;
  gchar key[]          = ".SDATA.**";
  gchar value[] = "AAAAAAA";

  guint32 single_sdata_kv_size;
  guint32 sdata_payload_array_size;

  const char iter_length = 17;

  for (char i = 0; i < iter_length; i++)
    {
      g_snprintf(key, sizeof(key), ".SDATA.%02d", i);
      sizes = add_key_value(msg, key, value);

      single_sdata_kv_size = NV_ENTRY_DIRECT_HDR + NV_TABLE_BOUND(strlen(key)+1 + strlen(value)+1);

      /* i+1 is stored, but the sdata array size is calculated when adding the i-th */
      sdata_payload_array_size = STRICT_ROUND_TO_NEXT_EIGHT(i) * sizeof(msg->sdata[0]);
      cr_assert_eq(old_msg_size + (i+1) * single_sdata_kv_size + sdata_payload_array_size, sizes.msg_size_new);
    }
}

#define SMALL_LENGTH 10
#define LARGE_LENGTH 256

Test(log_message, test_message_size)
{
  LogMessage *msg = log_msg_new_empty();

  sizes_t sizes;

  DEFUN_KEY_VALUE(small, 'C', 'D', SMALL_LENGTH);
  sizes = add_key_value(msg, small_key, small_value);
  // (SMALL_LENGTH-1)*'C'+'\0' + (SMALL_LENGTH-1)*'D'+'\0'
  guint32 entry_size = NV_ENTRY_DIRECT_HDR + NV_TABLE_BOUND(SMALL_LENGTH + SMALL_LENGTH);
  cr_assert_eq(sizes.nvtable_size_old + entry_size, sizes.nvtable_size_new);
  cr_assert_eq(sizes.msg_size_old + entry_size, sizes.msg_size_new);  // Size increased because of nvtable

  guint32 msg_size = sizes.msg_size_new;
  log_msg_set_tag_by_name(msg, "test_tag_storage");
  cr_assert(log_msg_is_tag_by_name(msg, "test_tag_storage"));
  cr_assert_eq(msg_size, log_msg_get_size(msg)); // Tag is not increased until tag id 65

  char *tag_name = strdup("00tagname");
  // (*8 to convert to bits) + no need plus 1 bcause we already added one tag: test_tag_storage
  for (int i = 0; i < GLIB_SIZEOF_LONG*8; i++)
    {
      sprintf(tag_name, "%dtagname", i);
      log_msg_set_tag_by_name(msg, tag_name);
    }
  free(tag_name);
  cr_assert_eq(msg_size + 2*GLIB_SIZEOF_LONG, log_msg_get_size(msg));


  DEFUN_KEY_VALUE(big, 'A', 'B', LARGE_LENGTH);
  sizes = add_key_value(msg, big_key, big_value); // nvtable is expanded
  entry_size = NV_ENTRY_DIRECT_HDR + NV_TABLE_BOUND(LARGE_LENGTH + LARGE_LENGTH);
  cr_assert_eq(sizes.nvtable_size_old + entry_size, sizes.nvtable_size_new); // but only increased by the entry
  cr_assert_eq(sizes.msg_size_old + entry_size, sizes.msg_size_new);  // nvtable is doubled

  test_with_sdata(msg, sizes.msg_size_new);

  log_msg_unref(msg);
}

Test(log_message, when_get_indirect_value_with_null_value_len_abort_instead_of_sigsegv, .signal=SIGABRT)
{
  LogMessageTestParams *params = log_message_test_params_new();

  NVHandle indirect = log_msg_get_value_handle("INDIRECT");
  log_msg_set_value_indirect(params->message, indirect, params->nv_handle, 0, 5);
  log_msg_get_value(params->message, indirect, NULL);

  log_message_test_params_free(params);
}

Test(log_message, test_cow_writing_cloned_message)
{
  LogMessage *msg = _construct_log_message();
  log_msg_set_value_by_name(msg, "orig_name", "orig_value", -1);

  LogPathOptions path_options = LOG_PATH_OPTIONS_INIT;
  LogMessage *cloned = log_msg_clone_cow(msg, &path_options);

  log_msg_set_value_by_name(cloned, "cloned_name", "cloned_value", -1);
  log_msg_set_value_by_name(cloned, "orig_name", "modified_value", -1);

  cr_assert_str_eq(log_msg_get_value_by_name(msg, "orig_name", NULL), "orig_value",
                   "Modifications on a COW-cloned message should not leak into the original message; actual: %s, expected: %s",
                   log_msg_get_value_by_name(msg, "orig_name", NULL), "orig_value");

  NVHandle cloned_name = log_msg_get_value_handle("cloned_name");
  gssize value_length;
  cr_assert_null(log_msg_get_value_if_set(msg, cloned_name, &value_length),
                 "Modifications on a COW-cloned message should not leak into the original message");

  log_msg_unref(cloned);
  log_msg_unref(msg);
}


Test(log_message, test_cow_make_writable)
{
  LogMessage *msg = _construct_log_message();
  log_msg_set_value_by_name(msg, "orig_name", "orig_value", -1);

  log_msg_write_protect(msg);
  cr_assert(log_msg_is_write_protected(msg));

  LogMessage *orig_msg = log_msg_ref(msg);

  LogPathOptions path_options = LOG_PATH_OPTIONS_INIT;
  log_msg_make_writable(&msg, &path_options);

  log_msg_set_value_by_name(msg, "orig_name2", "orig_value2", -1);

  NVHandle orig_name2 = log_msg_get_value_handle("orig_name2");
  gssize value_length;
  cr_assert_null(log_msg_get_value_if_set(orig_msg, orig_name2, &value_length),
                 "Modifications on a COW-cloned message should not leak into the original message");

  log_msg_unref(orig_msg);
  log_msg_unref(msg);
}

Test(log_message, test_cow_unset_value)
{
  LogMessage *msg = _construct_log_message();
  log_msg_set_value_by_name(msg, "orig_name", "orig_value", -1);
  log_msg_write_protect(msg);

  LogMessage *orig_msg = log_msg_ref(msg);

  LogPathOptions path_options = LOG_PATH_OPTIONS_INIT;
  log_msg_make_writable(&msg, &path_options);

  log_msg_unset_value_by_name(msg, "orig_name");

  cr_assert_str_eq(log_msg_get_value_by_name(orig_msg, "orig_name", NULL), "orig_value",
                   "Unsetting a value in a COW-cloned message should not unset the value in the original message; actual: %s, expected: %s",
                   log_msg_get_value_by_name(orig_msg, "orig_name", NULL), "orig_value");

  log_msg_unref(orig_msg);
  log_msg_unref(msg);
}