1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858
|
*******************************************************************************
Copyright 2022 Arm Limited and affiliates.
SPDX-License-Identifier: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*******************************************************************************
diff --git a/src/cpu/aarch64/jit_uni_reorder.cpp b/src/cpu/aarch64/jit_uni_reorder.cpp
index 24d6220cf..a6cefaa20 100644
--- a/src/cpu/aarch64/jit_uni_reorder.cpp
+++ b/src/cpu/aarch64/jit_uni_reorder.cpp
@@ -1,6 +1,7 @@
/*******************************************************************************
* Copyright 2018-2021 Intel Corporation
* Copyright 2020-2021 FUJITSU LIMITED
+* Copyright 2022 Arm Ltd. and affiliates
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -54,6 +55,35 @@ namespace aarch64 {
namespace tr {
+static bool prb_has_small_strides(const prb_t &prb) {
+ constexpr ptrdiff_t max_stride = (1LL << 31) - 1;
+ for (int d = 0; d < prb.ndims; ++d) {
+ const ptrdiff_t cms = max_stride / prb.nodes[d].n;
+ const bool small_strides = true
+ && prb.nodes[d].is < cms / (int)data_type_size(prb.itype)
+ && prb.nodes[d].os < cms / (int)data_type_size(prb.otype);
+ if (!small_strides) return false;
+ }
+ return true;
+}
+
+static bool prb_tail_friendly(const prb_t &prb) {
+ /* find optimal ndims to makes it easier to
+ * identify the blk_chunk in the loop*/
+ int ndims = prb.full_ndims - prb.ndims;
+
+ int n = prb.nodes[0].is;
+ for (int d = 1; d < prb.ndims; ++d) {
+ if (d != prb.blk_chunk_idx) n *= prb.nodes[d].n;
+ }
+ if (prb.ip_tail > 0
+ && ((ndims == 0 && n != 1)
+ || (ndims > 0 && prb.ndims > prb.blk_chunk_idx)))
+ return false;
+
+ return true;
+}
+
/** Minimal reasonable/desirable kernel size.
* The constant might be used to determine how a problem should be split
* between kernel and threading driver. */
@@ -121,18 +151,10 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
&& utils::one_of(p.otype, f32, s32, data_type::s8, u8)
&& utils::everyone_is(0, p.ioff, p.ooff) /* do we need this? */
&& utils::one_of(p.beta, 0.f, 1.f) /* anything else? */
- && simple_impl_desc_init(p, nullptr);
+ && simple_impl_desc_init(p, nullptr) && prb_has_small_strides(p)
+ && prb_tail_friendly(p);
if (!ok) return false;
- const ptrdiff_t max_stride = (1LL << 31) - 1;
- for (int d = 0; d < p.ndims; ++d) {
- const ptrdiff_t cms = max_stride / p.nodes[d].n;
- bool strides_ok = true
- && p.nodes[d].is < cms / (int)data_type_size(p.itype)
- && p.nodes[d].os < cms / (int)data_type_size(p.otype);
- if (!strides_ok) return false;
- }
-
return true;
}
@@ -153,6 +175,13 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
return (int)prb_.nodes[d].ss;
}
+ int blk_cnt() {
+ assert(prb_.blk_chunk_idx < prb_.full_ndims);
+ return (int)prb_.nodes[prb_.blk_chunk_idx].n - 1;
+ }
+ int op_padding() { return prb_.op_tail ? prb_.iblock - prb_.op_tail : 0; }
+ int ip_padding() { return prb_.ip_tail ? prb_.oblock - prb_.ip_tail : 0; }
+
void step(int off, int prev_i_off, int prev_o_off, int prev_s_off,
int &i_off, int &o_off, int &s_off, int step_size = 1) {
i_off = prev_i_off;
@@ -385,6 +414,7 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
prb_.otype, u8, data_type::s8, s32, f32)))
&& utils::everyone_is(8, n(0), n(1))
&& utils::everyone_is(1, os(0), is(1))
+ && utils::everyone_is(0, prb_.ip_tail, prb_.op_tail)
&& prb_.scale_type == scale_type_t::NONE && prb_.beta == 0.f;
}
@@ -405,17 +435,14 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
bool process_direct_copy(int len) {
using namespace data_type;
- const int simd_w = cpu_isa_traits<isa>::vlen == 16
- ? cpu_isa_traits<isa>::vlen / itype_sz /* use 128-bit VReg */
- : cpu_isa_traits<isa>::vlen / itype_sz
- / 2; /* use lower half of 512-bit ZReg */
-
+ const int simd_w = cpu_isa_traits<isa>::vlen / itype_sz;
bool can_do = true && mayiuse(isa)
&& utils::everyone_is(1, os(0), is(0))
&& (false || prb_.itype == prb_.otype
|| (prb_.itype == s32 && prb_.otype == f32)
|| (prb_.itype == f32 && prb_.otype == s32))
&& len % simd_w == 0 && n(0) % len == 0
+ && prb_.ip_tail % simd_w == 0 && prb_.op_tail % simd_w == 0
&& prb_.scale_type == scale_type_t::NONE && prb_.beta == 0.f;
if (!can_do) return false;
@@ -511,7 +538,8 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
}
void process_unroll_generic_step(int reg_unroll, const int *i_off,
- const int *o_off, const int *s_off) {
+ const int *o_off, const int *s_off, const int *ip_padding,
+ const bool h_padded) {
using namespace data_type;
auto cvt2ps
@@ -571,6 +599,8 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
for (int ur = 1; ur < reg_unroll; ++ur)
if (o_off[ur] != o_off[ur - 1] + 1) can_store_xmm = false;
const int ur_step = can_store_xmm ? 4 : 1;
+ const int load_tail_step
+ = !can_load_xmm && can_store_xmm ? ur_step : load_step;
const bool interim_f32 = false
|| utils::one_of(f32, prb_.itype, prb_.otype)
@@ -579,55 +609,85 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
const bool need_saturation
= (utils::one_of(prb_.otype, u8, data_type::s8, s32)
&& interim_f32);
-
- if (!can_load_xmm && can_store_xmm) {
- assert(ur_step == 4);
- /* load with stride */
- for (int ur = 0; ur < reg_unroll; ur += ur_step) {
-
+ if (h_padded) {
+ for (int ur = 0; ur < reg_unroll; ur += load_tail_step) {
+ if (itype_sz == 4)
+ movi(VReg4S(ur), 0);
+ else if (itype_sz == 2)
+ movi(VReg8H(ur), 0);
+ else
+ movi(VReg16B(ur), 0);
/* x_tmp_vec = X_TMP_0 - X_TMP_4
Do not use X_TMP_? as the last arg. */
- for (int r = 0; r < ur_step; ++r) {
- add_imm(x_tmp_vec[r], x_ptr_in_off,
- i_off[ur + r] * itype_sz, X_DEFAULT_ADDR);
+ for (int r = 0; r < load_tail_step; ++r) {
+ if (ip_padding[ur + r] == 0) {
+ add_imm(x_tmp_vec[r], x_ptr_in_off,
+ i_off[ur + r] * itype_sz, X_DEFAULT_ADDR);
+ }
}
- for (int r = 0; r < ur_step; ++r) {
- if (itype_sz == 4)
- ld1(VReg4S(ur)[r], ptr(x_tmp_vec[r]));
- else if (itype_sz == 2)
- ld1(VReg8H(ur)[r], ptr(x_tmp_vec[r]));
- else
- ld1(VReg16B(ur)[r], ptr(x_tmp_vec[r]));
+ for (int r = 0; r < load_tail_step; ++r) {
+ if (ip_padding[ur + r] == 0) {
+ if (itype_sz == 4)
+ ld1(VReg4S(ur)[r], ptr(x_tmp_vec[r]));
+ else if (itype_sz == 2)
+ ld1(VReg8H(ur)[r], ptr(x_tmp_vec[r]));
+ else
+ ld1(VReg16B(ur)[r], ptr(x_tmp_vec[r]));
+ }
}
}
} else {
- int ur = 0;
- int tmp_ur = 0;
- while (ur < reg_unroll) {
- int count = 0;
+ if (!can_load_xmm && can_store_xmm) {
+ assert(ur_step == 4);
+ /* load with stride */
+ for (int ur = 0; ur < reg_unroll; ur += ur_step) {
- do {
- add_imm(x_tmp_vec[count++], x_ptr_in_off,
- i_off[ur] * itype_sz, X_DEFAULT_ADDR);
- ur += load_step;
- } while (ur < reg_unroll && count < x_tmp_vec_size);
+ /* x_tmp_vec = X_TMP_0 - X_TMP_4
+ Do not use X_TMP_? as the last arg. */
+ for (int r = 0; r < ur_step; ++r) {
+ add_imm(x_tmp_vec[r], x_ptr_in_off,
+ i_off[ur + r] * itype_sz, X_DEFAULT_ADDR);
+ }
- for (int i = 0; i < count; i++) {
+ for (int r = 0; r < ur_step; ++r) {
+ if (itype_sz == 4)
+ ld1(VReg4S(ur)[r], ptr(x_tmp_vec[r]));
+ else if (itype_sz == 2)
+ ld1(VReg8H(ur)[r], ptr(x_tmp_vec[r]));
+ else
+ ld1(VReg16B(ur)[r], ptr(x_tmp_vec[r]));
+ }
+ }
+ } else {
+ int ur = 0;
+ int tmp_ur = 0;
+ while (ur < reg_unroll) {
+ int count = 0;
+
+ do {
+ add_imm(x_tmp_vec[count++], x_ptr_in_off,
+ i_off[ur] * itype_sz, X_DEFAULT_ADDR);
+ ur += load_step;
+ } while (ur < reg_unroll && count < x_tmp_vec_size);
+
+ for (int i = 0; i < count; i++) {
- switch (load_step * itype_sz) {
- case 16: ldr(QReg(tmp_ur), ptr(x_tmp_vec[i])); break;
- case 8: ldr(DReg(tmp_ur), ptr(x_tmp_vec[i])); break;
- case 4: ldr(SReg(tmp_ur), ptr(x_tmp_vec[i])); break;
- case 2: ldr(HReg(tmp_ur), ptr(x_tmp_vec[i])); break;
- case 1: ldr(BReg(tmp_ur), ptr(x_tmp_vec[i])); break;
- default: assert(!"unreachable");
+ switch (load_step * itype_sz) {
+ case 16:
+ ldr(QReg(tmp_ur), ptr(x_tmp_vec[i]));
+ break;
+ case 8: ldr(DReg(tmp_ur), ptr(x_tmp_vec[i])); break;
+ case 4: ldr(SReg(tmp_ur), ptr(x_tmp_vec[i])); break;
+ case 2: ldr(HReg(tmp_ur), ptr(x_tmp_vec[i])); break;
+ case 1: ldr(BReg(tmp_ur), ptr(x_tmp_vec[i])); break;
+ default: assert(!"unreachable");
+ }
+ tmp_ur += load_step;
}
- tmp_ur += load_step;
}
}
}
-
/* xmm[:] <-- (f32)xmm[:] */
if (interim_f32) {
const int cvt_step = nstl::max(load_step, ur_step);
@@ -708,7 +768,8 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
if (s_off[r] != s_off[r - 1] + 0)
scale_load_type = scale_load_type_t::load;
- if (scale_load_type == scale_load_type_t::bcast) {
+ if (scale_load_type == scale_load_type_t::bcast
+ && !h_padded) {
VReg4S v(xmm_scale.getIdx());
VReg4S v_dst(ur);
add_imm(X_TMP_0, x_ptr_scale_off, s_off[ur] * stype_sz,
@@ -724,7 +785,8 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
if (s_off[r] != s_off[r - 1] + 1)
scale_load_type = scale_load_type_t::gather;
- if (scale_load_type == scale_load_type_t::load) {
+ if (scale_load_type == scale_load_type_t::load
+ && !h_padded) {
uint32_t idx = xmm_scale.getIdx();
VReg4S v_dst(ur);
add_imm(X_TMP_0, x_ptr_scale_off, s_off[ur] * stype_sz,
@@ -739,14 +801,18 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
// so gather the scale factors one by one
/*ur_step is 1 or 4. */
for (int r = ur; r < ur + ur_step; ++r) {
- /* x_tmp_vec = X_TMP_0 - X_TMP_4
+ if (ip_padding[r] == 0 || !h_padded) {
+ /* x_tmp_vec = X_TMP_0 - X_TMP_4
Do not use X_TMP_? as the last arg. */
- add_imm(x_tmp_vec[r - ur], x_ptr_scale_off,
- s_off[r] * stype_sz, X_DEFAULT_ADDR);
+ add_imm(x_tmp_vec[r - ur], x_ptr_scale_off,
+ s_off[r] * stype_sz, X_DEFAULT_ADDR);
+ }
}
for (int r = ur; r < ur + ur_step; ++r) {
- VReg4S v(xmm_scale.getIdx());
- ld1(v[r - ur], ptr(x_tmp_vec[r - ur]));
+ if (ip_padding[r] == 0 || !h_padded) {
+ VReg4S v(xmm_scale.getIdx());
+ ld1(v[r - ur], ptr(x_tmp_vec[r - ur]));
+ }
}
fmul(VReg4S(ur), VReg4S(ur), xmm_scale);
}
@@ -925,7 +991,15 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
}
}
- void process_unroll_generic(int len) {
+ void comp_padding_flag(int ndims, int off, int len, int &i_tail) {
+ const int ip_without_padding
+ = ndims == 0 ? len - ip_padding() : prb_.ip_tail;
+ if ((ndims == 0 && off >= ip_without_padding)
+ || (ndims > 0 && (off % prb_.oblock) >= ip_without_padding))
+ i_tail = 1;
+ }
+
+ void process_unroll_generic(const int ndims, int len, const bool h_padded) {
const int blk = 8;
int i_off[2 * blk] = {0};
@@ -936,22 +1010,37 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
for (int off = 0; off < len; off += blk) {
const int reg_unroll = nstl::min(off + blk, len) - off;
+ int ip_padding[blk] = {0};
- /* compute offsets */
+ /* compute offsets and tail*/
for (int ur = off != 0 ? 0 : 1; ur < reg_unroll; ++ur) {
const int ur_c = curr * blk + ur;
const int ur_p = (ur_c - 1 + 2 * blk) % (2 * blk); // prev ur
step(off + ur, i_off[ur_p], o_off[ur_p], s_off[ur_p],
i_off[ur_c], o_off[ur_c], s_off[ur_c]);
+ if (h_padded)
+ comp_padding_flag(ndims, off + ur, len, ip_padding[ur]);
}
-
process_unroll_generic_step(reg_unroll, i_off + curr * blk,
- o_off + curr * blk, s_off + curr * blk);
+ o_off + curr * blk, s_off + curr * blk, ip_padding,
+ h_padded);
curr = 1 - curr;
}
}
+ void compute_ker(
+ const int ndims, const int len_unroll, const bool h_padded) {
+ bool optimized = false;
+ optimized = optimized
+ || (process_direct_copy<sve_256>(len_unroll) && !h_padded);
+ optimized = optimized
+ || (process_direct_copy<asimd>(len_unroll) && !h_padded);
+ optimized
+ = optimized || (process_unroll_tr8x8(len_unroll) && !h_padded);
+ if (!optimized) process_unroll_generic(ndims, len_unroll, h_padded);
+ }
+
void loop_begin(Label &l, XReg reg_cnt, int len) {
mov(reg_cnt, len);
L(l);
@@ -985,6 +1074,28 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
}
}
+ void compute_blk_ker(const int len_unroll) {
+ int omp_ndims = prb_.full_ndims - prb_.ndims;
+ Label no_last_blk, end_label;
+
+ if (prb_.ip_tail > 0 && prb_.op_tail == 0) {
+ if (omp_ndims == 0) {
+ cmp(reg_last_loop_cnt, 1);
+ bne(no_last_blk);
+ compute_ker(omp_ndims, len_unroll, true);
+ } else {
+ cmp(reg_blk_chunks, blk_cnt());
+ bne(no_last_blk);
+ compute_ker(omp_ndims, len_unroll, true);
+ }
+ b(end_label);
+ }
+
+ L(no_last_blk);
+ compute_ker(omp_ndims, len_unroll, false);
+ L(end_label);
+ }
+
bool simple_impl() {
simple_impl_desc_t d;
if (!simple_impl_desc_init(prb_, &d)) return false;
@@ -1013,11 +1124,7 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
if (n_jit_loops > 0)
loop_begin(l_loop[0], reg_cnt[0], n(nfu + 0) / ldu);
- bool optimized = false;
- optimized = optimized || process_direct_copy<sve_512>(d.len_unroll);
- optimized = optimized || process_direct_copy<asimd>(d.len_unroll);
- optimized = optimized || process_unroll_tr8x8(d.len_unroll);
- if (!optimized) process_unroll_generic(d.len_unroll);
+ compute_blk_ker(d.len_unroll);
if (n_jit_loops > 0)
loop_end(l_loop[0], reg_cnt[0], n(nfu + 0) / ldu, is(nfu + 0) * ldu,
@@ -1236,9 +1343,13 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
}
add_imm(X_TMP_0, abi_param1, PARAM(in), X_TMP_2);
add_imm(X_TMP_1, abi_param1, PARAM(out), X_TMP_2);
+ add_imm(reg_blk, abi_param1, PARAM(blk_chunks), reg_blk);
ldr(reg_ptr_in, ptr(X_TMP_0));
ldr(reg_ptr_out, ptr(X_TMP_1));
+ ldr(reg_blk_chunks, ptr(reg_blk));
+
#undef PARAM
+ mov_imm(reg_last_loop_cnt, 1);
mov(x_ptr_in_off, XReg(reg_ptr_in.getIdx()));
mov(x_ptr_out_off, XReg(reg_ptr_out.getIdx()));
@@ -1282,6 +1393,10 @@ private:
XReg reg_off_out = x9;
XReg reg_off_scale = x10;
+ XReg reg_blk = x11;
+ XReg reg_blk_chunks = x12;
+ XReg reg_last_loop_cnt = x11;
+
XReg reg_tmp = x0;
VReg4S xmm_scale = v15.s;
@@ -1416,10 +1531,16 @@ static void prb_thread_kernel_balance(
for (int d = 0; d < prb.ndims; ++d)
sz_total *= prb.nodes[d].n;
+ /* The general expression for sz_drv_thr can be written as
+ * sz_drv_min = C0 + FC * (nthr > 1 ? 1 : 0) + VC * (nthr - 1)
+ * where FC and VC are fixed and variable costs respectively.
+ * Though for now, the below heuristic seems to be good enough */
+ const size_t sz_drv_thr = (nthr > 1) ? 16 * nthr : 1;
+
/* sz_drv_min is the minimal size for the parallel
* driver required for good parallelization */
const size_t sz_drv_min
- = nstl::min<size_t>(16 * nthr, utils::div_up(sz_total, 1024));
+ = nstl::min<size_t>(sz_drv_thr, utils::div_up(sz_total, 1024));
/* kdims -- # of dimensions processed by a kernel
* sz_ker_cur -- product of the dimension processed by a kernel
@@ -1440,7 +1561,8 @@ static void prb_thread_kernel_balance(
* (less than tr::ker_prb_size_min). In that case try to split the
* innermost driver dimension into two, to increase sz_ker_cur. */
bool want_borrow_ker_from_drv = true && kdims < prb.ndims
- && sz_ker_cur < tr::ker_prb_size_min && sz_drv_cur > sz_drv_min;
+ && sz_ker_cur < tr::ker_prb_size_min && sz_drv_cur > sz_drv_min
+ && kdims != prb.blk_chunk_idx;
if (want_borrow_ker_from_drv) {
/* sz_want_borrow is the minimal sz, so that:
* o) sz_ker_cur * sz_want_borrow >= tr::ker_prb_size_min
@@ -1464,7 +1586,7 @@ static void prb_thread_kernel_balance(
* try to split the outermost kernel dimension into two, to increase
* sz_drv_cur. */
bool want_borrow_drv_from_ker = true && sz_ker_cur > tr::ker_prb_size_min
- && sz_drv_cur < sz_drv_min;
+ && sz_drv_cur < sz_drv_min && kdims != prb.blk_chunk_idx;
if (want_borrow_drv_from_ker) {
size_t sz_want_borrow = utils::div_up(sz_drv_min, sz_drv_cur);
for (; prb.nodes[kdims - 1].n % sz_want_borrow; ++sz_want_borrow)
@@ -1518,6 +1640,8 @@ status_t jit_uni_reorder_t::pd_t::create(reorder_pd_t **reorder_pd,
prb_dump(prb);
});
+ CHECK(prb_check_blk(prb, *dst_md));
+
int ndims_ker_max;
int nthr = dnnl_get_max_threads();
prb_thread_kernel_balance(prb, ndims_ker_max, nthr);
@@ -1552,7 +1676,7 @@ status_t jit_uni_reorder_t::pd_t::create(reorder_pd_t **reorder_pd,
void jit_uni_reorder_t::omp_driver_0d(
int off, const char *in, char *out, const float *scale) const {
- tr::call_param_t c {in, out, scale};
+ tr::call_param_t c {in, out, scale, 0};
(*kernel_)(&c);
}
@@ -1564,6 +1688,7 @@ void jit_uni_reorder_t::omp_driver_1d(int ithr, int nthr, int off,
c.in = in + d0 * ns[0].is * data_type_size(pd()->prb_.itype);
c.out = out + d0 * ns[0].os * data_type_size(pd()->prb_.otype);
c.scale = scale + d0 * ns[0].ss;
+ c.blk_chunks = d0;
(*kernel_)(&c);
});
}
@@ -1571,6 +1696,7 @@ void jit_uni_reorder_t::omp_driver_1d(int ithr, int nthr, int off,
void jit_uni_reorder_t::omp_driver_2d(int ithr, int nthr, int off,
const char *in, char *out, const float *scale) const {
const tr::node_t *ns = pd()->prb_.nodes + off;
+ const int blk_idx_off = pd()->prb_.blk_chunk_idx - off;
for_nd(ithr, nthr, (ptrdiff_t)ns[1].n, (ptrdiff_t)ns[0].n,
[&](ptrdiff_t d1, ptrdiff_t d0) {
auto c = tr::call_param_t();
@@ -1581,6 +1707,7 @@ void jit_uni_reorder_t::omp_driver_2d(int ithr, int nthr, int off,
+ (d0 * ns[0].os + d1 * ns[1].os)
* data_type_size(pd()->prb_.otype);
c.scale = scale + d0 * ns[0].ss + d1 * ns[1].ss;
+ c.blk_chunks = utils::pick(blk_idx_off, d0, d1);
(*kernel_)(&c);
});
}
@@ -1588,6 +1715,7 @@ void jit_uni_reorder_t::omp_driver_2d(int ithr, int nthr, int off,
void jit_uni_reorder_t::omp_driver_3d(int ithr, int nthr, int off,
const char *in, char *out, const float *scale) const {
const tr::node_t *ns = pd()->prb_.nodes + off;
+ const int blk_idx_off = pd()->prb_.blk_chunk_idx - off;
for_nd(ithr, nthr, (ptrdiff_t)ns[2].n, (ptrdiff_t)ns[1].n,
(ptrdiff_t)ns[0].n, [&](ptrdiff_t d2, ptrdiff_t d1, ptrdiff_t d0) {
auto c = tr::call_param_t();
@@ -1598,6 +1726,7 @@ void jit_uni_reorder_t::omp_driver_3d(int ithr, int nthr, int off,
+ (d0 * ns[0].os + d1 * ns[1].os + d2 * ns[2].os)
* data_type_size(pd()->prb_.otype);
c.scale = scale + d0 * ns[0].ss + d1 * ns[1].ss + d2 * ns[2].ss;
+ c.blk_chunks = utils::pick(blk_idx_off, d0, d1, d2);
(*kernel_)(&c);
});
}
@@ -1605,6 +1734,7 @@ void jit_uni_reorder_t::omp_driver_3d(int ithr, int nthr, int off,
void jit_uni_reorder_t::omp_driver_4d(int ithr, int nthr, int off,
const char *in, char *out, const float *scale) const {
const tr::node_t *ns = pd()->prb_.nodes + off;
+ const int blk_idx_off = pd()->prb_.blk_chunk_idx - off;
for_nd(ithr, nthr, (ptrdiff_t)ns[3].n, (ptrdiff_t)ns[2].n,
(ptrdiff_t)ns[1].n, (ptrdiff_t)ns[0].n,
[&](ptrdiff_t d3, ptrdiff_t d2, ptrdiff_t d1, ptrdiff_t d0) {
@@ -1619,6 +1749,7 @@ void jit_uni_reorder_t::omp_driver_4d(int ithr, int nthr, int off,
* data_type_size(pd()->prb_.otype);
c.scale = scale + d0 * ns[0].ss + d1 * ns[1].ss + d2 * ns[2].ss
+ d3 * ns[3].ss;
+ c.blk_chunks = utils::pick(blk_idx_off, d0, d1, d2, d3);
(*kernel_)(&c);
});
}
diff --git a/src/cpu/aarch64/jit_uni_reorder.hpp b/src/cpu/aarch64/jit_uni_reorder.hpp
index 88762756c..2fb6f0f89 100644
--- a/src/cpu/aarch64/jit_uni_reorder.hpp
+++ b/src/cpu/aarch64/jit_uni_reorder.hpp
@@ -1,6 +1,7 @@
/*******************************************************************************
* Copyright 2018-2020 Intel Corporation
* Copyright 2020 FUJITSU LIMITED
+* Copyright 2022 Arm Ltd. and affiliates
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -52,11 +53,19 @@ struct prb_t {
ptrdiff_t ooff;
scale_type_t scale_type;
float beta;
+ int full_ndims;
+ int ip_tail;
+ int op_tail;
+ int iblock;
+ int oblock;
+ int blk_chunk_idx;
};
status_t prb_init(prb_t &prb, const memory_desc_t &imd,
const memory_desc_t &omd, const primitive_attr_t *attr);
+status_t prb_check_blk(prb_t &prb, const memory_desc_t &imd);
+
/** sorts the problem nodes so that output strides come in ascending order */
void prb_normalize(prb_t &p);
@@ -82,6 +91,7 @@ struct call_param_t {
const void *in;
void *out;
const float *scale;
+ size_t blk_chunks;
};
struct kernel_t {
diff --git a/src/cpu/aarch64/jit_uni_reorder_utils.cpp b/src/cpu/aarch64/jit_uni_reorder_utils.cpp
index 3d6e424e3..7123811f8 100644
--- a/src/cpu/aarch64/jit_uni_reorder_utils.cpp
+++ b/src/cpu/aarch64/jit_uni_reorder_utils.cpp
@@ -1,6 +1,7 @@
/*******************************************************************************
* Copyright 2018-2021 Intel Corporation
* Copyright 2020 FUJITSU LIMITED
+* Copyright 2022 Arm Ltd. and affiliates
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -15,7 +16,8 @@
* limitations under the License.
*******************************************************************************/
-#include <assert.h>
+#include <cassert>
+#include <set>
#include "common/c_types_map.hpp"
#include "common/dnnl_thread.hpp"
@@ -46,8 +48,65 @@ struct layout_desc_t {
strides_t strides;
};
-status_t cvt_mem_desc_to_layout_desc(
- const memory_desc_t &md_, layout_desc_t &ld, const dims_t &blocks) {
+static status_t compute_blk_and_tail(
+ const memory_desc_t &md_, const int idx, int &blk, int &tail) {
+ const auto md = memory_desc_wrapper(md_);
+ const auto &bd = md.blocking_desc();
+ if (tail == 0) return status::success;
+
+ const std::set<dim_t> unique_inner_idxs(
+ bd.inner_idxs, bd.inner_idxs + bd.inner_nblks);
+ std::set<dim_t> dims_with_multiple_blks;
+ for (dim_t dim : unique_inner_idxs) {
+ if (std::count(bd.inner_idxs, bd.inner_idxs + bd.inner_nblks, dim) > 1)
+ dims_with_multiple_blks.insert(dim);
+ }
+
+ // Dims that have a tail and have multiple blocks are not supported by the jit kernel yet.
+ // For example:
+ // src_tag = abcd
+ // dst_tag = ABcd16b16a4b
+ // 16x15x3x3
+ // In this case, 'b' dim has two blocks and has a tail. It is not a supported case.
+ if (dims_with_multiple_blks.find(idx) != dims_with_multiple_blks.end())
+ return status::unimplemented;
+
+ // Only supports inconsistent padding in single and double blocks
+ // and the total block size <= 256
+ for (int iblk = bd.inner_nblks - 1; iblk > 0; --iblk) {
+ if (bd.inner_idxs[iblk] == idx) break;
+ blk *= bd.inner_blks[iblk];
+ tail *= bd.inner_blks[iblk];
+ }
+ if (unique_inner_idxs.size() > 2 || blk > 256) return status::unimplemented;
+
+ return status::success;
+}
+
+static status_t compute_chunk_idx(const prb_t &p, const memory_desc_t &imd_,
+ const memory_desc_t &omd_, const int blk_idx, int &chunk_idx) {
+ const auto imd = memory_desc_wrapper(imd_);
+ const auto omd = memory_desc_wrapper(omd_);
+ const auto &ibd = imd.blocking_desc();
+ const auto &obd = omd.blocking_desc();
+ if (p.ip_tail == 0 && p.op_tail == 0) return status::success;
+
+ const ptrdiff_t is
+ = ibd.strides[blk_idx] * obd.inner_blks[obd.inner_idxs[blk_idx]];
+ const ptrdiff_t os = obd.strides[blk_idx];
+
+ for (int i = blk_idx; i < omd.ndims(); ++i) {
+ if (p.nodes[i].os == os && p.nodes[i].is == is) {
+ chunk_idx = i;
+ return status::success;
+ }
+ }
+
+ return status::invalid_arguments;
+}
+
+status_t cvt_mem_desc_to_layout_desc(const memory_desc_t &md_,
+ layout_desc_t &ld, const dims_t &blocks, const dims_t &ext_padding) {
const auto md = memory_desc_wrapper(md_);
bool ok = true && md.is_blocking_desc() && md.extra().flags == 0;
@@ -75,7 +134,7 @@ status_t cvt_mem_desc_to_layout_desc(
stride *= bd.inner_blks[iblk];
}
}
- P(d, md.padded_dims()[d] / blocks[d], bd.strides[d]);
+ P(d, (md.padded_dims()[d] + ext_padding[d]) / blocks[d], bd.strides[d]);
// TODO: NOW: revisit, do we need a reverse?
// TODO: NOW: consider using strides instead of block sizes in md
@@ -98,7 +157,8 @@ status_t prb_init(prb_t &p, const memory_desc_t &imd, const memory_desc_t &omd,
auto check_post_ops = [](const primitive_attr_t *attr) {
const auto &po = attr->post_ops_;
- return po.len() == 0 || (po.len() == 1 && po.entry_[0].is_sum(false));
+ return po.len() == 0
+ || (po.len() == 1 && po.contain(primitive_kind::sum, 0));
};
bool ok = im_d.is_blocking_desc() && om_d.is_blocking_desc()
@@ -110,26 +170,58 @@ status_t prb_init(prb_t &p, const memory_desc_t &imd, const memory_desc_t &omd,
&& check_post_ops(attr);
if (!ok) return unimplemented;
- dims_t iblocks, oblocks;
+ dims_t iblocks, oblocks, ip_padding, op_padding;
im_d.compute_blocks(iblocks);
om_d.compute_blocks(oblocks);
+ utils::array_set(ip_padding, 0, im_d.ndims());
+ utils::array_set(op_padding, 0, om_d.ndims());
+
+ /* padding_dim consistency check
+ * only supports inconsitent padding for src
+ * TODO: Add inconsistent padding support for dst */
+ int ip_tail = 0;
+ int op_tail = 0;
+ int iblk_w_tail = 1;
+ int oblk_w_tail = 1;
+ int blk_idx = 0;
- /* padding_dim consistency check */
for (int d = 0; d < im_d.ndims(); ++d) {
- const auto pdim = im_d.padded_dims()[d];
- bool ok = true && pdim == om_d.padded_dims()[d]
- && pdim % iblocks[d] == 0 && pdim % oblocks[d] == 0;
- if (!ok) return unimplemented;
+ const int ip_tmp_dim = im_d.padded_dims()[d];
+ const int op_tmp_dim = om_d.padded_dims()[d];
+ const int ip_tmp_tail = ip_tmp_dim % oblocks[d];
+ const int op_tmp_tail = op_tmp_dim % iblocks[d];
+
+ const bool pdim_consistent = ip_tmp_dim == op_tmp_dim
+ && ip_tmp_tail == 0 && op_tmp_tail == 0;
+ const bool pdim_tail = ip_tmp_tail > 0
+ && (ip_tmp_dim + oblocks[d] - ip_tmp_tail) == op_tmp_dim
+ && op_tmp_tail == 0 && ip_tail == 0;
+ if (!pdim_consistent && !pdim_tail) return status::unimplemented;
+ if (pdim_tail) {
+ blk_idx = d;
+ ip_tail = ip_tmp_tail;
+ op_tail = op_tmp_tail;
+ iblk_w_tail = iblocks[d];
+ oblk_w_tail = oblocks[d];
+ ip_padding[d] = oblocks[d] - ip_tmp_tail;
+ op_padding[d] = iblocks[d] - op_tmp_tail;
+ }
}
+ CHECK(compute_blk_and_tail(omd, blk_idx, oblk_w_tail, ip_tail));
layout_desc_t ild, old;
- status_t status = cvt_mem_desc_to_layout_desc(imd, ild, iblocks);
+ status_t status
+ = cvt_mem_desc_to_layout_desc(imd, ild, iblocks, ip_padding);
if (status != success) return status;
- status = cvt_mem_desc_to_layout_desc(omd, old, oblocks);
+ status = cvt_mem_desc_to_layout_desc(omd, old, oblocks, op_padding);
if (status != success) return status;
p.itype = ild.dt;
p.otype = old.dt;
+ p.ip_tail = ip_tail;
+ p.op_tail = op_tail;
+ p.iblock = iblk_w_tail;
+ p.oblock = oblk_w_tail;
p.scale_type = attr->output_scales_.has_default_values()
? scale_type_t::NONE
@@ -156,7 +248,6 @@ status_t prb_init(prb_t &p, const memory_desc_t &imd, const memory_desc_t &omd,
while (i_pos < ild.ndims && o_pos < old.ndims) {
assert(ild.id[i_pos] == old.id[o_pos]);
- if (ild.id[i_pos] != old.id[o_pos]) return runtime_error;
assert(ndims < max_ndims);
if (ndims == max_ndims) return runtime_error;
@@ -191,7 +282,12 @@ status_t prb_init(prb_t &p, const memory_desc_t &imd, const memory_desc_t &omd,
ild.dims[i_pos] = factor;
}
}
+ int blk_chunk_idx = ndims;
+ CHECK(compute_chunk_idx(p, imd, omd, blk_idx, blk_chunk_idx));
+
p.ndims = ndims;
+ p.full_ndims = ndims;
+ p.blk_chunk_idx = blk_chunk_idx;
p.ioff = memory_desc_wrapper(imd).offset0();
p.ooff = memory_desc_wrapper(omd).offset0();
@@ -211,8 +307,28 @@ void prb_normalize(prb_t &p) {
&& p.nodes[j].n < p.nodes[min_pos].n);
if (new_min) min_pos = j;
}
- if (min_pos != d) nstl::swap(p.nodes[d], p.nodes[min_pos]);
+ if (min_pos != d) {
+ nstl::swap(p.nodes[d], p.nodes[min_pos]);
+ if (p.blk_chunk_idx == min_pos || p.blk_chunk_idx == d)
+ p.blk_chunk_idx = p.blk_chunk_idx == min_pos ? d : min_pos;
+ }
+ }
+}
+
+status_t prb_check_blk(prb_t &p, const memory_desc_t &md_) {
+ const auto md = memory_desc_wrapper(md_);
+ const auto &bd = md.blocking_desc();
+ if (p.ip_tail == 0) return status::success;
+
+ // Check if the inner blocks and p.nodes[blk].n in the firsti nblks
+ // is equivalent in reverse order when has tail in block layout.
+ const int nblk = bd.inner_nblks;
+ for (int iblk = 0; iblk < nblk; ++iblk) {
+ if (bd.inner_blks[nblk - iblk - 1]
+ != static_cast<ptrdiff_t>(p.nodes[iblk].n))
+ return status::unimplemented;
}
+ return status::success;
}
void prb_simplify(prb_t &p) {
@@ -225,18 +341,29 @@ void prb_simplify(prb_t &p) {
for (int d = 0; d < p.ndims - 1; ++d) {
auto &this_node = p.nodes[d + 0];
auto &next_node = p.nodes[d + 1];
+ const bool skip_blk_idx = (p.ip_tail > 0 || p.op_tail > 0)
+ && (p.blk_chunk_idx == d || p.blk_chunk_idx == d + 1);
const bool fold = false
- || next_node.n == (size_t)1 // trivial case, just drop next node
+ || (next_node.n == static_cast<size_t>(1)
+ && !skip_blk_idx) // trivial case, just drop next node
|| (true // or real folding if possible
- && next_node.is == (ptrdiff_t)this_node.n * this_node.is
- && next_node.os == (ptrdiff_t)this_node.n * this_node.os
+ && !skip_blk_idx
+ && next_node.is
+ == static_cast<ptrdiff_t>(
+ this_node.n * this_node.is)
+ && next_node.os
+ == static_cast<ptrdiff_t>(
+ this_node.n * this_node.os)
&& next_node.ss
- == (ptrdiff_t)this_node.n * this_node.ss);
+ == static_cast<ptrdiff_t>(
+ this_node.n * this_node.ss));
if (fold) {
this_node.n *= next_node.n;
for (int j = d + 2; j < p.ndims; ++j)
p.nodes[j - 1] = p.nodes[j];
+ if (d < p.blk_chunk_idx) --p.blk_chunk_idx;
--p.ndims;
+ --p.full_ndims;
--d; // make another try
}
}
@@ -251,6 +378,8 @@ void prb_node_split(prb_t &p, int dim, size_t n1) {
assert(p.nodes[dim].n % n1 == 0);
p.ndims += 1;
+ p.full_ndims += 1;
+ if (dim < p.blk_chunk_idx) p.blk_chunk_idx += 1;
for (int d = p.ndims; d > dim + 1; --d)
p.nodes[d] = p.nodes[d - 1];
|