1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204
|
From: Nico Grunbaum <na-g@nostrum.com>
Date: Wed, 27 Nov 2024 03:41:00 +0000
Subject: Bug 1921154 - libwebrtc build related changes for
AV1;r=mjf,webrtc-reviewers
These are most of the changes needed to get a build with AV1.
The crypto/openssl changes are later altered in the stack adding an NSPR based implementation of the functionality that was missing.
Differential Revision: https://phabricator.services.mozilla.com/D228540
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/4527c41ef71d7683c60d9c435991a0d93bc5ce4d
---
BUILD.gn | 4 ++++
media/BUILD.gn | 24 ++++++++++++++----------
rtc_base/BUILD.gn | 44 ++++++++++++++++++++++++--------------------
webrtc.gni | 4 ++--
4 files changed, 44 insertions(+), 32 deletions(-)
diff --git a/BUILD.gn b/BUILD.gn
index ce8fc4db57..b5a65f0591 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -525,6 +525,9 @@ if (!rtc_build_ssl) {
"crypto",
"ssl",
]
+ if (build_with_mozilla) {
+ libs = []
+ }
}
}
@@ -619,6 +622,7 @@ if (!build_with_chromium) {
"api/environment:environment_factory",
"api/video:video_frame",
"api/video:video_rtp_headers",
+ "api/video_codecs:builtin_video_decoder_factory",
"test:rtp_test_utils",
]
# Added when we removed deps in other places to avoid building
diff --git a/media/BUILD.gn b/media/BUILD.gn
index 6387ca64c6..13900012f5 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -12,12 +12,10 @@ import("../webrtc.gni")
group("media") {
deps = []
- if (!build_with_mozilla) {
- deps += [
- ":rtc_media",
- ":rtc_media_base",
- ]
- }
+ deps += [
+ ":rtc_media",
+ ":rtc_media_base",
+ ]
}
config("rtc_media_defines_config") {
@@ -282,6 +280,9 @@ rtc_library("media_engine") {
"base/media_engine.cc",
"base/media_engine.h",
]
+ deps -= [
+ ":media_channel_impl",
+ ]
}
}
@@ -431,6 +432,7 @@ rtc_library("codec_list") {
]
}
+# MOZILLA Bug 1931241 - how much of this do we need?
rtc_library("rtp_utils") {
if (!build_with_mozilla) {
sources = [
@@ -477,7 +479,6 @@ rtc_library("media_constants") {
}
rtc_library("turn_utils") {
-if (!build_with_mozilla) {
sources = [
"base/turn_utils.cc",
"base/turn_utils.h",
@@ -488,17 +489,14 @@ if (!build_with_mozilla) {
"../rtc_base/system:rtc_export",
]
}
-}
rtc_library("rid_description") {
-if (!build_with_mozilla) {
sources = [
"base/rid_description.cc",
"base/rid_description.h",
]
deps = [ ":codec" ]
}
-}
rtc_library("rtc_simulcast_encoder_adapter") {
visibility = [ "*" ]
@@ -717,6 +715,12 @@ rtc_library("rtc_audio_video") {
"engine/webrtc_voice_engine.cc",
"engine/webrtc_voice_engine.h",
]
+ if (build_with_mozilla) {
+ sources -= [
+ "engine/webrtc_video_engine.cc",
+ "engine/webrtc_voice_engine.cc",
+ ]
+ }
public_configs = []
if (!build_with_chromium) {
diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn
index 6f807ddf57..337d7f6106 100644
--- a/rtc_base/BUILD.gn
+++ b/rtc_base/BUILD.gn
@@ -1500,29 +1500,32 @@ rtc_source_set("ssl_header") {
}
rtc_source_set("digest") {
- visibility = [ "*" ]
- sources = [
- "message_digest.cc",
- "message_digest.h",
- "openssl_digest.cc",
- "openssl_digest.h",
- ]
- deps = [
- ":checks",
- ":ssl_header",
- ":stringutils",
- "//third_party/abseil-cpp/absl/strings:string_view",
- ]
-
- # If we are building the SSL library ourselves, we know it's BoringSSL.
- if (rtc_build_ssl) {
- deps += [ "//third_party/boringssl" ]
- } else {
- configs += [ "..:external_ssl_library" ]
- }
+if (!build_with_mozilla) {
+ visibility = [ "*" ]
+ sources = [
+ "message_digest.cc",
+ "message_digest.h",
+ "openssl_digest.cc",
+ "openssl_digest.h",
+ ]
+ deps = [
+ ":checks",
+ ":ssl_header",
+ ":stringutils",
+ "//third_party/abseil-cpp/absl/strings:string_view",
+ ]
+
+ # If we are building the SSL library ourselves, we know it's BoringSSL.
+ if (rtc_build_ssl) {
+ deps += [ "//third_party/boringssl" ]
+ } else {
+ configs += [ "..:external_ssl_library" ]
+ }
+}
}
rtc_library("crypto_random") {
+if (!build_with_mozilla) {
visibility = [ "*" ]
sources = [
"crypto_random.cc",
@@ -1543,6 +1546,7 @@ rtc_library("crypto_random") {
configs += [ "..:external_ssl_library" ]
}
}
+}
rtc_library("ssl") {
if (!build_with_mozilla) {
diff --git a/webrtc.gni b/webrtc.gni
index e533341b0f..7c0e9d6dfc 100644
--- a/webrtc.gni
+++ b/webrtc.gni
@@ -125,7 +125,7 @@ declare_args() {
# Used to specify an external OpenSSL include path when not compiling the
# library that comes with WebRTC (i.e. rtc_build_ssl == 0).
- rtc_ssl_root = "unused"
+ rtc_ssl_root = ""
# Enable when an external authentication mechanism is used for performing
# packet authentication for RTP packets instead of libsrtp.
@@ -352,7 +352,7 @@ declare_args() {
}
# Enable liboam only on non-mozilla builds.
-enable_libaom = !build_with_mozilla
+enable_libaom = true
# Make it possible to provide custom locations for some libraries (move these
# up into declare_args should we need to actually use them for the GN build).
|