1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
|
(ns puppetlabs.trapperkeeper.services.webserver.jetty9-service-override-settings-test
(:require [clojure.test :refer :all]
[puppetlabs.trapperkeeper.app :refer [get-service]]
[puppetlabs.trapperkeeper.services :as tk-services]
[puppetlabs.trapperkeeper.services.webserver.jetty9-service
:refer :all]
[puppetlabs.trapperkeeper.testutils.webserver.common :refer :all]
[puppetlabs.trapperkeeper.testutils.bootstrap
:refer [with-app-with-config]]
[puppetlabs.trapperkeeper.testutils.logging
:refer [with-test-logging]]
[schema.test :as schema-test]
[puppetlabs.trapperkeeper.testutils.webserver :as testutils]))
(use-fixtures :once
schema-test/validate-schemas
testutils/assert-clean-shutdown)
(def dev-resources-config-dir (str dev-resources-dir "config/jetty/"))
(def jetty-ssl-no-certs-config
{:webserver {:ssl-host "0.0.0.0"
:ssl-port 9001}})
(def jetty-plaintext-multiserver-override-config
{:webserver {:bar {:port 8080
:default-server true}
:foo {:port 9000}}})
(deftest test-override-webserver-settings!
(let [ssl-port 9001
overrides {:ssl-port ssl-port
:ssl-host "0.0.0.0"
:ssl-cert
(str dev-resources-config-dir
"ssl/certs/localhost.pem")
:ssl-cert-chain
(str dev-resources-config-dir
"ssl/certs/ca.pem")
:ssl-key
(str dev-resources-config-dir
"ssl/private_keys/localhost.pem")
:ssl-ca-cert
(str dev-resources-config-dir
"ssl/certs/ca.pem")
:ssl-crl-path
(str dev-resources-config-dir
"ssl/crls/crls_none_revoked.pem")}]
(testing "config override of all SSL settings before webserver starts is
successful"
(let [override-result (atom nil)
service1 (tk-services/service
[[:WebserverService override-webserver-settings!]]
(init [this context]
(reset! override-result
(override-webserver-settings!
overrides))
context))]
(with-test-logging
(with-app-with-config
app
[jetty9-service service1]
jetty-plaintext-multiserver-override-config
(let [s (get-service app :WebserverService)
add-ring-handler (partial add-ring-handler s)
body "Hi World"
path "/hi_world"
ring-handler (fn [req] {:status 200 :body body})]
(add-ring-handler ring-handler path)
(let [response (http-get
(format "https://localhost:%d%s/" ssl-port path)
default-options-for-https-client)]
(is (= (:status response) 200)
"Unsuccessful http response code ring handler response.")
(is (= (:body response) body)
"Unexpected body in ring handler response."))))
(is (logged? #"^webserver config overridden for key 'ssl-port'")
"Didn't find log message for override of 'ssl-port'")
(is (logged? #"^webserver config overridden for key 'ssl-host'")
"Didn't find log message for override of 'ssl-host'")
(is (logged? #"^webserver config overridden for key 'ssl-cert'")
"Didn't find log message for override of 'ssl-cert'")
(is (logged?
#"^webserver config overridden for key 'ssl-cert-chain'")
"Didn't find log message for override of 'ssl-cert-chain'")
(is (logged? #"^webserver config overridden for key 'ssl-key'")
"Didn't find log message for override of 'ssl-key'")
(is (logged? #"^webserver config overridden for key 'ssl-ca-cert'")
"Didn't find log message for override of 'ssl-ca-cert'")
(is (logged? #"^webserver config overridden for key 'ssl-crl-path'")
"Didn't find log message for override of 'ssl-crl-path'"))
(is (= overrides @override-result)
"Unexpected response to override-webserver-settings! call.")))
(testing "config override of all SSL settings before webserver starts is
successful when specifying a specific server"
(let [override-result (atom nil)
service1 (tk-services/service
[[:WebserverService override-webserver-settings!]]
(init [this context]
(reset! override-result
(override-webserver-settings!
:foo overrides))
context))]
(with-test-logging
(with-app-with-config
app
[jetty9-service service1]
jetty-multiserver-plaintext-config
(let [s (get-service app :WebserverService)
add-ring-handler (partial add-ring-handler s)
body "Hi World"
path "/hi_world"
ring-handler (fn [req] {:status 200 :body body})]
(add-ring-handler ring-handler path {:server-id :foo})
(let [response (http-get
(format "https://localhost:%d%s/" ssl-port path)
default-options-for-https-client)]
(is (= (:status response) 200)
"Unsuccessful http response code ring handler response.")
(is (= (:body response) body)
"Unexpected body in ring handler response."))))
(is (logged? #"^webserver config overridden for key 'ssl-port'")
"Didn't find log message for override of 'ssl-port'")
(is (logged? #"^webserver config overridden for key 'ssl-host'")
"Didn't find log message for override of 'ssl-host'")
(is (logged? #"^webserver config overridden for key 'ssl-cert'")
"Didn't find log message for override of 'ssl-cert'")
(is (logged? #"^webserver config overridden for key 'ssl-key'")
"Didn't find log message for override of 'ssl-key'")
(is (logged? #"^webserver config overridden for key 'ssl-ca-cert'")
"Didn't find log message for override of 'ssl-ca-cert'")
(is (logged? #"^webserver config overridden for key 'ssl-crl-path'")
"Didn't find log message for override of 'ssl-crl-path'"))
(is (= overrides @override-result)
"Unexpected response to override-webserver-settings! call.")))
(testing "SSL certificate settings can be overridden while other settings
from the config are still honored -- ssl-port and ssl-host"
(let [override-result (atom nil)
overrides {:ssl-cert
(str dev-resources-config-dir
"ssl/certs/localhost.pem")
:ssl-key
(str dev-resources-config-dir
"ssl/private_keys/localhost.pem")
:ssl-ca-cert
(str dev-resources-config-dir
"ssl/certs/ca.pem")}
service1 (tk-services/service
[[:WebserverService override-webserver-settings!]]
(init [this context]
(reset! override-result
(override-webserver-settings!
overrides))
context))]
(with-app-with-config
app
[jetty9-service service1]
jetty-ssl-no-certs-config
(let [s (get-service app :WebserverService)
add-ring-handler (partial add-ring-handler s)
body "Hi World"
path "/hi_world"
ring-handler (fn [req] {:status 200 :body body})]
(add-ring-handler ring-handler path)
(let [response (http-get
(format "https://localhost:%d%s/" ssl-port path)
default-options-for-https-client)]
(is (= (:status response) 200)
"Unsuccessful http response code ring handler response.")
(is (= (:body response) body)
"Unexpected body in ring handler response."))))
(is (= overrides @override-result)
"Unexpected response to override-webserver-settings! call.")))
(testing "attempt to override SSL settings fails when override call made
after webserver has already started"
(let [override-result (atom nil)
service1 (tk-services/service [])]
(with-app-with-config
app
[jetty9-service service1]
jetty-plaintext-config
(let [s (get-service app :WebserverService)
override-webserver-settings! (partial
override-webserver-settings!
s)]
(is (thrown-with-msg? java.lang.IllegalStateException
#"overrides cannot be set because webserver has already processed the config"
(override-webserver-settings! overrides)))))))
(testing "second attempt to override SSL settings fails"
(let [second-override-result (atom nil)
service1 (tk-services/service
[[:WebserverService
override-webserver-settings!]]
(init [this context]
(override-webserver-settings!
overrides)
(reset!
second-override-result
(is
(thrown-with-msg?
IllegalStateException
#"overrides cannot be set because they have already been set"
(override-webserver-settings!
overrides))))
context))]
(with-app-with-config
app
[jetty9-service service1]
jetty-plaintext-config
(let [s (get-service app :WebserverService)
add-ring-handler (partial add-ring-handler s)
body "Hi World"
path "/hi_world"
ring-handler (fn [req] {:status 200 :body body})]
(add-ring-handler ring-handler path)
(let [response (http-get
(format "https://localhost:%d%s/" ssl-port path)
default-options-for-https-client)]
(is (= (:status response) 200)
"Unsuccessful http response code ring handler response.")
(is (= (:body response) body)
"Unexpected body in ring handler response."))))
(is (instance? IllegalStateException @second-override-result)
"Second call to setting overrides did not throw expected exception.")))))
|
