File: instantiator_test.py

package info (click to toggle)
ufo2ft 3.7.0-2
  • links: PTS, VCS
  • area: main
  • in suites: forky
  • size: 6,624 kB
  • sloc: python: 18,685; makefile: 3
file content (1349 lines) | stat: -rw-r--r-- 52,036 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
import logging

import fontTools.designspaceLib as designspaceLib
import pytest
from fontTools.pens.recordingPen import RecordingPen

import ufo2ft.instantiator
from ufo2ft.util import openFont, openFontFactory


def test_interpolation_weight_width_class(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    for instance in designspace.instances:
        instance.font = generator.generate_instance(instance)

    # LightCondensed
    font = designspace.instances[0].font
    assert font.info.openTypeOS2WeightClass == 1
    assert font.info.openTypeOS2WidthClass == 1

    # BoldCondensed
    font = designspace.instances[1].font
    assert font.info.openTypeOS2WeightClass == 1000
    assert font.info.openTypeOS2WidthClass == 1

    # LightWide
    font = designspace.instances[2].font
    assert font.info.openTypeOS2WeightClass == 1
    assert font.info.openTypeOS2WidthClass == 9

    # BoldWide
    font = designspace.instances[3].font
    assert font.info.openTypeOS2WeightClass == 1000
    assert font.info.openTypeOS2WidthClass == 9

    # Medium_Narrow_I
    font = designspace.instances[4].font
    assert font.info.openTypeOS2WeightClass == 500
    assert font.info.openTypeOS2WidthClass == 9

    # Medium_Wide_I
    font = designspace.instances[5].font
    assert font.info.openTypeOS2WeightClass == 500
    assert font.info.openTypeOS2WidthClass == 9

    # Two
    font = designspace.instances[6].font
    assert font.info.openTypeOS2WeightClass == 1000
    assert font.info.openTypeOS2WidthClass == 9

    # One
    font = designspace.instances[7].font
    assert font.info.openTypeOS2WeightClass == 500
    assert font.info.openTypeOS2WidthClass == 9


def test_default_groups_only(ufo_module, data_dir, caplog):
    """Test that only the default source's groups end up in instances."""

    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )
    d.addSourceDescriptor(location={"Weight": 300}, font=ufo_module.Font())
    d.addSourceDescriptor(location={"Weight": 900}, font=ufo_module.Font())
    d.addInstanceDescriptor(styleName="2", location={"Weight": 400})

    d.sources[0].font.groups["public.kern1.GRK_alpha_alt_LC_1ST"] = [
        "alpha.alt",
        "alphatonos.alt",
    ]
    d.sources[1].font.groups["public.kern1.GRK_alpha_LC_1ST"] = [
        "alpha.alt",
        "alphatonos.alt",
    ]

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)
    assert "contains different groups than the default source" in caplog.text

    instance = generator.generate_instance(d.instances[0])
    assert instance.groups == {
        "public.kern1.GRK_alpha_alt_LC_1ST": ["alpha.alt", "alphatonos.alt"]
    }


def test_default_groups_only2(ufo_module, data_dir, caplog):
    """Test that the group difference warning is not triggered if non-default
    source groups are empty."""

    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )
    d.addSourceDescriptor(location={"Weight": 300}, font=ufo_module.Font())
    d.addSourceDescriptor(location={"Weight": 900}, font=ufo_module.Font())
    d.addInstanceDescriptor(styleName="2", location={"Weight": 400})

    d.sources[0].font.groups["public.kern1.GRK_alpha_alt_LC_1ST"] = [
        "alpha.alt",
        "alphatonos.alt",
    ]

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)
    assert "contains different groups than the default source" not in caplog.text

    instance = generator.generate_instance(d.instances[0])
    assert instance.groups == {
        "public.kern1.GRK_alpha_alt_LC_1ST": ["alpha.alt", "alphatonos.alt"]
    }


def test_interpolation_no_rounding(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    designspace.instances[4].location = {"weight": 123.456, "width": 789.123}
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=False
    )

    instance_font = generator.generate_instance(designspace.instances[4])
    assert isinstance(instance_font.info.ascender, float)
    assert isinstance(instance_font.kerning[("A", "J")], float)
    assert isinstance(instance_font["A"].contours[0][0].x, float)


def test_interpolation_rounding(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    designspace.instances[4].location = {"weight": 123.456, "width": 789.123}
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[4])
    assert isinstance(instance_font.info.ascender, int)
    assert isinstance(instance_font.kerning[("A", "J")], int)
    assert isinstance(instance_font["A"].contours[0][0].x, int)


def test_weight_class_from_wght_axis():
    assert ufo2ft.instantiator.weight_class_from_wght_value(-500) == 1
    assert ufo2ft.instantiator.weight_class_from_wght_value(1.1) == 1
    assert ufo2ft.instantiator.weight_class_from_wght_value(1) == 1
    assert ufo2ft.instantiator.weight_class_from_wght_value(500.6) == 501
    assert ufo2ft.instantiator.weight_class_from_wght_value(1000) == 1000
    assert ufo2ft.instantiator.weight_class_from_wght_value(1000.0) == 1000
    assert ufo2ft.instantiator.weight_class_from_wght_value(1000.1) == 1000
    assert ufo2ft.instantiator.weight_class_from_wght_value(2000.1) == 1000


def test_width_class_from_wdth_axis():
    assert ufo2ft.instantiator.width_class_from_wdth_value(-500) == 1
    assert ufo2ft.instantiator.width_class_from_wdth_value(50) == 1
    assert ufo2ft.instantiator.width_class_from_wdth_value(62.5) == 2
    assert ufo2ft.instantiator.width_class_from_wdth_value(75) == 3
    assert ufo2ft.instantiator.width_class_from_wdth_value(87.5) == 4
    assert ufo2ft.instantiator.width_class_from_wdth_value(100) == 5
    assert ufo2ft.instantiator.width_class_from_wdth_value(112) == 6
    assert ufo2ft.instantiator.width_class_from_wdth_value(112.5) == 6
    assert ufo2ft.instantiator.width_class_from_wdth_value(125) == 7
    assert ufo2ft.instantiator.width_class_from_wdth_value(130) == 7
    assert ufo2ft.instantiator.width_class_from_wdth_value(150) == 8
    assert ufo2ft.instantiator.width_class_from_wdth_value(190) == 9
    assert ufo2ft.instantiator.width_class_from_wdth_value(200) == 9
    assert ufo2ft.instantiator.width_class_from_wdth_value(1000) == 9


def test_swap_glyph_names(ufo_module, data_dir):
    ufo = openFont(data_dir / "SwapGlyphNames" / "A.ufo", ufo_module=ufo_module)

    ufo2ft.instantiator.swap_glyph_names(ufo, "a", "a.swap")

    # Test swapped outlines.
    assert ufo["a"].unicode == 0x61
    assert len(ufo["a"]) == 1
    assert len(ufo["a"][0]) == 8
    assert ufo["a"].width == 666
    assert ufo["a.swap"].unicode is None
    assert len(ufo["a.swap"]) == 1
    assert len(ufo["a.swap"][0]) == 4
    assert ufo["a.swap"].width == 600

    # Test swapped components.
    assert sorted(c.baseGlyph for c in ufo["aaa"].components) == [
        "a.swap",
        "a.swap",
        "x",
    ]
    assert sorted(c.baseGlyph for c in ufo["aaa.swap"].components) == ["a", "a", "y"]

    # Test swapped anchors.
    assert [dict(a) for a in ufo["a"].anchors] == [
        dict(x=153, y=0, name="bottom"),
        dict(x=153, y=316, name="top"),
    ]
    assert [dict(a) for a in ufo["a.swap"].anchors] == [
        dict(x=351, y=0, name="bottom"),
        dict(x=351, y=613, name="top"),
    ]

    # Test swapped glyph kerning.
    assert ufo.kerning == {
        ("public.kern1.a", "x"): 10,
        ("public.kern1.aswap", "x"): 20,
        ("a", "y"): 40,
        ("a.swap", "y"): 30,
        ("y", "a"): 60,
        ("y", "a.swap"): 50,
    }

    # Test swapped group membership.
    assert ufo.groups == {
        "public.kern1.a": ["a.swap"],
        "public.kern1.aswap": ["a"],
        "public.kern2.a": ["a.swap", "a"],
    }

    # Swap a second time.
    ufo2ft.instantiator.swap_glyph_names(ufo, "aaa", "aaa.swap")

    # Test swapped glyphs.
    assert sorted(c.baseGlyph for c in ufo["aaa"].components) == ["a", "a", "y"]
    assert sorted(c.baseGlyph for c in ufo["aaa.swap"].components) == [
        "a.swap",
        "a.swap",
        "x",
    ]

    # Test for no leftover temporary glyphs.
    assert {g.name for g in ufo} == {
        "space",
        "a",
        "a.swap",
        "aaa",
        "aaa.swap",
        "x",
        "y",
    }

    with pytest.raises(ufo2ft.instantiator.InstantiatorError, match="Cannot swap"):
        ufo2ft.instantiator.swap_glyph_names(ufo, "aaa", "aaa.swapa")


def test_swap_glyph_names_spec(ufo_module, data_dir):
    """Test that the rule example in the designspaceLib spec works.

    `adieresis` should look the same as before the rule application.

    [1]: fonttools/Doc/source/designspaceLib#ufo-instances
    """
    ufo = openFont(data_dir / "SwapGlyphNames" / "B.ufo", ufo_module=ufo_module)
    ufo2ft.instantiator.swap_glyph_names(ufo, "a", "a.alt")

    assert sorted(c.baseGlyph for c in ufo["adieresis"].components) == [
        "a.alt",
        "dieresiscomb",
    ]
    assert sorted(c.baseGlyph for c in ufo["adieresis.alt"].components) == [
        "a",
        "dieresiscomb",
    ]


def test_rules_are_applied_deterministically(ufo_module, data_dir):
    """Test that a combination of designspace rules that end up mapping
    serveral input glyphs to the same destination glyph result in a correct and
    deterministic series of glyph swaps.

    The example is a font with 2 Q designs that depend on a style axis
        style < 0.5: Q        style >= 0.5: Q.ss01
    and each Q also has an alternative shape in bolder weights (like Skia)
        weight < 780: Q       weight >= 780: Q.alt
        weight < 730: Q.ss01  weight >= 730: Q.ss01.alt

    Then we generate an instance at style = 1, weight = 900. From the rules,
    the default CMAP entry for Q should have the outlines of Q.ss01.alt from
    the black UFO.
    """
    doc = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceRuleOrder" / "MyFont.designspace"
    )
    doc.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(doc)
    instance = generator.generate_instance(doc.instances[0])
    pen = RecordingPen()
    instance["Q"].draw(pen)
    instance_recording = pen.value

    black_ufo = openFont(
        data_dir / "DesignspaceRuleOrder" / "MyFont_Black.ufo", ufo_module=ufo_module
    )
    pen = RecordingPen()
    black_ufo["Q.ss01.alt"].draw(pen)
    black_ufo_recording = pen.value

    assert instance_recording == black_ufo_recording


def test_raise_no_default_master(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans_no_default.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))

    with pytest.raises(ufo2ft.instantiator.InstantiatorError, match="no default"):
        ufo2ft.instantiator.Instantiator.from_designspace(
            designspace, round_geometry=True
        )


def test_raise_failed_glyph_interpolation(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceBrokenTest" / "DesignspaceTest.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(designspace)

    with pytest.raises(
        ufo2ft.instantiator.InstantiatorError, match="Failed to generate instance"
    ):
        for instance in designspace.instances:
            instance.font = generator.generate_instance(instance)


def test_ignore_failed_glyph_interpolation(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceBrokenTest" / "DesignspaceTest.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(designspace)
    generator.skip_export_glyphs.append("asas")

    for instance in designspace.instances:
        instance.font = generator.generate_instance(instance)
        assert (
            not instance.font["asas"].contours and not instance.font["asas"].components
        )


def test_raise_anisotropic_location(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans-width-only.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    designspace.instances[0].location["width"] = (100, 900)

    with pytest.raises(
        ufo2ft.instantiator.InstantiatorError, match="anisotropic instance locations"
    ):
        ufo2ft.instantiator.Instantiator.from_designspace(
            designspace, round_geometry=True
        )


def test_copy_nonkerning_group(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(designspace)

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.groups == {
        "nonkerning_group": ["A"],
        "public.kern2.asdf": ["A"],
    }


def test_interpolation(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font["l"].width == 220


def test_interpolation_only_default(ufo_module, data_dir, caplog):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    for name in designspace.default.font.glyphOrder:
        if name != "A":
            del designspace.default.font[name]

    with caplog.at_level(logging.WARNING):
        generator = ufo2ft.instantiator.Instantiator.from_designspace(
            designspace, round_geometry=True
        )
    assert "contains glyphs that are missing from the" in caplog.text

    instance_font = generator.generate_instance(designspace.instances[0])
    assert {g.name for g in instance_font} == {"A"}


def test_interpolation_masters_as_instances(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir
        / "DesignspaceBrokenTest"
        / "Designspace-MastersAsInstances.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.styleName == "Light ASDF"
    assert instance_font["l"].width == 160
    instance_font = generator.generate_instance(designspace.instances[1])
    assert instance_font.info.styleName == "Bold ASDF"
    assert instance_font["l"].width == 280


def test_non_default_layer(ufo_module, data_dir, caplog):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans-non-default-layer.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )
    instance_font = generator.generate_instance(designspace.instances[0])
    assert {g.name for g in instance_font} == {"A", "S", "W"}


def test_instance_attributes(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-instance-attrs.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.familyName == "aaa"
    assert instance_font.info.styleName == "sss"
    assert instance_font.info.postscriptFontName == "ppp"
    assert instance_font.info.styleMapFamilyName == "yyy"
    assert instance_font.info.styleMapStyleName == "xxx"


def test_instance_no_attributes(ufo_module, data_dir, caplog):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-bare.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    with caplog.at_level(logging.WARNING):
        instance_font = generator.generate_instance(designspace.instances[0])
    assert "missing the stylename attribute" in caplog.text

    assert instance_font.info.familyName == "MyFont"
    assert instance_font.info.styleName == "Light"
    assert instance_font.info.postscriptFontName is None
    assert instance_font.info.styleMapFamilyName is None
    assert instance_font.info.styleMapStyleName is None


def test_instance_lib_attributes(ufo_module, data_dir, caplog):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSans" / "MutatorSans.designspace"
    )
    designspace.instances[0].lib["public.fontInfo"] = {
        "openTypeOS2Panose": [
            2,
            11,
            5,
            4,
            2,
            2,
            2,
            2,
            2,
            4,
        ],
        "invalidFontInfoAttribute": "foobarbaz",
    }
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    with caplog.at_level(logging.WARNING):
        instance_font = generator.generate_instance(designspace.instances[0])

    assert instance_font.info.openTypeOS2Panose == [2, 11, 5, 4, 2, 2, 2, 2, 2, 4]
    assert (
        "Font 'MutatorMathTest' at instance location {'width': 0.0, 'weight': 0.0} "
        "has an unknown font info attribute 'invalidFontInfoAttribute' "
        "with value foobarbaz. This will be ignored."
    ) in caplog.text

    instance_font2 = generator.generate_instance(designspace.instances[1])
    assert instance_font2.info.openTypeOS2Panose is None


def test_axis_mapping(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-wght-wdth.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.openTypeOS2WeightClass == 400
    assert instance_font.info.openTypeOS2WidthClass == 5
    assert instance_font.info.italicAngle is None
    assert instance_font.lib["designspace.location"] == [
        ("weight", 100.0),
        ("width", 100.0),
    ]


def test_axis_mapping_manual_os2_classes(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-wght-wdth.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    designspace.sources[0].font.info.openTypeOS2WeightClass = 800
    designspace.sources[0].font.info.openTypeOS2WidthClass = 7
    designspace.sources[1].font.info.openTypeOS2WeightClass = 900
    designspace.sources[1].font.info.openTypeOS2WidthClass = 9
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.openTypeOS2WeightClass == 850
    assert instance_font.info.openTypeOS2WidthClass == 8
    assert instance_font.info.italicAngle is None
    assert instance_font.lib["designspace.location"] == [
        ("weight", 100.0),
        ("width", 100.0),
    ]


def test_axis_mapping_no_os2_width_class_inference(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-bare.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    designspace.sources[0].font.info.openTypeOS2WeightClass = 800
    designspace.sources[1].font.info.openTypeOS2WeightClass = 900
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.openTypeOS2WeightClass == 850
    assert instance_font.info.openTypeOS2WidthClass is None
    assert instance_font.info.italicAngle is None
    assert instance_font.lib["designspace.location"] == [("weight", 100.0)]


def test_axis_mapping_no_os2_class_inference(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-opsz.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.openTypeOS2WeightClass is None
    assert instance_font.info.openTypeOS2WidthClass is None
    assert instance_font.info.italicAngle is None
    assert instance_font.lib["designspace.location"] == [("optical", 15.0)]


def test_axis_mapping_italicAngle_inference(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-slnt.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.info.openTypeOS2WeightClass is None
    assert instance_font.info.openTypeOS2WidthClass is None
    assert instance_font.info.italicAngle == 40.123
    assert instance_font.lib["designspace.location"] == [("slant", 40.123)]


def test_lib_into_instance(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-lib.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    assert designspace.default.font.lib["blorb"] == "asasa"
    assert "public.skipExportGlyphs" not in designspace.sources[0].font.lib

    instance_font = generator.generate_instance(designspace.instances[0])
    assert instance_font.lib["blorb"] == "asasa"
    assert instance_font.lib["public.skipExportGlyphs"] == ["a", "b", "c"]

    instance_font2 = generator.generate_instance(designspace.instances[1])
    assert instance_font2.lib["blorb"] == "asasa"
    assert instance_font2.lib["public.skipExportGlyphs"] == ["a", "b", "c"]


def test_font_info_fallback_in_instance(ufo_module, data_dir):
    """Test that font info attributes are correctly copied according to the designspace
    docs fallback rules [1]. Notes: language "de" is 0x0407/1031.

    [1]:https://fonttools.readthedocs.io/en/stable/designspaceLib/index.html#common-lib-key-registry
    """
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-name.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )

    def assert_name_record_in_list(name_record, name_record_list):
        matched_name_records = [
            x
            for x in name_record_list
            if x["platformID"] == name_record["platformID"]
            and x["encodingID"] == name_record["encodingID"]
            and x["languageID"] == name_record["languageID"]
            and x["nameID"] == name_record["nameID"]
        ]
        # only one name record should match with given platformID,
        # encodingID, languageID, nameID
        assert len(matched_name_records) == 1
        # and the string value should match
        assert matched_name_records[0]["string"] == name_record["string"]

    # font info from the default source
    assert designspace.default.font.info.familyName == "MyFont"
    assert designspace.default.font.info.styleName == "Light"
    assert designspace.default.font.info.xHeight == 0
    assert designspace.default.font.info.openTypeNameRecords is None
    assert designspace.default.font.info.openTypeNameSampleText is None
    assert designspace.default.font.info.postscriptFontName == "MyFont-Light"
    # font info from the designspace root lib
    assert designspace.lib["public.fontInfo"]["familyName"] == "MyFont VF"
    assert designspace.lib["public.fontInfo"]["styleName"] == "Regular"
    assert designspace.lib["public.fontInfo"]["versionMajor"] == 1
    assert designspace.lib["public.fontInfo"]["versionMinor"] == 0
    assert designspace.lib["public.fontInfo"]["xHeight"] == 50
    assert "openTypeNameSampleText" not in designspace.lib["public.fontInfo"]
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 0,
            "string": "Urheberrecht 2025",
        },
        designspace.lib["public.fontInfo"]["openTypeNameRecords"],
    )

    # instance 0 has no instance font info, should use root lib attributes
    assert designspace.instances[0].lib == {}
    assert designspace.instances[0].familyName is None
    assert designspace.instances[0].styleName is None
    instance_light_font = generator.generate_instance(designspace.instances[0])
    assert instance_light_font.info.familyName == "MyFont VF"
    assert instance_light_font.info.styleName == "Regular"
    assert instance_light_font.info.versionMajor == 1
    assert instance_light_font.info.versionMinor == 0
    assert instance_light_font.info.xHeight == 50
    assert instance_light_font.info.openTypeNameSampleText is None
    # although the default source defines a 'postscriptFontName', this is considered
    # instance-specific and does not be copied (unless when there's only one source
    # and can unambiguously be copied to all instances, as they'll all be at the
    # default location, see `test_static_font_default_instance_inherits_all_fontinfo`
    assert instance_light_font.info.postscriptFontName is None
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 0,
            "string": "Urheberrecht 2025",
        },
        instance_light_font.info.openTypeNameRecords,
    )

    # instance 4 add new fontinfo attributes
    assert (
        designspace.instances[4].lib["public.fontInfo"]["openTypeNameSampleText"]
        == "Sample text for Bold instance"
    )
    assert designspace.instances[4].familyName == "MyFont"
    assert designspace.instances[4].styleName == "Bold"
    assert designspace.instances[4].localisedFamilyName == {"de": "MehrNamenTest"}
    assert designspace.instances[4].localisedStyleName == {}
    assert designspace.instances[4].localisedStyleMapFamilyName == {}
    assert designspace.instances[4].localisedStyleMapStyleName == {}
    assert {
        "platformID": 3,
        "encodingID": 1,
        "languageID": 1031,
        "nameID": 19,
        "string": "Beispieltext für die Fettschrift",
    } in designspace.instances[4].lib["public.fontInfo"]["openTypeNameRecords"]
    instance_bold_font = generator.generate_instance(designspace.instances[4])
    assert instance_bold_font.info.familyName == "MyFont"
    assert instance_bold_font.info.styleName == "Bold"
    assert (
        instance_bold_font.info.openTypeNameSampleText
        == "Sample text for Bold instance"
    )
    # check if lib-public.fontInfo-openTypeNameRecords is merged correctly
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 0,
            "string": "Urheberrecht 2025",
        },
        instance_bold_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 1,
            "string": "MehrNamenTest",
        },
        instance_bold_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 16,
            "string": "MehrNamenTest",
        },
        instance_bold_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 19,
            "string": "Beispieltext für die Fettschrift",
        },
        instance_bold_font.info.openTypeNameRecords,
    )

    # instance 1 has font info and multilingual familyName attributes,
    # but stylemapfamilyname not in, should autogenerate from familyName
    assert designspace.instances[1].familyName == "MyFont"
    assert designspace.instances[1].styleName == "SemiLight"
    assert designspace.instances[1].localisedFamilyName == {"de": "MehrNamenTest"}
    assert designspace.instances[1].localisedStyleName == {"de": "HalbLeicht"}
    assert designspace.instances[1].localisedStyleMapFamilyName == {}
    assert designspace.instances[1].localisedStyleMapStyleName == {}
    instance_semilight_font = generator.generate_instance(designspace.instances[1])
    assert instance_semilight_font.info.familyName == "MyFont"
    assert instance_semilight_font.info.styleName == "SemiLight"
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 16,
            "string": "MehrNamenTest",
        },
        instance_semilight_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 17,
            "string": "HalbLeicht",
        },
        instance_semilight_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 1,
            "string": "MehrNamenTest HalbLeicht",
        },
        instance_semilight_font.info.openTypeNameRecords,
    )
    # check if lib-public.fontInfo-openTypeNameRecords is merged correctly
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 0,
            "string": "Urheberrecht 2025",
        },
        instance_semilight_font.info.openTypeNameRecords,
    )

    # instance 2 has font info and all multilingual familyName attributes
    assert designspace.instances[2].localisedFamilyName == {"de": "MehrNamenTest"}
    assert designspace.instances[2].localisedStyleName == {"de": "DemiLeicht"}
    assert designspace.instances[2].localisedStyleMapFamilyName == {
        "de": "MehrNamenTest DemiLeichtx"
    }
    assert designspace.instances[2].localisedStyleMapStyleName == {"de": "Regular"}
    instance_demilight_font = generator.generate_instance(designspace.instances[2])
    assert len(instance_demilight_font.info.openTypeNameRecords) == 5
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 16,
            "string": "MehrNamenTest",
        },
        instance_demilight_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 17,
            "string": "DemiLeicht",
        },
        instance_demilight_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 1,
            "string": "MehrNamenTest DemiLeichtx",
        },
        instance_demilight_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 0x0407,
            "nameID": 2,
            "string": "Regular",
        },
        instance_demilight_font.info.openTypeNameRecords,
    )
    # check if lib-public.fontInfo-openTypeNameRecords is merged correctly
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 0,
            "string": "Urheberrecht 2025",
        },
        instance_demilight_font.info.openTypeNameRecords,
    )

    # instance 3 introduce fontinfo overrides
    assert designspace.instances[3].familyName == "MyFont"
    assert designspace.instances[3].styleName == "Regular"
    assert designspace.instances[3].lib["public.fontInfo"]["versionMajor"] == 3
    assert designspace.instances[3].lib["public.fontInfo"]["versionMinor"] == 141
    assert designspace.instances[3].lib["public.fontInfo"]["xHeight"] == 70
    assert designspace.instances[3].localisedFamilyName == {"de": "MehrNamenTest"}
    assert designspace.instances[3].localisedStyleName == {}
    assert designspace.instances[3].localisedStyleMapFamilyName == {}
    assert designspace.instances[3].localisedStyleMapStyleName == {}
    assert {
        "platformID": 3,
        "encodingID": 1,
        "languageID": 1031,
        "nameID": 0,
        "string": "Urheberrecht 2025 Overriden",
    } in designspace.instances[3].lib["public.fontInfo"]["openTypeNameRecords"]
    instance_regular_font = generator.generate_instance(designspace.instances[3])
    assert instance_regular_font.info.familyName == "MyFont"
    assert instance_regular_font.info.styleName == "Regular"
    assert instance_regular_font.info.versionMajor == 3
    assert instance_regular_font.info.versionMinor == 141
    assert instance_regular_font.info.xHeight == 70
    # check if lib-public.fontInfo-openTypeNameRecords is merged correctly
    # same platformID, encodingID, languageID, nameID should only exist once
    assert len(instance_regular_font.info.openTypeNameRecords) == 3
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 0,
            "string": "Urheberrecht 2025 Overriden",
        },
        instance_regular_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 1,
            "string": "MehrNamenTest",
        },
        instance_regular_font.info.openTypeNameRecords,
    )
    assert_name_record_in_list(
        {
            "platformID": 3,
            "encodingID": 1,
            "languageID": 1031,
            "nameID": 16,
            "string": "MehrNamenTest",
        },
        instance_regular_font.info.openTypeNameRecords,
    )


def test_font_info_fallback_should_skip_english_in_localized(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "BagelFatOne-Regular.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))

    # fontmake calls `splitInterpolable` before constructing the Instantiator.
    # It does that to split a v5 designspace which may contain discrete axes into
    # 'interpolable' sub-designspaces. This code also handles generating instance
    # names from STAT-related elements like axis <labelname>. As part of this, it
    # can sometimes add "en" (English) names to the sub-doc instances' localized
    # names (English names are normally defined in the instance attributes, but
    # subsequent designspaceLib code wants to access all the instance names via
    # the same localized* interface).
    # The uf2ft code in Instantiator._generate_instance_info that handles
    # the localized instance names currently does not distinguish between the
    # true localized names and these "en" name duplicates, and ends up
    # writing unnecessary openTypeNameRecords for the latter.
    [(_, designspace2)] = designspaceLib.split.splitInterpolable(designspace)
    assert designspace.instances[0].localisedFamilyName == {}
    assert designspace2.instances[0].localisedFamilyName == {"en": "Bagel Fat One"}

    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace2, round_geometry=True
    )

    instance_font = generator.generate_instance(designspace2.instances[0])

    assert instance_font.info.familyName == "Bagel Fat One"
    assert instance_font.info.styleName == "Regular"
    assert instance_font.info.openTypeNameRecords is None


def test_data_independence(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )
    instance_font1 = generator.generate_instance(designspace.instances[0])
    designspace.instances[0].lib["aaaaaaaa"] = 1
    instance_font2 = generator.generate_instance(designspace.instances[0])

    instance_font1["l"].unicodes.append(2)
    assert instance_font1["l"].unicodes == [0x6C, 2]
    assert instance_font2["l"].unicodes == [0x6C]

    instance_font1["l"].lib["asdf"] = 1
    assert instance_font1["l"].lib == {"asdf": 1}
    assert not instance_font2["l"].lib

    generator.copy_lib["sdjkhsjdhjdf"] = 1
    instance_font1.lib["asdf"] = 1
    assert instance_font1.lib == {
        "asdf": 1,
        "blorb": "asasa",
        "designspace.location": [("weight", 100.0)],
        "public.skipExportGlyphs": [],
    }
    assert instance_font2.lib == {
        "blorb": "asasa",
        "designspace.location": [("weight", 100.0)],
        "public.skipExportGlyphs": [],
    }

    assert generator.copy_info.openTypeOS2Panose == [2, 11, 5, 4, 2, 2, 2, 2, 2, 4]
    generator.copy_info.openTypeOS2Panose.append(1000)
    assert instance_font1.info.openTypeOS2Panose == [2, 11, 5, 4, 2, 2, 2, 2, 2, 4]
    assert instance_font2.info.openTypeOS2Panose == [2, 11, 5, 4, 2, 2, 2, 2, 2, 4]

    # copy_feature_text not tested because it is a(n immutable) string

    assert not generator.skip_export_glyphs
    generator.skip_export_glyphs.extend(["a", "b"])
    assert not instance_font1.lib["public.skipExportGlyphs"]
    assert not instance_font2.lib["public.skipExportGlyphs"]
    instance_font1.lib["public.skipExportGlyphs"].append("z")
    assert not instance_font2.lib["public.skipExportGlyphs"]


def test_skipped_fontinfo_attributes():
    """Test that we consider all available font info attributes for copying."""
    import fontMath.mathInfo
    import fontTools.ufoLib

    SKIPPED_ATTRS = {
        "guidelines",
        "macintoshFONDFamilyID",
        "macintoshFONDName",
        "openTypeNameCompatibleFullName",
        "openTypeNamePreferredFamilyName",
        "openTypeNamePreferredSubfamilyName",
        "openTypeNameUniqueID",
        "openTypeNameWWSFamilyName",
        "openTypeNameWWSSubfamilyName",
        "postscriptFontName",
        "postscriptFullName",
        "postscriptUniqueID",
        "styleMapFamilyName",
        "styleMapStyleName",
        "styleName",
        "woffMetadataUniqueID",
        "year",
    }

    assert (
        fontTools.ufoLib.fontInfoAttributesVersion3
        - set(fontMath.mathInfo._infoAttrs.keys())
        - {"postscriptWeightName"}  # Handled in fontMath specially.
        - ufo2ft.instantiator.UFO_INFO_ATTRIBUTES_TO_COPY_TO_INSTANCES
        == SKIPPED_ATTRS
    )


def test_static_font_default_instance_inherits_all_fontinfo(data_dir, ufo_module):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "DesignspaceTest" / "DesignspaceTest-static.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))

    assert len(designspace.sources) == 1  # single-master, static font
    assert len(designspace.instances) == 1
    # the default source's fontinfo.plist has a `postscriptFontName`
    designspace.sources[0].font.info.postscriptFontName = "MyFont-Light"

    # the DS instance does not have a `postScriptFontName` attribute, nor
    # does it have a `public.fontInfo` dict
    assert designspace.instances[0].postScriptFontName is None
    assert "public.fontInfo" not in designspace.instances[0].lib

    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )
    instance_font = generator.generate_instance(designspace.instances[0])

    # the instance inherits the postscriptFontName from the default source's
    # fontinfo.plist
    assert instance_font.info.postscriptFontName == "MyFont-Light"


def test_designspace_v5_discrete_axis_raises_error(data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "MutatorSansLite" / "MutatorFamily_v5_discrete_axis.designspace"
    )
    # The error message should advise to use `splitInterpolable()`
    with pytest.raises(
        ufo2ft.instantiator.InstantiatorError, match="splitInterpolable"
    ):
        ufo2ft.instantiator.Instantiator.from_designspace(designspace)


def test_opentype_os2_panose_merging(ufo_module):
    """Test that openTypeOS2Panose values are properly merged across sources.

    Only panose values that are identical across all sources should be copied
    to instances. Different values should be set to 0.
    """
    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )

    font1 = ufo_module.Font()
    font1.info.openTypeOS2Panose = [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]  # default source

    font2 = ufo_module.Font()
    font2.info.openTypeOS2Panose = [
        2,
        11,
        8,  # different at index 2
        2,
        4,
        5,
        4,
        2,
        2,
        4,
    ]

    font3 = ufo_module.Font()
    font3.info.openTypeOS2Panose = [
        2,
        11,
        5,
        3,  # different at index 3
        4,
        5,
        4,
        2,
        2,
        4,
    ]

    d.addSourceDescriptor(location={"Weight": 300}, font=font1)
    d.addSourceDescriptor(location={"Weight": 600}, font=font2)
    d.addSourceDescriptor(location={"Weight": 900}, font=font3)
    d.addInstanceDescriptor(styleName="Regular", location={"Weight": 400})
    d.addInstanceDescriptor(styleName="Bold", location={"Weight": 700})

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)

    instance1 = generator.generate_instance(d.instances[0])
    instance2 = generator.generate_instance(d.instances[1])

    # Indices 2 and 3 differ across sources, so they should be 0
    # All other indices are the same across sources
    expected_panose = [2, 11, 0, 0, 4, 5, 4, 2, 2, 4]

    assert instance1.info.openTypeOS2Panose == expected_panose
    assert instance2.info.openTypeOS2Panose == expected_panose


def test_opentype_os2_panose_all_different(ufo_module):
    """Test that when all panose values differ, the attribute is deleted."""
    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )

    # Create fonts with completely different panose values
    font1 = ufo_module.Font()
    font1.info.openTypeOS2Panose = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]

    font2 = ufo_module.Font()
    font2.info.openTypeOS2Panose = [10, 9, 8, 7, 6, 5, 4, 3, 2, 1]

    d.addSourceDescriptor(location={"Weight": 300}, font=font1)
    d.addSourceDescriptor(location={"Weight": 900}, font=font2)
    d.addInstanceDescriptor(styleName="Regular", location={"Weight": 600})

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)
    instance = generator.generate_instance(d.instances[0])

    # All values differ, so openTypeOS2Panose should be unset
    assert instance.info.openTypeOS2Panose is None


def test_opentype_os2_panose_missing_in_some_sources(ufo_module):
    """Test handling when some sources don't have panose values."""
    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )

    font1 = ufo_module.Font()
    font1.info.openTypeOS2Panose = [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]

    # Second font doesn't have panose, doesn't contribute
    font2 = ufo_module.Font()
    assert font2.info.openTypeOS2Panose is None

    font3 = ufo_module.Font()
    font3.info.openTypeOS2Panose = [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]

    d.addSourceDescriptor(location={"Weight": 300}, font=font1)
    d.addSourceDescriptor(location={"Weight": 600}, font=font2)
    d.addSourceDescriptor(location={"Weight": 900}, font=font3)
    d.addInstanceDescriptor(styleName="Regular", location={"Weight": 400})

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)
    instance = generator.generate_instance(d.instances[0])

    # The default source's panose should be copied since font2 has None and
    # font3 has same panose as font1
    assert instance.info.openTypeOS2Panose == [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]


def test_opentype_os2_panose_single_source(ufo_module):
    """Test that panose values are preserved as-is when there's only one source.

    Cf. https://github.com/googlefonts/fontc/issues/1609
    """
    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=400, maximum=900
    )

    font1 = ufo_module.Font()
    font1.info.openTypeOS2Panose = [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]

    d.addSourceDescriptor(location={"Weight": 400}, font=font1)
    d.addInstanceDescriptor(styleName="Regular", location={"Weight": 400})

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)

    instance = generator.generate_instance(d.instances[0])

    # With only one source, panose should be preserved as-is
    assert instance.info.openTypeOS2Panose == [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]


def test_opentype_os2_panose_no_mutation_of_default(ufo_module):
    """Test that processing panose values doesn't mutate the default source."""
    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )

    font1 = ufo_module.Font()
    original_panose = [2, 11, 5, 2, 4, 5, 4, 2, 2, 4]
    font1.info.openTypeOS2Panose = original_panose.copy()

    font2 = ufo_module.Font()
    font2.info.openTypeOS2Panose = [
        2,
        11,
        8,  # different at index 2
        2,
        4,
        5,
        4,
        2,
        2,
        4,
    ]

    d.addSourceDescriptor(location={"Weight": 300}, font=font1)
    d.addSourceDescriptor(location={"Weight": 900}, font=font2)
    d.addInstanceDescriptor(styleName="Regular", location={"Weight": 600})

    generator = ufo2ft.instantiator.Instantiator.from_designspace(d)
    instance = generator.generate_instance(d.instances[0])

    # The instance should have merged panose with 0 at index 2
    assert instance.info.openTypeOS2Panose == [2, 11, 0, 2, 4, 5, 4, 2, 2, 4]

    # The default source should remain unchanged
    assert font1.info.openTypeOS2Panose == original_panose
    assert d.default.font.info.openTypeOS2Panose == original_panose


@pytest.mark.parametrize(
    "panose_data,expected",
    [
        pytest.param(
            [[2, 11, 5], [2, 11, 8, 2, 4, 5, 4, 2, 2, 4, 99, 88, 77, 66, 55]],
            [2, 11, 0, 0, 0, 0, 0, 0, 0, 0],
            id="zero-padded",  # At least one source has length < 10 (will be padded)
        ),
        pytest.param(
            [
                [2, 11, 5, 2, 4, 5, 4, 2, 2, 4, 99, 88],
                [2, 11, 8, 2, 4, 5, 4, 2, 2, 4, 77, 66, 55],
            ],
            [2, 11, 0, 2, 4, 5, 4, 2, 2, 4],
            id="truncated",  # All sources have length > 10 (will be truncated)
        ),
    ],
)
def test_opentype_os2_panose_malformed_lengths(panose_data, expected, caplog):
    """Test handling of panose values with incorrect lengths (ufoLib2 only)."""
    ufo_module = pytest.importorskip("ufoLib2")

    d = designspaceLib.DesignSpaceDocument()
    d.addAxisDescriptor(
        name="Weight", tag="wght", minimum=300, default=300, maximum=900
    )

    fonts = []
    for i, panose_values in enumerate(panose_data):
        font = ufo_module.Font()
        font.info.openTypeOS2Panose = panose_values
        fonts.append(font)
        d.addSourceDescriptor(location={"Weight": 300 + i * 600}, font=font)

    d.addInstanceDescriptor(styleName="Regular", location={"Weight": 600})

    with caplog.at_level(logging.WARNING):
        generator = ufo2ft.instantiator.Instantiator.from_designspace(d)
        instance = generator.generate_instance(d.instances[0])

    # Should log a warning about invalid length
    assert (
        "openTypeOS2Panose values in designspace sources have invalid length"
        in caplog.text
    )

    # Should produce a valid result with exactly 10 values
    assert instance.info.openTypeOS2Panose == expected
    assert len(instance.info.openTypeOS2Panose) == 10


def test_strict_math_glyph(ufo_module, data_dir):
    designspace = designspaceLib.DesignSpaceDocument.fromfile(
        data_dir / "InstantiatorStrictMathGlyph" / "StrictMathGlyph.designspace"
    )
    designspace.loadSourceFonts(openFontFactory(ufo_module=ufo_module))
    generator = ufo2ft.instantiator.Instantiator.from_designspace(
        designspace, round_geometry=True
    )
    fonts = [
        generator.generate_instance(instance) for instance in designspace.instances
    ]
    assert len(fonts) == 1
    glyph = fonts[0]["test"]
    assert len(glyph.contours) == 1
    assert len(glyph.contours[0].points) == 16