File: checkcompletion.sh

package info (click to toggle)
util-linux 2.42~rc1-2
  • links: PTS, VCS
  • area: main
  • in suites: experimental
  • size: 101,864 kB
  • sloc: ansic: 185,733; sh: 24,450; yacc: 1,288; makefile: 534; xml: 422; python: 316; lex: 89; ruby: 75; csh: 37; exp: 19; sed: 16; perl: 15; sql: 9
file content (205 lines) | stat: -rwxr-xr-x 6,092 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
#!/bin/bash

#
# This script verifies bash-completion consistency by checking:
# 1. All user-facing programs have bash-completion files
# 2. All bash-completion files are registered in bash-completion/Makemodule.am
# 3. All bash-completion files are registered in meson.build
# 4. All bash-completion files correspond to actual programs
# 5. All bash-completion files handle all available long options in each program
#
# Copyright (C) 2025 Karel Zak <kzak@redhat.com>
# Copyright (C) 2025 Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
#

set -e

die() {
	echo "error: $1" >&2
	exit 1
}

usage() {
	echo "Usage: $0 [<top_srcdir>]"
	echo
	echo "Verifies bash-completion consistency across:"
	echo "  - Program definitions in */Makemodule.am"
	echo "  - bash-completion/ directory contents"
	echo "  - bash-completion/Makemodule.am registrations"
	echo "  - meson.build registrations"
	exit 1
}

# Programs that don't need bash completion:
# - nologin: no interactive use
# - agetty: terminal setup, no user interaction
# - login: authentication, no command-line arguments
# - sulogin: emergency login, no arguments
# - switch_root: initramfs utility, internal use
# - vipw: wrapper around editor
# - line: deprecated, simple utility
# - kill: conflicts with bash built-in kill command
exclude_programs="nologin|agetty|login|sulogin|switch_root|vipw|line|kill"

# Programs with special handling in bash-completion/Makemodule.am (symlinks/aliases)
# These are handled via install-data-hook-bashcomp-* rules
# - runuser: symlinked to su completion
# - lastb: symlinked to last completion
special_handling="runuser|lastb"

# Certain completions have an unusual algorithm that is distinct from the pattern used
# in the majority of completion files, we skip these for now.
unusual_completions="pipesz"

top_srcdir="$(realpath -qLs "${1:-.}")"
[ -d "${top_srcdir}" ] || die "directory '${top_srcdir}' not found"

cd "${top_srcdir}" || die "cannot cd to ${top_srcdir}"

completion_dir="bash-completion"
[ -d "${completion_dir}" ] || die "not found ${completion_dir}"

# Extract all user-facing programs from Makemodule.am files
# We look for: bin_PROGRAMS, sbin_PROGRAMS, usrbin_exec_PROGRAMS, usrsbin_exec_PROGRAMS
extract_programs() {
	find . -name "Makemodule.am" -type f -exec grep -h \
		-E "^(bin|sbin|usrbin_exec|usrsbin_exec)_PROGRAMS \+=" {} \; \
		| sed 's/.*+= *//' \
		| tr ' ' '\n' \
		| sed 's/\\//' \
		| grep -v '^$' \
		| grep -v '\.static$' \
		| sort -u
}

# Extract programs from bash-completion/Makemodule.am
extract_completion_registered() {
	grep 'bash-completion/' "${completion_dir}/Makemodule.am" \
		| sed -e 's/.*bash-completion\///' \
		      -e 's/\s.*//' \
		| sort -u
}

# Get actual bash-completion files
get_completion_files() {
	ls "${completion_dir}" \
		| grep -v '^Makemodule.am$' \
		| sort
}

# Extract programs from meson.build
extract_meson_registered() {
	if [ -f "meson.build" ]; then
		grep "bashcompletions +=" meson.build \
			| sed -e "s/.*bashcompletions += //" \
			      -e "s/\[//" \
			      -e "s/\]//" \
			      -e "s/'//g" \
			| tr ',' '\n' \
			| sed -e 's/^ *//' \
			      -e 's/ *$//' \
			| grep -v '^$' \
			| sort -u
	fi
}

# Check for the bash-completion file integrity, i.e. all long options are completed
# Argument(s): program_name
check_completion_file_integrity() {
	local prog="$1"

	prog_long_opts="$( TOP_SRCDIR="${top_srcdir}" "${top_srcdir}"/tools/get-options.sh "$prog" \
			| sed -e 's/^$//' -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//')"

	if [[ "$?" != "0" || -z "$prog_long_opts" ]]; then
		echo "Failed to get long options for $prog"
		return 1
	fi

	# tools/get-options.sh prints 'ENOTSUP' when it receives the name of an
	# unsupported program. See comments for the 'unsupported_programs' variable
	# in tools/get-options.sh for more details.
	#
	# We do not treat this case as an error, thereby we simply return 0 to the
	# caller and skip the comparison.
	if [ "$prog_long_opts" == "ENOTSUP" ]; then
		return 0
	fi

	comp_opts="$( cat "${completion_dir}/${prog}" \
			| grep -o -P '[[:space:]]*--(?![^[:alnum:]])[A-Za-z-.0-9_]*' \
			| sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//' \
			| sort \
			| uniq )"

	res="$( comm -23 <(echo "${prog_long_opts}") <(echo "${comp_opts}") )"
	if [ -n "$res" ]; then
		printf "%s\n%s\n" "${prog}:" "$res"
		return 1
	fi

	return 0
}

# Get programs that should have completions
programs=$(extract_programs | grep -v -w -E "(${exclude_programs}|${special_handling})")

# Get registered completions
registered=$(extract_completion_registered)

# Get meson registered completions
meson_registered=$(extract_meson_registered)

# Get actual completion files
files=$(get_completion_files)

# Find programs without completion files
missing_files=$(comm -23 <(echo "$programs") <(echo "$files"))

# Find completion files not registered in Makemodule.am
unregistered=$(comm -23 <(echo "$files") <(echo "$registered"))

# Find completion files without corresponding programs
orphaned=$(comm -23 <(echo "$files") <(echo "$programs"))

# Find completion files not registered in meson.build
meson_unregistered=$(comm -23 <(echo "$files") <(echo "$meson_registered"))

# Report findings
errors=0

if [ -n "$missing_files" ]; then
	echo "Programs missing bash-completion files:"
	echo "$missing_files" | sed 's/^/  /'
	errors=$((errors + 1))
fi

if [ -n "$unregistered" ]; then
	echo "bash-completion files not registered in bash-completion/Makemodule.am:"
	echo "$unregistered" | sed 's/^/  /'
	errors=$((errors + 1))
fi

if [ -n "$orphaned" ]; then
	echo "bash-completion files without corresponding programs:"
	echo "$orphaned" | sed 's/^/  /'
	errors=$((errors + 1))
fi

if [ -n "$meson_unregistered" ]; then
	echo "bash-completion files not registered in meson.build:"
	echo "$meson_unregistered" | sed 's/^/  /'
	errors=$((errors + 1))
fi

for f in $files; do
	[[ "$f" =~ $unusual_completions ]] && continue
	check_completion_file_integrity "$f" || errors=$((errors + 1))
done

if [ $errors -eq 0 ]; then
	echo "All bash-completion files are consistent."
	exit 0
else
	exit 1
fi