File: matcher_spec.rb

package info (click to toggle)
vim-command-t 5.0.2-5-g7147ba9-1
  • links: PTS, VCS
  • area: main
  • in suites: bullseye, buster
  • size: 744 kB
  • sloc: ruby: 3,394; ansic: 1,177; makefile: 27; sh: 26; xml: 11
file content (302 lines) | stat: -rw-r--r-- 10,618 bytes parent folder | download | duplicates (4)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
# Copyright 2010-present Greg Hurrell. All rights reserved.
# Licensed under the terms of the BSD 2-clause license.

require 'spec_helper'
require 'ostruct'

describe CommandT::Matcher do
  def matcher(*paths)
    scanner = OpenStruct.new(:paths => paths)
    CommandT::Matcher.new(scanner)
  end

  describe 'initialization' do
    it 'raises an ArgumentError if passed nil' do
      expect { CommandT::Matcher.new(nil) }.to raise_error(ArgumentError)
    end
  end

  describe '#sorted_matches_for' do
    def ordered_matches(paths, query)
      matcher(*paths).sorted_matches_for(query, :recurse => true)
    end

    it 'raises an ArgumentError if passed nil' do
      expect { matcher.sorted_matches_for(nil) }.to raise_error(ArgumentError)
    end

    it 'returns empty array when source array empty' do
      expect(matcher.sorted_matches_for('foo')).to eq([])
      expect(matcher.sorted_matches_for('')).to eq([])
    end

    it 'returns empty array when no matches' do
      matcher = matcher(*%w[foo/bar foo/baz bing])
      expect(matcher.sorted_matches_for('xyz')).to eq([])
    end

    it 'returns matching paths' do
      matcher = matcher(*%w[foo/bar foo/baz bing])
      matches = matcher.sorted_matches_for('z')
      expect(matches.map { |m| m.to_s }).to eq(['foo/baz'])
      matches = matcher.sorted_matches_for('bg')
      expect(matches.map { |m| m.to_s }).to eq(['bing'])
    end

    it 'performs case-insensitive matching' do
      matches = matcher('Foo').sorted_matches_for('f')
      expect(matches.map { |m| m.to_s }).to eq(['Foo'])
    end

    it 'considers the space character to match a literal space' do
      paths = ['path_no_space', 'path with/space']
      matches = matcher(*paths).sorted_matches_for('path space')
      expect(matches.map { |m| m.to_s }).to eq(['path with/space'])
    end

    context 'when the ignore_spaces option in specified' do
      it 'ignores the space character' do
        paths = ['path_no_space', 'path with/space']
        matches = matcher(*paths).sorted_matches_for('path space', :ignore_spaces => true)
        expect(matches.map { |m| m.to_s }).to eq(['path_no_space', 'path with/space'])
      end
    end

    it 'considers the empty string to match everything' do
      matches = matcher('foo').sorted_matches_for('')
      expect(matches.map { |m| m.to_s }).to eq(['foo'])
    end

    # Can't imagine this happening in practice, but want to handle it in case.
    it 'gracefully handles empty haystacks' do
      expect(matcher('', 'foo').sorted_matches_for('').map { |m| m.to_s }).to eq(['', 'foo'])
      expect(matcher('', 'foo').sorted_matches_for('f').map { |m| m.to_s }).to eq(['foo'])
    end

    it 'does not consider mere substrings of the query string to be a match' do
      expect(matcher('foo').sorted_matches_for('foo...')).to eq([])
    end

    it 'prioritizes shorter paths over longer ones' do
      expect(ordered_matches(%w[
        articles_controller_spec.rb
        article.rb
      ], 'art')).to eq(%w[
        article.rb
        articles_controller_spec.rb
      ])
    end

    it 'prioritizes matches after "/"' do
      expect(ordered_matches(%w[fooobar foo/bar], 'b')).to eq(%w[foo/bar fooobar])

      # note that / beats _
      expect(ordered_matches(%w[foo_bar foo/bar], 'b')).to eq(%w[foo/bar foo_bar])

      # / also beats -
      expect(ordered_matches(%w[foo-bar foo/bar], 'b')).to eq(%w[foo/bar foo-bar])

      # and numbers
      expect(ordered_matches(%w[foo9bar foo/bar], 'b')).to eq(%w[foo/bar foo9bar])

      # and periods
      expect(ordered_matches(%w[foo.bar foo/bar], 'b')).to eq(%w[foo/bar foo.bar])

      # and spaces
      expect(ordered_matches(['foo bar', 'foo/bar'], 'b')).to eq(['foo/bar', 'foo bar'])
    end

    it 'prioritizes matches after "-"' do
      expect(ordered_matches(%w[fooobar foo-bar], 'b')).to eq(%w[foo-bar fooobar])

      # - also beats .
      expect(ordered_matches(%w[foo.bar foo-bar], 'b')).to eq(%w[foo-bar foo.bar])
    end

    it 'prioritizes matches after "_"' do
      expect(ordered_matches(%w[fooobar foo_bar], 'b')).to eq(%w[foo_bar fooobar])

      # _ also beats .
      expect(ordered_matches(%w[foo.bar foo_bar], 'b')).to eq(%w[foo_bar foo.bar])
    end

    it 'prioritizes matches after " "' do
      expect(ordered_matches(['fooobar', 'foo bar'], 'b')).to eq(['foo bar', 'fooobar'])

      # " " also beats .
      expect(ordered_matches(['foo.bar', 'foo bar'], 'b')).to eq(['foo bar', 'foo.bar'])
    end

    it 'prioritizes matches after numbers' do
      expect(ordered_matches(%w[fooobar foo9bar], 'b')).to eq(%w[foo9bar fooobar])

      # numbers also beat .
      expect(ordered_matches(%w[foo.bar foo9bar], 'b')).to eq(%w[foo9bar foo.bar])
    end

    it 'prioritizes matches after periods' do
      expect(ordered_matches(%w[fooobar foo.bar], 'b')).to eq(%w[foo.bar fooobar])
    end

    it 'prioritizes matching capitals following lowercase' do
      expect(ordered_matches(%w[foobar fooBar], 'b')).to eq(%w[fooBar foobar])
    end

    it 'prioritizes matches earlier in the string' do
      expect(ordered_matches(%w[******b* **b*****], 'b')).to eq(%w[**b***** ******b*])
    end

    it 'prioritizes matches closer to previous matches' do
      expect(ordered_matches(%w[**b***c* **bc****], 'bc')).to eq(%w[**bc**** **b***c*])
    end

    it 'scores alternative matches of same path differently' do
      # ie:
      # app/controllers/articles_controller.rb
      expect(ordered_matches(%w[
        a**/****r******/**t*c***_*on*******.**
        ***/***********/art*****_con*******.**
      ], 'artcon')).to eq(%w[
        ***/***********/art*****_con*******.**
        a**/****r******/**t*c***_*on*******.**
      ])
    end

    it 'provides intuitive results for "artcon" and "articles_controller"' do
      expect(ordered_matches(%w[
        app/controllers/heartbeat_controller.rb
        app/controllers/articles_controller.rb
      ], 'artcon')).to eq(%w[
        app/controllers/articles_controller.rb
        app/controllers/heartbeat_controller.rb
      ])
    end

    it 'provides intuitive results for "aca" and "a/c/articles_controller"' do
      expect(ordered_matches(%w[
        app/controllers/heartbeat_controller.rb
        app/controllers/articles_controller.rb
      ], 'aca')).to eq(%w[
        app/controllers/articles_controller.rb
        app/controllers/heartbeat_controller.rb
      ])
    end

    it 'provides intuitive results for "d" and "doc/command-t.txt"' do
      expect(ordered_matches(%w[
        TODO
        doc/command-t.txt
      ], 'd')).to eq(%w[
        doc/command-t.txt
        TODO
      ])
    end

    it 'provides intuitive results for "do" and "doc/command-t.txt"' do
      expect(ordered_matches(%w[
        TODO
        doc/command-t.txt
      ], 'do')).to eq(%w[
        doc/command-t.txt
        TODO
      ])
    end

    it 'provides intuitive results for "matchh" search' do
      # Regression introduced in 187bc18.
      expect(ordered_matches(%w[
        vendor/bundle/ruby/1.8/gems/rspec-expectations-2.14.5/spec/rspec/matchers/has_spec.rb
        ruby/command-t/match.h
      ], 'matchh')).to eq(%w[
        ruby/command-t/match.h
        vendor/bundle/ruby/1.8/gems/rspec-expectations-2.14.5/spec/rspec/matchers/has_spec.rb
      ])
    end

    it 'provides intuitive results for "relqpath" search' do
      # Another regression.
      expect(ordered_matches(%w[
        *l**/e*t*t*/atla*/patter**/E*tAtla***el****q*e*e***al**at***HelperTra*t.php
        static_upstream/relay/query/RelayQueryPath.js
      ], 'relqpath')).to eq(%w[
        static_upstream/relay/query/RelayQueryPath.js
        *l**/e*t*t*/atla*/patter**/E*tAtla***el****q*e*e***al**at***HelperTra*t.php
      ])
    end

    it 'provides intuitive results for "controller" search' do
      # Another regression.
      expect(ordered_matches(%w[
        spec/command-t/controller_spec.rb
        ruby/command-t/controller.rb
      ], 'controller')).to eq(%w[
        ruby/command-t/controller.rb
        spec/command-t/controller_spec.rb
      ])
    end

    it "doesn't incorrectly accept repeats of the last-matched character" do
      # https://github.com/wincent/Command-T/issues/82
      matcher = matcher(*%w[ash/system/user/config.h])
      expect(matcher.sorted_matches_for('usercc')).to eq([])

      # simpler test case
      matcher = matcher(*%w[foobar])
      expect(matcher.sorted_matches_for('fooooo')).to eq([])

      # minimal repro
      matcher = matcher(*%w[ab])
      expect(matcher.sorted_matches_for('aa')).to eq([])
    end

    it 'ignores dotfiles by default' do
      matcher = matcher(*%w[.foo .bar])
      expect(matcher.sorted_matches_for('foo')).to eq([])
    end

    it 'shows dotfiles if the query starts with a dot' do
      matcher = matcher(*%w[.foo .bar])
      expect(matcher.sorted_matches_for('.fo')).to eq(%w[.foo])
    end

    it "doesn't show dotfiles if the query contains a non-leading dot" do
      matcher = matcher(*%w[.foo.txt .bar.txt])
      expect(matcher.sorted_matches_for('f.t')).to eq([])

      # counter-example
      expect(matcher.sorted_matches_for('.f.t')).to eq(%w[.foo.txt])
    end

    it "shows dotfiles when there is a non-leading dot that matches a leading dot within a path component" do
      matcher = matcher(*%w[this/.secret/stuff.txt something.else])
      expect(matcher.sorted_matches_for('t.sst')).to eq(%w[this/.secret/stuff.txt])
    end

    it "doesn't show a dotfile just because there was a match at index 0" do
      pending 'fix'
      matcher = matcher(*%w[src/.flowconfig])
      expect(matcher.sorted_matches_for('s')).to eq([])
    end

    it 'correctly computes non-recursive match score' do
      # Non-recursive match was incorrectly inflating some scores.
      # Related: https://github.com/wincent/command-t/issues/209
      matcher = matcher(*%w[
        app/assets/components/App/index.jsx
        app/assets/components/PrivacyPage/index.jsx
        app/views/api/docs/pagination/_index.md
      ])

      # You might want the second match here to come first, but in the
      # non-recursive case we greedily match the "app" in "app", the "a" in
      # "assets", the "p" in "components", and the first "p" in "App". This
      # doesn't score as favorably as matching the "app" in "app", the "ap" in
      # "api", and the "p" in "pagination".
      expect(matcher.sorted_matches_for('appappind')).to eq(%w[
        app/views/api/docs/pagination/_index.md
        app/assets/components/App/index.jsx
        app/assets/components/PrivacyPage/index.jsx
      ])
    end
  end
end