1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734
|
#
# Common code for all guests
#
# Copyright 2006-2009, 2013 Red Hat, Inc.
#
# This work is licensed under the GNU GPLv2 or later.
# See the COPYING file in the top-level directory.
import os
from . import cloudinit
from . import unattended
from . import volumeupload
from .installertreemedia import InstallerTreeMedia
from .installerinject import perform_cdrom_injections
from ..domain import DomainOs
from ..devices import DeviceDisk
from ..guest import Guest
from ..osdict import OSDB
from ..logger import log
from .. import progress
from .. import xmlutil
def _make_testsuite_path(path):
return os.path.join("/VIRTINST-TESTSUITE",
os.path.basename(path).split("-", 2)[-1])
class Installer(object):
"""
Class for kicking off VM installs. The VM is set up separately in a Guest
instance. This class tracks the install media/bootdev choice, alters the
Guest XML, boots it for the install, then saves the post install XML
config. The Guest is passed in via start_install, only install media
selection is done at __init__ time
:param cdrom: Path to a cdrom device or iso. Maps to virt-install --cdrom
:param location: An install tree URI, local directory, or ISO/CDROM path.
Largely handled by installtreemedia helper class. Maps to virt-install
--location
:param location_kernel: URL pointing to a kernel to fetch, or a relative
path to indicate where the kernel is stored in location
:param location_initrd: location_kernel, but pointing to an initrd
:param install_kernel: Kernel to install off of
:param install_initrd: Initrd to install off of
:param install_kernel_args: Kernel args <cmdline> to use. This overwrites
whatever the installer might request, unlike extra_args which will
append arguments.
:param no_install: If True, this installer specifically does not have
an install phase. We are just using it to create the initial XML.
"""
def __init__(self, conn, cdrom=None, location=None, install_bootdev=None,
location_kernel=None, location_initrd=None,
install_kernel=None, install_initrd=None, install_kernel_args=None,
no_install=None, is_reinstall=False):
self.conn = conn
# Entry point for virt-manager 'Customize' wizard to change autostart
self.autostart = False
self._install_cdrom_device_added = False
self._unattended_install_cdrom_device = None
self._tmpfiles = []
self._tmpvols = []
self._defaults_are_set = False
self._unattended_data = None
self._cloudinit_data = None
self._install_bootdev = install_bootdev
self._no_install = no_install
self._is_reinstall = is_reinstall
self._pre_reinstall_xml = None
self._treemedia = None
self._treemedia_bootconfig = None
self._cdrom = None
if cdrom:
cdrom = InstallerTreeMedia.validate_path(self.conn, cdrom)
self._cdrom = cdrom
self._install_bootdev = "cdrom"
elif (location or location_kernel or location_initrd or
install_kernel or install_initrd):
self._treemedia = InstallerTreeMedia(self.conn, location,
location_kernel, location_initrd,
install_kernel, install_initrd, install_kernel_args)
##################
# Static helpers #
##################
@staticmethod
def cleanup_created_disks(guest, meter):
"""
Remove any disks we created as part of the install. Only ever
called by clients.
"""
clean_disks = [d for d in guest.devices.disk if d.storage_was_created]
for disk in clean_disks:
path = disk.get_source_path()
log.debug("Removing created disk path=%s vol_object=%s",
path, disk.get_vol_object())
name = os.path.basename(path)
try:
meter.start(_("Removing disk '%s'") % name, None)
if disk.get_vol_object():
disk.get_vol_object().delete()
else: # pragma: no cover
# This case technically shouldn't happen here, but
# it's here in case future assumptions change
os.unlink(path)
meter.end()
except Exception as e: # pragma: no cover
log.debug("Failed to remove disk '%s'",
name, exc_info=True)
log.error("Failed to remove disk '%s': %s", name, e)
###################
# Private helpers #
###################
def _make_cdrom_device(self, path):
dev = DeviceDisk(self.conn)
dev.device = dev.DEVICE_CDROM
dev.set_source_path(path)
dev.sync_path_props()
dev.validate()
return dev
def _cdrom_path(self):
if self._treemedia:
return self._treemedia.cdrom_path()
return self._cdrom
def _add_install_cdrom_device(self, guest):
if self._install_cdrom_device_added:
return # pragma: no cover
if not bool(self._cdrom_path()):
return
self._install_cdrom_device_added = True
if self._is_reinstall:
cdroms = [d for d in guest.devices.disk if d.is_cdrom()]
if cdroms:
dev = cdroms[0]
dev.set_source_path(self._cdrom_path())
return
dev = self._make_cdrom_device(self._cdrom_path())
if self._is_reinstall:
dev.set_defaults(guest)
# Insert the CDROM before any other CDROM, so boot=cdrom picks
# it as the priority
for idx, disk in enumerate(guest.devices.disk):
if disk.is_cdrom():
guest.devices.add_child(dev, idx=idx)
return
guest.add_device(dev)
def _remove_install_cdrom_media(self, guest):
if not self._install_cdrom_device_added:
return
if guest.osinfo.is_windows():
# Keep media attached for windows which has a multi stage install
return
for disk in guest.devices.disk:
if (disk.is_cdrom() and
disk.get_source_path() == self._cdrom_path()):
disk.set_source_path(None)
disk.sync_path_props()
break
def _add_unattended_install_cdrom_device(self, guest, location):
if self._unattended_install_cdrom_device:
return # pragma: no cover
dev = self._make_cdrom_device(location)
dev.set_defaults(guest)
self._unattended_install_cdrom_device = dev.target
guest.add_device(dev)
# The CDROM we just added might be a SCSI one. If that's the case,
# libvirt will automatically add the necessary controller for us, but
# depending on the architecture its choice of model might not be
# usable by the guest OS. Try to add a virtio-scsi controller, if
# supported, for the best chance of the CDROM actually being picked up
guest.add_virtioscsi_controller()
if self.conn.in_testsuite():
# Hack to set just the XML path differently for the test suite.
# Setting this via regular 'path' will error that it doesn't exist
dev.source.file = _make_testsuite_path(location)
def _remove_unattended_install_cdrom_device(self, guest):
if not self._unattended_install_cdrom_device:
return
disk = [d for d in guest.devices.disk if
d.target == self._unattended_install_cdrom_device][0]
disk.set_source_path(None)
disk.sync_path_props()
def _build_boot_order(self, guest, bootdev):
bootorder = [bootdev]
# If guest has an attached disk, always have 'hd' in the boot
# list, so disks are marked as bootable/installable (needed for
# windows virtio installs, and booting local disk from PXE)
for disk in guest.devices.disk:
if disk.device == disk.DEVICE_DISK:
bootdev = "hd"
if bootdev not in bootorder:
bootorder.append(bootdev)
break
return bootorder
def _can_set_guest_bootorder(self, guest):
return (not guest.os.is_container() and
not guest.os.kernel and
not any([d.boot.order for d in guest.devices.get_all()]))
def _alter_treemedia_bootconfig(self, guest):
if not self._treemedia:
return
kernel, initrd, kernel_args = self._treemedia_bootconfig
if kernel:
guest.os.kernel = (self.conn.in_testsuite() and
_make_testsuite_path(kernel) or kernel)
if initrd:
guest.os.initrd = (self.conn.in_testsuite() and
_make_testsuite_path(initrd) or initrd)
if kernel_args:
guest.os.kernel_args = kernel_args
def _alter_bootconfig(self, guest):
"""
Generate the portion of the guest xml that determines boot devices
and parameters. (typically the <os></os> block)
:param guest: Guest instance we are installing
"""
guest.on_reboot = "destroy"
self._alter_treemedia_bootconfig(guest)
bootdev = self._install_bootdev
if bootdev and self._can_set_guest_bootorder(guest):
guest.os.bootorder = self._build_boot_order(guest, bootdev)
else:
guest.os.bootorder = []
def _alter_install_resources(self, guest, meter):
"""
Sets the appropriate amount of ram needed when performing a "network"
based installation
:param guest: Guest instance we are installing
"""
if not self._treemedia:
return
if not self._treemedia.requires_internet(guest, meter):
return
ram = guest.osinfo.get_network_install_required_ram(guest)
ram = (ram or 0) // 1024
if ram > guest.currentMemory:
msg = (_("Overriding memory to %(number)s MiB needed for "
"%(osname)s network install.") %
{"number": ram // 1024, "osname": guest.osinfo.name})
log.warning(msg)
guest.currentMemory = ram
################
# Internal API #
################
def _should_upload_media(self, guest):
"""
Return True if we should upload media to the connection scratchdir.
This doesn't consider if there is any media to upload, just whether
we _should_ upload if there _is_ media.
"""
scratchdir = InstallerTreeMedia.make_scratchdir(guest)
system_scratchdir = InstallerTreeMedia.get_system_scratchdir(guest)
if self.conn.is_remote():
return True
if self.conn.is_unprivileged():
return False
if scratchdir == system_scratchdir:
return False # pragma: no cover
return True
def _upload_media(self, guest, meter, paths):
system_scratchdir = InstallerTreeMedia.get_system_scratchdir(guest)
if (not self._should_upload_media(guest) and
not xmlutil.in_testsuite()):
# We have access to system scratchdir, don't jump through hoops
log.debug("Have access to preferred scratchdir so"
" nothing to upload") # pragma: no cover
return paths # pragma: no cover
if not guest.conn.support_remote_url_install():
# Needed for the test_urls suite
log.debug("Media upload not supported") # pragma: no cover
return paths # pragma: no cover
newpaths, tmpvols = volumeupload.upload_paths(
guest.conn, system_scratchdir, meter, paths)
self._tmpvols += tmpvols
return newpaths
def _prepare_unattended_data(self, guest, meter, scripts):
scratchdir = InstallerTreeMedia.make_scratchdir(guest)
injections = []
for script in scripts:
expected_filename = script.get_expected_filename()
unattended_cmdline = script.generate_cmdline()
log.debug("Generated unattended cmdline: %s", unattended_cmdline)
scriptpath = script.write()
self._tmpfiles.append(scriptpath)
injections.append((scriptpath, expected_filename))
drivers_location = guest.osinfo.get_pre_installable_drivers_location(
guest.os.arch)
drivers = unattended.download_drivers(
drivers_location, scratchdir, meter)
injections.extend(drivers)
self._tmpfiles.extend([driverpair[0] for driverpair in drivers])
iso = perform_cdrom_injections(injections, scratchdir)
self._tmpfiles.append(iso)
iso = self._upload_media(guest, meter, [iso])[0]
self._add_unattended_install_cdrom_device(guest, iso)
def _prepare_unattended_scripts(self, guest, meter):
url = None
os_tree = None
if self._treemedia:
if self._treemedia.is_network_url():
url = self.location
os_media = self._treemedia.get_os_media(guest, meter)
os_tree = self._treemedia.get_os_tree(guest, meter)
injection_method = "initrd"
else:
if not guest.osinfo.is_windows():
log.warning("Attempting unattended method=cdrom injection "
"for a non-windows OS. If this doesn't work, try "
"passing install media to --location")
osguess = OSDB.guess_os_by_iso(self.cdrom)
os_media = osguess[1] if osguess else None
injection_method = "cdrom"
return unattended.prepare_install_scripts(
guest, self._unattended_data, url,
os_media, os_tree, injection_method)
def _prepare_treemedia(self, guest, meter, unattended_scripts):
kernel, initrd, kernel_args = self._treemedia.prepare(guest, meter,
unattended_scripts)
paths = [kernel, initrd]
kernel, initrd = self._upload_media(guest, meter, paths)
self._treemedia_bootconfig = (kernel, initrd, kernel_args)
def _prepare_cloudinit(self, guest, meter):
scratchdir = InstallerTreeMedia.make_scratchdir(guest)
filepairs = cloudinit.create_files(scratchdir, self._cloudinit_data)
for filepair in filepairs:
self._tmpfiles.append(filepair[0])
iso = perform_cdrom_injections(filepairs, scratchdir, cloudinit=True)
self._tmpfiles.append(iso)
iso = self._upload_media(guest, meter, [iso])[0]
self._add_unattended_install_cdrom_device(guest, iso)
def _prepare(self, guest, meter):
if self._is_reinstall:
self._pre_reinstall_xml = guest.get_xml()
unattended_scripts = None
if self._unattended_data:
unattended_scripts = self._prepare_unattended_scripts(guest, meter)
if self._treemedia:
self._prepare_treemedia(guest, meter, unattended_scripts)
elif unattended_scripts:
self._prepare_unattended_data(guest, meter, unattended_scripts)
if self._cloudinit_data:
self._prepare_cloudinit(guest, meter)
def _cleanup(self, guest):
if self._treemedia:
self._treemedia.cleanup(guest)
for vol in self._tmpvols:
log.debug("Removing volume '%s'", vol.name())
vol.delete(0)
self._tmpvols = []
for f in self._tmpfiles:
log.debug("Removing %s", str(f))
os.unlink(f)
self._tmpfiles = []
def _get_postinstall_bootdev(self, guest):
if self.cdrom and self._no_install:
return DomainOs.BOOT_DEVICE_CDROM
if self._install_bootdev:
if any([d for d in guest.devices.disk
if d.device == d.DEVICE_DISK]):
return DomainOs.BOOT_DEVICE_HARDDISK
return self._install_bootdev
device = guest.devices.disk and guest.devices.disk[0].device or None
if device == DeviceDisk.DEVICE_DISK:
return DomainOs.BOOT_DEVICE_HARDDISK
elif device == DeviceDisk.DEVICE_CDROM:
return DomainOs.BOOT_DEVICE_CDROM
elif device == DeviceDisk.DEVICE_FLOPPY:
return DomainOs.BOOT_DEVICE_FLOPPY
return DomainOs.BOOT_DEVICE_HARDDISK
##############
# Public API #
##############
@property
def location(self):
if self._treemedia:
return self._treemedia.location
@property
def cdrom(self):
return self._cdrom
def set_initrd_injections(self, initrd_injections):
if not self._treemedia:
raise RuntimeError("Install method does not support "
"initrd injections.")
self._treemedia.set_initrd_injections(initrd_injections)
def set_extra_args(self, extra_args):
if not self._treemedia:
raise RuntimeError("Kernel arguments are only supported with "
"location or kernel installs.")
self._treemedia.set_extra_args(extra_args)
def set_install_defaults(self, guest):
"""
Allow API users to set defaults ahead of time if they want it.
Used by vmmDomainVirtinst so the 'Customize before install' dialog
shows accurate values.
If the user doesn't explicitly call this, it will be called by
start_install()
"""
if self._defaults_are_set:
return
if self._is_reinstall:
self._pre_reinstall_xml = guest.get_xml()
self._add_install_cdrom_device(guest)
if not guest.os.bootorder and self._can_set_guest_bootorder(guest):
bootdev = self._get_postinstall_bootdev(guest)
guest.os.bootorder = self._build_boot_order(guest, bootdev)
if not self._is_reinstall:
guest.set_defaults(None)
self._defaults_are_set = True
def get_search_paths(self, guest):
"""
Return a list of paths that the hypervisor will need search access
for to perform this install.
"""
search_paths = []
if ((self._treemedia or
self._cloudinit_data or
self._unattended_data) and
not self._should_upload_media(guest)):
search_paths.append(InstallerTreeMedia.make_scratchdir(guest))
if self._cdrom_path():
search_paths.append(self._cdrom_path())
return search_paths
def requires_postboot_xml_changes(self):
"""
Return True if the install operation has 2 XML phases, and
requires a hard VM poweroff to ensure the second stage is
used for subsequent boots.
"""
if self.has_cloudinit() or self.has_unattended():
return True
if self._no_install:
return False
return bool(self._cdrom or
self._install_bootdev or
self._treemedia)
def options_specified(self):
"""
Return True if some explicit install option was actually passed in
"""
if self._no_install:
return True
return self.requires_postboot_xml_changes()
def detect_distro(self, guest):
"""
Attempt to detect the distro for the Installer's 'location'. If
an error is encountered in the detection process (or if detection
is not relevant for the Installer type), None is returned.
:returns: distro variant string, or None
"""
ret = None
if self._treemedia:
ret = self._treemedia.detect_distro(guest)
elif self.cdrom:
if guest.conn.is_remote():
log.debug("Can't detect distro for cdrom "
"remote connection.")
else:
osguess = OSDB.guess_os_by_iso(self.cdrom)
if osguess:
ret = osguess[0]
else:
log.debug("No media for distro detection.")
log.debug("installer.detect_distro returned=%s", ret)
return ret
def set_unattended_data(self, unattended_data):
self._unattended_data = unattended_data
def set_cloudinit_data(self, cloudinit_data):
self._cloudinit_data = cloudinit_data
def has_cloudinit(self):
return bool(self._cloudinit_data)
def has_unattended(self):
return bool(self._unattended_data)
def get_generated_password(self):
if self._cloudinit_data:
return self._cloudinit_data.get_password_if_generated()
##########################
# guest install handling #
##########################
def _build_postboot_xml(self, guest_ro, final_xml, meter):
initial_guest = Guest(self.conn, parsexml=final_xml)
self._alter_bootconfig(initial_guest)
self._alter_install_resources(initial_guest, meter)
if self.has_cloudinit():
initial_guest.set_smbios_serial_cloudinit()
# When shim in the guest sees unpopulated EFI NVRAM, like when
# we create a new UEFI VM, it invokes fallback.efi to populate
# initial NVRAM boot entries. When the guest also has a TPM device,
# shim will do a one time VM reset. This reset throws off the
# reboot detection that is central to virt-install's install
# process.
#
# The main install case that this will usually be relevant is
# the combo of UEFI and --cloud-init. The latter usually implies
# use of a distro cloud image, which will be using shim, and the
# --cloud-init process requires a multi stage install compared
# to just a plain import install.
#
# For that case, we disable the default TPM device for the first
# boot.
if (guest_ro.have_default_tpm and
guest_ro.is_uefi() and
len(initial_guest.devices.tpm)):
log.debug(
"combo of default TPM, UEFI, and cloudinit is "
"used. assuming this VM is using a linux distro "
"cloud image with shim in the boot path. disabling "
"TPM for the first boot")
initial_guest.remove_device(initial_guest.devices.tpm[0])
final_guest = Guest(self.conn, parsexml=final_xml)
self._remove_install_cdrom_media(final_guest)
self._remove_unattended_install_cdrom_device(final_guest)
return initial_guest.get_xml(), final_guest.get_xml()
def _build_xml(self, guest, meter):
initial_xml = None
final_xml = guest.get_xml()
if self.requires_postboot_xml_changes():
initial_xml, final_xml = self._build_postboot_xml(
guest, final_xml, meter)
final_xml = self._pre_reinstall_xml or final_xml
log.debug("Generated initial_xml: %s",
(initial_xml and ("\n" + initial_xml) or "None required"))
log.debug("Generated final_xml: \n%s", final_xml)
return initial_xml, final_xml
def _manual_transient_create(self, initial_xml, final_xml, needs_boot):
"""
For hypervisors (like vz) that don't implement createXML,
we need to define+start, and undefine on start failure
"""
domain = self.conn.defineXML(initial_xml or final_xml)
if not needs_boot:
return domain
# Handle undefining the VM if the initial startup fails
try:
domain.create()
except Exception: # pragma: no cover
try:
domain.undefine()
except Exception:
pass
raise
if initial_xml and initial_xml != final_xml:
domain = self.conn.defineXML(final_xml)
return domain
def _create_guest(self, guest,
meter, initial_xml, final_xml, doboot, transient):
"""
Actually do the XML logging, guest defining/creating
:param doboot: Boot guest even if it has no install phase
"""
meter_label = _("Creating domain...")
meter = progress.ensure_meter(meter)
meter.start(meter_label, None)
needs_boot = doboot or bool(initial_xml)
if guest.type == "vz" and not self._is_reinstall:
if transient:
raise RuntimeError(_("Domain type 'vz' doesn't support "
"transient installs."))
domain = self._manual_transient_create(
initial_xml, final_xml, needs_boot)
else:
if transient or needs_boot:
domain = self.conn.createXML(initial_xml or final_xml, 0)
if not transient:
domain = self.conn.defineXML(final_xml)
try:
log.debug("XML fetched from libvirt object:\n%s",
domain.XMLDesc(0))
except Exception as e: # pragma: no cover
log.debug("Error fetching XML from libvirt object: %s", e)
meter.end()
return domain
def _flag_autostart(self, domain):
"""
Set the autostart flag for domain if the user requested it
"""
try:
domain.setAutostart(True)
except Exception as e: # pragma: no cover
if not self.conn.support.is_error_nosupport(e):
raise
log.warning("Could not set autostart flag: libvirt "
"connection does not support autostart.")
######################
# Public install API #
######################
def start_install(self, user_guest, meter=None,
dry=False, return_xml=False,
doboot=True, transient=False):
"""
Begin the guest install. Will add install media to the guest config,
launch it, then redefine the XML with the postinstall config.
:param return_xml: Don't create the guest, just return generated XML
"""
if not self._is_reinstall and not return_xml:
Guest.validate_name(self.conn, user_guest.name)
self.set_install_defaults(user_guest)
disks = user_guest.devices.disk[:]
# All installer XML alterations are made on this guest instance,
# so the user_guest instance is left intact
guest = Guest(self.conn, parsexml=user_guest.get_xml())
guest.have_default_tpm = user_guest.have_default_tpm
try:
self._prepare(guest, meter)
if not dry and not self._is_reinstall:
for dev in disks:
dev.build_storage(meter)
initial_xml, final_xml = self._build_xml(guest, meter)
if dry or return_xml:
return (initial_xml, final_xml)
domain = self._create_guest(
guest, meter, initial_xml, final_xml,
doboot, transient)
if self.autostart:
self._flag_autostart(domain)
return domain
finally:
self._cleanup(guest)
|