1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
|
From: =?utf-8?b?0L3QsNCx?= <nabijaczleweli@nabijaczleweli.xyz>
Date: Sat, 19 Oct 2024 21:13:54 +0200
Subject: sockets.cxx:195:12: error: format not a string literal and no format
arguments [-Werror=format-security]
---
sockets.cxx | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/sockets.cxx b/sockets.cxx
index ecdf0db..1f954f7 100644
--- a/sockets.cxx
+++ b/sockets.cxx
@@ -89,12 +89,12 @@ InitializeSockets(void)
/* than 2.2 in addition to 2.2, it will still return */
/* 2.2 in wVersion since that is the version we */
/* requested. */
-
+
if ( LOBYTE( wsaData.wVersion ) != 2 ||
HIBYTE( wsaData.wVersion ) != 2 ) {
fprintf(stderr, "Cannot get proper version of Windows Sockets\n");
WSACleanup( );
- return False;
+ return False;
}
/* The WinSock DLL is acceptable. Proceed. */
@@ -192,13 +192,13 @@ int ConnectToTcpAddr(const char* hostname, int port)
sock = socket(AF_INET, SOCK_STREAM, 0);
if (sock < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ConnectToTcpAddr: socket");
return -1;
}
if (connect(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ConnectToTcpAddr: connect");
close(sock);
return -1;
@@ -206,7 +206,7 @@ int ConnectToTcpAddr(const char* hostname, int port)
if (setsockopt(sock, IPPROTO_TCP, TCP_NODELAY,
(char *)&one, sizeof(one)) < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ConnectToTcpAddr: setsockopt");
close(sock);
return -1;
@@ -233,7 +233,7 @@ FindFreeTcpPort(void)
sock = socket(AF_INET, SOCK_STREAM, 0);
if (sock < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": FindFreeTcpPort: socket");
return 0;
}
@@ -268,28 +268,28 @@ int ListenAtTcpPort(int port)
sock = socket(AF_INET, SOCK_STREAM, 0);
if (sock < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ListenAtTcpPort: socket");
return -1;
}
if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR,
(const char *)&one, sizeof(one)) < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ListenAtTcpPort: setsockopt");
close(sock);
return -1;
}
if (bind(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ListenAtTcpPort: bind");
close(sock);
return -1;
}
if (listen(sock, 5) < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": ListenAtTcpPort: listen");
close(sock);
return -1;
@@ -312,14 +312,14 @@ int AcceptTcpConnection(int listenSock)
sock = accept(listenSock, (struct sockaddr *) &addr, &addrlen);
if (sock < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": AcceptTcpConnection: accept");
return -1;
}
if (setsockopt(sock, IPPROTO_TCP, TCP_NODELAY,
(char *)&one, sizeof(one)) < 0) {
- fprintf(stderr,programName);
+ fputs(programName, stderr);
perror(": AcceptTcpConnection: setsockopt");
close(sock);
return -1;
|
