1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281
|
/* Copyright (c) 2024-2025 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "gpuav/instrumentation/post_process_descriptor_indexing.h"
#include "drawdispatch/descriptor_validator.h"
#include "gpuav/core/gpuav.h"
#include "gpuav/resources/gpuav_shader_resources.h"
#include "gpuav/resources/gpuav_state_trackers.h"
#include "state_tracker/pipeline_state.h"
#include "state_tracker/shader_module.h"
#include "state_tracker/shader_object_state.h"
#include "profiling/profiling.h"
namespace gpuav {
struct PostProcessingCbState {
vko::BufferRange last_desc_set_binding_to_post_process_buffers_lut;
};
void RegisterPostProcessingValidation(Validator& gpuav, CommandBufferSubState& cb) {
if (!gpuav.gpuav_settings.shader_instrumentation.post_process_descriptor_indexing) {
return;
}
DescriptorSetBindings& desc_set_bindings = cb.shared_resources_cache.GetOrCreate<DescriptorSetBindings>();
desc_set_bindings.on_update_bound_descriptor_sets.emplace_back(
[](Validator&, CommandBufferSubState& cb, DescriptorSetBindings::BindingCommand& desc_binding_cmd) {
PostProcessingCbState& pp_cb_state = cb.shared_resources_cache.GetOrCreate<PostProcessingCbState>();
pp_cb_state.last_desc_set_binding_to_post_process_buffers_lut =
cb.gpu_resources_manager.GetDeviceLocalBufferRange(sizeof(glsl::PostProcessSSBO));
desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut =
pp_cb_state.last_desc_set_binding_to_post_process_buffers_lut;
});
cb.on_instrumentation_desc_set_update_functions.emplace_back(
[dummy_buffer_range = vko::BufferRange{}](CommandBufferSubState& cb, VkPipelineBindPoint,
VkDescriptorBufferInfo& out_buffer_info, uint32_t& out_dst_binding) mutable {
PostProcessingCbState* pp_cb_state = cb.shared_resources_cache.TryGet<PostProcessingCbState>();
if (pp_cb_state) {
out_buffer_info.buffer = pp_cb_state->last_desc_set_binding_to_post_process_buffers_lut.buffer;
out_buffer_info.offset = pp_cb_state->last_desc_set_binding_to_post_process_buffers_lut.offset;
out_buffer_info.range = pp_cb_state->last_desc_set_binding_to_post_process_buffers_lut.size;
} else {
// Eventually, no descriptor set was bound in command buffer.
// Instrumenation descriptor set is already defined at this point and needs a binding,
// so just provide a dummy buffer
if (dummy_buffer_range.buffer == VK_NULL_HANDLE) {
dummy_buffer_range = cb.gpu_resources_manager.GetDeviceLocalBufferRange(64);
}
out_buffer_info.buffer = dummy_buffer_range.buffer;
out_buffer_info.offset = dummy_buffer_range.offset;
out_buffer_info.range = dummy_buffer_range.size;
}
out_dst_binding = glsl::kBindingInstPostProcess;
});
auto bound_desc_sets_to_pp_buffer_map =
std::make_shared<vvl::unordered_map<std::shared_ptr<vvl::DescriptorSet>, vko::StagingBuffer>>();
cb.on_pre_cb_submission_functions.emplace_back([bound_desc_sets_to_pp_buffer_map](Validator& gpuav, CommandBufferSubState& cb,
VkCommandBuffer per_pre_submission_cb) {
VVL_ZoneScoped;
DescriptorSetBindings& desc_set_bindings = cb.shared_resources_cache.Get<DescriptorSetBindings>();
for (const DescriptorSetBindings::BindingCommand& desc_binding_cmd : desc_set_bindings.descriptor_set_binding_commands) {
vko::BufferRange desc_set_buffer_lut_buffer_range = cb.gpu_resources_manager.GetHostVisibleBufferRange(
32 * sizeof(VkDeviceAddress)); // No driver offers more than 32 descriptor set bindings
// For each unique bound descriptor set in this command buffer,
// create an appropriate post processing buffer,
// and update the "per CB submission desciptor set to post process buffers" LUT
// For each CB submission, and for each descriptor binding command,
// a "desciptor set to post process buffers LUT" is allocated and updated in a VkBuffer.
// When executing, this CB submission will access its own private
// post processing buffers, preventing concurrent use by another CB
for (size_t ds_i = 0; ds_i < desc_binding_cmd.bound_descriptor_sets.size(); ds_i++) {
// Perfectly can have gaps in descriptor sets bindings
if (!desc_binding_cmd.bound_descriptor_sets[ds_i]) {
continue;
}
DescriptorSetSubState& desc_set_state = SubState(*desc_binding_cmd.bound_descriptor_sets[ds_i]);
if (auto found = bound_desc_sets_to_pp_buffer_map->find(desc_binding_cmd.bound_descriptor_sets[ds_i]);
found == bound_desc_sets_to_pp_buffer_map->end()) {
// DescriptorSetSubState::GetPostProcessBufferSize() used to do a "auto guard = Lock()"
// But the lock was only guarding againg GPU-AV sub state, not the base state, so
// base.GetNonInlineDescriptorCount() access were not fully protected
const VkDeviceSize pp_buffer_size =
desc_set_state.base.GetNonInlineDescriptorCount() * sizeof(glsl::PostProcessDescriptorIndexSlot);
if (pp_buffer_size == 0) {
continue;
}
vko::StagingBuffer staging_buffer(cb.gpu_resources_manager, pp_buffer_size, per_pre_submission_cb);
auto desc_set_buffer_lut_ptr = (VkDeviceAddress*)desc_set_buffer_lut_buffer_range.offset_mapped_ptr;
desc_set_buffer_lut_ptr[ds_i] = staging_buffer.GetBufferRange().offset_address;
bound_desc_sets_to_pp_buffer_map->insert({desc_binding_cmd.bound_descriptor_sets[ds_i], staging_buffer});
} else {
auto desc_set_buffer_lut_ptr = (VkDeviceAddress*)desc_set_buffer_lut_buffer_range.offset_mapped_ptr;
desc_set_buffer_lut_ptr[ds_i] = found->second.GetBufferRange().offset_address;
}
}
// Dispatch a copy command, copying the per CB submission descriptor set LUT to the LUT created at
// "bind descriptor set command" record time, aka the one that shaders will ultimately access.
{
VkBufferMemoryBarrier barrier_write_after_read = vku::InitStructHelper();
barrier_write_after_read.srcAccessMask = VK_ACCESS_MEMORY_READ_BIT;
barrier_write_after_read.dstAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT;
barrier_write_after_read.buffer = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.buffer;
barrier_write_after_read.offset = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.offset;
barrier_write_after_read.size = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.size;
DispatchCmdPipelineBarrier(per_pre_submission_cb, VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
VK_PIPELINE_STAGE_TRANSFER_BIT, 0, 0, nullptr, 1, &barrier_write_after_read, 0, nullptr);
VkBufferCopy copy;
copy.srcOffset = desc_set_buffer_lut_buffer_range.offset;
copy.dstOffset = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.offset;
copy.size = desc_binding_cmd.bound_descriptor_sets.size() * sizeof(VkDeviceAddress);
DispatchCmdCopyBuffer(per_pre_submission_cb, desc_set_buffer_lut_buffer_range.buffer,
desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.buffer, 1, ©);
VkBufferMemoryBarrier barrier_read_before_write = vku::InitStructHelper();
barrier_read_before_write.srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT;
barrier_read_before_write.dstAccessMask = VK_ACCESS_MEMORY_READ_BIT;
barrier_read_before_write.buffer = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.buffer;
barrier_read_before_write.offset = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.offset;
barrier_read_before_write.size = desc_binding_cmd.desc_set_binding_to_post_process_buffers_lut.size;
DispatchCmdPipelineBarrier(per_pre_submission_cb, VK_PIPELINE_STAGE_TRANSFER_BIT,
VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, 0, 0, nullptr, 1, &barrier_read_before_write, 0,
nullptr);
}
}
});
if (vko::StagingBuffer::CanDeviceEverStage(gpuav)) {
cb.on_post_cb_submission_functions.emplace_back([bound_desc_sets_to_pp_buffer_map](Validator& gpuav,
CommandBufferSubState& cb,
VkCommandBuffer per_post_submission_cb) {
for (const auto& [desc_set, staging_buffer] : *bound_desc_sets_to_pp_buffer_map) {
staging_buffer.CmdCopyDeviceToHost(per_post_submission_cb);
}
});
}
// Validate descriptor set accesses done by command buffer submission
cb.on_cb_completion_functions.emplace_back([bound_desc_sets_to_pp_buffer_map](
Validator& gpuav, CommandBufferSubState& cb,
const CommandBufferSubState::LabelLogging& label_logging, const Location& loc) {
VVL_ZoneScoped;
// TODO - Currently we don't know the actual call that triggered this, but without just giving "vkCmdDraw" we
// will get VUID_Undefined We now have the DescriptorValidator::action_index, just need to hook it up!
Location draw_loc(vvl::Func::vkCmdDraw);
// We loop each vkCmdBindDescriptorSet, find each VkDescriptorSet that was used in the command buffer, and check
// its post process buffer for which descriptor was accessed Only check a VkDescriptorSet once, might be bound
// multiple times in a single command buffer
for (auto& [desc_set, staging_buffer] : *bound_desc_sets_to_pp_buffer_map) {
// We build once here, but will update the set_index and shader_handle when found
vvl::DescriptorValidator context(gpuav, cb.base, *desc_set, 0, VK_NULL_HANDLE, nullptr, draw_loc);
// We create a map with the |unique_shader_id| as the key so we can only do the state object lookup once per
// pipeline/shaderModule/shaderObject
using DescriptorAccessMap = vvl::unordered_map<uint32_t, std::vector<DescriptorAccess>>;
DescriptorAccessMap descriptor_access_map;
{
auto slot_ptr = (glsl::PostProcessDescriptorIndexSlot*)staging_buffer.GetHostBufferPtr();
const std::vector<gpuav::spirv::BindingLayout>& binding_layouts = SubState(*desc_set).GetBindingLayouts();
for (uint32_t binding = 0; binding < binding_layouts.size(); binding++) {
const gpuav::spirv::BindingLayout& binding_layout = binding_layouts[binding];
for (uint32_t descriptor_i = 0; descriptor_i < binding_layout.count; descriptor_i++) {
const glsl::PostProcessDescriptorIndexSlot slot = slot_ptr[binding_layout.start + descriptor_i];
if (slot.meta_data & glsl::kPostProcessMetaMaskAccessed) {
const uint32_t shader_id = slot.meta_data & glsl::kShaderIdMask;
const uint32_t action_index =
(slot.meta_data & glsl::kPostProcessMetaMaskActionIndex) >> glsl::kPostProcessMetaShiftActionIndex;
descriptor_access_map[shader_id].emplace_back(
DescriptorAccess{binding, descriptor_i, slot.variable_id, action_index});
}
}
}
}
// For each shader ID we can do the state object lookup once, then validate all the accesses inside of it
for (const auto& [shader_id, descriptor_accesses] : descriptor_access_map) {
auto it = gpuav.instrumented_shaders_map_.find(shader_id);
if (it == gpuav.instrumented_shaders_map_.end()) {
assert(false);
continue;
}
const vvl::Pipeline* pipeline_state = nullptr;
const vvl::ShaderObject* shader_object_state = nullptr;
if (it->second.pipeline != VK_NULL_HANDLE) {
// We use pipeline over vkShaderModule as likely they will have been destroyed by now
pipeline_state = gpuav.Get<vvl::Pipeline>(it->second.pipeline).get();
context.SetShaderHandleForGpuAv(&pipeline_state->Handle());
} else if (it->second.shader_object != VK_NULL_HANDLE) {
shader_object_state = gpuav.Get<vvl::ShaderObject>(it->second.shader_object).get();
ASSERT_AND_CONTINUE(shader_object_state->entrypoint);
context.SetShaderHandleForGpuAv(&shader_object_state->Handle());
} else {
assert(false);
continue;
}
for (const DescriptorAccess& descriptor_access : descriptor_accesses) {
auto descriptor_binding = desc_set->GetBinding(descriptor_access.binding);
ASSERT_AND_CONTINUE(descriptor_binding);
const ::spirv::ResourceInterfaceVariable* resource_variable = nullptr;
if (pipeline_state) {
for (const ShaderStageState& stage_state : pipeline_state->stage_states) {
ASSERT_AND_CONTINUE(stage_state.entrypoint);
auto variable_it =
stage_state.entrypoint->resource_interface_variable_map.find(descriptor_access.variable_id);
if (variable_it != stage_state.entrypoint->resource_interface_variable_map.end()) {
resource_variable = variable_it->second;
break; // Only need to find a single entry point
}
}
} else if (shader_object_state) {
ASSERT_AND_CONTINUE(shader_object_state->entrypoint);
auto variable_it =
shader_object_state->entrypoint->resource_interface_variable_map.find(descriptor_access.variable_id);
if (variable_it != shader_object_state->entrypoint->resource_interface_variable_map.end()) {
resource_variable = variable_it->second;
}
}
ASSERT_AND_CONTINUE(resource_variable);
// If we already validated/updated the descriptor on the CPU, don't redo it now in GPU-AV Post
// Processing
if (!desc_set->ValidateBindingOnGPU(*descriptor_binding, *resource_variable)) {
continue;
}
// This will represent the Set that was accessed in the shader, which might not match the
// vkCmdBindDescriptorSet index if sets are aliased
context.SetSetIndexForGpuAv(resource_variable->decorations.set);
std::string debug_region_name;
if (auto found_label_cmd_i = label_logging.action_cmd_i_to_label_cmd_i_map.find(descriptor_access.action_index);
found_label_cmd_i != label_logging.action_cmd_i_to_label_cmd_i_map.end()) {
debug_region_name = cb.GetDebugLabelRegion(found_label_cmd_i->second, label_logging.initial_label_stack);
}
Location access_loc(loc, debug_region_name);
context.SetLocationForGpuAv(access_loc);
context.ValidateBindingDynamic(*resource_variable, *descriptor_binding, descriptor_access.index);
}
}
}
return true;
});
}
} // namespace gpuav
|