1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
|
/* Copyright (c) 2018-2025 The Khronos Group Inc.
* Copyright (c) 2018-2025 Valve Corporation
* Copyright (c) 2018-2025 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "gpuav/core/gpuav.h"
#include "gpuav/core/gpuav_validation_pipeline.h"
#include "gpuav/validation_cmd/gpuav_validation_cmd_common.h"
#include "gpuav/resources/gpuav_vulkan_objects.h"
#include "gpuav/resources/gpuav_state_trackers.h"
#include "gpuav/shaders/gpuav_error_header.h"
#include "gpuav/shaders/validation_cmd/push_data.h"
#include "generated/gpuav_offline_spirv.h"
#include "error_message/error_strings.h"
#include "containers/limits.h"
namespace gpuav {
namespace valcmd {
struct TraceRaysValidationShader {
static size_t GetSpirvSize() { return validation_cmd_trace_rays_comp_size * sizeof(uint32_t); }
static const uint32_t* GetSpirv() { return validation_cmd_trace_rays_comp; }
glsl::TraceRaysPushData push_constants{};
static std::vector<VkDescriptorSetLayoutBinding> GetDescriptorSetLayoutBindings() { return {}; }
std::vector<VkWriteDescriptorSet> GetDescriptorWrites(VkDescriptorSet desc_set) const { return {}; }
};
void TraceRaysIndirect(Validator& gpuav, const Location& loc, CommandBufferSubState& cb_state,
VkDeviceAddress indirect_data_address) {
if (!gpuav.gpuav_settings.validate_indirect_trace_rays_buffers) {
return;
}
if (!gpuav.modified_features.shaderInt64) {
return;
}
if (cb_state.max_actions_cmd_validation_reached_) {
return;
}
valpipe::RestorablePipelineState restorable_state(cb_state, VK_PIPELINE_BIND_POINT_COMPUTE);
ValidationCommandsCommon& val_cmd_common =
cb_state.shared_resources_cache.GetOrCreate<ValidationCommandsCommon>(gpuav, cb_state, loc);
valpipe::ComputePipeline<TraceRaysValidationShader>& validation_pipeline =
gpuav.shared_resources_manager.GetOrCreate<valpipe::ComputePipeline<TraceRaysValidationShader>>(
gpuav, loc, val_cmd_common.error_logging_desc_set_layout_);
if (!validation_pipeline.valid) {
return;
}
// Setup shader resources
// ---
{
const uint64_t ray_query_dimension_max_width =
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupCount[0]) *
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupSize[0]);
const uint64_t ray_query_dimension_max_height =
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupCount[1]) *
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupSize[1]);
const uint64_t ray_query_dimension_max_depth =
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupCount[2]) *
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupSize[2]);
VkPhysicalDeviceRayTracingPipelinePropertiesKHR rt_pipeline_props = vku::InitStructHelper();
VkPhysicalDeviceProperties2 props2 = vku::InitStructHelper(&rt_pipeline_props);
DispatchGetPhysicalDeviceProperties2(gpuav.physical_device, &props2);
TraceRaysValidationShader shader_resources;
shader_resources.push_constants.indirect_data = indirect_data_address;
shader_resources.push_constants.trace_rays_width_limit =
static_cast<uint32_t>(std::min<uint64_t>(ray_query_dimension_max_width, vvl::kU32Max));
shader_resources.push_constants.trace_rays_height_limit =
static_cast<uint32_t>(std::min<uint64_t>(ray_query_dimension_max_height, vvl::kU32Max));
shader_resources.push_constants.trace_rays_depth_limit =
static_cast<uint32_t>(std::min<uint64_t>(ray_query_dimension_max_depth, vvl::kU32Max));
shader_resources.push_constants.max_ray_dispatch_invocation_count = rt_pipeline_props.maxRayDispatchInvocationCount;
if (!BindShaderResources(validation_pipeline, gpuav, cb_state, cb_state.compute_index,
uint32_t(cb_state.per_command_error_loggers.size()), shader_resources)) {
return;
}
}
// Setup validation pipeline
// ---
{
DispatchCmdBindPipeline(cb_state.VkHandle(), VK_PIPELINE_BIND_POINT_COMPUTE, validation_pipeline.pipeline);
DispatchCmdDispatch(cb_state.VkHandle(), 1, 1, 1);
}
CommandBufferSubState::ErrorLoggerFunc error_logger = [&gpuav, loc](const uint32_t* error_record, const LogObjectList& objlist,
const std::vector<std::string>&) {
bool skip = false;
using namespace glsl;
const uint32_t error_group = error_record[kHeaderShaderIdErrorOffset] >> kErrorGroupShift;
if (error_group != kErrorGroupGpuPreTraceRays) {
return skip;
}
const uint32_t error_sub_code = (error_record[kHeaderShaderIdErrorOffset] & kErrorSubCodeMask) >> kErrorSubCodeShift;
switch (error_sub_code) {
case kErrorSubCodePreTraceRaysLimitWidth: {
const uint32_t width = error_record[kPreActionParamOffset_0];
skip |= gpuav.LogError("VUID-VkTraceRaysIndirectCommandKHR-width-03638", objlist, loc,
"Indirect trace rays of VkTraceRaysIndirectCommandKHR::width of %" PRIu32
" would exceed VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] * "
"VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0] limit of %" PRIu64 ".",
width,
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupCount[0]) *
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupSize[0]));
break;
}
case kErrorSubCodePreTraceRaysLimitHeight: {
const uint32_t height = error_record[kPreActionParamOffset_0];
skip |= gpuav.LogError("VUID-VkTraceRaysIndirectCommandKHR-height-03639", objlist, loc,
"Indirect trace rays of VkTraceRaysIndirectCommandKHR::height of %" PRIu32
" would exceed VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] * "
"VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1] limit of %" PRIu64 ".",
height,
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupCount[1]) *
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupSize[1]));
break;
}
case kErrorSubCodePreTraceRaysLimitDepth: {
const uint32_t depth = error_record[kPreActionParamOffset_0];
skip |= gpuav.LogError("VUID-VkTraceRaysIndirectCommandKHR-depth-03640", objlist, loc,
"Indirect trace rays of VkTraceRaysIndirectCommandKHR::height of %" PRIu32
" would exceed VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] * "
"VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2] limit of %" PRIu64 ".",
depth,
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupCount[2]) *
static_cast<uint64_t>(gpuav.phys_dev_props.limits.maxComputeWorkGroupSize[2]));
break;
}
case kErrorSubCodePreTraceRaysLimitVolume: {
VkPhysicalDeviceRayTracingPipelinePropertiesKHR rt_pipeline_props = vku::InitStructHelper();
VkPhysicalDeviceProperties2 props2 = vku::InitStructHelper(&rt_pipeline_props);
DispatchGetPhysicalDeviceProperties2(gpuav.physical_device, &props2);
const VkExtent3D trace_rays_extent = {error_record[kPreActionParamOffset_0], error_record[kPreActionParamOffset_1],
error_record[kPreActionParamOffset_2]};
const uint64_t rays_volume = trace_rays_extent.width * trace_rays_extent.height * trace_rays_extent.depth;
skip |= gpuav.LogError(
"VUID-VkTraceRaysIndirectCommandKHR-width-03641", objlist, loc,
"Indirect trace rays of volume %" PRIu64
" (%s) would exceed VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount "
"limit of %" PRIu32 ".",
rays_volume, string_VkExtent3D(trace_rays_extent).c_str(), rt_pipeline_props.maxRayDispatchInvocationCount);
break;
}
default:
break;
}
return skip;
};
cb_state.per_command_error_loggers.emplace_back(std::move(error_logger));
}
} // namespace valcmd
} // namespace gpuav
|
