1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
/* Copyright (c) 2018-2025 The Khronos Group Inc.
* Copyright (c) 2018-2025 Valve Corporation
* Copyright (c) 2018-2025 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "gpuav/validation_cmd/gpuav_validation_cmd_common.h"
#include <vulkan/vulkan_core.h>
#include "gpuav/core/gpuav.h"
#include "gpuav/core/gpuav_constants.h"
#include "gpuav/resources/gpuav_state_trackers.h"
#include "gpuav/shaders/gpuav_shaders_constants.h"
namespace gpuav {
namespace valcmd {
namespace internal {
static void BindErrorLoggingDescSet(Validator &gpuav, CommandBufferSubState &cb_state, VkPipelineBindPoint bind_point,
VkPipelineLayout pipeline_layout, uint32_t cmd_index, uint32_t error_logger_index) {
assert(cmd_index < cst::indices_count);
assert(error_logger_index < cst::indices_count);
std::array<uint32_t, 2> dynamic_offsets = {
{cmd_index * gpuav.indices_buffer_alignment_, error_logger_index * gpuav.indices_buffer_alignment_}};
ValidationCommandsCommon &val_cmd_common = cb_state.shared_resources_cache.Get<ValidationCommandsCommon>();
DispatchCmdBindDescriptorSets(cb_state.VkHandle(), bind_point, pipeline_layout, glsl::kDiagCommonDescriptorSet, 1,
&val_cmd_common.error_logging_desc_set_, static_cast<uint32_t>(dynamic_offsets.size()),
dynamic_offsets.data());
}
void BindShaderResourcesHelper(Validator &gpuav, CommandBufferSubState &cb_state, uint32_t cmd_index, uint32_t error_logger_index,
VkPipelineLayout pipeline_layout, VkDescriptorSet desc_set,
const std::vector<VkWriteDescriptorSet> &descriptor_writes, const uint32_t push_constants_byte_size,
const void *push_constants) {
// Error logging resources
BindErrorLoggingDescSet(gpuav, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE, pipeline_layout, cmd_index, error_logger_index);
// Any push constants byte size below 4 is illegal. Can come from empty push constant struct
if (push_constants_byte_size >= 4) {
DispatchCmdPushConstants(cb_state.VkHandle(), pipeline_layout, VK_SHADER_STAGE_COMPUTE_BIT, 0, push_constants_byte_size,
push_constants);
}
if (!descriptor_writes.empty()) {
// Specific resources
DispatchUpdateDescriptorSets(gpuav.device, uint32_t(descriptor_writes.size()), descriptor_writes.data(), 0, nullptr);
DispatchCmdBindDescriptorSets(cb_state.VkHandle(), VK_PIPELINE_BIND_POINT_COMPUTE, pipeline_layout, glsl::kValPipeDescSet,
1, &desc_set, 0, nullptr);
}
}
} // namespace internal
ValidationCommandsCommon::ValidationCommandsCommon(Validator &gpuav, CommandBufferSubState &cb, const Location &loc)
: gpuav_(gpuav) {
const std::vector<VkDescriptorSetLayoutBinding> validation_cmd_bindings = {
// Error output buffer
{glsl::kBindingDiagErrorBuffer, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1, VK_SHADER_STAGE_ALL, nullptr},
// Buffer holding action command index in command buffer
{glsl::kBindingDiagActionIndex, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, 1, VK_SHADER_STAGE_ALL, nullptr},
// Buffer holding a resource index from the per command buffer command resources list
{glsl::kBindingDiagCmdResourceIndex, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, 1, VK_SHADER_STAGE_ALL, nullptr},
// Commands errors counts buffer
{glsl::kBindingDiagCmdErrorsCount, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1, VK_SHADER_STAGE_ALL, nullptr},
};
if (error_logging_desc_set_layout_ == VK_NULL_HANDLE) {
VkDescriptorSetLayoutCreateInfo validation_cmd_desc_set_layout_ci = vku::InitStructHelper();
validation_cmd_desc_set_layout_ci.bindingCount = static_cast<uint32_t>(validation_cmd_bindings.size());
validation_cmd_desc_set_layout_ci.pBindings = validation_cmd_bindings.data();
const VkResult result = DispatchCreateDescriptorSetLayout(gpuav_.device, &validation_cmd_desc_set_layout_ci, nullptr,
&error_logging_desc_set_layout_);
if (result != VK_SUCCESS) {
gpuav_.InternalError(gpuav_.device, loc, "Unable to create descriptor set layout used for validation commands.");
return;
}
}
assert((validation_cmd_desc_pool_ == VK_NULL_HANDLE) == (error_logging_desc_set_ == VK_NULL_HANDLE));
if (validation_cmd_desc_pool_ == VK_NULL_HANDLE && error_logging_desc_set_ == VK_NULL_HANDLE) {
const VkResult result = gpuav_.desc_set_manager_->GetDescriptorSet(
&validation_cmd_desc_pool_, error_logging_desc_set_layout_, &error_logging_desc_set_);
if (result != VK_SUCCESS) {
gpuav_.InternalError(gpuav_.device, loc, "Unable to create descriptor set used for validation commands.");
return;
}
}
std::array<VkWriteDescriptorSet, 4> validation_cmd_descriptor_writes = {};
assert(validation_cmd_bindings.size() == validation_cmd_descriptor_writes.size());
VkDescriptorBufferInfo error_output_buffer_desc_info = {};
assert(cb.error_output_buffer_range_.buffer != VK_NULL_HANDLE);
error_output_buffer_desc_info.buffer = cb.error_output_buffer_range_.buffer;
error_output_buffer_desc_info.offset = cb.error_output_buffer_range_.offset;
error_output_buffer_desc_info.range = cb.error_output_buffer_range_.size;
validation_cmd_descriptor_writes[0] = vku::InitStructHelper();
validation_cmd_descriptor_writes[0].dstBinding = glsl::kBindingDiagErrorBuffer;
validation_cmd_descriptor_writes[0].descriptorCount = 1;
validation_cmd_descriptor_writes[0].descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER;
validation_cmd_descriptor_writes[0].pBufferInfo = &error_output_buffer_desc_info;
validation_cmd_descriptor_writes[0].dstSet = error_logging_desc_set_;
VkDescriptorBufferInfo cmd_indices_buffer_desc_info = {};
assert(!gpuav_.indices_buffer_.IsDestroyed());
cmd_indices_buffer_desc_info.buffer = gpuav_.indices_buffer_.VkHandle();
cmd_indices_buffer_desc_info.offset = 0;
cmd_indices_buffer_desc_info.range = sizeof(uint32_t);
validation_cmd_descriptor_writes[1] = vku::InitStructHelper();
validation_cmd_descriptor_writes[1].dstBinding = glsl::kBindingDiagActionIndex;
validation_cmd_descriptor_writes[1].descriptorCount = 1;
validation_cmd_descriptor_writes[1].descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC;
validation_cmd_descriptor_writes[1].pBufferInfo = &cmd_indices_buffer_desc_info;
validation_cmd_descriptor_writes[1].dstSet = error_logging_desc_set_;
validation_cmd_descriptor_writes[2] = validation_cmd_descriptor_writes[1];
validation_cmd_descriptor_writes[2].dstBinding = glsl::kBindingDiagCmdResourceIndex;
VkDescriptorBufferInfo cmd_errors_count_buffer_desc_info = {};
cmd_errors_count_buffer_desc_info.buffer = cb.GetCmdErrorsCountsBuffer();
cmd_errors_count_buffer_desc_info.offset = 0;
cmd_errors_count_buffer_desc_info.range = VK_WHOLE_SIZE;
validation_cmd_descriptor_writes[3] = vku::InitStructHelper();
validation_cmd_descriptor_writes[3].dstBinding = glsl::kBindingDiagCmdErrorsCount;
validation_cmd_descriptor_writes[3].descriptorCount = 1;
validation_cmd_descriptor_writes[3].descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER;
validation_cmd_descriptor_writes[3].pBufferInfo = &cmd_errors_count_buffer_desc_info;
validation_cmd_descriptor_writes[3].dstSet = error_logging_desc_set_;
DispatchUpdateDescriptorSets(gpuav_.device, static_cast<uint32_t>(validation_cmd_descriptor_writes.size()),
validation_cmd_descriptor_writes.data(), 0, NULL);
}
ValidationCommandsCommon::~ValidationCommandsCommon() {
if (validation_cmd_desc_pool_ != VK_NULL_HANDLE && error_logging_desc_set_ != VK_NULL_HANDLE) {
gpuav_.desc_set_manager_->PutBackDescriptorSet(validation_cmd_desc_pool_, error_logging_desc_set_);
validation_cmd_desc_pool_ = VK_NULL_HANDLE;
error_logging_desc_set_ = VK_NULL_HANDLE;
}
if (error_logging_desc_set_layout_ != VK_NULL_HANDLE) {
DispatchDestroyDescriptorSetLayout(gpuav_.device, error_logging_desc_set_layout_, nullptr);
error_logging_desc_set_layout_ = VK_NULL_HANDLE;
}
}
} // namespace valcmd
} // namespace gpuav
|
