1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
|
/* Copyright (c) 2015-2025 The Khronos Group Inc.
* Copyright (c) 2015-2025 Valve Corporation
* Copyright (c) 2015-2025 LunarG, Inc.
* Copyright (C) 2015-2025 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "chassis/validation_object.h"
#include "containers/small_vector.h"
namespace object_lifetimes {
// Object Status -- used to track state of individual objects
typedef VkFlags ObjectStatusFlags;
enum ObjectStatusFlagBits {
OBJSTATUS_NONE = 0x00000000, // No status is set
OBJSTATUS_CUSTOM_ALLOCATOR = 0x00000002, // Allocated with custom allocator
};
// Object and state information structure
struct ObjTrackState {
uint64_t handle; // Object handle (new)
VulkanObjectType object_type; // Object type identifier
ObjectStatusFlags status; // Object state
uint64_t parent_object; // Parent object
std::unique_ptr<vvl::unordered_set<uint64_t> > child_objects; // Child objects (used for VkDescriptorPool only)
};
typedef vvl::concurrent_unordered_map<uint64_t, std::shared_ptr<ObjTrackState>, 6> object_map_type;
// Used for GPL and we know there are at most only 4 libraries that should be used
typedef vvl::concurrent_unordered_map<uint64_t, small_vector<std::shared_ptr<ObjTrackState>, 4>, 6> object_list_map_type;
class Tracker : public Logger {
public:
Tracker(DebugReport *dr) : Logger(dr) {}
void DestroyUndestroyedObjects(VulkanObjectType object_type, const Location &loc);
template <typename T1>
bool ValidateDestroyObject(T1 object_handle, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const {
auto object = HandleToUint64(object_handle);
const bool custom_allocator = pAllocator != nullptr;
bool skip = false;
if ((expected_custom_allocator_code != kVUIDUndefined || expected_default_allocator_code != kVUIDUndefined) &&
object != HandleToUint64(VK_NULL_HANDLE)) {
auto item = object_map[object_type].find(object);
if (item != object_map[object_type].end()) {
auto allocated_with_custom = (item->second->status & OBJSTATUS_CUSTOM_ALLOCATOR) ? true : false;
if (allocated_with_custom && !custom_allocator && expected_custom_allocator_code != kVUIDUndefined) {
// This check only verifies that custom allocation callbacks were provided to both Create and Destroy calls,
// it cannot verify that these allocation callbacks are compatible with each other.
skip |= LogError(expected_custom_allocator_code, object_handle, loc,
"Custom allocator not specified while destroying %s obj 0x%" PRIxLEAST64
" but specified at creation.",
string_VulkanObjectType(object_type), object);
} else if (!allocated_with_custom && custom_allocator && expected_default_allocator_code != kVUIDUndefined) {
skip |= LogError(expected_default_allocator_code, object_handle, loc,
"Custom allocator specified while destroying %s obj 0x%" PRIxLEAST64
" but not specified at creation.",
string_VulkanObjectType(object_type), object);
}
}
}
return skip;
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc,
VulkanObjectType parent_type = kVulkanObjectTypeDevice) const {
if (null_allowed && (object == VK_NULL_HANDLE)) {
return false;
}
return CheckObjectValidity(HandleToUint64(object), object_type, invalid_handle_vuid, wrong_parent_vuid, loc, parent_type);
}
template <typename T1, typename T2>
void CreateObject(T1 object, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator, const Location &loc,
T2 parent_object) {
uint64_t object_handle = HandleToUint64(object);
const bool custom_allocator = (pAllocator != nullptr);
auto &obj_map = object_map[object_type];
auto itr = obj_map.find(object_handle);
if (itr != obj_map.end()) {
return;
}
auto node = std::make_shared<ObjTrackState>();
node->object_type = object_type;
node->status = custom_allocator ? OBJSTATUS_CUSTOM_ALLOCATOR : OBJSTATUS_NONE;
node->handle = object_handle;
node->parent_object = HandleToUint64(parent_object);
const bool inserted = obj_map.insert(object_handle, node);
if (!inserted) {
// The object should not already exist. If we couldn't add it to the map, there was probably
// a race condition in the app. Report an error and move on.
// TODO should this be an error? https://gitlab.khronos.org/vulkan/vulkan/-/issues/3616
LogError("UNASSIGNED-ObjectTracker-Insert", object, loc,
"Couldn't insert %s Object 0x%" PRIxLEAST64
", already existed. This should not happen and may indicate a "
"race condition in the application.",
string_VulkanObjectType(object_type), object_handle);
return;
}
if (object_type == kVulkanObjectTypeDescriptorPool) {
node->child_objects.reset(new vvl::unordered_set<uint64_t>);
}
}
void DestroyObjectSilently(uint64_t object, VulkanObjectType object_type, const Location &loc);
template <typename T1>
void RecordDestroyObject(T1 object_handle, VulkanObjectType object_type, const Location &loc) {
auto object = HandleToUint64(object_handle);
if (object != HandleToUint64(VK_NULL_HANDLE)) {
if (object_map[object_type].contains(object)) {
DestroyObjectSilently(object, object_type, loc);
}
}
}
bool TracksObject(uint64_t object_handle, VulkanObjectType object_type) const;
bool CheckObjectValidity(uint64_t object_handle, VulkanObjectType object_type, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc, VulkanObjectType parent_type) const;
// Vector of unordered_maps per object type to hold ObjTrackState info
object_map_type object_map[kVulkanObjectTypeMax + 1];
void SetDeviceHandle(VkDevice device);
void SetInstanceHandle(VkInstance instance);
private:
// We don't know the handle (VkDevice or VkInstance) when Tracker is created and need to set afterwards
VulkanTypedHandle handle_;
};
class Instance : public vvl::base::Instance {
public:
using BaseClass = vvl::base::Instance;
using Func = vvl::Func;
using Struct = vvl::Struct;
using Field = vvl::Field;
Tracker tracker;
Instance(vvl::dispatch::Instance *dispatch);
~Instance();
void DestroyLeakedObjects();
bool ReportUndestroyedObjects(const Location &loc) const;
bool ReportLeakedObjects(VulkanObjectType object_type, const std::string &error_code,
const Location &loc) const;
void AllocateDisplayKHR(VkPhysicalDevice physical_device, VkDisplayKHR display, const Location &loc);
// helper methods for tracker
template <typename T1>
bool ValidateDestroyObject(T1 object_handle, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const {
return tracker.ValidateDestroyObject(object_handle, object_type, pAllocator, expected_custom_allocator_code,
expected_default_allocator_code, loc);
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc,
VulkanObjectType parent_type = kVulkanObjectTypeDevice) const {
return tracker.ValidateObject(object, object_type, null_allowed, invalid_handle_vuid, wrong_parent_vuid, loc, parent_type);
}
void DestroyObjectSilently(uint64_t object, VulkanObjectType object_type, const Location &loc) {
return tracker.DestroyObjectSilently(object, object_type, loc);
}
template <typename T1>
void RecordDestroyObject(T1 object, VulkanObjectType object_type, const Location &loc) {
tracker.RecordDestroyObject(object, object_type, loc);
}
void DestroyUndestroyedObjects(VulkanObjectType object_type, const Location &loc) { tracker.DestroyUndestroyedObjects(object_type, loc); }
#include "generated/object_tracker_instance_methods.h"
};
class Device : public vvl::base::Device {
using BaseClass = vvl::base::Device;
using Func = vvl::Func;
using Struct = vvl::Struct;
using Field = vvl::Field;
public:
// Override chassis read/write locks for this validation object
// This override takes a deferred lock. i.e. it is not acquired.
// This class does its own locking with a shared mutex.
ReadLockGuard ReadLock() const override;
WriteLockGuard WriteLock() override;
Tracker tracker;
mutable std::shared_mutex object_lifetime_mutex;
WriteLockGuard WriteSharedLock() { return WriteLockGuard(object_lifetime_mutex); }
ReadLockGuard ReadSharedLock() const { return ReadLockGuard(object_lifetime_mutex); }
object_list_map_type linked_graphics_pipeline_map;
// Constructor for object lifetime tracking
Device(vvl::dispatch::Device *dev, Instance *instance);
~Device();
void FinishDeviceSetup(const VkDeviceCreateInfo *pCreateInfo, const Location &loc) override;
void DestroyLeakedObjects();
bool ReportUndestroyedObjects(const Location &loc) const;
bool ReportLeakedObjects(VulkanObjectType object_type, const std::string &error_code,
const Location &loc) const;
void CreateQueue(VkQueue vkObj, const Location &loc);
void AllocateCommandBuffer(const VkCommandPool command_pool, const VkCommandBuffer command_buffer, VkCommandBufferLevel level,
const Location &loc);
void AllocateDescriptorSet(VkDescriptorPool descriptor_pool, VkDescriptorSet descriptor_set, const Location &loc);
void CreateSwapchainImageObject(VkImage swapchain_image, VkSwapchainKHR swapchain, const Location &loc);
void DestroyQueueDataStructures();
bool ValidateCommandBuffer(VkCommandPool command_pool, VkCommandBuffer command_buffer, const Location &loc) const;
bool ValidateDescriptorSet(VkDescriptorPool descriptor_pool, VkDescriptorSet descriptor_set, const Location &loc) const;
bool ValidateDescriptorSetLayoutCreateInfo(const VkDescriptorSetLayoutCreateInfo &create_info,
const Location &create_info_loc) const;
bool ValidateDescriptorWrite(VkWriteDescriptorSet const *desc, bool is_push_descriptor, const Location &loc) const;
bool ValidateAnonymousObject(uint64_t object, VkObjectType core_object_type, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc) const;
bool ValidateAccelerationStructures(const char *src_handle_vuid, const char *dst_handle_vuid, uint32_t count,
const VkAccelerationStructureBuildGeometryInfoKHR *infos, const Location &loc) const;
bool CheckPipelineObjectValidity(uint64_t object_handle, const char *invalid_handle_vuid, const Location &loc) const;
// helper methods for tracker
template <typename T1>
bool ValidateDestroyObject(T1 object_handle, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const {
return tracker.ValidateDestroyObject(object_handle, object_type, pAllocator, expected_custom_allocator_code,
expected_default_allocator_code, loc);
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc,
VulkanObjectType parent_type = kVulkanObjectTypeDevice) const {
uint64_t object_handle = HandleToUint64(object);
if (tracker.TracksObject(object_handle, kVulkanObjectTypePipeline) && loc.function != Func::vkDestroyPipeline) {
// special case if for pipeline if using GPL
// If destroying, even if the child libraries are gone, the user still has a way to remove the bad parent pipeline library
return CheckPipelineObjectValidity(object_handle, invalid_handle_vuid, loc);
}
return tracker.ValidateObject(object, object_type, null_allowed, invalid_handle_vuid, wrong_parent_vuid, loc, parent_type);
}
void DestroyObjectSilently(uint64_t object, VulkanObjectType object_type, const Location &loc) {
return tracker.DestroyObjectSilently(object, object_type, loc);
}
template <typename T1>
void RecordDestroyObject(T1 object, VulkanObjectType object_type, const Location &loc) {
tracker.RecordDestroyObject(object, object_type, loc);
}
void DestroyUndestroyedObjects(VulkanObjectType object_type, const Location &loc) { tracker.DestroyUndestroyedObjects(object_type, loc); }
#include "generated/object_tracker_device_methods.h"
};
} // namespace object_lifetimes
|