1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
|
/* Copyright (c) 2015-2025 The Khronos Group Inc.
* Copyright (c) 2015-2025 Valve Corporation
* Copyright (c) 2015-2025 LunarG, Inc.
* Copyright (C) 2015-2025 Google Inc.
* Modifications Copyright (C) 2020 Advanced Micro Devices, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "state_tracker/pipeline_layout_state.h"
#include "error_message/error_strings.h"
#include "state_tracker/shader_module.h"
#include "state_tracker/state_tracker.h"
#include "state_tracker/descriptor_sets.h"
// Dictionary of canonical form of the pipeline set layout of descriptor set layouts
static PipelineLayoutSetLayoutsDict pipeline_layout_set_layouts_dict;
// Dictionary of canonical form of the "compatible for set" records
static PipelineLayoutCompatDict pipeline_layout_compat_dict;
static PushConstantRangesDict push_constant_ranges_dict;
size_t PipelineLayoutCompatDef::hash() const {
hash_util::HashCombiner hc;
// The set number is integral to the CompatDef's distinctiveness
hc << set << push_constant_ranges.get() << is_independent_sets;
const auto &descriptor_set_layouts = *set_layouts_id.get();
for (uint32_t i = 0; i <= set; i++) {
hc << descriptor_set_layouts[i].get();
}
return hc.Value();
}
bool PipelineLayoutCompatDef::operator==(const PipelineLayoutCompatDef &other) const {
if ((set != other.set) || (push_constant_ranges != other.push_constant_ranges) ||
(is_independent_sets != other.is_independent_sets)) {
return false;
}
if (set_layouts_id == other.set_layouts_id) {
// if it's the same set_layouts_id, then *any* subset will match
return true;
}
// They aren't exactly the same PipelineLayoutSetLayouts, so we need to check if the required subsets match
const auto &descriptor_set_layouts = *set_layouts_id.get();
assert(set < descriptor_set_layouts.size());
const auto &other_ds_layouts = *other.set_layouts_id.get();
assert(set < other_ds_layouts.size());
for (uint32_t i = 0; i <= set; i++) {
if (descriptor_set_layouts[i] != other_ds_layouts[i]) {
return false;
}
}
return true;
}
std::string PipelineLayoutCompatDef::DescribeDifference(const PipelineLayoutCompatDef &other) const {
std::ostringstream ss;
if (set != other.set) {
ss << "The set " << set << " is different from the non-compatible pipeline layout (" << other.set << ")\n";
} else if (push_constant_ranges != other.push_constant_ranges) {
ss << "Pipeline layout pipeline bound with last call to vkCmdBindDescriptorSets has following push constant ranges:\n";
if (push_constant_ranges->empty()) {
ss << "Empty\n";
} else {
for (const auto [pcr_i, pcr] : vvl::enumerate(push_constant_ranges->data(), push_constant_ranges->size())) {
ss << "VkPushConstantRange[" << pcr_i << "]: " << string_VkPushConstantRange(pcr) << '\n';
}
}
ss << "But pipeline layout of last bound pipeline or last bound shaders has following push constant ranges:\n";
if (other.push_constant_ranges->empty()) {
ss << "Empty\n";
} else {
for (const auto [pcr_i, pcr] : vvl::enumerate(other.push_constant_ranges->data(), other.push_constant_ranges->size())) {
ss << "VkPushConstantRange[" << pcr_i << "]: " << string_VkPushConstantRange(pcr) << '\n';
}
}
} else if (is_independent_sets != other.is_independent_sets) {
ss << "One set is created with VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT while the other is not\n";
} else {
const auto &descriptor_set_layouts = *set_layouts_id.get();
const auto &other_ds_layouts = *other.set_layouts_id.get();
for (uint32_t i = 0; i <= set; i++) {
if (descriptor_set_layouts[i] != other_ds_layouts[i]) {
if (!descriptor_set_layouts[i] || !other_ds_layouts[i]) {
ss << "Set layout " << i << " contains a null set which is considered non-compatible\n";
break;
}
return descriptor_set_layouts[i]->DescribeDifference(i, *other_ds_layouts[i]);
}
}
}
return ss.str();
}
static PipelineLayoutCompatId GetCanonicalId(const uint32_t set_index, const PushConstantRangesId &pcr_id,
const PipelineLayoutSetLayoutsId &set_layouts_id, bool is_independent_sets) {
return pipeline_layout_compat_dict.LookUp(PipelineLayoutCompatDef(set_index, pcr_id, set_layouts_id, is_independent_sets));
}
// For repeatable sorting, not very useful for "memory in range" search
struct PushConstantRangeCompare {
bool operator()(const VkPushConstantRange *lhs, const VkPushConstantRange *rhs) const {
if (lhs->offset == rhs->offset) {
if (lhs->size == rhs->size) {
// The comparison is arbitrary, but avoids false aliasing by comparing all fields.
return lhs->stageFlags < rhs->stageFlags;
}
// If the offsets are the same then sorting by the end of range is useful for validation
return lhs->size < rhs->size;
}
return lhs->offset < rhs->offset;
}
};
PushConstantRangesId GetCanonicalId(uint32_t pushConstantRangeCount, const VkPushConstantRange *pPushConstantRanges) {
if (!pPushConstantRanges) {
// Hand back the empty entry (creating as needed)...
return push_constant_ranges_dict.LookUp(PushConstantRanges());
}
// Sort the input ranges to ensure equivalent ranges map to the same id
std::set<const VkPushConstantRange *, PushConstantRangeCompare> sorted;
for (uint32_t i = 0; i < pushConstantRangeCount; i++) {
sorted.insert(pPushConstantRanges + i);
}
PushConstantRanges ranges;
ranges.reserve(sorted.size());
for (const auto *range : sorted) {
ranges.emplace_back(*range);
}
return push_constant_ranges_dict.LookUp(std::move(ranges));
}
static PushConstantRangesId GetPushConstantRangesFromLayouts(const vvl::span<const vvl::PipelineLayout *const> &layouts) {
PushConstantRangesId ret{};
for (const auto *layout : layouts) {
if (layout && layout->push_constant_ranges_layout) {
ret = layout->push_constant_ranges_layout;
if (ret->size() > 0) {
return ret;
}
}
}
return ret;
}
std::vector<PipelineLayoutCompatId> GetCompatForSet(const std::vector<std::shared_ptr<vvl::DescriptorSetLayout const>> &set_layouts,
const PushConstantRangesId &push_constant_ranges,
VkPipelineLayoutCreateFlags pipeline_layout_create_flags) {
PipelineLayoutSetLayoutsDef set_layout_ids(set_layouts.size());
for (size_t i = 0; i < set_layouts.size(); i++) {
if (set_layouts[i]) {
set_layout_ids[i] = set_layouts[i]->GetLayoutId();
}
}
auto set_layouts_id = pipeline_layout_set_layouts_dict.LookUp(set_layout_ids);
std::vector<PipelineLayoutCompatId> set_compat_ids;
set_compat_ids.reserve(set_layouts.size());
// Only current flag to effect pipeline layout compatibility
bool is_independent_sets = (pipeline_layout_create_flags & VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT) != 0;
for (uint32_t i = 0; i < set_layouts.size(); i++) {
set_compat_ids.emplace_back(GetCanonicalId(i, push_constant_ranges, set_layouts_id, is_independent_sets));
}
return set_compat_ids;
}
// This is called when merging the flags from the pipeline layouts in libraries
VkPipelineLayoutCreateFlags GetCreateFlags(const vvl::span<const vvl::PipelineLayout *const> &layouts) {
// from https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/9870 and
// https://gitlab.khronos.org/vulkan/vulkan/-/issues/4264
// We do not actually combine the flags, instead we only take the flags from the final linked pipeline layout
return layouts[0] ? layouts[0]->CreateFlags() : 0;
}
namespace vvl {
static PipelineLayout::SetLayoutVector GetSetLayouts(DeviceState &dev_data, const VkPipelineLayoutCreateInfo *pCreateInfo) {
PipelineLayout::SetLayoutVector set_layouts(pCreateInfo->setLayoutCount);
for (uint32_t i = 0; i < pCreateInfo->setLayoutCount; ++i) {
set_layouts[i] = dev_data.Get<vvl::DescriptorSetLayout>(pCreateInfo->pSetLayouts[i]);
}
return set_layouts;
}
static PipelineLayout::SetLayoutVector GetSetLayouts(const vvl::span<const PipelineLayout *const> &layouts) {
PipelineLayout::SetLayoutVector set_layouts;
size_t num_layouts = 0;
for (const auto &layout : layouts) {
if (layout && (layout->set_layouts.size() > num_layouts)) {
num_layouts = layout->set_layouts.size();
}
}
if (!num_layouts) {
return {};
}
set_layouts.reserve(num_layouts);
for (size_t i = 0; i < num_layouts; ++i) {
const PipelineLayout *used_layout = nullptr;
for (const auto *layout : layouts) {
if (layout) {
if (layout->set_layouts.size() > i) {
// This _could_ be the layout we're looking for
used_layout = layout;
if (layout->set_layouts[i]) {
// This is the layout we're looking for. Any subsequent ones that match must be identical to this one.
break;
}
}
}
}
if (used_layout) {
set_layouts.emplace_back(used_layout->set_layouts[i]);
}
}
return set_layouts;
}
static bool HasImmutableSamplers(const PipelineLayout::SetLayoutVector &set_layouts) {
for (const auto &set_layout : set_layouts) {
if (set_layout && set_layout->HasImmutableSamplers()) {
return true;
}
}
return false;
}
PipelineLayout::PipelineLayout(DeviceState &dev_data, VkPipelineLayout handle, const VkPipelineLayoutCreateInfo *pCreateInfo)
: StateObject(handle, kVulkanObjectTypePipelineLayout),
set_layouts(GetSetLayouts(dev_data, pCreateInfo)),
push_constant_ranges_layout(GetCanonicalId(pCreateInfo->pushConstantRangeCount, pCreateInfo->pPushConstantRanges)),
create_flags(pCreateInfo->flags),
set_compat_ids(GetCompatForSet(set_layouts, push_constant_ranges_layout, create_flags)),
has_immutable_samplers(HasImmutableSamplers(set_layouts)) {}
PipelineLayout::PipelineLayout(const vvl::span<const PipelineLayout *const> &layouts)
: StateObject(static_cast<VkPipelineLayout>(VK_NULL_HANDLE), kVulkanObjectTypePipelineLayout),
set_layouts(GetSetLayouts(layouts)),
push_constant_ranges_layout(GetPushConstantRangesFromLayouts(layouts)), // TODO is this correct?
create_flags(GetCreateFlags(layouts)),
set_compat_ids(GetCompatForSet(set_layouts, push_constant_ranges_layout, create_flags)),
has_immutable_samplers(HasImmutableSamplers(set_layouts)) {}
const VkDescriptorSetLayoutBinding *PipelineLayout::FindBinding(const spirv::ResourceInterfaceVariable &variable) const {
const VkDescriptorSetLayoutBinding *binding = nullptr;
const uint32_t set = variable.decorations.set;
if (set < set_layouts.size()) {
const std::shared_ptr<vvl::DescriptorSetLayout const> set_layout = set_layouts[set];
if (set_layout) {
binding = set_layout->GetDescriptorSetLayoutBindingPtrFromBinding(variable.decorations.binding);
}
}
return binding;
}
} // namespace vvl
|