1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565
|
/* Copyright (c) 2015-2025 The Khronos Group Inc.
* Copyright (c) 2015-2025 Valve Corporation
* Copyright (c) 2015-2025 LunarG, Inc.
* Copyright (C) 2015-2024 Google Inc.
* Modifications Copyright (C) 2020 Advanced Micro Devices, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "state_tracker/semaphore_state.h"
#include "state_tracker/queue_state.h"
#include "state_tracker/state_tracker.h"
static bool CanSignalBinarySemaphoreAfterOperation(vvl::Semaphore::OpType op_type) {
return op_type == vvl::Semaphore::kNone || op_type == vvl::Semaphore::kWait;
}
static bool CanWaitBinarySemaphoreAfterOperation(vvl::Semaphore::OpType op_type) {
return op_type == vvl::Semaphore::kSignal || op_type == vvl::Semaphore::kBinaryAcquire;
}
static VkExternalSemaphoreHandleTypeFlags GetExportHandleTypes(const VkSemaphoreCreateInfo *pCreateInfo) {
auto export_info = vku::FindStructInPNextChain<VkExportSemaphoreCreateInfo>(pCreateInfo->pNext);
return export_info ? export_info->handleTypes : 0;
}
void vvl::Semaphore::TimePoint::Notify() const {
assert(signal_submit.has_value() && signal_submit->queue);
signal_submit->queue->Notify(signal_submit->seq);
}
vvl::Semaphore::Semaphore(DeviceState &dev, VkSemaphore handle, const VkSemaphoreTypeCreateInfo *type_create_info,
const VkSemaphoreCreateInfo *pCreateInfo)
: RefcountedStateObject(handle, kVulkanObjectTypeSemaphore),
type(type_create_info ? type_create_info->semaphoreType : VK_SEMAPHORE_TYPE_BINARY),
flags(pCreateInfo->flags),
export_handle_types(GetExportHandleTypes(pCreateInfo)),
initial_value(type == VK_SEMAPHORE_TYPE_TIMELINE ? type_create_info->initialValue : 0),
#ifdef VK_USE_PLATFORM_METAL_EXT
metal_semaphore_export(GetMetalExport(pCreateInfo)),
#endif // VK_USE_PLATFORM_METAL_EXT
completed_{type == VK_SEMAPHORE_TYPE_TIMELINE ? kSignal : kNone, SubmissionReference{},
type_create_info ? type_create_info->initialValue : 0},
next_payload_(completed_.payload + 1),
dev_data_(dev) {
}
const VulkanTypedHandle *vvl::Semaphore::InUse() const {
auto guard = ReadLock();
// Semaphore does not have a parent (in the sense of a VVL state object), and the value returned
// by the base class InUse is not useful for reporting (it is the semaphore's own handle)
const bool in_use = RefcountedStateObject::InUse() != nullptr;
if (!in_use) {
return nullptr;
}
// Scan timeline to find the first queue that uses the semaphore
for (const auto &[_, timepoint] : timeline_) {
if (timepoint.signal_submit.has_value() && timepoint.signal_submit->queue) {
return &timepoint.signal_submit->queue->Handle();
} else {
for (const SubmissionReference &wait_submit : timepoint.wait_submits) {
if (wait_submit.queue) {
return &wait_submit.queue->Handle();
}
}
}
}
// NOTE: In current implementation timepoints represent pending state. In-use tracking
// can retire timepoint even if submission is still pending, so timeline_ state it's
// always pending state but empty timeline does not mean there is no pending state.
// We don't make stronger guarantees because it's enough for in-use tracking.
// You can use NegativeSyncObject.TimelineSubmitSignalAndInUseTracking to check for
// a scenario when there is pending submission and timeline is empty.
//
// This should be taken into account when semaphore is used by functionality other than
// in-use tracking. In the following code we check completed_ state in case pending queue
// cannot be derived from timeline_. It's a bit unconventional. Maybe we need better
// separation between in-use tracking on other type of functionality. Or maybe it's about
// better definitions.
if (completed_.submit.queue) {
return &completed_.submit.queue->Handle();
}
assert(false && "Can't find queue that uses the semaphore");
static const VulkanTypedHandle empty{};
return ∅
}
enum vvl::Semaphore::Scope vvl::Semaphore::Scope() const {
auto guard = ReadLock();
return scope_;
}
void vvl::Semaphore::EnqueueSignal(const SubmissionReference &signal_submit, uint64_t &payload) {
auto guard = WriteLock();
if (type == VK_SEMAPHORE_TYPE_BINARY) {
payload = next_payload_++;
}
// Check there is no existing signal, validation should enforce this
assert(timeline_.find(payload) == timeline_.end() || !timeline_.find(payload)->second.signal_submit.has_value());
timeline_[payload].signal_submit.emplace(signal_submit);
}
void vvl::Semaphore::EnqueueWait(const SubmissionReference &wait_submit, uint64_t &payload) {
auto guard = WriteLock();
if (type == VK_SEMAPHORE_TYPE_BINARY) {
if (timeline_.empty()) {
if (scope_ != vvl::Semaphore::kInternal) {
// for external semaphore mark wait as completed, no guarantee of signal visibility
completed_ = SemOp(kWait, wait_submit, 0);
return;
} else {
// generate binary payload value from the last completed signals
assert(completed_.op_type == kSignal);
payload = completed_.payload;
}
} else {
// generate binary payload value from the most recent pending binary signal
assert(timeline_.rbegin()->second.HasSignaler());
payload = timeline_.rbegin()->first;
}
}
if (payload <= completed_.payload) {
// Signal is already retired and its timepoint removed. Mark wait as completed.
// NOTE: wait's submission can still be pending, but timepoint lifetime logic
// is determined by the signal. completed_ is updated when signal is retired.
// The matching waits should be resolved against completed_ in this case.
assert(!vvl::Contains(timeline_, payload));
completed_.op_type = kWait;
completed_.submit = wait_submit;
return;
}
timeline_[payload].wait_submits.emplace_back(wait_submit);
}
void vvl::Semaphore::EnqueueAcquire(vvl::Func acquire_command) {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
auto guard = WriteLock();
auto payload = next_payload_++;
assert(timeline_.find(payload) == timeline_.end());
timeline_[payload].acquire_command.emplace(acquire_command);
}
std::optional<vvl::Semaphore::SemOp> vvl::Semaphore::LastOp(const std::function<bool(OpType, uint64_t, bool)> &filter) const {
auto guard = ReadLock();
std::optional<SemOp> result;
for (auto pos = timeline_.rbegin(); pos != timeline_.rend(); ++pos) {
uint64_t payload = pos->first;
auto &timepoint = pos->second;
for (auto &op : timepoint.wait_submits) {
if (!filter || filter(kWait, payload, true)) {
result.emplace(SemOp(kWait, op, payload));
break;
}
}
if (!result && timepoint.signal_submit) {
// vkSemaphoreSignal can't be a pending operation, it signals immediately
const bool pending = timepoint.signal_submit->queue != nullptr;
if (!filter || filter(kSignal, payload, pending)) {
result.emplace(SemOp(kSignal, *timepoint.signal_submit, payload));
break;
}
}
if (!result && timepoint.acquire_command && (!filter || filter(kBinaryAcquire, payload, true))) {
result.emplace(SemOp(*timepoint.acquire_command, payload));
break;
}
}
if (!result && (!filter || filter(completed_.op_type, completed_.payload, false))) {
result.emplace(completed_);
}
return result;
}
std::optional<vvl::SubmissionReference> vvl::Semaphore::GetPendingBinaryWaitSubmission() const {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
auto guard = ReadLock();
if (timeline_.empty()) {
return {};
}
const auto &timepoint = timeline_.rbegin()->second;
assert(timepoint.wait_submits.empty() || timepoint.wait_submits.size() == 1);
// No waits
if (timepoint.wait_submits.empty()) {
return {};
}
// Skip waits that are not associated with a queue
if (timepoint.wait_submits[0].queue == nullptr) {
return {};
}
return timepoint.wait_submits[0];
}
std::optional<vvl::SemaphoreInfo> vvl::Semaphore::GetPendingBinarySignalTimelineDependency() const {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
auto guard = ReadLock();
if (timeline_.empty()) {
return {};
}
const TimePoint &timepoint = timeline_.rbegin()->second;
assert(timepoint.HasSignaler());
const auto &signal_submit = timepoint.signal_submit;
// A signal not associated with a queue cannot be blocked by timeline wait
// (host signal or image acquire signal)
if (!signal_submit.has_value() || signal_submit->queue == nullptr) {
return {};
}
return signal_submit->queue->FindTimelineWaitWithoutResolvingSignal(signal_submit->seq);
}
uint64_t vvl::Semaphore::CurrentPayload() const {
auto guard = ReadLock();
return completed_.payload;
}
bool vvl::Semaphore::CanBinaryBeSignaled() const {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
auto guard = ReadLock();
if (timeline_.empty()) {
return CanSignalBinarySemaphoreAfterOperation(completed_.op_type);
}
// Every timeline slot of binary semaphore should contain at least a signal.
// Wait before signal is not allowed.
assert(timeline_.rbegin()->second.HasSignaler());
return timeline_.rbegin()->second.HasWaiters();
}
bool vvl::Semaphore::CanBinaryBeWaited() const {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
auto guard = ReadLock();
if (timeline_.empty()) {
return CanWaitBinarySemaphoreAfterOperation(completed_.op_type);
}
const TimePoint &timepoint = timeline_.rbegin()->second;
assert(scope_ == vvl::Semaphore::kInternal); // Ensured by all calling sites
// Every timeline slot of binary semaphore should contain at least a signal.
// Wait before signal is not allowed.
assert(timepoint.HasSignaler());
// Can wait if there are no waiters
return !timepoint.HasWaiters();
}
void vvl::Semaphore::GetLastBinarySignalSource(VkQueue &queue, vvl::Func &acquire_command) const {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
queue = VK_NULL_HANDLE;
acquire_command = vvl::Func::Empty;
auto guard = ReadLock();
if (timeline_.empty()) {
if (completed_.op_type == kSignal && completed_.submit.queue) {
queue = completed_.submit.queue->VkHandle();
} else if (completed_.op_type == kBinaryAcquire) {
acquire_command = *completed_.acquire_command;
}
} else {
const TimePoint &timepoint = timeline_.rbegin()->second;
if (timepoint.signal_submit.has_value() && timepoint.signal_submit->queue) {
queue = timepoint.signal_submit->queue->VkHandle();
} else if (timepoint.acquire_command.has_value()) {
acquire_command = *timepoint.acquire_command;
}
}
}
bool vvl::Semaphore::HasResolvingTimelineSignal(uint64_t wait_payload) const {
assert(type == VK_SEMAPHORE_TYPE_TIMELINE);
auto guard = ReadLock();
// For external semaphore we can't track the signal.
// In theory, it can be context-dependent whether to assume the external signal is
// available or not in order to have false positive free validation. Assert that
// this function is only called for regular semaphores and it is up to the caller
// to handle external case.
assert(scope_ == vvl::Semaphore::kInternal);
// Check if completed payload value (which includes initial value) resolves the wait.
if (wait_payload <= completed_.payload) {
return true;
}
auto it = timeline_.find(wait_payload);
assert(it != timeline_.end()); // for each registered wait there is a timepoint
while (it != timeline_.end()) {
if (it->second.signal_submit.has_value()) {
assert(it->first >= wait_payload); // timepoints are ordered in increasing order
return true;
}
++it;
}
return false;
}
bool vvl::Semaphore::CanRetireBinaryWait(TimePoint &timepoint) const {
assert(type == VK_SEMAPHORE_TYPE_BINARY);
// The only allowed configuration when binary semaphore wait does not have a signal
// is external semaphore. Just retire the wait because there is no guarantee we can
// track the signal.
if (!timepoint.signal_submit.has_value()) {
assert(scope_ != kInternal);
return true;
}
// The resolving signal can only be on another queue (the earlier signals on the
// current queue are already processed and corresponding timepoints are retired).
// Initiate forward progress on signaling queue and ask the caller to wait.
timepoint.Notify();
return false;
}
bool vvl::Semaphore::CanRetireTimelineWait(const vvl::Queue *current_queue, uint64_t payload) const {
assert(type == VK_SEMAPHORE_TYPE_TIMELINE);
// In the correct program the resolving signal is the next signal on the timeline,
// otherwise this violates the rule of strictly increasing signal values.
auto it = timeline_.find(payload);
assert(it != timeline_.end());
for (; it != timeline_.end(); ++it) {
const TimePoint &t = it->second;
if (!t.signal_submit.has_value()) {
continue;
}
// If the next signal is on the waiting (current) queue, it can't be a resolving signal (blocked by wait).
// QueueSubmissionValidator will also report an error about non-increasing signal values
if (t.signal_submit->queue != nullptr && t.signal_submit->queue == current_queue) {
continue;
}
// Found the resolving signal
break;
}
// There is always a resolving signal when we reach a retirement phase (CPU successfully finished waiting on GPU).
// For external semaphore we might not have visibility of this signal. Just retire the wait.
if (it == timeline_.end()) {
assert(scope_ != kInternal);
return true;
}
// Found host signal that finishes this wait
const TimePoint &t = it->second;
if (t.signal_submit->queue == nullptr) {
return true;
}
// Notify signaling queue and wait for its queue thread
t.Notify();
return false;
}
void vvl::Semaphore::RetireWait(vvl::Queue *current_queue, uint64_t payload, const Location &loc, bool queue_thread) {
std::shared_future<void> waiter;
bool retire_external_payload = false;
uint64_t external_payload = 0;
{
auto guard = WriteLock();
if (payload <= completed_.payload) {
return;
}
if (scope_ != kInternal) {
if (!vvl::Find(timeline_, payload)) {
// GetSemaphoreCounterValue for external semaphore might not have a registered timepoint.
// Add timepoint so we can retire timeline up to that point.
assert(type == VK_SEMAPHORE_TYPE_TIMELINE);
auto payload_it = timeline_.insert({payload, TimePoint{}}).first;
// Search existing signal. If found, notify corresponding submission.
// (external payload, which is already reached by the gpu, is larger then found signal,
// this means that earlier signals were also processed, so we can retire them)
for (auto it = std::make_reverse_iterator(payload_it); it != timeline_.rend(); ++it) {
const TimePoint &t = it->second;
if (t.signal_submit.has_value() && t.signal_submit->queue) {
retire_external_payload = true;
external_payload = payload;
// Update payload value to retire existing signal.
// External payload will be retired after that to update current payload value.
payload = it->first;
break;
}
}
}
if (scope_ == kExternalTemporary) {
scope_ = kInternal;
imported_handle_type_.reset();
}
}
TimePoint &timepoint = vvl::FindExisting(timeline_, payload);
bool retire = false;
if (timepoint.acquire_command) {
retire = true; // There is resolving acquire signal, timepoint can be retired
} else if (type == VK_SEMAPHORE_TYPE_BINARY) {
retire = CanRetireBinaryWait(timepoint);
} else {
retire = CanRetireTimelineWait(current_queue, payload);
}
if (retire) {
// SemOp::submit is used only by the binary semaphores.
// Binary semaphores can have at most one wait per timepoint.
const auto submit_ref = (type == VK_SEMAPHORE_TYPE_BINARY) ? timepoint.wait_submits[0] : SubmissionReference{};
RetireTimePoint(payload, kWait, submit_ref);
return;
}
// Wait for some other queue or a host operation to retire
assert(timepoint.waiter.valid());
// the current timepoint should get destroyed while we're waiting, so copy out the waiter.
waiter = timepoint.waiter;
}
WaitTimePoint(std::move(waiter), payload, !queue_thread, loc);
if (retire_external_payload) {
auto guard = WriteLock();
RetireTimePoint(external_payload, kWait, SubmissionReference{});
}
}
void vvl::Semaphore::RetireSignal(uint64_t payload) {
auto guard = WriteLock();
if (payload <= completed_.payload) {
return;
}
TimePoint &timepoint = vvl::FindExisting(timeline_, payload);
assert(timepoint.signal_submit.has_value());
OpType completed_op = kSignal;
SubmissionReference completed_submit = *timepoint.signal_submit;
// If there is a wait operation then mark it as the last completed instead.
// The reason to do this here instead on the waiter side (after it is unblocked)
// is because signal can have larger (timeline) value than corresponding wait value.
// In this case it's the signal that defines the last completed value.
if (!timepoint.wait_submits.empty()) {
completed_op = kWait;
// SemOp::submit is used only for binary semaphores which can have only single wait
completed_submit = timepoint.wait_submits[0];
}
RetireTimePoint(payload, completed_op, completed_submit);
}
void vvl::Semaphore::RetireTimePoint(uint64_t payload, OpType completed_op, SubmissionReference completed_submit) {
auto it = timeline_.begin();
while (it != timeline_.end() && it->first <= payload) {
assert(it->first > completed_.payload);
it->second.completed.set_value();
++it;
}
timeline_.erase(timeline_.begin(), it);
completed_ = SemOp(completed_op, completed_submit, payload);
}
void vvl::Semaphore::WaitTimePoint(std::shared_future<void> &&waiter, uint64_t payload, bool unblock_validation_object,
const Location &loc) {
if (unblock_validation_object) {
dev_data_.BeginBlockingOperation();
}
auto result = waiter.wait_until(GetCondWaitTimeout());
if (unblock_validation_object) {
dev_data_.EndBlockingOperation();
}
if (result != std::future_status::ready) {
dev_data_.LogError(
"INTERNAL-ERROR-VkSemaphore-state-timeout", Handle(), loc,
"The Validation Layers hit a timeout waiting for timeline semaphore state to update. completed_.payload=%" PRIu64
" wait_payload=%" PRIu64,
completed_.payload, payload);
}
}
void vvl::Semaphore::SetSwapchainWaitInfo(const SwapchainWaitInfo &info) {
auto guard = WriteLock();
swapchain_wait_info_.emplace(info);
}
void vvl::Semaphore::ClearSwapchainWaitInfo() {
auto guard = WriteLock();
swapchain_wait_info_.reset();
}
std::optional<vvl::Semaphore::SwapchainWaitInfo> vvl::Semaphore::GetSwapchainWaitInfo() const {
auto guard = ReadLock();
// Return by value due to locking (not safe to access reference when unlocked)
return swapchain_wait_info_;
}
void vvl::Semaphore::Import(VkExternalSemaphoreHandleTypeFlagBits handle_type, VkSemaphoreImportFlags flags) {
auto guard = WriteLock();
if (scope_ != kExternalPermanent) {
if ((handle_type == VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT || flags & VK_SEMAPHORE_IMPORT_TEMPORARY_BIT) &&
scope_ == kInternal) {
scope_ = kExternalTemporary;
} else {
scope_ = kExternalPermanent;
}
}
imported_handle_type_ = handle_type;
}
void vvl::Semaphore::Export(VkExternalSemaphoreHandleTypeFlagBits handle_type) {
if (handle_type != VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT) {
// Cannot track semaphore state once it is exported, except for Sync FD handle types which have copy transference
auto guard = WriteLock();
scope_ = kExternalPermanent;
} else {
assert(type == VK_SEMAPHORE_TYPE_BINARY); // checked by validation phase
// Exporting a semaphore payload to a handle with copy transference has the same side effects on the source semaphore's
// payload as executing a semaphore wait operation
auto filter = [](const Semaphore::OpType op_type, uint64_t payload, bool is_pending) {
return is_pending && CanWaitBinarySemaphoreAfterOperation(op_type);
};
auto last_op = LastOp(filter);
if (last_op) {
EnqueueWait(last_op->submit, last_op->payload);
}
}
}
std::optional<VkExternalSemaphoreHandleTypeFlagBits> vvl::Semaphore::ImportedHandleType() const {
auto guard = ReadLock();
// Sanity check: semaphore imported -> scope is not internal
assert(!imported_handle_type_.has_value() || scope_ != kInternal);
return imported_handle_type_;
}
#ifdef VK_USE_PLATFORM_METAL_EXT
bool vvl::Semaphore::GetMetalExport(const VkSemaphoreCreateInfo *info) {
bool retval = false;
auto export_metal_object_info = vku::FindStructInPNextChain<VkExportMetalObjectCreateInfoEXT>(info->pNext);
while (export_metal_object_info) {
if (export_metal_object_info->exportObjectType == VK_EXPORT_METAL_OBJECT_TYPE_METAL_SHARED_EVENT_BIT_EXT) {
retval = true;
break;
}
export_metal_object_info = vku::FindStructInPNextChain<VkExportMetalObjectCreateInfoEXT>(export_metal_object_info->pNext);
}
return retval;
}
#endif // VK_USE_PLATFORM_METAL_EXT
|