1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620
|
/*
* Copyright (c) 2019-2025 Valve Corporation
* Copyright (c) 2019-2025 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <vulkan/utility/vk_format_utils.h>
#include "state_tracker/buffer_state.h"
#include "state_tracker/video_session_state.h"
#include "state_tracker/render_pass_state.h"
#include "sync/sync_access_context.h"
#include "sync/sync_image.h"
bool SimpleBinding(const vvl::Bindable &bindable) { return !bindable.sparse && bindable.Binding(); }
VkDeviceSize ResourceBaseAddress(const vvl::Buffer &buffer) { return buffer.GetFakeBaseAddress(); }
class HazardDetector {
const SyncAccessInfo &access_info_;
public:
HazardResult Detect(const ResourceAccessRangeMap::const_iterator &pos) const { return pos->second.DetectHazard(access_info_); }
HazardResult DetectAsync(const ResourceAccessRangeMap::const_iterator &pos, ResourceUsageTag start_tag,
QueueId queue_id) const {
return pos->second.DetectAsyncHazard(access_info_, start_tag, queue_id);
}
explicit HazardDetector(SyncAccessIndex access_index) : access_info_(GetAccessInfo(access_index)) {}
};
class HazardDetectorWithOrdering {
const SyncAccessInfo &access_info_;
const SyncOrdering ordering_rule_;
const SyncFlags flags_;
public:
HazardResult Detect(const ResourceAccessRangeMap::const_iterator &pos) const {
const OrderingBarrier &ordering = ResourceAccessState::GetOrderingRules(ordering_rule_);
return pos->second.DetectHazard(access_info_, ordering, flags_, kQueueIdInvalid);
}
HazardResult DetectAsync(const ResourceAccessRangeMap::const_iterator &pos, ResourceUsageTag start_tag,
QueueId queue_id) const {
return pos->second.DetectAsyncHazard(access_info_, start_tag, queue_id);
}
HazardDetectorWithOrdering(SyncAccessIndex access_index, SyncOrdering ordering, SyncFlags flags = 0)
: access_info_(GetAccessInfo(access_index)), ordering_rule_(ordering), flags_(flags) {}
};
class HazardDetectFirstUse {
public:
HazardDetectFirstUse(const ResourceAccessState &recorded_use, QueueId queue_id, const ResourceUsageRange &tag_range)
: recorded_use_(recorded_use), queue_id_(queue_id), tag_range_(tag_range) {}
HazardResult Detect(const ResourceAccessRangeMap::const_iterator &pos) const {
return pos->second.DetectHazard(recorded_use_, queue_id_, tag_range_);
}
HazardResult DetectAsync(const ResourceAccessRangeMap::const_iterator &pos, ResourceUsageTag start_tag,
QueueId queue_id) const {
return pos->second.DetectAsyncHazard(recorded_use_, tag_range_, start_tag, queue_id);
}
private:
const ResourceAccessState &recorded_use_;
const QueueId queue_id_;
const ResourceUsageRange &tag_range_;
};
AccessContext::AccessContext(uint32_t subpass, VkQueueFlags queue_flags,
const std::vector<SubpassDependencyGraphNode> &dependencies,
const std::vector<AccessContext> &contexts, const AccessContext *external_context) {
Reset();
const auto &subpass_dep = dependencies[subpass];
const bool has_barrier_from_external = subpass_dep.barrier_from_external.size() > 0U;
prev_.reserve(subpass_dep.prev.size() + (has_barrier_from_external ? 1U : 0U));
prev_by_subpass_.resize(subpass, nullptr); // Can't be more prevs than the subpass we're on
for (const auto &prev_dep : subpass_dep.prev) {
const auto prev_pass = prev_dep.first->pass;
const auto &prev_barriers = prev_dep.second;
assert(prev_dep.second.size());
prev_.emplace_back(&contexts[prev_pass], queue_flags, prev_barriers);
prev_by_subpass_[prev_pass] = &prev_.back();
}
async_.reserve(subpass_dep.async.size());
for (const auto async_subpass : subpass_dep.async) {
// Start tags are not known at creation time (as it's done at BeginRenderpass)
async_.emplace_back(contexts[async_subpass], kInvalidTag, kQueueIdInvalid);
}
if (has_barrier_from_external) {
// Store the barrier from external with the reat, but save pointer for "by subpass" lookups.
prev_.emplace_back(external_context, queue_flags, subpass_dep.barrier_from_external);
src_external_ = &prev_.back();
}
if (subpass_dep.barrier_to_external.size()) {
dst_external_ = TrackBack(this, queue_flags, subpass_dep.barrier_to_external);
}
}
template <typename NormalizeOp>
void AccessContext::Trim(NormalizeOp &&normalize) {
ForAll(std::forward<NormalizeOp>(normalize));
sparse_container::consolidate(access_state_map_);
}
void AccessContext::Trim() {
auto normalize = [](ResourceAccessRangeMap::value_type &access) { access.second.Normalize(); };
Trim(normalize);
}
void AccessContext::TrimAndClearFirstAccess() {
auto normalize = [](ResourceAccessRangeMap::value_type &access) {
access.second.Normalize();
access.second.ClearFirstUse();
};
Trim(normalize);
}
void AccessContext::AddReferencedTags(ResourceUsageTagSet &used) const {
auto gather = [&used](const ResourceAccessRangeMap::value_type &access) { access.second.GatherReferencedTags(used); };
ConstForAll(gather);
}
template <typename Action>
void AccessContext::ForAll(Action &&action) {
for (auto &access : access_state_map_) {
action(access);
}
}
template <typename Action>
void AccessContext::ConstForAll(Action &&action) const {
for (auto &access : access_state_map_) {
action(access);
}
}
void AccessContext::ResolveFromContext(const AccessContext &from) {
const NoopBarrierAction noop_barrier;
from.ResolveAccessRange(kFullRange, noop_barrier, &access_state_map_, nullptr);
}
void AccessContext::ResolvePreviousAccess(const ResourceAccessRange &range, ResourceAccessRangeMap *descent_map,
const ResourceAccessState *infill_state,
const ResourceAccessStateFunction *previous_barrier) const {
if (prev_.empty()) {
if (range.non_empty() && infill_state) {
// Fill the empty poritions of descent_map with the default_state with the barrier function applied (iff present)
ResourceAccessState state_copy;
if (previous_barrier) {
assert(bool(*previous_barrier));
state_copy = *infill_state;
(*previous_barrier)(&state_copy);
infill_state = &state_copy;
}
sparse_container::update_range_value(*descent_map, range, *infill_state,
sparse_container::value_precedence::prefer_dest);
}
} else {
// Look for something to fill the gap further along.
for (const auto &prev_dep : prev_) {
const ApplyTrackbackStackAction barrier_action(prev_dep.barriers, previous_barrier);
prev_dep.source_subpass->ResolveAccessRange(range, barrier_action, descent_map, infill_state);
}
}
}
// Non-lazy import of all accesses, WaitEvents needs this.
void AccessContext::ResolvePreviousAccesses() {
ResourceAccessState default_state;
if (!prev_.size()) return; // If no previous contexts, nothing to do
ResolvePreviousAccess(kFullRange, &access_state_map_, &default_state);
}
void AccessContext::UpdateAccessState(const vvl::Buffer &buffer, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
const ResourceAccessRange &range, ResourceUsageTagEx tag_ex) {
if (current_usage == SYNC_ACCESS_INDEX_NONE) {
return;
}
if (!SimpleBinding(buffer)) {
return;
}
const auto base_address = ResourceBaseAddress(buffer);
UpdateMemoryAccessStateFunctor action(*this, current_usage, ordering_rule, tag_ex);
UpdateMemoryAccessRangeState(access_state_map_, action, range + base_address);
}
void AccessContext::UpdateAccessState(const vvl::Image &image, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
const VkImageSubresourceRange &subresource_range, const ResourceUsageTag &tag) {
// range_gen is non-temporary to avoid an additional copy
const auto &sub_state = syncval_state::SubState(image);
ImageRangeGen range_gen = sub_state.MakeImageRangeGen(subresource_range, false);
UpdateAccessState(range_gen, current_usage, ordering_rule, ResourceUsageTagEx{tag});
}
void AccessContext::UpdateAccessState(const vvl::Image &image, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
const VkImageSubresourceRange &subresource_range, const VkOffset3D &offset,
const VkExtent3D &extent, const ResourceUsageTagEx tag_ex) {
// range_gen is non-temporary to avoid an additional copy
const auto &sub_state = syncval_state::SubState(image);
ImageRangeGen range_gen = sub_state.MakeImageRangeGen(subresource_range, offset, extent, false);
UpdateAccessState(range_gen, current_usage, ordering_rule, tag_ex);
}
void AccessContext::UpdateAccessState(const vvl::ImageView &image_view, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
const VkOffset3D &offset, const VkExtent3D &extent, const ResourceUsageTagEx tag_ex) {
// range_gen is non-temporary to avoid an additional copy
ImageRangeGen range_gen(syncval_state::MakeImageRangeGen(image_view, offset, extent));
UpdateAccessState(range_gen, current_usage, ordering_rule, tag_ex);
}
void AccessContext::UpdateAccessState(const vvl::ImageView &image_view, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
ResourceUsageTagEx tag_ex) {
auto range_gen = syncval_state::MakeImageRangeGen(image_view);
UpdateAccessState(range_gen, current_usage, ordering_rule, tag_ex);
}
void AccessContext::UpdateAccessState(const AttachmentViewGen &view_gen, AttachmentViewGen::Gen gen_type,
SyncAccessIndex current_usage, SyncOrdering ordering_rule, const ResourceUsageTag tag,
SyncFlags flags) {
const std::optional<ImageRangeGen> &attachment_gen = view_gen.GetRangeGen(gen_type);
if (attachment_gen) {
// Value of const optional is const, and will be copied in callee
UpdateAccessState(*attachment_gen, current_usage, ordering_rule, ResourceUsageTagEx{tag}, flags);
}
}
void AccessContext::UpdateAccessState(const vvl::VideoSession &vs_state, const vvl::VideoPictureResource &resource,
SyncAccessIndex current_usage, ResourceUsageTag tag) {
const auto image = static_cast<const vvl::Image *>(resource.image_state.get());
const auto offset = resource.GetEffectiveImageOffset(vs_state);
const auto extent = resource.GetEffectiveImageExtent(vs_state);
const auto &sub_state = syncval_state::SubState(*image);
ImageRangeGen range_gen(sub_state.MakeImageRangeGen(resource.range, offset, extent, false));
UpdateAccessState(range_gen, current_usage, SyncOrdering::kNonAttachment, ResourceUsageTagEx{tag});
}
void AccessContext::UpdateAccessState(ImageRangeGen &range_gen, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
ResourceUsageTagEx tag_ex, SyncFlags flags) {
if (current_usage == SYNC_ACCESS_INDEX_NONE) {
return;
}
UpdateMemoryAccessStateFunctor action(*this, current_usage, ordering_rule, tag_ex, flags);
UpdateMemoryAccessState(action, range_gen);
}
void AccessContext::UpdateAccessState(const ImageRangeGen &range_gen, SyncAccessIndex current_usage, SyncOrdering ordering_rule,
ResourceUsageTagEx tag_ex, SyncFlags flags) {
// range_gen is non-temporary to avoid infinite call recursion
ImageRangeGen mutable_range_gen(range_gen);
UpdateAccessState(mutable_range_gen, current_usage, ordering_rule, tag_ex, flags);
}
void AccessContext::ResolveChildContexts(const std::vector<AccessContext> &contexts) {
for (uint32_t subpass_index = 0; subpass_index < contexts.size(); subpass_index++) {
auto &context = contexts[subpass_index];
ApplyTrackbackStackAction barrier_action(context.GetDstExternalTrackBack().barriers);
context.ResolveAccessRange(kFullRange, barrier_action, &access_state_map_, nullptr, false);
}
}
// Caller must ensure that lifespan of this is less than the lifespan of from
void AccessContext::ImportAsyncContexts(const AccessContext &from) {
async_.insert(async_.end(), from.async_.begin(), from.async_.end());
}
// Suitable only for *subpass* access contexts
HazardResult AccessContext::DetectSubpassTransitionHazard(const TrackBack &track_back, const AttachmentViewGen &attach_view) const {
if (!attach_view.IsValid()) return HazardResult();
// We should never ask for a transition from a context we don't have
assert(track_back.source_subpass);
// Do the detection against the specific prior context independent of other contexts. (Synchronous only)
// Hazard detection for the transition can be against the merged of the barriers (it only uses src_...)
const SyncBarrier merged_barrier(track_back.barriers);
HazardResult hazard = track_back.source_subpass->DetectImageBarrierHazard(attach_view, merged_barrier, kDetectPrevious);
if (!hazard.IsHazard()) {
// The Async hazard check is against the current context's async set.
SyncBarrier null_barrier = {};
hazard = DetectImageBarrierHazard(attach_view, null_barrier, kDetectAsync);
}
return hazard;
}
void AccessContext::AddAsyncContext(const AccessContext *context, ResourceUsageTag tag, QueueId queue_id) {
if (context) {
async_.emplace_back(*context, tag, queue_id);
}
}
HazardResult AccessContext::DetectHazard(const vvl::Buffer &buffer, SyncAccessIndex access_index,
const ResourceAccessRange &range) const {
if (!SimpleBinding(buffer)) return HazardResult();
const auto base_address = ResourceBaseAddress(buffer);
HazardDetector detector(access_index);
return DetectHazardRange(detector, (range + base_address), DetectOptions::kDetectAll);
}
template <typename Detector>
HazardResult AccessContext::DetectHazard(Detector &detector, const AttachmentViewGen &view_gen, AttachmentViewGen::Gen gen_type,
DetectOptions options) const {
const std::optional<ImageRangeGen> &attachment_gen = view_gen.GetRangeGen(gen_type);
if (!attachment_gen) return HazardResult();
subresource_adapter::ImageRangeGenerator range_gen(*attachment_gen);
return DetectHazardGeneratedRanges(detector, range_gen, options);
}
template <typename Detector>
HazardResult AccessContext::DetectHazard(Detector &detector, const vvl::Image &image,
const VkImageSubresourceRange &subresource_range, const VkOffset3D &offset,
const VkExtent3D &extent, bool is_depth_sliced, DetectOptions options) const {
// range_gen is non-temporary to avoid additional copy
const auto &sub_state = syncval_state::SubState(image);
ImageRangeGen range_gen = sub_state.MakeImageRangeGen(subresource_range, offset, extent, is_depth_sliced);
return DetectHazardGeneratedRanges(detector, range_gen, options);
}
template <typename Detector>
HazardResult AccessContext::DetectHazard(Detector &detector, const vvl::Image &image,
const VkImageSubresourceRange &subresource_range, bool is_depth_sliced,
DetectOptions options) const {
// range_gen is non-temporary to avoid additional copy
const auto &sub_state = syncval_state::SubState(image);
ImageRangeGen range_gen = sub_state.MakeImageRangeGen(subresource_range, is_depth_sliced);
return DetectHazardGeneratedRanges(detector, range_gen, options);
}
HazardResult AccessContext::DetectHazard(const vvl::Image &image, SyncAccessIndex current_usage,
const VkImageSubresourceRange &subresource_range, bool is_depth_sliced) const {
HazardDetector detector(current_usage);
return DetectHazard(detector, image, subresource_range, is_depth_sliced, DetectOptions::kDetectAll);
}
HazardResult AccessContext::DetectHazard(const vvl::ImageView &image_view, SyncAccessIndex current_usage) const {
// Get is const, but callee will copy
HazardDetector detector(current_usage);
auto range_gen = syncval_state::MakeImageRangeGen(image_view);
return DetectHazardGeneratedRanges(detector, range_gen, DetectOptions::kDetectAll);
}
HazardResult AccessContext::DetectHazard(const ImageRangeGen &ref_range_gen, SyncAccessIndex current_usage,
const SyncOrdering ordering_rule, SyncFlags flags) const {
if (ordering_rule == SyncOrdering::kOrderingNone) {
HazardDetector detector(current_usage);
return DetectHazardGeneratedRanges(detector, ref_range_gen, DetectOptions::kDetectAll);
}
HazardDetectorWithOrdering detector(current_usage, ordering_rule, flags);
return DetectHazardGeneratedRanges(detector, ref_range_gen, DetectOptions::kDetectAll);
}
HazardResult AccessContext::DetectHazard(const vvl::ImageView &image_view, const VkOffset3D &offset, const VkExtent3D &extent,
SyncAccessIndex current_usage, SyncOrdering ordering_rule) const {
// range_gen is non-temporary to avoid an additional copy
ImageRangeGen range_gen(syncval_state::MakeImageRangeGen(image_view, offset, extent));
HazardDetectorWithOrdering detector(current_usage, ordering_rule);
return DetectHazardGeneratedRanges(detector, range_gen, DetectOptions::kDetectAll);
}
HazardResult AccessContext::DetectHazard(const AttachmentViewGen &view_gen, AttachmentViewGen::Gen gen_type,
SyncAccessIndex current_usage, SyncOrdering ordering_rule, SyncFlags flags) const {
HazardDetectorWithOrdering detector(current_usage, ordering_rule, flags);
return DetectHazard(detector, view_gen, gen_type, DetectOptions::kDetectAll);
}
HazardResult AccessContext::DetectHazard(const vvl::VideoSession &vs_state, const vvl::VideoPictureResource &resource,
SyncAccessIndex current_usage) const {
const auto image = static_cast<const vvl::Image *>(resource.image_state.get());
const auto &sub_state = syncval_state::SubState(*image);
const auto offset = resource.GetEffectiveImageOffset(vs_state);
const auto extent = resource.GetEffectiveImageExtent(vs_state);
ImageRangeGen range_gen(sub_state.MakeImageRangeGen(resource.range, offset, extent, false));
HazardDetector detector(current_usage);
return DetectHazardGeneratedRanges(detector, range_gen, DetectOptions::kDetectAll);
}
HazardResult AccessContext::DetectHazard(const vvl::Image &image, const VkImageSubresourceRange &subresource_range,
const VkOffset3D &offset, const VkExtent3D &extent, bool is_depth_sliced,
SyncAccessIndex current_usage, SyncOrdering ordering_rule) const {
if (ordering_rule == SyncOrdering::kOrderingNone) {
HazardDetector detector(current_usage);
return DetectHazard(detector, image, subresource_range, offset, extent, is_depth_sliced, DetectOptions::kDetectAll);
}
HazardDetectorWithOrdering detector(current_usage, ordering_rule);
return DetectHazard(detector, image, subresource_range, offset, extent, is_depth_sliced, DetectOptions::kDetectAll);
}
class BarrierHazardDetector {
public:
BarrierHazardDetector(SyncAccessIndex access_index, VkPipelineStageFlags2 src_exec_scope, SyncAccessFlags src_access_scope)
: access_info_(GetAccessInfo(access_index)),
src_exec_scope_(src_exec_scope),
src_access_scope_(src_access_scope) {}
HazardResult Detect(const ResourceAccessRangeMap::const_iterator &pos) const {
return pos->second.DetectBarrierHazard(access_info_, kQueueIdInvalid, src_exec_scope_, src_access_scope_);
}
HazardResult DetectAsync(const ResourceAccessRangeMap::const_iterator &pos, ResourceUsageTag start_tag,
QueueId queue_id) const {
// Async barrier hazard detection can use the same path as the usage index is not IsRead, but is IsWrite
return pos->second.DetectAsyncHazard(access_info_, start_tag, queue_id);
}
private:
const SyncAccessInfo &access_info_;
VkPipelineStageFlags2 src_exec_scope_;
SyncAccessFlags src_access_scope_;
};
class EventBarrierHazardDetector {
public:
EventBarrierHazardDetector(SyncAccessIndex access_index, VkPipelineStageFlags2 src_exec_scope, SyncAccessFlags src_access_scope,
const AccessContext::ScopeMap &event_scope, QueueId queue_id, ResourceUsageTag scope_tag)
: access_info_(GetAccessInfo(access_index)),
src_exec_scope_(src_exec_scope),
src_access_scope_(src_access_scope),
event_scope_(event_scope),
scope_queue_id_(queue_id),
scope_tag_(scope_tag),
scope_pos_(event_scope.cbegin()),
scope_end_(event_scope.cend()) {}
HazardResult Detect(const ResourceAccessRangeMap::const_iterator &pos) {
// Need to piece together coverage of pos->first range:
// Copy the range as we'll be chopping it up as needed
ResourceAccessRange range = pos->first;
const ResourceAccessState &access = pos->second;
HazardResult hazard;
bool in_scope = AdvanceScope(range);
bool unscoped_tested = false;
while (in_scope && !hazard.IsHazard()) {
if (range.begin < ScopeBegin()) {
if (!unscoped_tested) {
unscoped_tested = true;
hazard = access.DetectHazard(access_info_);
}
// Note: don't need to check for in_scope as AdvanceScope true means range and ScopeRange intersect.
// Thus a [ ScopeBegin, range.end ) will be non-empty.
range.begin = ScopeBegin();
} else { // in_scope implied that ScopeRange and range intersect
hazard = access.DetectBarrierHazard(access_info_, ScopeState(), src_exec_scope_, src_access_scope_, scope_queue_id_,
scope_tag_);
if (!hazard.IsHazard()) {
range.begin = ScopeEnd();
in_scope = AdvanceScope(range); // contains a non_empty check
}
}
}
if (range.non_empty() && !hazard.IsHazard() && !unscoped_tested) {
hazard = access.DetectHazard(access_info_);
}
return hazard;
}
HazardResult DetectAsync(const ResourceAccessRangeMap::const_iterator &pos, ResourceUsageTag start_tag,
QueueId queue_id) const {
// Async barrier hazard detection can use the same path as the usage index is not IsRead, but is IsWrite
return pos->second.DetectAsyncHazard(access_info_, start_tag, queue_id);
}
private:
bool ScopeInvalid() const { return scope_pos_ == scope_end_; }
bool ScopeValid() const { return !ScopeInvalid(); }
void ScopeSeek(const ResourceAccessRange &range) { scope_pos_ = event_scope_.lower_bound(range); }
// Hiding away the std::pair grunge...
ResourceAddress ScopeBegin() const { return scope_pos_->first.begin; }
ResourceAddress ScopeEnd() const { return scope_pos_->first.end; }
const ResourceAccessRange &ScopeRange() const { return scope_pos_->first; }
const ResourceAccessState &ScopeState() const { return scope_pos_->second; }
bool AdvanceScope(const ResourceAccessRange &range) {
// Note: non_empty is (valid && !empty), so don't change !non_empty to empty...
if (!range.non_empty()) return false;
if (ScopeInvalid()) return false;
if (ScopeRange().strictly_less(range)) {
ScopeSeek(range);
}
return ScopeValid() && ScopeRange().intersects(range);
}
const SyncAccessInfo access_info_;
VkPipelineStageFlags2 src_exec_scope_;
SyncAccessFlags src_access_scope_;
const AccessContext::ScopeMap &event_scope_;
QueueId scope_queue_id_;
const ResourceUsageTag scope_tag_;
AccessContext::ScopeMap::const_iterator scope_pos_;
AccessContext::ScopeMap::const_iterator scope_end_;
};
HazardResult AccessContext::DetectImageBarrierHazard(const vvl::Image &image, const VkImageSubresourceRange &subresource_range,
VkPipelineStageFlags2 src_exec_scope, const SyncAccessFlags &src_access_scope,
QueueId queue_id, const ScopeMap &scope_map, const ResourceUsageTag scope_tag,
AccessContext::DetectOptions options) const {
EventBarrierHazardDetector detector(SyncAccessIndex::SYNC_IMAGE_LAYOUT_TRANSITION, src_exec_scope, src_access_scope, scope_map,
queue_id, scope_tag);
return DetectHazard(detector, image, subresource_range, false, options);
}
HazardResult AccessContext::DetectImageBarrierHazard(const AttachmentViewGen &view_gen, const SyncBarrier &barrier,
DetectOptions options) const {
BarrierHazardDetector detector(SyncAccessIndex::SYNC_IMAGE_LAYOUT_TRANSITION, barrier.src_exec_scope.exec_scope,
barrier.src_access_scope);
return DetectHazard(detector, view_gen, AttachmentViewGen::Gen::kViewSubresource, options);
}
HazardResult AccessContext::DetectImageBarrierHazard(const vvl::Image &image, VkPipelineStageFlags2 src_exec_scope,
const SyncAccessFlags &src_access_scope,
const VkImageSubresourceRange &subresource_range,
const DetectOptions options) const {
BarrierHazardDetector detector(SyncAccessIndex::SYNC_IMAGE_LAYOUT_TRANSITION, src_exec_scope, src_access_scope);
return DetectHazard(detector, image, subresource_range, false, options);
}
ResourceAccessRangeMap::iterator AccessContext::UpdateMemoryAccessStateFunctor::Infill(ResourceAccessRangeMap *accesses,
const Iterator &pos,
const ResourceAccessRange &range) const {
// this is only called on gaps, and never returns a gap.
ResourceAccessState default_state;
context.ResolvePreviousAccess(range, accesses, &default_state);
return accesses->lower_bound(range);
}
void AccessContext::UpdateMemoryAccessStateFunctor::operator()(const ResourceAccessRangeMap::iterator &pos) const {
auto &access_state = pos->second;
access_state.Update(usage_info, ordering_rule, tag_ex, flags);
}
// This is called with the *recorded* command buffers access context, with the *active* access context pass in, againsts which
// hazards will be detected
HazardResult AccessContext::DetectFirstUseHazard(QueueId queue_id, const ResourceUsageRange &tag_range,
const AccessContext &access_context) const {
for (const auto &recorded_access : access_state_map_) {
// Cull any entries not in the current tag range
if (!recorded_access.second.FirstAccessInTagRange(tag_range)) continue;
HazardDetectFirstUse detector(recorded_access.second, queue_id, tag_range);
HazardResult hazard = access_context.DetectHazardRange(detector, recorded_access.first, DetectOptions::kDetectAll);
if (hazard.IsHazard()) {
return hazard;
}
}
return {};
}
// For RenderPass time validation this is "start tag", for QueueSubmit, this is the earliest
// unsynchronized tag for the Queue being tested against (max synchrononous + 1, perhaps)
ResourceUsageTag AccessContext::AsyncReference::StartTag() const { return (tag_ == kInvalidTag) ? context_->StartTag() : tag_; }
AttachmentViewGen::AttachmentViewGen(const vvl::ImageView *image_view, const VkOffset3D &offset, const VkExtent3D &extent)
: view_(image_view) {
gen_store_[Gen::kViewSubresource].emplace(syncval_state::MakeImageRangeGen(*image_view));
const bool has_depth = vkuFormatHasDepth(image_view->create_info.format);
const bool has_stencil = vkuFormatHasStencil(image_view->create_info.format);
// For depth-stencil attachment, the view's aspect flags are ignored according to the spec.
// MakeImageRangeGen works with the aspect flags. Derive aspect from format.
VkImageAspectFlags override_aspect_flags = 0;
if (has_depth || has_stencil) {
override_aspect_flags |= has_depth ? VK_IMAGE_ASPECT_DEPTH_BIT : 0;
override_aspect_flags |= has_stencil ? VK_IMAGE_ASPECT_STENCIL_BIT : 0;
}
// Range gen for attachment's render area
gen_store_[Gen::kRenderArea].emplace(syncval_state::MakeImageRangeGen(*image_view, offset, extent, override_aspect_flags));
// If attachment has both depth and stencil aspects then add range gens to represent each aspect separately.
if (has_depth && has_stencil) {
gen_store_[Gen::kDepthOnlyRenderArea].emplace(
syncval_state::MakeImageRangeGen(*image_view, offset, extent, VK_IMAGE_ASPECT_DEPTH_BIT));
gen_store_[Gen::kStencilOnlyRenderArea].emplace(
syncval_state::MakeImageRangeGen(*image_view, offset, extent, VK_IMAGE_ASPECT_STENCIL_BIT));
}
}
const std::optional<ImageRangeGen> &AttachmentViewGen::GetRangeGen(AttachmentViewGen::Gen type) const {
static_assert(Gen::kGenSize == 4, "Function written with this assumption");
// If the view is a depth only view, then the depth only portion of the render area is simply the render area.
// If the view is a depth stencil view, then the depth only portion of the render area will be a subset,
// and thus needs the generator function that will produce the address ranges of that subset
const bool depth_only = (type == kDepthOnlyRenderArea) && vkuFormatIsDepthOnly(view_->create_info.format);
const bool stencil_only = (type == kStencilOnlyRenderArea) && vkuFormatIsStencilOnly(view_->create_info.format);
if (depth_only || stencil_only) {
type = Gen::kRenderArea;
}
return gen_store_[type];
}
AttachmentViewGen::Gen AttachmentViewGen::GetDepthStencilRenderAreaGenType(bool depth_op, bool stencil_op) const {
assert(IsValid());
assert(vkuFormatIsDepthOrStencil(view_->create_info.format));
if (depth_op) {
assert(vkuFormatHasDepth(view_->create_info.format));
if (stencil_op) {
assert(vkuFormatHasStencil(view_->create_info.format));
return kRenderArea;
}
return kDepthOnlyRenderArea;
}
if (stencil_op) {
assert(vkuFormatHasStencil(view_->create_info.format));
return kStencilOnlyRenderArea;
}
assert(depth_op || stencil_op);
return kRenderArea;
}
|