1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332
|
/*
* Copyright (c) 2015-2025 The Khronos Group Inc.
* Copyright (c) 2015-2025 Valve Corporation
* Copyright (c) 2015-2025 LunarG, Inc.
* Copyright (c) 2015-2025 Google, Inc.
* Modifications Copyright (C) 2020-2021 Advanced Micro Devices, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*/
#include "../framework/layer_validation_tests.h"
#include "../framework/android_hardware_buffer.h"
#if defined(VK_USE_PLATFORM_ANDROID_KHR)
class NegativeAndroidHardwareBuffer : public VkLayerTest {};
TEST_F(NegativeAndroidHardwareBuffer, ImageCreate) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer image create info.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
VkImage img = VK_NULL_HANDLE;
VkImageCreateInfo ici = vku::InitStructHelper();
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_UNDEFINED;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
// undefined format
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-01975");
// Various extra errors for having VK_FORMAT_UNDEFINED without VkExternalFormatANDROID
m_errorMonitor->SetUnexpectedError("VUID_Undefined");
m_errorMonitor->SetUnexpectedError("VUID-VkImageCreateInfo-imageCreateMaxMipLevels-02251");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
// also undefined format
VkExternalFormatANDROID efa = vku::InitStructHelper();
efa.externalFormat = 0;
ici.pNext = &efa;
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-01975");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
// undefined format with an unknown external format
efa.externalFormat = 0xBADC0DE;
m_errorMonitor->SetDesiredError("VUID-VkExternalFormatANDROID-externalFormat-01894");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
// Retrieve it's properties to make it's external format 'known' (AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM)
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
// a defined image format with a non-zero external format
ici.format = VK_FORMAT_R8G8B8A8_UNORM;
efa.externalFormat = ahb_fmt_props.externalFormat;
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-01974");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
ici.format = VK_FORMAT_UNDEFINED;
// external format while MUTABLE
ici.flags = VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT;
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-02396");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
ici.flags = 0;
// external format while usage other than SAMPLED
ici.usage |= VK_IMAGE_USAGE_TRANSFER_DST_BIT;
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-02397");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
ici.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-09457");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
// external format while tiline other than OPTIMAL
ici.tiling = VK_IMAGE_TILING_LINEAR;
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-02398");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
// imageType
VkExternalMemoryImageCreateInfo emici = vku::InitStructHelper();
emici.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
ici.pNext = &emici; // remove efa from chain, insert emici
ici.format = VK_FORMAT_R8G8B8A8_UNORM;
ici.imageType = VK_IMAGE_TYPE_3D;
ici.extent = {64, 64, 64};
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-02393");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
// wrong mipLevels
ici.imageType = VK_IMAGE_TYPE_2D;
ici.extent = {64, 64, 1};
ici.mipLevels = 6; // should be 7
m_errorMonitor->SetDesiredError("VUID-VkImageCreateInfo-pNext-02394");
vk::CreateImage(device(), &ici, NULL, &img);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, FetchUnboundImageInfo) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer retreive image properties while memory unbound.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
VkExternalMemoryImageCreateInfo emici = vku::InitStructHelper();
emici.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkImageCreateInfo ici = vku::InitStructHelper(&emici);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_R8G8B8A8_UNORM;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_LINEAR;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
// attempt to fetch layout from unbound image
VkImageSubresource sub_rsrc = {};
sub_rsrc.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
VkSubresourceLayout sub_layout = {};
m_errorMonitor->SetDesiredError("VUID-vkGetImageSubresourceLayout-image-09432");
vk::GetImageSubresourceLayout(device(), image, &sub_rsrc, &sub_layout);
m_errorMonitor->VerifyFound();
// attempt to get memory reqs from unbound image
VkImageMemoryRequirementsInfo2 imri = vku::InitStructHelper();
imri.image = image;
VkMemoryRequirements2 mem_reqs = vku::InitStructHelper();
m_errorMonitor->SetDesiredError("VUID-VkImageMemoryRequirementsInfo2-image-01897");
vk::GetImageMemoryRequirements2(device(), &imri, &mem_reqs);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, GpuDataBuffer) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer missing USAGE_GPU_DATA_BUFFER.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper();
import_ahb_Info.buffer = ahb.handle();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
// Import requires format AHB_FMT_BLOB and usage AHB_USAGE_GPU_DATA_BUFFER
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02384");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, AllocationSize) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer correct allocationSize is used.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_BLOB, AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER, 64);
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper();
import_ahb_Info.buffer = ahb.handle();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
// Allocation size mismatch
{
memory_allocate_info.allocationSize = ahb_props.allocationSize + 1;
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-allocationSize-02383");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
// memoryTypeIndex mismatch
{
memory_allocate_info.allocationSize = ahb_props.allocationSize;
memory_allocate_info.memoryTypeIndex++;
#if defined(VVL_MOCK_ANDROID)
m_errorMonitor->SetUnexpectedError("VUID-vkAllocateMemory-pAllocateInfo-01714"); // incase at last index
#endif
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-memoryTypeIndex-02385");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
}
TEST_F(NegativeAndroidHardwareBuffer, DedicatedUsageColor) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer correct usage for dedicated allocated color image.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, AHARDWAREBUFFER_USAGE_GPU_FRAMEBUFFER, 64, 64);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkExternalFormatANDROID external_format = vku::InitStructHelper();
external_format.externalFormat = ahb_fmt_props.externalFormat;
VkImageCreateInfo ici = vku::InitStructHelper(&external_format);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_UNDEFINED;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02390");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, DedicatedUsageDS) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer correct usage for dedicated allocated depth/stencil image.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_S8_UINT, AHARDWAREBUFFER_USAGE_GPU_FRAMEBUFFER, 64, 64);
if (!ahb.handle()) {
GTEST_SKIP() << "Failed to Allocate AHB";
}
// Incase it hits the below driver bug, catch the false VUID error thrown from driver not creating valid AHB
m_errorMonitor->SetUnexpectedError("VUID-vkGetAndroidHardwareBufferPropertiesANDROID-buffer-01884");
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
if (ahb_fmt_props.format != VK_FORMAT_S8_UINT) {
GTEST_SKIP() << "Driver bug: Didn't turn AHB format into VK_FORMAT_S8_UINT";
}
VkExternalFormatANDROID external_format = vku::InitStructHelper();
external_format.externalFormat = ahb_fmt_props.externalFormat;
VkImageCreateInfo ici = vku::InitStructHelper(&external_format);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_UNDEFINED;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02390");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, MipmapChainComplete) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer correct mipmap chain.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
AHardwareBuffer_Desc ahb_desc = {};
ahb_desc.format = AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM;
ahb_desc.usage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE | AHARDWAREBUFFER_USAGE_GPU_MIPMAP_COMPLETE;
ahb_desc.width = 64;
ahb_desc.height = 64;
ahb_desc.layers = 1;
ahb_desc.stride = 1;
vkt::AHB ahb(&ahb_desc);
if (!ahb.handle()) {
// ERROR: AHardwareBuffer_allocate() with MIPMAP_COMPLETE fails. It returns -12, NO_MEMORY.
// The problem seems to happen in Pixel 2, not Pixel 3.
GTEST_SKIP() << "AHARDWAREBUFFER_USAGE_GPU_MIPMAP_COMPLETE not supported";
}
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkImageCreateInfo ici = vku::InitStructHelper();
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_R8G8B8A8_UNORM;
ici.mipLevels = 2;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02389");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, NoMipmapChain) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer correct mipmap chain.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
AHardwareBuffer_Desc ahb_desc = {};
ahb_desc.format = AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM;
ahb_desc.usage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
ahb_desc.width = 64;
ahb_desc.height = 64;
ahb_desc.layers = 1;
ahb_desc.stride = 1;
vkt::AHB ahb(&ahb_desc);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkImageCreateInfo ici = vku::InitStructHelper();
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_R8G8B8A8_UNORM;
ici.mipLevels = 2; // not 1
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02586");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ImageDimensions) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer dimension and VkImage match.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
AHardwareBuffer_Desc ahb_desc = {};
ahb_desc.format = AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM;
ahb_desc.usage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
ahb_desc.width = 128;
ahb_desc.height = 32;
ahb_desc.layers = 1;
ahb_desc.stride = 1;
vkt::AHB ahb(&ahb_desc);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkExternalFormatANDROID external_format = vku::InitStructHelper();
external_format.externalFormat = ahb_fmt_props.externalFormat;
VkImageCreateInfo ici = vku::InitStructHelper(&external_format);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_UNDEFINED;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02388");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, UnknownFormat) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer uses VK_FORMAT_UNDEFINED for external.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkImageCreateInfo ici = vku::InitStructHelper();
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_B8G8R8A8_UNORM;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02387");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, GpuUsage) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer has a GPU usage flag.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, AHARDWAREBUFFER_USAGE_PROTECTED_CONTENT, 64, 64);
if (!ahb.handle()) {
GTEST_SKIP() << "Was unable to allocate an AHB";
}
// Everything from ahb_props is garbage and not usable
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
m_errorMonitor->SetDesiredError("VUID-vkGetAndroidHardwareBufferPropertiesANDROID-buffer-01884");
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
m_errorMonitor->VerifyFound();
// Since we are creating a invalid AHB for the safe of getting the below AHB, there is a chance the driver will not be forgiving
// and still give an usable AHB
{
AHardwareBuffer_Desc ahb_desc_check = {};
AHardwareBuffer_describe(ahb.handle(), &ahb_desc_check);
if (ahb_desc_check.usage == 0) {
GTEST_SKIP() << "Was unable to create a valid AHB to be used";
}
}
VkExternalFormatANDROID external_format = vku::InitStructHelper();
external_format.externalFormat = 0;
VkImageCreateInfo ici = vku::InitStructHelper(&external_format);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_R8G8B8A8_UNORM;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&dedicated_allocation_info);
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
// Dedicated allocation with missing usage bits
// Setting up this test also triggers a slew of others
memory_allocate_info.allocationSize = 4096;
memory_allocate_info.memoryTypeIndex = 0;
m_errorMonitor->SetUnexpectedError("VUID-VkMemoryAllocateInfo-pNext-02390");
m_errorMonitor->SetUnexpectedError("VUID-VkMemoryAllocateInfo-memoryTypeIndex-02385");
m_errorMonitor->SetUnexpectedError("VUID-VkMemoryAllocateInfo-allocationSize-02383");
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02386");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ExportMemoryAllocateImage) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer VkExportMemoryAllocateInfo instead of import.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkExternalFormatANDROID external_format = vku::InitStructHelper();
external_format.externalFormat = ahb_fmt_props.externalFormat;
VkImageCreateInfo ici = vku::InitStructHelper(&external_format);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_UNDEFINED;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, ici, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = image;
dedicated_allocation_info.buffer = VK_NULL_HANDLE;
// Non-import allocation - replace import struct in chain with export struct
VkExportMemoryAllocateInfo export_memory = vku::InitStructHelper(&dedicated_allocation_info);
export_memory.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&export_memory);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-01874");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ExportMemoryAllocateBuffer) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer VkExportMemoryAllocateInfo instead of import.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkExternalMemoryBufferCreateInfo ext_buf_info = vku::InitStructHelper();
ext_buf_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkBufferCreateInfo buffer_create_info = vku::InitStructHelper(&ext_buf_info);
buffer_create_info.size = 4096;
buffer_create_info.usage = VK_BUFFER_USAGE_TRANSFER_SRC_BIT;
vkt::Buffer buffer(*m_device, buffer_create_info, vkt::no_mem);
VkMemoryDedicatedAllocateInfo dedicated_allocation_info = vku::InitStructHelper();
dedicated_allocation_info.image = VK_NULL_HANDLE;
dedicated_allocation_info.buffer = buffer;
// Non-import allocation - replace import struct in chain with export struct
VkExportMemoryAllocateInfo export_memory = vku::InitStructHelper(&dedicated_allocation_info);
export_memory.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&export_memory);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
memory_allocate_info.allocationSize = 0;
m_errorMonitor->SetUnexpectedError("VUID-VkMemoryDedicatedAllocateInfo-buffer-02965");
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-07901");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, CreateYCbCrSampler) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer YCbCr sampler creation.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
AddRequiredFeature(vkt::Feature::samplerYcbcrConversion);
RETURN_IF_SKIP(Init());
VkSamplerYcbcrConversion ycbcr_conv = VK_NULL_HANDLE;
VkSamplerYcbcrConversionCreateInfo sycci = vku::InitStructHelper();
sycci.format = VK_FORMAT_UNDEFINED;
sycci.ycbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY;
sycci.ycbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_FULL;
m_errorMonitor->SetDesiredError("VUID-VkSamplerYcbcrConversionCreateInfo-format-04061");
m_errorMonitor->SetUnexpectedError("VUID-VkSamplerYcbcrConversionCreateInfo-xChromaOffset-01651");
vk::CreateSamplerYcbcrConversion(device(), &sycci, NULL, &ycbcr_conv);
m_errorMonitor->VerifyFound();
VkExternalFormatANDROID efa = vku::InitStructHelper();
efa.externalFormat = AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM;
sycci.format = VK_FORMAT_R8G8B8A8_UNORM;
sycci.pNext = &efa;
m_errorMonitor->SetDesiredError("VUID-VkSamplerYcbcrConversionCreateInfo-format-01904");
m_errorMonitor->SetUnexpectedError("VUID-VkSamplerYcbcrConversionCreateInfo-xChromaOffset-01651");
vk::CreateSamplerYcbcrConversion(device(), &sycci, NULL, &ycbcr_conv);
m_errorMonitor->VerifyFound();
efa.externalFormat = AHARDWAREBUFFER_FORMAT_Y8Cb8Cr8_420;
sycci.format = VK_FORMAT_UNDEFINED;
sycci.ycbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_YCBCR_709;
sycci.ycbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_NARROW;
// Spec says if we use VkExternalFormatANDROID value of components is ignored.
sycci.components = {VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO};
vkt::SamplerYcbcrConversion conversion(*m_device, sycci);
}
TEST_F(NegativeAndroidHardwareBuffer, PhysDevImageFormatProp2) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer GetPhysicalDeviceImageFormatProperties.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_EXT_EXTERNAL_MEMORY_HOST_EXTENSION_NAME);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
VkImageFormatProperties2 ifp = vku::InitStructHelper();
VkPhysicalDeviceImageFormatInfo2 pdifi = vku::InitStructHelper();
pdifi.format = VK_FORMAT_R8G8B8A8_UNORM;
pdifi.tiling = VK_IMAGE_TILING_OPTIMAL;
pdifi.type = VK_IMAGE_TYPE_2D;
pdifi.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
VkAndroidHardwareBufferUsageANDROID ahbu = vku::InitStructHelper();
ahbu.androidHardwareBufferUsage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
ifp.pNext = &ahbu;
// AHB_usage chained to input without a matching external image format struc chained to output
m_errorMonitor->SetDesiredError("VUID-vkGetPhysicalDeviceImageFormatProperties2-pNext-01868");
vk::GetPhysicalDeviceImageFormatProperties2(m_device->Physical(), &pdifi, &ifp);
m_errorMonitor->VerifyFound();
// output struct chained, but does not include VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID usage
VkPhysicalDeviceExternalImageFormatInfo pdeifi = vku::InitStructHelper();
pdeifi.handleType = VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT;
pdifi.pNext = &pdeifi;
m_errorMonitor->SetDesiredError("VUID-vkGetPhysicalDeviceImageFormatProperties2-pNext-01868");
vk::GetPhysicalDeviceImageFormatProperties2(m_device->Physical(), &pdifi, &ifp);
m_errorMonitor->VerifyFound();
}
#if DISABLEUNTILAHBWORKS
TEST_F(NegativeAndroidHardwareBuffer, CreateImageView) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer image view creation.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
// Allocate an AHB and fetch its properties
AHardwareBuffer *ahb = nullptr;
AHardwareBuffer_Desc ahb_desc = {};
ahb_desc.format = AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM;
ahb_desc.usage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
ahb_desc.width = 64;
ahb_desc.height = 64;
ahb_desc.layers = 1;
AHardwareBuffer_allocate(&ahb_desc, &ahb);
// Retrieve AHB properties to make it's external format 'known'
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb, &ahb_props);
AHardwareBuffer_release(ahb);
VkExternalMemoryImageCreateInfo emici = vku::InitStructHelper();
emici.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
// Give image an external format
VkExternalFormatANDROID efa = vku::InitStructHelper(&emici);
efa.externalFormat = ahb_fmt_props.externalFormat;
ahb_desc.format = AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM;
ahb_desc.usage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
ahb_desc.width = 64;
ahb_desc.height = 1;
ahb_desc.layers = 1;
AHardwareBuffer_allocate(&ahb_desc, &ahb);
// Create another VkExternalFormatANDROID for test VUID-VkImageViewCreateInfo-image-02400
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props_Ycbcr =
vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props_Ycbcr =
vku::InitStructHelper(&ahb_fmt_props_Ycbcr);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb, &ahb_props_Ycbcr);
AHardwareBuffer_release(ahb);
VkExternalFormatANDROID efa_Ycbcr = vku::InitStructHelper();
efa_Ycbcr.externalFormat = ahb_fmt_props_Ycbcr.externalFormat;
// Need to make sure format has sample bit needed for image usage
if ((ahb_fmt_props_Ycbcr.formatFeatures & VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT) == 0) {
GTEST_SKIP() << "VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT feature bit not supported";
}
// Create the image
VkImage img = VK_NULL_HANDLE;
VkImageCreateInfo ici = vku::InitStructHelper(&efa);
ici.imageType = VK_IMAGE_TYPE_2D;
ici.arrayLayers = 1;
ici.extent = {64, 64, 1};
ici.format = VK_FORMAT_UNDEFINED;
ici.mipLevels = 1;
ici.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
ici.samples = VK_SAMPLE_COUNT_1_BIT;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
ici.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vk::CreateImage(device(), &ici, NULL, &img);
// Set up memory allocation
VkDeviceMemory img_mem = VK_NULL_HANDLE;
VkMemoryAllocateInfo mai = vku::InitStructHelper();
mai.allocationSize = 64 * 64 * 4;
mai.memoryTypeIndex = 0;
vk::AllocateMemory(device(), &mai, NULL, &img_mem);
// It shouldn't use vk::GetImageMemoryRequirements for imported AndroidHardwareBuffer when memory isn't bound yet
m_errorMonitor->SetDesiredError("VUID-vkGetImageMemoryRequirements-image-04004");
VkMemoryRequirements img_mem_reqs = {};
vk::GetImageMemoryRequirements(device(), img, &img_mem_reqs);
m_errorMonitor->VerifyFound();
vk::BindImageMemory(device(), img, img_mem, 0);
// Bind image to memory
vk::DestroyImage(device(), img, NULL);
vk::FreeMemory(device(), img_mem, NULL);
vk::CreateImage(device(), &ici, NULL, &img);
vk::AllocateMemory(device(), &mai, NULL, &img_mem);
vk::BindImageMemory(device(), img, img_mem, 0);
// Create a YCbCr conversion, with different external format, chain to view
VkSamplerYcbcrConversion ycbcr_conv = VK_NULL_HANDLE;
VkSamplerYcbcrConversionCreateInfo sycci = vku::InitStructHelper(&efa_Ycbcr);
sycci.format = VK_FORMAT_UNDEFINED;
sycci.ycbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY;
sycci.ycbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_FULL;
vk::CreateSamplerYcbcrConversion(device(), &sycci, NULL, &ycbcr_conv);
VkSamplerYcbcrConversionInfo syci = vku::InitStructHelper();
syci.conversion = ycbcr_conv;
// Create a view
VkImageView image_view = VK_NULL_HANDLE;
VkImageViewCreateInfo ivci = vku::InitStructHelper(&syci);
ivci.image = img;
ivci.viewType = VK_IMAGE_VIEW_TYPE_2D;
ivci.format = VK_FORMAT_UNDEFINED;
ivci.subresourceRange = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 1, 0, 1};
auto reset_view = [&image_view, dev]() {
if (VK_NULL_HANDLE != image_view) vk::DestroyImageView(dev, image_view, NULL);
image_view = VK_NULL_HANDLE;
};
// Up to this point, no errors expected
// Chained ycbcr conversion has different (external) format than image
m_errorMonitor->SetDesiredError("VUID-VkImageViewCreateInfo-image-02400");
// Also causes "unsupported format" - should be removed in future spec update
m_errorMonitor->SetDesiredError("VUID-VkImageViewCreateInfo-None-02273");
vk::CreateImageView(device(), &ivci, NULL, &image_view);
m_errorMonitor->VerifyFound();
reset_view();
vk::DestroySamplerYcbcrConversion(device(), ycbcr_conv, NULL);
sycci.pNext = &efa;
vk::CreateSamplerYcbcrConversion(device(), &sycci, NULL, &ycbcr_conv);
syci.conversion = ycbcr_conv;
// View component swizzle not IDENTITY
ivci.components.r = VK_COMPONENT_SWIZZLE_B;
ivci.components.b = VK_COMPONENT_SWIZZLE_R;
m_errorMonitor->SetDesiredError("VUID-VkImageViewCreateInfo-image-02401");
// Also causes "unsupported format" - should be removed in future spec update
m_errorMonitor->SetDesiredError("VUID-VkImageViewCreateInfo-None-02273");
vk::CreateImageView(device(), &ivci, NULL, &image_view);
m_errorMonitor->VerifyFound();
reset_view();
ivci.components.r = VK_COMPONENT_SWIZZLE_IDENTITY;
ivci.components.b = VK_COMPONENT_SWIZZLE_IDENTITY;
// View with external format, when format is not UNDEFINED
ivci.format = VK_FORMAT_R5G6B5_UNORM_PACK16;
m_errorMonitor->SetDesiredError("VUID-VkImageViewCreateInfo-image-02399");
// Also causes "view format different from image format"
m_errorMonitor->SetDesiredError("VUID-VkImageViewCreateInfo-image-01762");
vk::CreateImageView(device(), &ivci, NULL, &image_view);
m_errorMonitor->VerifyFound();
reset_view();
vk::DestroySamplerYcbcrConversion(device(), ycbcr_conv, NULL);
vk::DestroyImageView(device(), image_view, NULL);
vk::DestroyImage(device(), img, NULL);
vk::FreeMemory(device(), img_mem, NULL);
}
#endif // DISABLEUNTILAHBWORKS
TEST_F(NegativeAndroidHardwareBuffer, ImportBuffer) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer import as buffer.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
// non USAGE_GPU_*
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_BLOB, AHARDWAREBUFFER_USAGE_SENSOR_DIRECT_DATA, 512);
m_errorMonitor->SetUnexpectedError("VUID-vkGetAndroidHardwareBufferPropertiesANDROID-buffer-01884");
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
// Create export and import buffers
VkExternalMemoryBufferCreateInfo ext_buf_info = vku::InitStructHelper();
ext_buf_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper();
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
// Import as buffer requires usage AHB_USAGE_GPU_DATA_BUFFER
m_errorMonitor->SetDesiredError("VUID-VkImportAndroidHardwareBufferInfoANDROID-buffer-01881");
// Also causes "non-dedicated allocation format/usage" error
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-02384");
vkt::DeviceMemory mem_handle(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ExportBufferHandleType) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer export memory as AHB has a valid handleType.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
// Allocate device memory, no linked export struct indicating AHB handle type
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper();
memory_allocate_info.allocationSize = 65536;
memory_allocate_info.memoryTypeIndex = 0;
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
VkMemoryGetAndroidHardwareBufferInfoANDROID mgahbi = vku::InitStructHelper();
mgahbi.memory = memory;
AHardwareBuffer *ahb = nullptr;
m_errorMonitor->SetDesiredError("VUID-VkMemoryGetAndroidHardwareBufferInfoANDROID-handleTypes-01882");
vk::GetMemoryAndroidHardwareBufferANDROID(device(), &mgahbi, &ahb);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ExportBufferAllocationSize) {
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
// Create VkBuffer to be exported to an AHB
VkExternalMemoryBufferCreateInfo ext_buf_info = vku::InitStructHelper();
ext_buf_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkBufferCreateInfo buffer_create_info = vku::InitStructHelper(&ext_buf_info);
buffer_create_info.size = 4096;
buffer_create_info.usage = VK_BUFFER_USAGE_TRANSFER_SRC_BIT;
vkt::Buffer buffer(*m_device, buffer_create_info, vkt::no_mem);
VkMemoryRequirements mem_reqs;
vk::GetBufferMemoryRequirements(device(), buffer, &mem_reqs);
VkExportMemoryAllocateInfo export_memory_info = vku::InitStructHelper();
export_memory_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkMemoryAllocateInfo memory_info = vku::InitStructHelper(&export_memory_info);
memory_info.allocationSize = 0;
bool has_memtype =
m_device->Physical().SetMemoryType(mem_reqs.memoryTypeBits, &memory_info, VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT);
if (!has_memtype) {
GTEST_SKIP() << "No valid memory type index could be found";
}
m_errorMonitor->SetDesiredError("VUID-VkMemoryAllocateInfo-pNext-07900");
vkt::DeviceMemory memory(*m_device, memory_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ExportImageNonBound) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer export memory as AHB has image bound already.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
// Create VkImage to be exported to an AHB
VkExternalMemoryImageCreateInfo ext_image_info = vku::InitStructHelper();
ext_image_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkImageCreateInfo image_create_info = vku::InitStructHelper(&ext_image_info);
image_create_info.flags = 0;
image_create_info.imageType = VK_IMAGE_TYPE_2D;
image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM;
image_create_info.extent = {64, 1, 1};
image_create_info.mipLevels = 1;
image_create_info.arrayLayers = 1;
image_create_info.samples = VK_SAMPLE_COUNT_1_BIT;
image_create_info.tiling = VK_IMAGE_TILING_LINEAR;
image_create_info.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
image_create_info.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
image_create_info.usage = VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT;
vkt::Image image(*m_device, image_create_info, vkt::no_mem);
VkMemoryDedicatedAllocateInfo memory_dedicated_info = vku::InitStructHelper();
memory_dedicated_info.image = image;
memory_dedicated_info.buffer = VK_NULL_HANDLE;
VkExportMemoryAllocateInfo export_memory_info = vku::InitStructHelper(&memory_dedicated_info);
export_memory_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkMemoryAllocateInfo memory_info = vku::InitStructHelper(&export_memory_info);
// "When allocating new memory for an image that can be exported to an Android hardware buffer, the memory’s allocationSize must
// be zero":
memory_info.allocationSize = 0;
// Use any DEVICE_LOCAL memory found
bool has_memtype = m_device->Physical().SetMemoryType(0xFFFFFFFF, &memory_info, VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT);
if (!has_memtype) {
GTEST_SKIP() << "No valid memory type index could be found";
}
vkt::DeviceMemory memory(*m_device, memory_info);
VkMemoryGetAndroidHardwareBufferInfoANDROID mgahbi = vku::InitStructHelper();
mgahbi.memory = memory;
m_errorMonitor->SetDesiredError("VUID-VkMemoryGetAndroidHardwareBufferInfoANDROID-pNext-01883");
AHardwareBuffer *ahb = nullptr;
vk::GetMemoryAndroidHardwareBufferANDROID(device(), &mgahbi, &ahb);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, InvalidBindBufferMemory) {
TEST_DESCRIPTION("Validate binding AndroidHardwareBuffer VkBuffer act same as non-AHB buffers.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_BLOB, AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER, 64);
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkExternalMemoryBufferCreateInfo ext_buf_info = vku::InitStructHelper();
ext_buf_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkBufferCreateInfo buffer_create_info = vku::InitStructHelper(&ext_buf_info);
buffer_create_info.size = ahb_props.allocationSize;
buffer_create_info.usage = VK_BUFFER_USAGE_TRANSFER_SRC_BIT;
vkt::Buffer buffer(*m_device, buffer_create_info, vkt::no_mem);
// Try to get memory requirements prior to binding memory
VkBufferMemoryRequirementsInfo2 buffer_memory_requirements_info = vku::InitStructHelper();
buffer_memory_requirements_info.buffer = buffer;
VkMemoryDedicatedRequirements memory_dedicated_requirements = vku::InitStructHelper();
VkMemoryRequirements2 mem_reqs2 = vku::InitStructHelper(&memory_dedicated_requirements);
vk::GetBufferMemoryRequirements2(device(), &buffer_memory_requirements_info, &mem_reqs2);
VkMemoryRequirements mem_reqs = mem_reqs2.memoryRequirements;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper();
import_ahb_Info.buffer = ahb.handle();
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
if (!SetAllocationInfoImportAHB(m_device, ahb_props, memory_allocate_info)) {
GTEST_SKIP() << "No valid memory type index could be found";
}
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
if (memory.handle() == VK_NULL_HANDLE) {
GTEST_SKIP() << "This test failed to allocate memory for importing";
}
if (mem_reqs.alignment > 1) {
m_errorMonitor->SetAllowedFailureMsg("VUID-vkBindBufferMemory-buffer-01444"); // required dedicated
m_errorMonitor->SetDesiredError("VUID-vkBindBufferMemory-None-10739");
m_errorMonitor->SetDesiredError("VUID-vkBindBufferMemory-None-10741");
vk::BindBufferMemory(device(), buffer, memory.handle(), 1);
m_errorMonitor->VerifyFound();
}
VkDeviceSize buffer_offset = (mem_reqs.size - 1) & ~(mem_reqs.alignment - 1);
if (buffer_offset > 0) {
m_errorMonitor->SetDesiredError("VUID-vkBindBufferMemory-None-10741");
if (memory_dedicated_requirements.requiresDedicatedAllocation) {
m_errorMonitor->SetDesiredError("VUID-vkBindBufferMemory-buffer-01444");
}
vk::BindBufferMemory(device(), buffer, memory.handle(), buffer_offset);
m_errorMonitor->VerifyFound();
}
}
TEST_F(NegativeAndroidHardwareBuffer, ImportBufferHandleType) {
TEST_DESCRIPTION("Don't use proper resource handleType for import buffer");
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_BLOB, AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER, 64);
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper();
import_ahb_Info.buffer = ahb.handle();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
memory_allocate_info.allocationSize = ahb_props.allocationSize;
// driver won't expose correct memoryType since resource was not created as an import operation
// so just need any valid memory type returned from GetAHBInfo
for (int i = 0; i < 32; i++) {
if (ahb_props.memoryTypeBits & (1 << i)) {
memory_allocate_info.memoryTypeIndex = i;
break;
}
}
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
// Create buffer without VkExternalMemoryBufferCreateInfo
VkBufferCreateInfo buffer_create_info = vku::InitStructHelper();
buffer_create_info.size = ahb_props.allocationSize;
buffer_create_info.usage = VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT;
vkt::Buffer buffer(*m_device, buffer_create_info, vkt::no_mem);
m_errorMonitor->SetDesiredError("VUID-vkBindBufferMemory-memory-02986");
m_errorMonitor->SetUnexpectedError("VUID-vkBindBufferMemory-memory-01035");
vk::BindBufferMemory(device(), buffer, memory, 0);
m_errorMonitor->VerifyFound();
VkBindBufferMemoryInfo bind_buffer_info = vku::InitStructHelper();
bind_buffer_info.buffer = buffer;
bind_buffer_info.memory = memory;
bind_buffer_info.memoryOffset = 0;
m_errorMonitor->SetDesiredError("VUID-VkBindBufferMemoryInfo-memory-02986");
m_errorMonitor->SetUnexpectedError("VUID-VkBindBufferMemoryInfo-memory-01035");
vk::BindBufferMemory2KHR(device(), 1, &bind_buffer_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, ImportImageHandleType) {
TEST_DESCRIPTION("Don't use proper resource handleType for import image");
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
// Create buffer without VkExternalMemoryImageCreateInfo
VkImageCreateInfo image_create_info = vku::InitStructHelper();
image_create_info.flags = 0;
image_create_info.imageType = VK_IMAGE_TYPE_2D;
image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM;
image_create_info.extent = {64, 64, 1};
image_create_info.mipLevels = 1;
image_create_info.arrayLayers = 1;
image_create_info.samples = VK_SAMPLE_COUNT_1_BIT;
image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL;
image_create_info.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
image_create_info.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
vkt::Image image(*m_device, image_create_info, vkt::no_mem);
VkMemoryDedicatedAllocateInfo memory_dedicated_info = vku::InitStructHelper();
memory_dedicated_info.image = image;
memory_dedicated_info.buffer = VK_NULL_HANDLE;
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info =
vku::InitStructHelper(&memory_dedicated_info);
import_ahb_Info.buffer = ahb.handle();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
memory_allocate_info.allocationSize = ahb_props.allocationSize;
// driver won't expose correct memoryType since resource was not created as an import operation
// so just need any valid memory type returned from GetAHBInfo
for (int i = 0; i < 32; i++) {
if (ahb_props.memoryTypeBits & (1 << i)) {
memory_allocate_info.memoryTypeIndex = i;
break;
}
}
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->SetDesiredError("VUID-vkBindImageMemory-memory-02990");
m_errorMonitor->SetUnexpectedError("VUID-vkBindImageMemory-memory-01047");
m_errorMonitor->SetUnexpectedError("VUID-vkBindImageMemory-None-10737");
vk::BindImageMemory(device(), image, memory, 0);
m_errorMonitor->VerifyFound();
VkBindImageMemoryInfo bind_image_info = vku::InitStructHelper();
bind_image_info.image = image;
bind_image_info.memory = memory;
bind_image_info.memoryOffset = 0;
m_errorMonitor->SetDesiredError("VUID-VkBindImageMemoryInfo-memory-02990");
m_errorMonitor->SetUnexpectedError("VUID-VkBindImageMemoryInfo-pNext-01617");
m_errorMonitor->SetUnexpectedError("VUID-VkBindImageMemoryInfo-pNext-01615");
vk::BindImageMemory2KHR(device(), 1, &bind_image_info);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, DeviceImageMemoryReq) {
TEST_DESCRIPTION("Call vkGetDeviceImageMemoryRequirementsKHR with externalFormat of non-zero.");
SetTargetApiVersion(VK_API_VERSION_1_1);
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
AddRequiredExtensions(VK_KHR_MAINTENANCE_4_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM, AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE, 64, 64);
VkAndroidHardwareBufferFormatPropertiesANDROID ahb_fmt_props = vku::InitStructHelper();
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper(&ahb_fmt_props);
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
// The spec says the driver must not return zero, even if a VkFormat is returned with it, some older drivers do as a driver bug
if (ahb_fmt_props.externalFormat == 0) {
GTEST_SKIP() << "externalFormat was zero which is not valid";
}
VkExternalFormatANDROID external_format = vku::InitStructHelper();
external_format.externalFormat = ahb_fmt_props.externalFormat;
VkImageCreateInfo image_create_info = vku::InitStructHelper(&external_format);
image_create_info.imageType = VK_IMAGE_TYPE_2D;
image_create_info.arrayLayers = 1;
image_create_info.extent = {64, 64, 1};
image_create_info.format = VK_FORMAT_UNDEFINED;
image_create_info.mipLevels = 1;
image_create_info.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
image_create_info.samples = VK_SAMPLE_COUNT_1_BIT;
image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL;
image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT;
VkDeviceImageMemoryRequirements image_memory_req = vku::InitStructHelper();
image_memory_req.pCreateInfo = &image_create_info;
image_memory_req.planeAspect = VK_IMAGE_ASPECT_COLOR_BIT;
VkMemoryRequirements2 out_memory_req = vku::InitStructHelper();
m_errorMonitor->SetDesiredError("VUID-VkDeviceImageMemoryRequirements-pNext-06996");
vk::GetDeviceImageMemoryRequirementsKHR(device(), &image_memory_req, &out_memory_req);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeAndroidHardwareBuffer, NullAHBProperties) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer calls must have non-null AHB objects passed in.");
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_BLOB, AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER, 64);
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
m_errorMonitor->SetDesiredError("VUID-vkGetAndroidHardwareBufferPropertiesANDROID-buffer-parameter");
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), nullptr, &ahb_props);
m_errorMonitor->VerifyFound();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
}
TEST_F(NegativeAndroidHardwareBuffer, NullAHBImport) {
TEST_DESCRIPTION("Verify AndroidHardwareBuffer calls must have non-null AHB objects passed in.");
AddRequiredExtensions(VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME);
RETURN_IF_SKIP(Init());
vkt::AHB ahb(AHARDWAREBUFFER_FORMAT_BLOB, AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER, 64);
VkExternalMemoryBufferCreateInfo ext_buf_info = vku::InitStructHelper();
ext_buf_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID;
VkBufferCreateInfo buffer_create_info = vku::InitStructHelper(&ext_buf_info);
buffer_create_info.size = 512;
buffer_create_info.usage = VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT;
vkt::Buffer buffer(*m_device, buffer_create_info, vkt::no_mem);
VkAndroidHardwareBufferPropertiesANDROID ahb_props = vku::InitStructHelper();
vk::GetAndroidHardwareBufferPropertiesANDROID(device(), ahb.handle(), &ahb_props);
VkImportAndroidHardwareBufferInfoANDROID import_ahb_Info = vku::InitStructHelper();
import_ahb_Info.buffer = nullptr; // invalid
VkMemoryAllocateInfo memory_allocate_info = vku::InitStructHelper(&import_ahb_Info);
memory_allocate_info.allocationSize = ahb_props.allocationSize;
// Set index to match one of the bits in ahb_props that is also only Device Local
// Android implemenetations "should have" a DEVICE_LOCAL only index designed for AHB
VkMemoryPropertyFlagBits property = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
VkPhysicalDeviceMemoryProperties gpu_memory_props;
vk::GetPhysicalDeviceMemoryProperties(Gpu(), &gpu_memory_props);
memory_allocate_info.memoryTypeIndex = gpu_memory_props.memoryTypeCount + 1;
for (uint32_t i = 0; i < gpu_memory_props.memoryTypeCount; i++) {
if ((ahb_props.memoryTypeBits & (1 << i)) && ((gpu_memory_props.memoryTypes[i].propertyFlags & property) == property)) {
memory_allocate_info.memoryTypeIndex = i;
break;
}
}
if (memory_allocate_info.memoryTypeIndex >= gpu_memory_props.memoryTypeCount) {
GTEST_SKIP() << "No valid memory type index could be found; skipped.\n";
}
m_errorMonitor->SetDesiredError("VUID-VkImportAndroidHardwareBufferInfoANDROID-buffer-parameter");
vkt::DeviceMemory memory(*m_device, memory_allocate_info);
m_errorMonitor->VerifyFound();
}
#endif // VK_USE_PLATFORM_ANDROID_KHR
|