1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
|
/*
* Copyright (c) 2023-2025 The Khronos Group Inc.
* Copyright (c) 2023-2025 Valve Corporation
* Copyright (c) 2023-2025 LunarG, Inc.
* Copyright (c) 2023-2025 Google, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*/
#include "../framework/layer_validation_tests.h"
class PositiveGpuAVCopies : public GpuAVTest {};
TEST_F(PositiveGpuAVCopies, CopyBufferToImageD32) {
TEST_DESCRIPTION(
"Copy depth buffer to image with all depth values in the [0, 1] legal range. Depth image has format "
"VK_FORMAT_D32_SFLOAT.");
AddRequiredExtensions(VK_KHR_8BIT_STORAGE_EXTENSION_NAME);
AddRequiredFeature(vkt::Feature::uniformAndStorageBuffer8BitAccess);
RETURN_IF_SKIP(InitGpuAvFramework());
RETURN_IF_SKIP(InitState());
vkt::Buffer copy_src_buffer(*m_device, sizeof(float) * 64 * 64,
VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kHostVisibleMemProps);
float *ptr = static_cast<float *>(copy_src_buffer.Memory().Map());
for (size_t i = 0; i < 64 * 64; ++i) {
if (i % 2) {
ptr[i] = 1.0f;
} else {
ptr[i] = 0.0f;
}
}
vkt::Image copy_dst_image(*m_device, 64, 64, VK_FORMAT_D32_SFLOAT,
VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT);
copy_dst_image.SetLayout(VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL);
m_command_buffer.Begin();
VkBufferImageCopy buffer_image_copy_1;
buffer_image_copy_1.bufferOffset = 0;
buffer_image_copy_1.bufferRowLength = 0;
buffer_image_copy_1.bufferImageHeight = 0;
buffer_image_copy_1.imageSubresource = {VK_IMAGE_ASPECT_DEPTH_BIT, 0, 0, 1};
buffer_image_copy_1.imageOffset = {0, 0, 0};
buffer_image_copy_1.imageExtent = {64, 64, 1};
vk::CmdCopyBufferToImage(m_command_buffer, copy_src_buffer, copy_dst_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1,
&buffer_image_copy_1);
VkBufferImageCopy buffer_image_copy_2 = buffer_image_copy_1;
buffer_image_copy_2.imageOffset = {32, 32, 0};
buffer_image_copy_2.imageExtent = {32, 32, 1};
vk::CmdCopyBufferToImage(m_command_buffer, copy_src_buffer, copy_dst_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1,
&buffer_image_copy_2);
m_command_buffer.End();
m_default_queue->Submit(m_command_buffer);
vk::DeviceWaitIdle(*m_device);
}
TEST_F(PositiveGpuAVCopies, CopyBufferToImageD32U8) {
TEST_DESCRIPTION(
"Copy depth buffer to image with all depth values in the [0, 1] legal range. Depth image has format "
"VK_FORMAT_D32_SFLOAT_S8_UINT.");
AddRequiredExtensions(VK_KHR_8BIT_STORAGE_EXTENSION_NAME);
AddRequiredFeature(vkt::Feature::uniformAndStorageBuffer8BitAccess);
RETURN_IF_SKIP(InitGpuAvFramework());
RETURN_IF_SKIP(InitState());
vkt::Buffer copy_src_buffer(*m_device, 5 * 64 * 64, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
kHostVisibleMemProps);
auto ptr = static_cast<uint8_t *>(copy_src_buffer.Memory().Map());
std::memset(ptr, 0, static_cast<size_t>(copy_src_buffer.CreateInfo().size));
for (size_t i = 0; i < 64 * 64; ++i) {
auto ptr_float = reinterpret_cast<float *>(ptr + 5 * i);
if (i % 2) {
*ptr_float = 1.0f;
} else {
*ptr_float = 0.0f;
}
}
vkt::Image copy_dst_image(*m_device, 64, 64, VK_FORMAT_D32_SFLOAT_S8_UINT,
VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT);
copy_dst_image.SetLayout(VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL);
m_command_buffer.Begin();
VkBufferImageCopy buffer_image_copy;
buffer_image_copy.bufferOffset = 0;
buffer_image_copy.bufferRowLength = 0;
buffer_image_copy.bufferImageHeight = 0;
buffer_image_copy.imageSubresource = {VK_IMAGE_ASPECT_DEPTH_BIT, 0, 0, 1};
buffer_image_copy.imageOffset = {33, 33, 0};
buffer_image_copy.imageExtent = {31, 31, 1};
vk::CmdCopyBufferToImage(m_command_buffer, copy_src_buffer, copy_dst_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1,
&buffer_image_copy);
m_command_buffer.End();
m_default_queue->Submit(m_command_buffer);
vk::DeviceWaitIdle(*m_device);
}
TEST_F(PositiveGpuAVCopies, CopyBufferToImageTwoSubmit) {
TEST_DESCRIPTION("Make sure resources are managed correctly afer a CopyBufferToImage call.");
RETURN_IF_SKIP(InitGpuAvFramework());
RETURN_IF_SKIP(InitState());
vkt::CommandBuffer cb_0(*m_device, m_command_pool);
vkt::CommandBuffer cb_1(*m_device, m_command_pool);
auto image_ci = vkt::Image::ImageCreateInfo2D(32, 32, 1, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_TRANSFER_DST_BIT);
vkt::Image image(*m_device, image_ci, vkt::set_layout);
vkt::Buffer buffer(*m_device, 4096, VK_IMAGE_USAGE_TRANSFER_SRC_BIT);
VkBufferImageCopy region = {};
region.bufferRowLength = 0;
region.bufferImageHeight = 0;
region.imageSubresource = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 0, 1};
region.imageOffset = {0, 0, 0};
region.imageExtent = {32, 32, 1};
region.bufferOffset = 0;
cb_0.Begin();
vk::CmdCopyBufferToImage(cb_0, buffer, image, VK_IMAGE_LAYOUT_GENERAL, 1, ®ion);
cb_0.End();
m_default_queue->SubmitAndWait(cb_0);
cb_1.Begin();
cb_1.End();
m_default_queue->SubmitAndWait(cb_1);
}
TEST_F(PositiveGpuAVCopies, Resubmit) {
TEST_DESCRIPTION("Recreate and submit command buffers");
AddRequiredExtensions(VK_KHR_COPY_COMMANDS_2_EXTENSION_NAME);
RETURN_IF_SKIP(InitGpuAvFramework());
RETURN_IF_SKIP(InitState());
vkt::Image copy_dst_image(*m_device, 64, 64, VK_FORMAT_D32_SFLOAT_S8_UINT,
VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT);
copy_dst_image.SetLayout(VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL);
vkt::Buffer copy_src_buffer(*m_device, 16, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
kHostVisibleMemProps);
auto buffer_ptr = static_cast<uint8_t *>(copy_src_buffer.Memory().Map());
memset(buffer_ptr, 0, 16);
VkBufferImageCopy2 region2 = vku::InitStructHelper();
region2.bufferOffset = 0;
region2.bufferRowLength = 0;
region2.bufferImageHeight = 0;
region2.imageSubresource = {VK_IMAGE_ASPECT_DEPTH_BIT, 0, 0, 1};
region2.imageOffset = {0, 0, 0};
region2.imageExtent = {1, 1, 1};
VkCopyBufferToImageInfo2 buffer_image_copy = vku::InitStructHelper();
buffer_image_copy.srcBuffer = copy_src_buffer;
buffer_image_copy.dstImage = copy_dst_image;
buffer_image_copy.dstImageLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL;
buffer_image_copy.regionCount = 1;
buffer_image_copy.pRegions = ®ion2;
vkt::CommandBuffer cb_0(*m_device, m_command_pool);
vkt::CommandBuffer cb_1(*m_device, m_command_pool);
cb_0.Begin();
vk::CmdCopyBufferToImage2KHR(cb_0, &buffer_image_copy);
region2.imageOffset.x = 1;
vk::CmdCopyBufferToImage2KHR(cb_0, &buffer_image_copy);
cb_0.End();
m_default_queue->SubmitAndWait(cb_0);
cb_1.Begin();
region2.imageOffset.x = 2;
vk::CmdCopyBufferToImage2KHR(cb_1, &buffer_image_copy);
region2.imageOffset.x = 3;
vk::CmdCopyBufferToImage2KHR(cb_1, &buffer_image_copy);
cb_1.End();
m_default_queue->SubmitAndWait(cb_1);
cb_1.Begin();
region2.imageOffset.x = 4;
vk::CmdCopyBufferToImage2KHR(cb_1, &buffer_image_copy);
cb_1.End();
m_default_queue->SubmitAndWait(cb_1);
cb_0.Begin();
region2.imageOffset.x = 5;
vk::CmdCopyBufferToImage2KHR(cb_0, &buffer_image_copy);
cb_0.End();
m_default_queue->SubmitAndWait(cb_0);
}
TEST_F(PositiveGpuAVCopies, BatchSubmit) {
TEST_DESCRIPTION("Submit multiple command buffers");
AddRequiredExtensions(VK_KHR_COPY_COMMANDS_2_EXTENSION_NAME);
RETURN_IF_SKIP(InitGpuAvFramework());
RETURN_IF_SKIP(InitState());
vkt::Image copy_dst_image(*m_device, 64, 64, VK_FORMAT_D32_SFLOAT_S8_UINT,
VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT);
copy_dst_image.SetLayout(VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL);
vkt::Buffer copy_src_buffer(*m_device, 16, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
kHostVisibleMemProps);
auto buffer_ptr = static_cast<uint8_t *>(copy_src_buffer.Memory().Map());
memset(buffer_ptr, 0, 16);
VkBufferImageCopy2 region2 = vku::InitStructHelper();
region2.bufferOffset = 0;
region2.bufferRowLength = 0;
region2.bufferImageHeight = 0;
region2.imageSubresource = {VK_IMAGE_ASPECT_DEPTH_BIT, 0, 0, 1};
region2.imageOffset = {0, 0, 0};
region2.imageExtent = {1, 1, 1};
VkCopyBufferToImageInfo2 buffer_image_copy = vku::InitStructHelper();
buffer_image_copy.srcBuffer = copy_src_buffer;
buffer_image_copy.dstImage = copy_dst_image;
buffer_image_copy.dstImageLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL;
buffer_image_copy.regionCount = 1;
buffer_image_copy.pRegions = ®ion2;
vkt::CommandBuffer cb_0(*m_device, m_command_pool);
vkt::CommandBuffer cb_1(*m_device, m_command_pool);
vkt::CommandBuffer cb_2(*m_device, m_command_pool);
cb_0.Begin();
vk::CmdCopyBufferToImage2KHR(cb_0, &buffer_image_copy);
cb_0.End();
cb_1.Begin();
vk::CmdCopyBufferToImage2KHR(cb_1, &buffer_image_copy);
cb_1.End();
cb_2.Begin();
vk::CmdCopyBufferToImage2KHR(cb_2, &buffer_image_copy);
cb_2.End();
m_default_queue->Submit({cb_0, cb_1, cb_2});
m_default_queue->Wait();
cb_1.Begin();
region2.imageOffset.x = 1;
vk::CmdCopyBufferToImage2KHR(cb_1, &buffer_image_copy);
cb_1.End();
m_default_queue->Submit({cb_2, cb_1, cb_0});
m_default_queue->Wait();
}
|
