1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
|
/* Copyright (c) 2025 The Khronos Group Inc.
* Copyright (C) 2025 Arm Limited.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
#include "core_validation.h"
#include "drawdispatch/drawdispatch_vuids.h"
#include "state_tracker/cmd_buffer_state.h"
#include "state_tracker/descriptor_sets.h"
#include "state_tracker/shader_module.h"
#include "state_tracker/data_graph_pipeline_session_state.h"
#include "state_tracker/pipeline_layout_state.h"
#include "state_tracker/pipeline_state.h"
bool CoreChecks::ValidateDataGraphPipelineShaderModuleCreateInfo(VkDevice device,
const VkDataGraphPipelineShaderModuleCreateInfoARM& dg_shader_ci,
const Location& dg_shader_ci_loc,
const vvl::Pipeline& pipeline) const {
bool skip = false;
if (auto module_state = Get<vvl::ShaderModule>(dg_shader_ci.module)) {
if (!enabled_features.dataGraphSpecializationConstants) {
if (dg_shader_ci.pSpecializationInfo) {
skip |= LogError("VUID-VkDataGraphPipelineShaderModuleCreateInfoARM-dataGraphSpecializationConstants-09849", device,
dg_shader_ci_loc.dot(Field::pSpecializationInfo),
"(%p) is not null but dataGraphSpecializationConstants feature is not enabled",
dg_shader_ci.pSpecializationInfo);
}
}
}
for (uint32_t j = 0; j < dg_shader_ci.constantCount; j++) {
skip |= ValidateTensorSemiStructuredSparsityInfo(device, dg_shader_ci.pConstants[j],
dg_shader_ci_loc.dot(Field::pConstants, j), pipeline);
}
return skip;
}
bool CoreChecks::ValidateDataGraphPipelineCreateInfo(VkDevice device, const VkDataGraphPipelineCreateInfoARM& create_info,
const Location& create_info_loc, const vvl::Pipeline& pipeline) const {
bool skip = false;
if (const auto* pipeline_feedback = vku::FindStructInPNextChain<VkPipelineCreationFeedbackCreateInfo>(create_info.pNext)) {
if (pipeline_feedback->pipelineStageCreationFeedbackCount != 0) {
skip |= LogError(
"VUID-VkDataGraphPipelineCreateInfoARM-pNext-09804", device,
create_info_loc.pNext(Struct::VkPipelineCreationFeedbackCreateInfo, Field::pipelineStageCreationFeedbackCount),
"(%" PRIu32 ") must be zero", pipeline_feedback->pipelineStageCreationFeedbackCount);
}
}
auto pipeline_layout = Get<vvl::PipelineLayout>(create_info.layout);
ASSERT_AND_RETURN_SKIP(pipeline_layout);
const Location layout_loc = create_info_loc.dot(Field::layout);
if (!pipeline_layout->push_constant_ranges_layout->empty()) {
skip |=
LogError("VUID-VkDataGraphPipelineCreateInfoARM-layout-09767", device, layout_loc.dot(Field::pushConstantRangeCount),
"(%zu) must be zero", pipeline_layout->push_constant_ranges_layout->size());
}
for (uint32_t j = 0; j < pipeline_layout->set_layouts.list.size(); j++) {
auto dsl = pipeline_layout->set_layouts.list[j];
if ((dsl->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) != 0) {
if (!enabled_features.dataGraphUpdateAfterBind) {
skip |= LogError("VUID-VkDataGraphPipelineCreateInfoARM-dataGraphUpdateAfterBind-09768", device,
layout_loc.dot(Field::pSetLayouts, j),
"created with flags (%s) but the dataGraphUpdateAfterBind feature was not enabled",
string_VkDescriptorSetLayoutCreateFlags(dsl->GetCreateFlags()).c_str());
}
}
auto bindings = dsl->GetBindings();
for (uint32_t k = 0; k < bindings.size(); k++) {
auto binding = bindings[k];
auto mutable_bindings = dsl->GetMutableTypes(binding.binding);
if (!mutable_bindings.empty()) {
skip |=
LogError("VUID-VkDataGraphPipelineCreateInfoARM-pSetLayouts-09770", device,
layout_loc.dot(Field::pSetLayouts, j), "includes binding(s) of type VK_DESCRIPTOR_TYPE_MUTABLE_EXT");
}
}
}
for (uint32_t j = 0; j < create_info.resourceInfoCount; j++) {
auto resource = create_info.pResourceInfos[j];
if (resource.arrayElement != 0) {
skip |= LogError("VUID-VkDataGraphPipelineResourceInfoARM-arrayElement-09779", device,
create_info_loc.dot(Field::pResourceInfos, j).dot(Field::arrayElement), "(%" PRIu32 ") is not zero",
resource.arrayElement);
}
}
return skip;
}
bool CoreChecks::ValidateDataGraphPipelineCreateInfoFlags(VkPipelineCreateFlags2 flags, Location flags_loc) const {
bool skip = false;
constexpr VkPipelineCreateFlags2 valid_flag_mask =
VK_PIPELINE_CREATE_2_NO_PROTECTED_ACCESS_BIT | VK_PIPELINE_CREATE_2_PROTECTED_ACCESS_ONLY_BIT |
VK_PIPELINE_CREATE_2_DISABLE_OPTIMIZATION_BIT | VK_PIPELINE_CREATE_2_DESCRIPTOR_BUFFER_BIT_EXT |
VK_PIPELINE_CREATE_2_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT | VK_PIPELINE_CREATE_2_EARLY_RETURN_ON_FAILURE_BIT;
if ((flags & VK_PIPELINE_CREATE_2_DESCRIPTOR_BUFFER_BIT_EXT) && !enabled_features.dataGraphDescriptorBuffer) {
skip |= LogError(
"VUID-VkDataGraphPipelineCreateInfoARM-dataGraphDescriptorBuffer-09885", device, flags_loc,
"(%s) includes VK_PIPELINE_CREATE_2_DESCRIPTOR_BUFFER_BIT_EXT but the dataGraphDescriptorBuffer feature is not enabled.",
string_VkPipelineCreateFlags2(flags).c_str());
}
if ((flags & ~(valid_flag_mask)) != 0) {
skip |= LogError("VUID-VkDataGraphPipelineCreateInfoARM-flags-09764", device, flags_loc, "(%s) contains invalid values.",
string_VkPipelineCreateFlags2(flags).c_str());
}
if (!enabled_features.pipelineProtectedAccess) {
if ((flags & VK_PIPELINE_CREATE_2_NO_PROTECTED_ACCESS_BIT_EXT) != 0 ||
(flags & VK_PIPELINE_CREATE_2_PROTECTED_ACCESS_ONLY_BIT_EXT) != 0) {
skip |= LogError(
"VUID-VkDataGraphPipelineCreateInfoARM-pipelineProtectedAccess-09772", device, flags_loc,
"(%s) must not contain VK_PIPELINE_CREATE_2_PROTECTED_ACCESS_ONLY_BIT_EXT or "
"VK_PIPELINE_CREATE_2_NO_PROTECTED_ACCESS_BIT_EXT because the pipelineProtectedAccess feature was not enabled.",
string_VkPipelineCreateFlags2(flags).c_str());
}
} else {
if ((flags & VK_PIPELINE_CREATE_2_NO_PROTECTED_ACCESS_BIT_EXT) != 0 &&
(flags & VK_PIPELINE_CREATE_2_PROTECTED_ACCESS_ONLY_BIT_EXT) != 0) {
skip |= LogError("VUID-VkDataGraphPipelineCreateInfoARM-flags-09773", device, flags_loc,
"(%s) must not contain both VK_PIPELINE_CREATE_2_PROTECTED_ACCESS_ONLY_BIT_EXT and "
"VK_PIPELINE_CREATE_2_NO_PROTECTED_ACCESS_BIT_EXT",
string_VkPipelineCreateFlags2(flags).c_str());
}
}
skip |= ValidatePipelineCacheControlFlags(flags, flags_loc,
"VUID-VkDataGraphPipelineCreateInfoARM-pipelineCreationCacheControl-09871");
return skip;
}
bool CoreChecks::ValidateTensorSemiStructuredSparsityInfo(VkDevice device, const VkDataGraphPipelineConstantARM& constant,
const Location& constant_loc, const vvl::Pipeline& pipeline) const {
bool skip = false;
const auto* sparsity =
vku::FindStructInPNextChain<VkDataGraphPipelineConstantTensorSemiStructuredSparsityInfoARM>(constant.pNext);
const auto* tensor_desc = vku::FindStructInPNextChain<VkTensorDescriptionARM>(constant.pNext);
while (sparsity) {
if (!tensor_desc) {
skip |= LogError("VUID-VkDataGraphPipelineConstantARM-pNext-09775", device,
constant_loc.pNext(Struct::VkDataGraphPipelineConstantTensorSemiStructuredSparsityInfoARM),
"exists but the pNext chain doesn't include a VkTensorDescriptionARM.\n%s",
PrintPNextChain(Struct::VkDataGraphPipelineConstantARM, constant.pNext).c_str());
} else if (sparsity->dimension >= tensor_desc->dimensionCount) {
skip |= LogError(
"VUID-VkDataGraphPipelineConstantARM-pNext-09776", device,
constant_loc.pNext(Struct::VkDataGraphPipelineConstantTensorSemiStructuredSparsityInfoARM, Field::dimension),
"(%" PRIu32 ") must be less than the tensor rank (dimensionCount = %" PRIu32 ")", sparsity->dimension,
tensor_desc->dimensionCount);
} else if (tensor_desc->pDimensions[sparsity->dimension] % sparsity->groupSize != 0) {
skip |= LogError("VUID-VkDataGraphPipelineConstantARM-pNext-09777", device,
constant_loc.pNext(Struct::VkDataGraphPipelineConstantTensorSemiStructuredSparsityInfoARM,
Field::pDimensions, sparsity->dimension),
"(%" PRIu64 ") must be a multiple of groupSize (%" PRIu32 ")",
tensor_desc->pDimensions[sparsity->dimension], sparsity->groupSize);
}
// We can have multiple Sparsity structures in the pNext chain.
sparsity = vku::FindStructInPNextChain<VkDataGraphPipelineConstantTensorSemiStructuredSparsityInfoARM>(sparsity->pNext);
}
return skip;
}
bool CoreChecks::PreCallValidateCreateDataGraphPipelinesARM(VkDevice device, VkDeferredOperationKHR deferredOperation,
VkPipelineCache pipelineCache, uint32_t createInfoCount,
const VkDataGraphPipelineCreateInfoARM* pCreateInfos,
const VkAllocationCallbacks* pAllocator, VkPipeline* pPipelines,
const ErrorObject& error_obj, PipelineStates& pipeline_states,
chassis::CreateDataGraphPipelinesARM& chassis_state) const {
bool skip = ValidateDeviceQueueSupport(error_obj.location);
if (!enabled_features.dataGraph) {
skip |= LogError("VUID-vkCreateDataGraphPipelinesARM-dataGraph-09760", device, error_obj.location,
"dataGraph feature is not enabled");
}
if (VK_NULL_HANDLE != deferredOperation) {
skip |= LogError("VUID-vkCreateDataGraphPipelinesARM-deferredOperation-09761", device, error_obj.location,
"deferredOperation must be VK_NULL_HANDLE");
}
for (uint32_t i = 0; i < createInfoCount; i++) {
const VkDataGraphPipelineCreateInfoARM& create_info = pCreateInfos[i];
const vvl::Pipeline* pipeline = pipeline_states[i].get();
ASSERT_AND_RETURN_SKIP(pipeline);
const Location create_info_loc = error_obj.location.dot(Field::pCreateInfos, i);
// three different ways to define a datagraph:
const auto* dg_shader_ci = vku::FindStructInPNextChain<VkDataGraphPipelineShaderModuleCreateInfoARM>(create_info.pNext);
const auto* dg_pipeline_identifier_ci =
vku::FindStructInPNextChain<VkDataGraphPipelineIdentifierCreateInfoARM>(create_info.pNext);
const auto* qcom_model_ci = vku::FindStructInPNextChain<VkDataGraphPipelineBuiltinModelCreateInfoQCOM>(create_info.pNext);
// 1 and ONLY 1 of them MUST be present
uint32_t defined_structs = (qcom_model_ci ? 1 : 0) + (dg_pipeline_identifier_ci ? 1 : 0) + (dg_shader_ci ? 1 : 0);
if (defined_structs != 1) {
skip |= LogError("VUID-VkDataGraphPipelineCreateInfoARM-pNext-09763", device, create_info_loc,
"%" PRIu32 " of the possible required structures are included in the pNext chain%s.\n%s",
defined_structs, (defined_structs > 1) ? " (only 1 is allowed)" : "",
PrintPNextChain(Struct::VkDataGraphPipelineCreateInfoARM, create_info.pNext).c_str());
}
if (dg_pipeline_identifier_ci || qcom_model_ci) {
if (!(create_info.flags & VK_PIPELINE_CREATE_2_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT)) {
skip |= LogError(
"VUID-VkDataGraphPipelineCreateInfoARM-None-11840", device, create_info_loc.dot(Field::flags),
"(%s) does not include VK_PIPELINE_CREATE_2_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT, but the pNext chain include one "
"of VkDataGraphPipelineIdentifierCreateInfoARM or VkDataGraphPipelineBuiltinModelCreateInfoQCOM.\n%s",
string_VkPipelineCreateFlags2(create_info.flags).c_str(),
PrintPNextChain(Struct::VkDataGraphPipelineCreateInfoARM, create_info.pNext).c_str());
}
if (create_info.pResourceInfos || create_info.resourceInfoCount) {
skip |= LogError(
"VUID-VkDataGraphPipelineCreateInfoARM-None-11841", device, create_info_loc,
"pResourceInfos (%p) is not NULL, or resourceInfoCount (%" PRIu32 ") is not 0, but the pNext chain include one of VkDataGraphPipelineIdentifierCreateInfoARM or VkDataGraphPipelineBuiltinModelCreateInfoQCOM.\n%s",
create_info.pResourceInfos, create_info.resourceInfoCount,
PrintPNextChain(Struct::VkDataGraphPipelineCreateInfoARM, create_info.pNext).c_str());
}
}
if (dg_shader_ci) {
// checks for datagraph defined via a shader module.
const Location dg_shader_ci_loc = create_info_loc.pNext(Struct::VkDataGraphPipelineShaderModuleCreateInfoARM);
if (!enabled_features.dataGraphShaderModule) {
skip |= LogError("VUID-VkDataGraphPipelineCreateInfoARM-dataGraphShaderModule-09886", device, dg_shader_ci_loc,
"is in the pNext chain, but the dataGraphShaderModule feature is not enabled.\n%s",
PrintPNextChain(Struct::VkDataGraphPipelineCreateInfoARM, create_info.pNext).c_str());
}
// 2 possible ways to pass the shader, 1 and ONLY 1 MUST be present:
// - VkShaderModuleCreateInfo (shader_module_ci), or
// - VkDataGraphPipelineShaderModuleCreateInfoARM::module (dg_shader_ci->module)
if (const auto* shader_module_ci = vku::FindStructInPNextChain<VkShaderModuleCreateInfo>(create_info.pNext)) {
if (dg_shader_ci->module) {
skip |= LogError("VUID-VkDataGraphPipelineShaderModuleCreateInfoARM-pNext-09873", device,
dg_shader_ci_loc.dot(Field::module),
"(%s) is not NULL but the pNext chain includes a VkShaderModuleCreateInfo.\n%s",
FormatHandle(dg_shader_ci->module).c_str(),
PrintPNextChain(Struct::VkDataGraphPipelineCreateInfoARM, create_info.pNext).c_str());
}
skip |= ValidateShaderModuleCreateInfo(*shader_module_ci, create_info_loc.pNext(Struct::VkShaderModuleCreateInfo));
} else if (!Get<vvl::ShaderModule>(dg_shader_ci->module)) {
// there is no shader module: both dg_shader_ci->module and shader_module_ci are NULL
skip |= LogError(
"VUID-VkDataGraphPipelineShaderModuleCreateInfoARM-pNext-09874", device, dg_shader_ci_loc.dot(Field::module),
"(%s) is not a valid VkShaderModule and the pNext chain doesn't include a VkShaderModuleCreateInfo.\n%s",
FormatHandle(dg_shader_ci->module).c_str(),
PrintPNextChain(Struct::VkDataGraphPipelineCreateInfoARM, create_info.pNext).c_str());
}
// remaining checks for shader module: create info and spirv
skip |= ValidateDataGraphPipelineShaderModuleCreateInfo(device, *dg_shader_ci, dg_shader_ci_loc, *pipeline);
skip |= ValidateDataGraphPipelineShaderModuleSpirv(device, create_info, create_info_loc, *dg_shader_ci, *pipeline);
} else if (dg_pipeline_identifier_ci) {
// TODO: add here validation for datagraph defined as cache object
} else if (qcom_model_ci) {
// TODO: add here validation for datagraph defined as QCOM model object
}
// common checks
skip |= ValidateDataGraphPipelineCreateInfo(device, create_info, create_info_loc, *pipeline);
skip |= ValidateDataGraphPipelineCreateInfoFlags(create_info.flags, create_info_loc.dot(Field::flags));
}
return skip;
}
bool CoreChecks::PreCallValidateGetDataGraphPipelinePropertiesARM(VkDevice device, const VkDataGraphPipelineInfoARM* pPipelineInfo,
uint32_t propertiesCount,
VkDataGraphPipelinePropertyQueryResultARM* pProperties,
const ErrorObject& error_obj) const {
bool skip = false;
const auto pipeline_ptr = Get<vvl::Pipeline>(pPipelineInfo->dataGraphPipeline);
ASSERT_AND_RETURN_SKIP(pipeline_ptr);
if (VK_STRUCTURE_TYPE_DATA_GRAPH_PIPELINE_CREATE_INFO_ARM != pipeline_ptr->GetCreateInfoSType()) {
skip |= LogError("VUID-VkDataGraphPipelineInfoARM-dataGraphPipeline-09803", device,
error_obj.location.dot(Field::dataGraphPipeline),
"was not created with vkCreateDataGraphPipelinesARM. The create info structure type was %s",
string_VkStructureType(pipeline_ptr->GetCreateInfoSType()));
}
return skip;
}
bool CoreChecks::PreCallValidateCreateDataGraphPipelineSessionARM(VkDevice device,
const VkDataGraphPipelineSessionCreateInfoARM* pCreateInfo,
const VkAllocationCallbacks* pAllocator,
VkDataGraphPipelineSessionARM* pSession,
const ErrorObject& error_obj) const {
bool skip = false;
const auto pipeline_ptr = Get<vvl::Pipeline>(pCreateInfo->dataGraphPipeline);
ASSERT_AND_RETURN_SKIP(pipeline_ptr);
if (VK_STRUCTURE_TYPE_DATA_GRAPH_PIPELINE_CREATE_INFO_ARM != pipeline_ptr->GetCreateInfoSType()) {
skip |= LogError("VUID-VkDataGraphPipelineSessionCreateInfoARM-dataGraphPipeline-09781", device,
error_obj.location.dot(Field::dataGraphPipeline),
"was not created with vkCreateDataGraphPipelinesARM. The create info structure type was %s",
string_VkStructureType(pipeline_ptr->GetCreateInfoSType()));
return skip; // no point continuing if the pipeline isn't valid
}
if ((pCreateInfo->flags & VK_DATA_GRAPH_PIPELINE_SESSION_CREATE_PROTECTED_BIT_ARM) != 0) {
if (!enabled_features.protectedMemory) {
skip |= LogError("VUID-VkDataGraphPipelineSessionCreateInfoARM-protectedMemory-09782", device,
error_obj.location.dot(Field::dataGraphPipeline).dot(Field::flags),
"(%s) contains VK_DATA_GRAPH_PIPELINE_SESSION_CREATE_PROTECTED_BIT_ARM but the protectedMemory "
"feature is not enabled",
string_VkDataGraphPipelineSessionCreateFlagsARM(pCreateInfo->flags).c_str());
}
}
return skip;
}
void CoreChecks::PostCallRecordGetDataGraphPipelineSessionBindPointRequirementsARM(
VkDevice device, const VkDataGraphPipelineSessionBindPointRequirementsInfoARM* pInfo, uint32_t* pBindPointRequirementCount,
VkDataGraphPipelineSessionBindPointRequirementARM* pBindPointRequirements, const RecordObject& record_obj) {
if (record_obj.result != VK_SUCCESS) {
return;
}
if (auto session_ptr = Get<vvl::DataGraphPipelineSession>(pInfo->session)){
if (pBindPointRequirements) {
session_ptr->InitMemoryRequirements(device, pBindPointRequirements, *pBindPointRequirementCount);
}
}
}
bool CoreChecks::PreCallValidateGetDataGraphPipelineSessionMemoryRequirementsARM(
VkDevice device, const VkDataGraphPipelineSessionMemoryRequirementsInfoARM* pInfo, VkMemoryRequirements2* pMemoryRequirements,
const ErrorObject& error_obj) const {
bool skip = false;
auto session_ptr = Get<vvl::DataGraphPipelineSession>(pInfo->session);
ASSERT_AND_RETURN_SKIP(session_ptr);
auto& session = *session_ptr;
const Location pinfo_loc = error_obj.location.dot(Field::pInfo);
if (auto bpr = session.FindBindPointRequirement(pInfo->bindPoint)) {
if (VK_DATA_GRAPH_PIPELINE_SESSION_BIND_POINT_TYPE_MEMORY_ARM != bpr->bindPointType) {
skip |= LogError("VUID-vkGetDataGraphPipelineSessionMemoryRequirementsARM-bindPoint-09784", device,
pinfo_loc.dot(Field::bindPoint),
"%s has type %s, expected VK_DATA_GRAPH_PIPELINE_SESSION_BIND_POINT_TYPE_MEMORY_ARM",
string_VkDataGraphPipelineSessionBindPointARM(pInfo->bindPoint),
string_VkDataGraphPipelineSessionBindPointTypeARM(bpr->bindPointType));
}
if (pInfo->objectIndex >= bpr->numObjects) {
skip |= LogError(
"VUID-VkDataGraphPipelineSessionMemoryRequirementsInfoARM-objectIndex-09855", device,
pinfo_loc.dot(Field::objectIndex),
"(%" PRIu32
") must be less than the number of objects returned by vkGetDataGraphPipelineSessionBindPointRequirementsARM via "
"VkDataGraphPipelineSessionBindPointRequirementARM::numObjects (%" PRIu32
") with VkDataGraphPipelineSessionMemoryRequirementsInfoARM::bindPoint equal to (%s)",
pInfo->objectIndex, bpr->numObjects, string_VkDataGraphPipelineSessionBindPointARM(pInfo->bindPoint));
}
} else {
skip |= LogError("VUID-vkGetDataGraphPipelineSessionMemoryRequirementsARM-bindPoint-09784", device,
pinfo_loc.dot(Field::bindPoint), "(%s) not found in session memory requirements",
string_VkDataGraphPipelineSessionBindPointARM(pInfo->bindPoint));
}
return skip;
}
bool CoreChecks::PreCallValidateDestroyDataGraphPipelineSessionARM(VkDevice device, VkDataGraphPipelineSessionARM session,
const VkAllocationCallbacks* pAllocator,
const ErrorObject& error_obj) const {
bool skip = false;
if (auto session_state = Get<vvl::DataGraphPipelineSession>(session)) {
skip |= ValidateObjectNotInUse(session_state.get(), error_obj.location,
"VUID-vkDestroyDataGraphPipelineSessionARM-session-09793");
}
return skip;
}
bool CoreChecks::PreCallValidateCmdDispatchDataGraphARM(VkCommandBuffer commandBuffer, VkDataGraphPipelineSessionARM session,
const VkDataGraphPipelineDispatchInfoARM *pInfo, const ErrorObject& error_obj) const {
bool skip = false;
const auto& cb_state = *GetRead<vvl::CommandBuffer>(commandBuffer);
const auto &last_bound_state = cb_state.GetLastBoundDataGraph();
const vvl::DrawDispatchVuid &dispatch_vuid = GetDrawDispatchVuid(error_obj.location.function);
skip |= ValidateActionState(last_bound_state, dispatch_vuid);
const auto session_state_ptr = Get<vvl::DataGraphPipelineSession>(session);
ASSERT_AND_RETURN_SKIP(session_state_ptr);
const auto& session_state = *session_state_ptr;
const auto& bound_memory_map = session_state.BoundMemoryMap();
const LogObjectList& objlist = LogObjectList(commandBuffer, session);
for (const auto& bpr : session_state.BindPointReqs()) {
/* bpr: requirement; bound_memory_map: actually bound */
size_t n_bound = bound_memory_map.find(bpr.bindPoint) == bound_memory_map.end() ? 0 : bound_memory_map.at(bpr.bindPoint).size();
if (bpr.numObjects != n_bound) {
skip |= LogError("VUID-vkCmdDispatchDataGraphARM-session-09796", objlist, error_obj.location,
"%zu objects bound at bind point %s, required numObjects %" PRIu32 "; session %s.", n_bound,
string_VkDataGraphPipelineSessionBindPointARM(bpr.bindPoint), bpr.numObjects,
FormatHandle(session_state).c_str());
}
if (n_bound > 0) {
for (const auto& binding : bound_memory_map.at(bpr.bindPoint)) {
skip |= VerifyBoundMemoryIsValid(binding.memory_state.get(), objlist, session_state.Handle(), error_obj.location,
"VUID-vkCmdDispatchDataGraphARM-session-09796");
}
}
}
return skip;
}
|
