1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983
|
/* Copyright (c) 2015-2025 The Khronos Group Inc.
* Copyright (c) 2015-2025 Valve Corporation
* Copyright (c) 2015-2025 LunarG, Inc.
* Copyright (C) 2015-2025 Google Inc.
* Copyright (c) 2025 Arm Limited.
* Modifications Copyright (C) 2020-2022 Advanced Micro Devices, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <assert.h>
#include <sstream>
#include <string>
#include <vulkan/utility/vk_format_utils.h>
#include <vulkan/vulkan_core.h>
#include "generated/pnext_chain_extraction.h"
#include "core_validation.h"
#include "cc_buffer_address.h"
#include "state_tracker/image_state.h"
#include "state_tracker/tensor_state.h"
#include "state_tracker/buffer_state.h"
#include "state_tracker/ray_tracing_state.h"
#include "state_tracker/wsi_state.h"
#include "error_message/error_strings.h"
#include "utils/image_utils.h"
#include "utils/math_utils.h"
#include "state_tracker/data_graph_pipeline_session_state.h"
#include "state_tracker/cmd_buffer_state.h"
#include "containers/container_utils.h"
// For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value.
bool CoreChecks::VerifyBoundMemoryIsValid(const vvl::DeviceMemory *memory_state, const LogObjectList &objlist,
const VulkanTypedHandle &typed_handle, const Location &loc, const char *vuid) const {
bool skip = false;
if (!memory_state) {
const char *type_name = string_VulkanObjectType(typed_handle.type);
skip |=
LogError(vuid, objlist, loc, "(%s) is used with no memory bound. Memory should be bound by calling vkBind%sMemory().",
FormatHandle(typed_handle).c_str(), type_name + 2);
} else if (memory_state->Destroyed()) {
skip |= LogError(vuid, objlist, loc,
"(%s) is used, but bound memory was freed. Memory must not be freed prior to this operation.",
FormatHandle(typed_handle).c_str());
}
return skip;
}
bool CoreChecks::VerifyBoundMemoryIsDeviceVisible(const vvl::DeviceMemory *memory_state, const LogObjectList &objlist,
const VulkanTypedHandle &typed_handle, const Location &loc,
const char *vuid) const {
bool result = false;
if (memory_state) {
if ((phys_dev_mem_props.memoryTypes[memory_state->allocate_info.memoryTypeIndex].propertyFlags &
VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) == 0) {
result |= LogError(vuid, objlist, loc, "(%s) used with memory that is not device visible.",
FormatHandle(typed_handle).c_str());
}
}
return result;
}
// Check to see if memory was ever bound to this image
bool CoreChecks::ValidateMemoryIsBoundToImage(const LogObjectList &objlist, const vvl::Image &image_state, const Location &loc,
const char *vuid) const {
bool result = false;
if (image_state.create_from_swapchain != VK_NULL_HANDLE) {
if (!image_state.bind_swapchain) {
result |= LogError(
vuid, objlist, loc,
"(%s) is created by %s, and the image should be bound by calling vkBindImageMemory2(), and the pNext chain "
"includes VkBindImageMemorySwapchainInfoKHR.",
FormatHandle(image_state).c_str(), FormatHandle(image_state.create_from_swapchain).c_str());
} else if (image_state.create_from_swapchain != image_state.bind_swapchain->VkHandle()) {
result |=
LogError(vuid, objlist, loc,
"(%s) is created by %s, but the image is bound by %s. The image should be created and bound by the same "
"swapchain",
FormatHandle(image_state).c_str(), FormatHandle(image_state.create_from_swapchain).c_str(),
FormatHandle(image_state.bind_swapchain->Handle()).c_str());
}
} else if (image_state.IsExternalBuffer()) {
// TODO look into how to properly check for a valid bound memory for an external AHB
} else if (!image_state.sparse) {
// No need to optimize this since the size will only be 3 at most
const auto &memory_states = image_state.GetBoundMemoryStates();
if (memory_states.empty()) {
result |=
LogError(vuid, objlist, loc, "%s used with no memory bound. Memory should be bound by calling vkBindImageMemory().",
FormatHandle(image_state).c_str());
} else {
for (const auto &state : memory_states) {
result |= VerifyBoundMemoryIsValid(state.get(), objlist, image_state.Handle(), loc, vuid);
}
}
}
return result;
}
bool CoreChecks::ValidateMemoryIsBoundToTensor(const LogObjectList &objlist, const vvl::Tensor &tensor_state, const Location &loc,
const char *vuid) const {
bool result = false;
const auto &memory_states = tensor_state.GetBoundMemoryStates();
if (memory_states.empty()) {
result |= LogError(vuid, objlist, loc, "has no memory bound. Memory should be bound by calling vkBindTensorMemory().");
} else {
for (const auto &state : memory_states) {
result |= VerifyBoundMemoryIsValid(state.get(), objlist, tensor_state.Handle(), loc, vuid);
}
if (!tensor_state.sparse) {
if (memory_states.size() > 1) {
result |= LogError(vuid, objlist, loc, "is non-sparse and bound to %zu memory allocations.", memory_states.size());
}
}
}
return result;
}
bool CoreChecks::ValidateAccelStructsMemoryDoNotOverlap(const Location &function_loc, LogObjectList objlist,
const vvl::AccelerationStructureKHR &accel_struct_a, const Location &loc_a,
const vvl::AccelerationStructureKHR &accel_struct_b, const Location &loc_b,
const char *vuid) const {
bool skip = false;
const vvl::Buffer &buffer_a = *accel_struct_a.buffer_state;
const vvl::Buffer &buffer_b = *accel_struct_b.buffer_state;
const vvl::range<VkDeviceSize> range_a(accel_struct_a.create_info.offset, accel_struct_a.create_info.size);
const vvl::range<VkDeviceSize> range_b(accel_struct_b.create_info.offset, accel_struct_b.create_info.size);
if (const auto [memory, overlap_range] = buffer_a.GetResourceMemoryOverlap(range_a, &buffer_b, range_b);
memory != VK_NULL_HANDLE) {
objlist.add(accel_struct_a.Handle(), buffer_a.Handle(), accel_struct_b.Handle(), buffer_b.Handle());
skip |= LogError(vuid, objlist, function_loc,
"memory backing buffer (%s) used as storage for %s (%s) overlaps memory backing buffer (%s) used as "
"storage for %s (%s). Overlapped memory is (%s) on range %s.",
FormatHandle(buffer_a).c_str(), loc_a.Fields().c_str(), FormatHandle(accel_struct_a.Handle()).c_str(),
FormatHandle(buffer_b).c_str(), loc_b.Fields().c_str(), FormatHandle(accel_struct_b.Handle()).c_str(),
FormatHandle(memory).c_str(), string_range_hex(overlap_range).c_str());
}
return skip;
}
// Check to see if host-visible memory was bound to this buffer
bool CoreChecks::ValidateAccelStructBufferMemoryIsHostVisible(const vvl::AccelerationStructureKHR &accel_struct,
const Location &buffer_loc, const char *vuid) const {
bool result = false;
result |= ValidateMemoryIsBoundToBuffer(device, *accel_struct.buffer_state, buffer_loc, vuid);
if (!result) {
if (const auto memory_state = accel_struct.buffer_state->MemoryState()) {
if ((phys_dev_mem_props.memoryTypes[memory_state->allocate_info.memoryTypeIndex].propertyFlags &
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) {
const LogObjectList objlist(accel_struct.Handle(), accel_struct.buffer_state->Handle(), memory_state->Handle());
result |=
LogError(vuid, objlist, buffer_loc, "has been created with a buffer whose bound memory is not host visible.");
}
}
}
return result;
}
bool CoreChecks::ValidateAccelStructBufferMemoryIsNotMultiInstance(const vvl::AccelerationStructureKHR &accel_struct,
const Location &accel_struct_loc, const char *vuid) const {
bool skip = false;
if (const vvl::DeviceMemory *memory_state = accel_struct.buffer_state->MemoryState()) {
if (memory_state->multi_instance) {
const LogObjectList objlist(accel_struct.Handle(), accel_struct.buffer_state->Handle(), memory_state->Handle());
skip |= LogError(vuid, objlist, accel_struct_loc,
"has been created with a buffer bound to memory (%s) that was allocated with multiple instances.",
FormatHandle(memory_state->Handle()).c_str());
}
}
return skip;
}
// Valid usage checks for a call to SetMemBinding().
// For NULL mem case, output warning
// Make sure given object is in global object map
// IF a previous binding existed, output validation error
// Otherwise, add reference from objectInfo to memoryInfo
// Add reference off of objInfo
bool CoreChecks::ValidateSetMemBinding(const vvl::DeviceMemory &memory_state, const vvl::Bindable &mem_binding,
const Location &loc) const {
bool skip = false;
const bool bind_2 = (loc.function != Func::vkBindBufferMemory) && (loc.function != Func::vkBindImageMemory);
auto typed_handle = mem_binding.Handle();
const bool is_buffer = typed_handle.type == kVulkanObjectTypeBuffer;
const bool is_image = typed_handle.type == kVulkanObjectTypeImage;
const bool is_tensor = typed_handle.type == kVulkanObjectTypeTensorARM;
if (mem_binding.sparse) {
const char *vuid = kVUIDUndefined;
const char *handle_type = is_buffer ? "BUFFER" : is_image ? "IMAGE" : "TENSOR";
if (is_buffer) {
vuid = bind_2 ? "VUID-VkBindBufferMemoryInfo-buffer-01030" : "VUID-vkBindBufferMemory-buffer-01030";
} else if (is_image) {
vuid = bind_2 ? "VUID-VkBindImageMemoryInfo-image-01045" : "VUID-vkBindImageMemory-image-01045";
} else {
/* only buffer and image can be sparse */
assert(false);
}
const LogObjectList objlist(memory_state.Handle(), typed_handle);
skip |= LogError(vuid, objlist, loc,
"attempting to bind %s to %s which was created with sparse memory flags "
"(VK_%s_CREATE_SPARSE_*_BIT).",
FormatHandle(memory_state.Handle()).c_str(), FormatHandle(typed_handle).c_str(), handle_type);
}
const auto *prev_binding = mem_binding.MemoryState();
if (prev_binding || mem_binding.indeterminate_state) {
const char *vuid = kVUIDUndefined;
if (is_buffer) {
vuid = bind_2 ? "VUID-VkBindBufferMemoryInfo-buffer-07459" : "VUID-vkBindBufferMemory-buffer-07459";
} else if (is_image) {
vuid = bind_2 ? "VUID-VkBindImageMemoryInfo-image-07460" : "VUID-vkBindImageMemory-image-07460";
} else if (is_tensor) {
vuid = "VUID-VkBindTensorMemoryInfoARM-tensor-09712";
}
if (mem_binding.indeterminate_state) {
Func bind_call = is_buffer ? Func::vkBindBufferMemory2
: is_image ? Func::vkBindImageMemory2
: Func::vkBindTensorMemoryARM;
const char *handle_type = is_buffer ? "buffer" : is_image ? "image" : "tensor";
const LogObjectList objlist(memory_state.Handle(), typed_handle);
skip |= LogError(
vuid, objlist, loc,
"attempting to bind %s to %s which is in an indeterminate (possibly bound) state. A previous call to %s failed and "
"we have to assume the %s was bound (but best advise is to handle the case and recreate the %s).",
FormatHandle(memory_state.Handle()).c_str(), FormatHandle(typed_handle).c_str(), String(bind_call), handle_type,
handle_type);
} else {
const LogObjectList objlist(memory_state.Handle(), typed_handle, prev_binding->Handle());
skip |= LogError(vuid, objlist, loc, "attempting to bind %s to %s which has already been bound to %s.",
FormatHandle(memory_state.Handle()).c_str(), FormatHandle(typed_handle).c_str(),
FormatHandle(prev_binding->Handle()).c_str());
}
}
return skip;
}
bool CoreChecks::IgnoreAllocationSize(const VkMemoryAllocateInfo &allocate_info) const {
#ifdef VK_USE_PLATFORM_WIN32_KHR
const VkExternalMemoryHandleTypeFlags ignored_allocation = VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_BIT |
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_KMT_BIT |
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_RESOURCE_BIT;
const auto import_memory_win32 = vku::FindStructInPNextChain<VkImportMemoryWin32HandleInfoKHR>(allocate_info.pNext);
if (import_memory_win32 && (import_memory_win32->handleType & ignored_allocation) != 0) {
return true;
}
#elif VK_USE_PLATFORM_METAL_EXT
const VkExternalMemoryHandleTypeFlags ignored_allocation = VK_EXTERNAL_MEMORY_HANDLE_TYPE_MTLBUFFER_BIT_EXT |
VK_EXTERNAL_MEMORY_HANDLE_TYPE_MTLTEXTURE_BIT_EXT |
VK_EXTERNAL_MEMORY_HANDLE_TYPE_MTLHEAP_BIT_EXT;
const auto import_memory_metal = vku::FindStructInPNextChain<VkImportMemoryMetalHandleInfoEXT>(allocate_info.pNext);
if (import_memory_metal && (import_memory_metal->handleType & ignored_allocation) != 0) {
return true;
}
#endif // VK_USE_PLATFORM_METAL_EXT
// Handles 01874 cases
const auto export_info = vku::FindStructInPNextChain<VkExportMemoryAllocateInfo>(allocate_info.pNext);
if (export_info && (export_info->handleTypes & VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID)) {
const auto dedicated_info = vku::FindStructInPNextChain<VkMemoryDedicatedAllocateInfo>(allocate_info.pNext);
if (dedicated_info && dedicated_info->image) {
return true;
}
}
return false;
}
bool CoreChecks::HasExternalMemoryImportSupport(const vvl::Buffer &buffer, VkExternalMemoryHandleTypeFlagBits handle_type) const {
VkPhysicalDeviceExternalBufferInfo info = vku::InitStructHelper();
info.flags = buffer.create_info.flags;
// TODO - Add VkBufferUsageFlags2CreateInfo support
info.usage = buffer.create_info.usage;
info.handleType = handle_type;
VkExternalBufferProperties properties = vku::InitStructHelper();
DispatchGetPhysicalDeviceExternalBufferPropertiesHelper(api_version, physical_device, &info, &properties);
return (properties.externalMemoryProperties.externalMemoryFeatures & VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT) != 0;
}
bool CoreChecks::HasExternalMemoryImportSupport(const vvl::Image &image, VkExternalMemoryHandleTypeFlagBits handle_type) const {
VkPhysicalDeviceExternalImageFormatInfo external_info = vku::InitStructHelper();
external_info.handleType = handle_type;
VkPhysicalDeviceImageFormatInfo2 info = vku::InitStructHelper(&external_info);
info.format = image.create_info.format;
info.type = image.create_info.imageType;
info.tiling = image.create_info.tiling;
info.usage = image.create_info.usage;
info.flags = image.create_info.flags;
// TODO - Want to use vvl::PnextChainExtract, but would need to cleanup (and test) rest of how we add the other pNext here
// Note - some pNext structs that can be found in VkImageCreateInfo::pNext are not allowed in VkPhysicalDeviceImageFormatInfo2
VkImageFormatListCreateInfo format_list = vku::InitStructHelper();
if (auto original_format_list = vku::FindStructInPNextChain<VkImageFormatListCreateInfo>(image.create_info.pNext)) {
format_list.pViewFormats = original_format_list->pViewFormats;
format_list.viewFormatCount = original_format_list->viewFormatCount;
vvl::PnextChainAdd(&external_info, &format_list);
}
VkImageStencilUsageCreateInfo stencil_usage = vku::InitStructHelper();
if (auto original_stencil_usage = vku::FindStructInPNextChain<VkImageStencilUsageCreateInfo>(image.create_info.pNext)) {
stencil_usage.stencilUsage = original_stencil_usage->stencilUsage;
vvl::PnextChainAdd(&external_info, &stencil_usage);
}
VkPhysicalDeviceImageViewImageFormatInfoEXT image_view_format = vku::InitStructHelper();
if (auto original_image_view_format =
vku::FindStructInPNextChain<VkPhysicalDeviceImageViewImageFormatInfoEXT>(image.create_info.pNext)) {
image_view_format.imageViewType = original_image_view_format->imageViewType;
vvl::PnextChainAdd(&external_info, &image_view_format);
}
VkExternalImageFormatProperties external_properties = vku::InitStructHelper();
VkImageFormatProperties2 properties = vku::InitStructHelper(&external_properties);
if (image.create_info.tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
// Can't get into function with using external memory extensions which require GPDP2
if (DispatchGetPhysicalDeviceImageFormatProperties2Helper(api_version, physical_device, &info, &properties) != VK_SUCCESS) {
return false;
}
} else {
VkPhysicalDeviceImageDrmFormatModifierInfoEXT drm_format_modifier = vku::InitStructHelper();
drm_format_modifier.sharingMode = image.create_info.sharingMode;
drm_format_modifier.queueFamilyIndexCount = image.create_info.queueFamilyIndexCount;
drm_format_modifier.pQueueFamilyIndices = image.create_info.pQueueFamilyIndices;
vvl::PnextChainScopedAdd scoped_add_drm_fmt_mod(&info, &drm_format_modifier);
VkImageDrmFormatModifierPropertiesEXT drm_format_properties = vku::InitStructHelper();
if (DispatchGetImageDrmFormatModifierPropertiesEXT(device, image.VkHandle(), &drm_format_properties) != VK_SUCCESS) {
return false;
}
drm_format_modifier.drmFormatModifier = drm_format_properties.drmFormatModifier;
if (DispatchGetPhysicalDeviceImageFormatProperties2Helper(api_version, physical_device, &info, &properties) != VK_SUCCESS) {
return false;
}
}
return (external_properties.externalMemoryProperties.externalMemoryFeatures & VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT) != 0;
}
bool CoreChecks::HasExternalMemoryImportSupport(const vvl::Tensor &tensor, VkExternalMemoryHandleTypeFlagBits handle_type) const {
VkPhysicalDeviceExternalTensorInfoARM info = vku::InitStructHelper();
info.flags = tensor.create_info.flags;
info.handleType = handle_type;
VkExternalTensorPropertiesARM properties = vku::InitStructHelper();
dispatch_instance_->GetPhysicalDeviceExternalTensorPropertiesARM(physical_device, &info, &properties);
return (properties.externalMemoryProperties.externalMemoryFeatures & VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT) != 0;
}
bool CoreChecks::PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory,
const ErrorObject &error_obj) const {
bool skip = false;
if (Count<vvl::DeviceMemory>() >= phys_dev_props.limits.maxMemoryAllocationCount) {
skip |=
LogError("VUID-vkAllocateMemory-maxMemoryAllocationCount-04101", device, error_obj.location,
"The number of currently valid memory objects (%zu) is not less than maxMemoryAllocationCount (%" PRIu32 ").",
Count<vvl::DeviceMemory>(), phys_dev_props.limits.maxMemoryAllocationCount);
}
const Location allocate_info_loc = error_obj.location.dot(Field::pAllocateInfo);
if (IsExtEnabled(extensions.vk_khr_maintenance3) &&
pAllocateInfo->allocationSize > phys_dev_props_core11.maxMemoryAllocationSize) {
// Discussed in https://gitlab.khronos.org/vulkan/vulkan/-/issues/4119 and finalized in
// https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/7073 This is a limit the Working Group feels should be alerted
// to the user as if it was a VU. While some drivers should report VK_ERROR_OUT_OF_DEVICE_MEMORY, each platform has small
// quirks to it and there is no way for us to test the drivers will return the correct VkError here.
LogError("UNASSIGNED-vkAllocateMemory-maxMemoryAllocationSize", device, allocate_info_loc.dot(Field::allocationSize),
"(%" PRIu64 ") is larger than maxMemoryAllocationSize (%" PRIu64
"). While this might work locally on your machine, there are many external factors each platform has that is used "
"to determine this limit. You should receive VK_ERROR_OUT_OF_DEVICE_MEMORY from this call, but even if you do "
"not, it is highly advised from all hardware vendors to not ignore this limit.",
pAllocateInfo->allocationSize, phys_dev_props_core11.maxMemoryAllocationSize);
}
if (IsExtEnabled(extensions.vk_android_external_memory_android_hardware_buffer)) {
skip |= ValidateAllocateMemoryANDROID(*pAllocateInfo, allocate_info_loc);
} else {
if (!IgnoreAllocationSize(*pAllocateInfo) && 0 == pAllocateInfo->allocationSize) {
skip |= LogError("VUID-VkMemoryAllocateInfo-allocationSize-07899", device, allocate_info_loc.dot(Field::allocationSize),
"is 0.");
}
}
auto chained_flags_struct = vku::FindStructInPNextChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
const VkMemoryAllocateFlags memory_allocate_flags = chained_flags_struct ? chained_flags_struct->flags : 0;
if (memory_allocate_flags & VK_MEMORY_ALLOCATE_DEVICE_MASK_BIT) {
skip |= ValidateDeviceMaskToPhysicalDeviceCount(
chained_flags_struct->deviceMask, device, allocate_info_loc.pNext(Struct::VkMemoryAllocateFlagsInfo, Field::deviceMask),
"VUID-VkMemoryAllocateFlagsInfo-deviceMask-00675");
skip |= ValidateDeviceMaskToZero(chained_flags_struct->deviceMask, device,
allocate_info_loc.pNext(Struct::VkMemoryAllocateFlagsInfo, Field::deviceMask),
"VUID-VkMemoryAllocateFlagsInfo-deviceMask-00676");
}
if (memory_allocate_flags & VK_MEMORY_ALLOCATE_ZERO_INITIALIZE_BIT_EXT) {
const auto import_handle_type = vvl::GetImportHandleType(*pAllocateInfo);
if (import_handle_type.has_value()) {
skip |= LogError("VUID-VkMemoryAllocateFlagsInfo-flags-10760", device,
allocate_info_loc.pNext(Struct::VkMemoryAllocateFlagsInfo, Field::flags),
"contains VK_MEMORY_ALLOCATE_ZERO_INITIALIZE_BIT_EXT, but also trying to import memory from %s.",
string_VkExternalMemoryHandleTypeFlagBits(*import_handle_type));
}
}
if (pAllocateInfo->memoryTypeIndex >= phys_dev_mem_props.memoryTypeCount) {
skip |= LogError("VUID-vkAllocateMemory-pAllocateInfo-01714", device, allocate_info_loc.dot(Field::memoryTypeIndex),
"%" PRIu32 " is not a valid index. Device only advertises %" PRIu32 " memory types.",
pAllocateInfo->memoryTypeIndex, phys_dev_mem_props.memoryTypeCount);
} else {
const VkMemoryType memory_type = phys_dev_mem_props.memoryTypes[pAllocateInfo->memoryTypeIndex];
if (!IgnoreAllocationSize(*pAllocateInfo) &&
pAllocateInfo->allocationSize > phys_dev_mem_props.memoryHeaps[memory_type.heapIndex].size) {
skip |= LogError("VUID-vkAllocateMemory-pAllocateInfo-01713", device, allocate_info_loc.dot(Field::allocationSize),
"is %" PRIu64 " bytes from heap %" PRIu32 ",but size of that heap is only %" PRIu64 " bytes.",
pAllocateInfo->allocationSize, memory_type.heapIndex,
phys_dev_mem_props.memoryHeaps[memory_type.heapIndex].size);
}
if (!enabled_features.deviceCoherentMemory &&
((memory_type.propertyFlags & VK_MEMORY_PROPERTY_DEVICE_COHERENT_BIT_AMD) != 0)) {
skip |= LogError(
"VUID-vkAllocateMemory-deviceCoherentMemory-02790", device, allocate_info_loc.dot(Field::memoryTypeIndex),
"%" PRIu32
" includes the VK_MEMORY_PROPERTY_DEVICE_COHERENT_BIT_AMD memory property, but the deviceCoherentMemory feature "
"is not enabled.",
pAllocateInfo->memoryTypeIndex);
}
if (memory_type.propertyFlags & VK_MEMORY_PROPERTY_PROTECTED_BIT) {
if (!enabled_features.protectedMemory) {
skip |= LogError("VUID-VkMemoryAllocateInfo-memoryTypeIndex-01872", device,
allocate_info_loc.dot(Field::memoryTypeIndex),
"%" PRIu32
" includes the VK_MEMORY_PROPERTY_PROTECTED_BIT memory property, but the protectedMemory feature "
"is not enabled.",
pAllocateInfo->memoryTypeIndex);
}
if (memory_allocate_flags & VK_MEMORY_ALLOCATE_ZERO_INITIALIZE_BIT_EXT) {
skip |= LogError("VUID-VkMemoryAllocateFlagsInfo-flags-10761", device,
allocate_info_loc.pNext(Struct::VkMemoryAllocateFlagsInfo, Field::flags),
"contains VK_MEMORY_ALLOCATE_ZERO_INITIALIZE_BIT_EXT, but this memory type contains "
"VK_MEMORY_PROPERTY_PROTECTED_BIT and you can't zero initialize protected memory.");
}
}
}
bool imported_ahb_buffer = false;
bool imported_qnx_buffer = false;
#if defined(VK_USE_PLATFORM_ANDROID_KHR)
// "memory is not an imported Android Hardware Buffer" refers to VkImportAndroidHardwareBufferInfoANDROID with a non-NULL
// buffer value. Memory imported has another VUID to check size and allocationSize match up
if (auto imported_ahb_info = vku::FindStructInPNextChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
imported_ahb_info != nullptr) {
imported_ahb_buffer = imported_ahb_info->buffer != nullptr;
}
#endif // VK_USE_PLATFORM_ANDROID_KHR
#if defined(VK_USE_PLATFORM_SCREEN_QNX)
// "memory is not an imported QNX Screen Buffer" refers to VkImportScreenBufferInfoQNX with a non-NULL
// buffer value. Memory imported has another VUID to check size and allocationSize match up
if (auto imported_buffer_info = vku::FindStructInPNextChain<VkImportScreenBufferInfoQNX>(pAllocateInfo->pNext);
imported_buffer_info != nullptr) {
imported_qnx_buffer = imported_buffer_info->buffer != nullptr;
}
#endif // VK_USE_PLATFORM_SCREEN_QNX
const bool is_external_memory = imported_ahb_buffer || imported_qnx_buffer;
VkBuffer dedicated_buffer = VK_NULL_HANDLE;
VkImage dedicated_image = VK_NULL_HANDLE;
auto dedicated_allocate_info = vku::FindStructInPNextChain<VkMemoryDedicatedAllocateInfo>(pAllocateInfo->pNext);
if (dedicated_allocate_info) {
dedicated_buffer = dedicated_allocate_info->buffer;
dedicated_image = dedicated_allocate_info->image;
if ((dedicated_buffer != VK_NULL_HANDLE) && (dedicated_image != VK_NULL_HANDLE)) {
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01432", device, allocate_info_loc,
"pNext<VkMemoryDedicatedAllocateInfo> buffer (%s) or image (%s) has to be VK_NULL_HANDLE.",
FormatHandle(dedicated_buffer).c_str(), FormatHandle(dedicated_image).c_str());
} else if (dedicated_image != VK_NULL_HANDLE) {
// Dedicated VkImage
const LogObjectList objlist(device, dedicated_image);
const Location image_loc = allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::image);
auto image_state = Get<vvl::Image>(dedicated_image);
ASSERT_AND_RETURN_SKIP(image_state);
if (image_state->disjoint == true) {
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01797", objlist, image_loc,
"(%s) was created with VK_IMAGE_CREATE_DISJOINT_BIT.", FormatHandle(dedicated_image).c_str());
} else {
if (!IgnoreAllocationSize(*pAllocateInfo) && !is_external_memory &&
(pAllocateInfo->allocationSize < image_state->requirements[0].size)) {
skip |= LogError(
"VUID-VkMemoryDedicatedAllocateInfo-image-02964", objlist, allocate_info_loc.dot(Field::allocationSize),
"(%" PRIu64 ") needs to be greater than or equal to %s (%s) VkMemoryRequirements::size (%" PRIu64 ").",
pAllocateInfo->allocationSize, image_loc.Fields().c_str(), FormatHandle(dedicated_image).c_str(),
image_state->requirements[0].size);
}
if ((image_state->create_info.flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != 0) {
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01434", objlist, image_loc,
"(%s): was created with VK_IMAGE_CREATE_SPARSE_BINDING_BIT.",
FormatHandle(dedicated_image).c_str());
}
}
} else if (dedicated_buffer != VK_NULL_HANDLE) {
// Dedicated VkBuffer
const LogObjectList objlist(device, dedicated_buffer);
const Location buffer_loc = allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::buffer);
if (auto buffer_state = Get<vvl::Buffer>(dedicated_buffer)) {
if (!IgnoreAllocationSize(*pAllocateInfo) && !is_external_memory &&
(pAllocateInfo->allocationSize < buffer_state->requirements.size)) {
skip |= LogError(
"VUID-VkMemoryDedicatedAllocateInfo-buffer-02965", objlist, allocate_info_loc.dot(Field::allocationSize),
"(%" PRIu64 ") needs to be greater than or equal to %s (%s) VkMemoryRequirements::size (%" PRIu64 ").",
pAllocateInfo->allocationSize, buffer_loc.Fields().c_str(), FormatHandle(dedicated_buffer).c_str(),
buffer_state->requirements.size);
}
if ((buffer_state->create_info.flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != 0) {
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-buffer-01436", objlist, buffer_loc,
"(%s) was created with VK_BUFFER_CREATE_SPARSE_BINDING_BIT.",
FormatHandle(dedicated_buffer).c_str());
}
}
}
}
const auto dedicated_allocate_info_tensor =
vku::FindStructInPNextChain<VkMemoryDedicatedAllocateInfoTensorARM>(pAllocateInfo->pNext);
if (dedicated_allocate_info_tensor) {
const VkTensorARM dedicated_tensor = dedicated_allocate_info_tensor->tensor;
const auto tensor_state = Get<vvl::Tensor>(dedicated_tensor);
ASSERT_AND_RETURN_SKIP(tensor_state);
auto mem_reqs = tensor_state->MemReqs()->memoryRequirements;
if (!IgnoreAllocationSize(*pAllocateInfo) && (pAllocateInfo->allocationSize != mem_reqs.size)) {
const Location tensor_loc = allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfoTensorARM, Field::tensor);
const LogObjectList objlist(device, dedicated_tensor);
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfoTensorARM-allocationSize-09710", objlist,
allocate_info_loc.dot(Field::allocationSize),
"(%" PRIu64 ") needs to be equal to %s (%s) VkMemoryRequirements::size (%" PRIu64 ").",
pAllocateInfo->allocationSize, tensor_loc.Fields().c_str(), FormatHandle(dedicated_tensor).c_str(),
mem_reqs.size);
}
}
const auto import_memory_fd_info = vku::FindStructInPNextChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
const bool imported_opaque_fd =
import_memory_fd_info && import_memory_fd_info->handleType == VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT;
if (imported_opaque_fd) {
const Location import_loc = allocate_info_loc.pNext(Struct::VkImportMemoryFdInfoKHR, Field::fd);
if (const auto payload_info = device_state->GetOpaqueInfoFromFdHandle(import_memory_fd_info->fd)) {
if (pAllocateInfo->allocationSize != payload_info->allocation_size) {
skip |=
LogError("VUID-VkMemoryAllocateInfo-allocationSize-01742", device, allocate_info_loc.dot(Field::allocationSize),
"allocationSize (%" PRIu64 ") does not match %s (%d) allocationSize (%" PRIu64 ").",
pAllocateInfo->allocationSize, import_loc.Fields().c_str(), import_memory_fd_info->fd,
payload_info->allocation_size);
}
if (pAllocateInfo->memoryTypeIndex != payload_info->memory_type_index) {
skip |= LogError("VUID-VkMemoryAllocateInfo-allocationSize-01742", device,
allocate_info_loc.dot(Field::memoryTypeIndex),
"memoryTypeIndex (%" PRIu32 ") does not match %s (%d) memoryTypeIndex (%" PRIu32 ").",
pAllocateInfo->memoryTypeIndex, import_loc.Fields().c_str(), import_memory_fd_info->fd,
payload_info->memory_type_index);
}
if (dedicated_image != VK_NULL_HANDLE) {
if (payload_info->dedicated_image == VK_NULL_HANDLE) {
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01878", dedicated_image,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::image),
"is %s but %s (%d) was not created with a dedicated image.",
FormatHandle(dedicated_image).c_str(), import_loc.Fields().c_str(), import_memory_fd_info->fd);
} else {
auto dedicated_image_state = Get<vvl::Image>(dedicated_image);
auto payload_image_state = Get<vvl::Image>(payload_info->dedicated_image);
if (!dedicated_image_state || !payload_image_state ||
!dedicated_image_state->CompareCreateInfo(*payload_image_state)) {
// TODO - Print out info about image creation info
const LogObjectList objlist(payload_info->dedicated_image, dedicated_image);
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01878", objlist,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::image),
"is %s but %s (%d) was created with a dedicated image %s.",
FormatHandle(dedicated_image).c_str(), import_loc.Fields().c_str(),
import_memory_fd_info->fd, FormatHandle(payload_info->dedicated_image).c_str());
}
}
}
if (dedicated_buffer != VK_NULL_HANDLE) {
if (payload_info->dedicated_buffer == VK_NULL_HANDLE) {
skip |=
LogError("VUID-VkMemoryDedicatedAllocateInfo-buffer-01879", dedicated_buffer,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::buffer),
"is %s but %s (%d) was not created with a dedicated buffer.",
FormatHandle(dedicated_buffer).c_str(), import_loc.Fields().c_str(), import_memory_fd_info->fd);
} else {
auto dedicated_buffer_state = Get<vvl::Buffer>(dedicated_buffer);
auto payload_buffer_state = Get<vvl::Buffer>(payload_info->dedicated_buffer);
if (!dedicated_buffer_state || !payload_buffer_state ||
!dedicated_buffer_state->CompareCreateInfo(*payload_buffer_state)) {
// TODO - Print out info about buffer creation info
const LogObjectList objlist(payload_info->dedicated_buffer, dedicated_buffer);
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-buffer-01879", objlist,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::buffer),
"is %s but %s (%d) was created with a dedicated buffer %s.",
FormatHandle(dedicated_buffer).c_str(), import_loc.Fields().c_str(),
import_memory_fd_info->fd, FormatHandle(payload_info->dedicated_buffer).c_str());
}
}
}
}
// There is no reasonable way to query all variations of Image/Buffer creation to see what is supported, but if the import
// has dedicated Image/Buffer, we can at least validate that it has import support
// https://gitlab.khronos.org/vulkan/vulkan/-/issues/3667
if (dedicated_image != VK_NULL_HANDLE) {
auto dedicated_image_state = Get<vvl::Image>(dedicated_image);
if (dedicated_image_state &&
!HasExternalMemoryImportSupport(*dedicated_image_state, VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT)) {
skip |= LogError("VUID-VkImportMemoryFdInfoKHR-handleType-09862", dedicated_image,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::image),
"is %s but vkGetPhysicalDeviceImageFormatProperties2 shows no support for "
"VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT.",
FormatHandle(dedicated_image).c_str());
}
}
if (dedicated_buffer != VK_NULL_HANDLE) {
auto dedicated_buffer_state = Get<vvl::Buffer>(dedicated_buffer);
if (dedicated_buffer_state &&
!HasExternalMemoryImportSupport(*dedicated_buffer_state, VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT)) {
skip |= LogError("VUID-VkImportMemoryFdInfoKHR-handleType-09862", dedicated_buffer,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::buffer),
"is %s but vkGetPhysicalDeviceExternalBufferProperties shows no support for "
"VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT.",
FormatHandle(dedicated_buffer).c_str());
}
}
}
#ifdef VK_USE_PLATFORM_WIN32_KHR
if (const auto import_memory_win32_info = vku::FindStructInPNextChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext)) {
if (const auto payload_info = device_state->GetOpaqueInfoFromWin32Handle(import_memory_win32_info->handle)) {
if (IsValueIn(import_memory_win32_info->handleType,
{VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_KMT_BIT})) {
const Location import_loc = allocate_info_loc.pNext(Struct::VkImportMemoryWin32HandleInfoKHR, Field::handle);
static_assert(sizeof(HANDLE) == sizeof(uintptr_t)); // to use PRIxPTR for HANDLE formatting
if (pAllocateInfo->allocationSize != payload_info->allocation_size) {
skip |= LogError(
"VUID-VkMemoryAllocateInfo-allocationSize-01743", device, allocate_info_loc.dot(Field::allocationSize),
"allocationSize (%" PRIu64 ") does not match %s (0x%" PRIxPTR ") of type %s allocationSize (%" PRIu64 ").",
pAllocateInfo->allocationSize, import_loc.Fields().c_str(),
reinterpret_cast<std::uintptr_t>(import_memory_win32_info->handle),
string_VkExternalMemoryHandleTypeFlagBits(import_memory_win32_info->handleType),
payload_info->allocation_size);
}
if (pAllocateInfo->memoryTypeIndex != payload_info->memory_type_index) {
skip |= LogError("VUID-VkMemoryAllocateInfo-allocationSize-01743", device,
allocate_info_loc.dot(Field::memoryTypeIndex),
"memoryTypeIndex (%" PRIu32 ") does not match %s (0x%" PRIxPTR
") of type %s memoryTypeIndex (%" PRIu32 ").",
pAllocateInfo->memoryTypeIndex, import_loc.Fields().c_str(),
reinterpret_cast<std::uintptr_t>(import_memory_win32_info->handle),
string_VkExternalMemoryHandleTypeFlagBits(import_memory_win32_info->handleType),
payload_info->memory_type_index);
}
}
const Location import_loc = allocate_info_loc.pNext(Struct::VkImportMemoryWin32HandleInfoKHR, Field::handle);
if (dedicated_image != VK_NULL_HANDLE) {
if (IsValueIn(
import_memory_win32_info->handleType,
{VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_KMT_BIT,
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_KMT_BIT,
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_HEAP_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_RESOURCE_BIT})) {
if (payload_info->dedicated_image == VK_NULL_HANDLE) {
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01876", dedicated_image,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::image),
"is %s but %s (0x%" PRIxPTR ") was not created with a dedicated image.",
FormatHandle(dedicated_image).c_str(), import_loc.Fields().c_str(),
reinterpret_cast<std::uintptr_t>(import_memory_win32_info->handle));
} else {
auto dedicated_image_state = Get<vvl::Image>(dedicated_image);
auto payload_image_state = Get<vvl::Image>(payload_info->dedicated_image);
if (!dedicated_image_state || !payload_image_state ||
!dedicated_image_state->CompareCreateInfo(*payload_image_state)) {
// TODO - Print out info about image creation info
const LogObjectList objlist(payload_info->dedicated_image, dedicated_image);
skip |= LogError("VUID-VkMemoryDedicatedAllocateInfo-image-01876", objlist,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::image),
"is %s but %s (0x%" PRIxPTR ") was created with a dedicated image %s.",
FormatHandle(dedicated_image).c_str(), import_loc.Fields().c_str(),
reinterpret_cast<std::uintptr_t>(import_memory_win32_info->handle),
FormatHandle(payload_info->dedicated_image).c_str());
}
}
}
}
if (dedicated_buffer != VK_NULL_HANDLE) {
if (IsValueIn(
import_memory_win32_info->handleType,
{VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_KMT_BIT,
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_KMT_BIT,
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_HEAP_BIT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_RESOURCE_BIT})) {
if (payload_info->dedicated_buffer == VK_NULL_HANDLE) {
skip |=
LogError("VUID-VkMemoryDedicatedAllocateInfo-buffer-01877", dedicated_buffer,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::buffer),
"is %s but %s (0x%" PRIxPTR ") was not created with a dedicated buffer with handleType %s.",
FormatHandle(dedicated_buffer).c_str(), import_loc.Fields().c_str(),
reinterpret_cast<std::uintptr_t>(import_memory_win32_info->handle),
string_VkExternalMemoryHandleTypeFlagBits(import_memory_win32_info->handleType));
} else {
auto dedicated_buffer_state = Get<vvl::Buffer>(dedicated_buffer);
auto payload_buffer_state = Get<vvl::Buffer>(payload_info->dedicated_buffer);
if (!dedicated_buffer_state || !payload_buffer_state ||
!dedicated_buffer_state->CompareCreateInfo(*payload_buffer_state)) {
// TODO - Print out info about buffer creation info
const LogObjectList objlist(payload_info->dedicated_buffer, dedicated_buffer);
skip |=
LogError("VUID-VkMemoryDedicatedAllocateInfo-buffer-01877", objlist,
allocate_info_loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::buffer),
"is %s but %s (0x%" PRIxPTR ") was created with a dedicated buffer %s with handleType %s.",
FormatHandle(dedicated_buffer).c_str(), import_loc.Fields().c_str(),
reinterpret_cast<std::uintptr_t>(import_memory_win32_info->handle),
FormatHandle(payload_info->dedicated_buffer).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(import_memory_win32_info->handleType));
}
}
}
}
} else { // Handle created by non-Vulkan API (as opposite to using vkGetMemoryWin32HandleKHR)
constexpr VkExternalMemoryHandleTypeFlags nt_handles_outside_vulkan_api =
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_BIT | VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_HEAP_BIT |
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_RESOURCE_BIT;
constexpr VkExternalMemoryHandleTypeFlags global_share_handles_outside_vulkan_api =
VK_EXTERNAL_MEMORY_HANDLE_TYPE_D3D11_TEXTURE_KMT_BIT;
if ((import_memory_win32_info->handleType &
(nt_handles_outside_vulkan_api | global_share_handles_outside_vulkan_api)) != 0) {
VkMemoryWin32HandlePropertiesKHR handle_properties = vku::InitStructHelper();
DispatchGetMemoryWin32HandlePropertiesKHR(device, import_memory_win32_info->handleType,
import_memory_win32_info->handle, &handle_properties);
if (((1 << pAllocateInfo->memoryTypeIndex) & handle_properties.memoryTypeBits) == 0) {
skip |= LogError(
"VUID-VkMemoryAllocateInfo-memoryTypeIndex-00645", device, allocate_info_loc.dot(Field::memoryTypeIndex),
"is %" PRIu32 " but VkMemoryWin32HandlePropertiesKHR::memoryTypeBits is 0x%" PRIx32 " with handleType %s.",
pAllocateInfo->memoryTypeIndex, handle_properties.memoryTypeBits,
string_VkExternalMemoryHandleTypeFlagBits(import_memory_win32_info->handleType));
}
}
}
}
#endif
#ifdef VK_USE_PLATFORM_METAL_EXT
if (IsExtEnabled(extensions.vk_ext_external_memory_metal)) {
skip |= ValidateAllocateMemoryMetal(*pAllocateInfo, dedicated_allocate_info, allocate_info_loc);
}
#endif // VK_USE_PLATFORM_METAL_EXT
return skip;
}
bool CoreChecks::PreCallValidateFreeMemory(VkDevice device, VkDeviceMemory memory, const VkAllocationCallbacks *pAllocator,
const ErrorObject &error_obj) const {
bool skip = false;
if (auto mem_info = Get<vvl::DeviceMemory>(memory)) {
skip |= ValidateObjectNotInUse(mem_info.get(), error_obj.location, "VUID-vkFreeMemory-memory-00677");
}
return skip;
}
bool CoreChecks::ValidateInsertMemoryRange(const VulkanTypedHandle &typed_handle, const vvl::DeviceMemory &mem_info,
VkDeviceSize memoryOffset, const Location &loc) const {
bool skip = false;
if (!IgnoreAllocationSize(mem_info.allocate_info) && memoryOffset >= mem_info.allocate_info.allocationSize) {
const char *vuid = nullptr;
if (typed_handle.type == kVulkanObjectTypeBuffer) {
vuid = loc.function == Func::vkBindBufferMemory ? "VUID-vkBindBufferMemory-memoryOffset-01031"
: "VUID-VkBindBufferMemoryInfo-memoryOffset-01031";
} else if (typed_handle.type == kVulkanObjectTypeImage) {
vuid = loc.function == Func::vkBindImageMemory ? "VUID-vkBindImageMemory-memoryOffset-01046"
: "VUID-VkBindImageMemoryInfo-memoryOffset-01046";
} else if (typed_handle.type == kVulkanObjectTypeAccelerationStructureNV) {
vuid = "VUID-VkBindAccelerationStructureMemoryInfoNV-memoryOffset-03621";
} else if (typed_handle.type == kVulkanObjectTypeTensorARM) {
vuid = "VUID-VkBindTensorMemoryInfoARM-memoryOffset-09713";
} else if (typed_handle.type == kVulkanObjectTypeDataGraphPipelineSessionARM) {
vuid = "VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-memoryOffset-09787";
} else {
assert(false); // Unsupported object type
}
LogObjectList objlist(mem_info.Handle(), typed_handle);
skip |= LogError(vuid, objlist, loc,
"attempting to bind %s to %s, but the memoryOffset (%" PRIu64
") must be less than the memory allocation size (%" PRIu64 ").",
FormatHandle(mem_info.Handle()).c_str(), FormatHandle(typed_handle).c_str(), memoryOffset,
mem_info.allocate_info.allocationSize);
}
return skip;
}
bool CoreChecks::ValidateMemoryTypes(const vvl::DeviceMemory &mem_info, const uint32_t memory_type_bits,
const Location &resource_loc, const char *vuid) const {
bool skip = false;
if (((1 << mem_info.allocate_info.memoryTypeIndex) & memory_type_bits) == 0) {
skip |= LogError(vuid, mem_info.Handle(), resource_loc,
"require memoryTypeBits (0x%x) but (%s) was allocated with memoryTypeIndex (%" PRIu32
") with memoryTypeBits (0x%x).",
memory_type_bits, FormatHandle(mem_info.Handle()).c_str(), mem_info.allocate_info.memoryTypeIndex,
phys_dev_mem_props.memoryTypes[mem_info.allocate_info.memoryTypeIndex].propertyFlags);
}
return skip;
}
bool CoreChecks::ValidateBindBufferMemory(VkBuffer buffer, VkDeviceMemory memory, VkDeviceSize memoryOffset, const void *pNext,
const Location &loc) const {
bool skip = false;
const auto &device_group_create_info = device_state->device_group_create_info;
// Validate device group information
if (const auto *bind_buffer_memory_device_group_info = vku::FindStructInPNextChain<VkBindBufferMemoryDeviceGroupInfo>(pNext)) {
if (bind_buffer_memory_device_group_info->deviceIndexCount != 0 &&
bind_buffer_memory_device_group_info->deviceIndexCount != device_group_create_info.physicalDeviceCount &&
device_group_create_info.physicalDeviceCount > 0) {
const LogObjectList objlist(buffer, memory);
skip |= LogError("VUID-VkBindBufferMemoryDeviceGroupInfo-deviceIndexCount-01606", objlist,
loc.pNext(Struct::VkBindBufferMemoryDeviceGroupInfo, Field::deviceIndexCount),
"(%" PRIu32 ") is not the same as the number of physical devices in the logical device (%" PRIu32 ").",
bind_buffer_memory_device_group_info->deviceIndexCount, device_group_create_info.physicalDeviceCount);
} else {
for (uint32_t i = 0; i < bind_buffer_memory_device_group_info->deviceIndexCount; ++i) {
if (bind_buffer_memory_device_group_info->pDeviceIndices[i] >= device_group_create_info.physicalDeviceCount) {
const LogObjectList objlist(buffer, memory);
skip |= LogError(
"VUID-VkBindBufferMemoryDeviceGroupInfo-pDeviceIndices-01607", objlist,
loc.pNext(Struct::VkBindBufferMemoryDeviceGroupInfo, Field::pDeviceIndices, i),
"(%" PRIu32 ") larger then the number of physical devices in the logical device (%" PRIu32 ").",
bind_buffer_memory_device_group_info->pDeviceIndices[i], device_group_create_info.physicalDeviceCount);
}
}
}
}
auto buffer_state = Get<vvl::Buffer>(buffer);
ASSERT_AND_RETURN_SKIP(buffer_state);
const bool bind_buffer_mem_2 = loc.function != Func::vkBindBufferMemory;
// Validate memory requirements alignment
if (SafeModulo(memoryOffset, buffer_state->requirements.alignment) != 0) {
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-None-10739" : "VUID-vkBindBufferMemory-None-10739";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memoryOffset),
"is %" PRIu64 " but must be an integer multiple of the VkMemoryRequirements::alignment value %" PRIu64
", returned from a call to vkGetBufferMemoryRequirements with buffer.",
memoryOffset, buffer_state->requirements.alignment);
}
if (auto mem_info = Get<vvl::DeviceMemory>(memory)) {
// Track objects tied to memory
skip |= ValidateSetMemBinding(*mem_info, *buffer_state, loc);
// Validate VkExportMemoryAllocateInfo's VUs that can't be checked during vkAllocateMemory
// because they require buffer information.
if (mem_info->IsExport()) {
VkPhysicalDeviceExternalBufferInfo external_info = vku::InitStructHelper();
external_info.flags = buffer_state->create_info.flags;
// TODO: for now, there is no VkBufferUsageFlags2 flag that exceeds 32-bit but should be revisited later
external_info.usage = VkBufferUsageFlags(buffer_state->usage);
VkExternalBufferProperties external_properties = vku::InitStructHelper();
bool export_supported = true;
auto validate_export_handle_types = [&](VkExternalMemoryHandleTypeFlagBits flag) {
external_info.handleType = flag;
DispatchGetPhysicalDeviceExternalBufferPropertiesHelper(api_version, physical_device, &external_info,
&external_properties);
const auto external_features = external_properties.externalMemoryProperties.externalMemoryFeatures;
if ((external_features & VK_EXTERNAL_MEMORY_FEATURE_EXPORTABLE_BIT) == 0) {
export_supported = false;
const LogObjectList objlist(buffer, memory);
skip |= LogError("VUID-VkExportMemoryAllocateInfo-handleTypes-09860", objlist, loc,
"The VkDeviceMemory (%s) has VkExportMemoryAllocateInfo::handleTypes with the %s flag "
"set, which does not support VK_EXTERNAL_MEMORY_FEATURE_EXPORTABLE_BIT with the buffer "
"create flags (%s) and usage flags (%s).",
FormatHandle(memory).c_str(), string_VkExternalMemoryHandleTypeFlagBits(flag),
string_VkBufferCreateFlags(external_info.flags).c_str(),
string_VkBufferUsageFlags(external_info.usage).c_str());
}
if ((external_features & VK_EXTERNAL_MEMORY_FEATURE_DEDICATED_ONLY_BIT) != 0) {
if (!mem_info->IsDedicatedBuffer()) {
const LogObjectList objlist(buffer, memory);
skip |= LogError("VUID-VkMemoryAllocateInfo-pNext-00639", objlist, loc.dot(Field::memory),
"(%s) has VkExportMemoryAllocateInfo::handleTypes with the %s flag "
"set, which requires dedicated allocation for the buffer created with flags (%s) and "
"usage flags (%s), but the memory is allocated without dedicated allocation support.",
FormatHandle(memory).c_str(), string_VkExternalMemoryHandleTypeFlagBits(flag),
string_VkBufferCreateFlags(external_info.flags).c_str(),
string_VkBufferUsageFlags(external_info.usage).c_str());
}
}
};
IterateFlags<VkExternalMemoryHandleTypeFlagBits>(mem_info->export_handle_types, validate_export_handle_types);
// The types of external memory handles must be compatible
const auto compatible_types = external_properties.externalMemoryProperties.compatibleHandleTypes;
if (export_supported && (mem_info->export_handle_types & compatible_types) != mem_info->export_handle_types) {
const LogObjectList objlist(buffer, memory);
skip |= LogError("VUID-VkExportMemoryAllocateInfo-handleTypes-09860", objlist, loc.dot(Field::memory),
"(%s) has VkExportMemoryAllocateInfo::handleTypes (%s) that are not "
"reported as compatible by vkGetPhysicalDeviceExternalBufferProperties with the buffer create "
"flags (%s) and usage flags (%s).",
FormatHandle(memory).c_str(),
string_VkExternalMemoryHandleTypeFlags(mem_info->export_handle_types).c_str(),
string_VkBufferCreateFlags(external_info.flags).c_str(),
string_VkBufferUsageFlags(external_info.usage).c_str());
}
}
// Validate bound memory range information
skip |= ValidateInsertMemoryRange(VulkanTypedHandle(buffer, kVulkanObjectTypeBuffer), *mem_info, memoryOffset, loc);
const char *mem_type_vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-memory-01035" : "VUID-vkBindBufferMemory-memory-01035";
skip |= ValidateMemoryTypes(*mem_info, buffer_state->requirements.memoryTypeBits, loc.dot(Field::buffer), mem_type_vuid);
// Validate memory requirements size
if (buffer_state->requirements.size > (mem_info->allocate_info.allocationSize - memoryOffset)) {
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-None-10741" : "VUID-vkBindBufferMemory-None-10741";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc,
"allocationSize (%" PRIu64 ") minus memoryOffset (%" PRIu64 ") is %" PRIu64
" but must be at least as large as VkMemoryRequirements::size value %" PRIu64
", returned from a call to vkGetBufferMemoryRequirements with buffer.",
mem_info->allocate_info.allocationSize, memoryOffset,
mem_info->allocate_info.allocationSize - memoryOffset, buffer_state->requirements.size);
}
// Validate dedicated allocation
const VkBuffer dedicated_buffer = mem_info->GetDedicatedBuffer();
if (dedicated_buffer != VK_NULL_HANDLE && ((dedicated_buffer != buffer) || (memoryOffset != 0))) {
const char *vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-memory-01508" : "VUID-vkBindBufferMemory-memory-01508";
const LogObjectList objlist(buffer, memory, dedicated_buffer);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) is dedicated allocation, but VkMemoryDedicatedAllocateInfo::buffer %s must be equal "
"to %s and memoryOffset %" PRIu64 " must be zero.",
FormatHandle(memory).c_str(), FormatHandle(dedicated_buffer).c_str(), FormatHandle(buffer).c_str(),
memoryOffset);
} else if (IsExtEnabled(extensions.vk_khr_dedicated_allocation)) {
VkBufferMemoryRequirementsInfo2 buffer_memory_requirements_info_2 = vku::InitStructHelper();
buffer_memory_requirements_info_2.buffer = buffer;
VkMemoryDedicatedRequirements memory_dedicated_requirements = vku::InitStructHelper();
VkMemoryRequirements2 memory_requirements = vku::InitStructHelper(&memory_dedicated_requirements);
DispatchGetBufferMemoryRequirements2Helper(api_version, device, &buffer_memory_requirements_info_2, &memory_requirements);
if (memory_dedicated_requirements.requiresDedicatedAllocation) {
const char *vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-buffer-01444" : "VUID-vkBindBufferMemory-buffer-01444";
if (dedicated_buffer == VK_NULL_HANDLE) {
const LogObjectList objlist(buffer, memory);
skip |= LogError(
vuid, objlist, loc.dot(Field::memory),
"was created without a VkMemoryDedicatedAllocateInfo in the pNext chain, but the buffer, if queried with "
"vkGetBufferMemoryRequirements2() reports requiresDedicatedAllocation is VK_TRUE.\n%s",
PrintPNextChain(Struct::VkBindBufferMemoryInfo, pNext).c_str());
} else if (dedicated_buffer != buffer) {
const LogObjectList objlist(buffer, memory, dedicated_buffer);
skip |=
LogError(vuid, objlist, loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::pNext).dot(Field::buffer),
"is %s, but VkBindBufferMemoryInfo::buffer is %s.", FormatHandle(dedicated_buffer).c_str(),
FormatHandle(buffer).c_str());
}
}
}
const VkImage dedicated_image = mem_info->GetDedicatedImage();
if (dedicated_image != VK_NULL_HANDLE) {
const LogObjectList objlist(buffer, memory);
const char *vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-memory-10925" : "VUID-vkBindBufferMemory-memory-10925";
skip |= LogError(vuid, objlist, loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::pNext).dot(Field::image),
"is %s (not VK_NULL_HANDLE), but VkBindBufferMemoryInfo::buffer is %s.",
FormatHandle(dedicated_image).c_str(), FormatHandle(buffer).c_str());
}
auto chained_flags_struct = vku::FindStructInPNextChain<VkMemoryAllocateFlagsInfo>(mem_info->allocate_info.pNext);
if (enabled_features.bufferDeviceAddress && (buffer_state->usage & VK_BUFFER_USAGE_2_SHADER_DEVICE_ADDRESS_BIT) &&
(!chained_flags_struct || !(chained_flags_struct->flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT))) {
const LogObjectList objlist(buffer, memory);
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-bufferDeviceAddress-03339"
: "VUID-vkBindBufferMemory-bufferDeviceAddress-03339";
skip |= LogError(vuid, objlist, loc.dot(Field::buffer),
"was created with VK_BUFFER_USAGE_2_SHADER_DEVICE_ADDRESS_BIT, "
"but the memory was not allocated with VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT%s.",
chained_flags_struct ? "" : " (Need to add VkMemoryAllocateFlagsInfo to VkMemoryAllocateInfo::pNext)");
}
const VkMemoryAllocateFlags memory_allocate_flags = chained_flags_struct ? chained_flags_struct->flags : 0;
if (buffer_state->create_info.flags & VK_BUFFER_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT) {
if (!(memory_allocate_flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT)) {
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-descriptorBufferCaptureReplay-08112"
: "VUID-vkBindBufferMemory-descriptorBufferCaptureReplay-08112";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::buffer),
"was created with VK_BUFFER_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT,"
"but the bound memory was not allocated with VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT "
"(VkMemoryAllocateFlags::flags were %s).",
string_VkMemoryAllocateFlags(memory_allocate_flags).c_str());
}
if (!(memory_allocate_flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
const char *vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-buffer-09201" : "VUID-vkBindBufferMemory-buffer-09201";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::buffer),
"was created with VK_BUFFER_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT,"
"but the bound memory was not allocated with VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT "
"(VkMemoryAllocateFlags::flags were %s).",
string_VkMemoryAllocateFlags(memory_allocate_flags).c_str());
}
if (enabled_features.descriptorBufferCaptureReplay) {
if (!(memory_allocate_flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-bufferDeviceAddressCaptureReplay-09200"
: "VUID-vkBindBufferMemory-bufferDeviceAddressCaptureReplay-09200";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::buffer),
"was created with VK_BUFFER_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT,"
"but the bound memory was not allocated with "
"VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT (VkMemoryAllocateFlags::flags were %s).",
string_VkMemoryAllocateFlags(memory_allocate_flags).c_str());
}
}
}
// Validate export memory handles. Check if the memory meets the buffer's external memory requirements
if (mem_info->IsExport() && (mem_info->export_handle_types & buffer_state->external_memory_handle_types) == 0) {
const char *vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-memory-02726" : "VUID-vkBindBufferMemory-memory-02726";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) has an external handleType of %s which does not include at least one "
"handle from VkBuffer (%s) handleType %s.",
FormatHandle(memory).c_str(),
string_VkExternalMemoryHandleTypeFlags(mem_info->export_handle_types).c_str(),
FormatHandle(buffer).c_str(),
string_VkExternalMemoryHandleTypeFlags(buffer_state->external_memory_handle_types).c_str());
}
// Validate import memory handles
if (mem_info->IsImportAHB()) {
skip |= ValidateBufferImportedHandleANDROID(buffer_state->external_memory_handle_types, memory, buffer, loc);
} else if (mem_info->IsImport()) {
if ((mem_info->import_handle_type.value() & buffer_state->external_memory_handle_types) == 0) {
const char *vuid =
bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-memory-02985" : "VUID-vkBindBufferMemory-memory-02985";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) was created with an import operation with handleType of %s which "
"is not set in the VkBuffer (%s) VkExternalMemoryBufferCreateInfo::handleType (%s)",
FormatHandle(memory).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()),
FormatHandle(buffer).c_str(),
string_VkExternalMemoryHandleTypeFlags(buffer_state->external_memory_handle_types).c_str());
}
// Check if buffer can be bound to memory imported from specific handle type
if (!HasExternalMemoryImportSupport(*buffer_state, mem_info->import_handle_type.value())) {
const LogObjectList objlist(buffer, memory);
skip |= LogError(
"VUID-VkImportMemoryWin32HandleInfoKHR-handleType-09861", objlist, loc.dot(Field::memory),
"(%s) was imported from handleType %s but VkExternalBufferProperties does not report it as importable.",
FormatHandle(memory).c_str(), string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()));
}
}
// Validate mix of protected buffer and memory
if ((buffer_state->unprotected == false) && (mem_info->unprotected == true)) {
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-None-01898" : "VUID-vkBindBufferMemory-None-01898";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) was not created with protected memory but the VkBuffer (%s) was set "
"to use protected memory.",
FormatHandle(memory).c_str(), FormatHandle(buffer).c_str());
} else if ((buffer_state->unprotected == true) && (mem_info->unprotected == false)) {
const char *vuid = bind_buffer_mem_2 ? "VUID-VkBindBufferMemoryInfo-None-01899" : "VUID-vkBindBufferMemory-None-01899";
const LogObjectList objlist(buffer, memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) was created with protected memory but the VkBuffer (%s) was not set "
"to use protected memory.",
FormatHandle(memory).c_str(), FormatHandle(buffer).c_str());
}
}
return skip;
}
bool CoreChecks::PreCallValidateBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory memory, VkDeviceSize memoryOffset,
const ErrorObject &error_obj) const {
return ValidateBindBufferMemory(buffer, memory, memoryOffset, nullptr, error_obj.location);
}
bool CoreChecks::PreCallValidateBindBufferMemory2(VkDevice device, uint32_t bindInfoCount, const VkBindBufferMemoryInfo *pBindInfos,
const ErrorObject &error_obj) const {
bool skip = false;
for (uint32_t i = 0; i < bindInfoCount; i++) {
const Location loc = error_obj.location.dot(Field::pBindInfos, i);
skip |= ValidateBindBufferMemory(pBindInfos[i].buffer, pBindInfos[i].memory, pBindInfos[i].memoryOffset,
pBindInfos[i].pNext, loc);
}
return skip;
}
bool CoreChecks::PreCallValidateBindBufferMemory2KHR(VkDevice device, uint32_t bindInfoCount,
const VkBindBufferMemoryInfo *pBindInfos, const ErrorObject &error_obj) const {
return PreCallValidateBindBufferMemory2(device, bindInfoCount, pBindInfos, error_obj);
}
bool CoreChecks::PreCallValidateGetImageMemoryRequirements(VkDevice device, VkImage image,
VkMemoryRequirements *pMemoryRequirements,
const ErrorObject &error_obj) const {
bool skip = false;
const Location image_loc = error_obj.location.dot(Field::image);
skip |= ValidateGetImageMemoryRequirementsANDROID(image, image_loc);
if (auto image_state = Get<vvl::Image>(image)) {
// Checks for no disjoint bit
if (image_state->disjoint == true) {
skip |= LogError("VUID-vkGetImageMemoryRequirements-image-01588", image, image_loc,
"(%s) must not have been created with the VK_IMAGE_CREATE_DISJOINT_BIT "
"(need to use vkGetImageMemoryRequirements2).",
FormatHandle(image).c_str());
}
}
return skip;
}
bool CoreChecks::PreCallValidateGetImageMemoryRequirements2(VkDevice device, const VkImageMemoryRequirementsInfo2 *pInfo,
VkMemoryRequirements2 *pMemoryRequirements,
const ErrorObject &error_obj) const {
bool skip = false;
const Location info_loc = error_obj.location.dot(Field::pInfo);
const Location image_loc = info_loc.dot(Field::image);
skip |= ValidateGetImageMemoryRequirementsANDROID(pInfo->image, image_loc);
auto image_state = Get<vvl::Image>(pInfo->image);
ASSERT_AND_RETURN_SKIP(image_state);
const VkFormat image_format = image_state->create_info.format;
const VkImageTiling image_tiling = image_state->create_info.tiling;
const auto *image_plane_info = vku::FindStructInPNextChain<VkImagePlaneMemoryRequirementsInfo>(pInfo->pNext);
if (!image_plane_info && image_state->disjoint) {
if (vkuFormatIsMultiplane(image_format)) {
skip |= LogError("VUID-VkImageMemoryRequirementsInfo2-image-01589", pInfo->image, image_loc,
"(%s) was created with a multi-planar format (%s) and "
"VK_IMAGE_CREATE_DISJOINT_BIT, but the current pNext doesn't include a "
"VkImagePlaneMemoryRequirementsInfo struct",
FormatHandle(pInfo->image).c_str(), string_VkFormat(image_format));
}
if (image_state->create_info.tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
skip |= LogError("VUID-VkImageMemoryRequirementsInfo2-image-02279", pInfo->image, image_loc,
"(%s) was created with VK_IMAGE_CREATE_DISJOINT_BIT and has tiling of "
"VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT, "
"but the current pNext does not include a VkImagePlaneMemoryRequirementsInfo struct",
FormatHandle(pInfo->image).c_str());
}
} else if (image_plane_info) {
if ((image_state->disjoint == false)) {
skip |= LogError("VUID-VkImageMemoryRequirementsInfo2-image-01590", pInfo->image, image_loc,
"(%s) was not created with VK_IMAGE_CREATE_DISJOINT_BIT,"
"but the current pNext includes a VkImagePlaneMemoryRequirementsInfo struct",
FormatHandle(pInfo->image).c_str());
}
if ((vkuFormatIsMultiplane(image_format) == false) && (image_tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT)) {
skip |= LogError("VUID-VkImageMemoryRequirementsInfo2-image-02280", pInfo->image, image_loc,
"(%s) is a single-plane format (%s) and does not have tiling of "
"VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT,"
"but the current pNext includes a VkImagePlaneMemoryRequirementsInfo struct",
FormatHandle(pInfo->image).c_str(), string_VkFormat(image_format));
}
const VkImageAspectFlags aspect = image_plane_info->planeAspect;
if ((image_tiling == VK_IMAGE_TILING_LINEAR) || (image_tiling == VK_IMAGE_TILING_OPTIMAL)) {
// Make sure planeAspect is only a single, valid plane
if (vkuFormatIsMultiplane(image_format) && !IsOnlyOneValidPlaneAspect(image_format, aspect)) {
skip |=
LogError("VUID-VkImagePlaneMemoryRequirementsInfo-planeAspect-02281", pInfo->image,
info_loc.pNext(Struct::VkImagePlaneMemoryRequirementsInfo, Field::planeAspect),
"%s but is invalid for %s.", string_VkImageAspectFlags(aspect).c_str(), string_VkFormat(image_format));
}
} else if (image_tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
// TODO - Need to also check if lower then drmFormatModifierPlaneCount
if (GetBitSetCount(aspect) > 1 ||
!IsValueIn(VkImageAspectFlagBits(aspect),
{VK_IMAGE_ASPECT_MEMORY_PLANE_0_BIT_EXT, VK_IMAGE_ASPECT_MEMORY_PLANE_1_BIT_EXT,
VK_IMAGE_ASPECT_MEMORY_PLANE_2_BIT_EXT, VK_IMAGE_ASPECT_MEMORY_PLANE_3_BIT_EXT})) {
skip |=
LogError("VUID-VkImagePlaneMemoryRequirementsInfo-planeAspect-02282", pInfo->image,
info_loc.pNext(Struct::VkImagePlaneMemoryRequirementsInfo, Field::planeAspect),
"%s but is invalid for %s.", string_VkImageAspectFlags(aspect).c_str(), string_VkFormat(image_format));
}
}
}
return skip;
}
bool CoreChecks::PreCallValidateGetImageMemoryRequirements2KHR(VkDevice device, const VkImageMemoryRequirementsInfo2 *pInfo,
VkMemoryRequirements2 *pMemoryRequirements,
const ErrorObject &error_obj) const {
return PreCallValidateGetImageMemoryRequirements2(device, pInfo, pMemoryRequirements, error_obj);
}
bool CoreChecks::ValidateMapMemory(const vvl::DeviceMemory &mem_info, VkDeviceSize offset, VkDeviceSize size,
const Location &offset_loc, const Location &size_loc) const {
bool skip = false;
const bool map2 = offset_loc.function != Func::vkMapMemory;
const Location loc(offset_loc.function);
const VkDeviceMemory memory = mem_info.VkHandle();
const uint32_t memoryTypeIndex = mem_info.allocate_info.memoryTypeIndex;
const VkMemoryPropertyFlags propertyFlags = phys_dev_mem_props.memoryTypes[memoryTypeIndex].propertyFlags;
if ((propertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) {
skip |= LogError(map2 ? "VUID-VkMemoryMapInfo-memory-07962" : "VUID-vkMapMemory-memory-00682", memory, loc,
"Mapping memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set. "
"Memory has type %" PRIu32 " which has properties %s.",
memoryTypeIndex, string_VkMemoryPropertyFlags(propertyFlags).c_str());
}
if (mem_info.multi_instance) {
skip |= LogError(map2 ? "VUID-VkMemoryMapInfo-memory-07963" : "VUID-vkMapMemory-memory-00683", memory, loc,
"Memory allocated with multiple instances.");
}
if (size == 0) {
skip |= LogError(map2 ? "VUID-VkMemoryMapInfo-size-07960" : "VUID-vkMapMemory-size-00680", memory, size_loc, "is zero.");
}
// It is an application error to call VkMapMemory on an object that is already mapped
if (mem_info.mapped_range.size != 0) {
skip |= LogError(map2 ? "VUID-VkMemoryMapInfo-memory-07958" : "VUID-vkMapMemory-memory-00678", memory, loc,
"memory has already be mapped.");
}
// Validate offset is not over allocation size
const VkDeviceSize allocationSize = mem_info.allocate_info.allocationSize;
if (offset >= allocationSize) {
skip |= LogError(map2 ? "VUID-VkMemoryMapInfo-offset-07959" : "VUID-vkMapMemory-offset-00679", memory, offset_loc,
"0x%" PRIx64 " is larger than the total array size 0x%" PRIx64, offset, allocationSize);
}
// Validate that offset + size is within object's allocationSize
if (size != VK_WHOLE_SIZE) {
if ((offset + size) > allocationSize) {
skip |=
LogError(map2 ? "VUID-VkMemoryMapInfo-size-07961" : "VUID-vkMapMemory-size-00681", memory, offset_loc,
"0x%" PRIx64 " plus size 0x%" PRIx64 " (total 0x%" PRIx64 ") oversteps total array size 0x%" PRIx64 ".",
offset, size, size + offset, allocationSize);
}
}
return skip;
}
bool CoreChecks::PreCallValidateMapMemory(VkDevice device, VkDeviceMemory memory, VkDeviceSize offset, VkDeviceSize size,
VkFlags flags, void **ppData, const ErrorObject &error_obj) const {
bool skip = false;
if (auto mem_info = Get<vvl::DeviceMemory>(memory)) {
skip |= ValidateMapMemory(*mem_info.get(), offset, size, error_obj.location.dot(Field::offset),
error_obj.location.dot(Field::size));
if (flags & VK_MEMORY_MAP_PLACED_BIT_EXT) {
skip |= LogError("VUID-vkMapMemory-flags-09568", memory, error_obj.location.dot(Field::flags),
"VK_MEMORY_MAP_PLACED_BIT_EXT is not allowed in vkMapMemory()");
}
}
return skip;
}
bool CoreChecks::PreCallValidateMapMemory2(VkDevice device, const VkMemoryMapInfo *pMemoryMapInfo, void **ppData,
const ErrorObject &error_obj) const {
bool skip = false;
auto mem_info = Get<vvl::DeviceMemory>(pMemoryMapInfo->memory);
ASSERT_AND_RETURN_SKIP(mem_info);
const Location info_loc = error_obj.location.dot(Field::pMemoryMapInfo);
skip |= ValidateMapMemory(*mem_info.get(), pMemoryMapInfo->offset, pMemoryMapInfo->size, info_loc.dot(Field::offset),
info_loc.dot(Field::size));
if (pMemoryMapInfo->flags & VK_MEMORY_MAP_PLACED_BIT_EXT) {
if (!enabled_features.memoryMapPlaced) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09569", pMemoryMapInfo->memory, error_obj.location,
"(%s) has VK_MEMORY_MAP_PLACED_BIT_EXT set but memoryMapPlaced is not enabled",
string_VkMemoryMapFlags(pMemoryMapInfo->flags).c_str());
}
if (enabled_features.memoryMapRangePlaced) {
if (pMemoryMapInfo->offset % phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment != 0) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09573", pMemoryMapInfo->memory, info_loc.dot(Field::offset),
"(0x%" PRIx64
") is not an integer multiple of "
"minPlacedMemoryMapAlignment (0x%" PRIx64 ") while VK_MEMORY_MAP_PLACED_BIT_EXT is set",
pMemoryMapInfo->offset, phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment);
}
} else {
if (pMemoryMapInfo->offset != 0) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09571", pMemoryMapInfo->memory, info_loc.dot(Field::offset),
"(0x%" PRIx64
") is not zero while VK_MEMORY_MAP_PLACED_BIT_EXT is set and "
"memoryMapRangePlaced is not enabled.",
pMemoryMapInfo->offset);
}
if (pMemoryMapInfo->size != VK_WHOLE_SIZE && pMemoryMapInfo->size != mem_info->allocate_info.allocationSize) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09572", pMemoryMapInfo->memory, info_loc.dot(Field::size),
"(0x%" PRIx64 ") is not VK_WHOLE_SIZE or the size of memory (%" PRIu64
") while VK_MEMORY_MAP_PLACED_BIT_EXT is set and memoryMapRangePlaced is not enabled.",
pMemoryMapInfo->size, mem_info->allocate_info.allocationSize);
}
}
if (pMemoryMapInfo->size == VK_WHOLE_SIZE) {
if (mem_info->allocate_info.allocationSize % phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment !=
0) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09651", pMemoryMapInfo->memory, info_loc.dot(Field::size),
"is VK_WHOLE_SIZE but the size of the memory (0x%" PRIx64
") is not an integer multiple of minPlacedMemoryMapAlignment (0x%" PRIx64 ")",
mem_info->allocate_info.allocationSize,
phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment);
}
} else {
if (pMemoryMapInfo->size % phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment != 0) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09574", pMemoryMapInfo->memory, info_loc.dot(Field::size),
"(0x%" PRIx64
") is not VK_WHOLE_SIZE and is not an integer multiple of "
"minPlacedMemoryMapAlignment (0x%" PRIx64 ") while VK_MEMORY_MAP_PLACED_BIT_EXT is set",
pMemoryMapInfo->size, phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment);
}
}
if (mem_info->IsImport() &&
(mem_info->import_handle_type.value() == VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT ||
mem_info->import_handle_type.value() == VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_MAPPED_FOREIGN_MEMORY_BIT_EXT)) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09575", pMemoryMapInfo->memory, info_loc.dot(Field::flags),
"(%s) has VK_MEMORY_MAP_PLACED_BIT_EXT set but memory was imported with a handle type of %s",
string_VkMemoryMapFlags(pMemoryMapInfo->flags).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()));
}
const auto placed_info = vku::FindStructInPNextChain<VkMemoryMapPlacedInfoEXT>(pMemoryMapInfo->pNext);
const auto addr_loc = info_loc.pNext(Struct::VkMemoryMapPlacedInfoEXT, Field::pPlacedAddress);
if (placed_info == NULL) {
skip |=
LogError("VUID-VkMemoryMapInfo-flags-09570", pMemoryMapInfo->memory, info_loc.dot(Field::pNext),
"does not contain VkMemoryMapPlacedInfoEXT, but VK_MEMORY_MAP_PLACED_BIT_EXT was set in flags (%s).\n%s",
string_VkMemoryMapFlags(pMemoryMapInfo->flags).c_str(),
PrintPNextChain(Struct::VkMemoryMapInfo, pMemoryMapInfo->pNext).c_str());
} else if (placed_info->pPlacedAddress == NULL) {
skip |= LogError("VUID-VkMemoryMapInfo-flags-09570", pMemoryMapInfo->memory, addr_loc,
"is NULL, but VK_MEMORY_MAP_PLACED_BIT_EXT was set in flags (%s)",
string_VkMemoryMapFlags(pMemoryMapInfo->flags).c_str());
} else if (reinterpret_cast<std::uintptr_t>(placed_info->pPlacedAddress) %
phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment !=
0) {
skip |= LogError("VUID-VkMemoryMapPlacedInfoEXT-pPlacedAddress-09577", pMemoryMapInfo->memory, addr_loc,
"(%p) is not an integer multiple of "
"minPlacedMemoryMapAlignment (0x%" PRIx64 ")",
placed_info->pPlacedAddress, phys_dev_ext_props.map_memory_placed_props.minPlacedMemoryMapAlignment);
}
}
return skip;
}
bool CoreChecks::PreCallValidateMapMemory2KHR(VkDevice device, const VkMemoryMapInfoKHR *pMemoryMapInfo, void **ppData,
const ErrorObject &error_obj) const {
return PreCallValidateMapMemory2(device, pMemoryMapInfo, ppData, error_obj);
}
bool CoreChecks::PreCallValidateUnmapMemory(VkDevice device, VkDeviceMemory memory, const ErrorObject &error_obj) const {
bool skip = false;
auto mem_info = Get<vvl::DeviceMemory>(memory);
ASSERT_AND_RETURN_SKIP(mem_info);
if (!mem_info->mapped_range.size) {
skip |= LogError("VUID-vkUnmapMemory-memory-00689", memory, error_obj.location,
"Unmapping Memory without memory being mapped.");
}
return skip;
}
bool CoreChecks::PreCallValidateUnmapMemory2(VkDevice device, const VkMemoryUnmapInfo *pMemoryUnmapInfo,
const ErrorObject &error_obj) const {
bool skip = false;
auto mem_info = Get<vvl::DeviceMemory>(pMemoryUnmapInfo->memory);
ASSERT_AND_RETURN_SKIP(mem_info);
if (!mem_info->mapped_range.size) {
const Location info_loc = error_obj.location.dot(Field::pMemoryUnmapInfo);
skip |= LogError("VUID-VkMemoryUnmapInfo-memory-07964", pMemoryUnmapInfo->memory, error_obj.location,
"Unmapping Memory without memory being mapped.");
if (pMemoryUnmapInfo->flags & VK_MEMORY_UNMAP_RESERVE_BIT_EXT) {
if (!enabled_features.memoryUnmapReserve) {
skip |= LogError("VUID-VkMemoryUnmapInfo-flags-09579", pMemoryUnmapInfo->memory, info_loc.dot(Field::flags),
"VK_MEMORY_MAP_PLACED_BIT_EXT is set but memoryUnmapReserve is not enabled");
}
if (mem_info->IsImport() &&
(mem_info->import_handle_type.value() == VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT ||
mem_info->import_handle_type.value() == VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_MAPPED_FOREIGN_MEMORY_BIT_EXT)) {
skip |= LogError("VUID-VkMemoryUnmapInfo-flags-09580", pMemoryUnmapInfo->memory, info_loc.dot(Field::flags),
"VK_MEMORY_MAP_PLACED_BIT_EXT is set but memory was imported with a handle type of %s",
string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()));
}
}
}
return skip;
}
bool CoreChecks::PreCallValidateUnmapMemory2KHR(VkDevice device, const VkMemoryUnmapInfoKHR *pMemoryUnmapInfo,
const ErrorObject &error_obj) const {
return PreCallValidateUnmapMemory2(device, pMemoryUnmapInfo, error_obj);
}
bool CoreChecks::ValidateMemoryIsMapped(uint32_t mem_range_count, const VkMappedMemoryRange *mem_ranges,
const ErrorObject &error_obj) const {
bool skip = false;
for (uint32_t i = 0; i < mem_range_count; ++i) {
const Location memory_range_loc = error_obj.location.dot(Field::pMemoryRanges, i);
auto mem_info = Get<vvl::DeviceMemory>(mem_ranges[i].memory);
ASSERT_AND_CONTINUE(mem_info);
// Makes sure the memory is already mapped
if (mem_info->mapped_range.size == 0) {
skip |= LogError("VUID-VkMappedMemoryRange-memory-00684", mem_ranges[i].memory, memory_range_loc,
"Attempting to use memory (%s) that is not currently host mapped.",
FormatHandle(mem_ranges[i].memory).c_str());
}
if (mem_ranges[i].size == VK_WHOLE_SIZE) {
if (mem_info->mapped_range.offset > mem_ranges[i].offset) {
skip |= LogError("VUID-VkMappedMemoryRange-size-00686", mem_ranges[i].memory, memory_range_loc.dot(Field::offset),
"(%" PRIu64 ") is less than the mapped memory offset (%" PRIu64 ") (and size is VK_WHOLE_SIZE).",
mem_ranges[i].offset, mem_info->mapped_range.offset);
}
} else {
if (mem_info->mapped_range.offset > mem_ranges[i].offset) {
skip |=
LogError("VUID-VkMappedMemoryRange-size-00685", mem_ranges[i].memory, memory_range_loc.dot(Field::offset),
"(%" PRIu64 ") is less than the mapped memory offset (%" PRIu64 ") (and size is not VK_WHOLE_SIZE).",
mem_ranges[i].offset, mem_info->mapped_range.offset);
}
const uint64_t data_end = (mem_info->mapped_range.size == VK_WHOLE_SIZE)
? mem_info->allocate_info.allocationSize
: (mem_info->mapped_range.offset + mem_info->mapped_range.size);
if ((data_end < (mem_ranges[i].offset + mem_ranges[i].size))) {
skip |= LogError("VUID-VkMappedMemoryRange-size-00685", mem_ranges[i].memory, memory_range_loc,
"size (%" PRIu64 ") + offset (%" PRIu64
") "
"exceed the Memory Object's upper-bound (%" PRIu64 ").",
mem_ranges[i].size, mem_ranges[i].offset, data_end);
}
}
}
return skip;
}
bool CoreChecks::ValidateMappedMemoryRangeDeviceLimits(uint32_t mem_range_count, const VkMappedMemoryRange *mem_ranges,
const ErrorObject &error_obj) const {
bool skip = false;
for (uint32_t i = 0; i < mem_range_count; ++i) {
const Location memory_range_loc = error_obj.location.dot(Field::pMemoryRanges, i);
const uint64_t atom_size = phys_dev_props.limits.nonCoherentAtomSize;
const VkDeviceSize offset = mem_ranges[i].offset;
const VkDeviceSize size = mem_ranges[i].size;
if (SafeModulo(offset, atom_size) != 0) {
skip |= LogError("VUID-VkMappedMemoryRange-offset-00687", mem_ranges->memory, memory_range_loc.dot(Field::offset),
"(%" PRIu64 ") is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (%" PRIu64 ").",
offset, atom_size);
}
auto mem_info = Get<vvl::DeviceMemory>(mem_ranges[i].memory);
ASSERT_AND_CONTINUE(mem_info);
const auto allocation_size = mem_info->allocate_info.allocationSize;
if (size == VK_WHOLE_SIZE) {
const auto mapping_offset = mem_info->mapped_range.offset;
const auto mapping_size = mem_info->mapped_range.size;
const auto mapping_end = ((mapping_size == VK_WHOLE_SIZE) ? allocation_size : mapping_offset + mapping_size);
if (SafeModulo(mapping_end, atom_size) != 0 && mapping_end != allocation_size) {
skip |= LogError("VUID-VkMappedMemoryRange-size-01389", mem_ranges->memory, memory_range_loc.dot(Field::size),
"is VK_WHOLE_SIZE and the mapping end (%" PRIu64 " = %" PRIu64 " + %" PRIu64
") not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (%" PRIu64
") and not equal to the end of the memory object (%" PRIu64 ").",
mapping_end, mapping_offset, mapping_size, atom_size, allocation_size);
}
} else {
const auto range_end = size + offset;
if (range_end != allocation_size && SafeModulo(size, atom_size) != 0) {
skip |= LogError("VUID-VkMappedMemoryRange-size-01390", mem_ranges->memory, memory_range_loc.dot(Field::size),
"(%" PRIu64 ") is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (%" PRIu64
") and offset + size (%" PRIu64 " + %" PRIu64 " = %" PRIu64
") not equal to the memory size (%" PRIu64 ").",
size, atom_size, offset, size, range_end, allocation_size);
}
}
}
return skip;
}
bool CoreChecks::PreCallValidateFlushMappedMemoryRanges(VkDevice device, uint32_t memoryRangeCount,
const VkMappedMemoryRange *pMemoryRanges,
const ErrorObject &error_obj) const {
bool skip = false;
skip |= ValidateMappedMemoryRangeDeviceLimits(memoryRangeCount, pMemoryRanges, error_obj);
skip |= ValidateMemoryIsMapped(memoryRangeCount, pMemoryRanges, error_obj);
return skip;
}
bool CoreChecks::PreCallValidateInvalidateMappedMemoryRanges(VkDevice device, uint32_t memoryRangeCount,
const VkMappedMemoryRange *pMemoryRanges,
const ErrorObject &error_obj) const {
bool skip = false;
skip |= ValidateMappedMemoryRangeDeviceLimits(memoryRangeCount, pMemoryRanges, error_obj);
skip |= ValidateMemoryIsMapped(memoryRangeCount, pMemoryRanges, error_obj);
return skip;
}
bool CoreChecks::PreCallValidateGetDeviceMemoryCommitment(VkDevice device, VkDeviceMemory memory, VkDeviceSize *pCommittedMem,
const ErrorObject &error_obj) const {
bool skip = false;
if (auto mem_info = Get<vvl::DeviceMemory>(memory)) {
if ((phys_dev_mem_props.memoryTypes[mem_info->allocate_info.memoryTypeIndex].propertyFlags &
VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT) == 0) {
skip |= LogError("VUID-vkGetDeviceMemoryCommitment-memory-00690", memory, error_obj.location,
"Querying commitment for memory without "
"VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT set: %s.",
FormatHandle(memory).c_str());
}
}
return skip;
}
bool CoreChecks::ValidateBindTensorMemoryARM(uint32_t bindInfoCount, const VkBindTensorMemoryInfoARM *pBindInfos,
const ErrorObject &error_obj) const {
bool skip = false;
for (uint32_t i = 0; i < bindInfoCount; i++) {
const VkBindTensorMemoryInfoARM &bind_info = pBindInfos[i];
const Location bind_info_loc = error_obj.location.dot(Field::pBindInfos, i);
const auto tensor_state = Get<vvl::Tensor>(bind_info.tensor);
const auto mem_info = Get<vvl::DeviceMemory>(bind_info.memory);
ASSERT_AND_RETURN_SKIP(tensor_state && mem_info);
skip |= ValidateSetMemBinding(*mem_info, *tensor_state, bind_info_loc);
skip |= ValidateInsertMemoryRange(VulkanTypedHandle(bind_info.tensor, kVulkanObjectTypeTensorARM), *mem_info,
bind_info.memoryOffset, bind_info_loc);
auto mem_reqs = tensor_state->MemReqs()->memoryRequirements;
skip |=
ValidateMemoryTypes(*mem_info, mem_reqs.memoryTypeBits, bind_info_loc, "VUID-VkBindTensorMemoryInfoARM-memory-09714");
if (SafeModulo(bind_info.memoryOffset, mem_reqs.alignment) != 0) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-memoryOffset-09715", objlist, bind_info_loc.dot(Field::memoryOffset),
"(%" PRIu64 ") is not a multiple of the the tensor alignment requirement (%" PRIu64 ")",
bind_info.memoryOffset, mem_reqs.alignment);
}
if (mem_reqs.size > (mem_info->allocate_info.allocationSize - bind_info.memoryOffset)) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-size-09716", objlist, bind_info_loc.dot(Field::tensor),
"size requirement (%" PRIu64 ") is greater than allocationSize (%" PRIu64 ") - memoryOffset (%" PRIu64
").",
mem_reqs.size, mem_info->allocate_info.allocationSize, bind_info.memoryOffset);
}
if (!tensor_state->unprotected && mem_info->unprotected) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-tensor-09718", objlist, bind_info_loc.dot(Field::memory),
"(%s) was not created with protected memory but the VkTensorARM (%s) was "
"set to use protected memory.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.tensor).c_str());
} else if (tensor_state->unprotected && !mem_info->unprotected) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-tensor-09719", objlist, bind_info_loc.dot(Field::memory),
"(%s) was created with protected memory but the VkTensorARM (%s) was not "
"set to use protected memory.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.tensor).c_str());
}
const VkTensorARM dedicated_tensor = mem_info->GetDedicatedTensor();
if (dedicated_tensor != VK_NULL_HANDLE) {
if (dedicated_tensor != bind_info.tensor) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory, dedicated_tensor);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-tensor-09717", objlist, bind_info_loc.dot(Field::tensor),
"(%s) (dedicated) is different from bound tensor (%s).", FormatHandle(dedicated_tensor).c_str(),
FormatHandle(bind_info.tensor).c_str());
}
if (bind_info.memoryOffset != 0) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory, dedicated_tensor);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-memory-09806", objlist, bind_info_loc.dot(Field::memoryOffset),
"(%" PRIu64 ") for memory (%s) not zero.", bind_info.memoryOffset,
FormatHandle(bind_info.memory).c_str());
}
}
// Validate export memory handles. Check if the memory meets the tensor's external memory requirements
if (mem_info->IsExport() && (mem_info->export_handle_types & tensor_state->external_memory_handle_types) == 0) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-memory-09895", objlist, bind_info_loc.dot(Field::memory),
"(%s) has an external handleType of %s which does not include at least one "
"handle from VkTensorARM (%s) handleType %s.",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlags(mem_info->export_handle_types).c_str(),
FormatHandle(bind_info.tensor).c_str(),
string_VkExternalMemoryHandleTypeFlags(tensor_state->external_memory_handle_types).c_str());
}
// Validate import memory handles
if (mem_info->IsImportAHB()) {
skip |= ValidateTensorImportedHandleANDROID(tensor_state->external_memory_handle_types, bind_info.memory, bind_info.tensor, bind_info_loc);
} else if (mem_info->IsImport()) {
if ((mem_info->import_handle_type.value() & tensor_state->external_memory_handle_types) == 0) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-memory-09896", objlist, bind_info_loc.dot(Field::memory),
"(%s) was created with an import operation with handleType of %s which "
"is not set in VkExternalMemoryTensorCreateInfoARM::handleTypes (%s) for (%s)",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()),
string_VkExternalMemoryHandleTypeFlags(tensor_state->external_memory_handle_types).c_str(),
FormatHandle(bind_info.tensor).c_str());
}
// Check if buffer can be bound to memory imported from specific handle type
if (!HasExternalMemoryImportSupport(*tensor_state, mem_info->import_handle_type.value())) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError(
"VUID-VkImportMemoryWin32HandleInfoKHR-handleType-09861", objlist, bind_info_loc.dot(Field::memory),
"(%s) was imported from handleType %s but VkExternalTensorProperties does not report it as importable.",
FormatHandle(bind_info.memory).c_str(), string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()));
}
}
if (tensor_state->create_info.flags & VK_TENSOR_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_ARM) {
const auto allocate_flags = vku::FindStructInPNextChain<VkMemoryAllocateFlagsInfo>(mem_info->allocate_info.pNext);
if (allocate_flags) {
if (!(allocate_flags->flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT)) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-tensor-09943", objlist, bind_info_loc.dot(Field::memory),
"(%s) is missing VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT required for "
"VK_TENSOR_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_ARM tensor (%s).",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.tensor).c_str());
}
if (!(allocate_flags->flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
const LogObjectList objlist(bind_info.tensor, bind_info.memory);
skip |= LogError("VUID-VkBindTensorMemoryInfoARM-tensor-09944", objlist, bind_info_loc.dot(Field::memory),
"(%s) is missing VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT required for "
"VK_TENSOR_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_ARM tensor (%s).",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.tensor).c_str());
}
}
}
}
return skip;
}
bool CoreChecks::ValidateBindImageMemory(uint32_t bindInfoCount, const VkBindImageMemoryInfo *pBindInfos,
const ErrorObject &error_obj) const {
bool skip = false;
const auto &device_group_create_info = device_state->device_group_create_info;
const bool bind_image_mem_2 = error_obj.location.function != Func::vkBindImageMemory;
// Track all image sub resources if they are bound for bind_image_mem_2
// uint32_t[3] is which index in pBindInfos for max 3 planes
// Non disjoint images act as a single plane
vvl::unordered_map<VkImage, std::array<uint32_t, 3>> resources_bound;
bool is_drm = false;
for (uint32_t i = 0; i < bindInfoCount; i++) {
const Location loc = bind_image_mem_2 ? error_obj.location.dot(Field::pBindInfos, i) : error_obj.location.function;
const VkBindImageMemoryInfo &bind_info = pBindInfos[i];
if (auto image_state = Get<vvl::Image>(bind_info.image)) {
auto mem_info = Get<vvl::DeviceMemory>(bind_info.memory);
if (mem_info) {
// Track objects tied to memory
skip |= ValidateSetMemBinding(*mem_info, *image_state, loc);
}
const auto plane_info = vku::FindStructInPNextChain<VkBindImagePlaneMemoryInfo>(bind_info.pNext);
if (image_state->disjoint && plane_info == nullptr) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryInfo-image-07736", objlist, loc.dot(Field::image),
"is disjoint, add a VkBindImagePlaneMemoryInfo structure to the pNext chain of "
"VkBindImageMemoryInfo in order to bind planes of a disjoint image.");
}
// Currently disjoint planes only work with non-DRM
if (plane_info && IsValueIn(plane_info->planeAspect,
{VK_IMAGE_ASPECT_MEMORY_PLANE_0_BIT_EXT, VK_IMAGE_ASPECT_MEMORY_PLANE_1_BIT_EXT,
VK_IMAGE_ASPECT_MEMORY_PLANE_2_BIT_EXT, VK_IMAGE_ASPECT_MEMORY_PLANE_3_BIT_EXT})) {
is_drm = true;
}
// Need extra check for disjoint flag incase called without bindImage2 and don't want false positive errors
// no 'else' case as if that happens another VUID is already being triggered for it being invalid
if ((plane_info == nullptr) && (image_state->disjoint == false)) {
// Check non-disjoint images VkMemoryRequirements
// All validation using the image_state->requirements for external AHB is check in android only section
if (image_state->IsExternalBuffer() == false) {
const VkMemoryRequirements &mem_req = image_state->requirements[0];
// Validate memory requirements alignment
if (SafeModulo(bind_info.memoryOffset, mem_req.alignment) != 0) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-pNext-01616" : "VUID-vkBindImageMemory-None-10735";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memoryOffset),
"is %" PRIu64
" but must be an integer multiple of the VkMemoryRequirements::alignment value %" PRIu64
", returned from a call to vkGetImageMemoryRequirements with image.",
bind_info.memoryOffset, mem_req.alignment);
}
if (mem_info) {
const VkMemoryAllocateInfo &allocate_info = mem_info->allocate_info;
// Validate memory requirements size
if (!IgnoreAllocationSize(allocate_info) &&
mem_req.size > allocate_info.allocationSize - bind_info.memoryOffset) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-pNext-01617" : "VUID-vkBindImageMemory-None-10737";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc,
"allocationSize (%" PRIu64 ") minus memoryOffset (%" PRIu64 ") is %" PRIu64
" but must be at least as large as VkMemoryRequirements::size value %" PRIu64
", returned from a call to vkGetImageMemoryRequirements with image.",
allocate_info.allocationSize, bind_info.memoryOffset,
allocate_info.allocationSize - bind_info.memoryOffset, mem_req.size);
}
// Validate memory type used
{
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-pNext-01615" : "VUID-vkBindImageMemory-memory-01047";
skip |= ValidateMemoryTypes(*mem_info, mem_req.memoryTypeBits, loc.dot(Field::image), vuid);
}
}
}
if (bind_image_mem_2 == true) {
// since its a non-disjoint image, finding VkImage in map is a duplicate
auto it = resources_bound.find(image_state->VkHandle());
if (it == resources_bound.end()) {
std::array<uint32_t, 3> bound_index = {i, vvl::kNoIndex32, vvl::kNoIndex32};
resources_bound.emplace(image_state->VkHandle(), bound_index);
} else {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-vkBindImageMemory2-pBindInfos-04006", objlist, loc.dot(Field::image),
"is non-disjoint and is being bound twice at pBindInfos[%d]", it->second[0]);
}
}
} else if ((plane_info != nullptr) && (image_state->disjoint == true) && !is_drm) {
// Check disjoint images VkMemoryRequirements for given plane
int plane = 0;
// All validation using the image_state->plane*_requirements for external AHB is check in android only section
if (image_state->IsExternalBuffer() == false) {
const VkImageAspectFlagBits aspect = plane_info->planeAspect;
plane = vkuGetPlaneIndex(aspect);
const VkMemoryRequirements &disjoint_mem_req = image_state->requirements[plane];
// Validate memory requirements alignment
if (SafeModulo(bind_info.memoryOffset, disjoint_mem_req.alignment) != 0) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(
"VUID-VkBindImageMemoryInfo-pNext-01620", objlist, loc.dot(Field::memoryOffset),
"is %" PRIu64 " but must be an integer multiple of the VkMemoryRequirements::alignment value %" PRIu64
", returned from a call to vkGetImageMemoryRequirements2 with disjoint image for aspect plane %s.",
bind_info.memoryOffset, disjoint_mem_req.alignment, string_VkImageAspectFlagBits(aspect));
}
if (mem_info) {
const VkMemoryAllocateInfo &allocate_info = mem_info->allocate_info;
// Validate memory requirements size
if (disjoint_mem_req.size > allocate_info.allocationSize - bind_info.memoryOffset) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(
"VUID-VkBindImageMemoryInfo-pNext-01621", objlist, loc,
"allocationSize (%" PRIu64 ") minus memoryOffset (%" PRIu64 ") is %" PRIu64
" but must be at least as large as VkMemoryRequirements::size value %" PRIu64
", returned from a call to vkGetImageMemoryRequirements with disjoint image for aspect plane %s.",
allocate_info.allocationSize, bind_info.memoryOffset,
allocate_info.allocationSize - bind_info.memoryOffset, disjoint_mem_req.size,
string_VkImageAspectFlagBits(aspect));
}
// Validate memory type used
{
skip |= ValidateMemoryTypes(*mem_info, disjoint_mem_req.memoryTypeBits, loc.dot(Field::image),
"VUID-VkBindImageMemoryInfo-pNext-01619");
}
}
}
auto it = resources_bound.find(image_state->VkHandle());
if (it == resources_bound.end()) {
std::array<uint32_t, 3> bound_index = {vvl::kNoIndex32, vvl::kNoIndex32, vvl::kNoIndex32};
bound_index[plane] = i;
resources_bound.emplace(image_state->VkHandle(), bound_index);
} else {
if (it->second[plane] == vvl::kNoIndex32) {
it->second[plane] = i;
} else {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-vkBindImageMemory2-pBindInfos-04006", objlist, loc.dot(Field::image),
"is a disjoint image for plane %d but is being bound twice at "
"pBindInfos[%d]",
plane, it->second[plane]);
}
}
}
if (mem_info) {
// Validate bound memory range information
// if memory is exported to an AHB then the mem_info->allocationSize must be zero and this check is not needed
if ((mem_info->IsExport() == false) ||
((mem_info->export_handle_types & VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID) == 0)) {
skip |= ValidateInsertMemoryRange(VulkanTypedHandle(bind_info.image, kVulkanObjectTypeImage), *mem_info,
bind_info.memoryOffset, loc);
}
// Validate dedicated allocation
const VkImage dedicated_image = mem_info->GetDedicatedImage();
if (dedicated_image != VK_NULL_HANDLE) {
if (enabled_features.dedicatedAllocationImageAliasing) {
auto current_image_state = Get<vvl::Image>(bind_info.image);
if ((bind_info.memoryOffset != 0) || !current_image_state ||
!current_image_state->IsCreateInfoDedicatedAllocationImageAliasingCompatible(
mem_info->dedicated->create_info.image)) {
const char *vuid = bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-memory-02629"
: "VUID-vkBindImageMemory-memory-02629";
const LogObjectList objlist(bind_info.image, bind_info.memory, dedicated_image);
skip |= LogError(
vuid, objlist, loc.dot(Field::memory),
"(%s) is a dedicated memory allocation, but VkMemoryDedicatedAllocateInfo:: %s must compatible "
"with %s and memoryOffset %" PRIu64 " must be zero.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(dedicated_image).c_str(),
FormatHandle(bind_info.image).c_str(), bind_info.memoryOffset);
}
} else {
if ((bind_info.memoryOffset != 0) || (dedicated_image != bind_info.image)) {
const char *vuid = bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-memory-02628"
: "VUID-vkBindImageMemory-memory-02628";
const LogObjectList objlist(bind_info.image, bind_info.memory, dedicated_image);
skip |= LogError(
vuid, objlist, loc.dot(Field::memory),
"(%s) is a dedicated memory allocation, but VkMemoryDedicatedAllocateInfo::%s must be equal "
"to %s and memoryOffset %" PRIu64 " must be zero.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(dedicated_image).c_str(),
FormatHandle(bind_info.image).c_str(), bind_info.memoryOffset);
}
}
} else if (IsExtEnabled(extensions.vk_khr_dedicated_allocation) &&
(image_state->create_info.flags & VK_IMAGE_CREATE_DISJOINT_BIT) == 0) {
// If using Disjoint (for Multi-Planar, we need to include a VkImagePlaneMemoryRequirementsInfo) but if
// disjoint, it can't also have dedicated allocations
VkImageMemoryRequirementsInfo2 image_memory_requirements_info_2 = vku::InitStructHelper();
image_memory_requirements_info_2.image = bind_info.image;
VkMemoryDedicatedRequirements memory_dedicated_requirements = vku::InitStructHelper();
VkMemoryRequirements2 memory_requirements = vku::InitStructHelper(&memory_dedicated_requirements);
DispatchGetImageMemoryRequirements2Helper(api_version, device, &image_memory_requirements_info_2,
&memory_requirements);
if (memory_dedicated_requirements.requiresDedicatedAllocation) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-image-01445" : "VUID-vkBindImageMemory-image-01445";
if (dedicated_image == VK_NULL_HANDLE) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"was created without a VkMemoryDedicatedAllocateInfo in the pNext chain, but "
"vkGetImageMemoryRequirements2() reports "
"VkImageMemoryRequirementsInfo2::requiresDedicatedAllocation = VK_TRUE.");
} else if (dedicated_image != bind_info.image) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist,
loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::pNext).dot(Field::image),
"is %s, but VkBindImageMemoryInfo::image is %s.",
FormatHandle(dedicated_image).c_str(), FormatHandle(bind_info.image).c_str());
}
}
}
const VkBuffer dedicated_buffer = mem_info->GetDedicatedBuffer();
if (dedicated_buffer != VK_NULL_HANDLE) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-memory-10926" : "VUID-vkBindImageMemory-memory-10926";
skip |=
LogError(vuid, objlist, loc.pNext(Struct::VkMemoryDedicatedAllocateInfo, Field::pNext).dot(Field::buffer),
"is %s (not VK_NULL_HANDLE), but VkBindImageMemoryInfo::image is %s.",
FormatHandle(dedicated_buffer).c_str(), FormatHandle(bind_info.image).c_str());
}
auto chained_flags_struct = vku::FindStructInPNextChain<VkMemoryAllocateFlagsInfo>(mem_info->allocate_info.pNext);
const VkMemoryAllocateFlags memory_allocate_flags = chained_flags_struct ? chained_flags_struct->flags : 0;
if (image_state->create_info.flags & VK_IMAGE_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT) {
if ((memory_allocate_flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) == 0) {
const char *vuid = bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-descriptorBufferCaptureReplay-08113"
: "VUID-vkBindImageMemory-descriptorBufferCaptureReplay-08113";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::image),
"was created with the VK_IMAGE_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT bit set, "
"but the bound memory was allocated with %s and needs "
"VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT.",
string_VkMemoryAllocateFlags(memory_allocate_flags).c_str());
}
if ((memory_allocate_flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) == 0) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-image-09202" : "VUID-vkBindImageMemory-image-09202";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::image),
"was created with the VK_IMAGE_CREATE_DESCRIPTOR_BUFFER_CAPTURE_REPLAY_BIT_EXT bit set, "
"but the bound memory was allocated with %s and needs "
"VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.",
string_VkMemoryAllocateFlags(memory_allocate_flags).c_str());
}
}
// Validate export memory handles
if (mem_info->IsExport()) {
VkPhysicalDeviceImageDrmFormatModifierInfoEXT drm_format_modifier = vku::InitStructHelper();
drm_format_modifier.sharingMode = image_state->create_info.sharingMode;
drm_format_modifier.queueFamilyIndexCount = image_state->create_info.queueFamilyIndexCount;
drm_format_modifier.pQueueFamilyIndices = image_state->create_info.pQueueFamilyIndices;
VkPhysicalDeviceExternalImageFormatInfo external_info = vku::InitStructHelper();
VkPhysicalDeviceImageFormatInfo2 image_format_info = vku::InitStructHelper();
image_format_info.format = image_state->create_info.format;
image_format_info.type = image_state->create_info.imageType;
image_format_info.tiling = image_state->create_info.tiling;
image_format_info.usage = image_state->create_info.usage;
image_format_info.flags = image_state->create_info.flags;
// TODO - Want to use vvl::PnextChainExtract, but would need to cleanup (and test) rest of how we add the other
// pNext here
VkImageFormatListCreateInfo format_list = vku::InitStructHelper();
if (auto original_format_list =
vku::FindStructInPNextChain<VkImageFormatListCreateInfo>(image_state->create_info.pNext)) {
format_list.pViewFormats = original_format_list->pViewFormats;
format_list.viewFormatCount = original_format_list->viewFormatCount;
vvl::PnextChainAdd(&image_format_info, &format_list);
}
VkImageStencilUsageCreateInfo stencil_usage = vku::InitStructHelper();
if (auto original_stencil_usage =
vku::FindStructInPNextChain<VkImageStencilUsageCreateInfo>(image_state->create_info.pNext)) {
stencil_usage.stencilUsage = original_stencil_usage->stencilUsage;
vvl::PnextChainAdd(&image_format_info, &stencil_usage);
}
VkPhysicalDeviceImageViewImageFormatInfoEXT image_view_format = vku::InitStructHelper();
if (auto original_image_view_format = vku::FindStructInPNextChain<VkPhysicalDeviceImageViewImageFormatInfoEXT>(
image_state->create_info.pNext)) {
image_view_format.imageViewType = original_image_view_format->imageViewType;
vvl::PnextChainAdd(&image_format_info, &image_view_format);
}
// Add last as the Lambda will add to this
vvl::PnextChainAdd(&image_format_info, &external_info);
VkExternalImageFormatProperties external_properties = vku::InitStructHelper();
VkImageFormatProperties2 image_properties = vku::InitStructHelper(&external_properties);
bool export_supported = true;
auto validate_export_handle_types = [&](VkExternalMemoryHandleTypeFlagBits flag) {
external_info.handleType = flag;
external_info.pNext = NULL;
if (image_state->create_info.tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
VkImageDrmFormatModifierPropertiesEXT drm_modifier_properties = vku::InitStructHelper();
auto result =
DispatchGetImageDrmFormatModifierPropertiesEXT(device, bind_info.image, &drm_modifier_properties);
if (result == VK_SUCCESS) {
external_info.pNext = &drm_format_modifier;
drm_format_modifier.drmFormatModifier = drm_modifier_properties.drmFormatModifier;
}
}
auto result = DispatchGetPhysicalDeviceImageFormatProperties2Helper(api_version, physical_device,
&image_format_info, &image_properties);
if (result != VK_SUCCESS) {
export_supported = false;
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkExportMemoryAllocateInfo-handleTypes-09860", objlist, loc,
"The handle type (%s) specified by the memory's VkExportMemoryAllocateInfo, and the "
"VkImageCreateInfo\n%s"
"is not supported combination of parameters. "
"vkGetPhysicalDeviceImageFormatProperties2 returned back %s.",
string_VkExternalMemoryHandleTypeFlagBits(flag),
string_VkPhysicalDeviceImageFormatInfo2(image_format_info).c_str(),
string_VkResult(result));
return; // this exits lambda, not parent function
}
const auto external_features = external_properties.externalMemoryProperties.externalMemoryFeatures;
if ((external_features & VK_EXTERNAL_MEMORY_FEATURE_EXPORTABLE_BIT) == 0) {
export_supported = false;
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |=
LogError("VUID-VkExportMemoryAllocateInfo-handleTypes-09860", objlist, loc.dot(Field::memory),
"(%s) has VkExportMemoryAllocateInfo::handleTypes with the %s "
"flag set, which does not support VK_EXTERNAL_MEMORY_FEATURE_EXPORTABLE_BIT with the "
"VkImageCreateInfo\n%s",
FormatHandle(bind_info.memory).c_str(), string_VkExternalMemoryHandleTypeFlagBits(flag),
string_VkPhysicalDeviceImageFormatInfo2(image_format_info).c_str());
}
if ((external_features & VK_EXTERNAL_MEMORY_FEATURE_DEDICATED_ONLY_BIT) != 0) {
if (!mem_info->IsDedicatedImage()) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkMemoryAllocateInfo-pNext-00639", objlist, loc.dot(Field::memory),
"(%s) has VkExportMemoryAllocateInfo::handleTypes with the %s "
"flag set, which requires dedicated allocation for the VkImageCreateInfo\n%s"
"but the memory is allocated without dedicated allocation support.",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(flag),
string_VkPhysicalDeviceImageFormatInfo2(image_format_info).c_str());
}
}
};
IterateFlags<VkExternalMemoryHandleTypeFlagBits>(mem_info->export_handle_types, validate_export_handle_types);
// The types of external memory handles must be compatible
const auto compatible_types = external_properties.externalMemoryProperties.compatibleHandleTypes;
if (export_supported && (mem_info->export_handle_types & compatible_types) != mem_info->export_handle_types) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(
"VUID-VkExportMemoryAllocateInfo-handleTypes-09860", objlist, loc.dot(Field::memory),
"(%s) has VkExportMemoryAllocateInfo::handleTypes (%s) that are not "
"reported as compatible by vkGetPhysicalDeviceImageFormatProperties2 with VkImageCreateInfo\n%s",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlags(mem_info->export_handle_types).c_str(),
string_VkPhysicalDeviceImageFormatInfo2(image_format_info).c_str());
}
// Check if the memory meets the image's external memory requirements
if ((mem_info->export_handle_types & image_state->external_memory_handle_types) == 0) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-memory-02728" : "VUID-vkBindImageMemory-memory-02728";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) has an external handleType of %s which does not include at least "
"one handle from VkImage (%s) handleType %s.",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlags(mem_info->export_handle_types).c_str(),
FormatHandle(bind_info.image).c_str(),
string_VkExternalMemoryHandleTypeFlags(image_state->external_memory_handle_types).c_str());
}
}
// Validate import memory handles
if (mem_info->IsImportAHB() == true) {
skip |= ValidateImageImportedHandleANDROID(image_state->external_memory_handle_types, bind_info.memory,
bind_info.image, loc);
} else if (mem_info->IsImport() == true) {
if ((mem_info->import_handle_type.value() & image_state->external_memory_handle_types) == 0) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-memory-02989" : "VUID-vkBindImageMemory-memory-02989";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) was created with an import operation with handleType of %s "
"which is not set in the VkImage (%s) VkExternalMemoryImageCreateInfo::handleType (%s)",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()),
FormatHandle(bind_info.image).c_str(),
string_VkExternalMemoryHandleTypeFlags(image_state->external_memory_handle_types).c_str());
}
// Check if image can be bound to memory imported from specific handle type
if (!HasExternalMemoryImportSupport(*image_state, mem_info->import_handle_type.value())) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkImportMemoryWin32HandleInfoKHR-handleType-09861", objlist, loc.dot(Field::memory),
"(%s) was imported from handleType %s but VkExternalImageFormatProperties does not report "
"it as importable.",
FormatHandle(bind_info.memory).c_str(),
string_VkExternalMemoryHandleTypeFlagBits(mem_info->import_handle_type.value()));
}
}
// Validate mix of protected buffer and memory
if ((image_state->unprotected == false) && (mem_info->unprotected == true)) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-None-01901" : "VUID-vkBindImageMemory-None-01901";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) was not created with protected memory but the VkImage (%s) was "
"set to use protected memory.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.image).c_str());
} else if ((image_state->unprotected == true) && (mem_info->unprotected == false)) {
const char *vuid =
bind_image_mem_2 ? "VUID-VkBindImageMemoryInfo-None-01902" : "VUID-vkBindImageMemory-None-01902";
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(vuid, objlist, loc.dot(Field::memory),
"(%s) was created with protected memory but the VkImage (%s) was not "
"set to use protected memory.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.image).c_str());
}
}
const auto swapchain_info = vku::FindStructInPNextChain<VkBindImageMemorySwapchainInfoKHR>(bind_info.pNext);
if (swapchain_info) {
if (bind_info.memory != VK_NULL_HANDLE) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryInfo-pNext-01631", objlist, loc.dot(Field::memory),
"(%s) is not VK_NULL_HANDLE.", FormatHandle(bind_info.memory).c_str());
}
if (image_state->create_from_swapchain != swapchain_info->swapchain) {
const LogObjectList objlist(bind_info.image, image_state->create_from_swapchain, swapchain_info->swapchain);
// VU being worked on https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5078
skip |= LogError(
"UNASSIGNED-CoreValidation-BindImageMemory-Swapchain", objlist, loc.dot(Field::image),
"(%s) is created by %s, but the image is bound by %s. The image should be created and bound by the same "
"swapchain",
FormatHandle(bind_info.image).c_str(), FormatHandle(image_state->create_from_swapchain).c_str(),
FormatHandle(swapchain_info->swapchain).c_str());
}
if (auto swapchain_state = Get<vvl::Swapchain>(swapchain_info->swapchain)) {
if (swapchain_state->images.size() <= swapchain_info->imageIndex) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemorySwapchainInfoKHR-imageIndex-01644", objlist,
loc.pNext(Struct::VkBindImageMemorySwapchainInfoKHR, Field::swapchain),
"imageIndex (%" PRIu32 ") is out of bounds of %s images (size: %zu)",
swapchain_info->imageIndex, FormatHandle(swapchain_info->swapchain).c_str(),
swapchain_state->images.size());
}
if (swapchain_state->create_info.flags & VK_SWAPCHAIN_CREATE_DEFERRED_MEMORY_ALLOCATION_BIT_EXT) {
if (swapchain_state->images[swapchain_info->imageIndex].acquired == false) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemorySwapchainInfoKHR-swapchain-07756", objlist,
loc.pNext(Struct::VkBindImageMemorySwapchainInfoKHR, Field::swapchain),
"was created with VK_SWAPCHAIN_CREATE_DEFERRED_MEMORY_ALLOCATION_BIT_EXT but "
"imageIndex (%" PRIu32 ") has not been acquired",
swapchain_info->imageIndex);
}
}
}
} else {
if (image_state->create_from_swapchain) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryInfo-image-01630", objlist, loc,
"pNext doesn't include VkBindImageMemorySwapchainInfoKHR.");
}
if (!mem_info) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryInfo-pNext-01632", objlist, loc.dot(Field::memory), "(%s) is invalid.",
FormatHandle(bind_info.memory).c_str());
}
}
const auto bind_image_memory_device_group_info = vku::FindStructInPNextChain<VkBindImageMemoryDeviceGroupInfo>(bind_info.pNext);
if (bind_image_memory_device_group_info && bind_image_memory_device_group_info->splitInstanceBindRegionCount != 0) {
if (!(image_state->create_info.flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT)) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryInfo-pNext-01627", objlist,
loc.pNext(Struct::VkBindImageMemoryDeviceGroupInfo, Field::splitInstanceBindRegionCount),
"(%" PRId32
") is not 0 and %s is not created with "
"VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT.",
bind_image_memory_device_group_info->splitInstanceBindRegionCount,
FormatHandle(bind_info.image).c_str());
}
uint32_t phy_dev_square = 1;
if (device_group_create_info.physicalDeviceCount > 0) {
phy_dev_square = device_group_create_info.physicalDeviceCount * device_group_create_info.physicalDeviceCount;
}
if (bind_image_memory_device_group_info->splitInstanceBindRegionCount != phy_dev_square) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(
"VUID-VkBindImageMemoryDeviceGroupInfo-splitInstanceBindRegionCount-01636", objlist,
loc.pNext(Struct::VkBindImageMemoryDeviceGroupInfo, Field::splitInstanceBindRegionCount),
"(%" PRId32
") is not 0 and different from the number of physical devices in the logical device squared (%" PRIu32 ").",
bind_image_memory_device_group_info->splitInstanceBindRegionCount, phy_dev_square);
}
}
if (plane_info) {
// Checks for disjoint bit in image
if (image_state->disjoint == false) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError(
"VUID-VkBindImageMemoryInfo-pNext-01618", objlist, loc.dot(Field::image),
"(%s) is not created with VK_IMAGE_CREATE_DISJOINT_BIT, but pNext contains VkBindImagePlaneMemoryInfo.",
FormatHandle(bind_info.image).c_str());
}
// Make sure planeAspect is only a single, valid plane
const VkFormat image_format = image_state->create_info.format;
const VkImageAspectFlags aspect = plane_info->planeAspect;
const VkImageTiling image_tiling = image_state->create_info.tiling;
if ((image_tiling == VK_IMAGE_TILING_LINEAR) || (image_tiling == VK_IMAGE_TILING_OPTIMAL)) {
if (vkuFormatIsMultiplane(image_format) && !IsOnlyOneValidPlaneAspect(image_format, aspect)) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImagePlaneMemoryInfo-planeAspect-02283", objlist,
loc.pNext(Struct::VkBindImagePlaneMemoryInfo, Field::planeAspect),
"is %s but is invalid for %s.", string_VkImageAspectFlags(aspect).c_str(),
string_VkFormat(image_format));
}
} else if (image_tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
// TODO - Need to also check if lower then drmFormatModifierPlaneCount
if (GetBitSetCount(aspect) > 1 ||
!IsValueIn(VkImageAspectFlagBits(aspect),
{VK_IMAGE_ASPECT_MEMORY_PLANE_0_BIT_EXT, VK_IMAGE_ASPECT_MEMORY_PLANE_1_BIT_EXT,
VK_IMAGE_ASPECT_MEMORY_PLANE_2_BIT_EXT, VK_IMAGE_ASPECT_MEMORY_PLANE_3_BIT_EXT})) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImagePlaneMemoryInfo-planeAspect-02284", objlist,
loc.pNext(Struct::VkBindImagePlaneMemoryInfo, Field::planeAspect),
"is %s but is invalid for %s.", string_VkImageAspectFlags(aspect).c_str(),
string_VkFormat(image_format));
}
}
}
}
const auto bind_image_memory_device_group = vku::FindStructInPNextChain<VkBindImageMemoryDeviceGroupInfo>(bind_info.pNext);
if (bind_image_memory_device_group) {
if (bind_image_memory_device_group->deviceIndexCount > 0 &&
bind_image_memory_device_group->splitInstanceBindRegionCount > 0) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryDeviceGroupInfo-deviceIndexCount-01633", objlist, loc,
"VkBindImageMemoryDeviceGroupInfo has both deviceIndexCount (%" PRIu32
") and splitInstanceBindRegionCount (%" PRIu32 ") greater than 0.",
bind_image_memory_device_group->deviceIndexCount,
bind_image_memory_device_group->splitInstanceBindRegionCount);
}
if (bind_image_memory_device_group->deviceIndexCount != 0 &&
bind_image_memory_device_group->deviceIndexCount != device_group_create_info.physicalDeviceCount &&
device_group_create_info.physicalDeviceCount > 0) {
const LogObjectList objlist(bind_info.image, bind_info.memory);
skip |= LogError("VUID-VkBindImageMemoryDeviceGroupInfo-deviceIndexCount-01634", objlist,
loc.pNext(Struct::VkBindImageMemoryDeviceGroupInfo, Field::deviceIndexCount),
"is %" PRIu32 ", but the number of physical devices in the logical device is %" PRIu32 ".",
bind_image_memory_device_group->deviceIndexCount, device_group_create_info.physicalDeviceCount);
}
}
}
// Check to make sure all disjoint planes were bound
for (auto &resource : resources_bound) {
auto image_state = Get<vvl::Image>(resource.first);
if (image_state && image_state->disjoint == true && !is_drm) {
uint32_t total_planes = vkuFormatPlaneCount(image_state->create_info.format);
for (uint32_t i = 0; i < total_planes; i++) {
if (resource.second[i] == vvl::kNoIndex32) {
skip |= LogError("VUID-vkBindImageMemory2-pBindInfos-02858", resource.first, error_obj.location,
"Plane %" PRIu32
" of the disjoint image was not bound. All %d planes need to bound individually "
"in separate pBindInfos in a single call.",
i, total_planes);
}
}
}
}
return skip;
}
bool CoreChecks::PreCallValidateBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory memory, VkDeviceSize memoryOffset,
const ErrorObject &error_obj) const {
bool skip = false;
if (auto image_state = Get<vvl::Image>(image)) {
// Checks for no disjoint bit
if (image_state->disjoint == true) {
const LogObjectList objlist(image, memory);
skip |= LogError("VUID-vkBindImageMemory-image-01608", objlist, error_obj.location.dot(Field::image),
"was created with the VK_IMAGE_CREATE_DISJOINT_BIT (need to use vkBindImageMemory2).");
}
}
VkBindImageMemoryInfo bind_info = vku::InitStructHelper();
bind_info.image = image;
bind_info.memory = memory;
bind_info.memoryOffset = memoryOffset;
skip |= ValidateBindImageMemory(1, &bind_info, error_obj);
return skip;
}
void CoreChecks::PostCallRecordBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory memory, VkDeviceSize memoryOffset,
const RecordObject &record_obj) {
if (record_obj.result != VK_SUCCESS) {
return;
}
if (auto image_state = Get<vvl::Image>(image)) {
image_state->SetInitialLayoutMap();
}
}
bool CoreChecks::PreCallValidateBindImageMemory2(VkDevice device, uint32_t bindInfoCount, const VkBindImageMemoryInfo *pBindInfos,
const ErrorObject &error_obj) const {
return ValidateBindImageMemory(bindInfoCount, pBindInfos, error_obj);
}
void CoreChecks::PostCallRecordBindImageMemory2(VkDevice device, uint32_t bindInfoCount, const VkBindImageMemoryInfo *pBindInfos,
const RecordObject &record_obj) {
// Don't check |record_obj.result| as some binds might still be valid
for (uint32_t i = 0; i < bindInfoCount; i++) {
if (auto image_state = Get<vvl::Image>(pBindInfos[i].image)) {
// Need to protect if some VkBindMemoryStatus are not VK_SUCCESS
if (!image_state->HasBeenBound()) continue;
image_state->SetInitialLayoutMap();
}
}
}
bool CoreChecks::PreCallValidateBindImageMemory2KHR(VkDevice device, uint32_t bindInfoCount,
const VkBindImageMemoryInfo *pBindInfos, const ErrorObject &error_obj) const {
return PreCallValidateBindImageMemory2(device, bindInfoCount, pBindInfos, error_obj);
}
void CoreChecks::PostCallRecordBindImageMemory2KHR(VkDevice device, uint32_t bindInfoCount, const VkBindImageMemoryInfo *pBindInfos,
const RecordObject &record_obj) {
PostCallRecordBindImageMemory2(device, bindInfoCount, pBindInfos, record_obj);
}
bool CoreChecks::ValidateBufferSparseMemoryBindAlignments(const VkSparseMemoryBind &bind, const vvl::Buffer &buffer,
const Location &bind_loc, const Location &buffer_bind_info_loc) const {
bool skip = false;
if (SafeModulo(bind.resourceOffset, buffer.requirements.alignment) != 0) {
const LogObjectList objlist(bind.memory, buffer.Handle());
skip |=
LogError("VUID-VkSparseMemoryBind-resourceOffset-09491", objlist, buffer_bind_info_loc.dot(Field::buffer),
"(%s) is being bound, but %s.resourceOffset (%" PRIu64
") is not a multiple of required memory alignment (%" PRIu64 ").",
FormatHandle(buffer).c_str(), bind_loc.Fields().c_str(), bind.resourceOffset, buffer.requirements.alignment);
}
if (SafeModulo(bind.memoryOffset, buffer.requirements.alignment) != 0) {
const LogObjectList objlist(bind.memory, buffer.Handle());
skip |= LogError("VUID-VkSparseMemoryBind-resourceOffset-09491", objlist, buffer_bind_info_loc.dot(Field::buffer),
"(%s) is being bound, but %s.memoryOffset (%" PRIu64
") is not a multiple of required memory alignment (%" PRIu64 ").",
FormatHandle(buffer).c_str(), bind_loc.Fields().c_str(), bind.memoryOffset, buffer.requirements.alignment);
}
if (SafeModulo(bind.size, buffer.requirements.alignment) != 0) {
const LogObjectList objlist(bind.memory, buffer.Handle());
skip |=
LogError("VUID-VkSparseMemoryBind-resourceOffset-09491", objlist, buffer_bind_info_loc.dot(Field::buffer),
"(%s) is being bound, but %s.size (%" PRIu64 ") is not a multiple of required memory alignment (%" PRIu64 ").",
FormatHandle(buffer).c_str(), bind_loc.Fields().c_str(), bind.size, buffer.requirements.alignment);
}
return skip;
}
bool CoreChecks::ValidateImageSparseMemoryBindAlignments(const VkSparseMemoryBind &bind, const vvl::Image &image,
const Location &bind_loc, const Location &image_bind_info_loc) const {
bool skip = false;
if (SafeModulo(bind.resourceOffset, image.requirements[0].alignment) != 0) {
const LogObjectList objlist(bind.memory, image.Handle());
skip |=
LogError("VUID-VkSparseMemoryBind-resourceOffset-09492", objlist, image_bind_info_loc.dot(Field::image),
"(%s) is being bound, but %s.resourceOffset (%" PRIu64
") is not a multiple of required memory alignment (%" PRIu64 ").",
FormatHandle(image).c_str(), bind_loc.Fields().c_str(), bind.resourceOffset, image.requirements[0].alignment);
}
if (SafeModulo(bind.memoryOffset, image.requirements[0].alignment) != 0) {
const LogObjectList objlist(bind.memory, image.Handle());
skip |= LogError(
"VUID-VkSparseMemoryBind-resourceOffset-09492", objlist, image_bind_info_loc.dot(Field::image),
"(%s) is being bound, but %s.memoryOffset (%" PRIu64 ") is not a multiple of required memory alignment (%" PRIu64 ").",
FormatHandle(image).c_str(), bind_loc.Fields().c_str(), bind.memoryOffset, image.requirements[0].alignment);
}
return skip;
}
bool CoreChecks::ValidateSparseMemoryBind(const VkSparseMemoryBind &bind, const VkMemoryRequirements &requirements,
VkDeviceSize resource_size, VkExternalMemoryHandleTypeFlags external_handle_types,
const VulkanTypedHandle &resource_handle, const Location &loc) const {
bool skip = false;
if (auto memory_state = Get<vvl::DeviceMemory>(bind.memory)) {
if (!((uint32_t(1) << memory_state->allocate_info.memoryTypeIndex) & requirements.memoryTypeBits)) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-memory-01096", objlist, loc.dot(Field::memory),
"has a type index (%" PRIu32 ") that is not among the allowed types mask (0x%" PRIX32
") for this resource.",
memory_state->allocate_info.memoryTypeIndex, requirements.memoryTypeBits);
}
if (SafeModulo(bind.memoryOffset, requirements.alignment) != 0) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-memory-01096", objlist, loc.dot(Field::memoryOffset),
"(%" PRIu64 ") is not a multiple of required memory alignment (%" PRIu64 ")", bind.memoryOffset,
requirements.alignment);
}
if (phys_dev_mem_props.memoryTypes[memory_state->allocate_info.memoryTypeIndex].propertyFlags &
VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-memory-01097", objlist, loc.dot(Field::memory),
"type has VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT bit set.");
}
if (bind.memoryOffset >= memory_state->allocate_info.allocationSize) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-memoryOffset-01101", objlist, loc.dot(Field::memoryOffset),
"(%" PRIu64 ") must be less than the size of memory (%" PRIu64 ")", bind.memoryOffset,
memory_state->allocate_info.allocationSize);
}
if ((memory_state->allocate_info.allocationSize - bind.memoryOffset) < bind.size) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-size-01102", objlist, loc.dot(Field::size),
"(%" PRIu64 ") must be less than or equal to the size of memory (%" PRIu64
") minus memoryOffset (%" PRIu64 ").",
bind.size, memory_state->allocate_info.allocationSize, bind.memoryOffset);
}
if (memory_state->IsExport()) {
if (!(memory_state->export_handle_types & external_handle_types)) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-memory-02730", objlist,
loc.dot(Field::memory).pNext(Struct::VkExportMemoryAllocateInfo).dot(Field::handleTypes),
"is %s, but the external handle types specified in resource are %s.",
string_VkExternalMemoryHandleTypeFlags(memory_state->export_handle_types).c_str(),
string_VkExternalMemoryHandleTypeFlags(external_handle_types).c_str());
}
}
if (memory_state->IsImport()) {
if (!(*memory_state->import_handle_type & external_handle_types)) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-memory-02731", objlist, loc.dot(Field::memory),
"was created with memory import operation, with handle type %s, but the external handle types "
"specified in resource are %s.",
string_VkExternalMemoryHandleTypeFlagBits(*memory_state->import_handle_type),
string_VkExternalMemoryHandleTypeFlags(external_handle_types).c_str());
}
}
}
if (bind.size <= 0) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-size-01098", objlist, loc.dot(Field::size),
"(%" PRIu64 ") must be greater than 0.", bind.size);
}
if (resource_size <= bind.resourceOffset) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |=
LogError("VUID-VkSparseMemoryBind-resourceOffset-01099", objlist, loc.dot(Field::resourceOffset),
"(%" PRIu64 ") must be less than the size of the resource (%" PRIu64 ").", bind.resourceOffset, resource_size);
}
if ((resource_size - bind.resourceOffset) < bind.size) {
const LogObjectList objlist(bind.memory, resource_handle);
skip |= LogError("VUID-VkSparseMemoryBind-size-01100", objlist, loc.dot(Field::size),
"(%" PRIu64 ") must be less than or equal to the size of the resource (%" PRIu64
") minus resourceOffset (%" PRIu64 ").",
bind.size, resource_size, bind.resourceOffset);
}
return skip;
}
bool CoreChecks::ValidateImageSubresourceSparseImageMemoryBind(vvl::Image const &image_state, VkImageSubresource const &subresource,
const Location &bind_loc, const Location &subresource_loc) const {
bool skip = false;
skip |= ValidateImageAspectMask(image_state.VkHandle(), image_state.create_info.format, subresource.aspectMask,
image_state.disjoint, bind_loc, "VUID-VkSparseImageMemoryBindInfo-subresource-01106");
if (subresource.mipLevel >= image_state.create_info.mipLevels) {
skip |=
LogError("VUID-VkSparseImageMemoryBindInfo-subresource-01722", image_state.Handle(),
subresource_loc.dot(Field::mipLevel), "(%" PRIu32 ") is not less than mipLevels (%" PRIu32 ") of %s.image.",
subresource.mipLevel, image_state.create_info.mipLevels, bind_loc.Fields().c_str());
}
if (subresource.arrayLayer >= image_state.create_info.arrayLayers) {
skip |= LogError("VUID-VkSparseImageMemoryBindInfo-subresource-01723", image_state.Handle(),
subresource_loc.dot(Field::arrayLayer),
"(%" PRIu32 ") is not less than arrayLayers (%" PRIu32 ") of %s.image.", subresource.arrayLayer,
image_state.create_info.arrayLayers, bind_loc.Fields().c_str());
}
return skip;
}
// This will only be called after we are sure the image was created with VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT
bool CoreChecks::ValidateSparseImageMemoryBind(vvl::Image const *image_state, VkSparseImageMemoryBind const &bind,
const Location &bind_loc, const Location &memory_loc) const {
bool skip = false;
if (auto const memory_state = Get<vvl::DeviceMemory>(bind.memory)) {
// TODO: The closest one should be VUID-VkSparseImageMemoryBind-memory-01105 instead of the mentioned
// one. We also need to check memory_bind.memory
if (bind.memoryOffset >= memory_state->allocate_info.allocationSize) {
skip |= LogError("VUID-VkSparseMemoryBind-memoryOffset-01101", bind.memory, bind_loc.dot(Field::memoryOffset),
"(%" PRIu64 ") is not less than the size (%" PRIu64 ") of memory.", bind.memoryOffset,
memory_state->allocate_info.allocationSize);
}
// TODO: We cannot validate the requirement size since there is no way
// to calculate the size of an optimal tiled arbitrary image region (as of now).
const VkMemoryRequirements &requirement = image_state->requirements[0];
if (SafeModulo(bind.memoryOffset, requirement.alignment) != 0) {
skip |= LogError("VUID-VkSparseImageMemoryBind-memory-01105", bind.memory, memory_loc.dot(Field::memoryOffset),
"(%" PRIu64 ") is not a multiple of the required alignment (%" PRIu64 ").", bind.memoryOffset,
requirement.alignment);
}
skip |= ValidateMemoryTypes(*memory_state.get(), requirement.memoryTypeBits, memory_loc.dot(Field::memory),
"VUID-VkSparseImageMemoryBind-memory-01105");
if (memory_state->IsExport()) {
if (!(memory_state->export_handle_types & image_state->external_memory_handle_types)) {
const LogObjectList objlist(bind.memory, image_state->Handle());
skip |= LogError("VUID-VkSparseImageMemoryBind-memory-02732", objlist,
memory_loc.dot(Field::memory).pNext(Struct::VkExportMemoryAllocateInfo).dot(Field::handleTypes),
"is %s, but the external handle types specified in resource are %s.",
string_VkExternalMemoryHandleTypeFlags(memory_state->export_handle_types).c_str(),
string_VkExternalMemoryHandleTypeFlags(image_state->external_memory_handle_types).c_str());
}
}
if (memory_state->IsImport()) {
if (!(*memory_state->import_handle_type & image_state->external_memory_handle_types)) {
const LogObjectList objlist(bind.memory, image_state->Handle());
skip |= LogError("VUID-VkSparseImageMemoryBind-memory-02733", objlist, memory_loc.dot(Field::memory),
"was created with memory import operation, with handle type %s, but the external handle types "
"specified in resource are %s.",
string_VkExternalMemoryHandleTypeFlagBits(*memory_state->import_handle_type),
string_VkExternalMemoryHandleTypeFlags(image_state->external_memory_handle_types).c_str());
}
}
}
if (!image_state) {
return skip;
}
skip |=
ValidateImageSubresourceSparseImageMemoryBind(*image_state, bind.subresource, bind_loc, memory_loc.dot(Field::subresource));
const VkSparseImageMemoryRequirements *requirements = nullptr;
for (size_t memoryReqNdx = 0; memoryReqNdx < image_state->sparse_requirements.size(); ++memoryReqNdx) {
if (image_state->sparse_requirements[memoryReqNdx].formatProperties.aspectMask & bind.subresource.aspectMask) {
requirements = &image_state->sparse_requirements[memoryReqNdx];
break;
}
}
if (requirements) {
VkExtent3D const &granularity = requirements->formatProperties.imageGranularity;
if (SafeModulo(bind.offset.x, granularity.width) != 0) {
skip |= LogError("VUID-VkSparseImageMemoryBind-offset-01107", image_state->Handle(),
bind_loc.dot(Field::offset).dot(Field::x),
"(%" PRId32
") must be a multiple of the sparse image block width "
"(VkSparseImageFormatProperties::imageGranularity.width (%" PRIu32 ")) of the image.",
bind.offset.x, granularity.width);
}
if (SafeModulo(bind.offset.y, granularity.height) != 0) {
skip |= LogError("VUID-VkSparseImageMemoryBind-offset-01109", image_state->Handle(),
bind_loc.dot(Field::offset).dot(Field::y),
"(%" PRId32
") must be a multiple of the sparse image block height "
"(VkSparseImageFormatProperties::imageGranularity.height (%" PRIu32 ")) of the image.",
bind.offset.y, granularity.height);
}
if (SafeModulo(bind.offset.z, granularity.depth) != 0) {
skip |= LogError("VUID-VkSparseImageMemoryBind-offset-01111", image_state->Handle(),
bind_loc.dot(Field::offset).dot(Field::z),
"(%" PRId32
") must be a multiple of the sparse image block depth "
"(VkSparseImageFormatProperties::imageGranularity.depth (%" PRIu32 ")) of the image.",
bind.offset.z, granularity.depth);
}
VkExtent3D const subresource_extent = image_state->GetEffectiveSubresourceExtent(bind.subresource);
if ((SafeModulo(bind.extent.width, granularity.width) != 0) &&
((bind.extent.width + bind.offset.x) != subresource_extent.width)) {
skip |= LogError("VUID-VkSparseImageMemoryBind-extent-01108", image_state->Handle(),
bind_loc.dot(Field::extent).dot(Field::width),
"(%" PRIu32
") must either be a multiple of the sparse image block width "
"(VkSparseImageFormatProperties::imageGranularity.width (%" PRIu32
")) of the image, or else (extent.width + offset.x) (%" PRIu32
") must equal the width of the image subresource (%" PRIu32 ").",
bind.extent.width, granularity.width, bind.extent.width + bind.offset.x, subresource_extent.width);
}
if ((SafeModulo(bind.extent.height, granularity.height) != 0) &&
((bind.extent.height + bind.offset.y) != subresource_extent.height)) {
skip |= LogError("VUID-VkSparseImageMemoryBind-extent-01110", image_state->Handle(),
bind_loc.dot(Field::extent).dot(Field::height),
"(%" PRIu32
") must either be a multiple of the sparse image block height "
"(VkSparseImageFormatProperties::imageGranularity.height (%" PRIu32
")) of the image, or else (extent.height + offset.y) (%" PRIu32
") must equal the height of the image subresource (%" PRIu32 ").",
bind.extent.height, granularity.height, bind.extent.height + bind.offset.y, subresource_extent.height);
}
if ((SafeModulo(bind.extent.depth, granularity.depth) != 0) &&
((bind.extent.depth + bind.offset.z) != subresource_extent.depth)) {
skip |= LogError("VUID-VkSparseImageMemoryBind-extent-01112", image_state->Handle(),
bind_loc.dot(Field::extent).dot(Field::depth),
"(%" PRIu32
") must either be a multiple of the sparse image block depth "
"(VkSparseImageFormatProperties::imageGranularity.depth (%" PRIu32
")) of the image, or else (extent.depth + offset.z) (%" PRIu32
") must equal the depth of the image subresource (%" PRIu32 ").",
bind.extent.depth, granularity.depth, bind.extent.depth + bind.offset.z, subresource_extent.depth);
}
}
return skip;
}
bool CoreChecks::PreCallValidateGetBufferDeviceAddress(VkDevice device, const VkBufferDeviceAddressInfo *pInfo,
const ErrorObject &error_obj) const {
bool skip = false;
const LogObjectList objlist(device, pInfo->buffer);
if (!enabled_features.bufferDeviceAddress && !enabled_features.bufferDeviceAddressEXT) {
skip |= LogError("VUID-vkGetBufferDeviceAddress-bufferDeviceAddress-03324", objlist, error_obj.location,
"The bufferDeviceAddress feature must be enabled.");
}
if (device_state->physical_device_count > 1 && !enabled_features.bufferDeviceAddressMultiDevice &&
!enabled_features.bufferDeviceAddressMultiDeviceEXT) {
skip |= LogError("VUID-vkGetBufferDeviceAddress-device-03325", objlist, error_obj.location,
"If device was created with multiple physical devices, then the "
"bufferDeviceAddressMultiDevice feature must be enabled.");
}
if (auto buffer_state = Get<vvl::Buffer>(pInfo->buffer)) {
const Location info_loc = error_obj.location.dot(Field::pInfo);
if ((buffer_state->create_info.flags & VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) == 0) {
skip |= ValidateMemoryIsBoundToBuffer(objlist, *buffer_state, info_loc.dot(Field::buffer),
"VUID-vkGetBufferDeviceAddress-bufferDeviceAddress-03324");
}
skip |= ValidateBufferUsageFlags(objlist, *buffer_state, VK_BUFFER_USAGE_2_SHADER_DEVICE_ADDRESS_BIT, true,
"VUID-VkBufferDeviceAddressInfo-buffer-02601", info_loc.dot(Field::buffer));
}
return skip;
}
bool CoreChecks::PreCallValidateGetBufferDeviceAddressEXT(VkDevice device, const VkBufferDeviceAddressInfo *pInfo,
const ErrorObject &error_obj) const {
return PreCallValidateGetBufferDeviceAddress(device, pInfo, error_obj);
}
bool CoreChecks::PreCallValidateGetBufferDeviceAddressKHR(VkDevice device, const VkBufferDeviceAddressInfo *pInfo,
const ErrorObject &error_obj) const {
return PreCallValidateGetBufferDeviceAddress(device, pInfo, error_obj);
}
bool CoreChecks::PreCallValidateGetBufferOpaqueCaptureAddress(VkDevice device, const VkBufferDeviceAddressInfo *pInfo,
const ErrorObject &error_obj) const {
bool skip = false;
const LogObjectList objlist(device, pInfo->buffer);
if (!enabled_features.bufferDeviceAddress || !enabled_features.bufferDeviceAddressCaptureReplay) {
skip |= LogError("VUID-vkGetBufferOpaqueCaptureAddress-None-03326", objlist, error_obj.location,
"The bufferDeviceAddress and bufferDeviceAddressCaptureReplay feature must be enabled.");
}
if (device_state->physical_device_count > 1 && !enabled_features.bufferDeviceAddressMultiDevice) {
skip |= LogError("VUID-vkGetBufferOpaqueCaptureAddress-device-03327", objlist, error_obj.location,
"If device was created with multiple physical devices, then the "
"bufferDeviceAddressMultiDevice feature must be enabled.");
}
if (auto buffer_state = Get<vvl::Buffer>(pInfo->buffer)) {
const Location info_loc = error_obj.location.dot(Field::pInfo);
if ((buffer_state->create_info.flags & VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) == 0) {
skip |= LogError("VUID-vkGetBufferOpaqueCaptureAddress-pInfo-10725", objlist, info_loc.dot(Field::buffer),
"was not created with VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
}
skip |= ValidateBufferUsageFlags(objlist, *buffer_state, VK_BUFFER_USAGE_2_SHADER_DEVICE_ADDRESS_BIT, true,
"VUID-VkBufferDeviceAddressInfo-buffer-02601", info_loc.dot(Field::buffer));
}
return skip;
}
bool CoreChecks::PreCallValidateGetBufferOpaqueCaptureAddressKHR(VkDevice device, const VkBufferDeviceAddressInfo *pInfo,
const ErrorObject &error_obj) const {
return PreCallValidateGetBufferOpaqueCaptureAddress(device, pInfo, error_obj);
}
bool CoreChecks::PreCallValidateGetDeviceMemoryOpaqueCaptureAddress(VkDevice device,
const VkDeviceMemoryOpaqueCaptureAddressInfo *pInfo,
const ErrorObject &error_obj) const {
bool skip = false;
const LogObjectList objlst(device, pInfo->memory);
if (!enabled_features.bufferDeviceAddress || !enabled_features.bufferDeviceAddressCaptureReplay) {
skip |= LogError("VUID-vkGetDeviceMemoryOpaqueCaptureAddress-None-03334", objlst, error_obj.location,
"The bufferDeviceAddress and bufferDeviceAddressCaptureReplay feature must be enabled.");
}
if (device_state->physical_device_count > 1 && !enabled_features.bufferDeviceAddressMultiDevice) {
skip |= LogError("VUID-vkGetDeviceMemoryOpaqueCaptureAddress-device-03335", objlst, error_obj.location,
"If device was created with multiple physical devices, then the "
"bufferDeviceAddressMultiDevice feature was not enabled.");
}
if (auto mem_info = Get<vvl::DeviceMemory>(pInfo->memory)) {
auto chained_flags_struct = vku::FindStructInPNextChain<VkMemoryAllocateFlagsInfo>(mem_info->allocate_info.pNext);
if (!chained_flags_struct) {
skip |= LogError("VUID-VkDeviceMemoryOpaqueCaptureAddressInfo-memory-03336", objlst, error_obj.location,
"memory was created without a VkMemoryAllocateFlagsInfo structure, which is needed as the memory must "
"have been allocated with both VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT and "
"VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
} else if ((chained_flags_struct->flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) == 0) {
skip |= LogError("VUID-VkDeviceMemoryOpaqueCaptureAddressInfo-memory-03336", objlst, error_obj.location,
"memory must have been allocated with VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT "
"(VkMemoryAllocateFlagsInfo::flags were %s).",
string_VkMemoryAllocateFlags(chained_flags_struct->flags).c_str());
} else if ((chained_flags_struct->flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) == 0) {
skip |= LogError("VUID-vkGetDeviceMemoryOpaqueCaptureAddress-pInfo-10727", objlst, error_obj.location,
"memory must have been allocated with VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT "
"(VkMemoryAllocateFlagsInfo::flags were %s).",
string_VkMemoryAllocateFlags(chained_flags_struct->flags).c_str());
}
}
return skip;
}
bool CoreChecks::PreCallValidateGetDeviceMemoryOpaqueCaptureAddressKHR(VkDevice device,
const VkDeviceMemoryOpaqueCaptureAddressInfo *pInfo,
const ErrorObject &error_obj) const {
return PreCallValidateGetDeviceMemoryOpaqueCaptureAddress(device, pInfo, error_obj);
}
bool CoreChecks::ValidateMemoryIsBoundToBuffer(LogObjectList objlist, const vvl::Buffer &buffer_state, const Location &buffer_loc,
const char *vuid) const {
bool skip = false;
if (!buffer_state.sparse) {
objlist.add(buffer_state.Handle());
skip |= VerifyBoundMemoryIsValid(buffer_state.MemoryState(), objlist, buffer_state.Handle(), buffer_loc, vuid);
}
return skip;
}
// Used when only need to check a VkDeviceAddress is tied to a VkBuffer
bool CoreChecks::ValidateDeviceAddress(const Location &device_address_loc, const LogObjectList &objlist,
VkDeviceAddress device_address) const {
BufferAddressValidation<0> buffer_address_validator = {};
return buffer_address_validator.ValidateDeviceAddress(*this, device_address_loc, objlist, device_address);
}
bool CoreChecks::PreCallValidateBindTensorMemoryARM(VkDevice device, uint32_t bindInfoCount,
const VkBindTensorMemoryInfoARM *pBindInfos,
const ErrorObject &error_obj) const {
bool skip = false;
skip |= ValidateBindTensorMemoryARM(bindInfoCount, pBindInfos, error_obj);
return skip;
}
bool CoreChecks::ValidateBindDataGraphPipelineSessionMemoryARM(const VkBindDataGraphPipelineSessionMemoryInfoARM &bind_info,
const Location &bind_info_loc) const {
bool skip = false;
auto session_state = Get<vvl::DataGraphPipelineSession>(bind_info.session);
ASSERT_AND_RETURN_SKIP(session_state);
const LogObjectList objlist(bind_info.session, bind_info.memory);
const auto& bp_requirements = session_state->BindPointReqs();
const auto bpr_match = std::find_if(bp_requirements.begin(), bp_requirements.end(), [bind_info](const VkDataGraphPipelineSessionBindPointRequirementARM& bpr) {
return bpr.bindPoint == bind_info.bindPoint;
});
if (bpr_match == bp_requirements.end()) {
std::stringstream required_bindpoints;
for (auto &bpr : bp_requirements) {
if (!required_bindpoints.str().empty()) {
required_bindpoints << ", ";
}
required_bindpoints << string_VkDataGraphPipelineSessionBindPointARM(bpr.bindPoint);
}
skip |= LogError("VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-bindPoint-09786", objlist,
bind_info_loc.dot(Field::bindPoint), "bindPoint (%s) not found in requirements (%s).",
string_VkDataGraphPipelineSessionBindPointARM(bind_info.bindPoint), required_bindpoints.str().c_str());
} else {
if (bind_info.objectIndex > bpr_match->numObjects) {
skip |=
LogError("VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-objectIndex-09805", objlist,
bind_info_loc.dot(Field::objectIndex),
"(%" PRIu32 ") is greater than numObjects (%" PRIu32 ") defined for bindPoint (%s)", bind_info.objectIndex,
bpr_match->numObjects, string_VkDataGraphPipelineSessionBindPointARM(bind_info.bindPoint));
}
}
/* no point continuing if the bindpoint isn't valid: either not found or the index will cause a buffer overrun later on */
if (skip) {
return true;
}
const auto& mem_reqs_map = session_state->MemReqsMap();
const auto &bound_memory_map = session_state->BoundMemoryMap();
if (bound_memory_map.find(bind_info.bindPoint) != bound_memory_map.end()) {
for (const auto &bound_mem : bound_memory_map.at(bind_info.bindPoint)) {
if (bound_mem.memory_state->VkHandle() == bind_info.memory) {
skip |= LogError(
"VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-session-09785", objlist, bind_info_loc.dot(Field::bindPoint),
"attempting to bind %s to %s which has already been bound to %s.", FormatHandle(bind_info.memory).c_str(),
FormatHandle(session_state->Handle()).c_str(), FormatHandle(bound_mem.memory_state->Handle()).c_str());
}
}
}
auto mem_info = Get<vvl::DeviceMemory>(bind_info.memory);
ASSERT_AND_RETURN_SKIP(mem_info);
skip |= ValidateInsertMemoryRange(VulkanTypedHandle(bind_info.session, kVulkanObjectTypeDataGraphPipelineSessionARM), *mem_info,
bind_info.memoryOffset, bind_info_loc.dot(Field::memoryOffset));
if (mem_reqs_map.find(bind_info.bindPoint) != mem_reqs_map.end()) {
const auto &mem_reqs = mem_reqs_map.at(bind_info.bindPoint)[bind_info.objectIndex];
skip |= ValidateMemoryTypes(*mem_info, mem_reqs.memoryTypeBits, bind_info_loc.dot(Field::session),
"VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-memory-09788");
if (SafeModulo(bind_info.memoryOffset, mem_reqs.alignment) != 0) {
skip |= LogError("VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-memoryOffset-09789", objlist,
bind_info_loc.dot(Field::memoryOffset),
"(%" PRIu64 ") must be an integer multiple of the alignment member (%" PRIu64
") of the VkMemoryRequirements structure returned from a call to "
"vkGetDataGraphPipelineSessionMemoryRequirementsARM with session",
bind_info.memoryOffset, mem_reqs.alignment);
}
if (mem_reqs.size > (mem_info->allocate_info.allocationSize - bind_info.memoryOffset)) {
skip |= LogError(
"VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-size-09790", objlist, bind_info_loc.dot(Field::allocationSize),
"(%" PRIu64 ") minus memoryOffset (%" PRIu64 ") is less than VkMemoryRequirements::size (%" PRIu64 ").",
mem_info->allocate_info.allocationSize, bind_info.memoryOffset, mem_reqs.size);
}
}
// Validate compatible protected session and memory
if (!session_state->Unprotected() && mem_info->unprotected) {
const char *vuid = "VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-session-09791";
skip |= LogError(vuid, objlist, bind_info_loc.dot(Field::memory),
"(%s) was not created with protected memory but the VkDataGraphPipelineSessionARM (%s) was "
"set to use protected memory.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.session).c_str());
} else if (session_state->Unprotected() && !mem_info->unprotected) {
const char *vuid = "VUID-VkBindDataGraphPipelineSessionMemoryInfoARM-session-09792";
skip |= LogError(vuid, objlist, bind_info_loc.dot(Field::memory),
"(%s) was created with protected memory but the VkDataGraphPipelineSessionARM (%s) was not "
"set to use protected memory.",
FormatHandle(bind_info.memory).c_str(), FormatHandle(bind_info.session).c_str());
}
return skip;
}
bool CoreChecks::PreCallValidateBindDataGraphPipelineSessionMemoryARM(VkDevice device, uint32_t bindInfoCount,
const VkBindDataGraphPipelineSessionMemoryInfoARM* pBindInfos,
const ErrorObject& error_obj) const {
bool skip = false;
for (uint32_t i = 0; i < bindInfoCount; i++) {
skip |= ValidateBindDataGraphPipelineSessionMemoryARM(pBindInfos[i], error_obj.location.dot(Field::pBindInfos, i));
}
return skip;
}
bool CoreChecks::PreCallValidateCmdDecompressMemoryEXT(VkCommandBuffer commandBuffer,
const VkDecompressMemoryInfoEXT* pDecompressMemoryInfoEXT,
const ErrorObject& error_obj) const {
bool skip = false;
auto cb_state = GetRead<vvl::CommandBuffer>(commandBuffer);
const LogObjectList objlist(cb_state->Handle());
const Location memory_info_loc = error_obj.location.dot(Field::pDecompressMemoryInfoEXT);
for (uint32_t i = 0; i < pDecompressMemoryInfoEXT->regionCount; ++i) {
const auto& region = pDecompressMemoryInfoEXT->pRegions[i];
const Location region_loc = memory_info_loc.dot(Field::pRegions, i);
if (region.compressedSize > 0) {
const VkDeviceAddress start = region.srcAddress;
const VkDeviceSize size = region.compressedSize;
BufferAddressValidation<2> buffer_address_validator = {
{{{"VUID-VkDecompressMemoryRegionEXT-srcAddress-07686",
[start, size](const vvl::Buffer &buffer_state) {
const VkDeviceSize end =
buffer_state.create_info.size - static_cast<VkDeviceSize>(start - buffer_state.deviceAddress);
return size > end;
},
[size]() { return "The compressedSize (" + std::to_string(size) + ") does not fit in any buffer"; },
kEmptyErrorMsgBuffer},
{"VUID-VkDecompressMemoryRegionEXT-srcAddress-11764",
[](const vvl::Buffer &buffer_state) {
return (buffer_state.usage & VK_BUFFER_USAGE_2_MEMORY_DECOMPRESSION_BIT_EXT) == 0;
},
[]() { return "The following buffers are missing VK_BUFFER_USAGE_2_MEMORY_DECOMPRESSION_BIT_EXT"; },
kUsageErrorMsgBuffer}}}};
const Location src_loc = region_loc.dot(Field::srcAddress);
skip |= buffer_address_validator.ValidateDeviceAddress(*this, src_loc, objlist, start, size);
}
if (region.decompressedSize > 0) {
const VkDeviceAddress start = region.dstAddress;
const VkDeviceSize size = region.decompressedSize;
BufferAddressValidation<2> dst_range_validator = {
{{{"VUID-VkDecompressMemoryRegionEXT-dstAddress-07688",
[start, size](const vvl::Buffer &buffer_state) {
const VkDeviceSize end =
buffer_state.create_info.size - static_cast<VkDeviceSize>(start - buffer_state.deviceAddress);
return size > end;
},
[size]() { return "The decompressedSize (" + std::to_string(size) + ") does not fit in any buffer"; },
kEmptyErrorMsgBuffer},
{"VUID-VkDecompressMemoryRegionEXT-dstAddress-11765",
[](const vvl::Buffer &buffer_state) {
return (buffer_state.usage & VK_BUFFER_USAGE_2_MEMORY_DECOMPRESSION_BIT_EXT) == 0;
},
[]() { return "The following buffers are missing VK_BUFFER_USAGE_2_MEMORY_DECOMPRESSION_BIT_EXT"; },
kUsageErrorMsgBuffer}}}};
const Location dst_loc = region_loc.dot(Field::dstAddress);
skip |= dst_range_validator.ValidateDeviceAddress(*this, dst_loc, objlist, start, size);
}
}
return skip;
}
bool CoreChecks::PreCallValidateCmdDecompressMemoryIndirectCountEXT(VkCommandBuffer commandBuffer,
VkMemoryDecompressionMethodFlagsEXT decompressionMethod,
VkDeviceAddress indirectCommandsAddress,
VkDeviceAddress indirectCommandsCountAddress,
uint32_t maxDecompressionCount, uint32_t stride,
const ErrorObject& error_obj) const {
bool skip = false;
auto cb_state = GetRead<vvl::CommandBuffer>(commandBuffer);
const LogObjectList objlist(cb_state->Handle());
{
const VkDeviceSize max_range_size = static_cast<VkDeviceSize>(stride) * static_cast<VkDeviceSize>(maxDecompressionCount);
BufferAddressValidation<2> buffer_address_validator = {
{{{"VUID-vkCmdDecompressMemoryIndirectCountEXT-indirectCommandsAddress-07694",
[](const vvl::Buffer &buffer_state) { return (buffer_state.usage & VK_BUFFER_USAGE_2_INDIRECT_BUFFER_BIT) == 0; },
[]() { return "The following buffers are missing VK_BUFFER_USAGE_2_INDIRECT_BUFFER_BIT"; }, kUsageErrorMsgBuffer},
{"VUID-vkCmdDecompressMemoryIndirectCountEXT-indirectCommandsAddress-11794",
[indirectCommandsAddress, stride, maxDecompressionCount](const vvl::Buffer &buffer_state) {
if (maxDecompressionCount == 0 || stride == 0) return false;
const vvl::range<VkDeviceSize> required_range(
indirectCommandsAddress, indirectCommandsAddress + static_cast<VkDeviceSize>(stride) *
static_cast<VkDeviceSize>(maxDecompressionCount));
const vvl::range<VkDeviceSize> buffer_address_range = buffer_state.DeviceAddressRange();
return !buffer_address_range.includes(required_range);
},
[stride, maxDecompressionCount, max_range_size]() {
return "The required " + std::to_string(max_range_size) + " byte (stride [" + std::to_string(stride) +
"] * maxDecompressionCount [" + std::to_string(maxDecompressionCount) + "]) does not fit in any buffer";
},
kEmptyErrorMsgBuffer}}}};
const Location ic_addr_loc = error_obj.location.dot(Field::indirectCommandsAddress);
skip |=
buffer_address_validator.ValidateDeviceAddress(*this, ic_addr_loc, objlist, indirectCommandsAddress, max_range_size);
}
{
BufferAddressValidation<1> buffer_address_validator = {
{{{"VUID-vkCmdDecompressMemoryIndirectCountEXT-indirectCommandsCountAddress-07697",
[](const vvl::Buffer &buffer_state) { return (buffer_state.usage & VK_BUFFER_USAGE_2_INDIRECT_BUFFER_BIT) == 0; },
[]() { return "The following buffers are missing VK_BUFFER_USAGE_2_INDIRECT_BUFFER_BIT"; }, kUsageErrorMsgBuffer}}}};
const Location ic_count_loc = error_obj.location.dot(Field::indirectCommandsCountAddress);
skip |= buffer_address_validator.ValidateDeviceAddress(*this, ic_count_loc, objlist, indirectCommandsCountAddress);
}
return skip;
}
|