1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
/* Copyright (c) 2024-2026 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "generated/spirv_grammar_helper.h"
#include "gpuav/core/gpuav.h"
#include "gpuav/resources/gpuav_state_trackers.h"
#include "gpuav/shaders/gpuav_error_codes.h"
#include "gpuav/shaders/gpuav_error_header.h"
namespace gpuav {
void RegisterRayHitObjectValidation(Validator &gpuav, CommandBufferSubState &cb) {
if (!gpuav.gpuav_settings.shader_instrumentation.ray_hit_object) {
return;
}
cb.on_instrumentation_error_logger_register_functions.emplace_back([](Validator &gpuav, CommandBufferSubState &cb,
const LastBound &last_bound) {
CommandBufferSubState::InstrumentationErrorLogger inst_error_logger = [](Validator &gpuav, const Location &loc,
const uint32_t *error_record,
std::string &out_error_msg,
std::string &out_vuid_msg) {
using namespace glsl;
bool error_found = false;
if (GetErrorGroup(error_record) != kErrorGroup_InstRayHitObject) {
return error_found;
}
error_found = true;
std::ostringstream strm;
const uint32_t error_sub_code = GetSubError(error_record);
const uint32_t opcode = error_record[kInst_LogError_ParameterOffset_1];
switch (error_sub_code) {
case kErrorSubCode_RayHitObject_NegativeMin: {
// TODO - Figure a way to properly use GLSL floatBitsToUint and print the float values
strm << string_SpvOpcode(opcode) << " operand Ray Tmin value is negative. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11879";
} break;
case kErrorSubCode_RayHitObject_NegativeMax: {
strm << string_SpvOpcode(opcode) << " operand Ray Tmax value is negative. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11879";
} break;
case kErrorSubCode_RayHitObject_MinMax: {
strm << string_SpvOpcode(opcode) << " operand Ray Tmax is less than RayTmin. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11880";
} break;
case kErrorSubCode_RayHitObject_MinNaN: {
strm << string_SpvOpcode(opcode) << " operand Ray Tmin is NaN. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11881";
} break;
case kErrorSubCode_RayHitObject_MaxNaN: {
strm << string_SpvOpcode(opcode) << " operand Ray Tmax is NaN. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11881";
} break;
case kErrorSubCode_RayHitObject_OriginNaN: {
strm << string_SpvOpcode(opcode) << " operand Ray Origin contains a NaN. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11881";
} break;
case kErrorSubCode_RayHitObject_DirectionNaN: {
strm << string_SpvOpcode(opcode) << " operand Ray Direction contains a NaN. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11881";
} break;
case kErrorSubCode_RayHitObject_OriginFinite: {
strm << string_SpvOpcode(opcode) << " operand Ray Origin contains a non-finite value. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11878";
} break;
case kErrorSubCode_RayHitObject_DirectionFinite: {
strm << string_SpvOpcode(opcode) << " operand Ray Direction contains a non-finite value. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11878";
} break;
case kErrorSubCode_RayHitObject_BothSkip: {
const uint32_t value = error_record[kInst_LogError_ParameterOffset_0];
strm << string_SpvOpcode(opcode) << " operand Ray Flags is 0x" << std::hex << value << ". ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11883";
} break;
case kErrorSubCode_RayHitObject_SkipCull: {
const uint32_t value = error_record[kInst_LogError_ParameterOffset_0];
strm << string_SpvOpcode(opcode) << " operand Ray Flags is 0x" << std::hex << value << ". ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11884";
} break;
case kErrorSubCode_RayHitObject_Opaque: {
const uint32_t value = error_record[kInst_LogError_ParameterOffset_0];
strm << string_SpvOpcode(opcode) << " operand Ray Flags is 0x" << std::hex << value << ". ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11885";
} break;
case kErrorSubCode_RayHitObject_SkipTrianglesWithPipelineSkipAABBs: {
const uint32_t value = error_record[kInst_LogError_ParameterOffset_0];
strm << string_SpvOpcode(opcode) << " operand Ray Flags (0x" << std::hex << value
<< ") contains SkipTrianglesKHR, but pipeline was created with "
"VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11886";
} break;
case kErrorSubCode_RayHitObject_SkipAABBsWithPipelineSkipTriangles: {
const uint32_t value = error_record[kInst_LogError_ParameterOffset_0];
strm << string_SpvOpcode(opcode) << " operand Ray Flags (0x" << std::hex << value
<< ") contains SkipAABBsKHR, but pipeline was created with "
"VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11887";
} break;
case kErrorSubCode_RayHitObject_TimeOutOfRange: {
strm << string_SpvOpcode(opcode) << " operand time is not between 0.0 and 1.0. ";
out_vuid_msg = "VUID-RuntimeSpirv-OpHitObjectTraceRayEXT-11882";
} break;
case kErrorSubCode_RayHitObject_SBTIndexExceedsLimit: {
// For this case, param_0 contains the SBT index and opcode_type slot contains the max SBT index
const uint32_t sbt_index = error_record[kInst_LogError_ParameterOffset_0];
const uint32_t max_sbt_index = error_record[kInst_LogError_ParameterOffset_1];
strm << "OpHitObjectSetShaderBindingTableRecordIndexEXT SBT index (" << std::dec << sbt_index
<< ") exceeds VkPhysicalDeviceRayTracingInvocationReorderPropertiesEXT::maxShaderBindingTableRecordIndex (" << max_sbt_index << "). ";
out_vuid_msg = "VUID-RuntimeSpirv-maxShaderBindingTableRecordIndex-11888";
} break;
default:
error_found = false;
break;
}
out_error_msg += strm.str();
return error_found;
};
return inst_error_logger;
});
}
} // namespace gpuav
|
