1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295
|
/* Copyright (c) 2015-2025 The Khronos Group Inc.
* Copyright (c) 2015-2025 Valve Corporation
* Copyright (c) 2015-2025 LunarG, Inc.
* Copyright (C) 2015-2025 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "chassis/validation_object.h"
#include "containers/small_vector.h"
#include "containers/span.h"
namespace object_lifetimes {
enum ObjectStatusFlags {
kObjectStatusNone = 0x0,
kObjectStatusCustomAllocator = 0x1, // Allocated with custom allocator
kObjectStatusPoisoned = 0x2 // This object references destoyed objects
};
struct ObjectState;
class Tracker;
class Device;
using ObjectMap = vvl::concurrent_unordered_map<uint64_t, std::shared_ptr<ObjectState>, 6>;
// Used for GPL and we know there are at most only 4 libraries that should be used
using ObjectMapGPL = vvl::concurrent_unordered_map<uint64_t, small_vector<std::shared_ptr<ObjectState>, 4>, 6>;
struct ObjectState {
uint64_t handle;
VulkanObjectType object_type;
uint32_t status_flags;
uint64_t parent_object;
// Child objects (used for VkDescriptorPool only)
std::unique_ptr<vvl::unordered_set<uint64_t> > child_objects;
// ObjectState can be accessed from multiple threads
mutable std::shared_mutex poison_lock;
auto WriteLock() const { return std::unique_lock<std::shared_mutex>(poison_lock); }
auto ReadLock() const { return std::shared_lock<std::shared_mutex>(poison_lock); }
// The objects to poison if the current object becomes poisoned.
// These objects reference the current object in some way.
vvl::unordered_set<VulkanTypedHandle> objects_to_poison;
// The objects that can poison this object (they have this object in their objects_to_poison list).
// When the current object is destroyed it has to remove itself from all registered poisoners.
std::vector<VulkanTypedHandle> poisoners;
// If this object is poisoned, then this is a chain of poisoned objects starting with the object
// that was deleted and the last object is the one that directly marked this object as poisoned.
std::vector<VulkanTypedHandle> poison_chain;
void MakePoisonous(Tracker &tracker, VulkanTypedHandle poisoner, const std::vector<VulkanTypedHandle> &parent_poison_chain);
VulkanTypedHandle TypedHandle() const;
};
class Tracker : public Logger {
public:
Tracker(DebugReport *dr) : Logger(dr) {}
std::shared_ptr<ObjectState> GetObjectState(VulkanTypedHandle object) const;
template <typename T1>
bool ValidateDestroyObject(T1 object_handle, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const {
return ValidateDestroyObject(VulkanTypedHandle(object_handle, object_type), pAllocator, expected_custom_allocator_code,
expected_default_allocator_code, loc);
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, bool poisoned_object_allowed,
const char *invalid_handle_vuid, const char *wrong_parent_vuid, const Location &loc) const {
if (null_allowed && (object == VK_NULL_HANDLE)) {
return false;
}
return CheckObjectValidity(VulkanTypedHandle(object, object_type), poisoned_object_allowed, invalid_handle_vuid,
wrong_parent_vuid, loc);
}
template <typename T1, typename T2>
void CreateObject(T1 object, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator, const Location &loc,
T2 parent_object) {
CreateObject(VulkanTypedHandle(object, object_type), pAllocator, loc, HandleToUint64(parent_object));
}
template <typename T1>
void RecordDestroyObject(T1 object_handle, VulkanObjectType object_type, const Location &loc) {
RecordDestroyObject(VulkanTypedHandle(object_handle, object_type), loc);
}
template <typename PoisonerVkType>
void RegisterPoisonPairs(VulkanTypedHandle poisonee, vvl::span<PoisonerVkType> poisoners, VulkanObjectType poisoner_type) {
if (auto poisonee_state = GetObjectState(poisonee)) {
auto poisonee_lock = poisonee_state->WriteLock();
for (PoisonerVkType poisoner_vk_handle : poisoners) {
const VulkanTypedHandle poisoner(poisoner_vk_handle, poisoner_type);
if (auto poisoner_state = GetObjectState(poisoner)) {
auto poisoner_lock = poisoner_state->WriteLock();
poisoner_state->objects_to_poison.emplace(poisonee);
}
}
}
}
bool TracksObject(VulkanTypedHandle object) const;
bool CheckObjectValidity(VulkanTypedHandle object, bool poisoned_object_allowed, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc) const;
void DestroyObjectSilently(VulkanTypedHandle object, const Location &loc);
void DestroyUndestroyedObjects(VulkanObjectType object_type, const Location &loc);
void RegisterPoisonPair(VulkanTypedHandle poisonee, VulkanTypedHandle poisoner);
bool CheckPoisoning(const ObjectState &object_state, const char *vuid, const Location &loc) const;
std::string DescribePoisonChain(const std::vector<VulkanTypedHandle> &poison_chain) const;
void SetDeviceHandle(const Device& device);
void SetInstanceHandle(VkInstance instance);
bool IsMaintenance4Enabled() const { return is_device_maintenance4_enabled_; }
private:
void CreateObject(VulkanTypedHandle object, const VkAllocationCallbacks *pAllocator, const Location &loc,
uint64_t parent_handle);
bool ValidateDestroyObject(VulkanTypedHandle object, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const;
void RecordDestroyObject(VulkanTypedHandle object, const Location &loc);
public:
ObjectMap object_map[kVulkanObjectTypeMax + 1];
private:
// We don't know the handle (VkDevice or VkInstance) when Tracker is created and need to set afterwards
VulkanTypedHandle handle_;
// Affects validity of the objects that use pipeline layout
bool is_device_maintenance4_enabled_ = false;
};
class Instance : public vvl::base::Instance {
public:
using BaseClass = vvl::base::Instance;
using Func = vvl::Func;
using Struct = vvl::Struct;
using Field = vvl::Field;
Tracker tracker;
Instance(vvl::dispatch::Instance *dispatch);
~Instance();
void DestroyLeakedObjects();
bool ReportUndestroyedObjects(const Location &loc) const;
bool ReportLeakedObjects(VulkanObjectType object_type, const std::string &error_code,
const Location &loc) const;
void AllocateDisplayKHR(VkPhysicalDevice physical_device, VkDisplayKHR display, const Location &loc);
// helper methods for tracker
template <typename T1>
bool ValidateDestroyObject(T1 object_handle, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const {
return tracker.ValidateDestroyObject(object_handle, object_type, pAllocator, expected_custom_allocator_code,
expected_default_allocator_code, loc);
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc) const {
return tracker.ValidateObject(object, object_type, null_allowed, true, invalid_handle_vuid, wrong_parent_vuid, loc);
}
void DestroyObjectSilently(VulkanTypedHandle object, const Location &loc) { return tracker.DestroyObjectSilently(object, loc); }
template <typename T1>
void RecordDestroyObject(T1 object, VulkanObjectType object_type, const Location &loc) {
tracker.RecordDestroyObject(object, object_type, loc);
}
void DestroyUndestroyedObjects(VulkanObjectType object_type, const Location &loc) { tracker.DestroyUndestroyedObjects(object_type, loc); }
#include "generated/object_tracker_instance_methods.h"
};
class Device : public vvl::base::Device {
using BaseClass = vvl::base::Device;
using Func = vvl::Func;
using Struct = vvl::Struct;
using Field = vvl::Field;
public:
// Override chassis read/write locks for this validation object
// This override takes a deferred lock. i.e. it is not acquired.
// This class does its own locking with a shared mutex.
ReadLockGuard ReadLock() const override;
WriteLockGuard WriteLock() override;
Tracker tracker;
mutable std::shared_mutex object_lifetime_mutex;
WriteLockGuard WriteSharedLock() { return WriteLockGuard(object_lifetime_mutex); }
ReadLockGuard ReadSharedLock() const { return ReadLockGuard(object_lifetime_mutex); }
ObjectMapGPL linked_graphics_pipeline_map;
// Constructor for object lifetime tracking
Device(vvl::dispatch::Device *dev, Instance *instance);
~Device();
void FinishDeviceSetup(const VkDeviceCreateInfo *pCreateInfo, const Location &loc) override;
void DestroyLeakedObjects();
bool ReportUndestroyedObjects(const Location &loc) const;
bool ReportLeakedObjects(VulkanObjectType object_type, const std::string &error_code,
const Location &loc) const;
void CreateQueue(VkQueue vkObj, const Location &loc);
void AllocateCommandBuffer(const VkCommandPool command_pool, const VkCommandBuffer command_buffer, VkCommandBufferLevel level,
const Location &loc);
void AllocateDescriptorSet(VkDescriptorPool descriptor_pool, VkDescriptorSet descriptor_set, const Location &loc);
void CreateSwapchainImageObject(VkImage swapchain_image, VkSwapchainKHR swapchain, const Location &loc);
bool ValidateCommandBuffer(VkCommandPool command_pool, VkCommandBuffer command_buffer, const Location &loc) const;
bool ValidateDescriptorSet(VkDescriptorPool descriptor_pool, VkDescriptorSet descriptor_set, const Location &loc) const;
bool ValidateDescriptorSetLayoutCreateInfo(const VkDescriptorSetLayoutCreateInfo &create_info,
const Location &create_info_loc) const;
bool ValidateDescriptorWrite(VkWriteDescriptorSet const *desc, bool is_push_descriptor, const Location &loc) const;
bool ValidateAnonymousObject(uint64_t object, VkObjectType core_object_type, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc) const;
bool ValidateAccelerationStructures(const char *src_handle_vuid, const char *dst_handle_vuid, uint32_t count,
const VkAccelerationStructureBuildGeometryInfoKHR *infos, const Location &loc) const;
bool CheckPipelineObjectValidity(uint64_t object_handle, const char *invalid_handle_vuid, const Location &loc) const;
// helper methods for tracker
template <typename T1>
bool ValidateDestroyObject(T1 object_handle, VulkanObjectType object_type, const VkAllocationCallbacks *pAllocator,
const char *expected_custom_allocator_code, const char *expected_default_allocator_code,
const Location &loc) const {
return tracker.ValidateDestroyObject(object_handle, object_type, pAllocator, expected_custom_allocator_code,
expected_default_allocator_code, loc);
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, bool poisoned_object_allowed,
const char *invalid_handle_vuid, const char *wrong_parent_vuid, const Location &loc) const {
uint64_t object_handle = HandleToUint64(object);
// special case if for pipeline if using GPL
if (object_type == kVulkanObjectTypePipeline) {
if (auto object_state = tracker.GetObjectState(VulkanTypedHandle(object, object_type))) {
bool skip = false;
if (!poisoned_object_allowed) {
skip |= tracker.CheckPoisoning(*object_state, invalid_handle_vuid, loc);
}
// If destroying, even if the child libraries are gone, the user still
// has a way to remove the bad parent pipeline library
if (loc.function != Func::vkDestroyPipeline) {
skip |= CheckPipelineObjectValidity(object_handle, invalid_handle_vuid, loc);
}
return skip;
}
}
return tracker.ValidateObject(object, object_type, null_allowed, poisoned_object_allowed, invalid_handle_vuid,
wrong_parent_vuid, loc);
}
template <typename T1>
bool ValidateObject(T1 object, VulkanObjectType object_type, bool null_allowed, const char *invalid_handle_vuid,
const char *wrong_parent_vuid, const Location &loc) const {
return ValidateObject(object, object_type, null_allowed, true, invalid_handle_vuid, wrong_parent_vuid, loc);
}
template <typename T1>
void RecordDestroyObject(T1 object, VulkanObjectType object_type, const Location &loc) {
tracker.RecordDestroyObject(object, object_type, loc);
}
void DestroyUndestroyedObjects(VulkanObjectType object_type, const Location &loc) { tracker.DestroyUndestroyedObjects(object_type, loc); }
// RegisterPoisonPair helper when using CreatePipelines APIs
template <typename TCreateInfo>
void RegisterCommonPipelinePoisoning(const TCreateInfo *create_infos, const VkPipeline *pipelines, uint32_t pipeline_index) {
const VulkanTypedHandle pipeline_handle(pipelines[pipeline_index], kVulkanObjectTypePipeline);
const VulkanTypedHandle pipeline_layout_handle(create_infos[pipeline_index].layout, kVulkanObjectTypePipelineLayout);
tracker.RegisterPoisonPair(pipeline_handle, pipeline_layout_handle);
}
#include "generated/object_tracker_device_methods.h"
};
} // namespace object_lifetimes
|