1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
/*
* Copyright (c) 2025 The Khronos Group Inc.
* Copyright (c) 2025 Valve Corporation
* Copyright (c) 2025 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*/
// stype-check off
#include <vulkan/vulkan_core.h>
#include "../framework/layer_validation_tests.h"
static const VkLayerSettingEXT kLegacySetting = {OBJECT_LAYER_NAME, "legacy_detection", VK_LAYER_SETTING_TYPE_BOOL32_EXT,
1, &kVkTrue};
static VkLayerSettingsCreateInfoEXT kLegacySettingCreateInfo = {VK_STRUCTURE_TYPE_LAYER_SETTINGS_CREATE_INFO_EXT, nullptr, 1,
&kLegacySetting};
class NegativeLegacy : public LegacyTest {};
TEST_F(NegativeLegacy, RenderPass2Extension) {
AddRequiredExtensions(VK_KHR_CREATE_RENDERPASS_2_EXTENSION_NAME);
RETURN_IF_SKIP(InitFramework(&kLegacySettingCreateInfo));
RETURN_IF_SKIP(InitState());
m_errorMonitor->ExpectSuccess(kErrorBit | kWarningBit);
m_errorMonitor->SetDesiredWarning("WARNING-legacy-renderpass2");
CreateRenderPass();
m_errorMonitor->VerifyFound();
// Only report the first time
CreateRenderPass();
}
TEST_F(NegativeLegacy, MultipleDifferentWarnings) {
AddRequiredExtensions(VK_KHR_CREATE_RENDERPASS_2_EXTENSION_NAME);
AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_LOCAL_READ_EXTENSION_NAME);
RETURN_IF_SKIP(InitFramework(&kLegacySettingCreateInfo));
RETURN_IF_SKIP(InitState());
if (IsPlatformMockICD()) {
// Works locally
GTEST_SKIP() << "Github Action doesn't unload VVL and static reported bool is not reset";
}
m_errorMonitor->ExpectSuccess(kErrorBit | kWarningBit);
VkSubpassDescription subpass = {};
subpass.pipelineBindPoint = VK_PIPELINE_BIND_POINT_GRAPHICS;
VkRenderPassCreateInfo rp_ci = vku::InitStructHelper();
rp_ci.subpassCount = 1u;
rp_ci.pSubpasses = &subpass;
m_errorMonitor->SetDesiredWarning("WARNING-legacy-renderpass2");
vkt::RenderPass render_pass(*m_device, rp_ci);
m_errorMonitor->VerifyFound();
m_errorMonitor->SetDesiredWarning("WARNING-legacy-dynamicrendering");
vkt::Framebuffer framebuffer(*m_device, render_pass, 0, nullptr);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeLegacy, MuteSingleWarning) {
TEST_DESCRIPTION("Only mute of the two warnings to make sure mutting works");
const char *ids[] = {"WARNING-legacy-renderpass2"};
VkLayerSettingEXT layer_settings[2] = {kLegacySetting,
{OBJECT_LAYER_NAME, "message_id_filter", VK_LAYER_SETTING_TYPE_STRING_EXT, 1, ids}};
VkLayerSettingsCreateInfoEXT layer_setting_ci = {VK_STRUCTURE_TYPE_LAYER_SETTINGS_CREATE_INFO_EXT, nullptr, 2, layer_settings};
AddRequiredExtensions(VK_KHR_CREATE_RENDERPASS_2_EXTENSION_NAME);
AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_LOCAL_READ_EXTENSION_NAME);
RETURN_IF_SKIP(InitFramework(&layer_setting_ci));
RETURN_IF_SKIP(InitState());
if (IsPlatformMockICD()) {
// Works locally
GTEST_SKIP() << "Github Action doesn't unload VVL and static reported bool is not reset";
}
m_errorMonitor->ExpectSuccess(kErrorBit | kWarningBit);
VkSubpassDescription subpass = {};
subpass.pipelineBindPoint = VK_PIPELINE_BIND_POINT_GRAPHICS;
VkRenderPassCreateInfo rp_ci = vku::InitStructHelper();
rp_ci.subpassCount = 1u;
rp_ci.pSubpasses = &subpass;
// ignores WARNING-legacy-renderpass2
vkt::RenderPass render_pass(*m_device, rp_ci);
m_errorMonitor->SetDesiredWarning("WARNING-legacy-dynamicrendering");
vkt::Framebuffer framebuffer(*m_device, render_pass, 0, nullptr);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeLegacy, GetPhysicalDeviceProperties2Extension) {
AddRequiredExtensions(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
RETURN_IF_SKIP(InitFramework(&kLegacySettingCreateInfo));
m_errorMonitor->ExpectSuccess(kErrorBit | kWarningBit);
if (IsPlatformMockICD()) {
// Works locally
GTEST_SKIP() << "Github Action doesn't unload VVL and static reported bool is not reset";
}
#if defined(VK_USE_PLATFORM_ANDROID_KHR)
GTEST_SKIP() << "Android doesn't unload VVL and static reported bool is not reset";
#endif
m_errorMonitor->SetDesiredWarning("WARNING-legacy-gpdp2");
VkPhysicalDeviceFeatures features{};
vk::GetPhysicalDeviceFeatures(Gpu(), &features);
m_errorMonitor->VerifyFound();
VkFormatProperties format_properties{};
m_errorMonitor->SetDesiredWarning("WARNING-legacy-gpdp2");
vk::GetPhysicalDeviceFormatProperties(Gpu(), VK_FORMAT_R8G8B8A8_UNORM, &format_properties);
m_errorMonitor->VerifyFound();
// Only report the first time
vk::GetPhysicalDeviceFeatures(Gpu(), &features);
vk::GetPhysicalDeviceFormatProperties(Gpu(), VK_FORMAT_R8G8B8A8_UNORM, &format_properties);
}
TEST_F(NegativeLegacy, GetPhysicalDeviceProperties2Version) {
SetTargetApiVersion(VK_API_VERSION_1_1);
RETURN_IF_SKIP(InitFramework(&kLegacySettingCreateInfo));
m_errorMonitor->ExpectSuccess(kErrorBit | kWarningBit);
if (IsPlatformMockICD()) {
// Works locally
GTEST_SKIP() << "Github Action doesn't unload VVL and static reported bool is not reset";
}
#if defined(VK_USE_PLATFORM_ANDROID_KHR)
GTEST_SKIP() << "Android doesn't unload VVL and static reported bool is not reset";
#endif
m_errorMonitor->SetDesiredWarning("WARNING-legacy-gpdp2");
VkPhysicalDeviceFeatures features{};
vk::GetPhysicalDeviceFeatures(Gpu(), &features);
m_errorMonitor->VerifyFound();
VkFormatProperties format_properties{};
m_errorMonitor->SetDesiredWarning("WARNING-legacy-gpdp2");
vk::GetPhysicalDeviceFormatProperties(Gpu(), VK_FORMAT_R8G8B8A8_UNORM, &format_properties);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeLegacy, UseDeprecatedInstanceExtensions) {
if (m_instance_api_version < VK_API_VERSION_1_1) {
GTEST_SKIP() << "At least Vulkan version 1.1 is required";
}
app_info_.apiVersion = VK_API_VERSION_1_1;
m_instance_extension_names.clear();
m_instance_extension_names.emplace_back(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
m_instance_extension_names.emplace_back(VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
auto ici = GetInstanceCreateInfo();
auto debug_info = Monitor().GetDebugCreateInfo();
const_cast<VkDebugUtilsMessengerCreateInfoEXT *>(debug_info)->pNext = &kLegacySettingCreateInfo;
ici.pNext = debug_info;
Monitor().SetDesiredWarning("WARNING-legacy-extension");
VkInstance test_instance = VK_NULL_HANDLE;
vk::CreateInstance(&ici, nullptr, &test_instance);
Monitor().VerifyFound();
if (test_instance != VK_NULL_HANDLE) {
vk::DestroyInstance(test_instance, nullptr);
}
}
TEST_F(NegativeLegacy, UseDeprecatedDeviceExtensions) {
// We need to explicitly allow promoted extensions to be enabled as this test relies on this behavior
AllowPromotedExtensions();
SetTargetApiVersion(VK_API_VERSION_1_2);
AddRequiredExtensions(VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME);
RETURN_IF_SKIP(InitFramework(&kLegacySettingCreateInfo));
RETURN_IF_SKIP(InitState());
VkDevice local_device;
VkDeviceCreateInfo dev_info = vku::InitStructHelper();
VkDeviceQueueCreateInfo queue_info = vku::InitStructHelper();
queue_info.queueFamilyIndex = 0;
queue_info.queueCount = 1;
float qp = 1;
queue_info.pQueuePriorities = &qp;
dev_info.queueCreateInfoCount = 1;
dev_info.pQueueCreateInfos = &queue_info;
dev_info.enabledLayerCount = 0;
dev_info.ppEnabledLayerNames = NULL;
dev_info.enabledExtensionCount = m_device_extension_names.size();
dev_info.ppEnabledExtensionNames = m_device_extension_names.data();
// One for VK_KHR_buffer_device_address
// One for the dependency extension VK_KHR_device_group
m_errorMonitor->SetDesiredWarning("WARNING-legacy-extension", 2);
vk::CreateDevice(this->Gpu(), &dev_info, NULL, &local_device);
m_errorMonitor->VerifyFound();
}
TEST_F(NegativeLegacy, LoadDeprecatedExtension) {
TEST_DESCRIPTION("Test for loading a vk1.3 deprecated extension with a 1.3 instance on a 1.2 or less device");
SetTargetApiVersion(VK_API_VERSION_1_3);
RETURN_IF_SKIP(InitFramework(&kLegacySettingCreateInfo));
RETURN_IF_SKIP(InitState());
const char *extension = VK_KHR_SYNCHRONIZATION_2_EXTENSION_NAME;
if (!DeviceExtensionSupported(extension)) {
GTEST_SKIP() << extension << " not supported.";
}
VkDeviceQueueCreateInfo qci = vku::InitStructHelper();
qci.queueFamilyIndex = 0;
float priority = 1;
qci.pQueuePriorities = &priority;
qci.queueCount = 1;
VkDeviceCreateInfo dev_info = vku::InitStructHelper();
dev_info.queueCreateInfoCount = 1;
dev_info.pQueueCreateInfos = &qci;
dev_info.enabledExtensionCount = 1;
dev_info.ppEnabledExtensionNames = &extension;
m_errorMonitor->SetDesiredWarning("WARNING-legacy-extension");
VkDevice device = VK_NULL_HANDLE;
vk::CreateDevice(Gpu(), &dev_info, nullptr, &device);
if (DeviceValidationVersion() >= VK_API_VERSION_1_3) {
m_errorMonitor->VerifyFound();
}
if (device) {
vk::DestroyDevice(device, nullptr);
}
}
|
