1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442
|
2008-06-14 Darin Adler <darin@apple.com>
Rubber stamped by Sam.
- new names for kjs_binding.h and kjs_proxy.h
* WebView/WebFrame.mm:
* WebView/WebScriptDebugDelegate.mm:
* WebView/WebView.mm:
2008-06-14 Darin Adler <darin@apple.com>
Rubber stamped by Sam.
- renamed HTMLGenericFormElement to HTMLFormControlElement
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementWithName:inForm:]):
(-[WebHTMLRepresentation controlsInForm:]):
2008-06-14 Darin Adler <darin@apple.com>
Reviewed by Sam.
- more of https://bugs.webkit.org/show_bug.cgi?id=17257
start ref counts at 1 instead of 0 for speed
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
(WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
a ref call inside the Frame constructor. The lifetime rules for Frame are now the
conventional ones without a special case.
* WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
this function takes ownership of the DocumentLoader.
(-[WebDataSource initWithRequest:]): Use create instead of new.
* WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
PassRefPtr and also cleaned up the header a bit.
* WebView/WebDocumentLoaderMac.h:
(WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
functions private.
* WebView/WebFrame.mm:
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
of new.
2008-06-14 Darin Adler <darin@apple.com>
Reviewed by Sam.
- more work on https://bugs.webkit.org/show_bug.cgi?id=17257
start ref counts at 1 instead of 0 for speed
* WebView/WebFrame.mm:
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2008-06-13 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
- updated for addition of FormState argument to action policy functions
- added WebActionFormKey
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::actionDictionary):
* WebKit.exp:
* WebView/WebPolicyDelegate.mm:
* WebView/WebPolicyDelegatePrivate.h:
2008-06-12 John Sullivan <sullivan@apple.com>
Reviewed by Dan and Darin
Clear up the confusion about _close (older private method) vs -close (newer public method).
* WebView/WebView.mm:
(-[WebView _isClosed]):
simplified style
(-[WebView _close]):
added a comment about how clients and subclasses should use -close instead
(-[WebView dealloc]):
call -close instead of _close, so subclasses that override the public method will have the intended behavior
(-[WebView close]):
added a comment
(-[WebView _windowWillClose:]):
call -close instead of _close, so subclasses that override the public method will have the intended behavior
* WebView/WebViewPrivate.h:
added a comment about how clients and subclasses should use -close instead
2008-06-07 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- work on https://bugs.webkit.org/show_bug.cgi?id=17257
start ref counts at 1 instead of 0 for speed
* History/WebHistoryItem.mm:
(-[WebHistoryItem init]):
(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem initWithURL:target:parent:title:]):
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
* WebView/WebView.mm:
(+[WebView _decodeData:]):
2008-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Tim.
Bug 12983: Web Inspector break on the debugger keyword
<https://bugs.webkit.org/show_bug.cgi?id=12983>
Add stubs to allow old webkit debugger interface to build.
* WebView/WebScriptDebugger.h:
* WebView/WebScriptDebugger.mm:
2008-06-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
<rdar://problem/5980961>
In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
newBottom to be larger than oldBottom which is illegal.
* WebView/WebHTMLView.mm:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
2008-06-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Speculative fix for <rdar://problem/5661112>
CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
layouts to be triggered.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _createPlugin]):
2008-05-29 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
AppKit started putting PNG instead of PICT onto the pasteboard for screen
captures. Added support for PNG with kUTTypePNG. Tiger doesn't support
setting and retrieving pasteboard types with UTIs, but we don't know of any
applications on Tiger that put only PNG on the pasteboard.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2008-05-29 Anders Carlsson <andersca@apple.com>
Reviewed by Brady.
<rdar://problem/5970312>
icon file specified for stand alone web app causes crash if the icon can't be found
Handle the case where iconData is null.
* Misc/WebIconFetcher.mm:
(WebIconFetcherClient::finishedFetchingIcon):
2008-05-29 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
<rdar://problem/5971845>
https://bugs.webkit.org/show_bug.cgi?id=19313
Add version member to NPCocoaEvent
Initialize the version member to 0 for all events.
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(initializeEvent):
(WebNetscapePluginEventHandlerCocoa::drawRect):
(WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
(WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
(WebNetscapePluginEventHandlerCocoa::focusChanged):
2008-05-29 Dan Bernstein <mitz@apple.com>
Reviewed by Jessica Kahn.
- fix <rdar://problem/5965013> Page 2 does not print correctly
When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
_recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
-viewWillDraw being sent first, which could lead to painting without
valid layout. The fix is to ensure up-to-date layout in those methods
when printing.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
(-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2008-05-28 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
Remove workaround, this is no longer a problem.
* WebView/WebView.mm:
(-[WebView _removeObjectForIdentifier:]):
2008-05-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Tim Hatcher.
Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html
Added implementations for willExecuteProgram and didExecuteProgram, which
take care of making sure we're not hanging on to stale data.
2008-05-27 Timothy Hatcher <timothy@apple.com>
Fixes a bug where unplugging the monitor from a video card and
moving it to another video card would no longer show OpenGL plugins
until you relaunched Safari.
<rdar://problem/5790983> Add AllowOfflineDisplays pixel format
attribute to OpenGL contexts
Reviewed by Kevin Decker.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
(-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
2008-05-25 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
Follow-up for r33052. _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
* WebView/WebFrame.mm:
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
2008-05-23 Timothy Hatcher <timothy@apple.com>
Fix attaching and detaching the Web Inspector. This change removes
the clunky animation that never looked right and was causing issues
where the inspected WebView would get into a no useable state.
<rdar://problem/5958812> Attaching and Detaching the Web Inspector
can cause the inspected WebVIew to be unusable
Reviewed by Adam Roben.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController close]): Removes animation code.
Sets the frame directly and does a displayIfNeeded to prevent
showing the Inspector in the page and in the Inspector window.
(-[WebInspectorWindowController showWindow:]): Removes animation code.
Sets the frame directly.
(-[WebInspectorWindowController attach]): Simplified.
(-[WebInspectorWindowController detach]): Ditto.
2008-05-22 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix broken documentation of
webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
* WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
-webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
2008-05-22 Timothy Hatcher <timothy@apple.com>
<rdar://problem/5956403> Update the Develop menu to match the new Inspector items
Reviewed by Adam Roben.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWebInspector:]):
(-[WebInspectorWindowController showErrorConsole:]):
(-[WebInspectorWindowController toggleDebuggingJavaScript:]):
(-[WebInspectorWindowController toggleProfilingJavaScript:]):
(-[WebInspectorWindowController validateUserInterfaceItem:]):
* WebInspector/WebInspector.h:
* WebInspector/WebInspector.mm:
(-[WebInspector showConsole:]):
(-[WebInspector showTimeline:]):
(-[WebInspector isDebuggingJavaScript]):
(-[WebInspector toggleDebuggingJavaScript:]):
(-[WebInspector startDebuggingJavaScript:]):
(-[WebInspector stopDebuggingJavaScript:]):
(-[WebInspector isProfilingJavaScript]):
(-[WebInspector toggleProfilingJavaScript:]):
(-[WebInspector startProfilingJavaScript:]):
(-[WebInspector stopProfilingJavaScript:]):
2008-05-22 Josh Aas <joshmoz@gmail.com>
Reviewed by Anders.
<rdar://problem/5956429>
https://bugs.webkit.org/show_bug.cgi?id=19192
remove NPNVpluginEventModel, fix example plugin
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView getVariable:value:]):
2008-05-21 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
Add WebIconFetcher.
* Misc/WebIconFetcher.h: Added.
* Misc/WebIconFetcher.mm: Added.
(WebIconFetcherClient::WebIconFetcherClient):
(WebIconFetcherClient::finishedFetchingIcon):
(WebIconFetcherClient::setFetcher):
(-[WebIconFetcher init]):
(-[WebIconFetcher dealloc]):
(-[WebIconFetcher finalize]):
(-[WebIconFetcher cancel]):
(-[WebIconFetcher _initWithIconFetcher:client:]):
(+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
* Misc/WebIconFetcherInternal.h: Added.
* WebView/WebFrame.mm:
(-[WebFrame fetchApplicationIcon:selector:]):
* WebView/WebFramePrivate.h:
=== End merge of squirrelfish ===
2008-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Tim Hatcher.
Updated for API changes from merging with trunk WebCore's new debugger.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
exception return, since the DebuggerCallFrame no longer automatically
substitutes the exception for the return value.
* WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
lexical global object, since the debugger attaches based on dynamic
global object.
2008-05-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Re-enabled previously disabled debugging functionality.
There are two major changes from how the WebKit debugger used to work:
(1) All the interesting bits are implemented down in JavaScriptCore. The
debugger just calls through to KJS::DebuggerCallFrame for everything.
(2) Instead of copyihng a pointer to an ExecState once, the debugger
copies the DebuggerCallFrame passed to it in each callback. This is
because the VM no longer maintains a fully transparent execution state
to which you can hold a pointer, and the DebuggerCallFrames it vends
are temporaries.
Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
from its function. This is safer than the old method, which was to
hold a stale ExecState* and hope for the best.
2008-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Updated for API changes in KJS::Debugger.
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]): Changed the order of operations to
fix an ASSERT that can happen when re-entering _attachScriptDebugger.
2008-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Updated WebScriptDebugger API to accept a SourceProvider instead
of a WebCore::String, to avoid copying.
(WebScriptDebugger::sourceParsed): Updated this function not to return
a value.
2008-04-30 Geoffrey Garen <ggaren@apple.com>
Build fix: #ifdef'd out some code that doesn't work anymore.
2008-04-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
#ifdef'd out some debugger code that doesn't work anymore.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame scopeChain]):
2008-04-21 Geoffrey Garen <ggaren@apple.com>
Build fix.
* ChangeLog:
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame scopeChain]):
2008-03-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Build fix.
=== Start merge of squirrelfish ===
2008-05-21 Darin Adler <darin@apple.com>
- fix build
* WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
if we want, but if we do, we should probably make some refinements like checking _private->closed
and applicationIsTerminating.
2008-05-21 Darin Adler <darin@apple.com>
Reviewed by Anders and Kevin Decker.
- fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
* WebView/WebView.mm:
(-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
(-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
(-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
(-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
2008-05-19 Stephanie Lewis <slewis@apple.com>
Reviewed by Darin.
more fast teardown performance work
* Misc/WebDownload.m:
(-[WebDownloadInternal downloadDidBegin:]):
(-[WebDownloadInternal downloadDidFinish:]):
(-[WebDownloadInternal download:didFailWithError:]):
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::disableSuddenTermination):
(WebChromeClient::enableSuddenTermination):
2008-05-18 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
* Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
2008-05-16 Timothy Hatcher <timothy@apple.com>
Removes WebScriptDebugServer files and related calls. This removes
the hooks that Drosera uses for debugging. Now that the Web Inspector
has a better debugger, we don't need these anymore.
Reviewed by Sam Weinig.
* DefaultDelegates/WebScriptDebugServer.h: Removed.
* DefaultDelegates/WebScriptDebugServer.m: Removed.
* DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.exp:
* WebView/WebScriptDebugDelegate.mm:
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::sourceParsed):
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
* WebView/WebViewPrivate.h:
2008-05-16 Brady Eidson <beidson@apple.com>
Reviewed by Anders
<rdar://problem/5942616> - Need to standardize LocalStorage persistence path
Took the opportunity to touch up another pref that needs the same standardization.
That pref is currently not in use on Mac.
* WebView/WebPreferences.m:
(-[WebPreferences _setFTPDirectoryTemplatePath:]):
(-[WebPreferences _localStorageDatabasePath]):
(-[WebPreferences _setLocalStorageDatabasePath:]):
(-[WebPreferences _ftpDirectoryTemplatePath]):
2008-05-16 Chris Fleizach <cfleizach@apple.com>
Reviewed by Alice Liu
<rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
* WebView/WebFrame.mm:
(-[WebFrame _accessibilityTree]):
2008-05-15 Stephanie Lewis <slewis@apple.com>
fix mac build
* WebView/WebView.mm:
(-[WebView closeWithFastTeardown]):
2008-05-15 Stephanie Lewis <slewis@apple.com>
Reviewed by Anders.
Turn on fast teardown. I added a preference for using full teardown because
the LEAKS output will be useless without a full teardown.
preference for fullteardown
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(-[WebPreferences setFullDocumentTeardownEnabled:]):
(-[WebPreferences fullDocumentTeardownEnabled]):
* WebView/WebPreferencesPrivate.h:
on application quit dispatch unload events and destroy plugins then exit
* WebView/WebView.mm:
(-[WebView closeWithFastTeardown]):
(-[WebView _close]):
* WebView/WebViewPrivate.h:
2008-05-15 Stephanie Lewis <slewis@apple.com>
Reviewed by Anders.
get the pending frame unload count from WebCore
* WebView/WebFrame.mm:
(-[WebFrame _pendingFrameUnloadEventCount]):
* WebView/WebFramePrivate.h:
2008-05-15 John Sullivan <sullivan@apple.com>
Reviewed by Kevin Decker
- fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of
screen when new tab appears
The highlight should go away entirely, but this simple patch just makes it not jump away.
The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight _repositionHighlightWindow]):
Bail out if target view isn't in a window
2008-05-15 Stephanie Lewis <slewis@apple.com>
Reviewed by Anders.
Track views that contain plugin instances so that they can be destroyed at application
quit without walking the entire document tree.
Add/Remove Netscape plugin views from instance list. Start/stop are when netscape
plugins are created and destroyed
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):
Add/remove WebKit plugin views from instance list
* Plugins/WebPluginController.mm:
(-[WebPluginController addPlugin:]):
(-[WebPluginController destroyPlugin:]):
(-[WebPluginController destroyAllPlugins]):
Add a set of views with plugin instances to the WebPluginDatabase
* Plugins/WebPluginDatabase.h:
* Plugins/WebPluginDatabase.mm:
(-[WebPluginDatabase init]):
(-[WebPluginDatabase dealloc]):
(-[WebPluginDatabase addPluginInstanceView:]):
(-[WebPluginDatabase removePluginInstanceView:]):
(-[WebPluginDatabase removePluginInstanceViewsFor:]):
(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Handle cases where plugin views are detached before the plugin is destroyed.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::detachedFromParent2):
(WebFrameLoaderClient::transitionToCommittedFromCachedPage):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
Add plugin instances to the set in the WebPluginDatabase by way of the WebView
* WebView/WebHTMLView.mm:
(-[WebHTMLView _destroyAllWebPlugins]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebView.mm:
(-[WebView addPluginInstanceView:]):
(-[WebView removePluginInstanceView:]):
(-[WebView removePluginInstanceViewsFor:]):
* WebView/WebViewInternal.h:
2008-05-15 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
before setting the page group of the new page.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path
immediately after creating the page so it is in place for initializing the LocalStorageThread
2008-05-15 Timothy Hatcher <timothy@apple.com>
Fixes the bug where the Web Inspector would flash white while resizing.
This was cause by deferring the window creation.
<rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
Reviewed by Darin Adler.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]): Don't defer the window creation.
2008-05-15 Alexey Proskuryakov <ap@webkit.org>
Tiger build fix.
* Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
2008-05-15 Adele Peterson <adele@apple.com>
Reviewed and landed by Alexey.
Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
* Misc/WebNSAttributedStringExtras.mm:
(+[NSAttributedString _web_attributedStringFromRange:]):
2008-05-14 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Add missing NULL check to match rest of file, this was found by the editing fuzzer.
* WebView/WebResource.mm:
(-[WebResource data]):
2008-05-14 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Dan Bernstein.
NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
* Plugins/nptextinput.h:
2008-05-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Don't empty the application cache in _setCacheModel, since it will be called during initialization.
Instead, do it in [WebCache empty].
* Misc/WebCache.mm:
(+[WebCache empty]):
* WebView/WebView.mm:
(+[WebView _setCacheModel:]):
2008-05-13 chris fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin
<rdar://problem/4780592> WebKit application has its window announced as HTML content
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXWebAreaText]):
2008-05-13 Timothy Hatcher <timothy@apple.com>
Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
was referencing a nil WebView under validateUserInterfaceItem.
The validateUserInterfaceItem methods was being called at a time
when the WebHTMLView is being torndown.
<rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
while mousing down on menu bar after Xcode News window is opened
Reviewed by Ada Chan.
* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
return NO when it is nil. Adds a comment.
* WebView/WebPDFView.mm:
(-[WebPDFView validateUserInterfaceItem:]): Ditto.
2008-05-13 Mark Rowe <mrowe@apple.com>
Reviewed by John Sullivan.
<rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
* Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
* Carbon/HIWebView.m: Ditto.
(HIWebViewCreate):
(HIWebViewConstructor):
2008-05-12 Dan Bernstein <mitz@apple.com>
Reviewed by Ada Chan.
- WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
<rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
Added font cache statistics and a function to purge inactive font data.
* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics cachedFontDataCount]):
(+[WebCoreStatistics cachedFontDataInactiveCount]):
(+[WebCoreStatistics purgeInactiveFontData]):
(+[WebCoreStatistics glyphPageCount]):
2008-05-12 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Decorate some deprecated delegate methods with the availability macros.
The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
macros is good for consistency and documentation.
* WebView/WebFrameLoadDelegate.h:
* WebView/WebUIDelegate.h:
2008-05-12 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/5835604> Deprecate HIWebView
Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
* Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
* Carbon/HIWebView.h: Ditto.
2008-05-12 Kevin Decker <kdecker@apple.com>
Reviewed by Anders.
Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
Re-added these SPI methods because they are needed by some clients. They were accidentally removed
in changeset <http://trac.webkit.org/changeset/31028>
* Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
* WebView/WebFrame.mm:
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
* WebView/WebFrameInternal.h: Ditto.
* WebView/WebHTMLView.mm: Ditto.
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
* WebView/WebHTMLViewInternal.h: Ditto.
* WebView/WebHTMLViewPrivate.h: Ditto.
2008-05-12 Anders Carlsson <andersca@apple.com>
Reviewed by Alexey.
Empty the application cache when changing the cache model.
* WebView/WebView.mm:
(+[WebView _setCacheModel:]):
2008-05-12 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver.
<rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView start]):
Get the plug-in text input vtable pointer.
(-[WebBaseNetscapePluginView stop]):
Set the plug-in text input vtable pointer to 0.
(-[WebBaseNetscapePluginView inputContext]):
Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
(-[WebBaseNetscapePluginView hasMarkedText]):
(-[WebBaseNetscapePluginView insertText:]):
(-[WebBaseNetscapePluginView markedRange]):
(-[WebBaseNetscapePluginView selectedRange]):
(-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
(-[WebBaseNetscapePluginView unmarkText]):
(-[WebBaseNetscapePluginView validAttributesForMarkedText]):
(-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
(-[WebBaseNetscapePluginView characterIndexForPoint:]):
(-[WebBaseNetscapePluginView doCommandBySelector:]):
(-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
(-[WebBaseNetscapePluginView conversationIdentifier]):
Implement NSTextInput and call into the plug-in text input vtable.
(browserTextInputFuncs):
New method which returns the browser input vtable.
(-[WebBaseNetscapePluginView getVariable:value:]):
Support getting the browser input vtable pointer.
* Plugins/WebNetscapePluginEventHandlerCocoa.h:
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::keyDown):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
it means that the event should be passed on to the input manager.
* Plugins/npapi.mm:
(NPN_MarkedTextAbandoned):
(NPN_MarkedTextSelectionChanged):
Add implementations of browser input method methods.
* Plugins/nptextinput.h: Added.
Add file with new text input API.
2008-05-12 Alexey Proskuryakov <ap@webkit.org>
Roll out recent threading changes (r32807, r32810, r32819, r32822) to simplify
SquirrelFish merging.
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectsCount]):
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptReferencedObjectsCount]):
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
2008-05-07 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
https://bugs.webkit.org/show_bug.cgi?id=18880
<rdar://problem/5909513>
Stop suspending key up events before calling handleEvent.
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(WebNetscapePluginEventHandlerCarbon::sendEvent):
2008-05-06 Stephanie Lewis <slewis@apple.com>
Reviewed by Andersca.
prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
* Plugins/WebPluginDatabase.m: Removed.
* Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
* Plugins/npapi.m: Removed.
* Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
2008-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Initialize numArchs to 0.
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage isNativeLibraryData:]):
2008-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Add implementation of NPN_PopUpContextMenu.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView popUpContextMenu:]):
* Plugins/WebBaseNetscapePluginViewPrivate.h:
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
* Plugins/npapi.m:
(NPN_PopUpContextMenu):
2008-05-06 Anders Carlsson <andersca@apple.com>
Fix typo (don't read random memory).
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage isNativeLibraryData:]):
2008-05-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Change the isNativeLibraryData: method to handle universal binaries.
* Plugins/WebBasePluginPackage.m:
(swapIntsInHeader):
(-[WebBasePluginPackage isNativeLibraryData:]):
2008-05-06 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Preparation for upcoming work making LocalStorage persistent.
When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
* WebView/WebView.mm:
(+[WebView _applicationWillTerminate]): Close all LocalStorage areas before quitting.
2008-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for <rdar://problem/5884383>
Escape look-a-like characters from the the entire url.
* Misc/WebNSURLExtras.mm:
(escapeUnsafeCharacters):
(-[NSURL _web_userVisibleString]):
2008-05-05 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
* WebView/WebView.mm:
(-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
the document for Tiger and Leopard Mail. There is code in Mail that does it, and
the two interfere.
2008-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::localizedStringsURL):
2008-05-05 Anders Carlsson <andersca@apple.com>
Reviewed by Jess.
Apparently preflighting can cause hangs for some reason. Revert this for now.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage _initWithPath:]):
* Plugins/WebPluginPackage.m:
(-[WebPluginPackage initWithPath:]):
2008-05-05 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- https://bugs.webkit.org/show_bug.cgi?id=18789
fix some shouldCloseWithWindow edge cases
* WebView/WebView.mm:
(-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
NSWindowWillCloseNotification if the view was moved out of the window but still
had that window set as the host window. Also make sure this function doesn't do
anything if the WebView is already closed.
(-[WebView setHostWindow:]): Ditto.
2008-05-04 David Kilzer <ddkilzer@apple.com>
Make parameters match for WebChromeClient::addMessageToConsole()
Reviewed by John.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::addMessageToConsole): Renamed sourceID parameter
to sourceURL to match implementation in WebChromeClient.mm.
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Various Cocoa event model and 64-bit plug-in fixes.
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
Set click count.
(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
Don't try to get the mouse location for keyboard events.
* Plugins/WebPluginPackage.m:
(-[WebPluginPackage initWithPath:]):
Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
The event union is now named.
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::drawRect):
(WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
(WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
(WebNetscapePluginEventHandlerCocoa::focusChanged):
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
Call preflightAndReturnError on the bundle, which will check if any of the architectures
in the bundle match the current architecture.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage _initWithPath:]):
2008-05-02 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=18826
Make JavaScript heap per-thread
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectsCount]):
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptReferencedObjectsCount]):
Replaced static Collector calls with calls to a current thread's instance.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
Pass ExecState to jsString().
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
64-bit NPAPI plugin build fixes.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView windowBecameKey:]):
* Plugins/WebNetscapeDeprecatedFunctions.c:
* Plugins/WebNetscapeDeprecatedFunctions.h:
* Plugins/WebNetscapePluginEventHandler.mm:
(WebNetscapePluginEventHandler::create):
* Plugins/WebNetscapePluginEventHandlerCarbon.h:
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
* Plugins/WebPluginDatabase.m:
(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Tim.
Remove duplicate npfunctions.h header from WebKit.
* MigrateHeaders.make:
Migrate npfunctions.h
* Plugins/npfunctions.h: Removed.
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by John.
Add null checks for the event handler.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView stopTimers]):
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2008-05-01 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
* Plugins/WebNetscapePluginEventHandlerCocoa.h:
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
2008-05-01 Anders Carlsson <andersca@apple.com>
Fix build.
* Plugins/npfunctions.h:
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Forward mouse move events to the Netscape plug-in view.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView handleMouseMoved:]):
New method that just calls the current event handler.
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::flagsChanged):
NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
don't work on it so don't call them.
* WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::NetscapePluginWidget):
New Widget subclass to be used for Netscape plug-ins.
(NetscapePluginWidget::handleEvent):
Forward NSMouseMoved events to the plug-in.
(WebFrameLoaderClient::createPlugin):
Wrap the plug-in view in a NetscapePluginWidget.
2008-05-01 Alp Toker <alp@nuanti.com>
Rubber-stamped by Anders.
GTK+ build fix for changes in r32752. Use int32, not int32_t types in
npapi.h.
Additional fix to use same signedness in npapi.h and Mac for the
interval parameter.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(PluginTimer::PluginTimer):
(-[WebBaseNetscapePluginView stopTimers]):
(-[WebBaseNetscapePluginView restartTimers]):
(-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
(-[WebBaseNetscapePluginView unscheduleTimer:]):
* Plugins/WebBaseNetscapePluginViewPrivate.h:
* Plugins/npapi.m:
(NPN_ScheduleTimer):
(NPN_UnscheduleTimer):
* Plugins/npfunctions.h:
2008-04-30 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(PluginTimer::PluginTimer):
(PluginTimer::start):
(PluginTimer::fired):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView stopTimers]):
(-[WebBaseNetscapePluginView restartTimers]):
(-[WebBaseNetscapePluginView scrollWheel:]):
(-[WebBaseNetscapePluginView flagsChanged:]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView eventModel]):
(-[WebBaseNetscapePluginView fini]):
(-[WebBaseNetscapePluginView getVariable:value:]):
(-[WebBaseNetscapePluginView setVariable:value:]):
(-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
(-[WebBaseNetscapePluginView unscheduleTimer:]):
* Plugins/WebBaseNetscapePluginViewInternal.h:
* Plugins/WebBaseNetscapePluginViewPrivate.h:
* Plugins/WebNetscapePluginEventHandler.h:
* Plugins/WebNetscapePluginEventHandler.mm:
(WebNetscapePluginEventHandler::create):
* Plugins/WebNetscapePluginEventHandlerCarbon.h:
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(WebNetscapePluginEventHandlerCarbon::scrollWheel):
(WebNetscapePluginEventHandlerCarbon::flagsChanged):
(WebNetscapePluginEventHandlerCarbon::platformWindow):
* Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
(WebNetscapePluginEventHandlerCocoa::startTimers):
(WebNetscapePluginEventHandlerCocoa::stopTimers):
* Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
(WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
(WebNetscapePluginEventHandlerCocoa::drawRect):
(WebNetscapePluginEventHandlerCocoa::mouseDown):
(WebNetscapePluginEventHandlerCocoa::mouseDragged):
(WebNetscapePluginEventHandlerCocoa::mouseEntered):
(WebNetscapePluginEventHandlerCocoa::mouseExited):
(WebNetscapePluginEventHandlerCocoa::mouseMoved):
(WebNetscapePluginEventHandlerCocoa::mouseUp):
(WebNetscapePluginEventHandlerCocoa::scrollWheel):
(WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
(WebNetscapePluginEventHandlerCocoa::keyDown):
(WebNetscapePluginEventHandlerCocoa::keyUp):
(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
(WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
(WebNetscapePluginEventHandlerCocoa::focusChanged):
(WebNetscapePluginEventHandlerCocoa::platformWindow):
(WebNetscapePluginEventHandlerCocoa::sendEvent):
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
* Plugins/npapi.m:
(NPN_ScheduleTimer):
(NPN_UnscheduleTimer):
* Plugins/npfunctions.h:
2008-04-30 Brady Eidson <beidson@apple.com>
Fix my WebPreferences revert check-in
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
2008-04-30 Brady Eidson <beidson@apple.com>
Rubberstamped by John Sullivan
Revert the remainder of my original preferences changes from last week.
They caused a massive PLT regression (too many notifications being sent out
or listened to that weren't previously) and it's not in my schedule to refine
the preferences code instead of working on my feature!
* WebView/WebView.mm:
(-[WebView _updateSettingsFromPreferences:]):
(-[WebView _commonInitializationWithFrameName:groupName:]):
2008-04-30 Anders Carlsson <andersca@apple.com>
Fix the 64-bit build.
* Plugins/WebNetscapePluginEventHandler.h:
* Plugins/WebNetscapePluginEventHandler.mm:
* Plugins/WebNetscapePluginEventHandlerCarbon.h:
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2008-04-29 David D. Kilzer <ddkilzer@apple.com>
BUILD FIX for Release build.
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
separately so the compiler doesn't complain about an unused variable.
(WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
2008-04-29 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Refactor the Carbon event handling code out into a separate class in preparation for adding
the Cocoa event handling code.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
(-[WebBaseNetscapePluginView sendActivateEvent:]):
(-[WebBaseNetscapePluginView sendDrawRectEvent:]):
(-[WebBaseNetscapePluginView stopTimers]):
(-[WebBaseNetscapePluginView restartTimers]):
(-[WebBaseNetscapePluginView setHasFocus:]):
(-[WebBaseNetscapePluginView mouseDown:]):
(-[WebBaseNetscapePluginView mouseUp:]):
(-[WebBaseNetscapePluginView mouseEntered:]):
(-[WebBaseNetscapePluginView mouseExited:]):
(-[WebBaseNetscapePluginView mouseDragged:]):
(-[WebBaseNetscapePluginView keyUp:]):
(-[WebBaseNetscapePluginView keyDown:]):
(-[WebBaseNetscapePluginView cut:]):
(-[WebBaseNetscapePluginView copy:]):
(-[WebBaseNetscapePluginView paste:]):
(-[WebBaseNetscapePluginView selectAll:]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):
(-[WebBaseNetscapePluginView fini]):
(-[WebBaseNetscapePluginView drawRect:]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView windowBecameKey:]):
(-[WebBaseNetscapePluginView windowResignedKey:]):
(-[WebBaseNetscapePluginView windowDidMiniaturize:]):
(-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
(-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
(-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
(-[WebBaseNetscapePluginView _viewHasMoved]):
* Plugins/WebBaseNetscapePluginViewInternal.h:
* Plugins/WebNetscapePluginEmbeddedView.h:
* Plugins/WebNetscapePluginEventHandler.h: Added.
(WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
(WebNetscapePluginEventHandler::currentEventIsUserGesture):
(WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
* Plugins/WebNetscapePluginEventHandler.mm: Added.
(WebNetscapePluginEventHandler::create):
* Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
* Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
(WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
(getCarbonEvent):
(modifiersForEvent):
(WebNetscapePluginEventHandlerCarbon::sendNullEvent):
(WebNetscapePluginEventHandlerCarbon::drawRect):
(WebNetscapePluginEventHandlerCarbon::mouseDown):
(WebNetscapePluginEventHandlerCarbon::mouseUp):
(WebNetscapePluginEventHandlerCarbon::mouseEntered):
(WebNetscapePluginEventHandlerCarbon::mouseExited):
(WebNetscapePluginEventHandlerCarbon::mouseDragged):
(WebNetscapePluginEventHandlerCarbon::mouseMoved):
(WebNetscapePluginEventHandlerCarbon::keyDown):
(keyMessageForEvent):
(WebNetscapePluginEventHandlerCarbon::keyUp):
(WebNetscapePluginEventHandlerCarbon::focusChanged):
(WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
(WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
(WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
(WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
(WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
(WebNetscapePluginEventHandlerCarbon::startTimers):
(WebNetscapePluginEventHandlerCarbon::stopTimers):
(WebNetscapePluginEventHandlerCarbon::sendEvent):
2008-04-29 Mark Rowe <mrowe@apple.com>
Reviewed by David Harrison.
Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
* WebKit.exp:
* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.m:
2008-04-29 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin.
Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
* WebView/WebClipView.m:
(-[WebClipView scrollWheel:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView addMouseMovedObserver]):
(-[WebHTMLView removeMouseMovedObserver]):
(-[WebHTMLView acceptsFirstMouse:]):
* WebView/WebUIDelegatePrivate.h:
* WebView/WebView.mm:
(-[WebViewPrivate init]):
* WebView/WebViewPrivate.h:
2008-04-28 Rob Buis <buis@kde.org>
Reviewed by Maciej.
Build fix for Tiger.
* WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
2008-04-28 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
WebKit part of fix for <rdar://problem/3709505>
Safari should have a way to upload bundles from the file upload control (as zip)
Added UIDelegate methods to let the application handle generating replacement files for uploads.
In this case, Safari will create archived files for bundles so they can be uploaded properly.
* DefaultDelegates/WebDefaultUIDelegate.m:
(-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
(-[WebDefaultUIDelegate webView:generateReplacementFile:]):
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
(WebChromeClient::generateReplacementFile):
* WebView/WebUIDelegatePrivate.h:
2008-04-28 Anders Carlsson <andersca@apple.com>
Reviewed by Sam, Mark, Adele and Darin.
Initialize the application cache path.
* WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
(-[WebView _commonInitializationWithFrameName:groupName:]):
2008-04-28 Alice Liu <alice.liu@apple.com>
Reviewed by Darin.
Fix <rdar://problem/4911289> Add tabindex property to all children
of HTMLElement (7138)
http://bugs.webkit.org/show_bug.cgi?id=7138
* MigrateHeaders.make:
Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
because now that focus() has been moved to DOMHTMLElement.h, these
files are no longer needed.
2008-04-25 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
Fix run-webkit-tests --threading
and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
Proxy server issue in Sunday's Nightly
* WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
only done from icon database code, which is not robust enough.
2008-04-20 Adam Barth <hk9565@gmail.com>
Reviewed by Adam Roben and Sam Weinig.
Updated WebSecurityOrigin to match new SecurityOrigin API.
Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin domain]):
* Storage/WebSecurityOriginPrivate.h:
2008-04-25 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Add some content to an empty ICU header file to prevent verification errors.
* icu/unicode/utf_old.h:
2008-04-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Add offlineWebApplicationCacheEnabled preference.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
(-[WebPreferences offlineWebApplicationCacheEnabled]):
(-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _updateSettingsFromPreferences:]):
2008-04-24 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Remove code for calculating the glyph cache size.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Remove unused symbol.
2008-04-24 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
* WebKitPrefix.h:
2008-04-24 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Fix layout test regressions from my earlier preferences/settings tweak.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
the notification to update the settings, each WebView still needs to register for the
notification - restore that behavior.
2008-04-24 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
<rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
* WebView/WebFrame.mm:
(-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
VisiblePosition::caretRect() instead of the RenderObject method which
was removed.
2008-04-24 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Rework the Settings population again.
* WebView/WebView.mm:
(-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
and directly from WebView's common init function.
(-[WebView _preferencesChangedNotification:]):
(-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
after creating the new Page
2008-04-24 Darin Adler <darin@apple.com>
Reviewed by Geoff.
- fix crash in regression test where we'd ask a frame for a user agent string
after the WebView was already closed
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
added some code to prevent the crash in release builds if this problem happens
again.
2008-04-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Change some String arguments to be const references instead.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldInsertText):
2008-04-24 John Sullivan <sullivan@apple.com>
Mac build fix
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXButtonActionVerb]):
implement this method using the text in WebCoreLocalizedStrings.cpp
(-[WebViewFactory AXRadioButtonActionVerb]):
ditto
(-[WebViewFactory AXTextFieldActionVerb]):
ditto
(-[WebViewFactory AXCheckedCheckBoxActionVerb]):
ditto
(-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
ditto
(-[WebViewFactory AXLinkActionVerb]):
ditto
2008-04-23 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
object before the Settings object is initialized. It seems quite prudent to post the preferences changed notification,
thereby populating the Settings object, immediately after the Page is created.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2008-04-24 John Sullivan <sullivan@apple.com>
Reviewed by Jess
- fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
* Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]):
deploy userSpaceScaleFactor when using view distances on the window
2008-04-22 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
* Plugins/npfunctions.h:
2008-04-20 Matt Lilek <webkit@mattlilek.com>
Mysteriously reviewed by mitz|away.
Bug 18111: Closing a tab while dragging crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=18111
Null check the page before handling drag events.
* WebView/WebView.mm:
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
2008-04-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Add a WebPreference for the path of the local storage persistent store.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(-[WebPreferences _localStorageDatabasePath]):
(-[WebPreferences _setLocalStorageDatabasePath:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
2008-04-18 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
No reason to do the work twice...
* WebView/WebView.mm:
(-[WebView _close]):
2008-04-17 Eric Seidel <eric@webkit.org>
Reviewed by beth.
Rename Frame::renderer() to contentRenderer() and fix uses.
* Misc/WebCoreStatistics.mm:
* WebView/WebRenderNode.mm:
(-[WebRenderNode initWithWebFrameView:]):
2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by mrowe.
* WebView/WebFrame.mm: Remove temporary build fix.
2008-04-17 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2008-04-17 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Dan Bernstein.
Fix the Mac build.
* WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
for now. This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
for this to live going forward.
2008-04-15 Kevin Decker <kdecker@apple.com>
Reviewed by Anders.
<rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
a bundle out from underneath itself.
* Plugins/WebBasePluginPackage.h: Added unload method.
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
(-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage unload]): Added.
2008-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
* Configurations/WebKit.xcconfig:
2008-04-15 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan
Do a more complete job adding the "WebArchiveDebugMode" pref
* WebView/WebPreferences.m: Add both getter *and* setter
(-[WebPreferences webArchiveDebugModeEnabled]):
(-[WebPreferences setWebArchiveDebugModeEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Call the renamed getter
2008-04-14 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Add a hidden pref to debug WebArchive loading. With this pref on, when loading a WebArchive,
if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
network and will instead fail the load as "cancelled."
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
(-[WebPreferences _webArchiveDebugModeEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
2008-04-11 David Hyatt <hyatt@apple.com>
Rename CachedResource ref/deref methods to addClient/removeClient.
Reviewed by olliej
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLViewPrivate finalize]):
(-[WebHTMLViewPrivate clear]):
(-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2008-04-07 Brady Eidson <beidson@apple.com>
Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
* Configurations/WebKit.xcconfig:
2008-04-04 Adam Roben <aroben@apple.com>
Use WebCore's ICU headers instead of our own copy
Rubberstamped by Tim Hatcher.
* Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
PrivateHeaders.
2008-04-04 Adam Roben <aroben@apple.com>
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
* Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
WebCore's PrivateHeaders instead of our own copy.
2008-04-04 Ada Chan <adachan@apple.com>
Now we pass width and height directly as integers to format
the window title for a standalone image.
Reviewed by Dan.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory imageTitleForFilename:width:height:]):
2008-04-03 Nicholas Shanks <webkit@nickshanks.com>
Updated by Dan Bernstein. Reviewed by Dave Hyatt.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
font-weight does not properly support graded weights
* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleFromFontAttributes:]):
(-[WebHTMLView _originalFontB]):
(-[WebHTMLView _addToStyle:fontA:fontB:]):
2008-04-02 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Ensure that debug symbols are generated for x86_64 and ppc64 builds.
* Configurations/Base.xcconfig:
2008-03-31 Alice Liu <alice.liu@apple.com>
Reviewed by Darin.
* WebView/WebFrame.mm:
(-[WebFrame _accessibilityTree]):
The syntax for fetching an object from the AXObjectCache changed slightly
2008-03-31 Brady Eidson <beidson@apple.com>
Reviewed by Jon Honeycutt
Move a WebArchive loading check into WebCore
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
responsible for checking that state
2008-03-31 Brady Eidson <beidson@apple.com>
Reviewed by Darin and Mitz's rubber stamp
Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
* WebCoreSupport/WebEditorClient.mm:
* WebCoreSupport/WebEditorClient.h:
2008-03-28 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Remove WebArchiver.h/mm
* WebView/WebArchiver.h: Removed.
* WebView/WebArchiver.mm: Removed.
* DOM/WebDOMOperations.mm:
* WebCoreSupport/WebDragClient.mm:
* WebCoreSupport/WebEditorClient.mm:
* WebView/WebDataSource.mm:
* WebView/WebHTMLView.mm:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::dataForArchivedSelection):
* WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
* WebView/WebArchiver.mm: Ditto
* WebView/WebHTMLView.mm:
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
More Kit->Core WebArchive changes.
Create an archive from the current selection in a frame
* WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
easily in a followup
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
WebArchive saga continues - Can now make archives from ranges in WebCore
* DOM/WebDOMOperations.mm:
(-[DOMRange webArchive]):
(-[DOMRange markupString]):
* WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
* WebView/WebArchiver.mm:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
More Kit->Core webarchive code movement
* DOM/WebDOMOperations.mm:
(-[DOMNode markupString]): Call createFullMarkup() instead
* WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
* WebView/WebFrameInternal.h: Ditto
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
* WebView/WebArchiver.h:
* WebView/WebArchiver.mm:
* WebView/WebDataSource.mm:
(-[WebDataSource webArchive]):
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove unused [WebArchiver archiveNode:], made obsolete in r31400
* WebView/WebArchiver.h:
* WebView/WebArchiver.mm:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
"Yet another transitional step" to empty out WebKit-based code for archiving.
With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.
* DOM/WebDOMOperations.mm:
* WebView/WebArchiver.mm:
(+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.
This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.
This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
* WebView/WebDataSource.mm:
(-[WebDataSource mainResource]): Call DocumentLoader implementation
(-[WebDataSource subresources]): Ditto
* WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
* WebView/WebFrameInternal.h:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam
Change the "init from WebCore resource" version of WebResource to take PassRefPtr
(more efficient)
* WebView/WebResource.mm:
(-[WebResource _initWithCoreResource:]):
* WebView/WebResourceInternal.h:
2008-03-26 Brady Eidson <beidson@apple.com>
Build fix - accidentally checked in this change which was work in progress
* DOM/WebDOMOperations.mm:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Darin
When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"
That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node
* DOM/WebDOMOperations.mm:
(-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
calling into individual WebCore::Node implementations
* DOM/WebDOMOperationsPrivate.h:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
* WebView/WebDataSource.mm:
(-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
* WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
has now been ported down to WebCore
* WebView/WebFrameInternal.h:
2008-03-26 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Brady Eidson.
Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
* Configurations/WebKit.xcconfig:
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
2008-03-26 Mark Rowe <mrowe@apple.com>
Fix the Mac build.
* MigrateHeaders.make: Copy the newly generated header into the right place.
2008-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Beth Dakin
Remove entirely unused internal method
* WebView/WebArchiver.h:
* WebView/WebArchiver.mm:
2008-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
<rdar://problem/5819308> - View Source is empty when view webarchives
* WebCore.base.exp:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setParsedArchiveData):
(WebCore::DocumentLoader::parsedArchiveData):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
in the DocumentLoader
2008-03-25 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17933
Reopen All Windows From Last Session causes crash
* WebView/WebHTMLView.mm:
(-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
check.
2008-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Jon Honeycutt's rubberstamp
Fix a leak with the new WebArchive setup
* WebView/WebArchive.mm:
(-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2008-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Removed the concept of "pending archive resources" and the "archive resources delivery timer"
from WebFrameLoaderClient, as those concepts have been pushed into WebCore
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::WebFrameLoaderClient):
2008-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Remove newly obsolete FrameLoaderClient methods
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
2008-03-25 Brady Eidson <beidson@apple.com>
Release build fix
* WebView/WebArchive.mm:
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
2008-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Darin
<rdar://problem/4516169> - Support WebArchives on Windows
And paves the way for many future WebArchive bug fixes and enhancements
This change moves most of the real workhorse code about WebArchives into WebCore. It maintains
1-to-1 relationships between a few objects in WebCore and WebKit. Such as:
* WebArchive <-> LegacyWebArchive
* WebResource <-> ArchiveResource
* WebUnarchivingState <-> ArchiveResourceCollection
The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
and now exist in WebCore
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
(WebFrameLoaderClient::finalSetupForReplace):
(WebFrameLoaderClient::setDefersLoading):
(WebFrameLoaderClient::willUseArchive):
(WebFrameLoaderClient::isArchiveLoadPending):
(WebFrameLoaderClient::cancelPendingArchiveLoad):
(WebFrameLoaderClient::clearArchivedResources):
(WebFrameLoaderClient::createFrame):
* WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
(-[WebArchivePrivate init]):
(-[WebArchivePrivate initWithCoreArchive:]):
(-[WebArchivePrivate coreArchive]):
(-[WebArchivePrivate setCoreArchive:]):
(-[WebArchivePrivate dealloc]):
(-[WebArchivePrivate finalize]):
(-[WebArchive init]):
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive initWithData:]):
(-[WebArchive initWithCoder:]):
(-[WebArchive encodeWithCoder:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
(-[WebArchive data]):
(-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
(-[WebArchive WebCore::]):
* WebView/WebArchiveInternal.h: Added.
* WebView/WebDataSource.mm:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _addSubframeArchives:]):
(-[WebDataSource _documentFragmentWithArchive:]):
(-[WebDataSource subresourceForURL:]):
(-[WebDataSource addSubresource:]):
* WebView/WebDataSourceInternal.h:
* WebView/WebFrame.mm:
(-[WebFrame loadArchive:]):
* WebView/WebFrameInternal.h:
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
* WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
(-[WebResourcePrivate init]):
(-[WebResourcePrivate initWithCoreResource:]):
(-[WebResourcePrivate dealloc]):
(-[WebResourcePrivate finalize]):
(-[WebResource initWithCoder:]):
(-[WebResource encodeWithCoder:]):
(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _initWithCoreResource:WebCore::]):
(-[WebResource WebCore::]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _fileWrapperRepresentation]):
(-[WebResource _response]):
(-[WebResource _stringValue]):
* WebView/WebResourceInternal.h: Added.
* WebView/WebResourcePrivate.h:
* WebView/WebUnarchivingState.h: Removed.
* WebView/WebUnarchivingState.m: Removed.
2008-03-24 Oliver Hunt <oliver@apple.com>
Reviewed by Mark Rowe.
Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
<http://bugs.webkit.org/show_bug.cgi?id=18030>
Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
<http://bugs.webkit.org/show_bug.cgi?id=18057>
* WebView/WebHTMLView.mm:
(-[WebHTMLView keyDown:]):
2008-03-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej, landed by Brady
Bug 3580: iFrames Appear to be Cached
<http://bugs.webkit.org/show_bug.cgi?id=3580>
Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
<http://bugs.webkit.org/show_bug.cgi?id=15486>
Bug 15554: Reload causes <object> to use old data
<http://bugs.webkit.org/show_bug.cgi?id=15554>
If a page is reloaded, a child frame's URL can not be taken from a history item.
* WebView/WebFrame.mm:
(-[WebFrame _loadURL:referrer:intoChild:]):
2008-03-24 Darin Adler <darin@apple.com>
Reviewed by Beth.
- fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
* History/WebHistoryItem.mm:
(-[WebHistoryItem URL]): Use a reference to avoid making a copy.
* WebView/WebDataSource.mm:
(-[WebDataSource _URL]): Ditto.
(-[WebDataSource unreachableURL]): Ditto.
* WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
* History/WebHistory.mm:
* Misc/WebElementDictionary.mm:
* Misc/WebNSAttributedStringExtras.mm:
Remove unneeded imports of KURL.h.
2008-03-24 Brady Eidson <beidson@apple.com>
Reviewed by Darin's rubberstamp
Rename this file for upcoming work.
* WebView/WebArchive.m: Removed.
* WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
2008-03-24 Alexey Proskuryakov <ap@webkit.org>
Build fix.
* MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
2008-03-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
Bug 17670: Key events may improperly propagate from iframe to parent frame
<http://bugs.webkit.org/show_bug.cgi?id=17670>
Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
<http://bugs.webkit.org/show_bug.cgi?id=16381>
Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
as that results in us dispatching the key events for each frame going up the frame
tree.
* WebView/WebHTMLView.mm:
(-[WebHTMLView keyDown:]):
(-[WebHTMLView keyUp:]):
(-[WebHTMLView flagsChanged:]):
2008-03-21 Timothy Hatcher <timothy@apple.com>
Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
http://bugs.webkit.org/show_bug.cgi?id=17980
Reviewed by Adam.
The new highlight drawing was not honoring the fade value, so it was
always drawing at full opacity. The animation code didn't match Windows
and the new highlight anyway, so it has been removed. The highlight
how just detaches when it is hidden.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
(-[WebInspectorWindowController close]): Ditto.
(-[WebInspectorWindowController highlightNode:]): Call attach.
(-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
* WebInspector/WebNodeHighlight.h:
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
(-[WebNodeHighlight attach]): Renamed from attachHighlight.
(-[WebNodeHighlight detach]): Renamed from detachHighlight.
(-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
* WebInspector/WebNodeHighlightView.h:
* WebInspector/WebNodeHighlightView.m:
(-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
2008-03-20 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
command-line.
* Configurations/WebKit.xcconfig:
2008-03-20 Adam Roben <aroben@apple.com>
Make WebNodeHighlightView use InspectorController to do its painting
Reviewed by Tim Hatcher.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController highlightNode:]): Pass the
InspectorController to the WebNodeHighlight, and don't call
setHighlightedNode: (which has been removed).
(-[WebInspectorWindowController hideHighlight]): Removed call to
setHighlightedNode:.
* WebInspector/WebNodeHighlight.h:
- Replaced _highlightNode with _inspectorController
- Removed _highlightedNode accessors
- Added -inspectorController method
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
takes an InspectorController* and stores it in _inspectorController.
(-[WebNodeHighlight dealloc]): Removed code dealing with
_highlightedNode.
(-[WebNodeHighlight inspectorController]): Added.
* WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
(-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
GraphicsContexts to be based on a flipped CGContext, so we have to
specify that this view is flipped.
(-[WebNodeHighlightView drawRect:]): Changed to create a
GraphicsContext and pass it to InspectorController::drawNodeHighlight.
2008-03-18 David Hyatt <hyatt@apple.com>
Add support for a preference in WebKit that can be used in nightly builds to test full page
zoom.
Reviewed by Antti
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebView.mm:
(-[WebView setTextSizeMultiplier:]):
(-[WebView canMakeTextSmaller]):
(-[WebView makeTextSmaller:]):
(-[WebView canMakeTextLarger]):
(-[WebView makeTextLarger:]):
(-[WebView canMakeTextStandardSize]):
(-[WebView makeTextStandardSize:]):
2008-03-17 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Export _NPN_IntFromIdentifier as part of our NPAPI interface
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
2008-03-14 Brady Eidson <beidson@apple.com>
Reviewed by Brian Dash's rubberstamp
Remove a class declaration for a class that has never existed
* WebView/WebResource.h:
2008-03-14 David D. Kilzer <ddkilzer@apple.com>
Unify concept of enabling the Mac Java bridge.
Reviewed by Darin and Anders.
* Plugins/WebPluginJava.h: Removed unused file.
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
* WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
(WebFrameLoaderClient::javaApplet): Ditto.
2008-03-13 Antti Koivisto <antti@apple.com>
Reviewed by Darin.
* ForwardingHeaders/wtf/Deque.h: Added.
2008-03-13 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Call originalRequest, not initialRequest.
* WebView/WebDataSource.mm:
(-[WebDataSource initialRequest]):
2008-03-12 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
- cleanup after removing the bridge
* DOM/WebDOMOperations.mm:
(-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
* Misc/WebCoreStatistics.mm:
(-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
_frameLoader method.
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
Ditto.
* Plugins/WebPluginController.mm:
(-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
method. Without this we could leave a stale frame pointer around.
(WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
caller of the _isMainFrame method.
(WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
_frameLoader method.
(WebFrameLoaderClient::createFrame): Moved code here from _addChild.
* WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
turned out to be unused.
(core): Added overload for DocumentFragment.
(kit): Ditto.
(-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
to FrameLoader with _private->coreFrame->loader().
(-[WebFrame _attachScriptDebugger]): Ditto.
(-[WebFrame _clearCoreFrame]): Added.
(-[WebFrame _updateBackground]): More of the same.
(-[WebFrame _unmarkAllBadGrammar]): Ditto.
(-[WebFrame _unmarkAllMisspellings]): Ditto.
(-[WebFrame _hasSelection]): Ditto.
(-[WebFrame _atMostOneFrameHasSelection]): Ditto.
(-[WebFrame _findFrameWithSelection]): Ditto.
(-[WebFrame _dataSource]): Ditto.
(-[WebFrame _addData:]): Streamlined code a bit.
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
(-[WebFrame _receivedData:textEncodingName:]): Ditto.
(-[WebFrame _isDescendantOfFrame:]): Ditto.
(-[WebFrame _bodyBackgroundColor]): Ditto.
(-[WebFrame _isFrameSet]): Ditto.
(-[WebFrame _firstLayoutDone]): Ditto.
(-[WebFrame _loadType]): Ditto.
(-[WebFrame _isDisplayingStandaloneImage]): Ditto.
(-[WebFrame name]): Ditto.
(-[WebFrame DOMDocument]): Ditto.
(-[WebFrame frameElement]): Ditto.
(-[WebFrame provisionalDataSource]): Ditto.
(-[WebFrame dataSource]): Ditto.
(-[WebFrame loadRequest:]): Ditto.
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
(-[WebFrame loadArchive:]): Ditto.
(-[WebFrame stopLoading]): Ditto.
(-[WebFrame reload]): Ditto.
(-[WebFrame findFrameNamed:]): Ditto.
(-[WebFrame parentFrame]): Ditto.
(-[WebFrame childFrames]): Ditto.
(-[WebFrame windowObject]): Ditto.
(-[WebFrame globalContext]): Ditto.
* WebView/WebFrameInternal.h: Added overloads of core and kit.
Removed method declarations.
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
(formElementFromDOMElement): Ditto.
(-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
(inputElementFromDOMElement): Ditto.
(-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
(-[WebHTMLRepresentation elementIsPassword:]): Ditto.
(-[WebHTMLRepresentation formForElement:]): Ditto.
(-[WebHTMLRepresentation currentForm]): Ditto.
(-[WebHTMLRepresentation controlsInForm:]): Ditto.
(-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
(-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Call createFragmentFromText directly instead of via WebFrame.
(-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
Moved layout calls here from WebFrame.
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
(-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
(-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
(-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
(-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
Moved code here from WebFrame.
(-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
(-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
(-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
(-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
(-[WebHTMLView unmarkAllTextMatches]): Ditto.
(-[WebHTMLView rectsForTextMatches]): Ditto.
* WebView/WebHTMLViewInternal.h: Removed unused method declarations.
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
_frameLoader method.
* WebView/WebRenderNode.mm:
(copyRenderNode): Moved code here from WebFrame.
(-[WebRenderNode initWithWebFrameView:]): Ditto.
* WebView/WebResource.mm:
(-[WebResource _stringValue]): Moved code here from WebFrame.
* WebView/WebView.mm:
(-[WebView _close]): Use core function intsead of _frameLoader method.
(-[WebView setCustomTextEncodingName:]): Ditto.
(-[WebView setHostWindow:]): Moved code here from WebFrame.
(aeDescFromJSValue): Moved this here from WebFrame.
(-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
2008-03-12 Darin Adler <darin@apple.com>
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17640
eliminate WebCoreFrameBridge
Moved all the code from the bridge into WebFrame. This need not be the final
home of these methods -- they can be moved closer to their callers and improved
further -- but it eliminates the bridge without requiring a rewrite of the code.
It's a fairly mechanical process (just adding underscores to method names really).
There's even a chance that some of the methods are unused. Those we can remove
after checking if that's so.
* DOM/WebDOMOperations.mm:
(-[DOMNode markupString]): Use WebFrame rather than bridge.
(-[DOMDocument webFrame]): Changed to use the core and kit functions
instead of using the bridge.
(-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
(-[DOMRange markupString]): Ditto.
* DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
* DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
* History/WebHistoryItem.mm: Ditto.
* MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
* Misc/WebCoreStatistics.mm:
(-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
* Misc/WebElementDictionary.mm: Removed unneeded import.
* Misc/WebKitStatistics.m:
(+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
* Misc/WebKitStatisticsPrivate.h: Ditto.
* Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
* Misc/WebNSPasteboardExtras.mm: Ditto.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
rather than bridge.
* Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
* Plugins/WebNetscapePluginStream.mm: Ditto.
* Plugins/WebPluginContainerCheck.mm:
(-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
bridge to get to the WebCore::Frame.
* Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
* Plugins/WebPluginController.mm:
(-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
rather than bridge.
* WebCoreSupport/WebEditorClient.mm:
(selectorForKeyEvent): Tweaked comment.
* WebCoreSupport/WebFrameBridge.h: Removed.
* WebCoreSupport/WebFrameBridge.mm: Removed.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
(WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
I could remove this function entirely, but it looks like the Qt port is using it.
* WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
* WebView/WebArchiver.mm:
(+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
(+[WebArchiver archiveNode:]): Ditto.
(+[WebArchiver archiveSelectionInFrame:]): Ditto.
* WebView/WebDataSource.mm:
(-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
(-[WebDataSource _documentFragmentWithArchive:]): Ditto.
(-[WebDataSource subresources]): Ditto.
(-[WebDataSource subresourceForURL:]): Ditto.
* WebView/WebDataSourceInternal.h: Removed _bridge method.
* WebView/WebFrame.mm:
(-[WebFramePrivate dealloc]): Removed code to release the bridge.
(core): Go directly to the core frame, not via the bridge.
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
Remove the code to deal with the bridge.
(-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
shouldCreateRenderers flag, formerly on the bridge.
(-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
(aeDescFromJSValue): Moved here from bridge.
(-[WebFrame _domain]): Ditto.
(-[WebFrame _addData:]): Ditto.
(-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
(-[WebFrame _nodesFromList:]): Ditto.
(-[WebFrame _markupStringFromNode:nodes:]): Ditto.
(-[WebFrame _markupStringFromRange:nodes:]): Ditto.
(-[WebFrame _selectedString]): Ditto.
(-[WebFrame _stringForRange:]): Ditto.
(-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
(-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
(-[WebFrame _sendScrollEvent]): Ditto.
(-[WebFrame _drawRect:]): Ditto.
(-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
(-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
(-[WebFrame _copyRenderNode:copier:]): Ditto.
(-[WebFrame _copyRenderTree:]): Ditto.
(inputElementFromDOMElement): Ditto.
(formElementFromDOMElement): Ditto.
(-[WebFrame _elementWithName:inForm:]): Ditto.
(-[WebFrame _elementDoesAutoComplete:]): Ditto.
(-[WebFrame _elementIsPassword:]): Ditto.
(-[WebFrame _formForElement:]): Ditto.
(-[WebFrame _currentForm]): Ditto.
(-[WebFrame _controlsInForm:]): Ditto.
(-[WebFrame _searchForLabels:beforeElement:]): Ditto.
(-[WebFrame _matchLabels:againstElement:]): Ditto.
(-[WebFrame _URLWithAttributeString:]): Ditto.
(-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
(-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
(-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
(-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
(-[WebFrame _unmarkAllTextMatches]): Ditto.
(-[WebFrame _rectsForTextMatches]): Ditto.
(-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
(-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
(-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
(-[WebFrame _firstRectForDOMRange:]): Ditto.
(-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
(-[WebFrame _baseURL]): Ditto.
(-[WebFrame _stringWithData:]): Ditto.
(+[WebFrame _stringWithData:textEncodingName:]): Ditto.
(-[WebFrame _needsLayout]): Ditto.
(-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
(-[WebFrame _accessibilityTree]): Ditto.
(-[WebFrame _setBaseBackgroundColor:]): Ditto.
(-[WebFrame _setDrawsBackground:]): Ditto.
(-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
Ditto.
(-[WebFrame _selectionGranularity]): Ditto.
(-[WebFrame _convertToNSRange:]): Ditto.
(-[WebFrame _convertToDOMRange:]): Ditto.
(-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
(-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
(-[WebFrame _markDOMRange]): Ditto.
(-[WebFrame _markedTextNSRange]): Ditto.
(-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
(-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
(-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
(-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
(-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
(-[WebFrame _visiblePositionForPoint:]): Ditto.
(-[WebFrame _characterRangeAtPoint:]): Ditto.
(-[WebFrame _typingStyle]): Ditto.
(-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
(-[WebFrame _fontForSelection:]): Ditto.
(-[WebFrame _dragSourceMovedTo:]): Ditto.
(-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
(-[WebFrame _getData:andResponse:forURL:]): Ditto.
(-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
(-[WebFrame _canProvideDocumentSource]): Ditto.
(-[WebFrame _canSaveAsWebArchive]): Ditto.
(-[WebFrame _receivedData:textEncodingName:]): Ditto.
(-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
function. Couldn't just keep the bridge method because this was already here with the same name.
(-[WebFrame _selectedNSRange]): Ditto.
(-[WebFrame _selectNSRange:]): Ditto.
(-[WebFrame dealloc]): Remove bridge-related code.
(-[WebFrame finalize]): Ditto.
* WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
Removed the bridge parameter from the init method. Removed the #if blocks that
tried to make this header work in non-C++ ObjC files -- they were broken and unused.
Removed the _bridge method.
* WebView/WebFrameView.mm: Removed the _bridge method.
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
field.
(-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
(-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
(-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
(-[WebHTMLRepresentation documentSource]): Ditto.
(-[WebHTMLRepresentation DOMDocument]): Ditto.
(-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
(-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
(-[WebHTMLRepresentation elementIsPassword:]): Ditto.
(-[WebHTMLRepresentation formForElement:]): Ditto.
(-[WebHTMLRepresentation currentForm]): Ditto.
(-[WebHTMLRepresentation controlsInForm:]): Ditto.
(-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
(-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
* WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
(-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
(-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
(-[WebHTMLView _frameOrBoundsChanged]): Ditto.
(-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
(-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
(-[WebHTMLView drawSingleRect:]): Ditto.
(-[WebHTMLView draggedImage:movedTo:]): Ditto.
(-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
(-[WebHTMLView knowsPageRange:]): Ditto.
(-[WebHTMLView accessibilityAttributeValue:]): Ditto.
(-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
(-[WebHTMLView accessibilityHitTest:]): Ditto.
(-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
(-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
(-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
(-[WebHTMLView _changeSpellingToWord:]): Ditto.
(-[WebHTMLView startSpeaking:]): Ditto.
(-[WebHTMLView _updateFontPanel]): Ditto.
(-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
(-[WebHTMLView _layoutIfNeeded]): Ditto.
(-[WebHTMLView characterIndexForPoint:]): Ditto.
(-[WebHTMLView firstRectForCharacterRange:]): Ditto.
(-[WebHTMLView selectedRange]): Ditto.
(-[WebHTMLView markedRange]): Ditto.
(-[WebHTMLView attributedSubstringFromRange:]): Ditto.
(-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
(-[WebHTMLView insertText:]): Ditto.
(-[WebTextCompleteController _insertMatch:]): Ditto.
(-[WebTextCompleteController doCompletion]): Ditto.
(-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
(-[WebHTMLView string]): Ditto.
(-[WebHTMLView selectedString]): Ditto.
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
(-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
(-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
(-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
(-[WebHTMLView unmarkAllTextMatches]): Ditto.
(-[WebHTMLView rectsForTextMatches]): Ditto.
* WebView/WebRenderNode.mm:
(-[WebRenderNode initWithWebFrameView:]): Ditto.
* WebView/WebResource.mm:
(-[WebResource _stringValue]): Ditto.
* WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
* WebView/WebView.mm:
(-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
(-[WebView setProhibitsMainFrameScrolling:]): Ditto.
(-[WebView _setInViewSourceMode:]): Ditto.
(-[WebView _inViewSourceMode]): Ditto.
(-[WebView _executeCoreCommandByName:value:]): Ditto.
(-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
(-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
(-[WebView scrollDOMRangeToVisible:]): Ditto.
(-[WebView setSelectedDOMRange:affinity:]): Ditto.
(-[WebView setEditable:]): Ditto.
(-[WebView setTypingStyle:]): Ditto.
(-[WebView typingStyle]): Ditto.
(-[WebView replaceSelectionWithNode:]): Ditto.
(-[WebView replaceSelectionWithText:]): Ditto.
(-[WebView replaceSelectionWithMarkupString:]): Ditto.
(-[WebView replaceSelectionWithArchive:]): Ditto.
(-[WebView _insertNewlineInQuotedContent]): Ditto.
(-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
2008-03-12 David Hyatt <hyatt@apple.com>
Make the zoom factor a float and not a percent.
Reviewed by antti
* WebView/WebView.mm:
(-[WebView _setZoomMultiplier:isTextOnly:]):
2008-03-11 David Hyatt <hyatt@apple.com>
This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
New API is added that is parallel to the text zoom public API. You can get/set a pageSizeMultiplier and you
can zoom the page in, out or reset it to the standard size.
In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
and set the common zoom factor. In other words you can't combine text zoom and page zoom. One will always
win.
Reviewed by Tim H.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
* WebView/WebDocumentInternal.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView viewDidMoveToSuperview]):
* WebView/WebPDFView.h:
* WebView/WebPDFView.mm:
(-[WebPDFView _zoomOut:]):
(-[WebPDFView _zoomIn:]):
(-[WebPDFView _resetZoom:]):
(-[WebPDFView _canZoomOut]):
(-[WebPDFView _canZoomIn]):
(-[WebPDFView _canResetZoom]):
* WebView/WebView.mm:
(-[WebViewPrivate init]):
(-[WebView setTextSizeMultiplier:]):
(-[WebView textSizeMultiplier]):
(-[WebView _setZoomMultiplier:isTextOnly:]):
(-[WebView _zoomMultiplier:]):
(-[WebView _realZoomMultiplier]):
(-[WebView _realZoomMultiplierIsTextOnly]):
(-[WebView _canZoomOut:]):
(-[WebView _canZoomIn:]):
(-[WebView _zoomOut:isTextOnly:]):
(-[WebView _zoomIn:isTextOnly:]):
(-[WebView _canResetZoom:]):
(-[WebView _resetZoom:isTextOnly:]):
(-[WebView canMakeTextSmaller]):
(-[WebView makeTextSmaller:]):
(-[WebView canMakeTextLarger]):
(-[WebView makeTextLarger:]):
(-[WebView canMakeTextStandardSize]):
(-[WebView makeTextStandardSize:]):
(-[WebView setPageSizeMultiplier:]):
(-[WebView pageSizeMultiplier]):
(-[WebView canZoomPageIn]):
(-[WebView zoomPageIn:]):
(-[WebView canZoomPageOut]):
(-[WebView zoomPageOut:]):
(-[WebView canResetPageZoom]):
(-[WebView resetPageZoom:]):
(-[WebView _searchWithSpotlightFromMenu:]):
* WebView/WebViewInternal.h:
* WebView/WebViewPrivate.h:
2008-03-12 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler and Sam Weinig.
- <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
WKGetNSFontATSUFontId Tiger-only.
2008-03-12 Darin Adler <darin@apple.com>
- fix http://bugs.webkit.org/show_bug.cgi?id=17794
REGRESSION (r30980): 23 tests hanging on the Mac buildbot
* WebView/WebFrame.mm:
(-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
up pointer from the bridge to the frame. (My next check-in removes the bridge
entirely, but we need this until then.)
2008-03-11 Darin Adler <darin@apple.com>
Reviewed by Sam.
- remove all bridge-related things from WebCore except the bridge itself
* DOM/WebDOMOperations.mm:
(-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
* DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
* Plugins/WebPluginController.mm: Ditto.
* WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
init and close methods. Added a setWebFrame: method.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge setWebFrame:]): Added.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
(WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
bridge here. Soon we will be able to remove this entirely!
(WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
into WebFrame from the bridge.
* WebView/WebFrame.mm:
(-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
now owned by the frame.
(-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
debugger under GC without this!
(kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
use WebFrameLoaderClient instead of the bridge.
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
This is code that used to live in the bridge's init function.
(+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
(+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
(-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
the WebView is now the bridge's owner.
(-[WebFrame _updateBackground]): Changed this one call site that was calling the
WebCore::Frame::bridge function directly to use the kit function instead.
(-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
This code won't last long -- we're eliminating the bridge soon.
(-[WebFrame finalize]): Ditto.
* WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
for creating frames.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
where we have to allocate a WebFrameBridge and then immediately release it.
2008-03-11 Darin Adler <darin@apple.com>
Reviewed by Anders.
- remove code depending on the bridge to get from an NSView to a WebCore::Frame
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
to setView. A couple lines later, there is a call to _install, which sets the
view to the scroll view.
* WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
* WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
this file, since it's used by Safari.
* WebView/WebDynamicScrollBarsViewInternal.h: Added.
* WebView/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView updateScrollers]): Ditto.
(-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
(-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
(-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
(-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
(-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
(-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
(-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
(-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
(-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
(-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
(-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
(-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
* WebView/WebFrameView.mm:
(-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
* WebView/WebView.mm:
(-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
(-[WebView alwaysShowVerticalScroller]): Ditto.
(-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
(-[WebView alwaysShowHorizontalScroller]): Ditto.
2008-03-11 Darin Adler <darin@apple.com>
Reviewed by Sam.
- eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
* WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
bridge methods.
* WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
to recently-created functions.
(WebChromeClient::firstResponder): Moved code here from the bridge.
(WebChromeClient::makeFirstResponder): Ditto.
(WebChromeClient::runOpenPanel): Ditto.
(WebChromeClient::willPopUpMenu): Ditto.
* WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
is related to creating the bridge and connecting it to WebCore, which will
go next when I eliminate use of the bridge to get to/from the Frame*.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge close]): Moved the code to track the bridge count here
instead of the dealloc and finalize methods.
2008-03-11 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- update code affected by Range changes
* Misc/WebNSAttributedStringExtras.mm:
(+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
Use Range::create.
* WebView/WebHTMLView.mm:
(-[WebHTMLView attributedString]): Ditto.
2008-03-10 Darin Adler <darin@apple.com>
Reviewed by Sam.
- eliminate keyboard UI mode method from WebCoreFrameBridge
* WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
* WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
fields for keyboard UI mode.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
method.
(-[WebFrameBridge finalize]): Ditto.
* WebView/WebView.mm: Moved the keyboard mode code in here.
(-[WebView _close]): Remove observer from the distributed notification
center as well as the normal one.
(-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
here from the bridge.
(-[WebView _keyboardUIMode]): Ditto.
* WebView/WebViewInternal.h: Added _keyboardUIMode method.
2008-03-10 Darin Adler <darin@apple.com>
Reviewed by Sam.
- eliminate Java applet methods from WebCoreFrameBridge
* WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
* WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
the ones that load Java applets.
* WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
* WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2008-03-07 Simon Hausmann <hausmann@webkit.org>
Reviewed by Darin.
Done with Lars.
Simplified WebViewFactory's refreshPlugins method to only refresh the
plugins and not reload the frames anymore since that's now done in a
platform independent manner by WebCore::Page.
Also removed the now unused pluginNameForMIMEType and
pluginSupportsMIMEType methods.
* WebCoreSupport/WebViewFactory.mm:
* WebView/WebFrame.mm:
* WebView/WebFrameInternal.h:
* WebView/WebView.mm:
2008-03-08 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix 64-bit build with GCC 4.2.
* DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
* DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
* History/WebHistoryItem.mm: Ditto.
* Misc/WebElementDictionary.mm: Ditto.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
variable being unused in 64-bit.
* WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
* WebView/WebHTMLView.mm:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
(-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
2008-03-08 Darin Adler <darin@apple.com>
Reviewed by Adele.
- eliminate custom highlight methods from WebCoreFrameBridge
* WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::customHighlightRect): Moved code here from bridge.
(WebChromeClient::paintCustomHighlight): Ditto.
* WebCoreSupport/WebFrameBridge.mm: Removed code here.
2008-03-07 David D. Kilzer <ddkilzer@apple.com>
Unify concept of enabling Netscape Plug-in API (NPAPI).
Reviewed by Darin.
* WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
* WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
* Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
#if ENABLE(NETSCAPE_PLUGIN_API).
* Plugins/WebBaseNetscapePluginStream.mm: Ditto.
* Plugins/WebBaseNetscapePluginView.h: Ditto.
* Plugins/WebBaseNetscapePluginView.mm: Ditto.
* Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
* Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
* Plugins/WebBasePluginPackage.h: Ditto.
* Plugins/WebBasePluginPackage.m: Ditto.
(+[WebBasePluginPackage pluginWithPath:]):
* Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
* Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
* Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
* Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
* Plugins/WebNetscapePluginPackage.h: Ditto.
* Plugins/WebNetscapePluginPackage.m: Ditto.
* Plugins/WebNetscapePluginStream.h: Ditto.
* Plugins/WebNetscapePluginStream.mm: Ditto.
* Plugins/WebPluginDatabase.m: Ditto.
(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
* Plugins/npapi.m: Ditto.
* WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
(WebFrameLoaderClient::objectContentType):
(WebFrameLoaderClient::createPlugin):
* WebView/WebHTMLView.mm: Ditto.
(-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
* WebView/WebHTMLViewInternal.h: Ditto.
* WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
#if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
category to (WebInternal) category so we don't expose the ENABLE() macro
from the private header.
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
* WebView/WebFrameInternal.h: Ditto.
* WebView/WebFramePrivate.h: Ditto.
2008-03-07 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
<rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
* WebView/WebPreferences.m:
(+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
the one used in Safari.
2008-03-07 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix WebKit build with GCC 4.2.
* Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2008-03-07 Darin Adler <darin@apple.com>
Reviewed by Adam.
- eliminated WebCoreFrameBridge runOpenPanel
* WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runOpenPanel): Added.
(-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
FileChooser so it can get a result from the UI delegate.
(-[WebOpenPanelResultListener dealloc]): Added.
(-[WebOpenPanelResultListener finalize]): Added.
(-[WebOpenPanelResultListener cancel]): Added.
(-[WebOpenPanelResultListener chooseFilename:]): Added.
2008-03-06 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- fix regression test failures from the visited-link change
* History/WebHistory.mm:
(+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
to turn off visited links if there is no history object. Also call
removeAllVisitedLinks so we can start over from scratch with the new history.
2008-03-06 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix a regression from r30741: a crash under
WebFrameLoaderClient::createPlugin() when showing a Mail message with
an attachment
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
2008-03-06 Darin Adler <darin@apple.com>
- fix Tiger build
* History/WebHistory.mm: Added include of WebTypesInternal.h.
2008-03-06 Darin Adler <darin@apple.com>
- fix Release build
* History/WebHistory.mm:
(-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
(-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
(-[WebHistoryPrivate saveToURL:error:]): Ditto.
2008-03-06 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=17526
REGRESSION: iframes are added to Safari's History menu
by separating the visited link machinery from global history
* History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
(-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
method name, since it's on a private object.
(-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
PageGroup::removeAllVisitedLinks function if the last URL was removed.
(-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
method name, since it's on a private object.
(-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
(-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
method name, since it's on a private object.
(-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
Ditto.
(-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
to correctly return the error by using the newer version of writeToURL: and
removed the FIXME about that.
(-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
for every link in the history.
(-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
(-[WebHistory addItem:]): Moved into the WebPrivate category.
(-[WebHistory addItemForURL:]): Ditto.
(-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
create an item and already know its title.
(-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
(-[WebHistory containsItemForURLString:]): Ditto.
(-[WebHistory removeItem:]): Ditto.
(-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
(-[WebHistory _itemForURLString:]): Ditto.
(-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
* History/WebHistoryInternal.h: Added.
* History/WebHistoryItemInternal.h: Tweaked formatting and includes.
* History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
Also reorganized what was left behind.
* WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::populateVisitedLinks): Added a call to the new
-[WebHistory _addVisitedLinksToPageGroup:] method.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
-[WebHistory _addItemForURL:title:] method.
2008-03-05 Adam Roben <aroben@apple.com>
Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
Reviewed by Kevin M.
* WebView/WebFrame.mm:
* WebView/WebScriptDebugDelegate.mm:
* WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
* WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
2008-03-05 Adam Roben <aroben@apple.com>
Rename WebCoreScriptDebuggerImp to WebScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebuggerImp.h:
* WebView/WebCoreScriptDebuggerImp.mm:
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
* WebView/WebFrameInternal.h:
2008-03-05 Adam Roben <aroben@apple.com>
Remove WebScriptDebugger
Uses of WebScriptDebugger have been replaced with
WebCoreScriptDebuggerImp.
Reviewed by Kevin M.
* WebView/WebFrame.mm:
(-[WebFramePrivate dealloc]): Use delete instead of release since
WebCoreScriptDebuggerImp is a C++ class.
(-[WebFrame _attachScriptDebugger]): Updated to use early returns and
WebCoreScriptDebuggerImp.
(-[WebFrame _detachScriptDebugger]): Ditto.
* WebView/WebFrameInternal.h:
* WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
* WebView/WebScriptDebugDelegatePrivate.h: Removed.
* WebView/WebView.mm:
2008-03-05 Adam Roben <aroben@apple.com>
Remove -webFrame and -globalObject from WebScriptDebugger
WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
parameter to the constructor.
* WebView/WebCoreScriptDebuggerImp.mm:
(toWebFrame): Added.
(WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
(WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
WindowScriptObject ourselves instead of asking WebScriptDebugger for
it.
(WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
(WebCoreScriptDebuggerImp::returnEvent): Ditto.
(WebCoreScriptDebuggerImp::exception): Ditto.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptDebugger initWithWebFrame:]): Updated for change to
WebScriptDebuggerImp's constructor.
* WebView/WebScriptDebugDelegatePrivate.h: Removed
-webFrame/-globalObject.
2008-03-05 Adam Roben <aroben@apple.com>
Remove -enterFrame: and -leaveFrame from WebScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
lifetime.
* WebView/WebCoreScriptDebuggerImp.mm:
- Added declaration of -[WebScriptCallFrame
_initWithGlobalObject:caller:state:].
- Changed most uses of m_topCallFrame to m_topCallFrame.get()
(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
now-unnecessary initialization of m_topCallFrame.
(WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
with its implementation. The one difference between this
implementation and the old enterFrame: method is that we don't hand
our reference to m_topCallFrame to _initWithGlobalObject: -- that
method must now retain the passed-in WebScriptCallFrame manually.
(WebCoreScriptDebuggerImp::atStatement):
(WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
with its implementation.
(WebCoreScriptDebuggerImp::exception):
* WebView/WebScriptDebugDelegate.mm: Removed declaration of
-[WebScriptCallFrame _initWithGlobalObject:caller:state:].
(-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
to retain the passed-in caller.
* WebView/WebScriptDebugDelegatePrivate.h:
- Removed _current ivar
- Removed enterFrame:/leaveFrame declarations.
2008-03-05 Adam Roben <aroben@apple.com>
Remove -parsedSource: from WebScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebuggerImp.mm:
(WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
-[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
* WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
* WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2008-03-05 Adam Roben <aroben@apple.com>
Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebuggerImp.mm:
(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
trhough to callEvent instead of duplicating its code here.
(WebCoreScriptDebuggerImp::callEvent): Moved code from
-[WebScriptDebugger enteredFrame:sourceId:line:] here.
(WebCoreScriptDebuggerImp::returnEvent): Moved code from
-[WebScriptDebugger leavingFrame:sourceId:line:] here.
(WebCoreScriptDebuggerImp::exception): Moved code from
-[WebScriptDebugger exceptionRaised:sourceId:line:] here.
* WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
-leavingFrame:, and -exceptionRaised:.
* WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2008-03-05 Adam Roben <aroben@apple.com>
Remove -[WebScriptDebugger hitStatement:sourceId:line:]
Reviewed by Kevin M.
* WebView/WebCoreScriptDebuggerImp.mm:
(WebCoreScriptDebuggerImp::atStatement): Moved code here from
-[WebScriptDebugger hitStatement:sourceId:line:].
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptDebugger webFrame]): Added.
* WebView/WebScriptDebugDelegatePrivate.h:
2008-03-05 Adam Roben <aroben@apple.com>
Remove WebCoreScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebugger.h: Removed.
* WebView/WebCoreScriptDebugger.mm: Removed.
* WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
with WebScriptDebugger.
* WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
delegate] with just m_debugger.
(toNSString): Moved here from WebCoreScriptDebugger.mm.
(toNSURL): Ditto.
(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
(WebCoreScriptDebuggerImp::sourceParsed):
(WebCoreScriptDebuggerImp::callEvent):
(WebCoreScriptDebuggerImp::atStatement):
(WebCoreScriptDebuggerImp::returnEvent):
(WebCoreScriptDebuggerImp::exception):
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
WebCoreScriptDebuggerImp, so initialize it properly.
* WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
WebCoreScriptDebuggerImp.
2008-03-05 Adam Roben <aroben@apple.com>
Move WebCoreScriptDebuggerImp to its own source files
Also changed WebCoreScriptDebuggerImp coding style to match our style
guidelines.
Reviewed by Kevin M.
* WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
function.
* WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
implementation.
(toNSURL): Made no longer static.
* WebView/WebCoreScriptDebuggerImp.h: Added.
* WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
WebCoreScriptDebugger.mm and cleaned up.
(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
(WebCoreScriptDebuggerImp::sourceParsed):
(WebCoreScriptDebuggerImp::callEvent):
(WebCoreScriptDebuggerImp::atStatement):
(WebCoreScriptDebuggerImp::returnEvent):
(WebCoreScriptDebuggerImp::exception):
2008-03-05 Adam Roben <aroben@apple.com>
Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
Reviewed by Kevin M.
* WebView/WebCoreScriptDebugger.h:
- Removed newFrameWithGlobalObject:caller:state: from
WebScriptDebugger protocol
- Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
- Removed _current ivar from WebCoreScriptDebugger
* WebView/WebCoreScriptDebugger.mm:
(WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
the delegate.
(WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptDebugger dealloc]): Added code to release _current.
(-[WebScriptDebugger enterFrame:]): Added. Code came from
WebCoreScriptDebugger.
(-[WebScriptDebugger leaveFrame]): Ditto.
* WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
2008-03-05 Adam Roben <aroben@apple.com>
Remove WebCoreScriptCallFrame
Reviewed by Tim.
* WebView/WebCoreScriptDebugger.h:
- Replaced WebCoreScriptCallFrame with WebScriptCallFrame
- Replaced -newWrapperForFrame: with
-newFrameWithGlobalObject:caller:state:
- Removed WebCoreScriptCallFrame interface.
* WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
with WebScriptCallFrame.
(-[WebCoreScriptDebugger _enterFrame:]): Changed to call
-newFrameWithGlobalObject:caller:state.
(-[WebCoreScriptDebugger _leaveFrame]):
* WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
_private ivar to be of type WebScriptCallFramePrivate*.
* WebView/WebScriptDebugDelegate.mm:
- Replaced WebCoreScriptCallFrame with WebScriptCallFrame
- Added WebScriptCallFramePrivate
(-[WebScriptDebugger enteredFrame:sourceId:line:]):
(-[WebScriptDebugger hitStatement:sourceId:line:]):
(-[WebScriptDebugger leavingFrame:sourceId:line:]):
(-[WebScriptDebugger exceptionRaised:sourceId:line:]):
(-[WebScriptCallFramePrivate dealloc]): Added.
(-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
Code came from WebCoreScriptCallFrame.
(-[WebScriptCallFrame dealloc]): Added a call to release the _private
ivar.
(-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
_private with direct access of _private's ivars.
(-[WebScriptCallFrame caller]): Ditto.
(-[WebScriptCallFrame scopeChain]): Ditto.
(-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2008-03-05 Adam Roben <aroben@apple.com>
Move -_convertValueToObjcValue to WebScriptCallFrame
Reviewed by Darin.
* WebView/WebCoreScriptDebugger.h: Removed declaration of
-_convertValueToObjcValue.
* WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
from -[WebCoreScriptCallFrame _convertValueToObjcValue].
(-[WebScriptCallFrame scopeChain]): Changed to call
-_convertValueToObjcValue on self instead of _private.
(-[WebScriptCallFrame exception]): Ditto.
(-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2008-03-05 Adam Roben <aroben@apple.com>
Move -exception and -evaluateWebScript: to WebScriptCallFrame
Reviewed by Darin.
* WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
and -evaluateWebScript:.
* WebView/WebCoreScriptDebugger.mm: Removed -exception and
-evaluateWebScript:.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame exception]): Added. Code came from
-[WebCoreScriptCallFrame exception].
(-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
-[WebCoreScriptCallFrame evaluateWebScript:].
2008-03-05 Adam Roben <aroben@apple.com>
Move -scopeChain to WebScriptCallFrame
Reviewed by Darin.
* WebView/WebCoreScriptDebugger.h:
- Added declarations of -globalObject and -_convertValueToObjcValue:
to WebCoreScriptCallFrame
- Removed declaration of -scopeChain.
* WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
within the main WebCoreScriptCallFrame implementation.
(-[WebCoreScriptCallFrame globalObject]): Added.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame scopeChain]): Added. Code came from
-[WebCoreScriptCallFrame scopeChain].
2008-03-05 Adam Roben <aroben@apple.com>
Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
Reviewed by Darin.
* WebView/WebCoreScriptDebugger.h:
- Removed #else case of #ifdef __cplusplus since this file is only
ever used by C++ Objective-C files
- Removed 'using KJS::ExecState' statement since we prefer not to
have using statements in header files
- Consequently prefixed uses of ExecState with KJS::
- Added declaration of toNSString method that takes a const
UString&
- Added declaration of -[WebCoreScriptCallFrame state]
- Removed declaration of -[WebCoreScriptCallFrame functionName]
* WebView/WebCoreScriptDebugger.mm:
(toNSString): Made this no longer static.
(-[WebCoreScriptCallFrame state]): Added.
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame functionName]): Added. Code came from
-[WebCoreScriptCallFrame functionName], though I changed some nested
ifs into early returns.
2008-03-05 Adam Roben <aroben@apple.com>
Move WebCoreScriptDebugger to WebKit
Reviewed by Darin.
* WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
* WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
(toNSString):
(toNSURL):
(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
(WebCoreScriptDebuggerImp::sourceParsed):
(WebCoreScriptDebuggerImp::callEvent):
(WebCoreScriptDebuggerImp::atStatement):
(WebCoreScriptDebuggerImp::returnEvent):
(WebCoreScriptDebuggerImp::exception):
(+[WebCoreScriptDebugger initialize]):
(-[WebCoreScriptDebugger initWithDelegate:]):
(-[WebCoreScriptDebugger dealloc]):
(-[WebCoreScriptDebugger finalize]):
(-[WebCoreScriptDebugger delegate]):
(-[WebCoreScriptDebugger _enterFrame:]):
(-[WebCoreScriptDebugger _leaveFrame]):
(-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
(-[WebCoreScriptCallFrame _setWrapper:]):
(-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
(-[WebCoreScriptCallFrame dealloc]):
(-[WebCoreScriptCallFrame wrapper]):
(-[WebCoreScriptCallFrame caller]):
(-[WebCoreScriptCallFrame scopeChain]):
(-[WebCoreScriptCallFrame functionName]):
(-[WebCoreScriptCallFrame exception]):
(-[WebCoreScriptCallFrame evaluateWebScript:]):
* WebView/WebScriptDebugDelegate.mm: Updated header path.
* WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2008-03-05 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
Include file changes.
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebNetscapePluginPackage.m:
2008-03-04 Timothy Hatcher <timothy@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5720160> Browser windows "do nothing" while modal
dialog or menu is up due to run loop modes (or while scrolling)
Add new API that lets a WebView be scheduled with multiple runloops and modes.
This lets loading continue when in a nested runloop or in a different mode.
* Misc/WebKitVersionChecks.h: Add a new version define:
WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
(-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
(-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
* WebView/WebViewPrivate.h: Add the new pending API methods.
2008-03-04 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Fix crash that happens when trying to load a page with a Java applet.
* WebCoreSupport/WebFrameLoaderClient.mm:
Don't release the names and values array - the kit method returns an autoreleased array.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- fix 200+ failing regression tests
- fix http://bugs.webkit.org/show_bug.cgi?id=17668
Vertical scrollbar at slashdot.org is randomly not shown
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
code here to exactly match the way it was before it was moved from WebCore. I had
introduced a storage leak and that was causing problems with scroll bars!
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- remove WebCoreFrameBridge reapplyStyles method
* WebView/WebHTMLView.mm:
(-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- eliminate WebCoreFrameBridge createFrameViewWithNSView
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage):
Moved code here from createFrameViewWithNSView.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- removed WebCoreFrameBridge scrollOverflowInDirection
* WebView/WebFrameView.mm:
(-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
EventHandler directly instead of using the bridge.
(-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
of the ones from the bridge.
(-[WebFrameView scrollToEndOfDocument:]): Ditto.
(-[WebFrameView _pageVertically:]): Ditto.
(-[WebFrameView _pageHorizontally:]): Ditto.
(-[WebFrameView _scrollLineVertically:]): Ditto.
(-[WebFrameView _scrollLineHorizontally:]): Ditto.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- remove WebCoreFrameBridge installInFrame: method
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage): Call
-[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
* WebView/WebFrameView.mm:
(-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
(-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
method isn't nested inside an if statement. Call
-[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
* WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
used in WebFrameLoaderClient.mm.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- remove WebCoreFrameBridge window method
* WebCoreSupport/WebFrameBridge.mm: Removed window method.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- move code from WebFrameBridge into WebFrameLoaderClient
* WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
Changed to use WebCore::String.
(-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
and added a FIXME.
(WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
(WebFrameLoaderClient::objectContentType): Ditto.
(parameterValue): Added. Helper function, based on code originally in WebFrameBridge.
(pluginView): Ditto.
(WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- remove -[WebCoreFrameBridge dashboardRegionsChanged:]
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
The WebCore side now calls this only when there's an actual change.
* WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
2008-03-04 Darin Adler <darin@apple.com>
Reviewed by Adam.
- remove WebCoreFrameBridge issuePasteComand method
* WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
* WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
2008-03-03 Darin Adler <darin@apple.com>
Reviewed by Adam.
- some "cleanup" on the path to removing WebCoreFrameBridge
* Storage/WebDatabaseManager.mm: Tweak includes.
* Storage/WebDatabaseTrackerClient.mm: Ditto.
* Storage/WebSecurityOrigin.mm: Ditto.
* Storage/WebSecurityOriginInternal.h: Ditto.
* WebView/WebFrame.mm:
(core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
match WebCore::EditableLinkBehavior.
* WebView/WebFrameInternal.h: Removed unused kit function.
* WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
* WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
* WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
* WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
2008-03-01 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Update Xcode configuration to support building debug and release from the mysterious future.
* Configurations/DebugRelease.xcconfig:
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Anders Carlsson.
Replace use of WKPathFromFont with implementation in terms of public API.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Remove unused symbol.
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
* Misc/WebNSURLExtras.mm:
(-[NSURL _webkit_canonicalize]):
* WebKit.order:
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
* Misc/WebNSViewExtras.m: Remove _web_superviewOfClass:stoppingAtClass:.
* Misc/WebNSWindowExtras.m: Remove _webkit_displayThrottledWindows.
* Misc/WebSearchableTextView.m: Remove selectionImageForcingWhiteText:.
* WebCoreSupport/WebImageRendererFactory.m: Update comment to mention the last version of Safari that
requires this class.
* WebInspector/WebInspector.mm: Remove sharedWebInspector and update comments to mention the last version
of Safari that calls other obsolete methods.
* WebView/WebDocumentPrivate.h: Remove selectionImageForcingWhiteText:.
* WebView/WebHTMLView.mm: Ditto.
* WebView/WebPDFView.mm: Ditto.
* WebView/WebView.mm: Update comment to mentoin the last version of Safari that requires the obsolete method.
2008-02-29 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Eric Seidel.
Remove unneeded includes of WebKitSystemInterface.h.
* History/WebHistoryItem.mm:
* Misc/WebNSViewExtras.m:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebDataSource.mm:
* WebView/WebPDFView.mm:
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt and Oliver Hunt.
<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Remove unused symbol.
* WebKit.order: Ditto.
2008-02-28 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Hyatt.
Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
2008-02-27 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe (code) and Darin (concept)
Much better fix for <rdar://problem/4930688> (see r19549)
Original fix for <rdar://problem/3947312> (and 14 dupes)
Let me tell you a story:
A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
WebArchive code was intertwined with that code in bizarre and complex ways.
During the months long loader re-factoring where we pushed much loader code down into WebCore,
many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
with a sole purpose.
One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
single entry point for almost all loading (network or web archives)
This method would check various headers and other fields on the NSURLRequest and NSURLResponse
to make decisions about the load. If the cache control fields were expired or other conditions
in the headers were met, the load would be forced to go out to the network.
As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
At some point, all that remained was the special cases for loading WebArchives.
Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
to be WebArchive specific, further cementing the assumed design.
Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
specific point in time. Referring to the request to see if the resource should be reloaded seems
nonsensical, as does referring to the response headers to see if the resource is "expired". In the
context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
during the initial load!
After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
inspect the request or response objects - We are loading from a WebArchive, and we should never
make the decision to go out to the network when we actually have the resource available.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit
2008-02-27 Matt Lilek <webkit@mattlilek.com>
Reviewed by Adam Roben.
Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Remove duplicate preference setting.
(-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2008-02-25 Darin Adler <darin@apple.com>
Reviewed by Adam.
* WebView/WebArchiver.mm:
(+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
* WebView/WebFrame.mm:
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
variable name URL to avoid clashing with the renamed KURL in the future. Also use
blankURL.
(-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
(-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
(-[WebFrame loadHTMLString:baseURL:]): Ditto.
(-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
2008-02-24 Darin Adler <darin@apple.com>
Reviewed by Sam.
- remove separate client calls for "standard" and "reload' history
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory):
2008-02-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
Move basic threading support from WebCore to WTF.
* ForwardingHeaders/wtf/Threading.h: Added.
* ForwardingHeaders/wtf/Locker.h: Added.
2008-02-23 David Kilzer <ddkilzer@apple.com>
Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>
Reviewed by Darin.
* Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
and added Apple BSD-style license.
* Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2008-02-22 John Sullivan <sullivan@apple.com>
Reviewed by Adam Roben
Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
pasteAsPlainText: has the same behavior.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
(-[WebHTMLView readSelectionFromPasteboard:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(-[WebHTMLView pasteAsRichText:]):
(-[WebHTMLView paste:]):
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
2008-02-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Use BackForwardList::create instead.
* History/WebBackForwardList.mm:
(-[WebBackForwardList init]):
2008-02-21 John Sullivan <sullivan@apple.com>
Reviewed by Jessica Kahn
support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
(-[WebHTMLView readSelectionFromPasteboard:]):
pass NO for new matchStyle parameter to match old behavior
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
validate pasteAndMatchStyle the same way as pasteAsRichText
(-[WebHTMLView pasteAndMatchStyle:]):
just like pasteAsRichText but passes YES for matchStyle
(-[WebHTMLView pasteAsRichText:]):
pass NO for new matchStyle parameter to match old behavior
(-[WebHTMLView paste:]):
ditto
* WebView/WebView.mm:
added macro(pasteAndMatchStyle)
* WebView/WebViewPrivate.h:
added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
2008-02-20 Sam Weinig <sam@webkit.org>
Reviewed by Darin and Geoff.
- WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
There are currently no site-specific quirks on Mac, but we will propagate the state
to WebCore to avoid possible mistakes later.
2008-02-19 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Move back WebKit methods that were unused in WebCore.
* Misc/WebNSURLExtras.mm:
(+[NSURL _web_URLWithData:]):
(+[NSURL _web_URLWithData:relativeToURL:]):
(-[NSURL _web_originalData]):
(-[NSURL _web_originalDataAsString]):
(-[NSURL _web_isEmpty]):
(-[NSURL _webkit_canonicalize]):
(-[NSURL _webkit_URLByRemovingComponent:]):
(-[NSURL _webkit_URLByRemovingFragment]):
(-[NSURL _webkit_URLByRemovingResourceSpecifier]):
(-[NSURL _webkit_isFileURL]):
(-[NSString _webkit_isFileURL]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle):
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
2008-02-18 Darin Adler <darin@apple.com>
Reviewed by Sam.
* Misc/WebNSAttributedStringExtras.mm:
(+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
DeprecatedString.
2008-02-17 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
* MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
mistakenly not migrated.
2008-02-15 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
<rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
* WebView/WebDataSource.mm:
(+[WebDataSource _representationClassForMIMEType:]):
(-[WebDataSource _responseMIMEType]):
(-[WebDataSource subresources]):
(-[WebDataSource subresourceForURL:]):
* WebView/WebResource.mm:
(-[WebResource _initWithData:URL:response:]):
* WebView/WebResourcePrivate.h:
2008-02-15 Adam Roben <aroben@apple.com>
Make WebKit's FEATURE_DEFINES match WebCore's
Reviewed by Mark.
* Configurations/WebKit.xcconfig:
2008-02-14 Darin Adler <darin@apple.com>
Reviewed by Eric Seidel.
- updated for WebCore KURL changes
* History/WebHistoryItem.mm:
(-[WebHistoryItem URL]): Removed getNSURL call.
* Misc/WebElementDictionary.mm:
(-[WebElementDictionary _absoluteImageURL]): Ditto.
(-[WebElementDictionary _absoluteLinkURL]): Ditto.
* Misc/WebNSAttributedStringExtras.mm:
(fileWrapperForElement): Ditto.
(+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
* Misc/WebNSURLExtras.mm:
(-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
for function name change.
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::downloadURL): Removed getNSURL call.
* WebCoreSupport/WebDragClient.mm:
(WebDragClient::createDragImageForLink): Ditto.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
(WebFrameLoaderClient::startDownload): Ditto.
(WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
(WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
(WebFrameLoaderClient::cancelledError): Ditto.
(WebFrameLoaderClient::blockedError): Ditto.
(WebFrameLoaderClient::cannotShowURLError): Ditto.
(WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
(WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
(WebFrameLoaderClient::fileDoesNotExistError): Ditto.
(WebFrameLoaderClient::willUseArchive): Ditto.
(WebFrameLoaderClient::setTitle): Ditto.
(WebFrameLoaderClient::actionDictionary): Ditto.
(WebFrameLoaderClient::createFrame): Ditto.
(WebFrameLoaderClient::objectContentType): Ditto.
(WebFrameLoaderClient::createPlugin): Ditto.
(WebFrameLoaderClient::createJavaAppletWidget): Ditto.
* WebView/WebDataSource.mm:
(-[WebDataSource _URL]): Ditto.
(-[WebDataSource _initWithDocumentLoader:]): Ditto.
(-[WebDataSource unreachableURL]): Ditto.
* WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2008-02-14 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff.
Update order files.
* WebKit.order:
2008-02-14 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=17207
Database example doesn't work (requires not-yet-released Safari)
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
if it's too old.
2008-02-11 Darin Adler <darin@apple.com>
- roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
incorrectly due to visibility fix
Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
* Misc/WebKitVersionChecks.h: Removed the constant.
* WebView/WebView.mm:
(-[WebView _needsXcodeVisibilityQuirk]): Removed.
(-[WebView _preferencesChangedNotification:]): Removed call to
setNeedsXcodeVisibilityQuirk.
2008-02-12 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
* WebCoreSupport/WebFrameBridge.mm:
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory imageTitleForFilename:size:]):
Move implementation from WebFrameBridge to WebViewFactory.
2008-02-11 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
incorrectly due to visibility fix
Added an Xcode-specific quirk.
* Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
part of the check.
* WebView/WebView.mm:
(-[WebView _needsXcodeVisibilityQuirk]): Added.
(-[WebView _preferencesChangedNotification:]): Added a call to
setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
2008-02-10 Darin Adler <darin@apple.com>
- fix http://bugs.webkit.org/show_bug.cgi?id=17274
REGRESSION: User Agent string broken in r30119
* WebView/WebView.mm:
(-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
Fix wrong variable name. Doh!
2008-02-09 Darin Adler <darin@apple.com>
Reviewed by Tim Hatcher.
- fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
* WebView/WebView.mm:
(-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
garbage collector's Objective C++ support by not initializing a static to an object
that needs to be marked when running under GC.
2008-02-05 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
The key bindings are Command-Control-left arrow and
Command-Control-right arrow. To match AppKit, the bindings are enabled
only when certain user defaults are set.
* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
Frame::baseWritingDirectionForSelectionStart() and
Editor::setBaseWritingDirection() directly.
(-[WebHTMLView changeBaseWritingDirection:]): Ditto.
(writingDirectionKeyBindingsEnabled): Added.
(-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
method.
(-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
(-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
* WebView/WebView.mm:
2008-02-05 Mark Rowe <mrowe@apple.com>
Unreviewed build fix.
* WebView/WebView.mm: Add missing #import.
2008-02-05 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Update versioning to support the mysterious future.
* Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
2008-01-30 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
* WebView/WebHTMLView.mm:
(-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
this back, it's used by Mail.
(-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
also used by Mail. Moved to WebPrivate.
* WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
accidently remove them in the future.
2008-01-30 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Move off deprecated NSTableView methods.
* WebView/WebHTMLView.mm:
(-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
(-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
(-[WebTextCompleteController filterKeyDown:]): Ditto.
2008-01-26 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
* Misc/WebNSDataExtras.m:
(-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
to the new CFString so that they will be freed when no longer needed.
2008-01-26 Greg Bolsinga <bolsinga@apple.com>
<rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
Reviewed by Darin.
* WebCoreSupport/WebDashboardRegion.h: Removed.
* WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
2008-01-21 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
- fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
- add a missing export of WebDatabaseExpectedSizeKey
- implement deleteOrigin: and remove deleteDatabasesWithOrigin:
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
name instead of calling isValid().
(-[WebDatabaseManager deleteOrigin:]): Implemented.
(WebKitInitializeDatabasesIfNecessary): Updated for name change.
* Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
* WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
we had before with a single one.
* WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
* WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
* WebView/WebPreferences.m:
(+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
* WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
setDefaultDatabaseQuota:.
* WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
methods we had before with a single one.
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Removed the code to set the
default database origin quota in WebCore::Settings based on WebPreferences.
* WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
types of parameters that the database UI delegate methods had before.
2008-01-20 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
interested in supporting Safari 2 with TOT WebKit.
* WebView/WebView.mm:
(+[WebView initialize]):
2008-01-17 Timothy Hatcher <timothy@apple.com>
Reviewed by Adam Roben.
<rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
and inactive text selection after loading a page
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
The problem was other frames were changing the FocusController's active
status to false after the first responder frame set it to true. The last
frame to call _updateActiveState would win.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
if the first responder is the current WebHTMLView or the WebFrameView.
(-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
2008-01-18 Adam Roben <aroben@apple.com>
Rename _updateActiveState to _updateFocusedAndActiveState
Also renamed any related methods/members similarly.
Reviewed by Adele.
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
(-[WebHTMLView close]):
(_updateFocusedAndActiveStateTimerCallback):
(-[WebHTMLView viewWillMoveToWindow:]):
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView windowDidBecomeKey:]):
(-[WebHTMLView windowDidResignKey:]):
(-[WebHTMLView becomeFirstResponder]):
(-[WebHTMLView resignFirstResponder]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebHTMLViewPrivate.h:
2008-01-17 John Sullivan <sullivan@apple.com>
Reviewed by Darin
- fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
* WebView/WebFrameView.mm:
(-[WebFrameView initWithCoder:]):
override to bump the global WebFrameView count
2008-01-16 Adam Roben <aroben@apple.com>
Updated for renames/removal of WebCore methods.
Reviewed by Darin.
* Plugins/WebPluginController.mm:
(-[WebPluginController webPlugInContainerSelectionColor]): Changed to
ask isFocusedAndActive directly, instead of going through the frame
bridge.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateActiveState]): Updated for method renames.
2008-01-16 John Sullivan <sullivan@apple.com>
Reviewed by Adam and Dan
- cleaned up some existing logging
* WebView/WebHTMLView.mm:
(-[WebHTMLView setNeedsDisplay:]):
add method name to log, use "YES" and "NO" instead of (int)flag
(-[WebHTMLView setNeedsLayout:]):
ditto
(-[WebHTMLView setNeedsToApplyStyles:]):
ditto
2008-01-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Andre Boule.
Fixed <rdar://problem/5667627> [WebCache empty] implementation should
not disable/enable the cache
Toggle the cache model instead -- toggling disable/enable just causes
the cache to forget about resources, not reclaim their memory.
* Misc/WebCache.mm:
(+[WebCache empty]):
* WebView/WebView.mm:
* WebView/WebViewInternal.h:
2008-01-15 Adele Peterson <adele@apple.com>
Reviewed by Adam and Antti.
WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack.
2008-01-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by John Sullivan.
Fixed some world leak reports:
* <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
Interpreter after running cvs-base suite
* <rdar://problem/5669423> PLT complains about world leak if browser
window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
* Misc/WebCoreStatistics.h: Did a little renaming, to match
JavaScriptCore better. I kept the methods with the old names around,
though, because old versions of Safari need them.
* Misc/WebCoreStatistics.mm: Removed dependence on
WebCore::JavaScriptStatistics, which is gone now.
These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2008-01-10 Maciej Stachowiak <mjs@apple.com>
Not reviewed. Build fix.
- Attempt to fix mac build.
* Storage/WebDatabaseManager.mm:
2008-01-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager origins]):
(-[WebDatabaseManager databasesWithOrigin:]):
(-[WebDatabaseManager detailsForDatabase:withOrigin:]):
(-[WebDatabaseManager deleteDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebDatabaseTrackerClient.h:
* Storage/WebDatabaseTrackerClient.mm:
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):
(-[WebSecurityOrigin isEqual:]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin finalize]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOrigin _core]):
* Storage/WebSecurityOriginInternal.h:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForNewDatabase):
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
2008-01-10 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
to ensure the shouldAllowNavigation check is made.
2008-01-07 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Mark.
Enable SVG_FONTS by default.
* Configurations/WebKit.xcconfig:
2008-01-07 Adele Peterson <adele@apple.com>
Reviewed by Antti, Adam, and Mitz.
WebKit part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
2008-01-07 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
* Misc/WebNSAttributedStringExtras.mm:
2008-01-03 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
<rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
* WebView/WebView.mm:
(-[WebView _executeCoreCommandByName:value:]):
* WebView/WebViewPrivate.h:
Added an SPI to implement layoutTestController.execCommand.
2008-01-03 Kevin Decker <kdecker@apple.com>
Reviewed by Darin.
Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
* Misc/WebNSFileManagerExtras.h:
* Misc/WebNSFileManagerExtras.m:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set
"Where from:" metadata information.
* WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
2008-01-03 Alice Liu <alice.liu@apple.com>
Reviewed by Darin.
This fixes pageup/down in iframes. test for this is fast/frames/iframe-scroll-page-up-down.html
* WebView/WebHTMLView.mm:
(-[WebHTMLView doCommandBySelector:]):
Have the editor handle all the commands it supports instead of just text commands.
If not handled by the editor, the webview will handle the command.
2008-01-02 Kevin Decker <kdecker@apple.com>
Reviewed by Darin.
Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched
to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
2008-01-01 David D. Kilzer <ddkilzer@webkit.org>
Reviewed by Dan.
- fix http://bugs.webkit.org/show_bug.cgi?id=16700
Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
* DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of
-[NSFileManager fileExistsAtPath:isDirectory:] before using the value
of isDirectory.
2007-12-29 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Add DOMSVGFontElement/DOMSVGGlyphElement/DOMSVGMissingGlyphElement to MigrateHeaders.make
* MigrateHeaders.make:
2007-12-25 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
- fix an assertion failure when pressing the num lock key
* WebView/WebHTMLView.mm:
(-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to
WebCore.
2007-12-20 Darin Adler <darin@apple.com>
Reviewed by Oliver.
- fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
* WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of
selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:,
deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:,
moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:,
selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:,
and transpose:.
2007-12-20 Kevin Decker <kdecker@apple.com>
Reviewed by Anders.
Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop
writing to the window backing store. The problem was that change-set 28400 introduced an early return
which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL
plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
2007-12-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Build fix.
* ForwardingHeaders/kjs/SymbolTable.h: Added.
* ForwardingHeaders/wtf/VectorTraits.h: Added.
2007-12-16 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej Stachowiak.
Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebNetscapePluginStream.h:
* Plugins/WebNetscapePluginStream.mm:
(-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
(-[WebNetscapePluginStream dealloc]):
(-[WebNetscapePluginStream finalize]):
* Plugins/WebPlugInStreamLoaderDelegate.h: Moved from WebCore.
* WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Added.
(WebNetscapePlugInStreamLoaderClient::WebNetscapePlugInStreamLoaderClient):
* WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Added.
(WebNetscapePlugInStreamLoaderClient::didReceiveResponse): Call through to the equivalent WebPlugInStreamLoaderDelegate method.
(WebNetscapePlugInStreamLoaderClient::didReceiveData): Ditto.
(WebNetscapePlugInStreamLoaderClient::didFail): Ditto.
(WebNetscapePlugInStreamLoaderClient::didFinishLoading): Ditto.
2007-12-16 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14140
<rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
* WebView/WebHTMLView.mm:
(-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
when handling keypress, too.
(-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
(-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
restore the state for additional commands to be saved correctly.
2007-12-14 David D. Kilzer <ddkilzer@apple.com>
<rdar://problem/5647272> Remove user agent string hack for flickr.com
Reviewed by Darin.
* WebView/WebView.mm:
(-[WebView _userAgentForURL:]): Removed hack.
2007-12-14 David D. Kilzer <ddkilzer@apple.com>
<rdar://problem/5647261> Remove user agent string hack for yahoo.com
Reviewed by Darin.
* WebView/WebView.mm:
(-[WebView _userAgentForURL:]): Removed hack.
2007-12-14 Darin Adler <darin@apple.com>
Reviewed by Brady.
- fix http://bugs.webkit.org/show_bug.cgi?id=16296
<rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
* WebView/WebView.mm:
(-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
a didReceiveIcon method is present.
2007-12-14 Darin Adler <darin@apple.com>
Reviewed by Alexey.
- Changed a few more editing operations to use WebCore instead of WebKit.
- Removed some obsolete unused code.
* WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
defined and used on the WebKit side to here. These no longer belong on the bridge
and should be moved to the WebFrame class (or elsewhere).
* WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
* WebView/WebFrameView.mm:
(+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
(-[WebHTMLViewPrivate clear]): Ditto.
(-[WebHTMLView _setMouseDownEvent:]): Ditto.
(commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
disambiguated with the word "Move"). Added deleteBackward:,
deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
forwarded to WebCore.
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
operations that we forward to WebCore. Instead, look up any command that WebCore can
handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
(-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
(-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
(-[WebHTMLView resignFirstResponder]): Ditto.
(-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
* WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
_willMakeFirstResponderForNodeFocus.
2007-12-13 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
* Misc/WebKitVersionChecks.h:
* WebView/WebView.mm:
(-[WebView _needsKeyboardEventHandlingQuirks]):
(-[WebView _preferencesChangedNotification:]):
2007-12-12 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
* WebCoreSupport/WebCachedPagePlatformData.h: Added.
(WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
(WebCachedPagePlatformData::clear):
(WebCachedPagePlatformData::webDocumentView):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::savePlatformDataToCachedPage):
(WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here,
because that is now done in WebCore.
(WebFrameLoaderClient::transitionToCommittedForNewPage):
2007-12-12 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Kilzer.
Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
* Configurations/WebKit.xcconfig:
2007-12-11 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Scrub URL out of the tree in preparation for renaming KURL to URL.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary):
* WebView/WebDataSource.mm:
(-[WebDataSource _URL]):
* WebView/WebView.mm:
(-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2007-12-11 Darin Adler <darin@apple.com>
Reviewed by Geoff.
- change more editing commands to use WebCore::Editor
- change to use the new WebCore::Editor::command() function
* WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
to use the "forward to WebCore" macro instead of having hand-written implementations.
(kit): Added function to change a TriState to an AppKit-style tri-state value.
(-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
first character or copies the selector name, since the Editor commands are not case
sensitive any more. Returns a command object.
(-[WebHTMLView coreCommandByName:]): Added.
(-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
and changed to use the new coreCommandBySelector: method.
(-[WebHTMLView executeCoreCommandByName:]): Added.
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
methods that call through to WebCore to also use the state() and isEnabled()
functions on the commands for the menu item state and user interface item enabling.
(-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
name rather than having local methods for them; no need for methods with a single
call site.
(-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
than the deprecated execCommand().
(-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
than the deprecated execCommand().
* WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
2007-12-07 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
<rdar://problem/5535636>
Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
http://bugs.webkit.org/show_bug.cgi?id=13916
JavaScript detects Tab as a character input on a textfield validation
* WebCoreSupport/WebEditorClient.h:
Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
Renamed handleInputMethodKeypress() to handleInputMethodKeydown().
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleKeyboardEvent): This change makes sense only remotely, but it helped
to get tests working. I guess Mac keyboard event handling needs further refactoring.
* WebView/WebHTMLView.mm:
(selectorToCommandName): Convert AppKit editing selector name to Editor command name - extracted
from callWebCoreCommand:.
(_interceptEditingKeyEvent:shouldSaveCommand:): Insert text from keypress.
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
Convert incoming platform KeyDown into RawKeyDown, as this is what the view is interested in.
2007-12-10 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan
Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
This is because a common UI case is to want to know the originating URL of a Database
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForNewDatabase):
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
* WebView/WebUIDelegatePrivate.h:
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
(CallUIDelegateReturningUnsignedLongLong):
* WebView/WebViewInternal.h:
2007-12-10 Timothy Hatcher <timothy@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
* Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
2007-12-10 Kevin Decker <kdecker@apple.com>
Reviewed by Darin.
Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
* WebView/WebHTMLView.mm:
(-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
2007-12-08 Oliver Hunt <oliver@apple.com>
Reviewed by Sam W.
Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
Fixes <rdar://problem/5620249> Must disable SVG animation
<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
Minor updates to the feature flags used.
* Configurations/WebKit.xcconfig:
* DOM/WebDOMOperations.mm:
2007-12-07 Darin Adler <darin@apple.com>
Reviewed by Kevin Decker and Tim Hatcher.
- speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
* WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
(-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
window goes away, and the view is never removed from the window.
(-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
2007-12-07 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15981
speed up visited-link code a bit
* History/WebHistory.mm: Removed unused Latin-1 code path.
(-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
2007-12-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a forwarding header, since we now #include nodes.h through some
JavaScriptCore headers.
* ForwardingHeaders/wtf/ListRefPtr.h: Added.
2007-12-06 Brady Eidson <beidson@apple.com>
Reviewed by Oliver's rubber stamp
Let's go ahead and call the correct UI Delegate method, shall we?
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
2007-12-06 Adam Roben <aroben@apple.com>
Remove some assertions we know can fire and replace them with a FIXME
Reviewed by Anders.
* WebCoreSupport/WebFrameLoaderClient.mm:
2007-12-06 Timothy Hatcher <timothy@apple.com>
Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
Only assert if the major version is zero, since zero is handled in the other cases.
* WebView/WebView.mm:
(callGestalt): Remove the ASSERT.
(createMacOSXVersionString): ASSERT that major is not zero.
2007-12-06 Darin Adler <darin@apple.com>
Reviewed by Tim Hatcher.
- fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
* WebView/WebView.mm:
(callGestalt): Added.
(createMacOSXVersionString): Added.
(-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
"4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
(-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
2007-12-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
2007-12-04 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin.
- <rdar://5621435>
- Security Fix. Instead of having it off by default, WebKit now must
explicitly turn off local-resource restriction when needed for backwards
coimpatibility reasons.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
2007-12-05 Brady Eidson <beidson@apple.com>
Reviewed by Kevin Deckers rubberstamp
Disclose and export the Databases Directory defaults key
* Storage/WebDatabaseManager.mm:
* Storage/WebDatabaseManagerPrivate.h:
* WebKit.exp:
2007-12-04 Kevin Decker <kdecker@apple.com>
Reviewed by Anders.
<rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory pluginNameForMIMEType:]): Added.
2007-12-04 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Tweaked the way we typedef and cast these objc_msgSend calls
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
2007-12-04 John Sullivan <sullivan@apple.com>
Reviewed by Brady Eidson (with help from Mark Rowe)
Fixed return values for unsigned-long-long delegate methods
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
redid the change that Brady did at home over the weekend but forgot to check in
2007-11-27 Adam Roben <aroben@apple.com>
Remove -[WebFrameBridge setNeedsReapplyStyles]
This functionality is now WebCore's responsibility.
Reviewed by Hyatt.
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.order:
2007-12-04 John Sullivan <sullivan@apple.com>
Reviewed by Darin
Added deleteOrigin: SPI, which isn't fully implemented
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager deleteOrigin:]):
just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
2007-12-04 Timothy Hatcher <timothy@apple.com>
Reviewed by Mark Rowe.
Remove a check for early versions of Leopard CFNetwork now that
Leopard has shipped.
* Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
* WebView/WebView.mm:
(+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
2007-12-04 Kevin Decker <kdecker@apple.com>
Reviewed by Darin.
Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
This fix is exactly the same as chageset 28359 with the exception of an added early return in
updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
regardless of whether or not it actually needs to draw.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
down an ASSERT that was too strict.
(-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
function. Also tweaked a comment and added an early return if the plug-in can't draw.
2007-12-04 Darin Adler <darin@apple.com>
Reviewed by Kevin Decker.
* WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
* WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
* WebKit.order: Ditto.
2007-12-03 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
* WebView/WebHTMLView.mm:
(-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
that checked if the view had resized and sent the resize event, since
FrameView sends resize events now.
* WebView/WebHTMLViewInternal.h:
2007-12-03 Timothy Hatcher <timothy@apple.com>
Reviewed by Darin.
Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
to return a pointer to the implementation struct instead of a copy of the struct. This changes
all of the callers to dereference the pointer to access the struct fields.
* Plugins/WebNullPluginView.mm:
(-[WebNullPluginView reportFailure]):
* WebCoreSupport/WebFrameBridge.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebFrameLoaderClient::assignIdentifierToInitialRequest):
(WebFrameLoaderClient::dispatchWillSendRequest):
(WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
(WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebFrameLoaderClient::willCacheResponse):
(WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebFrameLoaderClient::dispatchDidFinishLoading):
(WebFrameLoaderClient::dispatchDidFailLoading):
(WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebFrameLoaderClient::dispatchWillClose):
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebFrameLoaderClient::dispatchDidFailLoad):
(WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebFrameLoaderClient::dispatchDidFinishLoad):
(WebFrameLoaderClient::dispatchDidFirstLayout):
* WebView/WebView.mm:
(WebViewGetResourceLoadDelegateImplementations):
(WebViewGetFrameLoadDelegateImplementations):
(-[WebView _dispatchDidReceiveIconFromWebFrame:]):
* WebView/WebViewInternal.h:
2007-12-03 Timothy Hatcher <timothy@apple.com>
Reviewed by Brady Eidson.
<rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
<rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
<rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
WebViewGetResourceLoadDelegateImplementations + 28
* WebView/WebView.mm:
(-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
(-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
(WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
if the WebView is nil. This fixes the crashes.
(WebViewGetFrameLoadDelegateImplementations): Ditto.
2007-12-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
* WebView/WebFrame.mm:
(-[WebFrame globalContext]): Use the toRef function instead of manually
casting.
2007-12-01 Brady Eidson <beidson@apple.com>
Reviewed by Tim
Added a default database quota of 5mb to the default WebPreferences
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
2007-11-30 John Sullivan <sullivan@apple.com>
Reviewed by Geoff Garen
Added another symbol for WebDatabaseManager clients
* WebKit.exp:
added .objc_class_name_WebSecurityOrigin
2007-11-30 Brady Eidson <beidson@apple.com>
Reviewed by Geoff
Add isEqual operator to WebSecurityOrigin
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin isEqual:]):
2007-11-30 John Sullivan <sullivan@apple.com>
Reviewed by Darin
Tweaks to newly-declared NSString * constants to make them usable from clients
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseManager.mm:
removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
* WebKit.exp:
export new NSNotification names and userInfo keys so clients can use them
2007-11-29 Anders Carlsson <andersca@apple.com>
Reviewed by John.
Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.
This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
is using the setter and not messing around with NSUserDefaults.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
(-[WebPreferences shrinksStandaloneImagesToFit]):
(-[WebPreferences setShrinksStandaloneImagesToFit:]):
2007-11-29 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Support for <rdar://problem/5556381> and <rdar://problem/5556379>
Hook up UI Delegate calls for the database engine feature and other small tweaks
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
(-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseTrackerClient.h:
* Storage/WebDatabaseTrackerClient.mm:
(WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto
* WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
(CallUIDelegateReturningUnsignedLongLong):
* WebView/WebViewInternal.h:
2007-11-28 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam.
- Added recursive runloop guards.
* DefaultDelegates/WebScriptDebugServer.m:
(-[WebScriptDebugServer suspendProcessIfPaused]):
2007-11-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix an assertion failure seen on the layout tests, and when closing the window after
visiting <http://www.coudal.com/losalamos/>.
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
descriptor even when the stream is being destroyed without the load completing. This
avoids leaking the path and file descriptor, and leaving the temporary file on disk.
2007-11-28 Adele Peterson <adele@apple.com>
Reviewed by Darin.
Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
WebHTMLView to prevent future problems in other methods as well.
* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(-[WebHTMLView keyDown:]):
(-[WebHTMLView keyUp:]):
(-[WebHTMLView flagsChanged:]):
(-[WebHTMLView _selectionStartFontAttributesAsRTF]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
(-[WebHTMLView checkSpelling:]):
(-[WebHTMLView showGuessPanel:]):
(-[WebHTMLView indent:]):
(-[WebHTMLView outdent:]):
(-[WebHTMLView paste:]):
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView insertText:]):
(-[WebHTMLView selectionTextRects]):
2007-11-28 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
* WebView/WebHTMLView.mm:
(-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
because addMouseMovedObserver returns early if the dataSource
is not nil. But if the dataSource is already set (which happens when
a WebHTMLView is being reused) then addMouseMovedObserver must not
be called again.
2007-11-27 Anders Carlsson <andersca@apple.com>
Reviewed by Brady.
* Storage/WebDatabaseManager.mm:
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseTrackerClient.mm:
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
* Storage/WebSecurityOriginInternal.h:
2007-11-27 Kevin Decker <kdecker@apple.com>
Reviewed by Darin, landed by Anders.
Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
database will compare bundle versions and always load the latest version.
* Plugins/WebBasePluginPackage.h:
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
but we think for now it's good enough for us.
* Plugins/WebPluginDatabase.m:
(considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
2007-11-26 Timothy Hatcher <timothy@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/5569233> Add the ability to disable author and user CSS styles
* WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
* WebView/WebPreferences.m:
(+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
(-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
(-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
* WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
2007-11-26 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Provide API for setting the default storage quota per database origin
* Misc/WebNSDictionaryExtras.h:
* Misc/WebNSDictionaryExtras.m:
(-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
(-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
(-[WebPreferences defaultDatabaseQuota]):
(-[WebPreferences setDefaultDatabaseQuota:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
2007-11-26 Darin Adler <darin@apple.com>
Reviewed by Adele.
- some middle-mouse-button-related fixes
These don't affect Safari since it maps the middle mouse button to the command key,
but that might not always be the case for future versions.
* WebView/WebHTMLView.mm:
(-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
(-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
(-[WebHTMLView otherMouseUp:]): Ditto, for up events.
* WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
2007-11-26 Anders Carlsson <andersca@apple.com>
Reviewed by Brady.
Get rid of the WebSecurityOriginPrivate object and store
the WebCore::SecurityOriginData pointer in the _private field of
the WebSecurityOrigin object instead.
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager databasesWithOrigin:]):
(-[WebDatabaseManager detailsForDatabase:withOrigin:]):
(-[WebDatabaseManager deleteDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin finalize]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
(-[WebSecurityOrigin _core]):
* Storage/WebSecurityOriginInternal.h:
2007-11-26 Timothy Hatcher <timothy@apple.com>
Reviewed by Adam Roben.
Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
http://bugs.webkit.org/show_bug.cgi?id=16137
Create the Web Inspector window with the textured style. Set the content border
thickness for the top of the window or the height of the toolbar. Also make the
window's bottom corners square, since a normal textured window normally has
rounded bottom corners.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]):
2007-11-24 Mark Rowe <mrowe@apple.com>
Tiger build fix.
* Plugins/WebBaseNetscapePluginStream.mm:
(CarbonPathFromPOSIXPath): Use WebCFAutorelease as this also works on Tiger.
2007-11-24 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
http://bugs.webkit.org/show_bug.cgi?id=13705
Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading. On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.
The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
(-[WebBaseNetscapePluginStream dealloc]):
(-[WebBaseNetscapePluginStream finalize]):
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
(-[WebBaseNetscapePluginStream _destroyStream]): Update to work with paths as NSStrings.
(-[WebBaseNetscapePluginStream _deliverDataToFile:]): Open the file if it is not already open, and write any data
to disk.
(-[WebBaseNetscapePluginStream finishedLoading]): If the stream is NP_ASFILE or NP_ASFILEONLY we need to ensure
that the file exists before _destroyStream passes it to the plugin. Simulating the arrival of an empty data block
ensure that the file will be created if it has not already.
(-[WebBaseNetscapePluginStream receivedData:]):
(CarbonPathFromPOSIXPath):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): Data is dealt with incrementally so there's no need to pass
it to finishedLoading.
(-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Ditto.
2007-11-23 Oliver Hunt <oliver@apple.com>
Reviewed by Mark Rowe.
Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves
* WebView/WebHTMLView.mm:
(-[WebHTMLView mouseDown:]):
2007-11-22 Dan Bernstein <mitz@apple.com>
Reviewed by Antti Koivisto.
- http://bugs.webkit.org/show_bug.cgi?id=15811
WebKit plug-ins can re-enter WebKit under attach()
<rdar://problem/5577978>
* Plugins/WebNullPluginView.mm:
(-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
above bug that added as part of fixing
<http://bugs.webkit.org/show_bug.cgi?id=15804>.
2007-11-21 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Fix WebKit to build without warnings under GCC 4.2.
* Configurations/Base.xcconfig:
2007-11-21 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Changes due to <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings
Update format strings to use format specifiers that match the argument types.
* Misc/WebGraphicsExtras.c:
(WebConvertBGRAToARGB):
2007-11-19 Brady Eidson <beidson@apple.com>
Reviewed by Maciej
Finished hooking up the WebKit API for database management.
Most of the API is actually implemented in WebCore and some of those methods might
only be stubs for now.
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
(-[WebDatabaseManager databasesWithOrigin:]): Ditto
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin usage]): Call through to WebCore
(-[WebSecurityOrigin quota]): Ditto
(-[WebSecurityOrigin setQuota:]): Ditto
(-[WebSecurityOrigin _core]): Get WebCore version of this object
* Storage/WebSecurityOriginInternal.h:
2007-11-17 Timothy Hatcher <timothy@apple.com>
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Implement the localizedStringsURL() client method to return the
localized URL of InspectorLocalizedStrings.js in WebCore.
* WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::localizedStringsURL): Added.
(WebInspectorClient::updateWindowTitle): Localized the window title.
(-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
(-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
2007-11-17 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15969
Eliminate Editor::deleteRange()
* WebView/WebHTMLView.mm:
(+[WebHTMLView initialize]):
(-[WebHTMLView yank:]):
(-[WebHTMLView yankAndSelect:]):
(-[WebHTMLView setMark:]):
(-[WebHTMLView deleteToMark:]):
(-[WebHTMLView selectToMark:]):
(-[WebHTMLView swapWithMark:]):
Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
2007-11-16 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Build WebCore as a sub-framework of WebKit in all configurations.
* Configurations/WebKit.xcconfig:
2007-11-16 John Sullivan <sullivan@apple.com>
Reviewed by Brady
* WebKit.exp:
Exported some new database-related symbols
2007-11-16 Brady Eidson <beidson@apple.com>
Reviewed by John
Database management API tweaks
Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?
* Misc/WebSecurityOrigin.mm: Removed.
* Misc/WebSecurityOriginInternal.h: Removed.
* Misc/WebSecurityOriginPrivate.h: Removed.
* Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebSecurityOrigin.mm: Added.
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOriginPrivate finalize]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
* Storage/WebSecurityOriginInternal.h: Added.
* Storage/WebSecurityOriginPrivate.h: Added.
2007-11-15 Brady Eidson <beidson@apple.com>
Reviewed by John
Stubbing out everything required for a WebKit API for databases
These interfaces seem to provide everything we need for UI and management at the browser level
* Misc/WebDatabaseManager.h: Removed.
* Misc/WebDatabaseManager.mm: Removed.
* Misc/WebDatabaseManagerPrivate.h: Removed.
* Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
(protocol, domain, and port)
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
* Misc/WebSecurityOriginInternal.h: Added.
* Misc/WebSecurityOriginPrivate.h: Added.
* Storage/WebDatabaseManager.mm: Added.
(+[WebDatabaseManager sharedWebDatabaseManager]):
(-[WebDatabaseManager origins]): Get a list of all origins currently tracked
(-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
(-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
(-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
(-[WebDatabaseManager deleteAllDatabases]):
(-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebDatabaseManagerPrivate.h: Added.
* Storage/WebDatabaseManagerInternal.h: Added.
(WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
* Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
* Storage/WebDatabaseTrackerClient.mm: Added.
(WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
(WebDatabaseTrackerClient::WebDatabaseTrackerClient):
(WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
Database-related things here
2007-11-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Anders Carlsson.
Renamed Shared to RefCounted.
* ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
* ForwardingHeaders/wtf/Shared.h: Removed.
* WebCoreSupport/WebContextMenuClient.h:
2007-11-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Moved Shared.h into wtf so it could be used in more places.
* ChangeLog:
* WebCoreSupport/WebContextMenuClient.h:
2007-11-13 John Sullivan <sullivan@apple.com>
Reviewed by Darin.
removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
removed use of PreferredType
2007-11-13 John Sullivan <sullivan@apple.com>
Reviewed by Dan Bernstein.
- fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in
form fields other than the one you're typing into
* WebCoreSupport/WebEditorClient.mm:
(selectorForKeyEvent):
correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
but didn't get updated here.
2007-11-12 Josh Aas <joshmoz@gmail.com>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=15946
add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView setVariable:value:]):
2007-11-12 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15954
Move DOM Selection operations out of SelectionController
* WebView/WebHTMLView.mm:
(-[WebHTMLView _expandSelectionToGranularity:]):
(-[WebHTMLView selectToMark:]):
(-[WebHTMLView swapWithMark:]):
* WebView/WebView.mm:
(-[WebView setSelectedDOMRange:affinity:]):
Adapted for SelectionController::setSelectedRange() now returning a bool.
2007-11-12 Oliver Hunt <oliver@apple.com>
Reviewed by Darin and Geoff.
<rdar://problem/5522011> The content of the password field of
Safari is displayed by reconversion.
Some input methods (notably Kotoeri) can incorrectly provide
access to the raw text of a password field. To work around
this we forcefully override the inputContext whenever a password
field is active.
* WebView/WebHTMLView.mm:
(-[WebHTMLView inputContext]):
2007-11-12 John Sullivan <sullivan@apple.com>
Reviewed by Tim Hatcher
- speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit:
-[WebPDFView(FileInternal) _updatePreferencesSoon] + 56
The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
by this class, but should be. (It is retained by WebHTMLView, e.g.).
* WebView/WebPDFView.mm:
(-[WebPDFView dealloc]):
release dataSource ivar
(-[WebPDFView setDataSource:]):
retain dataSource ivar
2007-11-09 Tristan O'Tierney <tristan@apple.com>
Reviewed by Timothy Hatcher.
This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
Pass up the new preferredType parameter as a string.
2007-11-09 Timothy Hatcher <timothy@apple.com>
Reviewed by John.
<rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
Extend the linked on or after check to every application when a script passed to
stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
was limited to VitalSource Bookshelf, but other developers are running into this.
* Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
* WebView/WebDocumentLoaderMac.mm:
(needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the
WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
* WebView/WebView.mm:
(-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use
WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
2007-11-08 Kevin McCullough <kmccullough@apple.com>
Build Fix.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::windowObjectCleared):
2007-11-07 Darin Adler <darin@apple.com>
Reviewed by Steve.
- removed some unused WebCore bridge methods
* WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of
using the bridge object.
2007-11-06 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Dave Kilzer.
Move Mac files from WebKit into WebKit/mac.
* Carbon: Copied from WebKit/Carbon.
* ChangeLog: Copied from WebKit/ChangeLog.
* ChangeLog-2002-12-03: Copied from WebKit/ChangeLog-2002-12-03.
* ChangeLog-2006-02-09: Copied from WebKit/ChangeLog-2006-02-09.
* ChangeLog-2007-10-14: Copied from WebKit/ChangeLog-2007-10-14.
* Configurations: Copied from WebKit/Configurations.
* DOM: Copied from WebKit/DOM.
* DefaultDelegates: Copied from WebKit/DefaultDelegates.
* ForwardingHeaders: Copied from WebKit/ForwardingHeaders.
* History: Copied from WebKit/History.
* Info.plist: Copied from WebKit/Info.plist.
* MigrateHeaders.make: Copied from WebKit/MigrateHeaders.make.
* Misc: Copied from WebKit/Misc.
* Panels: Copied from WebKit/Panels.
* Plugins: Copied from WebKit/Plugins.
* PublicHeaderChangesFromTiger.txt: Copied from WebKit/PublicHeaderChangesFromTiger.txt.
* Resources: Copied from WebKit/Resources.
* WebCoreSupport: Copied from WebKit/WebCoreSupport.
* WebInspector: Copied from WebKit/WebInspector.
* WebKit.exp: Copied from WebKit/WebKit.exp.
* WebKit.order: Copied from WebKit/WebKit.order.
* WebKitPrefix.h: Copied from WebKit/WebKitPrefix.h.
* WebView: Copied from WebKit/WebView.
* icu: Copied from WebKit/icu.
2007-11-06 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15847
Some editing cleanup
No change in functionality.
* WebView/WebHTMLView.mm:
(-[WebHTMLView deleteToEndOfLine:]):
(-[WebHTMLView deleteToEndOfParagraph:]):
WebCore had a duplicate of the same logic already. We are passing a boundary value to
a function that expects granularity, this may need to be straightened out in the future.
2007-11-05 John Sullivan <sullivan@apple.com>
* WebView/WebView.mm:
(-[WebView _searchWithSpotlightFromMenu:]):
Teeny style tweak to test svn access on other machine
2007-11-05 John Sullivan <sullivan@apple.com>
* WebView/WebView.mm:
(-[WebView computedStyleForElement:pseudoElement:]):
Teeny style tweak to test svn access
2007-11-02 Tristan O'Tierney <tristan@apple.com>
Reviewed by Darin Adler.
* DefaultDelegates/WebDefaultUIDelegate.m:
(-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]):
Forward the UI delegate to call webView:createWebViewWithRequest: if
this method doesn't exist.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchCreatePage):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView loadPluginRequest:]):
* WebView/WebView.mm:
(-[WebView _openNewWindowWithRequest:]):
Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome.
Removed createModalDialog to use new createWindow function.
* WebView/WebUIDelegatePrivate.h:
Added new webView:createWebViewWithRequest:windowFeatures: method.
2007-11-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15835
Small adaptations to new KJS::List class.
* ForwardingHeaders/kjs/value.h: Added.
2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
* WebKit.xcodeproj/project.pbxproj:
2007-11-02 Antti Koivisto <antti@apple.com>
Reviewed by Darin.
Add method to enable video composition.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
2007-11-02 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- fix problem I ran into while doing some testing on Mac for
<rdar://problem/5530185> WebKit does not show <object>
fallback content when both URL and MIME type is omitted
I don't know how to reproduce this failure in DumpRenderTree, so there is no
regression test.
* Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
the didSendError local variable. Instead we just set the error to nil once
we've sent it.
* Plugins/WebNullPluginView.mm:
(-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
the null plug-in image code is separate from the rest of the function and
so that the whole thing is not inside an if statement. Also don't hold a
reference to the DOM element if there is no error to report.
(-[WebNullPluginView reportFailure]): Added. Does the actual delegate
callback. Happens back at the top level of the run loop so it doesn't
fire deep inside layout. Also wrote this so that it is guaranteed not to
reenter and so that it can handle the case where the delegate destroys
the world (including this object). NOTE: This is not a real, general
solution to the problem of plug-ins that do work inside layout. We will need
a more general fix that works for other plug-ins, and we'll track that with
a separate bug report.
(-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
changed so it just does a performSelector:afterDelay:0.
2007-11-02 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=15780
Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
in the page coordinate system rather than the client area coordinate system.
2007-11-01 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
- fix an assertion failure when Command-Tabbing out of Safari
* WebView/WebHTMLView.mm:
(-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
WebCore.
2007-11-01 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
No need to match style when pasting plain text, since the fragment we build for plain text
won't have any style information on it.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
longer a need to know whether this function chosePlaintext.
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
(-[WebHTMLView _documentFragmentFromPasteboard:]):
2007-10-31 Timothy Hatcher <timothy@apple.com>
Reviewed by John Sullivan.
Move the developer extras preference to WebPreferences.
* WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
* WebView/WebPreferences.m:
(+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
(-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
(-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
* WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
* WebView/WebView.mm:
(+[WebView _developerExtrasEnabled]): Removed.
(-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
* WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
2007-10-30 David D. Kilzer <ddkilzer@webkit.org>
Generated files missing from WebCore's Xcode project file
<http://bugs.webkit.org/show_bug.cgi?id=15406>
Reviewed by Darin.
Added the following private header files to MigrateHeaders.make:
- DOMCSSStyleSheetPrivate.h
- DOMEventPrivate.h
- DOMHTMLCollectionPrivate.h
- DOMHTMLEmbedElementPrivate.h
- DOMHTMLIFrameElementPrivate.h
- DOMHTMLObjectElementPrivate.h
- DOMHTMLSelectElementPrivate.h
* MigrateHeaders.make:
2007-10-29 Antti Koivisto <antti@apple.com>
Reviewed by Maciej.
Some SPIs for media support.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
2007-10-29 Timothy Hatcher <timothy@apple.com>
Reviewed by John Sullivan.
Various semi-related changes:
- A WebView can now be asked for it's WebInspector. There is one
WebInspector per WebView.
- Refactor the WebInspector class and move obsolete methods to
a special category.
- Add new WebInspector methods to show, hide and show the
console/timeline panels.
- Add an isDisabled method to WebCache.
- Allow WebLocalizableStrings.h to be used in C files.
* Misc/WebCache.h: Add isDisabled.
* Misc/WebCache.mm:
(+[WebCache isDisabled]): New method.
* Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Call super if already visible
so the window will be ordered front.
(-[WebInspectorWindowController showWebInspector:]): Method used by menu items,
so they are enabled and work when the Inspector window is key.
(-[WebInspectorWindowController showErrorConsole:]): Ditto.
(-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
* WebInspector/WebInspector.h: Add and remove methods.
* WebInspector/WebInspector.mm:
(-[WebInspector webViewClosed]): Called when the WebView is closed/dealloced.
Clears the _webView pointer.
(-[WebInspector show:]): Calls thru to the Page's InspectorController.
(-[WebInspector showConsole:]): Ditto.
(-[WebInspector showTimeline:]): Ditto.
(-[WebInspector close:]): Ditto.
(-[WebInspector attach:]): Ditto.
(-[WebInspector detach:]): Ditto.
(+[WebInspector sharedWebInspector]): Moved to the obsolete category.
(+[WebInspector webInspector]): Ditto.
(-[WebInspector setWebFrame:]): Ditto.
(-[WebInspector window]): Ditto.
(-[WebInspector showWindow:]): Ditto.
* WebView/WebView.mm:
(-[WebViewPrivate dealloc]): Release the WebInspector.
(-[WebView _close]): Call webViewClosed on the WebInspector.
(-[WebView inspector]): Create a WebInspector if needed and return it.
* WebView/WebViewPrivate.h: Add the inspector method.
2007-10-30 Adele Peterson <adele@apple.com>
Reviewed by Darin.
WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
* WebView/WebHTMLView.mm:
(-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
(+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged.
(-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.
2007-10-27 Mark Ambachtsheer <mark.a@apple.com>
Reviewed by Darin.
Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
(0, 0) the clipping rectangle is not correct.
Added the origin to the window clip rectangle coordinates to account for plugins that
don't originate at (0,0); affects code for offscreen GWorlds only.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2007-10-26 Adele Peterson <adele@apple.com>
Reviewed by Oliver.
Adding WebKitSystemInterface support for the caps lock indicator
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
2007-10-25 David Hyatt <hyatt@apple.com>
Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
transforms.
Reviewed by aroben and mmitz
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
* WebKit.xcodeproj/project.pbxproj:
2007-10-25 John Sullivan <sullivan@apple.com>
Reviewed by Tim Hatcher
Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
always does, when available.
* WebView/WebPreferencesPrivate.h:
removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with
a comment that says that they can be removed when no longer needed. That time is now.
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
removed WebKitUsePDFPreviewViewPreferenceKey
(-[WebPreferences _usePDFPreviewView]):
removed
(-[WebPreferences _setUsePDFPreviewView:]):
removed
* WebView/WebPDFView.mm:
(-[WebPDFView initWithFrame:]):
don't check _usePDFPreviewView
* WebView/WebPreferenceKeysPrivate.h:
removed WebKitUsePDFPreviewViewPreferenceKey
2007-10-24 Timothy Hatcher <timothy@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
Use the WebKitSystemInterface that matches the system version.
* Configurations/DebugRelease.xcconfig:
* WebKit.xcodeproj/project.pbxproj:
2007-10-24 Brady Eidson <beidson@apple.com>
Reviewed by Anders
<rdar://problem/5554130> DatabaseTracker.o has a global initializer
* Misc/WebDatabaseManager.mm:
(WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
2007-10-23 Mark Rowe <mrowe@apple.com>
Build fix for Eric's build fix in r26916.
* MigrateHeaders.make:
2007-10-22 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
* MigrateHeaders.make: copy over font-face related DOM headers
2007-10-22 Andrew Wellington <proton@wiretapped.net>
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
* Configurations/WebKit.xcconfig:
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Added support for Chrome prompts required by the Storage API
Added support API for future managing of databases from the WebKit client
Added preference and initialization for the databases path
* Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and
remove the current available databases
* Misc/WebDatabaseManager.mm: Added.
(+[WebDatabaseManager origins]):
(+[WebDatabaseManager databasesWithOrigin:]):
(+[WebDatabaseManager deleteAllDatabases]):
(+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
(+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
(WebKitSetWebDatabasesPathIfNecessary): Setup the database path
* Misc/WebDatabaseManagerPrivate.h: Added.
* WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for
an origin exceeding its size limit
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runDatabaseSizeLimitPrompt):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebUIDelegate.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
* WebView/WebViewInternal.h:
2007-10-19 John Sullivan <sullivan@apple.com>
Reviewed by Tim Hatcher
- fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
* History/WebHistory.mm:
(-[WebHistoryPrivate removeAllItems]):
This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
to the other places where it's cleared.
2007-10-18 Dan Bernstein <mitz@apple.com>
Tiger build fix.
* WebView/WebDataSource.mm:
(-[WebDataSource _MIMETypeOfResponse:]):
2007-10-18 Dan Bernstein <mitz@apple.com>
Reviewed by Adam Roben.
- fix <rdar://problem/5313523>
REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
* WebView/WebDataSource.mm:
(-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
<rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse
with a MIMEType of application/octet-stream and a Content-Type header
starting with text/plain and returning text/plain as the MIME type in
that case.
(-[WebDataSource _responseMIMEType]): Added. Used to get the correct
response MIME type.
(-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
(-[WebDataSource _makeRepresentation]): Ditto.
(-[WebDataSource mainResource]): Ditto.
(-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
pass the MIME type explicitly.
(-[WebDataSource subresourceForURL:]): Ditto.
* WebView/WebDataSourcePrivate.h:
* WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
_responseMIMEType.
* WebView/WebResource.mm:
(-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
method to take a MIME type instead of extracting it from the response,
so that WebDataSource could pass the correct MIME type.
* WebView/WebResourcePrivate.h:
2007-10-17 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
- fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
* WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
It's safe to do that for functions that return integers or pointers, but not structures.
2007-10-16 David Kilzer <ddkilzer@apple.com>
Reviewed by Timothy.
<rdar://problem/5544354> Wrong delegate method called in
WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
2007-10-16 Darin Adler <darin@apple.com>
Reviewed by Adele.
- moved transpose command implementation into WebCore
* WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.
2007-10-16 Darin Adler <darin@apple.com>
Reviewed by Maciej and Geoff (and looked over by Eric).
- http://bugs.webkit.org/show_bug.cgi?id=15519
eliminate use of <ctype.h> for processing ASCII
* ForwardingHeaders/wtf/ASCIICType.h: Added.
* ForwardingHeaders/wtf/DisallowCType.h: Added.
* WebKitPrefix.h: Include DisallowCType.h.
* Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
* WebView/WebHTMLView.mm:
(-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper.
(-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes,
instead of using ispunct.
2007-10-16 John Sullivan <sullivan@apple.com>
Reviewed by Adam Roben
Cleaned up localizable strings
* English.lproj/Localizable.strings:
updated
* StringsNotToBeLocalized.txt:
updated
* WebKit.xcodeproj/project.pbxproj:
StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is
2007-10-15 Kevin Decker <kdecker@apple.com>
Reviewed by Darin Adler.
Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger
* WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in
too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk
that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will
load during first layout and not attach time. For this plug-in, loading at first layout is
expected and is consistent with Safari 2 behavior.
2007-10-15 John Sullivan <sullivan@apple.com>
Reviewed by Geoff Garen
Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit
I made the following changes:
- replaced NS_DURING with @try, and added opening brace if there wasn't one
- replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
- removed NS_ENDHANDLER, and added a closing brace if there wasn't one
- in a couple of places, fixed indentation therein
* Misc/WebIconDatabase.mm:
(objectFromPathForKey):
* WebView/WebHTMLView.mm:
(-[WebHTMLView drawSingleRect:]):
(-[WebHTMLView beginDocument]):
(-[WebHTMLView deleteToMark:]):
* WebView/WebView.mm:
(-[WebView initWithCoder:]):
== Rolled over to ChangeLog-2007-10-14 ==
|