1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491 8492 8493 8494 8495 8496 8497 8498 8499 8500 8501 8502 8503 8504 8505 8506 8507 8508 8509 8510 8511 8512 8513 8514 8515 8516 8517 8518 8519 8520 8521 8522 8523 8524 8525 8526 8527 8528 8529 8530 8531 8532 8533 8534 8535 8536 8537 8538 8539 8540 8541 8542 8543 8544 8545 8546 8547 8548 8549 8550 8551 8552 8553 8554 8555 8556 8557 8558 8559 8560 8561 8562 8563 8564 8565 8566 8567 8568 8569 8570 8571 8572 8573 8574 8575 8576 8577 8578 8579 8580 8581 8582 8583 8584 8585 8586 8587 8588 8589 8590 8591 8592 8593 8594 8595 8596 8597 8598 8599 8600 8601 8602 8603 8604 8605 8606 8607 8608 8609 8610 8611 8612 8613 8614 8615 8616 8617 8618 8619 8620 8621 8622 8623 8624 8625 8626 8627 8628 8629 8630 8631 8632 8633 8634 8635 8636 8637 8638 8639 8640 8641 8642 8643 8644 8645 8646 8647 8648 8649 8650 8651 8652 8653 8654 8655 8656 8657 8658 8659 8660 8661 8662 8663 8664 8665 8666 8667 8668 8669 8670 8671 8672 8673 8674 8675 8676 8677 8678 8679 8680 8681 8682 8683 8684 8685 8686 8687 8688 8689 8690 8691 8692 8693 8694 8695 8696 8697 8698 8699 8700 8701 8702 8703 8704 8705 8706 8707 8708 8709 8710 8711 8712 8713 8714 8715 8716 8717 8718 8719 8720 8721 8722 8723 8724 8725 8726 8727 8728 8729 8730 8731 8732 8733 8734 8735 8736 8737 8738 8739 8740 8741 8742 8743 8744 8745 8746 8747 8748 8749 8750 8751 8752 8753 8754 8755 8756 8757 8758 8759 8760 8761 8762 8763 8764 8765 8766 8767 8768 8769 8770 8771 8772 8773 8774 8775 8776 8777 8778 8779 8780 8781 8782 8783 8784 8785 8786 8787 8788 8789 8790 8791 8792 8793 8794 8795 8796 8797 8798 8799 8800 8801 8802 8803 8804 8805 8806 8807 8808 8809 8810 8811 8812 8813 8814 8815 8816 8817 8818 8819 8820 8821 8822 8823 8824 8825 8826 8827 8828 8829 8830 8831 8832 8833 8834 8835 8836 8837 8838 8839 8840 8841 8842 8843 8844 8845 8846 8847 8848 8849 8850 8851 8852 8853 8854 8855 8856 8857 8858 8859 8860 8861 8862 8863 8864 8865 8866 8867 8868 8869 8870 8871 8872 8873 8874 8875 8876 8877 8878 8879 8880 8881 8882 8883 8884 8885 8886 8887 8888 8889 8890 8891 8892 8893 8894 8895 8896 8897 8898 8899 8900 8901 8902 8903 8904 8905 8906 8907 8908 8909 8910 8911 8912 8913 8914 8915 8916 8917 8918 8919 8920 8921 8922 8923 8924 8925 8926 8927 8928 8929 8930 8931 8932 8933 8934 8935 8936 8937 8938 8939 8940 8941 8942 8943 8944 8945 8946 8947 8948 8949 8950 8951 8952 8953 8954 8955 8956 8957 8958 8959 8960 8961 8962 8963 8964 8965 8966 8967 8968 8969 8970 8971 8972 8973 8974 8975 8976 8977 8978 8979 8980 8981 8982 8983 8984 8985 8986 8987 8988 8989 8990 8991 8992 8993 8994 8995 8996 8997 8998 8999 9000 9001 9002 9003 9004 9005 9006 9007 9008 9009 9010 9011 9012 9013 9014 9015 9016 9017 9018 9019 9020 9021 9022 9023 9024 9025 9026 9027 9028 9029 9030 9031 9032 9033 9034 9035 9036 9037 9038 9039 9040 9041 9042 9043 9044 9045 9046 9047 9048 9049 9050 9051 9052 9053 9054 9055 9056 9057 9058 9059 9060 9061 9062 9063 9064 9065 9066 9067 9068 9069 9070 9071 9072 9073 9074 9075 9076 9077 9078 9079 9080 9081 9082 9083 9084 9085 9086 9087 9088 9089 9090 9091 9092 9093 9094 9095 9096 9097 9098 9099 9100 9101 9102 9103 9104 9105 9106 9107 9108 9109 9110 9111 9112 9113 9114 9115 9116 9117 9118 9119 9120 9121 9122 9123 9124 9125 9126 9127 9128 9129 9130 9131 9132 9133 9134 9135 9136 9137 9138 9139 9140 9141 9142 9143 9144 9145 9146 9147 9148 9149 9150 9151 9152 9153 9154 9155 9156 9157 9158 9159 9160 9161 9162 9163 9164 9165 9166 9167 9168 9169 9170 9171 9172 9173 9174 9175 9176 9177 9178 9179 9180 9181 9182 9183 9184 9185 9186 9187 9188 9189 9190 9191 9192 9193 9194 9195 9196 9197 9198 9199 9200 9201 9202 9203 9204 9205 9206 9207 9208 9209 9210 9211 9212 9213 9214 9215 9216 9217 9218 9219 9220 9221 9222 9223 9224 9225 9226 9227 9228 9229 9230 9231 9232 9233 9234 9235 9236 9237 9238 9239 9240 9241 9242 9243 9244 9245 9246 9247 9248 9249 9250 9251 9252 9253 9254 9255 9256 9257 9258 9259 9260 9261 9262 9263 9264 9265 9266 9267 9268 9269 9270 9271 9272 9273 9274 9275 9276 9277 9278 9279 9280 9281 9282 9283 9284 9285 9286 9287 9288 9289 9290 9291 9292 9293 9294 9295 9296 9297 9298 9299 9300 9301 9302 9303 9304 9305 9306 9307 9308 9309 9310 9311 9312 9313 9314 9315 9316 9317 9318 9319 9320 9321 9322 9323 9324 9325 9326 9327 9328 9329 9330 9331 9332 9333 9334 9335 9336 9337 9338 9339 9340 9341 9342 9343 9344 9345 9346 9347 9348 9349 9350 9351 9352 9353 9354 9355 9356 9357 9358 9359 9360 9361 9362 9363 9364 9365 9366 9367 9368 9369 9370 9371 9372 9373 9374 9375 9376 9377 9378 9379 9380 9381 9382 9383 9384 9385 9386 9387 9388 9389 9390 9391 9392 9393 9394 9395 9396 9397 9398 9399 9400 9401 9402 9403 9404 9405 9406 9407 9408 9409 9410 9411 9412 9413 9414 9415 9416 9417 9418 9419 9420 9421 9422 9423 9424 9425 9426 9427 9428 9429 9430 9431 9432 9433 9434 9435 9436 9437 9438 9439 9440 9441 9442 9443 9444 9445 9446 9447 9448 9449 9450 9451 9452 9453 9454 9455 9456 9457 9458 9459 9460 9461 9462 9463 9464 9465 9466 9467 9468 9469 9470 9471 9472 9473 9474 9475 9476 9477 9478 9479 9480 9481 9482 9483 9484 9485 9486 9487 9488 9489 9490 9491 9492 9493 9494 9495 9496 9497 9498 9499 9500 9501 9502 9503 9504 9505 9506 9507 9508 9509 9510 9511 9512 9513 9514 9515 9516 9517 9518 9519 9520 9521 9522 9523 9524 9525 9526 9527 9528 9529 9530 9531 9532 9533 9534 9535 9536 9537 9538 9539 9540 9541 9542 9543 9544 9545 9546 9547 9548 9549 9550 9551 9552 9553 9554 9555 9556 9557 9558 9559 9560 9561 9562 9563 9564 9565 9566 9567 9568 9569 9570 9571 9572 9573 9574 9575 9576 9577 9578 9579 9580 9581 9582 9583 9584 9585 9586 9587 9588 9589 9590 9591 9592 9593 9594 9595 9596 9597 9598 9599 9600 9601 9602 9603 9604 9605 9606 9607 9608 9609 9610 9611 9612 9613 9614 9615 9616 9617 9618 9619 9620 9621 9622 9623 9624 9625 9626 9627 9628 9629 9630 9631 9632 9633 9634 9635 9636 9637 9638 9639 9640 9641 9642 9643 9644 9645 9646 9647 9648 9649 9650 9651 9652 9653 9654 9655 9656 9657 9658 9659 9660 9661 9662 9663 9664 9665 9666 9667 9668 9669 9670 9671 9672 9673 9674 9675 9676 9677 9678 9679 9680 9681 9682 9683 9684 9685 9686 9687 9688 9689 9690 9691 9692 9693 9694 9695 9696 9697 9698 9699 9700 9701 9702 9703 9704 9705 9706 9707 9708 9709 9710 9711 9712 9713 9714 9715 9716 9717 9718 9719 9720 9721 9722 9723 9724 9725 9726 9727 9728 9729 9730 9731 9732 9733 9734 9735 9736 9737 9738 9739 9740 9741 9742 9743 9744 9745 9746 9747 9748 9749 9750 9751 9752 9753 9754 9755 9756 9757 9758 9759 9760 9761 9762 9763 9764 9765 9766 9767 9768 9769 9770 9771 9772 9773 9774 9775 9776 9777 9778 9779 9780 9781 9782 9783 9784 9785 9786 9787 9788 9789 9790 9791 9792 9793 9794 9795 9796 9797 9798 9799 9800 9801 9802 9803 9804 9805 9806 9807 9808 9809 9810 9811 9812 9813 9814 9815 9816 9817 9818 9819 9820 9821 9822 9823 9824 9825 9826 9827 9828 9829 9830 9831 9832 9833 9834 9835 9836 9837 9838 9839 9840 9841 9842 9843 9844 9845 9846 9847 9848 9849 9850 9851 9852 9853 9854 9855 9856 9857 9858 9859 9860 9861 9862 9863 9864 9865 9866 9867 9868 9869 9870 9871 9872 9873 9874 9875 9876 9877 9878 9879 9880 9881 9882 9883 9884 9885 9886 9887 9888 9889 9890 9891 9892 9893 9894 9895 9896 9897 9898 9899 9900 9901 9902 9903 9904 9905 9906 9907 9908 9909 9910 9911 9912 9913 9914 9915 9916 9917 9918 9919 9920 9921 9922 9923 9924 9925 9926 9927 9928 9929 9930 9931 9932 9933 9934 9935 9936 9937 9938 9939 9940 9941 9942 9943 9944 9945 9946 9947 9948 9949 9950 9951 9952 9953 9954 9955 9956 9957 9958 9959 9960 9961 9962 9963 9964 9965 9966 9967 9968 9969 9970 9971 9972 9973 9974 9975 9976 9977 9978 9979 9980 9981 9982 9983 9984 9985 9986 9987 9988 9989 9990 9991 9992 9993 9994 9995 9996 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010 10011 10012 10013 10014 10015 10016 10017 10018 10019 10020 10021 10022 10023 10024 10025 10026 10027 10028 10029 10030 10031 10032 10033 10034 10035 10036 10037 10038 10039 10040 10041 10042 10043 10044 10045 10046 10047 10048 10049 10050 10051 10052 10053 10054 10055 10056 10057 10058 10059 10060 10061 10062 10063 10064 10065 10066 10067 10068 10069 10070 10071 10072 10073 10074 10075 10076 10077 10078 10079 10080 10081 10082 10083 10084 10085 10086 10087 10088 10089 10090 10091 10092 10093 10094 10095 10096 10097 10098 10099 10100 10101 10102 10103 10104 10105 10106 10107 10108 10109 10110 10111 10112 10113 10114 10115 10116 10117 10118 10119 10120 10121 10122 10123 10124 10125 10126 10127 10128 10129 10130 10131 10132 10133 10134 10135 10136 10137 10138 10139 10140 10141 10142 10143 10144 10145 10146 10147 10148 10149 10150 10151 10152 10153 10154 10155 10156 10157 10158 10159 10160 10161 10162 10163 10164 10165 10166 10167 10168 10169 10170 10171 10172 10173 10174 10175 10176 10177 10178 10179 10180 10181 10182 10183 10184 10185 10186 10187 10188 10189 10190 10191 10192 10193 10194 10195 10196 10197 10198 10199 10200 10201 10202 10203 10204 10205 10206 10207 10208 10209 10210 10211 10212 10213 10214 10215 10216 10217 10218 10219 10220 10221 10222 10223 10224 10225 10226 10227 10228 10229 10230 10231 10232 10233 10234 10235 10236 10237 10238 10239 10240 10241 10242 10243 10244 10245 10246 10247 10248 10249 10250 10251 10252 10253 10254 10255 10256 10257 10258 10259 10260 10261 10262 10263 10264 10265 10266 10267 10268 10269 10270 10271 10272 10273 10274 10275 10276 10277 10278 10279 10280 10281 10282 10283 10284 10285 10286 10287 10288 10289 10290 10291 10292 10293 10294 10295 10296 10297 10298 10299 10300 10301 10302 10303 10304 10305 10306 10307 10308 10309 10310 10311 10312 10313 10314 10315 10316 10317 10318 10319 10320 10321 10322 10323 10324 10325 10326 10327 10328 10329 10330 10331 10332 10333 10334 10335 10336 10337 10338 10339 10340 10341 10342 10343 10344 10345 10346 10347 10348 10349 10350 10351 10352 10353 10354 10355 10356 10357 10358 10359 10360 10361 10362 10363 10364 10365 10366 10367 10368 10369 10370 10371 10372 10373 10374 10375 10376 10377 10378 10379 10380 10381 10382 10383 10384 10385 10386 10387 10388 10389 10390 10391 10392 10393 10394 10395 10396 10397 10398 10399 10400 10401 10402 10403 10404 10405 10406 10407 10408 10409 10410 10411 10412 10413 10414 10415 10416 10417 10418 10419 10420 10421 10422 10423 10424 10425 10426 10427 10428 10429 10430 10431 10432 10433 10434 10435 10436 10437 10438 10439 10440 10441 10442 10443 10444 10445 10446 10447 10448 10449 10450 10451 10452 10453 10454 10455 10456 10457 10458 10459 10460 10461 10462 10463 10464 10465 10466 10467 10468 10469 10470 10471 10472 10473 10474 10475 10476 10477 10478 10479 10480 10481 10482 10483 10484 10485 10486 10487 10488 10489 10490 10491 10492 10493 10494 10495 10496 10497 10498 10499 10500 10501 10502 10503 10504 10505 10506 10507 10508 10509 10510 10511 10512 10513 10514 10515 10516 10517 10518 10519 10520 10521 10522 10523 10524 10525 10526 10527 10528 10529 10530 10531 10532 10533 10534 10535 10536 10537 10538 10539 10540 10541 10542 10543 10544 10545 10546 10547 10548 10549 10550 10551 10552 10553 10554 10555 10556 10557 10558 10559 10560 10561 10562 10563 10564 10565 10566 10567 10568 10569 10570 10571 10572 10573 10574 10575 10576 10577 10578 10579 10580 10581 10582 10583 10584 10585 10586 10587 10588 10589 10590 10591 10592 10593 10594 10595 10596 10597 10598 10599 10600 10601 10602 10603 10604 10605 10606 10607 10608 10609 10610 10611 10612 10613 10614 10615 10616 10617 10618 10619 10620 10621 10622 10623 10624 10625 10626 10627 10628 10629 10630 10631 10632 10633 10634 10635 10636 10637 10638 10639 10640 10641 10642 10643 10644 10645 10646 10647 10648 10649 10650 10651 10652 10653 10654 10655 10656 10657 10658 10659 10660 10661 10662 10663 10664 10665 10666 10667 10668 10669 10670 10671 10672 10673 10674 10675 10676 10677 10678 10679 10680 10681 10682 10683 10684 10685 10686 10687 10688 10689 10690 10691 10692 10693 10694 10695 10696 10697 10698 10699 10700 10701 10702 10703 10704 10705 10706 10707 10708 10709 10710 10711 10712 10713 10714 10715 10716 10717 10718 10719 10720 10721 10722 10723 10724 10725 10726 10727 10728 10729 10730 10731 10732 10733 10734 10735 10736 10737 10738 10739 10740 10741 10742 10743 10744 10745 10746 10747 10748 10749 10750 10751 10752 10753 10754 10755 10756 10757 10758 10759 10760 10761 10762 10763 10764 10765 10766 10767 10768 10769 10770 10771 10772 10773 10774 10775 10776 10777 10778 10779 10780 10781 10782 10783 10784 10785 10786 10787 10788 10789 10790 10791 10792 10793 10794 10795 10796 10797 10798 10799 10800 10801 10802 10803 10804 10805 10806 10807 10808 10809 10810 10811 10812 10813 10814 10815 10816 10817 10818 10819 10820 10821 10822 10823 10824 10825 10826 10827 10828 10829 10830 10831 10832 10833 10834 10835 10836 10837 10838 10839 10840 10841 10842 10843 10844 10845 10846 10847 10848 10849 10850 10851 10852 10853 10854 10855 10856 10857 10858 10859 10860 10861 10862 10863 10864 10865 10866 10867 10868 10869 10870 10871 10872 10873 10874 10875 10876 10877 10878 10879 10880 10881 10882 10883 10884 10885 10886 10887 10888 10889 10890 10891 10892 10893 10894 10895 10896 10897 10898 10899 10900 10901 10902 10903 10904 10905 10906 10907 10908 10909 10910 10911 10912 10913 10914 10915 10916 10917 10918 10919 10920 10921 10922 10923 10924 10925 10926 10927 10928 10929 10930 10931 10932 10933 10934 10935 10936 10937 10938 10939 10940 10941 10942 10943 10944 10945 10946 10947 10948 10949 10950 10951 10952 10953 10954 10955 10956 10957 10958 10959 10960 10961 10962 10963 10964 10965 10966 10967 10968 10969 10970 10971 10972 10973 10974 10975 10976 10977 10978 10979 10980 10981 10982 10983 10984 10985 10986 10987 10988 10989 10990 10991 10992 10993 10994 10995 10996 10997 10998 10999 11000 11001 11002 11003 11004 11005 11006 11007 11008 11009 11010 11011 11012 11013 11014 11015 11016 11017 11018 11019 11020 11021 11022 11023 11024 11025 11026 11027 11028 11029 11030 11031 11032 11033 11034 11035 11036 11037 11038 11039 11040 11041 11042 11043 11044 11045 11046 11047 11048 11049 11050 11051 11052 11053 11054 11055 11056 11057 11058 11059 11060 11061 11062 11063 11064 11065 11066 11067 11068 11069 11070 11071 11072 11073 11074 11075 11076 11077 11078 11079 11080 11081 11082 11083 11084 11085 11086 11087 11088 11089 11090 11091 11092 11093 11094 11095 11096 11097 11098 11099 11100 11101 11102 11103 11104 11105 11106 11107 11108 11109 11110 11111 11112 11113 11114 11115 11116 11117 11118 11119 11120 11121 11122 11123 11124 11125 11126 11127 11128 11129 11130 11131 11132 11133 11134 11135 11136 11137 11138 11139 11140 11141 11142 11143 11144 11145 11146 11147 11148 11149 11150 11151 11152 11153 11154 11155 11156 11157 11158 11159 11160 11161 11162 11163 11164 11165 11166 11167 11168 11169 11170 11171 11172 11173 11174 11175 11176 11177 11178 11179 11180 11181 11182 11183 11184 11185 11186 11187 11188 11189 11190 11191 11192 11193 11194 11195 11196 11197 11198 11199 11200 11201 11202 11203 11204 11205 11206 11207 11208 11209 11210 11211 11212 11213 11214 11215 11216 11217 11218 11219 11220 11221 11222 11223 11224 11225 11226 11227 11228 11229 11230 11231 11232 11233 11234 11235 11236 11237 11238 11239 11240 11241 11242 11243 11244 11245 11246 11247 11248 11249 11250 11251 11252 11253 11254 11255 11256 11257 11258 11259 11260 11261 11262 11263 11264 11265 11266 11267 11268 11269 11270 11271 11272 11273 11274 11275 11276 11277 11278 11279 11280 11281 11282 11283 11284 11285 11286 11287 11288 11289 11290 11291 11292 11293 11294 11295 11296 11297 11298 11299 11300 11301 11302 11303 11304 11305 11306 11307 11308 11309 11310 11311 11312 11313 11314 11315 11316 11317 11318 11319 11320 11321 11322 11323 11324 11325 11326 11327 11328 11329 11330 11331 11332 11333 11334 11335 11336 11337 11338 11339 11340 11341 11342 11343 11344 11345 11346 11347 11348 11349 11350 11351 11352 11353 11354 11355 11356 11357 11358 11359 11360 11361 11362 11363 11364 11365 11366 11367 11368 11369 11370 11371 11372 11373 11374 11375 11376 11377 11378 11379 11380 11381 11382 11383 11384 11385 11386 11387 11388 11389 11390 11391 11392 11393 11394 11395 11396 11397 11398 11399 11400 11401 11402 11403 11404 11405 11406 11407 11408 11409 11410 11411 11412 11413 11414 11415 11416 11417 11418 11419 11420 11421 11422 11423 11424 11425 11426 11427 11428 11429 11430 11431 11432 11433 11434 11435 11436 11437 11438 11439 11440 11441 11442 11443 11444 11445 11446 11447 11448 11449 11450 11451 11452 11453 11454 11455 11456 11457 11458 11459 11460 11461 11462 11463 11464 11465 11466 11467 11468 11469 11470 11471 11472 11473 11474 11475 11476 11477 11478 11479 11480 11481 11482 11483 11484 11485 11486 11487 11488 11489 11490 11491 11492 11493 11494 11495 11496 11497 11498 11499 11500 11501 11502 11503 11504 11505 11506 11507 11508 11509 11510 11511 11512 11513 11514 11515 11516 11517 11518 11519 11520 11521 11522 11523 11524 11525 11526 11527 11528 11529 11530 11531 11532 11533 11534 11535 11536 11537 11538 11539 11540 11541 11542 11543 11544 11545 11546 11547 11548 11549 11550 11551 11552 11553 11554 11555 11556 11557 11558 11559 11560 11561 11562 11563 11564 11565 11566 11567 11568 11569 11570 11571 11572 11573 11574 11575 11576 11577 11578 11579 11580 11581 11582 11583 11584 11585 11586 11587 11588 11589 11590 11591 11592 11593 11594 11595 11596 11597 11598 11599 11600 11601 11602 11603 11604 11605 11606 11607 11608 11609 11610 11611 11612 11613 11614 11615 11616 11617 11618 11619 11620 11621 11622 11623 11624 11625 11626 11627 11628 11629 11630 11631 11632 11633 11634 11635 11636 11637 11638 11639 11640 11641 11642 11643 11644 11645 11646 11647 11648 11649 11650 11651 11652 11653 11654 11655 11656 11657 11658 11659 11660 11661 11662 11663 11664 11665 11666 11667 11668 11669 11670 11671 11672 11673 11674 11675 11676 11677 11678 11679 11680 11681 11682 11683 11684 11685 11686 11687 11688 11689 11690 11691 11692 11693 11694 11695 11696 11697 11698 11699 11700 11701 11702 11703 11704 11705 11706 11707 11708 11709 11710 11711 11712 11713 11714 11715 11716 11717 11718 11719 11720 11721 11722 11723 11724 11725 11726 11727 11728 11729 11730 11731 11732 11733 11734 11735 11736 11737 11738 11739 11740 11741 11742 11743 11744 11745 11746 11747 11748 11749 11750 11751 11752 11753 11754 11755 11756 11757 11758 11759 11760 11761 11762 11763 11764 11765 11766 11767 11768 11769 11770 11771 11772 11773 11774 11775 11776 11777 11778 11779 11780 11781 11782 11783 11784 11785 11786 11787 11788 11789 11790 11791 11792 11793 11794 11795 11796 11797 11798 11799 11800 11801 11802 11803 11804 11805 11806 11807 11808 11809 11810 11811 11812 11813 11814 11815 11816 11817 11818 11819 11820 11821 11822 11823 11824 11825 11826 11827 11828 11829 11830 11831 11832 11833 11834 11835 11836 11837 11838 11839 11840 11841 11842 11843 11844 11845 11846 11847 11848 11849 11850 11851 11852 11853 11854 11855 11856 11857 11858 11859 11860 11861 11862 11863 11864 11865 11866 11867 11868 11869 11870 11871 11872 11873 11874 11875 11876 11877 11878 11879 11880 11881 11882 11883 11884 11885 11886 11887 11888 11889 11890 11891 11892 11893 11894 11895 11896 11897 11898 11899 11900 11901 11902 11903 11904 11905 11906 11907 11908 11909 11910 11911 11912 11913 11914 11915 11916 11917 11918 11919 11920 11921 11922 11923 11924 11925 11926 11927 11928 11929 11930 11931 11932 11933 11934 11935 11936 11937 11938 11939 11940 11941 11942 11943 11944 11945 11946 11947 11948 11949 11950 11951 11952 11953 11954 11955 11956 11957 11958 11959 11960 11961 11962 11963 11964 11965 11966 11967 11968 11969 11970 11971 11972 11973 11974 11975 11976 11977 11978 11979 11980 11981 11982 11983 11984 11985 11986 11987 11988 11989 11990 11991 11992 11993 11994 11995 11996 11997 11998 11999 12000 12001 12002 12003 12004 12005 12006 12007 12008 12009 12010 12011 12012 12013 12014 12015 12016 12017 12018 12019 12020 12021 12022 12023 12024 12025 12026 12027 12028 12029 12030 12031 12032 12033 12034 12035 12036 12037 12038 12039 12040 12041 12042 12043 12044 12045 12046 12047 12048 12049 12050 12051 12052 12053 12054 12055 12056 12057 12058 12059 12060 12061 12062 12063 12064 12065 12066 12067 12068 12069 12070 12071 12072 12073 12074 12075 12076 12077 12078 12079 12080 12081 12082 12083 12084 12085 12086 12087 12088 12089 12090 12091 12092 12093 12094 12095 12096 12097 12098 12099 12100 12101 12102 12103 12104 12105 12106 12107 12108 12109 12110 12111 12112 12113 12114 12115 12116 12117 12118 12119 12120 12121 12122 12123 12124 12125 12126 12127 12128 12129 12130 12131 12132 12133 12134 12135 12136 12137 12138 12139 12140 12141 12142 12143 12144 12145 12146 12147 12148 12149 12150 12151 12152 12153 12154 12155 12156 12157 12158 12159 12160 12161 12162 12163 12164 12165 12166 12167 12168 12169 12170 12171 12172 12173 12174 12175 12176 12177 12178 12179 12180 12181 12182 12183 12184 12185 12186 12187 12188 12189 12190 12191 12192 12193 12194 12195 12196 12197 12198 12199 12200 12201 12202 12203 12204 12205 12206 12207 12208 12209 12210 12211 12212 12213 12214 12215 12216 12217 12218 12219 12220 12221 12222 12223 12224 12225 12226 12227 12228 12229 12230 12231 12232 12233 12234 12235 12236 12237 12238 12239 12240 12241 12242 12243 12244 12245 12246 12247 12248 12249 12250 12251 12252 12253 12254 12255 12256 12257 12258 12259 12260 12261 12262 12263 12264 12265 12266 12267 12268 12269 12270 12271 12272 12273 12274 12275 12276 12277 12278 12279 12280 12281 12282 12283 12284 12285 12286 12287 12288 12289 12290 12291 12292 12293 12294 12295 12296 12297 12298 12299 12300 12301 12302 12303 12304 12305 12306 12307 12308 12309 12310 12311 12312 12313 12314 12315 12316 12317 12318 12319 12320 12321 12322 12323 12324 12325 12326 12327 12328 12329 12330 12331 12332 12333 12334 12335 12336 12337 12338 12339 12340 12341 12342 12343 12344 12345 12346 12347 12348 12349 12350 12351 12352 12353 12354 12355 12356 12357 12358 12359 12360 12361 12362 12363 12364 12365 12366 12367 12368 12369 12370 12371 12372 12373 12374 12375 12376 12377 12378 12379 12380 12381 12382 12383 12384 12385 12386 12387 12388 12389 12390 12391 12392 12393 12394 12395 12396 12397 12398 12399 12400 12401 12402 12403 12404 12405 12406 12407 12408 12409 12410 12411 12412 12413 12414 12415 12416 12417 12418 12419 12420 12421 12422 12423 12424 12425 12426 12427 12428 12429 12430 12431 12432 12433 12434 12435 12436 12437 12438 12439 12440 12441 12442 12443 12444 12445 12446 12447 12448 12449 12450 12451 12452 12453 12454 12455 12456 12457 12458 12459 12460 12461 12462 12463 12464 12465 12466 12467 12468 12469 12470 12471 12472 12473 12474 12475 12476 12477 12478 12479 12480 12481 12482 12483 12484 12485 12486 12487 12488 12489 12490 12491 12492 12493 12494 12495 12496 12497 12498 12499 12500 12501 12502 12503 12504 12505 12506 12507 12508 12509 12510 12511 12512 12513 12514 12515 12516 12517 12518 12519 12520 12521 12522 12523 12524 12525 12526 12527 12528 12529 12530 12531 12532 12533 12534 12535 12536 12537 12538 12539 12540 12541 12542 12543 12544 12545 12546 12547 12548 12549 12550 12551 12552 12553 12554 12555 12556 12557 12558 12559 12560 12561 12562 12563 12564 12565 12566 12567 12568 12569 12570 12571 12572 12573 12574 12575 12576 12577 12578 12579 12580 12581 12582 12583 12584 12585 12586 12587 12588 12589 12590 12591 12592 12593 12594 12595 12596 12597 12598 12599 12600 12601 12602 12603 12604 12605 12606 12607 12608 12609 12610 12611 12612 12613 12614 12615 12616 12617 12618 12619 12620 12621 12622 12623 12624 12625 12626 12627 12628 12629 12630 12631 12632 12633 12634 12635 12636 12637 12638 12639 12640 12641 12642 12643 12644 12645 12646 12647 12648 12649 12650 12651 12652 12653 12654 12655 12656 12657 12658 12659 12660 12661 12662 12663 12664 12665 12666 12667 12668 12669 12670 12671 12672 12673 12674 12675 12676 12677 12678 12679 12680 12681 12682 12683 12684 12685 12686 12687 12688 12689 12690 12691 12692 12693 12694 12695 12696 12697 12698 12699 12700 12701 12702 12703 12704 12705 12706 12707 12708 12709 12710 12711 12712 12713 12714 12715 12716 12717 12718 12719 12720 12721 12722 12723 12724 12725 12726 12727 12728 12729 12730 12731 12732 12733 12734 12735 12736 12737 12738 12739 12740 12741 12742 12743 12744 12745 12746 12747 12748 12749 12750 12751 12752 12753 12754 12755 12756 12757 12758 12759 12760 12761 12762 12763 12764 12765 12766 12767 12768 12769 12770 12771 12772 12773 12774 12775 12776 12777 12778 12779 12780 12781 12782 12783 12784 12785 12786 12787 12788 12789 12790 12791 12792 12793 12794 12795 12796 12797 12798 12799 12800 12801 12802 12803 12804 12805 12806 12807 12808 12809 12810 12811 12812 12813 12814 12815 12816 12817 12818 12819 12820 12821 12822 12823 12824 12825 12826 12827 12828 12829 12830 12831 12832 12833 12834 12835 12836 12837 12838 12839 12840 12841 12842 12843 12844 12845 12846 12847 12848 12849 12850 12851 12852 12853 12854 12855 12856 12857 12858 12859 12860 12861 12862 12863 12864 12865 12866 12867 12868 12869 12870 12871 12872 12873 12874 12875 12876 12877 12878 12879 12880 12881 12882 12883 12884 12885 12886 12887 12888 12889 12890 12891 12892 12893 12894 12895 12896 12897 12898 12899 12900 12901 12902 12903 12904 12905 12906 12907 12908 12909 12910 12911 12912 12913 12914 12915 12916 12917 12918 12919 12920 12921 12922 12923 12924 12925 12926 12927 12928 12929 12930 12931 12932 12933 12934 12935 12936 12937 12938 12939 12940 12941 12942 12943 12944 12945 12946 12947 12948 12949 12950 12951 12952 12953 12954 12955 12956 12957 12958 12959 12960 12961 12962 12963 12964 12965 12966 12967 12968 12969 12970 12971 12972 12973 12974 12975 12976 12977 12978 12979 12980 12981 12982 12983 12984 12985 12986 12987 12988 12989 12990 12991 12992 12993 12994 12995 12996 12997 12998 12999 13000 13001 13002 13003 13004 13005 13006 13007 13008 13009 13010 13011 13012 13013 13014 13015 13016 13017 13018 13019 13020 13021 13022 13023 13024 13025 13026 13027 13028 13029 13030 13031 13032 13033 13034 13035 13036 13037 13038 13039 13040 13041 13042 13043 13044 13045 13046 13047 13048 13049 13050 13051 13052 13053 13054 13055 13056 13057 13058 13059 13060 13061 13062 13063 13064 13065 13066 13067 13068 13069 13070 13071 13072 13073 13074 13075 13076 13077 13078 13079 13080 13081 13082 13083 13084 13085 13086 13087 13088 13089 13090 13091 13092 13093 13094 13095 13096 13097 13098 13099 13100 13101 13102 13103 13104 13105 13106 13107 13108 13109 13110 13111 13112 13113 13114 13115 13116 13117 13118 13119 13120 13121 13122 13123 13124 13125 13126 13127 13128 13129 13130 13131 13132 13133 13134 13135 13136 13137 13138 13139 13140 13141 13142 13143 13144 13145 13146 13147 13148 13149 13150 13151 13152 13153 13154 13155 13156 13157 13158 13159 13160 13161 13162 13163 13164 13165 13166 13167 13168 13169 13170 13171 13172 13173 13174 13175 13176 13177 13178 13179 13180 13181 13182 13183 13184 13185 13186 13187 13188 13189 13190 13191 13192 13193 13194 13195 13196 13197 13198 13199 13200 13201 13202 13203 13204 13205 13206 13207 13208 13209 13210 13211 13212 13213 13214 13215 13216 13217 13218 13219 13220 13221 13222 13223 13224 13225 13226 13227 13228 13229 13230 13231 13232 13233 13234 13235 13236 13237 13238 13239 13240 13241 13242 13243 13244 13245 13246 13247 13248 13249 13250 13251 13252 13253 13254 13255 13256 13257 13258 13259 13260 13261 13262 13263 13264 13265 13266 13267 13268 13269 13270 13271 13272 13273 13274 13275 13276 13277 13278 13279 13280 13281 13282 13283 13284 13285 13286 13287 13288 13289 13290 13291 13292 13293 13294 13295 13296 13297 13298 13299 13300 13301 13302 13303 13304 13305 13306 13307 13308 13309 13310 13311 13312 13313 13314 13315 13316 13317 13318 13319 13320 13321 13322 13323 13324 13325 13326 13327 13328 13329 13330 13331 13332 13333 13334 13335 13336 13337 13338 13339 13340 13341 13342 13343 13344 13345 13346 13347 13348 13349 13350 13351 13352 13353 13354 13355 13356 13357 13358 13359 13360 13361 13362 13363 13364 13365 13366 13367 13368 13369 13370 13371 13372 13373 13374 13375 13376 13377 13378 13379 13380 13381 13382 13383 13384 13385 13386 13387 13388 13389 13390 13391 13392 13393 13394 13395 13396 13397 13398 13399 13400 13401 13402 13403 13404 13405 13406 13407 13408 13409 13410 13411 13412 13413 13414 13415 13416 13417 13418 13419 13420 13421 13422 13423 13424 13425 13426 13427 13428 13429 13430 13431 13432 13433 13434 13435 13436 13437 13438 13439 13440 13441 13442 13443 13444 13445 13446 13447 13448 13449 13450 13451 13452 13453 13454 13455 13456 13457 13458 13459 13460 13461 13462 13463 13464 13465 13466 13467 13468 13469 13470 13471 13472 13473 13474 13475 13476 13477 13478 13479 13480 13481 13482 13483 13484 13485 13486 13487 13488 13489 13490 13491 13492 13493 13494 13495 13496 13497 13498 13499 13500 13501 13502 13503 13504 13505 13506 13507 13508 13509 13510 13511 13512 13513 13514 13515 13516 13517 13518 13519 13520 13521 13522 13523 13524 13525 13526 13527 13528 13529 13530 13531 13532 13533 13534 13535 13536 13537 13538 13539 13540 13541 13542 13543 13544 13545 13546 13547 13548 13549 13550 13551 13552 13553 13554 13555 13556 13557 13558 13559 13560 13561 13562 13563 13564 13565 13566 13567 13568 13569 13570 13571 13572 13573 13574 13575 13576 13577 13578 13579 13580 13581 13582 13583 13584 13585 13586 13587 13588 13589 13590 13591 13592 13593 13594 13595 13596 13597 13598 13599 13600 13601 13602 13603 13604 13605 13606 13607 13608 13609 13610 13611 13612 13613 13614 13615 13616 13617 13618 13619 13620 13621 13622 13623 13624 13625 13626 13627 13628 13629 13630 13631 13632 13633 13634 13635 13636 13637 13638 13639 13640 13641 13642 13643 13644 13645 13646 13647 13648 13649 13650 13651 13652 13653 13654 13655 13656 13657 13658 13659 13660 13661 13662 13663 13664 13665 13666 13667 13668 13669 13670 13671 13672 13673 13674 13675 13676 13677 13678 13679 13680 13681 13682 13683 13684 13685 13686 13687 13688 13689 13690 13691 13692 13693 13694 13695 13696 13697 13698 13699 13700 13701 13702 13703 13704 13705 13706 13707 13708 13709 13710 13711 13712 13713 13714 13715 13716 13717 13718 13719 13720 13721 13722 13723 13724 13725 13726 13727 13728 13729 13730 13731 13732 13733 13734 13735 13736 13737 13738 13739 13740 13741 13742 13743 13744 13745 13746 13747 13748 13749 13750 13751 13752 13753 13754 13755 13756 13757 13758 13759 13760 13761 13762 13763 13764 13765 13766 13767 13768 13769 13770 13771 13772 13773 13774 13775 13776 13777 13778 13779 13780 13781 13782 13783 13784 13785 13786 13787 13788 13789 13790 13791 13792 13793 13794 13795 13796 13797 13798 13799 13800 13801 13802 13803 13804 13805 13806 13807 13808 13809 13810 13811 13812 13813 13814 13815 13816 13817 13818 13819 13820 13821 13822 13823 13824 13825 13826 13827 13828 13829 13830 13831 13832 13833 13834 13835 13836 13837 13838 13839 13840 13841 13842 13843 13844 13845 13846 13847 13848 13849 13850 13851 13852 13853 13854 13855 13856 13857 13858 13859 13860 13861 13862 13863 13864 13865 13866 13867 13868 13869 13870 13871 13872 13873 13874 13875 13876 13877 13878 13879 13880 13881 13882 13883 13884 13885 13886 13887 13888 13889 13890 13891 13892 13893 13894 13895 13896 13897 13898 13899 13900 13901 13902 13903 13904 13905 13906 13907 13908 13909 13910 13911 13912 13913 13914 13915 13916 13917 13918 13919 13920 13921 13922 13923 13924 13925 13926 13927 13928 13929 13930 13931 13932 13933 13934 13935 13936 13937 13938 13939 13940 13941 13942 13943 13944 13945 13946 13947 13948 13949 13950 13951 13952 13953 13954 13955 13956 13957 13958 13959 13960 13961 13962 13963 13964 13965 13966 13967 13968 13969 13970 13971 13972 13973 13974 13975 13976 13977 13978 13979 13980 13981 13982 13983 13984 13985 13986 13987 13988 13989 13990 13991 13992 13993 13994 13995 13996 13997 13998 13999 14000 14001 14002 14003 14004 14005 14006 14007 14008 14009 14010 14011 14012 14013 14014 14015 14016 14017 14018 14019 14020 14021 14022 14023 14024 14025 14026 14027 14028 14029 14030 14031 14032 14033 14034 14035 14036 14037 14038 14039 14040 14041 14042 14043 14044 14045 14046 14047 14048 14049 14050 14051 14052 14053 14054 14055 14056 14057 14058 14059 14060 14061 14062 14063 14064 14065 14066 14067 14068 14069 14070 14071 14072 14073 14074 14075 14076 14077 14078 14079 14080 14081 14082 14083 14084 14085 14086 14087 14088 14089 14090 14091 14092 14093 14094 14095 14096 14097 14098 14099 14100 14101 14102 14103 14104 14105 14106 14107 14108 14109 14110 14111 14112 14113 14114 14115 14116 14117 14118 14119 14120 14121 14122 14123 14124 14125 14126 14127 14128 14129 14130 14131 14132 14133 14134 14135 14136 14137 14138 14139 14140 14141 14142 14143 14144 14145 14146 14147 14148 14149 14150 14151 14152 14153 14154 14155 14156 14157 14158 14159 14160 14161 14162 14163 14164 14165 14166 14167 14168 14169 14170 14171 14172 14173 14174 14175 14176 14177 14178 14179 14180 14181 14182 14183 14184 14185 14186 14187 14188 14189 14190 14191 14192 14193 14194 14195 14196 14197 14198 14199 14200 14201 14202 14203 14204 14205 14206 14207 14208 14209 14210 14211 14212 14213 14214 14215 14216 14217 14218 14219 14220 14221 14222 14223 14224 14225 14226 14227 14228 14229 14230 14231 14232 14233 14234 14235 14236 14237 14238 14239 14240 14241 14242 14243 14244 14245 14246 14247 14248 14249 14250 14251 14252 14253 14254 14255 14256 14257 14258 14259 14260 14261 14262 14263 14264 14265 14266 14267 14268 14269 14270 14271 14272 14273 14274 14275 14276 14277 14278 14279 14280 14281 14282 14283 14284 14285 14286 14287 14288 14289 14290 14291 14292 14293 14294 14295 14296 14297 14298 14299 14300 14301 14302 14303 14304 14305 14306 14307 14308 14309 14310 14311 14312 14313 14314 14315 14316 14317 14318 14319 14320 14321 14322 14323 14324 14325 14326 14327 14328 14329 14330 14331 14332 14333 14334 14335 14336 14337 14338 14339 14340 14341 14342 14343 14344 14345 14346 14347 14348 14349 14350 14351 14352 14353 14354 14355 14356 14357 14358 14359 14360 14361 14362 14363 14364 14365 14366 14367 14368 14369 14370 14371 14372 14373 14374 14375 14376 14377 14378 14379 14380 14381 14382 14383 14384 14385 14386 14387 14388 14389 14390 14391 14392 14393 14394 14395 14396 14397 14398 14399 14400 14401 14402 14403 14404 14405 14406 14407 14408 14409 14410 14411 14412 14413 14414 14415 14416 14417 14418 14419 14420 14421 14422 14423 14424 14425 14426 14427 14428 14429 14430 14431 14432 14433 14434 14435 14436 14437 14438 14439 14440 14441 14442 14443 14444 14445 14446 14447 14448 14449 14450 14451 14452 14453 14454 14455 14456 14457 14458 14459 14460 14461 14462 14463 14464 14465 14466 14467 14468 14469 14470 14471 14472 14473 14474 14475 14476 14477 14478 14479 14480 14481 14482 14483 14484 14485 14486 14487 14488 14489 14490 14491 14492 14493 14494 14495 14496 14497 14498 14499 14500 14501 14502 14503 14504 14505 14506 14507 14508 14509 14510 14511 14512 14513 14514 14515 14516 14517 14518 14519 14520 14521 14522 14523 14524 14525 14526 14527 14528 14529 14530 14531 14532 14533 14534 14535 14536 14537 14538 14539 14540 14541 14542 14543 14544 14545 14546 14547 14548 14549 14550 14551 14552 14553 14554 14555 14556 14557 14558 14559 14560 14561 14562 14563 14564 14565 14566 14567 14568 14569 14570 14571 14572 14573 14574 14575 14576 14577 14578 14579 14580 14581 14582 14583 14584 14585 14586 14587 14588 14589 14590 14591 14592 14593 14594 14595 14596 14597 14598 14599 14600 14601 14602 14603 14604 14605 14606 14607 14608 14609 14610 14611 14612 14613 14614 14615 14616 14617 14618 14619 14620 14621 14622 14623 14624 14625 14626 14627 14628 14629 14630 14631 14632 14633 14634 14635 14636 14637 14638 14639 14640 14641 14642 14643 14644 14645 14646 14647 14648 14649 14650 14651 14652 14653 14654 14655 14656 14657 14658 14659 14660 14661 14662 14663 14664 14665 14666 14667 14668 14669 14670 14671 14672 14673 14674 14675 14676 14677 14678 14679 14680 14681 14682 14683 14684 14685 14686 14687 14688 14689 14690 14691 14692 14693 14694 14695 14696 14697 14698 14699 14700 14701 14702 14703 14704 14705 14706 14707 14708 14709 14710 14711 14712 14713 14714 14715 14716 14717 14718 14719 14720 14721 14722 14723 14724 14725 14726 14727 14728 14729 14730 14731 14732 14733 14734 14735 14736 14737 14738 14739 14740 14741 14742 14743 14744 14745 14746 14747 14748 14749 14750 14751 14752 14753 14754 14755 14756 14757 14758 14759 14760 14761 14762 14763 14764 14765 14766 14767 14768 14769 14770 14771 14772 14773 14774 14775 14776 14777 14778 14779 14780 14781 14782 14783 14784 14785 14786 14787 14788 14789 14790 14791 14792 14793 14794 14795 14796 14797 14798 14799 14800 14801 14802 14803 14804 14805 14806 14807 14808 14809 14810 14811 14812 14813 14814 14815 14816 14817 14818 14819 14820 14821 14822 14823 14824 14825 14826 14827 14828 14829 14830 14831 14832 14833 14834 14835 14836 14837 14838 14839 14840 14841 14842 14843 14844 14845 14846 14847 14848 14849 14850 14851 14852 14853 14854 14855 14856 14857 14858 14859 14860 14861 14862 14863 14864 14865 14866 14867 14868 14869 14870 14871 14872 14873 14874 14875 14876 14877 14878 14879 14880 14881 14882 14883 14884 14885 14886 14887 14888 14889 14890 14891 14892 14893 14894 14895 14896 14897 14898 14899 14900 14901 14902 14903 14904 14905 14906 14907 14908 14909 14910 14911 14912 14913 14914 14915 14916 14917 14918 14919 14920 14921 14922 14923 14924 14925 14926 14927 14928 14929 14930 14931 14932 14933 14934 14935 14936 14937 14938 14939 14940 14941 14942 14943 14944 14945 14946 14947 14948 14949 14950 14951 14952 14953 14954 14955 14956 14957 14958 14959 14960 14961 14962 14963 14964 14965 14966 14967 14968 14969 14970 14971 14972 14973 14974 14975 14976 14977 14978 14979 14980 14981 14982 14983 14984 14985 14986 14987 14988 14989 14990 14991 14992 14993 14994 14995 14996 14997 14998 14999 15000 15001 15002 15003 15004 15005 15006 15007 15008 15009 15010 15011 15012 15013 15014 15015 15016 15017 15018 15019 15020 15021 15022 15023 15024 15025 15026 15027 15028 15029 15030 15031 15032 15033 15034 15035 15036 15037 15038 15039 15040 15041 15042 15043 15044 15045 15046 15047 15048 15049 15050 15051 15052 15053 15054 15055 15056 15057 15058 15059 15060 15061 15062 15063 15064 15065 15066 15067 15068 15069 15070 15071 15072 15073 15074 15075 15076 15077 15078 15079 15080 15081 15082 15083 15084 15085 15086 15087 15088 15089 15090 15091 15092 15093 15094 15095 15096 15097 15098 15099 15100 15101 15102 15103 15104 15105 15106 15107 15108 15109 15110 15111 15112 15113 15114 15115 15116 15117 15118 15119 15120 15121 15122 15123 15124 15125 15126 15127 15128 15129 15130 15131 15132 15133 15134 15135 15136 15137 15138 15139 15140 15141 15142 15143 15144 15145 15146 15147 15148 15149 15150 15151 15152 15153 15154 15155 15156 15157 15158 15159 15160 15161 15162 15163 15164 15165 15166 15167 15168 15169 15170 15171 15172 15173 15174 15175 15176 15177 15178 15179 15180 15181 15182 15183 15184 15185 15186 15187 15188 15189 15190 15191 15192 15193 15194 15195 15196 15197 15198 15199 15200 15201 15202 15203 15204 15205 15206 15207 15208 15209 15210 15211 15212 15213 15214 15215 15216 15217 15218 15219 15220 15221 15222 15223 15224 15225 15226 15227 15228 15229 15230 15231 15232 15233 15234 15235 15236 15237 15238 15239 15240 15241 15242 15243 15244 15245 15246 15247 15248 15249 15250 15251 15252 15253 15254 15255 15256 15257 15258 15259 15260 15261 15262 15263 15264 15265 15266 15267 15268 15269 15270 15271 15272 15273 15274 15275 15276 15277 15278 15279 15280 15281 15282 15283 15284 15285 15286 15287 15288 15289 15290 15291 15292 15293 15294 15295 15296 15297 15298 15299 15300 15301 15302 15303 15304 15305 15306 15307 15308 15309 15310 15311 15312 15313 15314 15315 15316 15317 15318 15319 15320 15321 15322 15323 15324 15325 15326 15327 15328 15329 15330 15331 15332 15333 15334 15335 15336 15337 15338 15339 15340 15341 15342 15343 15344 15345 15346 15347 15348 15349 15350 15351 15352 15353 15354 15355 15356 15357 15358 15359 15360 15361 15362 15363 15364 15365 15366 15367 15368 15369 15370 15371 15372 15373 15374 15375 15376 15377 15378 15379 15380 15381 15382 15383 15384 15385 15386 15387 15388 15389 15390 15391 15392 15393 15394 15395 15396 15397 15398 15399 15400 15401 15402 15403 15404 15405 15406 15407 15408 15409 15410 15411 15412 15413 15414 15415 15416 15417 15418 15419 15420 15421 15422 15423 15424 15425 15426 15427 15428 15429 15430 15431 15432 15433 15434 15435 15436 15437 15438 15439 15440 15441 15442 15443 15444 15445 15446 15447 15448 15449 15450 15451 15452 15453 15454 15455 15456 15457 15458 15459 15460 15461 15462 15463 15464 15465 15466 15467 15468 15469 15470 15471 15472 15473 15474 15475 15476 15477 15478 15479 15480 15481 15482 15483 15484 15485 15486 15487 15488 15489 15490 15491 15492 15493 15494 15495 15496 15497 15498 15499 15500 15501 15502 15503 15504 15505 15506 15507 15508 15509 15510 15511 15512 15513 15514 15515 15516 15517 15518 15519 15520 15521 15522 15523 15524 15525 15526 15527 15528 15529 15530 15531 15532 15533 15534 15535 15536 15537 15538 15539 15540 15541 15542 15543 15544 15545 15546 15547 15548 15549 15550 15551 15552 15553 15554 15555 15556 15557 15558 15559 15560 15561 15562 15563 15564 15565 15566 15567 15568 15569 15570 15571 15572 15573 15574 15575 15576 15577 15578 15579 15580 15581 15582 15583 15584 15585 15586 15587 15588 15589 15590 15591 15592 15593 15594 15595 15596 15597 15598 15599 15600 15601 15602 15603 15604 15605 15606 15607 15608 15609 15610 15611 15612 15613 15614 15615 15616 15617 15618 15619 15620 15621 15622 15623 15624 15625 15626 15627 15628 15629 15630 15631 15632 15633 15634 15635 15636 15637 15638 15639 15640 15641 15642 15643 15644 15645 15646 15647 15648 15649 15650 15651 15652 15653 15654 15655 15656 15657 15658 15659 15660 15661 15662 15663 15664 15665 15666 15667 15668 15669 15670 15671 15672 15673 15674 15675 15676 15677 15678 15679 15680 15681 15682 15683 15684 15685 15686 15687 15688 15689 15690 15691 15692 15693 15694 15695 15696 15697 15698 15699 15700 15701 15702 15703 15704 15705 15706 15707 15708 15709 15710 15711 15712 15713 15714 15715 15716 15717 15718 15719 15720 15721 15722 15723 15724 15725 15726 15727 15728 15729 15730 15731 15732 15733 15734 15735 15736 15737 15738 15739 15740 15741 15742 15743 15744 15745 15746 15747 15748 15749 15750 15751 15752 15753 15754 15755 15756 15757 15758 15759 15760 15761 15762 15763 15764 15765 15766 15767 15768 15769 15770 15771 15772 15773 15774 15775 15776 15777 15778 15779 15780 15781 15782 15783 15784 15785 15786 15787 15788 15789 15790 15791 15792 15793 15794 15795 15796 15797 15798 15799 15800 15801 15802 15803 15804 15805 15806 15807 15808 15809 15810 15811 15812 15813 15814 15815 15816 15817 15818 15819 15820 15821 15822 15823 15824 15825 15826 15827 15828 15829 15830 15831 15832 15833 15834 15835 15836 15837 15838 15839 15840 15841 15842 15843 15844 15845 15846 15847 15848 15849 15850 15851 15852 15853 15854 15855 15856 15857 15858 15859 15860 15861 15862 15863 15864 15865 15866 15867 15868 15869 15870 15871 15872 15873 15874 15875 15876 15877 15878 15879 15880 15881 15882 15883 15884 15885 15886 15887 15888 15889 15890 15891 15892 15893 15894 15895 15896 15897 15898 15899 15900 15901 15902 15903 15904 15905 15906 15907 15908 15909 15910 15911 15912 15913 15914 15915 15916 15917 15918 15919 15920 15921 15922 15923 15924 15925 15926 15927 15928 15929 15930 15931 15932 15933 15934 15935 15936 15937 15938 15939 15940 15941 15942 15943 15944 15945 15946 15947 15948 15949 15950 15951 15952 15953 15954 15955 15956 15957 15958 15959 15960 15961 15962 15963 15964 15965 15966 15967 15968 15969 15970 15971 15972 15973 15974 15975 15976 15977 15978 15979 15980 15981 15982 15983 15984 15985 15986 15987 15988 15989 15990 15991 15992 15993 15994 15995 15996 15997 15998 15999 16000 16001 16002 16003 16004 16005 16006 16007 16008 16009 16010 16011 16012 16013 16014 16015 16016 16017 16018 16019 16020 16021 16022 16023 16024 16025 16026 16027 16028 16029 16030 16031 16032 16033 16034 16035 16036 16037 16038 16039 16040 16041 16042 16043 16044 16045 16046 16047 16048 16049 16050 16051 16052 16053 16054 16055 16056 16057 16058 16059 16060 16061 16062 16063 16064 16065 16066 16067 16068 16069 16070 16071 16072 16073 16074 16075 16076 16077 16078 16079 16080 16081 16082 16083 16084 16085 16086 16087 16088 16089 16090 16091 16092 16093 16094 16095 16096 16097 16098 16099 16100 16101 16102 16103 16104 16105 16106 16107 16108 16109 16110 16111 16112 16113 16114 16115 16116 16117 16118 16119 16120 16121 16122 16123 16124 16125 16126 16127 16128 16129 16130 16131 16132 16133 16134 16135 16136 16137 16138 16139 16140 16141 16142 16143 16144 16145 16146 16147 16148 16149 16150 16151 16152 16153 16154 16155 16156 16157 16158 16159 16160 16161 16162 16163 16164 16165 16166 16167 16168 16169 16170 16171 16172 16173 16174 16175 16176 16177 16178 16179 16180 16181 16182 16183 16184 16185 16186 16187 16188 16189 16190 16191 16192 16193 16194 16195 16196 16197 16198 16199 16200 16201 16202 16203 16204 16205 16206 16207 16208 16209 16210 16211 16212 16213 16214 16215 16216 16217 16218 16219 16220 16221 16222 16223 16224 16225 16226 16227 16228 16229 16230 16231 16232 16233 16234 16235 16236 16237 16238 16239 16240 16241 16242 16243 16244 16245 16246 16247 16248 16249 16250 16251 16252 16253 16254 16255 16256 16257 16258 16259 16260 16261 16262 16263 16264 16265 16266 16267 16268 16269 16270 16271 16272 16273 16274 16275 16276 16277 16278 16279 16280 16281 16282 16283 16284 16285 16286 16287 16288 16289 16290 16291 16292 16293 16294 16295 16296 16297 16298 16299 16300 16301 16302 16303 16304 16305 16306 16307 16308 16309 16310 16311 16312 16313 16314 16315 16316 16317 16318 16319 16320 16321 16322 16323 16324 16325 16326 16327 16328 16329 16330 16331 16332 16333 16334 16335 16336 16337 16338 16339 16340 16341 16342 16343 16344 16345 16346 16347 16348 16349 16350 16351 16352 16353 16354 16355 16356 16357 16358 16359 16360 16361 16362 16363 16364 16365 16366 16367 16368 16369 16370 16371 16372 16373 16374 16375 16376 16377 16378 16379 16380 16381 16382 16383 16384 16385 16386 16387 16388 16389 16390 16391 16392 16393 16394 16395 16396 16397 16398 16399 16400 16401 16402 16403 16404 16405 16406 16407 16408 16409 16410 16411 16412 16413 16414 16415 16416 16417 16418 16419 16420 16421 16422 16423 16424 16425 16426 16427 16428 16429 16430 16431 16432 16433 16434 16435 16436 16437 16438 16439 16440 16441 16442 16443 16444 16445 16446 16447 16448 16449 16450 16451 16452 16453 16454 16455 16456 16457 16458 16459 16460 16461 16462 16463 16464 16465 16466 16467 16468 16469 16470 16471 16472 16473 16474 16475 16476 16477 16478 16479 16480 16481 16482 16483 16484 16485 16486 16487 16488 16489 16490 16491 16492 16493 16494 16495 16496 16497 16498 16499 16500 16501 16502 16503 16504 16505 16506 16507 16508 16509 16510 16511 16512 16513 16514 16515 16516 16517 16518 16519 16520 16521 16522 16523 16524 16525 16526 16527 16528 16529 16530 16531 16532 16533 16534 16535 16536 16537 16538 16539 16540 16541 16542 16543 16544 16545 16546 16547 16548 16549 16550 16551 16552 16553 16554 16555 16556 16557 16558 16559 16560 16561 16562 16563 16564 16565 16566 16567 16568 16569 16570 16571 16572 16573 16574 16575 16576 16577 16578 16579 16580 16581 16582 16583 16584 16585 16586 16587 16588 16589 16590 16591 16592 16593 16594 16595 16596 16597 16598 16599 16600 16601 16602 16603 16604 16605 16606 16607 16608 16609 16610 16611 16612 16613 16614 16615 16616 16617 16618 16619 16620 16621 16622 16623 16624 16625 16626 16627 16628 16629 16630 16631 16632 16633 16634 16635 16636 16637 16638 16639 16640 16641 16642 16643 16644 16645 16646 16647 16648 16649 16650 16651 16652 16653 16654 16655 16656 16657 16658 16659 16660 16661 16662 16663 16664 16665 16666 16667 16668 16669 16670 16671 16672 16673 16674 16675 16676 16677 16678 16679 16680 16681 16682 16683 16684 16685 16686 16687 16688 16689 16690 16691 16692 16693 16694 16695 16696 16697 16698 16699 16700 16701 16702 16703 16704 16705 16706 16707 16708 16709 16710 16711 16712 16713 16714 16715 16716 16717 16718 16719 16720 16721 16722 16723 16724 16725 16726 16727 16728 16729 16730 16731 16732 16733 16734 16735 16736 16737 16738 16739 16740 16741 16742 16743 16744 16745 16746 16747 16748 16749 16750 16751 16752 16753 16754 16755 16756 16757 16758 16759 16760 16761 16762 16763 16764 16765 16766 16767 16768 16769 16770 16771 16772 16773 16774 16775 16776 16777 16778 16779 16780 16781 16782 16783 16784 16785 16786 16787 16788 16789 16790 16791 16792 16793 16794 16795 16796 16797 16798 16799 16800 16801 16802 16803 16804 16805 16806 16807 16808 16809 16810 16811 16812 16813 16814 16815 16816 16817 16818 16819 16820 16821 16822 16823 16824 16825 16826 16827 16828 16829 16830 16831 16832 16833 16834 16835 16836 16837 16838 16839 16840 16841 16842 16843 16844 16845 16846 16847 16848 16849 16850 16851 16852 16853 16854 16855 16856 16857 16858 16859 16860 16861 16862 16863 16864 16865 16866 16867 16868 16869 16870 16871 16872 16873 16874 16875 16876 16877 16878 16879 16880 16881 16882 16883 16884 16885 16886 16887 16888 16889 16890 16891 16892 16893 16894 16895 16896 16897 16898 16899 16900 16901 16902 16903 16904 16905 16906 16907 16908 16909 16910 16911 16912 16913 16914 16915 16916 16917 16918 16919 16920 16921 16922 16923 16924 16925 16926 16927 16928 16929 16930 16931 16932 16933 16934 16935 16936 16937 16938 16939 16940 16941 16942 16943 16944 16945 16946 16947 16948 16949 16950 16951 16952 16953 16954 16955 16956 16957 16958 16959 16960 16961 16962 16963 16964 16965 16966 16967 16968 16969 16970 16971 16972 16973 16974 16975 16976 16977 16978 16979 16980 16981 16982 16983 16984 16985 16986 16987 16988 16989 16990 16991 16992 16993 16994 16995 16996 16997 16998 16999 17000 17001 17002 17003 17004 17005 17006 17007 17008 17009 17010 17011 17012 17013 17014 17015 17016 17017 17018 17019 17020 17021 17022 17023 17024 17025 17026 17027 17028 17029 17030 17031 17032 17033 17034 17035 17036 17037 17038 17039 17040 17041 17042 17043 17044 17045 17046 17047 17048 17049 17050 17051 17052 17053 17054 17055 17056 17057 17058 17059 17060 17061 17062 17063 17064 17065 17066 17067 17068 17069 17070 17071 17072 17073 17074 17075 17076 17077 17078 17079 17080 17081 17082 17083 17084 17085 17086 17087 17088 17089 17090 17091 17092 17093 17094 17095 17096 17097 17098 17099 17100 17101 17102 17103 17104 17105 17106 17107 17108 17109 17110 17111 17112 17113 17114 17115 17116 17117 17118 17119 17120 17121 17122 17123 17124 17125 17126 17127 17128 17129 17130 17131 17132 17133 17134 17135 17136 17137 17138 17139 17140 17141 17142 17143 17144 17145 17146 17147 17148 17149 17150 17151 17152 17153 17154 17155 17156 17157 17158 17159 17160 17161 17162 17163 17164 17165 17166 17167 17168 17169 17170 17171 17172 17173 17174 17175 17176 17177 17178 17179 17180 17181 17182 17183 17184 17185 17186 17187 17188 17189 17190 17191 17192 17193 17194 17195 17196 17197 17198 17199 17200 17201 17202 17203 17204 17205 17206 17207 17208 17209 17210 17211 17212 17213 17214 17215 17216 17217 17218 17219 17220 17221 17222 17223 17224 17225 17226 17227 17228 17229 17230 17231 17232 17233 17234 17235 17236 17237 17238 17239 17240 17241 17242 17243 17244 17245 17246 17247 17248 17249 17250 17251 17252 17253 17254 17255 17256 17257 17258 17259 17260 17261 17262 17263 17264 17265 17266 17267 17268 17269 17270 17271 17272 17273 17274 17275 17276 17277 17278 17279 17280 17281 17282 17283 17284 17285 17286 17287 17288 17289 17290 17291 17292 17293 17294 17295 17296 17297 17298 17299 17300 17301 17302 17303 17304 17305 17306 17307 17308 17309 17310 17311 17312 17313 17314 17315 17316 17317 17318 17319 17320 17321 17322 17323 17324 17325 17326 17327 17328 17329 17330 17331 17332 17333 17334 17335 17336 17337 17338 17339 17340 17341 17342 17343 17344 17345 17346 17347 17348 17349 17350 17351 17352 17353 17354 17355 17356 17357 17358 17359 17360 17361 17362 17363 17364 17365 17366 17367 17368 17369 17370 17371 17372 17373 17374 17375 17376 17377 17378 17379 17380 17381 17382 17383 17384 17385 17386 17387 17388 17389 17390 17391 17392 17393 17394 17395 17396 17397 17398 17399 17400 17401 17402 17403 17404 17405 17406 17407 17408 17409 17410 17411 17412 17413 17414 17415 17416 17417 17418 17419 17420 17421 17422 17423 17424 17425 17426 17427 17428 17429 17430 17431 17432 17433 17434 17435 17436 17437 17438 17439 17440 17441 17442 17443 17444 17445 17446 17447 17448 17449 17450 17451 17452 17453 17454 17455 17456 17457 17458 17459 17460 17461 17462 17463 17464 17465 17466 17467 17468 17469 17470 17471 17472 17473 17474 17475 17476 17477 17478 17479 17480 17481 17482 17483 17484 17485 17486 17487 17488 17489 17490 17491 17492 17493 17494 17495 17496 17497 17498 17499 17500 17501 17502 17503 17504 17505 17506 17507 17508 17509 17510 17511 17512 17513 17514 17515 17516 17517 17518 17519 17520 17521 17522 17523 17524 17525 17526 17527 17528 17529 17530 17531 17532 17533 17534 17535 17536 17537 17538 17539 17540 17541 17542 17543 17544 17545 17546 17547 17548 17549 17550 17551 17552 17553 17554 17555 17556 17557 17558 17559 17560 17561 17562 17563 17564 17565 17566 17567 17568 17569 17570 17571 17572 17573 17574 17575 17576 17577 17578 17579 17580 17581 17582 17583 17584 17585 17586 17587 17588 17589 17590 17591 17592 17593 17594 17595 17596 17597 17598 17599 17600 17601 17602 17603 17604 17605 17606 17607 17608 17609 17610 17611 17612 17613 17614 17615 17616 17617 17618 17619 17620 17621 17622 17623 17624 17625 17626 17627 17628 17629 17630 17631 17632 17633 17634 17635 17636 17637 17638 17639 17640 17641 17642 17643 17644 17645 17646 17647 17648 17649 17650 17651 17652 17653 17654 17655 17656 17657 17658 17659 17660 17661 17662 17663 17664 17665 17666 17667 17668 17669 17670 17671 17672 17673 17674 17675 17676 17677 17678 17679 17680 17681 17682 17683 17684 17685 17686 17687 17688 17689 17690 17691 17692 17693 17694 17695 17696 17697 17698 17699 17700 17701 17702 17703 17704 17705 17706 17707 17708 17709 17710 17711 17712 17713 17714 17715 17716 17717 17718 17719 17720 17721 17722 17723 17724 17725 17726 17727 17728 17729 17730 17731 17732 17733 17734 17735 17736 17737 17738 17739 17740 17741 17742 17743 17744 17745 17746 17747 17748 17749 17750 17751 17752 17753 17754 17755 17756 17757 17758 17759 17760 17761 17762 17763 17764 17765 17766 17767 17768 17769 17770 17771 17772 17773 17774 17775 17776 17777 17778 17779 17780 17781 17782 17783 17784 17785 17786 17787 17788 17789 17790 17791 17792 17793 17794 17795 17796 17797 17798 17799 17800 17801 17802 17803 17804 17805 17806 17807 17808 17809 17810 17811 17812 17813 17814 17815 17816 17817 17818 17819 17820 17821 17822 17823 17824 17825 17826 17827 17828 17829 17830 17831 17832 17833 17834 17835 17836 17837 17838 17839 17840 17841 17842 17843 17844 17845 17846 17847 17848 17849 17850 17851 17852 17853 17854 17855 17856 17857 17858 17859 17860 17861 17862 17863 17864 17865 17866 17867 17868 17869 17870 17871 17872 17873 17874 17875 17876 17877 17878 17879 17880 17881 17882 17883 17884 17885 17886 17887 17888 17889 17890 17891 17892 17893 17894 17895 17896 17897 17898 17899 17900 17901 17902 17903 17904 17905 17906 17907 17908 17909 17910 17911 17912 17913 17914 17915 17916 17917 17918 17919 17920 17921 17922 17923 17924 17925 17926 17927 17928 17929 17930 17931 17932 17933 17934 17935 17936 17937 17938 17939 17940 17941 17942 17943 17944 17945 17946 17947 17948 17949 17950 17951 17952 17953 17954 17955 17956 17957 17958 17959 17960 17961 17962 17963 17964 17965 17966 17967 17968 17969 17970 17971 17972 17973 17974 17975 17976 17977 17978 17979 17980 17981 17982 17983 17984 17985 17986 17987 17988 17989 17990 17991 17992 17993 17994 17995 17996 17997 17998 17999 18000 18001 18002 18003 18004 18005 18006 18007 18008 18009 18010 18011 18012 18013 18014 18015 18016 18017 18018 18019 18020 18021 18022 18023 18024 18025 18026 18027 18028 18029 18030 18031 18032 18033 18034 18035 18036 18037 18038 18039 18040 18041 18042 18043 18044 18045 18046 18047 18048 18049 18050 18051 18052 18053 18054 18055 18056 18057 18058 18059 18060 18061 18062 18063 18064 18065 18066 18067 18068 18069 18070 18071 18072 18073 18074 18075 18076 18077 18078 18079 18080 18081 18082 18083 18084 18085 18086 18087 18088 18089 18090 18091 18092 18093 18094 18095 18096 18097 18098 18099 18100 18101 18102 18103 18104 18105 18106 18107 18108 18109 18110 18111 18112 18113 18114 18115 18116 18117 18118 18119 18120 18121 18122 18123 18124 18125 18126 18127 18128 18129 18130 18131 18132 18133 18134 18135 18136 18137 18138 18139 18140 18141 18142 18143 18144 18145 18146 18147 18148 18149 18150 18151 18152 18153 18154 18155 18156 18157 18158 18159 18160 18161 18162 18163 18164 18165 18166 18167 18168 18169 18170 18171 18172 18173 18174 18175 18176 18177 18178 18179 18180 18181 18182 18183 18184 18185 18186 18187 18188 18189 18190 18191 18192 18193 18194 18195 18196 18197 18198 18199 18200 18201 18202 18203 18204 18205 18206 18207 18208 18209 18210 18211 18212 18213 18214 18215 18216 18217 18218 18219 18220 18221 18222 18223 18224 18225 18226 18227 18228 18229 18230 18231 18232 18233 18234 18235 18236 18237 18238 18239 18240 18241 18242 18243 18244 18245 18246 18247 18248 18249 18250 18251 18252 18253 18254 18255 18256 18257 18258 18259 18260 18261 18262 18263 18264 18265 18266 18267 18268 18269 18270 18271 18272 18273 18274 18275 18276 18277 18278 18279 18280 18281 18282 18283 18284 18285 18286 18287 18288 18289 18290 18291 18292 18293 18294 18295 18296 18297 18298 18299 18300 18301 18302 18303 18304 18305 18306 18307 18308 18309 18310 18311 18312 18313 18314 18315 18316 18317 18318 18319 18320 18321 18322 18323 18324 18325 18326 18327 18328 18329 18330 18331 18332 18333 18334 18335 18336 18337 18338 18339 18340 18341 18342 18343 18344 18345 18346 18347 18348 18349 18350 18351 18352 18353 18354 18355 18356 18357 18358 18359 18360 18361 18362 18363 18364 18365 18366 18367 18368 18369 18370 18371 18372 18373 18374 18375 18376 18377 18378 18379 18380 18381 18382 18383 18384 18385 18386 18387 18388 18389 18390 18391 18392 18393 18394 18395 18396 18397 18398 18399 18400 18401 18402 18403 18404 18405 18406 18407 18408 18409 18410 18411 18412 18413 18414 18415 18416 18417 18418 18419 18420 18421 18422 18423 18424 18425 18426 18427 18428 18429 18430 18431 18432 18433 18434 18435 18436 18437 18438 18439 18440 18441 18442 18443 18444 18445 18446 18447 18448 18449 18450 18451 18452 18453 18454 18455 18456 18457 18458 18459 18460 18461 18462 18463 18464 18465 18466 18467 18468 18469 18470 18471 18472 18473 18474 18475 18476 18477 18478 18479 18480 18481 18482 18483 18484 18485 18486 18487 18488 18489 18490 18491 18492 18493 18494 18495 18496 18497 18498 18499 18500 18501 18502 18503 18504 18505 18506 18507 18508 18509 18510 18511 18512 18513 18514 18515 18516 18517 18518 18519 18520 18521 18522 18523 18524 18525 18526 18527 18528 18529 18530 18531 18532 18533 18534 18535 18536 18537 18538 18539 18540 18541 18542 18543 18544 18545 18546 18547 18548 18549 18550 18551 18552 18553 18554 18555 18556 18557 18558 18559 18560 18561 18562 18563 18564 18565 18566 18567 18568 18569 18570 18571 18572 18573 18574 18575 18576 18577 18578 18579 18580 18581 18582 18583 18584 18585 18586 18587 18588 18589 18590 18591 18592 18593 18594 18595 18596 18597 18598 18599 18600 18601 18602 18603 18604 18605 18606 18607 18608 18609 18610 18611 18612 18613 18614 18615 18616 18617 18618 18619 18620 18621 18622 18623 18624 18625 18626 18627 18628 18629 18630 18631 18632 18633 18634 18635 18636 18637 18638 18639 18640 18641 18642 18643 18644 18645 18646 18647 18648 18649 18650 18651 18652 18653 18654 18655 18656 18657 18658 18659 18660 18661 18662 18663 18664 18665 18666 18667 18668 18669 18670 18671 18672 18673 18674 18675 18676 18677 18678 18679 18680 18681 18682 18683 18684 18685 18686 18687 18688 18689 18690 18691 18692 18693 18694 18695 18696 18697 18698 18699 18700 18701 18702 18703 18704 18705 18706 18707 18708 18709 18710 18711 18712 18713 18714 18715 18716 18717 18718 18719 18720 18721 18722 18723 18724 18725 18726 18727 18728 18729 18730 18731 18732 18733 18734 18735 18736 18737 18738 18739 18740 18741 18742 18743 18744 18745 18746 18747 18748 18749 18750 18751 18752 18753 18754 18755 18756 18757 18758 18759 18760 18761 18762 18763 18764 18765 18766 18767 18768 18769 18770 18771 18772 18773 18774 18775 18776 18777 18778 18779 18780 18781 18782 18783 18784 18785 18786 18787 18788 18789 18790 18791 18792 18793 18794 18795 18796 18797 18798 18799 18800 18801 18802 18803 18804 18805 18806 18807 18808 18809 18810 18811 18812 18813 18814 18815 18816 18817 18818 18819 18820 18821 18822 18823 18824 18825 18826 18827 18828 18829 18830 18831 18832 18833 18834 18835 18836 18837 18838 18839 18840 18841 18842 18843 18844 18845 18846 18847 18848 18849 18850 18851 18852 18853 18854 18855 18856 18857 18858 18859 18860 18861 18862 18863 18864 18865 18866 18867 18868 18869 18870 18871 18872 18873 18874 18875 18876 18877 18878 18879 18880 18881 18882 18883 18884 18885 18886 18887 18888 18889 18890 18891 18892 18893 18894 18895 18896 18897 18898 18899 18900 18901 18902 18903 18904 18905 18906 18907 18908 18909 18910 18911 18912 18913 18914 18915 18916 18917 18918 18919 18920 18921 18922 18923 18924 18925 18926 18927 18928 18929 18930 18931 18932 18933 18934 18935 18936 18937 18938 18939 18940 18941 18942 18943 18944 18945 18946 18947 18948 18949 18950 18951 18952 18953 18954 18955 18956 18957 18958 18959 18960 18961 18962 18963 18964 18965 18966 18967 18968 18969 18970 18971 18972 18973 18974 18975 18976 18977 18978 18979 18980 18981 18982 18983 18984 18985 18986 18987 18988 18989 18990 18991 18992 18993 18994 18995 18996 18997 18998 18999 19000 19001 19002 19003 19004 19005 19006 19007 19008 19009 19010 19011 19012 19013 19014 19015 19016 19017 19018 19019 19020 19021 19022 19023 19024 19025 19026 19027 19028 19029 19030 19031 19032 19033 19034 19035 19036 19037 19038 19039 19040 19041 19042 19043 19044 19045 19046 19047 19048 19049 19050 19051 19052 19053 19054 19055 19056 19057 19058 19059 19060 19061 19062 19063 19064 19065 19066 19067 19068 19069 19070 19071 19072 19073 19074 19075 19076 19077 19078 19079 19080 19081 19082 19083 19084 19085 19086 19087 19088 19089 19090 19091 19092 19093 19094 19095 19096 19097 19098 19099 19100 19101 19102 19103 19104 19105 19106 19107 19108 19109 19110 19111 19112 19113 19114 19115 19116 19117 19118 19119 19120 19121 19122 19123 19124 19125 19126 19127 19128 19129 19130 19131 19132 19133 19134 19135 19136 19137 19138 19139 19140 19141 19142 19143 19144 19145 19146 19147 19148 19149 19150 19151 19152 19153 19154 19155 19156 19157 19158 19159 19160 19161 19162 19163 19164 19165 19166 19167 19168 19169 19170 19171 19172 19173 19174 19175 19176 19177 19178 19179 19180 19181 19182 19183 19184 19185 19186 19187 19188 19189 19190 19191 19192 19193 19194 19195 19196 19197 19198 19199 19200 19201 19202 19203 19204 19205 19206 19207 19208 19209 19210 19211 19212 19213 19214 19215 19216 19217 19218 19219 19220 19221 19222 19223 19224 19225 19226 19227 19228 19229 19230 19231 19232 19233 19234 19235 19236 19237 19238 19239 19240 19241 19242 19243 19244 19245 19246 19247 19248 19249 19250 19251 19252 19253 19254 19255 19256 19257 19258 19259 19260 19261 19262 19263 19264 19265 19266 19267 19268 19269 19270 19271 19272 19273 19274 19275 19276 19277 19278 19279 19280 19281 19282 19283 19284 19285 19286 19287 19288 19289 19290 19291 19292 19293 19294 19295 19296 19297 19298 19299 19300 19301 19302 19303 19304 19305 19306 19307 19308 19309 19310 19311 19312 19313 19314 19315 19316 19317 19318 19319 19320 19321 19322 19323 19324 19325 19326 19327 19328 19329 19330 19331 19332 19333 19334 19335 19336 19337 19338 19339 19340 19341 19342 19343 19344 19345 19346 19347 19348 19349 19350 19351 19352 19353 19354 19355 19356 19357 19358 19359 19360 19361 19362 19363 19364 19365 19366 19367 19368 19369 19370 19371 19372 19373 19374 19375 19376 19377 19378 19379 19380 19381 19382 19383 19384 19385 19386 19387 19388 19389 19390 19391 19392 19393 19394 19395 19396 19397 19398 19399 19400 19401 19402 19403 19404 19405 19406 19407 19408 19409 19410 19411 19412 19413 19414 19415 19416 19417 19418 19419 19420 19421 19422 19423 19424 19425 19426 19427 19428 19429 19430 19431 19432 19433 19434 19435 19436 19437 19438 19439 19440 19441 19442 19443 19444 19445 19446 19447 19448 19449 19450 19451 19452 19453 19454 19455 19456 19457 19458 19459 19460 19461 19462 19463 19464 19465 19466 19467 19468 19469 19470 19471 19472 19473 19474 19475 19476 19477 19478 19479 19480 19481 19482 19483 19484 19485 19486 19487 19488 19489 19490 19491 19492 19493 19494 19495 19496 19497 19498 19499 19500 19501 19502 19503 19504 19505 19506 19507 19508 19509 19510 19511 19512 19513 19514 19515 19516 19517 19518 19519 19520 19521 19522 19523 19524 19525 19526 19527 19528 19529 19530 19531 19532 19533 19534 19535 19536 19537 19538 19539 19540 19541 19542 19543 19544 19545 19546 19547 19548 19549 19550 19551 19552 19553 19554 19555 19556 19557 19558 19559 19560 19561 19562 19563 19564 19565 19566 19567 19568 19569 19570 19571 19572 19573 19574 19575 19576 19577 19578 19579 19580 19581 19582 19583 19584 19585 19586 19587 19588 19589 19590 19591 19592 19593 19594 19595 19596 19597 19598 19599 19600 19601 19602 19603 19604 19605 19606 19607 19608 19609 19610 19611 19612 19613 19614 19615 19616 19617 19618 19619 19620 19621 19622 19623 19624 19625 19626 19627 19628 19629 19630 19631 19632 19633 19634 19635 19636 19637 19638 19639 19640 19641 19642 19643 19644 19645 19646 19647 19648 19649 19650 19651 19652 19653 19654 19655 19656 19657 19658 19659 19660 19661 19662 19663 19664 19665 19666 19667 19668 19669 19670 19671 19672 19673 19674 19675 19676 19677 19678 19679 19680 19681 19682 19683 19684 19685 19686 19687 19688 19689 19690 19691 19692 19693 19694 19695 19696 19697 19698 19699 19700 19701 19702 19703 19704 19705 19706 19707 19708 19709 19710 19711 19712 19713 19714 19715 19716 19717 19718 19719 19720 19721 19722 19723 19724 19725 19726 19727 19728 19729 19730 19731 19732 19733 19734 19735 19736 19737 19738 19739 19740 19741 19742 19743 19744 19745 19746 19747 19748 19749 19750 19751 19752 19753 19754 19755 19756 19757 19758 19759 19760 19761 19762 19763 19764 19765 19766 19767 19768 19769 19770 19771 19772 19773 19774 19775 19776 19777 19778 19779 19780 19781 19782 19783 19784 19785 19786 19787 19788 19789 19790 19791 19792 19793 19794 19795 19796 19797 19798 19799 19800 19801 19802 19803 19804 19805 19806 19807 19808 19809 19810 19811 19812 19813 19814 19815 19816 19817 19818 19819 19820 19821 19822 19823 19824 19825 19826 19827 19828 19829 19830 19831 19832 19833 19834 19835 19836 19837 19838 19839 19840 19841 19842 19843 19844 19845 19846 19847 19848 19849 19850 19851 19852 19853 19854 19855 19856 19857 19858 19859 19860 19861 19862 19863 19864 19865 19866 19867 19868 19869 19870 19871 19872 19873 19874 19875 19876 19877 19878 19879 19880 19881 19882 19883 19884 19885 19886 19887 19888 19889 19890 19891 19892 19893 19894 19895 19896 19897 19898 19899 19900 19901 19902 19903 19904 19905 19906 19907 19908 19909 19910 19911 19912 19913 19914 19915 19916 19917 19918 19919 19920 19921 19922 19923 19924 19925 19926 19927 19928 19929 19930 19931 19932 19933 19934 19935 19936 19937 19938 19939 19940 19941 19942 19943 19944 19945 19946 19947 19948 19949 19950 19951 19952 19953 19954 19955 19956 19957 19958 19959 19960 19961 19962 19963 19964 19965 19966 19967 19968 19969 19970 19971 19972 19973 19974 19975 19976 19977 19978 19979 19980 19981 19982 19983 19984 19985 19986 19987 19988 19989 19990 19991 19992 19993 19994 19995 19996 19997 19998 19999 20000 20001 20002 20003 20004 20005 20006 20007 20008 20009 20010 20011 20012 20013 20014 20015 20016 20017 20018 20019 20020 20021 20022 20023 20024 20025 20026 20027 20028 20029 20030 20031 20032 20033 20034 20035 20036 20037 20038 20039 20040 20041 20042 20043 20044 20045 20046 20047 20048 20049 20050 20051 20052 20053 20054 20055 20056 20057 20058 20059 20060 20061 20062 20063 20064 20065 20066 20067 20068 20069 20070 20071 20072 20073 20074 20075 20076 20077 20078 20079 20080 20081 20082 20083 20084 20085 20086 20087 20088 20089 20090 20091 20092 20093 20094 20095 20096 20097 20098 20099 20100 20101 20102 20103 20104 20105 20106 20107 20108 20109 20110 20111 20112 20113 20114 20115 20116 20117 20118 20119 20120 20121 20122 20123 20124 20125 20126 20127 20128 20129 20130 20131 20132 20133 20134 20135 20136 20137 20138 20139 20140 20141 20142 20143 20144 20145 20146 20147 20148 20149 20150 20151 20152 20153 20154 20155 20156 20157 20158 20159 20160 20161 20162 20163 20164 20165 20166 20167 20168 20169 20170 20171 20172 20173 20174 20175 20176 20177 20178 20179 20180 20181 20182 20183 20184 20185 20186 20187 20188 20189 20190 20191 20192 20193 20194 20195 20196 20197 20198 20199 20200 20201 20202 20203 20204 20205 20206 20207 20208 20209 20210 20211 20212 20213 20214 20215 20216 20217 20218 20219 20220 20221 20222 20223 20224 20225 20226 20227 20228 20229 20230 20231 20232 20233 20234 20235 20236 20237 20238 20239 20240 20241 20242 20243 20244 20245 20246 20247 20248 20249 20250 20251 20252 20253 20254 20255 20256 20257 20258 20259 20260 20261 20262 20263 20264 20265 20266 20267 20268 20269 20270 20271 20272 20273 20274 20275 20276 20277 20278 20279 20280 20281 20282 20283 20284 20285 20286 20287 20288 20289 20290 20291 20292 20293 20294 20295 20296 20297 20298 20299 20300 20301 20302 20303 20304 20305 20306 20307 20308 20309 20310 20311 20312 20313 20314 20315 20316 20317 20318 20319 20320 20321 20322 20323 20324 20325 20326 20327 20328 20329 20330 20331 20332 20333 20334 20335 20336 20337 20338 20339 20340 20341 20342 20343 20344 20345 20346 20347 20348 20349 20350 20351 20352 20353 20354 20355 20356 20357 20358 20359 20360 20361 20362 20363 20364 20365 20366 20367 20368 20369 20370 20371 20372 20373 20374 20375 20376 20377 20378 20379 20380 20381 20382 20383 20384 20385 20386 20387 20388 20389 20390 20391 20392 20393 20394 20395 20396 20397 20398 20399 20400 20401 20402 20403 20404 20405 20406 20407 20408 20409 20410 20411 20412 20413 20414 20415 20416 20417 20418 20419 20420 20421 20422 20423 20424 20425 20426 20427 20428 20429 20430 20431 20432 20433 20434 20435 20436 20437 20438 20439 20440 20441 20442 20443 20444 20445 20446 20447 20448 20449 20450 20451 20452 20453 20454 20455 20456 20457 20458 20459 20460 20461 20462 20463 20464 20465 20466 20467 20468 20469 20470 20471 20472 20473 20474 20475 20476 20477 20478 20479 20480 20481 20482 20483 20484 20485 20486 20487 20488 20489 20490 20491 20492 20493 20494 20495 20496 20497 20498 20499 20500 20501 20502 20503 20504 20505 20506 20507 20508 20509 20510 20511 20512 20513 20514 20515 20516 20517 20518 20519 20520 20521 20522 20523 20524 20525 20526 20527 20528 20529 20530 20531 20532 20533 20534 20535 20536 20537 20538 20539 20540 20541 20542 20543 20544 20545 20546 20547 20548 20549 20550 20551 20552 20553 20554 20555 20556 20557 20558 20559 20560 20561 20562 20563 20564 20565 20566 20567 20568 20569 20570 20571 20572 20573 20574 20575 20576 20577 20578 20579 20580 20581 20582 20583 20584 20585 20586 20587 20588 20589 20590 20591 20592 20593 20594 20595 20596 20597 20598 20599 20600 20601 20602 20603 20604 20605 20606 20607 20608 20609 20610 20611 20612 20613 20614 20615 20616 20617 20618 20619 20620 20621 20622 20623 20624 20625 20626 20627 20628 20629 20630 20631 20632 20633 20634 20635 20636 20637 20638 20639 20640 20641 20642 20643 20644 20645 20646 20647 20648 20649 20650 20651 20652 20653 20654 20655 20656 20657 20658 20659 20660 20661 20662 20663 20664 20665 20666 20667 20668 20669 20670 20671 20672 20673 20674 20675 20676 20677 20678 20679 20680 20681 20682 20683 20684 20685 20686 20687 20688 20689 20690 20691 20692 20693 20694 20695 20696 20697 20698 20699 20700 20701 20702 20703 20704 20705 20706 20707 20708 20709 20710 20711 20712 20713 20714 20715 20716 20717 20718 20719 20720 20721 20722 20723 20724 20725 20726 20727 20728 20729 20730 20731 20732 20733 20734 20735 20736 20737 20738 20739 20740 20741 20742 20743 20744 20745 20746 20747 20748 20749 20750 20751 20752 20753 20754 20755 20756 20757 20758 20759 20760 20761 20762 20763 20764 20765 20766 20767 20768 20769 20770 20771 20772 20773 20774 20775 20776 20777 20778 20779 20780 20781 20782 20783 20784 20785 20786 20787 20788 20789 20790 20791 20792 20793 20794 20795 20796 20797 20798 20799 20800 20801 20802 20803 20804 20805 20806 20807 20808 20809 20810 20811 20812 20813 20814 20815 20816 20817 20818 20819 20820 20821 20822 20823 20824 20825 20826 20827 20828 20829 20830 20831 20832 20833 20834 20835 20836 20837 20838 20839 20840 20841 20842 20843 20844 20845 20846 20847 20848 20849 20850 20851 20852 20853 20854 20855 20856 20857 20858 20859 20860 20861 20862 20863 20864 20865 20866 20867 20868 20869 20870 20871 20872 20873 20874 20875 20876 20877 20878 20879 20880 20881 20882 20883 20884 20885 20886 20887 20888 20889 20890 20891 20892 20893 20894 20895 20896 20897 20898 20899 20900 20901 20902 20903 20904 20905 20906 20907 20908 20909 20910 20911 20912 20913 20914 20915 20916 20917 20918 20919 20920 20921 20922 20923 20924 20925 20926 20927 20928 20929 20930 20931 20932 20933 20934 20935 20936 20937 20938 20939 20940 20941 20942 20943 20944 20945 20946 20947 20948 20949 20950 20951 20952 20953 20954 20955 20956 20957 20958 20959 20960 20961 20962 20963 20964 20965 20966 20967 20968 20969 20970 20971 20972 20973 20974 20975 20976 20977 20978 20979 20980 20981 20982 20983 20984 20985 20986 20987 20988 20989 20990 20991 20992 20993 20994 20995 20996 20997 20998 20999 21000 21001 21002 21003 21004 21005 21006 21007 21008 21009 21010 21011 21012 21013 21014 21015 21016 21017 21018 21019 21020 21021 21022 21023 21024 21025 21026 21027 21028 21029 21030 21031 21032 21033 21034 21035 21036 21037 21038 21039 21040 21041 21042 21043 21044 21045 21046 21047 21048 21049 21050 21051 21052 21053 21054 21055 21056 21057 21058 21059 21060 21061 21062 21063 21064 21065 21066 21067 21068 21069 21070 21071 21072 21073 21074 21075 21076 21077 21078 21079 21080 21081 21082 21083 21084 21085 21086 21087 21088 21089 21090 21091 21092 21093 21094 21095 21096 21097 21098 21099 21100 21101 21102 21103 21104 21105 21106 21107 21108 21109 21110 21111 21112 21113 21114 21115 21116 21117 21118 21119 21120 21121 21122 21123 21124 21125 21126 21127 21128 21129 21130 21131 21132 21133 21134 21135 21136 21137 21138 21139 21140 21141 21142 21143 21144 21145 21146 21147 21148 21149 21150 21151 21152 21153 21154 21155 21156 21157 21158 21159 21160 21161 21162 21163 21164 21165 21166 21167 21168 21169 21170 21171 21172 21173 21174 21175 21176 21177 21178 21179 21180 21181 21182 21183 21184 21185 21186 21187 21188 21189 21190 21191 21192 21193 21194 21195 21196 21197 21198 21199 21200 21201 21202 21203 21204 21205 21206 21207 21208 21209 21210 21211 21212 21213 21214 21215 21216 21217 21218 21219 21220 21221 21222 21223 21224 21225 21226 21227 21228 21229 21230 21231 21232 21233 21234 21235 21236 21237 21238 21239 21240 21241 21242 21243 21244 21245 21246 21247 21248 21249 21250 21251 21252 21253 21254 21255 21256 21257 21258 21259 21260 21261 21262 21263 21264 21265 21266 21267 21268 21269 21270 21271 21272 21273 21274 21275 21276 21277 21278 21279 21280 21281 21282 21283 21284 21285 21286 21287 21288 21289 21290 21291 21292 21293 21294 21295 21296 21297 21298 21299 21300 21301 21302 21303 21304 21305 21306 21307 21308 21309 21310 21311 21312 21313 21314 21315 21316 21317 21318 21319 21320 21321 21322 21323 21324 21325 21326 21327 21328 21329 21330 21331 21332 21333 21334 21335 21336 21337 21338 21339 21340 21341 21342 21343 21344 21345 21346 21347 21348 21349 21350 21351 21352 21353 21354 21355 21356 21357 21358 21359 21360 21361 21362 21363 21364 21365 21366 21367 21368 21369 21370 21371 21372 21373 21374 21375 21376 21377 21378 21379 21380 21381 21382 21383 21384 21385 21386 21387 21388 21389 21390 21391 21392 21393 21394 21395 21396 21397 21398 21399 21400 21401 21402 21403 21404 21405 21406 21407 21408 21409 21410 21411 21412 21413 21414 21415 21416 21417 21418 21419 21420 21421 21422 21423 21424 21425 21426 21427 21428 21429 21430 21431 21432 21433 21434 21435 21436 21437 21438 21439 21440 21441 21442 21443 21444 21445 21446 21447 21448 21449 21450 21451 21452 21453 21454 21455 21456 21457 21458 21459 21460 21461 21462 21463 21464 21465 21466 21467 21468 21469 21470 21471 21472 21473 21474 21475 21476 21477 21478 21479 21480 21481 21482 21483 21484 21485 21486 21487 21488 21489 21490 21491 21492 21493 21494 21495 21496 21497 21498 21499 21500 21501 21502 21503 21504 21505 21506 21507 21508 21509 21510 21511 21512 21513 21514 21515 21516 21517 21518 21519 21520 21521 21522 21523 21524 21525 21526 21527 21528 21529 21530 21531 21532 21533 21534 21535 21536 21537 21538 21539 21540 21541 21542 21543 21544 21545 21546 21547 21548 21549 21550 21551 21552 21553 21554 21555 21556 21557 21558 21559 21560 21561 21562 21563 21564 21565 21566 21567 21568 21569 21570 21571 21572 21573 21574 21575 21576 21577 21578 21579 21580 21581 21582 21583 21584 21585 21586 21587 21588 21589 21590 21591 21592 21593 21594 21595 21596 21597 21598 21599 21600 21601 21602 21603 21604 21605 21606 21607 21608 21609 21610 21611 21612 21613 21614 21615 21616 21617 21618 21619 21620 21621 21622 21623 21624 21625 21626 21627 21628 21629 21630 21631 21632 21633 21634 21635 21636 21637 21638 21639 21640 21641 21642 21643 21644 21645 21646 21647 21648 21649 21650 21651 21652 21653 21654 21655 21656 21657 21658 21659 21660 21661 21662 21663 21664 21665 21666 21667 21668 21669 21670 21671 21672 21673 21674 21675 21676 21677 21678 21679 21680 21681 21682 21683 21684 21685 21686 21687 21688 21689 21690 21691 21692 21693 21694 21695 21696 21697 21698 21699 21700 21701 21702 21703 21704 21705 21706 21707 21708 21709 21710 21711 21712 21713 21714 21715 21716 21717 21718 21719 21720 21721 21722 21723 21724 21725 21726 21727 21728 21729 21730 21731 21732 21733 21734 21735 21736 21737 21738 21739 21740 21741 21742 21743 21744 21745 21746 21747 21748 21749 21750 21751 21752 21753 21754 21755 21756 21757 21758 21759 21760 21761 21762 21763 21764 21765 21766 21767 21768 21769 21770 21771 21772 21773 21774 21775 21776 21777 21778 21779 21780 21781 21782 21783 21784 21785 21786 21787 21788 21789 21790 21791 21792 21793 21794 21795 21796 21797 21798 21799 21800 21801 21802 21803 21804 21805 21806 21807 21808 21809 21810 21811 21812 21813 21814 21815 21816 21817 21818 21819 21820 21821 21822 21823 21824 21825 21826 21827 21828 21829 21830 21831 21832 21833 21834 21835 21836 21837 21838 21839 21840 21841 21842 21843 21844 21845 21846 21847 21848 21849 21850 21851 21852 21853 21854 21855 21856 21857 21858 21859 21860 21861 21862 21863 21864 21865 21866 21867 21868 21869 21870 21871 21872 21873 21874 21875 21876 21877 21878 21879 21880 21881 21882 21883 21884 21885 21886 21887 21888 21889 21890 21891 21892 21893 21894 21895 21896 21897 21898 21899 21900 21901 21902 21903 21904 21905 21906 21907 21908 21909 21910 21911 21912 21913 21914 21915 21916 21917 21918 21919 21920 21921 21922 21923 21924 21925 21926 21927 21928 21929 21930 21931 21932 21933 21934 21935 21936 21937 21938 21939 21940 21941 21942 21943 21944 21945 21946 21947 21948 21949 21950 21951 21952 21953 21954 21955 21956 21957 21958 21959 21960 21961 21962 21963 21964 21965 21966 21967 21968 21969 21970 21971 21972 21973 21974 21975 21976 21977 21978 21979 21980 21981 21982 21983 21984 21985 21986 21987 21988 21989 21990 21991 21992 21993 21994 21995 21996 21997 21998 21999 22000 22001 22002 22003 22004 22005 22006 22007 22008 22009 22010 22011 22012 22013 22014 22015 22016 22017 22018 22019 22020 22021 22022 22023 22024 22025 22026 22027 22028 22029 22030 22031 22032 22033 22034 22035 22036 22037 22038 22039 22040 22041 22042 22043 22044 22045 22046 22047 22048 22049 22050 22051 22052 22053 22054 22055 22056 22057 22058 22059 22060 22061 22062 22063 22064 22065 22066 22067 22068 22069 22070 22071 22072 22073 22074 22075 22076 22077 22078 22079 22080 22081 22082 22083 22084 22085 22086 22087 22088 22089 22090 22091 22092 22093 22094 22095 22096 22097 22098 22099 22100 22101 22102 22103 22104 22105 22106 22107 22108 22109 22110 22111 22112 22113 22114 22115 22116 22117 22118 22119 22120 22121 22122 22123 22124 22125 22126 22127 22128 22129 22130 22131 22132 22133 22134 22135 22136 22137 22138 22139 22140 22141 22142 22143 22144 22145 22146 22147 22148 22149 22150 22151 22152 22153 22154 22155 22156 22157 22158 22159 22160 22161 22162 22163 22164 22165 22166 22167 22168 22169 22170 22171 22172 22173 22174 22175 22176 22177 22178 22179 22180 22181 22182 22183 22184 22185 22186 22187 22188 22189 22190 22191 22192 22193 22194 22195 22196 22197 22198 22199 22200 22201 22202 22203 22204 22205 22206 22207 22208 22209 22210 22211 22212 22213 22214 22215 22216 22217 22218 22219 22220 22221 22222 22223 22224 22225 22226 22227 22228 22229 22230 22231 22232 22233 22234 22235 22236 22237 22238 22239 22240 22241 22242 22243 22244 22245 22246 22247 22248 22249 22250 22251 22252 22253 22254 22255 22256 22257 22258 22259 22260 22261 22262 22263 22264 22265 22266 22267 22268 22269 22270 22271 22272 22273 22274 22275 22276 22277 22278 22279 22280 22281 22282 22283 22284 22285 22286 22287 22288 22289 22290 22291 22292 22293 22294 22295 22296 22297 22298 22299 22300 22301 22302 22303 22304 22305 22306 22307 22308 22309 22310 22311 22312 22313 22314 22315 22316 22317 22318 22319 22320 22321 22322 22323 22324 22325 22326 22327 22328 22329 22330 22331 22332 22333 22334 22335 22336 22337 22338 22339 22340 22341 22342 22343 22344 22345 22346 22347 22348 22349 22350 22351 22352 22353 22354 22355 22356 22357 22358 22359 22360 22361 22362 22363 22364 22365 22366 22367 22368 22369 22370 22371 22372 22373 22374 22375 22376 22377 22378 22379 22380 22381 22382 22383 22384 22385 22386 22387 22388 22389 22390 22391 22392 22393 22394 22395 22396 22397 22398 22399 22400 22401 22402 22403 22404 22405 22406 22407 22408 22409 22410 22411 22412 22413 22414 22415 22416 22417 22418 22419 22420 22421 22422 22423 22424 22425 22426 22427 22428 22429 22430 22431 22432 22433 22434 22435 22436 22437 22438 22439 22440 22441 22442 22443 22444 22445 22446 22447 22448 22449 22450 22451 22452 22453 22454 22455 22456 22457 22458 22459 22460 22461 22462 22463 22464 22465 22466 22467 22468 22469 22470 22471 22472 22473 22474 22475 22476 22477 22478 22479 22480 22481 22482 22483 22484 22485 22486 22487 22488 22489 22490 22491 22492 22493 22494 22495 22496 22497 22498 22499 22500 22501 22502 22503 22504 22505 22506 22507 22508 22509 22510 22511 22512 22513 22514 22515 22516 22517 22518 22519 22520 22521 22522 22523 22524 22525 22526 22527 22528 22529 22530 22531 22532 22533 22534 22535 22536 22537 22538 22539 22540 22541 22542 22543 22544 22545 22546 22547 22548 22549 22550 22551 22552 22553 22554 22555 22556 22557 22558 22559 22560 22561 22562 22563 22564 22565 22566 22567 22568 22569 22570 22571 22572 22573 22574 22575 22576 22577 22578 22579 22580 22581 22582 22583 22584 22585 22586 22587 22588 22589 22590 22591 22592 22593 22594 22595 22596 22597 22598 22599 22600 22601 22602 22603 22604 22605 22606 22607 22608 22609 22610 22611 22612 22613 22614 22615 22616 22617 22618 22619 22620 22621 22622 22623 22624 22625 22626 22627 22628 22629 22630 22631 22632 22633 22634 22635 22636 22637 22638 22639 22640 22641 22642 22643 22644 22645 22646 22647 22648 22649 22650 22651 22652 22653 22654 22655 22656 22657 22658 22659 22660 22661 22662 22663 22664 22665 22666 22667 22668 22669 22670 22671 22672 22673 22674 22675 22676 22677 22678 22679 22680 22681 22682 22683 22684 22685 22686 22687 22688 22689 22690 22691 22692 22693 22694 22695 22696 22697 22698 22699 22700 22701 22702 22703 22704 22705 22706 22707 22708 22709 22710 22711 22712 22713 22714 22715 22716 22717 22718 22719 22720 22721 22722 22723 22724 22725 22726 22727 22728 22729 22730 22731 22732 22733 22734 22735 22736 22737 22738 22739 22740 22741 22742 22743 22744 22745 22746 22747 22748 22749 22750 22751 22752 22753 22754 22755 22756 22757 22758 22759 22760 22761 22762 22763 22764 22765 22766 22767 22768 22769 22770 22771 22772 22773 22774 22775 22776 22777 22778 22779 22780
|
2010-06-21 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[PNG decoder] direct access to jmpbuf is deprecated in libpng >= 1.4.0beta103
https://bugs.webkit.org/show_bug.cgi?id=40907
Define a JMPBUF macro to cope with deprecation of the jmpbuf
attribute in libpng >= 1.4.
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
2010-11-30 Huzaifa Sidhpurwala <huzaifas@redhat.com>
Backport crash fix for
https://bugs.webkit.org/show_bug.cgi?id=45611
Prevent block logical height of a root inline box from overflowing by clamping it
at INT_MAX. Otherwise, we will not be able to properly dirty the set of lines during
removal a floating object.
Test: fast/overflow/overflow-block-logical-height-crash.html
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
2010-08-25 Cris Neckar <cdn@chromium.org>
Reviewed by Darin Adler.
Added abort condition for RenderCounters when traversing a detached render tree.
https://bugs.webkit.org/show_bug.cgi?id=43812
Test: fast/css/counters/counter-traverse-object-crash.html
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
2010-08-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Fix security origin calculation in createPattern. Need to use
cachedImage->response().url() instead of cachedImage->url().
https://bugs.webkit.org/show_bug.cgi?id=44399.
Test: http/tests/security/canvas-remote-read-remote-image-redirect.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
crash when trying to access a stale Node pointer in FocusController::setFocusedNode
https://bugs.webkit.org/show_bug.cgi?id=44226
Test: fast/events/focus-change-crash2.html
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode): add a ref to prevent the focused node from being deleted
2010-08-12 Justin Schuh <jschuh@chromium.org>
Reviewed by Dumitru Daniliuc.
Clear PluginData's page pointer on page refresh
https://bugs.webkit.org/show_bug.cgi?id=43888
Test: plugins/access-after-page-destroyed.html
* page/Page.cpp:
(WebCore::Page::refreshPlugins):
2010-07-28 Justin Schuh <jschuh@chromium.org>
Reviewed by Nate Chapin.
Clear PluginData's page pointer on Page destruction
https://bugs.webkit.org/show_bug.cgi?id=43147
Test: plugins/access-after-page-destroyed.html
* page/Page.cpp:
(WebCore::Page::~Page):
2010-08-17 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Geolocation clearWatch() needs to protect against invalid IDs
https://bugs.webkit.org/show_bug.cgi?id=44096
If the ID passed to clearWatch() is invalid, we early-out.
Test: fast/dom/Geolocation/clear-watch-invalid-id-crash.html
* page/Geolocation.cpp:
(WebCore::Geolocation::Watchers::set):
(WebCore::Geolocation::Watchers::remove):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::clearWatch):
2010-07-20 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Check the node is a text node before doing the static cast
for editing commands.
https://bugs.webkit.org/show_bug.cgi?id=42655
Test: editing/execCommand/editing-nontext-node-crash.xhtml
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::fixupWhitespace):
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
2010-07-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Fisher.
Check history state against origin before setting
https://bugs.webkit.org/show_bug.cgi?id=42858
Tests: fast/loader/stateobjects/replacestate-base-illegal.html
fast/loader/stateobjects/replacestate-base-legal.html
* page/History.cpp:
(WebCore::History::urlForState):
(WebCore::History::stateObjectAdded):
2010-07-12 Tony Chang <tony@chromium.org>
Reviewed by David Hyatt.
crash in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=41196
Test: scrollbars/hidden-iframe-scrollbar-crash.html
* page/FrameView.cpp:
(WebCore::FrameView::detachCustomScrollbars):
2010-07-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Crash in RenderObject::containingBlock when clearing selection in a display:none node.
https://bugs.webkit.org/show_bug.cgi?id=41523
updateStyleIfNeeded before clearing the selection in the RenderView. Otherwise,
m_selectionStart and m_selectionEnd in RenderView point to garbage object.
This fixes the crash because updateStyleIfNeeded clears the selection before
clobbering nodes that contain the selection.
Test: editing/selection/crash-on-clear-selection.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::updateAppearance):
2010-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Kenneth Rohde Christiansen.
Firing the onchange event on select which changes its size > 1 causes the select
object to change from a menulist to a listbox. However, when propogating the events,
we do a bad cast assuming the object will remain a menulist. Added proper checks to
make sure we check the renderer after the onchange is fired and propogate the event
based on correct object type.
https://bugs.webkit.org/show_bug.cgi?id=40828
Test: fast/events/select-onchange-crash.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::setSelectedIndex):
2010-07-21 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659
Test: svg/custom/use-invalid-html.xhtml
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
2010-06-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
crash when focus is changed while trying to focus next element
https://bugs.webkit.org/show_bug.cgi?id=40407
Test: fast/events/focus-change-crash.html
* dom/Element.cpp:
(WebCore::Element::focus):
2010-08-10 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Take checks for ruby base existence out of the ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=43795
Test: fast/ruby/ruby-remove-no-base.html
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
2010-07-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Fisher.
Check history state against origin before setting
https://bugs.webkit.org/show_bug.cgi?id=42858
Tests: fast/loader/stateobjects/replacestate-base-illegal.html
fast/loader/stateobjects/replacestate-base-legal.html
* page/History.cpp:
(WebCore::History::urlForState):
(WebCore::History::stateObjectAdded):
2010-07-20 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Check the node is a text node before doing the static cast
for editing commands.
https://bugs.webkit.org/show_bug.cgi?id=42655
Test: editing/execCommand/editing-nontext-node-crash.xhtml
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::fixupWhitespace):
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
2010-07-21 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659
Test: svg/custom/use-invalid-html.xhtml
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
2010-07-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
<use> on <font-face> causes crashes, if SVGUseElement gets detached
https://bugs.webkit.org/show_bug.cgi?id=41621
Do not call removeFromMappedElementSheet() from the SVGFontFaceElement destructor,
as that can potentially cause the element to be reattached while destructing.
In order to fix the crash in the testcase, the order of calling the base-class detach
method in SVGUseElement and the instance/shadow tree destruction has to be reversed,
matching the order in removedFromDocument().
Test: svg/custom/use-font-face-crash.svg
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::~SVGFontFaceElement): Remove removeFromMappedElementSheet() call.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detach): Reverse order of calling base-class detach method and instance/shadow tree destruction.
2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Darin Adler.
Memory corruption with SVG <use> element
https://bugs.webkit.org/show_bug.cgi?id=40994
Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
datastructure with the points attribute, no matter if there are changes are not. This should be
furhter optimized, but this fix is sane and fixes the root of the evil races.
Test: svg/custom/use-property-synchronization-crash.svg
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
2010-07-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032
Added counter destruction to RenderWidget::destroy()
Test: fast/css/counters/destroy-counter-crash.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
2010-06-29 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7975842> Certain text is repeated after using splitText()
Tests: fast/text/setData-dirty-lines.html
fast/text/splitText-dirty-lines.html
* dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Call RenderText::setTextWithOffset() rather than
setText(), because only the former correctly dirties line boxes.
* dom/Text.cpp:
(WebCore::Text::splitText): Ditto.
2010-06-25 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8000667> Certain text is repeated before and after a line break
Test: fast/text/bidi-explicit-embedding-past-end.html
* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine): Committing explicit embedding past the end of the range
creates BidiRuns up to the end of the range, so at that point, we can stop iterating.
2010-06-23 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
https://bugs.webkit.org/show_bug.cgi?id=40953
REGRESSION (r58209-58231): Memory corruption with invalid SVG
https://bugs.webkit.org/show_bug.cgi?id=40173
Fix several crashes, all related to <foreignObject> and/or invalid SVG documents.
- Only allow <svg> nodes, as direct children of a <foreignObject>, not any other "partial" SVG content.
- Assure to create RenderSVGRoot objects for <svg> nodes in <foreignObject>, treat them as "outermost SVG elements".
- Never allow any partial SVG content to appear in any document. Only <svg> elements are allowed.
Tests: svg/custom/bug45331.svg
svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg
svg/foreignObject/no-crash-with-svg-content-in-html-document.svg
svg/foreignObject/svg-document-as-direct-child.svg
svg/foreignObject/svg-document-in-html-document.svg
svg/foreignObject/text-tref-02-b.svg
* dom/Element.cpp: Added childShouldCreateRenderer, with ENABLE(SVG) guards.
(WebCore::Element::childShouldCreateRenderer): Only create a renderer for a SVG child, if we're a SVG element, or if the child is a <svg> element.
* dom/Element.h: Added childShouldCreateRenderer, with ENABLE(SVG) guards.
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::childShouldCreateRenderer): Disallow arbitary SVG content, only <svg> elements are allowed as direct children of a <foreignObject>
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::isOutermostSVG): Be sure to create RenderSVGRoot objects for <svg> elements inside <foreignObject>
2010-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Do not render CSS Styles :first-letter and :first-line in a SVG text element context.
https://bugs.webkit.org/show_bug.cgi?id=40031
Test: svg/text/text-style-invalid.svg
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::firstLineBlock):
(WebCore::RenderSVGText::updateFirstLetter):
* rendering/RenderSVGText.h:
2010-06-11 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Don't process floats if parent node is not a RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=40033
Test: svg/text/clear-floats-crash.svg
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
2010-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851
Fix compilation with GSEAL_ENABLE.
* platform/gtk/GtkVersioning.h:
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::show):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::detachAdjustment):
(ScrollbarGtk::updateThumbPosition):
(ScrollbarGtk::updateThumbProportion):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::initXEvent):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformStart):
* plugins/gtk/gtk2xtbin.c:
(gtk_xtbin_realize):
(gtk_xtbin_new):
(gtk_xtbin_set_position):
(gtk_xtbin_unrealize):
2010-06-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] gtk_widget_get_window should replace widget->window
https://bugs.webkit.org/show_bug.cgi?id=40180
Replace all uses of widget->window with gtk_widget_get_window. For older
GTK+ versions, #define gtk_widget_get_window in GtkVersioning.h.
No tests necessary as functionality has not changed.
* platform/gtk/GtkPluginWidget.cpp:
(WebCore::GtkPluginWidget::invalidateRect): Replace widget->window use.
* platform/gtk/GtkVersioning.h: Add gtk_widget_get_window for old GTK+ versions.
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::getVisual): Replace widget->window use.
(WebCore::screenRect): Ditto.
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::show): Ditto.
* platform/gtk/WidgetGtk.cpp:
(WebCore::gdkDrawable): Ditto.
(WebCore::Widget::setCursor): Ditto.
2010-06-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
crash when focus is changed while trying to focus next element
https://bugs.webkit.org/show_bug.cgi?id=40407
Test: fast/events/focus-change-crash.html
* dom/Element.cpp:
(WebCore::Element::focus):
2010-05-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Move the m_width(Length) and m_columns(RenderTable::ColumnStruct)
vector out-of-bounds check out of the ASSERT into the main code.
https://bugs.webkit.org/show_bug.cgi?id=38261
Test: fast/table/fixed-table-layout-large-colspan-crash.html
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2010-05-21 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8009118> Crash in WebCore::toAlphabetic()
while running MangleMe
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=39508
The math was slightly off here, and we wound up trying to access an
array at index -1 in some cases. We need to decrement numberShadow
rather than subtracting one from the result of the modulo
operation.
* rendering/RenderListMarker.cpp:
(WebCore::toAlphabeticOrNumeric):
2010-05-20 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Ensure timers are stopped on Geolocation::disconnectFrame()
https://bugs.webkit.org/show_bug.cgi?id=39388
fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.
* page/Geolocation.cpp:
(WebCore::Geolocation::disconnectFrame):
2010-03-22 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381
* platform/text/TextBreakIteratorICU.cpp:
(WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying
on conversion to void*.
(WebCore::textBreakFirst): Ditto.
(WebCore::textBreakLast): Ditto.
(WebCore::textBreakNext): Ditto.
(WebCore::textBreakPrevious): Ditto.
(WebCore::textBreakPreceding): Ditto.
(WebCore::textBreakFollowing): Ditto.
(WebCore::textBreakCurrent): Ditto.
(WebCore::isTextBreak): Ditto.
(WebCore::setUpIteratorWithRules): Ditto.
2010-05-20 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/8007953> Textarea using custom font appears blank
Test: fast/css/font-face-in-shadow-DOM.html
When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
styles that still reference the placeholder font.
The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.
* dom/Element.cpp:
(WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
* rendering/RenderButton.h:
(WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
* rendering/RenderDataGrid.h:
(WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
* rendering/RenderFileUploadControl.h:
(WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
* rendering/RenderListItem.h:
(WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
* rendering/RenderObject.h:
(WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
* rendering/RenderProgress.h:
(WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
* rendering/RenderSlider.h:
(WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):
2010-05-19 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Check that the node is a text node before doing a static cast
to a Text class pointer.
https://bugs.webkit.org/show_bug.cgi?id=38626
Test: fast/text/text-transform-nontext-node-crash.xhtml
* rendering/RenderText.cpp:
(WebCore::RenderText::originalText):
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::originalText):
(WebCore::RenderTextFragment::previousCharacter):
2010-05-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
HTML Entity Escape the contents of a textarea node when accessed via the innerHTML and outerHTML node properties.
https://bugs.webkit.org/show_bug.cgi?id=38922
Test: fast/encoding/textnode-XSS.html
* editing/markup.cpp:
(WebCore::appendStartMarkup):
2010-05-12 James Robinson <jamesr@chromium.org>
Patch by Dan Bernstein.
Reviewed by David Hyatt.
Fix marking the layout root's parent as needing layout
https://bugs.webkit.org/show_bug.cgi?id=37760
If an element gets marked as needing layout due to the recalcStyle()
call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
be set to false. It's possible at this point that a parent of the
existing FrameView::m_layoutRoot will be marked as needing layout.
This patch updates FrameView::scheduleRelayoutOfSubtree to account
for this case.
Manual test only due to subtle timing issues.
* manual-tests/layoutroot_detach.xml: Added.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
2010-04-28 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey Proskuryakov.
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>
Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
Rolling the patch in as I could not reproduce Qt results locally.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.
2010-05-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Test: fast/dom/Element/normalize-crash.html
* dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
* dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
* dom/NamedAttrMap.h:
2010-05-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Based on a patch by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28697
<rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()
It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
that it can adjust start and end position to any node except for the one being removed -
so these notifications cannot be batched.
Test: fast/dom/Range/remove-all-children-crash.html
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Removed unused ExceptionCode.
(WebCore::willRemoveChildren): New function, used in removeChildren() case.
(WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it.
(WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode.
(WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode
and willRemoveChild.
* dom/Document.cpp:
(WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
* dom/Document.h:
(WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
* dom/Range.h:
* dom/Range.cpp:
(WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case.
(WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
2010-04-20 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
https://bugs.webkit.org/show_bug.cgi?id=37331
Added a setting to enable/disable media per-page and have the SVGImage
disable media for its dummy page. Also found and fixed a related bad
cast in the V8 bindings (JSC had a custom wrapper for this already).
Tests: media/svg-as-image-with-media-blocked.html
* dom/make_names.pl: Added media enabled check and V8 cast wrapper
* page/Settings.cpp: Added m_isMediaEnabled (defaults to true)
(WebCore::Settings::Settings):
(WebCore::Settings::setMediaEnabled):
* page/Settings.h:
(WebCore::Settings::isMediaEnabled):
* svg/graphics/SVGImage.cpp: Disables media in dummy page
(WebCore::SVGImage::dataChanged):
2010-04-02 Justin Schuh <jschuh@chromium.org>
Reviewed by Alexey Proskuryakov.
XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843
Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.
Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightFailure):
2010-05-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=26824
<rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
keyboard event dispatch.
EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
event if focused frame changes between keydown and keypress.
* manual-tests/focus-change-between-key-events.html: Added.
* page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame
changes while dispatching keydown. Also made similar changes for Windows to maintain matching
behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being
separate events.
2010-05-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
Test: editing/execCommand/clipboard-access.html
* WebCore.base.exp:
* editing/EditorCommand.cpp:
(WebCore::supportedCopyCut):
(WebCore::supportedPaste):
(WebCore::createCommandMap):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setJavaScriptCanAccessClipboard):
* page/Settings.h:
(WebCore::Settings::javaScriptCanAccessClipboard):
2010-05-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38260
<rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().
Broken all the way since r4 (yes, that's a revision number).
Test: http/tests/security/xss-DENIED-javascript-with-spaces.html
* css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
2010-04-14 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Javascript URL can be set as iframe.src via multiple DOM aliases
https://bugs.webkit.org/show_bug.cgi?id=37031
Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL static helper function from
JSElementCustom.cpp to exported function in JSDOMBinding.h.
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::setValue):
* bindings/js/JSDOMBinding.cpp:
(WebCore::allowSettingSrcToJavascriptURL):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::setNamedItem):
(WebCore::JSNamedNodeMap::setNamedItemNS):
* bindings/js/JSNodeCustom.cpp:
(WebCore::isAttrFrameSrc):
(WebCore::JSNode::setNodeValue):
(WebCore::JSNode::setTextContent):
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):
* bindings/v8/custom/V8AttrCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::setNamedItemNSCallback):
(WebCore::V8NamedNodeMap::setNamedItemCallback):
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::isFrameSrc):
(WebCore::V8Node::textContentAccessorSetter):
(WebCore::V8Node::nodeValueAccessorSetter):
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* dom/Attr.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
2010-03-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502
Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.
Test: http/tests/security/xss-DENIED-iframe-src-alias.html
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::nodeValue):
(WebCore::JSAttr::setNodeValue):
(WebCore::JSAttr::textContent):
(WebCore::JSAttr::setTextContent):
* bindings/v8/custom/V8AttrCustom.cpp:
(WebCore::V8Attr::nodeValueAccessorSetter):
(WebCore::V8Attr::nodeValueAccessorGetter):
(WebCore::V8Attr::textContentAccessorSetter):
(WebCore::V8Attr::textContentAccessorGetter):
* dom/Attr.idl:
2010-04-23 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7898436> :after content is duplicated
Test: fast/css-generated-content/after-duplicated-after-split.html
* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.
2010-03-30 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Taint the canvas if an SVG-derived pattern is rendered into it.
https://bugs.webkit.org/show_bug.cgi?id=36838
Test: fast/canvas/svg-taint.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
Take into account the image's hasSingleSecurityOrigin() property.
2010-03-22 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.
https://bugs.webkit.org/show_bug.cgi?id=36435
Test: fast/loader/stateobjects/replacestate-in-iframe.html
* loader/HistoryController.cpp:
(WebCore::HistoryController::replaceState):
2010-03-18 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7761400> Rework the fix for
https://bugs.webkit.org/show_bug.cgi?id=18722
Test: fast/dynamic/float-remove-above-line-2.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject): Treat 0- and less-than-0-height floats
as having a height of 1 so that they intersect with the line they originate on.
(WebCore::RenderBlock::clearFloats): Use numeric_limits.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Removed the intersection checks here,
so that a float is always included in the float list of the line it originates on, even
if it does not intersect that line. This ensures that every float is accounted for, which
is necessary during incremental layout when adding floats from clean lines.
2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641
Don't dig into buttons and menu lists when finding which element
should be modified by :first-letter pseudo class. Even before
this change, we didn't dig into inline buttons and menu lists as
they are replaced so this issue wasn't found long time.
Test: fast/css/first-letter-block-form-controls-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
2010-03-18 Darin Adler <darin@apple.com>
Reviewed by Kenneth Rohde Christiansen.
Remove Geolocation.lastPosition, no longer in the spec.
https://bugs.webkit.org/show_bug.cgi?id=36255
rdar://problem/7746357
* WebCore.base.exp: Updated since Geolocation's destructor is now non-virtual.
* page/Geolocation.cpp:
(WebCore::Geolocation::lastPosition): Add an assertion; it's only legal to
call this if access to the location is allowed.
* page/Geolocation.h: Removed unneeded includes. Made destructor non-virtual,
although it will still be virtual if any of the base classes have a virtual
destructor. Made lastPosition, isAllowed, and isDenied functions private.
Removed unused suspend, resume, setShouldClearCache, shouldClearCache,
and frame functions.
* page/Geolocation.idl: Removed lastPosition read-only attribute. No longer in
the Geolocation specification.
2010-07-09 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by NOBODY (OOPS!).
[GTK] Crashes when going back with page cache in unknown circunstances
https://bugs.webkit.org/show_bug.cgi?id=41710
Could not yet find a way to reproduce this in a layout test. The
issue is document being NULL, so this NULL-check should be enough
to get rid of the crash.
* page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent):
2010-07-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Scrollbars sometimes go dead and stop scrolling the view
https://bugs.webkit.org/show_bug.cgi?id=41711
Rework the setGtkAdjustment function slightly, make it have an
early return, and be more readable.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed.
Fixes regression on API test by disabling the scrollbars before
configuring the adjustments.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Scrollbars sometimes go dead and stop scrolling the view
https://bugs.webkit.org/show_bug.cgi?id=41711
Fixes GtkScrolledWindow scrollbars not actually scrolling the page
in certain conditions. No tests because it is hard to reproduce,
and depends on interaction with a widget that is outside of the
WebView, which is tricky.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Crash when hitting back on some pages
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236
Also NULL-check document, in hopes of fixing this hard to
reproduce crash that we are getting reported quite a bit.
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
2010-06-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853
Add GOwnPtr wrapper for GdkEvent and expose a setter for
PlatformMouseEvent::m_clickCount.
* GNUmakefile.am: Add GOwnPtrGtk.{cpp,h} to the sources list.
* platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::setClickCount): Added.
* platform/gtk/GOwnPtrGtk.cpp: Added.
(WTF::GdkEvent):
* platform/gtk/GOwnPtrGtk.h: Added.
2010-05-22 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Fix a crash when XHTMLMP is enabled. The frame pointer in Document
ctor can be null.
https://bugs.webkit.org/show_bug.cgi?id=39448
No new tests because it is obvious and it must be reproduced with
XHTMLMP enabled.
* dom/Document.cpp:
(WebCore::Document::Document):
2010-05-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
https://bugs.webkit.org/show_bug.cgi?id=39465
Added a helper function for converting a GDK action bitmask into a DragOperation bitmask.
No new tests as behavior has not changed.
* platform/gtk/ClipboardUtilitiesGtk.cpp:
(WebCore::gdkDragActionToDragOperation): Added.
* platform/gtk/ClipboardUtilitiesGtk.h:
2010-05-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
https://bugs.webkit.org/show_bug.cgi?id=39459
Add ClipboardUtilitiesGtk, a container for GTK+/WebCore clipboard utility functions.
Initially add a function which converts a WebCore::DragOperation to a bitmask of
GdkDragActions.
No new tests, because behavior has not changed.
* GNUmakefile.am:
* platform/gtk/ClipboardUtilitiesGtk.cpp: Added.
(WebCore::dragOperationToGdkDragActions): Added.
* platform/gtk/ClipboardUtilitiesGtk.h: Added.
2010-05-18 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232
Test: editing/execCommand/crash-indenting-list-item.html
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem):
(WebCore::IndentOutdentCommand::indentIntoBlockquote):
2010-05-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Build fix. Remove bashism from build system.
* GNUmakefile.am:
2010-05-13 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
REGRESSION: Crash by pasting to a textarea with white-space:nowrap
https://bugs.webkit.org/show_bug.cgi?id=38992
Test: editing/pasteboard/paste-plaintext-nowrap.html
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::highestVisuallyEquivalentDivBelowRoot):
(WebCore::InsertParagraphSeparatorCommand::doApply):
2010-05-15 Andrei Bucur <abucur@adobe.com>
Reviewed by Gustavo Noronha Silva.
Functions using the cairo_pattern_t object returned by
Pattern::createPlatformPattern sould destroy it after the painting
operation. Failing to do so causes memory leaks.
Test: No test was added because the patch adds no new functionality.
It just completes the normal life cycle of a cairo_pattern_t object.
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
2010-05-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail
The "announcement" is now made in the form of an object attribute
associated with the AtkObject.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_attributes):
2010-05-14 Adele Peterson <adele@apple.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left
Test: editing/selection/applystyle-to-inline-inside-block.html
* dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Now that this function correctly goes in and out of editable areas by calling
downstreamIgnoringEditingBoundaries and upstreamIgnoringEditingBoundaries for blocks (added in r58665), we no longer need a special case to
jump out to the parent when we hit an inline (which was added in r53085 when this issue was introduced).
2010-05-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.
[GTK] Theme does not render when printing
https://bugs.webkit.org/show_bug.cgi?id=38896
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozillaGtkWidget):
2010-05-10 Philippe Normand <pnormand@igalia.com>
Reviewed by David Levin.
[GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=38839
Fixed #ifdef/curly braces coherence.
* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp:
(WTF::GstElement):
2010-05-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Dirk Schulze.
[GStreamer] un-needed cairo.h include
https://bugs.webkit.org/show_bug.cgi?id=38837
Cairo not used in the sink anymore. So it's not needed to include
the header.
* platform/graphics/gstreamer/VideoSinkGStreamer.h:
2010-05-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
https://bugs.webkit.org/show_bug.cgi?id=38653
Check if willSendRequest cancelled the request before setting the
first party for the cookies in the message, otherwise we'll get a
critical warning.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
2010-05-07 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze
Fixed the inverse function of f(x) = ((x + 0.055) / 1.055) ^ 2.4
https://bugs.webkit.org/show_bug.cgi?id=38735
It is ((x ^ (1 / 2.4)) * 1.055) - 0.055
Chromium pixel tests cover the issue.
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::transformColorSpace):
2010-05-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=38769
ClipboardGtk should write the URL label in the text portion of the DataObject
No tests as this code path is currently unused in the GTK+ port.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writeURL): Write the label to the text portion of the DataObject, instead of the URL.
2010-05-07 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Potential crash in EventHandler::handleTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=38646
Fix a ref counting bug that can cause a crash if the m_originatingouchPointTargets
hashmap holds the last ref to an EventTarget when the user lifts their finger.
This is very hard to reproduce in a consistent way and clearly a
simple logic error in the code, therefore no new tests.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Don't let the RefPtr we get back from
the hasmap go out of scope so soon as it could delete the wrapped ptr if the
hashmap held the last ref (and we use the raw ptr that the RefPtr
wraps later in the WebCore::Touch constructor).
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Kenneth Rohde Christiansen.
[GTK] Fails to build on GTK+ < 2.14
https://bugs.webkit.org/show_bug.cgi?id=38746
Build fix only. Do basically the same as gtk_adjustment_configure
would do if we are bellow GTK+ 2.14.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::AdjustmentConfigure):
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Crash with MgOpenModerna font, with non-UTF-8 character
https://bugs.webkit.org/show_bug.cgi?id=37795
NULL-check the font platform data, for now, to avoid the crash.
Could not yet figure out a way to get a test written that does not
involve adding the font to the tree, but there are doubts about
licensing.
* platform/graphics/cairo/FontCacheCairo.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
No new tests, because functionality has not changed.
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here.
(WebCore::ClipboardGtk::helper): Added.
(WebCore::ClipboardGtk::dataObject): Added.
* platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Kenneth Rohde Christiansen.
[GTK] Fails to build on GTK+ < 2.14
https://bugs.webkit.org/show_bug.cgi?id=38746
Build fix only. Do basically the same as gtk_adjustment_configure
would do if we are bellow GTK+ 2.14.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::AdjustmentConfigure):
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Crash with MgOpenModerna font, with non-UTF-8 character
https://bugs.webkit.org/show_bug.cgi?id=37795
NULL-check the font platform data, for now, to avoid the crash.
Could not yet figure out a way to get a test written that does not
involve adding the font to the tree, but there are doubts about
licensing.
* platform/graphics/cairo/FontCacheCairo.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Rework where we get page step and line step from, so we do not
depend on scrollbars existing. Caught by API test I forgot to run.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Adjustment resetting uses wrong values, and misses page_size and steps
https://bugs.webkit.org/show_bug.cgi?id=38657
Fix resetting adjustment values. In the page cache case, we were
confusing page_size and upper, leading to stray scrollbars
sometimes.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-05-05 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.
No new tests as functionality has not changed.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData): Add support for images here.
(WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
2010-05-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=38497
<rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin
This is a hardening fix, and behavior really depends on what an underlying networking layer
does. So, no test.
* page/SecurityOrigin.cpp:
(WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading.
(WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities
have the same security origin.
2010-05-04 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin (and unofficially by Enrica Casucci).
REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
if the text is like a URL
https://bugs.webkit.org/show_bug.cgi?id=38374
Since r54368, documentFragmentFromDragData() creates an <a> element
with no anchor text for URL-like text dragged from input/textarea
element. If such text is dropped to input/textarea element, the text
is not inserted.
To fix this problem, use the original text or the URL as an anchor
text.
Test: editing/pasteboard/drag-drop-url-text.html
* page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
2010-05-04 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
Crash in handleTouchEvent: using dangling node ptrs in hashmap
https://bugs.webkit.org/show_bug.cgi?id=38514
When navigating away from a page, if you have your finger still
pressed and then lift it on the new page we see a crash if the
node got deleted as we still have a dangling pointer in the
m_originatingTouchPointTargets hashmap and try to use it as the
receiver to dispatch a touchend event.
Test: fast/events/touch/touch-stale-node-crash.html
* page/EventHandler.cpp:
(WebCore::EventHandler::clear): Clear the hashmap of touch targets.
2010-04-30 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GStreamer] endless loop after playback ended
https://bugs.webkit.org/show_bug.cgi?id=38384
At playback end ensure duration() will return a valid duration if
we managed to calculate it based on current position.
Test: media/video-duration-known-after-eos.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
2010-04-30 Brady Eidson <beidson@apple.com>
Reviewed by Eric Carlson.
<rdar://problem/7902467> - Audio plays upon loading of npr.org but shouldn't
No new tests. (Currently no way to test such site specific hack behavior)
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::asyncEventTimerFired): If the event to be dispatched is the canplay
event, wrap the dispatch with m_dispatchingCanPlayEvent set.
(WebCore::HTMLMediaElement::play): If m_dispatchingCanPlayEvent is true and the site is npr.org,
don't perform the play().
* html/HTMLMediaElement.h: Add m_dispatchingCanPlayEvent member.
2010-04-29 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
Reviewed by Jeremy Orlow.
Fix building with libpng-1.4.
https://bugs.webkit.org/show_bug.cgi?id=33287
No new tests (no behavior change).
Original patch by John Bowler <jbowler@acm.org>
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode):
2010-04-25 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Darin Adler.
Clicking a scrollbar blurs the currently focused element
https://bugs.webkit.org/show_bug.cgi?id=16809
WebKit ports that do not use native (platform) widgets for rendering the scrollbars
are currently mismatching a common behaviour of other browser vendors (including
Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
instance, can observe the opposite behaviour.
Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
If that is the case, it bails out and do not change focus behavior at all.
It is important to note that the given way this is implemented by this patch, non-frame
scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
in the same way as it works currently.
Tests: scrollbars/scrollbar-click-does-not-blur-content.html
scrollbars/scrollbar-iframe-click-does-not-blur-content.html
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
2010-04-28 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Make ClipboardGtk a "live" DataTransfer object, able to modify
the clipboard when setData(...) is called.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method.
(WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data.
(WebCore::dataObjectTypeFromHTMLClipboardType): Added.
(WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard.
(WebCore::ClipboardGtk::clearAllData): Ditto.
(WebCore::joinURIList): Added.
(WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible.
(WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard.
(WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types.
(WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files.
(WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard.
(WebCore::ClipboardGtk::writeRange): Ditto.
(WebCore::ClipboardGtk::writePlainText): Ditto.
(WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
* platform/gtk/DataObjectGtk.cpp:
(WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean from plain text.
(WebCore::DataObjectGtk::markup): Actually return the range if it's set.
(WebCore::DataObjectGtk::setText): Clean from plain text.
(WebCore::DataObjectGtk::clearText): Added.
(WebCore::DataObjectGtk::clearMarkup): Added.
* platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::clearURIList): Added.
(WebCore::DataObjectGtk::clearImage): Added.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets.
(WebCore::urisToKURLVector): Added.
(WebCore::PasteboardHelper::getClipboardContents): Added.
(WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs.
(WebCore::PasteboardHelper::targetListForDataObject): Ditto.
* platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.
2010-04-28 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.
No new tests, because pasteboard DataTransfer tests will be enabled
with the completion of the GTK+ DataTransfer object.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.
2010-04-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618
Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
(WebCore::DragController::draggingImageURL):
(WebCore::DragController::documentUnderMouse):
2010-04-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38131
I did a number of separate optimizations which speed up style
resolution enough to more than make up for the regression. This
measures as a total PLT speedup of somewhere between 1.5% and
3.7%.
Optimizations done:
- Cache determineLinkState results, to avoid the need to repeatedly compute
the visited link hash for the same element. This directly addresses much
of the slowdown, since all elements get their style computed twice now.
- Added a fast way to get the length of a CSSMutableStyleDeclaration, and use
in CSSStyleSelector::matchRulesForList, since it was hot there.
- Hoist some loop invariant code that's not detected by the compiler out of the
main loop in matchRulesForList
- inline CSSStyleSelector::initElement and locateSharedStyle,
since there is only one call site in each case
- Inline the common non-line fast case of determineLinkState, and split the rest into
out-of-line determineLinkStateSlowCase.
- Added inline versions of the functions called by
visitedLinkHash (the version called by determineLinkState).
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new
inline nonvirtual mutableLength().
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual
inline way to get the length if you know you have a mutable style decl.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::init): Clear cached link state.
(WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main
loop and get style decl length more efficiently.
(WebCore::CSSStyleSelector::initElement): inline (only one call site)
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast
case, call slow case.
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split
most of the above function into this slow case helper.
(WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled
way to get the current link state.
(WebCore::CSSStyleSelector::locateSharedStyle): inline
(WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way
to get the current link state.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::currentElementLinkState): inline way to
get link state for the current element; manages the cache
* platform/LinkHash.cpp:
(WebCore::visitedLinkHashInline): inline version of below function
(WebCore::visitedLinkHash): call the inline version
(WebCore::visitedURLInline): inline version of below function
(WebCore::visitedURL): call the inline version
(WebCore::visitedURL): call inline versions of above two functions
2010-04-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7766413>
Fixed a crash seen when using the JavaScriptCore API with WebKit.
No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
JavaScriptCore no longer allows this.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
default behaviors.
2010-04-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
WebKit crashes with deeply nested divs
https://bugs.webkit.org/show_bug.cgi?id=18282
The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
TreeDepthLimit.h. This is performance-efficient, but does not work for
DOM operations such as Node.appendChild().
Test: fast/parser/element-nesting-cap.html
* dom/Node.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::pushCurrentNode):
* html/HTMLParser.cpp:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/TreeDepthLimit.h:
Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
* dom/XMLTokenizer.cpp: Use maxDOMTreeDepth.
(WebCore::XMLTokenizer::pushCurrentNode):
* html/HTMLParser.cpp:
Introduce m_treeDepth, which counts the depth of the tree.
Unlike m_blocksInStack, it contains the number of non-block nodes.
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::reset):
(WebCore::HTMLParser::limitDepth):
Renamed from limitBlockDepth. Add check for m_nodeDepth.
(WebCore::HTMLParser::insertNodeAfterLimitDepth):
Renamed from insertNodeAfterLimitBlockDepth.
(WebCore::HTMLParser::parseToken):
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
(WebCore::HTMLParser::pushBlock):
(WebCore::HTMLParser::popOneBlockCommon):
(WebCore::HTMLParser::freeBlock):
* html/HTMLParser.h:
2010-04-22 Tony Chang <tony@chromium.org>
Reviewed by Dan Bernstein.
Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
https://bugs.webkit.org/show_bug.cgi?id=37950
Test: editing/text-iterator/rtl-selection-crash.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[GTK] Mute/unmute button on <video> elements are backwards
https://bugs.webkit.org/show_bug.cgi?id=33967
Fix mute/unmute buttons icons-action relation and explain why their
variable names and corresponding icons seem to be misleading but are
actually right. Original patch by Mike Hommey.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::initMediaStyling):
2010-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
Re-submit r56585 with fix for Chromium.
* plugins/PluginView.cpp: Guard getValueStatic() with
NETSCAPE_PLUGIN_API
(WebCore::PluginView::getValue):
* plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
* plugins/PluginViewNone.cpp: Guard platformGetValue() and
platformGetValueStatic with NETSCAPE_PLUGIN_API;
Guard privateBrowsingStateChanged() and setJavaScriptPaused() with
PLATFORM(MAC) or PLATFORM(CHROMIUM)
2010-04-21 Timothy Hatcher <timothy@apple.com>
Make UserContentURLPattern correctly check for subdomains and the URL
has the same suffix as the pattern. Also improve the parsing of the host.
https://bugs.webkit.org/show_bug.cgi?id=37357
Reviewed by Darin Adler.
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Simplify the subdomain pattern parsing to
simply check for "*" only or a "*." prefix and then do a substring.
(WebCore::UserContentURLPattern::matchesHost): Check that the host has a "." in the
position before the suffix to ensure it a subdomain and not just a suffix match.
2010-04-20 Timothy Hatcher <timothy@apple.com>
Fix matching of "file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.
Also fix comparisons to be case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=37889
Reviewed by Dave Hyatt.
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.
2010-04-20 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.
No new tests as functionality has not changed.
* GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
* platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
* platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming.
(WebCore::clipboard_get_contents_cb): Ditto.
(WebCore::Pasteboard::helper): Added, member is now private.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::documentFragment): Update to reflect method renaming.
(WebCore::Pasteboard::plainText): Ditto.
* platform/gtk/PasteboardHelper.cpp: Added.
(WebCore::PasteboardHelper::PasteboardHelper): Added.
(WebCore::PasteboardHelper::~PasteboardHelper): Added.
(WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit.
(WebCore::widgetFromFrame): Added helper function.
(WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit.
(WebCore::PasteboardHelper::getClipboard): Ditto.
(WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto.
(WebCore::PasteboardHelper::targetList): Ditto.
(WebCore::PasteboardHelper::fillSelectionData): Ditto.
(WebCore::PasteboardHelper::targetListForDataObject): Ditto.
(WebCore::getClipboardContentsCallback): Ditto.
(WebCore::clearClipboardContentsCallback): Ditto.
(WebCore::PasteboardHelper::writeClipboardContents): Ditto.
* platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.
2010-03-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=36733
Use a common header for Windows virtual key codes on all platforms
No change in functionality, so no new tests.
* platform/WindowsKeyboardCodes.h: Added. Define VK_* key codes as macros, matching Windows.
* platform/KeyboardCodes.h: Removed.
* platform/android/KeyboardCodes.h: Removed.
* platform/chromium/KeyboardCodesPosix.h: Removed.
* platform/chromium/KeyboardCodesWin.h: Removed.
* platform/haiku/KeyboardCodes.h: Removed.
* platform/wx/KeyboardCodes.h: Removed.
Removed platform specific attempts to do the same thing. In fact, platform/KeyboardCodes.h
was supposed to be cross-platform, but it didn't have a sufficiently descriptive name, and
its name was the same as platform-specific versions, so I chose a new one.
* platform/chromium/KeyboardCodes.h: Copied from WebCore/platform/chromium/KeyboardCodesWin.h.
Chromium redefines Windows constants to different names; keeping the header doing that to
avoid breaking Chromium code.
* GNUmakefile.am:
* WebCore.gypi:
Replaced KeyboardCodes.h with WindowsKeyboardCodes.h.
* WebCore.xcodeproj/project.pbxproj:
* platform/cocoa/KeyEventCocoa.mm:
(WebCore::windowsKeyCodeForKeyCode):
(WebCore::windowsKeyCodeForCharCode):
Mac used to hardcode the key codes; changed to use VK_* macros.
* config.h: Removed a hack to include KeyboardCodes.h, it shouldn't be necessary any more.
* platform/android/KeyEventAndroid.cpp:
* platform/brew/PlatformKeyboardEventBrew.cpp:
* platform/efl/PlatformKeyboardEventEfl.cpp:
* platform/gtk/KeyEventGtk.cpp:
* platform/haiku/PlatformKeyboardEventHaiku.cpp:
* platform/qt/PlatformKeyboardEventQt.cpp:
* platform/wx/KeyboardEventWx.cpp:
Changed to include WindowsKeyboardCodes.h.
2010-04-19 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Make the fix for <rdar://problem/7873647> from r57759 more robust.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.
2010-04-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862
Test: fast/invalid/invalidSVGFont.html
* loader/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.
2010-04-16 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7873647> Crash when updating hover state
Test: fast/dynamic/hover-style-recalc-crash.html
Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.
2010-04-15 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited link is wrong color. Make sure
that the pseudo style caching allows visited link styles to hang off other pseudo styles.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getCachedPseudoStyle):
2010-04-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Repaint of fixed, transformed element is broken
https://bugs.webkit.org/show_bug.cgi?id=37637
RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.
Also cache style()->position() in a local variable for performance.
Test: fast/repaint/fixed-tranformed.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
We have to check if the resource handler is cancelled before
checking the client, other case it could crash.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::parseDataUrl):
2010-04-13 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(r57511): many new graphics / svg related leaks
https://bugs.webkit.org/show_bug.cgi?id=37527
The content of a HashMap was not correctly deleted. Fixed this
in the DTor and in invalidateClient of RenderSVGResourceClipper.
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::invalidateClient):
2010-04-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=34653
Based on W3C spec and Firefox behavior, while invoking XHR Send with parameter
as String, the charset in Content-Type should be forced to set to UTF-8.
Test: http/tests/xmlhttprequest/request-encoding2.html
* platform/network/HTTPParsers.cpp:
(WebCore::extractCharsetFromMediaType):
(WebCore::findCharsetInMediaType):
* platform/network/HTTPParsers.h:
* xml/XMLHttpRequest.cpp:
(WebCore::setCharsetInMediaType):
(WebCore::XMLHttpRequest::send):
2010-04-12 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Throwing a SECURITY_ERR when openDatabase() cannot open a database
for whatever reason, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=33916
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
2010-04-10 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Defense in depth: make sure an SVG document in the <img> context has
a unique origin.
https://bugs.webkit.org/show_bug.cgi?id=37392
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Force the temporary rendering context into a unique origin.
* loader/FrameLoader.h:
(WebCore::FrameLoader::setForceSandboxFlags):
Support for setting sandbox flags that will always be applied.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::updateSandboxFlags):
Always apply any forced flags.
2010-04-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Prevent HTTP responses served with JSON content type from being rendered as HTML.
Test: http/tests/security/xss-DENIED-mime-type-execute-as-html.html
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::isTextMIMEType): Render application/json as text/plain.
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedNonImageMimeTypes): Add a compile assert to prevent addition of new mime types in non-image types.
2010-04-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37181
<rdar://problem/7835374> REGRESSION (r54400): Hangs when doing AJAX update with large amount of data
Test: fast/events/gc-freeze-with-attribute-listeners.html
The problem was that we were creating JS wrappers for nodes with attribute event listeners,
and GC is very slow if there are nodes with wrappers in a detached tree whose root does not
have a wrapper.
* bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Don't create
wrappers for attribute event listeners - if there is a node, JSLazyEventListener::initializeJSFunction()
will create one.
* bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the problem
we are stepping around now.
2010-04-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
WebGtk GLib-CRITICAL Segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=34937
Do not crash if a plugin does not return anything in
NP_GetMIMEDescription. This can happen, and other ports gracefully
handle the situation.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::fetchInfo):
2010-04-07 David Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.
This patch implements the policy described by David Baron here:
http://dbaron.org/mozilla/visited-privacy
Added new tests in fast/history.
* WebCore.base.exp:
Expose functions needed for the WebKit SPI used by layout tests.
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information. For normal Web pages, this will be false. It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
* css/CSSStyleSelector.h:
Rework the style selector to resolve two styles instead of one. The first forces the link to
be unvisited, and the second forces the link to be visited. The real state of the link is
cached on the principal (unvisited) style. The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).
* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.
* platform/LinkHash.cpp:
(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRings):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):
* rendering/RenderObject.h:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):
* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle. Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
* rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):
* rendering/style/RenderStyleConstants.h:
Change how link information is stored. The noninherited flags now have a bit set for if you're a link
or not. The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).
(WebCore::):
* svg/graphics/SVGPaintServer.cpp:
(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.
2010-04-08 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Fix build with MathML enabled.
* GNUmakefile.am:
2010-03-29 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Don't use unique domains for file:// separation: it breaks local
databases, and access to your own same-origin iframes. Instead, use
path-based access checks.
https://bugs.webkit.org/show_bug.cgi?id=36692
Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html
* dom/Document.cpp:
(WebCore::Document::initSecurityContext): renamed API.
* page/SecurityOrigin.h:
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
Initialize new flag. Take note of file:// path.
Copy new fields in copy constructor.
(WebCore::SecurityOrigin::canAccess):
Take into account path-based origin separation for file://
(WebCore::SecurityOrigin::enforceFilePathSeparation):
New method to enable file:// path origin separation.
(WebCore::SecurityOrigin::toString):
Return a null domain for an isolated file origin.
(WebCore::SecurityOrigin::isSameSchemeHostPort):
Take into account path-based origin separation for file://
(WebCore::SecurityOrigin::passesFileCheck):
Abstraction of common logic for file:// access checks.
2010-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
https://bugs.webkit.org/show_bug.cgi?id=36800
Added guards nodes from foreign documents to DOMSelection APIs.
Tests: editing/selection/DOMSelection-DocumentType.html
editing/selection/DOMSelection-crossing-document.html
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::extend):
(WebCore::DOMSelection::containsNode):
(WebCore::DOMSelection::isValidForPosition):
* page/DOMSelection.h:
2010-04-01 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Fix a NULL pointer crash if @import fails to load a stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=36804
Test: fast/xsl/xslt-bad-import-uri.html
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::parseString):
Handle an empty string gracefully. An empty string has a NULL
buffer, which we pass in to xmlCreateMemoryParserCtxt(). It returns
NULL if it is passed a NULL buffer.
In the top-level XSL case, the current code does not crash "by luck"
because the other APIs used can handle a NULL argument. In the
@import case, additional code runs which will deference the NULL.
2010-04-01 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Bug 36968 - 1 crash in Safari at com.apple.WebCore: WebCore::Element::getAttribute const
https://bugs.webkit.org/show_bug.cgi?id=36968
Test: accessibility/crash-with-noelement-selectbox.html
When a <select> element had no options, the selectedIndex == -1 and that was being
used to index into an empty array.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
2010-03-31 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
Crash when writing into a detached TITLE element
https://bugs.webkit.org/show_bug.cgi?id=25567
Document::setTitle() invoked HTMLTitleElement::setText(), which
contains DOM tree modification, even when setTitle() is called
from HTMLTitleElement::childrenChanged(). Fix to skip setText()
when setTitle() is called childrenChanged() to avoid cascading
DOM mutations between Document and HTMLTitleElement.
Test: fast/dom/title-content-write-set.html
* dom/Document.cpp:
(WebCore::Document::setTitle):
2010-03-31 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Crash submitting display:none textarea in a form
https://bugs.webkit.org/show_bug.cgi?id=36905
Test: fast/forms/textarea-submit-crash.html
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::appendFormData): Do update layout before
asking our renderer for its text, since we can't rely on our renderer's
text if layout is needed.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textWithHardLineBreaks): Don't update layout
while being asked for our text, since doing so may delete us, causing a crash.
2010-03-31 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<http://webkit.org/b/36878> REGRESSION: Trailing colon on hostnames (with no port specified) causes "Not allowed to use restricted network port"
* platform/KURL.cpp:
(WebCore::KURL::port): Explicitly handle the case of a colon being present in the URL after the host name but with
no port number before the path. This is handled in the same manner as the colon and port being omitted completely.
2010-03-27 Dmitry Gorbik <socket.h@gmail.com>
Reviewed by Pavel Feldman.
Fix the regression caused by r28078: a global variable
definition masks a local one in an inspector console
https://bugs.webkit.org/show_bug.cgi?id=32442
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
2010-03-24 Mark Rowe <mrowe@apple.com>
Revert the portion of r56489 that dealt with port zero as it introduced some test failures.
* platform/KURL.cpp:
(WebCore::KURL::port): Use the "ok" argument to charactersToUIntStrict to determine whether
it was able to successfully parse the string as an unsigned integer, rather than relying on
the fact it returned zero when it failed.
2010-03-24 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
WebKit should treat port numbers outside the valid range as being blacklisted
<http://webkit.org/b/36571> / <rdar://problem/7790908>
* platform/KURL.cpp:
(WebCore::KURL::port): Map invalid port numbers to invalidPortNumber.
(WebCore::portAllowed): Add invalidPortNumber to the blacklist.
* platform/KURLGoogle.cpp: invalid port numbers to invalidPortNumber.
(WebCore::KURL::port): Add invalidPortNumber to the blacklist.
Also bring this in to sync with KURL. Having this identical code in two places is stupid.
2010-03-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
[GStreamer] Fails to go to Loaded state because of floating point discrepancies
https://bugs.webkit.org/show_bug.cgi?id=35891
Use the m_fillStatus variable, which is more reliable, instead of
using the calculation, for the completed case.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::fillTimerFired):
2010-03-23 Chris Evans <cevans@chromium.org>
Reviewed by Darin Adler.
Fix hard-to-see crash due to incorrect libxml API usage.
https://bugs.webkit.org/show_bug.cgi?id=36000
Test: fast/text/bad-encoding.html
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::doEnd): Avoid operations on a closed context.
2010-03-18 Chris Evans <cevans@chromium.org>
Reviewed by Nikolas Zimmermann.
Fix a minor crash with mismatched array sizes in SVG animation
elements.
https://bugs.webkit.org/show_bug.cgi?id=35606
Test: svg/animations/keypoints-mismatch.svg
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
Globally apply validations relevant to all animation types.
2010-03-23 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545
Added missing NULL-check that other APIs have.
Test: svg/dom/frame-related-api-during-load.html
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::deselectAll):
2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398
Fix building with newest GTK+ versions.
* GNUmakefile.am:
* platform/gtk/GtkPluginWidget.cpp:
(WebCore::GtkPluginWidget::invalidateRect):
(WebCore::GtkPluginWidget::paint):
* platform/gtk/GtkVersioning.h: Added.
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::paint):
* plugins/gtk/gtk2xtbin.c:
(gtk_xtbin_set_position):
(gtk_xtbin_unrealize):
2010-03-19 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header
Test: websocket/tests/long-invalid-header.html
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
2010-03-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.
Tests: svg/filters/feColorMatrix-invalid-value.svg
svg/filters/feColorMatrix-values.svg
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
2010-03-22 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page
defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):
2010-03-19 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Fixed a crash with AnimationController getting deleted out from under itself.
It's possible for the Frame that owns an AnimationController to get deleted
in the EndTransitionEvent (or other animation events) to get deleted in the
event handler. Normally this case is protected against by preventing the Frame
from getting deleted until the end of the runloop. But native uses of the
WebView can subvert this protection. So I added a protector to the
animation event dispatcher to protect it in those cases.
Test: transitions/transition-end-event-destroy-iframe.html
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
2010-03-17 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
databaseIdentifiers are not filtered for slashes
<rdar://problem/7708789> and https://bugs.webkit.org/show_bug.cgi?id=36243
In addition to filtering for '/' and '\', to remove the directory vulnerability
on all platforms, it seems worth it to also escape other characters that are
obviously dangerous or illegal to have in a filename (mostly inspired by the
Windows illegal-character list).
No new tests - It's unclear how a test could possibly work into our testing
infrastructure.
* page/SecurityOrigin.cpp:
(WebCore::): Added a 128-bool table "needsEscaping" that has a true/false answer
for lower-ASCII.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier): "Unescape" the host
component using the KURL utility.
(WebCore::shouldEscapeUChar): If the char is lower-ASCII, look it up in the
needsEscaping table. Otherwise, let it pass.
(WebCore::encodedHost): Modeled after KURL's host escaping method, but targeted
for the escaping considerations for the host component. We don't use the KURL
version because this one is "different" enough because it operates on UTF16 and
has its own "is bad character?" decider.
(WebCore::SecurityOrigin::databaseIdentifier): Create the escaped host if needed,
and use it instead of the unescaped host.
* page/SecurityOrigin.h:
2010-03-16 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
REGRESSION (r53857): Crash when tabbing to <map>
https://bugs.webkit.org/show_bug.cgi?id=36017
Test: fast/events/imagemap-norender-crash.html
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug.
* platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
* platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
* platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support.
* platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac.
* platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call.
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
Causes "layout tables" to be exposed as AccessibilityTables for Gtk.
* accessibility/AccessibilityTable.cpp:
(AccessibilityTable::isTableExposableThroughAccessibility):
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Build fix for distcheck.
* GNUmakefile.am:
2010-03-15 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36152
[chromium] Add support for history.pushState and history.replaceState
This is covered by the existing tests in fast/loader/stateobjects
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Deserializer::deserialize):
(WebCore::SerializedScriptValue::deserialize):
* bindings/v8/SerializedScriptValue.h:
Switch to returning v8::Null instead of the empty value to match JSC
and the spec.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument): Call
dispatchDidNavigateWithinPage just before dispatching events to the
page. This ordering is important since the event handlers could
destroy the page or start another navigation.
* loader/FrameLoaderClient.h: Add dispatchDidNavigateWithinPage to
notify the client whenever a navigation occurs without changing any of
the documents in the page.
2010-03-16 Adam Roben <aroben@apple.com>
Fix linker warnings when building WebCore on Windows
Rubber-stamped by Steve Falkenburg.
* WebCore.vcproj/WebCore.vcproj: Exclude JSDOMFormData.cpp from the
build, since it's already included in DerivedSources.cpp. Also let VS
sort this file as it saw fit.
2010-03-15 Antti Koivisto <koivisto@iki.fi>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling
Translate coordinates correctly.
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
2010-03-16 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Eric Seidel.
[Qt] MediaPlayerPrivate: Initialize m_mediaPlayerControl to 0 to avoid crashes
when no media services can be found.
https://bugs.webkit.org/show_bug.cgi?id=36142
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2010-03-16 Adam Barth <abarth@webkit.org>
Unreviewed.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Add missing "!" in plugin code. Should fix plugins/embed-inside-object
on Gtk and Qt.
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
2010-03-16 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Delete DerivedSourcesAllInOne.cpp.
https://bugs.webkit.org/show_bug.cgi?id=33048
* Android.v8bindings.mk:
* bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Revert r56006 as it caused functional issues. We will work on a
testcase, and rework the fix, and land when we have this a bit
more testable.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaPlayButton):
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML.
https://bugs.webkit.org/show_bug.cgi?id=35025
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMWindow.prototype.Object):
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update.callback):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._update):
2010-03-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Spatial Navigation: Add a scrollIntoView call when focusing an element.
https://bugs.webkit.org/show_bug.cgi?id=36020
When focusing an element in Spatial Navigation logic, it is desired to make
this element visible in the current viewport. For that to happen, there
could be a call to Element's scrollIntoView method at focusing time. However
for visual aspects, it is preferable to scroll to an inflated rect of |element|
in order to consider the focus outline width.
As Element's scrollIntoView method does not provide this flexibility, patch adds
a custom scrollIntoView method to SpatialNavigation.h .
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::scrollIntoView):
* page/SpatialNavigation.h:
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Normalize timeout priorities through the GStreamer media player as
a whole. This should help avoid that any of them is starved.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::muteChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_render):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Use default priority also for parsing data: URIs.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::startData):
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Normalize SharedTimers priorities to always be
G_PRIORITY_DEFAULT. As it is currently, timers that should happen
immediately (0 miliseconds delay) end up delayed by a lot of time
due to glib starving lower priority sources.
* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireTime):
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add support for Fast Mobile Scrolling in the build system.
* GNUmakefile.am:
2010-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* GNUmakefile.am:
* WebCore.Inspector.exp:
* WebCore.base.exp:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InspectorClient.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowVisible):
(WebCore::InspectorController::frontendReady):
(WebCore::InspectorController::willCloseFrontend):
(WebCore::InspectorController::addConsoleMessage):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::inspectedWindowScriptObjectCleared):
(WebCore::InspectorController::setFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
(WebCore::InspectorController::releaseDOMAgent):
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
* inspector/InspectorController.h:
(WebCore::InspectorController::hasInspectorFrontendClient):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::InspectorFrontend):
(WebCore::InspectorFrontend::~InspectorFrontend):
(WebCore::InspectorFrontend::addConsoleMessage):
(WebCore::InspectorFrontend::bringToFront):
(WebCore::InspectorFrontend::inspectedURLChanged):
* inspector/InspectorFrontend.h:
* inspector/InspectorFrontendClient.h: Added.
(WebCore::InspectorFrontendClient::~InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.cpp: Added.
(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::FrontendMenuProvider::~FrontendMenuProvider):
(WebCore::FrontendMenuProvider::populateContextMenu):
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::moveWindowBy):
(WebCore::InspectorFrontendClientLocal::showContextMenu):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
* inspector/InspectorFrontendClientLocal.h: Added.
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::InspectorFrontendHost):
(WebCore::InspectorFrontendHost::~InspectorFrontendHost):
(WebCore::InspectorFrontendHost::loaded):
(WebCore::InspectorFrontendHost::attach):
(WebCore::InspectorFrontendHost::detach):
(WebCore::InspectorFrontendHost::closeWindow):
(WebCore::InspectorFrontendHost::bringToFront):
(WebCore::InspectorFrontendHost::inspectedURLChanged):
(WebCore::InspectorFrontendHost::canAttachWindow):
(WebCore::InspectorFrontendHost::setAttachedWindowHeight):
(WebCore::InspectorFrontendHost::moveWindowBy):
(WebCore::InspectorFrontendHost::showContextMenu):
* inspector/InspectorFrontendHost.h:
(WebCore::InspectorFrontendHost::create):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.bringToFront):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.close):
(WebInspector.bringToFront):
(WebInspector.inspectedURLChanged):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::openInspectorFrontend):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
* page/Page.h:
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
(WebCore::ContextMenu::addInspectElementItem):
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate to native styles inspector in
order to inspect styles from foreighn domains.
https://bugs.webkit.org/show_bug.cgi?id=36117
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::getStyles):
(WebCore::InspectorBackend::getInlineStyle):
(WebCore::InspectorBackend::getComputedStyle):
(WebCore::InspectorBackend::applyStyleText):
(WebCore::InspectorBackend::setStyleText):
(WebCore::InspectorBackend::setStyleProperty):
(WebCore::InspectorBackend::toggleStyleEnabled):
(WebCore::InspectorBackend::setRuleSelector):
(WebCore::InspectorBackend::addRule):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getInlineStyle):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):
(WebCore::InspectorDOMAgent::getAttributeStyles):
(WebCore::InspectorDOMAgent::applyStyleText):
(WebCore::InspectorDOMAgent::setStyleText):
(WebCore::InspectorDOMAgent::setStyleProperty):
(WebCore::InspectorDOMAgent::toggleStyleEnabled):
(WebCore::InspectorDOMAgent::setRuleSelector):
(WebCore::InspectorDOMAgent::addRule):
(WebCore::InspectorDOMAgent::bindStyle):
(WebCore::InspectorDOMAgent::bindRule):
(WebCore::InspectorDOMAgent::buildObjectForStyle):
(WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
(WebCore::InspectorDOMAgent::buildObjectForRule):
(WebCore::InspectorDOMAgent::uniqueStyleProperties):
(WebCore::InspectorDOMAgent::longhandProperties):
(WebCore::InspectorDOMAgent::shorthandPriority):
(WebCore::InspectorDOMAgent::ruleAffectsNode):
(WebCore::InspectorDOMAgent::toArray):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didGetEventListenersForNode):
(WebCore::InspectorFrontend::didGetStyles):
(WebCore::InspectorFrontend::didGetComputedStyle):
(WebCore::InspectorFrontend::didGetInlineStyle):
(WebCore::InspectorFrontend::didApplyStyleText):
(WebCore::InspectorFrontend::didSetStyleText):
(WebCore::InspectorFrontend::didSetStyleProperty):
(WebCore::InspectorFrontend::didToggleStyleEnabled):
(WebCore::InspectorFrontend::didSetRuleSelector):
(WebCore::InspectorFrontend::didAddRule):
* inspector/InspectorFrontend.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.CSSStyleDeclaration):
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/InjectedScript.js:
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.):
2010-03-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
RenderText::m_text should be a String, not RefPtr<StringImpl>
https://bugs.webkit.org/show_bug.cgi?id=36010
Refactoring only, so no new tests.
* platform/text/PlatformString.h:
(WebCore::String::makeLower):
(WebCore::String::makeUpper):
(WebCore::String::makeSecure):
(WebCore::String::makeCapitalized):
(WebCore::String::containsOnlyASCII):
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::containsOnlyWhitespace):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::setText):
(WebCore::RenderText::previousOffset):
(WebCore::RenderText::previousOffsetForBackwardDeletion):
(WebCore::RenderText::nextOffset):
* rendering/RenderText.h:
(WebCore::RenderText::text):
(WebCore::RenderText::characters):
(WebCore::RenderText::textLength):
2010-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Instead of talking to Settings directly to figure out if JavaScript is
enabled in a frame, we need to talk to the ScriptController. The
ScriptController is better at answering that question because it knows
about @sandbox.
Test: fast/frames/sandboxed-iframe-noscript.html
* dom/Document.cpp:
(WebCore::Document::Document):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createRenderer):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsNeeded):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::noscriptCreateErrorCheck):
(WebCore::HTMLParser::isInline):
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
2010-03-15 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800
Covered by existing tests.
* notifications/Notification.cpp:
(WebCore::Notification::Notification):
* notifications/Notification.h:
(WebCore::Notification::iconURL):
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35887
* platform/efl/ClipboardEfl.cpp: Added.
* platform/efl/PasteboardEfl.cpp: Added.
2010-03-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056
Test: fast/forms/menulist-disabled-selected-option.html
* dom/OptionElement.h:
* dom/SelectElement.cpp:
(WebCore::SelectElement::appendFormData):
If a selected option is disabled, skip it.
Remove code for non-selected menulist because of compatibility with
other browsers.
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35884
* platform/efl/FileSystemEfl.cpp: Added.
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35882
* platform/efl/ContextMenuItemEfl.cpp: Added.
2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
Simple change to stop tables from implementing AtkText.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(getInterfaceMaskFromObject):
2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Adam Barth.
According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only.
https://bugs.webkit.org/show_bug.cgi?id=33210
* page/EventSource.cpp:
(WebCore::EventSource::parseEventStreamLine):
2010-03-15 Valters Svabe <vsvabe@gmail.com>
Reviewed by Darin Adler.
:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288
Make sure we don't append things after :after-generated content, if
it's inside an anonymous block.
Test: fast/css-generated-content/block-after.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChild):
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
Add EFL port files to platform/efl.
http://webkit.org/b/35885
* platform/efl/KURLEfl.cpp: Added.
2010-03-15 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
When a label element is used as a click event handler, and it doesn't have any
corresponding control, it should handle the action itself.
Test: accessibility/label-element-press.html
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::accessKeyAction):
2010-03-15 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 36135 - GCController::garbageCollectNow() crashes when called from garbage collection
<https://bugs.webkit.org/show_bug.cgi?id=36135>
<rdar://problem/7752552>
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow): Fail silently if garbage collection is
active rather than hitting the CRASH() reentrancy guard.
2010-03-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Drop out of compositing mode when no elements need to composite
https://bugs.webkit.org/show_bug.cgi?id=36134
When no more elements on the page need to be composited, drop out of compositing
mode altogether, including removing the layer-backed view that hosts the layers.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): If the list of child layers to attach at
the root is empty, we have no composited layers, and can drop out of compositing mode by calling
willMoveOffscreen().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): In several places,
use willBeComposited rather than calling needsToBeComposited(), because it avoids
recomputing state that we know already (but assert that we're getting it right).
When we're assessing the root layer in post-order, see if we have any child layers that
are compositing, and also whether the root itself needs to composite. If neither are
true, then we can drop out of compositing mode.
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Move the
"inCompositingMode() && layer->isRootLayer()" test out of requiresCompositingLayer()
and into needsToBeComposited() so that we can call requiresCompositingLayer() separately
on the root layer above.
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35888
* platform/efl/SoundEfl.cpp: Added.
2010-03-15 Andy Estes <aestes@apple.com>
Reviewed by John Sullivan.
For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
Mice), set the number of wheel ticks equal to the atomic increment of
the device: a pixel. This ensures that any scrolling action will
generate at least one wheel tick, regardless of the speed/length of
the gesture.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>
Tests: fast/events/continuous-platform-wheelevent-in-scrolling-div.html
fast/events/platform-wheelevent-in-scrolling-div.html
* platform/mac/WebCoreSystemInterface.h: Modify method signature.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Call into
WebKitSystemInterface to determine both wheelTicksX/Y and deltaX/Y.
WKSI will query the event system for number of wheel ticks and
pixels/lines scrolled based on the device type.
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] duration query optimizations
https://bugs.webkit.org/show_bug.cgi?id=36116
Don't reattempt duration queries that previously failed and cache
media duration only if it's known.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::durationChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-11 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Clean up more bits of the open-source image decoders. In addition to
simplifying things somewhat, this makes all the decoders the same in
terms of how they construct "image reader" subclasses and init scale
data.
https://bugs.webkit.org/show_bug.cgi?id=36040
No functional change, so no tests.
* platform/image-decoders/ImageDecoder.h: Reorder a few declarations to try and group/order members slightly better.
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/gif/GIFImageDecoder.cpp: Move reader construction into decode(). Prep scale data in setSize(). Remove useless comment.
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::setSize):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
* platform/image-decoders/gif/GIFImageDecoder.h: Prep scale data in setSize().
* platform/image-decoders/gif/GIFImageReader.cpp: Prep scale data in setSize().
(GIFImageReader::read):
* platform/image-decoders/ico/ICOImageDecoder.cpp: Shorten code.
(WebCore::ICOImageDecoder::setSize):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Fix style. Move reader construction into decode().
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h: Move reader construction into decode().
(WebCore::JPEGImageDecoder::filenameExtension):
* platform/image-decoders/png/PNGImageDecoder.cpp: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize(). Remove useless comment.
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setSize):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.h: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize().
(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::isComplete):
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] updateStates called for all elements posting a state-change
https://bugs.webkit.org/show_bug.cgi?id=36115
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateMessageCallback): Update player state
only for state-change messages coming from playbin2 directly.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivate::pipeline): public accessor for the
playbin element.
2010-03-15 Jian Li <jianli@chromium.org>
Reviewed by Nate Chapin.
[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026
Test: http/tests/local/send-form-data.html
* Android.v8bindings.mk:
* WebCore.gypi:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
2010-03-15 Jian Li <jianli@chromium.org>
Reviewed by Sam Weinig.
Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024
The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
Test: http/tests/local/send-form-data.html
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.jscbindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Added.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* html/DOMFormData.idl: Added.
* page/DOMWindow.idl:
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32369
Revise iframe sandbox behavior to match the updated HTML5 spec.
- Enables window.sessionStorage in sandboxed iframes.
- Raises SECURITY_ERR exceptions when window.localStorage or
window.openDatabase() is blocked by iframe sandboxing.
Note: window.sessionStorage does not raise exceptions.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
* inspector/InspectorController.cpp:
(WebCore::InspectorController::selectDOMStorage): exception handling
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::handleEvent): exception handling
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage): re-enabled in iframe sandbox
(WebCore::DOMWindow::localStorage): raise exception rather than return null
(WebCore::DOMWindow::openDatabase): raise exception rather than return null
* page/DOMWindow.h: added exceptions to interface
* page/DOMWindow.idl: added exceptions to interface
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessLocalStorage): renamed function to reflect its purpose
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch): exception handling
2010-03-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement a progress indicator in the Audits panel
when resources are reloading
https://bugs.webkit.org/show_bug.cgi?id=35971
* English.lproj/localizedStrings.js:
* GNUmakefile.am:
* WebCore.gypi:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
(WebInspector.AuditLauncherView.prototype.get totalResources):
(WebInspector.AuditLauncherView.prototype.set totalResources):
(WebInspector.AuditLauncherView.prototype.get loadedResources):
(WebInspector.AuditLauncherView.prototype.set loadedResources):
(WebInspector.AuditLauncherView.prototype._resetResourceCount):
(WebInspector.AuditLauncherView.prototype.resourceStarted):
(WebInspector.AuditLauncherView.prototype.resourceFinished):
(WebInspector.AuditLauncherView.prototype.reset):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createCategoryElement):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype.resourceStarted):
(WebInspector.AuditsPanel.prototype.resourceFinished):
(WebInspector.AuditsPanel.prototype.reset):
* inspector/front-end/Images/spinner.gif: Added.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/audits.css:
(.audit-launcher-view .resource-progress > img):
* inspector/front-end/inspector.js:
(WebInspector.updateResource):
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735
Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::volumeChangedTimerFired):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::fillTimerFired):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::muteChangedTimerFired):
(WebCore::MediaPlayerPrivate::muteChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793
Only effectively load, and start buffering when playing, or when
the preload attribute is set.
Test: media/video-preload.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::commitLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::setPreload):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Holger Freyther.
[Qt] The behavior of QGradient with no stops is defined differently from HTML5 spec,
where the latter requires the gradient to be transparent black. Explicitly added a
transparent black color stop to match the HTML5 behavior.
https://bugs.webkit.org/show_bug.cgi?id=36060
* platform/graphics/qt/GradientQt.cpp:
(WebCore::Gradient::platformGradient):
2010-03-11 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Holger Freyther.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Some minor code clean ups in SpatialNavigation.cpp
* page/SpatialNavigation.cpp:
(WebCore::distanceInDirection):
(WebCore::deflateIfOverlapped):
2010-03-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Position of GraphBar elements is calculating more carefully
and they fully visible at the bottom of Timeline panel.
http://bugs.webkit.org/show_bug.cgi?id=35966
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordGraphRow.prototype.update):
2010-03-15 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413
Selection.modify() with 'lineboundary' granularity implies just
"Go to the end of the line", unlike selection expansion with
other type of granularities. This change handled LineGranularity
as special case, to look-up end of line with UPSTREAM affinity.
Doing this prevents look-up algorithm to go next line.
Test: editing/selection/extend-selection-expected.txt
* dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
Handled an edge case for node look-up with UPSTREAM.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingForward):
Added UPSTREAM tweak for the case for LineGranularity.
2010-03-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Always call PrintContext.end() from PrintContext::pageNumberForElement().
Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.
https://bugs.webkit.org/show_bug.cgi?id=36049
Test: printing/return-from-printing-mode.html
* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
2010-03-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] progressTimer never stopped after EOS
https://bugs.webkit.org/show_bug.cgi?id=36007
Mark the pipeline as paused only if playback hasn't ended
yet. When didEnd() is triggered, the pipeline is paused (but
paused() still returns false) and a timeupdate event is fired,
those 2 conditions allow the HTMLMediaElement to stop the
progressTimer (in updatePlayerState, via mediaPlayerTimeChanged).
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::updateStates):
2010-03-14 Chang Shu <chang.shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] [Symbian] Added block for ENABLE_SYMBIAN_DIALOG_PROVIDERS
on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=35919
* WebCore.pro:
2010-03-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Support for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=35937
Added support for HTMLProgressElement.
This implementation is enabled only for Qt, because only RenderThemeQt
was modified to actually draw the progress element.
The labels attribute of the progress element will be implemented in a
separate patch.
Tests: fast/dom/HTMLProgressElement/progress-element.html
fast/dom/HTMLProgressElement/set-progress-properties.html
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSValueKeywords.in:
* css/html.css:
* html/HTMLElement.cpp:
(WebCore::inlineTagList):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
* html/HTMLFormControlElement.h:
* html/HTMLProgressElement.cpp: Added.
(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::create):
(WebCore::HTMLProgressElement::createRenderer):
(WebCore::HTMLProgressElement::formControlType):
(WebCore::HTMLProgressElement::parseMappedAttribute):
(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):
(WebCore::HTMLProgressElement::position):
* html/HTMLProgressElement.h: Added.
(WebCore::HTMLProgressElement::isOptionalFormControl):
* html/HTMLProgressElement.idl: Added.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:
* platform/ThemeTypes.h:
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintProgressBar):
* platform/qt/RenderThemeQt.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::isProgress):
* rendering/RenderProgress.cpp: Added.
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::baselinePosition):
(WebCore::RenderProgress::calcPrefWidths):
(WebCore::RenderProgress::layout):
(WebCore::RenderProgress::updateFromElement):
* rendering/RenderProgress.h: Added.
(WebCore::RenderProgress::renderName):
(WebCore::RenderProgress::isProgress):
(WebCore::toRenderProgress):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustProgressBarStyle):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintProgressBar):
2010-03-14 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095
The issue here is that while dropEffect is meant to be initialized
to "none", the behaviour of the drag is differs between dragEffect
not being set and dragEffect being explicitly set to "none"
This patch corrects this behaviour by making Clipboard distinguish
between the initial "none" value of dropEffect and an explicit "none".
This alone is insufficient for correct behaviour, we also need to
resurrect the removed defaultOperationForDrag function, but we now
use the function only when dragEffect is uninitialized. There are a
few tweaks to the behaviour of the defaultOperationForDrag as well
to ensure exactly the same set of outcomes for all cases that we
may hit it.
* dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):
(WebCore::dragOpFromIEOp):
(WebCore::Clipboard::destinationOperation):
* dom/Clipboard.h:
(WebCore::Clipboard::dropEffect):
(WebCore::Clipboard::dropEffectIsUninitialized):
* page/DragController.cpp:
(WebCore::defaultOperationForDrag):
(WebCore::DragController::tryDHTMLDrag):
2010-03-14 Antti Koivisto <koivisto@iki.fi>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store
Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.
The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.
The feature is behind ENABLE_TILED_BACKING_STORE flag.
* WebCore.pri:
* WebCore.pro:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setTiledBackingStoreEnabled):
(WebCore::Frame::tiledBackingStorePaintBegin):
(WebCore::Frame::tiledBackingStorePaint):
(WebCore::Frame::tiledBackingStorePaintEnd):
(WebCore::Frame::tiledBackingStoreContentsRect):
* page/Frame.h:
(WebCore::Frame::tiledBackingStore):
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setTiledBackingStoreEnabled):
* page/Settings.h:
(WebCore::Settings::tiledBackingStoreEnabled):
* platform/graphics/Tile.h: Added.
(WebCore::Tile::create):
(WebCore::Tile::coordinate):
(WebCore::Tile::rect):
* platform/graphics/TiledBackingStore.cpp: Added.
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::viewportChanged):
(WebCore::TiledBackingStore::setContentsScale):
(WebCore::TiledBackingStore::tileDistance):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::dropOverhangingTiles):
(WebCore::TiledBackingStore::dropTilesOutsideRect):
(WebCore::TiledBackingStore::tileAt):
(WebCore::TiledBackingStore::setTile):
(WebCore::TiledBackingStore::removeTile):
(WebCore::TiledBackingStore::mapToContents):
(WebCore::TiledBackingStore::mapFromContents):
(WebCore::TiledBackingStore::contentsRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::tileCoordinateForPoint):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::startTileCreationTimer):
(WebCore::TiledBackingStore::tileCreationTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):
* platform/graphics/TiledBackingStore.h: Added.
(WebCore::TiledBackingStore::contentsScale):
(WebCore::TiledBackingStore::contentsFrozen):
* platform/graphics/TiledBackingStoreClient.h: Added.
* platform/graphics/qt/TileQt.cpp: Added.
(WebCore::checkeredPixmap):
(WebCore::Tile::Tile):
(WebCore::Tile::~Tile):
(WebCore::Tile::isDirty):
(WebCore::Tile::isReadyToPaint):
(WebCore::Tile::invalidate):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::swapBackBufferToFront):
(WebCore::Tile::paint):
(WebCore::Tile::paintCheckerPattern):
2010-03-14 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
WebCore part of removing support for legacy versions of Core Graphics
* WebCore.vcproj/WebCore.vcproj: Removed FontDatabase.{cpp,h}
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Removed call to wkCanCreateCGFontWithLOGFONT(),
as it is now always true.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Ditto.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Updated for
the removal of m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
(WebCore::createFontCustomPlatformData): Ditto. Also updated for change to
the FontCustomPlatformData constructor.
* platform/graphics/win/FontCustomPlatformData.h: Removed m_cgFont member.
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed cgFont
parameter.
* platform/graphics/win/FontDatabase.cpp: Removed.
* platform/graphics/win/FontDatabase.h: Removed.
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::platformDataInit): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::populateFontDatabase): Removed stub.
2010-03-14 Jessie Berlin <jberlin@webkit.org>
Reviewed by Sam Weinig.
"event.ctrlKey" is always false when dragging an element with "ctrl" key down
https://bugs.webkit.org/show_bug.cgi?id=17113
No new tests.
* page/DragController.cpp:
(WebCore::createMouseEvent):
Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.
2010-03-13 Antonio Gomes <tonikitoo@webkit.org>
Not reviewed identation fix.
* manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
https://bugs.webkit.org/show_bug.cgi?id=36034
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::OpacityAnimationQt::applyFrame):
2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: Opacity transitions end with begin value
https://bugs.webkit.org/show_bug.cgi?id=36019
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::AnimationQt::updateCurrentTime):
2010-03-13 Dirk Schulze <krit@webkit.org>
No review, rolling out r55927.
http://trac.webkit.org/changeset/55927
https://bugs.webkit.org/show_bug.cgi?id=35793
Breaks Gtk build bots.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::setPreload):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070
SVGFont should transform the path of a glyph, not the context. Modifying
the context causes wrong gradient transformations. This bug doesn't
influence CG because we generally fill or stroke texts with a mask image.
All other platforms provide a direct way to make the drawings.
* svg/SVGFont.cpp:
(WebCore::Font::drawTextUsingSVGFont):
2010-03-12 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>
This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):
* html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):
* html/HTMLVideoElement.idl:
* platform/graphics/mac/MediaPlayerProxy.h:
2010-03-12 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Add virtual destructor to DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=36077
DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.
No new tests, no change in behavior
* bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 36075 - Clean up screwyness re static string impls & Identifiers.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT
* platform/text/StringImpl.h:
(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.
2010-03-12 Enrica Casucci <enrica@apple.com>
Reviewed by Simon Fraser.
Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>
There were two problems to solve here:
- the incorrect anchoring of the rootChildLayer that was causing the composited
content to be positioned incorrectly
- the failure to paint the non composited content into the backing store when
animating composited content.
The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.
Tests: compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/vertical-scroll-composited.html
* manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
* manual-tests/win/milliondollar.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.
* platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.
2010-03-12 Robert Hogan <robert@webkit.org>
Not reviewed, build fix.
Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
the !ENABLE(DATABASE) build on all platforms when attempting to fix the
--minimal build on Qt.
Support for SQLite now seems to be non-negotiable for the Qt build but making
it mandatory requires review, so re-break --minimal Qt build for now.
Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073
* page/GeolocationPositionCache.cpp:
2010-03-12 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
<rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
https://bugs.webkit.org/show_bug.cgi?id=35507
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.
2010-03-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash
r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):
2010-03-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479
Use a given fallback color on ignored gradients if present. Gradients
must be ignored, if one dimension of the objects boundingBox is zero.
Test: svg/custom/gradient-with-1d-boundingbox.svg
* svg/graphics/SVGPaintServer.cpp:
(WebCore::SVGPaintServer::strokePaintServer):
* svg/graphics/SVGPaintServerGradient.cpp:
(WebCore::SVGPaintServerGradient::setup):
2010-03-12 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=36069
Eliminate InlineRunBox.
* WebCore.xcodeproj/project.pbxproj:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):
* rendering/InlineRunBox.h: Removed.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localBoundingBox):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):
* rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):
* rendering/RenderText.cpp:
(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793
Only effectively load, and start buffering when playing, or when
the preload attribute is set.
Test: media/video-preload.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::commitLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::setPreload):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-12 Dmitry Titov <dimich@chromium.org>
Not reviewed, build fix.
Reverts 55920 and 55921. Landing for Jian Li.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Removed.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
* html/DOMFormData.idl: Removed.
* page/DOMWindow.idl:
2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Add support for drawing text to PainterOpenVG
https://bugs.webkit.org/show_bug.cgi?id=35581
Doesn't come with any actual font classes, as OpenVG
by itself doesn't provide any access to platform fonts
but just the means to draw glyphs that have been loaded
manually before.
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PlatformPainterState::PlatformPainterState):
(WebCore::PlatformPainterState::copyPaintState):
(WebCore::PainterOpenVG::textDrawingMode):
(WebCore::PainterOpenVG::setTextDrawingMode):
(WebCore::PainterOpenVG::drawText):
* platform/graphics/openvg/PainterOpenVG.h:
2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Use masks to implement non-rectilinear clipping
https://bugs.webkit.org/show_bug.cgi?id=35544
Requires some additional context switching logic to
make sure the right context is current when dealing
with the mask, because we don't store it by ourselves.
Initial version of this code was written by
Eli Fidler <efidler@rim.com>, I did a couple of
bug fixes and efficiency improvements since then.
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PlatformPainterState::PlatformPainterState):
(WebCore::PlatformPainterState::~PlatformPainterState):
(WebCore::PlatformPainterState::maskingEnabled):
(WebCore::PlatformPainterState::applyState):
(WebCore::PlatformPainterState::saveMaskIfNecessary):
(WebCore::PainterOpenVG::intersectClipRect):
(WebCore::PainterOpenVG::clipPath):
(WebCore::PainterOpenVG::save):
* platform/graphics/openvg/PainterOpenVG.h:
(WebCore::PainterOpenVG::):
* platform/graphics/openvg/SurfaceOpenVG.cpp:
(WebCore::SurfaceOpenVG::makeCurrent):
(WebCore::SurfaceOpenVG::makeCompatibleCurrent):
* platform/graphics/openvg/SurfaceOpenVG.h:
(WebCore::SurfaceOpenVG::):
2010-03-12 Jian Li <jianli@chromium.org>
Reviewed by Sam Weinig.
Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024
The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
Test: http/tests/local/send-form-data.html
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Added.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* html/DOMFormData.idl: Added.
* page/DOMWindow.idl:
2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
https://bugs.webkit.org/show_bug.cgi?id=35538
SurfaceOpenVG can now not only encapsulate pbuffer
and window surfaces but also VGImage-based ones.
* platform/graphics/openvg/EGLDisplayOpenVG.cpp:
(WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
* platform/graphics/openvg/EGLDisplayOpenVG.h:
* platform/graphics/openvg/SurfaceOpenVG.cpp:
(WebCore::SurfaceOpenVG::SurfaceOpenVG):
* platform/graphics/openvg/SurfaceOpenVG.h:
2010-03-12 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Fix a crash when resource loading of media element is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992
Use of HTMLMediaElement::duration() after resource loading was canceled
will cause a crash. This is because HTMLMediaElement::m_player is used
when NULL.
Test: http/tests/media/video-cancel-load.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::duration):
Avoid calling to m_player when it is null.
(WebCore::HTMLMediaElement::userCancelledLoad):
Set m_readyState to HAVE_NOTHING.
2010-03-12 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
https://bugs.webkit.org/show_bug.cgi?id=20069
No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.
* css/CSSPrimitiveValue.cpp:
(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.
2010-03-12 Dan Bernstein <mitz@apple.com>
Build fix.
* platform/chromium/PlatformKeyboardEventChromium.cpp:
2010-03-12 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
https://bugs.webkit.org/show_bug.cgi?id=35949
Test: fast/events/overflow-scroll-fake-mouse-move.html
Soon after an overflow section scrolls under the mouse pointer, dispatch
a fake mouse move event. This is similar to how frame scrolling is handled
in WebKit, and has the effect of updating hover state, dispatching DOM mouse
events, and updating the tool tip.
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
(WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
(WebCore::EventHandler::clear): Stop the timer.
(WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
move events.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
is in the passed-in quad, ensure that a fake mouse move event is scheduled
to fire soon.
(WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
PlatformMouseEvent with the current mouse location, modifier key state and
time stamp and calls mouseMoved().
* page/EventHandler.h:
* platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
* platform/android/KeyEventAndroid.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
* platform/brew/PlatformKeyboardEventBrew.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
* platform/chromium/PlatformKeyboardEventChromium.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
* platform/haiku/PlatformKeyboardEventHaiku.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
* platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
* platform/wx/KeyboardEventWx.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset): Call
EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
a little to avoid computing the repaint rect twice.
2010-03-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Webkit doesn't build with workers on and database off
https://bugs.webkit.org/show_bug.cgi?id=35997
Added missing ENABLE(DATABASE) guards.
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):
2010-03-12 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha.
Make the defaultCookieJar use a no-third-party policy. Most
applications set their own cookie jar, but DumpRenderTree doesn't,
so it was failing the new third-party-cookie test.
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::defaultCookieJar):
2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983
* WebCore.pri:
* platform/network/qt/NetworkStateNotifierPrivate.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:
2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Adam Treat.
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
(WebCore::FrameView::scrollContentsFastPath):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsFastPath):
* platform/ScrollView.h:
* rendering/RenderBlock.h:
(WebCore::RenderBlock::positionedObjects):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
2010-03-11 Aaron Boodman <aa@chromium.org>
Kill WebDocument::applicationID() (part 1).
Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846
* notifications/Notification.cpp:
(WebCore::Notification::Notification):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::checkPermission):
* notifications/NotificationPresenter.h:
2010-03-11 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
[v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
https://bugs.webkit.org/show_bug.cgi?id=36043
No new tests, no changes in functionality.
* bindings/v8/DOMData.cpp:
(WebCore::DOMData::DOMData):
* bindings/v8/DOMData.h:
(WebCore::DOMData::handleWeakObject):
* bindings/v8/DOMDataStore.cpp:
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):
(WebCore::DOMDataStore::domSvgElementInstanceMap):
(WebCore::DOMDataStore::domSvgObjectWithContextMap):
* bindings/v8/ScopedDOMDataStore.cpp:
(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjectsInCurrentThread):
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Remove nonsense comments used in development & commited in error.
* platform/text/StringImpl.h:
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl
Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
(WebCore::StringImpl::createUninitialized): Added overflow check.
(WebCore::StringImpl::create): Reordered in file.
(WebCore::StringImpl::sharedBuffer): Reordered in file.
* platform/text/StringImpl.h:
(WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
(WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
(WebCore::StringImpl::setHash): Added missing ASSERT.
(WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
(WebCore::StringImpl::characters): Mark as const to match JSC.
(WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
(WebCore::StringImpl::computeHash): Remove redundant 'inline'.
2010-03-11 Mark Rowe <mrowe@apple.com>
Reviewed by David Kilzer.
<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
* Configurations/Base.xcconfig:
2010-03-11 Jungshik Shin <jshin@chromium.org>
[Chromium]: Plane 2 characters are rendered "blank"
(not even empty boxes) on Windows even when there are fonts to
cover them.
https://bugs.webkit.org/show_bug.cgi?id=35605
Test:LayoutTests/fast/text/international/plane2.html
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering.
(WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).
2010-03-11 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35889
* platform/efl/SystemTimeEfl.cpp: Added.
2010-03-11 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.
Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.
Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/FeatureDefines.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebCore.xcconfig:
2010-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:
2010-03-11 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Remove DOMObjectsInclude.h and update headers accordingly.
https://bugs.webkit.org/show_bug.cgi?id=36036
* WebCore.gypi:
* bindings/v8/DOMData.h:
* bindings/v8/DOMDataStore.h:
* bindings/v8/DOMObjectsInclude.h: Removed.
* bindings/v8/V8DOMMap.cpp:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8Proxy.cpp:
2010-03-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
Remove duplicate entries revealed after sorting.
* WebCore.xcodeproj/project.pbxproj:
2010-03-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
Sort the project file (also removing some bogus spaces that caused Xcode to rewrite the file
every time you opened it).
* WebCore.xcodeproj/project.pbxproj:
2010-03-11 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
Fix style issues and improve comments from
http://trac.webkit.org/changeset/55853.
https://bugs.webkit.org/show_bug.cgi?id=36029
* platform/animation/TimingFunction.h:
(WebCore::TimingFunction::TimingFunction):
2010-03-11 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
accessibilityIsIgnoredBase() needs to respect when platform says include
https://bugs.webkit.org/show_bug.cgi?id=36025
Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
answer. This allows the platform to make a yes decision on an element.
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::accessibilityIsIgnored):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
* accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::accessibilityIsIgnored):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/qt/AccessibilityObjectQt.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/win/AccessibilityObjectWin.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/wx/AccessibilityObjectWx.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
2010-03-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Fix build breakage with ENABLE_3D_CANVAS=0
https://bugs.webkit.org/show_bug.cgi?id=35995
No new tests; verified in Chromium that WebGL is disabled in
ENABLE_3D_CANVAS=0 builds.
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2010-03-11 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium mac build fix.
Add an explicit copy constructor to TimingFunction.
http://trac.webkit.org/changeset/55835 trigged an inlining
bug in gcc that the copy constructor resolves.
* platform/animation/TimingFunction.h:
(WebCore::TimingFunction::TimingFunction):
2010-03-11 Chris Fleizach <cfleizach@apple.com>
Fixing GTK. No review.
support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021
We don't need to cast to AccessibilityRenderObject to get language().
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_document_get_locale):
2010-03-11 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021
Allow non AccessibilityRenderObject classes to access the lang
attribute by moving the useful code into AccessibilityObject.
Test: platform/mac/accessibility/option-with-lang.html
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::language):
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::language):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::language):
* accessibility/AccessibilityRenderObject.h:
2010-03-11 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Access key modifier should be Ctrl+Alt for Darwin derived OS and Alt for the others
https://bugs.webkit.org/show_bug.cgi?id=35993
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::accessKeyModifiers):
2010-03-08 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Remove the deprecated argument to url_util::IsStandard in preparation
for deleting that version of the function. Pull the latest googleurl
with the new version for the Chromium builder.
* platform/KURLGoogle.cpp:
(WebCore::KURL::isHierarchical):
2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Make it possible to do builds with separate debug info in packages
* WebCore.pro:
2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Avoid double-buffering with Qt image decoders
Pass QIODevice::Unbuffered when opening the QBuffer that
wraps the image data, to hint to Qt that no extra buffering
is needed.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
2010-03-10 Ben Murdoch <benm@google.com>
Reviewed by Jeremy Orlow.
[Android] The platform touch events on Android are missing support
for key modifiers.
https://bugs.webkit.org/show_bug.cgi?id=35521
Add support in PlatformToucHEventAndroid for the platform supplying
key modifiers with touch events.
Fixes Android so it now passes basic-single-touch-events.html.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Fix two compiler warnings.
* platform/PlatformTouchEvent.h:
(WebCore::PlatformTouchEvent::PlatformTouchEvent): Add support for
key modifiers on Android.
* platform/android/PlatformTouchEventAndroid.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent): ditto.
2010-03-10 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676
Test: fast/dom/Geolocation/maximum-age.html
* WebCore.xcodeproj/project.pbxproj: Modified. Adds GeolocationPositionCache.h to Private headers
* page/Geolocation.cpp: Modified.
(WebCore::Geolocation::GeoNotifier::setUseCachedPosition): Added.
(WebCore::Geolocation::GeoNotifier::runSuccessCallback): Added.
(WebCore::Geolocation::GeoNotifier::timerFired): Modified. Added logic to handle using a cached position
(WebCore::Geolocation::Watchers::contains): Added. Required to determine if a notifier is a watch request
(WebCore::Geolocation::startRequest): Modified. Added logic to check for a cached position
(WebCore::Geolocation::requestUsesCachedPosition): Added. Callback to Geolocation object when notifier uses a cached position
(WebCore::Geolocation::makeCachedPositionCallbacks): Added.
(WebCore::Geolocation::haveSuitableCachedPosition): Added.
(WebCore::Geolocation::setIsAllowed): Modified.
(WebCore::Geolocation::positionChanged): Modified. Make callbacks using cached position where appropriate
(WebCore::Geolocation::geolocationServiceErrorOccurred): Modified. Make callbacks using cached position where appropriate
* page/Geolocation.h: Modified.
2010-03-11 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r55823. (To fix Qt --minimal build.)
I have déjà vu, I'm sure that I did it before. (r55598)
* bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
2010-03-11 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix after r55833.
Rename all instances of data() to characters()
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fieldNamed):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
2010-03-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
Allow custom memory allocation control for RenderLayerBacking class
https://bugs.webkit.org/show_bug.cgi?id=35857
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderLayer.cpp:3047
* rendering/RenderLayerBacking.h:
2010-03-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
Allow custom memory allocation control for TimingFunction struct
https://bugs.webkit.org/show_bug.cgi?id=35855
Inherits the following struct from FastAllocBase because it is
instantiated by 'new':
class name - instantiated at: WebCore/'location'
TimingFuction - platform/graphics/GraphicsLayer.h:89
* platform/animation/TimingFunction.h:
2010-03-10 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::uchars):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
2010-03-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
Fix for r55825, threadsafeCopy no longer needs to special-case for
empty strings (in fact, doing so results in leaks).
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::threadsafeCopy):
2010-03-10 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
https://bugs.webkit.org/show_bug.cgi?id=22150
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColorParameters):
2010-03-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35991
Would be faster to not use a thread specific to implement StringImpl::empty()
Copy JavaScriptCore in making 'static' strings threadsafe, make the empty string a static,
shared by all threads.
~2% progression on Dromaeo DOM core & JS lib tests.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::eventNames):
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::empty):
* platform/text/StringImpl.h:
(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):
2010-03-08 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Adding support for the optional creation callback that could be
passed to openDatabase().
Tests: storage/open-database-creation-callback.html
storage/open-database-creation-callback-isolated-world.html
https://bugs.webkit.org/show_bug.cgi?id=34726
* Android.jscbindings.mk
* Android.v8bindings.mk
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
* bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
* bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
* storage/Database.h:
(WebCore::Database::isNew):
* storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
2010-03-10 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make Chrome consistently handle leading format characters in URLs
https://bugs.webkit.org/show_bug.cgi?id=35948
Test: http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html
* platform/KURLGoogle.cpp:
2010-03-10 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Implementing DOMFormData class.
https://bugs.webkit.org/show_bug.cgi?id=35707
This patch only addresses the implementation of DOMFormData class and
moves the FormData construction logic from HTMLFormElement::createFormData
to FormData::create() so that it can be used by both HTMLFormElement
and XMLHttpRequest.
The DOMFormData IDL interface will be exposed in another patch and the
test will be added then.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/DOMFormData.cpp: Added.
* html/DOMFormData.h: Added.
* html/FormDataList.h:
(WebCore::FormDataList::encoding):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::createFormData):
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:
* platform/network/FormData.cpp:
(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::appendDOMFormData):
* platform/network/FormData.h:
(WebCore::FormData::boundary):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
* xml/XMLHttpRequest.h:
2010-03-10 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986
Elements that are subclassers of AXRenderObject have not been respecting
aria-hidden and other cases that would make them ignored. This applies
to tables, rows, cells, select boxes, sliders, and lists. Select boxes
also need to make sure their option elements respect aria-hidden as well.
Test: accessibility/aria-hidden-with-elements.html
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::accessibilityIsIgnored):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
(WebCore::AccessibilityListBox::doAccessibilityHitTest):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredCommon):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::accessibilityIsIgnored):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
* accessibility/AccessibilityTableColumn.h:
(WebCore::AccessibilityTableColumn::roleValue):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
* accessibility/AccessibilityTableHeaderContainer.h:
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
2010-03-10 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Make Document::postTask to use a single queue of tasks, to fire them in order
https://bugs.webkit.org/show_bug.cgi?id=35943
Test: existing worker-cloneport.html which was broken by initial patch in http://trac.webkit.org/changeset/55593.
Additional test which indirectly verifies the order of execution will come as part of https://bugs.webkit.org/show_bug.cgi?id=34726
* dom/Document.cpp:
(WebCore::Document::postTask): Always use the same task queue, independent of what thread is posting the task.
2010-03-10 Sanjeev Radhakrishnan <sanjeevr@chromium.org>
Reviewed by Darin Fisher.
Allow a plugin to participate in the browser's print workflow.
https://bugs.webkit.org/show_bug.cgi?id=35550
* loader/PluginDocument.cpp:
* loader/PluginDocument.h:
2010-03-10 Ilya Tikhonovsky <loislo@loislo-macbookpro.local>
Reviewed by Pavel Feldman.
Sidebar resize element height was adjusted.
Display name for Function Call details was adjusted.
https://bugs.webkit.org/show_bug.cgi?id=35939
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2010-03-10 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos.
Fix https://bugs.webkig.org/show_bug.cgi?id=35207
When XHTMLMP is enabled, all xhtml documents fail to render for webkit portings wich use libxml2 tokenizer.
No new tests as all the xhtml test cases in LayoutTests/dom/xhtml fails without this fix when XHTMLMP is enabled.
* dom/Document.cpp:
(WebCore::Document::isXHTMLMPDocument):
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::internalSubset):
(WebCore::externalSubsetHandler):
2010-03-10 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Adding all of the touch-related sources into Chromium's WebCore build.
https://bugs.webkit.org/show_bug.cgi?id=35874
Patch tested against the try bots, but the feature is exercised in the
fast/events/touch tests.
* WebCore.gypi:
2010-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: now that audits panel is added, add it to the
enums (for storing last active, etc.).
https://bugs.webkit.org/show_bug.cgi?id=35980
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::specialPanelForJSName):
* inspector/InspectorController.h:
(WebCore::InspectorController::):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::showPanel):
* inspector/front-end/inspector.js:
(WebInspector.showAuditsPanel):
2010-03-10 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Instead of describing the type of a wrapped v8 object
with an enum value, use a pointer to struct with more complete
information.
https://bugs.webkit.org/show_bug.cgi?id=35941
Refactoring only, so new tests.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/DOMData.cpp:
* bindings/v8/DOMData.h:
* bindings/v8/NPV8Object.cpp:
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWindowShell.h:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8Helpers.cpp:
* bindings/v8/V8Helpers.h:
* bindings/v8/V8Index.cpp: Removed.
* bindings/v8/V8Index.h:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.h:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.h:
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
* bindings/v8/custom/V8HTMLOptionElementConstructor.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
* bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
* bindings/v8/custom/V8WebGLArrayCustom.h:
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
* bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp:
* bindings/v8/custom/V8WorkerCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2010-03-10 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Extend keyboard navigation to allow directional navigation (Manual tests)
https://bugs.webkit.org/show_bug.cgi?id=18662
Adds a manual tests for the Spatial Navigation feature comprasing varios
Html focusable elements (e.g. <a>, <table>, <iframe>) and much of the logic
provided by the feature.
* manual-tests/spatial-navigation/links.html: Added.
* manual-tests/spatial-navigation/spatial-navigation-test-cases.html: Added.
2010-03-10 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35890
* platform/efl/ScrollbarEfl.h: Added.
* platform/efl/ScrollbarThemeEfl.h: Added.
2010-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Audits panel needs an icon.
Landing icon attached by Timothy. Enabling panel!
https://bugs.webkit.org/show_bug.cgi?id=35945
* WebCore.gypi:
* inspector/front-end/Images/auditsIcon.png: Added.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Roll-out r55657, as Xan noticed a bad degradation in playing
youtube HTML5 videos with it, that is fixed with it
reverted. Looks like we'll need to work a bit more on this.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::volumeChangedTimerFired):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::fillTimerFired):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::muteChangedTimerFired):
(WebCore::MediaPlayerPrivate::muteChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix ready state when buffering under PLAYING. We should not go
back to HaveNothing in that case.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::updateStates):
2010-03-10 Ada Chan <adachan@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=35976
Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().
* platform/win/ContextMenuWin.cpp:
2010-03-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add IndexedDatabase class and hook it up.
https://bugs.webkit.org/show_bug.cgi?id=35927
This change is mostly just adding the plumbing necessary for
the IndexedDatabaseRequest and IndexedDatabaseSync (not written
yet).
This code is non-functional, so no tests (yet).
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/ChromiumBridge.h:
* storage/IndexedDatabase.cpp: Added.
(WebCore::IndexedDatabase::get):
* storage/IndexedDatabase.h: Added.
(WebCore::IndexedDatabase::~IndexedDatabase):
* storage/IndexedDatabaseImpl.cpp: Added.
(WebCore::IndexedDatabaseImpl::get):
(WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl):
(WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
(WebCore::IndexedDatabaseImpl::open):
* storage/IndexedDatabaseImpl.h: Added.
* storage/chromium/IndexedDatabase.cpp: Added.
(WebCore::IndexedDatabase::get):
2010-03-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Sam Weinig.
Add one more parent check during node removal.
https://bugs.webkit.org/show_bug.cgi?id=35818
Test: fast/dom/Node/mutation-blur.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild): Added check.
2010-03-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added missing quote into localized strings.
* English.lproj/localizedStrings.js:
2010-03-10 Jeremy Orlow <jorlow@chromium.org>
Commit files that were supposed to go in with the last checkin.
2010-03-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitry Glazkov.
Baby steps towards IndexedDB: Start implementing callbacks.
https://bugs.webkit.org/show_bug.cgi?id=35911
This patch adds some infastructure for IndexedDB callbacks in V8.
It also adds a stub of IDBDatabaseRequest. In the near future,
I'll gut the event based implementation code, flesh out IDBReqest
further, and start plumbing IndexedDatabaseRequest.
Code is not testible because it doesn't work (yet).
* WebCore.gypi:
* bindings/v8/DOMObjectsInclude.h:
* bindings/v8/V8Index.cpp:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8CustomIDBCallback.h: Added.
(WebCore::V8CustomIDBCallback::create):
(WebCore::V8CustomIDBCallback::~V8CustomIDBCallback):
(WebCore::V8CustomIDBCallback::handleEvent):
(WebCore::V8CustomIDBCallback::V8CustomIDBCallback):
* bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
(WebCore::V8IndexedDatabaseRequest::openCallback):
* storage/IDBDatabaseRequest.h: Added.
(WebCore::IDBDatabaseRequest::request):
* storage/IDBDatabaseRequest.idl: Added.
* storage/IndexedDatabaseRequest.idl:
2010-03-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[Qt] Non animated gifs are animated in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35955
Properly map Qt animated and non-animated values to WebCore's
understanding of animated and non-animated images. Currently
we can not map anything to the cAnimationLoopNone value.
* manual-tests/qt/qt-anim.gif: Added.
* manual-tests/qt/qt-gif-test.html: Added.
* manual-tests/qt/qt-noanim.gif: Added.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::repetitionCount):
2010-03-07 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
[CAIRO] DoS on iexploder test with high text stroke width.
https://bugs.webkit.org/show_bug.cgi?id=33759
Specifying a big text stroke width can make WebKitGTK+ spend
a very long time in the cairo library for stroking the path of
the text. The best way to prevent this from happening right now
is to not stroke paths with a certain width. Samuel proposed to
not stroke with a width that is twice the width of the text. The
reason to use twice the text width is that even one stroke of
any charachter to be drawn would cover the full width.
Test: fast/text/text-stroke-width-cairo-dos.html
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
2010-03-10 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display list of active workers & support debugging
with fake workers.
https://bugs.webkit.org/show_bug.cgi?id=35568
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
* dom/Document.cpp:
(WebCore::Document::inspectorController):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::inspectorController):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::injectScript):
(WebCore::InjectedScriptHost::nextWorkerId):
(WebCore::InjectedScriptHost::didCreateWorker):
(WebCore::InjectedScriptHost::willDestroyWorker):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::resetScriptObjects):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::didCreateWorker):
(WebCore::InspectorController::willDestroyWorker):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didCreateWorker):
(WebCore::InspectorFrontend::willDestroyWorker):
* inspector/InspectorFrontend.h:
* inspector/InspectorWorkerResource.h: Added.
(WebCore::InspectorWorkerResource::create):
(WebCore::InspectorWorkerResource::id):
(WebCore::InspectorWorkerResource::url):
(WebCore::InspectorWorkerResource::isSharedWorker):
(WebCore::InspectorWorkerResource::InspectorWorkerResource):
* inspector/front-end/Checkbox.js: Added.
(WebInspector.Checkbox.callbackWrapper):
(WebInspector.Checkbox):
(WebInspector.Checkbox.prototype.checked):
* inspector/front-end/InjectedFakeWorker.js:
(InjectedFakeWorker.FakeWorker):
(InjectedFakeWorker.FakeWorker.prototype.terminate):
(InjectedFakeWorker.FakeWorker.prototype._handleException):
(InjectedFakeWorker.FakeWorker.prototype._importScripts):
(InjectedFakeWorker.FakeWorker.prototype._loadScript):
(InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.showInheritedToggleFunction):
(WebInspector.StylePropertiesSection):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/WorkersSidebarPane.js: Added.
(WebInspector.WorkersSidebarPane):
(WebInspector.WorkersSidebarPane.prototype.addWorker):
(WebInspector.WorkersSidebarPane.prototype.removeWorker):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
(WebInspector.WorkersSidebarPane.prototype.reset):
(WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument):
(WebInspector.Worker):
(WebInspector.didCreateWorker):
(WebInspector.willDestroyWorker):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::AbstractWorker):
(WebCore::AbstractWorker::~AbstractWorker):
(WebCore::AbstractWorker::onDestroyWorker):
(WebCore::AbstractWorker::contextDestroyed):
* workers/AbstractWorker.h:
(WebCore::AbstractWorker::id):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::SharedWorker):
* workers/Worker.cpp:
(WebCore::Worker::Worker):
2010-03-10 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed build fix. Fix variable name change that somehow didn't
make it into the patch.
2010-03-10 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by David Levin.
Bug 28293 - [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293
Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).
Tests: editing/pasteboard/dataTransfer-setData-getData.html
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::clearURL):
(WebCore::ChromiumDataObject::hasValidURL):
(WebCore::ChromiumDataObject::getURL):
(WebCore::ChromiumDataObject::setURL):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Tall image resources are cropped over the bottom.
https://bugs.webkit.org/show_bug.cgi?id=34720
* inspector/front-end/inspector.css:
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric
value in CSS property takes focus away.
https://bugs.webkit.org/show_bug.cgi?id=34697
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.):
2010-03-09 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993
Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.
Tests: editing/deleting/backspace-avoid-preceding-style.html
editing/inserting/replace-at-visible-boundary.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::positionAvoidingPrecedingNodes):
(WebCore::ReplaceSelectionCommand::doApply):
2010-03-09 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher.
REGRESSION: WebInspector docking busted on Windows
<rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
First off, a bit of settings-key related cleanup. If they're shared over multiple files, these
things should be properly declared Strings, not random loose char*'s.
Along with that change, we move the "inspectorStartsAttachedSettingName" from WebKit down to the
InspectorController in WebCore.
Finally, when the controller is ready to show the WebInspector window, it can use this newly
exposed settings key to call "setWindowVisible" directly instead of relying on "showWindow" to do
it indirectly.
* WebCore.base.exp:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::saveFrontendSettings):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::frontendSettingsSettingName):
(WebCore::InspectorController::inspectorStartsAttachedSettingName):
(WebCore::InspectorController::scriptObjectReady): Using the new inspectorStartsAttachedSettingName
key and some "can I attach this?" logic, call setWindowVisible directly to display the inspector
window.
(WebCore::InspectorController::populateScriptObjects):
* inspector/InspectorController.h:
2010-03-09 Alexey Proskuryakov <ap@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80
* bridge/objc/objc_instance.mm: (createInstanceWrapperCache): Fix Tiger code path, too.
2010-03-09 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80
* bridge/objc/objc_instance.mm: (createInstanceWrapperCache): It's not correct to use object
personality for keys, because the key can be a mutable object, so its hash can change over its
lifetime.
2010-03-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Fix review comment accidentally overlooked in bug 35713
https://bugs.webkit.org/show_bug.cgi?id=35947
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
* editing/DeleteSelectionCommand.h:
2010-03-03 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713
TextEdit behavior is to select the deleted space after a smartdelete.
Tests: editing/undo/undo-smart-delete-reversed-selection.html
editing/undo/undo-smart-delete-word.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
(WebCore::DeleteSelectionCommand::initializePositionData):
* editing/DeleteSelectionCommand.h:
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setWithoutValidation):
This assert looks bogus to me. undo-smart-delete-reversed-selection.html hits it
but not as a result of the other changes in this patch. The granularity when
deleting after making a wordgranularity selection is wordgranularity, not charactergranularity.
2010-03-09 Steve Falkenburg <sfalken@apple.com>
Rubber stamped by Adam Roben.
Load debug version of graphics library in Windows Debug_All builds.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
2010-03-09 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Plug-ins don't always respect the cookie accept policy.
<rdar://problem/7338359> and https://bugs.webkit.org/show_bug.cgi?id=26391
The problem is that the various plug-in implementations call into a ResourceLoader
directly instead of filtering the request through FrameLoader. This bypassed the step
of adding extra fields to the requests, such as the firstPartyForCookies URL.
Since plug-in code is currently so strewn about and very platform specific, I
think reworking it needs to be a task for domain experts. I don't know the implications
of adding *all* the extra fields to plug-in requests, for example.
There's no harm in this targeted fix for the hole in our cookie accept policy until
plug-ins can more fundamentally change.
Test: http/tests/plugins/third-party-cookie-accept-policy.html
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::load): Don't load a resource without first giving the request
a firstPartyForCookies URL.
2010-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adele Peterson.
Check for null renderer in scrollNode().
https://bugs.webkit.org/show_bug.cgi?id=34700
Test: fast/events/remove-child-onscroll.html
* page/EventHandler.cpp:
(WebCore::scrollNode): Return early if node->renderer() == 0
2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed distcheck fix.
* GNUmakefile.am:
2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix (only exposed by make distcheck). The
SharedWorkers files are not built, they need to be distributed.
* GNUmakefile.am:
2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Dirk Schulze.
[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706
Fix buffering to match GStreamer expectancies regarding the
pipeline state, so that videos which really need buffering to play
correctly also work, while maintaining the convenience of
on-disk-buffering. This required a bit of shuffling of state
change handling.
No behaviour change expected.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::fillTimerFired):
(WebCore::MediaPlayerPrivate::updateStates):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Dirk Schulze.
[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706
Do not call pause(), but set the GStreamer state directly. This is
just a GStreamer implementation detail, and this will avoid having
side effects in case we change the pause implementation in the
future.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::load):
2010-03-09 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893
Since <option> elements don't have renderers, their hit testing needs
to be handled with a special case.
Test: platform/mac/accessibility/listbox-hit-test.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Refactor Audits panel presentation layer.
This change removes unnecessary complexity:
- Audit scores were not used
- Audit rule parameters are passed as rule constructor arguments
- View management aligned with the rest of the front-end
- Single TreeOutline is used for category results (no need to create sections for those)
- Rules code beautified and simplified where possible
- Some UI improvements applied (see attached screenshot)
https://bugs.webkit.org/show_bug.cgi?id=35860
* inspector/front-end/AuditCategories.js:
(WebInspector.AuditCategories.PagePerformance.prototype.initialize):
(WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
(WebInspector.AuditCategoryResultPane):
(WebInspector.AuditCategoryResultPane.prototype._appendResult):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.CombineJsResourcesRule):
(WebInspector.AuditRules.CombineCssResourcesRule):
(WebInspector.AuditRules.MinimizeDnsLookupsRule):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.BrowserCacheControlRule):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ImageDimensionsRule):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine):
(WebInspector.AuditRules.StylesScriptsOrderRule):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine):
(WebInspector.AuditRules.CookieRuleBase):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._reloadResources):
(WebInspector.AuditsPanel.prototype._didMainResourceLoad):
(WebInspector.AuditsPanel.prototype.showResults):
(WebInspector.AuditsPanel.prototype.showLauncherView):
(WebInspector.AuditsPanel.prototype.get visibleView):
(WebInspector.AuditsPanel.prototype.set visibleView):
(WebInspector.AuditsPanel.prototype.show):
(WebInspector.AuditsPanel.prototype._clearButtonClicked):
(WebInspector.AuditCategory.prototype.addRule):
(WebInspector.AuditRule):
(WebInspector.AuditRule.prototype.set severity):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
(WebInspector.AuditCategoryResult):
(WebInspector.AuditCategoryResult.prototype.addRuleResult):
(WebInspector.AuditRuleResult):
(WebInspector.AuditRuleResult.prototype.addChild):
(WebInspector.AuditRuleResult.prototype.addURL):
(WebInspector.AuditRuleResult.prototype.addURLs):
(WebInspector.AuditRuleResult.prototype.addSnippet):
* inspector/front-end/Settings.js:
* inspector/front-end/audits.css:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector.documentKeyDown):
2010-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.
https://bugs.webkit.org/show_bug.cgi?id=35923
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::reloadPage):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::enableResourceTracking):
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: highlight text node containers while searching for node.
https://bugs.webkit.org/show_bug.cgi?id=35912
* inspector/InspectorController.cpp:
(WebCore::InspectorController::mouseDidMoveOverElement):
2010-03-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868
Cleaned up the private instance variables of the player.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::fillTimerFired):
(WebCore::MediaPlayerPrivate::mediaLocationChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868
Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.
* GNUmakefile.am:
* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added.
(WTF::GstElement):
* platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/gtk/GOwnPtrGtk.cpp: Removed.
* platform/gtk/GOwnPtrGtk.h: Removed.
* platform/network/soup/CookieJarSoup.cpp:
* platform/network/soup/DNSSoup.cpp:
* platform/network/soup/GOwnPtrSoup.cpp: Added.
(WTF::SoupURI):
* platform/network/soup/GOwnPtrSoup.h: Added.
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/soup/ResourceRequestSoup.cpp:
2010-03-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Should remove paddings of Win/Linux chromium's buttons
https://bugs.webkit.org/show_bug.cgi?id=35629
No new tests, but we may need to rebaseline bunch of expectation
images in chromium's tree.
* rendering/RenderThemeChromiumSkia.cpp:
* rendering/RenderThemeChromiumSkia.h:
2010-03-08 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Implement HTML5 <hgroup> element.
https://bugs.webkit.org/show_bug.cgi?id=33369
<hgroup> should behave the same as <nav>, <section>, <article>, and <aside>.
<hgroup> has no specific parsing rules.
Test: fast/html/hgroup-element.html
* css/html.css: Add hgroup as a block element.
* editing/htmlediting.cpp:
(WebCore::validBlockTag): Add hgroupTag.
* html/HTMLElement.cpp:
(WebCore::createTagPriorityMap): Returns 5 for hgroupTag.
(WebCore::blockTagList): Add hgroupTag.
* html/HTMLParser.cpp:
(WebCore::HTMLParser::getNode): Add hgroupTag.
* html/HTMLTagNames.in: Add hgroup.
2010-03-08 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=32131
Crash when inserting an ordered list.
Test: editing/execCommand/insert-ordered-list.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
* editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
2010-03-08 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Added a test for crash when you quit inside an unload handler.
rdar://problem/6958347
* manual-tests/quit-inside-unload.html: Added.
2010-03-08 Darin Adler <darin@apple.com>
Reviewed by Jon Honeycutt.
Don't auto-play <audio> and <video> elements loaded in background tabs
https://bugs.webkit.org/show_bug.cgi?id=35886
rdar://problem/7117745
* manual-tests/video-in-non-frontmost-tab.html: Added.
* manual-tests/resources/video-tab.html: Added.
* html/HTMLMediaElement.h: Added MediaCanStartListener as a base class, and
added the mediaCanStart function as well as a boolean,
m_isWaitingUntilMediaCanStart.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize
m_isWaitingUntilMediaCanStart.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call
removeMediaCanStartListener if m_isWaitingUntilMediaCanStart is true.
(WebCore::HTMLMediaElement::loadInternal): Set m_isWaitingUntilMediaCanStart
and call addMediaCanStartListener if canStartMedia is false.
(WebCore::HTMLMediaElement::mediaCanStart): Clear m_isWaitingUntilMediaCanStart
and call loadInternal.
2010-03-08 Csaba Osztrogonác <ossy@webkit.org>
[GTK] Unreviewed buildfix after r55688.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
2010-03-08 Csaba Osztrogonác <ossy@webkit.org>
[GTK] Unreviewed buildfix after r55688.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::):
2010-03-08 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix after r55688.
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
2010-03-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35879
Eliminate m_mightDownloadFromHandle
It was only used on Mac, and unnecessarily complicated the code.
No change in behavior, thus no test.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::load):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
2010-03-02 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Clean up usage of m_failed in open-source image decoders, part 1.
https://bugs.webkit.org/show_bug.cgi?id=35411
Makes setFailed() virtual so subclasses can override it (none do yet) to
do automatic cleanup on failure; makes it return a bool for easy
tailcalling; makes failed() the only way to access m_failed so
subclasses are assured setFailed() won't be bypassed. Plus one or two
other tiny cleanup bits.
Overriding setFailed() is coming in a subsequent patch because it can be
hairy and needs close review.
No functional change, so no tests.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::clearPointers):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::setData):
(WebCore::ImageDecoder::setSize):
(WebCore::ImageDecoder::setFailed):
(WebCore::ImageDecoder::failed):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::processFileHeader):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::processDirectoryEntries):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::isSizeAvailable):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::isSizeAvailable):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.h:
2010-03-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
Disallow WebGL when HW comp is not turned on at runtime
https://bugs.webkit.org/show_bug.cgi?id=35759
When HW comp is turned off with the runtime flag, WebGL would still
create a context, but silently fail to render. This prevents that.
Now if HW comp is turned off getContext('webgl') will return null.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
2010-03-08 Darin Adler <darin@apple.com>
Reviewed by Jon Honeycutt.
https://bugs.webkit.org/show_bug.cgi?id=35876
Fix minor style issues in HTMLMediaElement and classes derived from it.
Made many public members private and protected.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::screenRect): Got rid of a stray "const" and
retstructured the function to use early return and get rid of a local.
* html/HTMLMediaElement.h: Made lots of members private and some
protected. Also use private inheritance instead of public. Removed
some unneeded includes.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseMappedAttribute): Use player() instead
of m_player; HTMLMediaElement data members are now private, not protected.
(WebCore::HTMLVideoElement::supportsFullscreen): Ditto.
(WebCore::HTMLVideoElement::videoWidth): Ditto.
(WebCore::HTMLVideoElement::videoHeight): Ditto.
(WebCore::HTMLVideoElement::hasAvailableVideoFrame): Ditto.
(WebCore::HTMLVideoElement::webkitEnterFullScreen): Use isFullscreen()
instead of m_isFullscreen; same reason.
(WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto.
(WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
* html/HTMLVideoElement.h: Removed an unneeded include. Made many
public functions private. Got rid of unused paint function, which was
replaced with paintCurrentFrameInContext a while back.
2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
Gives platforms the ability to exclude parts of an AccessibilityTable
from the accessible hierarchy.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/AccessibilityTable.cpp:
(AccessibilityTable::addChildren):
* accessibility/AccessibilityTableColumn.h:
(accessibilityIsIgnored):
* accessibility/AccessibilityTableHeaderContainer.h:
(accessibilityIsIgnored):
* accessibility/AccessibilityTableRow.cpp:
(accessibilityIsIgnored):
2010-03-08 Jian Li <jianli@chromium.org>
No review. Fix build break on Tiger intel release.
* html/Blob.cpp:
* html/Blob.h:
2010-03-02 Adam Treat <atreat@rim.com>
Reviewed by Dave Hyatt.
Refactor the HostWindow methods for repaint, scroll, invalidate and blit
of backingstore and window by eliminating the three bools that currently
exist as params of the repaint method.
https://bugs.webkit.org/show_bug.cgi?id=34214
I've added extra methods to provide the hosts with more semantic
information of what is being requested thus eliminating the need for
these bools.
No tests as this change should not introduce any behavior changes in any
of the ports.
https://bugs.webkit.org/show_bug.cgi?id=34214
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::invalidateContents):
(WebCore::EmptyChromeClient::invalidateWindow):
(WebCore::EmptyChromeClient::invalidateContentsAndWindow):
(WebCore::EmptyChromeClient::invalidateContentsForSlowScroll):
* page/Chrome.cpp:
(WebCore::Chrome::invalidateContents):
(WebCore::Chrome::invalidateWindow):
(WebCore::Chrome::invalidateContentsAndWindow):
(WebCore::Chrome::invalidateContentsForSlowScroll):
* page/Chrome.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
2010-03-08 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474
Apparently, we're supposed to look at the sourceURL to figure out
whether we're running a script tag or a hyperlink. This logic is
copied from the JSC version.
Test: http/tests/security/popup-blocked-from-window-open.html
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::evaluate):
2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Adler.
Move the details of secure text mode into WebCore/platform.
Move the higher-level logic for secure text mode from Frame
to SelectionController.
https://bugs.webkit.org/show_bug.cgi?id=31265
No new tests: no functional changes.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::setUseSecureKeyboardEntryWhenActive):
* editing/SelectionController.cpp:
(WebCore::SelectionController::focusedOrActiveStateChanged):
(WebCore::SelectionController::updateSecureKeyboardEntryIfActive):
(WebCore::SelectionController::setUseSecureKeyboardEntry):
* editing/SelectionController.h:
* page/Frame.cpp:
(WebCore::Frame::setDocument):
* page/Frame.h:
* platform/SecureTextInput.cpp: Added.
(WebCore::enableSecureTextInput):
(WebCore::disableSecureTextInput):
* platform/SecureTextInput.h: Added.
(WebCore::enableSecureTextInput):
(WebCore::disableSecureTextInput):
2010-03-08 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
Relax the 3rd party cookie policy in cases where it won't add a new tracking vector.
<rdar://problem/7163012> and https://bugs.webkit.org/show_bug.cgi?id=35824
Test: http/tests/cookies/third-party-cookie-relaxing.html
If the 3rd-party domain in question already has a cookie set, allow changes
by setting the first party url of the request to be the url of the request itself:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
Ditto:
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
I've filed <rdar://problem/7728508> to track changing the policy in our networking layer.
2010-03-08 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
The following semantic is adopted per the discussions on public-webapps:
1) File.slice() does a synchronous IO to capture the current size and
modification time and cache them in the resulting Blob.
2) Subsequent Blob operations, like Blob.slice and Blob.size simply
use the cached values.
3) When the underlying file data are accessed, like in XHR.send(), the
UA will check the cached modification time against the current
modification time to determine if the file has been changed or not.
An error or exception will be thrown if needed.
Also add ENABLE_BLOB_SLICE feature define.
Test: http/tests/local/send-sliced-dragged-file.html
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* WebCore.pri:
* html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::size):
(WebCore::Blob::slice):
* html/Blob.h:
(WebCore::Blob::start):
(WebCore::Blob::length):
(WebCore::Blob::modificationTime):
* html/Blob.idl:
* platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendFileRange):
* platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(WebCore::operator==):
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream):
(WebCore::openNextStream):
(WebCore::formCreate):
(WebCore::formOpen):
(WebCore::formRead):
(WebCore::setHTTPBody):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
2010-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=34819
Fixes an issue where we repaint the caret rectangle even if the associated
selection is not in a content editable element. This is extraneous since the
caret is only visible when the selection is in a content editable element.
Hence, we should only repaint the caret rectangle when the associated selection
is in a content editable element.
Note, we always paint the caret when caret browsing is enabled.
Test: fast/repaint/no-caret-repaint-in-non-content-editable-element.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::recomputeCaretRect): Modified to call method
SelectionController::shouldRepaintCaret.
(WebCore::SelectionController::shouldRepaintCaret): Added.
(WebCore::SelectionController::invalidateCaretRect): Modified to call method
SelectionController::shouldRepaintCaret.
* editing/SelectionController.h:
2010-03-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
YouTube HTML5 video never starts playing on Windows
https://bugs.webkit.org/show_bug.cgi?id=33954
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::rfc2616DateStringFromTime): New, create an rfc 2616 formatted
string for an absolute time value.
(WebCore::addCookieParam): New, add a cookie param and value to a string builder.
(WebCore::MediaPlayerPrivate::setUpCookiesForQuickTime): Copy cookies for the movie to
be loaded from CFNetwork into WinINet so they are available when QuickTime tries to
download the movie.
(WebCore::MediaPlayerPrivate::load): Call setupCookiesForQuickTime.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
2010-03-08 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763
No new tests; this code isn't called.
* WebCore.base.exp:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
2010-03-07 David Levin <levin@chromium.org>
Chromium Linux build fix.
* platform/graphics/chromium/FontPlatformDataLinux.h: Add "class String" since a debug
only method returns a String.
2010-03-07 Mark Rowe <mrowe@apple.com>
Chromium build fix.
* platform/chromium/ClipboardChromium.cpp: Include Image.h since we're using WebCore::Image.
2010-03-07 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* platform/network/soup/ResourceHandleSoup.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
2010-03-07 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* platform/graphics/gtk/ImageGtk.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
2010-03-07 Mark Rowe <mrowe@apple.com>
Fix builds where USE_CG_SHADING is set.
* platform/graphics/cg/GradientCG.cpp: Include wtf/RetainPtr.h since WTF::RetainPtr is used when USE_CG_SHADING is set.
2010-03-07 Mark Rowe <mrowe@apple.com>
Windows build fix. Add some required includes.
* platform/graphics/win/ImageCGWin.cpp:
* platform/network/cf/ResourceHandleCFNet.cpp:
* platform/win/ClipboardWin.cpp:
2010-03-07 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* platform/graphics/GraphicsContext.h: Include wtf/PassOwnPtr.h since some platforms use WTF::PassOwnPtr in this header.
2010-03-07 Mark Rowe <mrowe@apple.com>
Qt build fix.
* platform/network/qt/ResourceHandleQt.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
2010-03-07 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* platform/gtk/ClipboardGtk.cpp: Include Image.h since we're using WebCore::Image.
2010-03-07 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Cameron Zwarich.
Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
* loader/CachedCSSStyleSheet.cpp:
* loader/CachedFont.cpp:
* loader/CachedImage.cpp:
* loader/CachedResource.cpp:
* loader/CachedResource.h:
* loader/CachedScript.cpp:
* loader/CachedXSLStyleSheet.cpp:
* loader/icon/IconFetcher.cpp:
* loader/loader.cpp:
* page/Page.cpp:
* platform/graphics/Image.cpp:
* platform/graphics/Image.h:
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
* platform/graphics/cg/PDFDocumentImage.cpp:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/mac/ImageMac.mm:
2010-03-07 Mark Rowe <mrowe@apple.com>
Chromium build fix.
* platform/chromium/ChromiumDataObject.h: Include SharedBuffer.h since the inline constructor of this
class means that the pointed-to type of the RefPtr member must be available.
2010-03-07 Mark Rowe <mrowe@apple.com>
Qt build fix.
* platform/network/qt/DnsPrefetchHelper.cpp: Include PlatformString.h since we're using WebCore::String.
2010-03-07 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472
Test: fast/forms/ValidityState-valueMissing-radio.html
* html/HTMLInputElement.cpp:
(WebCore::checkedRadioButtons): Move the location to be used by valueMissing().
(WebCore::HTMLInputElement::valueMissing):
Use checkedRadioButtons() instead of document()->checkedRadioButtons().
2010-03-07 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Cameron Zwarich.
Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
* bindings/objc/DOM.mm:
* loader/CachedImage.h:
* loader/EmptyClients.h:
* platform/graphics/GlyphPageTreeNode.cpp:
* platform/text/CString.h:
* platform/text/String.cpp:
* platform/text/mac/TextCodecMac.cpp:
* svg/graphics/SVGResourceFilter.h:
* svg/graphics/filters/SVGFEImage.h:
2010-03-07 Mark Rowe <mrowe@apple.com>
Completely remove two files that were deleted in r55635 from the Xcode project.
* WebCore.xcodeproj/project.pbxproj:
2010-03-07 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()
https://bugs.webkit.org/show_bug.cgi?id=35848
- Take the opportunity to fully autogenerate window.atob() and window.btoa().
* bindings/js/JSDOMWindowCustom.cpp:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
* page/DOMWindow.idl:
2010-03-07 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7722008> Column breaking ignores floats
https://bugs.webkit.org/show_bug.cgi?id=35837
Test: fast/multicol/float-truncation.html
Introduce an earlier column-break if otherwise a float that could fit
inside a single column will be split between columns.
It is still possible for floats to be needlessly broken if initially
they fit in the column, but normal flow truncation then shortens the
column.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::visibleTopOfHighestFloatExtendingBelow): Added.
Returns the visible top of the highest descendant float that visibly
extends below the given y offset, ignoring floats that are taller than
the given maximum height.
(WebCore::RenderBlock::layoutColumns): If the initial column height
would cause a float to be split, truncate above the float.
* rendering/RenderBlock.h:
2010-03-07 Dmitry Titov <dimich@chromium.org>
Not reviewed. Revert of r55593 which caused a regression of worker-cloneports.html.
REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDatabaseCallback.cpp: Removed.
* bindings/js/JSDatabaseCallback.h: Removed.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
* bindings/v8/custom/V8DatabaseCallback.h: Removed.
* dom/Document.cpp:
(WebCore::Document::postTask):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
* storage/Database.h:
* storage/DatabaseCallback.h: Removed.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
2010-03-06 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.
* accessibility/AccessibilityObject.h:
* dom/XMLTokenizer.cpp:
* dom/XMLTokenizerLibxml2.cpp:
* dom/XMLTokenizerQt.cpp:
* editing/TextAffinity.h:
* loader/FrameLoaderClient.h:
* page/FocusController.cpp:
* page/FrameTree.cpp:
* page/Geolocation.h:
* page/PositionCallback.h:
* page/PositionErrorCallback.h:
* platform/Cursor.h:
* platform/FileSystem.h:
* platform/FloatConversion.h:
* platform/KeyboardCodes.h:
* platform/PlatformKeyboardEvent.h:
* platform/PlatformTouchPoint.h:
* platform/SuddenTermination.h:
* platform/Widget.h:
* platform/graphics/Color.h:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatSize.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
* platform/graphics/openvg/PainterOpenVG.h:
* platform/graphics/openvg/SurfaceOpenVG.h:
* platform/network/ResourceHandleClient.h:
* platform/text/Base64.cpp:
* rendering/style/SVGRenderStyle.h:
* xml/XSLTProcessor.cpp:
* xml/XSLTProcessorLibxslt.cpp:
* xml/XSLTProcessorQt.cpp:
2010-03-06 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Move debug only JS wrapper-set tracking code into its own file.
https://bugs.webkit.org/show_bug.cgi?id=35839
* GNUmakefile.am: Added new files.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
Updated for new signature for willCacheWrapper and didUncacheWrapper.
* bindings/js/JSDOMWrapper.cpp: Added.
(WebCore::DOMObject::~DOMObject):
(WebCore::DOMObject::defineOwnProperty):
Moved from JSDOMBinding.cpp.
* bindings/js/JSDebugWrapperSet.cpp: Added.
(WebCore::JSDebugWrapperSet::shared):
(WebCore::JSDebugWrapperSet::JSDebugWrapperSet):
* bindings/js/JSDebugWrapperSet.h: Added.
(WebCore::JSDebugWrapperSet::add):
(WebCore::JSDebugWrapperSet::remove):
(WebCore::JSDebugWrapperSet::contains):
(WebCore::JSDebugWrapperSet::willCacheWrapper):
(WebCore::JSDebugWrapperSet::didUncacheWrapper):
Moved from JSDOMBinding.cpp.
2010-03-06 Sam Weinig <sam@webkit.org>
Rubber-stamped by Dan Bernstein.
Move DOMObjectHashTableMap, DOMWrapperWorld and WebCoreJSClientData into
their own files.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMObjectHashTableMap.cpp: Copied from bindings/js/JSDOMBinding.cpp.
* bindings/js/DOMObjectHashTableMap.h: Copied from bindings/js/JSDOMBinding.h.
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
* bindings/js/DOMWrapperWorld.cpp: Copied from bindings/js/JSDOMBinding.cpp.
(WebCore::forgetWorldOfDOMNodesForDocument):
* bindings/js/DOMWrapperWorld.h: Copied from bindings/js/JSDOMBinding.h.
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::rememberDocument):
(WebCore::DOMWrapperWorld::forgetDocument):
(WebCore::DOMWrapperWorld::isNormal):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
(WebCore::Document::getWrapperCache):
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/WebCoreJSClientData.h: Copied from bindings/js/JSDOMBinding.h.
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::~WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
* bindings/js/WorkerScriptController.cpp:
2010-03-06 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Sam Weinig.
Remove an unused method.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Changed comment.
(WebCore::RenderBlock::floatRect): Removed.
* rendering/RenderBlock.h: Removed floatRect().
2010-03-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make timeline overview bars transparent to mouse events.
https://bugs.webkit.org/show_bug.cgi?id=35832
* inspector/front-end/inspector.css:
2010-03-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Jeremy Orlow.
Web Inspector: switching to/from Timeline Panel moves scroller.
(Also added couple of record details items as I was fixing it).
https://bugs.webkit.org/show_bug.cgi?id=35829
* English.lproj/localizedStrings.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get defaultFocusedElement):
(WebInspector.TimelinePanel.prototype.show):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2010-03-06 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Removed unnecessary WinCE file.
The same functionality is provided by platform/win/SystemTimeWin.cpp.
https://bugs.webkit.org/show_bug.cgi?id=35799
* platform/wince/SystemTimeWince.cpp: Removed.
2010-03-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
This completes the fixing of the Atk table hierarchy which was started
in bug #35418.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::determineAccessibilityRole):
2010-03-06 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.
Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723
No new test. No new functionality.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):
Moved conversion code to DOMWindow and invoke it. Argument
checking remains here.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::atobCallback):
(WebCore::V8DOMWindow::btoaCallback):
Remove conversion code and call DOMWindow APIs. Although argument
checking remains here.
* page/DOMWindow.cpp:
(WebCore::hasMultibyteCharacters):
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
* page/DOMWindow.h:
Moved Conversion code from JSDOMWindow, modifing to fit JSC independent.
2010-03-06 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Fix decoration position in search input field.
This patch fixes rendering of input field of "search" type, whose decoration
(loupe icon and close button) was wrongly positioned when the input field was
contained in a block with -webkit-transform property.
Chromium bug: http://crbug.com/20439
[Chromium] Decoration of "search" input field is wrongly rendered
https://bugs.webkit.org/show_bug.cgi?id=30245
No new tests, since this patch fixes an existing test
(fast/forms/search-transformed.html) in Chromium layout tests.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect): Added. This method
does almost the same thing as RenderThemeMac::convertToPaintingRect.
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): The position
of the icon should not depend on its absolute position.
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): Ditto.
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): Ditto.
* rendering/RenderThemeChromiumSkia.h: Added new method.
2010-03-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: in Timeline panel, click followed with mouse move resets popover.
https://bugs.webkit.org/show_bug.cgi?id=35827
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._handleMouseAction):
2010-03-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.
If the cursor is trying to move into a node that has a height of 0,
skip over it.
Test: editing/execCommand/move-selection-back-line.html
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
2010-03-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Eric Seidel.
Enable resource loading callback while loading worker scripts
https://bugs.webkit.org/show_bug.cgi?id=35744
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
2010-03-05 Chris Fleizach <cfleizach@apple.com>
Reviewed by Eric Seidel.
WAI-ARIA live region doesn't appear when <div> only has a <div> child
https://bugs.webkit.org/show_bug.cgi?id=35751
Elements should not be ignored if they carry ARIA attributes in them.
Test: platform/mac/accessibility/div-containing-div-with-aria.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAAttributes):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIADropping):
(WebCore::AccessibilityObject::supportsARIADragging):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsARIADropping):
(WebCore::AccessibilityRenderObject::supportsARIADragging):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.h:
2010-03-05 Dmitry Titov <dimich@chromium.org>
Reviewed by Oliver Hunt.
Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to Frame
https://bugs.webkit.org/show_bug.cgi?id=32353
* manual-tests/clearTimeout-crash-bug29832.html: Added.
2010-03-05 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
[v8] Remove wrong assert in GC callback
https://bugs.webkit.org/show_bug.cgi?id=35757
Test: fast/workers/wrapper-map-gc.html
* bindings/v8/DOMData.h:
(WebCore::DOMData::handleWeakObject): remove ASSERT(isMainThread()), move another assert up to verify we are on the right thread.
2010-03-05 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added support for row layout with stretchy operators and
adjusted the over spacing for over and underover accordingly.
Tests: mathml/presentation/mo.xhtml
mathml/presentation/row.xhtml
* WebCore.xcodeproj/project.pbxproj:
* mathml/MathMLInlineContainerElement.cpp:
* mathml/MathMLTextElement.cpp:
* mathml/RenderMathMLMath.cpp: Added.
* mathml/RenderMathMLMath.h: Added.
* mathml/RenderMathMLOperator.cpp: Added.
* mathml/RenderMathMLOperator.h: Added.
* mathml/RenderMathMLRow.cpp: Added.
* mathml/RenderMathMLRow.h: Added.
* mathml/RenderMathMLUnderOver.cpp:
* mathml/mathtags.in:
2010-03-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=35772
Animation fill modes should be supported in the shorthand property
Add CSSPropertyWebkitAnimationFillMode to the list of properties
evaluated in the -webkit-animation shorthand.
Test: animations/animation-shorthand.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
2010-03-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser
https://bugs.webkit.org/show_bug.cgi?id=35815
Animation Fill Modes fail on Windows
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSStyleSelector.cpp:
* platform/graphics/mac/GraphicsLayerCA.mm:
- use new enum value
* platform/animation/Animation.h:
- change bitfield type
* rendering/style/RenderStyleConstants.h:
- add new enum for fill mode
2010-03-05 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r55593. (To fix Qt --minimal build.)
* bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
2010-03-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065
<rdar://problem/7573509>
Fix one instance of this assertion (not necessarily the one seen on hulu.com).
If the layer that clippingRoot() is being called on is itself compositing,
then it acts as the clipping root. Without this, calls to RenderLayer::childrenClipRect()
and RenderLayer::selfClipRect() via FrameView::windowClipRectForLayer(), for plug-ins,
caused the caching of an incorrect clip rects root.
Test: compositing/geometry/object-clip-rects-assertion.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clippingRoot):
2010-03-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Child clipping compositing layers don't show the blue debug color
https://bugs.webkit.org/show_bug.cgi?id=35807
Set a layer owner on the GraphicsLayers created for clipping children,
so that they can get to the debug settings that give them the blue color.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateClippingLayers):
2010-03-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
MobileMe movie page is missing playback controls
https://bugs.webkit.org/show_bug.cgi?id=35805
<rdar://problem/7653169>
On pages with video or plug-ins, we run overlap tests to determine which layers
need to be composited. There was an ordering dependency bug in
RenderLayerCompositor::computeCompositingRequirements() that caused us to fail
to detect that a layer needed to be composited, resulting in page content
not being visible.
Specifically, layer->setHasCompositingDescendant() can change the answer
to needsToBeComposited(), when a layer has to clip compositing descendants.
So if we change setHasCompositingDescendant(), then we need to re-test
clipsCompositingDescendants() and add the layer to the overlap map if so.
Test: compositing/overflow/overflow-compositing-descendant.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
2010-03-04 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Adding support for the optional creation callback that could be
passed to openDatabase().
Test: storage/open-database-creation-callback.html
https://bugs.webkit.org/show_bug.cgi?id=34726
* Android.jscbindings.mk
* Android.v8bindings.mk
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
* bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
* bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
* storage/Database.h:
(WebCore::Database::isNew):
* storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
2010-03-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Fixed infinite recursion of composited video on Windows
https://bugs.webkit.org/show_bug.cgi?id=35798
Due to a change in the way we get the platformLayer (WKCACFLayer)
for video, the mediaplayer was in an infinite loop with WKCACFLayer
bouncing notifySyncRequired calls back and forth. After discussion
we decided it would be better to avoid notifySyncRequired entirely,
which would walk up through WebCore calls and back down through
WebKit calls to tell the WKCACFLayerRenderer to kick off a render cycle.
I subclassed WKCACFLayer into a WKCACFRootLayer which has a pointer to
the WKCACFLayerRenderer. When something changes, we get the rootLayer()
by walking up the layers and make a virtual call which WKCACFRootLayer
implements to tell WKCACFLayerRenderer to render.
I also got rid of GraphicsLayer knowledge from WKCACFLayer. GraphicsLayerCACF
now makes a WebLayer subclass which implements the drawInContext()
virtual method.
I also had to add protection to the platformLayer() call in
MediaPlayerPrivateQuickTimeWin because it gets called earlier than before
when the layer is still null.
* platform/graphics/win/GraphicsLayerCACF.cpp:Implement WebLayer
(WebCore::WebLayer::create):
(WebCore::WebLayer::drawInContext):
(WebCore::WebLayer::WebLayer):
(WebCore::GraphicsLayerCACF::GraphicsLayerCACF):
(WebCore::GraphicsLayerCACF::setNeedsDisplayInRect):
(WebCore::GraphicsLayerCACF::updateLayerPreserves3D):
(WebCore::GraphicsLayerCACF::updateContentsImage):
* platform/graphics/win/GraphicsLayerCACF.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:Protect platformLayer from a null qtLayer
(WebCore::MediaPlayerPrivate::platformLayer):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:Got rid of no longer needed method
(WebCore::MediaPlayerPrivate::notifyAnimationStarted):
* platform/graphics/win/WKCACFLayer.cpp:Got rid of GraphicsLayer dependency. Made virtual.
(WebCore::displayCallback):
(WebCore::WKCACFLayer::create):
(WebCore::WKCACFLayer::WKCACFLayer):
(WebCore::WKCACFLayer::setNeedsCommit):
(WebCore::WKCACFLayer::setNeedsDisplay):
* platform/graphics/win/WKCACFLayer.h:
(WebCore::WKCACFLayer::setNeedsRender):
(WebCore::WKCACFLayer::drawInContext):
* platform/graphics/win/WKCACFLayerRenderer.cpp:Create WKCACFRootLayer which tells WKCACFLayerRenderer to render
(WebCore::WKCACFRootLayer::WKCACFRootLayer):
(WebCore::WKCACFRootLayer::create):
(WebCore::WKCACFRootLayer::setNeedsRender):
(WebCore::WKCACFRootLayer::setNeedsDisplay):
(WebCore::WKCACFLayerRenderer::rootLayer):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::setNeedsDisplay):
(WebCore::WKCACFLayerRenderer::createRenderer):
* platform/graphics/win/WKCACFLayerRenderer.h:
2010-03-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Levin.
[Chromium] Missing commas in WebCore.gypi file make building Geo unpossible.
https://bugs.webkit.org/show_bug.cgi?id=35797
No new tests, this is a latent compile break.
* WebCore.gypi:
2010-03-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/7718442> Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=35789
Don't load any media data when preload is 'none'.
Test: media/video-preload.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Don't call player's setPreload method
when autoplay is set.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setPreload): Set m_preload so we have the correct value when
the media engine is created.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_preload.
(WebCore::MediaPlayerPrivate::resumeLoad): New, kick off postponed a load.
(WebCore::MediaPlayerPrivate::load): Do nothing if preload is 'none'
(WebCore::MediaPlayerPrivate::loadInternal): New, complete loading.
(WebCore::MediaPlayerPrivate::prepareToPlay): New, resume a postponed load as someone
has called play().
(WebCore::MediaPlayerPrivate::setPreload): New, set m_preload.
2010-03-04 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Give CodeGeneratorV8.pm a much-needed spring cleaning.
https://bugs.webkit.org/show_bug.cgi?id=35697
* bindings/scripts/CodeGeneratorV8.pm: Remove unused code, fix style issues, make less hard-coded.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
2010-03-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Roll back r55522 since it regreses performance
according to chromium's page cycler.
https://bugs.webkit.org/show_bug.cgi?id=35568
2010-03-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser and Chris Marrin.
Bug 26869: Add fill modes for CSS Animations
https://bugs.webkit.org/show_bug.cgi?id=26869
Tests: animations/fill-mode-removed.html
animations/fill-mode-transform.html
animations/fill-mode.html
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSParser.cpp:
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* css/CSSValueKeywords.in:
- parse, assign and retrieve the value of the new
-webkit-animation-fill-mode property
* page/animation/AnimationBase.cpp:
* page/animation/AnimationBase.h:
- new state in animation engine for a finished animation
that is "filling" forwards in time. This allows the
engine to keep the animation around and not revert to the
old style.
- update the timer code to indicate it doesn't need to
keep animating if it is filling
- now that animations can extend beyond their elapsed time,
make sure progress works correctly with iteration counts
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- ensure correct style value is returned at the right
time by checking for fill mode
(WebCore::KeyframeAnimation::onAnimationEnd):
- continue to send the end event, but only remove the
animation if it isn't filling forwards
* platform/animation/Animation.cpp:
* platform/animation/Animation.h:
- new fill mode member property
* platform/animation/AnimationList.cpp:
- ensure the fill mode is propagated to a list of style valus
* platform/graphics/mac/GraphicsLayerCA.mm:
- make hardware layers use Core Animation's fill mode
2010-03-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Do not show link helper in popovers and/or for external resources.
https://bugs.webkit.org/show_bug.cgi?id=35785
* English.lproj/localizedStrings.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.hide):
* inspector/front-end/inspector.js:
(WebInspector.documentMouseOver):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.addMainEventListeners):
2010-03-05 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket onmessageerror event handler
https://bugs.webkit.org/show_bug.cgi?id=35570
Test: websocket/tests/error-detect.html
* websockets/WebSocket.cpp:
(WebCore::WebSocketChannel::didConnect): assert scriptExecutionContext.
(WebCore::WebSocketChannel::didReceiveMessage): assert scriptExecutionContext.
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didClose): assert scriptExecutionContext.
* websockets/WebSocket.h:
* websockets/WebSocket.idl: Add onerror event listener
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didReceiveData): call didReceiveMessageError if unknown frame tye is detected, or frame length overflowed.
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didReceiveMessageError):
2010-03-04 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Changing private members from PlatformTouchEvent and PlatformTouchPoint
to be protected, so that Chromium's PlatformTouchEventBuilder and
PlatformTouchPointBuilder can access them. Exercised by the
fast/events/touch tests.
https://bugs.webkit.org/show_bug.cgi?id=35760
* platform/PlatformTouchEvent.h:
(WebCore::PlatformTouchEvent::~PlatformTouchEvent):
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::~PlatformTouchPoint):
2010-03-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket crash bug when reloading the page while the WebSocket is busy
https://bugs.webkit.org/show_bug.cgi?id=35732
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::disconnect): clear m_context from WebSocketChannel and WebSocketHandshake.
(WebCore::WebSocketChannel::didOpen): check m_context
(WebCore::WebSocketChannel::didClose): clear m_context
(WebCore::WebSocketChannel::didReceiveData): check m_context, and check m_client early before appending to buffer
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clearScriptExecutionContext): Added.
* websockets/WebSocketHandshake.h:
2010-03-04 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630
Test: http/tests/xmlhttprequest/open-async-overload.html
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openCallback):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
* xml/XMLHttpRequest.h:
2010-03-04 James Robinson <jamesr@google.com>
Reviewed by Eric Seidel.
Styles do not have to be synchronously rematched after every event dispatch
https://bugs.webkit.org/show_bug.cgi?id=32580
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
2010-03-04 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
maemo spelled as mameo in WebCore.pro
https://bugs.webkit.org/show_bug.cgi?id=35765
Spelling corrected.
* WebCore.pro:
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.
Test: editing/input/option-page-up-down.html
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Update the obviously safe getters to allow caching
Test: fast/js/pic/cached-named-property-getter.html
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getOwnPropertySlot):
2010-03-04 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
* WebCore.xcodeproj/project.pbxproj: Copy DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h
in to the framework wrapper.
2010-03-04 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Handles setting HTMLSelectElement.length with mutation handlers present
https://bugs.webkit.org/show_bug.cgi?id=33983
When setting an HTMLSelectElement's length attribute, option elements have to be added or removed to the select
as appropriate. This is a little tricky with mutation events since they might add, remove, or reorder elements
while option elements are being added or deleted.
Tests: fast/forms/select-set-length-optgroup.html
fast/forms/select-set-length-with-mutation-remove.html
fast/forms/select-set-length-with-mutation-reorder.html
fast/forms/select-set-length-with-mutation-reparent.html
fast/forms/select-set-length-with-mutation.html
fast/forms/select-set-length.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength):
2010-03-04 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix after r55542 on Windows.
* WebCore.pro:
- plugins/win/PluginDatabaseWin.cpp removed.
- platform/win/WebCoreInstanceHandle.cpp added.
* platform/win/WebCoreInstanceHandle.cpp: Remove explicit qualification in namespace declaration to make gcc happy.
2010-03-04 Nate Chapin <japhet@chromium.org>
Reviewed by Kenneth Rohde Christiansen.
Fix the case where we do a same document navigation, scroll,
then repeat the same document navigation. Currently, the second
navigation does nothing.
https://bugs.webkit.org/show_bug.cgi?id=35547
Test: fast/loader/repeat-same-document-navigation.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument): Call scrollToFragment() whether or not the hash changed.
2010-03-04 Simon Fraser <simon.fraser@apple.com>
Build fix.
const long long cMaxDistance = numeric_limits<long long>::max() created global
initializers at the call sites, so replace with an inline function.
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
* page/SpatialNavigation.cpp:
(WebCore::distanceInDirection):
* page/SpatialNavigation.h:
(WebCore::maxDistance):
(WebCore::FocusCandidate::FocusCandidate):
2010-03-04 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed attempt to fix Windows build.
* page/SpatialNavigation.cpp:
(WebCore::spatialDistance):
2010-03-04 Simon Fraser <simon.fraser@apple.com>
Build fix.
Delcare updateFocusCandidateIfCloser static to avoid warning.
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
2010-03-04 Darin Fisher <darin@chromium.org>
Reviewed by Dmitry Titov.
[chromium] make history.{push,replace}State enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=35753
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setPushStateEnabled):
(WebCore::RuntimeEnabledFeatures::pushStateEnabled):
(WebCore::RuntimeEnabledFeatures::replaceStateEnabled):
* page/History.idl:
2010-03-04 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed attempt to (again) fix Mac build.
* page/SpatialNavigation.cpp:
(WebCore::spatialDistance):
2010-03-04 Dan Bernstein <mitz@apple.com>
Based on a patch from Nick Jong.
Reviewed by Simon Fraser.
Improve selection in multi-column blocks when hitting points above or
below a column rect.
Test: fast/multicol/hit-test-above-or-below.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPointToColumnContents): If the point lies
within the horizontal range for a column, constrain it to the column (if
it is above) or the next column (if it is below).
2010-03-04 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Attempt to fix Mac build.
* page/SpatialNavigation.cpp:
2010-03-04 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Add SpatialNavigation header and cpp to Mac XCode project file.
Reviewed by Kenneth Christiansen.
* WebCore.xcodeproj/project.pbxproj:
2010-03-02 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser, Eric Seidel and Darin Adler.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Based on the initial work of Marco Barisione <marco.barisione@collabora.co.uk>
Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662
This patch implements the core logic of the 'Spatial Navigation' feature [1].
It improves the accessibility support of WebCore by extending the basic keyboard
navigation currently available (based on Tab forward and backward) with the
addition of a two-dimensional directional navigation by using Left, Right, Up and
Down arrow keys to move to the "nearest" element in the corresponding direction.
Highlights:
* Feature is turned off by default in Settings. Port specific APIs need to be added
for toggling it on/off.
* Only elements viewed in the current viewport can have focus move to it. If the
"nearest" is not in viewport dimensions, then a scroll-in-direction action is
performed.
Known issues (to be covered in follow-up bugs):
* Add port specific hooks to each DRT to enable/disable Spatial Navigation.
* Support for spatial navigation through form elements (<input>, <select>, etc)
is be added.
* Make navigation keys customizable. It currently works with arrows keys only
(up, down, right and left).
* Make it support modifiers (Alt, Ctrl and Shift).
* Improve support on scrollable content.
[1] http://en.wikipedia.org/wiki/Spatial_navigation
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::focusDirectionForKey):
(WebCore::EventHandler::defaultArrowEventHandler):
* page/EventHandler.h:
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocus):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::advanceFocusDirectionally):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):
* page/FocusController.h:
* page/FocusDirection.h:
(WebCore::):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSpatialNavigationEnabled):
* page/Settings.h:
(WebCore::Settings::isSpatialNavigationEnabled):
* page/SpatialNavigation.cpp: Added.
(WebCore::distanceInDirection):
(WebCore::renderRectRelativeToRootDocument):
(WebCore::alignmentForRects):
(WebCore::isHorizontalMove):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::spatialDistance):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isInRootDocument):
(WebCore::deflateIfOverlapped):
* page/SpatialNavigation.h: Added.
(WebCore::):
(WebCore::FocusCandidate::FocusCandidate):
2010-03-04 Beth Dakin <bdakin@apple.com>
Reviewed by Anders Carlsson.
This fixes the layering violation I committed yesterday by moving
Page::instanceHandle into its own file just in the WebCore
namespace.
Added WebCoreInstanceHandle.h + .cpp and removed PageWin.cpp
* WebCore.vcproj/WebCore.vcproj:
* page/win/PageWin.cpp: Removed.
Remove all instance handle code from Page.
* page/Page.h:
New files.
* platform/win/WebCoreInstanceHandle.cpp: Added.
* platform/win/WebCoreInstanceHandle.h: Added.
(WebCore::setInstanceHandle):
(WebCore::instanceHandle):
Switch to WebCore::instanceHandle() instead of
Page::instanceHandle() and include the new header.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::Pasteboard):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::registerClass):
* platform/win/SharedTimerWin.cpp:
(WebCore::initializeOffScreenTimerWindow):
* plugins/win/PluginViewWin.cpp:
(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):
2010-03-04 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed build fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>
'glib_file_name' renamed to 'gligFileName'.
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource):
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove two last synchronous calls from front-end to InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=35720
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::enableSearchingForNode):
(WebCore::InspectorBackend::disableSearchingForNode):
(WebCore::InspectorBackend::setPauseOnExceptionsState):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorContorller::setSearchingForNode):
(WebCore::InspectorController::populateScriptObjects):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::searchingForNodeWasEnabled):
(WebCore::InspectorFrontend::searchingForNodeWasDisabled):
(WebCore::InspectorFrontend::updatePauseOnExceptionsState):
* inspector/InspectorFrontend.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.get statusBarItems):
(WebInspector.ElementsPanel.prototype.hide):
(WebInspector.ElementsPanel.prototype.reset):
(WebInspector.ElementsPanel.prototype.searchingForNodeWasEnabled):
(WebInspector.ElementsPanel.prototype.searchingForNodeWasDisabled):
(WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub.prototype.enableSearchingForNode):
(.WebInspector.InspectorBackendStub.prototype.disableSearchingForNode):
(.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptionsState):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype.updatePauseOnExceptionsState):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
(WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
* inspector/front-end/inspector.js:
(WebInspector.searchingForNodeWasEnabled):
(WebInspector.searchingForNodeWasDisabled):
(WebInspector.updatePauseOnExceptionsState):
2010-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Clicking on an error should take me to the error
https://bugs.webkit.org/show_bug.cgi?id=34860
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView):
(WebInspector.ResourceView.prototype._selectTab):
(WebInspector.ResourceView.prototype.selectContentTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showResource):
2010-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove sync access to resourceTrackingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=35693
* inspector/InspectorBackend.cpp:
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._reloadResources):
(WebInspector.AuditsPanel.prototype.show):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub):
(.WebInspector.InspectorBackendStub.prototype.enableResourceTracking):
(.WebInspector.InspectorBackendStub.prototype.disableResourceTracking):
(.WebInspector.InspectorBackendStub.prototype.enableDebugger):
(.WebInspector.InspectorBackendStub.prototype.disableDebugger):
(.WebInspector.InspectorBackendStub.prototype.enableProfiler):
(.WebInspector.InspectorBackendStub.prototype.disableProfiler):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.get resourceTrackingEnabled):
(WebInspector.ResourcesPanel.prototype.get visibleView):
(WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled):
(WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.ResourcesPanel.prototype._enableResourceTracking):
(WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
2010-03-04 Antoine Quint <ml@graougraou.com>
Reviewed by Darin Adler.
DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590
Test: fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html
Split off the internal-to-WebCore node insertion notification code from the DOM mutation
event dispatching, originally in dispatchChildInsertionEvents(), to a new static function
called notifyChildInserted(). This allows us to dispatch the mutation events at a later
time upon insertion of a child into to the tree, specifically _after_ attachment to the render
tree.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::notifyChildInserted):
(WebCore::dispatchChildInsertionEvents):
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
Make paths relocatable on runtime on Windows
https://bugs.webkit.org/show_bug.cgi?id=32711
* platform/graphics/gtk/ImageGtk.cpp:
(get_webkit_datadir):
(WebCore::Image::loadPlatformResource):
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Popup for Timeline panel will work in a tooltip mode
https://bugs.webkit.org/show_bug.cgi?id=35680
* inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.hide):
(WebInspector.Popover.prototype._positionElement):
(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._mouseMove.doHide):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._resetHoverTimer):
(WebInspector.PopoverHelper.prototype.hidePopup):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopupTimer):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.reset):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._adjustScrollPosition):
(WebInspector.TimelinePanel.prototype._getPopoverAnchor):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePanel.prototype._closeRecordDetails):
(WebInspector.TimelineRecordListRow):
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype._onClick):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._createCell):
(WebInspector.TimelinePanel.FormattedRecord.prototype._createRow):
(WebInspector.TimelinePanel.FormattedRecord.prototype._createLinkRow):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/inspector.css:
2010-03-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix.
Build fix after r55464.
No new tests, no new functionality.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/graphics/efl.
http://webkit.org/b/35539
* platform/graphics/efl/FloatRectEfl.cpp: Added.
* platform/graphics/efl/FontEfl.cpp: Added.
* platform/graphics/efl/IconEfl.cpp: Added.
* platform/graphics/efl/ImageEfl.cpp: Added.
* platform/graphics/efl/IntPointEfl.cpp: Added.
* platform/graphics/efl/IntRectEfl.cpp: Added.
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/text/efl.
http://webkit.org/b/35740
* platform/text/efl/TextBreakIteratorInternalICUEfl.cpp: Added.
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
Removing orphaned #if USE.
* platform/ThreadGlobalData.h:
2010-03-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Throttle sync requests sent to the LocalStorage background thread
https://bugs.webkit.org/show_bug.cgi?id=34943
Currently, once a second LocalStorage takes all keys/values which have
been changed and sends them to a background thread to sync. The problem
is that this background thread can get overwhelmed and stop being
responsive. This means that if any other page tries to start using
LocalStorage (and thus initiates the initial import) that'll block on
all the previous syncs completing.
To mitigate this, I'm adding code so that we never schedule another
sync task when another is still running. In order to keep the sync
tasks from growing exponentially when they do take longer than the
storage sync interval, I've also added a basic rate limiter. No effort
is made to ensure fairness/ordering of what gets synced nor is there
any way for this rate to be changed because most normal uses of
LocalStorage really shouldn't be hitting these types of limits anyway.
The only behavioral change that's observible in JavaScript is time based
and thus it's not practical to make new tests that aren't racy. The
existing layout tests cover LocalStorage pretty well, though.
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performSync):
* storage/StorageAreaSync.h:
2010-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Added support for worker instrumentation in inspector
(display list of active workers, allow debugging of workers
by injecting fake JS implementation)
https://bugs.webkit.org/show_bug.cgi?id=35568
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
* dom/Document.cpp:
(WebCore::Document::inspectorController):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::inspectorController):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::injectScript):
(WebCore::InjectedScriptHost::nextWorkerId):
(WebCore::InjectedScriptHost::didCreateWorker):
(WebCore::InjectedScriptHost::willDestroyWorker):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::resetScriptObjects):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::didCreateWorker):
(WebCore::InspectorController::willDestroyWorker):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didCreateWorker):
(WebCore::InspectorFrontend::willDestroyWorker):
* inspector/InspectorFrontend.h:
* inspector/InspectorWorkerResource.h: Added.
(WebCore::InspectorWorkerResource::create):
(WebCore::InspectorWorkerResource::id):
(WebCore::InspectorWorkerResource::url):
(WebCore::InspectorWorkerResource::isSharedWorker):
(WebCore::InspectorWorkerResource::InspectorWorkerResource):
* inspector/front-end/Checkbox.js: Added.
(WebInspector.Checkbox.callbackWrapper):
(WebInspector.Checkbox):
(WebInspector.Checkbox.prototype.checked):
* inspector/front-end/InjectedFakeWorker.js:
(InjectedFakeWorker.FakeWorker):
(InjectedFakeWorker.FakeWorker.prototype.terminate):
(InjectedFakeWorker.FakeWorker.prototype._handleException):
(InjectedFakeWorker.FakeWorker.prototype._importScripts):
(InjectedFakeWorker.FakeWorker.prototype._loadScript):
(InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/WorkersSidebarPane.js: Added.
(WebInspector.WorkersSidebarPane):
(WebInspector.WorkersSidebarPane.prototype.addWorker):
(WebInspector.WorkersSidebarPane.prototype.removeWorker):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
(WebInspector.WorkersSidebarPane.prototype.reset):
(WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument):
(WebInspector.Worker):
(WebInspector.didCreateWorker):
(WebInspector.willDestroyWorker):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::AbstractWorker):
(WebCore::AbstractWorker::~AbstractWorker):
(WebCore::AbstractWorker::onDestroyWorker):
(WebCore::AbstractWorker::contextDestroyed):
* workers/AbstractWorker.h:
(WebCore::AbstractWorker::id):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::SharedWorker):
* workers/Worker.cpp:
(WebCore::Worker::Worker):
2010-03-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.
This also allows shadow builds relying only on qmake to work properly.
* WebCore.pro:
2010-03-02 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[Qt] Avoid calling QFont::detach too often from FontQt
https://bugs.webkit.org/show_bug.cgi?id=35569
The letter- and wordspacing is inside the WebCore::Font class,
our QFont is located in the WebCore::FontPlatformData. Everytime
we need to use a QFont inside WebCore::Font we are calling the
font method which gets the QFont from the WebCore::FontPlatformData
and is applying the letter- and wordspacing. Internally this
will attempt to detach the QFont...
Avoid calling setLetterSpacing and setWordSpacing on QFont if
the WebCore::Font has the default applied.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::font):
2010-03-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=35574
* English.lproj/localizedStrings.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
(WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
* inspector/front-end/inspector.js:
(WebInspector.documentMouseOver):
(WebInspector.documentMouseOut):
(WebInspector.hideBadLinkPopupIfNecessary):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.showBadLinkPopup.popupOverOut):
(WebInspector.showBadLinkPopup):
(WebInspector.addMainEventListeners):
2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Oliver Hunt.
getUniformLocation() now returns null if uniform requested
is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669
Test:LayoutTests/fast/canvas/webgl/uniform-location.html
(added missing test)
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation):
2010-03-04 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710
* bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::setAllowSleep):
2010-03-04 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree
Simplify the handling of invalid or missing use-targets by cloning them
to empty <g> elements rather than just allowing the <use> element to
be copied into the shadow tree, as this violates a number of assumptions
in the shadow tree handling code.
Tests: svg/custom/use-nested-disallowed-target.svg
svg/custom/use-nested-missing-target-added.svg
svg/custom/use-nested-missing-target-removed.svg
svg/custom/use-nested-missing-target.svg
svg/custom/use-nested-notarget.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Move Cairo-related font code from platform/graphics/gtk to
platform/graphics/cairo, so other ports may use them.
http://webkit.org/b/35539
* GNUmakefile.am:
* platform/graphics/cairo/FontCacheCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontCacheGtk.cpp.
* platform/graphics/cairo/FontCustomPlatformData.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp.
* platform/graphics/cairo/FontCustomPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.h.
* platform/graphics/cairo/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformData.h.
* platform/graphics/cairo/FontPlatformDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp.
* platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp.
* platform/graphics/cairo/SimpleFontDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp.
* platform/graphics/gtk/FontCacheGtk.cpp: Removed.
* platform/graphics/gtk/FontCustomPlatformData.cpp: Removed.
* platform/graphics/gtk/FontCustomPlatformData.h: Removed.
* platform/graphics/gtk/FontPlatformData.h: Removed.
* platform/graphics/gtk/FontPlatformDataGtk.cpp: Removed.
* platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: Removed.
* platform/graphics/gtk/SimpleFontDataGtk.cpp: Removed.
2010-03-04 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs
This fixes the crash, but the SVG still doesn't render properly.
Test: svg/custom/tiling-regular-hexagonal-crash.svg
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when
the copy fails; instead return a blank bitmap. The caller doesn't
check for 0 before dereferencing.
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
Initialize m_isMultipartPayload in other ResourceResponse ctor.
In r55451 (bug 35628) I added an extra bool, but only initialized
it in one constructor.
https://bugs.webkit.org/show_bug.cgi?id=35719
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
2010-03-03 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Add a new class that stores information about Web Socket handshake request.
Instances of this class contain the necessary information to send a Web Socket
handshake request. In the future, this class will provide request information
to the Web Inspector.
WebSocketHandshake needs to provide request information
https://bugs.webkit.org/show_bug.cgi?id=34784
No new tests, since the current tests will suffice (LayoutTests/websocket/*).
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* websockets/WebSocketChannel.cpp:
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
* websockets/WebSocketHandshake.h:
* websockets/WebSocketHandshakeRequest.cpp: Added.
(WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest):
(WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest):
(WebCore::WebSocketHandshakeRequest::addExtraHeaderField):
(WebCore::WebSocketHandshakeRequest::headerFields):
(WebCore::WebSocketHandshakeRequest::host):
* websockets/WebSocketHandshakeRequest.h: Added.
2010-03-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Build fix after r55452.
No new tests, this is a build fix.
* page/Settings.cpp:
(WebCore::Settings::setDatabasesEnabled):
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::keyIdentifierForQtKeyCode):
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
https://bugs.webkit.org/show_bug.cgi?id=35690
Test: fast/events/zoom-dblclick.html
* dom/Node.cpp:
(WebCore::Node::dispatchMouseEvent):
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Last one (I hope).
* WebCore.xcodeproj/project.pbxproj:
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Unfortunately, (the webkit-patch rollout and) I missed these in r55485.
* bindings/js/JSDatabaseCallback.cpp: Removed.
* bindings/js/JSDatabaseCallback.h: Removed.
* bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
* bindings/v8/custom/V8DatabaseCallback.h: Removed.
* storage/DatabaseCallback.h: Removed.
2010-03-02 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a bug that could lead to a crash. Some parts of
SQLTransaction::checkAndHandleClosedDatabase() should only be run
when that method is invoked on the DB thread.
We cannot test this fix with a test, because the crash happens
only when all of the following conditions are met:
1. A database is closing.
2. A transaction on that database is in progress.
3. The transaction is in a state where a statement/transaction
success/error callback needs to be invoked (so there's a task for
this transaction pending on the main thread).
4. The DB thread finished processing all its tasks and called
SQLTransactionCoordinator::shutdown() before the main thread go to
that task.
The closest thing we have to a test is running
LayoutTests/storage/database-lock-after-reload.html 1000 times in
a row. Without the patch, the probability of a crash happening in
one of the runs is very high. With the patch, the test should
reliably run 1000 times in a row without a single crash.
https://bugs.webkit.org/show_bug.cgi?id=35624
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
2010-03-03 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Page should not care about Chromium plug-in implementation details
https://bugs.webkit.org/show_bug.cgi?id=35623
* WebCore.gypi: Compile PluginViewNone.cpp
* page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Remove conditional
compilation for PLATFORM(CHROMIUM).
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55474.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* dom/Document.cpp:
(WebCore::Document::postTask):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
* storage/Database.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55480.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
* storage/Database.cpp:
* storage/Database.h:
2010-03-03 Mark Rowe <mrowe@apple.com>
Reviewed by Geoff Garen.
Add virtual memory tags for TCMalloc and WebCore's purgeable buffers.
* platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create): Use the VM tag.
2010-03-03 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by nobody, build fix.
Move #include "DatabaseCallback.h" from Database.h to
Database.cpp.
* storage/Database.cpp:
* storage/Database.h:
2010-03-03 Darin Adler <darin@apple.com>
Fixed Mac build.
* WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
be used in the WebKit project.
2010-03-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=35044
Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
I'm often getting a crash even when opening the test for the first time in Safari, but it
doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
this condition, so no new regression test.
* dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining
input will pause parsing.
2010-03-03 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Adding support for the optional creation callback that could be
passed to openDatabase().
Test: storage/open-database-creation-callback.html
https://bugs.webkit.org/show_bug.cgi?id=34726
* Android.jscbindings.mk
* Android.v8bindings.mk
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
* bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
* bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
* storage/Database.h:
(WebCore::Database::isNew):
* storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
2010-03-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resources panel only shows uncompressed resource size.
https://bugs.webkit.org/show_bug.cgi?id=35403
* English.lproj/localizedStrings.js:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::updateScriptObject):
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype.refresh):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get resourceSize):
(WebInspector.Resource.prototype.set resourceSize):
(WebInspector.Resource.prototype.get transferSize):
(WebInspector.Resource.CompareBySize):
(WebInspector.Resource.CompareByTransferSize):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.populateSidebar):
(WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
(WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages):
(WebInspector.ResourceTransferSizeCalculator.prototype._value):
(WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes):
(WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize):
(WebInspector.ResourceGraph.prototype.refreshLabelPositions):
(WebInspector.ResourceGraph.prototype.refresh):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
(WebInspector.updateResource):
2010-03-03 Dan Bernstein <mitz@apple.com>
Build fix.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
2010-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
https://bugs.webkit.org/show_bug.cgi?id=32331
* inspector/InspectorBackend.cpp:
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
(WebInspector.ProfilesPanel.prototype.profilerWasDisabled):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfilesPanel.prototype._enableProfiling):
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype.canShowSourceLine):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
(WebInspector.ScriptsPanel.prototype._enableDebugging):
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
Tests: media/audio-constructor-preload.html
media/video-dom-preload.html
* html/HTMLAttributeNames.in: Remove autobuffer, add preload
* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of
autobuffer to true.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload.
(WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute.
(WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
before calling load() so it can pass the setting through to the media engine.
(WebCore::HTMLMediaElement::preload): New.
(WebCore::HTMLMediaElement::setPreload): Ditto
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Initialize m_preload.
(WebCore::MediaPlayer::load): Pass m_preload to newly created media engine.
(WebCore::MediaPlayer::preload): New, return m_preload.
(WebCore::MediaPlayer::setPreload): New, set m_preload.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setPreload):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-03-03 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7682756> Assertion failure when replacing the contents of a <select>
Test: fast/dom/remove-children-notification-order.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
before calling removedFromDocument() on each removed child, which matches
the order removeChild() does things, and avoids the assertion. This required
temporarily storing the removed children in a vector.
Also added comments about other discrepancies between this function and
removeChild().
2010-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Document cookieURL and firstPartyForCookies
https://bugs.webkit.org/show_bug.cgi?id=35613
Some folks asked what the cookieURL and the firstPartyForCookies were
on IRC. This patch documents these properties in the code so folks
don't have to ask on IRC anymore.
* dom/Document.h:
2010-03-03 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
https://bugs.webkit.org/show_bug.cgi?id=35666
* platform/gtk/GeolocationServiceGtk.cpp:
(WebCore::GeolocationServiceGtk::startUpdating):
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
* GNUmakefile.am: dist two new files concerning mathml support.
2010-03-03 Xan Lopez <xlopez@igalia.com>
Unreviewed distcheck fix.
Add new file to the build.
* GNUmakefile.am:
2010-03-03 Antti Koivisto <koivisto@iki.fi>
Reviewed by Oliver Hunt.
Make IntPoint usable as a hash key
https://bugs.webkit.org/show_bug.cgi?id=35586
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/IntPointHash.h: Added.
(WTF::IntPointHash::hash):
(WTF::IntPointHash::equal):
(WTF::):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
https://bugs.webkit.org/show_bug.cgi?id=35310
* WebCore.base.exp: Export Database::setIsAvailable
* WebCore.xcodeproj/project.pbxproj: Export needed headers as Private
* page/DOMWindow.cpp: Read isAvailable, not Settings::isDatabaseEnabled
(WebCore::DOMWindow::openDatabase):
* page/Settings.cpp: Add a call to Database::setIsAvailable.
(WebCore::Settings::setDatabasesEnabled):
2010-03-02 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::isMultipartPayload):
(WebCore::ResourceResponse::setIsMultipartPayload):
2010-03-02 Tony Chang <tony@chromium.org>
Not reviewed, test fix.
Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::create):
2010-03-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565
Just like for running script, we need to distinguish between querying
whether plug-ins are enabled and actually blocking a page from
instantiating a plugin. We need to issue different callbacks to the
FrameLoaderClient so that the client can inform us that plug-ins are
disabled in some cases without showing the "plug-in blocked" UI.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::requestObject):
(WebCore::FrameLoader::allowPlugins):
* loader/FrameLoader.h:
(WebCore::):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didNotAllowPlugins):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
* page/Page.cpp:
(WebCore::Page::pluginData):
* plugins/MimeType.cpp:
(WebCore::MimeType::enabledPlugin):
2010-03-02 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Support the HTTP OPTIONS verb (needed for preflight requests)
https://bugs.webkit.org/show_bug.cgi?id=34647
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::start):
2010-03-02 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs
This fixes the crash, but the SVG still doesn't render properly.
Test: svg/custom/tiling-regular-hexagonal-crash.svg
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when
the copy fails; instead return a blank bitmap. The caller doesn't
check for 0 before dereferencing.
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] use geoclue providers with don't provide update
https://bugs.webkit.org/show_bug.cgi?id=35191
No new tests, behaviour depends on system.
* platform/gtk/GeolocationServiceGtk.cpp:
(WebCore::GeolocationServiceGtk::startUpdating):
2010-03-02 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Adler.
Remove unnecessary check.
https://bugs.webkit.org/show_bug.cgi?id=35513
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
2010-03-02 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
* page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): PluginView methods may
not be called in the Chromium port.
2010-03-02 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler and Adam Roben.
Fix for <rdar://problem/7485289> WebKit crashes on systems that
don't support CoreAnimation
WKCACFLayerRenderer::acceleratedCompositingAvailable() now creates
a dummy HWND so that it can step through the whole setHostWindow()
and createRenderer() process. createRenderer() also calls a new
function, hardwareCapabilitiesIndicateCoreAnimationSupport() which
can only be called once we have a d3dDevice.
setHostWindow() and createRenderer() now both return bools that
indicate whether or not they have succeeded.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::hardwareCapabilitiesIndicateCoreAnimationSupport):
(WebCore::CoreAnimationTesterWindowWndProc):
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
(WebCore::WKCACFLayerRenderer::shared):
(WebCore::WKCACFLayerRenderer::createRenderer):
* platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRenderer::setHostWindow):
2010-03-02 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Jon Honeycutt.
ScriptDebugServer shouldn't care that Mac does not use PluginView for plug-ins.
* bindings/js/ScriptDebugServer.cpp:
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::setJavaScriptPaused): Add an empty implementation of setJavaScriptPaused.
2010-03-02 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Jon Honeycutt.
Clean up the build fix r55437 by adding an empty implementation of privateBrowsingStateChanged in PluginViewNone.cpp
* page/Page.cpp:
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::privateBrowsingStateChanged):
2010-03-02 Mark Rowe <mrowe@apple.com>
Fix the Mac build.
* page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Mac doesn't use WebCore's PluginView class
for plug-ins, so provide an empty implementation of privateBrowsingStateChanged for Mac.
2010-03-02 Andy Estes <aestes@apple.com>
Reviewed by Maciej Stachowiak.
Add the capability to create and dispatch a WheelEvent in JavaScript.
Ensure the event's default handler is triggered in the same way as it is
during a PlatformWheelEvent.
https://bugs.webkit.org/show_bug.cgi?id=35566
Test: fast/events/wheelevent-in-scrolling-div.html
* dom/Node.cpp: Ensure that the default behavior (scrolling) occurs for
wheel events originating both from the platform and from
JavaScript/ObjC.
(WebCore::Node::dispatchWheelEvent): Instantiate new WheelEvent with
the graunularity of the PlatformWheelEvent.
(WebCore::Node::defaultEventHandler): Add support for mousewheel events.
* dom/WheelEvent.cpp: Add three new member variables: m_deltaX, m_deltaY
and m_granularity. m_deltaX and m_deltaY differ from m_wheelDeltaX and
m_wheelDeltaY, which are the number of wheel ticks multiplied by 120 for
IE compatibility.
(WebCore::WheelEvent::WheelEvent): Initialize new member variables.
(WebCore::WheelEvent::initWheelEvent): Same.
(WebCore::WheelEvent::initWebKitWheelEvent): Same.
* dom/WheelEvent.h: See WheelEvent.cpp.
(WebCore::WheelEvent::): Add Granularity enum (Pixel, Line, Page).
(WebCore::WheelEvent::create): Add new arguments.
(WebCore::WheelEvent::deltaX): Amount of scroll in x direction.
(WebCore::WheelEvent::deltaY): Amount of scroll in y direction.
(WebCore::WheelEvent::granularity): Units of deltaX and deltaY.
* dom/WheelEvent.idl: Add initWebKitWheelEvent() to JavaScript. This is
the same as the initWheelEvent ObjC method. As the DOM Level 3 Events
specification is still a working draft and subject to change, prefix
'WebKit' to the method signature to indicate experimental support.
* page/EventHandler.cpp: Move the scroll handling from
handleWheelEvent() to defaultWheelEventHandler(), which is executed on
both PlatformWheelEvents and JavaScript WheelEvents.
(WebCore::scrollNode): Renamed from scrollAndAcceptEvent(). Remove
the PlatformWheelEvent from the argument list and instead return a
boolean indicating if the scroll event was accepted.
(WebCore::EventHandler::handleWheelEvent): Move scrolling code from here
(WebCore::EventHandler::defaultWheelEventHandler): ...to here.
* page/EventHandler.h: Add function signature.
2010-03-02 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Bug 35576: WebKit should tell plug-in instances when private browsing state changes
<http://webkit.org/b/35576>
Notify plug-in instances when the private browsing state changes to match the behavior of the
Mac plug-in code.
* page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Walk the frame tree and notify each PluginView that
the private browsing state has changed.
* page/Page.h:
* page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled): Notify the page that the private browsing state
has changed.
* plugins/PluginView.cpp:
(WebCore::PluginView::privateBrowsingStateChanged): Notify the plug-in instance of the new private
browsing state.
* plugins/PluginView.h:
2010-03-02 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Bug 30348: Implement private mode for plug-ins on Windows
<http://webkit.org/b/30348> / <rdar://problem/7562261>
Rework PluginView::getValue and PluginView::getValueStatic to remove the amount of code that
was duplicated across platforms. getValue and getValueStatic now call in to platform-specific
variants that indicate whether they handled the query. If the query is not handled by the
platform-specific variants then the cross-platform handler has a chance to handle it.
* plugins/PluginView.cpp:
(WebCore::PluginView::getValueStatic): Give the platform-specific variant a chance to handle the
variable lookup. If it does not handle it, return an error.
(WebCore::PluginView::getValue): Give the platform-specific variant and platform-specific static
variant a chance to handle the variable lookup. If they do not handle it, apply the cross-platform
handler. At the moment the cross-platform code handles NPNVWindowNPObject, NPNVPluginElementNPObject,
and NPNVprivateModeBool as they have an identical implementation across ports.
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::platformGetValue): PluginViewNone does not handle any lookups.
(WebCore::PluginView::platformGetValueStatic): Ditto.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
platform-independent implementation.
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue): Fix a bug noticed while updating this code.
The Qt implementation of the handler for NPNVToolkit was relying on case fall-through
to have some values handled by the static handler. When NPNVprivateModeBool was added
it was placed before the default case, interferring with this fall-through. It now
explicitly indicates in this situation that it was not handled.
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
2010-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make the default constructor available to all platforms.
* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/mac/KeyEventMac.mm:
2010-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519
Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::databaseThread):
* storage/DatabaseThread.h:
(WebCore::DatabaseThread::getThreadID):
2010-03-02 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Followup for REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript): To more perfectly match Gecko's rule,
strip whitespace from the attribute values before comparing to window/onload/onload().
2010-03-02 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
aria-label isn't respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=35400
When aria-label is used on an <option> element, it can take three forms.
An option in a multi-select list, a popup button and the menu that is displayed
from the popup button. This patches the three requisite locations so that if
aria-label is used, the correct accessibility text is returned.
Test: platform/mac/accessibility/option-with-arialabel.html
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::stringValue):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::getAttribute):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getAttribute):
(WebCore::AccessibilityRenderObject::stringValue):
* platform/PopupMenuClient.h:
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemAccessibilityText):
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlSingleLine::itemAccessibilityText):
2010-03-02 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526
Notify V8 of context disposals to allow it to clean up memory from those
contexts when idle. When disposing a context, start a timer that will
give V8 an idle notification after a while to force cleanup. Use a timer
to avoid performing an idle notification in the middle of navigation where
we know we are not idle.
* WebCore.gypi:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
* bindings/v8/V8GCForContextDispose.cpp: Added.
(WebCore::V8GCForContextDispose::V8GCForContextDispose):
(WebCore::V8GCForContextDispose::notifyContextDisposed):
(WebCore::V8GCForContextDispose::notifyIdleSooner):
(WebCore::V8GCForContextDispose::instance):
(WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
* bindings/v8/V8GCForContextDispose.h: Added.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
2010-03-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: adding missing image files to WebKit.qrc and gypi.
* WebCore.gypi:
* inspector/front-end/WebKit.qrc:
2010-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.
https://bugs.webkit.org/show_bug.cgi?id=35516
No new tests.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQt::setContentsToMedia):
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Use unsigned instead of uint which does not exist on windows
https://bugs.webkit.org/show_bug.cgi?id=35546
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::getCairoSurfacePixel):
(WebCore::getGdkPixbufPixel):
2010-03-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558
New functionality verified manually in Chromium; not possible to
write layout test. Ran WebGL tests in WebKit as well.
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
(WebCore::RuntimeEnabledFeatures::webGLRenderingContextEnabled):
(WebCore::RuntimeEnabledFeatures::webGLArrayBufferEnabled):
(WebCore::RuntimeEnabledFeatures::webGLByteArrayEnabled):
(WebCore::RuntimeEnabledFeatures::webGLUnsignedByteArrayEnabled):
(WebCore::RuntimeEnabledFeatures::webGLShortArrayEnabled):
(WebCore::RuntimeEnabledFeatures::webGLUnsignedShortArrayEnabled):
(WebCore::RuntimeEnabledFeatures::webGLIntArrayEnabled):
(WebCore::RuntimeEnabledFeatures::webGLUnsignedIntArrayEnabled):
(WebCore::RuntimeEnabledFeatures::webGLFloatArrayEnabled):
* page/DOMWindow.idl:
2010-03-02 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fail gracefully if NPN_GetProperty tries to retrieve a property that doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=35588
Required for passing LayoutTests/plugins/netscape-plugin-property-access-exception.html on Chromium.
* bindings/v8/NPV8Object.cpp:
(_NPN_GetProperty): If the result is empty, don't try to convert it to an NPVariant and return false.
2010-03-02 Jian Li <jianli@chromium.org>
Reviewed by Nate Chapin.
[V8] DOMCoreException should be visible as DOMException
https://bugs.webkit.org/show_bug.cgi?id=35552
Fix V8 code generator to use the correct visible name.
* bindings/scripts/CodeGeneratorV8.pm:
2010-03-02 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556
Test: fast/loader/for-window-event-onload-scripts.html
Match Gecko's rules for executing "for/event" scripts:
-If there's only a 'for' attribute, execute it.
-If there's only an 'event' attribute, execute it.
-If there's a 'for=window' and 'event=onload', execute it.
-If there's a 'for=window' and 'event=onload()', execute it.
-If there's any other combination of both 'for' and 'event', don't execute it.
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript):
* dom/ScriptElement.h:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::eventAttributeValue):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::eventAttributeValue):
* svg/SVGScriptElement.h:
Add the event attribute name:
* html/HTMLAttributeNames.in:
2010-03-02 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35555
QuickTime plugin content can spill outside the <object> tag
Set -masksToBounds on the layer that is handed to us by plug-ins, to ensure that sublayers
of that layer don't spill outside the <object> contents rect.
Manual test because it relies on QuickTime, and pixel results depend on movie loading timing.
* manual-tests/plugins/object-clipping.html: Added.
* platform/graphics/mac/GraphicsLayerCA.mm:
(WebCore::GraphicsLayerCA::setupContentsLayer):
2010-03-02 Adam Roben <aroben@apple.com>
Export SecurityOrigin::registerURLSchemeAsSecure
Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
Reviewed by Tim Hatcher.
* WebCore.base.exp: Added symbol, sorted file.
2010-03-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: render breakpoints as border images instead of canvas.
https://bugs.webkit.org/show_bug.cgi?id=35535
* inspector/front-end/Images/breakpointBorder.png: Added.
* inspector/front-end/Images/breakpointConditionalBorder.png: Added.
* inspector/front-end/Images/breakpointConditionalCounterBorder.png: Added.
* inspector/front-end/Images/breakpointCounterBorder.png: Added.
* inspector/front-end/Images/programCounterBorder.png: Added.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._updateExecutionLine):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype.resize):
* inspector/front-end/TextViewer.js:
(WebInspector.TextChunk):
* inspector/front-end/textViewer.css:
2010-01-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Ariya Hidayat.
[Qt] Special case Font::floatWidthForComplexText for single space
https://bugs.webkit.org/show_bug.cgi?id=33876
For a single space we can go through the QFontMetric::width routine
instead of converting the WebCore::String to a QString and then
going through the QTextLine.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):
2010-02-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Gustavo Noronha.
[Gtk] Support private browsing mode in plugins.
https://bugs.webkit.org/show_bug.cgi?id=35500
Integrate the PluginViewQt.cpp changes from r55358 into Gtk+.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
2010-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Update Qt bridge to new named getter signature
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
(JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
* bridge/qt/qt_runtime.h:
2010-03-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Move gstreamer-related source files to platform/graphics/gstreamer
https://bugs.webkit.org/show_bug.cgi?id=35518
Moved GStreamer-related files to platform/graphics/gstreamer so
other ports could benefit from this media player implementation.
* GNUmakefile.am:
* platform/graphics/gstreamer/DataSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp.
(_do_init):
(webkit_data_src_base_init):
(webkit_data_src_class_init):
(webkit_data_src_reset):
(webkit_data_src_init):
(webkit_data_src_finalize):
(webkit_data_src_change_state):
(webkit_data_src_uri_get_type):
(webkit_data_src_uri_get_protocols):
(webkit_data_src_uri_get_uri):
(webkit_data_src_uri_set_uri):
(webkit_data_src_uri_handler_init):
* platform/graphics/gstreamer/DataSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.h.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp.
(WebCore::greatestCommonDivisor):
(WebCore::mediaPlayerPrivateMessageCallback):
(WebCore::mediaPlayerPrivateSourceChangedCallback):
(WebCore::mediaPlayerPrivateVolumeChangedCallback):
(WebCore::notifyVolumeIdleCallback):
(WebCore::mediaPlayerPrivateMuteChangedCallback):
(WebCore::notifyMuteIdleCallback):
(WebCore::bufferingTimeoutCallback):
(WebCore::playbackPosition):
(WebCore::mediaPlayerPrivateRepaintCallback):
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::doGstInit):
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::changePipelineState):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded):
(WebCore::MediaPlayerPrivate::cancelSeek):
(WebCore::MediaPlayerPrivate::endPointTimerFired):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::volumeChangedCallback):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::queryBufferingStats):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::mediaLocationChanged):
(WebCore::MediaPlayerPrivate::loadNextLocation):
(WebCore::MediaPlayerPrivate::loadStateChanged):
(WebCore::MediaPlayerPrivate::sizeChanged):
(WebCore::MediaPlayerPrivate::timeChanged):
(WebCore::MediaPlayerPrivate::didEnd):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::muteChangedCallback):
(WebCore::MediaPlayerPrivate::muteChanged):
(WebCore::MediaPlayerPrivate::loadingFailed):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::repaint):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::setAutobuffer):
(WebCore::MediaPlayerPrivate::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.h.
(WebCore::MediaPlayerPrivate::pipelineReset):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp.
(webkit_video_sink_base_init):
(webkit_video_sink_init):
(webkit_video_sink_timeout_func):
(webkit_video_sink_render):
(webkit_video_sink_dispose):
(unlock_buffer_mutex):
(webkit_video_sink_unlock):
(webkit_video_sink_unlock_stop):
(webkit_video_sink_stop):
(webkit_video_sink_start):
(marshal_VOID__MINIOBJECT):
(webkit_video_sink_class_init):
(webkit_video_sink_new):
* platform/graphics/gstreamer/VideoSinkGStreamer.h: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.h.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp.
(doInit):
(webkit_web_src_base_init):
(webkit_web_src_class_init):
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcUriHandlerInit):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetFrame):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::willSendRequest):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::didFail):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.h.
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
Fix up WebCore to use the new named getter function signature, update the
codegenerator to the new calling convention, and fix the custom bindings.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
* bindings/js/JSDOMBinding.cpp:
(WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::namedItemGetter):
* bindings/js/JSDataGridColumnListCustom.cpp:
(WebCore::JSDataGridColumnList::nameGetter):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::JSHTMLAllCollection::nameGetter):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
* bindings/js/JSMimeTypeArrayCustom.cpp:
(WebCore::JSMimeTypeArray::nameGetter):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginArrayCustom.cpp:
(WebCore::JSPluginArray::nameGetter):
* bindings/js/JSPluginCustom.cpp:
(WebCore::JSPlugin::nameGetter):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectPropertyGetter):
* bindings/js/JSPluginElementFunctions.h:
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::nameGetter):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::nameGetter):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter):
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::lengthGetter):
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
* bridge/runtime_object.h:
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561
Update bindings generation and the few manual indexing getters we have to use
the new PropertySlot API.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::indexGetter):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::indexGetter):
* bridge/runtime_array.h:
2010-03-01 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
When a table's DOM is changed and an AX Table is not asked first for its children,
it would return wrong information. A table needs to make sure children are up to date in
all methods that can be called from the outside.
Test: platform/mac/accessibility/stale-table-rows.html
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clearChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::children):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::needsToUpdateChildren):
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Convert the zoom mode (page vs. text-only) into a proper enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
* GNUmakefile.am:
* WebCore.base.exp: Substituted symbols __ZN7WebCore5Frame13setZoomFactorEfNS_8ZoomModeE
and __ZN7WebCore8Settings11setZoomModeENS_8ZoomModeE for __ZN7WebCore5Frame13setZoomFactorEfb
and __ZN7WebCore8Settings16setZoomsTextOnlyEb, respectively.
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/Frame.cpp:
(WebCore::Frame::zoomMode):
(WebCore::Frame::shouldApplyTextZoom):
(WebCore::Frame::shouldApplyPageZoom):
(WebCore::Frame::setZoomFactor):
* page/Frame.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setZoomMode):
* page/Settings.h:
(WebCore::Settings::zoomMode):
* page/ZoomMode.h: Added.
(WebCore::):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentScale):
2010-03-01 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added support for the msubsup element that also handles the msup and msub elements.
Test: mathml/presentation/subsup.xhtml
* WebCore.xcodeproj/project.pbxproj:
* mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createRenderer):
* mathml/RenderMathMLSubSup.cpp: Added.
(WebCore::RenderMathMLSubSup::RenderMathMLSubSup):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::nonOperatorHeight):
(WebCore::RenderMathMLSubSup::layout):
(WebCore::RenderMathMLSubSup::baselinePosition):
* mathml/RenderMathMLSubSup.h: Added.
(WebCore::RenderMathMLSubSup::hasBase):
(WebCore::RenderMathMLSubSup::):
2010-03-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: use dejavu sans mono 11px on linux.
https://bugs.webkit.org/show_bug.cgi?id=35527
* inspector/front-end/inspector.css:
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
* platform/Widget.h:
(WebCore::Widget::widgetPositionsUpdated): new virtual method
widgetPositionsUpdated() to notify widgets when other widgets on
the page have been repositioned.
* rendering/RenderView.cpp:
(WebCore::RenderView::updateWidgetPositions): call widgetPositionsUpdated() on the widgets
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::widgetPositionsUpdated): call widgetPositionsUpdated() on the widget
* rendering/RenderWidget.h:
2010-03-01 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
Dist some mathml related files
* GNUmakefile.am:
2010-03-01 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241
Test: fast/canvas/webgl/webgl-array-invalid-ranges.html
* bindings/js/JSWebGLArrayBufferConstructor.cpp:
(WebCore::constructCanvasArrayBuffer):
* bindings/js/JSWebGLArrayBufferConstructor.h:
(WebCore::construct):
* bindings/js/JSWebGLArrayHelper.h:
(WebCore::setWebGLArrayFromArray):
* bindings/js/JSWebGLByteArrayConstructor.cpp:
(WebCore::constructCanvasByteArray):
* bindings/js/JSWebGLFloatArrayConstructor.cpp:
(WebCore::constructCanvasFloatArray):
* bindings/js/JSWebGLIntArrayConstructor.cpp:
(WebCore::constructCanvasIntArray):
* bindings/js/JSWebGLShortArrayConstructor.cpp:
(WebCore::constructCanvasShortArray):
* bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp:
(WebCore::constructCanvasUnsignedByteArray):
* bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp:
(WebCore::constructCanvasUnsignedIntArray):
* bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp:
(WebCore::constructCanvasUnsignedShortArray):
* bindings/v8/V8Binding.cpp:
(WebCore::toUInt32):
* bindings/v8/V8Binding.h:
(WebCore::toUInt32):
* bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
(WebCore::V8WebGLArrayBuffer::constructorCallback):
* bindings/v8/custom/V8WebGLArrayCustom.h:
(WebCore::constructWebGLArray):
(WebCore::getWebGLArrayElement):
(WebCore::setWebGLArrayFromArray):
(WebCore::setWebGLArray):
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
(WebCore::V8WebGLByteArray::constructorCallback):
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
(WebCore::V8WebGLFloatArray::constructorCallback):
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
(WebCore::V8WebGLIntArray::constructorCallback):
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
(WebCore::V8WebGLShortArray::constructorCallback):
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
(WebCore::V8WebGLUnsignedByteArray::constructorCallback):
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
(WebCore::V8WebGLUnsignedIntArray::constructorCallback):
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
(WebCore::V8WebGLUnsignedShortArray::constructorCallback):
* html/canvas/WebGLArray.cpp:
(WebCore::WebGLArray::setImpl):
* html/canvas/WebGLArray.h:
(WebCore::WebGLArray::verifySubRange):
(WebCore::WebGLArray::clampOffsetAndNumElements):
* html/canvas/WebGLArrayBuffer.cpp:
(WebCore::WebGLArrayBuffer::create):
(WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
(WebCore::WebGLArrayBuffer::tryAllocate):
* html/canvas/WebGLArrayBuffer.h:
* html/canvas/WebGLByteArray.cpp:
(WebCore::WebGLByteArray::create):
(WebCore::WebGLByteArray::WebGLByteArray):
(WebCore::WebGLByteArray::slice):
* html/canvas/WebGLByteArray.h:
* html/canvas/WebGLFloatArray.cpp:
(WebCore::WebGLFloatArray::create):
(WebCore::WebGLFloatArray::WebGLFloatArray):
(WebCore::WebGLFloatArray::slice):
* html/canvas/WebGLFloatArray.h:
* html/canvas/WebGLIntArray.cpp:
(WebCore::WebGLIntArray::create):
(WebCore::WebGLIntArray::WebGLIntArray):
(WebCore::WebGLIntArray::slice):
* html/canvas/WebGLIntArray.h:
* html/canvas/WebGLShortArray.cpp:
(WebCore::WebGLShortArray::create):
(WebCore::WebGLShortArray::WebGLShortArray):
(WebCore::WebGLShortArray::slice):
* html/canvas/WebGLShortArray.h:
* html/canvas/WebGLUnsignedByteArray.cpp:
(WebCore::WebGLUnsignedByteArray::create):
(WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
(WebCore::WebGLUnsignedByteArray::slice):
* html/canvas/WebGLUnsignedByteArray.h:
* html/canvas/WebGLUnsignedIntArray.cpp:
(WebCore::WebGLUnsignedIntArray::create):
(WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
(WebCore::WebGLUnsignedIntArray::slice):
* html/canvas/WebGLUnsignedIntArray.h:
* html/canvas/WebGLUnsignedShortArray.cpp:
(WebCore::WebGLUnsignedShortArray::create):
(WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
(WebCore::WebGLUnsignedShortArray::slice):
* html/canvas/WebGLUnsignedShortArray.h:
2010-03-01 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
<rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532
Test: fast/loader/api-test-go-to-current-back-forward-item.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): If the current item is the same as the target item, don't
consider this to be a same document navigation.
* page/Page.cpp:
(WebCore::Page::goToItem): Hard code the "going to the same item as the current item" relationship
as a precondition for stopping all loaders, as that will be a new document load.
2010-03-01 Robert Hogan <robert@webkit.org>
Reviewed by nobody, build fix.
Fix --minimal build. Add ENABLE(DATABASE) as compile time condition
for building file GeolocationPositionCache.cpp.
* page/GeolocationPositionCache.cpp:
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Implement support for paths
https://bugs.webkit.org/show_bug.cgi?id=34366
Adds an implementation of the Path class -
*almost* complete, but not quite because OpenVG
does not provide access to the points in a VGPath
unless one keeps track of all the points by
themselves, which we decided not to do.
Also hooked up to PainterOpenVG and GraphicsContext.
Further introduced is SharedResourceOpenVG, which is
intended as base class for paths and other OpenVG
resources (images, fonts) that WebKit creates as
long-lived objects. We are at a slight disadvantage
here as WebKit doesn't have the concept of resources
belonging to a specific (hardware graphics) context,
which is the reason why EGLDisplayOpenVG had to
provide a current display singleton; this class is
what actually requires that functionality.
Path::addArcTo() uses code by Yong Li <yoli@rim.com>.
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::beginPath):
(WebCore::GraphicsContext::addPath):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::PainterOpenVG):
(WebCore::PainterOpenVG::~PainterOpenVG):
(WebCore::PainterOpenVG::transformPath):
(WebCore::PainterOpenVG::beginPath):
(WebCore::PainterOpenVG::addPath):
(WebCore::PainterOpenVG::currentPath):
(WebCore::PainterOpenVG::drawPath):
* platform/graphics/openvg/PainterOpenVG.h:
* platform/graphics/openvg/PathOpenVG.cpp: Added.
(WebCore::PlatformPathOpenVG::PlatformPathOpenVG):
(WebCore::PlatformPathOpenVG::operator=):
(WebCore::PlatformPathOpenVG::~PlatformPathOpenVG):
(WebCore::PlatformPathOpenVG::clear):
(WebCore::PlatformPathOpenVG::createPath):
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::operator=):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::debugString):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/openvg/PlatformPathOpenVG.h: Added.
(WebCore::PlatformPathOpenVG::vgPath):
* platform/graphics/openvg/SharedResourceOpenVG.cpp: Added.
(WebCore::SharedResourceOpenVG::makeSharedContextCurrent):
(WebCore::SharedResourceOpenVG::makeCompatibleContextCurrent):
* platform/graphics/openvg/SharedResourceOpenVG.h: Added.
2010-03-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, bring English.lproj/locallizedStrings.js back to binary (UTF) mode.
* English.lproj/localizedStrings.js:
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Convert from TransformationMatrix to AffineTransform.
https://bugs.webkit.org/show_bug.cgi?id=35445
Dirk Schulze previously introduced AffineTransform as
replacement for most TransformationMatrix occurrences
in GraphicsContext & Co., but did not update the OpenVG
graphics backend as there's no publicly available way
to build it. This commit now takes care of that.
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::origin):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::isNonRotatedAffineTransformation):
(WebCore::PlatformPainterState::PlatformPainterState):
(WebCore::PlatformPainterState::applyState):
(WebCore::PlatformPainterState::applyTransformation):
(WebCore::PainterOpenVG::transformation):
(WebCore::PainterOpenVG::concatTransformation):
(WebCore::PainterOpenVG::setTransformation):
(WebCore::PainterOpenVG::scale):
(WebCore::PainterOpenVG::rotate):
(WebCore::PainterOpenVG::translate):
(WebCore::PainterOpenVG::intersectClipRect):
* platform/graphics/openvg/PainterOpenVG.h:
* platform/graphics/openvg/VGUtils.cpp:
(WebCore::VGMatrix::VGMatrix):
(WebCore::VGMatrix::operator AffineTransform):
(WebCore::VGMatrix::operator TransformationMatrix):
(WebCore::AffineTransform::operator VGMatrix):
* platform/graphics/openvg/VGUtils.h:
* platform/graphics/transforms/AffineTransform.h:
2010-03-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix segfault when drawing NPAPI plugins on Mac
Don't try to get a contexctRef for a null-pixmap. If the pixmap
size is 0,0 the private pixmap data has not yet been initialized.
* plugins/mac/PluginViewMac.cpp:
2010-03-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt build on Mac OS X/Cocoa 64-bit
Use the proper event/drawing-model guards instead of global 64-bit
guard for the NPAPI plugin implementation (view and package).
* plugins/mac/PluginPackageMac.cpp: Change guards and fix warning
* plugins/mac/PluginViewMac.cpp: Remove 64-bit guard
2010-02-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable breakpoint upon Shift-click.
https://bugs.webkit.org/show_bug.cgi?id=35477
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._format):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._mouseMove):
* inspector/front-end/textViewer.css:
2010-02-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35496
<rdar://problem/7663444> Opening newsweek.com and youtube.com has become very slow in debug builds
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::getIDRules):
(WebCore::CSSRuleSet::getClassRules):
(WebCore::CSSRuleSet::getTagRules):
Removed consistency checks, as they affect performance too much in this case.
2010-02-28 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
[Qt] Support private browsing mode in plugins
Add support for NPNVprivateModeBool property in plugins.
See also: https://developer.mozilla.org/En/Supporting_private_browsing_in_plugins
The NPNVprivateModeBool property is supported as scriptable property privateBrowsingEnabled
in the test WebKit plugin. The Mac platform also supports a cachedPrivateBrowsingEnabled
property implemented in the test plugin. This allows the Layout test
plugins/private-browsing-mode.html to retrieve the previous value of NPNVprivateModeBool
in the test plugin. Due to the platform-specific overhead required to support this bespoke
property it is not implemented as part of this patch, instead a new test,
plugins/private-browsing-mode-2.html, is added to ensure that setting and resetting
privateBrowsingEnabled works as expected.
http://bugs.webkit.org/show_bug.cgi?id=33180
Test: plugins/private-browsing-mode-2.html
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::getValue):
2010-02-27 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"
https://bugs.webkit.org/show_bug.cgi?id=33478
* inspector/front-end/StylesSidebarPane.js:
2010-02-27 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/7696607> Links do not respect -webkit-user-drag: none
https://bugs.webkit.org/show_bug.cgi?id=35475
Test: fast/css/user-drag-none.html
* page/DragController.cpp:
(WebCore::DragController::mayStartDragAtEventLocation): Added a node
parameter. The image drag check is done against the node, rather than
than against the hit test result. This prevents a non-draggable image
with an auto-draggable ancestor from being dragged alone. The link drag
check now ignores links that are -webkit-user-drag: none.
* page/DragController.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::shouldDragAutoNode): Pass the current node
to mayStartDragAtEventLocation().
2010-02-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: hangs when scrolling in Resource pane.
https://bugs.webkit.org/show_bug.cgi?id=35216
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
2010-02-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Abort XEmbed plugin initialization if our parent is not anchored
in a widget hierarchy. This can happen when the browser window is
destroyed while the plugin is being loaded, and will lead to a
crash.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformStart):
2010-02-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: reload inspected page on Cmd+R / Ctrl+R / F5 key event in inspector.
Drive-by fix for couple of minor front-end problems.
https://bugs.webkit.org/show_bug.cgi?id=35434
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::reloadPage):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didFinishLoading):
(WebCore::InspectorController::didFailLoading):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub.prototype.reloadPage):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._paintLine):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.toggleAttach):
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
* platform/efl/ScrollbarEfl.cpp: Added.
* platform/efl/EventLoopEfl.cpp: Added.
* platform/efl/PlatformKeyboardEventEfl.cpp: Added.
* platform/efl/DragImageEfl.cpp: Added.
* platform/efl/PlatformMouseEventEfl.cpp: Added.
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
* platform/efl/CursorEfl.cpp: Added.
* platform/efl/LocalizedStringsEfl.cpp: Added.
* platform/efl/SearchPopupMenuEfl.cpp: Added.
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to page/efl.
http://webkit.org/b/35087
* WebCore/page/efl/DragControllerEfl.cpp: Added.
* WebCore/page/efl/FrameEfl.cpp: Added.
* WebCore/page/efl/AccessibilityObjectEfl.cpp: Added.
* WebCore/page/efl/EventHandlerEfl.cpp: Added.
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
* WebCore/platform/efl/LoggingEfl.cpp: Added.
* WebCore/platform/efl/ScrollbarThemeEfl.cpp: Added.
* WebCore/platform/efl/TemporaryLinkStubs.cpp: Added.
* WebCore/platform/efl/ScrollViewEfl.cpp: Added.
* WebCore/platform/efl/SharedBufferEfl.cpp: Added.
* WebCore/platform/efl/DragDataEfl.cpp: Added.
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
* WebCore/platform/efl/RenderThemeEfl.cpp: Added.
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
* WebCore/platform/efl/PlatformWheelEventEfl.cpp: Added.
* WebCore/platform/efl/FileChooserEfl.cpp: Added.
* WebCore/platform/efl/ContextMenuEfl.cpp: Added.
* WebCore/platform/efl/PlatformScreenEfl.cpp: Added.
* WebCore/platform/efl/WidgetEfl.cpp: Added.
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438
Add a notion of a "secure" scheme that doesn't trigger mixed content
warnings. Let folks register new secure schemes in the same way they
can register "local" schemes.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::isMixedContent):
* page/SecurityOrigin.cpp:
(WebCore::secureSchemes):
(WebCore::SecurityOrigin::registerURLSchemeAsSecure):
(WebCore::SecurityOrigin::shouldTreatURLSchemeAsSecure):
* page/SecurityOrigin.h:
2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayerQt: artifacts and wrong transformOrigin
This was due to wrong way of applying cache-mode and transformation
on a graphics-item with HTML. Cache-mode should be updated
when the content type updates, even if it was the same cache-mode
https://bugs.webkit.org/show_bug.cgi?id=35382
Test URL attached to the bug now works correctly.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::computeTransform):
(WebCore::GraphicsLayerQtImpl::flushChanges):
2010-02-26 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Qt/Mac: Revert null timer removal (r51105)
https://bugs.webkit.org/show_bug.cgi?id=35396
r51105 removed the null timer event of the carbon event model. This however
breaks the flash of many sites.
Applying patch suggested by Girish Ramakrishnan in bug comment #1.
* plugins/PluginView.h:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformStart):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::nullEventTimerFired):
(WebCore::PluginView::mousePosForPlugin):
2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile error with 3d-canvas
Replaced a direct gl call with a getProcAddress call
https://bugs.webkit.org/show_bug.cgi?id=35448
No new tests.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::blendColor):
2010-02-26 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[BREWMP] Port EventHandler
https://bugs.webkit.org/show_bug.cgi?id=34796
Add platform-specific code required to implement EventHandler.
* page/brew/EventHandlerBrew.cpp: Added.
(WebCore::EventHandler::tabsToAllControls):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::passSubframeEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::accessKeyModifiers):
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
* WebCore/platform/efl/ClipboardEfl.cpp: Added.
* WebCore/platform/efl/PopupMenuEfl.cpp: Added.
* WebCore/platform/efl/SharedTimerEfl.cpp: Added.
* WebCore/platform/efl/RenderThemeEfl.h: Added.
* WebCore/platform/efl/Language.cpp: Added.
* WebCore/platform/efl/CookieJarEfl.cpp: Added.
* WebCore/platform/efl/MIMETypeRegistryEfl.cpp: Added.
2010-02-26 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Nate Chapin
To fire each event handler registered on an SVG node once per
event, Chromium needs an implementation of wasCreatedFromMarkup
added to V8LazyEventListener.h that matches the one in
WebKit/WebCore/bindings/js/JSLazyEventListener.h.
This patch adds such a matching implementation of wasCreatedFromMarkup
to V8LazyEventListener.h.
https://bugs.webkit.org/show_bug.cgi?id=35325
* bindings/v8/V8LazyEventListener.h:
(WebCore::V8LazyEventListener::wasCreatedFromMarkup):
2010-02-26 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] use geoclue_position_get_position_async to get geolocation position.
https://bugs.webkit.org/show_bug.cgi?id=35355
No new tests, behaviour depends on system.
* platform/gtk/GeolocationServiceGtk.cpp:
(WebCore::GeolocationServiceGtk::startUpdating):
(WebCore::GeolocationServiceGtk::get_position):
* platform/gtk/GeolocationServiceGtk.h:
2010-02-26 Yaar Schnitman <yaar@chromium.org>
Chromium Win build fix.
* WebCore.gyp/WebCore.gyp: Added missing file to action input.
2010-02-12 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.
https://bugs.webkit.org/show_bug.cgi?id=34859
This is covered by fast/dom/Window/invalid-protocol.html
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
* platform/KURLGoogle.cpp:
(WebCore::KURL::setProtocol):
(WebCore::KURL::isHierarchical):
2010-02-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Build fix following r55312).
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::invokeMethod):
2010-02-26 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Auto-generate and split DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=33048
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_derivedsourcesallinone.py: Added.
* bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
2010-02-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Build fix following r55312).
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::invokeMethod):
2010-02-26 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35450
Crash when a Java array property accessor raises an exception
Test: java/inaccessible-class.html
* bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): Check if the result
is null before interpreting it as an object or array.
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Extend AffineTransform to mapQuad
https://bugs.webkit.org/show_bug.cgi?id=35444
This makes mapQuad available for AffineTransform. So that platforms
can make use of it after the switch from TransformationMatrix to
AffineTransform in GraphicsContext.
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapRect): mapRect already did the calculation for mapQuad but gave back the
boundingBox of the resulting FloatQuad.
(WebCore::AffineTransform::mapQuad):
* platform/graphics/transforms/AffineTransform.h:
2010-02-26 Brady Eidson <beidson@apple.com>
Reviewed by Pavel Feldman.
Arrow keys do not scroll source view in Resources pane or Scripts pane.
<rdar://problem/7594367> and https://bugs.webkit.org/show_bug.cgi?id=34356
Handle vertical scrolling in the Text Viewer:
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer): Listen for the keydown event.
(WebInspector.TextViewer.prototype._handleKeyDown): If the event has no modifiers and refers
to an arrow key, scroll. The horizontal values were ripped from the default "pixels per scroll line"
value in ScrollBar.h.
2010-02-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Alexey Proskuryakov.
Bug 35401 - Fix handling of errors in handling calls over bridge,
where base object bridge-type does not match method bridge-type.
The code assumes users will only attempt to invoke a Java method
on a Java base object, etc.
Add language specific subclasses of RuntimeMethod, and pass the
RuntimeMethod into invokeMethod, so we can typecheck before
casting. Throw an exception on type mismatch.
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):new class to distinguish this type of RuntimeMethod.
(JSC::Bindings::CInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JSC::Bindings::CInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
* bridge/c/c_instance.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::JavaRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(JavaInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JavaInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
* bridge/jni/jsc/JavaInstanceJSC.h:
* bridge/jsc/BridgeJSC.h:
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
(ObjcRuntimeMethod::ObjcRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(ObjcInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(ObjcInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
(ObjcInstance::invokeObjcMethod): new method, takes an ObjcMethod* as an argument so that we don't need to dynamically determine the type.
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject): use new invokeObjcMethod method.
* bridge/runtime_method.cpp:
(JSC::callRuntimeMethod): pass RuntimeMethod as argument to invokeMethod, rather than its MethodList.
* bridge/runtime_object.cpp:
(JSC::RuntimeObject::methodGetter): use new getMethod method.
2010-02-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Make the lookup table generator include an explicit cast to expected
type of the function. We do this because otherwise the blind intptr_t
cast that is subsequently applied allows incorrectly typed functions
to be inserted into the table, where they will only fail at runtime.
This change makes such errors produce a compile time failure.
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
2010-02-26 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added basic support for the munder, munderover, and mover elements.
Tests: mathml/presentation/over.xhtml
mathml/presentation/under.xhtml
mathml/presentation/underover.xhtml
* WebCore.xcodeproj/project.pbxproj:
* mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createRenderer):
* mathml/RenderMathMLUnderOver.cpp: Added.
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
(WebCore::RenderMathMLUnderOver::addChild):
(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::stretchToHeight):
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):
(WebCore::RenderMathMLUnderOver::nonOperatorHeight):
* mathml/RenderMathMLUnderOver.h: Added.
(WebCore::RenderMathMLUnderOver::hasBase):
(WebCore::RenderMathMLUnderOver::):
2010-02-24 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
This CL implements a simple ad-hoc parser for CSS rgb() values.
If it fails, it returns false and the normal lex/yacc parser will
be invoked.
https://bugs.webkit.org/show_bug.cgi?id=35362
Covered by fast/canvas/canvas-bg.html, fast/canvas/canvas-bg-zoom.html,
and many more.
* css/CSSParser.cpp:
(WebCore::parseInt):
(WebCore::CSSParser::parseColor):
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=35419
3D canvas did not update when WTF_USE_ACCELERATED_COMPOSITING
was enabled but not from run-time settings. Added run-time
check that compositing is enabled.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Compilation failed because functions glSampleCoverage, glBlendEquation
and glActiveTexture were not available.
https://bugs.webkit.org/show_bug.cgi?id=35423
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::sampleCoverage):
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=35380
Fixed compilation error when WTF_USE_ACCELERATED_COMPOSITING=0
* css/MediaQueryEvaluator.cpp:
(WebCore::transform_3dMediaFeatureEval):
2010-02-26 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Incorrect painting after a size changed.
https://bugs.webkit.org/show_bug.cgi?id=35412
No new tests. Bug fix in backend.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::paint): Provide the source rectangle, rather than inferring it.
2010-02-26 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Incorrect handling of MIME types in Media Player
https://bugs.webkit.org/show_bug.cgi?id=35413
No new tests. Bug fix in backend.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::supportsType): Corrected logic.
2010-02-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35418
[Gtk] Every table, including layout tables, should be exposed as a table
This patch exposes layout tables as tables. (Addressing the problematic table
hierarchy remains to be done.)
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::determineAccessibilityRole):
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XSSAuditor is super super super slow
https://bugs.webkit.org/show_bug.cgi?id=35373
In this patch, we separate the decoding cache for the page's URL and
form data. Previously, we used the same cache for both, which caused
us miss the cache every time when the page had form data (because the
cache only stored one entry). When the form data is large, we were
wasting a lot of time canonicalizing.
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::findInRequest):
* page/XSSAuditor.h:
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
Move SVGResourceClipper to RenderSVGResourceClipper. This follows the changes
of Masker and helps to clean up the SVG code. Code snippets from SVGClipPathElement
and SVGResourceClipper got combined in RenderSVGResourceClipper. DRT results are
more readable for clipPath's now. It's possible to see the unit type of clipper, as
well as it's childs instead of just one path.
* Android.mk:
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderSVGResource.h:
(WebCore::):
* rendering/RenderSVGResourceClipper.cpp: Added.
(WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::invalidateClients):
(WebCore::RenderSVGResourceClipper::invalidateClient):
(WebCore::RenderSVGResourceClipper::applyResource):
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):
* rendering/RenderSVGResourceClipper.h: Added.
(WebCore::RenderSVGResourceClipper::renderName):
(WebCore::RenderSVGResourceClipper::resourceType):
(WebCore::RenderSVGResourceClipper::clipPathUnits):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::clipperBoundingBoxForRenderer):
(WebCore::SVGRenderBase::deregisterFromResources):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
(WebCore::writeStyle):
(WebCore::writeSVGResource):
(WebCore::writeResources):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
(WebCore::SVGClipPathElement::createRenderer):
* svg/SVGClipPathElement.h:
(WebCore::SVGClipPathElement::isValid):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResources):
* svg/graphics/SVGResource.h:
(WebCore::):
(WebCore::SVGResource::isPaintServer):
(WebCore::SVGResource::isFilter):
(WebCore::SVGResource::isMarker):
* svg/graphics/SVGResourceClipper.cpp: Removed.
* svg/graphics/SVGResourceClipper.h: Removed.
2010-02-26 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The element that a touchevent is dispatched to isn't always right
https://bugs.webkit.org/show_bug.cgi?id=35431
The element that touch events are dispatched on is not always the
correct one, as the cached m_touchEventTarget member is only updated
when the first element of the PlatformTouchEvent touch list is in the
TouchPressed state.
This patch changes this behavior to dispatch the event to the target
of the touch that caused the event to be generated and eliminates the
m_touchEventTarget in favour of using the touch target hashmap. It also
simplifies the way in which the touchTargets list is generated as we
no longer have m_touchEventTarget (which was used previously to build
the list). The new behavior matches the observed behavior of the
iPhone and Android.
* page/EventHandler.cpp:
(WebCore::assembleTargetTouches): Added. new function to build the
targetTouches list. Filters a list of touches (passed) about
another given touch.
(WebCore::EventHandler::handleTouchEvent): Remove the
m_touchEventTarget member, and simplify the generation of the
TouchLists that are bundled with the TouchEVent object. Dispatch
the event to the target of the touch that caused the event to be
fired.
* page/EventHandler.h: Remove m_touchEventTarget.
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.
http://bugs.webkit.org/show_bug.cgi?id=35180
Test: fast/loader/about-blank-hash-change.html
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAccessorSetter):
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::texImage2D): Apply flipY and premultiplyAlpha to the texture data.
(WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData): Extract data from ImageData, applying flipY and premultiplyAlpha.
* platform/graphics/GraphicsContext3D.h: Add function extractImageData declaration.
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057
Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport size to match the canvas size.
2010-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touch InspectorController to force front-end deployment.
* inspector/InspectorController.cpp:
2010-02-26 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: While the current timeline view in DevTools provides a great overview of
things happening, we should make it easier to locate the cause of an event,
e.g., link to JS where relevant.
Caller info support for all kind of Timeline events and new Function Call event will be added.
JSC can be patched the same way as it will be done for V8.
https://bugs.webkit.org/show_bug.cgi?id=33995
* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::callLocation):
* bindings/js/ScriptCallStack.h:
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::create):
(WebCore::ScriptCallStack::callLocation):
* bindings/v8/ScriptCallStack.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
* inspector/InspectorTimelineAgent.h:
(WebCore::):
(WebCore::InspectorTimelineAgent::instanceCount):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.hideWhenClicked):
(WebInspector.Popover.prototype._positionElement):
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._formatRecord):
(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelinePanel.prototype.reset):
(WebInspector.TimelinePanel.prototype._closeRecordDetails):
(WebInspector.TimelinePanel.prototype._onScroll):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineRecordListRow):
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordListRow.prototype._createCell):
(WebInspector.TimelineRecordListRow.prototype._createRow):
(WebInspector.TimelineRecordListRow.prototype._createLinkRow):
(WebInspector.TimelineRecordListRow.prototype._generateBubbleContent):
(WebInspector.TimelineRecordListRow.prototype._onClick):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.js:
(WebInspector.linkifyResourceAsNode):
2010-02-26 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed. Roll-out r55263 because it broke fast/forms/textarea-type-spaces-pretty-diff.html.
https://bugs.webkit.org/show_bug.cgi?id=30946
* editing/CompositeEditCommand.cpp:
(WebCore::isWhitespace):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/InsertTextCommand.h:
* editing/htmlediting.cpp:
* editing/htmlediting.h:
2010-02-25 Mark Rowe <mrowe@apple.com>
Reviewed by Brady Eidson.
<rdar://problem/7688455> REGRESSION(r55205): Crash inside dispatchEventsOnWindowAndFocusedNode when clicking link from bookmarks view
Null-check the document's page to avoid dereferencing a null page.
No regression test is added as this appears to be dependent on an interaction with Safari's bookmarks view that is
not testable from within DumpRenderTree.
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Multiple repaints on apple.com
https://bugs.webkit.org/show_bug.cgi?id=35409
apple.com was triggering the fast scaling path for background images due to
repeated repaints as more content came in. This occured due to a two problems
in the logic to detect scaling. The first is that the main context is flipped
on mac so fails the identity or translation check. We work around this by adding
an function that allows the scaling for a flipped CTM. The other problem was that
we were looking at the destination rect size instead of the destination tile size
when deciding if the size we were drawn at would cause scaling.
* platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::isIdentityOrTranslationOrFlipped):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
2010-02-25 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand).
https://bugs.webkit.org/show_bug.cgi?id=30946
<rdar://problem/7639184>
Do text insertion and whitespace rebalancing around the insertion in one step so that there's only one layout.
This patch was originally made by Justin Garcia.
Test: editing/inserting/rebalance-whitespace-1.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): No behavior changes here,
just pushed the code that determined the extent of whitespace surrounding a position
to its own helper function.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTextIntoNodeAndRebalanceWhitespace): Added. Find
whitespace surrounding the insertion position, add the text to insert, rebalance that entire
string, then insert it into the document.
(WebCore::InsertTextCommand::input):
* editing/InsertTextCommand.h:
* editing/htmlediting.cpp:
(WebCore::isWhitespace): Moved from CompositeEditCommand.cpp.
(WebCore::extentOfWhitespaceForRebalancingAt): Moved code from rebalanceWhitespaceAt into this helper
function. Obtains the offset of the start and end of whitespace around a particular position.
* editing/htmlediting.h:
2010-02-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35406
<rdar://problem/6945502> Make generic array methods work with JavaArray
Test: java/array-sort.html
Made RuntimeArray inherit from JSArray, keeping the promise given in ClassInfo.
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::~RuntimeArray):
* bridge/runtime_array.h:
(JSC::RuntimeArray::classInfo):
(JSC::RuntimeArray::getConcreteArray):
2010-02-25 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
Fixed a regression introduced in r44243, which made the assertion in checkListItems()
ineffective.
* dom/SelectElement.cpp:
(WebCore::SelectElementData::checkListItems): Copy the items vector before recomputing it,
then assert that the newly-computed vector is equal to the copy.
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
This makes the base class RenderSVGInline of RenderSVGTSpan and RenderSVGInlineText
dependent on SVGBaseRenderer.
The SVG spec want as to use the object bounding box of the text root as the bounding box
for text-childs. So we search for the text root and use it's bounding box, stroke rect and
repaint rect for further calculations.
Test: svg/filters/filter-on-tspan.svg
* rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::objectBoundingBox): Find the text root and give back it's bounding box.
(WebCore::RenderSVGInline::strokeBoundingBox): same for stroke rect
(WebCore::RenderSVGInline::repaintRectInLocalCoordinates): same for repaint rect
* rendering/RenderSVGInline.h:
(WebCore::RenderSVGInline::toSVGRenderBase): RenderSVGInline is part of SVGRenderBase now.
* rendering/RenderSVGTSpan.h:
(WebCore::RenderSVGTSpan::renderName): Removed bounding box code. Was just a hack for filters and maskers.
* rendering/SVGRenderSupport.cpp:
(WebCore::findTextRootObject): Search for the text root.
* rendering/SVGRenderSupport.h:
* svg/graphics/SVGPaintServerGradient.cpp: moved findTextRootObject to SVGRenderSupport
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
If the use element is a child of clipPath, any settings on x, y or transform does not
transform the clipPath it references.
The use-element just misses this transformation in toClipPath.
Test: svg/custom/use-on-clip-path-with-transformation.svg
* platform/graphics/cairo/PathCairo.cpp: Gtk port translated the path to the wrong direction.
(WebCore::Path::translate):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::toClipPath):
2010-02-25 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
File.type support.
https://bugs.webkit.org/show_bug.cgi?id=35361
Test: LayoutTests/editing/pasteboard/file-input-files-access.html
* html/File.cpp:
(WebCore::File::File):
* html/File.h:
(WebCore::File::type):
* html/File.idl:
2010-02-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Javascript console should not attempt to scroll to end of console if console is not visible
https://bugs.webkit.org/show_bug.cgi?id=22992
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
(WebInspector.ConsoleView.prototype.addMessage):
2010-02-25 Alexey Proskuryakov <ap@apple.com>
Qt and Gtk build fixes.
* GNUmakefile.am:
* WebCore.pro:
Added CRuntimeObject.{c,cpp}.
2010-02-25 Alexey Proskuryakov <ap@apple.com>
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Added CRuntimeObject.{c,cpp}.
2010-02-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35394
<rdar://problem/7685262> Make passing objects between Java and plug-ins work
* WebCore.PluginHostProcess.exp: WebKit now subclasses RuntimeObject, so it needed more exports.
* bridge/runtime_object.cpp:
(JSC::Bindings::callRuntimeObject):
(JSC::Bindings::callRuntimeConstructor):
Assert that a runtime object is passed as function.
* bridge/runtime_object.h: Moved RuntimeObject into Bindings namespace, matching other
related classes.
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::toString): Pass rootObject to convertValueToJValue(). It's not needed when
constructing a string, but this function now takes it for the sake of Object.
(JavaJSObject::convertValueToJObject): Check that object class is JavaRuntimeObject, not
just RuntimeObject.
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::setValueToInstance): Pass rootObject to convertValueToJValue().
(JavaArray::setValueAt): Ditto.
* bridge/jni/jsc/JNIUtilityPrivate.h: convertValueToJValue() now takes a RootObject argument,
because one is needed to gcProtect an object ghtat is wrapped into JSObject.
* bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Convert
JavaScript objects to Java JSObject ones. This was already happening in other code paths,
which we should change to use common code.
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::newRuntimeObject): Create an appropriate RuntimeObject subclass,
which is JavaRuntimeObject for Java.
(JavaInstance::invokeMethod): Unwrap returned JavaObjects that contain JS objects.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/c/CRuntimeObject.cpp: Added.
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::~CRuntimeObject):
(JSC::Bindings::CRuntimeObject::getInternalCInstance):
* bridge/c/CRuntimeObject.h: Added.
(JSC::Bindings::CRuntimeObject::classInfo):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::newRuntimeObject):
* bridge/c/c_instance.h:
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
* bridge/jni/jsc/JavaInstanceJSC.h:
* bridge/jni/jsc/JavaRuntimeObject.cpp: Added.
(JSC::Bindings::):
(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
(JSC::Bindings::JavaRuntimeObject::~JavaRuntimeObject):
(JSC::Bindings::JavaRuntimeObject::getInternalJavaInstance):
* bridge/jni/jsc/JavaRuntimeObject.h: Added.
(JSC::Bindings::JavaRuntimeObject::classInfo):
* bridge/jsc/BridgeJSC.h:
* bridge/objc/ObjCRuntimeObject.h: Added.
(JSC::Bindings::ObjCRuntimeObject::classInfo):
* bridge/objc/ObjCRuntimeObject.mm: Added.
(JSC::Bindings::):
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::~ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::getInternalObjCInstance):
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
(ObjcInstance::newRuntimeObject):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
* bridge/runtime_root.h:
Added RuntimeObject subclasses for each instance type, and use them for type casting.
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Adopt the same string as the one that is expected by
fast/parser/fragment-parser.html for the description used by the
<isindex> element.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::searchableIndexIntroduction):
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: evaluate-on-hover does not work on HTML files.
https://bugs.webkit.org/show_bug.cgi?id=35378
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer):
(WebInspector.SourceHTMLTokenizer.prototype.set line):
(WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute):
(WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue):
(WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute):
(WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue):
(WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType):
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer.prototype.set condition):
(WebInspector.SourceTokenizer.prototype.get condition):
(WebInspector.SourceTokenizer.prototype.get subTokenizer):
(WebInspector.SourceTokenizer.prototype.getLexCondition):
(WebInspector.SourceTokenizer.prototype.setLexCondition):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.set mimeType):
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
(WebInspector.TextEditorHighlighter.prototype._highlightLine):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._paintLine):
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Simple style cleanups.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::plugRemovedCallback):
(WebCore::plugAddedCallback):
(WebCore::PluginView::platformStart):
2010-02-25 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Optimize decoding of Latin-1 text by exploiting the fact that most of it will
be ASCII-only data.
https://bugs.webkit.org/show_bug.cgi?id=35233
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode):
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: make script lines count calculation lazy.
https://bugs.webkit.org/show_bug.cgi?id=35392
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.get linesCount):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype._addBreakpoint):
2010-02-25 James Choi <jchoi42@pha.jhu.edu>
Reviewed by David Levin.
Change hardcoded gcc paths to be Solaris friendly
https://bugs.webkit.org/show_bug.cgi?id=35213
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/IDLParser.pm:
* css/make-css-file-arrays.pl:
* dom/make_names.pl:
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Workaround Java plugins not drawing themselves properly on first
expose by doing a late size-allocate after 'plug-added' has been
emitted on the embedding GtkSocket. It's unclear to me if this is
a bug in our side or theirs, but this should be pretty safe and
fixes the annoyance while we investigate it further.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::plugAddedCallback):
(WebCore::PluginView::platformStart):
2010-02-23 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
Add missing include guards
* loader/CrossOriginPreflightResultCache.h:
* loader/MainResourceLoader.h:
2010-02-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Restrict the optimization flags for Symbian to release builds.
* WebCore.pro:
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds GraphicsContext3D QtWebKit implementation.
https://bugs.webkit.org/show_bug.cgi?id=35153
* WebCore.pri:
* WebCore.pro:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp: Added.
(WebCore::GraphicsContext3DInternal::isValid):
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::getProcAddress):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::beginPaint):
(WebCore::GraphicsContext3D::endPaint):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::sizeInBytes):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getImageData):
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Swap images for activate and deactivate breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=35383
* WebCore.gypi:
* inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png.
* inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Go back on symlink resolution if we are loading the flash plugin,
and the path contains /netscape/, following what Chromium does.
Thanks to Evan Martin for the help on this!
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::load):
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Scripts panel shows blank source when stopping on a breakpoint on refresh.
https://bugs.webkit.org/show_bug.cgi?id=35232
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.canShowSourceLine):
(WebInspector.Panel.prototype.showSourceLine):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
(WebInspector.ResourcesPanel.prototype.showSourceLine):
* inspector/front-end/Script.js:
(WebInspector.Script):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype.get searchableViews):
(WebInspector.ScriptsPanel.prototype.addScript):
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype.addBreakpoint):
(WebInspector.ScriptsPanel.prototype.removeBreakpoint):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype.canShowSourceLine):
(WebInspector.ScriptsPanel.prototype.showSourceLine):
(WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
(WebInspector.ScriptsPanel.prototype.showView):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
(WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare):
(WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype._addBreakpoint):
* inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector._choosePanelToShowSourceLine):
(WebInspector.canShowSourceLine):
(WebInspector.showSourceLine):
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
Currently the target of a touch is set to the resulting node of the hit test where the touch currently
is. This does not match the behavior of iPhone or Android. This patch uses a hashmap on the EventHandler
to keep track of the target element when a touch is first started. This target is then used as the target
for subsequent touches with the same id. This matches observed behavior on iPhone and Android.
Tests:
fast/events/touch/touch-target.html: Added.
fast/events/touch/basic-single-touch-events.html: Updated.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Store the originating target element of a touch in a hashmap
so that we can reuse that target for future events caused by that touch. This matches observed behavior
on iPhone and Android.
* page/EventHandler.h: Add hashmap as a member.
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::id): Store the touch point id as unsigned.
* platform/qt/PlatformTouchPointQt.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint): Cast platform touch id from signed to unsigned. Qt API
docs state that it will always be >= 0.
2010-02-24 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Add a convenient center() method to IntRect
https://bugs.webkit.org/show_bug.cgi?id=35346
As it is a convenience method, and implemention is
based on FloatRect's one, patch does not provide a
layout test.
* platform/graphics/IntRect.h:
(WebCore::IntRect::center):
2010-02-25 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Fake workers implementation that simulates workers using iframe and timer,
needed to support workers debugging. Also, a facility to inject scripts into
inspected page upon load.
https://bugs.webkit.org/show_bug.cgi?id=35148
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::addScriptToEvaluateOnLoad):
(WebCore::InspectorBackend::removeAllScriptsToEvaluateOnLoad):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::addScriptToEvaluateOnLoad):
(WebCore::InspectorController::removeAllScriptsToEvaluateOnLoad):
* inspector/InspectorController.h:
* inspector/front-end/InjectedFakeWorker.js: Added.
(InjectedFakeWorker.Worker):
(InjectedFakeWorker.FakeWorker):
(InjectedFakeWorker.FakeWorker.prototype.postMessage):
(InjectedFakeWorker.FakeWorker.prototype.terminate):
(InjectedFakeWorker.FakeWorker.prototype._onmessageWrapper):
(InjectedFakeWorker.FakeWorker.prototype._dispatchMessage):
(InjectedFakeWorker.FakeWorker.prototype._handleException):
(InjectedFakeWorker.FakeWorker.prototype._buildWorker):
(InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.handler):
(InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext):
(InjectedFakeWorker.FakeWorker.prototype._importScripts):
(InjectedFakeWorker.FakeWorker.prototype._loadScript):
(InjectedFakeWorker.URL):
(InjectedFakeWorker.URL.prototype.urlRegEx.split):
(InjectedFakeWorker.URL.prototype.mockLocation):
(InjectedFakeWorker.URL.prototype.completeWith):
(InjectedFakeWorker.URL.prototype.sameOrigin):
(InjectedFakeWorker.DOMCoreException.formatError):
(InjectedFakeWorker.DOMCoreException):
(InjectedFakeWorker.noop):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
(.WebInspector.InspectorBackendStub.prototype.addScriptToEvaluateOnLoad):
(.WebInspector.InspectorBackendStub.prototype.removeAllScriptsToEvaluateOnLoad):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2010-02-24 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Add mediaPlayerOwningDocument() to MediaPlayerClient.
https://bugs.webkit.org/show_bug.cgi?id=35374
No new tests. These are interface changes only.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Implementation for media element.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerOwningDocument): New virtual method.
2010-02-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Optimized Font::normalizeSpaces() by caching the String::characters()
instead of repeatedly calling operator[]
https://bugs.webkit.org/show_bug.cgi?id=35336
* platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces):
2010-02-24 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin.
[Chromium] Traditional Chinese Chrome on Windows should use PMingLiu instead of Simsun for Han characters
https://bugs.webkit.org/show_bug.cgi?id=35319
No visible change in the layout test.
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::):
2010-02-24 Anthony Ricaud <rik@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Reduce the timer to show the eval popover
https://bugs.webkit.org/show_bug.cgi?id=35344
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._mouseMove):
2010-02-24 Jay Campan <jcampan@google.com>
Reviewed by David Levin.
Don't show the autofill popup when the input text is disabled or read only.
Test: manual-tests/chromium/no-autofill-on-readonly.html
https://bugs.webkit.org/show_bug.cgi?id=35129
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::autofill):
* manual-tests/chromium/no-autofill-on-readonly.html: Added.
2010-02-24 Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed by Jeremy Orlow.
Wraps includes of SVG headers so that it's possible to
compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.
https://bugs.webkit.org/show_bug.cgi?id=35345
No new tests.
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/custom/V8CSSValueCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8SVGElementCustom.cpp:
2010-02-24 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Fix gtk build.
Include JSC headers as runtime/ instead of JavaScriptCore/
* bindings/js/JSDOMWrapper.h:
* bindings/js/ScriptWrappable.h:
2010-02-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
7.4% speedup on Dromaeo DOM Core tests.
2.3% speedup on Hixie DOM Core tests.
This fixes the following things from the last attempt:
- Now builds in both debug and release and passes all tests
- Properly use a WeakGCPtr, not just a raw pointer, in ScriptWrappable
- Properly look in the appropriate per-document or per-world map
- Added an assert that would have caught any of the problems I found
- Handle clearing the inline cache properly in all cases
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMObjectWrapper): Adjust for name changes.
(WebCore::forgetDOMNode): Clear wrapper pointer.
(WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
* bindings/js/JSDOMBinding.h:
(WebCore::Document::getWrapperCache): Inlined.
(WebCore::domObjectWrapperMapFor): Renamed to start with lowercase. Moved to header to inline.
* bindings/js/JSDOMWrapper.h: Added.
(WebCore::DOMObject::DOMObject): Factored this out of JSDOMBinding.h to avoid include
cycle. I think the class should be renamed, I picked a forward-looking header name because
we already have a DOMObject.h
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline): Renamed version of original createWrapper.
(WebCore::createWrapper): Call createWrapperInline. Out-of-line version.
(WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
* bindings/js/JSNodeCustom.h: Added.
(WebCore::getCachedDOMNodeWrapper): Moved from JSDOMBinding.cpp and moved here,
so it could inline everywhere without creating an include cycle. Consider inline
cache.
(WebCore::toJS): Moved to header to inline.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious
way for JavaScriptCore. (Using a WeakGCPtr).
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
* bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders
in the header, not just the impl file, so they can add inlining.
* dom/Node.idl: Add CustomHeader directive.
Add new files to build.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
2010-02-24 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Expose Database object of currently active task on the database thread
https://bugs.webkit.org/show_bug.cgi?id=35341
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::databaseThread):
* storage/DatabaseThread.h:
(WebCore::DatabaseThread::getDatabaseOfCurrentTask):
2010-02-24 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
supportsMuting() should be an internal interface between MediaPlayer and MediaPlayerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=35327
No new tests. Refactoring Only.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMuted): Do not check supportsMuting()
(WebCore::HTMLMediaElement::updateVolume): Set volume and muted
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setVolume): Check supportsMuting()
(WebCore::MediaPlayer::setMuted): Check supportsMuting()
* platform/graphics/MediaPlayer.h: Remove supportsMuting()
2010-02-24 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[Chromium API] Disambiguate allowJavaScript from didNotAllowScript
https://bugs.webkit.org/show_bug.cgi?id=35205
For clients that want to show a user interface element when JavaScript
was blocked on a page, we need to disambiguate between querying the
client for whether JavaScript is enabled from actually failing to
execute some script.
This patch adds a new FrameLoaderClient callback for when WebCore would
like to execute JavaScript but fails to because JavaScript is disabled.
This patch also touches every client of canExecuteScripts so they can
indicate whether we should make this callback. I was hoping there was
a better choke point, but my first two attempts were wrong in subtle
ways. pkasting points out that this will be easy to screw up in the
future, so it's better to make all the clients be explicit.
* WebCore.PluginHostProcess.exp:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
(WebCore::ScriptController::executeScriptInWorld):
* bindings/js/ScriptController.h:
(WebCore::):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setJavaScriptPaused):
* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
* bindings/v8/ScriptController.h:
(WebCore::):
* bindings/v8/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieve):
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::evaluateScript):
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::startElementNs):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controls):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::processToken):
* inspector/InspectorController.cpp:
(WebCore::canPassNodeToJavaScript):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::isProcessingUserGesture):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didNotAllowScript):
2010-02-24 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
https://bugs.webkit.org/show_bug.cgi?id=34997
If we want to let the FrameLoaderClient override arePluginsEnabled,
then we need to call out to the FrameLoaderClient every time we read
the setting.
We don't have testing infrustructure for these changes, which is lame.
I'm supposed to fix that in Bug 33991.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
* page/Page.cpp:
(WebCore::Page::pluginData):
* plugins/MimeType.cpp:
(WebCore::MimeType::enabledPlugin):
2010-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Dmitry Titov.
Do not fire focus events while a modal dialog is up.
https://bugs.webkit.org/show_bug.cgi?id=33962
Modifies the FocusController to check the frame's page's defersLoading() flag before firing blur/focus events.
This flag is set while a modal dialog (like a window.alert or window.confirm) is up. Firing the events causes
assertion failures, since when the dialog is dismissed the PageGroupLoadDeferrer assumes that no script has run.
Manual tests only as DumpRenderTree does not support modal dialogs
* manual-tests/modal-dialog-blur-selfclose.html: Added.
* manual-tests/modal-dialog-blur.html: Added.
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
2010-02-24 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/7018611> innerHTML applies meta/link/title tags from a detached html element
Test: fast/parser/fragment-parser.html
Ensure that fragment parsing has no side effects on the fragment’s owner
document.
* html/HTMLParser.cpp:
(WebCore::HTMLParser::insertNode): Don’t call
dispatchDocumentElementAvailable() for fragments.
(WebCore::HTMLParser::handleError): Don’t copy attributes to the owner
document’s <html> and <body> elements when a redundant <html> or <body>
is encountered while parsing a fragment.
(WebCore::HTMLParser::framesetCreateErrorCheck): Don’t change the owner
document’s <body> element’s style when parsing a fragment.
(WebCore::HTMLParser::createHead): Don’t attach the new <head> to the
ownder document of a fragment.
2010-02-24 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Need to create a CanvasSurface base class for HTMLCanvasElement.
https://bugs.webkit.org/show_bug.cgi?id=35322
This is an initial step in making the OffscreenCanvas object.
No new functionality so no new tests.
* GNUmakefile.am: Added CanvasSurface to the build.
* WebCore.gypi: ditto
* WebCore.pro: ditto
* WebCore.vcproj/WebCore.vcproj: ditto
* WebCore.xcodeproj/project.pbxproj: ditto
* dom/CanvasSurface.cpp: Added.
* dom/CanvasSurface.h: Added.
* html/HTMLCanvasElement.h: Made HTMLCanvasElement inherit from CanvasSurface.
2010-02-24 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
2010-02-24 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7682827> Text with :first-letter lingers after being removed
Test: fast/css/first-letter-set-text.html
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setTextInternal): Set this back as the
text node’s renderer, as removing the first letter has resets the node’s
renderer.
2010-02-24 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle fill without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35337
* platform/graphics/qt/GraphicsContextQt.cpp:
2010-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Corrects build break of QtLauncher on Windows.
The VERSION variable was not set anymore while building in trunk.
* WebCore.pro:
2010-02-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar.
Fix style and add the new images to the related file sets.
https://bugs.webkit.org/show_bug.cgi?id=35307
* WebCore.gypi:
* inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png:
* inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Get rid of an extra call to
setNPWindowIfNeeded. updatePluginWidget already calls this for us
if needed.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformStart):
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Try to sanitize a bit the geometry management of plugins.
Stop doing contradictory things in updatePluginWidget (we were at
the same time pretending the geometry setting was delayed until
::paint and setting the geometry not once but twice) and just set
it any time the windowRect or clipRect for the plugin has changed.
This is closer to what the Mac port does, and fixes instances of
the plugins not being drawn until the window is resized or
scrolled. Other than that all manual and layout tests seems to
still work.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::setNPWindowIfNeeded):
2010-02-23 Geoff Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Simplify animation lifetime handling. Previously we manually
determined whether our base element was safe when we unregistered
our listener, now we simply ensure that the base element itself
registers and unregisters the animation listener.
* svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::create):
(WebCore::ConditionEventListener::disconnectAnimation):
(WebCore::ConditionEventListener::ConditionEventListener):
(WebCore::ConditionEventListener::operator==):
(WebCore::ConditionEventListener::handleEvent):
(WebCore::SVGSMILElement::eventBaseFor):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
* svg/animation/SVGSMILElement.h:
2010-02-23 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
Chromium: Use V8::TerminateExecution to actually terminate workers.
https://bugs.webkit.org/show_bug.cgi?id=35137
Test: existing fast/workers/stress-js-execution.html which is currently failing
on Mac and Linux bots for Chromium.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
2010-02-23 Enrica Casucci <enrica@apple.com>
Reviewed by Simon Fraser.
REGRESSION: WebKit crashes when deleting images on blogger.com (34957)
<rdar://problem/7651935>
https://bugs.webkit.org/show_bug.cgi?id=34957
Fixing a regression introduced with revision 53085. Anchor elements should not be considered
in editable content when calculating the position in the parent before the node.
Test: editing/execCommand/delete-image-in-anchor.html
* dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):
2010-02-23 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher and Pavel Feldman.
Regression (r55107) - WebInspector docking is busted.
https://bugs.webkit.org/show_bug.cgi?id=35274
* inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Use the minimum height for this calculation,
not the preferred height.
(WebCore::InspectorController::attachWindow): attachWindow() shouldn't decide the policy, as it is
often called partway through the show or dock procedure after some of the initial conditions have
changed. Let the front-end itself and the InspectorClient's make the policy decision at the start
of the show/dock operation.
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canAttachWindow):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/inspector.js:
(WebInspector.toggleAttach): Before attaching, ask the front-end-host if attaching is allowed.
2010-02-23 Mark Rowe <mrowe@apple.com>
Reviewed by Geoff Garen.
<http://webkit.org/b/35287> ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading
CGImageSourceGetStatusAtIndex claims that all frames of a multi-frame image are incomplete when we've not yet received the
complete data for an image that is using an incremental data source (<rdar://problem/7679174>). We work around this by
special-casing all frames except the last in an image and treating them as complete if they are present and reported as
being incomplete. We do this on the assumption that loading new data can only modify the existing last frame or append new
frames. The last frame is only treated as being complete if the image source reports it as such. This ensures that it is
truly the last frame of the image rather than just the last that we currently have data for.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
2010-02-23 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
createFragmentFromMarkup did not handle correctly the case where documentElement is
not an HTMLElement. The static cast to HTMLElement was causing createContextualFragment to
crash.
Test: editing/execCommand/insert-list-xml.xhtml
* dom/Element.cpp:
(WebCore::Element::createContextualFragment): Added.
* dom/Element.h: Added createContextualFragment virtual function.
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup): Removed static cast to HTMLElement.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment): Modified to perform only checks
that are specific for an HTMLElement object. The rest of the logic has been moved to the
corresponding method in the Element class.
2010-02-23 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebCore should stop throwing away the CGImageSourceRef on Windows to improve GIF performance
https://bugs.webkit.org/show_bug.cgi?id=35309
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Changes references of GOwnPtr to reflect their new place.
http://webkit.org/b/35084
* WebCore/platform/KURL.cpp
* WebCore/platform/TextEncoding.cpp:
* WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:
* WebCore/platform/text/gtk/TextCodecGtk.cpp:
2010-02-23 Brady Eidson <beidson@apple.com>
Reviewed by Alexey Proskuryakov.
HTTP 307 after a 303 after a POST re-sends POST data from the original request.
<rdar://problem/7390251> and https://bugs.webkit.org/show_bug.cgi?id=31410
Test: http/tests/loading/307-after-303-after-post.html
Remember the last HTTP method send out during a redirect chain for a resource handle:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::lastHTTPMethod):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Refer to the last HTTP method used instead of the original method:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::ResourceHandle::willSendRequest):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
2010-02-23 Crystal Zhang <haizhang@rim.com>
Unreviewed build fix.
Fix build error when enable plugin proxy: 'toRenderEmbeddedObject' identifier not found.
As RenderEmbeddedObject inherits RenderPartObject and 'toRenderEmbeddedObject' belongs
to former one.
* html/HTMLMediaElement.cpp:
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] fix previous SVG-disabling patch
https://bugs.webkit.org/show_bug.cgi?id=35298
* WebCore.gypi: rename variable
* WebCore.gyp/WebCore.gyp: actually use the variable
2010-02-23 Michael Lotz <mmlr@mlotz.ch>
Reviewed by David Levin.
[Haiku] Fix conversion from BString to String
https://bugs.webkit.org/show_bug.cgi?id=35082
The previous patch to this file was broken (sorry). First of all,
the conversion from UTF8 was accidentally removed. Second, for
empty strings, we need to point the implementation at StringImpl::empty().
Covered by existing tests.
* platform/text/haiku/StringHaiku.cpp:
(WebCore::String::String):
2010-02-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Carlson.
[Qt] Prevent the media backend from handling non-audio or -video mime types
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] Allow building without SVG
https://bugs.webkit.org/show_bug.cgi?id=31522
* WebCore.gyp/WebCore.gyp, WebCore.gypi: test enable_svg flag.
* bindings/v8/custom/V8SVGDocumentCustom.cpp,
bindings/v8/custom/V8SVGPathSegCustom.cpp: test ENABLE(SVG).
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
again.
http://webkit.org/b/35084
* WebCore/platform/gtk/DataObjectGtk.h:
* WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2010-02-23 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle drawing without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35267
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawRect):
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
No new tests, removing dead code only.
* page/Settings.cpp:
* page/Settings.h:
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
The co-ordinates attached to a touch event are not used for tracking touch motion, rather the co-ordinates attached to Touches within the touch event should be used. Set the co-ordinates on the event itself to 0 to avoid confusion and match observed iPhone behavior.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Set the pageX/Y and screenX/Y co-ordinates attached to the touch event to 0,0 to match observed behavior on the iPhone.
* page/EventHandler.h: Remove now unused members m_firstTouchScreenPos and m_firstTouchPagePos.
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Various improvements to EventHandlerHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fix the build by not including PlatformScrollBar.h.
* page/haiku/EventHandlerHaiku.cpp:
(WebCore::isKeyboardOptionTab):
Use the correct keycode for tab keys.
(WebCore::EventHandler::focusDocumentView):
Use proper locking. In any case, Haiku doesn't append platform
widgets to WebCore widgets. But if it did, this implementation
would be correct.
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
Implemented.
(WebCore::EventHandler::eventActivatedView):
Removed notImplemented() and added note.
(WebCore::EventHandler::passMousePressEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseMoveEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Implemented.
(WebCore::EventHandler::accessKeyModifiers):
Added note.
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):
2010-02-17 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds cache to store Geolocation positions between browser sessions.
https://bugs.webkit.org/show_bug.cgi?id=34084
This is required to fully implement the Geolocation maximumAge property.
See Bug 30676.
No new tests, will add tests for maximumAge once complete.
* Android.mk: Modified. Added GeolocationPositionCache.cpp
* GNUmakefile.am: Modified. Added GeolocationPositionCache.[cpp|h]
* WebCore.gypi: Modified. Added GeolocationPositionCache.[cpp|h]
* WebCore.pro: Modified. Added GeolocationPositionCache.[cpp|h]
* WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationPositionCache.[cpp|h]
* WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationPositionCache.[cpp|h]
* page/GeolocationPositionCache.cpp: Added.
(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::~GeolocationPositionCache):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::readFromDB):
(WebCore::GeolocationPositionCache::writeToDB):
* page/GeolocationPositionCache.h: Added.
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
Test: fast/inline-block/inline-block-vertical-align-2.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::verticalPosition): Fixed vpos calculation.
We cannot cut corners for inline blocks, since they may have their own
text metrics.
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
No new tests, modifies a Chromium feature only.
* bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
* storage/Database.cpp: Modified. Sets database flag default to 'on'.
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Fix various issues in keyboard event generation.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed backspace keycode.
Fixed using the appropriate fields from the Haiku event for mapping
to the VK_* codes and added mapping a great deal more codes.
Added extraction of modifier key flags.
Completed implementation of disambiguateKeyDownEvent()
Implemented currentCapsLockState().
* platform/haiku/PlatformKeyboardEventHaiku.cpp:
(WebCore::keyIdentifierForHaikuKeyCode):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Adds Client::cancelGeolocationPermissionRequestForFrame and ChromeClient::cancelGeolocationPermissionRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=34962
These methods are required so that a Geolocation object can cancel an
asynchronous permission request. This allows the chrome client to cancel
any UI it is showing for the permission request.
No new tests, as this is for the purposes of browser UI only.
* loader/EmptyClients.h: Modified
(WebCore::EmptyChromeClient::cancelGeolocationPermissionRequestForFrame): Added
* page/Chrome.cpp: Modified.
(WebCore::Chrome::cancelGeolocationPermissionRequestForFrame): Added
* page/Chrome.h: Modified.
* page/ChromeClient.h: Modified.
(WebCore::ChromeClient::cancelGeolocationPermissionRequestForFrame): Added
* page/Geolocation.cpp: Modified.
(WebCore::Geolocation::disconnectFrame): Modified. Call cancelGeolocationPermissionRequestForFrame
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):
2010-02-23 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Correct build problems while building QtWebKit inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=34975
* WebCore.pro: Change the condition !standalone_package to !QTDIR_build
2010-02-23 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Connect video with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=35276
MediaControlPrivate and GraphicsLayer are patched together via
a shared PlatformLayer (QGraphicsItem). This patch makes sure that the
QGraphicsVideoItem from MediaControl becomes part of the scene
associsated with GraphicsLayer
Test: http://double.co.nz/video_test/test1.html with AC turned on
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::): mediaLayer member
(WebCore::GraphicsLayerQtImpl::opaqueArea): video is opaque
(WebCore::GraphicsLayerQtImpl::paint): don't paint video
(WebCore::GraphicsLayerQtImpl::flushChanges): flush mediaLayer
(WebCore::GraphicsLayerQt::setContentsToMedia): notify
* platform/graphics/qt/GraphicsLayerQt.h: reimp setContentsToMedia
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate): m_compositing
(WebCore::MediaPlayerPrivate::paint): don't paint if compositing
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
reimp from MediaPlayerPrivateInterface to support AC
(WebCore::MediaPlayerPrivate::platformLayer): ditto
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): ditto
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformWheelEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed coding style violations.
Synced extracting the correct coordinates with Haiku WebKit implementation.
Added extracting modifier key flags.
* platform/haiku/PlatformWheelEventHaiku.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2010-02-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
Build fix for PluginView
https://bugs.webkit.org/show_bug.cgi?id=35230
No new tests, build fix only.
* plugins/PluginView.cpp:
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
2010-02-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port ScriptController::createScriptInstanceForWidget
https://bugs.webkit.org/show_bug.cgi?id=34413
* bindings/js/ScriptControllerBrew.cpp: Added.
(WebCore::ScriptController::createScriptInstanceForWidget):
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Webkit crashes when using orca
https://bugs.webkit.org/show_bug.cgi?id=35169
Made webkit_accessible_text_get_caret_offset check if end selection
node is null.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset):
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implemented PopupMenu support.
https://bugs.webkit.org/show_bug.cgi?id=35078
Covered by existing tests.
The implementation is currently very simple: Added a PopupMenuHaiku
class that derives from a native BPopUpMenu. It attaches a BHandler
derivative to the BApplication (WebCore main thread) which receives
the item invokation and menu hidden events and informs the PopupMenuClient
accordingly.
* platform/PopupMenu.h:
Changed type of m_menu for Haiku.
* platform/haiku/PopupMenuHaiku.cpp:
(WebCore::PopupMenuHandler::PopupMenuHandler):
(WebCore::PopupMenuHandler::MessageReceived):
(WebCore::PopupMenuHaiku::PopupMenuHaiku):
(WebCore::PopupMenuHaiku::~PopupMenuHaiku):
(WebCore::PopupMenuHaiku::show):
(WebCore::PopupMenuHaiku::hide):
(WebCore::PopupMenuHaiku::Hide):
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
Removed bogus code.
(WebCore::PopupMenu::show):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::hide):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::updateFromElement):
Implemented.
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
Implemented according to Gtk port.
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformMouseEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Mapping Haiku button constants (bit field) to WebCore buttons was broken.
Extracting event time was broken (supposed to be in seconds).
Wrong coordinate was being extracted, needs to be content local.
Added extracting modifier key flags.
* platform/haiku/PlatformMouseEventHaiku.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implement creating and filling platform gradients.
https://bugs.webkit.org/show_bug.cgi?id=34683
Covered by existing tests.
* platform/graphics/Gradient.h:
Typedef PlatformGradient to BGradient
* platform/graphics/haiku/GradientHaiku.cpp:
(WebCore::Gradient::platformDestroy):
Delete the cached BGradient object.
(WebCore::Gradient::platformGradient):
Create a BGradient object according to the type of Gradient.
Return the cached object.
(WebCore::Gradient::fill):
use BView API to fill with the platform gradient.
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Build fix for debug builds of GlyphPageTreeNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=34528
Covered by existing tests.
* platform/graphics/GlyphPageTreeNode.cpp:
include <stdio.h> since printf() is used if NDEBUG is not defined.
2010-02-22 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium build fix.
Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.
CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
that a custom named getter was needed. That hint was removed in
http://trac.webkit.org/changeset/55104.
* bindings/scripts/CodeGeneratorV8.pm:
2010-02-22 Alexey Proskuryakov <ap@apple.com>
Rubber-stamped by Geoff Garen.
Rename RuntimeObjectImp to RuntimeObject.
* WebCore.PluginHostProcess.exp:
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::getRuntimeObject):
(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
(WebCore::runtimeObjectCustomPut):
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertValueToJValue):
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
(JSC::Bindings::Instance::newRuntimeObject):
* bridge/jsc/BridgeJSC.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::markChildren):
(JSC::Bindings::):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
(JSC::Bindings::QtInstance::getInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):
* bridge/qt/qt_instance.h:
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
(JSC::Bindings::):
(JSC::Bindings::QtPixmapInstance::variantFromObject):
(JSC::Bindings::QtPixmapInstance::createRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::valueRealType):
* bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
* bridge/runtime_object.cpp:
(JSC::RuntimeObject::RuntimeObject):
(JSC::RuntimeObject::~RuntimeObject):
(JSC::RuntimeObject::invalidate):
(JSC::RuntimeObject::fallbackObjectGetter):
(JSC::RuntimeObject::fieldGetter):
(JSC::RuntimeObject::methodGetter):
(JSC::RuntimeObject::getOwnPropertySlot):
(JSC::RuntimeObject::getOwnPropertyDescriptor):
(JSC::RuntimeObject::put):
(JSC::RuntimeObject::deleteProperty):
(JSC::RuntimeObject::defaultValue):
(JSC::callRuntimeObject):
(JSC::RuntimeObject::getCallData):
(JSC::callRuntimeConstructor):
(JSC::RuntimeObject::getConstructData):
(JSC::RuntimeObject::getOwnPropertyNames):
(JSC::RuntimeObject::throwInvalidAccessError):
* bridge/runtime_object.h:
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2010-02-19 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
Avoid recursion when trying to get the size of a PNG; it's unnecessary
and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167
Test: fast/images/bad-png.html
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode):
2010-02-22 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher.
Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
* WebCore.base.exp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()
decision based on if attachment would be allowed or not.
(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.
* inspector/InspectorController.h:
2010-02-22 Alexey Proskuryakov <ap@apple.com>
Build fix.
* WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!
2010-02-22 Alexey Proskuryakov <ap@apple.com>
Undo a small part of the previous commit.
* bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local
variable as RefPtr for safety.
2010-02-22 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35260
Eliminate __apple_runtime_object
No change in functionality, so no tests.
* WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.
* bindings/js/JSHTMLAppletElementCustom.cpp:
* bindings/js/JSHTMLEmbedElementCustom.cpp:
* bindings/js/JSHTMLObjectElementCustom.cpp:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
These objects no longer need overriding name getters, as they no longer intercept the
__apple_runtime_object property.
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in
this file, and now it's also used elsewhere when calling plug-in methods.
(WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting
name getters.
* bindings/js/JSPluginElementFunctions.h: Export pluginInstance().
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
Take plug-in element's instance directly, without relying on fake attribute lookup.
One change resulting from this is that RuntimeObjectImp may not be created in some cases -
this code only needs an instance, but the old code had to pass the instance wrapped into
RuntimeObjectImp.
2010-02-22 John Sullivan <sullivan@apple.com>
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=35256
HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index
No new tests because this code path is not used for JS-initiated changes.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.
2010-02-22 Enrica Casucci <enrica@apple.com>
Reviewed by Dan Bernstein.
Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060
Test: editing/selection/extend-byline-withfloat.html
* editing/visible_units.cpp:
(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.
2010-02-22 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium build fix.
* bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.
2010-02-22 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Streamline V8 event listener code. Merge all the variants of
V8DOMWrapper::getEventListner() into a single version and generate
addEventListener() and removeEventListener() bindings for all objects
except DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=35245
* Android.v8bindings.mk:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getEventListener):
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/custom/V8AbstractWorkerCustom.cpp: Removed.
* bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Removed.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
* bindings/v8/custom/V8EventSourceCustom.cpp: Removed.
* bindings/v8/custom/V8MessagePortCustom.cpp:
* bindings/v8/custom/V8NodeCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Removed.
* bindings/v8/custom/V8WebSocketCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
* dom/MessagePort.idl:
* dom/Node.idl:
* loader/appcache/DOMApplicationCache.idl:
* notifications/Notification.idl:
* page/EventSource.idl:
* svg/SVGElementInstance.idl:
* websockets/WebSocket.idl:
* workers/AbstractWorker.idl:
* workers/WorkerContext.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestUpload.idl:
2010-02-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Test: platform/mac/accessibility/element-focus.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
2010-02-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein, Darin Adler.
Remove addScrolledContentOffset/subtractScrolledContentOffset
https://bugs.webkit.org/show_bug.cgi?id=35225
Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
methods, and instead use the existing scrolledContentOffset(), and use
IntSize and IntPoint instead of lots of x, y variables.
Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
which is needed in a few places.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
* platform/graphics/IntPoint.h:
(WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::size):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
* rendering/TextControlInnerElements.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):
2009-02-22 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
fontconfig on Linux can change the render preferences on a per strike
basis (a strike a combination of face and size). Because of this, we
need to query fontconfig each time a new FontPlatformData is created
for a new size.
This patch adds support for querying this via ChromiumBridge.
https://bugs.webkit.org/show_bug.cgi?id=33065
* platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::setupPaint):
(WebCore::FontPlatformData::queryStyle):
add code to query fontconfig via ChromiumBridge
* platform/graphics/chromium/FontPlatformDataLinux.h:
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix for make distcheck.
* GNUmakefile.am:
2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
* wml/WMLVariables.cpp:
(WebCore::substituteVariableReferences):
2010-02-22 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::fillResponseFromMessage):
* platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::soupMessageFlags):
(WebCore::ResourceRequest::setSoupMessageFlags):
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
(WebCore::ResourceRequest::updateFromSoupMessage):
* platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::soupMessageFlags):
(WebCore::ResourceResponse::setSoupMessageFlags):
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
https://bugs.webkit.org/show_bug.cgi?id=35238
No new tests, build fix only.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::globalObjectPrototypeIsDOMWindow):
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Simon Fraser.
Simplifies calculation of the transform in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=35101
No new tests, optimization only.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
2010-02-22 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=34631
No new tests. This patch only affects multimedia backend.
* WebCore.pro: Build depends on Qt version.
* css/mediaControlsQt.css: Updated media controls.
* platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):
* platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.
* platform/qt/RenderThemeQt.h: Reimplemented a few more methods.
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Not reviewed: mac build fix
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
https://bugs.webkit.org/show_bug.cgi?id=33217
* English.lproj/localizedStrings.js:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::setBreakpointsActivated):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::setBreakpointsActivated):
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::activateBreakpoints):
(WebCore::InspectorBackend::deactivateBreakpoints):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
* inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub.prototype.activateBreakpoints):
(.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get breakpointsActivated):
(WebInspector.ScriptsPanel.prototype.addBreakpoint):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
* inspector/front-end/inspector.css:
* inspector/front-end/textViewer.css:
2010-02-22 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig and Maciej Stachowiak.
REGRESSION (r55039): Animation starts from near end when loaded over slow network
<http://webkit.org/b/35222> / <rdar://problem/7673523>
Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
2010-02-22 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Revert the previous change.
2010-02-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
8.8% speedup on Dromaeo DOM Core tests.
3.3% speedup on Hixie DOM Core tests.
* bindings/js/JSDOMBinding.cpp:
(WebCore::forgetDOMNode): Clear wrapper pointer.
(WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWrapperMapFor):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline): Renamed version of original createWrapper.
(WebCore::createWrapper): Call createWrapperInline. Out-of-line version.
(WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
* bindings/js/JSNodeCustom.h: Added.
(WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined.
(WebCore::toJS): Moved here so it can be inlined.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious
way for JavaScriptCore.
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
* bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders
in the header, not just the impl file, so they can add inlining.
* dom/Node.idl: Add CustomHeader directive.
Add new files to build.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
2010-02-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: windows build fix.
2010-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: stop on inline breakpoints on reload.
- ScriptBreakpoint struct has been introduced and reused in InspectorController
and debug server.
- JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer
There were no changes to semantics, only some mechanical changes:
- addBreakpoint and updateBreakpoint were merged into setBreakpoint
- ScriptDebugServer now operates ScriptBreakpoint instances instead of
BreakpointInfo.
- It no longer allocates maps and breakpoint info in heap - all done on stack.
- JavaScriptDebugListener is now ScriptDebugServer::Listener
- Listener methods no longer have ExecState (was unused).
- addListener/removeListener pair wuth no page argument removed (was unused).
- InspectorController now binds sourceID to url and maintains a map of 'sticky'
breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching,
breakpoint is being 'restored' synchronously in debug server and pushed to frontend.
Front-end no longer stores map of sticky breakpoints.
- setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
- A bunch of if(USE_JSC/V8/other) forks removed.
- InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.
https://bugs.webkit.org/show_bug.cgi?id=28799
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::currentCallFrame):
(WebCore::JSInjectedScriptHost::isActivation):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::shared):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::~ScriptDebugServer):
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::pageCreated):
(WebCore::ScriptDebugServer::hasListenersInterestedInPage):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::pauseProgram):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentCallFrame):
(WebCore::ScriptDebugServer::currentCallFrameState):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::toPage):
(WebCore::ScriptDebugServer::detach):
(WebCore::ScriptDebugServer::sourceParsed):
(WebCore::ScriptDebugServer::dispatchFunctionToListeners):
(WebCore::ScriptDebugServer::setJavaScriptPaused):
(WebCore::ScriptDebugServer::pauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
(WebCore::ScriptDebugServer::recompileAllJSFunctions):
(WebCore::ScriptDebugServer::didAddListener):
(WebCore::ScriptDebugServer::didRemoveListener):
(WebCore::ScriptDebugServer::didRemoveLastListener):
* bindings/js/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::Listener::~Listener):
(WebCore::ScriptDebugServer::):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::hasListeners):
(WebCore::ScriptDebugServer::hasGlobalListeners):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::shared):
* bindings/v8/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::Listener::~Listener):
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::pauseProgram):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
(WebCore::ScriptDebugServer::recompileAllJSFunctions):
(WebCore::ScriptDebugServer::currentCallFrameState):
(WebCore::ScriptDebugServer::pageCreated):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::~ScriptDebugServer):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
(WebCore::V8InjectedScriptHost::isActivationCallback):
* inspector/InjectedScriptHost.cpp:
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::setBreakpoint):
(WebCore::InspectorBackend::removeBreakpoint):
(WebCore::InspectorBackend::pauseInDebugger):
(WebCore::InspectorBackend::stepOverStatementInDebugger):
(WebCore::InspectorBackend::stepIntoStatementInDebugger):
(WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
(WebCore::InspectorBackend::pauseOnExceptionsState):
(WebCore::InspectorBackend::setPauseOnExceptionsState):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/ScriptBreakpoint.h: Added.
(WebCore::InspectorBreakpoint::InspectorBreakpoint):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::close):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::resumeDebugger):
(WebCore::InspectorController::setBreakpoint):
(WebCore::InspectorController::removeBreakpoint):
(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::failedToParseSource):
(WebCore::InspectorController::didPause):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::parsedScriptSource):
(WebCore::InspectorFrontend::restoredBreakpoint):
(WebCore::InspectorFrontend::failedToParseScriptSource):
(WebCore::InspectorFrontend::resumedScript):
* inspector/InspectorFrontend.h:
* inspector/JavaScriptDebugListener.h: Removed.
* inspector/JavaScriptDebugServer.cpp: Removed.
* inspector/JavaScriptDebugServer.h: Removed.
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint.prototype.set condition):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.addScript):
(WebInspector.ScriptsPanel.prototype.addBreakpoint):
(WebInspector.ScriptsPanel.prototype.removeBreakpoint):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
* inspector/front-end/inspector.js:
(WebInspector.restoredBreakpoint):
* page/Page.cpp:
(WebCore::Page::Page):
* platform/android/TemporaryLinkStubs.cpp:
2010-02-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make the UChar owned/ref-counted by StringImpl::CrossThreadRefCounted be const.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::sharedBuffer):
* platform/text/StringImpl.h:
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
Test: printing/page-break-always-for-overflow.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
* rendering/RenderBlock.h:
2010-02-21 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Remove auto_ptr usage in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=35157
The changes consists of:
- Changing auto_ptr arguments or return types to PassOwnPtr.
- Replacing local auto_ptr by OwnPtr.
- Removing now unneeded <memory> inclusion.
* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::workerContextDidReceiveResponse):
(WebCore::workerContextDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerContextDidReceiveAuthenticationCancellation):
* loader/WorkerThreadableLoader.h:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::create):
* loader/icon/IconLoader.h:
* platform/ContextMenu.cpp:
(WebCore::separatorItem):
* platform/CrossThreadCopier.h:
(WebCore::):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
* platform/network/ResourceResponseBase.h:
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument):
* workers/GenericWorkerTask.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
2010-02-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22215
Avoid calling absoluteClippedOverflowRect() so many times
RenderLayer::updateLayerPositions() computes the clipped overflow rect
and the outline bounds for repaint, and then calls repaintAfterLayoutIfNeeded()
which can compute the same rects all over again. Avoid this by passing
these two rects into repaintAfterLayoutIfNeeded() if known. This measurably
reduces the time spent in updateLayerPositions() for some content.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderObject.h:
2010-02-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35202
<rdar://problem/4856597> Calling Java method which accepts Object always passes a null argument
* bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Add cases for
other JS types.
2010-02-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
* html/DateComponents.cpp:
(WebCore::beforeGregorianStartDate):
* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::findPlugin):
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
No new tests: this is a build fix.
* WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test
2010-02-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23742
Applet methods can not return arrays to JS
* bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out
m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly.
* bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays.
Also, added an ifdef around code that's only needed on Tiger, and removed a comment saying
it can be removed when "new" plugin ships. I doubt that anyone can remember what "new"
could refer to back then.
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.
https://bugs.webkit.org/show_bug.cgi?id=35192
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype.viewRecreated):
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: need to highlight the evaluated expression used for popovers.
https://bugs.webkit.org/show_bug.cgi?id=35126
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._mouseMove):
(WebInspector.SourceFrame.prototype._hidePopup):
(WebInspector.SourceFrame.prototype._mouseHover):
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):
* inspector/front-end/inspector.css:
2010-02-20 Gustavo Noronha Silva <gns@gnome.org>
Roll out 55047 because it causes layout, and API tests to fail
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Refactor updating of ResourceResponse objects from soup message
objects, to avoid code duplication.
No behaviour change.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::fillResponseFromMessage):
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):
2010-02-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35190
Don't use system malloc in Java bindings
* bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector.
2010-02-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=9761
LiveConnect string conversion fails for java.lang.Object
Can't test Java in DRT (I wonder why).
* bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code.
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* WebCore.pri:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
2010-02-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35132
<rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
* page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse
pointer when above a plug-in or applet to prevent flicker.
2010-02-18 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
2010-02-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35178
LiveConnect code uses hand-rolled fprintf logging
Changed to use LOG, LOG_ERROR and ASSERT.
* platform/Logging.cpp:
(WebCore::getChannelFromName):
* platform/Logging.h:
* platform/mac/LoggingMac.mm:
(WebCore::InitializeLoggingChannelsIfNecessary):
* platform/win/LoggingWin.cpp:
(WebCore::InitializeLoggingChannelsIfNecessary):
TextConversion channel was (almost) unused, renamed to LiveConnect.
* platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames):
The only use of this channel was in platform specific code, commandeered it for cross-platform
needs.
* bridge/jni/JNIBridge.cpp:
* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::getJavaVM):
(JSC::Bindings::getJNIEnv):
(JSC::Bindings::getJNIField):
* bridge/jni/JNIUtility.h:
(JSC::Bindings::callJNIMethodV):
(JSC::Bindings::callJNIStaticMethod):
* bridge/jni/jni_jsobject.mm:
(completedJavaScriptAccess):
(dispatchToJavaScriptThread):
(performJavaScriptAccess):
(JavaJSObject::invoke):
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::getSlot):
(JavaJSObject::setSlot):
(JavaJSObject::toString):
(JavaJSObject::createNative):
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):
2010-02-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
RenderSVGResourceMasker causes an Assert on Wind builds during DRT
https://bugs.webkit.org/show_bug.cgi?id=35182
We remove the Assert for now and return earlier, if the HashMap of the Masker
does not contain the RenderObject. The RenderObject is an identifiert to get
a already calculated mask.
A race condition during parsing can cause the invalidation call, before the mask
got calculated (only during DRT on Win build bots).
The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::invalidateClient):
2010-02-18 Peter Kasting <pkasting@google.com>
Reviewed by Darin Fisher.
Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
https://bugs.webkit.org/show_bug.cgi?id=35136
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateRenderer): Shorten some code.
* page/DragController.cpp:
(WebCore::getImage): Shorten some code.
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
2010-02-19 Kenneth Rohde Christiansen <kenneth@webkit.org>
Rubberstamped by Noam Rosenthal, who wrote the original code.
Make mouse wheel scrolling work when using the GraphicsLayer.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
2010-02-19 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix Worker crash regression in r54972
https://bugs.webkit.org/show_bug.cgi?id=35166
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.
2010-02-19 Steve Block <steveblock@google.com>
Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests
* bindings/generic/RuntimeEnabledFeatures.cpp:
* storage/Database.cpp:
2010-02-19 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
No new tests, modifies a Chromium feature only.
* bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
* storage/Database.cpp: Modified. Sets database flag default to 'on'.
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
Test: inspector/elements-panel-xhtml-structure.xhtml
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
(WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeElement.prototype.onexpand):
(WebInspector.ElementsTreeElement.prototype.oncollapse):
(WebInspector.ElementsTreeElement.prototype.updateTitle.callback):
(WebInspector.ElementsTreeElement.prototype.updateTitle):
(WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium build fix: reverting r54997 and r54998.
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
* platform/KURLGoogle.cpp:
(WebCore::KURL::setProtocol):
(WebCore::KURL::isHierarchical):
2010-02-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] RTP/RTSP streams playback support
https://bugs.webkit.org/show_bug.cgi?id=33662
Added live pipelines support in updateStates().
* manual-tests/video-rtsp.html: Added.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::updateStates):
2010-02-18 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Adler.
Normalize custom ctors for Image, Option, Audio
https://bugs.webkit.org/show_bug.cgi?id=34782
Test: fast/js/custom-constructors.html
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
(WebCore::constructAudio):
* bindings/js/JSImageConstructor.cpp:
(WebCore::constructImage):
* bindings/js/JSOptionConstructor.cpp:
(WebCore::constructHTMLOptionElement):
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::v8HTMLAudioElementConstructorCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback):
* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::HTMLAudioElement):
(WebCore::HTMLAudioElement::createForJSConstructor):
* html/HTMLAudioElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createForJSConstructor):
(WebCore::HTMLImageElement::mapToEntry):
(WebCore::HTMLImageElement::createRenderer):
(WebCore::HTMLImageElement::attach):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::naturalHeight):
* html/HTMLImageElement.h:
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::createForJSConstructor):
(WebCore::HTMLOptionElement::ownerSelectElement):
(WebCore::HTMLOptionElement::nonRendererRenderStyle):
(WebCore::HTMLOptionElement::disabled):
(WebCore::HTMLOptionElement::insertedIntoTree):
* html/HTMLOptionElement.h:
2010-02-18 Simon Fraser <simon.fraser@apple.com>
No Review.
Remove a couple of extraneous spaces that got added to the project file
by hand-ending.
* WebCore.xcodeproj/project.pbxproj:
2010-02-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
Add logic to determine when painting via the software rendering path will give an equivalent
result to the accelerated compositing presentation. This tests for the presence of 3D transforms
via the existing RenderLayerCompositor::has3DContent() method.
* WebCore.base.exp: Export FrameView's isSoftwareRenderable(), paintBehavior() and setPaintBehavior().
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::isSoftwareRenderable): New method.
(WebCore::FrameView::paintBehavior): Make this non-inline so that we can reliably export it.
2010-02-18 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
<rdar://problem/7658811> Multiple style recalcs due to getComputedStyle() on “display: none;” element
when there are pending style sheets
Test: fast/css/getComputedStyle/pending-stylesheet.html
When querying a property of a computed style declaration for a non-rendered element,
CSSStyleSelector::styleForElement() was called, and if there were pending style sheet, it
would behave as if the lack of renderer is due to FOUC suppression, and set a flag on
the document causing it to recalculate style. On the next computed style property access,
style would be recalculated for the document, but then the flag would get set again if the
element did not have a renderer.
* dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets): Added. Temporarily sets
m_ignorePendingStylesheets around the call to CSSStyleSelector::styleForElement().
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::computedStyle): Use Document::styleForElementIgnoringPendingStylesheets().
2010-02-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020
We have rendering specific code in WebCore/svg/graphics. The goal is to move
this code into suitable Renderers. This helps us to clean up the code and makes
maintenance easier. It also makes it possible to remove rendering specific code
from SVG*Elements into this renderers. So the Renderer contains everything that
is needed to use the resource.
RenderSVGResource will be the base class for all new resource render classes like
RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.
This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
Another benefit is the much more useful result in DRT on using masker.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
* rendering/RenderPath.cpp:
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
* rendering/RenderSVGImage.h: Some code clean up according to the webkit style.
(WebCore::RenderSVGImage::toSVGRenderBase):
(WebCore::RenderSVGImage::renderName):
(WebCore::RenderSVGImage::isSVGImage):
(WebCore::RenderSVGImage::localToParentTransform):
(WebCore::RenderSVGImage::strokeBoundingBox):
(WebCore::RenderSVGImage::requiresLayer):
(WebCore::RenderSVGImage::localTransform):
* rendering/RenderSVGInlineText.h:
(WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
* rendering/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
* rendering/RenderSVGModelObject.h:
* rendering/RenderSVGResource.h: Added.
(WebCore::): Base class for all Resource renderers like masker, clipper and others.
(WebCore::RenderSVGResource::RenderSVGResource):
(WebCore::RenderSVGResource::cast):
(WebCore::RenderSVGResource::toRenderSVGResource):
(WebCore::RenderSVGResource::isSVGResource):
(WebCore::RenderSVGResource::drawsContents):
(WebCore::getRenderSVGResourceById):
* rendering/RenderSVGResourceMasker.cpp: Added.
(WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients.
(WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client.
(WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object.
(WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object.
(WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
* rendering/RenderSVGResourceMasker.h: Added.
(WebCore::MaskerData::MaskerData):
(WebCore::RenderSVGResourceMasker::renderName):
(WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT.
(WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT.
(WebCore::RenderSVGResourceMasker::resourceType):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::destroy): dito.
* rendering/RenderSVGText.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
(WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
* rendering/SVGRenderSupport.h:
(WebCore::SVGRenderBase::toSVGRenderBase):
(WebCore::SVGRenderBase::strokeBoundingBox):
(WebCore::SVGRenderBase::markerBoundingBox):
* rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly.
(WebCore::operator<<):
(WebCore::writeSVGResource):
(WebCore::writeSVGContainer):
(WebCore::writeSVGText):
(WebCore::writeSVGInlineText):
(WebCore::writeSVGImage):
(WebCore::write):
(WebCore::writeResourcesToObject):
* rendering/SVGRenderTreeAsText.h:
* svg/SVGMaskElement.cpp: Update Masker to use the new renderer.
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
(WebCore::SVGMaskElement::maskBoundingBox):
(WebCore::SVGMaskElement::createRenderer):
* svg/SVGMaskElement.h:
* svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed.
(WebCore::SVGStyledElement::invalidateResources):
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
* svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType.
(WebCore::toUnitType):
* svg/graphics/SVGResource.h:
(WebCore::):
(WebCore::SVGResource::isMarker):
* svg/graphics/SVGResourceMasker.cpp: Removed.
* svg/graphics/SVGResourceMasker.h: Removed.
2010-02-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Allow creating/dropping virtual tables when the module is FTS2.
https://bugs.webkit.org/show_bug.cgi?id=34867
* storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):
2010-02-18 Peter Kasting <pkasting@google.com>
Not reviewed, Chromium build fix.
r54963 had a typo in the WebCore.gypi change.
https://bugs.webkit.org/show_bug.cgi?id=35003
* WebCore.gypi:
2010-02-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
Changing forward declaration of TimingFunction in GraphicsLayer.h from
class to struct to match its actual definition in TimingFunction.h
https://bugs.webkit.org/show_bug.cgi?id=35069
* platform/graphics/GraphicsLayer.h:
Change forward declaration from: class TimingFunction to:
struct TimingFunction
2010-02-18 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507
Instead of having toHTMLImageElement which creates a new element,
assignToHTMLImageElement would set an existing HTML <img/> element to
contain the native QPixmap/QImge.
Also made some style fixes.
Additions to existing tests: see WebKit/qt/tests
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapWidthField::valueFromInstance): style
(JSC::Bindings::QtPixmapHeightField::valueFromInstance): style
(JSC::Bindings::QtPixmapAssignToElementMethod::name): assignTo
(JSC::Bindings::QtPixmapAssignToElementMethod::invoke): new function
(JSC::Bindings::QtPixmapAssignToElementMethod::numParameters): 1
(JSC::Bindings::QtPixmapToDataUrlMethod::invoke): style
(JSC::Bindings::QtPixmapToStringMethod::invoke): style
(JSC::Bindings::QtPixmapInstance::invokeMethod): style
(JSC::Bindings::QtPixmapClass::methodsNamed): new func, removed old
(JSC::Bindings::QtPixmapInstance::getPropertyNames): ditto
(JSC::Bindings::QtPixmapInstance::defaultValue): style
(JSC::Bindings::QtPixmapInstance::valueOf): style
(JSC::Bindings::QtPixmapInstance::toPixmap): style
(JSC::Bindings::QtPixmapInstance::variantFromObject): style
2010-02-18 Peter Kasting <pkasting@google.com>
Not reviewed, bustage fix.
An extraneous line in r54839 broke GIF animation.
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
2010-02-18 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7650652> REGRESSION: Selection painting issue in bug review textbox
https://bugs.webkit.org/show_bug.cgi?id=34946
Test: fast/repaint/selection-gap-overflow-scroll-2.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintSelection): localToContainerQuad() adjusts for
overflow scroll, but RenderLayer::addBlockSelectionGapsBounds() takes
non-scrolled coordinates, so account for that.
2010-02-17 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Adler.
Change the V8 and JSC SQLStatementErrorCallback to interpret
'undefined' return values as 'true', as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=35048
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallbackHelper):
(WebCore::invokeCallback):
(WebCore::invokeCallbackTreatUndefinedAsTrue):
* bindings/v8/custom/V8CustomVoidCallback.h:
2010-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
keyboard selection sometimes moves the wrong end of the selection for Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=35066
On Windows/Linux keyboard based selections should always move the same
end of the seleciton. On Mac, lineboundary and documentboundary changes
move different ends of the selection depending on which direction your
extending.
Test: editing/selection/extend-after-mouse-selection.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::startForPlatform):
(WebCore::SelectionController::endForPlatform):
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingBackward):
* editing/SelectionController.h:
2010-02-18 Timothy Hatcher <timothy@apple.com>
Add "with" to the list of keywords to syntax highlight.
http://webkit.org/b/35123
Reviewed by Pavel Feldman.
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer): Add "width" to _keywords.
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
(WebInspector.SourceJavaScriptTokenizer): Ditto.
2010-02-17 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Rework PNG-in-ICO decoding to copy the decoded framebuffer into the ICO
decoder, making the logic less crazy and more like the other decoders.
https://bugs.webkit.org/show_bug.cgi?id=28751
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::RGBA32Buffer::operator=):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::RGBA32Buffer):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::decodeAtIndex):
* platform/image-decoders/ico/ICOImageDecoder.h:
* platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::operator=):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::RGBA32Buffer::operator=):
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: multiple popovers on screen at the same time.
https://bugs.webkit.org/show_bug.cgi?id=35105
* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.hide):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup):
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Expand Object.__proto__ properly.
https://bugs.webkit.org/show_bug.cgi?id=35113
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
* inspector/front-end/ObjectProxy.js:
(WebInspector.ObjectProxy):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.callback):
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
2010-02-18 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
[V8] Merge the DOMWindow and WorkerContext object wrapping code paths,
and use a faster method of disambiguating between the types of contexts.
https://bugs.webkit.org/show_bug.cgi?id=35009
* bindings/scripts/CodeGeneratorV8.pm: Remove logic determining whether we need to
handle the WorkerContext case.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::globalObjectPrototypeIsDOMWindow):
(WebCore::V8DOMWrapper::instantiateV8Object): Merge instantiateV8Object paths.
* bindings/v8/V8DOMWrapper.h:
2010-02-12 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.
https://bugs.webkit.org/show_bug.cgi?id=34859
This is covered by fast/dom/Window/invalid-protocol.html
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
* platform/KURLGoogle.cpp:
(WebCore::KURL::setProtocol):
(WebCore::KURL::isHierarchical):
2010-02-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove some duplication between PluginView and Widget methods, and
move the setSelfVisible calls to the parent class.
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::show):
(WebCore::Widget::hide):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setFocus):
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
2010-02-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7655195> Switch Leopard back to using CGShading to avoid CGGradient leaks
Define USE_CG_SHADING on for Tiger and Leopard, and use it to toggle the methods
used for Core Graphics gradient drawing.
* platform/graphics/Gradient.h:
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::paint):
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: on-hover evaluation renders nodes and arrays as strings.
https://bugs.webkit.org/show_bug.cgi?id=35103
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
2010-02-18 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Particularly constructed WebFrames can try to access a null HistoryItem
<rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
Test: fast/loader/api-test-new-window-data-load-base-url.html
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateBackForwardListForFragmentScroll): We have a known case where a fragment scroll
might take place with a null m_currentItem. updateBackForwardListClippedAtTarget() will either move m_currentItem
to m_previousItem then create a new m_currentItem... or it will do nothing. So we either have both an m_currentItem
and m_previousItem, or we have neither. In the case where we have no m_previousItem, return early.
2010-02-18 Nate Chapin <japhet@chromium.org>
Reviewed by Eric Seidel.
[V8] Correctly handle the case where the event field on the
global object is a v8::Object, but not a DOM wrapper.
https://bugs.webkit.org/show_bug.cgi?id=34899
Test: fast/dom/Window/window-event-override-no-crash.html
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::isValidDOMObject):
(WebCore::V8DOMWrapper::isWrapperOfType):
* bindings/v8/V8DOMWrapper.h:
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, Qt build fix.
* inspector/front-end/WebKit.qrc:
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement evaluate-on-hover for scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=35003
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Images/gearButtonGlyph.png: Added.
* inspector/front-end/Images/popoverArrows.png: Added.
* inspector/front-end/Images/popoverBackground.png: Added.
* inspector/front-end/Images/thumbActiveHoriz.png: Added.
* inspector/front-end/Images/thumbActiveVert.png: Added.
* inspector/front-end/Images/thumbHoriz.png: Added.
* inspector/front-end/Images/thumbHoverHoriz.png: Added.
* inspector/front-end/Images/thumbHoverVert.png: Added.
* inspector/front-end/Images/thumbVert.png: Added.
* inspector/front-end/Images/trackHoriz.png: Added.
* inspector/front-end/Images/trackVert.png: Added.
* inspector/front-end/Popup.js:
(WebInspector.Popup):
(WebInspector.Popup.prototype.show):
(WebInspector.Popup.prototype.hide):
(WebInspector.Popup.prototype._positionElement):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype._scroll):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._mouseUp):
(WebInspector.SourceFrame.prototype._mouseMove):
(WebInspector.SourceFrame.prototype._mouseOut):
(WebInspector.SourceFrame.prototype._resetHoverTimer):
(WebInspector.SourceFrame.prototype._hidePopup):
(WebInspector.SourceFrame.prototype._mouseHover):
(WebInspector.SourceFrame.prototype._showPopup.showTextPopup):
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup.evaluateCallback):
(WebInspector.SourceFrame.prototype._showPopup):
(WebInspector.HoverPropertiesSection):
(WebInspector.HoverPropertiesSection.prototype.update):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype._lex):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._paintLine):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
* inspector/front-end/inspectorSyntaxHighlight.css:
* inspector/front-end/popover.css: Added.
2010-02-18 Ben Murdoch <benm@google.com>
Reviewed by Jeremy Orlow.
[v8] Complete upstreaming of V8 Touch Event bindings
https://bugs.webkit.org/show_bug.cgi?id=35094
No new tests required.
* bindings/v8/V8Index.cpp: Add generated touch event headers.
2010-02-18 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 build to use DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=35083
No new tests, build fix only.
* Android.derived.v8bindings.mk:
* Android.v8bindings.mk:
2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
fast/frames/iframe-reparenting.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35081
Check that the client is alive after every call to it, since any
of them could cause the load to be cancelled, and the client to go
away.
This is much better than protecting a specific subclass of
ResourceHandleClient (ResourceLoader), which makes us fail when
any other client is used.
Test: fast/frames/iframe-reparenting.html
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::parseDataUrl):
2010-02-18 Ben Murdoch <benm@google.com>
Reviewed by Nate Chapin.
[v8] [Android] V8 bindings for touch events are missing.
https://bugs.webkit.org/show_bug.cgi?id=33795
No new tests as this just enables touch events in V8. Existing touch tests suffice.
* WebCore.gypi: Add Touch idl files.
* bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
* bindings/v8/DOMObjectsInclude.h: Add touch headers.
* bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
* bindings/v8/V8Index.h: Add touch DOM object types.
* bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
* Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
* Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.
2010-02-18 William Chan <willchan@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35071
Disable loader limiting of requests per host for the chromium port.
No tests because we're only changing a constant.
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
2010-02-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
The NP Version supported by WebKit is at the moment hardcoded in
PluginPackage.cpp (to 24), but not all backends actually implement
the methods needed to claim this. Introduce a new method to be
implemented by each backend where the maximum supported version
can be specified, and set the GTK+ port NPVersion to 19. This
fixes an instantaneous crasher in the Sun Java NPAPI plugin.
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::initializeBrowserFuncs):
* plugins/PluginPackage.h:
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::NPVersion):
* plugins/mac/PluginPackageMac.cpp:
(WebCore::PluginPackage::NPVersion):
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::NPVersion):
* plugins/symbian/PluginPackageSymbian.cpp:
(WebCore::PluginPackage::NPVersion):
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::NPVersion):
2010-02-17 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin, Darin Fisher, Simon Hausmann.
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382
Test: fast/frames/iframe-reparenting-new-page.html
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateOnReparenting):
Called on the frame that was just re-parented and inserted into another Document.
Simply invoke Frame::transferChildFrameToNewDocument(...);
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
* html/HTMLFrameElementBase.h:
* html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::setName):
Make this a virtual function, to be able to reach it via Frame::m_ownerElement.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::adoptFrame):
* loader/FrameLoaderClient.h:
Add a new method, didTransferChildFrameToNewDocument().
It compliments createFrame() in that a frame which was re-parented
in DOM and potentially changes Page, should notify the WebKit
implementation about potential ownership change.
Many embedders assume that Page owns all the Frames, or at least
all Frames are destroyed before 'their' Page is destroyed. Obviously, if Frame
can be transferred to another Page, the embedders should be notified.
* page/Frame.cpp:
(WebCore::Frame::transferChildFrameToNewDocument):
Added, makes actual adjustments for Frame - resets the Page,
updates the frame tree and frame name, calls to FrameLoaderClient
to update external objects and recurses into children.
Can only be used on child frames.
* page/Frame.h:
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Copying and pasting into a contenteditable area can create <div>s surrounded by <span>s
https://bugs.webkit.org/show_bug.cgi?id=26937
This happens because of a span added when we copy that is used to
preserve styles. To avoid this, when we paste, make sure to apply
the styles to the span's children and then remove the style span.
This change is covered by existing layout tests.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::copyStyleToChildren):
* editing/ReplaceSelectionCommand.h:
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34914
When pasting absolute font sizes into a content editable area with
page zoom, adjust the font sizes to be the same after page zoom is
applied.
Test: editing/pasteboard/page-zoom.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34737
Copying styled list items then pasting into a list
should work the same as copying unstyle list items:
it shouldn't indent an extra level, but styles should
be copied.
Small cleanups to insertAsListItems to make variable names
more descriptive.
Test: editing/pasteboard/paste-list-003.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
2010-02-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=34794
Retrieve the type, key code, text and modifiers from BREW's keyboard event.
* platform/PlatformKeyboardEvent.h:
* platform/brew/PlatformKeyboardEventBrew.cpp: Added.
(WebCore::keyIdentifierForBrewKeyCode):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::singleCharacterString):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
2010-02-17 Hayato Ito <hayato@chromium.org>
Reviewed by Eric Seidel.
Support CSS page-break-inside with a value of 'avoid'.
https://bugs.webkit.org/show_bug.cgi?id=34080
Test: printing/page-break-inside.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
2010-02-17 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
Fixed bug in webkit r54694. check m_client after it calls user
callback, because user callback may call close(), which would
call onclose event handler.
Test: websocket/tests/bufferedAmount-after-close.html
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::didClose):
(WebCore::WebSocketChannel::didReceiveData):
* websockets/WebSocketChannel.h:
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didClose):
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
* websockets/WorkerThreadableWebSocketChannel.h:
2010-02-17 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
In diffing render styles, consider all pseudo style changes.
Without this patch, only :before and :after are considered. This is the cause of the following bug.
https://bugs.webkit.org/show_bug.cgi?id=32187
Test: fast/css/first-letter-first-line-hover.html
* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::hasAnyPublicPseudoStyles):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
(WebCore::):
2010-02-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add WebCore::prefetchDNS
https://bugs.webkit.org/show_bug.cgi?id=34873
DNS prefetching is not implemented because the maximum number
of UDP sockets is quite small in most BREW devices.
* platform/network/brew/DNSBrew.cpp: Added.
(WebCore::prefetchDNS):
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
It's hard for Chromium port to load an icon inside
Icon::createIconForFiles() because of sanbox and multi-process
architecture. So this change adds a method to request an icon to
Chrome class, and makes FileChooser receives an Icon instance
asynchronously. Synchronous loading also works with the new interface.
Because all ports don't have implementations of Chrome::iconForFiles()
yet, FileChooser tries to load an Icon synchronously with
Icon::createIconForFiles(), then tries to load an Icon asynchronously
with Chrome::iconForFiles() if Icon::createIconForFiles() returns 0.
The existing Icon::createIconForFiles() implementations should be
moved to Chrome::iconForFiles(). We're going to remove
Icon::createIconForFiles().
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::iconForFiles): Add an empty implementation.
* page/Chrome.cpp:
(WebCore::Chrome::iconForFiles): Delegate to ChromeClient::iconForFiles().
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::iconForFiles): Add a declaration as a pure virtual method.
* platform/FileChooser.cpp:
(WebCore::FileChooser::FileChooser): Use loadIcon().
(WebCore::FileChooser::chooseFiles): ditto.
(WebCore::FileChooser::loadIcon): Added.
(WebCore::FileChooser::iconLoaded): Added.
* platform/FileChooser.h: Add two methods to FileChooserClient; repaint() and iconForFiles().
* platform/graphics/Icon.h: Add a FIXME comment.
* platform/graphics/gtk/IconGtk.cpp: ditto.
* platform/graphics/mac/IconMac.mm: ditto.
* platform/graphics/qt/IconQt.cpp: ditto.
* platform/graphics/win/IconWin.cpp: ditto.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::iconForFiles): Delegate to Chrome::iconForFiles().
(WebCore::RenderFileUploadControl::click): Use chrome().
(WebCore::RenderFileUploadControl::chrome):
* rendering/RenderFileUploadControl.h:
(WebCore::RenderFileUploadControl::repaint):
2010-02-17 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Bug 35065: Delay between page loading and animated GIF playing
<http://webkit.org/b/35065> / <rdar://problem/7109548>
BitmapImage::startAnimation was adding the current frame duration to the desired start time
of the frame for every time it was called. If the function then bailed out due to not having
sufficient data to render the frame, this would lead to the desired start time of the frame
being pushed out multiple times. On an animated GIF that took mulitple seconds to load this
could happen many times for a single frame, resulting in the start time of the second frame
of the animation being pushed out by as much as five seconds.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation): Change the order of the code slightly so that the
desired start time is only updated after determining that we have sufficient data to handle
the next frame.
2010-02-17 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Implemented homeDirectoryPath() and listDirectory() on the Haiku platform.
https://bugs.webkit.org/show_bug.cgi?id=34687
Covered by existing tests.
* platform/haiku/FileSystemHaiku.cpp:
(WebCore::homeDirectoryPath): Implemented
(WebCore::listDirectory): Implemented
2010-02-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port userIdleTime
https://bugs.webkit.org/show_bug.cgi?id=34259
Return an arbitrarily high userIdleTime so that releasing pages from the page
cache isn't postponed.
* platform/brew/SystemTimeBrew.cpp: Added.
(WebCore::userIdleTime):
2010-02-17 Dirk Schulze <krit@webkit.org>
Rolling out r54909. Breaks SL and Win.
2010-02-17 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Fix Chromium's bindings for Database.transaction(): a 'null'
callback should be treated as no callback.
Test: storage/null-callbacks.html
https://bugs.webkit.org/show_bug.cgi?id=35047
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::createTransaction):
2010-02-17 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020
We have rendering specific code in WebCore/svg/graphics. The goal is to move
this code into suitable Renderers. This helps us to clean up the code and makes
maintenance easier. It also makes it possible to remove rendering specific code
from SVG*Elements into this renderers. So the Renderer contains everything that
is needed to use the resource.
RenderSVGResource will be the base class for all new resource render classes like
RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.
This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
Another benefit is the much more useful result in DRT on using masker.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
* rendering/RenderPath.cpp:
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
* rendering/RenderSVGImage.h: Some code clean up according to the webkit style.
(WebCore::RenderSVGImage::toSVGRenderBase):
(WebCore::RenderSVGImage::renderName):
(WebCore::RenderSVGImage::isSVGImage):
(WebCore::RenderSVGImage::localToParentTransform):
(WebCore::RenderSVGImage::strokeBoundingBox):
(WebCore::RenderSVGImage::requiresLayer):
(WebCore::RenderSVGImage::localTransform):
* rendering/RenderSVGInlineText.h:
(WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
* rendering/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
* rendering/RenderSVGModelObject.h:
* rendering/RenderSVGResource.h: Added.
(WebCore::): Base class for all Resource renderers like masker, clipper and others.
(WebCore::RenderSVGResource::RenderSVGResource):
(WebCore::RenderSVGResource::cast):
(WebCore::RenderSVGResource::toRenderSVGResource):
(WebCore::RenderSVGResource::isSVGResource):
(WebCore::RenderSVGResource::drawsContents):
(WebCore::getRenderSVGResourceById):
* rendering/RenderSVGResourceMasker.cpp: Added.
(WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients.
(WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client.
(WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object.
(WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object.
(WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
* rendering/RenderSVGResourceMasker.h: Added.
(WebCore::MaskerData::MaskerData):
(WebCore::RenderSVGResourceMasker::renderName):
(WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT.
(WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT.
(WebCore::RenderSVGResourceMasker::resourceType):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::destroy): dito.
* rendering/RenderSVGText.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
(WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
* rendering/SVGRenderSupport.h:
(WebCore::SVGRenderBase::toSVGRenderBase):
(WebCore::SVGRenderBase::strokeBoundingBox):
(WebCore::SVGRenderBase::markerBoundingBox):
* rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly.
(WebCore::operator<<):
(WebCore::writeSVGResource):
(WebCore::writeSVGContainer):
(WebCore::writeSVGText):
(WebCore::writeSVGInlineText):
(WebCore::writeSVGImage):
(WebCore::write):
(WebCore::writeResourcesToObject):
* rendering/SVGRenderTreeAsText.h:
* svg/SVGMaskElement.cpp: Update Masker to use the new renderer.
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
(WebCore::SVGMaskElement::maskBoundingBox):
(WebCore::SVGMaskElement::createRenderer):
* svg/SVGMaskElement.h:
* svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed.
(WebCore::SVGStyledElement::invalidateResources):
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
* svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType.
(WebCore::toUnitType):
* svg/graphics/SVGResource.h:
(WebCore::):
(WebCore::SVGResource::isMarker):
* svg/graphics/SVGResourceMasker.cpp: Removed.
* svg/graphics/SVGResourceMasker.h: Removed.
2010-02-17 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Refactor texImage2D and texSubImage2D taking Image to use common code
https://bugs.webkit.org/show_bug.cgi?id=34458
Merged the Safari and Chromium code which extracts the data from
Image objects into common entry points on GraphicsContext3D. This
immediately fixes the following three problems:
- Chromium not implementing texSubImage2D taking Image.
- Safari not obeying the flipY parameter to texImage2D or
texSubImage2D taking Image.
- Safari not obeying the premultipyAlpha parameter to texImage2D
or texSubImage2D taking Image.
Added new test verifying the behavior of texImage2D and
texSubImage2D and the flipY parameter. The premultiplyAlpha
parameter can not be tested yet as the implementation is not yet
spec compliant. This will be fixed in a follow-on bug.
Ran all WebGL demos in demo repository on Safari and Chromium;
textures are now the right way up in both browsers, and
transparent textures in Particles demo now look correct in Safari.
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext3D.cpp: Added.
(WebCore::GraphicsContext3D::extractImageData):
(WebCore::GraphicsContext3D::processImageData):
(WebCore::GraphicsContext3D::premultiplyAlpha):
(WebCore::GraphicsContext3D::unmultiplyAlpha):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::):
* platform/graphics/cg/GraphicsContext3DCG.cpp: Added.
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
* platform/graphics/skia/GraphicsContext3DSkia.cpp: Added.
(WebCore::GraphicsContext3D::getImageData):
2010-02-17 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsLayer: support perspective and 3D transforms
https://bugs.webkit.org/show_bug.cgi?id=34960
New tests: http://webkit.org/blog-files/3d-transforms/perspective-by-example.html
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::updateTransform):
(WebCore::GraphicsLayerQtImpl::setBaseTransform):
(WebCore::GraphicsLayerQtImpl::computeTransform):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
2010-02-17 Peter Kasting <pkasting@google.com>
Unreviewed, build fix.
Fix crashes due to an omitted line in r54839.
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
2010-02-17 Alok Priyadarshi <alokp@chromium.org>
Reviewed by Ariya Hidayat.
Bug 34900: Implement accelerated compositing for chromium.
https://bugs.webkit.org/show_bug.cgi?id=34900
Do not exclude files needed for accelerated compositing. In fact there is no need to exclude these files.
These files are already guarded with WTF_USE_ACCELERATED_COMPOSITING flag.
* WebCore.gyp/WebCore.gyp: Removed GraphicsLayer.cpp, RenderLayerBacking.cpp,
and RenderLayerCompositor.cpp from excluded list.
2010-02-17 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Remove the obsolete chromium interface for handling DownloadURL.
https://bugs.webkit.org/show_bug.cgi?id=34982
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::setData):
2010-02-17 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that span multiple columns
* manual-tests/match-marker-rects.html: Added.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTextMatchMarker): Use the text renderer rather
than its ancestor block for the local-to-absolute transformation.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Does not send an Accept header for subresources, causing some sites to break
https://bugs.webkit.org/show_bug.cgi?id=33242
Set */* as the Accept header when downloading resources
that did not set an Accept header. This behaviour is similar to
the one adopted by Chromium.
Test: http/tests/misc/image-checks-for-accept.html
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::startHttp):
2010-02-17 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Fixes initialization order of members for GeolocationServiceChromium.
https://bugs.webkit.org/show_bug.cgi?id=35034
* platform/chromium/GeolocationServiceChromium.cpp:
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
Resolve symlinks before trying to load plugins as modules, since
GModule won't do it.
Based on original work by Gustavo Noronha.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::load):
2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Protect the resource loader object from disappearing during
parseDataUrl.
Tested by testdownload API test.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::parseDataUrl):
2010-02-17 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Implements GeolocationServices for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=32068
This is part of implementing Geolocation framework for Chromium. Existing layout tests should pass.
* WebCore.gypi:
* page/Geolocation.h:
* platform/GeolocationService.h:
2010-02-17 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds missing platform and feature guards to V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=34987
No new tests, build fix only.
* bindings/v8/V8Proxy.cpp: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
* bindings/v8/V8Proxy.h: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
* bindings/v8/custom/V8DocumentCustom.cpp: Modified. Adds XPATH guards
2010-02-17 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Include WebCore's npruntime.h for Android in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=35002
Currently, the V8 bindings include bindings/npruntime.h, which is a
Chromium-specific file outside of the WebKit tree.
No new tests, build fix only.
* bindings/v8/NPV8Object.cpp:
* bindings/v8/NPV8Object.h:
* bindings/v8/V8NPObject.h:
* bindings/v8/V8NPUtils.h:
* bindings/v8/npruntime_impl.h:
* bindings/v8/npruntime_priv.h:
2010-01-07 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should handle BUFFERING messages
https://bugs.webkit.org/show_bug.cgi?id=30004
Initial support for on-disk buffering of videos. This works only
for Quicktime and flv though.
* css/mediaControlsGtk.css:
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack): Draw the
buffering status in the media controls.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateMessageCallback): Defer buffering
messages handling to processBufferingStats().
(WebCore::bufferingTimeoutCallback): Closure called periodically
during the on-disk buffering process.
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate): New instance
variables and create playbin2 here instead of doing it in load().
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): New instance
variables.
(WebCore::MediaPlayerPrivate::load): Simply set uri on playbin2
instead of creating the pipeline and setting uri all together.
(WebCore::MediaPlayerPrivate::processBufferingStats): Start a new
timeout source if the player is starting on-disk buffering.
(WebCore::MediaPlayerPrivate::queryBufferingStats): Method called
200ms during on-disk buffering to update the maxTimeLoaded and few
other private variables.
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::bytesLoaded): Fixed implementations
regarding buffering.
(WebCore::MediaPlayerPrivate::totalBytes): Improved logging.
(WebCore::MediaPlayerPrivate::updateStates): Start playback if it
was internally paused at beginning of on-disk buffering and set
ready/network states depending on the state of the on-disk
buffering process.
(WebCore::MediaPlayerPrivate::didEnd): Emit durationChanged.
(WebCore::MediaPlayerPrivate::setAutobuffer): Edit playbin2 flags
property depending on autoBuffer value.
(WebCore::MediaPlayerPrivate::createGSTPlayBin): Don't set uri
there, it is now done in load().
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: New methods
and instance variables.
2010-02-16 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add a new setting which gives the option of assigning every file:///
to its own unique domain.
https://bugs.webkit.org/show_bug.cgi?id=34778
Test: Pending in forthcoming separate change due to non-trivial
dependencies.
* dom/Document.cpp:
(WebCore::Document::initSecurityContext): Place file:/// URI documents
into their own unique domains if the new setting requires it.
* page/Settings.h:
* page/Settings.cpp:
(WebCore::Settings::setAllowFileAccessFromFileURLs): Simple setter.
* page/SecurityOrigin.h:
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::makeUnique): Add simple ability to force an
origin to be considered unique.
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: drosera/demo.js not syntax highlighted correctly.
https://bugs.webkit.org/show_bug.cgi?id=35008
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer.Registry):
(WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: prefer smooth scrolling to instant highlight.
https://bugs.webkit.org/show_bug.cgi?id=34978
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._scroll):
(WebInspector.TextChunk):
(WebInspector.TextChunk.prototype._createRow):
* inspector/front-end/textViewer.css:
2010-02-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Nikolas Zimmermann.
SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630
When the background image is an SVG image, and it is smaller than the area
it is supposed to fill, we were using renderSubTreeToImage to draw it.
That call was not going through all the drawing phases, and so the SVG itself
would not be drawn.
Test: svg/css/background-image-svg.html
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
2010-02-16 Bryan Yeung <bryeung@chromium.org>
Reviewed by Nikolas Zimmermann.
Remove the bounds on stroke width and miter for the skia platform.
https://bugs.webkit.org/show_bug.cgi?id=34954
Test: svg/custom/stroke-width-large.svg
* platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::setupPaintForStroking):
2010-02-16 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG text disappaears after double click
https://bugs.webkit.org/show_bug.cgi?id=34880
Tests: svg/text/selection-doubleclick.svg
svg/text/selection-tripleclick.svg
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection):
Use InlineTextBox::selectionStartEnd() instead of
RenderObject::selectionStartEnd() because latter may span multiple
comparing startPos and endPos is irrelevant in some cases.
former selectionStartEnd() is for single line and comparing
startPos and endPos will make sense.
2010-02-16 Jessie Berlin <jberlin@webkit.org>
Reviewed by Timothy Hatcher.
Inspector should display Array lengths in the property lists.
https://bugs.webkit.org/show_bug.cgi?id=20695
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
For objects of type 'array' (which includes Arrays, NodeLists, and HTMLCollections), make the length of the object available via propertyLength on the proxy object.
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
For properties that have propertyLength defined, append it to the displayed description.
2010-02-16 Yusuke Sato <yusukes@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
https://bugs.webkit.org/show_bug.cgi?id=34735
Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.
Test: fast/css/font-face-opentype.html
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
2010-02-16 Darin Adler <darin@apple.com>
* page/MediaCanStartListener.h: Fixed license.
2010-02-16 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981
Also did some simple cleanup of HTMLMediaElement to get ready to make it
a client of the same mechanism.
* WebCore.base.exp: Added Page::setCanStartMedia and resorted.
* WebCore.xcodeproj/project.pbxproj: Added MediaCanStartListener.h.
* html/HTMLAudioElement.h: Added an implementation of isVideo since that
is now a pure virtual function in HTMLMediaElement. Also made tagPriority
private.
* html/HTMLMediaElement.h: Made it clearer that HTMLMediaElement is an
abstract base class by making its constructor protected and making the
isVideo function a pure virtual function.
* page/Page.cpp:
(WebCore::Page::Page): Updated for name change from m_canStartPlugins
to m_canStartMedia.
(WebCore::Page::addMediaCanStartListener): Renamed and added an assertion.
(WebCore::Page::removeUnstartedMedia): Ditto.
(WebCore::Page::setCanStartMedia): Renamed plugin to media and moved
the code here from PageWin.cpp. The main change from the one in PageWin.cpp
is that this function calls mediaCanStart rather than explicitly calling a
combination of start and dispatchDidFailToStartPlugin on a PluginView.
* page/Page.h: Re-sorted forward class declarations. Renamed the plugin
starting functions to media starting names and changed types from
PluginView to MediaCanStartListener.
* page/MediaCanStartListener.h: Added.
* page/win/PageWin.cpp: Moved setCanStartPlugins to the platform-independent
Page.cpp file so it can be used for more than just Windows plug-ins.
* plugins/PluginView.cpp: Sorted includes.
(WebCore::PluginView::startOrAddToUnstartedList): Use addMediaCanStartListener.
(WebCore::PluginView::mediaCanStart): Added. Called when the page decides that
media can start. Contains the code that used to be in Page::setCanStartPlugins.
(WebCore::PluginView::removeFromUnstartedListIfNecessary): Use
removeMediaCanStartListener.
* plugins/PluginView.h: Adopted MediaCanStartListener.
2010-02-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=34999
Compositing layers inside overflow:scroll divs are not always updated on scrolling
When RenderLayer::scrollToOffset() updates compositing layer positions, it needs
to start updating at its stacking context rather than just its compositing ancestor.
The stacking context is guaranteed to contain all descendants of the overflow
layer, including those that are not direct descendants of the overflow layer in stacking
(and therefore compositing) order.
Test: compositing/overflow/scroll-ancestor-update.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
2010-02-16 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Allow FloatRect::center() to return fractional coordinates. It was
mistakenly converting to integers.
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::center):
2010-02-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=34964
Leaks tool reports false memory leaks due to Rope implementation.
Renamed cUStringImpl::size() to UStringImpl::size()UStringImpl::length()
(matches WebCore::StringImpl).
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::length):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
2010-02-15 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7288853> Message about missing plugin does not specify
the type or download link for download
Reviewed by Mark Rowe.
* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::findPlugin):
Only update the mimeType out param if we find a plug-in for the file
extension.
2010-02-16 Simon Fraser <simon.fraser@apple.com>
Build fix for Tiger.
Add #if USE(ACCELERATED_COMPOSITING) around the call to mediaPlayerRenderingModeChanged().
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::setUpVideoRendering):
2010-02-16 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Eric Carlson.
Buildfix for r54826.
HTMLMediaElement class defined by HTMLMediaElement.h in #if ENABLE(VIDEO) block,
it should be in #if ENABLE(VIDEO) block in rendering/RenderLayerBacking.cpp too.
* rendering/RenderLayerBacking.cpp: Missing #if ENABLE(VIDEO) guard added.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
2010-02-16 Julie Parent <jparent@chromium.org>
Unreviewed: Chromium build fix.
http://trac.webkit.org/changeset/54823 introduced an unused variable. Remove it.
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
2010-02-16 Mark Rowe <mrowe@apple.com>
Reviewed by Alexey Proskuryakov.
Bug 34974: Leak of ScheduledAction during layout tests
<https://bugs.webkit.org/show_bug.cgi?id=34974>
ScheduledAction::create was returning a raw pointer which was threaded down through to an OwnPtr in DOMTimer.
If any of the code paths in between hit an error case and returned early the raw pointer would be leaked. We
can avoid this by passing it as a PassOwnPtr. This will ensure that the ScheduledAction is cleaned up should
an error case be hit.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout): Store the newly-created ScheduledAction in an OwnPtr and then hand it off
as the function argument.
(WebCore::JSDOMWindow::setInterval): Ditto.
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout): Ditto.
(WebCore::JSWorkerContext::setInterval): Ditto.
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create): Return a PassOwnPtr.
* bindings/js/ScheduledAction.h:
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer): Update argument type.
(WebCore::DOMTimer::install): Ditto.
* page/DOMTimer.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setTimeout): Ditto.
(WebCore::DOMWindow::setInterval): Ditto.
* page/DOMWindow.h:
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by David Hyatt.
SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004
Large step towards making WebKit an usable SVG viewer.
Make zooming into SVG documents work as expected, in both standalone and XHTML/SVG compound documents.
SVG applies a global scale to the document, whereas CSS zooms all individual length units (on full-page-zoom).
Scaling has to be avoided for all SVG specific CSS properties (already works) and for some selected CSS
properties shared between CSS & SVG that explicitely need a different treatment in the context of SVG.
To name a few: font-size, letter-spacing, etc. should stay invariant under zoom in SVG document fragments.
Some new rules regarding zooming:
- "Zoom text only" should never affect SVG documents, neither text nor content should zoom.
This option doesn't make much sense for SVG, so it's wise to avoid side-effects and disable it.
In compound documents the SVG would stay as-is and only text of surrounding XHTML content would zoom.
- "Full page zoom" is the only zoom mode affecting SVG. (Panning only works in standalone documents.)
Cover all mentioned cases above by a new set of layout tests.
Tests: svg/zoom/page/absolute-sized-document-no-scrollbars.svg
svg/zoom/page/absolute-sized-document-scrollbars.svg
svg/zoom/page/relative-sized-document-scrollbars.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/page/zoom-foreignObject.svg
svg/zoom/page/zoom-hixie-mixed-008.xml
svg/zoom/page/zoom-hixie-mixed-009.xml
svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
svg/zoom/page/zoom-svg-float-border-padding.xml
svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml
* css/CSSStyleSelector.cpp: Blacklist certain properties not to be zoomed for SVG elements.
(WebCore::CSSStyleSelector::styleForDocument): Don't zoom font-sizes.
(WebCore::CSSStyleSelector::applyProperty): Ditto (+ letter/word-spacing).
(WebCore::CSSStyleSelector::setFontSize): Ditto.
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Never apply text zoom to SVG.
* css/CSSStyleSelector.h:
* css/SVGCSSStyleSelector.cpp: -webkit-shadow + SVG was incorrectly respecting zoom factor.
(WebCore::CSSStyleSelector::applySVGProperty):
* page/Frame.cpp:
(WebCore::Frame::shouldApplyTextZoom): Remove SVG special cases.
(WebCore::Frame::shouldApplyPageZoom): Ditto.
(WebCore::Frame::setZoomFactor): Don't force setZoomsTextOnly() - SVG now uses FPZ as well.
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::calcReplacedWidth): CSSPropertyWidth is explicitely not scaled by CSSStyleSelector, fix that for outermost <svg> elements.
(WebCore::RenderSVGRoot::calcReplacedHeight): Ditto for CSSPropertyHeight.
(WebCore::RenderSVGRoot::layout): Simplify & cleanup code, take advantage of new calcWidth/Height functionality, no need to scale anything here.
(WebCore::RenderSVGRoot::paint): Use parentOriginToBorderBox() instead of duplicating code.
(WebCore::RenderSVGRoot::calcViewport): Simplify code.
(WebCore::RenderSVGRoot::localToBorderBoxTransform): Calculate viewBoxToViewTransformation() against unscaled width()/height() values.
* rendering/RenderSVGRoot.h:
* svg/SVGLength.cpp:
(WebCore::SVGLength::PercentageOfViewport): Cleanup & document function.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentScale): Return pageZoomFactor(), not just the zoomFactor() - as we want to ignore text-only zoom.
(WebCore::SVGSVGElement::setCurrentScale): Pass isTextOnly=false to setZoomFactor().
2010-02-16 Julie Parent <jparent@chromium.org>
Unreviewed: Chromium build fix.
https://bugs.webkit.org/show_bug.cgi?id=34998
Move include of JavaScriptProfile.h behind if (USE_JSC).
* inspector/InspectorController.cpp:
2010-02-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoffrey Garen and Kevin Decker.
https://bugs.webkit.org/show_bug.cgi?id=34989
<rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content
* html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler): Added some
comments about the way we pass events down to plug-ins.
2010-02-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Carlson.
With hardware acceleration turned off, video frames never display if poster
image is specified
https://bugs.webkit.org/show_bug.cgi?id=34965
HTMLVideoElement's m_shouldDisplayPosterImage was never updated after
the movie supplied its first video frame, so the poster would continue to show.
Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called
each time a new frame is available. updatePosterImage() is cheap.
Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of
ugly casts.
Test: manual-tests/media-elements/video-replaces-poster.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check.
(WebCore::HTMLMediaElement::setNetworkState): Ditto.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage().
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual
method on the base class.
* html/HTMLVideoElement.h: Override updatePosterImage().
2010-02-16 Simon Fraser <simon.fraser@apple.com>
Build fix for platforms without ACCELERATED_COMPOSITING defined.
mediaPlayerRenderingModeChanged() is only available when ACCELERATED_COMPOSITING is defined.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::setUpVideoRendering):
2010-02-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Carlson.
Autoplaying video with poster doesn't reliably show up
https://bugs.webkit.org/show_bug.cgi?id=34966
A timing issue with compositing updates when replacing the poster image
with the video could cause the video to not display.
Fix by making video layer hook up more similar to WebGL etc, by having the
video kick off a recalcStyle() via a SyntheticStyleChange. This requires
vending a PlaformLayer* from the media player, up through the element.
Test: media/video-replaces-poster.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRenderingModeChanged): Use setNeedsStyleRecalc()
to kick off a compositing update.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::platformLayer): Export the media engine's layer.
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::platformLayer): Method to vend the media layer.
(WebCore::MediaPlayer::platformLayer):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerRenderingModeChanged): New client callback
to indicate that the rendering mode changed. The element uses this to kick off a
recalcStyle.
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::platformLayer): Method to vend the media layer.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::createQTMovieLayer): No longer parent the layer directly
via setContentsToMedia().
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): Ditto.
(WebCore::MediaPlayerPrivate::setUpVideoRendering): Tell the client that the
rendering mode changed.
(WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Call setContentsToMedia()
here.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Add platformLayer().
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
(WebCore::MediaPlayerPrivate::setUpVideoRendering): Call mediaPlayerRenderingModeChanged()
(WebCore::MediaPlayerPrivate::createLayerForMovie): Don't parent the layer ourselves any more.
* rendering/RenderVideo.h: videoGraphicsLayer() is no longer needed.
* rendering/RenderVideo.cpp: Ditto.
2010-02-12 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Code cleanup in ImageDecoders; no functional change.
https://bugs.webkit.org/show_bug.cgi?id=28751
* Make code mostly comply with the style guide (switch indenting, use of
"!" vs. "== 0", don't unnecessarily wrap lines, etc.)
* Eliminate m_allDataReceived in ICO/BMP decoders since it's in the
base ImageDecoder class
* Remove some useless or wrong comments, add others
* Wrap comments at 80 columns (most already were) for
consistency/readability
* Avoid casts by using correct variable types
* Consistent naming of decode() function/args
* Shorter code in some places
* Make declaration and definition order match
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::forceLoadEverything):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::setSize):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::):
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::BMPImageDecoder):
(WebCore::BMPImageDecoder::setData):
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
(WebCore::BMPImageDecoder::decodeHelper):
(WebCore::BMPImageDecoder::processFileHeader):
* platform/image-decoders/bmp/BMPImageDecoder.h:
(WebCore::BMPImageDecoder::readUint32):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::BMPImageReader):
(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::isInfoHeaderValid):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):
* platform/image-decoders/bmp/BMPImageReader.h:
(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::pastEndOfImage):
(WebCore::BMPImageReader::readCurrentPixel):
(WebCore::BMPImageReader::getComponent):
(WebCore::BMPImageReader::getAlpha):
(WebCore::BMPImageReader::setI):
(WebCore::BMPImageReader::setRGBA):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/gif/GIFImageDecoder.h:
(WebCore::GIFImageDecoder::):
(WebCore::GIFImageDecoder::filenameExtension):
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::do_lzw):
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::~GIFImageReader):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::~ICOImageDecoder):
(WebCore::ICOImageDecoder::setData):
(WebCore::ICOImageDecoder::isSizeAvailable):
(WebCore::ICOImageDecoder::frameSizeAtIndex):
(WebCore::ICOImageDecoder::frameCount):
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::compareEntries):
(WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex):
(WebCore::ICOImageDecoder::decode):
(WebCore::ICOImageDecoder::decodeDirectory):
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectoryEntries):
(WebCore::ICOImageDecoder::readDirectoryEntry):
* platform/image-decoders/ico/ICOImageDecoder.h:
(WebCore::ICOImageDecoder::readUint16):
(WebCore::ICOImageDecoder::readUint32):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageReader::decode):
(WebCore::error_exit):
(WebCore::fill_input_buffer):
(WebCore::term_source):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
(WebCore::JPEGImageDecoder::filenameExtension):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
(WebCore::decodingWarning):
(WebCore::headerAvailable):
(WebCore::rowAvailable):
(WebCore::pngComplete):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageReader::createInterlaceBuffer):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::filenameExtension):
* platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::setDecodedImage):
2010-02-16 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix.
* WebCore.pro: Missing backslash added.
2010-02-16 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.
https://bugs.webkit.org/show_bug.cgi?id=34848
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JavaScriptProfile.cpp: Added.
(WebCore::profileCache):
(WebCore::getTitleCallback):
(WebCore::getHeadCallback):
(WebCore::getUniqueIdCallback):
(WebCore::focus):
(WebCore::exclude):
(WebCore::restoreAll):
(WebCore::finalize):
(WebCore::ProfileClass):
(WebCore::toJS):
* bindings/js/JavaScriptProfile.h: Added.
* bindings/js/JavaScriptProfileNode.cpp: Added.
(WebCore::profileNodeCache):
(WebCore::getFunctionName):
(WebCore::getURL):
(WebCore::getLineNumber):
(WebCore::getTotalTime):
(WebCore::getSelfTime):
(WebCore::getNumberOfCalls):
(WebCore::getChildren):
(WebCore::getVisible):
(WebCore::getCallUID):
(WebCore::finalize):
(WebCore::ProfileNodeClass):
(WebCore::toJS):
* bindings/js/JavaScriptProfileNode.h: Added.
* inspector/JavaScriptProfile.cpp: Removed.
* inspector/JavaScriptProfile.h: Removed.
* inspector/JavaScriptProfileNode.cpp: Removed.
* inspector/JavaScriptProfileNode.h: Removed.
2010-02-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Elements Panel: Limit the number of initially loaded element children
https://bugs.webkit.org/show_bug.cgi?id=34421
Test: inspector/elements-panel-limited-children.html
* English.lproj/localizedStrings.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._insertChild):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit):
(WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit):
(WebInspector.ElementsTreeElement.prototype.get expandedChildCount):
(WebInspector.ElementsTreeElement.prototype.showChild):
(WebInspector.ElementsTreeElement.prototype.insertChildElement):
(WebInspector.ElementsTreeElement.prototype.moveChild):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
(WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren):
():
* inspector/front-end/inspector.css:
2010-02-16 Ismail Donmez <ismail@namtrac.org>
Reviewed by Pavel Feldman.
Fix compilation with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=32724
* rendering/RenderLayerBacking.cpp:
(WebCore::inspectorTimelineAgent):
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: turn off line wrapping in source view.
https://bugs.webkit.org/show_bug.cgi?id=34935
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.markAndRevealRange):
(WebInspector.TextViewer.prototype._paintLine):
* inspector/front-end/textViewer.css:
* inspector/front-end/utilities.js:
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: let search iterate over views in Resources
and keep the view in Scripts.
https://bugs.webkit.org/show_bug.cgi?id=34968
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
(WebInspector.Panel.prototype.showSourceLineForURL):
(WebInspector.Panel.prototype.searchIteratesOverViews):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.get _resources):
(WebInspector.ResourcesPanel.prototype.searchIteratesOverViews):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.showingLastSearchResult):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.focusSearchField):
2010-02-16 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] canvas clipping is buggy
https://bugs.webkit.org/show_bug.cgi?id=32405
Apparently the bug was in GraphicsContext::roundToDevicePixels, we
didn't take unto accounts rotation, so the device pixels were rounded
incorrectly. The new formula is a 1:1 copy from GraphicsContextCG so
it should be rather safe
Test: http://glimr.rubyforge.org/cake/canvas.html#Polaroids now looks right
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Copy the formula from
GraphicsContextCG
2010-02-16 Yury Semikhatsky <yurys@chromium.org>
Not Reviewed, build fix.
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::center): make conversion from float to int explicit so that compiler
doesn't complain about that.
2010-02-15 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout
Refine the fix for https://bugs.webkit.org/show_bug.cgi?id=34923 by using the center of
a quad’s bounding box, rather than its top left, as the reference point passed to
offsetFromContainer(). This ensures that if a sliver off the top of the selection rect is in
one column, but most of it is on another column, the single rect we return will be for the
second column.
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::center): Added.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localToContainerQuad): Use the center instead of the top left.
2010-02-15 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker
https://bugs.webkit.org/show_bug.cgi?id=34831
No new tests, no change of functionality.
* rendering/SVGCharacterLayoutInfo.h:
(WebCore::SVGTextChunkWalker::SVGTextChunkWalker):
Removed setupBackground(), setupFill(), setupFillSelection(),
setupStroke(), setupStrokeSelection(), setupForeground()
and associated member variables.
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::setupBackground):
renamed from chunkSetupBackgroundCallback.
(WebCore::SVGRootInlineBoxPaintWalker::setupFill):
renamed from chunkSetupFillCallback.
(WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection):
renamed from chunkSetupFillSelectionCallback.
(WebCore::SVGRootInlineBoxPaintWalker::setupStroke):
renamed from chunkSetupStrokeCallback.
(WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection):
renamed from chunkSetupStrokeSelectionCallback.
(WebCore::SVGRootInlineBoxPaintWalker::setupForeground):
renamed from chunkSetupForegroundCallback.
(WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
renamed from chunkPortionCallback.
(WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
extracted from walkTextChunks.
(WebCore::SVGRootInlineBox::paint):
follow SVGTextChunkWalker change.
(WebCore::SVGRootInlineBox::walkTextChunks):
moved paint some specific code to SVGRootInlineBoxPaintWalker::chunkPortionCallback().
2010-02-15 Dan Bernstein <mitz@apple.com>
Try to fix the Chromium build.
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::convertToPaintingRect):
2010-02-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags
PtrAndFlags has now been removed; remove forwarding header.
* ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 34952 - String lengths in UString should be unsigned.
This matches WebCore::StringImpl, and better unifies behaviour throughout JSC.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):
2010-02-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when going back to a page that has data: URIs, with page cache enabled
https://bugs.webkit.org/show_bug.cgi?id=34944
Set the URL in the newly created response, when parsing data:
URIs.
Test: fast/harness/page-cache-crash-on-data-urls.html
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::parseDataUrl):
2010-02-15 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7647300> Incorrect client rects for blocks the span multiple columns and their descendants
https://bugs.webkit.org/show_bug.cgi?id=34923
Test: fast/multicol/client-rects.html
In column layout, a different transform applies to different points in
the block and its descendants, depending on their y coordinate within the
block. offsetFromContainer() used to return the offset that applied to
the origin. With this change, it returns the offset that applies to a
given reference point. When mapping a quad from local to absolute
coordinates, the top left of the quad’s bounding box is used as that
reference point.
* editing/SelectionController.cpp:
(WebCore::SelectionController::layout): Pass the caret’s origin as the
reference point to offsetFromContainer().
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns): Adds the offset between the
given point and its image under the column paint-time transform to the
given offset. Used by offsetFromContainer() where it had previously used
adjustRectForColumns(), which takes a rect and operates less efficiently.
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer): Pass the transformed point as
the reference point to offsetFromContainer().
(WebCore::RenderBox::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().
(WebCore::RenderBox::offsetFromContainer): Use adjustForColumns() instead
of adjustRectForColumns(), and use the reference point to get the right
adjustment for the point of interest, instead of the origin, in case this
box spans multiple columns.
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::offsetFromContainer): Ditto. Actually apply the
column offset to the computation, which previously this function didn’t
do.
(WebCore::RenderInline::mapLocalToContainer): Pass the transformed point
as the reference point to offsetFromContainer().
(WebCore::RenderInline::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().
* rendering/RenderInline.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::mapLocalToContainer): Apply column adjustment,
based on the reference point, to the transform if needed.
(WebCore::RenderObject::localToContainerQuad): Initialize the
TransformState with the top left corner of the quad’s bounding box. It
is later used as the reference point when deciding on which column to
base the calculations.
(WebCore::RenderObject::offsetFromContainer): Adjust for columns.
(WebCore::RenderObject::offsetFromAncestorContainer): Pass the origin
as the reference point to offsetFromContainer().
* rendering/RenderObject.h:
(WebCore::RenderObject::adjustForColumns): Added.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::offsetFromContainer): Pass the reference
point through.
* rendering/RenderTableCell.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange): Map (the origin of) each
rect to absolute coordinates individually.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::convertToPaintingRect): Pass a point to
offsetFromContainer().
2010-02-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/7130641> Browser objects identity is not preserved by Safari
Test: plugins/netscape-browser-object-identity.html
* bridge/runtime_root.h: (JSC::Bindings::RootObject::addInvalidationCallback):
RootObject can now call out during invalidation, making it possible for other code to know
when this happens.
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::InvalidationCallback::~InvalidationCallback): Empty destructor,
in cpp file since it's virtual.
(JSC::Bindings::RootObject::invalidate): Invoke invalidation callbacks.
* bridge/NP_jsobject.cpp:
(ObjectMap): Keep a JSObject->NPObject map for each RootObject. It somewhat cleaner to
keep it outside RootObject, because (1) it is agnostic of what kinds of objects can wrap
JSObject, and (2) out of process NPAPI implementation also keeps its corresponding map
separately, due to supporting per-instance granularity (as opposed to per-RootObject here).
(jsDeallocate): Remove the corresponding map entry.
(_NPN_CreateScriptObject): Try to fetch existing object from the map, incrementing refcount.
2010-02-15 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
Removed redefine of LOG_VERBOSE. This should not have commited in
the first place.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2010-02-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: incorrect syntax highlighting as HTML in a script tag.
We were preserving initial lexer state upon entering other tags while in <script>
but were not doing it for <script tag itself. As a result, nested script
tags were failing to highlight.
https://bugs.webkit.org/show_bug.cgi?id=34934
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
2010-02-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
Add a progress-indicator logging channel to WebCore, and convert the old WebKit Logging
messages over to WebCore-style.
No new tests. (Logging changes only)
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
* platform/Logging.cpp:
(WebCore::):
(WebCore::getChannelFromName):
* platform/Logging.h:
2010-02-15 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
https://bugs.webkit.org/show_bug.cgi?id=34901
When a signal/slot/property is of type QWebElement, it can seamlessly
connect with JS objects that hold a WebCore element.
New tests, see WebKit/qt/ChangeLog
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtWebElementRuntime::create): A proxy to QWebElement
constructor
(JSC::Bindings::QtWebElementRuntime::get): A proxy to
QWebElement::element
(JSC::Bindings::convertValueToQVariant): handle QWebElement
(JSC::Bindings::convertQVariantToValue): handle QWebElement
2010-02-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, Chromium build fix (force conversion of property names to
strings in Web Inspector's injected script).
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
2010-02-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touch InspectorController in order to kick win bot tests
with new injected script contents.
* inspector/InspectorController.cpp:
2010-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: highlight actual search match in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=34251
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
* inspector/front-end/InjectedScript.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.findSearchMatches):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._paintLine):
* inspector/front-end/textViewer.css:
* inspector/front-end/utilities.js:
2010-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: XPathResult objects are not expanded in console.
https://bugs.webkit.org/show_bug.cgi?id=34926
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(WebInspector.ObjectPropertiesSection.CompareProperties):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/Section.js:
(WebInspector.Section):
* inspector/front-end/inspector.css:
2010-02-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] wrong video aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=34790
Fixed natural size calculation regarding pixel aspect ratio and
display aspect ratio.
Test: media/video-display-aspect-ratio.html
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::greatestCommonDivisor):
(WebCore::MediaPlayerPrivate::naturalSize):
2010-02-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HTML5 iframe sandbox bypass of window.top.location navigation via <form target="_top">
https://bugs.webkit.org/show_bug.cgi?id=33277
submitForm wasn't respecting shouldAllowNavigation. Instead of calling
the wrapper function, we need to call shouldAllowNavigation because we
need to handle the "frame not found" case differently than the
"navigation denied" case.
Test: http/tests/security/sandboxed-iframe-form-top.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
2010-02-14 Kent Tamura <tkent@chromium.org>
No review. Touch RenderRuny*.cpp to fix Chromium/Windows build bot.
* rendering/RenderRuby.cpp: Add a comment for #endf.
* rendering/RenderRubyBase.cpp: Add a comment for #endf.
* rendering/RenderRubyRun.cpp: Add a comment for #endf.
* rendering/RenderRubyText.cpp: Add a comment for #endf.
2010-02-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: cache created row, span and text elements
in TextView to improve scroller performance on debug build.
https://bugs.webkit.org/show_bug.cgi?id=34921
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.set visible):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype.freeCachedElements):
(WebInspector.TextViewer.prototype._buildChunks):
(WebInspector.TextViewer.prototype._makeLineAChunk):
(WebInspector.TextViewer.prototype._paintLine):
(WebInspector.TextViewer.prototype._releaseLines):
(WebInspector.TextViewer.prototype._appendSpan):
(WebInspector.TextViewer.prototype._appendTextNode):
(WebInspector.TextChunk):
(WebInspector.TextChunk.prototype.set expanded):
(WebInspector.TextChunk.prototype._lineNumberText):
(WebInspector.TextChunk.prototype._createRow):
2010-02-13 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Refactor parsing/serialization functions in HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=34852
- Rename formStringToDouble() to parseToDoubleForNumberType()
- Rename formStringToDateComponents() to parseToDateComponents()
- Rename formStringFromDouble() to serializeForNumberType()
- Add serializeForDateTimeTypes()
The code is moved from setValueAsDate() and setDateValue().
- Add serialize()
parseToDouble() is the top-level function to parse a
type-dependent string and return a double
value. parseToDoubleForNumber() and parseToDateComponents()
functions are helper functions for it. serialize() is the
top-level function to serialize a double value to a type-dependent
string, and serializeForNumberType() and
serializeForDateTimeTypes() are helper functions for it.
No tests because of no functional changes.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::parseToDouble):
(WebCore::HTMLInputElement::valueAsDate):
(WebCore::HTMLInputElement::setValueAsDate):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::serializeForDateTimeTypes):
(WebCore::HTMLInputElement::serialize):
(WebCore::HTMLInputElement::serializeForNumberType):
(WebCore::HTMLInputElement::parseToDoubleForNumberType):
(WebCore::HTMLInputElement::parseToDateComponents):
* html/HTMLInputElement.h:
* html/ValidityState.cpp:
(WebCore::ValidityState::typeMismatch):
* rendering/RenderSlider.cpp:
(WebCore::SliderRange::valueFromElement):
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::setValueForPosition):
2010-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
Improve text control intrinsic widths.
https://bugs.webkit.org/show_bug.cgi?id=25566
https://bugs.webkit.org/show_bug.cgi?id=25581
https://bugs.webkit.org/show_bug.cgi?id=25958
For Mac fonts that have invalid avgCharWidth entries in the OS/2 table,
fallback to the Safari 4- behavior of using the width of a zero. For other
fonts, make Mac match Windows (and thus IE) metrics.
Lucida Grande is hard-coded to match MS Shell Dlg for inputs and
Courier New for textareas in order to match Safari Win, Firefox and, in
some cases IE (IE uses different default fonts depending on encoding).
The only case where we still don't match Windows is if no font-size is
set. The default font-size for form controls on the Mac is smaller and
thus text-control widths will be slightly smaller.
No new tests. Covered by existing tests.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformCharWidthInit):
* rendering/RenderTextControl.cpp:
(WebCore::):
(WebCore::RenderTextControl::hasValidAvgCharWidth):
(WebCore::RenderTextControl::getAvgCharWidth):
(WebCore::RenderTextControl::calcPrefWidths):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::scaleEmToUnits):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::getAvgCharWidth):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
* rendering/RenderTextControlSingleLine.h:
2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unnecessary QBrush construction for doing a solid color stroke
https://bugs.webkit.org/show_bug.cgi?id=34874
Use the similar trick like in r54347, i.e. use the special brush for
solid color to avoid expensive QBrush constructor.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setPlatformStrokeColor):
2010-02-11 Darin Fisher <darin@chromium.org>
Reviewed by Jeremy Orlow.
Pass the Document along to the ChromiumBridge cookie methods.
https://bugs.webkit.org/show_bug.cgi?id=34878
* platform/chromium/ChromiumBridge.h:
* platform/network/chromium/CookieJarChromium.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
2010-02-12 Eric Seidel <eric@webkit.org>
No review, rolling out r54694.
http://trac.webkit.org/changeset/54694
https://bugs.webkit.org/show_bug.cgi?id=34633
This appears to have caused crashes on the Leopard bot. See
bug 34898.
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::didClose):
* websockets/WebSocketChannel.h:
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didClose):
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
* websockets/WorkerThreadableWebSocketChannel.h:
2010-02-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Workers' EventListeners should be removed before JSGlobalData is destroyed
https://bugs.webkit.org/show_bug.cgi?id=34903
(Patch co-developed with Alexey Proskuryakov).
Since http://trac.webkit.org/changeset/54460 the EventListeners registered by a
worker thread are not removed until after the thread's JSGlobalData has been
destroyed. This is slightly worrisome since the JSEventListener contains
JSObject*s, which will be dangling once the heap is destroyed. The
JSEventListeners may also reference the worker thread's normal world, which
again it makes no sense to keep around after the JSGlobalData is freed.
Remove all event listeners immediately prior to tearing down the JSGlobalData.
https://bugs.webkit.org/show_bug.cgi?id=34728 addressed the symptoms of this
problem, and it is probably cleaner to make the client data's normal world no
longer be a member (since it is a ref-counted object), however they should be
no requirement to 'detatch' – it makes no sense for anyone to be referencing
the world after the JSGlobalData has gone away (the world's purpose is to hold
wrapper objects in the JSGlobalData's heap). Keep the restructuring that makes
the normal world no longer be a member, but remove the detach mechanism this
patch added & replace with stronger ASSERTs.
* bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::~WebCoreJSClientData):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):
2010-02-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.
These break the OS X Leaks tool. Use a bits stolen from the refCount to hold the
'InTable' and 'HasTerminatingNullCharacter' flags, along with the string type
(fixes a leak where the string data is allocated at the address (this + 1), and is
misinterpreted as being an internal buffer).
* WebCore.base.exp:
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::createWithTerminatingNullCharacter):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
* platform/text/StringImpl.h:
(WebCore::StringImpl::):
(WebCore::StringImpl::hasTerminatingNullCharacter):
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::StringImpl::ref):
(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):
(WebCore::StringImpl::operator new):
(WebCore::StringImpl::bufferOwnership):
* storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::markDatabase):
2010-02-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Repaint bug on Text selection in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16939
Tests: svg/overflow/overflow-on-foreignObject.svg
svg/text/foreignObject-text-clipping-bug.xml
Selecting text contained in <foreignObject> leads to artefacts. Same for zooming/panning.
RenderForeignObject contained old legacy code returning FloatRect() for repaintRectInLocalCoordinates,
which is obviously wrong. Fixing that leads to even more problems, as the underlying RenderBlock
did not reflect the x/y translation set on the <foreignObject>. This is problematic, as laying out
positioned objects in the XHTML subtree depends on proper size/location values of the frameRect.
Correctly clip on overflow="hidden". overflow="scroll" & friends are not yet supported, see lengthy
comment in RenderSVGBlock why we either need RenderLayer for RenderForeignObject or need to rework
overflow handling to avoid RenderLayer.
SVGForeignObjectElement uses a hacky custom solution to synchronize CSS width/height properties with
the SVG width/height attributes. Remove all of that code and just implement calcWidth/calcHeight in
RenderForeignObject, grabbing the right values from SVGForeignObjectElement::width/height upon layout.
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::paint): Clip properly to the actual bounds of the foreignObject, respecting that x/y translation is handled by RenderBlock now.
(WebCore::RenderForeignObject::clippedOverflowRectForRepaint): Added missing function, forward to SVGRenderBase just like all other SVG renderers.
(WebCore::RenderForeignObject::computeRectForRepaint): Remove manual implementation, forward to SVGRenderBase.
(WebCore::RenderForeignObject::localToParentTransform): Respect x/y translation here _after_ applying localTransform().
(WebCore::RenderForeignObject::calcWidth): Override RenderBlock::calcWidth to grab width() from SVGForeignObjectElement.
(WebCore::RenderForeignObject::calcHeight): Override RenderBlock::calcHeight to grab height() from SVGForeignObjectElement.
(WebCore::RenderForeignObject::layout): Calculate viewport once and cache it. Push x/y location down to RenderBlock - analogous to RenderSVGText.
(WebCore::RenderForeignObject::nodeAtFloatPoint): Adapt to x/y translation changes (map through localTransform, not localToParentTransform). Respect overflow clipping.
(WebCore::RenderForeignObject::mapLocalToContainer): Set useTransforms=true, to avoid assertions when selecting text in foreign objects.
* rendering/RenderForeignObject.h:
(WebCore::RenderForeignObject::objectBoundingBox): Return cached m_viewport.
(WebCore::RenderForeignObject::strokeBoundingBox): Ditto.
(WebCore::RenderForeignObject::repaintRectInLocalCoordinates): Ditto.
* rendering/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::setStyle): Cleanup code, move setHasOverflowClip() overrides in updateBoxModelInfoFromStyle where it belongs.
(WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle): Added to force setting setHasOverflowClip(false).
* rendering/RenderSVGBlock.h:
* svg/SVGForeignObjectElement.cpp: Kill a lot of custom code - it was just plain wrong to utilize CSS to push width/height information down to RenderBlock.
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
2010-02-12 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7609268> REGRESSION (r50301): Problem selecting text in a Devanagari website
https://bugs.webkit.org/show_bug.cgi?id=34865
Test: fast/text/glyph-reordering.html
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): Added. Sets m_isMonotonic
and populates m_glyphEndOffsets with the end offsets of each glyph’s corresponding character range.
(WebCore::ComplexTextController::advance): For non-monotonic runs, use endOffsetAt() to get
glyphs’ end offsets.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Check for monotonicity and call
setIsNonMonotonic() if needed.
* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::lastIndexAt): Added this getter.
(WebCore::ComplexTextController::ComplexTextRun::isMonotonic): Ditto.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isMonotonic.
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
2010-02-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=34866
Leopard Debug Bot crashed on fast/forms/old-names.html
* html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Removed
a misplaced checkConsistency() call. We are not looking at cache content at this point, and
caches will be reset on next access.
2010-02-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: restore highlighting animation, bring back
keyboard navigation, beautify search results.
https://bugs.webkit.org/show_bug.cgi?id=34853
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype.highlightLine):
* inspector/front-end/textViewer.css:
2010-02-12 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] handle to the document can only own Objects, not Values
https://bugs.webkit.org/show_bug.cgi?id=34854
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentWrapper):
(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
* bindings/v8/V8DOMWindowShell.h:
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
2010-02-12 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Replaced stray CRLF with LF.
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::suggestedValue):
* wml/WMLInputElement.h:
2010-02-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Make qtlauncher and qgvlauncher use the generated headers
path to make sure they are correctly generated.
* WebCore.pro:
2010-02-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Ensure relative paths in generated .pri files to ensure that
a source package with pre-generated derived sources can be compiled.
- Re-add a separate headers.pri file for WEBKIT_API_HEADERS
- Rename the generated headers.pri to classheaders.pri to avoid
confusion with the one generated by synqt since they don't have the
same content.
- Remove private headers list variable from classheaders.pri
- Use $$PWD in classheaders.pri
- Remove classheaders.pri from the installed files
* WebCore.pro:
2010-02-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Manually add support for the install target on Symbian.
This is required to copy the headers over the ones in Qt.
* WebCore.pro:
2010-02-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Minor fixes on QtWebKit headers generation.
- Adds QtWebKit to the generated headers destination path
- Improve compatibility with MinGW
* WebCore.pro:
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289
Test: websocket/tests/cookies/httponly-cookie.pl
* platform/CookieJar.h: add cookieRequestHeaderFieldValue()
* platform/chromium/ChromiumBridge.h:
* platform/haiku/CookieJarHaiku.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/mac/CookieJar.mm:
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
* platform/network/android/CookieJarAndroid.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/network/chromium/CookieJarChromium.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/network/curl/CookieJarCurl.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/network/win/CookieJarCFNetWin.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/network/win/CookieJarWin.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* platform/qt/CookieJarQt.cpp:
(WebCore::cookieRequestHeaderFieldValue):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage): use cookieRequestHeaderFieldValue() instead of cookies() to include HttpOnly cookies.
2010-02-16 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha Silva.
Notify about size changes in the WebKit GStreamer source.
https://bugs.webkit.org/show_bug.cgi?id=34881
* platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(StreamingClient::didReceiveResponse):
* platform/graphics/gtk/WebKitWebSourceGStreamer.h:
This makes sure that other GStreamer elements know about the
size and on-disk buffering actually works.
Only notify about size changes if gst-plugins-base before
0.10.27 is used, because from that version onwards this is
automatically handled.
If appsrc 0.10.27 or later is used, set the min-percent property
to 20% to allow more time to pass between the need-data signal
and starvation of the pipeline.
Also reset the size when stopping the source and send EOS
on seeking failures.
2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use clipRegion instead of clipPath to save lots of CPU cycles.
https://bugs.webkit.org/show_bug.cgi?id=32375
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
2010-02-11 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
https://bugs.webkit.org/show_bug.cgi?id=34877
Also fix whitespace erros that surface due to the above fix.
This doesn't change the code logic. Hence no new tests are required.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
2010-02-11 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Focusing a resource in the inspector should default to content not header
https://bugs.webkit.org/show_bug.cgi?id=34861
* inspector/front-end/Settings.js:
(WebInspector.Settings.prototype._load): changed initial default to content tab
2010-02-11 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item
https://bugs.webkit.org/show_bug.cgi?id=34872
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.update): triggers afterUpdate
(WebInspector.StylePropertiesSection.prototype.afterUpdate): factored out _afterUpdate handling
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Add roundedIntSize() convenience method converting FloatSize to IntSize, just like roundedIntPoint() converting FloatPoint to IntPoint.
* platform/graphics/FloatSize.h:
(WebCore::roundedIntSize):
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783
- ValidityState.tooLong behavior was inconsistent with UIs of
<input> and <textarea>. tooLong checked Unicode code point length
though the UIs checks grapheme cluster length.
- Setting HTMLTextAreaElement::value didn't update the dirty flag.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::tooLong): Use numGraphemeClusters() instead of length().
* html/HTMLTextAreaElement.cpp:
Rename setValue() to setNonDirtyValue(), and introduce setValue()
which calls setNonDirtyValue() and sets the dirty flag.
(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::reset):
(WebCore::HTMLTextAreaElement::setValue):
(WebCore::HTMLTextAreaElement::setNonDirtyValue):
(WebCore::HTMLTextAreaElement::setDefaultValue):
(WebCore::HTMLTextAreaElement::tooLong): Use numGraphemeClusters() instead of length().
* html/HTMLTextAreaElement.h:
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
Test: websocket/tests/bufferedAmount-after-close.html
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::didClose):
* websockets/WebSocketChannel.h:
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didClose):
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
* websockets/WorkerThreadableWebSocketChannel.h:
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785
Tests: websocket/tests/workers/close-in-shared-worker.html
websocket/tests/workers/close-in-worker.html
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::close):
2010-02-11 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Cursor
https://bugs.webkit.org/show_bug.cgi?id=34672
* platform/brew/CursorBrew.cpp: Added.
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::dummyCursor):
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::moveCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
2010-02-11 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Add back in a fast path for v8 object wrapping
when it's not possible we're in a WorkerContext (the fast
path is important for performance).
https://bugs.webkit.org/show_bug.cgi?id=34805
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8ObjectInWorkerContext):
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8DOMWrapper.h:
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Small cleanups in SVG render tree code.
Centralize calls to inflateShadow(), in SVGRenderSupport::computeRectForRepaint,
instead of spreading them around the subclasses. All classes should inherit
protected from SVGRenderBase, made it consistent.
Doesn't affect layout tests.
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::computeRectForRepaint):
* rendering/RenderSVGImage.h:
* rendering/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeRectForRepaint):
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::layout):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::computeRectForRepaint):
* rendering/SVGRootInlineBox.h:
2010-02-11 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=34857
Move InlineIterator and BidiRun into new files so subclasses can access them.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/BidiRun.cpp: Added.
(WebCore::BidiRun::destroy):
(WebCore::throw):
(WebCore::BidiRun::operator delete):
* rendering/BidiRun.h: Added.
(WebCore::BidiRun::BidiRun):
(WebCore::BidiRun::next):
* rendering/InlineIterator.h: Added.
(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::atEnd):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::direction):
(WebCore::InlineBidiResolver::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::requiresLineBox):
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
https://bugs.webkit.org/show_bug.cgi?id=34836
setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
which in turn uses toV8() with the indexer type, which is declared in
the header for the indexer type.
No new tests, build fix only.
* bindings/scripts/CodeGeneratorV8.pm:
2010-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: split source code into chunks in order to improve text
viewer performance on large files.
https://bugs.webkit.org/show_bug.cgi?id=34816
This change brings back SourceFrame's canvas+style magic, restores line
wrapping and makes things a lot like they used to be.
It removes TextEditor for now and renames NativeTextViewer into TextViewer.
TextViewer is no longer derived from TextEditor.
This TextViewer is still based on TextEditorModel, no iframes are involved.
Instead of creating div per line, TextViewer splits source code into 50 line
chunks. Upon scroll event, visible chunks are sharded into lines and individual
lines are highlighted. Whenever highlighted region gets outside of the visible
area, highlight spans are thrown away and region is replaced with the original
plain text chunk.
Complex stuff:
- Whenever there is a need to manipulate individual lines (add message bubble /
set breakpoint / reveal / etc.), individual chunks for such lines are created.
- There is also an implicit machinery that is maintaining selection when it
goes beyond the visible area.
- Search occurrences are implemented as artificial spans interweaving
highlighting markup.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/NativeTextViewer.js: Removed.
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype.set executionLine):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype.removeBreakpoint):
(WebInspector.SourceFrame.prototype.addMessage):
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.sizeToFitContentHeight):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype.markAndRevealRange):
(WebInspector.SourceFrame.prototype.clearMarkedRange):
(WebInspector.SourceFrame.prototype._breakpointChanged):
(WebInspector.SourceFrame.prototype._updateExecutionLine):
(WebInspector.SourceFrame.prototype._addMessageToSource):
(WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
(WebInspector.SourceFrame.prototype._createConditionElement):
(WebInspector.SourceFrame.prototype._keyDown):
(WebInspector.SourceFrame.prototype.resize):
(WebInspector.SourceFrame.prototype._drawProgramCounterInContext):
(WebInspector.SourceFrame.prototype._drawProgramCounterImageIfNeeded):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype._removeBreakpoint):
(WebInspector.SourceView.prototype.searchCanceled):
(WebInspector.SourceView.prototype._jumpToSearchResult):
* inspector/front-end/TextEditor.js: Removed.
* inspector/front-end/TextViewer.js: Added.
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype.set mimeType):
(WebInspector.TextViewer.prototype.get textModel):
(WebInspector.TextViewer.prototype.revealLine):
(WebInspector.TextViewer.prototype.addDecoration):
(WebInspector.TextViewer.prototype.removeDecoration):
(WebInspector.TextViewer.prototype.markAndRevealRange):
(WebInspector.TextViewer.prototype.highlightLine):
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextViewer.prototype._createChunkRow):
(WebInspector.TextViewer.prototype._makeLineAChunk):
(WebInspector.TextViewer.prototype._indexChunks):
(WebInspector.TextViewer.prototype._highlightChanged):
(WebInspector.TextViewer.prototype._scroll):
(WebInspector.TextViewer.prototype.setCoalescingUpdate):
(WebInspector.TextViewer.prototype._repaintAll):
(WebInspector.TextViewer.prototype._chunkForOffset):
(WebInspector.TextViewer.prototype._chunkNumberForLine):
(WebInspector.TextViewer.prototype._chunkStartLine):
(WebInspector.TextViewer.prototype._restoreChunks):
(WebInspector.TextViewer.prototype._repaint):
(WebInspector.TextViewer.prototype._getSelection):
(WebInspector.TextViewer.prototype._restoreSelection):
(WebInspector.TextViewer.prototype._selectionToPosition):
(WebInspector.TextViewer.prototype._createLineRow):
(WebInspector.TextViewer.prototype._paintLine):
(WebInspector.TextViewer.prototype._createSpan):
(WebInspector.TextViewer.prototype._createLink):
(WebInspector.TextViewer.prototype._rewriteHref):
(WebInspector.TextViewer.prototype._markRange):
(WebInspector.TextViewer.prototype._decimalDigits):
(WebInspector.TextViewer.prototype.resize):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
* inspector/front-end/textEditor.css: Removed.
* inspector/front-end/textViewer.css: Added.
* inspector/front-end/utilities.js:
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
2010-02-11 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] ENABLE_RUBY flag was restored by r54649, but default value wasn't added for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=34698
* WebCore.pri: Add ENABLE_RUBY=1 as default setting.
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 Makefile to generate Notifications and WebSockets headers required by V8DOMWrapper.cpp
https://bugs.webkit.org/show_bug.cgi?id=34815
No new tests, build fix only.
* Android.derived.v8bindings.mk:
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 Makefile to generate XPath header required by V8Proxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=34814
No new tests, build fix only.
* Android.derived.v8bindings.mk:
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Update Android V8 Makefile to generate Inspector headers required by V8 ScriptObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=34806
No new tests, build fix only.
* Android.derived.v8bindings.mk:
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Guards SVG code in V8 bindings with ENABLE(SVG)
https://bugs.webkit.org/show_bug.cgi?id=34812
Also updates Android V8 Makefile to generate required SVG headers.
No new tests, build fix only.
* Android.derived.v8bindings.mk:
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore::toV8):
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* html/HTMLTagNames.in: Make the ruby-related tag names conditional.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject): ifdef the code that would create ruby elements.
* rendering/RenderObject.h: ditto above
* rendering/RenderRuby.cpp: ifdef this whole file
* rendering/RenderRuby.h: ditto
* rendering/RenderRubyBase.cpp: ditto
* rendering/RenderRubyBase.h: ditto
* rendering/RenderRubyRun.cpp: ditto
* rendering/RenderRubyRun.h: ditto
* rendering/RenderRubyText.cpp: ditto
* rendering/RenderRubyText.h: ditto
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Step attribute support for date&time types.
https://bugs.webkit.org/show_bug.cgi?id=30847
- Add implementation for ValidityState.stepMismatch, stepUp() and
stepDown() for date, datetime, datetime-local, month, time, week types.
- Fix string representation of DateComponents.
Tests: fast/forms/ValidityState-stepMismatch.html
fast/forms/input-stepup-stepdown.html
* html/HTMLInputElement.cpp:
- Change monthDefaultMaximum so that DateComponents::m_year doesn't overflow.
(WebCore::HTMLInputElement::stepBase):
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::getStepParameters):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::applyStep):
Renamed from applyStepForNumberOrRange(), and add support for other types.
(WebCore::HTMLInputElement::stepUp): Rename applyStepForNumberOrRange().
(WebCore::HTMLInputElement::stepDown): Rename applyStepForNumberOrRange().
(WebCore::HTMLInputElement::setValueAsDate): Use setDateValue().
(WebCore::HTMLInputElement::setDateValue):
A helper function to make the best representation of DateComponents.
(WebCore::HTMLInputElement::setValueAsNumber): Use setDateValue().
* html/HTMLInputElement.h:
2010-02-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
postMessage does not send ImageData
https://bugs.webkit.org/show_bug.cgi?id=34825
Implement serialisation of ImageData, and for testing reasons
expose the ImageData constructor (which should already have
been exposed).
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedImageData::create):
(WebCore::SerializedImageData::width):
(WebCore::SerializedImageData::height):
(WebCore::SerializedImageData::data):
(WebCore::SerializedImageData::SerializedImageData):
(WebCore::SerializedScriptValueData::SerializedScriptValueData):
(WebCore::SharedSerializedData::asImageData):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::convertIfTerminal):
(WebCore::TeardownTreeWalker::convertIfTerminal):
* bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValueData::):
(WebCore::SerializedScriptValueData::asImageData):
* html/canvas/CanvasPixelArray.h:
(WebCore::CanvasPixelArray::data):
* page/DOMWindow.idl:
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Address last round of review comments on r53607
https://bugs.webkit.org/show_bug.cgi?id=33940
Mostly renaming and cleaning up.
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::createInline):
* css/StyleBase.cpp:
(WebCore::StyleBase::baseURL):
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
* css/StyleSheet.h:
(WebCore::StyleSheet::href):
(WebCore::StyleSheet::setFinalURL):
(WebCore::StyleSheet::finalURL):
* dom/Document.cpp:
(WebCore::Document::updateBaseURL):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::loadSheet):
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::create):
(WebCore::XSLStyleSheet::createInline):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::parseString):
(WebCore::XSLStyleSheet::loadChildSheets):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
2010-02-10 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsLayer: somtimes the item flickers at the end of an animation
This is because we try to delete the animation when finished: that is
unnecessary. WebCore manages the animation's lifecycle and makes sure
to call the right function when the animation can be deleted.
https://bugs.webkit.org/show_bug.cgi?id=34761
No new tests.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQt::addAnimation): No need to delete here
(WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater
2010-02-10 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for wxMac/Cocoa.
* platform/wx/wxcode/mac/carbon/fontprops.cpp: Removed.
* platform/wx/wxcode/mac/carbon/fontprops.mm: Copied from WebCore/platform/wx/wxcode/mac/carbon/fontprops.cpp.
* wscript:
2010-02-10 Jon Honeycutt <jhoneycutt@apple.com>
REGRESSION(24929): PDF page doesn't load in background tab
Reviewed by Dan Bernstein.
* plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList):
Only delay loading of the plug-in if we'll kick off our own load of the
plug-in data later, in start().
2010-02-10 Enrica Casucci <enrica@apple.com>
Reviewed by Simon Fraser.
Crash in WebKit!WebCore::RenderTextControlSingleLine::createInnerTextStyle doing anything in Safari after sitting on a page with 3D site
<rdar://problem/7557201>
https://bugs.webkit.org/show_bug.cgi?id=34823
No tests added because the code is exercised by the existing tests.
The root cause was the fact that we were not releasing a reference that was held by CA.
In debug builds we had an assert in the destructor of WKCACFLayer.
* platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::~GraphicsLayerCACF):
2010-02-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Typedef DragImageRef
https://bugs.webkit.org/show_bug.cgi?id=34791
Use IImage* as it is the BREW's image type.
* platform/DragImage.h:
2010-02-10 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser and Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating
SVGMaskElement is the only class that keeps a HashMap of canvas
resources rather than just a pointer to a resource. This
patch makes SVGMaskElement invalidate all of its resources in the
HashMap instead of just one.
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
(WebCore::SVGMaskElement::invalidateCanvasResources):
* svg/SVGMaskElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
(WebCore::SVGStyledElement::invalidateCanvasResources):
* svg/SVGStyledElement.h:
2010-02-10 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
Fixes to rect conversion and image rendering on Haiku
https://bugs.webkit.org/show_bug.cgi?id=34684
Covered by existing tests.
The changes to the rect conversions are indeed correct. In Haiku (to stay
compatibly with BeOS), a BRect specifies the left/top and bottom/right pixel
*indices*, even though the values are floating point. So a rectangle covering
just one pixel would be specified as BRect(0, 0, 0, 0). In WebCore and other
frame works, such rectangles would be expressed as 0, 0, 1, 1. In WebCore, the
width and height of rectangles refer to the distance between pixels, while on
Haiku, a one pixel rect has indeed a width and height of 0, as confusing as
that may be.
The part of the patch that affects
WebCore/platform/graphics/haiku/ImageHaiku.cpp also implements the drawing
methods more correctly. Image observers are notified, and pattern drawing takes
the "phase" into account which makes scrolled backgrounds render correctly.
Transformations are still not supported, since the Haiku drawing backend itself
does not yet support them.
Use OwnPtr when creating the BBitmap to avoid future leaks with early returns.
Convert the bitmap data to non pre-multiplied until Haiku supports drawing
pre-multiplied bitmaps.
* platform/graphics/haiku/FloatRectHaiku.cpp: Fixed conversion
* platform/graphics/haiku/ImageHaiku.cpp:
(WebCore::BitmapImage::draw): Fixed placement, notify observers
(WebCore::Image::drawPattern): Implemented using "phase" to fix scrolling, notify observers
* platform/graphics/haiku/IntRectHaiku.cpp: Fixed conversion
* platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Fixed conversion
2010-02-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Levin.
Clean up unused member var and initialization in Document
https://bugs.webkit.org/show_bug.cgi?id=34820
Remove unused m_secureForms member variable in Document.
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
2010-02-10 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Add Windows complex text support and Mac support for containsCharacters.
https://bugs.webkit.org/show_bug.cgi?id=34759
* platform/graphics/SimpleFontData.h:
* platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::roundsGlyphAdvances):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::hfont):
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::platformWidthForGlyph):
(WebCore::SimpleFontData::scriptFontProperties):
(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformCommonDestroy):
(WebCore::SimpleFontData::widthForGDIGlyph):
* platform/wx/wxcode/fontprops.h:
* platform/wx/wxcode/gtk/fontprops.cpp:
(wxFontContainsCharacters):
* platform/wx/wxcode/mac/carbon/fontprops.cpp:
(wxFontContainsCharacters):
* platform/wx/wxcode/win/fontprops.cpp:
(wxFontContainsCharacters):
* platform/wx/wxcode/win/non-kerned-drawing.cpp:
(WebCore::drawTextWithSpacing):
* wscript:
2010-02-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Frame::dragImageForSelection
https://bugs.webkit.org/show_bug.cgi?id=34792
Add FrameBrew.cpp which contains a dummy implementation of
Frame::dragImageForSelection.
* page/brew/FrameBrew.cpp: Added.
(WebCore::Frame::dragImageForSelection):
2010-02-10 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix. Switch drawPattern to Image class like other platforms.
* platform/graphics/BitmapImage.h:
* platform/graphics/wx/ImageWx.cpp:
(WebCore::Image::drawPattern):
2010-02-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
Added CA_PRINT_TREE functionality to WKCACFLayer implementation
https://bugs.webkit.org/show_bug.cgi?id=34779
I've tried to duplicate the look of the output on Mac, but
it's not quite the same. It shows all the useful information though.
It is enabled by setting the environment variable CA_PRINT_TREE=1
* platform/graphics/win/WKCACFLayer.cpp:Implementation of printTree
(WebCore::WKCACFLayer::isTransformLayer):
Moved function to cpp file because it needs to use the function form
of kCACFTransformLayer because the DLL is delay loaded, and that function
can only be called from the cpp file.
(WebCore::WKCACFLayer::sublayerAtIndex):
(WebCore::printIndent):
(WebCore::printTransform):
(WebCore::WKCACFLayer::printTree):Prints from this layer down
(WebCore::WKCACFLayer::printLayer):Prints this layer and recursively calls sublayers
* platform/graphics/win/WKCACFLayer.h:
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::createRenderer):Adds a name to the root layers
(WebCore::WKCACFLayerRenderer::render):Calls printTree when CA_PRINT_TREE is 1
* platform/graphics/win/WKCACFLayerRenderer.h:
2010-02-10 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Change V8DOMWrapper::lookupDOMWrapper() and configureTemplate()
to not use V8ClassIndex.
https://bugs.webkit.org/show_bug.cgi?id=34768
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
2010-02-10 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Handle the possibility that ScheduledAction::execute() may
retrieve a null V8Proxy* even if not in a WorkerContext (e.g., if
JS was disallowed).
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
Test: fast/canvas/webgl/viewport-unchanged-upon-resize.html
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::reshape):
2010-02-10 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement image interpolation quality.
https://bugs.webkit.org/show_bug.cgi?id=34629
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
2010-02-10 Eric Seidel <eric@webkit.org>
No review, Mac build fix.
Crash in Flash at http://www.cctv.com/
https://bugs.webkit.org/show_bug.cgi?id=34673
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::getValueStatic):
2010-02-10 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
When unsetting the adjustments from a ScrollView, also disconnect
them from the Scrollbars.
Test: fast/frames/frame-crash-with-page-cache.html
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::~ScrollbarGtk):
(ScrollbarGtk::detachAdjustment):
* platform/gtk/ScrollbarGtk.h:
2010-02-09 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34490
WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
Test: fast/images/destroyed-image-load-event.html
* ForwardingHeaders/wtf/ValueCheck.h: Added.
* loader/ImageLoader.cpp:
(WTF::ValueCheck): Special case value check for ImageLoader - it's allocated inside elements,
so check the owner instead.
(WebCore::ImageEventSender::hasPendingEvents): Added a debugging aid for ImageLoader destructor.
(WebCore::ImageLoader::~ImageLoader): Assert that we're not going to leave dangling pointers
in ImageEventSender.
(WebCore::ImageLoader::setImage): Cancel events that could be dispatched for the previous
image. The only client using this method that I could find was DeleteButton, which doesn't
care about load events for the new image, so I didn't add any code for firing those.
(WebCore::ImageLoader::setLoadingImage): This method only existed to confuse readers -
there wasn't any meaningful code shared (callers just undid most assignments made there).
Merged the logic into callers.
(WebCore::ImageLoader::updateFromElement): We're forgetting the old image, so forget its
old events, too.
(WebCore::ImageLoader::notifyFinished): This can be called from setImage(), in which case
no one is going to dispatch the event "soon". So, don't queue it.
(WebCore::ImageEventSender::dispatchPendingEvents): Call checkConsistency(). This didn't
help catch this particuar bug, but seems like a useful check anyway.
* loader/ImageLoader.h: Removed setLoadingImage().
2010-02-10 Jon Honeycutt <jhoneycutt@apple.com>
Mac build fix. Unreviewed.
* WebCore.xcodeproj/project.pbxproj:
Add PluginViewNone.cpp to the Mac project.
2010-02-10 Adam Roben <aroben@apple.com>
Optimize ImageBuffer::toDataURL's CG implementation
There was some unused code that could have been removed in r31830 when
this function was changed not to flip the CG image anymore.
Fixes <http://webkit.org/b/34808> ImageBuffer::toDataURL allocates
unnecessary memory under CoreGraphics
Reviewed by Sam Weinig.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Don't allocate an unused CGImageRef
and buffer, and switch to the new overload of base64Encode that
doesn't require us to copy all the image data into a Vector first.
* platform/text/Base64.cpp:
(WebCore::base64Encode):
* platform/text/Base64.h:
Added an overload that takes a raw data pointer and length, just like
we have for base64Decode. The overload that takes a Vector as input
just calls through to the new overload.
2010-02-10 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
Complete the fix for <rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546
* manual-tests/drag-image-table-part-decorations.html:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint): Don’t paint collapsed borders if this object shouldn’t
paint within the current painting root.
2010-02-08 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7436875> Crash in Flash when visiting
http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
Reviewed by Darin Adler.
Test: platform/win/plugins/plugin-delayed-destroy.html
* bridge/NP_jsobject.cpp:
(_NPN_Evaluate):
If Flash calls this to evaluate a script that destroys the PluginView,
we crash when returning to Flash code. Before evaluating the script,
call PluginView::keepAlive() to hold a ref to this instance (and release
it asynchronously).
* plugins/PluginView.cpp:
(WebCore::instanceMap):
Return a map from the NPP to the PluginView.
(WebCore::PluginView::~PluginView):
Assert that the keep alive timer is not running; remove ourselves from
the instance map.
(WebCore::PluginView::performRequest):
The parent Frame is now a RefPtr; use .get().
(WebCore::PluginView::status):
Ditto.
(WebCore::PluginView::didReceiveResponse):
Ditto.
(WebCore::PluginView::PluginView):
Add the view to the instance map.
(WebCore::PluginView::lifeSupportTimerFired):
Deref the PluginView.
(WebCore::PluginView::keepAlive):
Ref the PluginView, then start a time to release the reference
asynchronously.
(WebCore::PluginView::keepAlive):
Find the PluginView in the map, and call its keepAlive() function.
* plugins/PluginView.h:
Made m_parentFrame a RefPtr, so that it will remain valid when the
keep alive timer fires.
(WebCore::PluginView::parentFrame):
Use .get().
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
Use .get().
(WebCore::PluginView::handleKeyboardEvent):
Use .get().
(WebCore::PluginView::handleMouseEvent):
Use .get().
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::keepAlive):
Stubbed.
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Mac port.
* WebCore.base.exp:
2010-02-10 Jeremy Orlow <jorlow@chromium.org>
Revert 54599 because it breaks a lot of tests on Windows Chrome
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._insertChild):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
():
* inspector/front-end/inspector.css:
2010-02-10 Adam Roben <aroben@apple.com>
Fix bad paths in WebCore.vcproj
These were harmless in VS2005, but cause project conversion errors in
VS2010 RC.
Fixes <http://webkit.org/b/34801>.
Reviewed by Dan Bernstein.
* WebCore.vcproj/WebCore.vcproj: Removed leading "." from paths to
JSHTMLFrameSetElement.{cpp,h}.
2010-02-10 Julien Chaffraix <jchaffraix@webkit.org>
Not reviewed (build fix).
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont): Return a
SimpleFontData here.
2010-02-10 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Eric Seidel.
Bug 23287 - Avoid using FontPlatformData outside the FontCache
No functional change, only refactored the code using FontPlatformData to use SimpleFontData.
This change leaves the class FontCached as it needs some thoughts and more refactoring.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Call getCachedFontData with the 2 parameters directly.
* css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily): Ditto.
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontData): This method is meant to replace getCachedFontPlatformData
that was moved in the private section of the class. It calls getCachedFontPlatformData and cache
the returned FontPlatformData if it is not null.
(WebCore::FontCache::getFontData): Updated to use the new getCachedFontData.
* platform/graphics/FontCache.h: Updated several methods to return a SimpleFontData in lieu of a
FontPlatformData. Moved some method in the private sections.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wince/FontCacheWince.cpp:
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
Updated all the previous platform methods to return a SimpleFontData.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getSimilarFontPlatformData): Updated to return a SimpleFontData.
(WebCore::FontCache::getLastResortFallbackFont): Ditto. Also refactored the code
and moved a DEFINE_STATIC_LOCAL where it is needed.
2010-02-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Elements Panel: Limit the number of initially loaded element children
https://bugs.webkit.org/show_bug.cgi?id=34421
Test: inspector/elements-panel-limited-children.html
* English.lproj/localizedStrings.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._insertChild):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit):
(WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit):
(WebInspector.ElementsTreeElement.prototype.get expandedChildCount):
(WebInspector.ElementsTreeElement.prototype.showChild):
(WebInspector.ElementsTreeElement.prototype.insertChildElement):
(WebInspector.ElementsTreeElement.prototype.moveChild):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
(WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren):
():
* inspector/front-end/inspector.css:
2010-02-10 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Remove several #if USE(JSC) branches. Introduce ScriptDebugServer class for
making JavaScriptDebugServer engine-agnostic.
https://bugs.webkit.org/show_bug.cgi?id=34795
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/ScriptDebugServer.cpp: Added.
(WebCore::ScriptDebugServer::recompileAllJSFunctions):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
* bindings/js/ScriptDebugServer.h: Added.
* bindings/v8/ScriptDebugServer.cpp: Added.
(WebCore::ScriptDebugServer::recompileAllJSFunctions):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
* bindings/v8/ScriptDebugServer.h: Added.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
* page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
2009-10-06 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().
Will be reverted when the following winscw compiler bug is fixed.
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
https://bugs.webkit.org/show_bug.cgi?id=28054
* bridge/jni/jsc/JavaInstanceJSC.h:
* bridge/jni/v8/JavaInstanceV8.h:
2010-02-10 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
https://bugs.webkit.org/show_bug.cgi?id=34667
* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.cpp: Added.
(WebCore::RuntimeEnabledFeatures::audioEnabled):
(WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled):
(WebCore::RuntimeEnabledFeatures::mediaErrorEnabled):
(WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled):
(WebCore::RuntimeEnabledFeatures::webSocketEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
* bindings/generic/RuntimeEnabledFeatures.h: Added.
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
(WebCore::RuntimeEnabledFeatures::localStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
(WebCore::RuntimeEnabledFeatures::geolocationEnabled):
(WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/RuntimeEnabledFeatures.cpp: Removed.
* bindings/v8/RuntimeEnabledFeatures.h: Removed.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8NavigatorCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
2010-02-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add two basic categories for the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=32930
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/AuditCategories.js: Added.
(WebInspector.AuditCategories.PagePerformance):
(WebInspector.AuditCategories.PagePerformance.prototype.initialize):
(WebInspector.AuditCategories.NetworkUtilization):
(WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype.show):
* inspector/front-end/AuditRules.js: Added.
(WebInspector.AuditRules.arrayAsUL):
(WebInspector.AuditRules.getDomainToResourcesMap):
(WebInspector.AuditRules.evaluateInTargetWindow):
(WebInspector.AuditRules.GzipRule):
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.CombineJsResourcesRule):
(WebInspector.AuditRules.CombineCssResourcesRule):
(WebInspector.AuditRules.MinimizeDnsLookupsRule):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule):
(WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedStylesheetRatioMessage):
(WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedTotalRatioMessage):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule):
(WebInspector.AuditRules.CacheControlRule.prototype.InfoCheck.1.FailCheck.0.WarningCheck.1.SevereCheck.2.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
(WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
(WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.ImageDimensionsRule):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasDimension):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasWidth):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasHeight):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine):
(WebInspector.AuditRules.CssInHeadRule):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine.allViews):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine):
(WebInspector.AuditRules.StylesScriptsOrderRule):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine):
(WebInspector.AuditRules.CookieRuleBase):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule):
(WebInspector.AuditRules.CookieSizeRule.prototype._average):
(WebInspector.AuditRules.CookieSizeRule.prototype._max):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies.avgSizeSorter):
(WebInspector.AuditRules.StaticCookielessRule):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._constructCategories):
(WebInspector.AuditsPanel.prototype._reloadResources):
(WebInspector.AuditsPanel.prototype.show):
(WebInspector.AuditsPanel.prototype._updateLauncherViewControls):
(WebInspector.AuditCategory):
(WebInspector.AuditCategory.prototype.get id):
(WebInspector.AuditCategory.prototype.get ruleCount):
(WebInspector.AuditCategory.prototype.runRules):
(WebInspector.AuditCategory.prototype._ensureInitialized):
(WebInspector.AuditCategoryResult):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/audits.css:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.addPanelToolbarIcon):
(WebInspector.documentKeyDown):
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184
This is how the spec works now.
Test: fast/frames/sandboxed-iframe-forms-dynamic.html
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
* bindings/generic/BindingDOMWindow.h:
(WebCore::::createWindow):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
* dom/Document.cpp:
* dom/Document.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::requestObject):
(WebCore::FrameLoader::shouldAllowNavigation):
(WebCore::FrameLoader::updateSandboxFlags):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:
2010-02-09 Ariya Hidayat <ariya.hidayat@gmail.com>
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Remove old, outdated unused code block.
* platform/graphics/qt/GraphicsContextQt.cpp:
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Notify ChromeClientChromium of state change notifications.
https://bugs.webkit.org/show_bug.cgi?id=34464
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::toChromeClientChromium):
(WebCore::AXObjectCache::postPlatformNotification):
* page/chromium/ChromeClientChromium.h:
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
[BREWMP] Port PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=34600
Retrieve the event type, position, key modifiers, time stamp
and click count from AEEEvent.
* platform/PlatformMouseEvent.h:
* platform/brew/PlatformMouseEventBrew.cpp: Added.
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by Timothy Hatcher.
[Chromium] RenderTheme does not draw focus rings on SL for checkboxes, radio buttons
https://bugs.webkit.org/show_bug.cgi?id=34544
Covered by layout tests when run on SL.
* platform/chromium/ThemeChromiumMac.mm:
(-[TCMVisibleView _focusRingVisibleRect]):
(-[TCMVisibleView _focusRingClipAncestor]):
(FocusIndicationFix::currentOSHasSetFocusRingStyleInBitmapBug):
(FocusIndicationFix::swizzleFocusView):
(FocusIndicationFix::ScopedFixer::ScopedFixer):
(FocusIndicationFix::ScopedFixer::~ScopedFixer):
(+[NSView TCMInterposing_focusView]):
(WebCore::paintCheckbox):
(WebCore::paintRadio):
(WebCore::paintButton):
2010-02-09 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Check if returned wrapper is empty before operating on it.
https://bugs.webkit.org/show_bug.cgi?id=34746
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
https://bugs.webkit.org/show_bug.cgi?id=34706
* inspector/InjectedScriptHost.idl:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::currentCallFrame):
(WebCore::InspectorBackend::getProfile):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::pausedScript):
(WebCore::InspectorFrontend::resumedScript):
(WebCore::InspectorFrontend::profilerWasEnabled):
(WebCore::InspectorFrontend::profilerWasDisabled):
(WebCore::InspectorFrontend::didGetProfile):
* inspector/InspectorFrontend.h:
* page/Console.idl:
2010-02-09 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Geoff Garen.
Rename StringBuilder::release && JSStringBuilder::releaseJSString
to 'build()'.
* bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
2010-02-09 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/7400160> Netscape plug-ins are not instantiated on property access if there are pending stylesheets
https://bugs.webkit.org/show_bug.cgi?id=34776
Tests: plugins/instance-available-before-stylesheets-loaded-object.html
plugins/instance-available-before-stylesheets-loaded.html
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Call
updateLayoutIgnorePendingStylesheets() before checking for a renderer.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Ditto.
2010-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
Problems navigating by caret in links whose text wraps onto
subsequent lines.
https://bugs.webkit.org/show_bug.cgi?id=25676
We should not search ahead if we are not in the last element.
* dom/Position.cpp:
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
More optimization for AffineTransform with SVG
https://bugs.webkit.org/show_bug.cgi?id=34774
Some optimizations to safe unnecessary summations and multiplications.
Optimize AffineTransform to handle an identity or translation matrix
more efficient.
Added translationRight to avoid multiplications of matrices as much as
possible.
No tests added, no change of functionality.
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::inverse):
(WebCore::AffineTransform::translate):
(WebCore::AffineTransform::translateRight):
* platform/graphics/transforms/AffineTransform.h:
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::translationForAttributes):
(WebCore::RenderForeignObject::localToParentTransform):
* rendering/RenderForeignObject.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToBorderBoxTransform):
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
* rendering/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::localToParentTransform):
* rendering/SVGRootInlineBox.cpp:
(WebCore::applyTextLengthCorrectionToTextChunk):
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
SVG Pattern size was clipped to the size of the target, if the pattern is bigger than the target. This
causes problems, if the patternTransform scales the pattern. This patch deletes the clipping.
Tests: svg/custom/pattern-excessive-malloc.svg
svg/custom/pattern-size-bigger-than-target-size.svg
svg/custom/pattern-skew-transformed.svg
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::buildPattern):
2010-02-09 Darin Adler <darin@apple.com>
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Fixed typo in comment.
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting selected
text on SVG. Selected texts are painted with style from
getCachedPseudoStyle() instead of style().
Tests: svg/text/selection-styles.xhtml
* rendering/SVGCharacterLayoutInfo.h:
(WebCore::SVGTextChunkWalker::SVGTextChunkWalker):
(WebCore::SVGTextChunkWalker::setupFillSelection):
(WebCore::SVGTextChunkWalker::setupStrokeSelection):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection):
(WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillSelectionCallback):
(WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeSelectionCallback):
(WebCore::SVGRootInlineBoxPaintWalker::activePaintServer):
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::walkTextChunks):
* rendering/SVGInlineTextBox.h:
(WebCore::):
Add callback hooks and its implementation for handle new
subphases.
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::chunkSelectionStartEnd):
(WebCore::SVGInlineTextBox::paintCharacters):
Split box text into selected part and non-selected part, and use
separate subphases to paint them.
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk):
Relax ASSERT() condition to accept a part of text.
* svg/graphics/SVGPaintServer.cpp:
(WebCore::applyStrokeStyleToContext):
(WebCore::SVGPaintServer::setup):
* svg/graphics/SVGPaintServer.h:
* svg/graphics/SVGPaintServerGradient.cpp:
(WebCore::SVGPaintServerGradient::setup):
* svg/graphics/SVGPaintServerGradient.h:
* svg/graphics/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/SVGPaintServerPattern.h:
* svg/graphics/SVGPaintServerSolid.cpp:
(WebCore::SVGPaintServerSolid::setup):
* svg/graphics/SVGPaintServerSolid.h:
Change setup() signature to accept RenderStyle instead of always
using RenderObject::style().
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
No scroll bars are displayed for standalone SVG image
https://bugs.webkit.org/show_bug.cgi?id=11225
Height and width defined for svg element are not honored
https://bugs.webkit.org/show_bug.cgi?id=24033
SVG file does not pan and has no scroll bars
https://bugs.webkit.org/show_bug.cgi?id=24448
Adapt to SVG 1.1 errata to change the overflow handling:
Replace "svg { overflow: hidden }" by "svg:not(:root) { overflow: hidden }" to allow standalone SVG documents to contain scrolllbars.
Agreed by SVG WG to make this the default behaviour, already implemented by Opera & FireFox (partial support).
Add new tests in svg/overflow covering all special SVG css overflow handling rules on inner/outer svg elements.
Tests: svg/overflow/overflow-on-inner-svg-element-defaults.svg
svg/overflow/overflow-on-inner-svg-element.svg
svg/overflow/overflow-on-outermost-svg-element-defaults.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3.svg
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
* css/svg.css: Change default <svg> overflow rule to only apply to inner <svg> elements.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Only apply overflow rules for non-standalone SVG documents.
* rendering/RenderSVGRoot.cpp: Remove all calls to isOverflowHidden - it's always the case for the outermost SVG element, see spec + errata.
(WebCore::RenderSVGRoot::paint): Always clip to initial viewport size.
(WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
(WebCore::RenderSVGRoot::nodeAtPoint): Simplify.
* rendering/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::applyViewportClip): Use isOverflowHidden() instead of a manual oveflow query and clip in float precision.
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::isOverflowHidden): Simplify implementation, assure the function is not called anymore for RenderSVGRoot objects.
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port KURL::fileSystemPath
https://bugs.webkit.org/show_bug.cgi?id=34516
Convert a file URL to a file path by prefixing
AEEFS_HOME_DIR to access files relative to the current
module directory in a case-sensitive manner.
As IWeb "file:" engine opens files in BREW's application-relative
file namespace, we follow the same policy here.
* platform/brew/KURLBrew.cpp: Added.
(WebCore::KURL::fileSystemPath):
2010-02-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] the above website does not render properly when in compositing mode
https://bugs.webkit.org/show_bug.cgi?id=34681
http://media.24ways.org/2009/15/spinner-alt.html now renders correctly
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::MaskEffectQt::MaskEffectQt): implement mask as
QGraphicsEffect
(WebCore::MaskEffectQt::draw): reimp
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): init the effect
(WebCore::GraphicsLayerQtImpl::paint): no need for drawContents
(WebCore::GraphicsLayerQtImpl::flushChanges): make sure to update the
mask layer, not just the actual children
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
[BREWMP] Fix macro redefinition error in BREWMP simulator build.
https://bugs.webkit.org/show_bug.cgi?id=34738
Remove warning: 'FAR' macro redefinition.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
Tests: fast/css/inline-element-line-break.html
fast/css/pseudo-element-line-break.html
findNextLineBreak() unconditionally allowed lines to break between elements when no other line breaking opportunity had been found,
but that was unnecessary and led to incorrect layout. Disallow that kind of line breaks.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
Test: printing/numberOfPages.html
* WebCore.base.exp:
* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
(WebCore::PrintContext::numberOfPages):
* page/PrintContext.h:
(WebCore::PrintContext::pageRects):
2010-02-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
[V8] Move Element custom methods into generic bindings
This patch moves the security checks in setAttribute,
setAttributeNode, setAttributeNS and setAttributeNodeNS from
V8ElementCustom into the generic bindings so that they can be
reused in other bindings. This is in a similar vein to
<https://bugs.webkit.org/attachment.cgi?id=45872>.
https://bugs.webkit.org/show_bug.cgi?id=34554
LayoutTests: None
* WebCore.gypi:
* bindings/generic/BindingElement.h: Added.
(WebCore::::setAttribute):
(WebCore::::setAttributeNode):
(WebCore::::setAttributeNS):
(WebCore::::setAttributeNodeNS):
* bindings/v8/V8Binding.h:
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore::V8Element::setAttributeCallback):
(WebCore::V8Element::setAttributeNodeCallback):
(WebCore::V8Element::setAttributeNSCallback):
(WebCore::V8Element::setAttributeNodeNSCallback):
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
https://bugs.webkit.org/show_bug.cgi?id=31227
Test: http/tests/loading/load-javascript-after-many-xhrs.html
* loader/loader.cpp:
(WebCore::Loader::Host::servePendingRequests):
2010-02-08 David Levin <levin@chromium.org>
Reviewed by Gavin Barraclough.
REGRESSION (before r54472): Various tests in fast/workers are crashing on the buildbot.
https://bugs.webkit.org/show_bug.cgi?id=34728
The core part of the fix is to change WebCoreJSClientData::m_normalWorld
from DOMWrapperWorld to RefPtr<DOMWrapperWorld> so that the DOMWrapperWorld
is really ref counted.
No new tests because current tests sufficiently cover this as evidenced as
the buildbot crashes.
* bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Made this robust to m_globalData
being 0.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::create): Made this class follow the standard
create pattern for RefCounted classes.
(WebCore::DOMWrapperWorld::detachFromGlobalData): Since this class can
now outlive JSGlobalData, this method tells it to stop using its JSGlobalData.
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Adjusted due to
m_normalWorld being a RefPtr.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Ditto (and added
asserts for the FIXME).
(WebCore::WebCoreJSClientData::normalWorld): Ditto.
* bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::create): Made the constructor protected.
(WebCore::IsolatedWorld::IsolatedWorld): Made the constructor protected, so
that code would have to use the create method.
2010-02-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Remove special utf-8 tag from Chromium cilpboard code because
we now have the corresponding code in generic clipboard framework
code in chromium (since it's needed by other places than in Web
page rendering) and no longer need the separate workaround code in
WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34567
Test: (for regression) editing/pasteboard
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writeRange):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::documentFragment):
2010-02-08 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Crash due to layout not done in case involving removal of absolute positioning
https://bugs.webkit.org/show_bug.cgi?id=34734
rdar://problem/7588280
Test: fast/dynamic/position-change-layout.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Call markContainingBlocksForLayout in
a case where the object already needs layout, but might have a new containing
block and so needs to mark the new containing block.
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
* manual-tests/onbeforeunload-focused-iframe.html: Added.
* manual-tests/resources/focused-iframe.html: Added.
2010-02-08 Alexey Proskuryakov <ap@apple.com>
Addressing review feedback.
* bridge/c/c_instance.h: Removed argument name.
2010-02-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34727
Assertion crashes and freezes when plug-in property access results in an exception
Test: plugins/netscape-plugin-property-access-exception.html
* bridge/c/c_instance.h: Made moveGlobalExceptionToExecState public, since it also need to
be called from CField.
* bridge/c/c_runtime.cpp:
(JSC::Bindings::CField::valueFromInstance): Call moveGlobalExceptionToExecState(). Without
this, not only didn't we get exceptions, but we also got an assertion failure because of
dangling global exception on next call into plug-in.
(JSC::Bindings::CField::setValueToInstance): Ditto.
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed build fix of ChromiumWin.
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::):
(WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
(WebCore::TransparencyWin::setupTransformForKeepTransform):
* platform/graphics/chromium/TransparencyWin.h:
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::):
2010-02-05 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Jeremy Orlow.
Adding a way to get the set of all open database handles pointing
to a given database.
https://bugs.webkit.org/show_bug.cgi?id=34619
Sometimes we need to be able to close all handles to a database as
soon as possible (to delete the DB file, for example).
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getOpenDatabases):
* storage/DatabaseTracker.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed windows build-fix.
* page/win/FrameCGWin.cpp:
(WebCore::drawRectIntoContext):
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
This adds back AffineTransform. This saves additional 4% memory consumption
on the 50k rects stress test: https://bugs.webkit.org/attachment.cgi?id=46721
It also makes it possible to optimize the calculations internally of
AffineTransform to the needs of 2D transformations (the second benefit for SVG,
which uses transformations relative often at the moment.
Everything that is 2D related (like images, patterns, gradients, fonts), uses
AffineTransform now.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSVGMatrixCustom.cpp:
(WebCore::JSSVGMatrix::multiply):
(WebCore::JSSVGMatrix::inverse):
(WebCore::JSSVGMatrix::rotateFromVector):
* bindings/js/JSSVGPODTypeWrapper.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
(WebCore::V8SVGMatrix::multiplyCallback):
(WebCore::V8SVGMatrix::inverseCallback):
(WebCore::V8SVGMatrix::rotateFromVectorCallback):
* html/HTMLCanvasElement.cpp: Changed to AffineTransform now
(WebCore::HTMLCanvasElement::baseTransform):
* html/HTMLCanvasElement.h:
* platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::matrixTransform):
* platform/graphics/FloatPoint.h:
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::drawPattern):
* platform/graphics/GeneratedImage.h:
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::setGradientSpaceTransform):
(WebCore::Gradient::setPlatformGradientSpaceTransform):
* platform/graphics/Gradient.h:
(WebCore::Gradient::gradientSpaceTransform):
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::baseTransform):
* platform/graphics/Path.h:
* platform/graphics/Pattern.cpp:
(WebCore::Pattern::setPatternSpaceTransform):
* platform/graphics/Pattern.h:
(WebCore::Pattern::create):
(WebCore::Pattern::tileImage):
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::GraphicsContext::getCTM):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/cairo/PathCairo.cpp:
* platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/haiku/ImageHaiku.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/haiku/PathHaiku.cpp:
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawComplexText):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/qt/PathQt.cpp:
* platform/graphics/qt/PatternQt.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::setPlatformGradientSpaceTransform):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/skia/PathSkia.cpp:
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleTextDrawing):
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::makeIdentity): needed by some parts of WebCore
(WebCore::AffineTransform::scale): Didn't scale the complete matrix
(WebCore::AffineTransform::translate): Didn't respect other transformations
(WebCore::AffineTransform::shear): direct calculation, no extra multiply of matrices
(WebCore::AffineTransform::map):
(WebCore::AffineTransform::mapPoint):
(WebCore::AffineTransform::mapRect):
* platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::isIdentityOrTranslation):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::toAffineTransform):
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
* platform/graphics/win/GraphicsContextCairoWin.cpp:
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/wince/FontWince.cpp:
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::drawBitmapPattern):
* platform/graphics/wince/ImageBufferWince.cpp:
(WebCore::):
(WebCore::BufferedImage::drawPattern):
* platform/graphics/wince/PathWince.cpp:
(WebCore::Path::transform):
* platform/graphics/wince/PlatformPathWince.cpp:
(WebCore::drawPolygons):
(WebCore::PathPolygon::transform):
(WebCore::PlatformPathElement::transform):
(WebCore::PlatformPath::strokePath):
(WebCore::PlatformPath::fillPath):
(WebCore::PlatformPath::transform):
* platform/graphics/wince/PlatformPathWince.h:
(WebCore::):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::drawPattern):
(WebCore::Image::drawPattern):
* platform/graphics/wx/PathWx.cpp:
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozillaGtkWidget):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localTransform):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData):
(WebCore::RenderBoxModelScaleData::transform):
(WebCore::RenderBoxModelScaleData::setTransform):
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::translationForAttributes):
(WebCore::RenderForeignObject::localToParentTransform):
* rendering/RenderForeignObject.h:
(WebCore::RenderForeignObject::localTransform):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localTransform):
(WebCore::RenderObject::localToParentTransform):
(WebCore::RenderObject::absoluteTransform):
* rendering/RenderObject.h:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::localToParentTransform):
(WebCore::RenderPath::localTransform):
* rendering/RenderPath.h:
* rendering/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::absoluteTransform):
* rendering/RenderSVGImage.h:
(WebCore::RenderSVGImage::localToParentTransform):
(WebCore::RenderSVGImage::localTransform):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToBorderBoxTransform):
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::absoluteTransform):
(WebCore::RenderSVGRoot::localTransform):
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGText.h:
(WebCore::RenderSVGText::localToParentTransform):
(WebCore::RenderSVGText::localTransform):
* rendering/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::localToParentTransform):
(WebCore::RenderSVGTransformableContainer::localTransform):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* rendering/RenderSVGTransformableContainer.h:
* rendering/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::markerBoundaries):
(WebCore::RenderSVGViewportContainer::markerContentTransformation):
(WebCore::RenderSVGViewportContainer::viewportTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
(WebCore::RenderSVGViewportContainer::absoluteTransform):
* rendering/RenderSVGViewportContainer.h:
* rendering/SVGCharacterLayoutInfo.cpp:
(WebCore::SVGChar::characterTransform):
* rendering/SVGCharacterLayoutInfo.h:
(WebCore::SVGTextChunkWalker::operator()):
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
(WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
(WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback):
(WebCore::SVGInlineTextBox::paintCharacters):
(WebCore::SVGInlineTextBox::paintDecoration):
* rendering/SVGMarkerLayoutInfo.h:
(WebCore::MarkerLayout::MarkerLayout):
* rendering/SVGRenderSupport.cpp:
(WebCore::applyTransformToPaintInfo):
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/SVGRenderTreeAsText.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
(WebCore::applyTextLengthCorrectionToTextChunk):
(WebCore::SVGRootInlineBox::buildLayoutInformation):
* rendering/TransformState.cpp:
(WebCore::TransformState::applyTransform):
* rendering/TransformState.h:
* svg/GradientAttributes.h:
(WebCore::GradientAttributes::gradientTransform):
(WebCore::GradientAttributes::setGradientTransform):
* svg/PatternAttributes.h:
(WebCore::PatternAttributes::patternTransform):
(WebCore::PatternAttributes::setPatternTransform):
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::resetToBaseValue):
(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
(WebCore::SVGAnimateMotionElement::applyResultsToTarget):
* svg/SVGAnimateMotionElement.h:
* svg/SVGAnimateTransformElement.cpp:
* svg/SVGAnimateTransformElement.h:
* svg/SVGElement.h:
(WebCore::SVGElement::supplementalTransform):
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::viewBoxToViewTransform):
* svg/SVGFitToViewBox.h:
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getCTM):
(WebCore::SVGLocatable::getScreenCTM):
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGLocatable.h:
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::viewBoxToViewTransform):
* svg/SVGMarkerElement.h:
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::drawMaskerContent):
* svg/SVGMatrix.idl:
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::buildPattern):
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::getCTM):
* svg/SVGPreserveAspectRatio.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport):
(WebCore::SVGSVGElement::createSVGMatrix):
(WebCore::SVGSVGElement::createSVGTransformFromMatrix):
(WebCore::SVGSVGElement::getCTM):
(WebCore::SVGSVGElement::getScreenCTM):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
* svg/SVGSVGElement.h:
* svg/SVGStyledLocatableElement.cpp:
(WebCore::SVGStyledLocatableElement::getCTM):
(WebCore::SVGStyledLocatableElement::getScreenCTM):
* svg/SVGStyledLocatableElement.h:
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::getCTM):
(WebCore::SVGStyledTransformableElement::getScreenCTM):
(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
(WebCore::SVGStyledTransformableElement::supplementalTransform):
* svg/SVGStyledTransformableElement.h:
(WebCore::SVGStyledTransformableElement::isStyledTransformable):
(WebCore::SVGStyledTransformableElement::toPathData):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::getScreenCTM):
(WebCore::SVGTextElement::getCTM):
(WebCore::SVGTextElement::animatedLocalTransform):
(WebCore::SVGTextElement::supplementalTransform):
* svg/SVGTextElement.h:
* svg/SVGTextPathElement.cpp:
* svg/SVGTransform.cpp:
(SVGTransform::SVGTransform):
(SVGTransform::matrix):
(SVGTransform::setMatrix):
* svg/SVGTransform.h:
* svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::isZero):
* svg/SVGTransformDistance.h:
* svg/SVGTransformList.cpp:
(SVGTransformList::createSVGTransformFromMatrix):
(SVGTransformList::concatenate):
(SVGTransformList::valueAsString):
* svg/SVGTransformList.h:
* svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::getCTM):
(WebCore::SVGTransformable::getScreenCTM):
(WebCore::SVGTransformable::parseTransformValue):
* svg/SVGTransformable.h:
(WebCore::SVGTransformable::):
* svg/graphics/SVGPaintServerGradient.cpp:
(WebCore::SVGPaintServerGradient::gradientTransform):
(WebCore::SVGPaintServerGradient::setGradientTransform):
(WebCore::clipToTextMask):
(WebCore::SVGPaintServerGradient::setup):
* svg/graphics/SVGPaintServerGradient.h:
* svg/graphics/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::patternTransform):
(WebCore::SVGPaintServerPattern::setPatternTransform):
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/SVGPaintServerPattern.h:
* svg/graphics/SVGResourceClipper.cpp:
(WebCore::SVGResourceClipper::applyClip):
* svg/graphics/SVGResourceMarker.cpp:
(WebCore::SVGResourceMarker::markerTransformation):
(WebCore::SVGResourceMarker::draw):
* svg/graphics/SVGResourceMarker.h:
* svg/graphics/filters/SVGFEImage.cpp:
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
2010-02-08 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Make an inline function containing a static var out-of-line. This is
a workaround for Xcode 3.1 bug radar 7070016. We tripped on this in
deviceRGBColorSpaceRef on the Chromium canaries. This is a proactive
fix for the same problem in sRGBColorSpaceRef().
https://bugs.webkit.org/show_bug.cgi?id=34663
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::sRGBColorSpaceRef):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
2010-02-08 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Unify the WorkerContext V8 object wrapping code with
the standard V8 object wrapping code.
https://bugs.webkit.org/show_bug.cgi?id=34658
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::getReceiverObject):
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use fastStrDup instead of strdup
https://bugs.webkit.org/show_bug.cgi?id=33943
Replace strdup/free with fastStrDup/fastFree.
* bridge/IdentifierRep.h:
(WebCore::IdentifierRep::IdentifierRep):
* bridge/jni/JNIBridge.cpp:
(JavaMethod::~JavaMethod):
(appendClassName):
(JavaMethod::signature):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::~ResourceHandleManager):
(WebCore::ResourceHandleManager::setCookieJarFileName):
(WebCore::ResourceHandleManager::initializeHandle):
* plugins/PluginStream.cpp:
(WebCore::PluginStream::~PluginStream):
(WebCore::PluginStream::startStream):
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xsltParamArrayFromParameterMap):
(WebCore::freeXsltParamArray):
2010-02-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix Qt build on Windows.
nmake fails to pick the right cpp file, so we have to
rename the file to to a unique name.
* WebCore.pro:
* platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp.
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
All SVG *-expected.txt files contain wrong results
https://bugs.webkit.org/show_bug.cgi?id=34703
Finally dump meaningful information for SVG layout tests.
Use 'absoluteClippedOverflowRect' which goes through the same code paths used
to actually calculate repaint rects etc - instead of the legacy CSS-unaware
code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
Remove absoluteTransform() - a long standing TODO, finally not needed anymore.
Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.
As we're now dumping clipped overflow rects any problems with repaint rects will become
immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.
Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.
* rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
* rendering/RenderObject.h: Remove absoluteTransform() method.
* rendering/RenderSVGHiddenContainer.h: Ditto.
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
(WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
(WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
* rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
* rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method.
(WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
* rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
* rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y.
(WebCore::SVGRenderBase::isOverflowHidden):
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()).
(WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
* svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform().
(WebCore::absoluteTransformForRenderer):
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::SVGPaintServerGradient::setup):
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34402
Implements all of the numeric CSS3 list-style-types as per
section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.
Test: fast/lists/w3-css3-list-styles-numeric.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* inspector/front-end/SourceCSSTokenizer.re2js:
* platform/text/CharacterNames.h: Added constant hyphenMinus.
* rendering/RenderListMarker.cpp:
(WebCore::): Defined enum SequenceType.
(WebCore::toAlphabeticOrNumeric): Added.
(WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric.
(WebCore::toNumeric): Added.
(WebCore::listMarkerSuffix):
(WebCore::listMarkerText):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::calcPrefWidths):
(WebCore::RenderListMarker::getRelativeMarkerRect):
* rendering/style/RenderStyle.h:
(WebCore::):
* rendering/style/RenderStyleConstants.h: Added numeric list style types
and fixed indent level for the enum values.
(WebCore::):
2010-02-07 Ismail Donmez <ismail@namtrac.org>
Reviewed by Darin Adler.
Include wtf/StringExtras.h for strdup definition, which
is needed for WinCE.
* bridge/IdentifierRep.h:
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
https://bugs.webkit.org/show_bug.cgi?id=34680
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::setData):
2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* page/chromium/ChromeClientChromium.h:
2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Using inlines and function-level statics don't mix, according to gcc.
https://bugs.webkit.org/show_bug.cgi?id=34663
De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.
It appears that the initialization check, generated by gcc doesn't account
for a possibility that the function may be inlined, resulting in lazy
initialization failure for more than one inlined instance of the function.
No behavior change, so no new tests.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::deviceRGBColorSpaceRef):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
2010-02-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Dan Bernstein.
Added an ASSERT to catch an implausible but theoretically possible leak.
In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.
This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
* platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.
2010-02-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348
The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.
I also changed the order of a couple of calls in QTMovieWin to account
for changed calling order from the logic above.
* platform/graphics/win/GraphicsLayerCACF.cpp:Update to new virtual function API
(WebCore::GraphicsLayerCACF::setContentsToMedia):
(WebCore::GraphicsLayerCACF::updateContentsMedia):
* platform/graphics/win/GraphicsLayerCACF.h:Update to new virtual function API
(WebCore::GraphicsLayerCACF::):
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWinPrivate::cacheMovieScale):Fix a bug where ratio was computed wrong because it was using integer math
(QTMovieWinPrivate::task):Compute movie scale before computing movie size so values are correct
(QTMovieWinPrivate::setSize):Move movie size update to updateMovieSize()
(QTMovieWinPrivate::updateMovieSize):Wrap size update in a new call so it can be used from multiple places
2010-02-05 Enrica Casucci <enrica@apple.com>
Reviewed by Simon Fraser.
Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848
Added a manual test.
* manual-tests/win: Added.
* manual-tests/win/horizontal-scroll-composited.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
2010-02-05 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Levin.
Implementation of GlyphPage::fill() for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527
Covered by existing tests.
* platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp
2010-01-19 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Dave Hyatt.
Implement flattening of framesets
https://bugs.webkit.org/show_bug.cgi?id=32717
The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.
Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.
Tests: fast/frames/flattening/frameset-flattening-advanced.html
fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):
* page/Settings.h:
(WebCore::Settings::frameSetFlatteningEnabled):
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::layoutWithFlattening):
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):
* rendering/RenderFrameSet.h:
2010-02-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Changing display type of parent of input on focus causes input field to not receive key events
https://bugs.webkit.org/show_bug.cgi?id=34620
<rdar://problem/7584572>
When layout affects a text input, the RenderTextControl gets destroyed and
recreated, which in turn makes a new innerTextElement. However, if the text field was
focused, the VisibleSelection is left pointing to the old innerTextElement, so text
input no longer works.
The fix is to call updateFocusAppearanceSoon() when attaching the input element,
which will update the selection if necessary.
Test: fast/forms/restore-selection-after-layout.html
* dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable,
m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
* dom/Document.cpp:
(WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection
(WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter.
(WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
* dom/Element.cpp:
(WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
* dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.
2010-02-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.
https://bugs.webkit.org/show_bug.cgi?id=34646
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype.show):
(WebInspector.CookieItemsView.prototype._update):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
(WebInspector.CookieItemsView.prototype._createDataGrid):
(WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare):
(WebInspector.CookieItemsView.prototype._populateDataGrid):
(WebInspector.CookieItemsView.prototype._createSimpleDataGrid):
(WebInspector.CookieItemsView.prototype._populateSimpleDataGrid):
(WebInspector.CookieItemsView.prototype._deleteCookieCallback):
(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.autoSizeColumns):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._queryFinished):
* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype._queryFinished):
* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel.prototype.dataGridForResult):
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: group cookies by frame, show total
cookies size, allow sorting cookie table.
https://bugs.webkit.org/show_bug.cgi?id=34617
* English.lproj/localizedStrings.js:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::deleteCookie):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype.update):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._cookiesForDomain):
(WebInspector.CookieItemsView.prototype.dataGridForCookies):
(WebInspector.CookieItemsView.prototype._createNodes):
(WebInspector.CookieItemsView.prototype._sortData.localeCompare):
(WebInspector.CookieItemsView.prototype._sortData.numberCompare):
(WebInspector.CookieItemsView.prototype._sortData.expiresCompare):
(WebInspector.CookieItemsView.prototype._sortData):
* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel.prototype.showCookies):
(WebInspector.CookieSidebarTreeElement):
(WebInspector.CookieSidebarTreeElement.prototype.onselect):
(WebInspector.CookieSidebarTreeElement.prototype.get subtitle):
(WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
* inspector/front-end/inspector.js:
(WebInspector.updateResource):
2010-02-05 Maxime Simone <simon.maxime@gmail.com>
Reviewed by David Levin.
More robust conversion from BString to String for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527
Covered by existing tests.
* platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.
2010-02-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Windows build fix.
* WebCore.vcproj/WebCore.make:
2010-02-05 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Dirk Schulze.
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::debugString): Path dumping style is aproached to Mac.
2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
(WebCore::doGstInit):
* platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
* platform/graphics/gtk/WebKitWebSourceGStreamer.h:
Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure.
This makes sure that referer, cookies, authentication information
and all kinds of other context are passed to GStreamer for websites
like Vimeo or YouTube.
2010-02-05 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Clean up code for getting a v8::FunctionTemplate.
https://bugs.webkit.org/show_bug.cgi?id=34606
* bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
* bindings/v8/V8Binding.cpp:
(WebCore::configureTemplate):
* bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead.
(WebCore::V8DOMWrapper::getConstructor):
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::lookupDOMWrapper):
* bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates.
(WebCore::V8ClassIndex::getTemplate):
* bindings/v8/V8Index.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::toV8):
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::v8HTMLAudioElementConstructorCallback):
(WebCore::V8HTMLAudioElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLAudioElementConstructor.h:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLImageElementConstructor.h:
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback):
(WebCore::V8HTMLOptionElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLOptionElementConstructor.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::createInjectedScriptHostV8Wrapper):
2010-02-05 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597
* plugins/PluginView.h:
2010-02-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
- Use SerializedScriptValue for passing data between injected script and
inspector frontend.
- Remove custom JSON implementation from the instpector utility script.
- Make sure that only objects created in the same ScriptState can be values
of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't
want ScriptObjects to leak between contexts.
- Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing
it as additional parameter.
https://bugs.webkit.org/show_bug.cgi?id=33592
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
* bindings/js/ScriptArray.cpp:
(WebCore::ScriptArray::set):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::ScriptFunctionCall):
(WebCore::ScriptFunctionCall::appendArgument):
* bindings/js/ScriptFunctionCall.h:
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::set):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):
* bindings/js/ScriptValue.h:
* bindings/v8/ScriptArray.cpp:
(WebCore::ScriptArray::set):
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::ScriptFunctionCall):
(WebCore::ScriptFunctionCall::appendArgument):
* bindings/v8/ScriptFunctionCall.h:
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptObject::set):
* bindings/v8/ScriptState.h:
* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::deserialize):
* bindings/v8/ScriptValue.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::dispatch):
(WebCore::InjectedScript::callFrames):
(WebCore::InjectedScript::wrapForConsole):
(WebCore::InjectedScript::releaseWrapperObjectGroup):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::dispatchOnInjectedScript):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setFrontendProxyObject):
(WebCore::InspectorController::didPause):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::InspectorFrontend):
(WebCore::InspectorFrontend::newScriptArray):
(WebCore::InspectorFrontend::newScriptObject):
(WebCore::InspectorFrontend::populateFrontendSettings):
(WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
(WebCore::InspectorFrontend::addConsoleMessage):
(WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
(WebCore::InspectorFrontend::updateResource):
(WebCore::InspectorFrontend::removeResource):
(WebCore::InspectorFrontend::didGetResourceContent):
(WebCore::InspectorFrontend::updateFocusedNode):
(WebCore::InspectorFrontend::setAttachedWindow):
(WebCore::InspectorFrontend::addRecordToTimeline):
(WebCore::InspectorFrontend::parsedScriptSource):
(WebCore::InspectorFrontend::failedToParseScriptSource):
(WebCore::InspectorFrontend::addProfileHeader):
(WebCore::InspectorFrontend::setRecordingProfile):
(WebCore::InspectorFrontend::didGetProfileHeaders):
(WebCore::InspectorFrontend::didGetProfile):
(WebCore::InspectorFrontend::pausedScript):
(WebCore::InspectorFrontend::setDocument):
(WebCore::InspectorFrontend::setDetachedRoot):
(WebCore::InspectorFrontend::setChildNodes):
(WebCore::InspectorFrontend::childNodeCountUpdated):
(WebCore::InspectorFrontend::childNodeInserted):
(WebCore::InspectorFrontend::childNodeRemoved):
(WebCore::InspectorFrontend::attributesUpdated):
(WebCore::InspectorFrontend::didRemoveNode):
(WebCore::InspectorFrontend::didGetChildNodes):
(WebCore::InspectorFrontend::didApplyDomChange):
(WebCore::InspectorFrontend::didGetEventListenersForNode):
(WebCore::InspectorFrontend::didGetCookies):
(WebCore::InspectorFrontend::didDispatchOnInjectedScript):
(WebCore::InspectorFrontend::addDatabase):
(WebCore::InspectorFrontend::selectDatabase):
(WebCore::InspectorFrontend::didGetDatabaseTableNames):
(WebCore::InspectorFrontend::addDOMStorage):
(WebCore::InspectorFrontend::selectDOMStorage):
(WebCore::InspectorFrontend::didGetDOMStorageEntries):
(WebCore::InspectorFrontend::didSetDOMStorageItem):
(WebCore::InspectorFrontend::didRemoveDOMStorageItem):
(WebCore::InspectorFrontend::updateDOMStorage):
(WebCore::InspectorFrontend::addNodesToSearchResult):
(WebCore::InspectorFrontend::contextMenuItemSelected):
(WebCore::InspectorFrontend::evaluateForTestInFrontend):
(WebCore::InspectorFrontend::callSimpleFunction):
* inspector/InspectorFrontend.h:
(WebCore::InspectorFrontend::scriptState):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
(injectedScriptConstructor.):
* inspector/front-end/InjectedScriptAccess.js:
(InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback):
(InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
(InjectedScriptAccess._installHandler):
* inspector/front-end/inspector.js:
(WebInspector.pausedScript):
(WebInspector.addConsoleMessage):
2010-02-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Generate convenience headers (QWebView, etc) using qmake
In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.
These extra headers are installed alongside the normal headers.
* WebCore.pro: Use headers.pri based on DerivedSources instead
of the one previously checked in in the source tree.
2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Enable JAVASCRIPT_DEBUGGER in chromium port.
https://bugs.webkit.org/show_bug.cgi?id=34638
* page/Console.cpp:
* page/Console.h:
* page/Console.idl:
2010-02-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Tab width for javascript source is 8, should be 4
https://bugs.webkit.org/show_bug.cgi?id=31248
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces):
(WebInspector.TextEditorModel.prototype._innerSetText):
(WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
2010-02-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24872
When pasting a list into another list should not indent another level.
If the cursor is at the beginning of the line, it should insert the
list items before the current list item. If the cursor is at the end
of the line, it should insert the list items after the current list item.
This matches Firefox and IE and makes the common activity of reordering a list
work as expected.
This also adds a small helper method (isListItem) to htmlediting.h.
Test: editing/pasteboard/paste-list-002.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* editing/ReplaceSelectionCommand.h:
* editing/htmlediting.cpp:
(WebCore::isListItem):
(WebCore::appendedSublist):
* editing/htmlediting.h:
2010-02-04 Mark Rowe <mrowe@apple.com>
Reviewed by Timothy Hatcher.
Build fix. Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.
* WebCore.base.exp: Remove symbol.
* WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.
2010-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Updated to use new WeakGCPtr::clear interface.
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::invalidateJSFunction):
2010-02-04 Geoffrey Garen <ggaren@apple.com>
Build fix: Added a forwarding header.
* ForwardingHeaders/runtime/WeakGCPtr.h: Added.
2010-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov and Darin Adler.
REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>
There were two bugs here:
1. A stale wrapper would invalidate a node's event listeners, even if
the node had a fresh wrapper keeping it alive.
The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.
2. Conversely, a stale wrapper would not invalidate a node's event
listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)
The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.
* ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.
* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.
* bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.
* dom/EventListener.h:
(WebCore::EventListener::invalidateJSFunction): ditto
* dom/EventTarget.h:
(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto
2010-02-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.
Test: editing/inserting/paragraph-outside-nested-divs.html
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::highestVisuallyEquivalentDiv):
(WebCore::InsertParagraphSeparatorCommand::doApply):
2010-02-04 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.
2. Jump straight to the transaction error callback when a
statement fails in a way that makes sqlite automatically rollback
the transaction.
3. Fix the code that handles the "quota reached" failure, as it is
one of the failures that lead to an automatic transaction
rollback.
https://bugs.webkit.org/show_bug.cgi?id=34280
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::isAutoCommitOn):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):
* platform/sql/SQLiteTransaction.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
2010-02-04 Peter Kasting <pkasting@google.com>
Not reviewed, rollback.
Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.
* platform/chromium/ScrollbarThemeChromiumMac.h:
2010-02-04 Stephen White <senorblanco@chromium.org>
Unreviewed, build fix.
Fix for Chromium/Mac after palindromic scrollbar change (54345).
Covered by many layout tests.
* platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
2010-02-04 Clemmitt Sigler <cmsigler@gmail.com>
Reviewed by David Levin.
WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
Updated WebCore/GNUmakefile.am to include needed files in build.
https://bugs.webkit.org/show_bug.cgi?id=34387
No new tests.
* GNUmakefile.am:
2010-02-04 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
Misc coding style fixes in Haiku port code.
https://bugs.webkit.org/show_bug.cgi?id=34527
No tests needed.
* platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
* platform/haiku/DragImageHaiku.cpp: Trailing white space.
* platform/haiku/FileChooserHaiku.cpp: Sorted headers.
* platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h
2010-02-04 Enrica Casucci <enrica@apple.com>
Reviewed by Csaba Osztrogonac.
Fixed crash on QT introduced with the fix for
https://bugs.webkit.org/show_bug.cgi?id=34609
The test has been added with the original patch.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.
2010-02-04 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
Conditionalize third party cookie policy for libsoup 2.29.90.
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::setCookies):
* platform/network/soup/DNSSoup.cpp:
(WebCore::prefetchDNS):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
(WebCore::startHttp):
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
(WebCore::ResourceRequest::updateFromSoupMessage):
2010-02-04 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Gustavo Noronha Silva.
Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.
* platform/gtk/GOwnPtrGtk.cpp:
2010-02-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
https://bugs.webkit.org/show_bug.cgi?id=34520
Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html
* dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute
properties before attributes. Otherwise, copying "checked" attribute would make the cloned
node checked, unchecking original (they share a name, and are thus in the same radio group).
We do want the original to be unchecked, but we also want to know its original state in
HTMLInputElement::copyNonAttributeProperties().
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties):
Use setChecked instead of plain assignment to prevent m_checked getting out of sync with
checkedRadioButtons. Also, copy field related to default checked state, so that m_checked
won't be overridden when copying attributes.
2010-02-04 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after addition of Clipboard::writePlainText method.
* platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::writePlainText):
* platform/wx/ClipboardWx.h:
2010-02-04 Enrica Casucci <enrica@apple.com>
Reviewed by Oliver Hunt.
REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609
Test: editing/pasteboard/drop-inputtext-acquires-style.html
The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.
* dom/Clipboard.h: Added writePlainText pure virtual function.
* editing/Editor.cpp:
(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
* editing/htmlediting.cpp:
(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp
* editing/htmlediting.h:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
* platform/Pasteboard.h:
* platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::writePlainText): Added.
* platform/android/ClipboardAndroid.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writePlainText): Added.
* platform/chromium/ClipboardChromium.h:
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writePlainText): Added.
* platform/gtk/ClipboardGtk.h:
* platform/haiku/ClipboardHaiku.cpp:
(WebCore::ClipboardHaiku::writePlainText): Added.
* platform/haiku/ClipboardHaiku.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writePlainText): Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writePlainText): Added helper function.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added.
* platform/qt/ClipboardQt.h:
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writePlainText): Added.
* platform/win/ClipboardWin.h:
2010-02-04 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Fix bug in V8 convertNPVariantToJValue when converting float and double types
https://bugs.webkit.org/show_bug.cgi?id=34593
No new tests, build fix only.
* bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
(JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
2010-02-04 Chris Guillory <chris.guillory@google.com>
Reviewed by Darin Fisher.
[Chromium] Notify ChromeClientChromium of AccessibilityObject state
change notifications.
https://bugs.webkit.org/show_bug.cgi?id=34464
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::toChromeClientChromium):
(WebCore::AXObjectCache::postPlatformNotification):
* page/chromium/ChromeClientChromium.h:
2010-02-04 Stephen White <senorblanco@chromium.org>
Unreviewed, build fix for Chromium.
Revert r54341 ("[v8] Remove clear method from DOM object maps"),
since it causes the worker tests to fail on Chromium.
* bindings/v8/DOMData.h:
(WebCore::DOMData::removeObjectsFromWrapperMap):
* bindings/v8/DOMDataStore.h:
(WebCore::ChunkedTable::clear):
(WebCore::ChunkedTable::clearEntries):
(WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
(WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjectsInCurrentThreadHelper):
(WebCore::removeAllDOMObjectsInCurrentThread):
* bindings/v8/V8DOMMap.h:
(WebCore::WeakReferenceMap::clear):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602
* platform/network/soup/DNSSoup.cpp:
(WebCore::prefetchDNS): NULL-check the SoupURI that is created
from the hostname; that will happen for invalid hostnames.
2010-02-04 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(textForObject):
Checking if render objects are texts before calling toRenderText
2010-02-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Set first party URI in all SoupMessages. This allows libsoup to
implement a "no third party cookies" policy in case it wants
to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
use it for SoupURI.
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::setCookies):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
(WebCore::startHttp):
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
(WebCore::ResourceRequest::updateFromSoupMessage):
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: group cookies by domains, not frame's domains.
https://bugs.webkit.org/show_bug.cgi?id=34599
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._cookiesForDomain):
* inspector/front-end/inspector.js:
(WebInspector.updateResource):
(WebInspector._addCookieDomain):
2010-02-04 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Delete V8CustomBinding.h and all references to V8Custom
https://bugs.webkit.org/show_bug.cgi?id=32638
* bindings/v8/NPV8Object.cpp:
* bindings/v8/V8DOMWindowShell.h:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Utilities.cpp:
* bindings/v8/custom/V8AbstractWorkerCustom.cpp:
* bindings/v8/custom/V8AttrCustom.cpp:
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8ClipboardCustom.cpp:
* bindings/v8/custom/V8CoordinatesCustom.cpp:
* bindings/v8/custom/V8CustomBinding.h: Removed.
* bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
* bindings/v8/custom/V8DatabaseCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventSourceConstructor.cpp:
* bindings/v8/custom/V8EventSourceCustom.cpp:
* bindings/v8/custom/V8GeolocationCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::v8HTMLAudioElementConstructorCallback):
(WebCore::V8HTMLAudioElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
* bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback):
(WebCore::V8HTMLOptionElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
* bindings/v8/custom/V8HistoryCustom.cpp:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bindings/v8/custom/V8MessagePortCustom.cpp:
* bindings/v8/custom/V8NodeCustom.cpp:
* bindings/v8/custom/V8NodeFilterCustom.cpp:
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
* bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
* bindings/v8/custom/V8SVGLengthCustom.cpp:
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
* bindings/v8/custom/V8StorageCustom.cpp:
* bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
* bindings/v8/custom/V8WebGLArrayCustom.h:
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* bindings/v8/custom/V8WorkerCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Unnecessary QBrush construction for doing a solid fill
https://bugs.webkit.org/show_bug.cgi?id=34559
Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setPlatformFillColor):
2010-02-04 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371
Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.
* WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.
* platform/Scrollbar.h: Replaced scroll amount constants with static methods.
(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.
* platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/haiku/PlatformWheelEventHaiku.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.
2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
https://bugs.webkit.org/show_bug.cgi?id=34062
This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
(WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
(WebCore::OpacityAnimationQt::updateState): style change
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Cookies for resources are not shown in storage panel.
https://bugs.webkit.org/show_bug.cgi?id=34594
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getCookies):
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::updateScriptObject):
(WebCore::InspectorResource::cachedResource):
* inspector/InspectorResource.h:
(WebCore::InspectorResource::requestURL):
2010-02-04 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Remove clear method from DOM object maps
https://bugs.webkit.org/show_bug.cgi?id=34530
No new tests. Should be covered by existent testing infrastructure.
* bindings/v8/DOMData.h:
* bindings/v8/DOMDataStore.h:
* bindings/v8/V8DOMMap.cpp:
* bindings/v8/V8DOMMap.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
2010-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
[Gtk] Check if the renderer() exists in textForObject.
This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.
In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(textForObject):
2010-02-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Provide strongly typed C++ interface for inspector's injected script.
https://bugs.webkit.org/show_bug.cgi?id=33616
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScript.cpp: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::dispatch):
(WebCore::InjectedScript::callFrames):
(WebCore::InjectedScript::wrapAndStringifyForConsole):
(WebCore::InjectedScript::releaseWrapperObjectGroup):
* inspector/InjectedScript.h: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::~InjectedScript):
(WebCore::InjectedScript::hasNoValue):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptForId):
(WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::dispatchOnInjectedScript):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::setFrontendProxyObject):
(WebCore::InspectorController::close):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::didPause):
(WebCore::InspectorController::injectedScriptForNodeId):
* inspector/InspectorController.h:
(WebCore::InspectorController::frontendScriptState):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addConsoleMessage):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
2010-02-04 Philippe Normand <pnormand@igalia.com>
Rubber stamped by Xan Lopez.
Missing include, build fix after landing of patch from the bug 34435.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2010-02-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435
Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent nor Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
* platform/gtk/GOwnPtrGtk.cpp: Added.
(WTF::SoupURI):
(WTF::GstElement):
* platform/gtk/GOwnPtrGtk.h: Added.
2010-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
make this code engine-agnostic.
https://bugs.webkit.org/show_bug.cgi?id=34531
* inspector/InjectedScriptHost.cpp:
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
* inspector/InspectorBackend.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::close):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
* inspector/InspectorFrontend.h:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptCallFrame.h:
* inspector/JavaScriptDebugListener.h:
* inspector/JavaScriptDebugServer.cpp:
* inspector/JavaScriptDebugServer.h:
* inspector/JavaScriptProfile.cpp:
* inspector/JavaScriptProfile.h:
* inspector/JavaScriptProfileNode.cpp:
* inspector/JavaScriptProfileNode.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
* page/Page.cpp:
(WebCore::Page::Page):
2010-02-03 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Defer formatting of times displayed on media controls to the current theme.
https://bugs.webkit.org/show_bug.cgi?id=34405
No new tests needed. Refactoring Only.
* rendering/MediaControlElements.cpp: Removed formatTime()
(WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
* rendering/MediaControlElements.h:
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime): new virtual method
(WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method
(WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
* rendering/RenderTheme.h:
2010-02-03 Steve Falkenburg <sfalken@apple.com>
Windows Debug_All build fix.
* platform/graphics/win/WKCACFLayer.cpp:
2010-02-03 Brady Eidson <beidson@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and https://bugs.webkit.org/show_bug.cgi?id=34550
Tests: fast/loader/document-with-fragment-url-1.html
fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html
* platform/KURL.cpp:
(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,
any fragment identifier from the absolute URL should be removed from the resulting resolution.
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port TextBreakIteratorInternalICU
https://bugs.webkit.org/show_bug.cgi?id=34515
Port TextBreakIteratorInternalICU.
* platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added.
(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):
2010-02-03 Adele Peterson <adele@apple.com>
Reviewed by Simon Fraser.
Fix for <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319
Test: fast/css/counters/counter-before-selector-crash.html
* rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.
2010-02-03 Adele Peterson <adele@apple.com>
Reviewed by Brady Eidson.
Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.
* page/PageGroup.cpp:
2010-02-03 Adele Peterson <adele@apple.com>
Reviewed by Brady Eidson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized
For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.
* page/PageGroup.cpp:
2010-02-03 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546
* manual-tests/drag-image-table-part-decorations.html: Added.
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.
2010-02-03 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium mac build fix.
[V8] Remove unused V8Proxy* variable from generated wrapping code.
* bindings/scripts/CodeGeneratorV8.pm:
2010-02-03 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.
https://bugs.webkit.org/show_bug.cgi?id=32563
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptObject.cpp:
* bindings/v8/V8AbstractEventListener.cpp:
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8NodeFilterCondition.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.h
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8CustomPositionCallback.cpp:
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2010-02-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix drawing buttons in viewless WebKit.
* platform/mac/ThemeMac.mm:
(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.
2010-02-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425
Reverting r54279, it was a misunderstanding.
* platform/network/qt/SocketStreamHandlePrivate.h:
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):
(WebCore::SocketStreamHandlePrivate::close):
2010-02-03 Drew Wilson <atwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513
Test: Existing tests suffice (fixes test downstream in Chrome).
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
Changed to no longer derive from ActiveDOMObject (handles its own refcounting).
(WebCore::SharedWorkerScriptLoader::load):
Now increments own refcount when a load is pending.
(WebCore::SharedWorkerScriptLoader::notifyFinished):
Changed to decrement refcount when load is complete.
* workers/WorkerScriptLoaderClient.h:
Documentation change about reliability of notifyFinished() when used from worker context.
2010-02-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Inspector renders blank scripts on reloading the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34537
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2010-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Provide strongly typed C++ interface for inspector's injected script.
https://bugs.webkit.org/show_bug.cgi?id=33616
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScript.cpp: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::dispatch):
(WebCore::InjectedScript::callFrames):
(WebCore::InjectedScript::wrapAndStringify):
(WebCore::InjectedScript::releaseWrapperObjectGroup):
* inspector/InjectedScript.h: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::~InjectedScript):
(WebCore::InjectedScript::hasNoValue):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptForId):
(WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::dispatchOnInjectedScript):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::setFrontendProxyObject):
(WebCore::InspectorController::close):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::didPause):
(WebCore::InspectorController::injectedScriptForNodeId):
* inspector/InspectorController.h:
(WebCore::InspectorController::frontendScriptState):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addConsoleMessage):
2010-02-03 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::State::State):
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::setBaseTransform):
(WebCore::GraphicsLayerQtImpl::drawContents):
(WebCore::GraphicsLayerQtImpl::notifyChange):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::GraphicsLayerQt::setNeedsDisplayInRect):
(WebCore::applyTimingFunction):
(WebCore::webkitAnimationToQtAnimationValue):
(WebCore::AnimationQtBase::updateState):
(WebCore::AnimationQt::updateCurrentTime):
(WebCore::TransformAnimationQt::TransformAnimationQt):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::TransformAnimationQt::updateState):
(WebCore::OpacityAnimationQt::updateState):
(WebCore::GraphicsLayerQt::pauseAnimation):
2010-02-02 Bryan Yeung <bryeung@google.com>
Reviewed by Darin Adler.
Avoid using an invalidated KURL object in baseURI.
https://bugs.webkit.org/show_bug.cgi?id=34492
This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.
* dom/Element.cpp:
(WebCore::Element::baseURI):
2010-02-02 Joel Stanley <joel@jms.id.au>
Reviewed by David Levin.
[Chromium] Make setCaretBlinkInterval static.
https://bugs.webkit.org/show_bug.cgi?id=31704
This is so it can be called from the newly exposed Chromium API setter
method.
* rendering/RenderThemeChromiumLinux.cpp:
* rendering/RenderThemeChromiumLinux.h:
2010-02-02 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425
Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.
No new tests, since no new functionality is introduced.
* platform/network/qt/SocketStreamHandlePrivate.h:
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):
(WebCore::SocketStreamHandlePrivate::close):
(WebCore::SocketStreamHandlePrivate::socketBytesWritten):
2010-02-03 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.
[V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
* bindings/v8/V8Collection.h:
(WebCore::getV8Object):
(WebCore::toNativeCollection):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):
(WebCore::nodeCollectionIndexedPropertyEnumerator):
(WebCore::collectionIndexedPropertyEnumerator):
(WebCore::collectionStringOrNullIndexedPropertyGetter):
(WebCore::collectionStringIndexedPropertyGetter):
(WebCore::setCollectionIndexedGetter):
(WebCore::setCollectionNamedGetter):
(WebCore::setCollectionStringOrNullIndexedGetter):
(WebCore::setCollectionStringIndexedGetter):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::downcastSVGPathSeg):
(WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object):
(WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object):
(WebCore::V8DOMWrapper::convertToV8Object):
(WebCore::V8DOMWrapper::instantiateV8Object):
(WebCore::V8DOMWrapper::isDOMEventWrapper):
(WebCore::V8DOMWrapper::htmlElementType):
(WebCore::V8DOMWrapper::svgElementType):
(WebCore::V8DOMWrapper::convertEventToV8Object):
(WebCore::):
(WebCore::V8DOMWrapper::convertDocumentToV8Object):
(WebCore::V8DOMWrapper::convertNodeToV8Object):
(WebCore::V8DOMWrapper::convertNewNodeToV8Object):
(WebCore::V8DOMWrapper::convertEventListenerToV8Object):
(WebCore::V8DOMWrapper::convertDOMImplementationToV8Object):
(WebCore::V8DOMWrapper::convertStyleSheetToV8Object):
(WebCore::V8DOMWrapper::convertCSSValueToV8Object):
(WebCore::V8DOMWrapper::convertCSSRuleToV8Object):
(WebCore::V8DOMWrapper::convertWindowToV8Object):
(WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertToV8Object):
(WebCore::V8DOMWrapper::convertNodeToV8Object):
(WebCore::V8DOMWrapper::convertNewNodeToV8Object):
(WebCore::V8DOMWrapper::convertEventToV8Object):
(WebCore::V8DOMWrapper::convertEventListenerToV8Object):
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::createPatternCallback):
* bindings/v8/custom/V8CustomPositionCallback.cpp:
(WebCore::V8CustomPositionCallback::handleEvent):
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
(WebCore::V8CustomPositionErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
(WebCore::V8CustomSQLStatementCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
(WebCore::V8CustomSQLTransactionCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::V8Document::implementationAccessorGetter):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore::V8Element::setAttributeNodeCallback):
(WebCore::V8Element::setAttributeNodeNSCallback):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::namedPropertyGetter):
(WebCore::V8HTMLDocument::allAccessorGetter):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::namedPropertyGetter):
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::createInjectedScript):
(WebCore::V8InjectedScriptHost::nodeForIdCallback):
(WebCore::V8InjectedScriptHost::databaseForIdCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::portsAccessorGetter):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
(WebCore::V8NodeList::callAsFunctionCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
(WebCore::V8SVGMatrix::multiplyCallback):
(WebCore::V8SVGMatrix::inverseCallback):
(WebCore::V8SVGMatrix::rotateFromVectorCallback):
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::transformToFragmentCallback):
(WebCore::V8XSLTProcessor::transformToDocumentCallback):
2010-02-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Start unforking debugger and profiler code.
Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=34481
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/ScriptProfile.h: Added.
* bindings/js/ScriptProfiler.cpp: Added.
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
* bindings/js/ScriptProfiler.h: Added.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptProfile.h: Added.
(WebCore::ScriptProfile::create):
(WebCore::ScriptProfile::~ScriptProfile):
(WebCore::ScriptProfile::title):
(WebCore::ScriptProfile::uid):
(WebCore::ScriptProfile::ScriptProfile):
* bindings/v8/ScriptProfiler.cpp: Added.
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
* bindings/v8/ScriptProfiler.h: Added.
* bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::endGroup):
(WebCore::InspectorController::show):
(WebCore::InspectorController::setDOMStorageItem):
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::createProfileHeader):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::specialPanelForJSName):
* inspector/InspectorController.h:
(WebCore::InspectorController::searchingForNodeInPage):
* page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
* page/Console.h:
(WebCore::):
(WebCore::Console::create):
(WebCore::Console::profiles):
* page/Console.idl:
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716
- Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck()
- Introduce HTMLFormControlElement::setNeedsWillValidate()
- Introduce HTMLFormControlElement::m_hasName to make willValidate()
work in parseMappedAttribute().
- We need to call setNeedsValidityCheck() when HTMLInputElement::step or
HTMLTextAreaElement::maxLength is changed.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::formDestroyed):
(WebCore::HTMLFormControlElement::willValidate): Avoids function calls.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::disabled): Move the code from .cpp.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::setFileListFromRenderer):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
(WebCore::HTMLTextAreaElement::setValue):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::subtreeHasChanged):
2010-02-02 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Adele Peterson.
Bug 34198 - Ruby text should not inherit line-height
(https://bugs.webkit.org/show_bug.cgi?id=34198)
Resetting line-height to 'normal' in the default UA style sheet.
Adding layout-test to check for this.
Test: fast/ruby/ruby-line-height.html
* css/html.css:
2010-02-02 James Robinson <jamesr@chromium.org>
Reviewed by Dmitry Titov.
Add a null check for image, which might be NULL if tileSize is empty
https://bugs.webkit.org/show_bug.cgi?id=34510
Test: fast/gradients/crash-on-1px-border.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Tests: fast/forms/ValidityState-rangeOverflow.html
fast/forms/ValidityState-rangeUnderflow.html
* html/HTMLInputElement.cpp:
Defines the hard limits for the types as double values.
(WebCore::HTMLInputElement::rangeUnderflow): Supports the types.
(WebCore::HTMLInputElement::rangeOverflow): Supports the types.
(WebCore::HTMLInputElement::minimum): Supports the types.
(WebCore::HTMLInputElement::maximum): Supports the types.
2010-02-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket set pending activity to avoid unexpected GC.
https://bugs.webkit.org/show_bug.cgi?id=34014
Test: websocket/tests/websocket-pending-activity.html
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): set pending activity until it receives didClose.
(WebCore::WebSocket::contextDestroyed): check socket is already closed.
(WebCore::WebSocket::stop): close the connection and unset pending activity when it stops.
(WebCore::WebSocket::didClose): unset pending activity.
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data.
2010-02-02 Gustavo Noronha Silva <gns@gnome.org>
No review, rolling out r54261.
http://trac.webkit.org/changeset/54261
https://bugs.webkit.org/show_bug.cgi?id=34435
Causes crashes on release builds
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
* platform/gtk/GOwnPtrGtk.cpp: Removed.
* platform/gtk/GOwnPtrGtk.h: Removed.
2010-02-02 David Levin <levin@chromium.org>
No review, rolling out r54245.
http://trac.webkit.org/changeset/54245
https://bugs.webkit.org/show_bug.cgi?id=34492
This patch seems to have broken thousands of chromium tests on
Windows (and since it was for chromium, I'm rolling it out).
* dom/Element.cpp:
(WebCore::Element::baseURI):
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* WebCore.vcproj/QTMovieWin.rc:
2010-02-02 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r54257.
http://trac.webkit.org/changeset/54257
https://bugs.webkit.org/show_bug.cgi?id=34491
[Chromium] broke thousands of Win tests and a few of Linux tests.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::applyAntiAliasedClipPaths):
* platform/graphics/skia/PlatformContextSkia.h:
2010-02-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435
Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent not Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
* platform/gtk/GOwnPtrGtk.cpp: Added.
(WTF::SoupURI):
(WTF::GstElement):
* platform/gtk/GOwnPtrGtk.h: Added.
2010-02-02 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.
https://bugs.webkit.org/show_bug.cgi?id=32563
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptObject.cpp:
* bindings/v8/V8AbstractEventListener.cpp:
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8NodeFilterCondition.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8CustomPositionCallback.cpp:
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2010-02-02 Garret Kelly <gdk@chromium.org>
Reviewed by David Levin.
When using the Skia graphics context, the beginTransparencyLayer call
currently creates a new layer, but does not keep the current
compositing mode for use when merging the created layer back onto the
rest of the context. This patch fixes that.
https://bugs.webkit.org/show_bug.cgi?id=34491
fast/backgrounds/svg-as-mask.html is affected by this change in Chromium,
but not fixed. This is the first of a series of patches to fix it.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.h:
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=34409
Platform guards for localtime_r are not needed because we already have
WTF::getLocalTime which does the same thing.
* loader/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
* loader/FTPDirectoryParser.cpp:
(WebCore::gmtimeQt):
2010-02-02 Adam Roben <aroben@apple.com>
Copy WebCore's bindings generation scripts to the PrivateHeaders
directory on Mac
This will allow other projects to use these scripts.
Fixes <http://webkit.org/b/34498>.
Reviewed by Mark Rowe.
* WebCore.xcodeproj/project.pbxproj: Added the bindings generation
scripst to the Copy Headers phase, and marked them as Private.
2010-02-02 Adam Roben <aroben@apple.com>
Copy WebCore's bindings generation scripts to a more sensible location
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebCore.vcproj/WebCore.make:
* WebCore.vcproj/WebCoreGenerated.vcproj:
Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts.
2010-02-02 Adam Roben <aroben@apple.com>
Rename the scripts used to copy WebCore's bindings generation scripts
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts.
* WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh.
* WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames.
2010-02-02 Adam Roben <aroben@apple.com>
Stop copying IDL files into $(WebKitOutputDir)
No one uses these anymore (as of r52921).
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files
anymore. Keep copying the scripts, though, since other projects
(outside of the WebKit repository) do use those.
2010-02-02 Bryan Yeung <bryeung@google.com>
Reviewed by Darin Adler.
Avoid using an invalidated KURL object in baseURI.
https://bugs.webkit.org/show_bug.cgi?id=34492
This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
* dom/Element.cpp:
(WebCore::Element::baseURI):
2010-02-02 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34076
<rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute
Test: fast/forms/misplaced-img-form-registration.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added
to vector again.
(WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something
that's actually registered.
* html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails
to insert the image element, then there will be no removed from tree notification either,
need to unregister right away.
2010-02-02 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors
Extract OS version into WebInspector.platformFlavor
https://bugs.webkit.org/show_bug.cgi?id=34469
* inspector/front-end/InspectorBackendStub.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.platform):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
(WebInspector.pendingDispatches.0.URLRegExp.i.get platform):
(WebInspector.get platformFlavor):
(WebInspector._detectPlatformFlavor):
(WebInspector.loaded):
(WebInspector.toolbarDragStart):
(WebInspector.isMac):
2010-02-02 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds utility functions for converting between JavaInstance and NPAPI types
https://bugs.webkit.org/show_bug.cgi?id=34468
This is required by Android for injecting objects into V8 JavaScript.
No new tests, added utility functions only.
* Android.v8bindings.mk: Modified. Added JavaNPObjectV8.cpp
* bridge/jni/v8/JavaNPObjectV8.cpp: Added.
(JSC::Bindings::AllocJavaNPObject):
(JSC::Bindings::FreeJavaNPObject):
(JSC::Bindings::):
(JSC::Bindings::JavaInstanceToNPObject):
(JSC::Bindings::ExtractJavaInstance):
(JSC::Bindings::JavaNPObjectHasMethod):
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectHasProperty):
(JSC::Bindings::JavaNPObjectGetProperty):
* bridge/jni/v8/JavaNPObjectV8.h: Added.
2010-02-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Symbian plugins include a wrong header file for QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34475
* plugins/symbian/PluginViewSymbian.cpp:
2010-02-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: URLs are not syntax-higlighted as links in source view.
This change enables linkifier in the NativeTextViewer. It adds
"linkify" and "a_node" parse states into the highlighter in order
to detect links and distinguish between resource and external ones.
Contains drive-by fix for the webkit-html-* styles and moves them to the
common location.
https://bugs.webkit.org/show_bug.cgi?id=34364
* inspector/front-end/NativeTextViewer.js:
(WebInspector.NativeTextViewer):
(WebInspector.NativeTextViewer.prototype._createSpan):
(WebInspector.NativeTextViewer.prototype._createLink):
(WebInspector.NativeTextViewer.prototype._rewriteHref):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype._createEditorIfNeeded):
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer):
(WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute):
(WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue):
(WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute):
(WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue):
(WebInspector.SourceHTMLTokenizer.prototype._stringToken):
(WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType):
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype._contentLoaded):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
* inspector/front-end/inspector.css:
* inspector/front-end/inspectorSyntaxHighlight.css:
2010-02-02 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Install libraries and headers in package builds
https://bugs.webkit.org/show_bug.cgi?id=34325
Add the QtWebKit libraries to the installable items, except on
Symbian where the libraries are always linked in their final
destination.
Also include the headers generated by syncqt in the installation.
* WebCore.pro:
2010-02-02 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Dmitry Titov.
[V8] Raising an exception while setting timeout/interval from a detached frame
https://bugs.webkit.org/show_bug.cgi?id=34453
This fixes the issue/failing test mentioned in Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=32671
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port Screen
https://bugs.webkit.org/show_bug.cgi?id=34299
Get the screen size and depth from the main display bitmap.
* platform/brew/ScreenBrew.cpp: Added.
(WebCore::getDisplayInfo):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port LocalizedStrings
https://bugs.webkit.org/show_bug.cgi?id=34257
Port LocalizedStrings to BREWMP.
* platform/brew/LocalizedStringsBrew.cpp: Added.
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):
(WebCore::resetButtonDefaultLabel):
(WebCore::defaultLanguage):
(WebCore::searchableIndexIntroduction):
(WebCore::fileButtonChooseFileLabel):
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagInspectElement):
(WebCore::searchMenuNoRecentSearchesText):
(WebCore::searchMenuRecentSearchesText):
(WebCore::searchMenuClearRecentSearchesText):
(WebCore::unknownFileSizeText):
(WebCore::AXWebAreaText):
(WebCore::AXLinkText):
(WebCore::AXListMarkerText):
(WebCore::AXImageMapText):
(WebCore::AXHeadingText):
(WebCore::imageTitle):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::AXButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
(WebCore::AXDefinitionListTermText):
(WebCore::AXDefinitionListDefinitionText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port systemBeep
https://bugs.webkit.org/show_bug.cgi?id=33601
Implement systemBeep with IShell_Beep.
* platform/brew/SoundBrew.cpp: Added.
(WebCore::systemBeep):
2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Win] Utilize PrintContext to share the printing code with other ports
https://bugs.webkit.org/show_bug.cgi?id=34312
No new tests as this is just a small refactoring.
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/show_bug.cgi?id=34194
Make it easy to convert between IntPoint and AEEPoint.
* platform/graphics/IntPoint.h:
* platform/graphics/brew/IntPointBrew.cpp: Added.
(WebCore::IntPoint::IntPoint):
(WebCore::IntPoint::operator AEEPoint):
2010-02-02 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
https://bugs.webkit.org/show_bug.cgi?id=34434
No new tests, build fix only.
* bindings/v8/V8DOMMap.h: Modified.
(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.
2010-02-02 Avi Drissman <avi@chromium.org>
Reviewed by Eric Seidel.
Sync up Chromium Mac render theme to Mac render theme
https://bugs.webkit.org/show_bug.cgi?id=34340
Covered by existing layout tests.
* platform/chromium/ThemeChromiumMac.mm:
(WebCore::updateStates):
(WebCore::checkbox):
(WebCore::paintCheckbox):
(WebCore::radio):
(WebCore::paintRadio):
(WebCore::listButtonSizes):
(WebCore::setupButtonCell):
(WebCore::button):
(WebCore::paintButton):
(WebCore::ThemeChromiumMac::controlSize):
(WebCore::ThemeChromiumMac::minimumControlSize):
(WebCore::ThemeChromiumMac::controlBorder):
(WebCore::ThemeChromiumMac::paint):
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(WebCore::convertNSColorToColor):
(WebCore::RenderThemeChromiumMac::systemColor):
(WebCore::RenderThemeChromiumMac::isControlStyled):
(WebCore::RenderThemeChromiumMac::adjustRepaintRect):
(WebCore::RenderThemeChromiumMac::convertToPaintingRect):
(WebCore::RenderThemeChromiumMac::paintCapsLockIndicator):
(WebCore::RenderThemeChromiumMac::paintMenuList):
(WebCore::RenderThemeChromiumMac::paintMenuListButton):
(WebCore::RenderThemeChromiumMac::adjustMenuListStyle):
(WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeChromiumMac::paintSliderTrack):
(WebCore::RenderThemeChromiumMac::paintSliderThumb):
(WebCore::RenderThemeChromiumMac::paintSearchField):
(WebCore::RenderThemeChromiumMac::setSearchFieldSize):
(WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle):
(WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumMac::popupButton):
(WebCore::RenderThemeChromiumMac::sliderThumbHorizontal):
(WebCore::RenderThemeChromiumMac::sliderThumbVertical):
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port Logging
https://bugs.webkit.org/show_bug.cgi?id=34300
Log calls to notImplemented() by default.
* platform/brew/LoggingBrew.cpp: Added.
(WebCore::InitializeLoggingChannelsIfNecessary):
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port FileChooser
https://bugs.webkit.org/show_bug.cgi?id=34261
Port FileChooser to BREWMP.
* platform/brew/FileChooserBrew.cpp: Added.
(WebCore::FileChooser::basenameForWidth):
2010-02-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for IconDatabaseClient class
https://bugs.webkit.org/show_bug.cgi?id=33252
Inherits the following struct from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class IconDatabaseClient - loader/icon/IconDatabase.cpp:89
* loader/icon/IconDatabaseClient.h:
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=34220
Port MIMETypeRegistry with an extension map as other ports do.
* platform/brew: Added.
* platform/brew/MIMETypeRegistryBrew.cpp: Added.
(WebCore::):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2010-02-01 Dmitry Titov <dimich@chromium.org>
Not reviewed, revert r54194 that fails new test on Qt and Chromium.
https://bugs.webkit.org/show_bug.cgi?id=34382
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
* html/HTMLFrameElementBase.h:
* page/Frame.cpp:
* page/Frame.h:
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840
Test: printing/page-break-always.html
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* page/PrintContext.cpp:
(WebCore::PrintContext::pageRect): Added a getter function.
(WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize.
(WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement.
(WebCore::enclosingBoxModelObject): Added for pageNumberForElement.
(WebCore::PrintContext::pageNumberForElement): Added for testing.
* page/PrintContext.h:
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add conversions between IntSize and AEESize
https://bugs.webkit.org/show_bug.cgi?id=34197
Make it easy to convert between IntSize and AEESize.
* platform/graphics/IntSize.h:
* platform/graphics/brew/IntSizeBrew.cpp: Added.
(WebCore::IntSize::IntSize):
(WebCore::IntSize::operator AEESize):
2010-02-01 Stephen White <senorblanco@chromium.org>
Reviewed by Eric Seidel.
Fix for Pattern transformations in Chromium/Skia. This required
reworking Pattern a bit to be more like the Gradient implementation.
In particular, it now holds an m_pattern reference to the
platform-specific implementation, and passes along changes to the
m_patternSpaceTransformation, in the same way that Gradient does for
m_gradientSpaceTransformation. This is necessary since Skia creates the
platform-specific pattern (SkShader) once, rather than recreating it
on each draw.
For platforms other than Skia, m_pattern is unused, they will
continue to use the static createPlatformPattern(), and the new
notification functions are stubbed out. Other platforms can switch to
the new implementation if they so choose.
https://bugs.webkit.org/show_bug.cgi?id=24534
Covered by svg/custom/pattern-y-offset.svg,
svg/custom/pattern-cycle-detection.svg, and many more.
* platform/graphics/Pattern.cpp:
(WebCore::Pattern::Pattern):
Initializer for m_pattern.
(WebCore::Pattern::~Pattern):
call platformDestroy().
(WebCore::Pattern::setPatternSpaceTransform):
Pass along the transform via setPlatformPatternSpaceTransform().
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::setPlatformPatternSpaceTransform):
Stub implementations for non-skia platforms.
* platform/graphics/Pattern.h:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
Call platformPattern() instead of static version.
Since Pattern now owns its SkShader, no need to unref here.
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
Unref the SkShader on destroy.
(WebCore::Pattern::platformPattern):
Create the platform pattern (SkShader) once, and cache it.
(WebCore::Pattern::setPlatformPatternSpaceTransform):
Set the shader's local matrix from the m_patternSpaceTransformation.
2010-02-01 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27312
Implements support for full page blocking via the X-XSS-Protection header.
Tests: http/tests/security/xssAuditor/full-block-base-href.html
http/tests/security/xssAuditor/full-block-get-from-iframe.html
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
http/tests/security/xssAuditor/full-block-javascript-link.html
http/tests/security/xssAuditor/full-block-link-onclick.html
http/tests/security/xssAuditor/full-block-object-tag.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/full-block-script-tag-with-source.html
http/tests/security/xssAuditor/full-block-script-tag.html
http/tests/security/xssAuditor/malformed-xss-protection-header.html
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added.
(WebCore::XSSAuditor::findInRequest): Modified to call method
XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
* page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader
and fixed misspelled words in large comment block.
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port SharedTimer with IShell_SetTimerEx.
https://bugs.webkit.org/show_bug.cgi?id=33599
As fireTime passed in setSharedTimerFireTime is the absolute time,
we must calcalute the interval by subtracting currentTime() from
fireTime and pass the result to ISHELL_SetTimerEx.
* platform/brew/SharedTimerBrew.cpp: Added.
(WebCore::invokeCallback):
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireTime):
(WebCore::stopSharedTimer):
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
[Chromium] Unreviewed attempt to fix the chromium build.
Corresponding change: http://trac.webkit.org/changeset/54182
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
* bindings/v8/ScriptController.h:
2010-02-01 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382
Test: fast/frames/iframe-reparenting-new-page.html
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
* html/HTMLFrameElementBase.h:
* page/Frame.cpp:
(WebCore::Frame::setPage):
* page/Frame.h: Add setPage method. It is only currently used when iframe is
moved between pages (so the ASSERT(m_ownerElement).
2010-02-01 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher.
Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451
* platform/KURL.cpp:
(WebCore::portAllowed):
2010-01-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
[V8] Add compile time guards for IndexedDB custom functions
https://bugs.webkit.org/show_bug.cgi?id=34368
* bindings/v8/custom/V8IDBRequestCustom.cpp:
* bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
2010-01-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig + Oliver Hunt.
Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean. This may be passed from the JSC bindings (where we have an exec state),
or read from the event. Add a Flag to the IDL to mark this information is required.
* WebCore.Video.exp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::processingUserGesture):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):
* bindings/js/ScriptController.h:
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Event.cpp:
(WebCore::Event::isUserEvent):
* dom/Event.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::isProcessingUserGesture):
* loader/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlSeekButtonElement::defaultEventHandler):
2010-02-01 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use the fallback style on Maemo 5
https://bugs.webkit.org/show_bug.cgi?id=34376
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
* platform/qt/RenderThemeQt.h:
2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Nate Chapin.
[V8] Making V8 generated classes' GetTemplate() function public
https://bugs.webkit.org/show_bug.cgi?id=34026
* bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
2010-02-01 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds V8-specific JNI bridge classes
https://bugs.webkit.org/show_bug.cgi?id=34166
This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.
No new tests, build fix only.
* Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
* bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
* bridge/jni/v8/JNIBridgeV8.cpp: Added.
(JavaField::JavaField):
* bridge/jni/v8/JNIBridgeV8.h: Added.
(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):
2010-02-01 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds V8-specific JNI utility functions.
https://bugs.webkit.org/show_bug.cgi?id=33901
This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.
No new tests, build fix only.
* Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
* bridge/jni/v8/JNIUtilityPrivate.cpp: Added.
(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):
* bridge/jni/v8/JNIUtilityPrivate.h: Added.
2010-02-01 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds V8 version of JavaClass
https://bugs.webkit.org/show_bug.cgi?id=33898
This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC
No new tests, build fix only.
* Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
* bridge/jni/v8/JavaClassV8.cpp: Added.
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
* bridge/jni/v8/JavaClassV8.h: Added.
2010-02-01 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds V8 version of JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=33951
This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.
No new tests, build fix only.
* Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
* bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.
(JavaInstance::invokeMethod): Modified. Fixed comment
* bridge/jni/v8/JavaInstanceV8.cpp: Added.
(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):
* bridge/jni/v8/JavaInstanceV8.h: Added.
(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):
2010-02-01 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.
https://bugs.webkit.org/show_bug.cgi?id=34152
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::stop):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
* storage/SQLTransaction.h:
* storage/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::shutdown):
2010-02-01 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
2010-02-01 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium build fix.
Failed to properly add new files for http://trac.webkit.org/changeset/54150.
* bindings/v8/custom/V8BarInfoCustom.cpp: Added.
* bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
* bindings/v8/custom/V8CSSValueCustom.cpp: Added.
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
* bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
* bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
* bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
* bindings/v8/custom/V8SVGElementCustom.cpp: Added.
* bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
* bindings/v8/custom/V8ScreenCustom.cpp: Added.
* bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
* bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Add support for addUserScript to chromium port.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/v8/ScriptController.h:
2010-02-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=34448
<rdar://problem/7598130>
RenderVideo::intrinsicSizeChanged infinite recursion
* rendering/RenderImage.h:
(WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can
be called by RenderVideo.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not
RenderVideo::intrinsicSizeChanged.
(WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of
RenderImage::imageChanged.
2010-02-01 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Generate toV8() converter for most WebCore->V8 conversions,
and defined custom converters in their respective V8<class>Custom.cpp.
Old converters in V8DOMWrapper will be deleted in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=32563
* Android.v8bindings.mk:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8BarInfoCustom.cpp: Added.
* bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
* bindings/v8/custom/V8CSSValueCustom.cpp: Added.
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8ConsoleCustom.cpp:
* bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8HistoryCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NavigatorCustom.cpp:
* bindings/v8/custom/V8NodeCustom.cpp:
* bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
* bindings/v8/custom/V8SVGElementCustom.cpp: Added.
* bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
* bindings/v8/custom/V8ScreenCustom.cpp: Added.
* bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
* bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
* dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
2010-02-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: lazy-load textual resources to avoid UI hangup
https://bugs.webkit.org/show_bug.cgi?id=34332
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.prototype._innerSelectContentTab):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.show):
(WebInspector.SourceView.prototype.contentTabSelected):
2010-02-01 Brady Eidson <beidson@apple.com>
Reviewed by Adele Peterson.
Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
Test: fast/loader/crash-copying-backforwardlist.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): Null check currentItem().
* page/Page.cpp:
(WebCore::Page::goToItem): Ditto.
2010-02-01 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Remove unused file that doesn't seem to belong to the port.
https://bugs.webkit.org/show_bug.cgi?id=34445
* platform/wx/KeyEventWin.cpp: Removed.
2010-02-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438
Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::paint): Removed outdated FIXME.
(WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto.
(WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement.
(WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto.
(WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto.
(WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
* html/HTMLVideoElement.h:
* html/HTMLVideoElement.idl:
2010-02-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Syntax highlighting in source view of
Resources pane stops half-way.
There were two problems here: (1) styles for html highlighter were not
added into the css file (they used to be injected manually in the
SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
Otherwise unbalanced quotes in the text nodes were matching too match
into the string tokens.
https://bugs.webkit.org/show_bug.cgi?id=34359
* inspector/front-end/NativeTextViewer.js:
(WebInspector.NativeTextViewer.prototype._createLineDivs):
(WebInspector.NativeTextViewer.prototype._lineHeight):
(WebInspector.NativeTextViewer.prototype.initFontMetrics):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createEditorIfNeeded):
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer):
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.initFontMetrics):
(WebInspector.TextEditor.prototype._registerShortcuts):
* inspector/front-end/inspectorSyntaxHighlight.css:
2010-02-01 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
https://bugs.webkit.org/show_bug.cgi?id=34335
* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.
2010-02-01 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.
No new tests. The new AffineTransformation code is tested by fast/canvas.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::willDraw):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/Path.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::transform):
* platform/graphics/cairo/TransformationMatrixCairo.cpp:
(WebCore::AffineTransform::operator cairo_matrix_t):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::getAffineCTM):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::transform):
* platform/graphics/cg/TransformationMatrixCG.cpp:
(WebCore::AffineTransform::operator CGAffineTransform):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/haiku/PathHaiku.cpp:
(WebCore::Path::transform):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::transform):
* platform/graphics/qt/TransformationMatrixQt.cpp:
(WebCore::AffineTransform::operator QTransform):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::getAffineCTM):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::transform):
* platform/graphics/skia/TransformationMatrixSkia.cpp:
(WebCore::AffineTransform::operator SkMatrix):
* platform/graphics/transforms/AffineTransform.cpp: Added.
(WebCore::affineTransformDecompose):
(WebCore::affineTransformCompose):
(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::reset):
(WebCore::AffineTransform::setMatrix):
(WebCore::AffineTransform::isIdentity):
(WebCore::AffineTransform::det):
(WebCore::AffineTransform::isInvertible):
(WebCore::AffineTransform::inverse):
(WebCore::AffineTransform::multiply):
(WebCore::AffineTransform::multLeft):
(WebCore::AffineTransform::rotate):
(WebCore::AffineTransform::scale):
(WebCore::AffineTransform::translate):
(WebCore::AffineTransform::scaleNonUniform):
(WebCore::AffineTransform::rotateFromVector):
(WebCore::AffineTransform::flipX):
(WebCore::AffineTransform::flipY):
(WebCore::AffineTransform::shear):
(WebCore::AffineTransform::skew):
(WebCore::AffineTransform::skewX):
(WebCore::AffineTransform::skewY):
(WebCore::makeMapBetweenRects):
(WebCore::AffineTransform::map):
(WebCore::AffineTransform::mapPoint):
(WebCore::AffineTransform::mapRect):
(WebCore::AffineTransform::blend):
(WebCore::AffineTransform::toTransformationMatrix):
* platform/graphics/transforms/AffineTransform.h: Added.
(WebCore::AffineTransform::a):
(WebCore::AffineTransform::setA):
(WebCore::AffineTransform::b):
(WebCore::AffineTransform::setB):
(WebCore::AffineTransform::c):
(WebCore::AffineTransform::setC):
(WebCore::AffineTransform::d):
(WebCore::AffineTransform::setD):
(WebCore::AffineTransform::e):
(WebCore::AffineTransform::setE):
(WebCore::AffineTransform::f):
(WebCore::AffineTransform::setF):
(WebCore::AffineTransform::operator== ):
(WebCore::AffineTransform::operator!=):
(WebCore::AffineTransform::operator*=):
(WebCore::AffineTransform::operator*):
(WebCore::AffineTransform::setMatrix):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::getAffineCTM):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::transform):
* platform/graphics/wx/TransformationMatrixWx.cpp:
(WebCore::AffineTransform::operator wxGraphicsMatrix):
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586
New API in MediaPlayer for mute control. 3 new methods are
introduced:
- bool supportsMuting() const;
- bool muted() const;
- void setMuted(bool);
Platform MediaPlayer implementations can support it easily if the
underlying sound daemon/API supports muting (eg. not only setting
volume to 0) like PulseAudio for instance on Linux. At the moment
the only player supporting this new API is the
MediaPlayerPrivateGStreamer.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
(WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::supportsMuting):
(WebCore::NullMediaPlayerPrivate::setMuted):
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::muted):
(WebCore::MediaPlayer::supportsMuting):
(WebCore::MediaPlayer::setMuted):
(WebCore::MediaPlayer::volumeChanged):
(WebCore::MediaPlayer::muteChanged):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsMuting):
(WebCore::MediaPlayerPrivateInterface::setMuted):
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateVolumeChangedCallback):
(WebCore::notifyVolumeIdleCallback):
(WebCore::mediaPlayerPrivateMuteChangedCallback):
(WebCore::notifyMuteIdleCallback):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::volumeChangedCallback):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::muteChangedCallback):
(WebCore::MediaPlayerPrivate::muteChanged):
(WebCore::MediaPlayerPrivate::createGSTPlayBin):
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-02-01 Henry Haverinen <henry.haverinen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Build without SSL support is broken
Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.
https://bugs.webkit.org/show_bug.cgi?id=34416
* platform/network/qt/SocketStreamHandlePrivate.h:
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):
2010-02-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).
* inspector/front-end/NativeTextViewer.js:
(WebInspector.NativeTextViewer):
(WebInspector.NativeTextViewer.prototype._updatePreferredSize):
(WebInspector.NativeTextViewer.prototype._registerMouseListeners):
(WebInspector.NativeTextViewer.prototype._mouseDown):
(WebInspector.NativeTextViewer.prototype._contextMenu):
(WebInspector.NativeTextViewer.prototype._lineForMouseEvent):
(WebInspector.NativeTextViewer.prototype._lineHeight):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype._registerMouseListeners):
(WebInspector.TextEditor.prototype._offsetToLine):
(WebInspector.TextEditor.prototype._lineHeight):
(WebInspector.TextEditor.prototype.reveal):
(WebInspector.TextEditor.prototype._paint):
(WebInspector.TextEditor.prototype._updateDivDecorations):
(WebInspector.TextEditor.prototype._paintSelection):
2010-02-01 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds implementation of JavaString for V8.
https://bugs.webkit.org/show_bug.cgi?id=33953
No new tests, build fix only.
* bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
* bridge/jni/v8: Added.
* bridge/jni/v8/JavaStringV8.h: Added.
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
2010-02-01 Alex Milowski <alex@milowski.com>
Reviewed by Darin Adler.
Added compile time debug support for mathml layout (block boundary & baseline)
* mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::stretchToHeight):
(WebCore::RenderMathMLBlock::paint):
* mathml/RenderMathMLBlock.h:
2010-02-01 Philippe Normand <pnormand@igalia.com>
Rubber stamped by Xan Lopez.
Fixed compilation warning about unsigned vs signed comparison.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::paint):
2010-01-31 Kent Tamura <tkent@chromium.org>
Unreviewed. Revert r54112 and r54124 because of Windows build error.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::willDraw):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/Path.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/cairo/PathCairo.cpp:
* platform/graphics/cairo/TransformationMatrixCairo.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/cg/TransformationMatrixCG.cpp:
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
* platform/graphics/haiku/PathHaiku.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/qt/PathQt.cpp:
* platform/graphics/qt/TransformationMatrixQt.cpp:
* platform/graphics/skia/GraphicsContextSkia.cpp:
* platform/graphics/skia/PathSkia.cpp:
* platform/graphics/skia/TransformationMatrixSkia.cpp:
* platform/graphics/transforms/AffineTransform.cpp: Removed.
* platform/graphics/transforms/AffineTransform.h: Removed.
* platform/graphics/wince/GraphicsContextWince.cpp:
* platform/graphics/wx/GraphicsContextWx.cpp:
* platform/graphics/wx/PathWx.cpp:
* platform/graphics/wx/TransformationMatrixWx.cpp:
(WebCore::TransformationMatrix::operator wxGraphicsMatrix):
2010-01-31 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Limit the scope of packing alignment to avoid MSVC C4103 warning.
https://bugs.webkit.org/show_bug.cgi?id=34390
Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.
* bindings/js/JSSVGPODTypeWrapper.h:
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix valueAsNumber calculation for type=month.
https://bugs.webkit.org/show_bug.cgi?id=34304
valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.
* html/DateComponents.cpp:
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::monthsSinceEpoch):
* html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseToDouble):
Switch to monthsSinceEpoch() for type=MONTH.
(WebCore::HTMLInputElement::valueAsDate):
Add code with millisecondsSinceEpoch() for MONTH because
parseToDouble() changed its behavior.
(WebCore::HTMLInputElement::setValueAsNumber):
Use setMonthsSinceEpoch() for MONTH.
2010-01-31 Dan Bernstein <mitz@apple.com>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
https://bugs.webkit.org/show_bug.cgi?id=34398
* inspector/front-end/inspector.css: Specify line-height: normal for
".console-message .bubble" and ".sidebar-tree-item .status .bubble".
2010-01-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Implement CSSOM Range.getClientRects for collapsed selections
https://bugs.webkit.org/show_bug.cgi?id=34239
When getting the quads for a range on a text node, allow returning
zero width quads. This leaves the case of collapsed selections inside
elements still not fixed, but no worse.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteQuadsForRange):
2010-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808
Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::isIdentityOrTranslation):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData):
(WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData):
(WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer):
(WebCore::RenderBoxModelScaleData::size):
(WebCore::RenderBoxModelScaleData::setSize):
(WebCore::RenderBoxModelScaleData::lastPaintTime):
(WebCore::RenderBoxModelScaleData::setLastPaintTime):
(WebCore::RenderBoxModelScaleData::useLowQualityScale):
(WebCore::RenderBoxModelScaleData::transform):
(WebCore::RenderBoxModelScaleData::setTransform):
(WebCore::RenderBoxModelScaleData::setUseLowQualityScale):
(WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed):
(WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired):
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
(WebCore::RenderBoxModelObject::highQualityRepaintTimerFired):
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderBoxModelObject.h:
2010-01-31 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.
No new tests. The new AffineTransformation code is tested by fast/canvas.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::willDraw):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/Path.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::transform):
* platform/graphics/cairo/TransformationMatrixCairo.cpp:
(WebCore::AffineTransform::operator cairo_matrix_t):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::getAffineCTM):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::transform):
* platform/graphics/cg/TransformationMatrixCG.cpp:
(WebCore::AffineTransform::operator CGAffineTransform):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/haiku/PathHaiku.cpp:
(WebCore::Path::transform):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::transform):
* platform/graphics/qt/TransformationMatrixQt.cpp:
(WebCore::AffineTransform::operator QTransform):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::getAffineCTM):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::transform):
* platform/graphics/skia/TransformationMatrixSkia.cpp:
(WebCore::AffineTransform::operator SkMatrix):
* platform/graphics/transforms/AffineTransform.cpp: Added.
(WebCore::affineTransformDecompose):
(WebCore::affineTransformCompose):
(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::reset):
(WebCore::AffineTransform::setMatrix):
(WebCore::AffineTransform::isIdentity):
(WebCore::AffineTransform::det):
(WebCore::AffineTransform::isInvertible):
(WebCore::AffineTransform::inverse):
(WebCore::AffineTransform::multiply):
(WebCore::AffineTransform::multLeft):
(WebCore::AffineTransform::rotate):
(WebCore::AffineTransform::scale):
(WebCore::AffineTransform::translate):
(WebCore::AffineTransform::scaleNonUniform):
(WebCore::AffineTransform::rotateFromVector):
(WebCore::AffineTransform::flipX):
(WebCore::AffineTransform::flipY):
(WebCore::AffineTransform::shear):
(WebCore::AffineTransform::skew):
(WebCore::AffineTransform::skewX):
(WebCore::AffineTransform::skewY):
(WebCore::makeMapBetweenRects):
(WebCore::AffineTransform::map):
(WebCore::AffineTransform::mapPoint):
(WebCore::AffineTransform::mapRect):
(WebCore::AffineTransform::blend):
* platform/graphics/transforms/AffineTransform.h: Added.
(WebCore::AffineTransform::a):
(WebCore::AffineTransform::setA):
(WebCore::AffineTransform::b):
(WebCore::AffineTransform::setB):
(WebCore::AffineTransform::c):
(WebCore::AffineTransform::setC):
(WebCore::AffineTransform::d):
(WebCore::AffineTransform::setD):
(WebCore::AffineTransform::e):
(WebCore::AffineTransform::setE):
(WebCore::AffineTransform::f):
(WebCore::AffineTransform::setF):
(WebCore::AffineTransform::operator== ):
(WebCore::AffineTransform::operator!=):
(WebCore::AffineTransform::operator*=):
(WebCore::AffineTransform::operator*):
(WebCore::AffineTransform::setMatrix):
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::getAffineCTM):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getAffineCTM):
(WebCore::GraphicsContext::concatCTM):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::transform):
* platform/graphics/wx/TransformationMatrixWx.cpp:
(WebCore::AffineTransform::operator wxGraphicsMatrix):
2010-01-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] Breakpoint source line is not displayed
in the breakpoint manager.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
2010-01-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Introduce NativeTextViewer.
This change handles rendering highlighted text, using browser's
selection/drag/drop/click logic. Breakpoint decorations and
program counter is working.
Todo: line numbers are painted 'under' the text when scrolling
horizontally, search is not yet implemented.
https://bugs.webkit.org/show_bug.cgi?id=34391
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DivBasedTextViewer.js: Added.
(WebInspector.DivBasedTextViewer):
(WebInspector.DivBasedTextViewer.prototype._textChanged):
(WebInspector.DivBasedTextViewer.prototype._createLineDivs):
(WebInspector.DivBasedTextViewer.prototype._updatePreferredSize):
(WebInspector.DivBasedTextViewer.prototype._scroll):
(WebInspector.DivBasedTextViewer.prototype._registerMouseListeners):
(WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners):
(WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners):
(WebInspector.DivBasedTextViewer.prototype._paintSelection):
(WebInspector.DivBasedTextViewer.prototype._positionDivDecoration):
(WebInspector.DivBasedTextViewer.prototype._mouseDown):
(WebInspector.DivBasedTextViewer.prototype._contextMenu):
(WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent):
(WebInspector.DivBasedTextViewer.prototype._paintLine):
(WebInspector.DivBasedTextViewer.prototype._createSpan):
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.sizeToFitContentHeight):
(WebInspector.SourceFrame.prototype._createEditorIfNeeded):
(WebInspector.SourceFrame.prototype._addMessageToSource):
(WebInspector.SourceFrame.prototype.resize):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.setDivDecoration):
(WebInspector.TextEditor.prototype._registerMouseListeners):
(WebInspector.TextEditor.prototype._registerKeyboardListeners):
(WebInspector.TextEditor.prototype._registerClipboardListeners):
(WebInspector.TextEditor.prototype.reveal):
(WebInspector.TextEditor.prototype._textChanged):
(WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint):
(WebInspector.TextEditor.prototype._updatePreferredSize):
(WebInspector.TextEditor.prototype.resize):
(WebInspector.TextEditor.prototype._paintLinesContinuation):
(WebInspector.TextEditor.prototype._paintLine):
(WebInspector.TextEditor.prototype._contextMenu):
(WebInspector.TextEditor.prototype._caretForMouseEvent):
(WebInspector.TextEditor.prototype._changeFont):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype._lex):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/textEditor.css:
2010-01-31 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms
https://bugs.webkit.org/show_bug.cgi?id=34168
Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded
and Symbian
* WebCore.pro:
2010-01-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.
https://bugs.webkit.org/show_bug.cgi?id=34266
* bindings/v8/ScriptState.cpp:
* bindings/v8/ScriptState.h:
2010-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Use CGGradient on Leopard and later, since it's faster than CGShading
https://bugs.webkit.org/show_bug.cgi?id=34384
Use CGGradient on Leopard and later, rather than CGShading, for
performance.
* platform/graphics/Gradient.h:
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops.
Did not call this from getColor() to avoid overhead of a function call.
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger.
(WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger.
(WebCore::Gradient::fill): Call new paint() method.
(WebCore::Gradient::paint): New convenence method that avoids testing
isRadial() in a bunch of other places.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath): Call the gradient's paint() method.
(WebCore::GraphicsContext::strokePath): Ditto
(WebCore::GraphicsContext::fillRect): Ditto
(WebCore::GraphicsContext::strokeRect): Ditto
2010-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adele Peterson.
Do color animations on premultiplied colors
https://bugs.webkit.org/show_bug.cgi?id=34383
Convert colors to premultiplied alpha before interpolating them,
then convert the result back to non-premultiplied. This gives better
results when animating from transparent colors.
Test: transitions/color-transition-premultiplied.html
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
2010-01-30 Gustavo Noronha Silva <gns@gnome.org>
Build fixes needed for make distcheck.
* GNUmakefile.am:
2010-01-29 Mark Rowe <mrowe@apple.com>
Stop copying an IDL file in to the framework wrapper.
* WebCore.xcodeproj/project.pbxproj:
2010-01-29 Mark Rowe <mrowe@apple.com>
Sort Xcode projects.
* WebCore.xcodeproj/project.pbxproj:
== Rolled over to ChangeLog-2010-01-29 ==
|