1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491 8492 8493 8494 8495 8496 8497 8498 8499 8500 8501 8502 8503 8504 8505 8506 8507 8508 8509 8510 8511 8512 8513 8514 8515 8516 8517 8518 8519 8520 8521 8522 8523 8524 8525 8526 8527 8528 8529 8530 8531 8532 8533 8534 8535 8536 8537 8538 8539 8540 8541 8542 8543 8544 8545 8546 8547 8548 8549 8550 8551 8552 8553 8554 8555 8556 8557 8558 8559 8560 8561 8562 8563 8564 8565 8566 8567 8568 8569 8570 8571 8572 8573 8574 8575 8576 8577 8578 8579 8580 8581 8582 8583 8584 8585 8586 8587 8588 8589 8590 8591 8592 8593 8594 8595 8596 8597 8598 8599 8600 8601 8602 8603 8604 8605 8606 8607 8608 8609 8610 8611 8612 8613 8614 8615 8616 8617 8618 8619 8620 8621 8622 8623 8624 8625 8626 8627 8628 8629 8630 8631 8632 8633 8634 8635 8636 8637 8638 8639 8640 8641 8642 8643 8644 8645 8646 8647 8648 8649 8650 8651 8652 8653 8654 8655 8656 8657 8658 8659 8660 8661 8662 8663 8664 8665 8666 8667 8668 8669 8670 8671 8672 8673 8674 8675 8676 8677 8678 8679 8680 8681 8682 8683 8684 8685 8686 8687 8688 8689 8690 8691 8692 8693 8694 8695 8696 8697 8698 8699 8700 8701 8702 8703 8704 8705 8706 8707 8708 8709 8710 8711 8712 8713 8714 8715 8716 8717 8718 8719 8720 8721 8722 8723 8724 8725 8726 8727 8728 8729 8730 8731 8732 8733 8734 8735 8736 8737 8738 8739 8740 8741 8742 8743 8744 8745 8746 8747 8748 8749 8750 8751 8752 8753 8754 8755 8756 8757 8758 8759 8760 8761 8762 8763 8764 8765 8766 8767 8768 8769 8770 8771 8772 8773 8774 8775 8776 8777 8778 8779 8780 8781 8782 8783 8784 8785 8786 8787 8788 8789 8790 8791 8792 8793 8794 8795 8796 8797 8798 8799 8800 8801 8802 8803 8804 8805 8806 8807 8808 8809 8810 8811 8812 8813 8814 8815 8816 8817 8818 8819 8820 8821 8822 8823 8824 8825 8826 8827 8828 8829 8830 8831 8832 8833 8834 8835 8836 8837 8838 8839 8840 8841 8842 8843 8844 8845 8846 8847 8848 8849 8850 8851 8852 8853 8854 8855 8856 8857 8858 8859 8860 8861 8862 8863 8864 8865 8866 8867 8868 8869 8870 8871 8872 8873 8874 8875 8876 8877 8878 8879 8880 8881 8882 8883 8884 8885 8886 8887 8888 8889 8890 8891 8892 8893 8894 8895 8896 8897 8898 8899 8900 8901 8902 8903 8904 8905 8906 8907 8908 8909 8910 8911 8912 8913 8914 8915 8916 8917 8918 8919 8920 8921 8922 8923 8924 8925 8926 8927 8928 8929 8930 8931 8932 8933 8934 8935 8936 8937 8938 8939 8940 8941 8942 8943 8944 8945 8946 8947 8948 8949 8950 8951 8952 8953 8954 8955 8956 8957 8958 8959 8960 8961 8962 8963 8964 8965 8966 8967 8968 8969 8970 8971 8972 8973 8974 8975 8976 8977 8978 8979 8980 8981 8982 8983 8984 8985 8986 8987 8988 8989 8990 8991 8992 8993 8994 8995 8996 8997 8998 8999 9000 9001 9002 9003 9004 9005 9006 9007 9008 9009 9010 9011 9012 9013 9014 9015 9016 9017 9018 9019 9020 9021 9022 9023 9024 9025 9026 9027 9028 9029 9030 9031 9032 9033 9034 9035 9036 9037 9038 9039 9040 9041 9042 9043 9044 9045 9046 9047 9048 9049 9050 9051 9052 9053 9054 9055 9056 9057 9058 9059 9060 9061 9062 9063 9064 9065 9066 9067 9068 9069 9070 9071 9072 9073 9074 9075 9076 9077 9078 9079 9080 9081 9082 9083 9084 9085 9086 9087 9088 9089 9090 9091 9092 9093 9094 9095 9096 9097 9098 9099 9100 9101 9102 9103 9104 9105 9106 9107 9108 9109 9110 9111 9112 9113 9114 9115 9116 9117 9118 9119 9120 9121 9122 9123 9124 9125 9126 9127 9128 9129 9130 9131 9132 9133 9134 9135 9136 9137 9138 9139 9140 9141 9142 9143 9144 9145 9146 9147 9148 9149 9150 9151 9152 9153 9154 9155 9156 9157 9158 9159 9160 9161 9162 9163 9164 9165 9166 9167 9168 9169 9170 9171 9172 9173 9174 9175 9176 9177 9178 9179 9180 9181 9182 9183 9184 9185 9186 9187 9188 9189 9190 9191 9192 9193 9194 9195 9196 9197 9198 9199 9200 9201 9202 9203 9204 9205 9206 9207 9208 9209 9210 9211 9212 9213 9214 9215 9216 9217 9218 9219 9220 9221 9222 9223 9224 9225 9226 9227 9228 9229 9230 9231 9232 9233 9234 9235 9236 9237 9238 9239 9240 9241 9242 9243 9244 9245 9246 9247 9248 9249 9250 9251 9252 9253 9254 9255 9256 9257 9258 9259 9260 9261 9262 9263 9264 9265 9266 9267 9268 9269 9270 9271 9272 9273 9274 9275 9276 9277 9278 9279 9280 9281 9282 9283 9284 9285 9286 9287 9288 9289 9290 9291 9292 9293 9294 9295 9296 9297 9298 9299 9300 9301 9302 9303 9304 9305 9306 9307 9308 9309 9310 9311 9312 9313 9314 9315 9316 9317 9318 9319 9320 9321 9322 9323 9324 9325 9326 9327 9328 9329 9330 9331 9332 9333 9334 9335 9336 9337 9338 9339 9340 9341 9342 9343 9344 9345 9346 9347 9348 9349 9350 9351 9352 9353 9354 9355 9356 9357 9358 9359 9360 9361 9362 9363 9364 9365 9366 9367 9368 9369 9370 9371 9372 9373 9374 9375 9376 9377 9378 9379 9380 9381 9382 9383 9384 9385 9386 9387 9388 9389 9390 9391 9392 9393 9394 9395 9396 9397 9398 9399 9400 9401 9402 9403 9404 9405 9406 9407 9408 9409 9410 9411 9412 9413 9414 9415 9416 9417 9418 9419 9420 9421 9422 9423 9424 9425 9426 9427 9428 9429 9430 9431 9432 9433 9434 9435 9436 9437 9438 9439 9440 9441 9442 9443 9444 9445 9446 9447 9448 9449 9450 9451 9452 9453 9454 9455 9456 9457 9458 9459 9460 9461 9462 9463 9464 9465 9466 9467 9468 9469 9470 9471 9472 9473 9474 9475 9476 9477 9478 9479 9480 9481 9482 9483 9484 9485 9486 9487 9488 9489 9490 9491 9492 9493 9494 9495 9496 9497 9498 9499 9500 9501 9502 9503 9504 9505 9506 9507 9508 9509 9510 9511 9512 9513 9514 9515 9516 9517 9518 9519 9520 9521 9522 9523 9524 9525 9526 9527 9528 9529 9530 9531 9532 9533 9534 9535 9536 9537 9538 9539 9540 9541 9542 9543 9544 9545 9546 9547 9548 9549 9550 9551 9552 9553 9554 9555 9556 9557 9558 9559 9560 9561 9562 9563 9564 9565 9566 9567 9568 9569 9570 9571 9572 9573 9574 9575 9576 9577 9578 9579 9580 9581 9582 9583 9584 9585 9586 9587 9588 9589 9590 9591 9592 9593 9594 9595 9596 9597 9598 9599 9600 9601 9602 9603 9604 9605 9606 9607 9608 9609 9610 9611 9612 9613 9614 9615 9616 9617 9618 9619 9620 9621 9622 9623 9624 9625 9626 9627 9628 9629 9630 9631 9632 9633 9634 9635 9636 9637 9638 9639 9640 9641 9642 9643 9644 9645 9646 9647 9648 9649 9650 9651 9652 9653 9654 9655 9656 9657 9658 9659 9660 9661 9662 9663 9664 9665 9666 9667 9668 9669 9670 9671 9672 9673 9674 9675 9676 9677 9678 9679 9680 9681 9682 9683 9684 9685 9686 9687 9688 9689 9690 9691 9692 9693 9694 9695 9696 9697 9698 9699 9700 9701 9702 9703 9704 9705 9706 9707 9708 9709 9710 9711 9712 9713 9714 9715 9716 9717 9718 9719 9720 9721 9722 9723 9724 9725 9726 9727 9728 9729 9730 9731 9732 9733 9734 9735 9736 9737 9738 9739 9740 9741 9742 9743 9744 9745 9746 9747 9748 9749 9750 9751 9752 9753 9754 9755 9756 9757 9758 9759 9760 9761 9762 9763 9764 9765 9766 9767 9768 9769 9770 9771 9772 9773 9774 9775 9776 9777 9778 9779 9780 9781 9782 9783 9784 9785 9786 9787 9788 9789 9790 9791 9792 9793 9794 9795 9796 9797 9798 9799 9800 9801 9802 9803 9804 9805 9806 9807 9808 9809 9810 9811 9812 9813 9814 9815 9816 9817 9818 9819 9820 9821 9822 9823 9824 9825 9826 9827 9828 9829 9830 9831 9832 9833 9834 9835 9836 9837 9838 9839 9840 9841 9842 9843 9844 9845 9846 9847 9848 9849 9850 9851 9852 9853 9854 9855 9856 9857 9858 9859 9860 9861 9862 9863 9864 9865 9866 9867 9868 9869 9870 9871 9872 9873 9874 9875 9876 9877 9878 9879 9880 9881 9882 9883 9884 9885 9886 9887 9888 9889 9890 9891 9892 9893 9894 9895 9896 9897 9898 9899 9900 9901 9902 9903 9904 9905 9906 9907 9908 9909 9910 9911 9912 9913 9914 9915 9916 9917 9918 9919 9920 9921 9922 9923 9924 9925 9926 9927 9928 9929 9930 9931 9932 9933 9934 9935 9936 9937 9938 9939 9940 9941 9942 9943 9944 9945 9946 9947 9948 9949 9950 9951 9952 9953 9954 9955 9956 9957 9958 9959 9960 9961 9962 9963 9964 9965 9966 9967 9968 9969 9970 9971 9972 9973 9974 9975 9976 9977 9978 9979 9980 9981 9982 9983 9984 9985 9986 9987 9988 9989 9990 9991 9992 9993 9994 9995 9996 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010 10011 10012 10013 10014 10015 10016 10017 10018 10019 10020 10021 10022 10023 10024 10025 10026 10027 10028 10029 10030 10031 10032 10033 10034 10035 10036 10037 10038 10039 10040 10041 10042 10043 10044 10045 10046 10047 10048 10049 10050 10051 10052 10053 10054 10055 10056 10057 10058 10059 10060 10061 10062 10063 10064 10065 10066 10067 10068 10069 10070 10071 10072 10073 10074 10075 10076 10077 10078 10079 10080 10081 10082 10083 10084 10085 10086 10087 10088 10089 10090 10091 10092 10093 10094 10095 10096 10097 10098 10099 10100 10101 10102 10103 10104 10105 10106 10107 10108 10109 10110 10111 10112 10113 10114 10115 10116 10117 10118 10119 10120 10121 10122 10123 10124 10125 10126 10127 10128 10129 10130 10131 10132 10133 10134 10135 10136 10137 10138 10139 10140 10141 10142 10143 10144 10145 10146 10147 10148 10149 10150 10151 10152 10153 10154 10155 10156 10157 10158 10159 10160 10161 10162 10163 10164 10165 10166 10167 10168 10169 10170 10171 10172 10173 10174 10175 10176 10177 10178 10179 10180 10181 10182 10183 10184 10185 10186 10187 10188 10189 10190 10191 10192 10193 10194 10195 10196 10197 10198 10199 10200 10201 10202 10203 10204 10205 10206 10207 10208 10209 10210 10211 10212 10213 10214 10215 10216 10217 10218 10219 10220 10221 10222 10223 10224 10225 10226 10227 10228 10229 10230 10231 10232 10233 10234 10235 10236 10237 10238 10239 10240 10241 10242 10243 10244 10245 10246 10247 10248 10249 10250 10251 10252 10253 10254 10255 10256 10257 10258 10259 10260 10261 10262 10263 10264 10265 10266 10267 10268 10269 10270 10271 10272 10273 10274 10275 10276 10277 10278 10279 10280 10281 10282 10283 10284 10285 10286 10287 10288 10289 10290 10291 10292 10293 10294 10295 10296 10297 10298 10299 10300 10301 10302 10303 10304 10305 10306 10307 10308 10309 10310 10311 10312 10313 10314 10315 10316 10317 10318 10319 10320 10321 10322 10323 10324 10325 10326 10327 10328 10329 10330 10331 10332 10333 10334 10335 10336 10337 10338 10339 10340 10341 10342 10343 10344 10345 10346 10347 10348 10349 10350 10351 10352 10353 10354 10355 10356 10357 10358 10359 10360 10361 10362 10363 10364 10365 10366 10367 10368 10369 10370 10371 10372 10373 10374 10375 10376 10377 10378 10379 10380 10381 10382 10383 10384 10385 10386 10387 10388 10389 10390 10391 10392 10393 10394 10395 10396 10397 10398 10399 10400 10401 10402 10403 10404 10405 10406 10407 10408 10409 10410 10411 10412 10413 10414 10415 10416 10417 10418 10419 10420 10421 10422 10423 10424 10425 10426 10427 10428 10429 10430 10431 10432 10433 10434 10435 10436 10437 10438 10439 10440 10441 10442 10443 10444 10445 10446 10447 10448 10449 10450 10451 10452 10453 10454 10455 10456 10457 10458 10459 10460 10461 10462 10463 10464 10465 10466 10467 10468 10469 10470 10471 10472 10473 10474 10475 10476 10477 10478 10479 10480 10481 10482 10483 10484 10485 10486 10487 10488 10489 10490 10491 10492 10493 10494 10495 10496 10497 10498 10499 10500 10501 10502 10503 10504 10505 10506 10507 10508 10509 10510 10511 10512 10513 10514 10515 10516 10517 10518 10519 10520 10521 10522 10523 10524 10525 10526 10527 10528 10529 10530 10531 10532 10533 10534 10535 10536 10537 10538 10539 10540 10541 10542 10543 10544 10545 10546 10547 10548 10549 10550 10551 10552 10553 10554 10555 10556 10557 10558 10559 10560 10561 10562 10563 10564 10565 10566 10567 10568 10569 10570 10571 10572 10573 10574 10575 10576 10577 10578 10579 10580 10581 10582 10583 10584 10585 10586 10587 10588 10589 10590 10591 10592 10593 10594 10595 10596 10597 10598 10599 10600 10601 10602 10603 10604 10605 10606 10607 10608 10609 10610 10611 10612 10613 10614 10615 10616 10617 10618 10619 10620 10621 10622 10623 10624 10625 10626 10627 10628 10629 10630 10631 10632 10633 10634 10635 10636 10637 10638 10639 10640 10641 10642 10643 10644 10645 10646 10647 10648 10649 10650 10651 10652 10653 10654 10655 10656 10657 10658 10659 10660 10661 10662 10663 10664 10665 10666 10667 10668 10669 10670 10671 10672 10673 10674 10675 10676 10677 10678 10679 10680 10681 10682 10683 10684 10685 10686 10687 10688 10689 10690 10691 10692 10693 10694 10695 10696 10697 10698 10699 10700 10701 10702 10703 10704 10705 10706 10707 10708 10709 10710 10711 10712 10713 10714 10715 10716 10717 10718 10719 10720 10721 10722 10723 10724 10725 10726 10727 10728 10729 10730 10731 10732 10733 10734 10735 10736 10737 10738 10739 10740 10741 10742 10743 10744 10745 10746 10747 10748 10749 10750 10751 10752 10753 10754 10755 10756 10757 10758 10759 10760 10761 10762 10763 10764 10765 10766 10767 10768 10769 10770 10771 10772 10773 10774 10775 10776 10777 10778 10779 10780 10781 10782 10783 10784 10785 10786 10787 10788 10789 10790 10791 10792 10793 10794 10795 10796 10797 10798 10799 10800 10801 10802 10803 10804 10805 10806 10807 10808 10809 10810 10811 10812 10813 10814 10815 10816 10817 10818 10819 10820 10821 10822 10823 10824 10825 10826 10827 10828 10829 10830 10831 10832 10833 10834 10835 10836 10837 10838 10839 10840 10841 10842 10843 10844 10845 10846 10847 10848 10849 10850 10851 10852 10853 10854 10855 10856 10857 10858 10859 10860 10861 10862 10863 10864 10865 10866 10867 10868 10869 10870 10871 10872 10873 10874 10875 10876 10877 10878 10879 10880 10881 10882 10883 10884 10885 10886 10887 10888 10889 10890 10891 10892 10893 10894 10895 10896 10897 10898 10899 10900 10901 10902 10903 10904 10905 10906 10907 10908 10909 10910 10911 10912 10913 10914 10915 10916 10917 10918 10919 10920 10921 10922 10923 10924 10925 10926 10927 10928 10929 10930 10931 10932 10933 10934 10935 10936 10937 10938 10939 10940 10941 10942 10943 10944 10945 10946 10947 10948 10949 10950 10951 10952 10953 10954 10955 10956 10957 10958 10959 10960 10961 10962 10963 10964 10965 10966 10967 10968 10969 10970 10971 10972 10973 10974 10975 10976 10977 10978 10979 10980 10981 10982 10983 10984 10985 10986 10987 10988 10989 10990 10991 10992 10993 10994 10995 10996 10997 10998 10999 11000 11001 11002 11003 11004 11005 11006 11007 11008 11009 11010 11011 11012 11013 11014 11015 11016 11017 11018 11019 11020 11021 11022 11023 11024 11025 11026 11027 11028 11029 11030 11031 11032 11033 11034 11035 11036 11037 11038 11039 11040 11041 11042 11043 11044 11045 11046 11047 11048 11049 11050 11051 11052 11053 11054 11055 11056 11057 11058 11059 11060 11061 11062 11063 11064 11065 11066 11067 11068 11069 11070 11071 11072 11073 11074 11075 11076 11077 11078 11079 11080 11081 11082 11083 11084 11085 11086 11087 11088 11089 11090 11091 11092 11093 11094 11095 11096 11097 11098 11099 11100 11101 11102 11103 11104 11105 11106 11107 11108 11109 11110 11111 11112 11113 11114 11115 11116 11117 11118 11119 11120 11121 11122 11123 11124 11125 11126 11127 11128 11129 11130 11131 11132 11133 11134 11135 11136 11137 11138 11139 11140 11141 11142 11143 11144 11145 11146 11147 11148 11149 11150 11151 11152 11153 11154 11155 11156 11157 11158 11159 11160 11161 11162 11163 11164 11165 11166 11167 11168 11169 11170 11171 11172 11173 11174 11175 11176 11177 11178 11179 11180 11181 11182 11183 11184 11185 11186 11187 11188 11189 11190 11191 11192 11193 11194 11195 11196 11197 11198 11199 11200 11201 11202 11203 11204 11205 11206 11207 11208 11209 11210 11211 11212 11213 11214 11215 11216 11217 11218 11219 11220 11221 11222 11223 11224 11225 11226 11227 11228 11229 11230 11231 11232 11233 11234 11235 11236 11237 11238 11239 11240 11241 11242 11243 11244 11245 11246 11247 11248 11249 11250 11251 11252 11253 11254 11255 11256 11257 11258 11259 11260 11261 11262 11263 11264 11265 11266 11267 11268 11269 11270 11271 11272 11273 11274 11275 11276 11277 11278 11279 11280 11281 11282 11283 11284 11285 11286 11287 11288 11289 11290 11291 11292 11293 11294 11295 11296 11297 11298 11299 11300 11301 11302 11303 11304 11305 11306 11307 11308 11309 11310 11311 11312 11313 11314 11315 11316 11317 11318 11319 11320 11321 11322 11323 11324 11325 11326 11327 11328 11329 11330 11331 11332 11333 11334 11335 11336 11337 11338 11339 11340 11341 11342 11343 11344 11345 11346 11347 11348 11349 11350 11351 11352 11353 11354 11355 11356 11357 11358 11359 11360 11361 11362 11363 11364 11365 11366 11367 11368 11369 11370 11371 11372 11373 11374 11375 11376 11377 11378 11379 11380 11381 11382 11383 11384 11385 11386 11387 11388 11389 11390 11391 11392 11393 11394 11395 11396 11397 11398 11399 11400 11401 11402 11403 11404 11405 11406 11407 11408 11409 11410 11411 11412 11413 11414 11415 11416 11417 11418 11419 11420 11421 11422 11423 11424 11425 11426 11427 11428 11429 11430 11431 11432 11433 11434 11435 11436 11437 11438 11439 11440 11441 11442 11443 11444 11445 11446 11447 11448 11449 11450 11451 11452 11453 11454 11455 11456 11457 11458 11459 11460 11461 11462 11463 11464 11465 11466 11467 11468 11469 11470 11471 11472 11473 11474 11475 11476 11477 11478 11479 11480 11481 11482 11483 11484 11485 11486 11487 11488 11489 11490 11491 11492 11493 11494 11495 11496 11497 11498 11499 11500 11501 11502 11503 11504 11505 11506 11507 11508 11509 11510 11511 11512 11513 11514 11515 11516 11517 11518 11519 11520 11521 11522 11523 11524 11525 11526 11527 11528 11529 11530 11531 11532 11533 11534 11535 11536 11537 11538 11539 11540 11541 11542 11543 11544 11545 11546 11547 11548 11549 11550 11551 11552 11553 11554 11555 11556 11557 11558 11559 11560 11561 11562 11563 11564 11565 11566 11567 11568 11569 11570 11571 11572 11573 11574 11575 11576 11577 11578 11579 11580 11581 11582 11583 11584 11585 11586 11587 11588 11589 11590 11591 11592 11593 11594 11595 11596 11597 11598 11599 11600 11601 11602 11603 11604 11605 11606 11607 11608 11609 11610 11611 11612 11613 11614 11615 11616 11617 11618 11619 11620 11621 11622 11623 11624 11625 11626 11627 11628 11629 11630 11631 11632 11633 11634 11635 11636 11637 11638 11639 11640 11641 11642 11643 11644 11645 11646 11647 11648 11649 11650 11651 11652 11653 11654 11655 11656 11657 11658 11659 11660 11661 11662 11663 11664 11665 11666 11667 11668 11669 11670 11671 11672 11673 11674 11675 11676 11677 11678 11679 11680 11681 11682 11683 11684 11685 11686 11687 11688 11689 11690 11691 11692 11693 11694 11695 11696 11697 11698 11699 11700 11701 11702 11703 11704 11705 11706 11707 11708 11709 11710 11711 11712 11713 11714 11715 11716 11717 11718 11719 11720 11721 11722 11723 11724 11725 11726 11727 11728 11729 11730 11731 11732 11733 11734 11735 11736 11737 11738 11739 11740 11741 11742 11743 11744 11745 11746 11747 11748 11749 11750 11751 11752 11753 11754 11755 11756 11757 11758 11759 11760 11761 11762 11763 11764 11765 11766 11767 11768 11769 11770 11771 11772 11773 11774 11775 11776 11777 11778 11779 11780 11781 11782 11783 11784 11785 11786 11787 11788 11789 11790 11791 11792 11793 11794 11795 11796 11797 11798 11799 11800 11801 11802 11803 11804 11805 11806 11807 11808 11809 11810 11811 11812 11813 11814 11815 11816 11817 11818 11819 11820 11821 11822 11823 11824 11825 11826 11827 11828 11829 11830 11831 11832 11833 11834 11835 11836 11837 11838 11839 11840 11841 11842 11843 11844 11845 11846 11847 11848 11849 11850 11851 11852 11853 11854 11855 11856 11857 11858 11859 11860 11861 11862 11863 11864 11865 11866 11867 11868 11869 11870 11871 11872 11873 11874 11875 11876 11877 11878 11879 11880 11881 11882 11883 11884 11885 11886 11887 11888 11889 11890 11891 11892 11893 11894 11895 11896 11897 11898 11899 11900 11901 11902 11903 11904 11905 11906 11907 11908 11909 11910 11911 11912 11913 11914 11915 11916 11917 11918 11919 11920 11921 11922 11923 11924 11925 11926 11927 11928 11929 11930 11931 11932 11933 11934 11935 11936 11937 11938 11939 11940 11941 11942 11943 11944 11945 11946 11947 11948 11949 11950 11951 11952 11953 11954 11955 11956 11957 11958 11959 11960 11961 11962 11963 11964 11965 11966 11967 11968 11969 11970 11971 11972 11973 11974 11975 11976 11977 11978 11979 11980 11981 11982 11983 11984 11985 11986 11987 11988 11989 11990 11991 11992 11993 11994 11995 11996 11997 11998 11999 12000 12001 12002 12003 12004 12005 12006 12007 12008 12009 12010 12011 12012 12013 12014 12015 12016 12017 12018 12019 12020 12021 12022 12023 12024 12025 12026 12027 12028 12029 12030 12031 12032 12033 12034 12035 12036 12037 12038 12039 12040 12041 12042 12043 12044 12045 12046 12047 12048 12049 12050 12051 12052 12053 12054 12055 12056 12057 12058 12059 12060 12061 12062 12063 12064 12065 12066 12067 12068 12069 12070 12071 12072 12073 12074 12075 12076 12077 12078 12079 12080 12081 12082 12083 12084 12085 12086 12087 12088 12089 12090 12091 12092 12093 12094 12095 12096 12097 12098 12099 12100 12101 12102 12103 12104 12105 12106 12107 12108 12109 12110 12111 12112 12113 12114 12115 12116 12117 12118 12119 12120 12121 12122 12123 12124 12125 12126 12127 12128 12129 12130 12131 12132 12133 12134 12135 12136 12137 12138 12139 12140 12141 12142 12143 12144 12145 12146 12147 12148 12149 12150 12151 12152 12153 12154 12155 12156 12157 12158 12159 12160 12161 12162 12163 12164 12165 12166 12167 12168 12169 12170 12171 12172 12173 12174 12175 12176 12177 12178 12179 12180 12181 12182 12183 12184 12185 12186 12187 12188 12189 12190 12191 12192 12193 12194 12195 12196 12197 12198 12199 12200 12201 12202 12203 12204 12205 12206 12207 12208 12209 12210 12211 12212 12213 12214 12215 12216 12217 12218 12219 12220 12221 12222 12223 12224 12225 12226 12227 12228 12229 12230 12231 12232 12233 12234 12235 12236 12237 12238 12239 12240 12241 12242 12243 12244 12245 12246 12247 12248 12249 12250 12251 12252 12253 12254 12255 12256 12257 12258 12259 12260 12261 12262 12263 12264 12265 12266 12267 12268 12269 12270 12271 12272 12273 12274 12275 12276 12277 12278 12279 12280 12281 12282 12283 12284 12285 12286 12287 12288 12289 12290 12291 12292 12293 12294 12295 12296 12297 12298 12299 12300 12301 12302 12303 12304 12305 12306 12307 12308 12309 12310 12311 12312 12313 12314 12315 12316 12317 12318 12319 12320 12321 12322 12323 12324 12325 12326 12327 12328 12329 12330 12331 12332 12333 12334 12335 12336 12337 12338 12339 12340 12341 12342 12343 12344 12345 12346 12347 12348 12349 12350 12351 12352 12353 12354 12355 12356 12357 12358 12359 12360 12361 12362 12363 12364 12365 12366 12367 12368 12369 12370 12371 12372 12373 12374 12375 12376 12377 12378 12379 12380 12381 12382 12383 12384 12385 12386 12387 12388 12389 12390 12391 12392 12393 12394 12395 12396 12397 12398 12399 12400 12401 12402 12403 12404 12405 12406 12407 12408 12409 12410 12411 12412 12413 12414 12415 12416 12417 12418 12419 12420 12421 12422 12423 12424 12425 12426 12427 12428 12429 12430 12431 12432 12433 12434 12435 12436 12437 12438 12439 12440 12441 12442 12443 12444 12445 12446 12447 12448 12449 12450 12451 12452 12453 12454 12455 12456 12457 12458 12459 12460 12461 12462 12463 12464 12465 12466 12467 12468 12469 12470 12471 12472 12473 12474 12475 12476 12477 12478 12479 12480 12481 12482 12483 12484 12485 12486 12487 12488 12489 12490 12491 12492 12493 12494 12495 12496 12497 12498 12499 12500 12501 12502 12503 12504 12505 12506 12507 12508 12509 12510 12511 12512 12513 12514 12515 12516 12517 12518 12519 12520 12521 12522 12523 12524 12525 12526 12527 12528 12529 12530 12531 12532 12533 12534 12535 12536 12537 12538 12539 12540 12541 12542 12543 12544 12545 12546 12547 12548 12549 12550 12551 12552 12553 12554 12555 12556 12557 12558 12559 12560 12561 12562 12563 12564 12565 12566 12567 12568 12569 12570 12571 12572 12573 12574 12575 12576 12577 12578 12579 12580 12581 12582 12583 12584 12585 12586 12587 12588 12589 12590 12591 12592 12593 12594 12595 12596 12597 12598 12599 12600 12601 12602 12603 12604 12605 12606 12607 12608 12609 12610 12611 12612 12613 12614 12615 12616 12617 12618 12619 12620 12621 12622 12623 12624 12625 12626 12627 12628 12629 12630 12631 12632 12633 12634 12635 12636 12637 12638 12639 12640 12641 12642 12643 12644 12645 12646 12647 12648 12649 12650 12651 12652 12653 12654 12655 12656 12657 12658 12659 12660 12661 12662 12663 12664 12665 12666 12667 12668 12669 12670 12671 12672 12673 12674 12675 12676 12677 12678 12679 12680 12681 12682 12683 12684 12685 12686 12687 12688 12689 12690 12691 12692 12693 12694 12695 12696 12697 12698 12699 12700 12701 12702 12703 12704 12705 12706 12707 12708 12709 12710 12711 12712 12713 12714 12715 12716 12717 12718 12719 12720 12721 12722 12723 12724 12725 12726 12727 12728 12729 12730 12731 12732 12733 12734 12735 12736 12737 12738 12739 12740 12741 12742 12743 12744 12745 12746 12747 12748 12749 12750 12751 12752 12753 12754 12755 12756 12757 12758 12759 12760 12761 12762 12763 12764 12765 12766 12767 12768 12769 12770 12771 12772 12773 12774 12775 12776 12777 12778 12779 12780 12781 12782 12783 12784 12785 12786 12787 12788 12789 12790 12791 12792 12793 12794 12795 12796 12797 12798 12799 12800 12801 12802 12803 12804 12805 12806 12807 12808 12809 12810 12811 12812 12813 12814 12815 12816 12817 12818 12819 12820 12821 12822 12823 12824 12825 12826 12827 12828 12829 12830 12831 12832 12833 12834 12835 12836 12837 12838 12839 12840 12841 12842 12843 12844 12845 12846 12847 12848 12849 12850 12851 12852 12853 12854 12855 12856 12857 12858 12859 12860 12861 12862 12863 12864 12865 12866 12867 12868 12869 12870 12871 12872 12873 12874 12875 12876 12877 12878 12879 12880 12881 12882 12883 12884 12885 12886 12887 12888 12889 12890 12891 12892 12893 12894 12895 12896 12897 12898 12899 12900 12901 12902 12903 12904 12905 12906 12907 12908 12909 12910 12911 12912 12913 12914 12915 12916 12917 12918 12919 12920 12921 12922 12923 12924 12925 12926 12927 12928 12929 12930 12931 12932 12933 12934 12935 12936 12937 12938 12939 12940 12941 12942 12943 12944 12945 12946 12947 12948 12949 12950 12951 12952 12953 12954 12955 12956 12957 12958 12959 12960 12961 12962 12963 12964 12965 12966 12967 12968 12969 12970 12971 12972 12973 12974 12975 12976 12977 12978 12979 12980 12981 12982 12983 12984 12985 12986 12987 12988 12989 12990 12991 12992 12993 12994 12995 12996 12997 12998 12999 13000 13001 13002 13003 13004 13005 13006 13007 13008 13009 13010 13011 13012 13013 13014 13015 13016 13017 13018 13019 13020 13021 13022 13023 13024 13025 13026 13027 13028 13029 13030 13031 13032 13033 13034 13035 13036 13037 13038 13039 13040 13041 13042 13043 13044 13045 13046 13047 13048 13049 13050 13051 13052 13053 13054 13055 13056 13057 13058 13059 13060 13061 13062 13063 13064 13065 13066 13067 13068 13069 13070 13071 13072 13073 13074 13075 13076 13077 13078 13079 13080 13081 13082 13083 13084 13085 13086 13087 13088 13089 13090 13091 13092 13093 13094 13095 13096 13097 13098 13099 13100 13101 13102 13103 13104 13105 13106 13107 13108 13109 13110 13111 13112 13113 13114 13115 13116 13117 13118 13119 13120 13121 13122 13123 13124 13125 13126 13127 13128 13129 13130 13131 13132 13133 13134 13135 13136 13137 13138 13139 13140 13141 13142 13143 13144 13145 13146 13147 13148 13149 13150 13151 13152 13153 13154 13155 13156 13157 13158 13159 13160 13161 13162 13163 13164 13165 13166 13167 13168 13169 13170 13171 13172 13173 13174 13175 13176 13177 13178 13179 13180 13181 13182 13183 13184 13185 13186 13187 13188 13189 13190 13191 13192 13193 13194 13195 13196 13197 13198 13199 13200 13201 13202 13203 13204 13205 13206 13207 13208 13209 13210 13211 13212 13213 13214 13215 13216 13217 13218 13219 13220 13221 13222 13223 13224 13225 13226 13227 13228 13229 13230 13231 13232 13233 13234 13235 13236 13237 13238 13239 13240 13241 13242 13243 13244 13245 13246 13247 13248 13249 13250 13251 13252 13253 13254 13255 13256 13257 13258 13259 13260 13261 13262 13263 13264 13265 13266 13267 13268 13269 13270 13271 13272 13273 13274 13275 13276 13277 13278 13279 13280 13281 13282 13283 13284 13285 13286 13287 13288 13289 13290 13291 13292 13293 13294 13295 13296 13297 13298 13299 13300 13301 13302 13303 13304 13305 13306 13307 13308 13309 13310 13311 13312 13313 13314 13315 13316 13317 13318 13319 13320 13321 13322 13323 13324 13325 13326 13327 13328 13329 13330 13331 13332 13333 13334 13335 13336 13337 13338 13339 13340 13341 13342 13343 13344 13345 13346 13347 13348 13349 13350 13351 13352 13353 13354 13355 13356 13357 13358 13359 13360 13361 13362 13363 13364 13365 13366 13367 13368 13369 13370 13371 13372 13373 13374 13375 13376 13377 13378 13379 13380 13381 13382 13383 13384 13385 13386 13387 13388 13389 13390 13391 13392 13393 13394 13395 13396 13397 13398 13399 13400 13401 13402 13403 13404 13405 13406 13407 13408 13409 13410 13411 13412 13413 13414 13415 13416 13417 13418 13419 13420 13421 13422 13423 13424 13425 13426 13427 13428 13429 13430 13431 13432 13433 13434 13435 13436 13437 13438 13439 13440 13441 13442 13443 13444 13445 13446 13447 13448 13449 13450 13451 13452 13453 13454 13455 13456 13457 13458 13459 13460 13461 13462 13463 13464 13465 13466 13467 13468 13469 13470 13471 13472 13473 13474 13475 13476 13477 13478 13479 13480 13481 13482 13483 13484 13485 13486 13487 13488 13489 13490 13491 13492 13493 13494 13495 13496 13497 13498 13499 13500 13501 13502 13503 13504 13505 13506 13507 13508 13509 13510 13511 13512 13513 13514 13515 13516 13517 13518 13519 13520 13521 13522 13523 13524 13525 13526 13527 13528 13529 13530 13531 13532 13533 13534 13535 13536 13537 13538 13539 13540 13541 13542 13543 13544 13545 13546 13547 13548 13549 13550 13551 13552 13553 13554 13555 13556 13557 13558 13559 13560 13561 13562 13563 13564 13565 13566 13567 13568 13569 13570 13571 13572 13573 13574 13575 13576 13577 13578 13579 13580 13581 13582 13583 13584 13585 13586 13587 13588 13589 13590 13591 13592 13593 13594 13595 13596 13597 13598 13599 13600 13601 13602 13603 13604 13605 13606 13607 13608 13609 13610 13611 13612 13613 13614 13615 13616 13617 13618 13619 13620 13621 13622 13623 13624 13625 13626 13627 13628 13629 13630 13631 13632 13633 13634 13635 13636 13637 13638 13639 13640 13641 13642 13643 13644 13645 13646 13647 13648 13649 13650 13651 13652 13653 13654 13655 13656 13657 13658 13659 13660 13661 13662 13663 13664 13665 13666 13667 13668 13669 13670 13671 13672 13673 13674 13675 13676 13677 13678 13679 13680 13681 13682 13683 13684 13685 13686 13687 13688 13689 13690 13691 13692 13693 13694 13695 13696 13697 13698 13699 13700 13701 13702 13703 13704 13705 13706 13707 13708 13709 13710 13711 13712 13713 13714 13715 13716 13717 13718 13719 13720 13721 13722 13723 13724 13725 13726 13727 13728 13729 13730 13731 13732 13733 13734 13735 13736 13737 13738 13739 13740 13741 13742 13743 13744 13745 13746 13747 13748 13749 13750 13751 13752 13753 13754 13755 13756 13757 13758 13759 13760 13761 13762 13763 13764 13765 13766 13767 13768 13769 13770 13771 13772 13773 13774 13775 13776 13777 13778 13779 13780 13781 13782 13783 13784 13785 13786 13787 13788 13789 13790 13791 13792 13793 13794 13795 13796 13797 13798 13799 13800 13801 13802 13803 13804 13805 13806 13807 13808 13809 13810 13811 13812 13813 13814 13815 13816 13817 13818 13819 13820 13821 13822 13823 13824 13825 13826 13827 13828 13829 13830 13831 13832 13833 13834 13835 13836 13837 13838 13839 13840 13841 13842 13843 13844 13845 13846 13847 13848 13849 13850 13851 13852 13853 13854 13855 13856 13857 13858 13859 13860 13861 13862 13863 13864 13865 13866 13867 13868 13869 13870 13871 13872 13873 13874 13875 13876 13877 13878 13879 13880 13881 13882 13883 13884 13885 13886 13887 13888 13889 13890 13891 13892 13893 13894 13895 13896 13897 13898 13899 13900 13901 13902 13903 13904 13905 13906 13907 13908 13909 13910 13911 13912 13913 13914 13915 13916 13917 13918 13919 13920 13921 13922 13923 13924 13925 13926 13927 13928 13929 13930 13931 13932 13933 13934 13935 13936 13937 13938 13939 13940 13941 13942 13943 13944 13945 13946 13947 13948 13949 13950 13951 13952 13953 13954 13955 13956 13957 13958 13959 13960 13961 13962 13963 13964 13965 13966 13967 13968 13969 13970 13971 13972 13973 13974 13975 13976 13977 13978 13979 13980 13981 13982 13983 13984 13985 13986 13987 13988 13989 13990 13991 13992 13993 13994 13995 13996 13997 13998 13999 14000 14001 14002 14003 14004 14005 14006 14007 14008 14009 14010 14011 14012 14013 14014 14015 14016 14017 14018 14019 14020 14021 14022 14023 14024 14025 14026 14027 14028 14029 14030 14031 14032 14033 14034 14035 14036 14037 14038 14039 14040 14041 14042 14043 14044 14045 14046 14047 14048 14049 14050 14051 14052 14053 14054 14055 14056 14057 14058 14059 14060 14061 14062 14063 14064 14065 14066 14067 14068 14069 14070 14071 14072 14073 14074 14075 14076 14077 14078 14079 14080 14081 14082 14083 14084 14085 14086 14087 14088 14089 14090 14091 14092 14093 14094 14095 14096 14097 14098 14099 14100 14101 14102 14103 14104 14105 14106 14107 14108 14109 14110 14111 14112 14113 14114 14115 14116 14117 14118 14119 14120 14121 14122 14123 14124 14125 14126 14127 14128 14129 14130 14131 14132 14133 14134 14135 14136 14137 14138 14139 14140 14141 14142 14143 14144 14145 14146 14147 14148 14149 14150 14151 14152 14153 14154 14155 14156 14157 14158 14159 14160 14161 14162 14163 14164 14165 14166 14167 14168 14169 14170 14171 14172 14173 14174 14175 14176 14177 14178 14179 14180 14181 14182 14183 14184 14185 14186 14187 14188 14189 14190 14191 14192 14193 14194 14195 14196 14197 14198 14199 14200 14201 14202 14203 14204 14205 14206 14207 14208 14209 14210 14211 14212 14213 14214 14215 14216 14217 14218 14219 14220 14221 14222 14223 14224 14225 14226 14227 14228 14229 14230 14231 14232 14233 14234 14235 14236 14237 14238 14239 14240 14241 14242 14243 14244 14245 14246 14247 14248 14249 14250 14251 14252 14253 14254 14255 14256 14257 14258 14259 14260 14261 14262 14263 14264 14265 14266 14267 14268 14269 14270 14271 14272 14273 14274 14275 14276 14277 14278 14279 14280 14281 14282 14283 14284 14285 14286 14287 14288 14289 14290 14291 14292 14293 14294 14295 14296 14297 14298 14299 14300 14301 14302 14303 14304 14305 14306 14307 14308 14309 14310 14311 14312 14313 14314 14315 14316 14317 14318 14319 14320 14321 14322 14323 14324 14325 14326 14327 14328 14329 14330 14331 14332 14333 14334 14335 14336 14337 14338 14339 14340 14341 14342 14343 14344 14345 14346 14347 14348 14349 14350 14351 14352 14353 14354 14355 14356 14357 14358 14359 14360 14361 14362 14363 14364 14365 14366 14367 14368 14369 14370 14371 14372 14373 14374 14375 14376 14377 14378 14379 14380 14381 14382 14383 14384 14385 14386 14387 14388 14389 14390 14391 14392 14393 14394 14395 14396 14397 14398 14399 14400 14401 14402 14403 14404 14405 14406 14407 14408 14409 14410 14411 14412 14413 14414 14415 14416 14417 14418 14419 14420 14421 14422 14423 14424 14425 14426 14427 14428 14429 14430 14431 14432 14433 14434 14435 14436 14437 14438 14439 14440 14441 14442 14443 14444 14445 14446 14447 14448 14449 14450 14451 14452 14453 14454 14455 14456 14457 14458 14459 14460 14461 14462 14463 14464 14465 14466 14467 14468 14469 14470 14471 14472 14473 14474 14475 14476 14477 14478 14479 14480 14481 14482 14483 14484 14485 14486 14487 14488 14489 14490 14491 14492 14493 14494 14495 14496 14497 14498 14499 14500 14501 14502 14503 14504 14505 14506 14507 14508 14509 14510 14511 14512 14513 14514 14515 14516 14517 14518 14519 14520 14521 14522 14523 14524 14525 14526 14527 14528 14529 14530 14531 14532 14533 14534 14535 14536 14537 14538 14539 14540 14541 14542 14543 14544 14545 14546 14547 14548 14549 14550 14551 14552 14553 14554 14555 14556 14557 14558 14559 14560 14561 14562 14563 14564 14565 14566 14567 14568 14569 14570 14571 14572 14573 14574 14575 14576 14577 14578 14579 14580 14581 14582 14583 14584 14585 14586 14587 14588 14589 14590 14591 14592 14593 14594 14595 14596 14597 14598 14599 14600 14601 14602 14603 14604 14605 14606 14607 14608 14609 14610 14611 14612 14613 14614 14615 14616 14617 14618 14619 14620 14621 14622 14623 14624 14625 14626 14627 14628 14629 14630 14631 14632 14633 14634 14635 14636 14637 14638 14639 14640 14641 14642 14643 14644 14645 14646 14647 14648 14649 14650 14651 14652 14653 14654 14655 14656 14657 14658 14659 14660 14661 14662 14663 14664 14665 14666 14667 14668 14669 14670 14671 14672 14673 14674 14675 14676 14677 14678 14679 14680 14681 14682 14683 14684 14685 14686 14687 14688 14689 14690 14691 14692 14693 14694 14695 14696 14697 14698 14699 14700 14701 14702 14703 14704 14705 14706 14707 14708 14709 14710 14711 14712 14713 14714 14715 14716 14717 14718 14719 14720 14721 14722 14723 14724 14725 14726 14727 14728 14729 14730 14731 14732 14733 14734 14735 14736 14737 14738 14739 14740 14741 14742 14743 14744 14745 14746 14747 14748 14749 14750 14751 14752 14753 14754 14755 14756 14757 14758 14759 14760 14761 14762 14763 14764 14765 14766 14767 14768 14769 14770 14771 14772 14773 14774 14775 14776 14777 14778 14779 14780 14781 14782 14783 14784 14785 14786 14787 14788 14789 14790 14791 14792 14793 14794 14795 14796 14797 14798 14799 14800 14801 14802 14803 14804 14805 14806 14807 14808 14809 14810 14811 14812 14813 14814 14815 14816 14817 14818 14819 14820 14821 14822 14823 14824 14825 14826 14827 14828 14829 14830 14831 14832 14833 14834 14835 14836 14837 14838 14839 14840 14841 14842 14843 14844 14845 14846 14847 14848 14849 14850 14851 14852 14853 14854 14855 14856 14857 14858 14859 14860 14861 14862 14863 14864 14865 14866 14867 14868 14869 14870 14871 14872 14873 14874 14875 14876 14877 14878 14879 14880 14881 14882 14883 14884 14885 14886 14887 14888 14889 14890 14891 14892 14893 14894 14895 14896 14897 14898 14899 14900 14901 14902 14903 14904 14905 14906 14907 14908 14909 14910 14911 14912 14913 14914 14915 14916 14917 14918 14919 14920 14921 14922 14923 14924 14925 14926 14927 14928 14929 14930 14931 14932 14933 14934 14935 14936 14937 14938 14939 14940 14941 14942 14943 14944 14945 14946 14947 14948 14949 14950 14951 14952 14953 14954 14955 14956 14957 14958 14959 14960 14961 14962 14963 14964 14965 14966 14967 14968 14969 14970 14971 14972 14973 14974 14975 14976 14977 14978 14979 14980 14981 14982 14983 14984 14985 14986 14987 14988 14989 14990 14991 14992 14993 14994 14995 14996 14997 14998 14999 15000 15001 15002 15003 15004 15005 15006 15007 15008 15009 15010 15011 15012 15013 15014 15015 15016 15017 15018 15019 15020 15021 15022 15023 15024 15025 15026 15027 15028 15029 15030 15031 15032 15033 15034 15035 15036 15037 15038 15039 15040 15041 15042 15043 15044 15045 15046 15047 15048 15049 15050 15051 15052 15053 15054 15055 15056 15057 15058 15059 15060 15061 15062 15063 15064 15065 15066 15067 15068 15069 15070 15071 15072 15073 15074 15075 15076 15077 15078 15079 15080 15081 15082 15083 15084 15085 15086 15087 15088 15089 15090 15091 15092 15093 15094 15095 15096 15097 15098 15099 15100 15101 15102 15103 15104 15105 15106 15107 15108 15109 15110 15111 15112 15113 15114 15115 15116 15117 15118 15119 15120 15121 15122 15123 15124 15125 15126 15127 15128 15129 15130 15131 15132 15133 15134 15135 15136 15137 15138 15139 15140 15141 15142 15143 15144 15145 15146 15147 15148 15149 15150 15151 15152 15153 15154 15155 15156 15157 15158 15159 15160 15161 15162 15163 15164 15165 15166 15167 15168 15169 15170 15171 15172 15173 15174 15175 15176 15177 15178 15179 15180 15181 15182 15183 15184 15185 15186 15187 15188 15189 15190 15191 15192 15193 15194 15195 15196 15197 15198 15199 15200 15201 15202 15203 15204 15205 15206 15207 15208 15209 15210 15211 15212 15213 15214 15215 15216 15217 15218 15219 15220 15221 15222 15223 15224 15225 15226 15227 15228 15229 15230 15231 15232 15233 15234 15235 15236 15237 15238 15239 15240 15241 15242 15243 15244 15245 15246 15247 15248 15249 15250 15251 15252 15253 15254 15255 15256 15257 15258 15259 15260 15261 15262 15263 15264 15265 15266 15267 15268 15269 15270 15271 15272 15273 15274 15275 15276 15277 15278 15279 15280 15281 15282 15283 15284 15285 15286 15287 15288 15289 15290 15291 15292 15293 15294 15295 15296 15297 15298 15299 15300 15301 15302 15303 15304 15305 15306 15307 15308 15309 15310 15311 15312 15313 15314 15315 15316 15317 15318 15319 15320 15321 15322 15323 15324 15325 15326 15327 15328 15329 15330 15331 15332 15333 15334 15335 15336 15337 15338 15339 15340 15341 15342 15343 15344 15345 15346 15347 15348 15349 15350 15351 15352 15353 15354 15355 15356 15357 15358 15359 15360 15361 15362 15363 15364 15365 15366 15367 15368 15369 15370 15371 15372 15373 15374 15375 15376 15377 15378 15379 15380 15381 15382 15383 15384 15385 15386 15387 15388 15389 15390 15391 15392 15393 15394 15395 15396 15397 15398 15399 15400 15401 15402 15403 15404 15405 15406 15407 15408 15409 15410 15411 15412 15413 15414 15415 15416 15417 15418 15419 15420 15421 15422 15423 15424 15425 15426 15427 15428 15429 15430 15431 15432 15433 15434 15435 15436 15437 15438 15439 15440 15441 15442 15443 15444 15445 15446 15447 15448 15449 15450 15451 15452 15453 15454 15455 15456 15457 15458 15459 15460 15461 15462 15463 15464 15465 15466 15467 15468 15469 15470 15471 15472 15473 15474 15475 15476 15477 15478 15479 15480 15481 15482 15483 15484 15485 15486 15487 15488 15489 15490 15491 15492 15493 15494 15495 15496 15497 15498 15499 15500 15501 15502 15503 15504 15505 15506 15507 15508 15509 15510 15511 15512 15513 15514 15515 15516 15517 15518 15519 15520 15521 15522 15523 15524 15525 15526 15527 15528 15529 15530 15531 15532 15533 15534 15535 15536 15537 15538 15539 15540 15541 15542 15543 15544 15545 15546 15547 15548 15549 15550 15551 15552 15553 15554 15555 15556 15557 15558 15559 15560 15561 15562 15563 15564 15565 15566 15567 15568 15569 15570 15571 15572 15573 15574 15575 15576 15577 15578 15579 15580 15581 15582 15583 15584 15585 15586 15587 15588 15589 15590 15591 15592 15593 15594 15595 15596 15597 15598 15599 15600 15601 15602 15603 15604 15605 15606 15607 15608 15609 15610 15611 15612 15613 15614 15615 15616 15617 15618 15619 15620 15621 15622 15623 15624 15625 15626 15627 15628 15629 15630 15631 15632 15633 15634 15635 15636 15637 15638 15639 15640 15641 15642 15643 15644 15645 15646 15647 15648 15649 15650 15651 15652 15653 15654 15655 15656 15657 15658 15659 15660 15661 15662 15663 15664 15665 15666 15667 15668 15669 15670 15671 15672 15673 15674 15675 15676 15677 15678 15679 15680 15681 15682 15683 15684 15685 15686 15687 15688 15689 15690 15691 15692 15693 15694 15695 15696 15697 15698 15699 15700 15701 15702 15703 15704 15705 15706 15707 15708 15709 15710 15711 15712 15713 15714 15715 15716 15717 15718 15719 15720 15721 15722 15723 15724 15725 15726 15727 15728 15729 15730 15731 15732 15733 15734 15735 15736 15737 15738 15739 15740 15741 15742 15743 15744 15745 15746 15747 15748 15749 15750 15751 15752 15753 15754 15755 15756 15757 15758 15759 15760 15761 15762 15763 15764 15765 15766 15767 15768 15769 15770 15771 15772 15773 15774 15775 15776 15777 15778 15779 15780 15781 15782 15783 15784 15785 15786 15787 15788 15789 15790 15791 15792 15793 15794 15795 15796 15797 15798 15799 15800 15801 15802 15803 15804 15805 15806 15807 15808 15809 15810 15811 15812 15813 15814 15815 15816 15817 15818 15819 15820 15821 15822 15823 15824 15825 15826 15827 15828 15829 15830 15831 15832 15833 15834 15835 15836 15837 15838 15839 15840 15841 15842 15843 15844 15845 15846 15847 15848 15849 15850 15851 15852 15853 15854 15855 15856 15857 15858 15859 15860 15861 15862 15863 15864 15865 15866 15867 15868 15869 15870 15871 15872 15873 15874 15875 15876 15877 15878 15879 15880 15881 15882 15883 15884 15885 15886 15887 15888 15889 15890 15891 15892 15893 15894 15895 15896 15897 15898 15899 15900 15901 15902 15903 15904 15905 15906 15907 15908 15909 15910 15911 15912 15913 15914 15915 15916 15917 15918 15919 15920 15921 15922 15923 15924 15925 15926 15927 15928 15929 15930 15931 15932 15933 15934 15935 15936 15937 15938 15939 15940 15941 15942 15943 15944 15945 15946 15947 15948 15949 15950 15951 15952 15953 15954 15955 15956 15957 15958 15959 15960 15961 15962 15963 15964 15965 15966 15967 15968 15969 15970 15971 15972 15973 15974 15975 15976 15977 15978 15979 15980 15981 15982 15983 15984 15985 15986 15987 15988 15989 15990 15991 15992 15993 15994 15995 15996 15997 15998 15999 16000 16001 16002 16003 16004 16005 16006 16007 16008 16009 16010 16011 16012 16013 16014 16015 16016 16017 16018 16019 16020 16021 16022 16023 16024 16025 16026 16027 16028 16029 16030 16031 16032 16033 16034 16035 16036 16037 16038 16039 16040 16041 16042 16043 16044 16045 16046 16047 16048 16049 16050 16051 16052 16053 16054 16055 16056 16057 16058 16059 16060 16061 16062 16063 16064 16065 16066 16067 16068 16069 16070 16071 16072 16073 16074 16075 16076 16077 16078 16079 16080 16081 16082 16083 16084 16085 16086 16087 16088 16089 16090 16091 16092 16093 16094 16095 16096 16097 16098 16099 16100 16101 16102 16103 16104 16105 16106 16107 16108 16109 16110 16111 16112 16113 16114 16115 16116 16117 16118 16119 16120 16121 16122 16123 16124 16125 16126 16127 16128 16129 16130 16131 16132 16133 16134 16135 16136 16137 16138 16139 16140 16141 16142 16143 16144 16145 16146 16147 16148 16149 16150 16151 16152 16153 16154 16155 16156 16157 16158 16159 16160 16161 16162 16163 16164 16165 16166 16167 16168 16169 16170 16171 16172 16173 16174 16175 16176 16177 16178 16179 16180 16181 16182 16183 16184 16185 16186 16187 16188 16189 16190 16191 16192 16193 16194 16195 16196 16197 16198 16199 16200 16201 16202 16203 16204 16205 16206 16207 16208 16209 16210 16211 16212 16213 16214 16215 16216 16217 16218 16219 16220 16221 16222 16223 16224 16225 16226 16227 16228 16229 16230 16231 16232 16233 16234 16235 16236 16237 16238 16239 16240 16241 16242 16243 16244 16245 16246 16247 16248 16249 16250 16251 16252 16253 16254 16255 16256 16257 16258 16259 16260 16261 16262 16263 16264 16265 16266 16267 16268 16269 16270 16271 16272 16273 16274 16275 16276 16277 16278 16279 16280 16281 16282 16283 16284 16285 16286 16287 16288 16289 16290 16291 16292 16293 16294 16295 16296 16297 16298 16299 16300 16301 16302 16303 16304 16305 16306 16307 16308 16309 16310 16311 16312 16313 16314 16315 16316 16317 16318 16319 16320 16321 16322 16323 16324 16325 16326 16327 16328 16329 16330 16331 16332 16333 16334 16335 16336 16337 16338 16339 16340 16341 16342 16343 16344 16345 16346 16347 16348 16349 16350 16351 16352 16353 16354 16355 16356 16357 16358 16359 16360 16361 16362 16363 16364 16365 16366 16367 16368 16369 16370 16371 16372 16373 16374 16375 16376 16377 16378 16379 16380 16381 16382 16383 16384 16385 16386 16387 16388 16389 16390 16391 16392 16393 16394 16395 16396 16397 16398 16399 16400 16401 16402 16403 16404 16405 16406 16407 16408 16409 16410 16411 16412 16413 16414 16415 16416 16417 16418 16419 16420 16421 16422 16423 16424 16425 16426 16427 16428 16429 16430 16431 16432 16433 16434 16435 16436 16437 16438 16439 16440 16441 16442 16443 16444 16445 16446 16447 16448 16449 16450 16451 16452 16453 16454 16455 16456 16457 16458 16459 16460 16461 16462 16463 16464 16465 16466 16467 16468 16469 16470 16471 16472 16473 16474 16475 16476 16477 16478 16479 16480 16481 16482 16483 16484 16485 16486 16487 16488 16489 16490 16491 16492 16493 16494 16495 16496 16497 16498 16499 16500 16501 16502 16503 16504 16505 16506 16507 16508 16509 16510 16511 16512 16513 16514 16515 16516 16517 16518 16519 16520 16521 16522 16523 16524 16525 16526 16527 16528 16529 16530 16531 16532 16533 16534 16535 16536 16537 16538 16539 16540 16541 16542 16543 16544 16545 16546 16547 16548 16549 16550 16551 16552 16553 16554 16555 16556 16557 16558 16559 16560 16561 16562 16563 16564 16565 16566 16567 16568 16569 16570 16571 16572 16573 16574 16575 16576 16577 16578 16579 16580 16581 16582 16583 16584 16585 16586 16587 16588 16589 16590 16591 16592 16593 16594 16595 16596 16597 16598 16599 16600 16601 16602 16603 16604 16605 16606 16607 16608 16609 16610 16611 16612 16613 16614 16615 16616 16617 16618 16619 16620 16621 16622 16623 16624 16625 16626 16627 16628 16629 16630 16631 16632 16633 16634 16635 16636 16637 16638 16639 16640 16641 16642 16643 16644 16645 16646 16647 16648 16649 16650 16651 16652 16653 16654 16655 16656 16657 16658 16659 16660 16661 16662 16663 16664 16665 16666 16667 16668 16669 16670 16671 16672 16673 16674 16675 16676 16677 16678 16679 16680 16681 16682 16683 16684 16685 16686 16687 16688 16689 16690 16691 16692 16693 16694 16695 16696 16697 16698 16699 16700 16701 16702 16703 16704 16705 16706 16707 16708 16709 16710 16711 16712 16713 16714 16715 16716 16717 16718 16719 16720 16721 16722 16723 16724 16725 16726 16727 16728 16729 16730 16731 16732 16733 16734 16735 16736 16737 16738 16739 16740 16741 16742 16743 16744 16745 16746 16747 16748 16749 16750 16751 16752 16753 16754 16755 16756 16757 16758 16759 16760 16761 16762 16763 16764 16765 16766 16767 16768 16769 16770 16771 16772 16773 16774 16775 16776 16777 16778 16779 16780 16781 16782 16783 16784 16785 16786 16787 16788 16789 16790 16791 16792 16793 16794 16795 16796 16797 16798 16799 16800 16801 16802 16803 16804 16805 16806 16807 16808 16809 16810 16811 16812 16813 16814 16815 16816 16817 16818 16819 16820 16821 16822 16823 16824 16825 16826 16827 16828 16829 16830 16831 16832 16833 16834 16835 16836 16837 16838 16839 16840 16841 16842 16843 16844 16845 16846 16847 16848 16849 16850 16851 16852 16853 16854 16855 16856 16857 16858 16859 16860 16861 16862 16863 16864 16865 16866 16867 16868 16869 16870 16871 16872 16873 16874 16875 16876 16877 16878 16879 16880 16881 16882 16883 16884 16885 16886 16887 16888 16889 16890 16891 16892 16893 16894 16895 16896 16897 16898 16899 16900 16901 16902 16903 16904 16905 16906 16907 16908 16909 16910 16911 16912 16913 16914 16915 16916 16917 16918 16919 16920 16921 16922 16923 16924 16925 16926 16927 16928 16929 16930 16931 16932 16933 16934 16935 16936 16937 16938 16939 16940 16941 16942 16943 16944 16945 16946 16947 16948 16949 16950 16951 16952 16953 16954 16955 16956 16957 16958 16959 16960 16961 16962 16963 16964 16965 16966 16967 16968 16969 16970 16971 16972 16973 16974 16975 16976 16977 16978 16979 16980 16981 16982 16983 16984 16985 16986 16987 16988 16989 16990 16991 16992 16993 16994 16995 16996 16997 16998 16999 17000 17001 17002 17003 17004 17005 17006 17007 17008 17009 17010 17011 17012 17013 17014 17015 17016 17017 17018 17019 17020 17021 17022 17023 17024 17025 17026 17027 17028 17029 17030 17031 17032 17033 17034 17035 17036 17037 17038 17039 17040 17041 17042 17043 17044 17045 17046 17047 17048 17049 17050 17051 17052 17053 17054 17055 17056 17057 17058 17059 17060 17061 17062 17063 17064 17065 17066 17067 17068 17069 17070 17071 17072 17073 17074 17075 17076 17077 17078 17079 17080 17081 17082 17083 17084 17085 17086 17087 17088 17089 17090 17091 17092 17093 17094 17095 17096 17097 17098 17099 17100 17101 17102 17103 17104 17105 17106 17107 17108 17109 17110 17111 17112 17113 17114 17115 17116 17117 17118 17119 17120 17121 17122 17123 17124 17125 17126 17127 17128 17129 17130 17131 17132 17133 17134 17135 17136 17137 17138 17139 17140 17141 17142 17143 17144 17145 17146 17147 17148 17149 17150 17151 17152 17153 17154 17155 17156 17157 17158 17159 17160 17161 17162 17163 17164 17165 17166 17167 17168 17169 17170 17171 17172 17173 17174 17175 17176 17177 17178 17179 17180 17181 17182 17183 17184 17185 17186 17187 17188 17189 17190 17191 17192 17193 17194 17195 17196 17197 17198 17199 17200 17201 17202 17203 17204 17205 17206 17207 17208 17209 17210 17211 17212 17213 17214 17215 17216 17217 17218 17219 17220 17221 17222 17223 17224 17225 17226 17227 17228 17229 17230 17231 17232 17233 17234 17235 17236 17237 17238 17239 17240 17241 17242 17243 17244 17245 17246 17247 17248 17249 17250 17251 17252 17253 17254 17255 17256 17257 17258 17259 17260 17261 17262 17263 17264 17265 17266 17267 17268 17269 17270 17271 17272 17273 17274 17275 17276 17277 17278 17279 17280 17281 17282 17283 17284 17285 17286 17287 17288 17289 17290 17291 17292 17293 17294 17295 17296 17297 17298 17299 17300 17301 17302 17303 17304 17305 17306 17307 17308 17309 17310 17311 17312 17313 17314 17315 17316 17317 17318 17319 17320 17321 17322 17323 17324 17325 17326 17327 17328 17329 17330 17331 17332 17333 17334 17335 17336 17337 17338 17339 17340 17341 17342 17343 17344 17345 17346 17347 17348 17349 17350 17351 17352 17353 17354 17355 17356 17357 17358 17359 17360 17361 17362 17363 17364 17365 17366 17367 17368 17369 17370 17371 17372 17373 17374 17375 17376 17377 17378 17379 17380 17381 17382 17383 17384 17385 17386 17387 17388 17389 17390 17391 17392 17393 17394 17395 17396 17397 17398 17399 17400 17401 17402 17403 17404 17405 17406 17407 17408 17409 17410 17411 17412 17413 17414 17415 17416 17417 17418 17419 17420 17421 17422 17423 17424 17425 17426 17427 17428 17429 17430 17431 17432 17433 17434 17435 17436 17437 17438 17439 17440 17441 17442 17443 17444 17445 17446 17447 17448 17449 17450 17451 17452 17453 17454 17455 17456 17457 17458 17459 17460 17461 17462 17463 17464 17465 17466 17467 17468 17469 17470 17471 17472 17473 17474 17475 17476 17477 17478 17479 17480 17481 17482 17483 17484 17485 17486 17487 17488 17489 17490 17491 17492 17493 17494 17495 17496 17497 17498 17499 17500 17501 17502 17503 17504 17505 17506 17507 17508 17509 17510 17511 17512 17513 17514 17515 17516 17517 17518 17519 17520 17521 17522 17523 17524 17525 17526 17527 17528 17529 17530 17531 17532 17533 17534 17535 17536 17537 17538 17539 17540 17541 17542 17543 17544 17545 17546 17547 17548 17549 17550 17551 17552 17553 17554 17555 17556 17557 17558 17559 17560 17561 17562 17563 17564 17565 17566 17567 17568 17569 17570 17571 17572 17573 17574 17575 17576 17577 17578 17579 17580 17581 17582 17583 17584 17585 17586 17587 17588 17589 17590 17591 17592 17593 17594 17595 17596 17597 17598 17599 17600 17601 17602 17603 17604 17605 17606 17607 17608 17609 17610 17611 17612 17613 17614 17615 17616 17617 17618 17619 17620 17621 17622 17623 17624 17625 17626 17627 17628 17629 17630 17631 17632 17633 17634 17635 17636 17637 17638 17639 17640 17641 17642 17643 17644 17645 17646 17647 17648 17649 17650 17651 17652 17653 17654 17655 17656 17657 17658 17659 17660 17661 17662 17663 17664 17665 17666 17667 17668 17669 17670 17671 17672 17673 17674 17675 17676 17677 17678 17679 17680 17681 17682 17683 17684 17685 17686 17687 17688 17689 17690 17691 17692 17693 17694 17695 17696 17697 17698 17699 17700 17701 17702 17703 17704 17705 17706 17707 17708 17709 17710 17711 17712 17713 17714 17715 17716 17717 17718 17719 17720 17721 17722 17723 17724 17725 17726 17727 17728 17729 17730 17731 17732 17733 17734 17735 17736 17737 17738 17739 17740 17741 17742 17743 17744 17745 17746 17747 17748 17749 17750 17751 17752 17753 17754 17755 17756 17757 17758 17759 17760 17761 17762 17763 17764 17765 17766 17767 17768 17769 17770 17771 17772 17773 17774 17775 17776 17777 17778 17779 17780 17781 17782 17783 17784 17785 17786 17787 17788 17789 17790 17791 17792 17793 17794 17795 17796 17797 17798 17799 17800 17801 17802 17803 17804 17805 17806 17807 17808 17809 17810 17811 17812 17813 17814 17815 17816 17817 17818 17819 17820 17821 17822 17823 17824 17825 17826 17827 17828 17829 17830 17831 17832 17833 17834 17835 17836 17837 17838 17839 17840 17841 17842 17843 17844 17845 17846 17847 17848 17849 17850 17851 17852 17853 17854 17855 17856 17857 17858 17859 17860 17861 17862 17863 17864 17865 17866 17867 17868 17869 17870 17871 17872 17873 17874 17875 17876 17877 17878 17879 17880 17881 17882 17883 17884 17885 17886 17887 17888 17889 17890 17891 17892 17893 17894 17895 17896 17897 17898 17899 17900 17901 17902 17903 17904 17905 17906 17907 17908 17909 17910 17911 17912 17913 17914 17915 17916 17917 17918 17919 17920 17921 17922 17923 17924 17925 17926 17927 17928 17929 17930 17931 17932 17933 17934 17935 17936 17937 17938 17939 17940 17941 17942 17943 17944 17945 17946 17947 17948 17949 17950 17951 17952 17953 17954 17955 17956 17957 17958 17959 17960 17961 17962 17963 17964 17965 17966 17967 17968 17969 17970 17971 17972 17973 17974 17975 17976 17977 17978 17979 17980 17981 17982 17983 17984 17985 17986 17987 17988 17989 17990 17991 17992 17993 17994 17995 17996 17997 17998 17999 18000 18001 18002 18003 18004 18005 18006 18007 18008 18009 18010 18011 18012 18013 18014 18015 18016 18017 18018 18019 18020 18021 18022 18023 18024 18025 18026 18027 18028 18029 18030 18031 18032 18033 18034 18035 18036 18037 18038 18039 18040 18041 18042 18043 18044 18045 18046 18047 18048 18049 18050 18051 18052 18053 18054 18055 18056 18057 18058 18059 18060 18061 18062 18063 18064 18065 18066 18067 18068 18069 18070 18071 18072 18073 18074 18075 18076 18077 18078 18079 18080 18081 18082 18083 18084 18085 18086 18087 18088 18089 18090 18091 18092 18093 18094 18095 18096 18097 18098 18099 18100 18101 18102 18103 18104 18105 18106 18107 18108 18109 18110 18111 18112 18113 18114 18115 18116 18117 18118 18119 18120 18121 18122 18123 18124 18125 18126 18127 18128 18129 18130 18131 18132 18133 18134 18135 18136 18137 18138 18139 18140 18141 18142 18143 18144 18145 18146 18147 18148 18149 18150 18151 18152 18153 18154 18155 18156 18157 18158 18159 18160 18161 18162 18163 18164 18165 18166 18167 18168 18169 18170 18171 18172 18173 18174 18175 18176 18177 18178 18179 18180 18181 18182 18183 18184 18185 18186 18187 18188 18189 18190 18191 18192 18193 18194 18195 18196 18197 18198 18199 18200 18201 18202 18203 18204 18205 18206 18207 18208 18209 18210 18211 18212 18213 18214 18215 18216 18217 18218 18219 18220 18221 18222 18223 18224 18225 18226 18227 18228 18229 18230 18231 18232 18233 18234 18235 18236 18237 18238 18239 18240 18241 18242 18243 18244 18245 18246 18247 18248 18249 18250 18251 18252 18253 18254 18255 18256 18257 18258 18259 18260 18261 18262 18263 18264 18265 18266 18267 18268 18269 18270 18271 18272 18273 18274 18275 18276 18277 18278 18279 18280 18281 18282 18283 18284 18285 18286 18287 18288 18289 18290 18291 18292 18293 18294 18295 18296 18297 18298 18299 18300 18301 18302 18303 18304 18305 18306 18307 18308 18309 18310 18311 18312 18313 18314 18315 18316 18317 18318 18319 18320 18321 18322 18323 18324 18325 18326 18327 18328 18329 18330 18331 18332 18333 18334 18335 18336 18337 18338 18339 18340 18341 18342 18343 18344 18345 18346 18347 18348 18349 18350 18351 18352 18353 18354 18355 18356 18357 18358 18359 18360 18361 18362 18363 18364 18365 18366 18367 18368 18369 18370 18371 18372 18373 18374 18375 18376 18377 18378 18379 18380 18381 18382 18383 18384 18385 18386 18387 18388 18389 18390 18391 18392 18393 18394 18395 18396 18397 18398 18399 18400 18401 18402 18403 18404 18405 18406 18407 18408 18409 18410 18411 18412 18413 18414 18415 18416 18417 18418 18419 18420 18421 18422 18423 18424 18425 18426 18427 18428 18429 18430 18431 18432 18433 18434 18435 18436 18437 18438 18439 18440 18441 18442 18443 18444 18445 18446 18447 18448 18449 18450 18451 18452 18453 18454 18455 18456 18457 18458 18459 18460 18461 18462 18463 18464 18465 18466 18467 18468 18469 18470 18471 18472 18473 18474 18475 18476 18477 18478 18479 18480 18481 18482 18483 18484 18485 18486 18487 18488 18489 18490 18491 18492 18493 18494 18495 18496 18497 18498 18499 18500 18501 18502 18503 18504 18505 18506 18507 18508 18509 18510 18511 18512 18513 18514 18515 18516 18517 18518 18519 18520 18521 18522 18523 18524 18525 18526 18527 18528 18529 18530 18531 18532 18533 18534 18535 18536 18537 18538 18539 18540 18541 18542 18543 18544 18545 18546 18547 18548 18549 18550 18551 18552 18553 18554 18555 18556 18557 18558 18559 18560 18561 18562 18563 18564 18565 18566 18567 18568 18569 18570 18571 18572 18573 18574 18575 18576 18577 18578 18579 18580 18581 18582 18583 18584 18585 18586 18587 18588 18589 18590 18591 18592 18593 18594 18595 18596 18597 18598 18599 18600 18601 18602 18603 18604 18605 18606 18607 18608 18609 18610 18611 18612 18613 18614 18615 18616 18617 18618 18619 18620 18621 18622 18623 18624 18625 18626 18627 18628 18629 18630 18631 18632 18633 18634 18635 18636 18637 18638 18639 18640 18641 18642 18643 18644 18645 18646 18647 18648 18649 18650 18651 18652 18653 18654 18655 18656 18657 18658 18659 18660 18661 18662 18663 18664 18665 18666 18667 18668 18669 18670 18671 18672 18673 18674 18675 18676 18677 18678 18679 18680 18681 18682 18683 18684 18685 18686 18687 18688 18689 18690 18691 18692 18693 18694 18695 18696 18697 18698 18699 18700 18701 18702 18703 18704 18705 18706 18707 18708 18709 18710 18711 18712 18713 18714 18715 18716 18717 18718 18719 18720 18721 18722 18723 18724 18725 18726 18727 18728 18729 18730 18731 18732 18733 18734 18735 18736 18737 18738 18739 18740 18741 18742 18743 18744 18745 18746 18747 18748 18749 18750 18751 18752 18753 18754 18755 18756 18757 18758 18759 18760 18761 18762 18763 18764 18765 18766 18767 18768 18769 18770 18771 18772 18773 18774 18775 18776 18777 18778 18779 18780 18781 18782 18783 18784 18785 18786 18787 18788 18789 18790 18791 18792 18793 18794 18795 18796 18797 18798 18799 18800 18801 18802 18803 18804 18805 18806 18807 18808 18809 18810 18811 18812 18813 18814 18815 18816 18817 18818 18819 18820 18821 18822 18823 18824 18825 18826 18827 18828 18829 18830 18831 18832 18833 18834 18835 18836 18837 18838 18839 18840 18841 18842 18843 18844 18845 18846 18847 18848 18849 18850 18851 18852 18853 18854 18855 18856 18857 18858 18859 18860 18861 18862 18863 18864 18865 18866 18867 18868 18869 18870 18871 18872 18873 18874 18875 18876 18877 18878 18879 18880 18881 18882 18883 18884 18885 18886 18887 18888 18889 18890 18891 18892 18893 18894 18895 18896 18897 18898 18899 18900 18901 18902 18903 18904 18905 18906 18907 18908 18909 18910 18911 18912 18913 18914 18915 18916 18917 18918 18919 18920 18921 18922 18923 18924 18925 18926 18927 18928 18929 18930 18931 18932 18933 18934 18935 18936 18937 18938 18939 18940 18941 18942 18943 18944 18945 18946 18947 18948 18949 18950 18951 18952 18953 18954 18955 18956 18957 18958 18959 18960 18961 18962 18963 18964 18965 18966 18967 18968 18969 18970 18971 18972 18973 18974 18975 18976 18977 18978 18979 18980 18981 18982 18983 18984 18985 18986 18987 18988 18989 18990 18991 18992 18993 18994 18995 18996 18997 18998 18999 19000 19001 19002 19003 19004 19005 19006 19007 19008 19009 19010 19011 19012 19013 19014 19015 19016 19017 19018 19019 19020 19021 19022 19023 19024 19025 19026 19027 19028 19029 19030 19031 19032 19033 19034 19035 19036 19037 19038 19039 19040 19041 19042 19043 19044 19045 19046 19047 19048 19049 19050 19051 19052 19053 19054 19055 19056 19057 19058 19059 19060 19061 19062 19063 19064 19065 19066 19067 19068 19069 19070 19071 19072 19073 19074 19075 19076 19077 19078 19079 19080 19081 19082 19083 19084 19085 19086 19087 19088 19089 19090 19091 19092 19093 19094 19095 19096 19097 19098 19099 19100 19101 19102 19103 19104 19105 19106 19107 19108 19109 19110 19111 19112 19113 19114 19115 19116 19117 19118 19119 19120 19121 19122 19123 19124 19125 19126 19127 19128 19129 19130 19131 19132 19133 19134 19135 19136 19137 19138 19139 19140 19141 19142 19143 19144 19145 19146 19147 19148 19149 19150 19151 19152 19153 19154 19155 19156 19157 19158 19159 19160 19161 19162 19163 19164 19165 19166 19167 19168 19169 19170 19171 19172 19173 19174 19175 19176 19177 19178 19179 19180 19181 19182 19183 19184 19185 19186 19187 19188 19189 19190 19191 19192 19193 19194 19195 19196 19197 19198 19199 19200 19201 19202 19203 19204 19205 19206 19207 19208 19209 19210 19211 19212 19213 19214 19215 19216 19217 19218 19219 19220 19221 19222 19223 19224 19225 19226 19227 19228 19229 19230 19231 19232 19233 19234 19235 19236 19237 19238 19239 19240 19241 19242 19243 19244 19245 19246 19247 19248 19249 19250 19251 19252 19253 19254 19255 19256 19257 19258 19259 19260 19261 19262 19263 19264 19265 19266 19267 19268 19269 19270 19271 19272 19273 19274 19275 19276 19277 19278 19279 19280 19281 19282 19283 19284 19285 19286 19287 19288 19289 19290 19291 19292 19293 19294 19295 19296 19297 19298 19299 19300 19301 19302 19303 19304 19305 19306 19307 19308 19309 19310 19311 19312 19313 19314 19315 19316 19317 19318 19319 19320 19321 19322 19323 19324 19325 19326 19327 19328 19329 19330 19331 19332 19333 19334 19335 19336 19337 19338 19339 19340 19341 19342 19343 19344 19345 19346 19347 19348 19349 19350 19351 19352 19353 19354 19355 19356 19357 19358 19359 19360 19361 19362 19363 19364 19365 19366 19367 19368 19369 19370 19371 19372 19373 19374 19375 19376 19377 19378 19379 19380 19381 19382 19383 19384 19385 19386 19387 19388 19389 19390 19391 19392 19393 19394 19395 19396 19397 19398 19399 19400 19401 19402 19403 19404 19405 19406 19407 19408 19409 19410 19411 19412 19413 19414 19415 19416 19417 19418 19419 19420 19421 19422 19423 19424 19425 19426 19427 19428 19429 19430 19431 19432 19433 19434 19435 19436 19437 19438 19439 19440 19441 19442 19443 19444 19445 19446 19447 19448 19449 19450 19451 19452 19453 19454 19455 19456 19457 19458 19459 19460 19461 19462 19463 19464 19465 19466 19467 19468 19469 19470 19471 19472 19473 19474 19475 19476 19477 19478 19479 19480 19481 19482 19483 19484 19485 19486 19487 19488 19489 19490 19491 19492 19493 19494 19495 19496 19497 19498 19499 19500 19501 19502 19503 19504 19505 19506 19507 19508 19509 19510 19511 19512 19513 19514 19515 19516 19517 19518 19519 19520 19521 19522 19523 19524 19525 19526 19527 19528 19529 19530 19531 19532 19533 19534 19535 19536 19537 19538 19539 19540 19541 19542 19543 19544 19545 19546 19547 19548 19549 19550 19551 19552 19553 19554 19555 19556 19557 19558 19559 19560 19561 19562 19563 19564 19565 19566 19567 19568 19569 19570 19571 19572 19573 19574 19575 19576 19577 19578 19579 19580 19581 19582 19583 19584 19585 19586 19587 19588 19589 19590 19591 19592 19593 19594 19595 19596 19597 19598 19599 19600 19601 19602 19603 19604 19605 19606 19607 19608 19609 19610 19611 19612 19613 19614 19615 19616 19617 19618 19619 19620 19621 19622 19623 19624 19625 19626 19627 19628 19629 19630 19631 19632 19633 19634 19635 19636 19637 19638 19639 19640 19641 19642 19643 19644 19645 19646 19647 19648 19649 19650 19651 19652 19653 19654 19655 19656 19657 19658 19659 19660 19661 19662 19663 19664 19665 19666 19667 19668 19669 19670 19671 19672 19673 19674 19675 19676 19677 19678 19679 19680 19681 19682 19683 19684 19685 19686 19687 19688 19689 19690 19691 19692 19693 19694 19695 19696 19697 19698 19699 19700 19701 19702 19703 19704 19705 19706 19707 19708 19709 19710 19711 19712 19713 19714 19715 19716 19717 19718 19719 19720 19721 19722 19723 19724 19725 19726 19727 19728 19729 19730 19731 19732 19733 19734 19735 19736 19737 19738 19739 19740 19741 19742 19743 19744 19745 19746 19747 19748 19749 19750 19751 19752 19753 19754 19755 19756 19757 19758 19759 19760 19761 19762 19763 19764 19765 19766 19767 19768 19769 19770 19771 19772 19773 19774 19775 19776 19777 19778 19779 19780 19781 19782 19783 19784 19785 19786 19787 19788 19789 19790 19791 19792 19793 19794 19795 19796 19797 19798 19799 19800 19801 19802 19803 19804 19805 19806 19807 19808 19809 19810 19811 19812 19813 19814 19815 19816 19817 19818 19819 19820 19821 19822 19823 19824 19825 19826 19827 19828 19829 19830 19831 19832 19833 19834 19835 19836 19837 19838 19839 19840 19841 19842 19843 19844 19845 19846 19847 19848 19849 19850 19851 19852 19853 19854 19855 19856 19857 19858 19859 19860 19861 19862 19863 19864 19865 19866 19867 19868 19869 19870 19871 19872 19873 19874 19875 19876 19877 19878 19879 19880 19881 19882 19883 19884 19885 19886 19887 19888 19889 19890 19891 19892 19893 19894 19895 19896 19897 19898 19899 19900 19901 19902 19903 19904 19905 19906 19907 19908 19909 19910 19911 19912 19913 19914 19915 19916 19917 19918 19919 19920 19921 19922 19923 19924 19925 19926 19927 19928 19929 19930 19931 19932 19933 19934 19935 19936 19937 19938 19939 19940 19941 19942 19943 19944 19945 19946 19947 19948 19949 19950 19951 19952 19953 19954 19955 19956 19957 19958 19959 19960 19961 19962 19963 19964 19965 19966 19967 19968 19969 19970 19971 19972 19973 19974 19975 19976 19977 19978 19979 19980 19981 19982 19983 19984 19985 19986 19987 19988 19989 19990 19991 19992 19993 19994 19995 19996 19997 19998 19999 20000 20001 20002 20003 20004 20005 20006 20007 20008 20009 20010 20011 20012 20013 20014 20015 20016 20017 20018 20019 20020 20021 20022 20023 20024 20025 20026 20027 20028 20029 20030 20031 20032 20033 20034 20035 20036 20037 20038 20039 20040 20041 20042 20043 20044 20045 20046 20047 20048 20049 20050 20051 20052 20053 20054 20055 20056 20057 20058 20059 20060 20061 20062 20063 20064 20065 20066 20067 20068 20069 20070 20071 20072 20073 20074 20075 20076 20077 20078 20079 20080 20081 20082 20083 20084 20085 20086 20087 20088 20089 20090 20091 20092 20093 20094 20095 20096 20097 20098 20099 20100 20101 20102 20103 20104 20105 20106 20107 20108 20109 20110 20111 20112 20113 20114 20115 20116 20117 20118 20119 20120 20121 20122 20123 20124 20125 20126 20127 20128 20129 20130 20131 20132 20133 20134 20135 20136 20137 20138 20139 20140 20141 20142 20143 20144 20145 20146 20147 20148 20149 20150 20151 20152 20153 20154 20155 20156 20157 20158 20159 20160 20161 20162 20163 20164 20165 20166 20167 20168 20169 20170 20171 20172 20173 20174 20175 20176 20177 20178 20179 20180 20181 20182 20183 20184 20185 20186 20187 20188 20189 20190 20191 20192 20193 20194 20195 20196 20197 20198 20199 20200 20201 20202 20203 20204 20205 20206 20207 20208 20209 20210 20211 20212 20213 20214 20215 20216 20217 20218 20219 20220 20221 20222 20223 20224 20225 20226 20227 20228 20229 20230 20231 20232 20233 20234 20235 20236 20237 20238 20239 20240 20241 20242 20243 20244 20245 20246 20247 20248 20249 20250 20251 20252 20253 20254 20255 20256 20257 20258 20259 20260 20261 20262 20263 20264 20265 20266 20267 20268 20269 20270 20271 20272 20273 20274 20275 20276 20277 20278 20279 20280 20281 20282 20283 20284 20285 20286 20287 20288 20289 20290 20291 20292 20293 20294 20295 20296 20297 20298 20299 20300 20301 20302 20303 20304 20305 20306 20307 20308 20309 20310 20311 20312 20313 20314 20315 20316 20317 20318 20319 20320 20321 20322 20323 20324 20325 20326 20327 20328 20329 20330 20331 20332 20333 20334 20335 20336 20337 20338 20339 20340 20341 20342 20343 20344 20345 20346 20347 20348 20349 20350 20351 20352 20353 20354 20355 20356 20357 20358 20359 20360 20361 20362 20363 20364 20365 20366 20367 20368 20369 20370 20371 20372 20373 20374 20375 20376 20377 20378 20379 20380 20381 20382 20383 20384 20385 20386 20387 20388 20389 20390 20391 20392 20393 20394 20395 20396 20397 20398 20399 20400 20401 20402 20403 20404 20405 20406 20407 20408 20409 20410 20411 20412 20413 20414 20415 20416 20417 20418 20419 20420 20421 20422 20423 20424 20425 20426 20427 20428 20429 20430 20431 20432 20433 20434 20435 20436 20437 20438 20439 20440 20441 20442 20443 20444 20445 20446 20447 20448 20449 20450 20451 20452 20453 20454 20455 20456 20457 20458 20459 20460 20461 20462 20463 20464 20465 20466 20467 20468 20469 20470 20471 20472 20473 20474 20475 20476 20477 20478 20479 20480 20481 20482 20483 20484 20485 20486 20487 20488 20489 20490 20491 20492 20493 20494 20495 20496 20497 20498 20499 20500 20501 20502 20503 20504 20505 20506 20507 20508 20509 20510 20511 20512 20513 20514 20515 20516 20517 20518 20519 20520 20521 20522 20523 20524 20525 20526 20527 20528 20529 20530 20531 20532 20533 20534 20535 20536 20537 20538 20539 20540 20541 20542 20543 20544 20545 20546 20547 20548 20549 20550 20551 20552 20553 20554 20555 20556 20557 20558 20559 20560 20561 20562 20563 20564 20565 20566 20567 20568 20569 20570 20571 20572 20573 20574 20575 20576 20577 20578 20579 20580 20581 20582 20583 20584 20585 20586 20587 20588 20589 20590 20591 20592 20593 20594 20595 20596 20597 20598 20599 20600 20601 20602 20603 20604 20605 20606 20607 20608 20609 20610 20611 20612 20613 20614 20615 20616 20617 20618 20619 20620 20621 20622 20623 20624 20625 20626 20627 20628 20629 20630 20631 20632 20633 20634 20635 20636 20637 20638 20639 20640 20641 20642 20643 20644 20645 20646 20647 20648 20649 20650 20651 20652 20653 20654 20655 20656 20657 20658 20659 20660 20661 20662 20663 20664 20665 20666 20667 20668 20669 20670 20671 20672 20673 20674 20675 20676 20677 20678 20679 20680 20681 20682 20683 20684 20685 20686 20687 20688 20689 20690 20691 20692 20693 20694 20695 20696 20697 20698 20699 20700 20701 20702 20703 20704 20705 20706 20707 20708 20709 20710 20711 20712 20713 20714 20715 20716 20717 20718 20719 20720 20721 20722 20723 20724 20725 20726 20727 20728 20729 20730 20731 20732 20733 20734 20735 20736 20737 20738 20739 20740 20741 20742 20743 20744 20745 20746 20747 20748 20749 20750 20751 20752 20753 20754 20755 20756 20757 20758 20759 20760 20761 20762 20763 20764 20765 20766 20767 20768 20769 20770 20771 20772 20773 20774 20775 20776 20777 20778 20779 20780 20781 20782 20783 20784 20785 20786 20787 20788 20789 20790 20791 20792 20793 20794 20795 20796 20797 20798 20799 20800 20801 20802 20803 20804 20805 20806 20807 20808 20809 20810 20811 20812 20813 20814 20815 20816 20817 20818 20819 20820 20821 20822 20823 20824 20825 20826 20827 20828 20829 20830 20831 20832 20833 20834 20835 20836 20837 20838 20839 20840 20841 20842 20843 20844 20845 20846 20847 20848 20849 20850 20851 20852 20853 20854 20855 20856 20857 20858 20859 20860 20861 20862 20863 20864 20865 20866 20867 20868 20869 20870 20871 20872 20873 20874 20875 20876 20877 20878 20879 20880 20881 20882 20883 20884 20885 20886 20887 20888 20889 20890 20891 20892 20893 20894 20895 20896 20897 20898 20899 20900 20901 20902 20903 20904 20905 20906 20907 20908 20909 20910 20911 20912 20913 20914 20915 20916 20917 20918 20919 20920 20921 20922 20923 20924 20925 20926 20927 20928 20929 20930 20931 20932 20933 20934 20935 20936 20937 20938 20939 20940 20941 20942 20943 20944 20945 20946 20947 20948 20949 20950 20951 20952 20953 20954 20955 20956 20957 20958 20959 20960 20961 20962 20963 20964 20965 20966 20967 20968 20969 20970 20971 20972 20973 20974 20975 20976 20977 20978 20979 20980 20981 20982 20983 20984 20985 20986 20987 20988 20989 20990 20991 20992 20993 20994 20995 20996 20997 20998 20999 21000 21001 21002 21003 21004 21005 21006 21007 21008 21009 21010 21011 21012 21013 21014 21015 21016 21017 21018 21019 21020 21021 21022 21023 21024 21025 21026 21027 21028 21029 21030 21031 21032 21033 21034 21035 21036 21037 21038 21039 21040 21041 21042 21043 21044 21045 21046 21047 21048 21049 21050 21051 21052 21053 21054 21055 21056 21057 21058 21059 21060 21061 21062 21063 21064 21065 21066 21067 21068 21069 21070 21071 21072 21073 21074 21075 21076 21077 21078 21079 21080 21081 21082 21083 21084 21085 21086 21087 21088 21089 21090 21091 21092 21093 21094 21095 21096 21097 21098 21099 21100 21101 21102 21103 21104 21105 21106 21107 21108 21109 21110 21111 21112 21113 21114 21115 21116 21117 21118 21119 21120 21121 21122 21123 21124 21125 21126 21127 21128 21129 21130 21131 21132 21133 21134 21135 21136 21137 21138 21139 21140 21141 21142 21143 21144 21145 21146 21147 21148 21149 21150 21151 21152 21153 21154 21155 21156 21157 21158 21159 21160 21161 21162 21163 21164 21165 21166 21167 21168 21169 21170 21171 21172 21173 21174 21175 21176 21177 21178 21179 21180 21181 21182 21183 21184 21185 21186 21187 21188 21189 21190 21191 21192 21193 21194 21195 21196 21197 21198 21199 21200 21201 21202 21203 21204 21205 21206 21207 21208 21209 21210 21211 21212 21213 21214 21215 21216 21217 21218 21219 21220 21221 21222 21223 21224 21225 21226 21227 21228 21229 21230 21231 21232 21233 21234 21235 21236 21237 21238 21239 21240 21241 21242 21243 21244 21245 21246 21247 21248 21249 21250 21251 21252 21253 21254 21255 21256 21257 21258 21259 21260 21261 21262 21263 21264 21265 21266 21267 21268 21269 21270 21271 21272 21273 21274 21275 21276 21277 21278 21279 21280 21281 21282 21283 21284 21285 21286 21287 21288 21289 21290 21291 21292 21293 21294 21295 21296 21297 21298 21299 21300 21301 21302 21303 21304 21305 21306 21307 21308 21309 21310 21311 21312 21313 21314 21315 21316 21317 21318 21319 21320 21321 21322 21323 21324 21325 21326 21327 21328 21329 21330 21331 21332 21333 21334 21335 21336 21337 21338 21339 21340 21341 21342 21343 21344 21345 21346 21347 21348 21349 21350 21351 21352 21353 21354 21355 21356 21357 21358 21359 21360 21361 21362 21363 21364 21365 21366 21367 21368 21369 21370 21371 21372 21373 21374 21375 21376 21377 21378 21379 21380 21381 21382 21383 21384 21385 21386 21387 21388 21389 21390 21391 21392 21393 21394 21395 21396 21397 21398 21399 21400 21401 21402 21403 21404 21405 21406 21407 21408 21409 21410 21411 21412 21413 21414 21415 21416 21417 21418 21419 21420 21421 21422 21423 21424 21425 21426 21427 21428 21429 21430 21431 21432 21433 21434 21435 21436 21437 21438 21439 21440 21441 21442 21443 21444 21445 21446 21447 21448 21449 21450 21451 21452 21453 21454 21455 21456 21457 21458 21459 21460 21461 21462 21463 21464 21465 21466 21467 21468 21469 21470 21471 21472 21473 21474 21475 21476 21477 21478 21479 21480 21481 21482 21483 21484 21485 21486 21487 21488 21489 21490 21491 21492 21493 21494 21495 21496 21497 21498 21499 21500 21501 21502 21503 21504 21505 21506 21507 21508 21509 21510 21511 21512 21513 21514 21515 21516 21517 21518 21519 21520 21521 21522 21523 21524 21525 21526 21527 21528 21529 21530 21531 21532 21533 21534 21535 21536 21537 21538 21539 21540 21541 21542 21543 21544 21545 21546 21547 21548 21549 21550 21551 21552 21553 21554 21555 21556 21557 21558 21559 21560 21561 21562 21563 21564 21565 21566 21567 21568 21569 21570 21571 21572 21573 21574 21575 21576 21577 21578 21579 21580 21581 21582 21583 21584 21585 21586 21587 21588 21589 21590 21591 21592 21593 21594 21595 21596 21597 21598 21599 21600 21601 21602 21603 21604 21605 21606 21607 21608 21609 21610 21611 21612 21613 21614 21615 21616 21617 21618 21619 21620 21621 21622 21623 21624 21625 21626 21627 21628 21629 21630 21631 21632 21633 21634 21635 21636 21637 21638 21639 21640 21641 21642 21643 21644 21645 21646 21647 21648 21649 21650 21651 21652 21653 21654 21655 21656 21657 21658 21659 21660 21661 21662 21663 21664 21665 21666 21667 21668 21669 21670 21671 21672 21673 21674 21675 21676 21677 21678 21679 21680 21681 21682 21683 21684 21685 21686 21687 21688 21689 21690 21691 21692 21693 21694 21695 21696 21697 21698 21699 21700 21701 21702 21703 21704 21705 21706 21707 21708 21709 21710 21711 21712 21713 21714 21715 21716 21717 21718 21719 21720 21721 21722 21723 21724 21725 21726 21727 21728 21729 21730 21731 21732 21733 21734 21735 21736 21737 21738 21739 21740 21741 21742 21743 21744 21745 21746 21747 21748 21749 21750 21751 21752 21753 21754 21755 21756 21757 21758 21759 21760 21761 21762 21763 21764 21765 21766 21767 21768 21769 21770 21771 21772 21773 21774 21775 21776 21777 21778 21779 21780 21781 21782 21783 21784 21785 21786 21787 21788 21789 21790 21791 21792 21793 21794 21795 21796 21797 21798 21799 21800 21801 21802 21803 21804 21805 21806 21807 21808 21809 21810 21811 21812 21813 21814 21815 21816 21817 21818 21819 21820 21821 21822 21823 21824 21825 21826 21827 21828 21829 21830 21831 21832 21833 21834 21835 21836 21837 21838 21839 21840 21841 21842 21843 21844 21845 21846 21847 21848 21849 21850 21851 21852 21853 21854 21855 21856 21857 21858 21859 21860 21861 21862 21863 21864 21865 21866 21867 21868 21869 21870 21871 21872 21873 21874 21875 21876 21877 21878 21879 21880 21881 21882 21883 21884 21885 21886 21887 21888 21889 21890 21891 21892 21893 21894 21895 21896 21897 21898 21899 21900 21901 21902 21903 21904 21905 21906 21907 21908 21909 21910 21911 21912 21913 21914 21915 21916 21917 21918 21919 21920 21921 21922 21923 21924 21925 21926 21927 21928 21929 21930 21931 21932 21933 21934 21935 21936 21937 21938 21939 21940 21941 21942 21943 21944 21945 21946 21947 21948 21949 21950 21951 21952 21953 21954 21955 21956 21957 21958 21959 21960 21961 21962 21963 21964 21965 21966 21967 21968 21969 21970 21971 21972 21973 21974 21975 21976 21977 21978 21979 21980 21981 21982 21983 21984 21985 21986 21987 21988 21989 21990 21991 21992 21993 21994 21995 21996 21997 21998 21999 22000 22001 22002 22003 22004 22005 22006 22007 22008 22009 22010 22011 22012 22013 22014 22015 22016 22017 22018 22019 22020 22021 22022 22023 22024 22025 22026 22027 22028 22029 22030 22031 22032 22033 22034 22035 22036 22037 22038 22039 22040 22041 22042 22043 22044 22045 22046 22047 22048 22049 22050 22051 22052 22053 22054 22055 22056 22057 22058 22059 22060 22061 22062 22063 22064 22065 22066 22067 22068 22069 22070 22071 22072 22073 22074 22075 22076 22077 22078 22079 22080 22081 22082 22083 22084 22085 22086 22087 22088 22089 22090 22091 22092 22093 22094 22095 22096 22097 22098 22099 22100 22101 22102 22103 22104 22105 22106 22107 22108 22109 22110 22111 22112 22113 22114 22115 22116 22117 22118 22119 22120 22121 22122 22123 22124 22125 22126 22127 22128 22129 22130 22131 22132 22133 22134 22135 22136 22137 22138 22139 22140 22141 22142 22143 22144 22145 22146 22147 22148 22149 22150 22151 22152 22153 22154 22155 22156 22157 22158 22159 22160 22161 22162 22163 22164 22165 22166 22167 22168 22169 22170 22171 22172 22173 22174 22175 22176 22177 22178 22179 22180 22181 22182 22183 22184 22185 22186 22187 22188 22189 22190 22191 22192 22193 22194 22195 22196 22197 22198 22199 22200 22201 22202 22203 22204 22205 22206 22207 22208 22209 22210 22211 22212 22213 22214 22215 22216 22217 22218 22219 22220 22221 22222 22223 22224 22225 22226 22227 22228 22229 22230 22231 22232 22233 22234 22235 22236 22237 22238 22239 22240 22241 22242 22243 22244 22245 22246 22247 22248 22249 22250 22251 22252 22253 22254 22255 22256 22257 22258 22259 22260 22261 22262 22263 22264 22265 22266 22267 22268 22269 22270 22271 22272 22273 22274 22275 22276 22277 22278 22279 22280 22281 22282 22283 22284 22285 22286 22287 22288 22289 22290 22291 22292 22293 22294 22295 22296 22297 22298 22299 22300 22301 22302 22303 22304 22305 22306 22307 22308 22309 22310 22311 22312 22313 22314 22315 22316 22317 22318 22319 22320 22321 22322 22323 22324 22325 22326 22327 22328 22329 22330 22331 22332 22333 22334 22335 22336 22337 22338 22339 22340 22341 22342 22343 22344 22345 22346 22347 22348 22349 22350 22351 22352 22353 22354 22355 22356 22357 22358 22359 22360 22361 22362 22363 22364 22365 22366 22367 22368 22369 22370 22371 22372 22373 22374 22375 22376 22377 22378 22379 22380 22381 22382 22383 22384 22385 22386 22387 22388 22389 22390 22391 22392 22393 22394 22395 22396 22397 22398 22399 22400 22401 22402 22403 22404 22405 22406 22407 22408 22409 22410 22411 22412 22413 22414 22415 22416 22417 22418 22419 22420 22421 22422 22423 22424 22425 22426 22427 22428 22429 22430 22431 22432 22433 22434 22435 22436 22437 22438 22439 22440 22441 22442 22443 22444 22445 22446 22447 22448 22449 22450 22451 22452 22453 22454 22455 22456 22457 22458 22459 22460 22461 22462 22463 22464 22465 22466 22467 22468 22469 22470 22471 22472 22473 22474 22475 22476 22477 22478 22479 22480 22481 22482 22483 22484 22485 22486 22487 22488 22489 22490 22491 22492 22493 22494 22495 22496 22497 22498 22499 22500 22501 22502 22503 22504 22505 22506 22507 22508 22509 22510 22511 22512 22513 22514 22515 22516 22517 22518 22519 22520 22521 22522 22523 22524 22525 22526 22527 22528 22529 22530 22531 22532 22533 22534 22535 22536 22537 22538 22539 22540 22541 22542 22543 22544 22545 22546 22547 22548 22549 22550 22551 22552 22553 22554 22555 22556 22557 22558 22559 22560 22561 22562 22563 22564 22565 22566 22567 22568 22569 22570 22571 22572 22573 22574 22575 22576 22577 22578 22579 22580 22581 22582 22583 22584 22585 22586 22587 22588 22589 22590 22591 22592 22593 22594 22595 22596 22597 22598 22599 22600 22601 22602 22603 22604 22605 22606 22607 22608 22609 22610 22611 22612 22613 22614 22615 22616 22617 22618 22619 22620 22621 22622 22623 22624 22625 22626 22627 22628 22629 22630 22631 22632 22633 22634 22635 22636 22637 22638 22639 22640 22641 22642 22643 22644 22645 22646 22647 22648 22649 22650 22651 22652 22653 22654 22655 22656 22657 22658 22659 22660 22661 22662 22663 22664 22665 22666 22667 22668 22669 22670 22671 22672 22673 22674 22675 22676 22677 22678 22679 22680 22681 22682 22683 22684 22685 22686 22687 22688 22689 22690 22691 22692 22693 22694 22695 22696 22697 22698 22699 22700 22701 22702 22703 22704 22705 22706 22707 22708 22709 22710 22711 22712 22713 22714 22715 22716 22717 22718 22719 22720 22721 22722 22723 22724 22725 22726 22727 22728 22729 22730 22731 22732 22733 22734 22735 22736 22737 22738 22739 22740 22741 22742 22743 22744 22745 22746 22747 22748 22749 22750 22751 22752 22753 22754 22755 22756 22757 22758 22759 22760 22761 22762 22763 22764 22765 22766 22767 22768 22769 22770 22771 22772 22773 22774 22775 22776 22777 22778 22779 22780 22781 22782 22783 22784 22785 22786 22787 22788 22789 22790 22791 22792 22793 22794 22795 22796 22797 22798 22799 22800 22801 22802 22803 22804 22805 22806 22807 22808 22809 22810 22811 22812 22813 22814 22815 22816 22817 22818 22819 22820 22821 22822 22823 22824 22825 22826 22827 22828 22829 22830 22831 22832 22833 22834 22835 22836 22837 22838 22839 22840 22841 22842 22843 22844 22845 22846 22847 22848 22849 22850 22851 22852 22853 22854 22855 22856 22857 22858 22859 22860 22861 22862 22863 22864 22865 22866 22867 22868 22869 22870 22871 22872 22873 22874 22875 22876 22877 22878 22879 22880 22881 22882 22883 22884 22885 22886 22887 22888 22889 22890 22891 22892 22893 22894 22895 22896 22897 22898 22899 22900 22901 22902 22903 22904 22905 22906 22907 22908 22909 22910 22911 22912 22913 22914 22915 22916 22917 22918 22919 22920 22921 22922 22923 22924 22925 22926 22927 22928 22929 22930 22931 22932 22933 22934 22935 22936 22937 22938 22939 22940 22941 22942 22943 22944 22945 22946 22947 22948 22949 22950 22951 22952 22953 22954 22955 22956 22957 22958 22959 22960 22961 22962 22963 22964 22965 22966 22967 22968 22969 22970 22971 22972 22973 22974 22975 22976 22977 22978 22979 22980 22981 22982 22983 22984 22985 22986 22987 22988 22989 22990 22991 22992 22993 22994 22995 22996 22997 22998 22999 23000 23001 23002 23003 23004 23005 23006 23007 23008 23009 23010 23011 23012 23013 23014 23015 23016 23017 23018 23019 23020 23021 23022 23023 23024 23025 23026 23027 23028 23029 23030 23031 23032 23033 23034 23035 23036 23037 23038 23039 23040 23041 23042 23043 23044 23045 23046 23047 23048 23049 23050 23051 23052 23053 23054 23055 23056 23057 23058 23059 23060 23061 23062 23063 23064 23065 23066 23067 23068 23069 23070 23071 23072 23073 23074 23075 23076 23077 23078 23079 23080 23081 23082 23083 23084 23085 23086 23087 23088 23089 23090 23091 23092 23093 23094 23095 23096 23097 23098 23099 23100 23101 23102 23103 23104 23105 23106 23107 23108 23109 23110 23111 23112 23113 23114 23115 23116 23117 23118 23119 23120 23121 23122 23123 23124 23125 23126 23127 23128 23129 23130 23131 23132 23133 23134 23135 23136 23137 23138 23139 23140 23141 23142 23143 23144 23145 23146 23147 23148 23149 23150 23151 23152 23153 23154 23155 23156 23157 23158 23159 23160 23161 23162 23163 23164 23165 23166 23167 23168 23169 23170 23171 23172 23173 23174 23175 23176 23177 23178 23179 23180 23181 23182 23183 23184 23185 23186 23187 23188 23189 23190 23191 23192 23193 23194 23195 23196 23197 23198 23199 23200 23201 23202 23203 23204 23205 23206 23207 23208 23209 23210 23211 23212 23213 23214 23215 23216 23217 23218 23219 23220 23221 23222 23223 23224 23225 23226 23227 23228 23229 23230 23231 23232 23233 23234 23235 23236 23237 23238 23239 23240 23241 23242 23243 23244 23245 23246 23247 23248 23249 23250 23251 23252 23253 23254 23255 23256 23257 23258 23259 23260 23261 23262 23263 23264 23265 23266 23267 23268 23269 23270 23271 23272 23273 23274 23275 23276 23277 23278 23279 23280 23281 23282 23283 23284 23285 23286 23287 23288 23289 23290 23291 23292 23293 23294 23295 23296 23297 23298 23299 23300 23301 23302 23303 23304 23305 23306 23307 23308 23309 23310 23311 23312 23313 23314 23315 23316 23317 23318 23319 23320 23321 23322 23323 23324 23325 23326 23327 23328 23329 23330 23331 23332 23333 23334 23335 23336 23337 23338 23339 23340 23341 23342 23343 23344 23345 23346 23347 23348 23349 23350 23351 23352 23353 23354 23355 23356 23357 23358 23359 23360 23361 23362 23363 23364 23365 23366 23367 23368 23369 23370 23371 23372 23373 23374 23375 23376 23377 23378 23379 23380 23381 23382 23383 23384 23385 23386 23387 23388 23389 23390 23391 23392 23393 23394 23395 23396 23397 23398 23399 23400 23401 23402 23403 23404 23405 23406 23407 23408 23409 23410 23411 23412 23413 23414 23415 23416 23417 23418 23419 23420 23421 23422 23423 23424 23425 23426 23427 23428 23429 23430 23431 23432 23433 23434 23435 23436 23437 23438 23439 23440 23441 23442 23443 23444 23445 23446 23447 23448 23449 23450 23451 23452 23453 23454 23455 23456 23457 23458 23459 23460 23461 23462 23463 23464 23465 23466 23467 23468 23469 23470 23471 23472 23473 23474 23475 23476 23477 23478 23479 23480 23481 23482 23483 23484 23485 23486 23487 23488 23489 23490 23491 23492 23493 23494 23495 23496 23497 23498 23499 23500 23501 23502 23503 23504 23505 23506 23507 23508 23509 23510 23511 23512 23513 23514 23515 23516 23517 23518 23519 23520 23521 23522 23523 23524 23525 23526 23527 23528 23529 23530 23531 23532 23533 23534 23535 23536 23537 23538 23539 23540 23541 23542 23543 23544 23545 23546 23547 23548 23549 23550 23551 23552 23553 23554 23555 23556 23557 23558 23559 23560 23561 23562 23563 23564 23565 23566 23567 23568 23569 23570 23571 23572 23573 23574 23575 23576 23577 23578 23579 23580 23581 23582 23583 23584 23585 23586 23587 23588 23589 23590 23591 23592 23593 23594 23595 23596 23597 23598 23599 23600 23601 23602 23603 23604 23605 23606 23607 23608 23609 23610 23611 23612 23613 23614 23615 23616 23617 23618 23619 23620 23621 23622 23623 23624 23625 23626 23627 23628 23629 23630 23631 23632 23633 23634 23635 23636 23637 23638 23639 23640 23641 23642 23643 23644 23645 23646 23647 23648 23649 23650 23651 23652 23653 23654 23655 23656 23657 23658 23659 23660 23661 23662 23663 23664 23665 23666 23667 23668 23669 23670 23671 23672 23673 23674 23675 23676 23677 23678 23679 23680 23681 23682 23683 23684 23685 23686 23687 23688 23689 23690 23691 23692 23693 23694 23695 23696 23697 23698 23699 23700 23701 23702 23703 23704 23705 23706 23707 23708 23709 23710 23711 23712 23713 23714 23715 23716 23717 23718 23719 23720 23721 23722 23723 23724 23725 23726 23727 23728 23729 23730 23731 23732 23733 23734 23735 23736 23737 23738 23739 23740 23741 23742 23743 23744 23745 23746 23747 23748 23749 23750 23751 23752 23753 23754 23755 23756 23757 23758 23759 23760 23761 23762 23763 23764 23765 23766 23767 23768 23769 23770 23771 23772 23773 23774 23775 23776 23777 23778 23779 23780 23781 23782 23783 23784 23785 23786 23787 23788 23789 23790 23791 23792 23793 23794 23795 23796 23797 23798 23799 23800 23801 23802 23803 23804 23805 23806 23807 23808 23809 23810 23811 23812 23813 23814 23815 23816 23817 23818 23819 23820 23821 23822 23823 23824 23825 23826 23827 23828 23829 23830 23831 23832 23833 23834 23835 23836 23837 23838 23839 23840 23841 23842 23843 23844 23845 23846 23847 23848 23849 23850 23851 23852 23853 23854 23855 23856 23857 23858 23859 23860 23861 23862 23863 23864 23865 23866 23867 23868 23869 23870 23871 23872 23873 23874 23875 23876 23877 23878 23879 23880 23881 23882 23883 23884 23885 23886 23887 23888 23889 23890 23891 23892 23893 23894 23895 23896 23897 23898 23899 23900 23901 23902 23903 23904 23905 23906 23907 23908 23909 23910 23911 23912 23913 23914 23915 23916 23917 23918 23919 23920 23921 23922 23923 23924 23925 23926 23927 23928 23929 23930 23931 23932 23933 23934 23935 23936 23937 23938 23939 23940 23941 23942 23943 23944 23945 23946 23947 23948 23949 23950 23951 23952 23953 23954 23955 23956 23957 23958 23959 23960 23961 23962 23963 23964 23965 23966 23967 23968 23969 23970 23971 23972 23973 23974 23975 23976 23977 23978 23979 23980 23981 23982 23983 23984 23985 23986 23987 23988 23989 23990 23991 23992 23993 23994 23995 23996 23997 23998 23999 24000 24001 24002 24003 24004 24005 24006 24007 24008 24009 24010 24011 24012 24013 24014 24015 24016 24017 24018 24019 24020 24021 24022 24023 24024 24025 24026 24027 24028 24029 24030 24031 24032 24033 24034 24035 24036 24037 24038 24039 24040 24041 24042 24043 24044 24045 24046 24047 24048 24049 24050 24051 24052 24053 24054 24055 24056 24057 24058 24059 24060 24061 24062 24063 24064 24065 24066 24067 24068 24069 24070 24071 24072 24073 24074 24075 24076 24077 24078 24079 24080 24081 24082 24083 24084 24085 24086 24087 24088 24089 24090 24091 24092 24093 24094 24095 24096 24097 24098 24099 24100 24101 24102 24103 24104 24105 24106 24107 24108 24109 24110 24111 24112 24113 24114 24115 24116 24117 24118 24119 24120 24121 24122 24123 24124 24125 24126 24127 24128 24129 24130 24131 24132 24133 24134 24135 24136 24137 24138 24139 24140 24141 24142 24143 24144 24145 24146 24147 24148 24149 24150 24151 24152 24153 24154 24155 24156 24157 24158 24159 24160 24161 24162 24163 24164 24165 24166 24167 24168 24169 24170 24171 24172 24173 24174 24175 24176 24177 24178 24179 24180 24181 24182 24183 24184 24185 24186 24187 24188 24189 24190 24191 24192 24193 24194 24195 24196 24197 24198 24199 24200 24201 24202 24203 24204 24205 24206 24207 24208 24209 24210 24211 24212 24213 24214 24215 24216 24217 24218 24219 24220 24221 24222 24223 24224 24225 24226 24227 24228 24229 24230 24231 24232 24233 24234 24235 24236 24237 24238 24239 24240 24241 24242 24243 24244 24245 24246 24247 24248 24249 24250 24251 24252 24253 24254 24255 24256 24257 24258 24259 24260 24261 24262 24263 24264 24265 24266 24267 24268 24269 24270 24271 24272 24273 24274 24275 24276 24277 24278 24279 24280 24281 24282 24283 24284 24285 24286 24287 24288 24289 24290 24291 24292 24293 24294 24295 24296 24297 24298 24299 24300 24301 24302 24303 24304 24305 24306 24307 24308 24309 24310 24311 24312 24313 24314 24315 24316 24317 24318 24319 24320 24321 24322 24323 24324 24325 24326 24327 24328 24329 24330 24331 24332 24333 24334 24335 24336 24337 24338 24339 24340 24341 24342 24343 24344 24345 24346 24347 24348 24349 24350 24351 24352 24353 24354 24355 24356 24357 24358 24359 24360 24361 24362 24363 24364 24365 24366 24367 24368 24369 24370 24371 24372 24373 24374 24375 24376 24377 24378 24379 24380 24381 24382 24383 24384 24385 24386 24387 24388 24389 24390 24391 24392 24393 24394 24395 24396 24397 24398 24399 24400 24401 24402 24403 24404 24405 24406 24407 24408 24409 24410 24411 24412 24413 24414 24415 24416 24417 24418 24419 24420 24421 24422 24423 24424 24425 24426 24427 24428 24429 24430 24431 24432 24433 24434 24435 24436 24437 24438 24439 24440 24441 24442 24443 24444 24445 24446 24447 24448 24449 24450 24451 24452 24453 24454 24455 24456 24457 24458 24459 24460 24461 24462 24463 24464 24465 24466 24467 24468 24469 24470 24471 24472 24473 24474 24475 24476 24477 24478 24479 24480 24481 24482 24483 24484 24485 24486 24487 24488 24489 24490 24491 24492 24493 24494 24495 24496 24497 24498 24499 24500 24501 24502 24503 24504 24505 24506 24507 24508 24509 24510 24511 24512 24513 24514 24515 24516 24517 24518 24519 24520 24521 24522 24523 24524 24525 24526 24527 24528 24529 24530 24531 24532 24533 24534 24535 24536 24537 24538 24539 24540 24541 24542 24543 24544 24545 24546 24547 24548 24549 24550 24551 24552 24553 24554 24555 24556 24557 24558 24559 24560 24561 24562 24563 24564 24565 24566 24567 24568 24569 24570 24571 24572 24573 24574 24575 24576 24577 24578 24579 24580 24581 24582 24583 24584 24585 24586 24587 24588 24589 24590 24591 24592 24593 24594 24595 24596 24597 24598 24599 24600 24601 24602 24603 24604 24605 24606 24607 24608 24609 24610 24611 24612 24613 24614 24615 24616 24617 24618 24619 24620 24621 24622 24623 24624 24625 24626 24627 24628 24629 24630 24631 24632 24633 24634 24635 24636 24637 24638 24639 24640 24641 24642 24643 24644 24645 24646 24647 24648 24649 24650 24651 24652 24653 24654 24655 24656 24657 24658 24659 24660 24661 24662 24663 24664 24665 24666 24667 24668 24669 24670 24671 24672 24673 24674 24675 24676 24677 24678 24679 24680 24681 24682 24683 24684 24685 24686 24687 24688 24689 24690 24691 24692 24693 24694 24695 24696 24697 24698 24699 24700 24701 24702 24703 24704 24705 24706 24707 24708 24709 24710 24711 24712 24713 24714 24715 24716 24717 24718 24719 24720 24721 24722 24723 24724 24725 24726 24727 24728 24729 24730 24731 24732 24733 24734 24735 24736 24737 24738 24739 24740 24741 24742 24743 24744 24745 24746 24747 24748 24749 24750 24751 24752 24753 24754 24755 24756 24757 24758 24759 24760 24761 24762 24763 24764 24765 24766 24767 24768 24769 24770 24771 24772 24773 24774 24775 24776 24777 24778 24779 24780 24781 24782 24783 24784 24785 24786 24787 24788 24789 24790 24791 24792 24793 24794 24795 24796 24797 24798 24799 24800 24801 24802 24803 24804 24805 24806 24807 24808 24809 24810 24811 24812 24813 24814 24815 24816 24817 24818 24819 24820 24821 24822 24823 24824 24825 24826 24827 24828 24829 24830 24831 24832 24833 24834 24835 24836 24837 24838 24839 24840 24841 24842 24843 24844 24845 24846 24847 24848 24849 24850 24851 24852 24853 24854 24855 24856 24857 24858 24859 24860 24861 24862 24863 24864 24865 24866 24867 24868 24869 24870 24871 24872 24873 24874 24875 24876 24877 24878 24879 24880 24881 24882 24883 24884 24885 24886 24887 24888 24889 24890 24891 24892 24893 24894 24895 24896 24897 24898 24899 24900 24901 24902 24903 24904 24905 24906 24907 24908 24909 24910 24911 24912 24913 24914 24915 24916 24917 24918 24919 24920 24921 24922 24923 24924 24925 24926 24927 24928 24929 24930 24931 24932 24933 24934 24935 24936 24937 24938 24939 24940 24941 24942 24943 24944 24945 24946 24947 24948 24949 24950 24951 24952 24953 24954 24955 24956 24957 24958 24959 24960 24961 24962 24963 24964 24965 24966 24967 24968 24969 24970 24971 24972 24973 24974 24975 24976 24977 24978 24979 24980 24981 24982 24983 24984 24985 24986 24987 24988 24989 24990 24991 24992 24993 24994 24995 24996 24997 24998 24999 25000 25001 25002 25003 25004 25005 25006 25007 25008 25009 25010 25011 25012 25013 25014 25015 25016 25017 25018 25019 25020 25021 25022 25023 25024 25025 25026 25027 25028 25029 25030 25031 25032 25033 25034 25035 25036 25037 25038 25039 25040 25041 25042 25043 25044 25045 25046 25047 25048 25049 25050 25051 25052 25053 25054 25055 25056 25057 25058 25059 25060 25061 25062 25063 25064 25065 25066 25067 25068 25069 25070 25071 25072 25073 25074 25075 25076 25077 25078 25079 25080 25081 25082 25083 25084 25085 25086 25087 25088 25089 25090 25091 25092 25093 25094 25095 25096 25097 25098 25099 25100 25101 25102 25103 25104 25105 25106 25107 25108 25109 25110 25111 25112 25113 25114 25115 25116 25117 25118 25119 25120 25121 25122 25123 25124 25125 25126 25127 25128 25129 25130 25131 25132 25133 25134 25135 25136 25137 25138 25139 25140 25141 25142 25143 25144 25145 25146 25147 25148 25149 25150 25151 25152 25153 25154 25155 25156 25157 25158 25159 25160 25161 25162 25163 25164 25165 25166 25167 25168 25169 25170 25171 25172 25173 25174 25175 25176 25177 25178 25179 25180 25181 25182 25183 25184 25185 25186 25187 25188 25189 25190 25191 25192 25193 25194 25195 25196 25197 25198 25199 25200 25201 25202 25203 25204 25205 25206 25207 25208 25209 25210 25211 25212 25213 25214 25215 25216 25217 25218 25219 25220 25221 25222 25223 25224 25225 25226 25227 25228 25229 25230 25231 25232 25233 25234 25235 25236 25237 25238 25239 25240 25241 25242 25243 25244 25245 25246 25247 25248 25249 25250 25251 25252 25253 25254 25255 25256 25257 25258 25259 25260 25261 25262 25263 25264 25265 25266 25267 25268 25269 25270 25271 25272 25273 25274 25275 25276 25277 25278 25279 25280 25281 25282 25283 25284 25285 25286 25287 25288 25289 25290 25291 25292 25293 25294 25295 25296 25297 25298 25299 25300 25301 25302 25303 25304 25305 25306 25307 25308 25309 25310 25311 25312 25313 25314 25315 25316 25317 25318 25319 25320 25321 25322 25323 25324 25325 25326 25327 25328 25329 25330 25331 25332 25333 25334 25335 25336 25337 25338 25339 25340 25341 25342 25343 25344 25345 25346 25347 25348 25349 25350 25351 25352 25353 25354 25355 25356 25357 25358 25359 25360 25361 25362 25363 25364 25365 25366 25367 25368 25369 25370 25371 25372 25373 25374 25375 25376 25377 25378 25379 25380 25381 25382 25383 25384 25385 25386 25387 25388 25389 25390 25391 25392 25393 25394 25395 25396 25397 25398 25399 25400 25401 25402 25403 25404 25405 25406 25407 25408 25409 25410 25411 25412 25413 25414 25415 25416 25417 25418 25419 25420 25421 25422 25423 25424 25425 25426 25427 25428 25429 25430 25431 25432 25433 25434 25435 25436 25437 25438 25439 25440 25441 25442 25443 25444 25445 25446 25447 25448 25449 25450 25451 25452 25453 25454 25455 25456 25457 25458 25459 25460 25461 25462 25463 25464 25465 25466 25467 25468 25469 25470 25471 25472 25473 25474 25475 25476 25477 25478 25479 25480 25481 25482 25483 25484 25485 25486 25487 25488 25489 25490 25491 25492 25493 25494 25495 25496 25497 25498 25499 25500 25501 25502 25503 25504 25505 25506 25507 25508 25509 25510 25511 25512 25513 25514 25515 25516 25517 25518 25519 25520 25521 25522 25523 25524 25525 25526 25527 25528 25529 25530 25531 25532 25533 25534 25535 25536 25537 25538 25539 25540 25541 25542 25543 25544 25545 25546 25547 25548 25549 25550 25551 25552 25553 25554 25555 25556 25557 25558 25559 25560 25561 25562 25563 25564 25565 25566 25567 25568 25569 25570 25571 25572 25573 25574 25575 25576 25577 25578 25579 25580 25581 25582 25583 25584 25585 25586 25587 25588 25589 25590 25591 25592 25593 25594 25595 25596 25597 25598 25599 25600 25601 25602 25603 25604 25605 25606 25607 25608 25609 25610 25611 25612 25613 25614 25615 25616 25617 25618 25619 25620 25621 25622 25623 25624 25625 25626 25627 25628 25629 25630 25631 25632 25633 25634 25635 25636 25637 25638 25639 25640 25641 25642 25643 25644 25645 25646 25647 25648 25649 25650 25651 25652 25653 25654 25655 25656 25657 25658 25659 25660 25661 25662 25663 25664 25665 25666 25667 25668 25669 25670 25671 25672 25673 25674 25675 25676 25677 25678 25679 25680 25681 25682 25683 25684 25685 25686 25687 25688 25689 25690 25691 25692 25693 25694 25695 25696 25697 25698 25699 25700 25701 25702 25703 25704 25705 25706 25707 25708 25709 25710 25711 25712 25713 25714 25715 25716 25717 25718 25719 25720 25721 25722 25723 25724 25725 25726 25727 25728 25729 25730 25731 25732 25733 25734 25735 25736 25737 25738 25739 25740 25741 25742 25743 25744 25745 25746 25747 25748 25749 25750 25751 25752 25753 25754 25755 25756 25757 25758 25759 25760 25761 25762 25763 25764 25765 25766 25767 25768 25769 25770 25771 25772 25773 25774 25775 25776 25777 25778 25779 25780 25781 25782 25783 25784 25785 25786 25787 25788 25789 25790 25791 25792 25793 25794 25795 25796 25797 25798 25799 25800 25801 25802 25803 25804 25805 25806 25807 25808 25809 25810 25811 25812 25813 25814 25815 25816 25817 25818 25819 25820 25821 25822 25823 25824 25825 25826 25827 25828 25829 25830 25831 25832 25833 25834 25835 25836 25837 25838 25839 25840 25841 25842 25843 25844 25845 25846 25847 25848 25849 25850 25851 25852 25853 25854 25855 25856 25857 25858 25859 25860 25861 25862 25863 25864 25865 25866 25867 25868 25869 25870 25871 25872 25873 25874 25875 25876 25877 25878 25879 25880 25881 25882 25883 25884 25885 25886 25887 25888 25889 25890 25891 25892 25893 25894 25895 25896 25897 25898 25899 25900 25901 25902 25903 25904 25905 25906 25907 25908 25909 25910 25911 25912 25913 25914 25915 25916 25917 25918 25919 25920 25921 25922 25923 25924 25925 25926 25927 25928 25929 25930 25931 25932 25933 25934 25935 25936 25937 25938 25939 25940 25941 25942 25943 25944 25945 25946 25947 25948 25949 25950 25951 25952 25953 25954 25955 25956 25957 25958 25959 25960 25961 25962 25963 25964 25965 25966 25967 25968 25969 25970 25971 25972 25973 25974 25975 25976 25977 25978 25979 25980 25981 25982 25983 25984 25985 25986 25987 25988 25989 25990 25991 25992 25993 25994 25995 25996 25997 25998 25999 26000 26001 26002 26003 26004 26005 26006 26007 26008 26009 26010 26011 26012 26013 26014 26015 26016 26017 26018 26019 26020 26021 26022 26023 26024 26025 26026 26027 26028 26029 26030 26031 26032 26033 26034 26035 26036 26037 26038 26039 26040 26041 26042 26043 26044 26045 26046 26047 26048 26049 26050 26051 26052 26053 26054 26055 26056 26057 26058 26059 26060 26061 26062 26063 26064 26065 26066 26067 26068 26069 26070 26071 26072 26073 26074 26075 26076 26077 26078 26079 26080 26081 26082 26083 26084 26085 26086 26087 26088 26089 26090 26091 26092 26093 26094 26095 26096 26097 26098 26099 26100 26101 26102 26103 26104 26105 26106 26107 26108 26109 26110 26111 26112 26113 26114 26115 26116 26117 26118 26119 26120 26121 26122 26123 26124 26125 26126 26127 26128 26129 26130 26131 26132 26133 26134 26135 26136 26137 26138 26139 26140 26141 26142 26143 26144 26145 26146 26147 26148 26149 26150 26151 26152 26153 26154 26155 26156 26157 26158 26159 26160 26161 26162 26163 26164 26165 26166 26167 26168 26169 26170 26171 26172 26173 26174 26175 26176 26177 26178 26179 26180 26181 26182 26183 26184 26185 26186 26187 26188 26189 26190 26191 26192 26193 26194 26195 26196 26197 26198 26199 26200 26201 26202 26203 26204 26205 26206 26207 26208 26209 26210 26211 26212 26213 26214 26215 26216 26217 26218 26219 26220 26221 26222 26223 26224 26225 26226 26227 26228 26229 26230 26231 26232 26233 26234 26235 26236 26237 26238 26239 26240 26241 26242 26243 26244 26245 26246 26247 26248 26249 26250 26251 26252 26253 26254 26255 26256 26257 26258 26259 26260 26261 26262 26263 26264 26265 26266 26267 26268 26269 26270 26271 26272 26273 26274 26275 26276 26277 26278 26279 26280 26281 26282 26283 26284 26285 26286 26287 26288 26289 26290 26291 26292 26293 26294 26295 26296 26297 26298 26299 26300 26301 26302 26303 26304 26305 26306 26307 26308 26309 26310 26311 26312 26313 26314 26315 26316 26317 26318 26319 26320 26321 26322 26323 26324 26325 26326 26327 26328 26329 26330 26331 26332 26333 26334 26335 26336 26337 26338 26339 26340 26341 26342 26343 26344 26345 26346 26347 26348 26349 26350 26351 26352 26353 26354 26355 26356 26357 26358 26359 26360 26361 26362 26363 26364 26365 26366 26367 26368 26369 26370 26371 26372 26373 26374 26375 26376 26377 26378 26379 26380 26381 26382 26383 26384 26385 26386 26387 26388 26389 26390 26391 26392 26393 26394 26395 26396 26397 26398 26399 26400 26401 26402 26403 26404 26405 26406 26407 26408 26409 26410 26411 26412 26413 26414 26415 26416 26417 26418 26419 26420 26421 26422 26423 26424 26425 26426 26427 26428 26429 26430 26431 26432 26433 26434 26435 26436 26437 26438 26439 26440 26441 26442 26443 26444 26445 26446 26447 26448 26449 26450 26451 26452 26453 26454 26455 26456 26457 26458 26459 26460 26461 26462 26463 26464 26465 26466 26467 26468 26469 26470 26471 26472 26473 26474 26475 26476 26477 26478 26479 26480 26481 26482 26483 26484 26485 26486 26487 26488 26489 26490 26491 26492 26493 26494 26495 26496 26497 26498 26499 26500 26501 26502 26503 26504 26505 26506 26507 26508 26509 26510 26511 26512 26513 26514 26515 26516 26517 26518 26519 26520 26521 26522 26523 26524 26525 26526 26527 26528 26529 26530 26531 26532 26533 26534 26535 26536 26537 26538 26539 26540 26541 26542 26543 26544 26545 26546 26547 26548 26549 26550 26551 26552 26553 26554 26555 26556 26557 26558 26559 26560 26561 26562 26563 26564 26565 26566 26567 26568 26569 26570 26571 26572 26573 26574 26575 26576 26577 26578 26579 26580 26581 26582 26583 26584 26585 26586 26587 26588 26589 26590 26591 26592 26593 26594 26595 26596 26597 26598 26599 26600 26601 26602 26603 26604 26605 26606 26607 26608 26609 26610 26611 26612 26613 26614 26615 26616 26617 26618 26619 26620 26621 26622 26623 26624 26625 26626 26627 26628 26629 26630 26631 26632 26633 26634 26635 26636 26637 26638 26639 26640 26641 26642 26643 26644 26645 26646 26647 26648 26649 26650 26651 26652 26653 26654 26655 26656 26657 26658 26659 26660 26661 26662 26663 26664 26665 26666 26667 26668 26669 26670 26671 26672 26673 26674 26675 26676 26677 26678 26679 26680 26681 26682 26683 26684 26685 26686 26687 26688 26689 26690 26691 26692 26693 26694 26695 26696 26697 26698 26699 26700 26701 26702 26703 26704 26705 26706 26707 26708 26709 26710 26711 26712 26713 26714 26715 26716 26717 26718 26719 26720 26721 26722 26723 26724 26725 26726 26727 26728 26729 26730 26731 26732 26733 26734 26735 26736 26737 26738 26739 26740 26741 26742 26743 26744 26745 26746 26747 26748 26749 26750 26751 26752 26753 26754 26755 26756 26757 26758 26759 26760 26761 26762 26763 26764 26765 26766 26767 26768 26769 26770 26771 26772 26773 26774 26775 26776 26777 26778 26779 26780 26781 26782 26783 26784 26785 26786 26787 26788 26789 26790 26791 26792 26793 26794 26795 26796 26797 26798 26799 26800 26801 26802 26803 26804 26805 26806 26807 26808 26809 26810 26811 26812 26813 26814 26815 26816 26817 26818 26819 26820 26821 26822 26823 26824 26825 26826 26827 26828 26829 26830 26831 26832 26833 26834 26835 26836 26837 26838 26839 26840 26841 26842 26843 26844 26845 26846 26847 26848 26849 26850 26851 26852 26853 26854 26855 26856 26857 26858 26859 26860 26861 26862 26863 26864 26865 26866 26867 26868 26869 26870 26871 26872 26873 26874 26875 26876 26877 26878 26879 26880 26881 26882 26883 26884 26885 26886 26887 26888 26889 26890 26891 26892 26893 26894 26895 26896 26897 26898 26899 26900 26901 26902 26903 26904 26905 26906 26907 26908 26909 26910 26911 26912 26913 26914 26915 26916 26917 26918 26919 26920 26921 26922 26923 26924 26925 26926 26927 26928 26929 26930 26931 26932 26933 26934 26935 26936 26937 26938 26939 26940 26941 26942 26943 26944 26945 26946 26947 26948 26949 26950 26951 26952 26953 26954 26955 26956 26957 26958 26959 26960 26961 26962 26963 26964 26965 26966 26967 26968 26969 26970 26971 26972 26973 26974 26975 26976 26977 26978 26979 26980 26981 26982 26983 26984 26985 26986 26987 26988 26989 26990 26991 26992 26993 26994 26995 26996 26997 26998 26999 27000 27001 27002 27003 27004 27005 27006 27007 27008 27009 27010 27011 27012 27013 27014 27015 27016 27017 27018 27019 27020 27021 27022 27023 27024 27025 27026 27027 27028 27029 27030 27031 27032 27033 27034 27035 27036 27037 27038 27039 27040 27041 27042 27043 27044 27045 27046 27047 27048 27049 27050 27051 27052 27053 27054 27055 27056 27057 27058 27059 27060 27061 27062 27063 27064 27065 27066 27067 27068 27069 27070 27071 27072 27073 27074 27075 27076 27077 27078 27079 27080 27081 27082 27083 27084 27085 27086 27087 27088 27089 27090 27091 27092 27093 27094 27095 27096 27097 27098 27099 27100 27101 27102 27103 27104 27105 27106 27107 27108 27109 27110 27111 27112 27113 27114 27115 27116 27117 27118 27119 27120 27121 27122 27123 27124 27125 27126 27127 27128 27129 27130 27131 27132 27133 27134 27135 27136 27137 27138 27139 27140 27141 27142 27143 27144 27145 27146 27147 27148 27149 27150 27151 27152 27153 27154 27155 27156 27157 27158 27159 27160 27161 27162 27163 27164 27165 27166 27167 27168 27169 27170 27171 27172 27173 27174 27175 27176 27177 27178 27179 27180 27181 27182 27183 27184 27185 27186 27187 27188 27189 27190 27191 27192 27193 27194 27195 27196 27197 27198 27199 27200 27201 27202 27203 27204 27205 27206 27207 27208 27209 27210 27211 27212 27213 27214 27215 27216 27217 27218 27219 27220 27221 27222 27223 27224 27225 27226 27227 27228 27229 27230 27231 27232 27233 27234 27235 27236 27237 27238 27239 27240 27241 27242 27243 27244 27245 27246 27247 27248 27249 27250 27251 27252 27253 27254 27255 27256 27257 27258 27259 27260 27261 27262 27263 27264 27265 27266 27267 27268 27269 27270 27271 27272 27273 27274 27275 27276 27277 27278 27279 27280 27281 27282 27283 27284 27285 27286 27287 27288 27289 27290 27291 27292 27293 27294 27295 27296 27297 27298 27299 27300 27301 27302 27303 27304 27305 27306 27307 27308 27309 27310 27311 27312 27313 27314 27315 27316 27317 27318 27319 27320 27321 27322 27323 27324 27325 27326 27327 27328 27329 27330 27331 27332 27333 27334 27335 27336 27337 27338 27339 27340 27341 27342 27343 27344 27345 27346 27347 27348 27349 27350 27351 27352 27353 27354 27355 27356 27357 27358 27359 27360 27361 27362 27363 27364 27365 27366 27367 27368 27369 27370 27371 27372 27373 27374 27375 27376 27377 27378 27379 27380 27381 27382 27383 27384 27385 27386 27387 27388 27389 27390 27391 27392 27393 27394 27395 27396 27397 27398 27399 27400 27401 27402 27403 27404 27405 27406 27407 27408 27409 27410 27411 27412 27413 27414 27415 27416 27417 27418 27419 27420 27421 27422 27423 27424 27425 27426 27427 27428 27429 27430 27431 27432 27433 27434 27435 27436 27437 27438 27439 27440 27441 27442 27443 27444 27445 27446 27447 27448 27449 27450 27451 27452 27453 27454 27455 27456 27457 27458 27459 27460 27461 27462 27463 27464 27465 27466 27467 27468 27469 27470 27471 27472 27473 27474 27475 27476 27477 27478 27479 27480 27481 27482 27483 27484 27485 27486 27487 27488 27489 27490 27491 27492 27493 27494 27495 27496 27497 27498 27499 27500 27501 27502 27503 27504 27505 27506 27507 27508 27509 27510 27511 27512 27513 27514 27515 27516 27517 27518 27519 27520 27521 27522 27523 27524 27525 27526 27527 27528 27529 27530 27531 27532 27533 27534 27535 27536 27537 27538 27539 27540 27541 27542 27543 27544 27545 27546 27547 27548 27549 27550 27551 27552 27553 27554 27555 27556 27557 27558 27559 27560 27561 27562 27563 27564 27565 27566 27567 27568 27569 27570 27571 27572 27573 27574 27575 27576 27577 27578 27579 27580 27581 27582 27583 27584 27585 27586 27587 27588 27589 27590 27591 27592 27593 27594 27595 27596 27597 27598 27599 27600 27601 27602 27603 27604 27605 27606 27607 27608 27609 27610 27611 27612 27613 27614 27615 27616 27617 27618 27619 27620 27621 27622 27623 27624 27625 27626 27627 27628 27629 27630 27631 27632 27633 27634 27635 27636 27637 27638 27639 27640 27641 27642 27643 27644 27645 27646 27647 27648 27649 27650 27651 27652 27653 27654 27655 27656 27657 27658 27659 27660 27661 27662 27663 27664 27665 27666 27667 27668 27669 27670 27671 27672 27673 27674 27675 27676 27677 27678 27679 27680 27681 27682 27683 27684 27685 27686 27687 27688 27689 27690 27691 27692 27693 27694 27695 27696 27697 27698 27699 27700 27701 27702 27703 27704 27705 27706 27707 27708 27709 27710 27711 27712 27713 27714 27715 27716 27717 27718 27719 27720 27721 27722 27723 27724 27725 27726 27727 27728 27729 27730 27731 27732 27733 27734 27735 27736 27737 27738 27739 27740 27741 27742 27743 27744 27745 27746 27747 27748 27749 27750 27751 27752 27753 27754 27755 27756 27757 27758 27759 27760 27761 27762 27763 27764 27765 27766 27767 27768 27769 27770 27771 27772 27773 27774 27775 27776 27777 27778 27779 27780 27781 27782 27783 27784 27785 27786 27787 27788 27789 27790 27791 27792 27793 27794 27795 27796 27797 27798 27799 27800 27801 27802 27803 27804 27805 27806 27807 27808 27809 27810 27811 27812 27813 27814 27815 27816 27817 27818 27819 27820 27821 27822 27823 27824 27825 27826 27827 27828 27829 27830 27831 27832 27833 27834 27835 27836 27837 27838 27839 27840 27841 27842 27843 27844 27845 27846 27847 27848 27849 27850 27851 27852 27853 27854 27855 27856 27857 27858 27859 27860 27861 27862 27863 27864 27865 27866 27867 27868 27869 27870 27871 27872 27873 27874 27875 27876 27877 27878 27879 27880 27881 27882 27883 27884 27885 27886 27887 27888 27889 27890 27891 27892 27893 27894 27895 27896 27897 27898 27899 27900 27901 27902 27903 27904 27905 27906 27907 27908 27909 27910 27911 27912 27913 27914 27915 27916 27917 27918 27919 27920 27921 27922 27923 27924 27925 27926 27927 27928 27929 27930 27931 27932 27933 27934 27935 27936 27937 27938 27939 27940 27941 27942 27943 27944 27945 27946 27947 27948 27949 27950 27951 27952 27953 27954 27955 27956 27957 27958 27959 27960 27961 27962 27963 27964 27965 27966 27967 27968 27969 27970 27971 27972 27973 27974 27975 27976 27977 27978 27979 27980 27981 27982 27983 27984 27985 27986 27987 27988 27989 27990 27991 27992 27993 27994 27995 27996 27997 27998 27999 28000 28001 28002 28003 28004 28005 28006 28007 28008 28009 28010 28011 28012 28013 28014 28015 28016 28017 28018 28019 28020 28021 28022 28023 28024 28025 28026 28027 28028 28029 28030 28031 28032 28033 28034 28035 28036 28037 28038 28039 28040 28041 28042 28043 28044 28045 28046 28047 28048 28049 28050 28051 28052 28053 28054 28055 28056 28057 28058 28059 28060 28061 28062 28063 28064 28065 28066 28067 28068 28069 28070 28071 28072 28073 28074 28075 28076 28077 28078 28079 28080 28081 28082 28083 28084 28085 28086 28087 28088 28089 28090 28091 28092 28093 28094 28095 28096 28097 28098 28099 28100 28101 28102 28103 28104 28105 28106 28107 28108 28109 28110 28111 28112 28113 28114 28115 28116 28117 28118 28119 28120 28121 28122 28123 28124 28125 28126 28127 28128 28129 28130 28131 28132 28133 28134 28135 28136 28137 28138 28139 28140 28141 28142 28143 28144 28145 28146 28147 28148 28149 28150 28151 28152 28153 28154 28155 28156 28157 28158 28159 28160 28161 28162 28163 28164 28165 28166 28167 28168 28169 28170 28171 28172 28173 28174 28175 28176 28177 28178 28179 28180 28181 28182 28183 28184 28185 28186 28187 28188 28189 28190 28191 28192 28193 28194 28195 28196 28197 28198 28199 28200 28201 28202 28203 28204 28205 28206 28207 28208 28209 28210 28211 28212 28213 28214 28215 28216 28217 28218 28219 28220 28221 28222 28223 28224 28225 28226 28227 28228 28229 28230 28231 28232 28233 28234 28235 28236 28237 28238 28239 28240 28241 28242 28243 28244 28245 28246 28247 28248 28249 28250 28251 28252 28253 28254 28255 28256 28257 28258 28259 28260 28261 28262 28263 28264 28265 28266 28267 28268 28269 28270 28271 28272 28273 28274 28275 28276 28277 28278 28279 28280 28281 28282 28283 28284 28285 28286 28287 28288 28289 28290 28291 28292 28293 28294 28295 28296 28297 28298 28299 28300 28301 28302 28303 28304 28305 28306 28307 28308 28309 28310 28311 28312 28313 28314 28315 28316 28317 28318 28319 28320 28321 28322 28323 28324 28325 28326 28327 28328 28329 28330 28331 28332 28333 28334 28335 28336 28337 28338 28339 28340 28341 28342 28343 28344 28345 28346 28347 28348 28349 28350 28351 28352 28353 28354 28355 28356 28357 28358 28359 28360 28361 28362 28363 28364 28365 28366 28367 28368 28369 28370 28371 28372 28373 28374 28375 28376 28377 28378 28379 28380 28381 28382 28383 28384 28385 28386 28387 28388 28389 28390 28391 28392 28393 28394 28395 28396 28397 28398 28399 28400 28401 28402 28403 28404 28405 28406 28407 28408 28409 28410 28411 28412 28413 28414 28415 28416 28417 28418 28419 28420 28421 28422 28423 28424 28425 28426 28427 28428 28429 28430 28431 28432 28433 28434 28435 28436 28437 28438 28439 28440 28441 28442 28443 28444 28445 28446 28447 28448 28449 28450 28451 28452 28453 28454 28455 28456 28457 28458 28459 28460 28461 28462 28463 28464 28465 28466 28467 28468 28469 28470 28471 28472 28473 28474 28475 28476 28477 28478 28479 28480 28481 28482 28483 28484 28485 28486 28487 28488 28489 28490 28491 28492 28493 28494 28495 28496 28497 28498 28499 28500 28501 28502 28503 28504 28505 28506 28507 28508 28509 28510 28511 28512 28513 28514 28515 28516 28517 28518 28519 28520 28521 28522 28523 28524 28525 28526 28527 28528 28529 28530 28531 28532 28533 28534 28535 28536 28537 28538 28539 28540 28541 28542 28543 28544 28545 28546 28547 28548 28549 28550 28551 28552 28553 28554 28555 28556 28557 28558 28559 28560 28561 28562 28563 28564 28565 28566 28567 28568 28569 28570 28571 28572 28573 28574 28575 28576 28577 28578 28579 28580 28581 28582 28583 28584 28585 28586 28587 28588 28589 28590 28591 28592 28593 28594 28595 28596 28597 28598 28599 28600 28601 28602 28603 28604 28605 28606 28607 28608 28609 28610 28611 28612 28613 28614 28615 28616 28617 28618 28619 28620 28621 28622 28623 28624 28625 28626 28627 28628 28629 28630 28631 28632 28633 28634 28635 28636 28637 28638 28639 28640 28641 28642 28643 28644 28645 28646 28647 28648 28649 28650 28651 28652 28653 28654 28655 28656 28657 28658 28659 28660 28661 28662 28663 28664 28665 28666 28667 28668 28669 28670 28671 28672 28673 28674 28675 28676 28677 28678 28679 28680 28681 28682 28683 28684 28685 28686 28687 28688 28689 28690 28691 28692 28693 28694 28695 28696 28697 28698 28699 28700 28701 28702 28703 28704 28705 28706 28707 28708 28709 28710 28711 28712 28713 28714 28715 28716 28717 28718 28719 28720 28721 28722 28723 28724 28725 28726 28727 28728 28729 28730 28731 28732 28733 28734 28735 28736 28737 28738 28739 28740 28741 28742 28743 28744 28745 28746 28747 28748 28749 28750 28751 28752 28753 28754 28755 28756 28757 28758 28759 28760 28761 28762 28763 28764 28765 28766 28767 28768 28769 28770 28771 28772 28773 28774 28775 28776 28777 28778 28779 28780 28781 28782 28783 28784 28785 28786 28787 28788 28789 28790 28791 28792 28793 28794 28795 28796 28797 28798 28799 28800 28801 28802 28803 28804 28805 28806 28807 28808 28809 28810 28811 28812 28813 28814 28815 28816 28817 28818 28819 28820 28821 28822 28823 28824 28825 28826 28827 28828 28829 28830 28831 28832 28833 28834 28835 28836 28837 28838 28839 28840 28841 28842 28843 28844 28845 28846 28847 28848 28849 28850 28851 28852 28853 28854 28855 28856 28857 28858 28859 28860 28861 28862 28863 28864 28865 28866 28867 28868 28869 28870 28871 28872 28873 28874 28875 28876 28877 28878 28879 28880 28881 28882 28883 28884 28885 28886 28887 28888 28889 28890 28891 28892 28893 28894 28895 28896 28897 28898 28899 28900 28901 28902 28903 28904 28905 28906 28907 28908 28909 28910 28911 28912 28913 28914 28915 28916 28917 28918 28919 28920 28921 28922 28923 28924 28925 28926 28927 28928 28929 28930 28931 28932 28933 28934 28935 28936 28937 28938 28939 28940 28941 28942 28943 28944 28945 28946 28947 28948 28949 28950 28951 28952 28953 28954 28955 28956 28957 28958 28959 28960 28961 28962 28963 28964 28965 28966 28967 28968 28969 28970 28971 28972 28973 28974 28975 28976 28977 28978 28979 28980 28981 28982 28983 28984 28985 28986 28987 28988 28989 28990 28991 28992 28993 28994 28995 28996 28997 28998 28999 29000 29001 29002 29003 29004 29005 29006 29007 29008 29009 29010 29011 29012 29013 29014 29015 29016 29017 29018 29019 29020 29021 29022 29023 29024 29025 29026 29027 29028 29029 29030 29031 29032 29033 29034 29035 29036 29037 29038 29039 29040 29041 29042 29043 29044 29045 29046 29047 29048 29049 29050 29051 29052 29053 29054 29055 29056 29057 29058 29059 29060 29061 29062 29063 29064 29065 29066 29067 29068 29069 29070 29071 29072 29073 29074 29075 29076 29077 29078 29079 29080 29081 29082 29083 29084 29085 29086 29087 29088 29089 29090 29091 29092 29093 29094 29095 29096 29097 29098 29099 29100 29101 29102 29103 29104 29105 29106 29107 29108 29109 29110 29111 29112 29113 29114 29115 29116 29117 29118 29119 29120 29121 29122 29123 29124 29125 29126 29127 29128 29129 29130 29131 29132 29133 29134 29135 29136 29137 29138 29139 29140 29141 29142 29143 29144 29145 29146 29147 29148 29149 29150 29151 29152 29153 29154 29155 29156 29157 29158 29159 29160 29161 29162 29163 29164 29165 29166 29167 29168 29169 29170 29171 29172 29173 29174 29175 29176 29177 29178 29179 29180 29181 29182 29183 29184 29185 29186 29187 29188 29189 29190 29191 29192 29193 29194 29195 29196 29197 29198 29199 29200 29201 29202 29203 29204 29205 29206 29207 29208 29209 29210 29211 29212 29213 29214 29215 29216 29217 29218 29219 29220 29221 29222 29223 29224 29225 29226 29227 29228 29229 29230 29231 29232 29233 29234 29235 29236 29237 29238 29239 29240 29241 29242 29243 29244 29245 29246 29247 29248 29249 29250 29251 29252 29253 29254 29255 29256 29257 29258 29259 29260 29261 29262 29263 29264 29265 29266 29267 29268 29269 29270 29271 29272 29273 29274 29275 29276 29277 29278 29279 29280 29281 29282 29283 29284 29285 29286 29287 29288 29289 29290 29291 29292 29293 29294 29295 29296 29297 29298 29299 29300 29301 29302 29303 29304 29305 29306 29307 29308 29309 29310 29311 29312 29313 29314 29315 29316 29317 29318 29319 29320 29321 29322 29323 29324 29325 29326 29327 29328 29329 29330 29331 29332 29333 29334 29335 29336 29337 29338 29339 29340 29341 29342 29343 29344 29345 29346 29347 29348 29349 29350 29351 29352 29353 29354 29355 29356 29357 29358 29359 29360 29361 29362 29363 29364 29365 29366 29367 29368 29369 29370 29371 29372 29373 29374 29375 29376 29377 29378 29379 29380 29381 29382 29383 29384 29385 29386 29387 29388 29389 29390 29391 29392 29393 29394 29395 29396 29397 29398 29399 29400 29401 29402 29403 29404 29405 29406 29407 29408 29409 29410 29411 29412 29413 29414 29415 29416 29417 29418 29419 29420 29421 29422 29423 29424 29425 29426 29427 29428 29429 29430 29431 29432 29433 29434 29435 29436 29437 29438 29439 29440 29441 29442 29443 29444 29445 29446 29447 29448 29449 29450 29451 29452 29453 29454 29455 29456 29457 29458 29459 29460 29461 29462 29463 29464 29465 29466 29467 29468 29469 29470 29471 29472 29473 29474 29475 29476 29477 29478 29479 29480 29481 29482 29483 29484 29485 29486 29487 29488 29489 29490 29491 29492 29493 29494 29495 29496 29497 29498 29499 29500 29501 29502 29503 29504 29505 29506 29507 29508 29509 29510 29511 29512 29513 29514 29515 29516 29517 29518 29519 29520 29521 29522 29523 29524 29525 29526 29527 29528 29529 29530 29531 29532 29533 29534 29535 29536 29537 29538 29539 29540 29541 29542 29543 29544 29545 29546 29547 29548 29549 29550 29551 29552 29553 29554 29555 29556 29557 29558 29559 29560 29561 29562 29563 29564 29565 29566 29567 29568 29569 29570 29571 29572 29573 29574 29575 29576 29577 29578 29579 29580 29581 29582 29583 29584 29585 29586 29587 29588 29589 29590 29591 29592 29593 29594 29595 29596 29597 29598 29599 29600 29601 29602 29603 29604 29605 29606 29607 29608 29609 29610 29611 29612 29613 29614 29615 29616 29617 29618 29619 29620 29621 29622 29623 29624 29625 29626 29627 29628 29629 29630 29631 29632 29633 29634 29635 29636 29637 29638 29639 29640 29641 29642 29643 29644 29645 29646 29647 29648 29649 29650 29651 29652 29653 29654 29655 29656 29657 29658 29659 29660 29661 29662 29663 29664 29665 29666 29667 29668 29669 29670 29671 29672 29673 29674 29675 29676 29677 29678 29679 29680 29681 29682 29683 29684 29685 29686 29687 29688 29689 29690 29691 29692 29693 29694 29695 29696 29697 29698 29699 29700 29701 29702 29703 29704 29705 29706 29707 29708 29709 29710 29711 29712 29713 29714 29715 29716 29717 29718 29719 29720 29721 29722 29723 29724 29725 29726 29727 29728 29729 29730 29731 29732 29733 29734 29735 29736 29737 29738 29739 29740 29741 29742 29743 29744 29745 29746 29747 29748 29749 29750 29751 29752 29753 29754 29755 29756 29757 29758 29759 29760 29761 29762 29763 29764 29765 29766 29767 29768 29769 29770 29771 29772 29773 29774 29775 29776 29777 29778 29779 29780 29781 29782 29783 29784 29785 29786 29787 29788 29789 29790 29791 29792 29793 29794 29795 29796 29797 29798 29799 29800 29801 29802 29803 29804 29805 29806 29807 29808 29809 29810 29811 29812 29813 29814 29815 29816 29817 29818 29819 29820 29821 29822 29823 29824 29825 29826 29827 29828 29829 29830 29831 29832 29833 29834 29835 29836 29837 29838 29839 29840 29841 29842 29843 29844 29845 29846 29847 29848 29849 29850 29851 29852 29853 29854 29855 29856 29857 29858 29859 29860 29861 29862 29863 29864 29865 29866 29867 29868 29869 29870 29871 29872 29873 29874 29875 29876 29877 29878 29879 29880 29881 29882 29883 29884 29885 29886 29887 29888 29889 29890 29891 29892 29893 29894 29895 29896 29897 29898 29899 29900 29901 29902 29903 29904 29905 29906 29907 29908 29909 29910 29911 29912 29913 29914 29915 29916 29917 29918 29919 29920 29921 29922 29923 29924 29925 29926 29927 29928 29929 29930 29931 29932 29933 29934 29935 29936 29937 29938 29939 29940 29941 29942 29943 29944 29945 29946 29947 29948 29949 29950 29951 29952 29953 29954 29955 29956 29957 29958 29959 29960 29961 29962 29963 29964 29965 29966 29967 29968 29969 29970 29971 29972 29973 29974 29975 29976 29977 29978 29979 29980 29981 29982 29983 29984 29985 29986 29987 29988 29989 29990 29991 29992 29993 29994 29995 29996 29997 29998 29999 30000 30001 30002 30003 30004 30005 30006 30007 30008 30009 30010 30011 30012 30013 30014 30015 30016 30017 30018 30019 30020 30021 30022 30023 30024 30025 30026 30027 30028 30029 30030 30031 30032 30033 30034 30035 30036 30037 30038 30039 30040 30041 30042 30043 30044 30045 30046 30047 30048 30049 30050 30051 30052 30053 30054 30055 30056 30057 30058 30059 30060 30061 30062 30063 30064 30065 30066 30067 30068 30069 30070 30071 30072 30073 30074 30075 30076 30077 30078 30079 30080 30081 30082 30083 30084 30085 30086 30087 30088 30089 30090 30091 30092 30093 30094 30095 30096 30097 30098 30099 30100 30101 30102 30103 30104 30105 30106 30107 30108 30109 30110 30111 30112 30113 30114 30115 30116 30117 30118 30119 30120 30121 30122 30123 30124 30125 30126 30127 30128 30129 30130 30131 30132 30133 30134 30135 30136 30137 30138 30139 30140 30141 30142 30143 30144 30145 30146 30147 30148 30149 30150 30151 30152 30153 30154 30155 30156 30157 30158 30159 30160 30161 30162 30163 30164 30165 30166 30167 30168 30169 30170 30171 30172 30173 30174 30175 30176 30177 30178 30179 30180 30181 30182 30183 30184 30185 30186 30187 30188 30189 30190 30191 30192 30193 30194 30195 30196 30197 30198 30199 30200 30201 30202 30203 30204 30205 30206 30207 30208 30209 30210 30211 30212 30213 30214 30215 30216 30217 30218 30219 30220 30221 30222 30223 30224 30225 30226 30227 30228 30229 30230 30231 30232 30233 30234 30235 30236 30237 30238 30239 30240 30241 30242 30243 30244 30245 30246 30247 30248 30249 30250 30251 30252 30253 30254 30255 30256 30257 30258 30259 30260 30261 30262 30263 30264 30265 30266 30267 30268 30269 30270 30271 30272 30273 30274 30275 30276 30277 30278 30279 30280 30281 30282 30283 30284 30285 30286 30287 30288 30289 30290 30291 30292 30293 30294 30295 30296 30297 30298 30299 30300 30301 30302 30303 30304 30305 30306 30307 30308 30309 30310 30311 30312 30313 30314 30315 30316 30317 30318 30319 30320 30321 30322 30323 30324 30325 30326 30327 30328 30329 30330 30331 30332 30333 30334 30335 30336 30337 30338 30339 30340 30341 30342 30343 30344 30345 30346 30347 30348 30349 30350 30351 30352 30353 30354 30355 30356 30357 30358 30359 30360 30361 30362 30363 30364 30365 30366 30367 30368 30369 30370 30371 30372 30373 30374 30375 30376 30377 30378 30379 30380 30381 30382 30383 30384 30385 30386 30387 30388 30389 30390 30391 30392 30393 30394 30395 30396 30397 30398 30399 30400 30401 30402 30403 30404 30405 30406 30407 30408 30409 30410 30411 30412 30413 30414 30415 30416 30417 30418 30419 30420 30421 30422 30423 30424 30425 30426 30427 30428 30429 30430 30431 30432 30433 30434 30435 30436 30437 30438 30439 30440 30441 30442 30443 30444 30445 30446 30447 30448 30449 30450 30451 30452 30453 30454 30455 30456 30457 30458 30459 30460 30461 30462 30463 30464 30465 30466 30467 30468 30469 30470 30471 30472 30473 30474 30475 30476 30477 30478 30479 30480 30481 30482 30483 30484 30485 30486 30487 30488 30489 30490 30491 30492 30493 30494 30495 30496 30497 30498 30499 30500 30501 30502 30503 30504 30505 30506 30507 30508 30509 30510 30511 30512 30513 30514 30515 30516 30517 30518 30519 30520 30521 30522 30523 30524 30525 30526 30527 30528 30529 30530 30531 30532 30533 30534 30535 30536 30537 30538 30539 30540 30541 30542 30543 30544 30545 30546 30547 30548 30549 30550 30551 30552 30553 30554 30555 30556 30557 30558 30559 30560 30561 30562 30563 30564 30565 30566 30567 30568 30569 30570 30571 30572 30573 30574 30575 30576 30577 30578 30579 30580 30581 30582 30583 30584 30585 30586 30587 30588 30589 30590 30591 30592 30593 30594 30595 30596 30597 30598 30599 30600 30601 30602 30603 30604 30605 30606 30607 30608 30609 30610 30611 30612 30613 30614 30615 30616 30617 30618 30619 30620 30621 30622 30623 30624 30625 30626 30627 30628 30629 30630 30631 30632 30633 30634 30635 30636 30637 30638 30639 30640 30641 30642 30643 30644 30645 30646 30647 30648 30649 30650 30651 30652 30653 30654 30655 30656 30657 30658 30659 30660 30661 30662 30663 30664 30665 30666 30667 30668 30669 30670 30671 30672 30673 30674 30675 30676 30677 30678 30679 30680 30681 30682 30683 30684 30685 30686 30687 30688 30689 30690 30691 30692 30693 30694 30695 30696 30697 30698 30699 30700 30701 30702 30703 30704 30705 30706 30707 30708 30709 30710 30711 30712 30713 30714 30715 30716 30717 30718 30719 30720 30721 30722 30723 30724 30725 30726 30727 30728 30729 30730 30731 30732 30733 30734 30735 30736 30737 30738 30739 30740 30741 30742 30743 30744 30745 30746 30747 30748 30749 30750 30751 30752 30753 30754 30755 30756 30757 30758 30759 30760 30761 30762 30763 30764 30765 30766 30767 30768 30769 30770 30771 30772 30773 30774 30775 30776 30777 30778 30779 30780 30781 30782 30783 30784 30785 30786 30787 30788 30789 30790 30791 30792 30793 30794 30795 30796 30797 30798 30799 30800 30801 30802 30803 30804 30805 30806 30807 30808 30809 30810 30811 30812 30813 30814 30815 30816 30817 30818 30819 30820 30821 30822 30823 30824 30825 30826 30827 30828 30829 30830 30831 30832 30833 30834 30835 30836 30837 30838 30839 30840 30841 30842 30843 30844 30845 30846 30847 30848 30849 30850 30851 30852 30853 30854 30855 30856 30857 30858 30859 30860 30861 30862 30863 30864 30865 30866 30867 30868 30869 30870 30871 30872 30873 30874 30875 30876 30877 30878 30879 30880 30881 30882 30883 30884 30885 30886 30887 30888 30889 30890 30891 30892 30893 30894 30895 30896 30897 30898 30899 30900 30901 30902 30903 30904 30905 30906 30907 30908 30909 30910 30911 30912 30913 30914 30915 30916 30917 30918 30919 30920 30921 30922 30923 30924 30925 30926 30927 30928 30929 30930 30931 30932 30933 30934 30935 30936 30937 30938 30939 30940 30941 30942 30943 30944 30945 30946 30947 30948 30949 30950 30951 30952 30953 30954 30955 30956 30957 30958 30959 30960 30961 30962 30963 30964 30965 30966 30967 30968 30969 30970 30971 30972 30973 30974 30975 30976 30977 30978 30979 30980 30981 30982 30983 30984 30985 30986 30987 30988 30989 30990 30991 30992 30993 30994 30995 30996 30997 30998 30999 31000 31001 31002 31003 31004 31005 31006 31007 31008 31009 31010 31011 31012 31013 31014 31015 31016 31017 31018 31019 31020 31021 31022 31023 31024 31025 31026 31027 31028 31029 31030 31031 31032 31033 31034 31035 31036 31037 31038 31039 31040 31041 31042 31043 31044 31045 31046 31047 31048 31049 31050 31051 31052 31053 31054 31055 31056 31057 31058 31059 31060 31061 31062 31063 31064 31065 31066 31067 31068 31069 31070 31071 31072 31073 31074 31075 31076 31077 31078 31079 31080 31081 31082 31083 31084 31085 31086 31087 31088 31089 31090 31091 31092 31093 31094 31095 31096 31097 31098 31099 31100 31101 31102 31103 31104 31105 31106 31107 31108 31109 31110 31111 31112 31113 31114 31115 31116 31117 31118 31119 31120 31121 31122 31123 31124 31125 31126 31127 31128 31129 31130 31131 31132 31133 31134 31135 31136 31137 31138 31139 31140 31141 31142 31143 31144 31145 31146 31147 31148 31149 31150 31151 31152 31153 31154 31155 31156 31157 31158 31159 31160 31161 31162 31163 31164 31165 31166 31167 31168 31169 31170 31171 31172 31173 31174 31175 31176 31177 31178 31179 31180 31181 31182 31183 31184 31185 31186 31187 31188 31189 31190 31191 31192 31193 31194 31195 31196 31197 31198 31199 31200 31201 31202 31203 31204 31205 31206 31207 31208 31209 31210 31211 31212 31213 31214 31215 31216 31217 31218 31219 31220 31221 31222 31223 31224 31225 31226 31227 31228 31229 31230 31231 31232 31233 31234 31235 31236 31237 31238 31239 31240 31241 31242 31243 31244 31245 31246 31247 31248 31249 31250 31251 31252 31253 31254 31255 31256 31257 31258 31259 31260 31261 31262 31263 31264 31265 31266 31267 31268 31269 31270 31271 31272 31273 31274 31275 31276 31277 31278 31279 31280 31281 31282 31283 31284 31285 31286 31287 31288 31289 31290 31291 31292 31293 31294 31295 31296 31297 31298 31299 31300 31301 31302 31303 31304 31305 31306 31307 31308 31309 31310 31311 31312 31313 31314 31315 31316 31317 31318 31319 31320 31321 31322 31323 31324 31325 31326 31327 31328 31329 31330 31331 31332 31333 31334 31335 31336 31337 31338 31339 31340 31341 31342 31343 31344 31345 31346 31347 31348 31349 31350 31351 31352 31353 31354 31355 31356 31357 31358 31359 31360 31361 31362 31363 31364 31365 31366 31367 31368 31369 31370 31371 31372 31373 31374 31375 31376 31377 31378 31379 31380 31381 31382 31383 31384 31385 31386 31387 31388 31389 31390 31391 31392 31393 31394 31395 31396 31397 31398 31399 31400 31401 31402 31403 31404 31405 31406 31407 31408 31409 31410 31411 31412 31413 31414 31415 31416 31417 31418 31419 31420 31421 31422 31423 31424 31425 31426 31427 31428 31429 31430 31431 31432 31433 31434 31435 31436 31437 31438 31439 31440 31441 31442 31443 31444 31445 31446 31447 31448 31449 31450 31451 31452 31453 31454 31455 31456 31457 31458 31459 31460 31461 31462 31463 31464 31465 31466 31467 31468 31469 31470 31471 31472 31473 31474 31475 31476 31477 31478 31479 31480 31481 31482 31483 31484 31485 31486 31487 31488 31489 31490 31491 31492 31493 31494 31495 31496 31497 31498 31499 31500 31501 31502 31503 31504 31505 31506 31507 31508 31509 31510 31511 31512 31513 31514 31515 31516 31517 31518 31519 31520 31521 31522 31523 31524 31525 31526 31527 31528 31529 31530 31531 31532 31533 31534 31535 31536 31537 31538 31539 31540 31541 31542 31543 31544 31545 31546 31547 31548 31549 31550 31551 31552 31553 31554 31555 31556 31557 31558 31559 31560 31561 31562 31563 31564 31565 31566 31567 31568 31569 31570 31571 31572 31573 31574 31575 31576 31577 31578 31579 31580 31581 31582 31583 31584 31585 31586 31587 31588 31589 31590 31591 31592 31593 31594 31595 31596 31597 31598 31599 31600 31601 31602 31603 31604 31605 31606 31607 31608 31609 31610 31611 31612 31613 31614 31615 31616 31617 31618 31619 31620 31621 31622 31623 31624 31625 31626 31627 31628 31629 31630 31631 31632 31633 31634 31635 31636 31637 31638 31639 31640 31641 31642 31643 31644 31645 31646 31647 31648 31649 31650 31651 31652 31653 31654 31655 31656 31657 31658 31659 31660 31661 31662 31663 31664 31665 31666 31667 31668 31669 31670 31671 31672 31673 31674 31675 31676 31677 31678 31679 31680 31681 31682 31683 31684 31685 31686 31687 31688 31689 31690 31691 31692 31693 31694 31695 31696 31697 31698 31699 31700 31701 31702 31703 31704 31705 31706 31707 31708 31709 31710 31711 31712 31713 31714 31715 31716 31717 31718 31719 31720 31721 31722 31723 31724 31725 31726 31727 31728 31729 31730 31731 31732 31733 31734 31735 31736 31737 31738 31739 31740 31741 31742 31743 31744 31745 31746 31747 31748 31749 31750 31751 31752 31753 31754 31755 31756 31757 31758 31759 31760 31761 31762 31763 31764 31765 31766 31767 31768 31769 31770 31771 31772 31773 31774 31775 31776 31777 31778 31779 31780 31781 31782 31783 31784 31785 31786 31787 31788 31789 31790 31791 31792 31793 31794 31795 31796 31797 31798 31799 31800 31801 31802 31803 31804 31805 31806 31807 31808 31809 31810 31811 31812 31813 31814 31815 31816 31817 31818 31819 31820 31821 31822 31823 31824 31825 31826 31827 31828 31829 31830 31831 31832 31833 31834 31835 31836 31837 31838 31839 31840 31841 31842 31843 31844 31845 31846 31847 31848 31849 31850 31851 31852 31853 31854 31855 31856 31857 31858 31859 31860 31861 31862 31863 31864 31865 31866 31867 31868 31869 31870 31871 31872 31873 31874 31875 31876 31877 31878 31879 31880 31881 31882 31883 31884 31885 31886 31887 31888 31889 31890 31891 31892 31893 31894 31895 31896 31897 31898 31899 31900 31901 31902 31903 31904 31905 31906 31907 31908 31909 31910 31911 31912 31913 31914 31915 31916 31917 31918 31919 31920 31921 31922 31923 31924 31925 31926 31927 31928 31929 31930 31931 31932 31933 31934 31935 31936 31937 31938 31939 31940 31941 31942 31943 31944 31945 31946 31947 31948 31949 31950 31951 31952 31953 31954 31955 31956 31957 31958 31959 31960 31961 31962 31963 31964 31965 31966 31967 31968 31969 31970 31971 31972 31973 31974 31975 31976 31977 31978 31979 31980 31981 31982 31983 31984 31985 31986 31987 31988 31989 31990 31991 31992 31993 31994 31995 31996 31997 31998 31999 32000 32001 32002 32003 32004 32005 32006 32007 32008 32009 32010 32011 32012 32013 32014 32015 32016 32017 32018 32019 32020 32021 32022 32023 32024 32025 32026 32027 32028 32029 32030 32031 32032 32033 32034 32035 32036 32037 32038 32039 32040 32041 32042 32043 32044 32045 32046 32047 32048 32049 32050 32051 32052 32053 32054 32055 32056 32057 32058 32059 32060 32061 32062 32063 32064 32065 32066 32067 32068 32069 32070 32071 32072 32073 32074 32075 32076 32077 32078 32079 32080 32081 32082 32083 32084 32085 32086 32087 32088 32089 32090 32091 32092 32093 32094 32095 32096 32097 32098 32099 32100 32101 32102 32103 32104 32105 32106 32107 32108 32109 32110 32111 32112 32113 32114 32115 32116 32117 32118 32119 32120 32121 32122 32123 32124 32125 32126 32127 32128 32129 32130 32131 32132 32133 32134 32135 32136 32137 32138 32139 32140 32141 32142 32143 32144 32145 32146 32147 32148 32149 32150 32151 32152 32153 32154 32155 32156 32157 32158 32159 32160 32161 32162 32163 32164 32165 32166 32167 32168 32169 32170 32171 32172 32173 32174 32175 32176 32177 32178 32179 32180 32181 32182 32183 32184 32185 32186 32187 32188 32189 32190 32191 32192 32193 32194 32195 32196 32197 32198 32199 32200 32201 32202 32203 32204 32205 32206 32207 32208 32209 32210 32211 32212 32213 32214 32215 32216 32217 32218 32219 32220 32221 32222 32223 32224 32225 32226 32227 32228 32229 32230 32231 32232 32233 32234 32235 32236 32237 32238 32239 32240 32241 32242 32243 32244 32245 32246 32247 32248 32249 32250 32251 32252 32253 32254 32255 32256 32257 32258 32259 32260 32261 32262 32263 32264 32265 32266 32267 32268 32269 32270 32271 32272 32273 32274 32275 32276 32277 32278 32279 32280 32281 32282 32283 32284 32285 32286 32287 32288 32289 32290 32291 32292 32293 32294 32295 32296 32297 32298 32299 32300 32301 32302 32303 32304 32305 32306 32307 32308 32309 32310 32311 32312 32313 32314 32315 32316 32317 32318 32319 32320 32321 32322 32323 32324 32325 32326 32327 32328 32329 32330 32331 32332 32333 32334 32335 32336 32337 32338 32339 32340 32341 32342 32343 32344 32345 32346 32347 32348 32349 32350 32351 32352 32353 32354 32355 32356 32357 32358 32359 32360 32361 32362 32363 32364 32365 32366 32367 32368 32369 32370 32371 32372 32373 32374 32375 32376 32377 32378 32379 32380 32381 32382 32383 32384 32385 32386 32387 32388 32389 32390 32391 32392 32393 32394 32395 32396 32397 32398 32399 32400 32401 32402 32403 32404 32405 32406 32407 32408 32409 32410 32411 32412 32413 32414 32415 32416 32417 32418 32419 32420 32421 32422 32423 32424 32425 32426 32427 32428 32429 32430 32431 32432 32433 32434 32435 32436 32437 32438 32439 32440 32441 32442 32443 32444 32445 32446 32447 32448 32449 32450 32451 32452 32453 32454 32455 32456 32457 32458 32459 32460 32461 32462 32463 32464 32465 32466 32467 32468 32469 32470 32471 32472 32473 32474 32475 32476 32477 32478 32479 32480 32481 32482 32483 32484 32485 32486 32487 32488 32489 32490 32491 32492 32493 32494 32495 32496 32497 32498 32499 32500 32501 32502 32503 32504 32505 32506 32507 32508 32509 32510 32511 32512 32513 32514 32515 32516 32517 32518 32519 32520 32521 32522 32523 32524 32525 32526 32527 32528 32529 32530 32531 32532 32533 32534 32535 32536 32537 32538 32539 32540 32541 32542 32543 32544 32545 32546 32547 32548 32549 32550 32551 32552 32553 32554 32555 32556 32557 32558 32559 32560 32561 32562 32563 32564 32565 32566 32567 32568 32569 32570 32571 32572 32573 32574 32575 32576 32577 32578 32579 32580 32581 32582 32583 32584 32585 32586 32587 32588 32589 32590 32591 32592 32593 32594 32595 32596 32597 32598 32599 32600 32601 32602 32603 32604 32605 32606 32607 32608 32609 32610 32611 32612 32613 32614 32615 32616 32617 32618 32619 32620 32621 32622 32623 32624 32625 32626 32627 32628 32629 32630 32631 32632 32633 32634 32635 32636 32637 32638 32639 32640 32641 32642 32643 32644 32645 32646 32647 32648 32649 32650 32651 32652 32653 32654 32655 32656 32657 32658 32659 32660 32661 32662 32663 32664 32665 32666 32667 32668 32669 32670 32671 32672 32673 32674 32675 32676 32677 32678 32679 32680 32681 32682 32683 32684 32685 32686 32687 32688 32689 32690 32691 32692 32693 32694 32695 32696 32697 32698 32699 32700 32701 32702 32703 32704 32705 32706 32707 32708 32709 32710 32711 32712 32713 32714 32715 32716 32717 32718 32719 32720 32721 32722 32723 32724 32725 32726 32727 32728 32729 32730 32731 32732 32733 32734 32735 32736 32737 32738 32739 32740 32741 32742 32743 32744 32745 32746 32747 32748 32749 32750 32751 32752 32753 32754 32755 32756 32757 32758 32759 32760 32761 32762 32763 32764 32765 32766 32767 32768 32769 32770 32771 32772 32773 32774 32775 32776 32777 32778 32779 32780 32781 32782 32783 32784 32785 32786 32787 32788 32789 32790 32791 32792 32793 32794 32795 32796 32797 32798 32799 32800 32801 32802 32803 32804 32805 32806 32807 32808 32809 32810 32811 32812 32813 32814 32815 32816 32817 32818 32819 32820 32821 32822 32823 32824 32825 32826 32827 32828 32829 32830 32831 32832 32833 32834 32835 32836 32837 32838 32839 32840 32841 32842 32843 32844 32845 32846 32847 32848 32849 32850 32851 32852 32853 32854 32855 32856 32857 32858 32859 32860 32861 32862 32863 32864 32865 32866 32867 32868 32869 32870 32871 32872 32873 32874 32875 32876 32877 32878 32879 32880 32881 32882 32883 32884 32885 32886 32887 32888 32889 32890 32891 32892 32893 32894 32895 32896 32897 32898 32899 32900 32901 32902 32903 32904 32905 32906 32907 32908 32909 32910 32911 32912 32913 32914 32915 32916 32917 32918 32919 32920 32921 32922 32923 32924 32925 32926 32927 32928 32929 32930 32931 32932 32933 32934 32935 32936 32937 32938 32939 32940 32941 32942 32943 32944 32945 32946 32947 32948 32949 32950 32951 32952 32953 32954 32955 32956 32957 32958 32959 32960 32961 32962 32963 32964 32965 32966 32967 32968 32969 32970 32971 32972 32973 32974 32975 32976 32977 32978 32979 32980 32981 32982 32983 32984 32985 32986 32987 32988 32989 32990 32991 32992 32993 32994 32995 32996 32997 32998 32999 33000 33001 33002 33003 33004 33005 33006 33007 33008 33009 33010 33011 33012 33013 33014 33015 33016 33017 33018 33019 33020 33021 33022 33023 33024 33025 33026 33027 33028 33029 33030 33031 33032 33033 33034 33035 33036 33037 33038 33039 33040 33041 33042 33043 33044 33045 33046 33047 33048 33049 33050 33051 33052 33053 33054 33055 33056 33057 33058 33059 33060 33061 33062 33063 33064 33065 33066 33067 33068 33069 33070 33071 33072 33073 33074 33075 33076 33077 33078 33079 33080 33081 33082 33083 33084 33085 33086 33087 33088 33089 33090 33091 33092 33093 33094 33095 33096 33097 33098 33099 33100 33101 33102 33103 33104 33105 33106 33107 33108 33109 33110 33111 33112 33113 33114 33115 33116 33117 33118 33119 33120 33121 33122 33123 33124 33125 33126 33127 33128 33129 33130 33131 33132 33133 33134 33135 33136 33137 33138 33139 33140 33141 33142 33143 33144 33145 33146 33147 33148 33149 33150 33151 33152 33153 33154 33155 33156 33157 33158 33159 33160 33161 33162 33163 33164 33165 33166 33167 33168 33169 33170 33171 33172 33173 33174 33175 33176 33177 33178 33179 33180 33181 33182 33183 33184 33185 33186 33187 33188 33189 33190 33191 33192 33193 33194 33195 33196 33197 33198 33199 33200 33201 33202 33203 33204 33205 33206 33207 33208 33209 33210 33211 33212 33213 33214 33215 33216 33217 33218 33219 33220 33221 33222 33223 33224 33225 33226 33227 33228 33229 33230 33231 33232 33233 33234 33235 33236 33237 33238 33239 33240 33241 33242 33243 33244 33245 33246 33247 33248 33249 33250 33251 33252 33253 33254 33255 33256 33257 33258 33259 33260 33261 33262 33263 33264 33265 33266 33267 33268 33269 33270 33271 33272 33273 33274 33275 33276 33277 33278 33279 33280 33281 33282 33283 33284 33285 33286 33287 33288 33289 33290 33291 33292 33293 33294 33295 33296 33297 33298 33299 33300 33301 33302 33303 33304 33305 33306 33307 33308 33309 33310 33311 33312 33313 33314 33315 33316 33317 33318 33319 33320 33321 33322 33323 33324 33325 33326 33327 33328 33329 33330 33331 33332 33333 33334 33335 33336 33337 33338 33339 33340 33341 33342 33343 33344 33345 33346 33347 33348 33349 33350 33351 33352 33353 33354 33355 33356 33357 33358 33359 33360 33361 33362 33363 33364 33365 33366 33367 33368 33369 33370 33371 33372 33373 33374 33375 33376 33377 33378 33379 33380 33381 33382 33383 33384 33385 33386 33387 33388 33389 33390 33391 33392 33393 33394 33395 33396 33397 33398 33399 33400 33401 33402 33403 33404 33405 33406 33407 33408 33409 33410 33411 33412 33413 33414 33415 33416 33417 33418 33419 33420 33421 33422 33423 33424 33425 33426 33427 33428 33429 33430 33431 33432 33433 33434 33435 33436 33437 33438 33439 33440 33441 33442 33443 33444 33445 33446 33447 33448 33449 33450 33451 33452 33453 33454 33455 33456 33457 33458 33459 33460 33461 33462 33463 33464 33465 33466 33467 33468 33469 33470 33471 33472 33473 33474 33475 33476 33477 33478 33479 33480 33481 33482 33483 33484 33485 33486 33487 33488 33489 33490 33491 33492 33493 33494 33495 33496 33497 33498 33499 33500 33501 33502 33503 33504 33505 33506 33507 33508 33509 33510 33511 33512 33513 33514 33515 33516 33517 33518 33519 33520 33521 33522 33523 33524 33525 33526 33527 33528 33529 33530 33531 33532 33533 33534 33535 33536 33537 33538 33539 33540 33541 33542 33543 33544 33545 33546 33547 33548 33549 33550 33551 33552 33553 33554 33555 33556 33557 33558 33559 33560 33561 33562 33563 33564 33565 33566 33567 33568 33569 33570 33571 33572 33573 33574 33575 33576 33577 33578 33579 33580 33581 33582 33583 33584 33585 33586 33587 33588 33589 33590 33591 33592 33593 33594 33595 33596 33597 33598 33599 33600 33601 33602 33603 33604 33605 33606 33607 33608 33609 33610 33611 33612 33613 33614 33615 33616 33617 33618 33619 33620 33621 33622 33623 33624 33625 33626 33627 33628 33629 33630 33631 33632 33633 33634 33635 33636 33637 33638 33639 33640 33641 33642 33643 33644 33645 33646 33647 33648 33649 33650 33651 33652 33653 33654 33655 33656 33657 33658 33659 33660 33661 33662 33663 33664 33665 33666 33667 33668 33669 33670 33671 33672 33673 33674 33675 33676 33677 33678 33679 33680 33681 33682 33683 33684 33685 33686 33687 33688 33689 33690 33691 33692 33693 33694 33695 33696 33697 33698 33699 33700 33701 33702 33703 33704 33705 33706 33707 33708 33709 33710 33711 33712 33713 33714 33715 33716 33717 33718 33719 33720 33721 33722 33723 33724 33725 33726 33727 33728 33729 33730 33731 33732 33733 33734 33735 33736 33737 33738 33739 33740 33741 33742 33743 33744 33745 33746 33747 33748 33749 33750 33751 33752 33753 33754 33755 33756 33757 33758 33759 33760 33761 33762 33763 33764 33765 33766 33767 33768 33769 33770 33771 33772 33773 33774 33775 33776 33777 33778 33779 33780 33781 33782 33783 33784 33785 33786 33787 33788 33789 33790 33791 33792 33793 33794 33795 33796 33797 33798 33799 33800 33801 33802 33803 33804 33805 33806 33807 33808 33809 33810 33811 33812 33813 33814 33815 33816 33817 33818 33819 33820 33821 33822 33823 33824 33825 33826 33827 33828 33829 33830 33831 33832 33833 33834 33835 33836 33837 33838 33839 33840 33841 33842 33843 33844 33845 33846 33847 33848 33849 33850 33851 33852 33853 33854 33855 33856 33857 33858 33859 33860 33861 33862 33863 33864 33865 33866 33867 33868 33869 33870 33871 33872 33873 33874 33875 33876 33877 33878 33879 33880 33881 33882 33883 33884 33885 33886 33887 33888 33889 33890 33891 33892 33893 33894 33895 33896 33897 33898 33899 33900 33901 33902 33903 33904 33905 33906 33907 33908 33909 33910 33911 33912 33913 33914 33915 33916 33917 33918 33919 33920 33921 33922 33923 33924 33925 33926 33927 33928 33929 33930 33931 33932 33933 33934 33935 33936 33937 33938 33939 33940 33941 33942 33943 33944 33945 33946 33947 33948 33949 33950 33951 33952 33953 33954 33955 33956 33957 33958 33959 33960 33961 33962 33963 33964 33965 33966 33967 33968 33969 33970 33971 33972 33973 33974 33975 33976 33977 33978 33979 33980 33981 33982 33983 33984 33985 33986 33987 33988 33989 33990 33991 33992 33993 33994 33995 33996 33997 33998 33999 34000 34001 34002 34003 34004 34005 34006 34007 34008 34009 34010 34011 34012 34013 34014 34015 34016 34017 34018 34019 34020 34021 34022 34023 34024 34025 34026 34027 34028 34029 34030 34031 34032 34033 34034 34035 34036 34037 34038 34039 34040 34041 34042 34043 34044 34045 34046 34047 34048 34049 34050 34051 34052 34053 34054 34055 34056 34057 34058 34059 34060 34061 34062 34063 34064 34065 34066 34067 34068 34069 34070 34071 34072 34073 34074 34075 34076 34077 34078 34079 34080 34081 34082 34083 34084 34085 34086 34087 34088 34089 34090 34091 34092 34093 34094 34095 34096 34097 34098 34099 34100 34101 34102 34103 34104 34105 34106 34107 34108 34109 34110 34111 34112 34113 34114 34115 34116 34117 34118 34119 34120 34121 34122 34123 34124 34125 34126 34127 34128 34129 34130 34131 34132 34133 34134 34135 34136 34137 34138 34139 34140 34141 34142 34143 34144 34145 34146 34147 34148 34149 34150 34151 34152 34153 34154 34155 34156 34157 34158 34159 34160 34161 34162 34163 34164 34165 34166 34167 34168 34169 34170 34171 34172 34173 34174 34175 34176 34177 34178 34179 34180 34181 34182 34183 34184 34185 34186 34187 34188 34189 34190 34191 34192 34193 34194 34195 34196 34197 34198 34199 34200 34201 34202 34203 34204 34205 34206 34207 34208 34209 34210 34211 34212 34213 34214 34215 34216 34217 34218 34219 34220 34221 34222 34223 34224 34225 34226 34227 34228 34229 34230 34231 34232 34233 34234 34235 34236 34237 34238 34239 34240 34241 34242 34243 34244 34245 34246 34247 34248 34249 34250 34251 34252 34253 34254 34255 34256 34257 34258 34259 34260 34261 34262 34263 34264 34265 34266 34267 34268 34269 34270 34271 34272 34273 34274 34275 34276 34277 34278 34279 34280 34281 34282 34283 34284 34285 34286 34287 34288 34289 34290 34291 34292 34293 34294 34295 34296 34297 34298 34299 34300 34301 34302 34303 34304 34305 34306 34307 34308 34309 34310 34311 34312 34313 34314 34315 34316 34317 34318 34319 34320 34321 34322 34323 34324 34325 34326 34327 34328 34329 34330 34331 34332 34333 34334 34335 34336 34337 34338 34339 34340 34341 34342 34343 34344 34345 34346 34347 34348 34349 34350 34351 34352 34353 34354 34355 34356 34357 34358 34359 34360 34361 34362 34363 34364 34365 34366 34367 34368 34369 34370 34371 34372 34373 34374 34375 34376 34377 34378 34379 34380 34381 34382 34383 34384 34385 34386 34387 34388 34389 34390 34391 34392 34393 34394 34395 34396 34397 34398 34399 34400 34401 34402 34403 34404 34405 34406 34407 34408 34409 34410 34411 34412 34413 34414 34415 34416 34417 34418 34419 34420 34421 34422 34423 34424 34425 34426 34427 34428 34429 34430 34431 34432 34433 34434 34435 34436 34437 34438 34439 34440 34441 34442 34443 34444 34445 34446 34447 34448 34449 34450 34451 34452 34453 34454 34455 34456 34457 34458 34459 34460 34461 34462 34463 34464 34465 34466 34467 34468 34469 34470 34471 34472 34473 34474 34475 34476 34477 34478 34479 34480 34481 34482 34483 34484 34485 34486 34487 34488 34489 34490 34491 34492 34493 34494 34495 34496 34497 34498 34499 34500 34501 34502 34503 34504 34505 34506 34507 34508 34509 34510 34511 34512 34513 34514 34515 34516 34517 34518 34519 34520 34521 34522 34523 34524 34525 34526 34527 34528 34529 34530 34531 34532 34533 34534 34535 34536 34537 34538 34539 34540 34541 34542 34543 34544 34545 34546 34547 34548 34549 34550 34551 34552 34553 34554 34555 34556 34557 34558 34559 34560 34561 34562 34563 34564 34565 34566 34567 34568 34569 34570 34571 34572 34573 34574 34575 34576 34577 34578 34579 34580 34581 34582 34583 34584 34585 34586 34587 34588 34589 34590 34591 34592 34593 34594 34595 34596 34597 34598 34599 34600 34601 34602 34603 34604 34605 34606 34607 34608 34609 34610 34611 34612 34613 34614 34615 34616 34617 34618 34619 34620 34621 34622 34623 34624 34625 34626 34627 34628 34629 34630 34631 34632 34633 34634 34635 34636 34637 34638 34639 34640 34641 34642 34643 34644 34645 34646 34647 34648 34649 34650 34651 34652 34653 34654 34655 34656 34657 34658 34659 34660 34661 34662 34663 34664 34665 34666 34667 34668 34669 34670 34671 34672 34673 34674 34675 34676 34677 34678 34679 34680 34681 34682 34683 34684 34685 34686 34687 34688 34689 34690 34691 34692 34693 34694 34695 34696 34697 34698 34699 34700 34701 34702 34703 34704 34705 34706 34707 34708 34709 34710 34711 34712 34713 34714 34715 34716 34717 34718 34719 34720 34721 34722 34723 34724 34725 34726 34727 34728 34729 34730 34731 34732 34733 34734 34735 34736 34737 34738 34739 34740 34741 34742 34743 34744 34745 34746 34747 34748 34749 34750 34751 34752 34753 34754 34755 34756 34757 34758 34759 34760 34761 34762 34763 34764 34765 34766 34767 34768 34769 34770 34771 34772 34773 34774 34775 34776 34777 34778 34779 34780 34781 34782 34783 34784 34785 34786 34787 34788 34789 34790 34791 34792 34793 34794 34795 34796 34797 34798 34799 34800 34801 34802 34803 34804 34805 34806 34807 34808 34809 34810 34811 34812 34813 34814 34815 34816 34817 34818 34819 34820 34821 34822 34823 34824 34825 34826 34827 34828 34829 34830 34831 34832 34833 34834 34835 34836 34837 34838 34839 34840 34841 34842 34843 34844 34845 34846 34847 34848 34849 34850 34851 34852 34853 34854 34855 34856 34857 34858 34859 34860 34861 34862 34863 34864 34865 34866 34867 34868 34869 34870 34871 34872 34873 34874 34875 34876 34877 34878 34879 34880 34881 34882 34883 34884 34885 34886 34887 34888 34889 34890 34891 34892 34893 34894 34895 34896 34897 34898 34899 34900 34901 34902 34903 34904 34905 34906 34907 34908 34909 34910 34911 34912 34913 34914 34915 34916 34917 34918 34919 34920 34921 34922 34923 34924 34925 34926 34927 34928 34929 34930 34931 34932 34933 34934 34935 34936 34937 34938 34939 34940 34941 34942 34943 34944 34945 34946 34947 34948 34949 34950 34951 34952 34953 34954 34955 34956 34957 34958 34959 34960 34961 34962 34963 34964 34965 34966 34967 34968 34969 34970 34971 34972 34973 34974 34975 34976 34977 34978 34979 34980 34981 34982 34983 34984 34985 34986 34987 34988 34989 34990 34991 34992 34993 34994 34995 34996 34997 34998 34999 35000 35001 35002 35003 35004 35005 35006 35007 35008 35009 35010 35011 35012 35013 35014 35015 35016 35017 35018 35019 35020 35021 35022 35023 35024 35025 35026 35027 35028 35029 35030 35031 35032 35033 35034 35035 35036 35037 35038 35039 35040 35041 35042 35043 35044 35045 35046 35047 35048 35049 35050 35051 35052 35053 35054 35055 35056 35057 35058 35059 35060 35061 35062 35063 35064 35065 35066 35067 35068 35069 35070 35071 35072 35073 35074 35075 35076 35077 35078 35079 35080 35081 35082 35083 35084 35085 35086 35087 35088 35089 35090 35091 35092 35093 35094 35095 35096 35097 35098 35099 35100 35101 35102 35103 35104 35105 35106 35107 35108 35109 35110 35111 35112 35113 35114 35115 35116 35117 35118 35119 35120 35121 35122 35123 35124 35125 35126 35127 35128 35129 35130 35131 35132 35133 35134 35135 35136 35137 35138 35139 35140 35141 35142 35143 35144 35145 35146 35147 35148 35149 35150 35151 35152 35153 35154 35155 35156 35157 35158 35159 35160 35161 35162 35163 35164 35165 35166 35167 35168 35169 35170 35171 35172 35173 35174 35175 35176 35177 35178 35179 35180 35181 35182 35183 35184 35185 35186 35187 35188 35189 35190 35191 35192 35193 35194 35195 35196 35197 35198 35199 35200 35201 35202 35203 35204 35205 35206 35207 35208 35209 35210 35211 35212 35213 35214 35215 35216 35217 35218 35219 35220 35221 35222 35223 35224 35225 35226 35227 35228 35229 35230 35231 35232 35233 35234 35235 35236 35237 35238 35239 35240 35241 35242 35243 35244 35245 35246 35247 35248 35249 35250 35251 35252 35253 35254 35255 35256 35257 35258 35259 35260 35261 35262 35263 35264 35265 35266 35267 35268 35269 35270 35271 35272 35273 35274 35275 35276 35277 35278 35279 35280 35281 35282 35283 35284 35285 35286 35287 35288 35289 35290 35291 35292 35293 35294 35295 35296 35297 35298 35299 35300 35301 35302 35303 35304 35305 35306 35307 35308 35309 35310 35311 35312 35313 35314 35315 35316 35317 35318 35319 35320 35321 35322 35323 35324 35325 35326 35327 35328 35329 35330 35331 35332 35333 35334 35335 35336 35337 35338 35339 35340 35341 35342 35343 35344 35345 35346 35347 35348 35349 35350 35351 35352 35353 35354 35355 35356 35357 35358 35359 35360 35361 35362 35363 35364 35365 35366 35367 35368 35369 35370 35371 35372 35373 35374 35375 35376 35377 35378 35379 35380 35381 35382 35383 35384 35385 35386 35387 35388 35389 35390 35391 35392 35393 35394 35395 35396 35397 35398 35399 35400 35401 35402 35403 35404 35405 35406 35407 35408 35409 35410 35411 35412 35413 35414 35415 35416 35417 35418 35419 35420 35421 35422 35423 35424 35425 35426 35427 35428 35429 35430 35431 35432 35433 35434 35435 35436 35437 35438 35439 35440 35441 35442 35443 35444 35445 35446 35447 35448 35449 35450 35451 35452 35453 35454 35455 35456 35457 35458 35459 35460 35461 35462 35463 35464 35465 35466 35467 35468 35469 35470 35471 35472 35473 35474 35475 35476 35477 35478 35479 35480 35481 35482 35483 35484 35485 35486 35487 35488 35489 35490 35491 35492 35493 35494 35495 35496 35497 35498 35499 35500 35501 35502 35503 35504 35505 35506 35507 35508 35509 35510 35511 35512 35513 35514 35515 35516 35517 35518 35519 35520 35521 35522 35523 35524 35525 35526 35527 35528 35529 35530 35531 35532 35533 35534 35535 35536 35537 35538 35539 35540 35541 35542 35543 35544 35545 35546 35547 35548 35549 35550 35551 35552 35553 35554 35555 35556 35557 35558 35559 35560 35561 35562 35563 35564 35565 35566 35567 35568 35569 35570 35571 35572 35573 35574 35575 35576 35577 35578 35579 35580 35581 35582 35583 35584 35585 35586 35587 35588 35589 35590 35591 35592 35593 35594 35595 35596 35597 35598 35599 35600 35601 35602 35603 35604 35605 35606 35607 35608 35609 35610 35611 35612 35613 35614 35615 35616 35617 35618 35619 35620 35621 35622 35623 35624 35625 35626 35627 35628 35629 35630 35631 35632 35633 35634 35635 35636 35637 35638 35639 35640 35641 35642 35643 35644 35645 35646 35647 35648 35649 35650 35651 35652 35653 35654 35655 35656 35657 35658 35659 35660 35661 35662 35663 35664 35665 35666 35667 35668 35669 35670 35671 35672 35673 35674 35675 35676 35677 35678 35679 35680 35681 35682 35683 35684 35685 35686 35687 35688 35689 35690 35691 35692 35693 35694 35695 35696 35697 35698 35699 35700 35701 35702 35703 35704 35705 35706 35707 35708 35709 35710 35711 35712 35713 35714 35715 35716 35717 35718 35719 35720 35721 35722 35723 35724 35725 35726 35727 35728 35729 35730 35731 35732 35733 35734 35735 35736 35737 35738 35739 35740 35741 35742 35743 35744 35745 35746 35747 35748 35749 35750 35751 35752 35753 35754 35755 35756 35757 35758 35759 35760 35761 35762 35763 35764 35765 35766 35767 35768 35769 35770 35771 35772 35773 35774 35775 35776 35777 35778 35779 35780 35781 35782 35783 35784 35785 35786 35787 35788 35789 35790 35791 35792 35793 35794 35795 35796 35797 35798 35799 35800 35801 35802 35803 35804 35805 35806 35807 35808 35809 35810 35811 35812 35813 35814 35815 35816 35817 35818 35819 35820 35821 35822 35823 35824 35825 35826 35827 35828 35829 35830 35831 35832 35833 35834 35835 35836 35837 35838 35839 35840 35841 35842 35843 35844 35845 35846 35847 35848 35849 35850 35851 35852 35853 35854 35855 35856 35857 35858 35859 35860 35861 35862 35863 35864 35865 35866 35867 35868 35869 35870 35871 35872 35873 35874 35875 35876 35877 35878 35879 35880 35881 35882 35883 35884 35885 35886 35887 35888 35889 35890 35891 35892 35893 35894 35895 35896 35897 35898 35899 35900 35901 35902 35903 35904 35905 35906 35907 35908 35909 35910 35911 35912 35913 35914 35915 35916 35917 35918 35919 35920 35921 35922 35923 35924 35925 35926 35927 35928 35929 35930 35931 35932 35933 35934 35935 35936 35937 35938 35939 35940 35941 35942 35943 35944 35945 35946 35947 35948 35949 35950 35951 35952 35953 35954 35955 35956 35957 35958 35959 35960 35961 35962 35963 35964 35965 35966 35967 35968 35969 35970 35971 35972 35973 35974 35975 35976 35977 35978 35979 35980 35981 35982 35983 35984 35985 35986 35987 35988 35989 35990 35991 35992 35993 35994 35995 35996 35997 35998 35999 36000 36001 36002 36003 36004 36005 36006 36007 36008 36009 36010 36011 36012 36013 36014 36015 36016 36017 36018 36019 36020 36021 36022 36023 36024 36025 36026 36027 36028 36029 36030 36031 36032 36033 36034 36035 36036 36037 36038 36039 36040 36041 36042 36043 36044 36045 36046 36047 36048 36049 36050 36051 36052 36053 36054 36055 36056 36057 36058 36059 36060 36061 36062 36063 36064 36065 36066 36067 36068 36069 36070 36071 36072 36073 36074 36075 36076 36077 36078 36079 36080 36081 36082 36083 36084 36085 36086 36087 36088 36089 36090 36091 36092 36093 36094 36095 36096 36097 36098 36099 36100 36101 36102 36103 36104 36105 36106 36107 36108 36109 36110 36111 36112 36113 36114 36115 36116 36117 36118 36119 36120 36121 36122 36123 36124 36125 36126 36127 36128 36129 36130 36131 36132 36133 36134 36135 36136 36137 36138 36139 36140 36141 36142 36143 36144 36145 36146 36147 36148 36149 36150 36151 36152 36153 36154 36155 36156 36157 36158 36159 36160 36161 36162 36163 36164 36165 36166 36167 36168 36169 36170 36171 36172 36173 36174 36175 36176 36177 36178 36179 36180 36181 36182 36183 36184 36185 36186 36187 36188 36189 36190 36191 36192 36193 36194 36195 36196 36197 36198 36199 36200 36201 36202 36203 36204 36205 36206 36207 36208 36209 36210 36211 36212 36213 36214 36215 36216 36217 36218 36219 36220 36221 36222 36223 36224 36225 36226 36227 36228 36229 36230 36231 36232 36233 36234 36235 36236 36237 36238 36239 36240 36241 36242 36243 36244 36245 36246 36247 36248 36249 36250 36251 36252 36253 36254 36255 36256 36257 36258 36259 36260 36261 36262 36263 36264 36265 36266 36267 36268 36269 36270 36271 36272 36273 36274 36275 36276 36277 36278 36279 36280 36281 36282 36283 36284 36285 36286 36287 36288 36289 36290 36291 36292 36293 36294 36295 36296 36297 36298 36299 36300 36301 36302 36303 36304 36305 36306 36307 36308 36309 36310 36311 36312 36313 36314 36315 36316 36317 36318 36319 36320 36321 36322 36323 36324 36325 36326 36327 36328 36329 36330 36331 36332 36333 36334 36335 36336 36337 36338 36339 36340 36341 36342 36343 36344 36345 36346 36347 36348 36349 36350 36351 36352 36353 36354 36355 36356 36357 36358 36359 36360 36361 36362 36363 36364 36365 36366 36367 36368 36369 36370 36371 36372 36373 36374 36375 36376 36377 36378 36379 36380 36381 36382 36383 36384 36385 36386 36387 36388 36389 36390 36391 36392 36393 36394 36395 36396 36397 36398 36399 36400 36401 36402 36403 36404 36405 36406 36407 36408 36409 36410 36411 36412 36413 36414 36415 36416 36417 36418 36419 36420 36421 36422 36423 36424 36425 36426 36427 36428 36429 36430 36431 36432 36433 36434 36435 36436 36437 36438 36439 36440 36441 36442 36443 36444 36445 36446 36447 36448 36449 36450 36451 36452 36453 36454 36455 36456 36457 36458 36459 36460 36461 36462 36463 36464 36465 36466 36467 36468 36469 36470 36471 36472 36473 36474 36475 36476 36477 36478 36479 36480 36481 36482 36483 36484 36485 36486 36487 36488 36489 36490 36491 36492 36493 36494 36495 36496 36497 36498 36499 36500 36501 36502 36503 36504 36505 36506 36507 36508 36509 36510 36511 36512 36513 36514 36515 36516 36517 36518 36519 36520 36521 36522 36523 36524 36525 36526 36527 36528 36529 36530 36531 36532 36533 36534 36535 36536 36537 36538 36539 36540 36541 36542 36543 36544 36545 36546 36547 36548 36549 36550 36551 36552 36553 36554 36555 36556 36557 36558 36559 36560 36561 36562 36563 36564 36565 36566 36567 36568 36569 36570 36571 36572 36573 36574 36575 36576 36577 36578 36579 36580 36581 36582 36583 36584 36585 36586 36587 36588 36589 36590 36591 36592 36593 36594 36595 36596 36597 36598 36599 36600 36601 36602 36603 36604 36605 36606 36607 36608 36609 36610 36611 36612 36613 36614 36615 36616 36617 36618 36619 36620 36621 36622 36623 36624 36625 36626 36627 36628 36629 36630 36631 36632 36633 36634 36635 36636 36637 36638 36639 36640 36641 36642 36643 36644 36645 36646 36647 36648 36649 36650 36651 36652 36653 36654 36655 36656 36657 36658 36659 36660 36661 36662 36663 36664 36665 36666 36667 36668 36669 36670 36671 36672 36673 36674 36675 36676 36677 36678 36679 36680 36681 36682 36683 36684 36685 36686 36687 36688 36689 36690 36691 36692 36693 36694 36695 36696 36697 36698 36699 36700 36701 36702 36703 36704 36705 36706 36707 36708 36709 36710 36711 36712 36713 36714 36715 36716 36717 36718 36719 36720 36721 36722 36723 36724 36725 36726 36727 36728 36729 36730 36731 36732 36733 36734 36735 36736 36737 36738 36739 36740 36741 36742 36743 36744 36745 36746 36747 36748 36749 36750 36751 36752 36753 36754 36755 36756 36757 36758 36759 36760 36761 36762 36763 36764 36765 36766 36767 36768 36769 36770 36771 36772 36773 36774 36775 36776 36777 36778 36779 36780 36781 36782 36783 36784 36785 36786 36787 36788 36789 36790 36791 36792 36793 36794 36795 36796 36797 36798 36799 36800 36801 36802 36803 36804 36805 36806 36807 36808 36809 36810 36811 36812 36813 36814 36815 36816 36817 36818 36819 36820 36821 36822 36823 36824 36825 36826 36827 36828 36829 36830 36831 36832 36833 36834 36835 36836 36837 36838 36839 36840 36841 36842 36843 36844 36845 36846 36847 36848 36849 36850 36851 36852 36853 36854 36855 36856 36857 36858 36859 36860 36861 36862 36863 36864 36865 36866 36867 36868 36869 36870 36871 36872 36873 36874 36875 36876 36877 36878 36879 36880 36881 36882 36883 36884 36885 36886 36887 36888 36889 36890 36891 36892 36893 36894 36895 36896 36897 36898 36899 36900 36901 36902 36903 36904 36905 36906 36907 36908 36909 36910 36911 36912 36913 36914 36915 36916 36917 36918 36919 36920 36921 36922 36923 36924 36925 36926 36927 36928 36929 36930 36931 36932 36933 36934 36935 36936 36937 36938 36939 36940 36941 36942 36943 36944 36945 36946 36947 36948 36949 36950 36951 36952 36953 36954 36955 36956 36957 36958 36959 36960 36961 36962 36963 36964 36965 36966 36967 36968 36969 36970 36971 36972 36973 36974 36975 36976 36977 36978 36979 36980 36981 36982 36983 36984 36985 36986 36987 36988 36989 36990 36991 36992 36993 36994 36995 36996 36997 36998 36999 37000 37001 37002 37003 37004 37005 37006 37007 37008 37009 37010 37011 37012 37013 37014 37015 37016 37017 37018 37019 37020 37021 37022 37023 37024 37025 37026 37027 37028 37029 37030 37031 37032 37033 37034 37035 37036 37037 37038 37039 37040 37041 37042 37043 37044 37045 37046 37047 37048 37049 37050 37051 37052 37053 37054 37055 37056 37057 37058 37059 37060 37061 37062 37063 37064 37065 37066 37067 37068 37069 37070 37071 37072 37073 37074 37075 37076 37077 37078 37079 37080 37081 37082 37083 37084 37085 37086 37087 37088 37089 37090 37091 37092 37093 37094 37095 37096 37097 37098 37099 37100 37101 37102 37103 37104 37105 37106 37107 37108 37109 37110 37111 37112 37113 37114 37115 37116 37117 37118 37119 37120 37121 37122 37123 37124 37125 37126 37127 37128 37129 37130 37131 37132 37133 37134 37135 37136 37137 37138 37139 37140 37141 37142 37143 37144 37145 37146 37147 37148 37149 37150 37151 37152 37153 37154 37155 37156 37157 37158 37159 37160 37161 37162 37163 37164 37165 37166 37167 37168 37169 37170 37171 37172 37173 37174 37175 37176 37177 37178 37179 37180 37181 37182 37183 37184 37185 37186 37187 37188 37189 37190 37191 37192 37193 37194 37195 37196 37197 37198 37199 37200 37201 37202 37203 37204 37205 37206 37207 37208 37209 37210 37211 37212 37213 37214 37215 37216 37217 37218 37219 37220 37221 37222 37223 37224 37225 37226 37227 37228 37229 37230 37231 37232 37233 37234 37235 37236 37237 37238 37239 37240 37241 37242 37243 37244 37245 37246 37247 37248 37249 37250 37251 37252 37253 37254 37255 37256 37257 37258 37259 37260 37261 37262 37263 37264 37265 37266 37267 37268 37269 37270 37271 37272 37273 37274 37275 37276 37277 37278 37279 37280 37281 37282 37283 37284 37285 37286 37287 37288 37289 37290 37291 37292 37293 37294 37295 37296 37297 37298 37299 37300 37301 37302 37303 37304 37305 37306 37307 37308 37309 37310 37311 37312 37313 37314 37315 37316 37317 37318 37319 37320 37321 37322 37323 37324 37325 37326 37327 37328 37329 37330 37331 37332 37333 37334 37335 37336 37337 37338 37339 37340 37341 37342 37343 37344 37345 37346 37347 37348 37349 37350 37351 37352 37353 37354 37355 37356 37357 37358 37359 37360 37361 37362 37363 37364 37365 37366 37367 37368 37369 37370 37371 37372 37373 37374 37375 37376 37377 37378 37379 37380 37381 37382 37383 37384 37385 37386 37387 37388 37389 37390 37391 37392 37393 37394 37395 37396 37397 37398 37399 37400 37401 37402 37403 37404 37405 37406 37407 37408 37409 37410 37411 37412 37413 37414 37415 37416 37417 37418 37419 37420 37421 37422 37423 37424 37425 37426 37427 37428 37429 37430 37431 37432 37433 37434 37435 37436 37437 37438 37439 37440 37441 37442 37443 37444 37445 37446 37447 37448 37449 37450 37451 37452 37453 37454 37455 37456 37457 37458 37459 37460 37461 37462 37463 37464 37465 37466 37467 37468 37469 37470 37471 37472 37473 37474 37475 37476 37477 37478 37479 37480 37481 37482 37483 37484 37485 37486 37487 37488 37489 37490 37491 37492 37493 37494 37495 37496 37497 37498 37499 37500 37501 37502 37503 37504 37505 37506 37507 37508 37509 37510 37511 37512 37513 37514 37515 37516 37517 37518 37519 37520 37521 37522 37523 37524 37525 37526 37527 37528 37529 37530 37531 37532 37533 37534 37535 37536 37537 37538 37539 37540 37541 37542 37543 37544 37545 37546 37547 37548 37549 37550 37551 37552 37553 37554 37555 37556 37557 37558 37559 37560 37561 37562 37563 37564 37565 37566 37567 37568 37569 37570 37571 37572 37573 37574 37575 37576 37577 37578 37579 37580 37581 37582 37583 37584 37585 37586 37587 37588 37589 37590 37591 37592 37593 37594 37595 37596 37597 37598 37599 37600 37601 37602 37603 37604 37605 37606 37607 37608 37609 37610 37611 37612 37613 37614 37615 37616 37617 37618 37619 37620 37621 37622 37623 37624 37625 37626 37627 37628 37629 37630 37631 37632 37633 37634 37635 37636 37637 37638 37639 37640 37641 37642 37643 37644 37645 37646 37647 37648 37649 37650 37651 37652 37653 37654 37655 37656 37657 37658 37659 37660 37661 37662 37663 37664 37665 37666 37667 37668 37669 37670 37671 37672 37673 37674 37675 37676 37677 37678 37679 37680 37681 37682 37683 37684 37685 37686 37687 37688 37689 37690 37691 37692 37693 37694 37695 37696 37697 37698 37699 37700 37701 37702 37703 37704 37705 37706 37707 37708 37709 37710 37711 37712 37713 37714 37715 37716 37717 37718 37719 37720 37721 37722 37723 37724 37725 37726 37727 37728 37729 37730 37731 37732 37733 37734 37735 37736 37737 37738 37739 37740 37741 37742 37743 37744 37745 37746 37747 37748 37749 37750 37751 37752 37753 37754 37755 37756 37757 37758 37759 37760 37761 37762 37763 37764 37765 37766 37767 37768 37769 37770 37771 37772 37773 37774 37775 37776 37777 37778 37779 37780 37781 37782 37783 37784 37785 37786 37787 37788 37789 37790 37791 37792 37793 37794 37795 37796 37797 37798 37799 37800 37801 37802 37803 37804 37805 37806 37807 37808 37809 37810 37811 37812 37813 37814 37815 37816 37817 37818 37819 37820 37821 37822 37823 37824 37825 37826 37827 37828 37829 37830 37831 37832 37833 37834 37835 37836 37837 37838 37839 37840 37841 37842 37843 37844 37845 37846 37847 37848 37849 37850 37851 37852 37853 37854 37855 37856 37857 37858 37859 37860 37861 37862 37863 37864 37865 37866 37867 37868 37869 37870 37871 37872 37873 37874 37875 37876 37877 37878 37879 37880 37881 37882 37883 37884 37885 37886 37887 37888 37889 37890 37891 37892 37893 37894 37895 37896 37897 37898 37899 37900 37901 37902 37903 37904 37905 37906 37907 37908 37909 37910 37911 37912 37913 37914 37915 37916 37917 37918 37919 37920 37921 37922 37923 37924 37925 37926 37927 37928 37929 37930 37931 37932 37933 37934 37935 37936 37937 37938 37939 37940 37941 37942 37943 37944 37945 37946 37947 37948 37949 37950 37951 37952 37953 37954 37955 37956 37957 37958 37959 37960 37961 37962 37963 37964 37965 37966 37967 37968 37969 37970 37971 37972 37973 37974 37975 37976 37977 37978 37979 37980 37981 37982 37983 37984 37985 37986 37987 37988 37989 37990 37991 37992 37993 37994 37995 37996 37997 37998 37999 38000 38001 38002 38003 38004 38005 38006 38007 38008 38009 38010 38011 38012 38013 38014 38015 38016 38017 38018 38019 38020 38021 38022 38023 38024 38025 38026 38027 38028 38029 38030 38031 38032 38033 38034 38035 38036 38037 38038 38039 38040 38041 38042 38043 38044 38045 38046 38047 38048 38049 38050 38051 38052 38053 38054 38055 38056 38057 38058 38059 38060 38061 38062 38063 38064 38065 38066 38067 38068 38069 38070 38071 38072 38073 38074 38075 38076 38077 38078 38079 38080 38081 38082 38083 38084 38085 38086 38087 38088 38089 38090 38091 38092 38093 38094 38095 38096 38097 38098 38099 38100 38101 38102 38103 38104 38105 38106 38107 38108 38109 38110 38111 38112 38113 38114 38115 38116 38117 38118 38119 38120 38121 38122 38123 38124 38125 38126 38127 38128 38129 38130 38131 38132 38133 38134 38135 38136 38137 38138 38139 38140 38141 38142 38143 38144 38145 38146 38147 38148 38149 38150 38151 38152 38153 38154 38155 38156 38157 38158 38159 38160 38161 38162 38163 38164 38165 38166 38167 38168 38169 38170 38171 38172 38173 38174 38175 38176 38177 38178 38179 38180 38181 38182 38183 38184 38185 38186 38187 38188 38189 38190 38191 38192 38193 38194 38195 38196 38197 38198 38199 38200 38201 38202 38203 38204 38205 38206 38207 38208 38209 38210 38211 38212 38213 38214 38215 38216 38217 38218 38219 38220 38221 38222 38223 38224 38225 38226 38227 38228 38229 38230 38231 38232 38233 38234 38235 38236 38237 38238 38239 38240 38241 38242 38243 38244 38245 38246 38247 38248 38249 38250 38251 38252 38253 38254 38255 38256 38257 38258 38259 38260 38261 38262 38263 38264 38265 38266 38267 38268 38269 38270 38271 38272 38273 38274 38275 38276 38277 38278 38279 38280 38281 38282 38283 38284 38285 38286 38287 38288 38289 38290 38291 38292 38293 38294 38295 38296 38297 38298 38299 38300 38301 38302 38303 38304 38305 38306 38307 38308 38309 38310 38311 38312 38313 38314 38315 38316 38317 38318 38319 38320 38321 38322 38323 38324 38325 38326 38327 38328 38329 38330 38331 38332 38333 38334 38335 38336 38337 38338 38339 38340 38341 38342 38343 38344 38345 38346 38347 38348 38349 38350 38351 38352 38353 38354 38355 38356 38357 38358 38359 38360 38361 38362 38363 38364 38365 38366 38367 38368 38369 38370 38371 38372 38373 38374 38375 38376 38377 38378 38379 38380 38381 38382 38383 38384 38385 38386 38387 38388 38389 38390 38391 38392 38393 38394 38395 38396 38397 38398 38399 38400 38401 38402 38403 38404 38405 38406 38407 38408 38409 38410 38411 38412 38413 38414 38415 38416 38417 38418 38419 38420 38421 38422 38423 38424 38425 38426 38427 38428 38429 38430 38431 38432 38433 38434 38435 38436 38437 38438 38439 38440 38441 38442 38443 38444 38445 38446 38447 38448 38449 38450 38451 38452 38453 38454 38455 38456 38457 38458 38459 38460 38461 38462 38463 38464 38465 38466 38467 38468 38469 38470 38471 38472 38473 38474 38475 38476 38477 38478 38479 38480 38481 38482 38483 38484 38485 38486 38487 38488 38489 38490 38491 38492 38493 38494 38495 38496 38497 38498 38499 38500 38501 38502 38503 38504 38505 38506 38507 38508 38509 38510 38511 38512 38513 38514 38515 38516 38517 38518 38519 38520 38521 38522 38523 38524 38525 38526 38527 38528 38529 38530 38531 38532 38533 38534 38535 38536 38537 38538 38539 38540 38541 38542 38543 38544 38545 38546 38547 38548 38549 38550 38551 38552 38553 38554 38555 38556 38557 38558 38559 38560 38561 38562 38563 38564 38565 38566 38567 38568 38569 38570 38571 38572 38573 38574 38575 38576 38577 38578 38579 38580 38581 38582 38583 38584 38585 38586 38587 38588 38589 38590 38591 38592 38593 38594 38595 38596 38597 38598 38599 38600 38601 38602 38603 38604 38605 38606 38607 38608 38609 38610 38611 38612 38613 38614 38615 38616 38617 38618 38619 38620 38621 38622 38623 38624 38625 38626 38627 38628 38629 38630 38631 38632 38633 38634 38635 38636 38637 38638 38639 38640 38641 38642 38643 38644 38645 38646 38647 38648 38649 38650 38651 38652 38653 38654 38655 38656 38657 38658 38659 38660 38661 38662 38663 38664 38665 38666 38667 38668 38669 38670 38671 38672 38673 38674 38675 38676 38677 38678 38679 38680 38681 38682 38683 38684 38685 38686 38687 38688 38689 38690 38691 38692 38693 38694 38695 38696 38697 38698 38699 38700 38701 38702 38703 38704 38705 38706 38707 38708 38709 38710 38711 38712 38713 38714 38715 38716 38717 38718 38719 38720 38721 38722 38723 38724 38725 38726 38727 38728 38729 38730 38731 38732 38733 38734 38735 38736 38737 38738 38739 38740 38741 38742 38743 38744 38745 38746 38747 38748 38749 38750 38751 38752 38753 38754 38755 38756 38757 38758 38759 38760 38761 38762 38763 38764 38765 38766 38767 38768 38769 38770 38771 38772 38773 38774 38775 38776 38777 38778 38779 38780 38781 38782 38783 38784 38785 38786 38787 38788 38789 38790 38791 38792 38793 38794 38795 38796 38797 38798 38799 38800 38801 38802 38803 38804 38805 38806 38807 38808 38809 38810 38811 38812 38813 38814 38815 38816 38817 38818 38819 38820 38821 38822 38823 38824 38825 38826 38827 38828 38829 38830 38831 38832 38833 38834 38835 38836 38837 38838 38839 38840 38841 38842 38843 38844 38845 38846 38847 38848 38849 38850 38851 38852 38853 38854 38855 38856 38857 38858 38859 38860 38861 38862 38863 38864 38865 38866 38867 38868 38869 38870 38871 38872 38873 38874 38875 38876 38877 38878 38879 38880 38881 38882 38883 38884 38885 38886 38887 38888 38889 38890 38891 38892 38893 38894 38895 38896 38897 38898 38899 38900 38901 38902 38903 38904 38905 38906 38907 38908 38909 38910 38911 38912 38913 38914 38915 38916 38917 38918 38919 38920 38921 38922 38923 38924 38925 38926 38927 38928 38929 38930 38931 38932 38933 38934 38935 38936 38937 38938 38939 38940 38941 38942 38943 38944 38945 38946 38947 38948 38949 38950 38951 38952 38953 38954 38955 38956 38957 38958 38959 38960 38961 38962 38963 38964 38965 38966 38967 38968 38969 38970 38971 38972 38973 38974 38975 38976 38977 38978 38979 38980 38981 38982 38983 38984 38985 38986 38987 38988 38989 38990 38991 38992 38993 38994 38995 38996 38997 38998 38999 39000 39001 39002 39003 39004 39005 39006 39007 39008 39009 39010 39011 39012 39013 39014 39015 39016 39017 39018 39019 39020 39021 39022 39023 39024 39025 39026 39027 39028 39029 39030 39031 39032 39033 39034 39035 39036 39037 39038 39039 39040 39041 39042 39043 39044 39045 39046 39047 39048 39049 39050 39051 39052 39053 39054 39055 39056 39057 39058 39059 39060 39061 39062 39063 39064 39065 39066 39067 39068 39069 39070 39071 39072 39073 39074 39075 39076 39077 39078 39079 39080 39081 39082 39083 39084 39085 39086 39087 39088 39089 39090 39091 39092 39093 39094 39095 39096 39097 39098 39099 39100 39101 39102 39103 39104 39105 39106 39107 39108 39109 39110 39111 39112 39113 39114 39115 39116 39117 39118 39119 39120 39121 39122 39123 39124 39125 39126 39127 39128 39129 39130 39131 39132 39133 39134 39135 39136 39137 39138 39139 39140 39141 39142 39143 39144 39145 39146 39147 39148 39149 39150 39151 39152 39153 39154 39155 39156 39157 39158 39159 39160 39161 39162 39163 39164 39165 39166 39167 39168 39169 39170 39171 39172 39173 39174 39175 39176 39177 39178 39179 39180 39181 39182 39183 39184 39185 39186 39187 39188 39189 39190 39191 39192 39193 39194 39195 39196 39197 39198 39199 39200 39201 39202 39203 39204 39205 39206 39207 39208 39209 39210 39211 39212 39213 39214 39215 39216 39217 39218 39219 39220 39221 39222 39223 39224 39225 39226 39227 39228 39229 39230 39231 39232 39233 39234 39235 39236 39237 39238 39239 39240 39241 39242 39243 39244 39245 39246 39247 39248 39249 39250 39251 39252 39253 39254 39255 39256 39257 39258 39259 39260 39261 39262 39263 39264 39265 39266 39267 39268 39269 39270 39271 39272 39273 39274 39275 39276 39277 39278 39279 39280 39281 39282 39283 39284 39285 39286 39287 39288 39289 39290 39291 39292 39293 39294 39295 39296 39297 39298 39299 39300 39301 39302 39303 39304 39305 39306 39307 39308 39309 39310 39311 39312 39313 39314 39315 39316 39317 39318 39319 39320 39321 39322 39323 39324 39325 39326 39327 39328 39329 39330 39331 39332 39333 39334 39335 39336 39337 39338 39339 39340 39341 39342 39343 39344 39345 39346 39347 39348 39349 39350 39351 39352 39353 39354 39355 39356 39357 39358 39359 39360 39361 39362 39363 39364 39365 39366 39367 39368 39369 39370 39371 39372 39373 39374 39375 39376 39377 39378 39379 39380 39381 39382 39383 39384 39385 39386 39387 39388 39389 39390 39391 39392 39393 39394 39395 39396 39397 39398 39399 39400 39401 39402 39403 39404 39405 39406 39407 39408 39409 39410 39411 39412 39413 39414 39415 39416 39417 39418 39419 39420 39421 39422 39423 39424 39425 39426 39427 39428 39429 39430 39431 39432 39433 39434 39435 39436 39437 39438 39439 39440 39441 39442 39443 39444 39445 39446 39447 39448 39449 39450 39451 39452 39453 39454 39455 39456 39457 39458 39459 39460 39461 39462 39463 39464 39465 39466 39467 39468 39469 39470 39471 39472 39473 39474 39475 39476 39477 39478 39479 39480 39481 39482 39483 39484 39485 39486 39487 39488 39489 39490 39491 39492 39493 39494 39495 39496 39497 39498 39499 39500 39501 39502 39503 39504 39505 39506 39507 39508 39509 39510 39511 39512 39513 39514 39515 39516 39517 39518 39519 39520 39521 39522 39523 39524 39525 39526 39527 39528 39529 39530 39531 39532 39533 39534 39535 39536 39537 39538 39539 39540 39541 39542 39543 39544 39545 39546 39547 39548 39549 39550 39551 39552 39553 39554 39555 39556 39557 39558 39559 39560 39561 39562 39563 39564 39565 39566 39567 39568 39569 39570 39571 39572 39573 39574 39575 39576 39577 39578 39579 39580 39581 39582 39583 39584 39585 39586 39587 39588 39589 39590 39591 39592 39593 39594 39595 39596 39597 39598 39599 39600 39601 39602 39603 39604 39605 39606 39607 39608 39609 39610 39611 39612 39613 39614 39615 39616 39617 39618 39619 39620 39621 39622 39623 39624 39625 39626 39627 39628 39629 39630 39631 39632 39633 39634 39635 39636 39637 39638 39639 39640 39641 39642 39643 39644 39645 39646 39647 39648 39649 39650 39651 39652 39653 39654 39655 39656 39657 39658 39659 39660 39661 39662 39663 39664 39665 39666 39667 39668 39669 39670 39671 39672 39673 39674 39675 39676 39677 39678 39679 39680 39681 39682 39683 39684 39685 39686 39687 39688 39689 39690 39691 39692 39693 39694 39695 39696 39697 39698 39699 39700 39701 39702 39703 39704 39705 39706 39707 39708 39709 39710 39711 39712 39713 39714 39715 39716 39717 39718 39719 39720 39721 39722 39723 39724 39725 39726 39727 39728 39729 39730 39731 39732 39733 39734 39735 39736 39737 39738 39739 39740 39741 39742 39743 39744 39745 39746 39747 39748 39749 39750 39751 39752 39753 39754 39755 39756 39757 39758 39759 39760 39761 39762 39763 39764 39765 39766 39767 39768 39769 39770 39771 39772 39773 39774 39775 39776 39777 39778 39779 39780 39781 39782 39783 39784 39785 39786 39787 39788 39789 39790 39791 39792 39793 39794 39795 39796 39797 39798 39799 39800 39801 39802 39803 39804 39805 39806 39807 39808 39809 39810 39811 39812 39813 39814 39815 39816 39817 39818 39819 39820 39821 39822 39823 39824 39825 39826 39827 39828 39829 39830 39831 39832 39833 39834 39835 39836 39837 39838 39839 39840 39841 39842 39843 39844 39845 39846 39847 39848 39849 39850 39851 39852 39853 39854 39855 39856 39857 39858 39859 39860 39861 39862 39863 39864 39865 39866 39867 39868 39869 39870 39871 39872 39873 39874 39875 39876 39877 39878 39879 39880 39881 39882 39883 39884 39885 39886 39887 39888 39889 39890 39891 39892 39893 39894 39895 39896 39897 39898 39899 39900 39901 39902 39903 39904 39905 39906 39907 39908 39909 39910 39911 39912 39913 39914 39915 39916 39917 39918 39919 39920 39921 39922 39923 39924 39925 39926 39927 39928 39929 39930 39931 39932 39933 39934 39935 39936 39937 39938 39939 39940 39941 39942 39943 39944 39945 39946 39947 39948 39949 39950 39951 39952 39953 39954 39955 39956 39957 39958 39959 39960 39961 39962 39963 39964 39965 39966 39967 39968 39969 39970 39971 39972 39973 39974 39975 39976 39977 39978 39979 39980 39981 39982 39983 39984 39985 39986 39987 39988 39989 39990 39991 39992 39993 39994 39995 39996 39997 39998 39999 40000 40001 40002 40003 40004 40005 40006 40007 40008 40009 40010 40011 40012 40013 40014 40015 40016 40017 40018 40019 40020 40021 40022 40023 40024 40025 40026 40027 40028 40029 40030 40031 40032 40033 40034 40035 40036 40037 40038 40039 40040 40041 40042 40043 40044 40045 40046 40047 40048 40049 40050 40051 40052 40053 40054 40055 40056 40057 40058 40059 40060 40061 40062 40063 40064 40065 40066 40067 40068 40069 40070 40071 40072 40073 40074 40075 40076 40077 40078 40079 40080 40081 40082 40083 40084 40085 40086 40087 40088 40089 40090 40091 40092 40093 40094 40095 40096 40097 40098 40099 40100 40101 40102 40103 40104 40105 40106 40107 40108 40109 40110 40111 40112 40113 40114 40115 40116 40117 40118 40119 40120 40121 40122 40123 40124 40125 40126 40127 40128 40129 40130 40131 40132 40133 40134 40135 40136 40137 40138 40139 40140 40141 40142 40143 40144 40145 40146 40147 40148 40149 40150 40151 40152 40153 40154 40155 40156 40157 40158 40159 40160 40161 40162 40163 40164 40165 40166 40167 40168 40169 40170 40171 40172 40173 40174 40175 40176 40177 40178 40179 40180 40181 40182 40183 40184 40185 40186 40187 40188 40189 40190 40191 40192 40193 40194 40195 40196 40197 40198 40199 40200 40201 40202 40203 40204 40205 40206 40207 40208 40209 40210 40211 40212 40213 40214 40215 40216 40217 40218 40219 40220 40221 40222 40223 40224 40225 40226 40227 40228 40229 40230 40231 40232 40233 40234 40235 40236 40237 40238 40239 40240 40241 40242 40243 40244 40245 40246 40247 40248 40249 40250 40251 40252 40253 40254 40255 40256 40257 40258 40259 40260 40261 40262 40263 40264 40265 40266 40267 40268 40269 40270 40271 40272 40273 40274 40275 40276 40277 40278 40279 40280 40281 40282 40283 40284 40285 40286 40287 40288 40289 40290 40291 40292 40293 40294 40295 40296 40297 40298 40299 40300 40301 40302 40303 40304 40305 40306 40307 40308 40309 40310 40311 40312 40313 40314 40315 40316 40317 40318 40319 40320 40321 40322 40323 40324 40325 40326 40327 40328 40329 40330 40331 40332 40333 40334 40335 40336 40337 40338 40339 40340 40341 40342 40343 40344 40345 40346 40347 40348 40349 40350 40351 40352 40353 40354 40355 40356 40357 40358 40359 40360 40361 40362 40363 40364 40365 40366 40367 40368 40369 40370 40371 40372 40373 40374 40375 40376 40377 40378 40379 40380 40381 40382 40383 40384 40385 40386 40387 40388 40389 40390 40391 40392 40393 40394 40395 40396 40397 40398 40399 40400 40401 40402 40403 40404 40405 40406 40407 40408 40409 40410 40411 40412 40413 40414 40415 40416 40417 40418 40419 40420 40421 40422 40423 40424 40425 40426 40427 40428 40429 40430 40431 40432 40433 40434 40435 40436 40437 40438 40439 40440 40441 40442 40443 40444 40445 40446 40447 40448 40449 40450 40451 40452 40453 40454 40455 40456 40457 40458 40459 40460 40461 40462 40463 40464 40465 40466 40467 40468 40469 40470 40471 40472 40473 40474 40475 40476 40477 40478 40479 40480 40481 40482 40483 40484 40485 40486 40487 40488 40489 40490 40491 40492 40493 40494 40495 40496 40497 40498 40499 40500 40501 40502 40503 40504 40505 40506 40507 40508 40509 40510 40511 40512 40513 40514 40515 40516 40517 40518 40519 40520 40521 40522 40523 40524 40525 40526 40527 40528 40529 40530 40531 40532 40533 40534 40535 40536 40537 40538 40539 40540 40541 40542 40543 40544 40545 40546 40547 40548 40549 40550 40551 40552 40553 40554 40555 40556 40557 40558 40559 40560 40561 40562 40563 40564 40565 40566 40567 40568 40569 40570 40571 40572 40573 40574 40575 40576 40577 40578 40579 40580 40581 40582 40583 40584 40585 40586 40587 40588 40589 40590 40591 40592 40593 40594 40595 40596 40597 40598 40599 40600 40601 40602 40603 40604 40605 40606 40607 40608 40609 40610 40611 40612 40613 40614 40615 40616 40617 40618 40619 40620 40621 40622 40623 40624 40625 40626 40627 40628 40629 40630 40631 40632 40633 40634 40635 40636 40637 40638 40639 40640 40641 40642 40643 40644 40645 40646 40647 40648 40649 40650 40651 40652 40653 40654 40655 40656 40657 40658 40659 40660 40661 40662 40663 40664 40665 40666 40667 40668 40669 40670 40671 40672 40673 40674 40675 40676 40677 40678 40679 40680 40681 40682 40683 40684 40685 40686 40687 40688 40689 40690 40691 40692 40693 40694 40695 40696 40697 40698 40699 40700 40701 40702 40703 40704 40705 40706 40707 40708 40709 40710 40711 40712 40713 40714 40715 40716 40717 40718 40719 40720 40721 40722 40723 40724 40725 40726 40727 40728 40729 40730 40731 40732 40733 40734 40735 40736 40737 40738 40739 40740 40741 40742 40743 40744 40745 40746 40747 40748 40749 40750 40751 40752 40753 40754 40755 40756 40757 40758 40759 40760 40761 40762 40763 40764 40765 40766 40767 40768 40769 40770 40771 40772 40773 40774 40775 40776 40777 40778 40779 40780 40781 40782 40783 40784 40785 40786 40787 40788 40789 40790 40791 40792 40793 40794 40795 40796 40797 40798 40799 40800 40801 40802 40803 40804 40805 40806 40807 40808 40809 40810 40811 40812 40813 40814 40815 40816 40817 40818 40819 40820 40821 40822 40823 40824 40825 40826 40827 40828 40829 40830 40831 40832 40833 40834 40835 40836 40837 40838 40839 40840 40841 40842 40843 40844 40845 40846 40847 40848 40849 40850 40851 40852 40853 40854 40855 40856 40857 40858 40859 40860 40861 40862 40863 40864 40865 40866 40867 40868 40869 40870 40871 40872 40873 40874 40875 40876 40877 40878 40879 40880 40881 40882 40883 40884 40885 40886 40887 40888 40889 40890 40891 40892 40893 40894 40895 40896 40897 40898 40899 40900 40901 40902 40903 40904 40905 40906 40907 40908 40909 40910 40911 40912 40913 40914 40915 40916 40917 40918 40919 40920 40921 40922 40923 40924 40925 40926 40927 40928 40929 40930 40931 40932 40933 40934 40935 40936 40937 40938 40939 40940 40941 40942 40943 40944 40945 40946 40947 40948 40949 40950 40951 40952 40953 40954 40955 40956 40957 40958 40959 40960 40961 40962 40963 40964 40965 40966 40967 40968 40969 40970 40971 40972 40973 40974 40975 40976 40977 40978 40979 40980 40981 40982 40983 40984 40985 40986 40987 40988 40989 40990 40991 40992 40993 40994 40995 40996 40997 40998 40999 41000 41001 41002 41003 41004 41005 41006 41007 41008 41009 41010 41011 41012 41013 41014 41015 41016 41017 41018 41019 41020 41021 41022 41023 41024 41025 41026 41027 41028 41029 41030 41031 41032 41033 41034 41035 41036 41037 41038 41039 41040 41041 41042 41043 41044 41045 41046 41047 41048 41049 41050 41051 41052 41053 41054 41055 41056 41057 41058 41059 41060 41061 41062 41063 41064 41065 41066 41067 41068 41069 41070 41071 41072 41073 41074 41075 41076 41077 41078 41079 41080 41081 41082 41083 41084 41085 41086 41087 41088 41089 41090 41091 41092 41093 41094 41095 41096 41097 41098 41099 41100 41101 41102 41103 41104 41105 41106 41107 41108 41109 41110 41111 41112 41113 41114 41115 41116 41117 41118 41119 41120 41121 41122 41123 41124 41125 41126 41127 41128 41129 41130 41131 41132 41133 41134 41135 41136 41137 41138 41139 41140 41141 41142 41143 41144 41145 41146 41147 41148 41149 41150 41151 41152 41153 41154 41155 41156 41157 41158 41159 41160 41161 41162 41163 41164 41165 41166 41167 41168 41169 41170 41171 41172 41173 41174 41175 41176 41177 41178 41179 41180 41181 41182 41183 41184 41185 41186 41187 41188 41189 41190 41191 41192 41193 41194 41195 41196 41197 41198 41199 41200 41201 41202 41203 41204 41205 41206 41207 41208 41209 41210 41211 41212 41213 41214 41215 41216 41217 41218 41219 41220 41221 41222 41223 41224 41225 41226 41227 41228 41229 41230 41231 41232 41233 41234 41235 41236 41237 41238 41239 41240 41241 41242 41243 41244 41245 41246 41247 41248 41249 41250 41251 41252 41253 41254 41255 41256 41257 41258 41259 41260 41261 41262 41263 41264 41265 41266 41267 41268 41269 41270 41271 41272 41273 41274 41275 41276 41277 41278 41279 41280 41281 41282 41283 41284 41285 41286 41287 41288 41289 41290 41291 41292 41293 41294 41295 41296 41297 41298 41299 41300 41301 41302 41303 41304 41305 41306 41307 41308 41309 41310 41311 41312 41313 41314 41315 41316 41317 41318 41319 41320 41321 41322 41323 41324 41325 41326 41327 41328 41329 41330 41331 41332 41333 41334 41335 41336 41337 41338 41339 41340 41341 41342 41343 41344 41345 41346 41347 41348 41349 41350 41351 41352 41353 41354 41355 41356 41357 41358 41359 41360 41361 41362 41363 41364 41365 41366 41367 41368 41369 41370 41371 41372 41373 41374 41375 41376 41377 41378 41379 41380 41381 41382 41383 41384 41385 41386 41387 41388 41389 41390 41391 41392 41393 41394 41395 41396 41397 41398 41399 41400 41401 41402 41403 41404 41405 41406 41407 41408 41409 41410 41411 41412 41413 41414 41415 41416 41417 41418 41419 41420 41421 41422 41423 41424 41425 41426 41427 41428 41429 41430 41431 41432 41433 41434 41435 41436 41437 41438 41439 41440 41441 41442 41443 41444 41445 41446 41447 41448 41449 41450 41451 41452 41453 41454 41455 41456 41457 41458 41459 41460 41461 41462 41463 41464 41465 41466 41467 41468 41469 41470 41471 41472 41473 41474 41475 41476 41477 41478 41479 41480 41481 41482 41483 41484 41485 41486 41487 41488 41489 41490 41491 41492 41493 41494 41495 41496 41497 41498 41499 41500 41501 41502 41503 41504 41505 41506 41507 41508 41509 41510 41511 41512 41513 41514 41515 41516 41517 41518 41519 41520 41521 41522 41523 41524 41525 41526 41527 41528 41529 41530 41531 41532 41533 41534 41535 41536 41537 41538 41539 41540 41541 41542 41543 41544 41545 41546 41547 41548 41549 41550 41551 41552 41553 41554 41555 41556 41557 41558 41559 41560 41561 41562 41563 41564 41565 41566 41567 41568 41569 41570 41571 41572 41573 41574 41575 41576 41577 41578 41579 41580 41581 41582 41583 41584 41585 41586 41587 41588 41589 41590 41591 41592 41593 41594 41595 41596 41597 41598 41599 41600 41601 41602 41603 41604 41605 41606 41607 41608 41609 41610 41611 41612 41613 41614 41615 41616 41617 41618 41619 41620 41621 41622 41623 41624 41625 41626 41627 41628 41629 41630 41631 41632 41633 41634 41635 41636 41637 41638 41639 41640 41641 41642 41643 41644 41645 41646 41647 41648 41649 41650 41651 41652 41653 41654 41655 41656 41657 41658 41659 41660 41661 41662 41663 41664 41665 41666 41667 41668 41669 41670 41671 41672 41673 41674 41675 41676 41677 41678 41679 41680 41681 41682 41683 41684 41685 41686 41687 41688 41689 41690 41691 41692 41693 41694 41695 41696 41697 41698 41699 41700 41701 41702 41703 41704 41705 41706 41707 41708 41709 41710 41711 41712 41713 41714 41715 41716 41717 41718 41719 41720 41721 41722 41723 41724 41725 41726 41727 41728 41729 41730 41731 41732 41733 41734 41735 41736 41737 41738 41739 41740 41741 41742 41743 41744 41745 41746 41747 41748 41749 41750 41751 41752 41753 41754 41755 41756 41757 41758 41759 41760 41761 41762 41763 41764 41765 41766 41767 41768 41769 41770 41771 41772 41773 41774 41775 41776 41777 41778 41779 41780 41781 41782 41783 41784 41785 41786 41787 41788 41789 41790 41791 41792 41793 41794 41795 41796 41797 41798 41799 41800 41801 41802 41803 41804 41805 41806 41807 41808 41809 41810 41811 41812 41813 41814 41815 41816 41817 41818 41819 41820 41821 41822 41823 41824 41825 41826 41827 41828 41829 41830 41831 41832 41833 41834 41835 41836 41837 41838 41839 41840 41841 41842 41843 41844 41845 41846 41847 41848 41849 41850 41851 41852 41853 41854 41855 41856 41857 41858 41859 41860 41861 41862 41863 41864 41865 41866 41867 41868 41869 41870 41871 41872 41873 41874 41875 41876 41877 41878 41879 41880 41881 41882 41883 41884 41885 41886 41887 41888 41889 41890 41891 41892 41893 41894 41895 41896 41897 41898 41899 41900 41901 41902 41903 41904 41905 41906 41907 41908 41909 41910 41911 41912 41913 41914 41915 41916 41917 41918 41919 41920 41921 41922 41923 41924 41925 41926 41927 41928 41929 41930 41931 41932 41933 41934 41935 41936 41937 41938 41939 41940 41941 41942 41943 41944 41945 41946 41947 41948 41949 41950 41951 41952 41953 41954 41955 41956 41957 41958 41959 41960 41961 41962 41963 41964 41965 41966 41967 41968 41969 41970 41971 41972 41973 41974 41975 41976 41977 41978 41979 41980 41981 41982 41983 41984 41985 41986 41987 41988 41989 41990 41991 41992 41993 41994 41995 41996 41997 41998 41999 42000 42001 42002 42003 42004 42005 42006 42007 42008 42009 42010 42011 42012 42013 42014 42015 42016 42017 42018 42019 42020 42021 42022 42023 42024 42025 42026 42027 42028 42029 42030 42031 42032 42033 42034 42035 42036 42037 42038 42039 42040 42041 42042 42043 42044 42045 42046 42047 42048 42049 42050 42051 42052 42053 42054 42055 42056 42057 42058 42059 42060 42061 42062 42063 42064 42065 42066 42067 42068 42069 42070 42071 42072 42073 42074 42075 42076 42077 42078 42079 42080 42081 42082 42083 42084 42085 42086 42087 42088 42089 42090 42091 42092 42093 42094 42095 42096 42097 42098 42099 42100 42101 42102 42103 42104 42105 42106 42107 42108 42109 42110 42111 42112 42113 42114 42115 42116 42117 42118 42119 42120 42121 42122 42123 42124 42125 42126 42127 42128 42129 42130 42131 42132 42133 42134 42135 42136 42137 42138 42139 42140 42141 42142 42143 42144 42145 42146 42147 42148 42149 42150 42151 42152 42153 42154 42155 42156 42157 42158 42159 42160 42161 42162 42163 42164 42165 42166 42167 42168 42169 42170 42171 42172 42173 42174 42175 42176 42177 42178 42179 42180 42181 42182 42183 42184 42185 42186 42187 42188 42189 42190 42191 42192 42193 42194 42195 42196 42197 42198 42199 42200 42201 42202 42203 42204 42205 42206 42207 42208 42209 42210 42211 42212 42213 42214 42215 42216 42217 42218 42219 42220 42221 42222 42223 42224 42225 42226 42227 42228 42229 42230 42231 42232 42233 42234 42235 42236 42237 42238 42239 42240 42241 42242 42243 42244 42245 42246 42247 42248 42249 42250 42251 42252 42253 42254 42255 42256 42257 42258 42259 42260 42261 42262 42263 42264 42265 42266 42267 42268 42269 42270 42271 42272 42273 42274 42275 42276 42277 42278 42279 42280 42281 42282 42283 42284 42285 42286 42287 42288 42289 42290 42291 42292 42293 42294 42295 42296 42297 42298 42299 42300 42301 42302 42303 42304 42305 42306 42307 42308 42309 42310 42311 42312 42313 42314 42315 42316 42317 42318 42319 42320 42321 42322 42323 42324 42325 42326 42327 42328 42329 42330 42331 42332 42333 42334 42335 42336 42337 42338 42339 42340 42341 42342 42343 42344 42345 42346 42347 42348 42349 42350 42351 42352 42353 42354 42355 42356 42357 42358 42359 42360 42361 42362 42363 42364 42365 42366 42367 42368 42369 42370 42371 42372 42373 42374 42375 42376 42377 42378 42379 42380 42381 42382 42383 42384 42385 42386 42387 42388 42389 42390 42391 42392 42393 42394 42395 42396 42397 42398 42399 42400 42401 42402 42403 42404 42405 42406 42407 42408 42409 42410 42411 42412 42413 42414 42415 42416 42417 42418 42419 42420 42421 42422 42423 42424 42425 42426 42427 42428 42429 42430 42431 42432 42433 42434 42435 42436 42437 42438 42439 42440 42441 42442 42443 42444 42445 42446 42447 42448 42449 42450 42451 42452 42453 42454 42455 42456 42457 42458 42459 42460 42461 42462 42463 42464 42465 42466 42467 42468 42469 42470 42471 42472 42473 42474 42475 42476 42477 42478 42479 42480 42481 42482 42483 42484 42485 42486 42487 42488 42489 42490 42491 42492 42493 42494 42495 42496 42497 42498 42499 42500 42501 42502 42503 42504 42505 42506 42507 42508 42509 42510 42511 42512 42513 42514 42515 42516 42517 42518 42519 42520 42521 42522 42523 42524 42525 42526 42527 42528 42529 42530 42531 42532 42533 42534 42535 42536 42537 42538 42539 42540 42541 42542 42543 42544 42545 42546 42547 42548 42549 42550 42551 42552 42553 42554 42555 42556 42557 42558 42559 42560 42561 42562 42563 42564 42565 42566 42567 42568 42569 42570 42571 42572 42573 42574 42575 42576 42577 42578 42579 42580 42581 42582 42583 42584 42585 42586 42587 42588 42589 42590 42591 42592 42593 42594 42595 42596 42597 42598 42599 42600 42601 42602 42603 42604 42605 42606 42607 42608 42609 42610 42611 42612 42613 42614 42615 42616 42617 42618 42619 42620 42621 42622 42623 42624 42625 42626 42627 42628 42629 42630 42631 42632 42633 42634 42635 42636 42637 42638 42639 42640 42641 42642 42643 42644 42645 42646 42647 42648 42649 42650 42651 42652 42653 42654 42655 42656 42657 42658 42659 42660 42661 42662 42663 42664 42665 42666 42667 42668 42669 42670 42671 42672 42673 42674 42675 42676 42677 42678 42679 42680 42681 42682 42683 42684 42685 42686 42687 42688 42689 42690 42691 42692 42693 42694 42695 42696 42697 42698 42699 42700 42701 42702 42703 42704 42705 42706 42707 42708 42709 42710 42711 42712 42713 42714 42715 42716 42717 42718 42719 42720 42721 42722 42723 42724 42725 42726 42727 42728 42729 42730 42731 42732 42733 42734 42735 42736 42737 42738 42739 42740 42741 42742 42743 42744 42745 42746 42747 42748 42749 42750 42751 42752 42753 42754 42755 42756 42757 42758 42759 42760 42761 42762 42763 42764 42765 42766 42767 42768 42769 42770 42771 42772 42773 42774 42775 42776 42777 42778 42779 42780 42781 42782 42783 42784 42785 42786 42787 42788 42789 42790 42791 42792 42793 42794 42795 42796 42797 42798 42799 42800 42801 42802 42803 42804 42805 42806 42807 42808 42809 42810 42811 42812 42813 42814 42815 42816 42817 42818 42819 42820 42821 42822 42823 42824 42825 42826 42827 42828 42829 42830 42831 42832 42833 42834 42835 42836 42837 42838 42839 42840 42841 42842 42843 42844 42845 42846 42847 42848 42849 42850 42851 42852 42853 42854 42855 42856 42857 42858 42859 42860 42861 42862 42863 42864 42865 42866 42867 42868 42869 42870 42871 42872 42873 42874 42875 42876 42877 42878 42879 42880 42881 42882 42883 42884 42885 42886 42887 42888 42889 42890 42891 42892 42893 42894 42895 42896 42897 42898 42899 42900 42901 42902 42903 42904 42905 42906 42907 42908 42909 42910 42911 42912 42913 42914 42915 42916 42917 42918 42919 42920 42921 42922 42923 42924 42925 42926 42927 42928 42929 42930 42931 42932 42933 42934 42935 42936 42937 42938 42939 42940 42941 42942 42943 42944 42945 42946 42947 42948 42949 42950 42951 42952 42953 42954 42955 42956 42957 42958 42959 42960 42961 42962 42963 42964 42965 42966 42967 42968 42969 42970 42971 42972 42973 42974 42975 42976 42977 42978 42979 42980 42981 42982 42983 42984 42985 42986 42987 42988 42989 42990 42991 42992 42993 42994 42995 42996 42997 42998 42999 43000 43001 43002 43003 43004 43005 43006 43007 43008 43009 43010 43011 43012 43013 43014 43015 43016 43017 43018 43019 43020 43021 43022 43023 43024 43025 43026 43027 43028 43029 43030 43031 43032 43033 43034 43035 43036 43037 43038 43039 43040 43041 43042 43043 43044 43045 43046 43047 43048 43049 43050 43051 43052 43053 43054 43055 43056 43057 43058 43059 43060 43061 43062 43063 43064 43065 43066 43067 43068 43069 43070 43071 43072 43073 43074 43075 43076 43077 43078 43079 43080 43081 43082 43083 43084 43085 43086 43087 43088 43089 43090 43091 43092 43093 43094 43095 43096 43097 43098 43099 43100 43101 43102 43103 43104 43105 43106 43107 43108 43109 43110 43111 43112 43113 43114 43115 43116 43117 43118 43119 43120 43121 43122 43123 43124 43125 43126 43127 43128 43129 43130 43131 43132 43133 43134 43135 43136 43137 43138 43139 43140 43141 43142 43143 43144 43145 43146 43147 43148 43149 43150 43151 43152 43153 43154 43155 43156 43157 43158 43159 43160 43161 43162 43163 43164 43165 43166 43167 43168 43169 43170 43171 43172 43173 43174 43175 43176 43177 43178 43179 43180 43181 43182 43183 43184 43185 43186 43187 43188 43189 43190 43191 43192 43193 43194 43195 43196 43197 43198 43199 43200 43201 43202 43203 43204 43205 43206 43207 43208 43209 43210 43211 43212 43213 43214 43215 43216 43217 43218 43219 43220 43221 43222 43223 43224 43225 43226 43227 43228 43229 43230 43231 43232 43233 43234 43235 43236 43237 43238 43239 43240 43241 43242 43243 43244 43245 43246 43247 43248 43249 43250 43251 43252 43253 43254 43255 43256 43257 43258 43259 43260 43261 43262 43263 43264 43265 43266 43267 43268 43269 43270 43271 43272 43273 43274 43275 43276 43277 43278 43279 43280 43281 43282 43283 43284 43285 43286 43287 43288 43289 43290 43291 43292 43293 43294 43295 43296 43297 43298 43299 43300 43301 43302 43303 43304 43305 43306 43307 43308 43309 43310 43311 43312 43313 43314 43315 43316 43317 43318 43319 43320 43321 43322 43323 43324 43325 43326 43327 43328 43329 43330 43331 43332 43333 43334 43335 43336 43337 43338 43339 43340 43341 43342 43343 43344 43345 43346 43347 43348 43349 43350 43351 43352 43353 43354 43355 43356 43357 43358 43359 43360 43361 43362 43363 43364 43365 43366 43367 43368 43369 43370 43371 43372 43373 43374 43375 43376 43377 43378 43379 43380 43381 43382 43383 43384 43385 43386 43387 43388 43389 43390 43391 43392 43393 43394 43395 43396 43397 43398 43399 43400 43401 43402 43403 43404 43405 43406 43407 43408 43409 43410 43411 43412 43413 43414 43415 43416 43417 43418 43419 43420 43421 43422 43423 43424 43425 43426 43427 43428 43429 43430 43431 43432 43433 43434 43435 43436 43437 43438 43439 43440 43441 43442 43443 43444 43445 43446 43447 43448 43449 43450 43451 43452 43453 43454 43455 43456 43457 43458 43459 43460 43461 43462 43463 43464 43465 43466 43467 43468 43469 43470 43471 43472 43473 43474 43475 43476 43477 43478 43479 43480 43481 43482 43483 43484 43485 43486 43487 43488 43489 43490 43491 43492 43493 43494 43495 43496 43497 43498 43499 43500 43501 43502 43503 43504 43505 43506 43507 43508 43509 43510 43511 43512 43513 43514 43515 43516 43517 43518 43519 43520 43521 43522 43523 43524 43525 43526 43527 43528 43529 43530 43531 43532 43533 43534 43535 43536 43537 43538 43539 43540 43541 43542 43543 43544 43545 43546 43547 43548 43549 43550 43551 43552 43553 43554 43555 43556 43557 43558 43559 43560 43561 43562 43563 43564 43565 43566 43567 43568 43569 43570 43571 43572 43573 43574 43575 43576 43577 43578 43579 43580 43581 43582 43583 43584 43585 43586 43587 43588 43589 43590 43591 43592 43593 43594 43595 43596 43597 43598 43599 43600 43601 43602 43603 43604 43605 43606 43607 43608 43609 43610 43611 43612 43613 43614 43615 43616 43617 43618 43619 43620 43621 43622 43623 43624 43625 43626 43627 43628 43629 43630 43631 43632 43633 43634 43635 43636 43637 43638 43639 43640 43641 43642 43643 43644 43645 43646 43647 43648 43649 43650 43651 43652 43653 43654 43655 43656 43657 43658 43659 43660 43661 43662 43663 43664 43665 43666 43667 43668 43669 43670 43671 43672 43673 43674 43675 43676 43677 43678 43679 43680 43681 43682 43683 43684 43685 43686 43687 43688 43689 43690 43691 43692 43693 43694 43695 43696 43697 43698 43699 43700 43701 43702 43703 43704 43705 43706 43707 43708 43709 43710 43711 43712 43713 43714 43715 43716 43717 43718 43719 43720 43721 43722 43723 43724 43725 43726 43727 43728 43729 43730 43731 43732 43733 43734 43735 43736 43737 43738 43739 43740 43741 43742 43743 43744 43745 43746 43747 43748 43749 43750 43751 43752 43753 43754 43755 43756 43757 43758 43759 43760 43761 43762 43763 43764 43765 43766 43767 43768 43769 43770 43771 43772 43773 43774 43775 43776 43777 43778 43779 43780 43781 43782 43783 43784 43785 43786 43787 43788 43789 43790 43791 43792 43793 43794 43795 43796 43797 43798 43799 43800 43801 43802 43803 43804 43805 43806 43807 43808 43809 43810 43811 43812 43813 43814 43815 43816 43817 43818 43819 43820 43821 43822 43823 43824 43825 43826 43827 43828 43829 43830 43831 43832 43833 43834 43835 43836 43837 43838 43839 43840 43841 43842 43843 43844 43845 43846 43847 43848 43849 43850 43851 43852 43853 43854 43855 43856 43857 43858 43859 43860 43861 43862 43863 43864 43865 43866 43867 43868 43869 43870 43871 43872 43873 43874 43875 43876 43877 43878 43879 43880 43881 43882 43883 43884 43885 43886 43887 43888 43889 43890 43891 43892 43893 43894 43895 43896 43897 43898 43899 43900 43901 43902 43903 43904 43905 43906 43907 43908 43909 43910 43911 43912 43913 43914 43915 43916 43917 43918 43919 43920 43921 43922 43923 43924 43925 43926 43927 43928 43929 43930 43931 43932 43933 43934 43935 43936 43937 43938 43939 43940 43941 43942 43943 43944 43945 43946 43947 43948 43949 43950 43951 43952 43953 43954 43955 43956 43957 43958 43959 43960 43961 43962 43963 43964 43965 43966 43967 43968 43969 43970 43971 43972 43973 43974 43975 43976 43977 43978 43979 43980 43981 43982 43983 43984 43985 43986 43987 43988 43989 43990 43991 43992 43993 43994 43995 43996 43997 43998 43999 44000 44001 44002 44003 44004 44005 44006 44007 44008 44009 44010 44011 44012 44013 44014 44015 44016 44017 44018 44019 44020 44021 44022 44023 44024 44025 44026 44027 44028 44029 44030 44031 44032 44033 44034 44035 44036 44037 44038 44039 44040 44041 44042 44043 44044 44045 44046 44047 44048 44049 44050 44051 44052 44053 44054 44055 44056 44057 44058 44059 44060 44061 44062 44063 44064 44065 44066 44067 44068 44069 44070 44071 44072 44073 44074 44075 44076 44077 44078 44079 44080 44081 44082 44083 44084 44085 44086 44087 44088 44089 44090 44091 44092 44093 44094 44095 44096 44097 44098 44099 44100 44101 44102 44103 44104 44105 44106 44107 44108 44109 44110 44111 44112 44113 44114 44115 44116 44117 44118 44119 44120 44121 44122 44123 44124 44125 44126 44127 44128 44129 44130 44131 44132 44133 44134 44135 44136 44137 44138 44139 44140 44141 44142 44143 44144 44145 44146 44147 44148 44149 44150 44151 44152 44153 44154 44155 44156 44157 44158 44159 44160 44161 44162 44163 44164 44165 44166 44167 44168 44169 44170 44171 44172 44173 44174 44175 44176 44177 44178 44179 44180 44181 44182 44183 44184 44185 44186 44187 44188 44189 44190 44191 44192 44193 44194 44195 44196 44197 44198 44199 44200 44201 44202 44203 44204 44205 44206 44207 44208 44209 44210 44211 44212 44213 44214 44215 44216 44217 44218 44219 44220 44221 44222 44223 44224 44225 44226 44227 44228 44229 44230 44231 44232 44233 44234 44235 44236 44237 44238 44239 44240 44241 44242 44243 44244 44245 44246 44247 44248 44249 44250 44251 44252 44253 44254 44255 44256 44257 44258 44259 44260 44261 44262 44263 44264 44265 44266 44267 44268 44269 44270 44271 44272 44273 44274 44275 44276 44277 44278 44279 44280 44281 44282 44283 44284 44285 44286 44287 44288 44289 44290 44291 44292 44293 44294 44295 44296 44297 44298 44299 44300 44301 44302 44303 44304 44305 44306 44307 44308 44309 44310 44311 44312 44313 44314 44315 44316 44317 44318 44319 44320 44321 44322 44323 44324 44325 44326 44327 44328 44329 44330 44331 44332 44333 44334 44335 44336 44337 44338 44339 44340 44341 44342 44343 44344 44345 44346 44347 44348 44349 44350 44351 44352 44353 44354 44355 44356 44357 44358 44359 44360 44361 44362 44363 44364 44365 44366 44367 44368 44369 44370 44371 44372 44373 44374 44375 44376 44377 44378 44379 44380 44381 44382 44383 44384 44385 44386 44387 44388 44389 44390 44391 44392 44393 44394 44395 44396 44397 44398 44399 44400 44401 44402 44403 44404 44405 44406 44407 44408 44409 44410 44411 44412 44413 44414 44415 44416 44417 44418 44419 44420 44421 44422 44423 44424 44425 44426 44427 44428 44429 44430 44431 44432 44433 44434 44435 44436 44437 44438 44439 44440 44441 44442 44443 44444 44445 44446 44447 44448 44449 44450 44451 44452 44453 44454 44455 44456 44457 44458 44459 44460 44461 44462 44463 44464 44465 44466 44467 44468 44469 44470 44471 44472 44473 44474 44475 44476 44477 44478 44479 44480 44481 44482 44483 44484 44485 44486 44487 44488 44489 44490 44491 44492 44493 44494 44495 44496 44497 44498 44499 44500 44501 44502 44503 44504 44505 44506 44507 44508 44509 44510 44511 44512 44513 44514 44515 44516 44517 44518 44519 44520 44521 44522 44523 44524 44525 44526 44527 44528 44529 44530 44531 44532 44533 44534 44535 44536 44537 44538 44539 44540 44541 44542 44543 44544 44545 44546 44547 44548 44549 44550 44551 44552 44553 44554 44555 44556 44557 44558 44559 44560 44561 44562 44563 44564 44565 44566 44567 44568 44569 44570 44571 44572 44573 44574 44575 44576 44577 44578 44579 44580 44581 44582 44583 44584 44585 44586 44587 44588 44589 44590 44591 44592 44593 44594 44595 44596 44597 44598 44599 44600 44601 44602 44603 44604 44605 44606 44607 44608 44609 44610 44611 44612 44613 44614 44615 44616 44617 44618 44619 44620 44621 44622 44623 44624 44625 44626 44627 44628 44629 44630 44631 44632 44633 44634 44635 44636 44637 44638 44639 44640 44641 44642 44643 44644 44645 44646 44647 44648 44649 44650 44651 44652 44653 44654 44655 44656 44657 44658 44659 44660 44661 44662 44663 44664 44665 44666 44667 44668 44669 44670 44671 44672 44673 44674 44675 44676 44677 44678 44679 44680 44681 44682 44683 44684 44685 44686 44687 44688 44689 44690 44691 44692 44693 44694 44695 44696 44697 44698 44699 44700 44701 44702 44703 44704 44705 44706 44707 44708 44709 44710 44711 44712 44713 44714 44715 44716 44717 44718 44719 44720 44721 44722 44723 44724 44725 44726 44727 44728 44729 44730 44731 44732 44733 44734 44735 44736 44737 44738 44739 44740 44741 44742 44743 44744 44745 44746 44747 44748 44749 44750 44751 44752 44753 44754 44755 44756 44757 44758 44759 44760 44761 44762 44763 44764 44765 44766 44767 44768 44769 44770 44771 44772 44773 44774 44775 44776 44777 44778 44779 44780 44781 44782 44783 44784 44785 44786 44787 44788 44789 44790 44791 44792 44793 44794 44795 44796 44797 44798 44799 44800 44801 44802 44803 44804 44805 44806 44807 44808 44809 44810 44811 44812 44813 44814 44815 44816 44817 44818 44819 44820 44821 44822 44823 44824 44825 44826 44827 44828 44829 44830 44831 44832 44833 44834 44835 44836 44837 44838 44839 44840 44841 44842 44843 44844 44845 44846 44847 44848 44849 44850 44851 44852 44853 44854 44855 44856 44857 44858 44859 44860 44861 44862 44863 44864 44865 44866 44867 44868 44869 44870 44871 44872 44873 44874 44875 44876 44877 44878 44879 44880 44881 44882 44883 44884 44885 44886 44887 44888 44889 44890 44891 44892 44893 44894 44895 44896 44897 44898 44899 44900 44901 44902 44903 44904 44905 44906 44907 44908 44909 44910 44911 44912 44913 44914 44915 44916 44917 44918 44919 44920 44921 44922 44923 44924 44925 44926 44927 44928 44929 44930 44931 44932 44933 44934 44935 44936 44937 44938 44939 44940 44941 44942 44943 44944 44945 44946 44947 44948 44949 44950 44951 44952 44953 44954 44955 44956 44957 44958 44959 44960 44961 44962 44963 44964 44965 44966 44967 44968 44969 44970 44971 44972 44973 44974 44975 44976 44977 44978 44979 44980 44981 44982 44983 44984 44985 44986 44987 44988 44989 44990 44991 44992 44993 44994 44995 44996 44997 44998 44999 45000 45001 45002 45003 45004 45005 45006 45007 45008 45009 45010 45011 45012 45013 45014 45015 45016 45017 45018 45019 45020 45021 45022 45023 45024 45025 45026 45027 45028 45029 45030 45031 45032 45033 45034 45035 45036 45037 45038 45039 45040 45041 45042 45043 45044 45045 45046 45047 45048 45049 45050 45051 45052 45053 45054 45055 45056 45057 45058 45059 45060 45061 45062 45063 45064 45065 45066 45067 45068 45069 45070 45071 45072 45073 45074 45075 45076 45077 45078 45079 45080 45081 45082 45083 45084 45085 45086 45087 45088 45089 45090 45091 45092 45093 45094 45095 45096 45097 45098 45099 45100 45101 45102 45103 45104 45105 45106 45107 45108 45109 45110 45111 45112 45113 45114 45115 45116 45117 45118 45119 45120 45121 45122 45123 45124 45125 45126 45127 45128 45129 45130 45131 45132 45133 45134 45135 45136 45137 45138 45139 45140 45141 45142 45143 45144 45145 45146 45147 45148 45149 45150 45151 45152 45153 45154 45155 45156 45157 45158 45159 45160 45161 45162 45163 45164 45165 45166 45167 45168 45169 45170 45171 45172 45173 45174 45175 45176 45177 45178 45179 45180 45181 45182 45183 45184 45185 45186 45187 45188 45189 45190 45191 45192 45193 45194 45195 45196 45197 45198 45199 45200 45201 45202 45203 45204 45205 45206 45207 45208 45209 45210 45211 45212 45213 45214 45215 45216 45217 45218 45219 45220 45221 45222 45223 45224 45225 45226 45227 45228 45229 45230 45231 45232 45233 45234 45235 45236 45237 45238 45239 45240 45241 45242 45243 45244 45245 45246 45247 45248 45249 45250 45251 45252 45253 45254 45255 45256 45257 45258 45259 45260 45261 45262 45263 45264 45265 45266 45267 45268 45269 45270 45271 45272 45273 45274 45275 45276 45277 45278 45279 45280 45281 45282 45283 45284 45285 45286 45287 45288 45289 45290 45291 45292 45293 45294 45295 45296 45297 45298 45299 45300 45301 45302 45303 45304 45305 45306 45307 45308 45309 45310 45311 45312 45313 45314 45315 45316 45317 45318 45319 45320 45321 45322 45323 45324 45325 45326 45327 45328 45329 45330 45331 45332 45333 45334 45335 45336 45337 45338 45339 45340 45341 45342 45343 45344 45345 45346 45347 45348 45349 45350 45351 45352 45353 45354 45355 45356 45357 45358 45359 45360 45361 45362 45363 45364 45365 45366 45367 45368 45369 45370 45371 45372 45373 45374 45375 45376 45377 45378 45379 45380 45381 45382 45383 45384 45385 45386 45387 45388 45389 45390 45391 45392 45393 45394 45395 45396 45397 45398 45399 45400 45401 45402 45403 45404 45405 45406 45407 45408 45409 45410 45411 45412 45413 45414 45415 45416 45417 45418 45419 45420 45421 45422 45423 45424 45425 45426 45427 45428 45429 45430 45431 45432 45433 45434 45435 45436 45437 45438 45439 45440 45441 45442 45443 45444 45445 45446 45447 45448 45449 45450 45451 45452 45453 45454 45455 45456 45457 45458 45459 45460 45461 45462 45463 45464 45465 45466 45467 45468 45469 45470 45471 45472 45473 45474 45475 45476 45477 45478 45479 45480 45481 45482 45483 45484 45485 45486 45487 45488 45489 45490 45491 45492 45493 45494 45495 45496 45497 45498 45499 45500 45501 45502 45503 45504 45505 45506 45507 45508 45509 45510 45511 45512 45513 45514 45515 45516 45517 45518 45519 45520 45521 45522 45523 45524 45525 45526 45527 45528 45529 45530 45531 45532 45533 45534 45535 45536 45537 45538 45539 45540 45541 45542 45543 45544 45545 45546 45547 45548 45549 45550 45551 45552 45553 45554 45555 45556 45557 45558 45559 45560 45561 45562 45563 45564 45565 45566 45567 45568 45569 45570 45571 45572 45573 45574 45575 45576 45577 45578 45579 45580 45581 45582 45583 45584 45585 45586 45587 45588 45589 45590 45591 45592 45593 45594 45595 45596 45597 45598 45599 45600 45601 45602 45603 45604 45605 45606 45607 45608 45609 45610 45611 45612 45613 45614 45615 45616 45617 45618 45619 45620 45621 45622 45623 45624 45625 45626 45627 45628 45629 45630 45631 45632 45633 45634 45635 45636 45637 45638 45639 45640 45641 45642 45643 45644 45645 45646 45647 45648 45649 45650 45651 45652 45653 45654 45655 45656 45657 45658 45659 45660 45661 45662 45663 45664 45665 45666 45667 45668 45669 45670 45671 45672 45673 45674 45675 45676 45677 45678 45679 45680 45681 45682 45683 45684 45685 45686 45687 45688 45689 45690 45691 45692 45693 45694 45695 45696 45697 45698 45699 45700 45701 45702 45703 45704 45705 45706 45707 45708 45709 45710 45711 45712 45713 45714 45715 45716 45717 45718 45719 45720 45721 45722 45723 45724 45725 45726 45727 45728 45729 45730 45731 45732 45733 45734 45735 45736 45737 45738 45739 45740 45741 45742 45743 45744 45745 45746 45747 45748 45749 45750 45751 45752 45753 45754 45755 45756 45757 45758 45759 45760 45761 45762 45763 45764 45765 45766 45767 45768 45769 45770 45771 45772 45773 45774 45775 45776 45777 45778 45779 45780 45781 45782 45783 45784 45785 45786 45787 45788 45789 45790 45791 45792 45793 45794 45795 45796 45797 45798 45799 45800 45801 45802 45803 45804 45805 45806 45807 45808 45809 45810 45811 45812 45813 45814 45815 45816 45817 45818 45819 45820 45821 45822 45823 45824 45825 45826 45827 45828 45829 45830 45831 45832 45833 45834 45835 45836 45837 45838 45839 45840 45841 45842 45843 45844 45845 45846 45847 45848 45849 45850 45851 45852 45853 45854 45855 45856 45857 45858 45859 45860 45861 45862 45863 45864 45865 45866 45867 45868 45869 45870 45871 45872 45873 45874 45875 45876 45877 45878 45879 45880 45881 45882 45883 45884 45885 45886 45887 45888 45889 45890 45891 45892 45893 45894 45895 45896 45897 45898 45899 45900 45901 45902 45903 45904 45905 45906 45907 45908 45909 45910 45911 45912 45913 45914 45915 45916 45917 45918 45919 45920 45921 45922 45923 45924 45925 45926 45927 45928 45929 45930 45931 45932 45933 45934 45935 45936 45937 45938 45939 45940 45941 45942 45943 45944 45945 45946 45947 45948 45949 45950 45951 45952 45953 45954 45955 45956 45957 45958 45959 45960 45961 45962 45963 45964 45965 45966 45967 45968 45969 45970 45971 45972 45973 45974 45975 45976 45977 45978 45979 45980 45981 45982 45983 45984 45985 45986 45987 45988 45989 45990 45991 45992 45993 45994 45995 45996 45997 45998 45999 46000 46001 46002 46003 46004 46005 46006 46007 46008 46009 46010 46011 46012 46013 46014 46015 46016 46017 46018 46019 46020 46021 46022 46023 46024 46025 46026 46027 46028 46029 46030 46031 46032 46033 46034 46035 46036 46037 46038 46039 46040 46041 46042 46043 46044 46045 46046 46047 46048 46049 46050 46051 46052 46053 46054 46055 46056 46057 46058 46059 46060 46061 46062 46063 46064 46065 46066 46067 46068 46069 46070 46071 46072 46073 46074 46075 46076 46077 46078 46079 46080 46081 46082 46083 46084 46085 46086 46087 46088 46089 46090 46091 46092 46093 46094 46095 46096 46097 46098 46099 46100 46101 46102 46103 46104 46105 46106 46107 46108 46109 46110 46111 46112 46113 46114 46115 46116 46117 46118 46119 46120 46121 46122 46123 46124 46125 46126 46127 46128 46129 46130 46131 46132 46133 46134 46135 46136 46137 46138 46139 46140 46141 46142 46143 46144 46145 46146 46147 46148 46149 46150 46151 46152 46153 46154 46155 46156 46157 46158 46159 46160 46161 46162 46163 46164 46165 46166 46167 46168 46169 46170 46171 46172 46173 46174 46175 46176 46177 46178 46179 46180 46181 46182 46183 46184 46185 46186 46187 46188 46189 46190 46191 46192 46193 46194 46195 46196 46197 46198 46199 46200 46201 46202 46203 46204 46205 46206 46207 46208 46209 46210 46211 46212 46213 46214 46215 46216 46217 46218 46219 46220 46221 46222 46223 46224 46225 46226 46227 46228 46229 46230 46231 46232 46233 46234 46235 46236 46237 46238 46239 46240 46241 46242 46243 46244 46245 46246 46247 46248 46249 46250 46251 46252 46253 46254 46255 46256 46257 46258 46259 46260 46261 46262 46263 46264 46265 46266 46267 46268 46269 46270 46271 46272 46273 46274 46275 46276 46277 46278 46279 46280 46281 46282 46283 46284 46285 46286 46287 46288 46289 46290 46291 46292 46293 46294 46295 46296 46297 46298 46299 46300 46301 46302 46303 46304 46305 46306 46307 46308 46309 46310 46311 46312 46313 46314 46315 46316 46317 46318 46319 46320 46321 46322 46323 46324 46325 46326 46327 46328 46329 46330 46331 46332 46333 46334 46335 46336 46337 46338 46339 46340 46341 46342 46343 46344 46345 46346 46347 46348 46349 46350 46351 46352 46353 46354 46355 46356 46357 46358 46359 46360 46361 46362 46363 46364 46365 46366 46367 46368 46369 46370 46371 46372 46373 46374 46375 46376 46377 46378 46379 46380 46381 46382 46383 46384 46385 46386 46387 46388 46389 46390 46391 46392 46393 46394 46395 46396 46397 46398 46399 46400 46401 46402 46403 46404 46405 46406 46407 46408 46409 46410 46411 46412 46413 46414 46415 46416 46417 46418 46419 46420 46421 46422 46423 46424 46425 46426 46427 46428 46429 46430 46431 46432 46433 46434 46435 46436 46437 46438 46439 46440 46441 46442 46443 46444 46445 46446 46447 46448 46449 46450 46451 46452 46453 46454 46455 46456 46457 46458 46459 46460 46461 46462 46463 46464 46465 46466 46467 46468 46469 46470 46471 46472 46473 46474 46475 46476 46477 46478 46479 46480 46481 46482 46483 46484 46485 46486 46487 46488 46489 46490 46491 46492 46493 46494 46495 46496 46497 46498 46499 46500 46501 46502 46503 46504 46505 46506 46507 46508 46509 46510 46511 46512 46513 46514 46515 46516 46517 46518 46519 46520 46521 46522 46523 46524 46525 46526 46527 46528 46529 46530 46531 46532 46533 46534 46535 46536 46537 46538 46539 46540 46541 46542 46543 46544 46545 46546 46547 46548 46549 46550 46551 46552 46553 46554 46555 46556 46557 46558 46559 46560 46561 46562 46563 46564 46565 46566 46567 46568 46569 46570 46571 46572 46573 46574 46575 46576 46577 46578 46579 46580 46581 46582 46583 46584 46585 46586 46587 46588 46589 46590 46591 46592 46593 46594 46595 46596 46597 46598 46599 46600 46601 46602 46603 46604 46605 46606 46607 46608 46609 46610 46611 46612 46613 46614 46615 46616 46617 46618 46619 46620 46621 46622 46623 46624 46625 46626 46627 46628 46629 46630 46631 46632 46633 46634 46635 46636 46637 46638 46639 46640 46641 46642 46643 46644 46645 46646 46647 46648 46649 46650 46651 46652 46653 46654 46655 46656 46657 46658 46659 46660 46661 46662 46663 46664 46665 46666 46667 46668 46669 46670 46671 46672 46673 46674 46675 46676 46677 46678 46679 46680 46681 46682 46683 46684 46685 46686 46687 46688 46689 46690 46691 46692 46693 46694 46695 46696 46697 46698 46699 46700 46701 46702 46703 46704 46705 46706 46707 46708 46709 46710 46711 46712 46713 46714 46715 46716 46717 46718 46719 46720 46721 46722 46723 46724 46725 46726 46727 46728 46729 46730 46731 46732 46733 46734 46735 46736 46737 46738 46739 46740 46741 46742 46743 46744 46745 46746 46747 46748 46749 46750 46751 46752 46753 46754 46755 46756 46757 46758 46759 46760 46761 46762 46763 46764 46765 46766 46767 46768 46769 46770 46771 46772 46773 46774 46775 46776 46777 46778 46779 46780 46781 46782 46783 46784 46785 46786 46787 46788 46789 46790 46791 46792 46793 46794 46795 46796 46797 46798 46799 46800 46801 46802 46803 46804 46805 46806 46807 46808 46809 46810 46811 46812 46813 46814 46815 46816 46817 46818 46819 46820 46821 46822 46823 46824 46825 46826 46827 46828 46829 46830 46831 46832 46833 46834 46835 46836 46837 46838 46839 46840 46841 46842 46843 46844 46845 46846 46847 46848 46849 46850 46851 46852 46853 46854 46855 46856 46857 46858 46859 46860 46861 46862 46863 46864 46865 46866 46867 46868 46869 46870 46871 46872 46873 46874 46875 46876 46877 46878 46879 46880 46881 46882 46883 46884 46885 46886 46887 46888 46889 46890 46891 46892 46893 46894 46895 46896 46897 46898 46899 46900 46901 46902 46903 46904 46905 46906 46907 46908 46909 46910 46911 46912 46913 46914 46915 46916 46917 46918 46919 46920 46921 46922 46923 46924 46925 46926 46927 46928 46929 46930 46931 46932 46933 46934 46935 46936 46937 46938 46939 46940 46941 46942 46943 46944 46945 46946 46947 46948 46949 46950 46951 46952 46953 46954 46955 46956 46957 46958 46959 46960 46961 46962 46963 46964 46965 46966 46967 46968 46969 46970 46971 46972 46973 46974 46975 46976 46977 46978 46979 46980 46981 46982 46983 46984 46985 46986 46987 46988 46989 46990 46991 46992 46993 46994 46995 46996 46997 46998 46999 47000 47001 47002 47003 47004 47005 47006 47007 47008 47009 47010 47011 47012 47013 47014 47015 47016 47017 47018 47019 47020 47021 47022 47023 47024 47025 47026 47027 47028 47029 47030 47031 47032 47033 47034 47035 47036 47037 47038 47039 47040 47041 47042 47043 47044 47045 47046 47047 47048 47049 47050 47051 47052 47053 47054 47055 47056 47057 47058 47059 47060 47061 47062 47063 47064 47065 47066 47067 47068 47069 47070 47071 47072 47073 47074 47075 47076 47077 47078 47079 47080 47081 47082 47083 47084 47085 47086 47087 47088 47089 47090 47091 47092 47093 47094 47095 47096 47097 47098 47099 47100 47101 47102 47103 47104 47105 47106 47107 47108 47109 47110 47111 47112 47113 47114 47115 47116 47117 47118 47119 47120 47121 47122 47123 47124 47125 47126 47127 47128 47129 47130 47131 47132 47133 47134 47135 47136 47137 47138 47139 47140 47141 47142 47143 47144 47145 47146 47147 47148 47149 47150 47151 47152 47153 47154 47155 47156 47157 47158 47159 47160 47161 47162 47163 47164 47165 47166 47167 47168 47169 47170 47171 47172 47173 47174 47175 47176 47177 47178 47179 47180 47181 47182 47183 47184 47185 47186 47187 47188 47189 47190 47191 47192 47193 47194 47195 47196 47197 47198 47199 47200 47201 47202 47203 47204 47205 47206 47207 47208 47209 47210 47211 47212 47213 47214 47215 47216 47217 47218 47219 47220 47221 47222 47223 47224 47225 47226 47227 47228 47229 47230 47231 47232 47233 47234 47235 47236 47237 47238 47239 47240 47241 47242 47243 47244 47245 47246 47247 47248 47249 47250 47251 47252 47253 47254 47255 47256 47257 47258 47259 47260 47261 47262 47263 47264 47265 47266 47267 47268 47269 47270 47271 47272 47273 47274 47275 47276 47277 47278 47279 47280 47281 47282 47283 47284 47285 47286 47287 47288 47289 47290 47291 47292 47293 47294 47295 47296 47297 47298 47299 47300 47301 47302 47303 47304 47305 47306 47307 47308 47309 47310 47311 47312 47313 47314 47315 47316 47317 47318 47319 47320 47321 47322 47323 47324 47325 47326 47327 47328 47329 47330 47331 47332 47333 47334 47335 47336 47337 47338 47339 47340 47341 47342 47343 47344 47345 47346 47347 47348 47349 47350 47351 47352 47353 47354 47355 47356 47357 47358 47359 47360 47361 47362 47363 47364 47365 47366 47367 47368 47369 47370 47371 47372 47373 47374 47375 47376 47377 47378 47379 47380 47381 47382 47383 47384 47385 47386 47387 47388 47389 47390 47391 47392 47393 47394 47395 47396 47397 47398 47399 47400 47401 47402 47403 47404 47405 47406 47407 47408 47409 47410 47411 47412 47413 47414 47415 47416 47417 47418 47419 47420 47421 47422 47423 47424 47425 47426 47427 47428 47429 47430 47431 47432 47433 47434 47435 47436 47437 47438 47439 47440 47441 47442 47443 47444 47445 47446 47447 47448 47449 47450 47451 47452 47453 47454 47455 47456 47457 47458 47459 47460 47461 47462 47463 47464 47465 47466 47467 47468 47469 47470 47471 47472 47473 47474 47475 47476 47477 47478 47479 47480 47481 47482 47483 47484 47485 47486 47487 47488 47489 47490 47491 47492 47493 47494 47495 47496 47497 47498 47499 47500 47501 47502 47503 47504 47505 47506 47507 47508 47509 47510 47511 47512 47513 47514 47515 47516 47517 47518 47519 47520 47521 47522 47523 47524 47525 47526 47527 47528 47529 47530 47531 47532 47533 47534 47535 47536 47537 47538 47539 47540 47541 47542 47543 47544 47545 47546 47547 47548 47549 47550 47551 47552 47553 47554 47555 47556 47557 47558 47559 47560 47561 47562 47563 47564 47565 47566 47567 47568 47569 47570 47571 47572 47573 47574 47575 47576 47577 47578 47579 47580 47581 47582 47583 47584 47585 47586 47587 47588 47589 47590 47591 47592 47593 47594 47595 47596 47597 47598 47599 47600 47601 47602 47603 47604 47605 47606 47607 47608 47609 47610 47611 47612 47613 47614 47615 47616 47617 47618 47619 47620 47621 47622 47623 47624 47625 47626 47627 47628 47629 47630 47631 47632 47633 47634 47635 47636 47637 47638 47639 47640 47641 47642 47643 47644 47645 47646 47647 47648 47649 47650 47651 47652 47653 47654 47655 47656 47657 47658 47659 47660 47661 47662 47663 47664 47665 47666 47667 47668 47669 47670 47671 47672 47673 47674 47675 47676 47677 47678 47679 47680 47681 47682 47683 47684 47685 47686 47687 47688 47689 47690 47691 47692 47693 47694 47695 47696 47697 47698 47699 47700 47701 47702 47703 47704 47705 47706 47707 47708 47709 47710 47711 47712 47713 47714 47715 47716 47717 47718 47719 47720 47721 47722 47723 47724 47725 47726 47727 47728 47729 47730 47731 47732 47733 47734 47735 47736 47737 47738 47739 47740 47741 47742 47743 47744 47745 47746 47747 47748 47749 47750 47751 47752 47753 47754 47755 47756 47757 47758 47759 47760 47761 47762 47763 47764 47765 47766 47767 47768 47769 47770 47771 47772 47773 47774 47775 47776 47777 47778 47779 47780 47781 47782 47783 47784 47785 47786 47787 47788 47789 47790 47791 47792 47793 47794 47795 47796 47797 47798 47799 47800 47801 47802 47803 47804 47805 47806 47807 47808 47809 47810 47811 47812 47813 47814 47815 47816 47817 47818 47819 47820 47821 47822 47823 47824 47825 47826 47827 47828 47829 47830 47831 47832 47833 47834 47835 47836 47837 47838 47839 47840 47841 47842 47843 47844 47845 47846 47847 47848 47849 47850 47851 47852 47853 47854 47855 47856 47857 47858 47859 47860 47861 47862 47863 47864 47865 47866 47867 47868 47869 47870 47871 47872 47873 47874 47875 47876 47877 47878 47879 47880 47881 47882 47883 47884 47885 47886 47887 47888 47889 47890 47891 47892 47893 47894 47895 47896 47897 47898 47899 47900 47901 47902 47903 47904 47905 47906 47907 47908 47909 47910 47911 47912 47913 47914 47915 47916 47917 47918 47919 47920 47921 47922 47923 47924 47925 47926 47927 47928 47929 47930 47931 47932 47933 47934 47935 47936 47937 47938 47939 47940 47941 47942 47943 47944 47945 47946 47947 47948 47949 47950 47951 47952 47953 47954 47955 47956 47957 47958 47959 47960 47961 47962 47963 47964 47965 47966 47967 47968 47969 47970 47971 47972 47973 47974 47975 47976 47977 47978 47979 47980 47981 47982 47983 47984 47985 47986 47987 47988 47989 47990 47991 47992 47993 47994 47995 47996 47997 47998 47999 48000 48001 48002 48003 48004 48005 48006 48007 48008 48009 48010 48011 48012 48013 48014 48015 48016 48017 48018 48019 48020 48021 48022 48023 48024 48025 48026 48027 48028 48029 48030 48031 48032 48033 48034 48035 48036 48037 48038 48039 48040 48041 48042 48043 48044 48045 48046 48047 48048 48049 48050 48051 48052 48053 48054 48055 48056 48057 48058 48059 48060 48061 48062 48063 48064 48065 48066 48067 48068 48069 48070 48071 48072 48073 48074 48075 48076 48077 48078 48079 48080 48081 48082 48083 48084 48085 48086 48087 48088 48089 48090 48091 48092 48093 48094 48095 48096 48097 48098 48099 48100 48101 48102 48103 48104 48105 48106 48107 48108 48109 48110 48111 48112 48113 48114 48115 48116 48117 48118 48119 48120 48121 48122 48123 48124 48125 48126 48127 48128 48129 48130 48131 48132 48133 48134 48135 48136 48137 48138 48139 48140 48141 48142 48143 48144 48145 48146 48147 48148 48149 48150 48151 48152 48153 48154 48155 48156 48157 48158 48159 48160 48161 48162 48163 48164 48165 48166 48167 48168 48169 48170 48171 48172 48173 48174 48175 48176 48177 48178 48179 48180 48181 48182 48183 48184 48185 48186 48187 48188 48189 48190 48191 48192 48193 48194 48195 48196 48197 48198 48199 48200 48201 48202 48203 48204 48205 48206 48207 48208 48209 48210 48211 48212 48213 48214 48215 48216 48217 48218 48219 48220 48221 48222 48223 48224 48225 48226 48227 48228 48229 48230 48231 48232 48233 48234 48235 48236 48237 48238 48239 48240 48241 48242 48243 48244 48245 48246 48247 48248 48249 48250 48251 48252 48253 48254 48255 48256 48257 48258 48259 48260 48261 48262 48263 48264 48265 48266 48267 48268 48269 48270 48271 48272 48273 48274 48275 48276 48277 48278 48279 48280 48281 48282 48283 48284 48285 48286 48287 48288 48289 48290 48291 48292 48293 48294 48295 48296 48297 48298 48299 48300 48301 48302 48303 48304 48305 48306 48307 48308 48309 48310 48311 48312 48313 48314 48315 48316 48317 48318 48319 48320 48321 48322 48323 48324 48325 48326 48327 48328 48329 48330 48331 48332 48333 48334 48335 48336 48337 48338 48339 48340 48341 48342 48343 48344 48345 48346 48347 48348 48349 48350 48351 48352 48353 48354 48355 48356 48357 48358 48359 48360 48361 48362 48363 48364 48365 48366 48367 48368 48369 48370 48371 48372 48373 48374 48375 48376 48377 48378 48379 48380 48381 48382 48383 48384 48385 48386 48387 48388 48389 48390 48391 48392 48393 48394 48395 48396 48397 48398 48399 48400 48401 48402 48403 48404 48405 48406 48407 48408 48409 48410 48411 48412 48413 48414 48415 48416 48417 48418 48419 48420 48421 48422 48423 48424 48425 48426 48427 48428 48429 48430 48431 48432 48433 48434 48435 48436 48437 48438 48439 48440 48441 48442 48443 48444 48445 48446 48447 48448 48449 48450 48451 48452 48453 48454 48455 48456 48457 48458 48459 48460 48461 48462 48463 48464 48465 48466 48467 48468 48469 48470 48471 48472 48473 48474 48475 48476 48477 48478 48479 48480 48481 48482 48483 48484 48485 48486 48487 48488 48489 48490 48491 48492 48493 48494 48495 48496 48497 48498 48499 48500 48501 48502 48503 48504 48505 48506 48507 48508 48509 48510 48511 48512 48513 48514 48515 48516 48517 48518 48519 48520 48521 48522 48523 48524 48525 48526 48527 48528 48529 48530 48531 48532 48533 48534 48535 48536 48537 48538 48539 48540 48541 48542 48543 48544 48545 48546 48547 48548 48549 48550 48551 48552 48553 48554 48555 48556 48557 48558 48559 48560 48561 48562 48563 48564 48565 48566 48567 48568 48569 48570 48571 48572 48573 48574 48575 48576 48577 48578 48579 48580 48581 48582 48583 48584 48585 48586 48587 48588 48589 48590 48591 48592 48593 48594 48595 48596 48597 48598 48599 48600 48601 48602 48603 48604 48605 48606 48607 48608 48609 48610 48611 48612 48613 48614 48615 48616 48617 48618 48619 48620 48621 48622 48623 48624 48625 48626 48627 48628 48629 48630 48631 48632 48633 48634 48635 48636 48637 48638 48639 48640 48641 48642 48643 48644 48645 48646 48647 48648 48649 48650 48651 48652 48653 48654 48655 48656 48657 48658 48659 48660 48661 48662 48663 48664 48665 48666 48667 48668 48669 48670 48671 48672 48673 48674 48675 48676 48677 48678 48679 48680 48681 48682 48683 48684 48685 48686 48687 48688 48689 48690 48691 48692 48693 48694 48695 48696 48697 48698 48699 48700 48701 48702 48703 48704 48705 48706 48707 48708 48709 48710 48711 48712 48713 48714 48715 48716 48717 48718 48719 48720 48721 48722 48723 48724 48725 48726 48727 48728 48729 48730 48731 48732 48733 48734 48735 48736 48737 48738 48739 48740 48741 48742 48743 48744 48745 48746 48747 48748 48749 48750 48751 48752 48753 48754 48755 48756 48757 48758 48759 48760 48761 48762 48763 48764 48765 48766 48767 48768 48769 48770 48771 48772 48773 48774 48775 48776 48777 48778 48779 48780 48781 48782 48783 48784 48785 48786 48787 48788 48789 48790 48791 48792 48793 48794 48795 48796 48797 48798 48799 48800 48801 48802 48803 48804 48805 48806 48807 48808 48809 48810 48811 48812 48813 48814 48815 48816 48817 48818 48819 48820 48821 48822 48823 48824 48825 48826 48827 48828 48829 48830 48831 48832 48833 48834 48835 48836 48837 48838 48839 48840 48841 48842 48843 48844 48845 48846 48847 48848 48849 48850 48851 48852 48853 48854 48855 48856 48857 48858 48859 48860 48861 48862 48863 48864 48865 48866 48867 48868 48869 48870 48871 48872 48873 48874 48875 48876 48877 48878 48879 48880 48881 48882 48883 48884 48885 48886 48887 48888 48889 48890 48891 48892 48893 48894 48895 48896 48897 48898 48899 48900 48901 48902 48903 48904 48905 48906 48907 48908 48909 48910 48911 48912 48913 48914 48915 48916 48917 48918 48919 48920 48921 48922 48923 48924 48925 48926 48927 48928 48929 48930 48931 48932 48933 48934 48935 48936 48937 48938 48939 48940 48941 48942 48943 48944 48945 48946 48947 48948 48949 48950 48951 48952 48953 48954 48955 48956 48957 48958 48959 48960 48961 48962 48963 48964 48965 48966 48967 48968 48969 48970 48971 48972 48973 48974 48975 48976 48977 48978 48979 48980 48981 48982 48983 48984 48985 48986 48987 48988 48989 48990 48991 48992 48993 48994 48995 48996 48997 48998 48999 49000 49001 49002 49003 49004 49005 49006 49007 49008 49009 49010 49011 49012 49013 49014 49015 49016 49017 49018 49019 49020 49021 49022 49023 49024 49025 49026 49027 49028 49029 49030 49031 49032 49033 49034 49035 49036 49037 49038 49039 49040 49041 49042 49043 49044 49045 49046 49047 49048 49049 49050 49051 49052 49053 49054 49055 49056 49057 49058 49059 49060 49061 49062 49063 49064 49065 49066 49067 49068 49069 49070 49071 49072 49073 49074 49075 49076 49077 49078 49079 49080 49081 49082 49083 49084 49085 49086 49087 49088 49089 49090 49091 49092 49093 49094 49095 49096 49097 49098 49099 49100 49101 49102 49103 49104 49105 49106 49107 49108 49109 49110 49111 49112 49113 49114 49115 49116 49117 49118 49119 49120 49121 49122 49123 49124 49125 49126 49127 49128 49129 49130 49131 49132 49133 49134 49135 49136 49137 49138 49139 49140 49141 49142 49143 49144 49145 49146 49147 49148 49149 49150 49151 49152 49153 49154 49155 49156 49157 49158 49159 49160 49161 49162 49163 49164 49165 49166 49167 49168 49169 49170 49171 49172 49173 49174 49175 49176 49177 49178 49179 49180 49181 49182 49183 49184 49185 49186 49187 49188 49189 49190 49191 49192 49193 49194 49195 49196 49197 49198 49199 49200 49201 49202 49203 49204 49205 49206 49207 49208 49209 49210 49211 49212 49213 49214 49215 49216 49217 49218 49219 49220 49221 49222 49223 49224 49225 49226 49227 49228 49229 49230 49231 49232 49233 49234 49235 49236 49237 49238 49239 49240 49241 49242 49243 49244 49245 49246 49247 49248 49249 49250 49251 49252 49253 49254 49255 49256 49257 49258 49259 49260 49261 49262 49263 49264 49265 49266 49267 49268 49269 49270 49271 49272 49273 49274 49275 49276 49277 49278 49279 49280 49281 49282 49283 49284 49285 49286 49287 49288 49289 49290 49291 49292 49293 49294 49295 49296 49297 49298 49299 49300 49301 49302 49303 49304 49305 49306 49307 49308 49309 49310 49311 49312 49313 49314 49315 49316 49317 49318 49319 49320 49321 49322 49323 49324 49325 49326 49327 49328 49329 49330 49331 49332 49333 49334 49335 49336 49337 49338 49339 49340 49341 49342 49343 49344 49345 49346 49347 49348 49349 49350 49351 49352 49353 49354 49355 49356 49357 49358 49359 49360 49361 49362 49363 49364 49365 49366 49367 49368 49369 49370 49371 49372 49373 49374 49375 49376 49377 49378 49379 49380 49381 49382 49383 49384 49385 49386 49387 49388 49389 49390 49391 49392 49393 49394 49395 49396 49397 49398 49399 49400 49401 49402 49403 49404 49405 49406 49407 49408 49409 49410 49411 49412 49413 49414 49415 49416 49417 49418 49419 49420 49421 49422 49423 49424 49425 49426 49427 49428 49429 49430 49431 49432 49433 49434 49435 49436 49437 49438 49439 49440 49441 49442 49443 49444 49445 49446 49447 49448 49449 49450 49451 49452 49453 49454 49455 49456 49457 49458 49459 49460 49461 49462 49463 49464 49465 49466 49467 49468 49469 49470 49471 49472 49473 49474 49475 49476 49477 49478 49479 49480 49481 49482 49483 49484 49485 49486 49487 49488 49489 49490 49491 49492 49493 49494 49495 49496 49497 49498 49499 49500 49501 49502 49503 49504 49505 49506 49507 49508 49509 49510 49511 49512 49513 49514 49515 49516 49517 49518 49519 49520 49521 49522 49523 49524 49525 49526 49527 49528 49529 49530 49531 49532 49533 49534 49535 49536 49537 49538 49539 49540 49541 49542 49543 49544 49545 49546 49547 49548 49549 49550 49551 49552 49553 49554 49555 49556 49557 49558 49559 49560 49561 49562 49563 49564 49565 49566 49567 49568 49569 49570 49571 49572 49573 49574 49575 49576 49577 49578 49579 49580 49581 49582 49583 49584 49585 49586 49587 49588 49589 49590 49591 49592 49593 49594 49595 49596 49597 49598 49599 49600 49601 49602 49603 49604 49605 49606 49607 49608 49609 49610 49611 49612 49613 49614 49615 49616 49617 49618 49619 49620 49621 49622 49623 49624 49625 49626 49627 49628 49629 49630 49631 49632 49633 49634 49635 49636 49637 49638 49639 49640 49641 49642 49643 49644 49645 49646 49647 49648 49649 49650 49651 49652 49653 49654 49655 49656 49657 49658 49659 49660 49661 49662 49663 49664 49665 49666 49667 49668 49669 49670 49671 49672 49673 49674 49675 49676 49677 49678 49679 49680 49681 49682 49683 49684 49685 49686 49687 49688 49689 49690 49691 49692 49693 49694 49695 49696 49697 49698 49699 49700 49701 49702 49703 49704 49705 49706 49707 49708 49709 49710 49711 49712 49713 49714 49715 49716 49717 49718 49719 49720 49721 49722 49723 49724 49725 49726 49727 49728 49729 49730 49731 49732 49733 49734 49735 49736 49737 49738 49739 49740 49741 49742 49743 49744 49745 49746 49747 49748 49749 49750 49751 49752 49753 49754 49755 49756 49757 49758 49759 49760 49761 49762 49763 49764 49765 49766 49767 49768 49769 49770 49771 49772 49773 49774 49775 49776 49777 49778 49779 49780 49781 49782 49783 49784 49785 49786 49787 49788 49789 49790 49791 49792 49793 49794 49795 49796 49797 49798 49799 49800 49801 49802 49803 49804 49805 49806 49807 49808 49809 49810 49811 49812 49813 49814 49815 49816 49817 49818 49819 49820 49821 49822 49823 49824 49825 49826 49827 49828 49829 49830 49831 49832 49833 49834 49835 49836 49837 49838 49839 49840 49841 49842 49843 49844 49845 49846 49847 49848 49849 49850 49851 49852 49853 49854 49855 49856 49857 49858 49859 49860 49861 49862 49863 49864 49865 49866 49867 49868 49869 49870 49871 49872 49873 49874 49875 49876 49877 49878 49879 49880 49881 49882 49883 49884 49885 49886 49887 49888 49889 49890 49891 49892 49893 49894 49895 49896 49897 49898 49899 49900 49901 49902 49903 49904 49905 49906 49907 49908 49909 49910 49911 49912 49913 49914 49915 49916 49917 49918 49919 49920 49921 49922 49923 49924 49925 49926 49927 49928 49929 49930 49931 49932 49933 49934 49935 49936 49937 49938 49939 49940 49941 49942 49943 49944 49945 49946 49947 49948 49949 49950 49951 49952 49953 49954 49955 49956 49957 49958 49959 49960 49961 49962 49963 49964 49965 49966 49967 49968 49969 49970 49971 49972 49973 49974 49975 49976 49977 49978 49979 49980 49981 49982 49983 49984 49985 49986 49987 49988 49989 49990 49991 49992 49993 49994 49995 49996 49997 49998 49999 50000 50001 50002 50003 50004 50005 50006 50007 50008 50009 50010 50011 50012 50013 50014 50015 50016 50017 50018 50019 50020 50021 50022 50023 50024 50025 50026 50027 50028 50029 50030 50031 50032 50033 50034 50035 50036 50037 50038 50039 50040 50041 50042 50043 50044 50045 50046 50047 50048 50049 50050 50051 50052 50053 50054 50055 50056 50057 50058 50059 50060 50061 50062 50063 50064 50065 50066 50067 50068 50069 50070 50071 50072 50073 50074 50075 50076 50077 50078 50079 50080 50081 50082 50083 50084 50085 50086 50087 50088 50089 50090 50091 50092 50093 50094 50095 50096 50097 50098 50099 50100 50101 50102 50103 50104 50105 50106 50107 50108 50109 50110 50111 50112 50113 50114 50115 50116 50117 50118 50119 50120 50121 50122 50123 50124 50125 50126 50127 50128 50129 50130 50131 50132 50133 50134 50135 50136 50137 50138 50139 50140 50141 50142 50143 50144 50145 50146 50147 50148 50149 50150 50151 50152 50153 50154 50155 50156 50157 50158 50159 50160 50161 50162 50163 50164 50165 50166 50167 50168 50169 50170 50171 50172 50173 50174 50175 50176 50177 50178 50179 50180 50181 50182 50183 50184 50185 50186 50187 50188 50189 50190 50191 50192 50193 50194 50195 50196 50197 50198 50199 50200 50201 50202 50203 50204 50205 50206 50207 50208 50209 50210 50211 50212 50213 50214 50215 50216 50217 50218 50219 50220 50221 50222 50223 50224 50225 50226 50227 50228 50229 50230 50231 50232 50233 50234 50235 50236 50237 50238 50239 50240 50241 50242 50243 50244 50245 50246 50247 50248 50249 50250 50251 50252 50253 50254 50255 50256 50257 50258 50259 50260 50261 50262 50263 50264 50265 50266 50267 50268 50269 50270 50271 50272 50273 50274 50275 50276 50277 50278 50279 50280 50281 50282 50283 50284 50285 50286 50287 50288 50289 50290 50291 50292 50293 50294 50295 50296 50297 50298 50299 50300 50301 50302 50303 50304 50305 50306 50307 50308 50309 50310 50311 50312 50313 50314 50315 50316 50317 50318 50319 50320 50321 50322 50323 50324 50325 50326 50327 50328 50329 50330 50331 50332 50333 50334 50335 50336 50337 50338 50339 50340 50341 50342 50343 50344 50345 50346 50347 50348 50349 50350 50351 50352 50353 50354 50355 50356 50357 50358 50359 50360 50361 50362 50363 50364 50365 50366 50367 50368 50369 50370 50371 50372 50373 50374 50375 50376 50377 50378 50379 50380 50381 50382 50383 50384 50385 50386 50387 50388 50389 50390 50391 50392 50393 50394 50395 50396 50397 50398 50399 50400 50401 50402 50403 50404 50405 50406 50407 50408 50409 50410 50411 50412 50413 50414 50415 50416 50417 50418 50419 50420 50421 50422 50423 50424 50425 50426 50427 50428 50429 50430 50431 50432 50433 50434 50435 50436 50437 50438 50439 50440 50441 50442 50443 50444 50445 50446 50447 50448 50449 50450 50451 50452 50453 50454 50455 50456 50457 50458 50459 50460 50461 50462 50463 50464 50465 50466 50467 50468 50469 50470 50471 50472 50473 50474 50475 50476 50477 50478 50479 50480 50481 50482 50483 50484 50485 50486 50487 50488 50489 50490 50491 50492 50493 50494 50495 50496 50497 50498 50499 50500 50501 50502 50503 50504 50505 50506 50507 50508 50509 50510 50511 50512 50513 50514 50515 50516 50517 50518 50519 50520 50521 50522 50523 50524 50525 50526 50527 50528 50529 50530 50531 50532 50533 50534 50535 50536 50537 50538 50539 50540 50541 50542 50543 50544 50545 50546 50547 50548 50549 50550 50551 50552 50553 50554 50555 50556 50557 50558 50559 50560 50561 50562 50563 50564 50565 50566 50567 50568 50569 50570 50571 50572 50573 50574 50575 50576 50577 50578 50579 50580 50581 50582 50583 50584 50585 50586 50587 50588 50589 50590 50591 50592 50593 50594 50595 50596 50597 50598 50599 50600 50601 50602 50603 50604 50605 50606 50607 50608 50609 50610 50611 50612 50613 50614 50615 50616 50617 50618 50619 50620 50621 50622 50623 50624 50625 50626 50627 50628 50629 50630 50631 50632 50633 50634 50635 50636 50637 50638 50639 50640 50641 50642 50643 50644 50645 50646 50647 50648 50649 50650 50651 50652 50653 50654 50655 50656 50657 50658 50659 50660 50661 50662 50663 50664 50665 50666 50667 50668 50669 50670 50671 50672 50673 50674 50675 50676 50677 50678 50679 50680 50681 50682 50683 50684 50685 50686 50687 50688 50689 50690 50691 50692 50693 50694 50695 50696 50697 50698 50699 50700 50701 50702 50703 50704 50705 50706 50707 50708 50709 50710 50711 50712 50713 50714 50715 50716 50717 50718 50719 50720 50721 50722 50723 50724 50725 50726 50727 50728 50729 50730 50731 50732 50733 50734 50735 50736 50737 50738 50739 50740 50741 50742 50743 50744 50745 50746 50747 50748 50749 50750 50751 50752 50753 50754 50755 50756 50757 50758 50759 50760 50761 50762 50763 50764 50765 50766 50767 50768 50769 50770 50771 50772 50773 50774 50775 50776 50777 50778 50779 50780 50781 50782 50783 50784 50785 50786 50787 50788 50789 50790 50791 50792 50793 50794 50795 50796 50797 50798 50799 50800 50801 50802 50803 50804 50805 50806 50807 50808 50809 50810 50811 50812 50813 50814 50815 50816 50817 50818 50819 50820 50821 50822 50823 50824 50825 50826 50827 50828 50829 50830 50831 50832 50833 50834 50835 50836 50837 50838 50839 50840 50841 50842 50843 50844 50845 50846 50847 50848 50849 50850 50851 50852 50853 50854 50855 50856 50857 50858 50859 50860 50861 50862 50863 50864 50865 50866 50867 50868 50869 50870 50871 50872 50873 50874 50875 50876 50877 50878 50879 50880 50881 50882 50883 50884 50885 50886 50887 50888 50889 50890 50891 50892 50893 50894 50895 50896 50897 50898 50899 50900 50901 50902 50903 50904 50905 50906 50907 50908 50909 50910 50911 50912 50913 50914 50915 50916 50917 50918 50919 50920 50921 50922 50923 50924 50925 50926 50927 50928 50929 50930 50931 50932 50933 50934 50935 50936 50937 50938 50939 50940 50941 50942 50943 50944 50945 50946 50947 50948 50949 50950 50951 50952 50953 50954 50955 50956 50957 50958 50959 50960 50961 50962 50963 50964 50965 50966 50967 50968 50969 50970 50971 50972 50973 50974 50975 50976 50977 50978 50979 50980 50981 50982 50983 50984 50985 50986 50987 50988 50989 50990 50991 50992 50993 50994 50995 50996 50997 50998 50999 51000 51001 51002 51003 51004 51005 51006 51007 51008 51009 51010 51011 51012 51013 51014 51015 51016 51017 51018 51019 51020 51021 51022 51023 51024 51025 51026 51027 51028 51029 51030 51031 51032 51033 51034 51035 51036 51037 51038 51039 51040 51041 51042 51043 51044 51045 51046 51047 51048 51049 51050 51051 51052 51053 51054 51055 51056 51057 51058 51059 51060 51061 51062 51063 51064 51065 51066 51067 51068 51069 51070 51071 51072 51073 51074 51075 51076 51077 51078 51079 51080 51081 51082 51083 51084 51085 51086 51087 51088 51089 51090 51091 51092 51093 51094 51095 51096 51097 51098 51099 51100 51101 51102 51103 51104 51105 51106 51107 51108 51109 51110 51111 51112 51113 51114 51115 51116 51117 51118 51119 51120 51121 51122 51123 51124 51125 51126 51127 51128 51129 51130 51131 51132 51133 51134 51135 51136 51137 51138 51139 51140 51141 51142 51143 51144 51145 51146 51147 51148 51149 51150 51151 51152 51153 51154 51155 51156 51157 51158 51159 51160 51161 51162 51163 51164 51165 51166 51167 51168 51169 51170 51171 51172 51173 51174 51175 51176 51177 51178 51179 51180 51181 51182 51183 51184 51185 51186 51187 51188 51189 51190 51191 51192 51193 51194 51195 51196 51197 51198 51199 51200 51201 51202 51203 51204 51205 51206 51207 51208 51209 51210 51211 51212 51213 51214 51215 51216 51217 51218 51219 51220 51221 51222 51223 51224 51225 51226 51227 51228 51229 51230 51231 51232 51233 51234 51235 51236 51237 51238 51239 51240 51241 51242 51243 51244 51245 51246 51247 51248 51249 51250 51251 51252 51253 51254 51255 51256 51257 51258 51259 51260 51261 51262 51263 51264 51265 51266 51267 51268 51269 51270 51271 51272 51273 51274 51275 51276 51277 51278 51279 51280 51281 51282 51283 51284 51285 51286 51287 51288 51289 51290 51291 51292 51293 51294 51295 51296 51297 51298 51299 51300 51301 51302 51303 51304 51305 51306 51307 51308 51309 51310 51311 51312 51313 51314 51315 51316 51317 51318 51319 51320 51321 51322 51323 51324 51325 51326 51327 51328 51329 51330 51331 51332 51333 51334 51335 51336 51337 51338 51339 51340 51341 51342 51343 51344 51345 51346 51347 51348 51349 51350 51351 51352 51353 51354 51355 51356 51357 51358 51359 51360 51361 51362 51363 51364 51365 51366 51367 51368 51369 51370 51371 51372 51373 51374 51375 51376 51377 51378 51379 51380 51381 51382 51383 51384 51385 51386 51387 51388 51389 51390 51391 51392 51393 51394 51395 51396 51397 51398 51399 51400 51401 51402 51403 51404 51405 51406 51407 51408 51409 51410 51411 51412 51413 51414 51415 51416 51417 51418 51419 51420 51421 51422 51423 51424 51425 51426 51427 51428 51429 51430 51431 51432 51433 51434 51435 51436 51437 51438 51439 51440 51441 51442 51443 51444 51445 51446 51447 51448 51449 51450 51451 51452 51453 51454 51455 51456 51457 51458 51459 51460 51461 51462 51463 51464 51465 51466 51467 51468 51469 51470 51471 51472 51473 51474 51475 51476 51477 51478 51479 51480 51481 51482 51483 51484 51485 51486 51487 51488 51489 51490 51491 51492 51493 51494 51495 51496 51497 51498 51499 51500 51501 51502 51503 51504 51505 51506 51507 51508 51509 51510 51511 51512 51513 51514 51515 51516 51517 51518 51519 51520 51521 51522 51523 51524 51525 51526 51527 51528 51529 51530 51531 51532 51533 51534 51535 51536 51537 51538 51539 51540 51541 51542 51543 51544 51545 51546 51547 51548 51549 51550 51551 51552 51553 51554 51555 51556 51557 51558 51559 51560 51561 51562 51563 51564 51565 51566 51567 51568 51569 51570 51571 51572 51573 51574 51575 51576 51577 51578 51579 51580 51581 51582 51583 51584 51585 51586 51587 51588 51589 51590 51591 51592 51593 51594 51595 51596 51597 51598 51599 51600 51601 51602 51603 51604 51605 51606 51607 51608 51609 51610 51611 51612 51613 51614 51615 51616 51617 51618 51619 51620 51621 51622 51623 51624 51625 51626 51627 51628 51629 51630 51631 51632 51633 51634 51635 51636 51637 51638 51639 51640 51641 51642 51643 51644 51645 51646 51647 51648 51649 51650 51651 51652 51653 51654 51655 51656 51657 51658 51659 51660 51661 51662 51663 51664 51665 51666 51667 51668 51669 51670 51671 51672 51673 51674 51675 51676 51677 51678 51679 51680 51681 51682 51683 51684 51685 51686 51687 51688 51689 51690 51691 51692 51693 51694 51695 51696 51697 51698 51699 51700 51701 51702 51703 51704 51705 51706 51707 51708 51709 51710 51711 51712 51713 51714 51715 51716 51717 51718 51719 51720 51721 51722 51723 51724 51725 51726 51727 51728 51729 51730 51731 51732 51733 51734 51735 51736 51737 51738 51739 51740 51741 51742 51743 51744 51745 51746 51747 51748 51749 51750 51751 51752 51753 51754 51755 51756 51757 51758 51759 51760 51761 51762 51763 51764 51765 51766 51767 51768 51769 51770 51771 51772 51773 51774 51775 51776 51777 51778 51779 51780 51781 51782 51783 51784 51785 51786 51787 51788 51789 51790 51791 51792 51793 51794 51795 51796 51797 51798 51799 51800 51801 51802 51803 51804 51805 51806 51807 51808 51809 51810 51811 51812 51813 51814 51815 51816 51817 51818 51819 51820 51821 51822 51823 51824 51825 51826 51827 51828 51829 51830 51831 51832 51833 51834 51835 51836 51837 51838 51839 51840 51841 51842 51843 51844 51845 51846 51847 51848 51849 51850 51851 51852 51853 51854 51855 51856 51857 51858 51859 51860 51861 51862 51863 51864 51865 51866 51867 51868 51869 51870 51871 51872 51873 51874 51875 51876 51877 51878 51879 51880 51881 51882 51883 51884 51885 51886 51887 51888 51889 51890 51891 51892 51893 51894 51895 51896 51897 51898 51899 51900 51901 51902 51903 51904 51905 51906 51907 51908 51909 51910 51911 51912 51913 51914 51915 51916 51917 51918 51919 51920 51921 51922 51923 51924 51925 51926 51927 51928 51929 51930 51931 51932 51933 51934 51935 51936 51937 51938 51939 51940 51941 51942 51943 51944 51945 51946 51947 51948 51949 51950 51951 51952 51953 51954 51955 51956 51957 51958 51959 51960 51961 51962 51963 51964 51965 51966 51967 51968 51969 51970 51971 51972 51973 51974 51975 51976 51977 51978 51979 51980 51981 51982 51983 51984 51985 51986 51987 51988 51989 51990 51991 51992 51993 51994 51995 51996 51997 51998 51999 52000 52001 52002 52003 52004 52005 52006 52007 52008 52009 52010 52011 52012 52013 52014 52015 52016 52017 52018 52019 52020 52021 52022 52023 52024 52025 52026 52027 52028 52029 52030 52031 52032 52033 52034 52035 52036 52037 52038 52039 52040 52041 52042 52043 52044 52045 52046 52047 52048 52049 52050 52051 52052 52053 52054 52055 52056 52057 52058 52059 52060 52061 52062 52063 52064 52065 52066 52067 52068 52069 52070 52071 52072 52073 52074 52075 52076 52077 52078 52079 52080 52081 52082 52083 52084 52085 52086 52087 52088 52089 52090 52091 52092 52093 52094 52095 52096 52097 52098 52099 52100 52101 52102 52103 52104 52105 52106 52107 52108 52109 52110 52111 52112 52113 52114 52115 52116 52117 52118 52119 52120 52121 52122 52123 52124 52125 52126 52127 52128 52129 52130 52131 52132 52133 52134 52135 52136 52137 52138 52139 52140 52141 52142 52143 52144 52145 52146 52147 52148 52149 52150 52151 52152 52153 52154 52155 52156 52157 52158 52159 52160 52161 52162 52163 52164 52165 52166 52167 52168 52169 52170 52171 52172 52173 52174 52175 52176 52177 52178 52179 52180 52181 52182 52183 52184 52185 52186 52187 52188 52189 52190 52191 52192 52193 52194 52195 52196 52197 52198 52199 52200 52201 52202 52203 52204 52205 52206 52207 52208 52209 52210 52211 52212 52213 52214 52215 52216 52217 52218 52219 52220 52221 52222 52223 52224 52225 52226 52227 52228 52229 52230 52231 52232 52233 52234 52235 52236 52237 52238 52239 52240 52241 52242 52243 52244 52245 52246 52247 52248 52249 52250 52251 52252 52253 52254 52255 52256 52257 52258 52259 52260 52261 52262 52263 52264 52265 52266 52267 52268 52269 52270 52271 52272 52273 52274 52275 52276 52277 52278 52279 52280 52281 52282 52283 52284 52285 52286 52287 52288 52289 52290 52291 52292 52293 52294 52295 52296 52297 52298 52299 52300 52301 52302 52303 52304 52305 52306 52307 52308 52309 52310 52311 52312 52313 52314 52315 52316 52317 52318 52319 52320 52321 52322 52323 52324 52325 52326 52327 52328 52329 52330 52331 52332 52333 52334 52335 52336 52337 52338 52339 52340 52341 52342 52343 52344 52345 52346 52347 52348 52349 52350 52351 52352 52353 52354 52355 52356 52357 52358 52359 52360 52361 52362 52363 52364 52365 52366 52367 52368 52369 52370 52371 52372 52373 52374 52375 52376 52377 52378 52379 52380 52381 52382 52383 52384 52385 52386 52387 52388 52389 52390 52391 52392 52393 52394 52395 52396 52397 52398 52399 52400 52401 52402 52403 52404 52405 52406 52407 52408 52409 52410 52411 52412 52413 52414 52415 52416 52417 52418 52419 52420 52421 52422 52423 52424 52425 52426 52427 52428 52429 52430 52431 52432 52433 52434 52435 52436 52437 52438 52439 52440 52441 52442 52443 52444 52445 52446 52447 52448 52449 52450 52451 52452 52453 52454 52455 52456 52457 52458 52459 52460 52461 52462 52463 52464 52465 52466 52467 52468 52469 52470 52471 52472 52473 52474 52475 52476 52477 52478 52479 52480 52481 52482 52483 52484 52485 52486 52487 52488 52489 52490 52491 52492 52493 52494 52495 52496 52497 52498 52499 52500 52501 52502 52503 52504 52505 52506 52507 52508 52509 52510 52511 52512 52513 52514 52515 52516 52517 52518 52519 52520 52521 52522 52523 52524 52525 52526 52527 52528 52529 52530 52531 52532 52533 52534 52535 52536 52537 52538 52539 52540 52541 52542 52543 52544 52545 52546 52547 52548 52549 52550 52551 52552 52553 52554 52555 52556 52557 52558 52559 52560 52561 52562 52563 52564 52565 52566 52567 52568 52569 52570 52571 52572 52573 52574 52575 52576 52577 52578 52579 52580 52581 52582 52583 52584 52585 52586 52587 52588 52589 52590 52591 52592 52593 52594 52595 52596 52597 52598 52599 52600 52601 52602 52603 52604 52605 52606 52607 52608 52609 52610 52611 52612 52613 52614 52615 52616 52617 52618 52619 52620 52621 52622 52623 52624 52625 52626 52627 52628 52629 52630 52631 52632 52633 52634 52635 52636 52637 52638 52639 52640 52641 52642 52643 52644 52645 52646 52647 52648 52649 52650 52651 52652 52653 52654 52655 52656 52657 52658 52659 52660 52661 52662 52663 52664 52665 52666 52667 52668 52669 52670 52671 52672 52673 52674 52675 52676 52677 52678 52679 52680 52681 52682 52683 52684 52685 52686 52687 52688 52689 52690 52691 52692 52693 52694 52695 52696 52697 52698 52699 52700 52701 52702 52703 52704 52705 52706 52707 52708 52709 52710 52711 52712 52713 52714 52715 52716 52717 52718 52719 52720 52721 52722 52723 52724 52725 52726 52727 52728 52729 52730 52731 52732 52733 52734 52735 52736 52737 52738 52739 52740 52741 52742 52743 52744 52745 52746 52747 52748 52749 52750 52751 52752 52753 52754 52755 52756 52757 52758 52759 52760 52761 52762 52763 52764 52765 52766 52767 52768 52769 52770 52771 52772 52773 52774 52775 52776 52777 52778 52779 52780 52781 52782 52783 52784 52785 52786 52787 52788 52789 52790 52791 52792 52793 52794 52795 52796 52797 52798 52799 52800 52801 52802 52803 52804 52805 52806 52807 52808 52809 52810 52811 52812 52813 52814 52815 52816 52817 52818 52819 52820 52821 52822 52823 52824 52825 52826 52827 52828 52829 52830 52831 52832 52833 52834 52835 52836 52837 52838 52839 52840 52841 52842 52843 52844 52845 52846 52847 52848 52849 52850 52851 52852 52853 52854 52855 52856 52857 52858 52859 52860 52861 52862 52863 52864 52865 52866 52867 52868 52869 52870 52871 52872 52873 52874 52875 52876 52877 52878 52879 52880 52881 52882 52883 52884 52885 52886 52887 52888 52889 52890 52891 52892 52893 52894 52895 52896 52897 52898 52899 52900 52901 52902 52903 52904 52905 52906 52907 52908 52909 52910 52911 52912 52913 52914 52915 52916 52917 52918 52919 52920 52921 52922 52923 52924 52925 52926 52927 52928 52929 52930 52931 52932 52933 52934 52935 52936 52937 52938 52939 52940 52941 52942 52943 52944 52945 52946 52947 52948 52949 52950 52951 52952 52953 52954 52955 52956 52957 52958 52959 52960 52961 52962 52963 52964 52965 52966 52967 52968 52969 52970 52971 52972 52973 52974 52975 52976 52977 52978 52979 52980 52981 52982 52983 52984 52985 52986 52987 52988 52989 52990 52991 52992 52993 52994 52995 52996 52997 52998 52999 53000 53001 53002 53003 53004 53005 53006 53007 53008 53009 53010 53011 53012 53013 53014 53015 53016 53017 53018 53019 53020 53021 53022 53023 53024 53025 53026 53027 53028 53029 53030 53031 53032 53033 53034 53035 53036 53037 53038 53039 53040 53041 53042 53043 53044 53045 53046 53047 53048 53049 53050 53051 53052 53053 53054 53055 53056 53057 53058 53059 53060 53061 53062 53063 53064 53065 53066 53067 53068 53069 53070 53071 53072 53073 53074 53075 53076 53077 53078 53079 53080 53081 53082 53083 53084 53085 53086 53087 53088 53089 53090 53091 53092 53093 53094 53095 53096 53097 53098 53099 53100 53101 53102 53103 53104 53105 53106 53107 53108 53109 53110 53111 53112 53113 53114 53115 53116 53117 53118 53119 53120 53121 53122 53123 53124 53125 53126 53127 53128 53129 53130 53131 53132 53133 53134 53135 53136 53137 53138 53139 53140 53141 53142 53143 53144 53145 53146 53147 53148 53149 53150 53151 53152 53153 53154 53155 53156 53157 53158 53159 53160 53161 53162 53163 53164 53165 53166 53167 53168 53169 53170 53171 53172 53173 53174 53175 53176 53177 53178 53179 53180 53181 53182 53183 53184 53185 53186 53187 53188 53189 53190 53191 53192 53193 53194 53195 53196 53197 53198 53199 53200 53201 53202 53203 53204 53205 53206 53207 53208 53209 53210 53211 53212 53213 53214 53215 53216 53217 53218 53219 53220 53221 53222 53223 53224 53225 53226 53227 53228 53229 53230 53231 53232 53233 53234 53235 53236 53237 53238 53239 53240 53241 53242 53243 53244 53245 53246 53247 53248 53249 53250 53251 53252 53253 53254 53255 53256 53257 53258 53259 53260 53261 53262 53263 53264 53265 53266 53267 53268 53269 53270 53271 53272 53273 53274 53275 53276 53277 53278 53279 53280 53281 53282 53283 53284 53285 53286 53287 53288 53289 53290 53291 53292 53293 53294 53295 53296 53297 53298 53299 53300 53301 53302 53303 53304 53305 53306 53307 53308 53309 53310 53311 53312 53313 53314 53315 53316 53317 53318 53319 53320 53321 53322 53323 53324 53325 53326 53327 53328 53329 53330 53331 53332 53333 53334 53335 53336 53337 53338 53339 53340 53341 53342 53343 53344 53345 53346 53347 53348 53349 53350 53351 53352 53353 53354 53355 53356 53357 53358 53359 53360 53361 53362 53363 53364 53365 53366 53367 53368 53369 53370 53371 53372 53373 53374 53375 53376 53377 53378 53379 53380 53381 53382 53383 53384 53385 53386 53387 53388 53389 53390 53391 53392 53393 53394 53395 53396 53397 53398 53399 53400 53401 53402 53403 53404 53405 53406 53407 53408 53409 53410 53411 53412 53413 53414 53415 53416 53417 53418 53419 53420 53421 53422 53423 53424 53425 53426 53427 53428 53429 53430 53431 53432 53433 53434 53435 53436 53437 53438 53439 53440 53441 53442 53443 53444 53445 53446 53447 53448 53449 53450 53451 53452 53453 53454 53455 53456 53457 53458 53459 53460 53461 53462 53463 53464 53465 53466 53467 53468 53469 53470 53471 53472 53473 53474 53475 53476 53477 53478 53479 53480 53481 53482 53483 53484 53485 53486 53487 53488 53489 53490 53491 53492 53493 53494 53495 53496 53497 53498 53499 53500 53501 53502 53503 53504 53505 53506 53507 53508 53509 53510 53511 53512 53513 53514 53515 53516 53517 53518 53519 53520 53521 53522 53523 53524 53525 53526 53527 53528 53529 53530 53531 53532 53533 53534 53535 53536 53537 53538 53539 53540 53541 53542 53543 53544 53545 53546 53547 53548 53549 53550 53551 53552 53553 53554 53555 53556 53557 53558 53559 53560 53561 53562 53563 53564 53565 53566 53567 53568 53569 53570 53571 53572 53573 53574 53575 53576 53577 53578 53579 53580 53581 53582 53583 53584 53585 53586 53587 53588 53589 53590 53591 53592 53593 53594 53595 53596 53597 53598 53599 53600 53601 53602 53603 53604 53605 53606 53607 53608 53609 53610 53611 53612 53613 53614 53615 53616 53617 53618 53619 53620 53621 53622 53623 53624 53625 53626 53627 53628 53629 53630 53631 53632 53633 53634 53635 53636 53637 53638 53639 53640 53641 53642 53643 53644 53645 53646 53647 53648 53649 53650 53651 53652 53653 53654 53655 53656 53657 53658 53659 53660 53661 53662 53663 53664 53665 53666 53667 53668 53669 53670 53671 53672 53673 53674 53675 53676 53677 53678 53679 53680 53681 53682 53683 53684 53685 53686 53687 53688 53689 53690 53691 53692 53693 53694 53695 53696 53697 53698 53699 53700 53701 53702 53703 53704 53705 53706 53707 53708 53709 53710 53711 53712 53713 53714 53715 53716 53717 53718 53719 53720 53721 53722 53723 53724 53725 53726 53727 53728 53729 53730 53731 53732 53733 53734 53735 53736 53737 53738 53739 53740 53741 53742 53743 53744 53745 53746 53747 53748 53749 53750 53751 53752 53753 53754 53755 53756 53757 53758 53759 53760 53761 53762 53763 53764 53765 53766 53767 53768 53769 53770 53771 53772 53773 53774 53775 53776 53777 53778 53779 53780 53781 53782 53783 53784 53785 53786 53787 53788 53789 53790 53791 53792 53793 53794 53795 53796 53797 53798 53799 53800 53801 53802 53803 53804 53805 53806 53807 53808 53809 53810 53811 53812 53813 53814 53815 53816 53817 53818 53819 53820 53821 53822 53823 53824 53825 53826 53827 53828 53829 53830 53831 53832 53833 53834 53835 53836 53837 53838 53839 53840 53841 53842 53843 53844 53845 53846 53847 53848 53849 53850 53851 53852 53853 53854 53855 53856 53857 53858 53859 53860 53861 53862 53863 53864 53865 53866 53867 53868 53869 53870 53871 53872 53873 53874 53875 53876 53877 53878 53879 53880 53881 53882 53883 53884 53885 53886 53887 53888 53889 53890 53891 53892 53893 53894 53895 53896 53897 53898 53899 53900 53901 53902 53903 53904 53905 53906 53907 53908 53909 53910 53911 53912 53913 53914 53915 53916 53917 53918 53919 53920 53921 53922 53923 53924 53925 53926 53927 53928 53929 53930 53931 53932 53933 53934 53935 53936 53937 53938 53939 53940 53941 53942 53943 53944 53945 53946 53947 53948 53949 53950 53951 53952 53953 53954 53955 53956 53957 53958 53959 53960 53961 53962 53963 53964 53965 53966 53967 53968 53969 53970 53971 53972 53973 53974 53975 53976 53977 53978 53979 53980 53981 53982 53983 53984 53985 53986 53987 53988 53989 53990 53991 53992 53993 53994 53995 53996 53997 53998 53999 54000 54001 54002 54003 54004 54005 54006 54007 54008 54009 54010 54011 54012 54013 54014 54015 54016 54017 54018 54019 54020 54021 54022 54023 54024 54025 54026 54027 54028 54029 54030 54031 54032 54033 54034 54035 54036 54037 54038 54039 54040 54041 54042 54043 54044 54045 54046 54047 54048 54049 54050 54051 54052 54053 54054 54055 54056 54057 54058 54059 54060 54061 54062 54063 54064 54065 54066 54067 54068 54069 54070 54071 54072 54073 54074 54075 54076 54077 54078 54079 54080 54081 54082 54083 54084 54085 54086 54087 54088 54089 54090 54091 54092 54093 54094 54095 54096 54097 54098 54099 54100 54101 54102 54103 54104 54105 54106 54107 54108 54109 54110 54111 54112 54113 54114 54115 54116 54117 54118 54119 54120 54121 54122 54123 54124 54125 54126 54127 54128 54129 54130 54131 54132 54133 54134 54135 54136 54137 54138 54139 54140 54141 54142 54143 54144 54145 54146 54147 54148 54149 54150 54151 54152 54153 54154 54155 54156 54157 54158 54159 54160 54161 54162 54163 54164 54165 54166 54167 54168 54169 54170 54171 54172 54173 54174 54175 54176 54177 54178 54179 54180 54181 54182 54183 54184 54185 54186 54187 54188 54189 54190 54191 54192 54193 54194 54195 54196 54197 54198 54199 54200 54201 54202 54203 54204 54205 54206 54207 54208 54209 54210 54211 54212 54213 54214 54215 54216 54217 54218 54219 54220 54221 54222 54223 54224 54225 54226 54227 54228 54229 54230 54231 54232 54233 54234 54235 54236 54237 54238 54239 54240 54241 54242 54243 54244 54245 54246 54247 54248 54249 54250 54251 54252 54253 54254 54255 54256 54257 54258 54259 54260 54261 54262 54263 54264 54265 54266 54267 54268 54269 54270 54271 54272 54273 54274 54275 54276 54277 54278 54279 54280 54281 54282 54283 54284 54285 54286 54287 54288 54289 54290 54291 54292 54293 54294 54295 54296 54297 54298 54299 54300 54301 54302 54303 54304 54305 54306 54307 54308 54309 54310 54311 54312 54313 54314 54315 54316 54317 54318 54319 54320 54321 54322 54323 54324 54325 54326 54327 54328 54329 54330 54331 54332 54333 54334 54335 54336 54337 54338 54339 54340 54341 54342 54343 54344 54345 54346 54347 54348 54349 54350 54351 54352 54353 54354 54355 54356 54357 54358 54359 54360 54361 54362 54363 54364 54365 54366 54367 54368 54369 54370 54371 54372 54373 54374 54375 54376 54377 54378 54379 54380 54381 54382 54383 54384 54385 54386 54387 54388 54389 54390 54391 54392 54393 54394 54395 54396 54397 54398 54399 54400 54401 54402 54403 54404 54405 54406 54407 54408 54409 54410 54411 54412 54413 54414 54415 54416 54417 54418 54419 54420 54421 54422 54423 54424 54425 54426 54427 54428 54429 54430 54431 54432 54433 54434 54435 54436 54437 54438 54439 54440 54441 54442 54443 54444 54445 54446 54447 54448 54449 54450 54451 54452 54453 54454 54455 54456 54457 54458 54459 54460 54461 54462 54463 54464 54465 54466 54467 54468 54469 54470 54471 54472 54473 54474 54475 54476 54477 54478 54479 54480 54481 54482 54483 54484 54485 54486 54487 54488 54489 54490 54491 54492 54493 54494 54495 54496 54497 54498 54499 54500 54501 54502 54503 54504 54505 54506 54507 54508 54509 54510 54511 54512 54513 54514 54515 54516 54517 54518 54519 54520 54521 54522 54523 54524 54525 54526 54527 54528 54529 54530 54531 54532 54533 54534 54535 54536 54537 54538 54539 54540 54541 54542 54543 54544 54545 54546 54547 54548 54549 54550 54551 54552 54553 54554 54555 54556 54557 54558 54559 54560 54561 54562 54563 54564 54565 54566 54567 54568 54569 54570 54571 54572 54573 54574 54575 54576 54577 54578 54579 54580 54581 54582 54583 54584 54585 54586 54587 54588 54589 54590 54591 54592 54593 54594 54595 54596 54597 54598 54599 54600 54601 54602 54603 54604 54605 54606 54607 54608 54609 54610 54611 54612 54613 54614 54615 54616 54617 54618 54619 54620 54621 54622 54623 54624 54625 54626 54627 54628 54629 54630 54631 54632 54633 54634 54635 54636 54637 54638 54639 54640 54641 54642 54643 54644 54645 54646 54647 54648 54649 54650 54651 54652 54653 54654 54655 54656 54657 54658 54659 54660 54661 54662 54663 54664 54665 54666 54667 54668 54669 54670 54671 54672 54673 54674 54675 54676 54677 54678 54679 54680 54681 54682 54683 54684 54685 54686 54687 54688 54689 54690 54691 54692 54693 54694 54695 54696 54697 54698 54699 54700 54701 54702 54703 54704 54705 54706 54707 54708 54709 54710 54711 54712 54713 54714 54715 54716 54717 54718 54719 54720 54721 54722 54723 54724 54725 54726 54727 54728 54729 54730 54731 54732 54733 54734 54735 54736 54737 54738 54739 54740 54741 54742 54743 54744 54745 54746 54747 54748 54749 54750 54751 54752 54753 54754 54755 54756 54757 54758 54759 54760 54761 54762 54763 54764 54765 54766 54767 54768 54769 54770 54771 54772 54773 54774 54775 54776 54777 54778 54779 54780 54781 54782 54783 54784 54785 54786 54787 54788 54789 54790 54791 54792 54793 54794 54795 54796 54797 54798 54799 54800 54801 54802 54803 54804 54805 54806 54807 54808 54809 54810 54811 54812 54813 54814 54815 54816 54817 54818 54819 54820 54821 54822 54823 54824 54825 54826 54827 54828 54829 54830 54831 54832 54833 54834 54835 54836 54837 54838 54839 54840 54841 54842 54843 54844 54845 54846 54847 54848 54849 54850 54851 54852 54853 54854 54855 54856 54857 54858 54859 54860 54861 54862 54863 54864 54865 54866 54867 54868 54869 54870 54871 54872 54873 54874 54875 54876 54877 54878 54879 54880 54881 54882 54883 54884 54885 54886 54887 54888 54889 54890 54891 54892 54893 54894 54895 54896 54897 54898 54899 54900 54901 54902 54903 54904 54905 54906 54907 54908 54909 54910 54911 54912 54913 54914 54915 54916 54917 54918 54919 54920 54921 54922 54923 54924 54925 54926 54927 54928 54929 54930 54931 54932 54933 54934 54935 54936 54937 54938 54939 54940 54941 54942 54943 54944 54945 54946 54947 54948 54949 54950 54951 54952 54953 54954 54955 54956 54957 54958 54959 54960 54961 54962 54963 54964 54965 54966 54967 54968 54969 54970 54971 54972 54973 54974 54975 54976 54977 54978 54979 54980 54981 54982 54983 54984 54985 54986 54987 54988 54989 54990 54991 54992 54993 54994 54995 54996 54997 54998 54999 55000 55001 55002 55003 55004 55005 55006 55007 55008 55009 55010 55011 55012 55013 55014 55015 55016 55017 55018 55019 55020 55021 55022 55023 55024 55025 55026 55027 55028 55029 55030 55031 55032 55033 55034 55035 55036 55037 55038 55039 55040 55041 55042 55043 55044 55045 55046 55047 55048 55049 55050 55051 55052 55053 55054 55055 55056 55057 55058 55059 55060 55061 55062 55063 55064 55065 55066 55067 55068 55069 55070 55071 55072 55073 55074 55075 55076 55077 55078 55079 55080 55081 55082 55083 55084 55085 55086 55087 55088 55089 55090 55091 55092 55093 55094 55095 55096 55097 55098 55099 55100 55101 55102 55103 55104 55105 55106 55107 55108 55109 55110 55111 55112 55113 55114 55115 55116 55117 55118 55119 55120 55121 55122 55123 55124 55125 55126 55127 55128 55129 55130 55131 55132 55133 55134 55135 55136 55137 55138 55139 55140 55141 55142 55143 55144 55145 55146 55147 55148 55149 55150 55151 55152 55153 55154 55155 55156 55157 55158 55159 55160 55161 55162 55163 55164 55165 55166 55167 55168 55169 55170 55171 55172 55173 55174 55175 55176 55177 55178 55179 55180 55181 55182 55183 55184 55185 55186 55187 55188 55189 55190 55191 55192 55193 55194 55195 55196 55197 55198 55199 55200 55201 55202 55203 55204 55205 55206 55207 55208 55209 55210 55211 55212 55213 55214 55215 55216 55217 55218 55219 55220 55221 55222 55223 55224 55225 55226 55227 55228 55229 55230 55231 55232 55233 55234 55235 55236 55237 55238 55239 55240 55241 55242 55243 55244 55245 55246 55247 55248 55249 55250 55251 55252 55253 55254 55255 55256 55257 55258 55259 55260 55261 55262 55263 55264 55265 55266 55267 55268 55269 55270 55271 55272 55273 55274 55275 55276 55277 55278 55279 55280 55281 55282 55283 55284 55285 55286 55287 55288 55289 55290 55291 55292 55293 55294 55295 55296 55297 55298 55299 55300 55301 55302 55303 55304 55305 55306 55307 55308 55309 55310 55311 55312 55313 55314 55315 55316 55317 55318 55319 55320 55321 55322 55323 55324 55325 55326 55327 55328 55329 55330 55331 55332 55333 55334 55335 55336 55337 55338 55339 55340 55341 55342 55343 55344 55345 55346 55347 55348 55349 55350 55351 55352 55353 55354 55355 55356 55357 55358 55359 55360 55361 55362 55363 55364 55365 55366 55367 55368 55369 55370 55371 55372 55373 55374 55375 55376 55377 55378 55379 55380 55381 55382 55383 55384 55385 55386 55387 55388 55389 55390 55391 55392 55393 55394 55395 55396 55397 55398 55399 55400 55401 55402 55403 55404 55405 55406 55407 55408 55409 55410 55411 55412 55413 55414 55415 55416 55417 55418 55419 55420 55421 55422 55423 55424 55425 55426 55427 55428 55429 55430 55431 55432 55433 55434 55435 55436 55437 55438 55439 55440 55441 55442 55443 55444 55445 55446 55447 55448 55449 55450 55451 55452 55453 55454 55455 55456 55457 55458 55459 55460 55461 55462 55463 55464 55465 55466 55467 55468 55469 55470 55471 55472 55473 55474 55475 55476 55477 55478 55479 55480 55481 55482 55483 55484 55485 55486 55487 55488 55489 55490 55491 55492 55493 55494 55495 55496 55497 55498 55499 55500 55501 55502 55503 55504 55505 55506 55507 55508 55509 55510 55511 55512 55513 55514 55515 55516 55517 55518 55519 55520 55521 55522 55523 55524 55525 55526 55527 55528 55529 55530 55531 55532 55533 55534 55535 55536 55537 55538 55539 55540 55541 55542 55543 55544 55545 55546 55547 55548 55549 55550 55551 55552 55553 55554 55555 55556 55557 55558 55559 55560 55561 55562 55563 55564 55565 55566 55567 55568 55569 55570 55571 55572 55573 55574 55575 55576 55577 55578 55579 55580 55581 55582 55583 55584 55585 55586 55587 55588 55589 55590 55591 55592 55593 55594 55595 55596 55597 55598 55599 55600 55601 55602 55603 55604 55605 55606 55607 55608 55609 55610 55611 55612 55613 55614 55615 55616 55617 55618 55619 55620 55621 55622 55623 55624 55625 55626 55627 55628 55629 55630 55631 55632 55633 55634 55635 55636 55637 55638 55639 55640 55641 55642 55643 55644 55645 55646 55647 55648 55649 55650 55651 55652 55653 55654 55655 55656 55657 55658 55659 55660 55661 55662 55663 55664 55665 55666 55667 55668 55669 55670 55671 55672 55673 55674 55675 55676 55677 55678 55679 55680 55681 55682 55683 55684 55685 55686 55687 55688 55689 55690 55691 55692 55693 55694 55695 55696 55697 55698 55699 55700 55701 55702 55703 55704 55705 55706 55707 55708 55709 55710 55711 55712 55713 55714 55715 55716 55717 55718 55719 55720 55721 55722 55723 55724 55725 55726 55727 55728 55729 55730 55731 55732 55733 55734 55735 55736 55737 55738 55739 55740 55741 55742 55743 55744 55745 55746 55747 55748 55749 55750 55751 55752 55753 55754 55755 55756 55757 55758 55759 55760 55761 55762 55763 55764 55765 55766 55767 55768 55769 55770 55771 55772 55773 55774 55775 55776 55777 55778 55779 55780 55781 55782 55783 55784 55785 55786 55787 55788 55789 55790 55791 55792 55793 55794 55795 55796 55797 55798 55799 55800 55801 55802 55803 55804 55805 55806 55807 55808 55809 55810 55811 55812 55813 55814 55815 55816 55817 55818 55819 55820 55821 55822 55823 55824 55825 55826 55827 55828 55829 55830 55831 55832 55833 55834 55835 55836 55837 55838 55839 55840 55841 55842 55843 55844 55845 55846 55847 55848 55849 55850 55851 55852 55853 55854 55855 55856 55857 55858 55859 55860 55861 55862 55863 55864 55865 55866 55867 55868 55869 55870 55871 55872 55873 55874 55875 55876 55877 55878 55879 55880 55881 55882 55883 55884 55885 55886 55887 55888 55889 55890 55891 55892 55893 55894 55895 55896 55897 55898 55899 55900 55901 55902 55903 55904 55905 55906 55907 55908 55909 55910 55911 55912 55913 55914 55915 55916 55917 55918 55919 55920 55921 55922 55923 55924 55925 55926 55927 55928 55929 55930 55931 55932 55933 55934 55935 55936 55937 55938 55939 55940 55941 55942 55943 55944 55945 55946 55947 55948 55949 55950 55951 55952 55953 55954 55955 55956 55957 55958 55959 55960 55961 55962 55963 55964 55965 55966 55967 55968 55969 55970 55971 55972 55973 55974 55975 55976 55977 55978 55979 55980 55981 55982 55983 55984 55985 55986 55987 55988 55989 55990 55991 55992 55993 55994 55995 55996 55997 55998 55999 56000 56001 56002 56003 56004 56005 56006 56007 56008 56009 56010 56011 56012 56013 56014 56015 56016 56017 56018 56019 56020 56021 56022 56023 56024 56025 56026 56027 56028 56029 56030 56031 56032 56033 56034 56035 56036 56037 56038 56039 56040 56041 56042 56043 56044 56045 56046 56047 56048 56049 56050 56051 56052 56053 56054 56055 56056 56057 56058 56059 56060 56061 56062 56063 56064 56065 56066 56067 56068 56069 56070 56071 56072 56073 56074 56075 56076 56077 56078 56079 56080 56081 56082 56083 56084 56085 56086 56087 56088 56089 56090 56091 56092 56093 56094 56095 56096 56097 56098 56099 56100 56101 56102 56103 56104 56105 56106 56107 56108 56109 56110 56111 56112 56113 56114 56115 56116 56117 56118 56119 56120 56121 56122 56123 56124 56125 56126 56127 56128 56129 56130 56131 56132 56133 56134 56135 56136 56137 56138 56139 56140 56141 56142 56143 56144 56145 56146 56147 56148 56149 56150 56151 56152 56153 56154 56155 56156 56157 56158 56159 56160 56161 56162 56163 56164 56165 56166 56167 56168 56169 56170 56171 56172 56173 56174 56175 56176 56177 56178 56179 56180 56181 56182 56183 56184 56185 56186 56187 56188 56189 56190 56191 56192 56193 56194 56195 56196 56197 56198 56199 56200 56201 56202 56203 56204 56205 56206 56207 56208 56209 56210 56211 56212 56213 56214 56215 56216 56217 56218 56219 56220 56221 56222 56223 56224 56225 56226 56227 56228 56229 56230 56231 56232 56233 56234 56235 56236 56237 56238 56239 56240 56241 56242 56243 56244 56245 56246 56247 56248 56249 56250 56251 56252 56253 56254 56255 56256 56257 56258 56259 56260 56261 56262 56263 56264 56265 56266 56267 56268 56269 56270 56271 56272 56273 56274 56275 56276 56277 56278 56279 56280 56281 56282 56283 56284 56285 56286 56287 56288 56289 56290 56291 56292 56293 56294 56295 56296 56297 56298 56299 56300 56301 56302 56303 56304 56305 56306 56307 56308 56309 56310 56311 56312 56313 56314 56315 56316 56317 56318 56319 56320 56321 56322 56323 56324 56325 56326 56327 56328 56329 56330 56331 56332 56333 56334 56335 56336 56337 56338 56339 56340 56341 56342 56343 56344 56345 56346 56347 56348 56349 56350 56351 56352 56353 56354 56355 56356 56357 56358 56359 56360 56361 56362 56363 56364 56365 56366 56367 56368 56369 56370 56371 56372 56373 56374 56375 56376 56377 56378 56379 56380 56381 56382 56383 56384 56385 56386 56387 56388 56389 56390 56391 56392 56393 56394 56395 56396 56397 56398 56399 56400 56401 56402 56403 56404 56405 56406 56407 56408 56409 56410 56411 56412 56413 56414 56415 56416 56417 56418 56419 56420 56421 56422 56423 56424 56425 56426 56427 56428 56429 56430 56431 56432 56433 56434 56435 56436 56437 56438 56439 56440 56441 56442 56443 56444 56445 56446 56447 56448 56449 56450 56451 56452 56453 56454 56455 56456 56457 56458 56459 56460 56461 56462 56463 56464 56465 56466 56467 56468 56469 56470 56471 56472 56473 56474 56475 56476 56477 56478 56479 56480 56481 56482 56483 56484 56485 56486 56487 56488 56489 56490 56491 56492 56493 56494 56495 56496 56497 56498 56499 56500 56501 56502 56503 56504 56505 56506 56507 56508 56509 56510 56511 56512 56513 56514 56515 56516 56517 56518 56519 56520 56521 56522 56523 56524 56525 56526 56527 56528 56529 56530 56531 56532 56533 56534 56535 56536 56537 56538 56539 56540 56541 56542 56543 56544 56545 56546 56547 56548 56549 56550 56551 56552 56553 56554 56555 56556 56557 56558 56559 56560 56561 56562 56563 56564 56565 56566 56567 56568 56569 56570 56571 56572 56573 56574 56575 56576 56577 56578 56579 56580 56581 56582 56583 56584 56585 56586 56587 56588 56589 56590 56591 56592 56593 56594 56595 56596 56597 56598 56599 56600 56601 56602 56603 56604 56605 56606 56607 56608 56609 56610 56611 56612 56613 56614 56615 56616 56617 56618 56619 56620 56621 56622 56623 56624 56625 56626 56627 56628 56629 56630 56631 56632 56633 56634 56635 56636 56637 56638 56639 56640 56641 56642 56643 56644 56645 56646 56647 56648 56649 56650 56651 56652 56653 56654 56655 56656 56657 56658 56659 56660 56661 56662 56663 56664 56665 56666 56667 56668 56669 56670 56671 56672 56673 56674 56675 56676 56677 56678 56679 56680 56681 56682 56683 56684 56685 56686 56687 56688 56689 56690 56691 56692 56693 56694 56695 56696 56697 56698 56699 56700 56701 56702 56703 56704 56705 56706 56707 56708 56709 56710 56711 56712 56713 56714 56715 56716 56717 56718 56719 56720 56721 56722 56723 56724 56725 56726 56727 56728 56729 56730 56731 56732 56733 56734 56735 56736 56737 56738 56739 56740 56741 56742 56743 56744 56745 56746 56747 56748 56749 56750 56751 56752 56753 56754 56755 56756 56757 56758 56759 56760 56761 56762 56763 56764 56765 56766 56767 56768 56769 56770 56771 56772 56773 56774 56775 56776 56777 56778 56779 56780 56781 56782 56783 56784 56785 56786 56787 56788 56789 56790 56791 56792 56793 56794 56795 56796 56797 56798 56799 56800 56801 56802 56803 56804 56805 56806 56807 56808 56809 56810 56811 56812 56813 56814 56815 56816 56817 56818 56819 56820 56821 56822 56823 56824 56825 56826 56827 56828 56829 56830 56831 56832 56833 56834 56835 56836 56837 56838 56839 56840 56841 56842 56843 56844 56845 56846 56847 56848 56849 56850 56851 56852 56853 56854 56855 56856 56857 56858 56859 56860 56861 56862 56863 56864 56865 56866 56867 56868 56869 56870 56871 56872 56873 56874 56875 56876 56877 56878 56879 56880 56881 56882 56883 56884 56885 56886 56887 56888 56889 56890 56891 56892 56893 56894 56895 56896 56897 56898 56899 56900 56901 56902 56903 56904 56905 56906 56907 56908 56909 56910 56911 56912 56913 56914 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56929 56930 56931 56932 56933 56934 56935 56936 56937 56938 56939 56940 56941 56942 56943 56944 56945 56946 56947 56948 56949 56950 56951 56952 56953 56954 56955 56956 56957 56958 56959 56960 56961 56962 56963 56964 56965 56966 56967 56968 56969 56970 56971 56972 56973 56974 56975 56976 56977 56978 56979 56980 56981 56982 56983 56984 56985 56986 56987 56988 56989 56990 56991 56992 56993 56994 56995 56996 56997 56998
|
2012-04-05 Oliver Hunt <oliver@apple.com>
SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496
Reviewed by Gavin Barraclough.
Don't attempt to use the DFG when SSE2 is not available.
* dfg/DFGCapabilities.cpp:
(JSC::DFG::canCompileOpcodes):
2012-03-23 Gavin Barraclough <barraclough@apple.com>
REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989
Reviewed by Oliver Hunt.
Patch originally by chris reiss <christopher.reiss@nokia.com>,
allow the year to appear before the timezone in date strings.
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
2012-03-23 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Unreviewed. Build fix for linux-bot (qt) after r109021.
* runtime/Error.cpp:
2012-03-23 Oliver Hunt <oliver@apple.com>
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=79693
Reviewed by Filip Pizlo.
Alas we can't provide the stack trace as an array, as despite everyone wanting
an array, everyone arbitrarily creates the array by calling split on the stack
trace. To create the array we would have provided them in the first place.
This changes the exception's stack property to a \n separated string. To get the
old array just do <exception>.stack.split("\n").
* runtime/Error.cpp:
(JSC::addErrorInfo):
2012-03-05 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Add GMainLoop and GMainContext to be handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=79496
Reviewed by Martin Robinson.
Handle GMainLoop and GMainContext in GRefPtr, by calling
g_main_loop_(un)ref and g_main_context_(un)ref in the
implementation of the refGPtr and derefGPtr template functions.
* wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):
* wtf/gobject/GRefPtr.h:
(WTF):
* wtf/gobject/GTypedefs.h:
2012-03-04 Jurij Smakov <jurij@wooyd.org>
SPARC also needs aligned accesses.
Rubber-stamped by Gustavo Noronha Silva.
* wtf/Platform.h:
2012-02-21 Gustavo Noronha Silva <kov@debian.org> and Bob Tracy <rct@frus.com>
Does not build on IA64, SPARC and Alpha
https://bugs.webkit.org/show_bug.cgi?id=79047
Rubber-stamped by Kent Tamura.
* wtf/dtoa/utils.h: these architectures also have correct double
operations, so add them to the appropriate side of the check.
2012-02-20 Pino Toscano <pino@debian.org>
Does not build on GNU Hurd
https://bugs.webkit.org/show_bug.cgi?id=79045
Reviewed by Gustavo Noronha Silva.
* wtf/Platform.h: define WTF_OS_HURD.
* wtf/ThreadIdentifierDataPthreads.cpp: adds a band-aid fix
for the lack of PTHREAD_KEYS_MAX definition, with a value which
should not cause issues.
2012-02-19 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck issues.
* GNUmakefile.list.am: Add missing files.
2012-02-18 Sam Weinig <sam@webkit.org>
Fix style issues in DFG Phase classes
https://bugs.webkit.org/show_bug.cgi?id=78983
Reviewed by Ryosuke Niwa.
* dfg/DFGArithNodeFlagsInferencePhase.cpp:
* dfg/DFGCFAPhase.cpp:
* dfg/DFGCSEPhase.cpp:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
Add a space before the colon in class declarations.
2012-02-18 Filip Pizlo <fpizlo@apple.com>
Attempt to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-02-18 Sam Weinig <sam@webkit.org>
Fix the libc++ build.
Reviewed by Anders Carlsson.
* heap/Weak.h:
Libc++'s nullptr emulation does not allow default construction
of the nullptr_t type. Work around this with the arguably clearer
just returning nullptr.
2012-02-18 Filip Pizlo <fpizlo@apple.com>
DFGPropagator.cpp has too many things
https://bugs.webkit.org/show_bug.cgi?id=78956
Reviewed by Oliver Hunt.
Added the notion of a DFG::Phase. Removed DFG::Propagator, and took its
various things and put them into separate files. These new phases follow
the naming convention "DFG<name>Phase" where <name> is a noun. They are
called via functions of the form "perform<name>".
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGArithNodeFlagsInferencePhase.cpp: Added.
(DFG):
(JSC::DFG::performArithNodeFlagsInference):
* dfg/DFGArithNodeFlagsInferencePhase.h: Added.
(DFG):
* dfg/DFGCFAPhase.cpp: Added.
(DFG):
(JSC::DFG::performCFA):
* dfg/DFGCFAPhase.h: Added.
(DFG):
* dfg/DFGCSEPhase.cpp: Added.
(DFG):
(JSC::DFG::performCSE):
* dfg/DFGCSEPhase.h: Added.
(DFG):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGPhase.cpp: Added.
(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
* dfg/DFGPhase.h: Added.
(DFG):
(Phase):
(JSC::DFG::Phase::Phase):
(JSC::DFG::Phase::~Phase):
(JSC::DFG::Phase::globalData):
(JSC::DFG::Phase::codeBlock):
(JSC::DFG::Phase::profiledBlock):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
(JSC::DFG::runPhase):
* dfg/DFGPredictionPropagationPhase.cpp: Added.
(DFG):
(JSC::DFG::performPredictionPropagation):
* dfg/DFGPredictionPropagationPhase.h: Added.
(DFG):
* dfg/DFGPropagator.cpp: Removed.
* dfg/DFGPropagator.h: Removed.
* dfg/DFGVirtualRegisterAllocationPhase.cpp: Added.
(DFG):
(JSC::DFG::performVirtualRegisterAllocation):
* dfg/DFGVirtualRegisterAllocationPhase.h: Added.
(DFG):
2012-02-17 Filip Pizlo <fpizlo@apple.com>
DFG::Graph should have references to JSGlobalData, the CodeBlock being compiled, and
the CodeBlock that was used for profiling
https://bugs.webkit.org/show_bug.cgi?id=78954
Reviewed by Gavin Barraclough.
* bytecode/CodeBlock.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::execute):
* dfg/DFGAbstractState.h:
* dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::parse):
* dfg/DFGByteCodeParser.h:
(DFG):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(Graph):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::globalCFA):
(JSC::DFG::propagate):
* dfg/DFGPropagator.h:
(DFG):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
2012-02-17 Ahmad Sharif <asharif.tools@gmail.com>
There is a warning in memset in glibc that gets triggered through a
warndecl when the fill-value of memset is a non-zero constant and the
size is zero. This warning is enabled when building with
-D_FORTIFY_SOURCE=2. This patch fixes the warning.
https://bugs.webkit.org/show_bug.cgi?id=78513
Reviewed by Alexey Proskuryakov
* wtf/Vector.h:
2012-02-17 Kalev Lember <kalevlember@gmail.com>
Remove unused parameters from WTF threading API
https://bugs.webkit.org/show_bug.cgi?id=78389
Reviewed by Adam Roben.
waitForThreadCompletion() had an out param 'void **result' to get the
'void *' returned by ThreadFunction. However, the implementation in
ThreadingWin.cpp ignored the out param, not filling it in. This had
led to a situation where none of the client code made use of the param
and just ignored it.
To clean this up, the patch changes the signature of ThreadFunction to
return void instead of void* and drops the the unused 'void **result'
parameter from waitForThreadCompletion. Also, all client code is
updated for the API change.
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=78389 , even
though the change only affects internal API, Safari is using it
directly and we'll need to keep the old versions around for ABI
compatibility. For this, the patch adds compatibility wrappers with
the old ABI.
* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/SamplingTool.cpp:
(JSC::SamplingThread::threadStartFunc):
(JSC::SamplingThread::stop):
* bytecode/SamplingTool.h:
(SamplingThread):
* heap/Heap.cpp:
(JSC::Heap::~Heap):
(JSC::Heap::blockFreeingThreadStartFunc):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
* heap/MarkStack.h:
(MarkStackThreadSharedData):
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):
* wtf/ParallelJobsGeneric.h:
(ThreadPrivate):
* wtf/ThreadFunctionInvocation.h: Update the signature of
ThreadFunction.
(WTF):
* wtf/Threading.cpp:
(WTF::threadEntryPoint): Update for ThreadFunction signature change.
(WTF):
(WTF::ThreadFunctionWithReturnValueInvocation::ThreadFunctionWithReturnValueInvocation):
ABI compatibility function for Safari.
(ThreadFunctionWithReturnValueInvocation): Ditto.
(WTF::compatEntryPoint): Ditto.
(WTF::createThread): Ditto.
(WTF::waitForThreadCompletion): Ditto.
* wtf/Threading.h: Update the signature of ThreadFunction and
waitForThreadCompletion.
(WTF):
* wtf/ThreadingPthreads.cpp: Implement the new API.
(WTF::wtfThreadEntryPoint):
(WTF):
(WTF::createThreadInternal):
(WTF::waitForThreadCompletion):
* wtf/ThreadingWin.cpp: Implement the new API.
(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion):
2012-02-16 Oliver Hunt <oliver@apple.com>
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Reviewed by Gavin Barraclough.
Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.
* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):
2012-02-17 Mark Hahnenberg <mhahnenberg@apple.com>
Rename Bump* to Copy*
https://bugs.webkit.org/show_bug.cgi?id=78573
Reviewed by Geoffrey Garen.
Renamed anything with "Bump" in the name to have "Copied" instead.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/BumpBlock.h: Removed.
* heap/BumpSpace.cpp: Removed.
* heap/BumpSpace.h: Removed.
* heap/BumpSpaceInlineMethods.h: Removed.
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):
* heap/ConservativeRoots.h:
(ConservativeRoots):
* heap/CopiedBlock.h: Added.
(JSC):
(CopiedBlock):
(JSC::CopiedBlock::CopiedBlock):
* heap/CopiedSpace.cpp: Added.
(JSC):
(JSC::CopiedSpace::tryAllocateSlowCase):
* heap/CopiedSpace.h: Added.
(JSC):
(CopiedSpace):
(JSC::CopiedSpace::isInCopyPhase):
(JSC::CopiedSpace::totalMemoryAllocated):
(JSC::CopiedSpace::totalMemoryUtilized):
* heap/CopiedSpaceInlineMethods.h: Added.
(JSC):
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::pin):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::recycleBlock):
(JSC::CopiedSpace::getFreshBlock):
(JSC::CopiedSpace::borrowBlock):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::fitsInCurrentBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::allocateFromBlock):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::isOversize):
(JSC::CopiedSpace::isPinned):
(JSC::CopiedSpace::oversizeBlockFor):
(JSC::CopiedSpace::blockFor):
* heap/Heap.cpp:
* heap/Heap.h:
(JSC):
(Heap):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):
* heap/MarkStack.h:
(MarkStackThreadSharedData):
* heap/SlotVisitor.h:
(SlotVisitor):
* runtime/JSArray.cpp:
* runtime/JSObject.cpp:
2012-02-16 Yuqiang Xian <yuqiang.xian@intel.com>
Add JSC code profiling support on Linux x86
https://bugs.webkit.org/show_bug.cgi?id=78871
Reviewed by Gavin Barraclough.
We don't unwind the stack for now as we cannot guarantee all the
libraries are compiled without -fomit-frame-pointer.
* tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
* tools/CodeProfiling.cpp:
(JSC):
(JSC::profilingTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):
2012-02-16 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed. Rolling out r107980, because it broke 32 bit platforms.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):
2012-02-16 Filip Pizlo <fpizlo@apple.com>
ENABLE_INTERPRETER should be ENABLE_CLASSIC_INTERPRETER
https://bugs.webkit.org/show_bug.cgi?id=78791
Rubber stamped by Oliver Hunt.
Just a renaming, nothing more. Also renamed COMPUTED_GOTO_INTERPRETER to
COMPUTED_GOTO_CLASSIC_INTERPRETER.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/AbstractPC.h:
(AbstractPC):
* interpreter/CallFrame.h:
(ExecState):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(Interpreter):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(NativeExecutable):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSGlobalData):
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/Platform.h:
2012-02-15 Geoffrey Garen <ggaren@apple.com>
Made Weak<T> single-owner, adding PassWeak<T>
https://bugs.webkit.org/show_bug.cgi?id=78740
Reviewed by Sam Weinig.
This works basically the same way as OwnPtr<T> and PassOwnPtr<T>.
This clarifies the semantics of finalizers: It's ambiguous and probably
a bug to copy a finalizer (i.e., it's a bug to run a C++ destructor
twice), so I've made Weak<T> non-copyable. Anywhere we used to copy a
Weak<T>, we now use PassWeak<T>.
This also makes Weak<T> HashMaps more efficient.
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype): Use PassWeak<T> instead of set(), since
set() is gone now.
* JavaScriptCore.xcodeproj/project.pbxproj: Export!
* heap/PassWeak.h: Added.
(JSC):
(PassWeak):
(JSC::PassWeak::PassWeak):
(JSC::PassWeak::~PassWeak):
(JSC::PassWeak::get):
(JSC::::leakHandle):
(JSC::adoptWeak):
(JSC::operator==):
(JSC::operator!=): This is the Weak<T> version of PassOwnPtr<T>.
* heap/Weak.h:
(Weak):
(JSC::Weak::Weak):
(JSC::Weak::release):
(JSC::Weak::hashTableDeletedValue):
(JSC::=):
(JSC): Changed to be non-copyable, removing a lot of copying-related
APIs. Added hash traits so hash maps still work.
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate): Use PassWeak<T>, as required by
our new hash map API.
2012-02-16 Mark Hahnenberg <mhahnenberg@apple.com>
Fix the broken viewport tests
https://bugs.webkit.org/show_bug.cgi?id=78774
Reviewed by Kenneth Rohde Christiansen.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.cpp:
(WTF):
(WTF::toDoubleType): Template-ized to allow other functions to specify whether they
want to allow trailing junk or not when calling strtod.
(WTF::charactersToDouble):
(WTF::charactersToFloat):
(WTF::charactersToFloatIgnoringJunk): Created new version of charactersToFloat that allows
trailing junk.
* wtf/text/WTFString.h:
(WTF):
2012-02-16 Oliver Hunt <oliver@apple.com>
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Reviewed by Gavin Barraclough.
Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.
* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):
2012-02-15 Gavin Barraclough <barraclough@apple.com>
Numerous trivial bugs in Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=78777
Reviewed by Sam Weinig.
There are a handful of really trivial bugs, related to Object.defineProperty:
* Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
* Calling an undefined setter should only throw in strict mode.
* When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
* Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
* Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
* If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
* 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
* Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
* Should be able to define an non-configurable accessor.
These are mostly all one-line changes, e.g. inverted boolean checks, masking against wrong attribute.
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
- Added ASSERT.
- Calling an undefined setter should only throw in strict mode.
(JSC::JSArray::putDescriptor):
- Should be able to define an non-configurable accessor.
(JSC::JSArray::defineOwnNumericProperty):
- Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
(JSC::JSArray::putByIndexBeyondVectorLength):
- If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
* runtime/JSArray.h:
(JSArray):
- made enterDictionaryMode public, called from JSObject.
* runtime/JSObject.cpp:
(JSC::JSObject::put):
- Calling an undefined setter should only throw in strict mode.
(JSC::JSObject::preventExtensions):
- Put array objects into dictionary mode to handle this!
(JSC::JSObject::defineOwnProperty):
- Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
- Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperties):
- Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesWithOverride):
- When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
(JSC::PropertyDescriptor::attributesOverridingCurrent):
- When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
* runtime/Structure.cpp:
(JSC::Structure::freezeTransition):
- 'freezeTransition' shouldn't be setting the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
(JSC::Structure::isFrozen):
- 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
2012-02-13 Filip Pizlo <fpizlo@apple.com>
DFG should not check the types of arguments that are dead
https://bugs.webkit.org/show_bug.cgi?id=78518
Reviewed by Geoff Garen.
The argument checks are now elided if the corresponding SetArgument is dead,
and the abstract value of the argument is set to bottom (None, []). This is
performance neutral on the benchmarks we currently track.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
2012-02-15 Oliver Hunt <oliver@apple.com>
Ensure that the DFG JIT always plants a CodeOrigin when making calls
https://bugs.webkit.org/show_bug.cgi?id=78763
Reviewed by Gavin Barraclough.
Make all calls plant a CodeOrigin prior to the actual
call. Also clobbers the Interpreter with logic to ensure
that the interpreter always plants a bytecode offset.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(CallBeginToken):
(JSC::DFG::JITCompiler::beginJSCall):
(JSC::DFG::JITCompiler::beginCall):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(ExecState):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::codeOriginIndexForDFG):
2012-02-14 Oliver Hunt <oliver@apple.com>
Fix Interpreter.
* runtime/Executable.cpp:
(JSC):
* runtime/Executable.h:
(ExecutableBase):
2012-02-14 Matt Lilek <mrl@apple.com>
Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=78629
Reviewed by David Kilzer.
* Configurations/FeatureDefines.xcconfig:
2012-02-14 Filip Pizlo <fpizlo@apple.com>
Unreviewed, build fix for non-DFG platforms.
* assembler/MacroAssembler.h:
(MacroAssembler):
2012-02-14 Filip Pizlo <fpizlo@apple.com>
Unreviewed, fix build and configuration goof.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::invert):
* dfg/DFGCommon.h:
2012-02-13 Filip Pizlo <fpizlo@apple.com>
DFG should be able to emit code on control flow edges
https://bugs.webkit.org/show_bug.cgi?id=78515
Reviewed by Gavin Barraclough.
This gets us a few steps closer to being able to perform global register allocation,
by allowing us to have landing pads on control flow edges. This will let us reshuffle
registers if it happens to be necessary due to different reg alloc decisions in
differen blocks.
This also introduces the notion of a landing pad for OSR entry, which will allow us
to emit code that places data into registers when we're entering into the DFG from
the old JIT.
Finally, this patch introduces a verification mode that checks that the landing pads
are actually emitted and do actually work as advertised. When verification is disabled,
this has no effect on behavior.
* assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::invert):
(JSC::MacroAssembler::isInvertible):
* dfg/DFGCommon.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(DFG):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::haveEdgeCodeToEmit):
(JSC::DFG::SpeculativeJIT::emitEdgeCode):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
2012-02-14 Filip Pizlo <fpizlo@apple.com>
Assertion failure under JSC::DFG::AbstractState::execute loading economist.com
https://bugs.webkit.org/show_bug.cgi?id=78153
<rdar://problem/10861712> <rdar://problem/10861947>
Reviewed by Oliver Hunt.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
2012-02-14 Eric Seidel <eric@webkit.org>
Upstream Android's additions to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=78536
Reviewed by Adam Barth.
* wtf/Platform.h:
2012-02-12 Mark Hahnenberg <mhahnenberg@apple.com>
Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044
Reviewed by Geoffrey Garen.
* parser/Lexer.cpp: Added template argument. This version allows junk after numbers.
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp: Ditto.
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
* runtime/LiteralParser.cpp: Ditto.
(JSC::::Lexer::lexNumber):
* wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.
It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):
* wtf/dtoa.h:
(WTF):
* wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.
(WTF::toDoubleType):
2012-02-13 Mark Hahnenberg <mhahnenberg@apple.com>
More windows build fixing
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-02-13 Oliver Hunt <oliver@apple.com>
Executing out of bounds in JSC::Yarr::YarrCodeBlock::execute / JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=76315
Reviewed by Gavin Barraclough.
Perform a 3 byte compare using two comparisons, rather than trying to perform the
operation with a four byte load.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
2012-02-13 Mark Hahnenberg <mhahnenberg@apple.com>
Windows build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-02-12 Mark Hahnenberg <mhahnenberg@apple.com>
Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044
Reviewed by Geoffrey Garen.
* parser/Lexer.cpp: Added template argument. This version allows junk after numbers.
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp: Ditto.
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
* runtime/LiteralParser.cpp: Ditto.
(JSC::::Lexer::lexNumber):
* wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.
It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):
* wtf/dtoa.h:
(WTF):
* wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.
(WTF::toDoubleType):
2012-02-13 Sam Weinig <sam@webkit.org>
Move JSC related assertions out of Assertions.h and into their own header
https://bugs.webkit.org/show_bug.cgi?id=78508
Reviewed by Gavin Barraclough.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Add GCAssertions.h
* heap/GCAssertions.h: Added.
Move assertions here.
* runtime/WriteBarrier.h:
Add #include of GCAssertions.h
* wtf/Assertions.h:
Remove JSC related assertions.
* wtf/Compiler.h:
Add compiler check for __has_trivial_destructor.
2012-02-13 Chao-ying Fu <fu@mips.com>
Update MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=78392
Reviewed by Gavin Barraclough.
* jit/JIT.h:
(JIT):
2012-02-13 Patrick Gansterer <paroga@webkit.org>
Remove obsolete #if from ThreadSpecific.h
https://bugs.webkit.org/show_bug.cgi?id=78485
Reviewed by Adam Roben.
Since alle platform use either pthread or Win32 for threading,
we can remove all PLATFORM() preprocessor statements.
* wtf/ThreadSpecific.h:
(ThreadSpecific):
2012-02-13 Jessie Berlin <jberlin@apple.com>
Fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-02-13 Sam Weinig <sam@webkit.org>
Use C11's _Static_assert for COMPILE_ASSERT if it is available
https://bugs.webkit.org/show_bug.cgi?id=78506
Rubber-stamped by Antti Koivisto.
Use C11's _Static_assert for COMPILE_ASSERT if it is available to give slightly
better error messages.
* wtf/Assertions.h:
Use _Static_assert if it is available.
* wtf/Compiler.h:
Add COMPILER_SUPPORTS support for _Static_assert when using the LLVM Compiler.
2012-02-13 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Add GSList to the list of GObject types in GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=78487
Reviewed by Philippe Normand.
Handle the GSList type in GOwnPtr, by calling g_slist_free in the
implementation of the freeOwnedGPtr template function.
* wtf/gobject/GOwnPtr.cpp:
(WTF::GSList):
(WTF):
* wtf/gobject/GOwnPtr.h:
(WTF):
* wtf/gobject/GTypedefs.h:
2012-02-06 Raphael Kubo da Costa <kubo@profusion.mobi>
[EFL] Drop support for the Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=77874
Reviewed by Eric Seidel.
Nobody seems to be maintaining the Curl backend in WebCore, the
EFL port developers all seem to be using the Soup backend and the
port itself has many features which are only implemented for the
latter.
* wtf/PlatformEfl.cmake: Always build the gobject-dependent source
files.
2012-02-13 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for !ENABLE(JIT) after r107485.
* bytecode/PolymorphicPutByIdList.cpp:
2012-02-13 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=78434
Unreviewed - temporarily reverting r107498 will I fix a couple of testcases.
* parser/Parser.cpp:
(JSC::::parseFunctionInfo):
* runtime/ClassInfo.h:
(MethodTable):
(JSC):
* runtime/JSCell.cpp:
(JSC):
* runtime/JSCell.h:
(JSCell):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC):
* runtime/JSGlobalObjectFunctions.h:
(JSC):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSValue::get):
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSValue.h:
(JSValue):
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::setHasGetterSetterProperties):
(Structure):
2012-02-12 Ashod Nakashian <ashodnakashian@yahoo.com>
KeywordLookupGenerator.py script fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=77886
Reviewed by Benjamin Poulain.
* parser/Keywords.table: Converted to LF-only.
2012-02-12 Shinya Kawanaka <shinyak@google.com>
Introduce ShadowRootList.
https://bugs.webkit.org/show_bug.cgi?id=78069
Reviewed by Hajime Morita.
DoublyLinkedList should have tail() method to take the last element.
* wtf/DoublyLinkedList.h:
(DoublyLinkedList):
(WTF::::tail):
(WTF):
2012-02-12 Raphael Kubo da Costa <kubo@profusion.mobi>
[CMake] Move source files in WTF_HEADERS to WTF_SOURCES.
https://bugs.webkit.org/show_bug.cgi?id=78436
Reviewed by Daniel Bates.
* wtf/CMakeLists.txt: Move .cpp files from WTF_HEADERS to WTF_SOURCES,
and correctly sort the files which start with 'M'.
2012-02-12 Sam Weinig <sam@webkit.org>
Move the NumberOfCores.h/cpp files into the WTF group of JavaScriptCore.xcodeproj.
Rubber-stamped by Anders Carlsson.
* JavaScriptCore.xcodeproj/project.pbxproj:
2012-02-12 Raphael Kubo da Costa <kubo@profusion.mobi>
[CMake] Remove unused or empty variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=78437
Reviewed by Daniel Bates.
* CMakeLists.txt: Remove unused JavaScriptCore_HEADERS definition.
* shell/CMakeLists.txt: Remove unused JSC_HEADERS definition.
* wtf/CMakeLists.txt: Remove empty WTF_LIBRARIES definition, it will
be defined later by Platform*.cmake via LIST(APPEND WTF_LIBRARIES).
2012-02-12 Filip Pizlo <fpizlo@apple.com>
DFG::SpeculativeJIT calls fprintf() instead of dataLog in terminateSpeculativeExecution()
https://bugs.webkit.org/show_bug.cgi?id=78431
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
2012-02-11 Benjamin Poulain <benjamin@webkit.org>
Add back WTFURL to WebKit
https://bugs.webkit.org/show_bug.cgi?id=77291
Reviewed by Adam Barth.
WTFURL was removed from WebKit in r86787.
This patch adds the code back to WTF with the following changes:
-Guard the feature with USE(WTFURL).
-Change the typename CHAR to CharacterType to follow recent WebKit conventions.
-Fix some coding style to make check-webkit-style happy.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Platform.h:
* wtf/url/api/ParsedURL.cpp: Added.
(WTF):
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::scheme):
(WTF::ParsedURL::username):
(WTF::ParsedURL::password):
(WTF::ParsedURL::host):
(WTF::ParsedURL::port):
(WTF::ParsedURL::path):
(WTF::ParsedURL::query):
(WTF::ParsedURL::fragment):
(WTF::ParsedURL::segment):
* wtf/url/api/ParsedURL.h: Added.
(WTF):
(ParsedURL):
(WTF::ParsedURL::spec):
* wtf/url/api/URLString.h: Added.
(WTF):
(URLString):
(WTF::URLString::URLString):
(WTF::URLString::string):
* wtf/url/src/RawURLBuffer.h: Added.
(WTF):
(RawURLBuffer):
(WTF::RawURLBuffer::RawURLBuffer):
(WTF::RawURLBuffer::~RawURLBuffer):
(WTF::RawURLBuffer::resize):
* wtf/url/src/URLBuffer.h: Added.
(WTF):
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
* wtf/url/src/URLCharacterTypes.cpp: Added.
(WTF):
():
* wtf/url/src/URLCharacterTypes.h: Added.
(WTF):
(URLCharacterTypes):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isHexChar):
():
(WTF::URLCharacterTypes::isCharOfType):
* wtf/url/src/URLComponent.h: Added.
(WTF):
(URLComponent):
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::fromRange):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonEmpty):
(WTF::URLComponent::isEmptyOrInvalid):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):
* wtf/url/src/URLEscape.cpp: Added.
(WTF):
():
* wtf/url/src/URLEscape.h: Added.
(WTF):
(WTF::appendURLEscapedCharacter):
* wtf/url/src/URLParser.h: Added.
(WTF):
(URLParser):
():
(WTF::URLParser::isPossibleAuthorityTerminator):
(WTF::URLParser::parseAuthority):
(WTF::URLParser::extractScheme):
(WTF::URLParser::parseAfterScheme):
(WTF::URLParser::parseStandardURL):
(WTF::URLParser::parsePath):
(WTF::URLParser::parsePathURL):
(WTF::URLParser::parseMailtoURL):
(WTF::URLParser::parsePort):
(WTF::URLParser::extractFileName):
(WTF::URLParser::extractQueryKeyValue):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::consecutiveSlashes):
(WTF::URLParser::isPortDigit):
(WTF::URLParser::nextAuthorityTerminator):
(WTF::URLParser::parseUserInfo):
(WTF::URLParser::parseServerInfo):
* wtf/url/src/URLQueryCanonicalizer.h: Added.
(WTF):
(URLQueryCanonicalizer):
(WTF::URLQueryCanonicalizer::canonicalize):
(WTF::URLQueryCanonicalizer::isAllASCII):
(WTF::URLQueryCanonicalizer::isRaw8Bit):
(WTF::URLQueryCanonicalizer::appendRaw8BitQueryString):
(WTF::URLQueryCanonicalizer::convertToQueryEncoding):
* wtf/url/src/URLSegments.cpp: Added.
(WTF):
(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):
* wtf/url/src/URLSegments.h: Added.
(WTF):
(URLSegments):
():
(WTF::URLSegments::URLSegments):
2012-02-11 Filip Pizlo <fpizlo@apple.com>
Old JIT put_by_id profiling counts every put_by_id_transition as taking slow path
https://bugs.webkit.org/show_bug.cgi?id=78430
<rdar://problem/10849469> <rdar://problem/10849684>
Reviewed by Gavin Barraclough.
The old JIT's put_by_id transition caching involves repatching the slow call to
a generated stub. That means that the call is counted as "slow case". So, this
patch inserts code to decrement the slow case count if the stub succeeds.
Looks like a ~1% speed-up on V8.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
2012-02-11 Filip Pizlo <fpizlo@apple.com>
Build fix for Qt.
* wtf/DataLog.h:
2012-02-11 Filip Pizlo <fpizlo@apple.com>
It should be possible to send all JSC debug logging to a file
https://bugs.webkit.org/show_bug.cgi?id=78418
Reviewed by Sam Weinig.
Introduced wtf/DataLog, which defines WTF::dataFile, WTF::dataLog,
and WTF::dataLogV. Changed all debugging- and profiling-related printfs
to use WTF::dataLog() or one of its friends. By default, debug logging
goes to stderr, unless you change the setting in wtf/DataLog.cpp.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::vprintfStdoutInstr):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/Opcode.cpp:
(JSC::OpcodeStats::~OpcodeStats):
* bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCommon.h:
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::dump):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::dump):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
* heap/Heap.cpp:
(JSC::Heap::destroy):
* heap/MarkedBlock.h:
* interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* profiler/Profile.cpp:
(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::dumpRegExpTrace):
* runtime/RegExp.cpp:
(JSC::RegExp::matchCompareWithInterpreter):
* runtime/SamplingCounter.cpp:
(JSC::AbstractSamplingCounter::dump):
* runtime/SamplingCounter.h:
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
* runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
* tools/CodeProfile.cpp:
(JSC::CodeProfile::report):
* tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
* wtf/CMakeLists.txt:
* wtf/DataLog.cpp: Added.
(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLog):
* wtf/DataLog.h: Added.
(WTF):
* wtf/HashTable.cpp:
(WTF::HashTableStats::~HashTableStats):
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
* wtf/text/WTFString.cpp:
(String::show):
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::dumpDisjunction):
2012-02-11 Gavin Barraclough <barraclough@apple.com>
Move special __proto__ property to Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=78409
Reviewed by Oliver Hunt.
Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named __proto__.
2) Object.prototype.__proto__ can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement __proto__, it can just be made a regular accessor property.
* parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- No need to prohibit functions named __proto__.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- Add __proto__ accessor to Object.prototype.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):
- Definition of the __proto__ accessor functions.
* runtime/JSGlobalObjectFunctions.h:
- Declaration of the __proto__ accessor functions.
* runtime/JSObject.cpp:
(JSC::JSObject::put):
- Remove the special handling for __proto__, there is still a check to allow for a fast guard for accessors excluding __proto__.
(JSC::JSObject::putDirectAccessor):
- Track on the structure whether an object contains accessors other than one for __proto__.
(JSC::JSObject::defineOwnProperty):
- No need to prohibit definition of own properties named __proto__.
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
- Remove the special handling for __proto__.
(JSC::JSValue::get):
- Remove the special handling for __proto__.
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
- Remove the special handling for __proto__.
* runtime/JSValue.h:
(JSValue):
- Made synthesizePrototype public (this may be needed by the __proto__ getter).
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
- Perform the security check & call prototype() directly.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
* runtime/Structure.h:
(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
2012-02-11 Filip Pizlo <fpizlo@apple.com>
DFG CFA assumes that a WeakJSConstant's structure is known
https://bugs.webkit.org/show_bug.cgi?id=78428
<rdar://problem/10849492> <rdar://problem/10849621>
Reviewed by Gavin Barraclough.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
2012-02-11 Mark Hahnenberg <mhahnenberg@apple.com>
Qt debug build fix
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): Platforms that don't use clang will allocate
JSFinalObjects in the destuctor subspace, so we should remove this assert so it
doesn't cause crashes.
2012-02-11 Filip Pizlo <fpizlo@apple.com>
Old 32_64 JIT should assert that its use of map() is consistent with the DFG
OSR exit's expectations
https://bugs.webkit.org/show_bug.cgi?id=78419
<rdar://problem/10817121>
Reviewed by Oliver Hunt.
* jit/JITInlineMethods.h:
(JSC::JIT::map):
2012-02-11 Mark Hahnenberg <mhahnenberg@apple.com>
Reduce the reentrancy limit of the interpreter for the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=78400
Reviewed by Gavin Barraclough.
* interpreter/Interpreter.h: Lowered the maximum reentrancy limit for large thread stacks.
(JSC):
2012-02-11 Filip Pizlo <fpizlo@apple.com>
[DFG] Misuse of WeakJSConstants in silentFillGPR code.
https://bugs.webkit.org/show_bug.cgi?id=78423
<rdar://problem/10849353> <rdar://problem/10804043>
Reviewed by Sam Weinig.
The code was using Node::isConstant(), when it was supposed to use Node::hasConstant().
This patch is a surgical fix; the bigger problem is: why do we have isConstant() and
hasConstant() when hasConstant() is correct and isConstant() is almost always wrong?
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillGPR):
2012-02-11 Sam Weinig <sam@webkit.org>
Prepare JavaScriptCore to build with libc++
<rdar://problem/10426673>
https://bugs.webkit.org/show_bug.cgi?id=78424
Reviewed by Anders Carlsson.
* wtf/NullPtr.cpp:
* wtf/NullPtr.h:
libc++ provides std::nullptr emulation, so we don't have to.
2012-02-07 Filip Pizlo <fpizlo@apple.com>
DFG should have polymorphic put_by_id caching
https://bugs.webkit.org/show_bug.cgi?id=78062
<rdar://problem/10326439> <rdar://problem/10824839>
Reviewed by Oliver Hunt.
Implemented polymorphic put_by_id caching in the DFG, and added much of the
machinery that would be needed to implement it in the old JIT as well.
I decided against using the old PolymorphicAccessStructureList mechanism as
this didn't quite fit with put_by_id. In particular, I wanted the ability to
have one list that captured all relevant cases (including proto put_by_id
if we ever decided to do it). And I wanted the code to have better
encapsulation. And I didn't want to get confused by the fact that the
original (non-list) put_by_id cache may itself consist of a stub routine.
This code is still sub-optimal (for example adding a replace to a list whose
previous elements are all transitions should just repatch the original code,
but here it will generate a stub) but it already generates a >20% speed-up
on V8-splay, leading to a 2% win overall in splay. Neutral elsewhere.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/PolymorphicPutByIdList.cpp: Added.
(JSC):
(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::from):
(JSC::PolymorphicPutByIdList::~PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::isFull):
(JSC::PolymorphicPutByIdList::isAlmostFull):
(JSC::PolymorphicPutByIdList::addAccess):
(JSC::PolymorphicPutByIdList::visitWeak):
* bytecode/PolymorphicPutByIdList.h: Added.
(JSC):
(PutByIdAccess):
(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::isSet):
(JSC::PutByIdAccess::operator!):
(JSC::PutByIdAccess::type):
(JSC::PutByIdAccess::isTransition):
(JSC::PutByIdAccess::isReplace):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::structure):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):
(JSC::PolymorphicPutByIdList::isEmpty):
(JSC::PolymorphicPutByIdList::size):
(JSC::PolymorphicPutByIdList::at):
(JSC::PolymorphicPutByIdList::operator[]):
(JSC::PolymorphicPutByIdList::kind):
* bytecode/PutKind.h: Added.
(JSC):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdList):
(StructureStubInfo):
(JSC::StructureStubInfo::reset):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
(DFG):
* dfg/DFGRepatch.cpp:
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(DFG):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgRepatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgBuildPutByIdList):
(JSC::DFG::dfgResetPutByID):
* dfg/DFGRepatch.h:
(DFG):
* runtime/WriteBarrier.h:
(WriteBarrierBase):
(JSC::WriteBarrierBase::copyFrom):
2012-02-10 Vineet Chaudhary <rgf748@motorola.com>
https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it
Reviewed by Timothy Hatcher.
* API/WebKitAvailability.h: Added AVAILABLE_AFTER_WEBKIT_VERSION_5_1 and
AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1 for the new versions.
2012-02-10 Mark Hahnenberg <mhahnenberg@apple.com>
Fixing windows build
Unreviewed build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-02-10 Adam Klein <adamk@chromium.org>
Enable MUTATION_OBSERVERS by default on all platforms
https://bugs.webkit.org/show_bug.cgi?id=78196
Reviewed by Ojan Vafai.
* Configurations/FeatureDefines.xcconfig:
2012-02-10 Yong Li <yoli@rim.com>
ENABLE(ASSEMBLER_WX_EXCLUSIVE): LinkBuffer can leave pages not marked as executable.
https://bugs.webkit.org/show_bug.cgi?id=76724
Reviewed by Rob Buis.
This issue only exists when both ENABLE(ASSEMBLER_WX_EXCLUSIVE) and ENABLE(BRANCH_COMPACTION) are on.
The size used to call makeExecutable can be smaller than the one that was used for makeWritable.
So it can leave pages behind that are not set back to default flags. When an assembly on one of those
pages is executed or JIT returns to those pages in the case it was already executing from there, the
software will crash.
* assembler/LinkBuffer.h: Add m_initialSize and use it in performFinalization().
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(LinkBuffer):
2012-02-10 Mark Hahnenberg <mhahnenberg@apple.com>
Split MarkedSpace into destructor and destructor-free subspaces
https://bugs.webkit.org/show_bug.cgi?id=77761
Reviewed by Geoffrey Garen.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject): Switched over to use destructor-free space.
* heap/Heap.h:
(JSC::Heap::allocatorForObjectWithoutDestructor): Added to give clients (e.g. the JIT) the ability to
pick which subspace they want to allocate out of.
(JSC::Heap::allocatorForObjectWithDestructor): Ditto.
(Heap):
(JSC::Heap::allocateWithDestructor): Added private function for CellAllocator to use.
(JSC):
(JSC::Heap::allocateWithoutDestructor): Ditto.
* heap/MarkedAllocator.cpp: Added the cellsNeedDestruction flag to allocators so that they can allocate
their MarkedBlocks correctly.
(JSC::MarkedAllocator::allocateBlock):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::cellsNeedDestruction):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC):
(JSC::MarkedAllocator::init): Replaced custom set functions, which were only used upon initialization, with
an init function that does all of that stuff in fewer lines.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::callDestructor): Templatized, along with specializedSweep and sweepHelper, to make
checking the m_cellsNeedDestructor flag faster and cleaner looking.
(JSC):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::cellsNeedDestruction):
(JSC):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):
* heap/MarkedSpace.h:
(MarkedSpace):
(Subspace):
(JSC::MarkedSpace::allocatorFor): Needed function to differentiate between the two broad subspaces of
allocators.
(JSC):
(JSC::MarkedSpace::destructorAllocatorFor): Ditto.
(JSC::MarkedSpace::allocateWithoutDestructor): Ditto.
(JSC::MarkedSpace::allocateWithDestructor): Ditto.
(JSC::MarkedSpace::forEachBlock):
* jit/JIT.h:
* jit/JITInlineMethods.h: Modified to use the proper allocator for JSFinalObjects and others.
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
* runtime/JSArray.cpp:
(JSC):
* runtime/JSArray.h:
(JSArray):
(JSC::JSArray::create):
(JSC):
(JSC::JSArray::tryCreateUninitialized):
* runtime/JSCell.h:
(JSCell):
(JSC):
(NeedsDestructor): Template struct that calculates at compile time whether the class in question requires
destruction or not using the compiler type trait __has_trivial_destructor. allocateCell then checks this
constant to decide whether to allocate in the destructor or destructor-free parts of the heap.
(JSC::allocateCell):
* runtime/JSFunction.cpp:
(JSC):
* runtime/JSFunction.h:
(JSFunction):
* runtime/JSObject.cpp:
(JSC):
* runtime/JSObject.h:
(JSNonFinalObject):
(JSC):
(JSFinalObject):
(JSC::JSFinalObject::create):
2012-02-10 Adrienne Walker <enne@google.com>
Remove implicit copy constructor usage in HashMaps with OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=78071
Reviewed by Darin Adler.
Change the return type of emptyValue() in PairHashTraits to be the
actual type returned rather than the trait type to avoid an implicit
generation of the OwnPtr copy constructor. This happens for hash
traits involving OwnPtr where the empty value is not zero and each
hash bucket needs to be initialized with emptyValue().
Also, update StructureTransitionTable to use default hash traits
rather than rolling its own, in order to update it to handle
EmptyValueType.
Test: patch from bug 74154 compiles on Clang with this patch
* runtime/StructureTransitionTable.h:
(StructureTransitionTable):
* wtf/HashTraits.h:
(GenericHashTraits):
(PairHashTraits):
(WTF::PairHashTraits::emptyValue):
2012-02-10 Aron Rosenberg <arosenberg@logitech.com>
[Qt] Fix compiler warning in Visual Studio 2010 about TR1
https://bugs.webkit.org/show_bug.cgi?id=63642
Reviewed by Simon Hausmann.
* JavaScriptCore.pri:
2012-02-10 Michael Saboff <msaboff@apple.com>
Yarr assert with regexp where alternative in *-quantified group matches empty
https://bugs.webkit.org/show_bug.cgi?id=67752
Reviewed by Gavin Barraclough.
Added backtracking for the prior alternative if it matched
but didn't consume any input characters.
* yarr/YarrJIT.cpp:
(YarrOp): New jump.
(JSC::Yarr::YarrGenerator::generate): Emit conditional jump
when an alternative matches and no input was consumed. Moved the
zero length match check for a set of alternatives to the alternative
code from the parentheses cases to the alternative end cases.
Converted the existing zero length checks in the parentheses cases
to runtime assertion checks.
(JSC::Yarr::YarrGenerator::backtrack): Link new jump to backtrack
to prior term.
2012-02-10 Roland Takacs <takacs.roland@stud.u-szeged.hu>
[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309
Reviewed by Zoltan Herczeg.
These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread",
and a local static function [initializeGCThreads] is moved from
MainThreadMac.mm to the common MainThread.cpp to make them available
for other platforms.
Measurement results:
V8 speed-up: 1.025x as fast [From: 663.4ms To: 647.0ms ]
V8 Splay speed-up: 1.185x as fast [From: 138.4ms To: 116.8ms ]
Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
* JavaScriptCore.order:
* wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
* wtf/MainThread.h:
(WTF):
* wtf/Platform.h:
* wtf/mac/MainThreadMac.mm:
(WTF):
2012-02-09 Andy Wingo <wingo@igalia.com>
Eliminate dead code in BytecodeGenerator::resolve()
https://bugs.webkit.org/show_bug.cgi?id=78242
Reviewed by Gavin Barraclough.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
BytecodeGenerator::shouldOptimizeLocals() is only true for
FunctionCode, and thus cannot be true for GlobalCode.
2012-02-09 Andy Wingo <wingo@igalia.com>
Remove BytecodeGenerator::isLocal
https://bugs.webkit.org/show_bug.cgi?id=78241
Minor refactor to BytecodeGenerator.
Reviewed by Gavin Barraclough.
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant): Remove now-unused
methods.
* bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::isPure): Use the ResolveResult mechanism
instead of isLocal. This will recognize more resolve nodes as
being pure.
(JSC::PrefixResolveNode::emitBytecode): Use isReadOnly on the
location instead of isLocalConstant.
2012-02-09 Oliver Hunt <oliver@apple.com>
The JS Parser scope object needs a VectorTrait specialization
https://bugs.webkit.org/show_bug.cgi?id=78308
Reviewed by Gavin Barraclough.
This showed up as a periodic crash in various bits of generated code
originally, but I've added an assertion in the bytecode generator
that makes the effected code much more crash-happy should it go
wrong again.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
* parser/Parser.cpp:
* parser/Parser.h:
(JSC):
* runtime/JSActivation.h:
(JSC::JSActivation::isValidScopedLookup):
(JSActivation):
2012-02-08 Oliver Hunt <oliver@apple.com>
Whoops, fix the build.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
2012-02-08 Oliver Hunt <oliver@apple.com>
Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147
Reviewed by Gavin Barraclough.
Debugging is easier if we always ensure that we have a non-null
inferred name.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
2012-02-08 Oliver Hunt <oliver@apple.com>
updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145
Reviewed by Gavin Barraclough.
Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.
* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):
2012-02-07 Robert Kroeger <rjkroege@chromium.org>
[chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492
Reviewed by Adam Barth.
* wtf/Platform.h:
2012-02-07 Tony Chang <tony@chromium.org>
merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036
Reviewed by Darin Adler.
* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
2012-02-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[CMAKE] Use *bin* and *lib* directories for executable and libraries.
https://bugs.webkit.org/show_bug.cgi?id=77928
Reviewed by Daniel Bates.
CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.
* shell/CMakeLists.txt: Change *Programs* with *bin*.
2012-02-07 Gavin Barraclough <barraclough@apple.com>
Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045
Reviewed by Darin Adler.
Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()
This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.
* runtime/JSType.h:
- sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
and thus is excluded from isVariableObject() checks.
2012-02-06 Jer Noble <jer.noble@apple.com>
Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885
Reviewed by Eric Carlson.
* wtf/Platform.h: Added WTF_USE_COREMEDIA.
2012-02-06 Filip Pizlo <fpizlo@apple.com>
ValueToNumber and ValueToDouble nodes don't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=77855
<rdar://problem/10811325>
Reviewed by Gavin Barraclough.
Removed ValueToNumber and ValueToDouble, because the only thing they were doing
was wasting registers.
This looks like a 1% win on V8 (with a 5% win on crypto) and a 2-3% win on Kraken,
mostly due to a >10% win on gaussian-blur. No win anywhere else.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getToInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(DFG):
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(Propagator):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2012-02-06 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix after r106197.
* tools/CodeProfiling.cpp:
(JSC::CodeProfiling::notifyAllocator): getenv() isn't supported by WinCE. Don't call it.
2012-02-05 Gavin Barraclough <barraclough@apple.com>
Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
https://bugs.webkit.org/show_bug.cgi?id=77451
Reviewed by Sam Weinig.
These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineOwnProperty):
* debugger/DebuggerActivation.h:
(DebuggerActivation):
* runtime/ClassInfo.h:
(MethodTable):
(JSC):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
* runtime/JSCell.cpp:
(JSC):
* runtime/JSCell.h:
(JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineOwnProperty):
(JSC):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
* runtime/JSObject.cpp:
(JSC):
* runtime/JSObject.h:
(JSObject):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck.
* GNUmakefile.list.am: Add missing files.
2012-02-05 Filip Pizlo <fpizlo@apple.com>
DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797
Reviewed by Oliver Hunt.
The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).
The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.
This is performance-neutral on all benchmarks we track.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
(AbstractState):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):
* dfg/DFGCommon.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(DFG):
* dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):
* dfg/DFGNodeReferenceBlob.h: Added.
(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):
* dfg/DFGNodeUse.h: Added.
(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
2012-02-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425
Reviewed by Daniel Bates.
Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.
* shell/CMakeLists.txt:
2012-02-04 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::quantifyAtom):
- Fix comment.
2012-02-04 Kalev Lember <kalevlember@gmail.com>
[GTK] CurrentTime: Reorder headers for win32
https://bugs.webkit.org/show_bug.cgi?id=77808
Reviewed by Martin Robinson.
In GTK+ win32 port, monotonicallyIncreasingTime() implementation is
based on g_get_monotonic_time(). Reorder headers to make sure glib.h
gets included even when the platform is win32.
CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
CurrentTime.cpp:321:53: error: 'g_get_monotonic_time' was not declared in this scope
CurrentTime.cpp:322:1: warning: control reaches end of non-void function [-Wreturn-type]
* wtf/CurrentTime.cpp:
2012-02-03 Anders Carlsson <andersca@apple.com>
Prefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
https://bugs.webkit.org/show_bug.cgi?id=77788
Reviewed by Andreas Kling.
The current typedef name, 'ThisIsHereToForceASemicolonAfterThisMacro', shows up when trying to
code-complete 'this' in Xcode. Prefix the typedef with two underscores to stop this from happening.
* wtf/FastAllocBase.h:
2012-02-03 Rob Buis <rbuis@rim.com>
Fix alignment warnings in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55368
Reviewed by Filip Pizlo.
Use reinterpret_cast_ptr and static_cast to get rid of alignment issues in ARMv7 code.
* heap/HandleTypes.h:
(JSC::HandleTypes::getFromSlot):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::forEachCell):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::unvalidatedGet):
2012-02-03 Mark Hahnenberg <mhahnenberg@apple.com>
Build fix
Unreviewed build fix
Forgot to add a couple files.
* heap/MarkedAllocator.cpp: Added.
(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
* heap/MarkedAllocator.h: Added.
(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):
2012-02-03 Mark Hahnenberg <mhahnenberg@apple.com>
Refactor MarkedBlock::SizeClass into a separate class
https://bugs.webkit.org/show_bug.cgi?id=77600
Reviewed by Geoffrey Garen.
We pulled SizeClass out into its own class, named MarkedAllocator, and gave it
the responsibility of allocating objects from the collection of MarkedBlocks
that it manages. Also limited the amount of coupling to internal data fields
from other places, although it's mostly unavoidable in the JIT code.
Eventually MarkedAllocator will implement various policies to do with object
management, e.g. whether or not to run destructors on objects that it manages.
MarkedSpace will manage a collection of MarkedAllocators with varying policies,
as it does now but to a larger extent.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
* heap/Heap.cpp:
(JSC::Heap::collect):
(JSC::Heap::resetAllocators):
* heap/Heap.h:
(JSC::Heap::allocatorForObject):
(Heap):
* heap/MarkedAllocator.cpp: Added.
(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
* heap/MarkedAllocator.h: Added.
(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::didAddBlock):
(JSC::MarkedSpace::didConsumeFreeList):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
2012-02-03 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Replace GNU linker script for exports with export macros in WTF/JSC
https://bugs.webkit.org/show_bug.cgi?id=77723
Reviewed by Tor Arne Vestbø.
* wtf/Platform.h: Enable use of export macros.
2012-02-02 Hajime Morrita <morrita@chromium.org>
Unreviewed, removing an unnecessarily JS_PRIVATE_EXPORT annotation.
* interpreter/Interpreter.h:
(Interpreter):
2012-01-31 Hajime Morrita <morrita@chromium.org>
[Mac] eliminate JavaScriptCore.exp
https://bugs.webkit.org/show_bug.cgi?id=72854
Reviewed by Darin Adler.
- Removed exp files and corresponding makefile entries.
- Changed the build configuration no to use exp file.
* Configurations/JavaScriptCore.xcconfig:
* DerivedSources.make:
* JavaScriptCore.JSVALUE32_64only.exp: Removed.
* JavaScriptCore.JSVALUE64only.exp: Removed.
* JavaScriptCore.exp: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Platform.h:
2012-02-02 Benjamin Poulain <bpoulain@apple.com>
Running a Web Worker on about:blank crashes the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77593
Reviewed by Michael Saboff.
The method Interpreter::execute() was crashing on empty programs because
the assumption is made the source is not null.
This patch shortcut the execution when the String is null to avoid invalid
memory access.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
2012-02-02 Kalev Lember <kalevlember@gmail.com>
[GTK] Use win32 native threading
https://bugs.webkit.org/show_bug.cgi?id=77676
Reviewed by Martin Robinson.
r97269 switched from glib threading to pthreads, breaking win32 GTK+.
This is a follow up, removing some leftovers in ThreadSpecific.h and
switching win32 to use the native threading in ThreadingWin.cpp.
* GNUmakefile.list.am: Compile in win32 native threading support
* wtf/ThreadSpecific.h: Remove GTK+-specific definitions
(ThreadSpecific):
(WTF::::destroy):
2012-02-02 Filip Pizlo <fpizlo@apple.com>
retrieveCallerFromVMCode should call trueCallerFrame
https://bugs.webkit.org/show_bug.cgi?id=77684
Reviewed by Oliver Hunt.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCallerFromVMCode):
2012-02-02 Kalev Lember <kalevlember@gmail.com>
[GTK] Implement current executable path finding for win32
https://bugs.webkit.org/show_bug.cgi?id=77677
Reviewed by Martin Robinson.
The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.
* wtf/gobject/GlibUtilities.cpp:
(getCurrentExecutablePath):
2012-02-02 Filip Pizlo <fpizlo@apple.com>
Throwing away bytecode and then reparsing during DFG optimization is just
plain wrong and makes things crash
https://bugs.webkit.org/show_bug.cgi?id=77680
<rdar://problem/10798490>
Reviewed by Oliver Hunt.
This is the minimal surgical fix: it removes the code that triggered bytecode
throw-away. Once we're confident that this is a good idea, we can kill all of
the code that implements the feature.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::addValueProfile):
* jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
2012-02-02 Filip Pizlo <fpizlo@apple.com>
Release build debugging should be easier
https://bugs.webkit.org/show_bug.cgi?id=77669
Reviewed by Gavin Barraclough.
* assembler/ARMAssembler.h:
(ARMAssembler):
(JSC::ARMAssembler::debugOffset):
* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::debugOffset):
(ARMInstructionFormatter):
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
* assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::debugOffset):
* assembler/AssemblerBuffer.h:
(AssemblerBuffer):
(JSC::AssemblerBuffer::debugOffset):
* assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::debugSize):
* assembler/MIPSAssembler.h:
(MIPSAssembler):
(JSC::MIPSAssembler::debugOffset):
* assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::debugOffset):
(X86InstructionFormatter):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):
* bytecode/CodeBlock.cpp:
(JSC):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/CodeOrigin.h:
(CodeOrigin):
(JSC):
(JSC::CodeOrigin::inlineStack):
* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* bytecode/DataFormat.h:
(JSC::dataFormatToString):
* bytecode/PredictedType.cpp:
(JSC):
(JSC::predictionToString):
* bytecode/PredictedType.h:
(JSC):
* bytecode/ValueRecovery.h:
(ValueRecovery):
(JSC::ValueRecovery::dump):
* bytecompiler/BytecodeGenerator.cpp:
(JSC):
(JSC::BytecodeGenerator::setDumpsGeneratedCode):
(JSC::BytecodeGenerator::dumpsGeneratedCode):
(JSC::BytecodeGenerator::generate):
* dfg/DFGAbstractValue.h:
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::dump):
(AbstractValue):
(JSC::DFG::AbstractValue::dump):
* dfg/DFGAssemblyHelpers.h:
(DFG):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGFPRInfo.h:
(FPRInfo):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::debugName):
* dfg/DFGGraph.cpp:
(DFG):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGNode.h:
(DFG):
(JSC::DFG::arithNodeFlagsAsString):
(Node):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::dumpChildren):
* dfg/DFGOSRExit.cpp:
(DFG):
(JSC::DFG::OSRExit::dump):
* dfg/DFGOSRExit.h:
(OSRExit):
* runtime/JSValue.cpp:
(JSC):
(JSC::JSValue::description):
* runtime/JSValue.h:
(JSValue):
* wtf/BitVector.cpp:
(WTF):
(WTF::BitVector::dump):
* wtf/BitVector.h:
(BitVector):
2012-02-02 Oliver Hunt <oliver@apple.com>
Getters and setters cause line numbers in errors/console.log to be offset for the whole file
https://bugs.webkit.org/show_bug.cgi?id=77675
Reviewed by Timothy Hatcher.
Our default literal parsing logic doesn't handle the extra work required for
getters and setters. When it encounters one, it rolls back the lexer and
then switches to a more complete parsing function. Unfortunately it was only
winding back the character position, and was ignoring the line number and
other lexer data. This led to every getter and setter causing the line number
to be incorrectly incremented leading to increasingly incorrect numbers for
the rest of the file.
* parser/Parser.cpp:
(JSC::::parseObjectLiteral):
2012-02-02 Andy Wingo <wingo@igalia.com>
Fix type punning warning in HashTable.h debug builds
https://bugs.webkit.org/show_bug.cgi?id=77422
Reviewed by Gavin Barraclough.
* wtf/HashTable.h (WTF::HashTable::checkKey): Fix type punning
warning appearing in debug builds with gcc-4.6.2 on GNU/Linux.
2012-02-01 Michael Saboff <msaboff@apple.com>
Yarr crash with regexp replace
https://bugs.webkit.org/show_bug.cgi?id=67454
Reviewed by Gavin Barraclough.
Properly handle the case of a back reference to an unmatched
subpattern by always matching without consuming any characters.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchBackReference):
(JSC::Yarr::Interpreter::backtrackBackReference):
2012-02-01 Gavin Barraclough <barraclough@apple.com>
calling function on catch block scope containing an eval result in wrong this value being passed
https://bugs.webkit.org/show_bug.cgi?id=77581
Reviewed by Oliver Hunt.
javascript:function F(){ return 'F' in this; }; try { throw F; } catch (e) { eval(""); alert(e()); }
* bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createTryStatement):
* parser/NodeConstructors.h:
(JSC::TryNode::TryNode):
* parser/Nodes.h:
(TryNode):
* parser/Parser.cpp:
(JSC::::parseTryStatement):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createTryStatement):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::isStaticScopeObject):
(JSC):
2012-02-01 Oliver Hunt <oliver@apple.com>
Add support for inferred function names
https://bugs.webkit.org/show_bug.cgi?id=77579
Reviewed by Gavin Barraclough.
Add new "inferred" names to function expressions, getters, and setters.
This property is not exposed to JS, so is only visible in the debugger
and profiler.
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::makeAssignNode):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
(JSC::FunctionBodyNode::inferredName):
(FunctionBodyNode):
* profiler/Profiler.cpp:
(JSC):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/Executable.h:
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::inferredName):
(FunctionExecutable):
* runtime/JSFunction.cpp:
(JSC::JSFunction::calculatedDisplayName):
(JSC):
(JSC::getCalculatedDisplayName):
* runtime/JSFunction.h:
(JSC):
2012-02-01 Filip Pizlo <fpizlo@apple.com>
DFG should fold double-to-int conversions
https://bugs.webkit.org/show_bug.cgi?id=77532
Reviewed by Oliver Hunt.
Performance neutral on major benchmarks. But it makes calling V8's
Math.random() 4x faster.
* bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::addOrFindConstant):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addConstant):
(CodeBlock):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::isInt32Constant):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArithSub):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::valueOfNumberConstantAsInt32):
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::asDouble):
2012-02-01 Filip Pizlo <fpizlo@apple.com>
DFG graph dump for GetScopedVar should show the correct prediction
https://bugs.webkit.org/show_bug.cgi?id=77530
Reviewed by Geoff Garen.
GetScopedVar has a heap prediction, not a variable prediction. But it does
have a variable. Hence we need to check for heap predictions before checking
for variable predictions.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
2012-02-01 Mark Hahnenberg <mhahnenberg@apple.com>
Replace JSArray destructor with finalizer
https://bugs.webkit.org/show_bug.cgi?id=77488
Reviewed by Geoffrey Garen.
* JavaScriptCore.exp:
* runtime/JSArray.cpp:
(JSC::JSArray::finalize): Added finalizer.
(JSC::JSArray::allocateSparseMap): Factored out code for allocating new sparse maps.
(JSC):
(JSC::JSArray::deallocateSparseMap): Factored out code for deallocating sparse maps.
(JSC::JSArray::enterDictionaryMode): Renamed enterSparseMode to enterDictionaryMode
because the old name was confusing because we could have a sparse array that never
called enterSparseMode.
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
* runtime/JSArray.h:
(JSArray):
2012-02-01 Andy Wingo <wingo@igalia.com>
Refactor identifier resolution in BytecodeGenerator
https://bugs.webkit.org/show_bug.cgi?id=76285
Reviewed by Geoffrey Garen.
* bytecompiler/BytecodeGenerator.h:
(JSC::ResolveResult): New class, to describe the storage
location corresponding to an identifier in a program.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve): New function, replacing
findScopedProperty.
(JSC::BytecodeGenerator::resolveConstDecl): New function,
encapsulating what ConstDeclNode::emitBytecode used to do.
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar): New functions,
corresponding to the old emitGetScopedVar and emitPutScopedVar.
(JSC::BytecodeGenerator::registerFor): Remove version that took an
Identifier&; replaced by ResolveResult::local().
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis): Change to accept a
"resolveResult" argument. This is more clear, and reduces the
amount of double analysis happening at compile-time.
* bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::DeleteResolveNode::emitBytecode):
(JSC::TypeOfResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode): Refactor to use the new
ResolveResult structure.
2012-02-01 Csaba Osztrogonác <ossy@webkit.org>
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Unreviewed, rolling out r106407.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):
2012-01-31 Hajime Morrita <morrita@chromium.org>
Add missing JS_PRIVATE_EXPORTs
https://bugs.webkit.org/show_bug.cgi?id=77507
Reviewed by Kevin Ollivier.
* heap/MarkedSpace.h:
(MarkedSpace):
* interpreter/Interpreter.h:
(Interpreter):
* runtime/JSValue.h:
(JSValue):
* wtf/text/AtomicString.h:
(WTF::AtomicString::add):
* wtf/text/WTFString.h:
(WTF):
2012-01-31 Geoffrey Garen <ggaren@apple.com>
Stop using -fomit-frame-pointer
https://bugs.webkit.org/show_bug.cgi?id=77403
Reviewed by Filip Pizlo.
JavaScriptCore is too fast. I'm just the man to fix it.
* Configurations/JavaScriptCore.xcconfig:
2012-01-31 Michael Saboff <msaboff@apple.com>
StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
https://bugs.webkit.org/show_bug.cgi?id=76647
Reviewed by Darin Adler.
Changed stringProtoFuncToUpperCase to call StringImpl::upper() in a manor similar
to stringProtoFuncToLowerCase(). Fixed StringImpl::upper() to handle to special
cases. One case is s-sharp (0xdf) which converts to "SS". The other case is
for characters which become 16 bit values when converted to upper case. For
those, we up convert the the source string and use the 16 bit path.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
* wtf/unicode/CharacterNames.h:
(smallLetterSharpS): New constant
2012-01-31 Oliver Hunt <oliver@apple.com>
Remove unneeded sourceId property
https://bugs.webkit.org/show_bug.cgi?id=77495
Reviewed by Filip Pizlo.
sourceId isn't used anymore, so we'll just remove it.
* runtime/Error.cpp:
(JSC):
(JSC::addErrorInfo):
(JSC::hasErrorInfo):
2012-01-31 Oliver Hunt <oliver@apple.com>
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Reviewed by Gavin Barraclough.
Original patch by Juan Carlos Montemayor Elosua:
This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.
Modified to be correct on ToT, with a variety of correctness,
performance, and security improvements.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
2012-01-31 Scott Graham <scottmg@chromium.org>
[Chromium] Remove references to gyp cygwin build target
https://bugs.webkit.org/show_bug.cgi?id=77253
Reviewed by Julien Chaffraix.
Target dependency is no longer required, it's done earlier in the
build process.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2012-01-31 Michael Saboff <msaboff@apple.com>
ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
https://bugs.webkit.org/show_bug.cgi?id=77443
Reviewed by Gavin Barraclough.
Removed failing ASSERT() and thus destructor. The ASSERT isn't needed.
We are hitting it in the YARR JIT case where we bail out and go to the
interpreter with a partially JIT'ed function. Since we haven't linked
the JIT'ed code, there is likely to be some unresolved jumps in the vector
when the ARMv7Assembler destructor is called. For the case where we
complete the JIT process, we clear the vector at the end of
LinkBuffer::linkCode (LinkBuffer.h:292).
* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
2012-01-31 Anders Carlsson <andersca@apple.com>
Vector<T>::operator== shouldn't require T to have operator!=
https://bugs.webkit.org/show_bug.cgi?id=77448
Reviewed by Andreas Kling.
Change VectorComparer::compare to use !(a == b) instead of a != b since
it makes more sense for Vector::operator== to use the element's operator==.
* wtf/Vector.h:
2012-01-30 Oliver Hunt <oliver@apple.com>
get_by_val_arguments is broken in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77389
Reviewed by Gavin Barraclough.
When get_by_val had wad a value profile added, the same slot was not added to
get_by_val_arguments. This broke the interpreter as the interpreter falls
back on its regular get_by_val implementation.
No tests are added as the interpreter is fairly broken in its
current state (multiple tests fail due to this bug).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
():
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetArgumentByVal):
2012-01-30 Oliver Hunt <oliver@apple.com>
Unexpected syntax error
https://bugs.webkit.org/show_bug.cgi?id=77340
Reviewed by Gavin Barraclough.
Function calls and new expressions have the same semantics for
assignment, so should simply share their lhs handling.
* parser/Parser.cpp:
(JSC::::parseMemberExpression):
2012-01-30 Gavin Barraclough <barraclough@apple.com>
Unreviewed ARMv7 build fix.
* tools/CodeProfiling.cpp:
(JSC):
(JSC::setProfileTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):
2012-01-30 David Levin <levin@chromium.org>
Using OS(WIN) or OS(MAC) should cause a build error.
https://bugs.webkit.org/show_bug.cgi?id=77162
Reviewed by Darin Adler.
* wtf/Platform.h: Expand them into something that will
cause a compile error.
2012-01-30 Yong Li <yoli@rim.com>
[BlackBerry] OS(QNX) also has TM_GMTOFF, TM_ZONE, and TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=77360
Reviewed by Rob Buis.
Turn on HAVE(TM_GMTOFF), HAVE(TM_ZONE), and HAVE(TIMEGM)
for OS(QNX).
* wtf/Platform.h:
2012-01-30 Gavin Barraclough <barraclough@apple.com>
Speculative Windows build fix.
* assembler/MacroAssemblerCodeRef.h:
(FunctionPtr):
2012-01-30 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=77163
MacroAssemblerCodeRef.h uses OS(WIN) instead of OS(WINDOWS)
Rubber stamped by Geoff Garen
* assembler/MacroAssemblerCodeRef.h:
2012-01-30 Gavin Barraclough <barraclough@apple.com>
Unreviewed build fix for interpreter builds.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(CodeBlock):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
2012-01-30 Gavin Barraclough <barraclough@apple.com>
Unreviewed build fix following bug#76855
* JavaScriptCore.exp:
2012-01-30 Michael Saboff <msaboff@apple.com>
CaseFoldingHash::hash() doesn't handle 8 bit strings directly
https://bugs.webkit.org/show_bug.cgi?id=76652
Reviewed by Andreas Kling.
* wtf/text/StringHash.h:
(WTF::CaseFoldingHash::hash): Added 8 bit string code path.
2012-01-30 Michael Saboff <msaboff@apple.com>
stringProtoFuncReplace converts 8 bit strings to 16 bit during replacement
https://bugs.webkit.org/show_bug.cgi?id=76651
Reviewed by Geoffrey Garen.
Made local function substituteBackreferencesSlow a template function
based on character width. Cleaned up getCharacters() in both UString
and StringImpl. Changed getCharacters<UChar> to up convert an 8 bit
string to 16 bits if necessary.
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
* runtime/UString.h:
(JSC::LChar):
(JSC::UChar):
* wtf/text/StringImpl.h:
(WTF::UChar):
2012-01-30 Gavin Barraclough <barraclough@apple.com>
Clean up putDirect
https://bugs.webkit.org/show_bug.cgi?id=76232
Reviewed by Sam Weinig.
Part 3 - merge op_put_getter & op_put_setter.
Putting these separately is inefficient (and makes future optimiation,
e.g. making GetterSetter immutable) harder. Change to emit a single
op_put_getter_setter bytecode op. Ultimately we should probably be
able to merge this with put direct, to create a common op to initialize
object literal properties.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
():
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPutGetterSetter):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JIT):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_getter_setter):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_getter_setter):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
():
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
(JSC):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
():
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
2012-01-30 Michael Saboff <msaboff@apple.com>
Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=76649
Reviewed by Geoffrey Garen.
* JavaScriptCore.exp: Added export for charactersToDouble.
2012-01-30 Michael Saboff <msaboff@apple.com>
WebCore decodeEscapeSequences unnecessarily converts 8 bit strings to 16 bit when decoding.
https://bugs.webkit.org/show_bug.cgi?id=76648
Reviewed by Geoffrey Garen.
Added a new overloaded append member that takes a String& argument, an offest
and a length to do direct sub string appending to a StringBuilder.
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
2012-01-29 Zoltan Herczeg <zherczeg@webkit.org>
Custom written CSS lexer
https://bugs.webkit.org/show_bug.cgi?id=70107
Reviewed by Antti Koivisto and Oliver Hunt.
Add new helper functions for the custom written CSS lexer.
* wtf/ASCIICType.h:
(WTF::toASCIILowerUnchecked):
(WTF):
(WTF::isASCIIAlphaCaselessEqual):
2012-01-29 Filip Pizlo <fpizlo@apple.com>
REGRESSION (r105576-r105582): Web Inspector Crash in JSC::JSValue::toString(JSC::ExecState*) const
https://bugs.webkit.org/show_bug.cgi?id=77146
<rdar://problem/10770586>
Reviewed by Oliver Hunt.
The old JIT expects that the result of the last operation is in the lastResultRegister. The DFG JIT is
designed to correctly track the lastResultRegister by looking at SetLocal nodes. However, when the DFG
JIT inlines a code block, it forgets that the inlined code block's result would have been placed in the
lastResultRegister. Hence if we OSR exit on the first node following the end of an inlined code block
that had a return value, and that first node uses the return value, the old JIT will get massively
confused. This patch takes a surgical approach: instead of making the DFG smarter, it makes the old
JIT slightly dumber.
* jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
2012-01-29 Filip Pizlo <fpizlo@apple.com>
Build fix for Mac non-x64 platforms.
* tools/CodeProfiling.cpp:
(JSC):
2012-01-28 Gavin Barraclough <barraclough@apple.com>
Reserve 'let'
https://bugs.webkit.org/show_bug.cgi?id=77293
Rubber stamped by Oliver Hunt.
'let' may become a keyword in ES6. We're going to try experimentally reserving it,
to see if this breaks the web.
* parser/Keywords.table:
2012-01-27 Gavin Barraclough <barraclough@apple.com>
Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855
Reviewed by Oliver Hunt.
To enable the profiler, set the JSC_CODE_PROFILING environment variable to
1 (no tracing the C stack), 2 (trace one level of C code) or 3 (recursively
trace all samples).
The profiler requires -fomit-frame-pointer to be removed from the build flags.
* JavaScriptCore.exp:
- Removed an export.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added new files
* bytecode/CodeBlock.cpp:
- For baseline codeblocks, cache the result of canCompileWithDFG.
* bytecode/CodeBlock.h:
- For baseline codeblocks, cache the result of canCompileWithDFG.
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::initializeAllocator):
- Notify the profiler when the allocator is created.
(JSC::ExecutableAllocator::allocate):
- Inform the allocated of the ownerUID.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::initializeAllocator):
- Notify the profiler when the allocator is created.
(JSC::ExecutableAllocator::allocate):
- Inform the allocated of the ownerUID.
* jit/JITStubs.cpp:
- If profiling, don't mask the return address in JIT code.
(We do so to provide nicer backtraces in debug builds).
* runtime/Completion.cpp:
(JSC::evaluate):
- Notify the profiler of script evaluations.
* tools: Added.
* tools/CodeProfile.cpp: Added.
(JSC::symbolName):
- Helper function to get the name of a symbol in the framework.
(JSC::truncateTrace):
- Helper to truncate traces into methods know to have uninformatively deep stacks.
(JSC::CodeProfile::sample):
- Record a stack trace classifying samples.
(JSC::CodeProfile::report):
- {Print profiler output.
* tools/CodeProfile.h: Added.
- new class, captures a set of samples associated with an evaluated script,
and nested to record samples from subscripts.
* tools/CodeProfiling.cpp: Added.
(JSC::CodeProfiling::profilingTimer):
- callback fired then a timer event occurs.
(JSC::CodeProfiling::notifyAllocator):
- called when the executable allocator is constructed.
(JSC::CodeProfiling::getOwnerUIDForPC):
- helper to lookup the codeblock from an address in JIT code
(JSC::CodeProfiling::begin):
- enter a profiling scope.
(JSC::CodeProfiling::end):
- exit a profiling scope.
* tools/CodeProfiling.h: Added.
- new class, instantialed from Completion to define a profiling scope.
* tools/ProfileTreeNode.h: Added.
- new class, used to construct a tree of samples.
* tools/TieredMMapArray.h: Added.
- new class, a malloc-free vector (can be used while the main thread is suspended,
possibly holding the malloc heap lock).
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
- Allow allocation handles to track information about their owner.
* wtf/MetaAllocator.h:
(MetaAllocator):
- Allow allocation handles to track information about their owner.
* wtf/MetaAllocatorHandle.h:
(MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::ownerUID):
- Allow allocation handles to track information about their owner.
* wtf/OSAllocator.h:
(WTF::OSAllocator::reallocateCommitted):
- reallocate an existing, committed memory allocation.
2012-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r106187.
http://trac.webkit.org/changeset/106187
https://bugs.webkit.org/show_bug.cgi?id=77276
The last rollout was a false charge. (Requested by morrita on
#webkit).
* runtime/ExceptionHelpers.h:
(InterruptedExecutionError):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/RegExp.h:
(RegExp):
* runtime/RegExpMatchesArray.h:
(RegExpMatchesArray):
2012-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r106151.
http://trac.webkit.org/changeset/106151
https://bugs.webkit.org/show_bug.cgi?id=77275
may break windows build (Requested by morrita on #webkit).
* runtime/ExceptionHelpers.h:
(InterruptedExecutionError):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/RegExp.h:
(RegExp):
* runtime/RegExpMatchesArray.h:
(RegExpMatchesArray):
2012-01-28 Filip Pizlo <fpizlo@apple.com>
GC invoked while doing an old JIT property storage reallocation may lead
to an object that refers to a dead structure
https://bugs.webkit.org/show_bug.cgi?id=77273
<rdar://problem/10770565>
Reviewed by Gavin Barraclough.
The put_by_id transition was already saving the old structure by virtue of
having the object on the stack, so that wasn't going to get deleted. But the
new structure was unprotected in the transition. I've now changed the
transition code to save the new structure, ensuring that the GC will know it
to be marked if invoked from within put_by_id_transition_realloc.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC):
():
2012-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r106167.
http://trac.webkit.org/changeset/106167
https://bugs.webkit.org/show_bug.cgi?id=77264
broke LayoutTests/fast/js/string-capitalization.html
(Requested by msaboff on #webkit).
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
2012-01-27 Filip Pizlo <fpizlo@apple.com>
Build fix for interpreter platforms.
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
2012-01-27 Michael Saboff <msaboff@apple.com>
StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
https://bugs.webkit.org/show_bug.cgi?id=76647
Reviewed by Geoffrey Garen.
Changed stringProtoFuncToUpperCase to call StringImpl::upper() is a manor similar
to stringProtoFuncToLowerCase(). Fixed StringImpl::upper() to handle the two
8 bit characters that when converted to upper case become 16 bit characters.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase): Removed extra trailing whitespace.
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
2012-01-27 Hajime Morita <morrita@google.com>
[JSC] ThunkGenerators.cpp should hide its asm-defined symbols
https://bugs.webkit.org/show_bug.cgi?id=77244
Reviewed by Filip Pizlo.
* jit/ThunkGenerators.cpp: Added HIDE_SYMBOLS()
* wtf/InlineASM.h: Moved some duplicated macros from ThunkGenerators.cpp
2012-01-27 Simon Hausmann <simon.hausmann@nokia.com>
[JSC] Asm-originated symbols should be marked as hidden
https://bugs.webkit.org/show_bug.cgi?id=77150
Reviewed by Filip Pizlo.
* dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,
but they were missing in the CPU(X86) and the CPU(X86_64) cases.
2012-01-27 MORITA Hajime <morrita@google.com>
[JSC] Some JS_EXPORTDATA may not be necessary.
https://bugs.webkit.org/show_bug.cgi?id=77145
Reviewed by Darin Adler.
Removed JS_EXPORTDATA attributes whose attributing symbols are
not exported on Mac port.
* runtime/ExceptionHelpers.h:
(InterruptedExecutionError):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/RegExp.h:
(RegExp):
* runtime/RegExpMatchesArray.h:
(RegExpMatchesArray):
2012-01-27 MORITA Hajime <morrita@google.com>
[WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
https://bugs.webkit.org/show_bug.cgi?id=77113
Reviewed by Darin Adler.
* wtf/text/WTFString.h: Removed some WTF_EXPORT_PRIVATE attributes which we don't need to export.
2012-01-27 Zeno Albisser <zeno@webkit.org>
[Qt][Mac] Build fails after adding ICU support (r105997).
https://bugs.webkit.org/show_bug.cgi?id=77118
Use Apple code path for unicode date formats on mac.
Reviewed by Tor Arne Vestbø.
* runtime/DatePrototype.cpp:
():
2012-01-27 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add a GKeyFile especialization to GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=77191
Reviewed by Martin Robinson.
* wtf/gobject/GOwnPtr.cpp:
(WTF::GKeyFile): Implement freeOwnedGPtr for GKeyFile.
* wtf/gobject/GOwnPtr.h: Add GKeyFile template.
* wtf/gobject/GTypedefs.h: Add forward declaration for GKeyFile.
2012-01-25 Yury Semikhatsky <yurys@chromium.org>
Web Inspector: should be possible to open function declaration from script popover
https://bugs.webkit.org/show_bug.cgi?id=76913
Added display function name and source location to the popover in scripts panel.
Now when a function is hovered user can navigate to its definition.
Reviewed by Pavel Feldman.
* JavaScriptCore/JavaScriptCore.exp
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSFunction.h:
(JSFunction):
2012-01-26 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed. Build fix, wx uses the Mac ICU headers so we must match Mac behavior.
* runtime/DatePrototype.cpp:
():
2012-01-26 Mark Hahnenberg <mhahnenberg@apple.com>
Merge AllocationSpace into MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=77116
Reviewed by Geoffrey Garen.
Merging AllocationSpace and MarkedSpace in preparation for future refactoring/enhancement to
MarkedSpace allocation.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/AllocationSpace.cpp: Removed.
* heap/AllocationSpace.h: Removed.
* heap/BumpSpace.h:
(BumpSpace):
* heap/Heap.h:
(JSC::Heap::objectSpace):
(Heap):
():
* heap/HeapBlock.h:
():
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::tryAllocateHelper):
(JSC):
(JSC::MarkedSpace::tryAllocate):
(JSC::MarkedSpace::allocateSlowCase):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlocks):
(TakeIfUnmarked):
(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue):
(JSC::MarkedSpace::shrink):
(GatherDirtyCells):
(JSC::GatherDirtyCells::returnValue):
(JSC::GatherDirtyCells::GatherDirtyCells):
(JSC::GatherDirtyCells::operator()):
(JSC::MarkedSpace::gatherDirtyCells):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC::MarkedSpace::blocks):
(JSC::MarkedSpace::forEachCell):
(JSC):
(JSC::MarkedSpace::allocate):
2012-01-26 Oliver Hunt <oliver@apple.com>
MSVC bug fix.
<rdar://problem/10703671> MSVC generates bad code for enum compare.
RS=Geoff
Make bitfield large enough to work around MSVC's desire to make enums
signed types.
* bytecode/CallLinkInfo.h:
(CallLinkInfo):
2012-01-26 Filip Pizlo <fpizlo@apple.com>
All DFG helpers that may call out to arbitrary JS code must know where they
were called from due to inlining and call stack walking
https://bugs.webkit.org/show_bug.cgi?id=77070
<rdar://problem/10750834>
Reviewed by Geoff Garen.
Changed the DFG to always record a code origin index in the tag of the argument
count (which we previously left blank for the benefit of LLInt, but is still
otherwise unused by the DFG), so that if we ever need to walk the stack accurately
we know where to start. In particular, if the current ExecState* points several
semantic call frames away from the true semantic call frame because we had
performed inlining, having the code origin index recorded means that we can reify
those call frames as necessary to give runtime/library code an accurate view of
the current JS state.
This required several large but mechanical changes:
- Calling a function from the DFG now plants a store32 instruction to store the
code origin index. But the indices of code origins were previously picked by
the DFG::JITCompiler after code generation completed. I changed this somewhat;
even though the code origins are put into the CodeBlock after code gen, the
code gen now knows a priori what their indices will be. Extensive assertions
are in place to ensure that the two don't get out of sync, in the form of the
DFG::CallBeginToken. Note that this mechanism has almost no effect on JS calls;
those don't need the code origin index set in the call frame because we can get
it by doing a binary search on the return PC.
- Stack walking now always calls trueCallFrame() first before beginning the walk,
since even the top call frame may be wrong. It still calls trueCallerFrame() as
before to get to the next frame, though trueCallerFrame() is now mostly a
wrapper around callerFrame()->trueCallFrame().
- Because the mechanism for getting the code origin of a call frame is bimodal
(either the call frame knows its code origin because the code origin index was
set, or it's necessary to use the callee frame's return PC), I put in extra
mechanisms to determine whether your caller, or your callee, corresponds to
a call out of C++ code. Previously we just had the host call flag, but this is
insufficient as it does not cover the case of someone calling JSC::call(). But
luckily we can determine this just by looking at the return PC: if the return
PC is in range of the ctiTrampiline, then two things are true: this call
frame's PC will tell you nothing about where you came from in your caller, and
the caller already knows where it's at because it must have set the code origin
index (unless it's not DFG code, in which case we don't care because there is
no inlining to worry about).
- During testing this revealed a simple off-by-one goof in DFG::ByteCodeParser's
inlining code, so I fixed it.
- Finally because I was tired of doing random #if's for checking if I should be
passing around an Instruction* or a ReturnAddressPtr, I created a class called
AbstractPC that holds whatever notion of a PC is appropriate for the current
execution environment. It's designed to work gracefully even if both the
interpreter and the JIT are compiled in, and should integrate nicely with the
LLInt.
This is neutral on all benchmarks and fixes some nasty corner-case regressions of
evil code that uses combinations of getters/setters and function.arguments.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOrigin):
(CodeBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(CallBeginToken):
(JSC::DFG::CallBeginToken::CallBeginToken):
(JSC::DFG::CallBeginToken::assertCodeOriginIndex):
(JSC::DFG::CallBeginToken::assertNoCodeOriginIndex):
(DFG):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):
(JSC::DFG::JITCompiler::nextCallBeginToken):
(JSC::DFG::JITCompiler::beginCall):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGOperations.cpp:
():
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/AbstractPC.cpp: Added.
(JSC):
(JSC::AbstractPC::AbstractPC):
* interpreter/AbstractPC.h: Added.
(JSC):
(AbstractPC):
(JSC::AbstractPC::AbstractPC):
(JSC::AbstractPC::hasJITReturnAddress):
(JSC::AbstractPC::jitReturnAddress):
(JSC::AbstractPC::hasInterpreterReturnAddress):
(JSC::AbstractPC::interpreterReturnAddress):
(JSC::AbstractPC::isSet):
(JSC::AbstractPC::operator!):
():
* interpreter/CallFrame.cpp:
(JSC):
(JSC::CallFrame::trueCallFrame):
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::abstractReturnPC):
(JSC::ExecState::codeOriginIndexForDFGWithInlining):
(ExecState):
(JSC::ExecState::trueCallFrame):
(JSC::ExecState::trueCallFrameFromVMCode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::findFunctionCallFrameFromVMCode):
* interpreter/Interpreter.h:
(Interpreter):
():
* jit/JITStubs.cpp:
(JSC):
():
* jit/JITStubs.h:
(JSC):
(JSC::returnAddressIsInCtiTrampoline):
* runtime/JSFunction.cpp:
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::getOwnPropertyDescriptor):
2012-01-26 Peter Varga <pvarga@webkit.org>
Fix build when VERBOSE_SPECULATION_FAILURE is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=77104
Reviewed by Filip Pizlo.
* dfg/DFGOperations.cpp:
():
2012-01-26 Michael Saboff <msaboff@apple.com>
String::latin1() should take advantage of 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=76646
Reviewed by Geoffrey Garen.
* wtf/text/WTFString.cpp:
(WTF::String::latin1): For 8 bit strings, use existing buffer
without conversion.
2012-01-26 Michael Saboff <msaboff@apple.com>
Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions
https://bugs.webkit.org/show_bug.cgi?id=76645
Reviewed by Geoffrey Garen.
* wtf/text/StringImpl.cpp:
(WTF::equalIgnoringCase): New LChar version.
(WTF::findInner): New helper function.
(WTF::StringImpl::find): Added 8 bit path.
(WTF::reverseFindInner): New helper funciton.
(WTF::StringImpl::reverseFind): Added 8 bit path.
(WTF::StringImpl::reverseFindIgnoringCase): Added 8 bit path.
* wtf/text/StringImpl.h:
(WTF):
2012-01-26 Csaba Osztrogonác <ossy@webkit.org>
[Qt][Win] One more speculative buildfix after r105970.
* JavaScriptCore.pri:
2012-01-26 Csaba Osztrogonác <ossy@webkit.org>
[Qt][Win] Speculative buildfix after r105970.
* JavaScriptCore.pri: Link lgdi for DeleteObject() and DeleteDC().
2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r105982.
http://trac.webkit.org/changeset/105982
https://bugs.webkit.org/show_bug.cgi?id=77090
breaks the world (Requested by WildFox on #webkit).
* wtf/MainThread.cpp:
(WTF):
* wtf/Platform.h:
* wtf/mac/MainThreadMac.mm:
(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
2012-01-26 Roland Takacs <takacs.roland@stud.u-szeged.hu>
[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309
Reviewed by Zoltan Herczeg.
These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread"
is moved from MainThreadMac.mm to the common MainThread.cpp to make
them available for other platforms.
Measurement results:
V8 speed-up: 1.071x as fast [From: 746.1ms To: 696.4ms ]
WindScorpion speed-up: 1.082x as fast [From: 3490.4ms To: 3226.7ms]
V8 Splay speed-up: 1.158x as fast [From: 145.8ms To: 125.9ms ]
Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
* wtf/MainThread.cpp:
(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
* wtf/Platform.h:
* wtf/mac/MainThreadMac.mm:
2012-01-26 Andy Estes <aestes@apple.com>
REGRESSION (r105555): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types
https://bugs.webkit.org/show_bug.cgi?id=77073
Reviewed by Ryosuke Niwa.
r105555 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined.
This should have been changed to OS(WINDOWS). This causes the
preprocessor to strip out Win32 data type overrides for deleteOwnedPtr,
causing allocations made by Win32 to be deleted by fastmalloc.
* wtf/OwnPtrCommon.h:
(WTF): Use OS(WINDOWS) instead of OS(WIN).
2012-01-25 Mark Rowe <mrowe@apple.com>
Attempted Mac build fix after r105939.
* runtime/DatePrototype.cpp: Don't #include unicode/udat.h on Mac or iOS.
It isn't used on these platforms and isn't available in the ICU headers
for Mac.
2012-01-25 Mark Rowe <mrowe@apple.com>
Build in to an alternate location when USE_STAGING_INSTALL_PATH is set.
<rdar://problem/10609417> Adopt USE_STAGING_INSTALL_PATH
Reviewed by David Kilzer.
* Configurations/Base.xcconfig: Define NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR, which contains
the path where JavaScriptCore is normally installed. Update JAVASCRIPTCORE_FRAMEWORKS_DIR
to point to the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.
* Configurations/JavaScriptCore.xcconfig: Always set the framework's install name based on
the normal framework location. This prevents an incorrect install name from being used when
installing in to the staged frameworks directory.
2012-01-25 Eli Fidler <efidler@rim.com>
Implement Date.toLocaleString() using ICU
https://bugs.webkit.org/show_bug.cgi?id=76714
Reviewed by Darin Adler.
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
2012-01-25 Hajime Morita <morrita@google.com>
ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=76863
Reviewed by Dimitri Glazkov.
Added a feature flag.
* Configurations/FeatureDefines.xcconfig:
2012-01-25 Yong Li <yoli@rim.com>
[BlackBerry] Implement OSAllocator::commit/decommit.
BlackBerry port should support virtual memory decommiting.
https://bugs.webkit.org/show_bug.cgi?id=77013
Reviewed by Rob Buis.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
* wtf/Platform.h:
2012-01-24 Oliver Hunt <oliver@apple.com>
Make DFG update topCallFrame
https://bugs.webkit.org/show_bug.cgi?id=76969
Reviewed by Filip Pizlo.
Add NativeCallFrameTracer to manage topCallFrame assignment
in the DFG operations, and make use of it.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
():
* interpreter/Interpreter.h:
(JSC):
(NativeCallFrameTracer):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
2012-01-24 Filip Pizlo <fpizlo@apple.com>
Inlining breaks call frame walking when the walking is done from outside the inlinee,
but inside a code block that had inlining
https://bugs.webkit.org/show_bug.cgi?id=76978
<rdar://problem/10720904>
Reviewed by Oliver Hunt.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOriginForReturn):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
2012-01-24 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC
Reviewed by Oliver Hunt.
Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):
- Track live handle objects in a map.
(WTF::MetaAllocator::release):
- Removed support for handles with null m_allocator (no longer used).
- Notify the tracker of handles being released.
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
- Moved functionality out into MetaAllocator::release.
(WTF::MetaAllocatorHandle::shrink):
- Removed support for handles with null m_allocator (no longer used).
(WTF::MetaAllocator::MetaAllocator):
- Initialize m_tracker.
(WTF::MetaAllocator::allocate):
- Notify the tracker of new allocations.
* wtf/MetaAllocator.h:
(WTF::MetaAllocatorTracker::find):
- Lookup a MetaAllocatorHandle based on an address inside the allocation.
(WTF::MetaAllocator::trackAllocations):
- Register a callback object to track allocation state.
* wtf/MetaAllocatorHandle.h:
- Remove unused createSelfManagedHandle/constructor.
(WTF::MetaAllocatorHandle::key):
- Added, for use in RedBlackTree.
2012-01-24 Mark Hahnenberg <mhahnenberg@apple.com>
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665
Reviewed by Geoffrey Garen.
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
Also added a temporary variable to avoid warnings from GCC.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new. Also added a temporary variable to avoid warnings from GCC.
* runtime/JSObject.h:
2012-01-24 Geoffrey Garen <ggaren@apple.com>
JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861
Fixed two failing layout tests after my last patch.
Reviewed by Gavin Barraclough.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort): Call value() after calling toString(), as
in all other cases.
I missed this case because the JSString* type has a valid operator<,
so the compiler didn't complain.
2012-01-24 Kenichi Ishibashi <bashi@chromium.org>
[V8] Add Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=76803
Reviewed by Kenneth Russell.
* wtf/ArrayBufferView.h:
(WTF::ArrayBufferView::isUnsignedByteClampedArray): Added.
* wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::isUnsignedByteClampedArray): Overridden to return true.
2012-01-23 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add WebKitDownload to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72949
Reviewed by Martin Robinson.
* wtf/gobject/GOwnPtr.cpp:
(WTF::GTimer): Use g_timer_destroy() to free a GTimer.
* wtf/gobject/GOwnPtr.h: Add GTimer template.
* wtf/gobject/GTypedefs.h: Add GTimer forward declaration.
2012-01-24 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt LinuxSH4 build after r105698.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2012-01-23 Geoffrey Garen <ggaren@apple.com>
JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861
Reviewed by Gavin Barraclough.
This makes the common case -- toString() on a string -- faster and
inline-able. (Not a measureable speedup, but we can now remove a bunch
of duplicate hand-rolled code for this optimization.)
This also clarifies the boundary between "C++ strings" and "JS strings".
In all cases other than true, false, null, undefined, and multi-digit
numbers, the JS runtime was just retrieving a UString from a JSString,
so returning a JSString* is strictly better. In the other cases, we can
optimize to avoid creating a new JSString if we care to, but it doesn't
seem to be a big deal.
* JavaScriptCore.exp: Export!
* jsc.cpp:
(functionPrint):
(functionDebug):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):
* API/JSValueRef.cpp:
(JSValueToStringCopy):
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString): Call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".
* dfg/DFGOperations.cpp:
(JSC::DFG::operationValueAddNotNumber):
* jit/JITStubs.cpp:
(op_add): Updated for removal of toPrimitiveString():
all '+' operands can use toString(), except for object operands, which
need to take a slow path to call toPrimitive().
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
* runtime/DateConstructor.cpp:
(JSC::dateParse):
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Call value() after calling toString(), as above.
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::create): Simplified down to one canonical create()
function, to make string handling easier.
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/ExceptionHelpers.cpp:
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
* runtime/JSArray.cpp:
(JSC::JSArray::sort): Call value() after calling toString(), as above.
* runtime/JSCell.cpp:
* runtime/JSCell.h: Removed JSCell::toString() because JSValue does this
job now. Doing it in JSCell is slower (requires extra type checking), and
creates the misimpression that language-defined toString() behavior is
an implementation detail of JSCell.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape): Call value() after calling toString(), as above.
* runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::Stringifier):
(JSC::JSONProtoFuncParse): Removed some manual optimization that toString()
takes care of.
* runtime/JSObject.cpp:
(JSC::JSObject::toString):
* runtime/JSObject.h: Updated to return JSString*.
* runtime/JSString.cpp:
* runtime/JSString.h:
(JSC::JSValue::toString): Removed, since I removed JSCell::toString().
* runtime/JSValue.cpp:
(JSC::JSValue::toStringSlowCase): Removed toPrimitiveString(), and re-
spawned toStringSlowCase() from its zombie corpse, since toPrimitiveString()
basically did what we want all the time. (Note that the toPrimitive()
preference changes from NoPreference to PreferString, because that's
how ToString is defined in the language. op_add does not want this behavior.)
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString): A little simpler, now that toString()
returns a JSString*.
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable): More calls to value(), as above.
* runtime/Operations.cpp:
(JSC::jsAddSlowCase): Need to check for object before taking the toString()
fast path becuase adding an object to a string requires calling toPrimitive()
on the object, not toString(). (They differ in their preferred conversion
type.)
* runtime/Operations.h:
(JSC::jsString):
(JSC::jsStringFromArguments): This code gets simpler, now that toString()
does the right thing.
(JSC::jsAdd): Now checks for object, just like jsAddSlowCase().
* runtime/RegExpConstructor.cpp:
(JSC::setRegExpConstructorInput):
(JSC::constructRegExp):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString): More calls to value(), as above.
* runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
(JSC::callStringConstructor): This code gets simpler, now that toString()
does the right thing.
* runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString): Some of this code gets simpler, now that toString()
does the right thing. More calls to value(), as above.
2012-01-23 Luke Macpherson <macpherson@chromium.org>
Unreviewed, rolling out r105676.
http://trac.webkit.org/changeset/105676
https://bugs.webkit.org/show_bug.cgi?id=76665
Breaks build on max due to compile warnings.
* runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
2012-01-23 Mark Hahnenberg <mhahnenberg@apple.com>
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665
Reviewed by Geoffrey Garen.
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new.
* runtime/JSObject.h:
2012-01-23 Brian Weinstein <bweinstein@apple.com>
More build fixing after r105646.
* JavaScriptCore.exp:
2012-01-23 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC
Reviewed by Geoff Garen.
Step 2: generalize RedBlackTree. The profiler is going to want tio use
a RedBlackTree, allow this class to work with subclasses of
RedBlackTree::Node, Node should not need to know the names of the m_key
and m_value fields (the subclass can provide a key() accessor), and
RedBlackTree does not need to know anything about ValueType.
* JavaScriptCore.exp:
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
* wtf/MetaAllocator.h:
(WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
(WTF::MetaAllocator::FreeSpaceNode::key):
* wtf/MetaAllocatorHandle.h:
(WTF::MetaAllocatorHandle::key):
* wtf/RedBlackTree.h:
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):
2012-01-23 Andy Estes <aestes@apple.com>
Fix the build after r105635.
* JavaScriptCore.exp:
2012-01-23 Mark Hahnenberg <mhahnenberg@apple.com>
Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310
Reviewed by Sam Weinig.
Removed StackBounds and the stack() function from JSGlobalData since it no
longer accessed any members of JSGlobalData.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThread):
* parser/Parser.cpp:
(JSC::::Parser):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
2012-01-23 Gavin Barraclough <barraclough@apple.com>
Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855
Rubber stanmped by Geoff Garen.
Mechanical change - pass CodeBlock through to the executable allocator,
such that we will be able to map ranges of JIT code back to their owner.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
2012-01-23 Xianzhu Wang <wangxianzhu@chromium.org>
Basic enhancements to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67081
This change contains the following enhancements to StringBuilder,
for convenience, performance, testability, etc.:
- Change toStringPreserveCapacity() to const
- new public methods: capacity(), swap(), toAtomicString(), canShrink()
and append(const StringBuilder&)
- == and != opearators to compare StringBuilders and a StringBuilder/String
Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp
Reviewed by Darin Adler.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
(WTF::SubstringTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::add):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::canShrink):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::toAtomicString):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::capacity):
(WTF::StringBuilder::is8Bit):
(WTF::StringBuilder::swap):
(WTF::equal):
(WTF::operator==):
(WTF::operator!=):
* wtf/text/StringImpl.h:
2012-01-23 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck.
* GNUmakefile.list.am: Add missing files, remove deleted files and
fix indentation.
2012-01-22 Filip Pizlo <fpizlo@apple.com>
Build fix for non-DFG platforms that error out on warn-unused-parameter.
* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
* bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
2012-01-22 Filip Pizlo <fpizlo@apple.com>
Build fix for non-DFG platforms.
* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
* bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
2012-01-20 Filip Pizlo <fpizlo@apple.com>
DFG should not have code that directly decodes the states of old JIT inline
cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768
Reviewed by Sam Weinig.
Introduced new classes (like GetByIdStatus) that encapsulate the set of things
that the DFG would like to know about property accesses and calls. Whereas it
previously got this information by directly decoding the data structures used
by the old JIT for inline caching, it now uses these classes, which do the work
for it. This should make it somewhat more straight forward to introduce new
ways of profiling the same information.
Also hoisted StructureSet into bytecode/ from dfg/, because it's now used by
code in bytecode/.
Making this work right involved carefully ensuring that the heuristics for
choosing how to handle property accesses was at least as good as what we had
before, since I completely restructured that code. Currently the performance
looks neutral. Since I rewrote the code I did change some things that I never
liked before, like previously if a put_bu_id had executed exactly once then
we'd compile it as if it had taken slow-path. Executing once is special because
then the inline cache is not baked in, so there is no information about how the
DFG should optimize the code. Now this is rationalized: if the put_by_id does
not offer enough information to be optimized (i.e. had executed 0 or 1 times)
then we turn it into a forced OSR exit (i.e. a patch point). However, get_by_id
still has the old behavior; I left it that way because I didn't want to make
too many changes at once.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CallLinkStatus.cpp: Added.
(JSC::CallLinkStatus::computeFor):
* bytecode/CallLinkStatus.h: Added.
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(JSC::CallLinkStatus::couldTakeSlowPath):
(JSC::CallLinkStatus::callTarget):
* bytecode/GetByIdStatus.cpp: Added.
(JSC::GetByIdStatus::computeFor):
* bytecode/GetByIdStatus.h: Added.
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::state):
(JSC::GetByIdStatus::isSet):
(JSC::GetByIdStatus::operator!):
(JSC::GetByIdStatus::isSimpleDirect):
(JSC::GetByIdStatus::takesSlowPath):
(JSC::GetByIdStatus::makesCalls):
(JSC::GetByIdStatus::structureSet):
(JSC::GetByIdStatus::offset):
* bytecode/MethodCallLinkStatus.cpp: Added.
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/MethodCallLinkStatus.h: Added.
(JSC::MethodCallLinkStatus::MethodCallLinkStatus):
(JSC::MethodCallLinkStatus::isSet):
(JSC::MethodCallLinkStatus::operator!):
(JSC::MethodCallLinkStatus::needsPrototypeCheck):
(JSC::MethodCallLinkStatus::structure):
(JSC::MethodCallLinkStatus::prototypeStructure):
(JSC::MethodCallLinkStatus::function):
(JSC::MethodCallLinkStatus::prototype):
* bytecode/PutByIdStatus.cpp: Added.
(JSC::PutByIdStatus::computeFor):
* bytecode/PutByIdStatus.h: Added.
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::state):
(JSC::PutByIdStatus::isSet):
(JSC::PutByIdStatus::operator!):
(JSC::PutByIdStatus::isSimpleReplace):
(JSC::PutByIdStatus::isSimpleTransition):
(JSC::PutByIdStatus::takesSlowPath):
(JSC::PutByIdStatus::oldStructure):
(JSC::PutByIdStatus::newStructure):
(JSC::PutByIdStatus::structureChain):
(JSC::PutByIdStatus::offset):
* bytecode/StructureSet.h: Added.
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::clear):
(JSC::StructureSet::add):
(JSC::StructureSet::addAll):
(JSC::StructureSet::remove):
(JSC::StructureSet::contains):
(JSC::StructureSet::isSubsetOf):
(JSC::StructureSet::isSupersetOf):
(JSC::StructureSet::size):
(JSC::StructureSet::at):
(JSC::StructureSet::operator[]):
(JSC::StructureSet::last):
(JSC::StructureSet::predictionFromStructures):
(JSC::StructureSet::operator==):
(JSC::StructureSet::dump):
* dfg/DFGAbstractValue.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGStructureSet.h: Removed.
2012-01-20 Filip Pizlo <fpizlo@apple.com>
JIT compilation should not require ExecState
https://bugs.webkit.org/show_bug.cgi?id=76729
<rdar://problem/10731545>
Reviewed by Gavin Barraclough.
Changed the relevant JIT driver functions to take JSGlobalData& instead of
ExecState*, since really they just needed the global data.
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
2012-01-20 David Levin <levin@chromium.org>
Make OwnPtr<HDC> work for the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76738
Reviewed by Jian Li.
* JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnPtrWin.cpp to the
Chromium Windows build.
* wtf/OwnPtrCommon.h: Changed from platform WIN to OS WIN for
OwnPtr<HDC> and similar constructs.
2012-01-19 Geoffrey Garen <ggaren@apple.com>
Removed some regexp entry boilerplate code
https://bugs.webkit.org/show_bug.cgi?id=76687
Reviewed by Darin Adler.
1% - 2% speedup on regexp tests, no change overall.
* runtime/RegExp.cpp:
(JSC::RegExp::match):
- ASSERT that our startIndex is non-negative, because anything less
would be uncivilized.
- ASSERT that our input is not the null string for the same reason.
- No need to test for startOffset being past the end of the string,
since the regular expression engine will do this test for us.
- No need to initialize the output vector, since the regular expression
engine will fill it in for us.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::interpret):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
RegExp used to do these jobs for us, but now we do them for ourselves
because it's a better separation of concerns, and the JIT can do them
more efficiently than C++ code:
- Test for "past the end" before doing any matching -- otherwise
a* will match with zero length past the end of the string, which is wrong.
- Initialize the output vector before doing any matching.
2012-01-20 Filip Pizlo <fpizlo@apple.com>
Build fix for no-DFG configuration.
Needed for <rdar://problem/10727689>.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfiledOpcode):
* jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
2012-01-19 Filip Pizlo <fpizlo@apple.com>
Bytecode instructions that may have value profiling should have a direct inline
link to the ValueProfile instance
https://bugs.webkit.org/show_bug.cgi?id=76682
<rdar://problem/10727689>
Reviewed by Sam Weinig.
Each opcode that gets value profiled now has a link to its ValueProfile. This
required rationalizing the emission of value profiles for opcode combos, like
op_method_check/op_get_by_id and op_call/op_call_put_result. It only makes
sense for one of them to have a value profile link, and it makes most sense
for it to be the one that actually sets the result. The previous behavior was
to have op_method_check profile for op_get_by_id when they were used together,
but otherwise for op_get_by_id to have its own profiles. op_call already did
the right thing; all profiling was done by op_call_put_result.
But rationalizing this code required breaking some of the natural boundaries
that the code had; for instance the code in DFG that emits a GetById in place
of both op_method_check and op_get_by_id must now know that it's the latter of
those that has the value profile, while the first of those constitutes the OSR
target. Hence each CodeOrigin must now have two bytecode indices - one for
OSR exit and one for profiling.
Finally this change required some refiddling of our optimization heuristics,
because now all code blocks have "more instructions" due to the value profile
slots.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfileForBytecodeOffset):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::bytecodeIndexForValueProfile):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
* jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
* jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
* runtime/Options.cpp:
(JSC::Options::initializeOptions):
2012-01-20 ChangSeok Oh <shivamidow@gmail.com>
undefined reference to symbol eina_module_free
https://bugs.webkit.org/show_bug.cgi?id=76681
Reviewed by Martin Robinson.
eina_module_free has been used without including eina libraries after r104936.
* wtf/PlatformEfl.cmake: Add EINA_LIBRARIES.
2012-01-19 Tony Chang <tony@chromium.org>
[chromium] Remove an obsolete comment about features.gypi
https://bugs.webkit.org/show_bug.cgi?id=76643
There can be only one features.gypi.
Reviewed by James Robinson.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2012-01-19 Geoffrey Garen <ggaren@apple.com>
Implicit creation of a regular expression should eagerly check for syntax errors
https://bugs.webkit.org/show_bug.cgi?id=76642
Reviewed by Oliver Hunt.
This is a correctness fix and a slight optimization.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch): Check for syntax errors because that's the
correct behavior.
* runtime/RegExp.cpp:
(JSC::RegExp::match): ASSERT that we aren't a syntax error. (One line
of code change, many lines of indentation change.)
Since we have no clients that try to match a RegExp that is a syntax error,
let's optimize out the check.
2012-01-19 Mark Hahnenberg <mhahnenberg@apple.com>
Implement a new allocator for backing stores
https://bugs.webkit.org/show_bug.cgi?id=75181
Reviewed by Filip Pizlo.
We want to move away from using fastMalloc for the backing stores for
some of our objects (e.g. JSArray, JSObject, JSString, etc). These backing
stores have a nice property in that they only have a single owner (i.e. a
single pointer to them at any one time). One way that we can take advantage
of this property is to implement a simple bump allocator/copying collector,
which will run alongside our normal mark/sweep collector, that only needs to
update the single owner pointer rather than having to redirect an arbitrary
number of pointers in from-space to to-space.
This plan can give us a number of benefits. We can beat fastMalloc in terms
of both performance and memory usage, we can track how much memory we're using
far more accurately than our rough estimation now through the use of
reportExtraMemoryCost, and we can allocate arbitrary size objects (as opposed
to being limited to size classes like we have been historically). This is also
another step toward moving away from lazy destruction, which will improve our memory footprint.
We start by creating said allocator and moving the ArrayStorage for JSArray
to use it rather than fastMalloc.
The design of the collector is as follows:
Allocation:
-The collector allocates 64KB chunks from the OS to use for object allocation.
-Each chunk contains an offset, a flag indicating if the block has been pinned,
and a payload, along with next and prev pointers so that they can be put in DoublyLinkedLists.
-Any allocation greater than 64KB gets its own separate oversize block, which
is managed separately from the rest.
-If the allocator receives a request for more than the remaining amount in the
current block, it grabs a fresh block.
-Grabbing a fresh block means grabbing one off of the global free list (which is now
shared between the mark/sweep allocator and the bump allocator) if there is one.
If there isn't a new one we do one of two things: allocate a new block from the OS
if we're not ready for a GC yet, or run a GC and then try again. If we still don't
have enough space after the GC, we allocate a new block from the OS.
Garbage collection:
-At the start of garbage collection during conservative stack scanning, if we encounter
what appears to be a pointer to a bump-allocated block of memory, we pin that block so
that it will not be copied for this round of collection.
-We also pin any oversize blocks that we encounter, which effectively doubles as a
"mark bit" for that block. Any oversize blocks that aren't pinned at the end of copying
are given back to the OS.
-Marking threads are now also responsible for copying bump-allocated objects to newSpace
-Each marking thread has a private 64KB block into which it copies bump-allocated objects that it encounters.
-When that block fills up, the marking thread gives it back to the allocator and requests a new one.
-When all marking has concluded, each thread gives back its copy block, even if it isn't full.
-At the conclusion of copying (which is done by the end of the marking phase), we un-pin
any pinned blocks and give any blocks left in from-space to the global free list.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
* heap/AllocationSpace.h:
(JSC::AllocationSpace::waterMark):
* heap/BumpBlock.h: Added.
(JSC::BumpBlock::BumpBlock):
* heap/BumpSpace.cpp: Added.
(JSC::BumpSpace::tryAllocateSlowCase):
* heap/BumpSpace.h: Added.
(JSC::BumpSpace::isInCopyPhase):
(JSC::BumpSpace::totalMemoryAllocated):
(JSC::BumpSpace::totalMemoryUtilized):
* heap/BumpSpaceInlineMethods.h: Added.
(JSC::BumpSpace::BumpSpace):
(JSC::BumpSpace::init):
(JSC::BumpSpace::contains):
(JSC::BumpSpace::pin):
(JSC::BumpSpace::startedCopying):
(JSC::BumpSpace::doneCopying):
(JSC::BumpSpace::doneFillingBlock):
(JSC::BumpSpace::recycleBlock):
(JSC::BumpSpace::getFreshBlock):
(JSC::BumpSpace::borrowBlock):
(JSC::BumpSpace::addNewBlock):
(JSC::BumpSpace::allocateNewBlock):
(JSC::BumpSpace::fitsInBlock):
(JSC::BumpSpace::fitsInCurrentBlock):
(JSC::BumpSpace::tryAllocate):
(JSC::BumpSpace::tryAllocateOversize):
(JSC::BumpSpace::allocateFromBlock):
(JSC::BumpSpace::tryReallocate):
(JSC::BumpSpace::tryReallocateOversize):
(JSC::BumpSpace::isOversize):
(JSC::BumpSpace::isPinned):
(JSC::BumpSpace::oversizeBlockFor):
(JSC::BumpSpace::blockFor):
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::add):
* heap/ConservativeRoots.h:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
(JSC::Heap::releaseFreeBlocks):
* heap/Heap.h:
(JSC::Heap::waterMark):
(JSC::Heap::highWaterMark):
(JSC::Heap::setHighWaterMark):
(JSC::Heap::tryAllocateStorage):
(JSC::Heap::tryReallocateStorage):
* heap/HeapBlock.h: Added.
(JSC::HeapBlock::HeapBlock):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::copy):
(JSC::SlotVisitor::copyAndAppend):
(JSC::SlotVisitor::doneCopying):
* heap/MarkStack.h:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::resetAllocator):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::SlotVisitor):
* heap/TinyBloomFilter.h:
(JSC::TinyBloomFilter::reset):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):
(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::~JSArray):
(JSC::JSArray::enterSparseMode):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::visitChildren):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(JSC::JSArray::inSparseMode):
(JSC::JSArray::isLengthWritable):
* wtf/CheckedBoolean.h: Added.
(CheckedBoolean::CheckedBoolean):
(CheckedBoolean::~CheckedBoolean):
(CheckedBoolean::operator bool):
* wtf/DoublyLinkedList.h:
(WTF::::push):
* wtf/StdLibExtras.h:
(WTF::isPointerAligned):
2012-01-19 Joi Sigurdsson <joi@chromium.org>
Enable use of precompiled headers in Chromium port on Windows.
Bug 76381 - Use precompiled headers in Chromium port on Windows
https://bugs.webkit.org/show_bug.cgi?id=76381
Reviewed by Tony Chang.
* JavaScriptCore.gyp/JavaScriptCore.gyp: Include WinPrecompile.gypi.
2012-01-18 Roland Takacs <takacs.roland@stud.u-szeged.hu>
Cross-platform processor core counter fix
https://bugs.webkit.org/show_bug.cgi?id=76540
Reviewed by Zoltan Herczeg.
I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)"
and I removed the OS checking macros from ParallelJobsGeneric.cpp because
the NumberOfCores.cpp contains them for counting CPU cores.
The processor core counter patch located at
https://bugs.webkit.org/show_bug.cgi?id=76530
* wtf/NumberOfCores.cpp:
* wtf/ParallelJobsGeneric.cpp:
2012-01-18 Csaba Osztrogonác <ossy@webkit.org>
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Unreviewed cross-MinGW buildfix after r105270.
* wtf/NumberOfCores.cpp: Use windows.h instead of Windows.h.
2012-01-18 Roland Takacs <takacs.roland@stud.u-szeged.hu>
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Reviewed by Zoltan Herczeg.
Two files have been created that include the processor core counter function.
It used to be in ParallelJobsGeneric.h/cpp before.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Options.cpp:
(JSC::Options::initializeOptions):
* wtf/CMakeLists.txt:
* wtf/NumberOfCores.cpp: Added.
(WTF::numberOfProcessorCores):
* wtf/NumberOfCores.h: Added.
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
* wtf/ParallelJobsGeneric.h:
2012-01-18 Balazs Kelemen <kbalazs@webkit.org>
[Qt] Consolidate layout test crash logging
https://bugs.webkit.org/show_bug.cgi?id=75088
Reviewed by Simon Hausmann.
Move backtrace generating logic into WTFReportBacktrace
and add a way to deinstall signal handlers if we know
that we have already printed the backtrace.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/Assertions.cpp:
(WTFLogLocker::WTFReportBacktrace):
(WTFLogLocker::WTFSetCrashHook):
(WTFLogLocker::WTFInvokeCrashHook):
* wtf/Assertions.h:
2012-01-17 Geoffrey Garen <ggaren@apple.com>
Factored out some code into a helper function.
I think this might help getting rid of omit-frame-pointer.
Reviewed by Sam Weinig.
No benchmark change.
* runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch): Moved to here...
(JSC::replaceUsingRegExpSearch): ...from here.
2012-01-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=74455
Reviewed by Filip Pizlo.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isUint8ClampedArrayPrediction):
(JSC::isActionableMutableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateUint8ClampedArray):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::clampDoubleToByte):
(JSC::DFG::compileClampIntegerToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSCell.h:
* runtime/JSGlobalData.h:
* wtf/Forward.h:
* wtf/Uint8Array.h:
* wtf/Uint8ClampedArray.h: Added.
(WTF::Uint8ClampedArray::set):
(WTF::Uint8ClampedArray::create):
(WTF::Uint8ClampedArray::Uint8ClampedArray):
(WTF::Uint8ClampedArray::subarray):
2012-01-17 Sam Weinig <sam@webkit.org>
Add helper macro for forward declaring objective-c classes
https://bugs.webkit.org/show_bug.cgi?id=76485
Reviewed by Anders Carlsson.
* wtf/Compiler.h:
Add OBJC_CLASS macro which helps reduce code when forward declaring an
objective-c class in a header which can be included from both Objective-C
and non-Objective-C files.
2012-01-17 Filip Pizlo <fpizlo@apple.com>
DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361
Reviewed by Csaba Osztrogonác.
Fix for 32-bit.
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2012-01-15 Filip Pizlo <fpizlo@apple.com>
DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361
<rdar://problem/10698060>
Reviewed by Geoff Garen.
Added the ability to cache JS getter calls and custom getter calls in the DFG.
Most of this is pretty mundane, since the old JIT supported this functionality
as well. But a couple interesting things had to happen:
- There are now two variants of GetById: GetById, which works as before, and
GetByIdFlush, which flushes registers prior to doing the GetById. Only
GetByIdFlush can be used for caching getters. We detect which GetById style
to use by looking at the inline caches of the old JIT.
- Exception handling for getter calls planted in stubs uses a separate lookup
handler routine, which uses the CodeOrigin stored in the StructureStubInfo.
This is a 40% speed-up in the Dromaeo DOM Traversal average. It removes all of
the DFG regressions we saw in Dromaeo. This is neutral on SunSpider, V8, and
Kraken.
* bytecode/StructureStubInfo.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::willNeedFlush):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupResults):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::JITCompiler::addExceptionCheck):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
2012-01-16 Jon Lee <jonlee@apple.com>
Build fix for r105086.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2012-01-16 Jon Lee <jonlee@apple.com>
Remove HTML notifications support on Mac
https://bugs.webkit.org/show_bug.cgi?id=76401
<rdar://problem/10589881>
Reviewed by Sam Weinig.
* wtf/Platform.h: Define ENABLE_HTML_NOTIFICATIONS macro.
2012-01-16 Zeno Albisser <zeno@webkit.org>
[Qt] Fix QT_VERSION related warnings when building on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=76340
This bug was caused by r104826.
As already mentioned for https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.
Reviewed by Tor Arne Vestbø.
* wtf/Platform.h:
2012-01-16 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck.
* GNUmakefile.list.am: Fix typo.
2012-01-16 Pavel Heimlich <tropikhajma@gmail.com>
Solaris Studio supports alignment macros too
https://bugs.webkit.org/show_bug.cgi?id=75453
Reviewed by Hajime Morita.
* wtf/Alignment.h:
2012-01-16 Yuqiang Xian <yuqiang.xian@intel.com>
Build fix on 32bit if verbose debug is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=76351
Reviewed by Hajime Morita.
Mostly change "%lu" to "%zu" to print a "size_t" variable.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
2012-01-15 Filip Pizlo <fpizlo@apple.com>
The C calling convention logic in DFG::SpeculativeJIT should be available even
when not generating code for the DFG speculative path
https://bugs.webkit.org/show_bug.cgi?id=76355
Reviewed by Dan Bernstein.
Moved all of the logic for placing C call arguments into the right place (stack
or registers) into a new class, DFG::CCallHelpers. This class inherits from
AssemblyHelpers, another DFG grab-bag of helper functions. I could have moved
this code into AssemblyHelpers, but decided against it, because I wanted to
limit the number of methods each class in the JIT has. Hence now we have a
slightly odd organization of JIT classes in DFG: MacroAssembler (basic instruction
emission) <= AssemblyHelpers (some additional JS smarts) <= CCallHelpers
(understands calls to C functions) <= JITCompiler (can compile a graph to machine
code). Each of these except for JITCompiler can be reused for stub compilation.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGCCallHelpers.h: Added.
(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
2012-01-15 Pablo Flouret <pablof@motorola.com>
Fix compilation errors on build-webkit --debug --no-video on mac.
https://bugs.webkit.org/show_bug.cgi?id=75867
Reviewed by Philippe Normand.
Make ENABLE_VIDEO_TRACK conditional on ENABLE_VIDEO, video track feature
doesn't build without video.
* wtf/Platform.h:
2012-01-14 David Levin <levin@chromium.org>
HWndDC should be in platform/win instead of wtf.
https://bugs.webkit.org/show_bug.cgi?id=76314
Reviewed by Sam Weinig.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
2012-01-13 David Levin <levin@chromium.org>
check-webkit-style: should encourage the use of Own* classes for Windows DC.
https://bugs.webkit.org/show_bug.cgi?id=76227
Reviewed by Dirk Pranke.
* wtf/win/HWndDCWin.h:
(WTF::HwndDC::HwndDC): Add a way to do GetDCEx.
There are no users, but I want to catch this in check-webkit-style
and tell any users to use HwndDC to avoid leaks.
2012-01-13 David Levin <levin@chromium.org>
Header file is missing header guard.
Reviewed by Dirk Pranke.
* wtf/win/HWndDCWin.h: Added the guards.
2012-01-13 Andy Wingo <wingo@igalia.com>
Eval in strict mode does not need dynamic checks
https://bugs.webkit.org/show_bug.cgi?id=76286
Reviewed by Oliver Hunt.
* runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):
Eval in strict mode cannot introduce variables, so it not impose
the need for dynamic checks.
2012-01-13 David Levin <levin@chromium.org>
HWndDC is a better name than HwndDC.
https://bugs.webkit.org/show_bug.cgi?id=76281
Reviewed by Darin Adler.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* wtf/win/HWndDCWin.h: Renamed from Source/JavaScriptCore/wtf/win/HwndDCWin.h.
(WTF::HWndDC::HWndDC):
(WTF::HWndDC::~HWndDC):
(WTF::HWndDC::operator HDC):
2012-01-13 YoungTaeck Song <youngtaeck.song@samsung.com>
[EFL] Add OwnPtr specialization for Eina_Module.
https://bugs.webkit.org/show_bug.cgi?id=76255
Reviewed by Andreas Kling.
Add an overload for deleteOwnedPtr(Eina_Module*) on EFL port.
* wtf/OwnPtrCommon.h:
* wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
2012-01-13 Yuqiang Xian <yuqiang.xian@intel.com>
Unreviewed build fix after r104787 if JIT_VERBOSE_OSR is defined
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2012-01-12 Hajime Morrita <morrita@chromium.org>
JavaScriptCore: Mark all exported symbols in the header file automatically.
https://bugs.webkit.org/show_bug.cgi?id=72855
Reviewed by Darin Adler.
Added WTF_EXPORT_PRIVATE and JS_EXPORT_PRIVATE based on JavaScriptCore.exp files.
The change is generated by a tool calledListExportables (https://github.com/omo/ListExportables)
* API/OpaqueJSString.h:
* bytecode/CodeBlock.h:
* bytecode/SamplingTool.h:
* debugger/Debugger.h:
* debugger/DebuggerActivation.h:
* debugger/DebuggerCallFrame.h:
* heap/AllocationSpace.h:
* heap/HandleHeap.h:
* heap/Heap.h:
* heap/MachineStackMarker.h:
* heap/MarkStack.h:
* heap/VTableSpectrum.h:
* heap/WriteBarrierSupport.h:
* parser/Nodes.h:
* parser/ParserArena.h:
* profiler/Profile.h:
* runtime/ArgList.h:
* runtime/CallData.h:
* runtime/Completion.h:
* runtime/ConstructData.h:
* runtime/DateInstance.h:
* runtime/Error.h:
* runtime/ExceptionHelpers.h:
* runtime/FunctionConstructor.h:
* runtime/Identifier.h:
* runtime/InitializeThreading.h:
* runtime/InternalFunction.h:
* runtime/JSArray.h:
* runtime/JSByteArray.h:
* runtime/JSCell.h:
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.h:
* runtime/JSGlobalThis.h:
* runtime/JSLock.h:
* runtime/JSObject.h:
* runtime/JSString.h:
* runtime/JSValue.h:
* runtime/JSVariableObject.h:
* runtime/Lookup.h:
* runtime/MemoryStatistics.h:
* runtime/ObjectPrototype.h:
* runtime/Options.h:
* runtime/PropertyDescriptor.h:
* runtime/PropertyNameArray.h:
* runtime/PropertySlot.h:
* runtime/RegExp.h:
* runtime/RegExpObject.h:
* runtime/SamplingCounter.h:
* runtime/SmallStrings.h:
* runtime/StringObject.h:
* runtime/Structure.h:
* runtime/TimeoutChecker.h:
* runtime/UString.h:
* runtime/WriteBarrier.h:
* wtf/ArrayBufferView.h:
* wtf/ByteArray.h:
* wtf/CryptographicallyRandomNumber.h:
* wtf/CurrentTime.h:
* wtf/DateMath.h:
* wtf/DecimalNumber.h:
* wtf/FastMalloc.cpp:
* wtf/FastMalloc.h:
* wtf/MD5.h:
* wtf/MainThread.h:
* wtf/MetaAllocator.h:
* wtf/MetaAllocatorHandle.h:
* wtf/OSAllocator.h:
* wtf/PageBlock.h:
* wtf/RandomNumber.h:
* wtf/RefCountedLeakCounter.h:
* wtf/SHA1.h:
* wtf/Threading.cpp:
* wtf/Threading.h:
* wtf/ThreadingPrimitives.h:
* wtf/WTFThreadData.h:
* wtf/dtoa.h:
* wtf/text/AtomicString.h:
* wtf/text/CString.h:
* wtf/text/StringBuilder.h:
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:
* wtf/unicode/Collator.h:
* wtf/unicode/UTF8.h:
* yarr/Yarr.h:
* yarr/YarrPattern.h:
2012-01-12 MORITA Hajime <morrita@google.com>
[Chromium] JSExportMacros.h should be visible.
https://bugs.webkit.org/show_bug.cgi?id=76147
Reviewed by Tony Chang.
* config.h:
2012-01-12 David Levin <levin@chromium.org>
HwndDC is a better name than OwnGetDC.
https://bugs.webkit.org/show_bug.cgi?id=76235
Reviewed by Dmitry Titov.
This is a better name for two reasons:
1. "Own" implies "delete". In this case, the final call is a release (ReleaseDC).
2. "Ref" would be a better name due to the release but the RefPtr (and OwnPtr)
classes always take something to hold on to. In this case, the object (the DC)
is created by the class once it is given a Window to ensure that the HDC
was actually created using GetDC.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* wtf/win/HwndDCWin.h: Renamed from Source/JavaScriptCore/wtf/win/OwnGetDCWin.h.
(WTF::HwndDC::HwndDC):
(WTF::HwndDC::~HwndDC):
(WTF::HwndDC::operator HDC):
2012-01-12 Gavin Barraclough <barraclough@apple.com>
Clean up putDirect (part 2)
https://bugs.webkit.org/show_bug.cgi?id=76232
Reviewed by Sam Weinig.
Rename putWithAttributes to putDirectVirtual, to identify that this
has the same unchecked-DefineOwnProperty behaviour, change putDirectInternal
to be templated on an enum indicating which behaviour it is supposed to be
implementing, and change clients that are defining properties to call
putDirectInternal correctly.
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::putDirectVirtual):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/ClassInfo.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/JSActivation.cpp:
(JSC::JSActivation::putDirectVirtual):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putDirectVirtual):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putDirectVirtual):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::putDirectVirtual):
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::putDirectVirtual):
* runtime/JSVariableObject.h:
2012-01-12 Gavin Barraclough <barraclough@apple.com>
Clean up putDirect (part 1)
https://bugs.webkit.org/show_bug.cgi?id=76232
Reviewed by Sam Weinig.
putDirect has ambiguous semantics, clean these up a bit.
putDirect generally behaves a bit like a fast defineOwnProperty, but one that
always creates the property, with no checking to validate the put it permitted.
It also encompasses two slightly different behaviors.
(1) a fast form of put for JSActivation, which doesn't have to handle searching
the prototype chain, getter/setter properties, or the magic __proto__ value.
Break this out as a new method, 'putOwnDataProperty'.
(2) the version of putDirect on JSValue will also check for overwriting ReadOnly
values, in strict mode. This is, however, not so smart on a few level, since
it is only called from op_put_by_id with direct set, which is only used with
an object as the base, and is only used to put new properties onto objects.
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSActivation.cpp:
(JSC::JSActivation::put):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSObject.h:
(JSC::JSObject::putOwnDataProperty):
* runtime/JSValue.h:
2012-01-12 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=76141
defineSetter/defineGetter may fail to update Accessor attribute
Reviewed by Oliver Hunt.
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):
* runtime/Structure.cpp:
(JSC::Structure::attributeChangeTransition):
* runtime/Structure.h:
2012-01-12 David Levin <levin@chromium.org>
[chromium] Fix DC leak in WebScreenInfoFactory.
https://bugs.webkit.org/show_bug.cgi?id=76203
Reviewed by Dmitry Titov.
* JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnGetDCWin.h
* JavaScriptCore.gypi: Added OwnGetDCWin.h
* JavaScriptCore/wtf/win/OwnGetDCWin.h: Made an owner class for GetDC which needs ReleaseDC as opposed to DeleteDC.
2012-01-11 Gavin Barraclough <barraclough@apple.com>
Allow accessor get/set property to be set to undefined
https://bugs.webkit.org/show_bug.cgi?id=76148
Reviewed by Oliver Hunt.
AccessorDescriptor properties may have their get & set properties defined to reference a function
(Callable object) or be set to undefined. Valid PropertyDescriptors created by toPropertyDescriptor
(defined from JS code via Object.defineProperty, etc) have get and set properties that are in one of
three states (1) nonexistent, (2) set to undefined, or (3) a function (any Callable object).
On the PropertyDescriptor object these three states are represneted by JSValue(), jsUndefined(), and
any JSObject* (with a constraint that this must be callable).
Logically the get/set property of an accessor descriptor on an object might be in any of the three
states above, but in practice there is no way to distinguish between the first two states. As such
we stor the get/set values in property storage in a JSObject* field, with 0 indicating absent or
undefined. When unboxing to a PropertyDescriptor, map this back to a JS undefined value.
* runtime/GetterSetter.h:
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):
- Allow the getter/setter to be cleared.
* runtime/JSArray.cpp:
(JSC::JSArray::putDescriptor):
- Changed to call getterObject/setterObject.
(JSC::JSArray::defineOwnNumericProperty):
- Added ASSERT.
* runtime/JSObject.cpp:
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
- Changed to call getterObject/setterObject.
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptor):
- getter/setter values read from properties on object are never missing, they will now be set as undefined by 'setDescriptor'.
(JSC::toPropertyDescriptor):
- Do not translate undefined->empty, this loses an important distinction between a get/set property being absent, or being explicitly set to undefined.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::getterObject):
(JSC::PropertyDescriptor::setterObject):
- Accessors to convert the get/set property to an object pointer, converting undefined to 0.
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
- Translate a getter/setter internally represented at 0 to undefined, indicating that it is present.
* runtime/PropertyDescriptor.h:
- Declare getterObject/setterObject.
2012-01-12 Zeno Albisser <zeno@webkit.org>
[Qt][WK2][Mac] Conflict of MacTypes.h defining a Fixed type after r104560.
https://bugs.webkit.org/show_bug.cgi?id=76175
Defining ENABLE_CSS_FILTERS leads to ambiguous references
due to MacTypes.h being included.
Defining CF_OPEN_SOURCE works around this problem.
Reviewed by Simon Hausmann.
* wtf/Platform.h:
2012-01-12 Simon Hausmann <simon.hausmann@nokia.com>
Make the new WTF module build on Qt
https://bugs.webkit.org/show_bug.cgi?id=76163
Reviewed by Tor Arne Vestbø.
* JavaScriptCore.pro: Removed wtf from the subdirs to build.
2012-01-11 Filip Pizlo <fpizlo@apple.com>
CodeBlock::m_executeCounter should be renamed to CodeBlock::m_jitExecuteCounter
https://bugs.webkit.org/show_bug.cgi?id=76144
<rdar://problem/10681711>
Rubber stamped by Gavin Barraclough.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
2012-01-11 Gavin Barraclough <barraclough@apple.com>
Merge 'Getter'/'Setter' attributes into 'Accessor'
https://bugs.webkit.org/show_bug.cgi?id=76141
Reviewed by Filip Pizlo.
These are currently ambiguous (and used inconsistently). It would logically appear
that either being bit set implies that the corresponding type of accessor is present
but (a) we don't correctly enforce this, and (b) this means the attributes would not
be able to distinguish between a data descriptor and an accessor descriptor with
neither a getter nor setter defined (which is a descriptor permissible under the spec).
This ambiguity would lead to unsafe property caching behavior (though this does not
represent an actual current bug, since we are currently unable to create descriptors
that have neither a getter nor setter, it just prevents us from doing so).
* runtime/Arguments.cpp:
(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::putDescriptor):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperty):
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
(JSC::PropertyDescriptor::setSetter):
(JSC::PropertyDescriptor::setGetter):
(JSC::PropertyDescriptor::attributesOverridingCurrent):
2012-01-11 Gavin Barraclough <barraclough@apple.com>
Object.defineProperty([], 'length', {}) should not make length read-only
https://bugs.webkit.org/show_bug.cgi?id=76097
Reviewed by Oliver Hunt.
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- We should be checking writablePresent().
2012-01-11 Filip Pizlo <fpizlo@apple.com>
Code duplication for invoking the JIT and DFG should be reduced
https://bugs.webkit.org/show_bug.cgi?id=76117
<rdar://problem/10680189>
Rubber stamped by Geoff Garen.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITDriver.h: Added.
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
2012-01-11 Geoffrey Garen <ggaren@apple.com>
Bytecode dumping is broken for call opcodes (due to two new operands)
https://bugs.webkit.org/show_bug.cgi?id=75886
Reviewed by Oliver Hunt.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printCallOp): Made a helper function, so I wouldn't have
to fix this more than once. The helper function skips the extra two operands
at the end of the opcode, used for optimization.
(JSC::CodeBlock::dump): Used the helper function.
* bytecode/CodeBlock.h: Declared the helper function.
2012-01-09 Geoffrey Garen <ggaren@apple.com>
REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
https://bugs.webkit.org/show_bug.cgi?id=75911
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNodeForLeftHandSide): Cleanup: No need to
explicitly cast to our return type in C++.
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode): Make sure to copy our function
into a temporary register before evaluating our arguments, since argument
evaluation might include function calls or assignments that overwrite our callee by name.
2012-01-11 Michael Saboff <msaboff@apple.com>
v8-regexp spends 35% of its time allocating and copying internal regexp results data
https://bugs.webkit.org/show_bug.cgi?id=76079
Reviewed by Geoffrey Garen.
Added a new RegExpResults struct that has the input string, the number of
subexpressions and the output vector. Changed RegExpConstructor to
include a RegExpConstructorPrivate instead of having a reference to one.
Changed RegExpMatchesArray to include a RegExpResults instead of a
reference to a RegExpConstructorPrivate. Created an overloaded assignment
operator to assign a RegExpConstructorPrivate to a RegExpResults.
Collectively this change is worth 24% performance improvement to v8-regexp.
* runtime/RegExpConstructor.cpp:
(JSC::RegExpResult::operator=):
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):
(JSC::RegExpMatchesArray::~RegExpMatchesArray):
(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::arrayOfMatches):
(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):
(JSC::RegExpConstructor::setInput):
(JSC::RegExpConstructor::input):
(JSC::RegExpConstructor::setMultiline):
(JSC::RegExpConstructor::multiline):
* runtime/RegExpConstructor.h:
(JSC::RegExpResult::RegExpResult):
(JSC::RegExpConstructor::performMatch):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):
2012-01-11 Eugene Girard <girard@google.com>
Typo in error message: Unexpected token 'defualt'
https://bugs.webkit.org/show_bug.cgi?id=75105
Reviewed by Simon Fraser.
* parser/Parser.h:
(JSC::Parser::getTokenName):
2012-01-11 Anders Carlsson <andersca@apple.com>
Assertion failure in JSC::allocateCell trying to allocate a JSString
https://bugs.webkit.org/show_bug.cgi?id=76101
Reviewed by Adam Roben.
Remove the ExecutableBase::s_info and JSString::s_info static member variables from the .def file and
export them explicitly using the JS_EXPORTDATA macro.
member variables explicitly using
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Executable.h:
* runtime/JSString.h:
2012-01-10 Mark Rowe <mrowe@apple.com>
<rdar://problem/10673792> jsc should install directly in to versioned Resources subfolder
This ensures that jsc ends up in a consistent location whether built in to the same DSTROOT
as JavaScriptCore.framework or in to a different one.
Rubber-stamped by Dan Bernstein.
* Configurations/JSC.xcconfig: Update INSTALL_PATH.
2012-01-10 Filip Pizlo <fpizlo@apple.com>
DFG inlining block linking compares BlockIndex against bytecode index
https://bugs.webkit.org/show_bug.cgi?id=76018
<rdar://problem/10671979>
Reviewed by Gavin Barraclough.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
2012-01-10 Filip Pizlo <fpizlo@apple.com>
CodeBlock.h declares too many things
https://bugs.webkit.org/show_bug.cgi?id=76001
Rubber stamped by Gavin Barraclough.
Removed all non-CodeBlock type declarations from CodeBlock.h, and put them
into separate header files. Also removed all non-CodeBlock method implementations
from CodeBlock.cpp and put them into corresponding cpp files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/RepatchBuffer.h:
* bytecode/CallLinkInfo.cpp: Added.
(JSC::CallLinkInfo::unlink):
* bytecode/CallLinkInfo.h: Added.
(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::~CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::getCallLinkInfoReturnLocation):
(JSC::getCallLinkInfoBytecodeIndex):
* bytecode/CallReturnOffsetToBytecodeOffset.h: Added.
(JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
(JSC::getCallReturnOffset):
* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:
* bytecode/CodeType.h: Added.
* bytecode/ExpressionRangeInfo.h: Added.
* bytecode/GlobalResolveInfo.h: Added.
(JSC::GlobalResolveInfo::GlobalResolveInfo):
* bytecode/HandlerInfo.h: Added.
* bytecode/LineInfo.h: Added.
* bytecode/MethodCallLinkInfo.cpp: Added.
(JSC::MethodCallLinkInfo::reset):
* bytecode/MethodCallLinkInfo.h: Added.
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
(JSC::getMethodCallLinkInfoReturnLocation):
(JSC::getMethodCallLinkInfoBytecodeIndex):
* bytecode/StructureStubInfo.h:
(JSC::getStructureStubInfoReturnLocation):
(JSC::getStructureStubInfoBytecodeIndex):
2012-01-10 Anders Carlsson <andersca@apple.com>
Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989
<rdar://problem/9601915>
Reviewed by Sam Weinig.
* wtf/Functional.h:
Add function wrapper for a function that takes three parameters.
2012-01-10 Filip Pizlo <fpizlo@apple.com>
CodeBlock::m_numParameters should be encapsulated
https://bugs.webkit.org/show_bug.cgi?id=75985
<rdar://problem/10671020>
Reviewed by Oliver Hunt.
Encapsulated CodeBlock::m_numParameters and hooked argument profile creation
into it. This appears to be performance neutral.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::addParameter):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numParameters):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitReturn):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::arityCheckFor):
(JSC::lazyLinkFor):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
2012-01-10 Gavin Barraclough <barraclough@apple.com>
Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935
Fix 32-bit builds.
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
2012-01-10 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-01-10 Gavin Barraclough <barraclough@apple.com>
Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935
Reviewed by Sam Weinig.
Do not allow Array length to be set if it is non-configurable, and if the new
length is less than the old length then intervening properties should removed
in reverse order. Removal of properties should cease if an intervening indexed
property being removed is non-configurable.
* JavaScriptCore.exp:
- Removed export for setLength.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
- JSArray::setLength now takes an ExecState*
(JSC::arrayProtoFuncSlice):
- JSArray::setLength now takes an ExecState*
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- JSArray::setLength now takes an ExecState*
(JSC::JSArray::put):
- JSArray::setLength now takes an ExecState*
(JSC::compareKeysForQSort):
- Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::getOwnPropertyNames):
- Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::setLength):
- Check lengthIsReadOnly(), rather than copying the entire map to iterate
over to determine which keys to remove, instead just copy the keys from
the map to a Vector. When inSparseMode sort the keys in the Vector so
that we can remove properties in reverse order.
* runtime/JSArray.h:
- JSArray::setLength now takes an ExecState*
2012-01-10 Gavin Barraclough <barraclough@apple.com>
Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975
Reviewed by Sam Weinig.
Rather than strictEqual.
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnNumericProperty):
- Missing configurablePresent() check.
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- call sameValue.
* runtime/PropertyDescriptor.cpp:
(JSC::sameValue):
- Moved from JSArray.cpp, fix NaN comparison.
(JSC::PropertyDescriptor::equalTo):
- call sameValue.
* runtime/PropertyDescriptor.h:
- Added declaration for sameValue.
2012-01-09 Gavin Barraclough <barraclough@apple.com>
Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919
Reviewed by Sam Weinig.
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
- need to increment the string position.
2012-01-09 Mark Rowe <mrowe@apple.com>
JavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore framework target
<http://webkit.org/b/75907> / <rdar://problem/10659862>
We'd like for it to be possible to build jsc without building JavaScriptCore.framework and the explicit
dependencies prevent this.
Reviewed by Dan Bernstein.
* JavaScriptCore.xcodeproj/project.pbxproj:
2012-01-09 Adam Treat <atreat@rim.com>
Log is a little to verbose for blackberry port
https://bugs.webkit.org/show_bug.cgi?id=75728
The BlackBerry::Platform::Log* functions take care of the call to vfprintf
which is resulting in unintentional noise in our logs. Add a conditional
directive to fix.
Change to using BlackBerry::Platform::logStreamV which does not insert
threading info and newlines unlike BlackBerry::Platform::log.
Finally, add log locking and unlocking which the BlackBerry platform
uses to ensure that N threads do not trample on each other's logs.
Reviewed by Rob Buis.
* wtf/Assertions.cpp:
(WTFLogLocker::WTFReportAssertionFailure):
(WTFLogLocker::WTFReportAssertionFailureWithMessage):
(WTFLogLocker::WTFReportArgumentAssertionFailure):
(WTFLogLocker::WTFReportFatalError):
(WTFLogLocker::WTFReportError):
(WTFLogLocker::WTFLog):
(WTFLogLocker::WTFLogVerbose):
2012-01-09 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75789
defineOwnProperty not implemented for Array objects
Reviewed by Sam Weinig.
Implements support for getter/setter & non-default attribute properties on arrays,
by forcing them into a dictionary-like 'SparseMode'. This fixes ~300 test-262
test failures.
* JavaScriptCore.exp:
- Updated exports.
* dfg/DFGOperations.cpp:
- JSArray::pop now requires an exec state.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
- JSArray::pop now requires an exec state.
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::add):
- Add a potentially empty entry into the map.
(JSC::SparseArrayValueMap::put):
- Changed to call setter.
(JSC::SparseArrayEntry::get):
- calls getters.
(JSC::SparseArrayEntry::getNonSparseMode):
- does not call getters.
(JSC::JSArray::enterSparseMode):
- Convert into 'SparseMode' - removes the vectors, don't allow it to be recreated.
(JSC::JSArray::putDescriptor):
- Create a numeric property based on a descriptor.
(JSC::sameValue):
- See ES5.1 9.12.
(JSC::reject):
- Helper for the [[DefineOwnProperty]] algorithm.
(JSC::JSArray::defineOwnNumericProperty):
- Define an indexed property on an array object.
(JSC::JSArray::setLengthWritable):
- Marks the length read-only, enters SparseMode as necessary.
(JSC::JSArray::defineOwnProperty):
- Defines either an indexed property or 'length' on an array object.
(JSC::JSArray::getOwnPropertySlotByIndex):
- Updated to correctly handle accessor descriptors & attributes.
(JSC::JSArray::getOwnPropertyDescriptor):
- Updated to correctly handle accessor descriptors & attributes.
(JSC::JSArray::put):
- Pass strict mode flag to setLength.
(JSC::JSArray::putByIndex):
- putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.
(JSC::JSArray::putByIndexBeyondVectorLength):
- Pass exec to SparseArrayValueMap::put.
(JSC::JSArray::deletePropertyByIndex):
- Do not allow deletion of non-configurable properties.
(JSC::compareKeysForQSort):
- used in implementation of getOwnPropertyNames.
(JSC::JSArray::getOwnPropertyNames):
- Properties in the sparse map should be iterated in order.
(JSC::JSArray::setLength):
- Updated to take a 'shouldThrow' flag, return a result indicating error.
(JSC::JSArray::pop):
- pop should throw an error if length is not writable, even if the array is empty.
(JSC::JSArray::push):
- putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.
(JSC::JSArray::sort):
- Changed 'get' to 'getNonSparseMode' (can't be getters to call).
(JSC::JSArray::compactForSorting):
- Changed 'get' to 'getNonSparseMode' (can't be getters to call).
* runtime/JSArray.h:
(JSC::SparseArrayValueMap::lengthIsReadOnly):
- Check if the length is read only.
(JSC::SparseArrayValueMap::setLengthIsReadOnly):
- Mark the length as read only.
(JSC::SparseArrayValueMap::find):
- Moved into header.
(JSC::JSArray::isLengthWritable):
- Wraps SparseArrayValueMap::lengthIsReadOnly.
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- Should be returning the result of putDescriptor.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesOverridingCurrent):
- Added attributesOverridingCurrent - this should probably be merged with attributesWithOverride.
* runtime/PropertyDescriptor.h:
- Added attributesOverridingCurrent.
2012-01-09 Pavel Heimlich <tropikhajma@gmail.com>
There is no support for fastcall in Solaris Studio.
Fixes build on Solaris.
https://bugs.webkit.org/show_bug.cgi?id=75736
Reviewed by Gavin Barraclough.
* jit/JITStubs.h:
2012-01-09 Pavel Heimlich <tropikhajma@gmail.com>
Fix build failure on Solaris
https://bugs.webkit.org/show_bug.cgi?id=75733
Reviewed by Gavin Barraclough.
* wtf/ByteArray.h:
2012-01-01 Raphael Kubo da Costa <kubo@profusion.mobi>
[CMake] Clean up some cruft from WTF's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420
Reviewed by Daniel Bates.
* wtf/CMakeLists.txt: Remove the unused WTF_PORT_FLAGS variable; add
all needed paths to WTF_INCLUDE_DIRECTORIES in a single place.
2012-01-08 Xianzhu Wang <wangxianzhu@chromium.org>
Fix compilation error about ListHashSetReverseIterator
https://bugs.webkit.org/show_bug.cgi?id=75372
Reviewed by Darin Adler.
There is a typo in class ListHashSetReverseIterator:
typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
Should be
typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
* wtf/ListHashSet.h:
2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
WinCE build fix after r104415.
* jit/JITExceptions.cpp:
* jit/JITExceptions.h:
2012-01-08 Filip Pizlo <fpizlo@apple.com>
The JIT's protocol for exception handling should be available to other parts of the system
https://bugs.webkit.org/show_bug.cgi?id=75808
<rdar://problem/10661025>
Reviewed by Oliver Hunt.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* jit/JITExceptions.cpp: Added.
(JSC::genericThrow):
(JSC::jitThrow):
* jit/JITExceptions.h: Added.
* jit/JITStubs.cpp:
* runtime/JSGlobalData.h:
2012-01-06 Hajime Morrita <morrita@chromium.org>
https://bugs.webkit.org/show_bug.cgi?id=75296
JSString should not have JS_EXPORTCLASS annotation
Reviewed by Kevin Ollivier.
* runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Added missing symbols which were hidden by JS_EXPORTCLASS.
2012-01-06 Michael Saboff <msaboff@apple.com>
JSArray::pop() should compare SparseArrayValueMap::find() to SparseArrayValueMap::notFound()
https://bugs.webkit.org/show_bug.cgi?id=75757
Reviewed by Gavin Barraclough.
* runtime/JSArray.cpp:
(JSC::JSArray::pop): Changed map->end() to map->notFound().
2012-01-06 Filip Pizlo <fpizlo@apple.com>
JIT stub slow paths that would be identical to that of an interpreter should be factored out
https://bugs.webkit.org/show_bug.cgi?id=75743
<rdar://problem/10657024>
Reviewed by Geoff Garen.
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/CommonSlowPaths.h: Added.
(JSC::CommonSlowPaths::opInstanceOfSlow):
(JSC::CommonSlowPaths::opIn):
(JSC::CommonSlowPaths::opResolve):
(JSC::CommonSlowPaths::opResolveSkip):
(JSC::CommonSlowPaths::opResolveWithBase):
(JSC::CommonSlowPaths::opResolveWithThis):
2012-01-06 Sam Weinig <sam@webkit.org>
Fix windows build.
* wtf/TypeTraits.cpp:
2012-01-05 Michael Saboff <msaboff@apple.com>
Default HashTraits for Opcode don't work for Opcode = 0
https://bugs.webkit.org/show_bug.cgi?id=75595
Reviewed by Oliver Hunt.
Removed the populating of the m_opcodeIDTable table in the
case where the OpcodeID and Opcode are the same (m_enabled is false).
Instead we just cast the one type to the other.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcodeID):
2012-01-06 Sam Weinig <sam@webkit.org>
Add a DecayArray type trait as a first step towards merging OwnPtr and OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=75737
Reviewed by Anders Carlsson.
* wtf/TypeTraits.cpp:
* wtf/TypeTraits.h:
Added a DecayArray trait, that can convert T[] and T[3] -> T*. DecayArray
is composed of some helpers which are also exposed, Conditional<>, which
can provide one type or another based on a boolean predicate, IsArray<>
which can deduce array types, and RemoveExtent<>, which removes the extent
from an array type.
2012-01-06 Oliver Hunt <oliver@apple.com>
GetByteArrayLength is incorrect
https://bugs.webkit.org/show_bug.cgi?id=75735
Reviewed by Filip Pizlo.
Load the byte array length from the correct location.
This stops an existing test from hanging.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2012-01-06 Filip Pizlo <fpizlo@apple.com>
Fix build.
* JavaScriptCore.xcodeproj/project.pbxproj:
2012-01-06 Oliver Hunt <oliver@apple.com>
DFG no longer optimises CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=75729
Reviewed by Gavin Barraclough.
Rename ByteArray (in its ClassInfo) to Uint8ClampedArray to match
the future name when we switch over to the new typed-array based
ImageData specification.
* runtime/JSByteArray.cpp:
2012-01-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Use HashMap<OwnPtr> for SourceProviderCache items
https://bugs.webkit.org/show_bug.cgi?id=75346
Reviewed by Daniel Bates.
* parser/Parser.cpp:
* parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):
* parser/SourceProviderCache.h:
2012-01-06 Sam Weinig <sam@webkit.org>
Remove unused OwnFastMallocPtr class.
https://bugs.webkit.org/show_bug.cgi?id=75722
Reviewed by Geoffrey Garen.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/OwnFastMallocPtr.h: Removed.
* wtf/text/StringImpl.h:
* wtf/wtf.pro:
2012-01-06 Benjamin Poulain <bpoulain@webkit.org>
[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
https://bugs.webkit.org/show_bug.cgi?id=75631
Reviewed by Andreas Kling.
* JavaScriptCore.xcodeproj/project.pbxproj:
2012-01-06 Eric Seidel <eric@webkit.org> and Gustavo Noronha Silva <gustavo.noronha@collabora.com>
Make the new WTF module build on Gtk
https://bugs.webkit.org/show_bug.cgi?id=75669
* GNUmakefile.am:
2012-01-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Remove un-needed VPATHs from project includes
Reviewed by Simon Hausmann.
* JavaScriptCore.pri:
* wtf/wtf.pri:
2012-01-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Move listing of include paths and libs to pri files in sources
Includepaths are sometimes modified by non-Qt contributors so keeping
them in files inside Sources makes it more likely that they are updated
along with project files for the other ports.
Using pri files instead of prf files for this also has the benefit that
the include() from the main target file can be parsed and followed by
Qt Creator -- something that does not work with load().
Dependency from a target to a library through the WEBKIT variable are
handled through forwarding-files in Tools/qmake/mkspecs/modules, which
set the source root of the module and include the right pri file.
Ideally we'd use the variant of include() that takes an optional
namespace to read the variables into, or the fromfile() function,
but both of these add an overhead of about 40% on the total qmake
runtime, due to making a deep copy of all the variables in the
project or re-reading all the prf files from scratch.
Reviewed by Simon Hausmann.
Reviewed by Ossy.
* JavaScriptCore.pri: Renamed from Tools/qmake/mkspecs/features/javascriptcore.prf.
* Target.pri:
* wtf/wtf.pri: Renamed from Tools/qmake/mkspecs/features/wtf.prf.
* wtf/wtf.pro:
2012-01-06 Hajime Morrita <morrita@chromium.org>
WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=75612
Reviewed by Kevin Ollivier.
* wtf/text/WTFString.h:
(WTF::String::findIgnoringCase):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::String::isHashTableDeletedValue):
2012-01-05 Dan Bernstein <mitz@apple.com>
<rdar://problem/10633760> Update copyright strings
Reviewed by Mark Rowe.
* Info.plist:
2012-01-05 Gavin Barraclough <barraclough@apple.com>
Date constructor handles infinite values incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=70998
Reviewed by Filip Pizlo.
* runtime/DateConstructor.cpp:
(JSC::constructDate):
- should be checking !finite rather then isnan.
2012-01-05 Gavin Barraclough <barraclough@apple.com>
date.toISOString produces incorrect results for dates with ms prior to 1970
https://bugs.webkit.org/show_bug.cgi?id=75684
Reviewed by Sam Weinig.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
2012-01-05 Gavin Barraclough <barraclough@apple.com>
Array.prototype.lastIndexOf ignores undefined fromIndex.
https://bugs.webkit.org/show_bug.cgi?id=75678
Reviewed by Sam Weinig.
array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncLastIndexOf):
- should check argumnet count, rather than checking agument value for undefined.
2012-01-05 Gavin Barraclough <barraclough@apple.com>
Date parsing is too restrictive.
https://bugs.webkit.org/show_bug.cgi?id=75671
Reviewed by Oliver Hunt.
ES5 date parsing currently requires all fields to be present, which does not match the spec (ES5.1 15.9.1.15).
The spec allow a date to be date only, or date + time.
The date portion on the should match: (pseudocode!:)
[(+|-)YY]YYYY[-MM[-DD]]
though we are slightly more liberal (permitted by the spec), allowing:
[+|-]Y+[-MM[-DD]]
The time portion should match:
THH:mm[:ss[.sss]][Z|(+|-)HH:mm]
again we're slightly more liberal, allowing:
THH:mm[:ss[.s+]][Z|(+|-)HH:mm]
* wtf/DateMath.cpp:
(WTF::parseES5DatePortion):
- Month/day fields are optional, default to 01.
(WTF::parseES5TimePortion):
- Hours/Minutes are requires, seconds/timezone are optional.
(WTF::parseES5DateFromNullTerminatedCharacters):
- Dates may be date only, or date + time.
2012-01-05 Bruno Dilly <bdilly@profusion.mobi>
[EFL] Undefined references to ICU_I18N symbols on WTF
https://bugs.webkit.org/show_bug.cgi?id=75642
Unreviewed build fix.
Add ${ICU_I18N_LIBRARIES} to WTF_LIBRARIES on wtf efl platform cmake.
Some undefined references were ucol_setAttribute_44, ucol_close_44,
ucol_getAttribute_44...
* wtf/PlatformEfl.cmake:
2012-01-05 Geoffrey Garen <ggaren@apple.com>
Refined the fast path for StringImpl::hash()
https://bugs.webkit.org/show_bug.cgi?id=75178
Reviewed by Darin Adler.
Moved the hash calculation code into an out-of-line function to clean up
the hot path.
No measurable benchmark change, but this knocks some samples off in
Instruments, and I think this is a step toward removing -fomit-frame-pointer.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::hashSlowCase):
* wtf/text/StringImpl.h:
(WTF::StringImpl::hash): The patch.
* wtf/text/StringStatics.cpp:
(WTF::StringImpl::hashSlowCase): Abide by the cockamamie Windows build
scheme, which requires all out-of-line StringImpl functions used by
WebCore be defined in this file instead of StringImpl.cpp. (See http://trac.webkit.org/changeset/59187.)
2012-01-05 Gavin Barraclough <barraclough@apple.com>
Literal tab in JSONString fails
https://bugs.webkit.org/show_bug.cgi?id=71772
Reviewed by Oliver Hunt.
rfc4627 does not allow literal tab characters in JSON source.
* runtime/LiteralParser.cpp:
(JSC::isSafeStringCharacter):
- do not allow literal tab in StrictJSON mode.
2012-01-05 Gavin Barraclough <barraclough@apple.com>
push/shift fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75610
Reviewed by Sam Weinig.
Array object commonly store data in a vector, consisting of a portion that is
in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to shift with grow the pre-capacity, and
the current algorithm for increaseVectorLength (used by push, or [[Put]]) will
never shrink the pre-capacity, so a push/shift fifo may consume an inordinate
amount of memory, whilst having a relatively small active length.
* runtime/JSArray.cpp:
(JSC::JSArray::increaseVectorLength):
- If m_indexBias is non-zero, decay it over time.
2012-01-05 Csaba Osztrogonác <ossy@webkit.org>
unshift/pop fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75588
Reviewed by Zoltan Herczeg.
Buildfix after r104120.
* runtime/JSArray.cpp: Remove useless asserts, baecause unsigned expression >= 0 is always true
(JSC::JSArray::unshiftCount):
2012-01-05 Zoltan Herczeg <zherczeg@webkit.org>
Unreviewed gardening after r104134.
* wtf/Assertions.cpp:
2012-01-05 Zoltan Herczeg <zherczeg@webkit.org>
Unreviewed gardening after r75605.
Rubber stamped by NOBODY Csaba Osztrogonác.
* wtf/Assertions.cpp:
2012-01-05 Benjamin Poulain <benjamin@webkit.org>
Improve charactersAreAllASCII() to compare multiple characters at a time
https://bugs.webkit.org/show_bug.cgi?id=74063
Reviewed by Darin Adler.
A new header ASCIIFastPath.h contains the functions related to
the detection of ASCII by using machine words. Part of it comes from
WebCore's TextCodecASCIIFastPath.h.
The function charactersAreAllASCII() is moved to TextCodecASCIIFastPath.h
and is implemented with computer word comparison.
The gain over the previous implementation of charactersAreAllASCII() is of
the order of how many comparison are avoided (4x, 8x, 16x depending on the
format and the CPU type).
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/text/ASCIIFastPath.h: Added.
(WTF::isAlignedToMachineWord):
(WTF::alignToMachineWord):
(WTF::isAllASCII):
(WTF::charactersAreAllASCII):
* wtf/text/WTFString.h:
* wtf/wtf.pro:
2012-01-05 Mark Rowe <mrowe@apple.com>
<http://webkit.org/b/75606> [Mac] WTF logging functions should output to both stderr and ASL
We should always log to both ASL and stderr on platforms where this won't result in launchd
duplicating the messages.
Reviewed by Dan Bernstein.
* wtf/Assertions.cpp:
(vprintf_stderr_common):
2012-01-05 Mark Rowe <mrowe@apple.com>
<http://webkit.org/b/75605> WTF logging functions should call vprintf_stderr_common only once per line
Several of the WTF logging functions make multiple calls to vprintf_stderr_common to output a
single line of text. This results in strangely formatted output if vprintf_stderr_common is
retargeted to an output device that is message-oriented (such as ASL) rather than stream-oriented
like stderr.
Reviewed by Dan Bernstein.
* wtf/Assertions.cpp:
(vprintf_stderr_with_prefix): Helper function to prepend a given prefix on to the given format
string before handing it off to vprintf_stderr_common. This requires disabling warnings about
calling a printf-like function with a non-literal format string for this piece of code. It's
safe in this particular case as vprintf_stderr_with_prefix is only ever given a literal prefix.
(vprintf_stderr_with_trailing_newline): Helper function to append a trailling newline on to the
given format string if one does not already exist. It requires the same treatment with regards
to the non-literal format string warning.
(WTFReportAssertionFailureWithMessage): Switch to using vprintf_stderr_with_prefix.
(WTFReportBacktrace): Switch from calling fprintf directly to using fprintf_stderr_common.
(WTFReportFatalError): Switch to using vprintf_stderr_with_prefix.
(WTFReportError): Ditto.
(WTFLog): Switch to using vprintf_stderr_with_trailing_newline.
(WTFLogVerbose): Ditto.
2012-01-04 Gavin Barraclough <barraclough@apple.com>
unshift/pop fifo may consume excessive memory
https://bugs.webkit.org/show_bug.cgi?id=75588
Reviewed by Sam Weinig.
The Array object commonly store data in a vector, consisting of a portion that
is in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to pop with grow the post-capacity, and the
current algorithm for increasePrefixVectorLength (used by unshift) will never
stink the post-capacity, so a unshift/pop fifo may consume an inordinate amount
of memory, whilst having a relatively small active length.
* runtime/JSArray.cpp:
(JSC::storageSize):
- sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)
(JSC::SparseArrayValueMap::put):
- sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)
(JSC::JSArray::increaseVectorLength):
- sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)
(JSC::JSArray::unshiftCountSlowCase):
- renamed from increaseVectorPrefixLength (this was a bad name, since it
also moved the ArrayStorage header), rewritten.
(JSC::JSArray::shiftCount):
- sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned
(JSC::JSArray::unshiftCount):
- sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned,
increaseVectorPrefixLength renamed to unshiftCountSlowCase
(JSC::JSArray::sortNumeric):
* runtime/JSArray.h:
- Updated function declarations, m_indexBias should be unsigned.
2012-01-04 Mark Rowe <mrowe@apple.com>
<http://webkit.org/b/75604> All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments
Since JSC::Arguments has an OwnPtr for a member it needs to override destroy
to ensure that the correct destructor is invoked. This is necessary because
JSCell subclasses all intentionally have non-virtual destructors.
Reviewed by Filip Pizlo.
* runtime/Arguments.cpp:
(JSC::Arguments::destroy):
* runtime/Arguments.h:
2012-01-04 Filip Pizlo <fpizlo@apple.com>
Unreviewed, accidentally turned off the JIT in previous commit. Turning
it back on.
* wtf/Platform.h:
2012-01-04 Filip Pizlo <fpizlo@apple.com>
Changed "return" to "break" in some macrology I introduced in
http://trac.webkit.org/changeset/104086. This is a benign change, as
"return" was technically correct for all uses of the macro.
Reviewed by Oliver Hunt.
* dfg/DFGGraph.cpp:
* wtf/Platform.h:
2012-01-04 Michael Saboff <msaboff@apple.com>
StructureStubInfo not reset when corresponding MethodCallLinkInfo is reset
https://bugs.webkit.org/show_bug.cgi?id=75583
Reviewed by Filip Pizlo.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally): Find the corresponding
StructureStubInfo and reset the appropriate JIT and
the StructureStubInfo itself when reseting a MethodCallLinkInfo.
2012-01-04 Michael Saboff <msaboff@apple.com>
Invalid ASSERT() in DFGRepatch.cpp near line 385
https://bugs.webkit.org/show_bug.cgi?id=75584
Reviewed by Filip Pizlo.
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDProtoList): Fixed ASSERT to use ==.
2012-01-04 Filip Pizlo <fpizlo@apple.com>
Incorrect use of DFG node reference counts when mutating the graph
https://bugs.webkit.org/show_bug.cgi?id=75580
<rdar://problem/10644607>
Reviewed by Oliver Hunt.
Made deref(node) follow the pattern of ref(node), which it should have
to begin with.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
* dfg/DFGNode.h:
(JSC::DFG::Node::deref):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixupNode):
2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
The custom qmake variable 'WEBKIT' is used for signaling that a
target depends in some way on other subproject of the WebKit
project. For now this is limited to the set of intermediate
libraries: wtf, javascriptcore, webcore, and webkit2.
This replaces the previous convension of using load(foo) for
just include paths, and CONFIG += foo to also link against foo.
Adding a dependency results in additional include paths being
available, and potentially linking to the library. This is
decided by the build system based on conditions such as what
kind of target is being built and the general build config.
An advantage to his approach is that it simplifies the individual
foo.prf files, for example by allowing us to use INCLUDEPATH +=
and LIBS += as normal instead of prepending.
Reviewed by Simon Hausmann.
* Target.pri:
* jsc.pro:
* wtf/wtf.pro:
2012-01-03 Filip Pizlo <fpizlo@apple.com>
DFG: The assertion that a double-voted variable cannot become double-unvoted is wrong
https://bugs.webkit.org/show_bug.cgi?id=75516
<rdar://problem/10640266>
Reviewed by Gavin Barraclough.
Removed the offending assertion, since it was wrong. Also hardened the code to make
this case less likely by first having the propagator fixpoint converge, and then doing
double voting combined with a second fixpoint. This is neutral on benchmarks and
fixes the assertion in a fairly low-risk way (i.e. we won't vote a variable double
until we've converged to the conclusion that it really is double).
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagatePredictions):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
2012-01-03 Filip Pizlo <fpizlo@apple.com>
REGRESSION (r98196-98236): Incorrect layout of iGoogle with RSS feeds
https://bugs.webkit.org/show_bug.cgi?id=75303
<rdar://problem/10633533>
Reviewed by Gavin Barraclough.
The this argument was not being kept alive in some cases during inlining and intrinsic
optimizations.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionCheck):
(JSC::DFG::ByteCodeParser::handleInlining):
2012-01-03 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-01-03 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-01-03 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75140
Reviewed by Sam Weinig.
Rewrite JSArray::putSlowCase to be much cleaner & simpler.
This rewrite only significantly changes behaviour for sparse array, specifically
in how sparse arrays are reified back to vector form. This does not affect arrays
with less than 10000 entries (since these always use a vector). The more common
cases of sparse array behavior (though large sparse arrays are rare) - arrays that
always remain sparse, and arrays that are filled in reverse sequential order -
should be just as fast or faster (since reification is simpler & no longer
requires map lookups) after these changes.
Simplifying this code allows all cases of putByIndex that need to grow the vector
to do so via increaseVectorLength, which means that this method can encapsulate
the policy of determining how the vector should be grown.
No performance impact.
* runtime/JSArray.cpp:
(JSC::isDenseEnoughForVector):
- any array of length <= MIN_SPARSE_ARRAY_INDEX is dense enough for a vector.
(JSC::JSArray::putByIndex):
- simplify & comment.
(JSC::JSArray::putByIndexBeyondVectorLength):
- Re-written to be much clearer & simpler.
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
- add explicit checks against MAX_STORAGE_VECTOR_LENGTH, so clients do not need do so.
(JSC::JSArray::push):
- simplify & comment.
* runtime/JSArray.h:
- removed SparseArrayValueMap::take.
2012-01-03 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2012-01-03 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75140
Reviewed by Sam Weinig.
Simplify JSArray creation - remove ArgsList/JSValue* create methods
(this functionality can be implemented in terms of tryCreateUninitialized).
* JavaScriptCore.exp:
* runtime/ArrayConstructor.cpp:
- use constructArray/constructEmptyArray instead of calling JSArray::create directly
(JSC::constructArrayWithSizeQuirk):
* runtime/JSArray.cpp:
* runtime/JSArray.h:
- removed ArgsList/JSValue* create methods
* runtime/JSGlobalObject.h:
(JSC::constructEmptyArray):
(JSC::constructArray):
- changed to be implemented in terms of JSArray::tryCreateUninitialized
2012-01-03 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75429
ThrowTypeError should be a singleton object
Reviewed by Sam Weinig.
Per section 13.2.3 of the spec.
We could change setAccessorDescriptor to be able to share the global
GetterSetter object, rather than storing the accessor functions and
creating a new GetterSetter in defineProperty - but this won't be a
small change to PropertyDescriptors (and would probably mean making
GetterSetter objects immutable?) - so I'll leave that for another
patch.
* JavaScriptCore.exp:
- don't export setAccessorDescriptor
* runtime/Arguments.cpp:
(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):
- call throwTypeErrorGetterSetter instead of createTypeErrorFunction
* runtime/Error.cpp:
* runtime/Error.h:
- remove createTypeErrorFunction
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
- remove unused createDescriptorForThrowingProperty
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- removed m_strictModeTypeErrorFunctionStructure.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::internalFunctionStructure):
- removed m_strictModeTypeErrorFunctionStructure.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setAccessorDescriptor):
- changed to take a GetterSetter
* runtime/PropertyDescriptor.h:
- changed to take a GetterSetter
2012-01-02 Gavin Barraclough <barraclough@apple.com>
Check in fixes for jsc tests following bug #75455.
* tests/mozilla/ecma/GlobalObject/15.1.2.2-1.js:
* tests/mozilla/ecma/GlobalObject/15.1.2.2-2.js:
2012-01-02 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75452
If argument to Error is undefined, message is not set
Reviewed by Sam Weinig.
Per section 15.11.1.1 of the spec.
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::create):
(JSC::ErrorInstance::finishCreation):
2012-01-02 Gavin Barraclough <barraclough@apple.com>
ES5 prohibits parseInt from supporting octal
https://bugs.webkit.org/show_bug.cgi?id=75455
Reviewed by Sam Weinig.
See sections 15.1.2.2 and annex E.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
2012-01-02 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=55343
Global JSON should be configurable but isn't
Reviewed by Sam Weinig.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- make JSON configurable
2012-01-01 Filip Pizlo <fpizlo@apple.com>
Call instructions should leave room for linking information
https://bugs.webkit.org/show_bug.cgi?id=75422
<rdar://problem/10633985>
Reviewed by Oliver Hunt.
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
2011-12-31 Dan Bernstein <mitz@apple.com>
Continue trying to fix the Windows build after r103823.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-12-31 Dan Bernstein <mitz@apple.com>
Start trying to fix the Windows build after r103823.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-12-30 Anders Carlsson <andersca@apple.com>
Add a ParamStorageTraits specialization for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=75392
Reviewed by Daniel Bates.
* wtf/Functional.h:
Add a partial specialization of ParamStorageTraits for RetainPtr<T>.
* wtf/RetainPtr.h:
Bring in the retainPtr function template from WTF.
2011-12-29 Sam Weinig <sam@webkit.org>
It should be easier to iterate a Vector backwards
https://bugs.webkit.org/show_bug.cgi?id=75359
Reviewed by Anders Carlsson.
Adds Vector::rbegin(), Vector::rend(), and Vector::reversed(),
a new proxy driven way to access a vector backwards. One can use
reversed() in a range-based for loop like so:
for (auto val: myVector.reversed())
doSomething(val)
* wtf/Vector.h:
(WTF::Vector::~Vector):
Fix style.
(WTF::Vector::rbegin):
(WTF::Vector::rend):
Added using standard adaptor std::reverse_iterator.
(WTF::Vector::reversed):
(WTF::Vector::VectorReverseProxy::begin):
(WTF::Vector::VectorReverseProxy::end):
Add proxy similar to one used in HashMap for keys() and values()
which allows access to a Vector backwards for use in range-based
for loops.
2011-12-29 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75140
Reviewed by Oliver Hunt.
Start cleaning up JSArray construction. JSArray has a set of create methods,
one of which (currently) takes a 'creation mode' enum parameter. Based on that
parameter, the constructor does one of two completely different things. If the
parameter is 'CreateInitialized' it creates an array, setting the length, but
does not eagerly allocate a storage vector of the specified length. A small
(BASE_VECTOR_LEN sized) initial vector will be allocated, and cleared, property
access to the vector will read the hole value (return undefined). The alternate
usage of this method ('CreateCompact') does something very different. It tries
to create an array of the requested length, and also allocates a storage vector
large enough to hold all properties. It does not clear the storage vector,
leaving the memory uninitialized and requiring the user to call a method
'uncheckedSetIndex' to initialize values in the vector.
This patch factors out these two behaviours, moving the 'CreateCompact' mode
into its own method, 'tryCreateUninitialized' (matching the naming for this
functionality in the string classes). 'tryCreateUninitialized' may return 0 if
memory allocation fails during construction of the object. The construction
pattern changes such that values added during initialization will be marked if
a GC is triggered during array allocation. 'CreateInitialized' no longer need
be passed to create a normal, fully constructed array with a length, and this
method is merged with the version of 'create' that does not take an initial
length (length parameter defaults to 0).
* JavaScriptCore.exp:
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- removed 'CreateInitialized' argument
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
- changed to call 'tryCreateUninitialized'
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
- changed to call 'tryCreateUninitialized'
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
- initialize m_storage to null; if construction fails, make destruction safe
(JSC::JSArray::finishCreation):
- merge versions of this method, takes an initialLength parameter defaulting to zero
(JSC::JSArray::tryFinishCreationUninitialized):
- version of 'finishCreation' that tries to eagerly allocate storage; may fail & return 0
(JSC::JSArray::~JSArray):
- check for null m_storage, in case array construction failed.
(JSC::JSArray::increaseVectorPrefixLength):
* runtime/JSArray.h:
(JSC::JSArray::create):
- merge versions of this method, takes an initialLength parameter defaulting to zero
(JSC::JSArray::tryCreateUninitialized):
- version of 'create' that tries to eagerly allocate storage; may fail & return 0
(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):
- used in conjunction with 'tryCreateUninitialized' to initialize the array
* runtime/JSGlobalObject.h:
(JSC::constructEmptyArray):
- removed 'CreateInitialized' argument
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::finishCreation):
- removed 'CreateInitialized' argument
2011-12-29 Anders Carlsson <andersca@apple.com>
Add a retainPtr function template
https://bugs.webkit.org/show_bug.cgi?id=75365
Reviewed by Dan Bernstein.
This makes it easier to make a RetainPtr using template argument deduction, which
is useful when passing RetainPtr objects as function arguments.
* wtf/RetainPtr.h:
(WTF::retainPtr):
2011-12-28 Yuqiang Xian <yuqiang.xian@intel.com>
spill unboxed values in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=75291
Reviewed by Filip Pizlo.
Currently all the values are spilled as boxed in DFG 32_64, which is
not necessary and introduces additional stores/loads. Instead we
can spill them as unboxed if feasible. It can be applied to the
Integers, Cells and Booleans in DFG 32_64. Doubles are left as is
because they don't need to be boxed at all. The modifications to the
spill/fill and the OSR exit are required, as well as a bug fix to the
"isUnknownJS" logic.
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isUnknownJS):
(JSC::DFG::GenerationInfo::spill):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::isKnownNotBoolean):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::spill):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
2011-12-28 Anders Carlsson <andersca@apple.com>
Add an implicit block conversion operator to WTF::Function
https://bugs.webkit.org/show_bug.cgi?id=75325
Reviewed by Dan Bernstein.
* wtf/Compiler.h:
Add a define for COMPILER_SUPPORTS(BLOCKS). It's only defined for clang, since the gcc blocks implementation
is buggy, especially when it comes to C++.
* wtf/Functional.h:
Add a block conversion operator that creates and returns an autoreleased block that will call the function when executed.
2011-12-27 Anders Carlsson <andersca@apple.com>
Add a new WTF::bind overload that takes 6 parameters
https://bugs.webkit.org/show_bug.cgi?id=75287
Reviewed by Sam Weinig.
* wtf/Functional.h:
2011-12-27 Sam Weinig <sam@webkit.org>
Continue moving compiler feature checks to use the COMPILER_SUPPORTS() macro
https://bugs.webkit.org/show_bug.cgi?id=75268
Reviewed by Anders Carlsson.
* wtf/Compiler.h:
Add support for COMPILER_SUPPORTS(CXX_NULLPTR) and COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).
* wtf/Noncopyable.h:
Use COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).
* wtf/NullPtr.cpp:
* wtf/NullPtr.h:
Use COMPILER_SUPPORTS(CXX_NULLPTR). Remove support for HAVE(NULLPTR).
* wtf/RefPtr.h:
* wtf/RetainPtr.h:
Switch from HAVE(NULLPTR) to COMPILER_SUPPORTS(CXX_NULLPTR).
2011-12-27 Anders Carlsson <andersca@apple.com>
Misc fixes and cleanups in Functional.h
https://bugs.webkit.org/show_bug.cgi?id=75281
Reviewed by Andreas Kling.
- Reformat template declarations so that the class begins on a new line.
- Change the parameter template parameters to start at P1 instead of P0.
- Add function wrappers and bind overloads for 4 and 5 parameter functions.
- Change the Function call operator to be const so const functions can be called.
* wtf/Functional.h:
2011-12-27 Tony Chang <tony@chromium.org>
[chromium] Minor cleanup of gyp files.
https://bugs.webkit.org/show_bug.cgi?id=75269
Reviewed by Adam Barth.
* JavaScriptCore.gyp/JavaScriptCore.gyp: msvs_guid is no longer needed
and vim/emacs specific hooks should be added by the user.
2011-12-27 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75260
Null name for host function can result in dereference of uninitialize memory
Reviewed by Filip Pizlo.
This is a recent regression in ToT, if the name passed to finishCreation of a host function is null,
we are currently skipping the putDirect, which leaves memory uninitialized. This patch reverts the
aspect of the change that introduced the issue. It might be better if functions that don't have a
name don't have this property at all, but that's change should be separate from fixing the bug.
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
- Always initialize the name property.
2011-12-27 Anders Carlsson <andersca@apple.com>
Function should handle wrapping/unwrapping RefPtr and PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=75266
Reviewed by Sam Weinig.
Add ParamStorageTraits that can be used for deciding how bound parameters should be stored
and peeked at. For RefPtr we want to use the raw pointer when "peeking" to avoid ref-churn.
For PassRefPtr, we want to use RefPtr for storage but still use the raw pointer when peeking.
* wtf/Functional.h:
(WTF::ParamStorageTraits::wrap):
(WTF::ParamStorageTraits::unwrap):
2011-12-27 Tony Chang <tony@chromium.org>
[chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264
Reviewed by Adam Barth.
* JavaScriptCore.gyp/JavaScriptCore.gyp: Enable WPO for wtf and yarr.
2011-12-26 Gavin Barraclough <barraclough@apple.com>
Errk! OS X build fix.
* JavaScriptCore.exp:
2011-12-26 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSObject.h:
2011-12-26 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75231
Fail to throw in strict mode on assign to read only static properties
Reviewed by Filip Pizlo.
There are three bugs here:
* symbolTablePut should throw for strict mode accesses.
* lookupPut should throw for strict mode accesses.
* NumberConstructor should override put to call lookupPut, to trap assignment to readonly properties.
* runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::put):
* runtime/JSActivation.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::symbolTablePut):
* runtime/Lookup.h:
(JSC::lookupPut):
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::put):
* runtime/NumberConstructor.h:
2011-12-26 Gavin Barraclough <barraclough@apple.com>
Fix miss-commit of utf8 change.
Reviewed by Filip Pizlo
Eeep, patch as landed a while ago had no effect! - acidentally landed
modified version of patch used for performance testing.
(This isn't covered by layout tests because layour tests don't use jsc,
and the tests/mozilla tests use latin1, which was already supported!)
Landing changes as intended (and as originally reviewed).
* jsc.cpp:
(jscSource):
2011-12-26 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for ARMv7.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):
2011-12-26 Hajime Morrita <morrita@google.com>
Rename WTF_INLINE, JS_INLINE to HIDDEN_INLINE
https://bugs.webkit.org/show_bug.cgi?id=74990
Reviewed by Kevin Ollivier.
* runtime/JSExportMacros.h: Removed JS_INLINE
* wtf/ExportMacros.h: Renamed WTF_INLINE to HIDDEN_INLINE
2011-12-24 Filip Pizlo <fpizlo@apple.com>
The ArgumentCount field in the CallFrame should have its tag left blank for other uses
https://bugs.webkit.org/show_bug.cgi?id=75199
<rdar://problem/10625105>
<rdar://problem/10625106>
Reviewed by Oliver Hunt.
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/CallFrame.h:
(JSC::ExecState::argumentCountIncludingThis):
(JSC::ExecState::setArgumentCountIncludingThis):
* interpreter/Register.h:
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):
(JSC::Register::payload):
(JSC::Register::tag):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
2011-12-25 Andreas Kling <awesomekling@apple.com>
Yarr: Avoid copying vectors in CharacterClassConstructor.
<http://webkit.org/b/75206>
Reviewed by Darin Adler.
Yarr::CharacterClassConstructor::charClass() was hot when loading twitter
feeds (1.2%), replace the usage of Vector::append() by swap() since we're
always clearing the source vector afterwards anyway.
* yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
2011-12-24 Darin Adler <darin@apple.com>
Specialize HashTraits for RefPtr to use PassRefPtr as "pass type" to reduce reference count churn
https://bugs.webkit.org/show_bug.cgi?id=72476
Reviewed by Sam Weinig.
* wtf/HashTraits.h: Defined PassInType and store function in HashTraits<RefPtr>.
2011-12-23 Geoffrey Garen <ggaren@apple.com>
Inlined Yarr::execute
https://bugs.webkit.org/show_bug.cgi?id=75180
Reviewed reluctantly by Beth Dakin.
Tiny speedup on SunSpider string tests. Removes some samples from
Instruments. A step toward removing -fomit-frame-pointer.
* yarr/YarrJIT.cpp:
* yarr/YarrJIT.h:
(JSC::Yarr::execute): ONE LINE FUNCTION, Y U NOT INLINED?!
2011-12-23 Filip Pizlo <fpizlo@apple.com>
DFG loads from signed 8-bit and 16-bit typed arrays are broken
https://bugs.webkit.org/show_bug.cgi?id=75163
Reviewed by Geoffrey Garen.
Added 8-bit and 16-bit signed loads. Because doing so on ARM is less trivial, I'm
currently disabling Int8Array and Int16Array optimizations on ARM.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load8Signed):
(JSC::MacroAssemblerX86Common::load16Signed):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movswl_mr):
(JSC::X86Assembler::movsbl_mr):
* bytecode/PredictedType.h:
(JSC::isActionableMutableArrayPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
2011-12-23 Filip Pizlo <fpizlo@apple.com>
DFG does double-to-int conversion incorrectly when storing into int typed arrays
https://bugs.webkit.org/show_bug.cgi?id=75164
<rdar://problem/10557547>
Reviewed by Geoffrey Garen.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerX86Common::truncateDoubleToUint32):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
2011-12-23 Geoffrey Garen <ggaren@apple.com>
Refactored String.prototype.replace
https://bugs.webkit.org/show_bug.cgi?id=75114
Reviewed by Darin Adler.
No performance difference.
I think this is a step toward removing -fomit-frame-pointer.
* runtime/JSString.cpp:
* runtime/JSString.h: Removed the test and special case for a single-character
search string because the standard path does this test and special case
for us. (As an aside, if we do come up with a unique single-character
replace optimization in future, it probably belongs in the replace function,
and not in JSString.)
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace): Split this mega-sized function into:
(JSC::replaceUsingStringSearch): - This reasonably sized function, and
(JSC::replaceUsingRegExpSearch): - This still mega-sized function.
2011-12-23 Pierre Rossi <pierre.rossi@gmail.com>
[Qt] REGRESSION(r103467): It broke fast/images/animated-gif-restored-from-bfcache.html
https://bugs.webkit.org/show_bug.cgi?id=75087
monotonicallyIncreasingTime needs to hava a higher resolution than milliseconds.
Reviewed by Darin Adler.
* wtf/CurrentTime.cpp:
(WTF::monotonicallyIncreasingTime):
2011-12-22 Filip Pizlo <fpizlo@apple.com>
DFG should not speculate array even when predictions say that the base is not an array
https://bugs.webkit.org/show_bug.cgi?id=75160
<rdar://problem/10622646>
<rdar://problem/10622649>
Reviewed by Oliver Hunt.
Added the ability to call slow path when the base is known to not be an array.
Also rationalized the logic for deciding when the index is not an int, and
cleaned up the logic for deciding when to speculate typed array.
Neutral for the most part, with odd speed-ups and slow-downs. The slow-downs can
likely be mitigated by having the notion of a polymorphic array access, where we
try, but don't speculate, to access the array one way before either trying some
other ways or calling slow path.
* bytecode/PredictedType.h:
(JSC::isActionableMutableArrayPrediction):
(JSC::isActionableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValIsPure):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-22 Gavin Barraclough <barraclough@apple.com>
Unreviewed - fix stylebot issues from last patch.
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
2011-12-22 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=75151
Add attributes field to JSArray's SparseMap
Reviewed by Sam Weinig.
This will be necessary to be able to support non- writable/configurable/enumerable
properties, and helpful for getters/setters.
Added a concept of being 'inSparseMode' - this indicates the array has a non-standard
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- JSArray::sort methods not allowed on arrays that are 'inSparseMode'.
(must fall back to generic sort alogrithm).
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
- moved reportedMapCapacity into the SparseArrayValueMap object.
(JSC::SparseArrayValueMap::find):
(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::visitChildren):
- Added.
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::visitChildren):
- Updated for changes in SparseArrayValueMap.
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
- Disallow on 'SparseMode' arrays.
* runtime/JSArray.h:
(JSC::SparseArrayEntry::SparseArrayEntry):
- An entry in the sparse array - value (WriteBarrier) + attributes.
(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC::SparseArrayValueMap::sparseMode):
(JSC::SparseArrayValueMap::setSparseMode):
- Flags to track whether an Array is forced into SparseMode.
(JSC::SparseArrayValueMap::remove):
(JSC::SparseArrayValueMap::notFound):
(JSC::SparseArrayValueMap::isEmpty):
(JSC::SparseArrayValueMap::contains):
(JSC::SparseArrayValueMap::size):
(JSC::SparseArrayValueMap::begin):
(JSC::SparseArrayValueMap::end):
- accessors to the map
(JSC::SparseArrayValueMap::take):
- only for use on non-SpareMode arrays.
(JSC::JSArray::inSparseMode):
- Added.
2011-12-22 Filip Pizlo <fpizlo@apple.com>
DFG CFA sometimes generates an incorrect proof that a node is known to be a typed array
https://bugs.webkit.org/show_bug.cgi?id=75150
<rdar://problem/10621900>
Reviewed by Gavin Barraclough.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
2011-12-22 Filip Pizlo <fpizlo@apple.com>
DFG JIT does exactly the wrong thing when doing strict equality on two known cells
https://bugs.webkit.org/show_bug.cgi?id=75138
<rdar://problem/10621526>
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
2011-12-22 Balazs Kelemen <kbalazs@webkit.org>
Fix debug build with assertions disabled
https://bugs.webkit.org/show_bug.cgi?id=75075
Reviewed by Darin Adler.
Check whether assertions are disabled instead of NDEBUG
where appropriate to avoid "defined but not used" warnings.
* wtf/DateMath.cpp:
(WTF::initializeDates):
2011-12-22 Mariusz Grzegorczyk <mariusz.g@samsung.com>
[EFL] Missing plugins support for efl port
https://bugs.webkit.org/show_bug.cgi?id=44505
Reviewed by Anders Carlsson.
Add define of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for efl port.
* wtf/Platform.h:
2011-12-22 Wei Charles <charles.wei@torchmobile.com.cn>
Remove un-used data member of LiteralParser::Lex::m_string
https://bugs.webkit.org/show_bug.cgi?id=68216
Reviewed by George Staikos.
* runtime/LiteralParser.h:
2011-12-21 Dan Bernstein <mitz@apple.com>
OS X build fix after r103488.
* JavaScriptCore.exp:
2011-12-21 Konrad Piascik <kpiascik@rim.com>
Implement the JavaScriptCore bindings for eventListenerHandlerLocation
https://bugs.webkit.org/show_bug.cgi?id=74313
Reviewed by Eric Seidel.
Updated project files to get Windows and Mac builds working.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-12-21 Filip Pizlo <fpizlo@apple.com>
DFG ConvertThis optimizations do not honor the distinction between the global object and the global this object
https://bugs.webkit.org/show_bug.cgi?id=75058
<rdar://problem/10616612>
<rdar://problem/10617500>
Reviewed by Oliver Hunt.
Added a call to toThisObject() in the DFG when planting a direct reference to the global this object.
Instead of adding a separate toThisObject() method on JSCell which does not take ExecState*, I reascribed
a new contract: if you're calling toThisObject() on JSObject or one of its subtypes, then the ExecState*
is optional.
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::globalThisObjectFor):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSObject.h:
2011-12-21 Pierre Rossi <pierre.rossi@gmail.com>
Implement montonicallyIncreasingClock() on Qt
https://bugs.webkit.org/show_bug.cgi?id=62159
Reviewed by Darin Adler.
* wtf/CurrentTime.cpp:
(WTF::monotonicallyIncreasingTime):
2011-12-20 Filip Pizlo <fpizlo@apple.com>
32_64 baseline JIT should attempt to convert division results to integers, and record when that fails
https://bugs.webkit.org/show_bug.cgi?id=74997
<rdar://problem/10612389>
Reviewed by Gavin Barraclough.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_div):
2011-12-20 Filip Pizlo <fpizlo@apple.com>
JavaScriptCore should be consistent about how it reads and writes ArgumentCount
https://bugs.webkit.org/show_bug.cgi?id=74989
<rdar://problem/10612006>
Reviewed by Gavin Barraclough.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
2011-12-20 Filip Pizlo <fpizlo@apple.com>
Value Profiles for arguments should be more easily accessible to the interpreter
https://bugs.webkit.org/show_bug.cgi?id=74984
<rdar://problem/10611364>
Reviewed by Gavin Barraclough.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setArgumentValueProfileSize):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::totalNumberOfValueProfiles):
(JSC::CodeBlock::getFromAllValueProfiles):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
2011-12-20 Gavin Barraclough <barraclough@apple.com>
JSC shell should accept utf8 input.
Reviewed by Filip Pizlo.
* jsc.cpp:
(jscSource):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):
2011-12-20 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig
* runtime/JSGlobalData.cpp:
- removed some dead code.
2011-12-19 Geoffrey Garen <ggaren@apple.com>
Tightened up Vector<T>::append
https://bugs.webkit.org/show_bug.cgi?id=74906
Reviewed by Sam Weinig.
Not a measurable speedup, but code inspection shows better code generated,
and I believe this is a step toward turning off -fomit-frame-pointer.
* wtf/Vector.h:
(WTF::::append):
(WTF::::appendSlowCase): Split out the slow case into a separate function
to keep unnecessary instructions off the hot path. This means the hot
path can now be inlined more often.
Removed some old MSVC7 cruft. Hopefully, we don't need to hang on to a
compiler work-around from 2007.
2011-12-19 Yuqiang Xian <yuqiang.xian@intel.com>
Temporary GPR should not be lazily allocated in DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=74908
Reviewed by Filip Pizlo.
On X86, we used to allocate a temporary GPR lazily when it's really
used rather than defined. This may cause potential issues of
allocating registers inside control flow and result in problems in
subsequent code generation, for example the DFG JIT may think an
operand already being spilled (to satisfy the allocation request) and
generate code to read the data from memory, but the allocation and
spilling are in a branch which is not taken at runtime, so the
generated code is incorrect.
Although current DFG JIT code doesn't have this problematic pattern,
it's better to cut-off the root to avoid any potential issues in the
future.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::GPRTemporary::gpr):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-19 Yuqiang Xian <yuqiang.xian@intel.com>
Remove unused code for non-speculative Arith operations from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=74905
Reviewed by Filip Pizlo.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
* dfg/DFGSpeculativeJIT64.cpp:
2011-12-19 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=74903
Exceptions not thrown correctly from DFG JIT on 32bit
Reviewed by Oliver Hunt.
Arguments for lookupExceptionHandler are not setup correctly.
In the case of ARMv7 we rely on lr being preserved over a call,
this in invalid. On x86 we don't should be poking the arguments onto the stack!
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
* dfg/DFGGPRInfo.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
2011-12-19 Filip Pizlo <fpizlo@apple.com>
If we detect that we can use the JIT, don't use computed opcode lookups
https://bugs.webkit.org/show_bug.cgi?id=74899
<rdar://problem/10604551>
Reviewed by Gavin Barraclough.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
2011-12-19 Geoffrey Garen <ggaren@apple.com>
Try to fix the Qt build.
Unreviewed.
* wtf/ThreadSpecific.h: #include!
2011-12-18 Filip Pizlo <fpizlo@apple.com>
It should be possible to change the value of an Options variable without recompiling the world
https://bugs.webkit.org/show_bug.cgi?id=74807
Reviewed by Gavin Barraclough.
* runtime/Options.cpp:
(JSC::Options::initializeOptions):
* runtime/Options.h:
2011-12-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r103250.
http://trac.webkit.org/changeset/103250
https://bugs.webkit.org/show_bug.cgi?id=74877
it still breaks codegen (Requested by olliej on #webkit).
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::byValIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-16 Oliver Hunt <oliver@apple.com>
Rolling r103120 back in with merge errors corrected.
PutByVal[Alias] unnecessarily reloads the storage buffer
https://bugs.webkit.org/show_bug.cgi?id=74747
Reviewed by Gavin Barraclough.
Make PutByVal use GetIndexedStorage to load the storage buffer.
This required switching PutByVal to a vararg node (which is
responsible for most of the noise in this patch). This fixes the
remaining portion of the kraken regression caused by the GetByVal
storage load elimination, and a 1-5% win on some of the sub tests of
the typed array benchmark at:
http://stepheneb.github.com/webgl-matrix-benchmarks/matrix_benchmark.html
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::byValIndexIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-15 Geoffrey Garen <ggaren@apple.com>
Placement new does an unnecessary NULL check
https://bugs.webkit.org/show_bug.cgi?id=74676
Reviewed by Sam Weinig.
We can define our own version, which skips the NULL check.
Not a measurable speedup, but code inspection shows better code generated,
and I believe this is a step toward turning off -fomit-frame-pointer.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::create):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::create): Use the NotNull version of placement
new to skip the NULL check.
* API/JSCallbackObject.h: Removed a conflicting, unnecessaray placement new.
(JSC::JSCallbackObject::create):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::grow):
* heap/HandleHeap.h:
(JSC::HandleHeap::allocate):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::recycle):
* jit/JITCode.h:
(JSC::JITCode::clear):
* jsc.cpp:
(GlobalObject::create):
* profiler/CallIdentifier.h:
* runtime/Arguments.h:
(JSC::Arguments::create):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::create):
* runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::create):
* runtime/BooleanObject.h:
(JSC::BooleanObject::create):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::create):
* runtime/DateConstructor.h:
(JSC::DateConstructor::create):
* runtime/DateInstance.h:
(JSC::DateInstance::create):
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::create):
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::create):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
* runtime/ExceptionHelpers.h:
(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::create):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
* runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::create):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
* runtime/GetterSetter.h:
(JSC::GetterSetter::create):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::create):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
* runtime/JSByteArray.h:
(JSC::JSByteArray::create): Use the NotNull version of placement
new to skip the NULL check.
* runtime/JSCell.h: Removed a conflicting, unnecessaray placement new.
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
* runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::create):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::create):
* runtime/JSONObject.h:
(JSC::JSONObject::create):
* runtime/JSObject.h:
(JSC::JSFinalObject::create):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
* runtime/JSString.cpp:
(JSC::StringObject::create):
* runtime/JSString.h:
(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
* runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::create):
* runtime/NumberObject.h:
(JSC::NumberObject::create):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::create):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::create):
* runtime/RegExp.cpp:
(JSC::RegExp::createWithoutCaching):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::create):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::create):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
* runtime/StringConstructor.h:
(JSC::StringConstructor::create):
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::createStructure):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
* testRegExp.cpp:
(GlobalObject::create):
* wtf/BitVector.cpp:
(WTF::BitVector::OutOfLineBits::create): Use the NotNull version of placement
new to skip the NULL check.
* wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::create): Standardized spacing to make grep easier.
* wtf/ByteArray.cpp:
(WTF::ByteArray::create):
* wtf/Deque.h:
(WTF::::append):
(WTF::::prepend): Use NotNull, as above.
* wtf/FastAllocBase.h: Added a placement new, since this class would otherwise
hide the name of the global placement new.
(WTF::fastNew): Standardized spacing. Most of these functions don't need
NotNull, since they check for NULL, and the optimizer can see that.
* wtf/HashTable.h:
* wtf/HashTraits.h:
(WTF::SimpleClassHashTraits::constructDeletedValue):
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::allocFreeSpaceNode): NotNull, as above.
* wtf/StdLibExtras.h:
(throw): This is our NotNull placement new. Declaring that we throw is
the C++ way to say that operator new will not return NULL.
* wtf/ThreadSpecific.h:
(WTF::T):
* wtf/Vector.h:
(WTF::::append):
(WTF::::tryAppend):
(WTF::::uncheckedAppend):
(WTF::::insert):
* wtf/text/AtomicStringHash.h:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):
* wtf/text/StringImpl.h:
(WTF::StringImpl::tryCreateUninitialized):
* wtf/text/StringStatics.cpp:
(WTF::AtomicString::init): Use NotNull, as above.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): Standardized
spacing for easy grep.
2011-12-19 Eric Carlson <eric.carlson@apple.com>
Enable <track> for Mac build
https://bugs.webkit.org/show_bug.cgi?id=74838
Reviewed by Darin Adler.
* wtf/Platform.h:
2011-12-18 Filip Pizlo <fpizlo@apple.com>
DFG is too sloppy with register allocation
https://bugs.webkit.org/show_bug.cgi?id=74835
Reviewed by Gavin Barraclough.
Added assertions that at the end of a successfully generated basic block,
all use counts should be zero. This revealed a number of bugs:
- Array length optimizations were turning a must-generate node into one
that is not must-generate, but failing to change the ref count
accordingly.
- Indexed property storage optimizations were failing to deref their
children, or to deref the indexed property storage node itself. Also,
they used the Phantom node as a replacement. But the Phantom node is
must-generate, which was causing bizarre issues. So this introduces a
Nop node, which should be used in cases where you want a node that is
skipped and has no children.
This does not have any significant performance effect, but it should
relieve some register pressure. The main thing this patch adds, though,
are the assertions, which should make it easier to do register allocation
related changes in the future.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::use):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
* dfg/DFGNode.h:
(JSC::DFG::Node::deref):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-18 Benjamin Poulain <bpoulain@apple.com>
Remove the duplicated code from ASCIICType.h
https://bugs.webkit.org/show_bug.cgi?id=74771
Reviewed by Andreas Kling.
Use isASCIIDigit() and isASCIIAlpha() instead of copying the code.
* wtf/ASCIICType.h:
(WTF::isASCIIDigit):
(WTF::isASCIIAlphanumeric):
(WTF::isASCIIHexDigit):
2011-12-18 Anders Carlsson <andersca@apple.com>
Set the main frame view scroll position asynchronously
https://bugs.webkit.org/show_bug.cgi?id=74823
Reviewed by Sam Weinig.
* JavaScriptCore.exp:
2011-12-10 Andreas Kling <kling@webkit.org>
OpaqueJSClass: Remove RVCT2 workarounds.
<http://webkit.org/b/74250>
Reviewed by Benjamin Poulain.
We no longer need workarounds for the RVCT2 compiler since it was
only used for the Symbian port of WebKit which is now defunct.
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
2011-12-16 Benjamin Poulain <bpoulain@apple.com>
Remove the duplicated code from ASCIICType.h
https://bugs.webkit.org/show_bug.cgi?id=74771
Reviewed by Andreas Kling.
The functions were sharing similar code and were defined for the various input types.
Use templates instead to avoid code duplication.
* wtf/ASCIICType.h:
(WTF::isASCII):
(WTF::isASCIIAlpha):
(WTF::isASCIIAlphanumeric):
(WTF::isASCIIDigit):
(WTF::isASCIIHexDigit):
(WTF::isASCIILower):
(WTF::isASCIIOctalDigit):
(WTF::isASCIIPrintable):
(WTF::isASCIISpace):
(WTF::isASCIIUpper):
(WTF::toASCIILower):
(WTF::toASCIIUpper):
(WTF::toASCIIHexValue):
(WTF::lowerNibbleToASCIIHexDigit):
(WTF::upperNibbleToASCIIHexDigit):
2011-12-16 Filip Pizlo <fpizlo@apple.com>
DFG OSR exit may get confused about where in the scratch buffer it stored a value
https://bugs.webkit.org/show_bug.cgi?id=74695
Reviewed by Oliver Hunt.
The code that reads from the scratch buffer now explicitly knows which locations to
read from. No new tests, since this patch covers a case so uncommon that I don't know
how to make a test for it.
* dfg/DFGOSRExitCompiler.h:
(JSC::DFG::OSRExitCompiler::badIndex):
(JSC::DFG::OSRExitCompiler::initializePoisoned):
(JSC::DFG::OSRExitCompiler::poisonIndex):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
2011-12-16 Oliver Hunt <oliver@apple.com>
PutByVal[Alias] unnecessarily reloads the storage buffer
https://bugs.webkit.org/show_bug.cgi?id=74747
Reviewed by Gavin Barraclough.
Make PutByVal use GetIndexedStorage to load the storage buffer.
This required switching PutByVal to a vararg node (which is
responsible for most of the noise in this patch). This fixes the
remaining portion of the kraken regression caused by the GetByVal
storage load elimination, and a 1-5% win on some of the sub tests of
the typed array benchmark at:
http://stepheneb.github.com/webgl-matrix-benchmarks/matrix_benchmark.html
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::byValIndexIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-16 Daniel Bates <dbates@rim.com>
Include BlackBerryPlatformLog.h instead of BlackBerryPlatformMisc.h
Rubber-stamped by Antonio Gomes.
BlackBerry::Platform::logV() is declared in BlackBerryPlatformLog.h. That is, it isn't
declared in BlackBerryPlatformMisc.h. Hence, we should include BlackBerryPlatformLog.h
instead of BlackBerryPlatformMisc.h.
* wtf/Assertions.cpp:
2011-12-16 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize destructors
https://bugs.webkit.org/show_bug.cgi?id=74331
Reviewed by Geoffrey Garen.
This is a megapatch which frees us from the chains of virtual destructors.
In order to remove the virtual destructors, which are the last of the virtual
functions, from the JSCell hierarchy, we need to add the ClassInfo pointer to
the cell rather than to the structure because in order to be able to lazily call
the static destroy() functions that will replace the virtual destructors, we
need to be able to access the ClassInfo without the danger of the object's
Structure being collected before the object itself.
After adding the ClassInfo to the cell, we can then begin to remove our use
of vptrs for optimizations within the JIT and the GC. When we have removed
all of the stored vptrs from JSGlobalData, we can then also remove all of
the related VPtrStealingHack code.
The replacement for virtual destructors will be to add a static destroy function
pointer to the MethodTable stored in ClassInfo. Any subclass of JSCell that has
a non-trivial destructor will require its own static destroy function to static
call its corresponding destructor, which will now be non-virtual. In future
patches we will slowly move away from destructors altogether as we make more and
more objects backed by GC memory rather than malloc-ed memory. The GC will now
call the static destroy method rather than the virtual destructor.
As we go through the hierarchy and add static destroy functions to classes,
we will also add a new assert, ASSERT_HAS_TRIVIAL_DESTRUCTOR, to those classes
to which it applies. The future goal is to eventually have every class have that assert.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::destroy): Add a destroy function to statically call
~JSCallbackConstructor because it has some extra destruction logic.
* API/JSCallbackConstructor.h:
* API/JSCallbackFunction.cpp: Add trivial destructor assert for JSCallbackFunction.
* API/JSCallbackObject.cpp: Add a destroy function to statically call ~JSCallbackObject
because it has a member OwnPtr that needs destruction.
(JSC::::destroy):
* API/JSCallbackObject.h:
* JavaScriptCore.exp: Add/remove necessary symbols for JSC.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Same for Windows symbols.
* debugger/DebuggerActivation.cpp: DebuggerActivation, for some strange reason, didn't
have its own ClassInfo despite the fact that it overrides a number of MethodTable
methods. Added the ClassInfo, along with an assertion that its destructor is trivial.
* debugger/DebuggerActivation.h:
* dfg/DFGOperations.cpp: Remove global data first argument to isJSArray, isJSByteArray,
isJSString, as it is no longer necessary.
(JSC::DFG::putByVal):
* dfg/DFGRepatch.cpp: Ditto. Also remove uses of jsArrayVPtr in favor of using the
JSArray ClassInfo pointer.
(JSC::DFG::tryCacheGetByID):
* dfg/DFGSpeculativeJIT.cpp: Replace uses of the old vptrs with new ClassInfo
comparisons since we don't have vptrs anymore.
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h: Ditto.
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
* dfg/DFGSpeculativeJIT32_64.cpp: Ditto.
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp: Ditto.
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* heap/Heap.cpp: Remove all uses of vptrs in GC optimizations and replace them with
ClassInfo comparisons.
(JSC::Heap::Heap):
* heap/MarkStack.cpp: Ditto.
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::visitChildren):
(JSC::SlotVisitor::drain):
* heap/MarkStack.h: Ditto.
(JSC::MarkStack::MarkStack):
* heap/MarkedBlock.cpp: Ditto.
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedSweep):
* heap/MarkedBlock.h: Ditto.
* heap/SlotVisitor.h: Ditto.
(JSC::SlotVisitor::SlotVisitor):
* heap/VTableSpectrum.cpp: Now that we don't have vptrs, we can't count them.
We'll have to rename this class and make it use ClassInfo ptrs in a future patch.
(JSC::VTableSpectrum::count):
* interpreter/Interpreter.cpp: Remove all global data arguments from isJSArray,
etc. functions.
(JSC::loadVarargs):
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JIT.h: Remove vptr argument from emitAllocateBasicJSObject
* jit/JITInlineMethods.h: Remove vptr planting, and add ClassInfo planting,
remove all vtable related code.
(JSC::JIT::emitLoadCharacterString):
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
* jit/JITOpcodes.cpp: Replace vptr related branch code with corresponding ClassInfo.
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_convert_this):
* jit/JITOpcodes32_64.cpp: Ditto.
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_convert_this):
* jit/JITPropertyAccess.cpp: Ditto.
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITPropertyAccess32_64.cpp: Ditto.
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITStubs.cpp: Remove global data argument from isJSString, etc.
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* jit/SpecializedThunkJIT.h: Replace vptr related stuff with ClassInfo stuff.
(JSC::SpecializedThunkJIT::loadJSStringArgument):
* runtime/ArrayConstructor.cpp: Add trivial destructor assert.
* runtime/ArrayPrototype.cpp: Remove global data argument from isJSArray.
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
* runtime/BooleanConstructor.cpp: Add trivial destructor assert.
* runtime/BooleanObject.cpp: Ditto.
* runtime/BooleanPrototype.cpp: Ditto.
* runtime/ClassInfo.h: Add destroy function pointer to MethodTable.
* runtime/DateConstructor.cpp: Add trivial destructor assert.
* runtime/DateInstance.cpp: Add destroy function for DateInstance because it has a RefPtr
that needs destruction.
(JSC::DateInstance::destroy):
* runtime/DateInstance.h:
* runtime/Error.cpp: Ditto (because of UString member).
(JSC::StrictModeTypeErrorFunction::destroy):
* runtime/Error.h:
* runtime/ErrorConstructor.cpp: Add trivial destructor assert.
* runtime/ErrorInstance.cpp: Ditto.
* runtime/ExceptionHelpers.cpp: Ditto.
* runtime/Executable.cpp: Add destroy functions for ExecutableBase and subclasses.
(JSC::ExecutableBase::destroy):
(JSC::NativeExecutable::destroy):
(JSC::ScriptExecutable::destroy):
(JSC::EvalExecutable::destroy):
(JSC::ProgramExecutable::destroy):
(JSC::FunctionExecutable::destroy):
* runtime/Executable.h:
* runtime/FunctionConstructor.cpp: Add trivial destructor assert.
* runtime/FunctionPrototype.cpp: Ditto. Also remove global data first arg from isJSArray.
(JSC::functionProtoFuncApply):
* runtime/GetterSetter.cpp: Ditto.
* runtime/InitializeThreading.cpp: Remove call to JSGlobalData::storeVPtrs since it no
longer exists.
(JSC::initializeThreadingOnce):
* runtime/InternalFunction.cpp: Remove vtableAnchor function, add trivial destructor assert,
remove first arg from isJSString.
(JSC::InternalFunction::displayName):
* runtime/InternalFunction.h: Remove VPtrStealingHack.
* runtime/JSAPIValueWrapper.cpp: Add trivial destructor assert.
* runtime/JSArray.cpp: Add static destroy to call ~JSArray. Replace vptr checks in
destructor with ClassInfo checks.
(JSC::JSArray::~JSArray):
(JSC::JSArray::destroy):
* runtime/JSArray.h: Remove VPtrStealingHack. Remove globalData argument from isJSArray
and change them to check the ClassInfo rather than the vptrs.
(JSC::isJSArray):
* runtime/JSBoundFunction.cpp: Add trival destructor assert. Remove first arg from isJSArray.
(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
* runtime/JSByteArray.cpp: Add static destroy function, replace vptr checks with ClassInfo checks.
(JSC::JSByteArray::~JSByteArray):
(JSC::JSByteArray::destroy):
* runtime/JSByteArray.h: Remove VPtrStealingHack code.
(JSC::isJSByteArray):
* runtime/JSCell.cpp: Add trivial destructor assert. Add static destroy function.
(JSC::JSCell::destroy):
* runtime/JSCell.h: Remove VPtrStealingHack code. Add function for returning the offset
of the ClassInfo pointer in the object for use by the JIT. Add the ClassInfo pointer to
the JSCell itself, and grab it from the Structure. Remove the vptr and setVPtr functions,
as they are no longer used. Add a validatedClassInfo function to JSCell for any clients
that want to verify, while in Debug mode, that the ClassInfo contained in the cell is the
same one as that contained in the Structure. This isn't used too often, because most of
the places where we compare the ClassInfo to things can be called during destruction.
Since the Structure is unreliable during the phase when destructors are being called,
we can't call validatedClassInfo.
(JSC::JSCell::classInfoOffset):
(JSC::JSCell::structure):
(JSC::JSCell::classInfo):
* runtime/JSFunction.cpp: Remove VPtrStealingHack code. Add static destroy, remove vtableAnchor,
remove first arg from call to isJSString.
(JSC::JSFunction::destroy):
(JSC::JSFunction::displayName):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp: Remove all VPtr stealing code and storage, including storeVPtrs,
as these vptrs are no longer needed in the codebase.
* runtime/JSGlobalData.h:
(JSC::TypedArrayDescriptor::TypedArrayDescriptor): Changed the TypedArrayDescriptor to use
ClassInfo rather than the vptr.
* runtime/JSGlobalObject.cpp: Add static destroy function.
(JSC::JSGlobalObject::destroy):
* runtime/JSGlobalObject.h:
* runtime/JSGlobalThis.cpp: Add trivial destructor assert.
* runtime/JSNotAnObject.cpp: Ditto.
* runtime/JSONObject.cpp: Ditto. Remove first arg from isJSArray calls.
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSFinalObject::destroy):
(JSC::JSNonFinalObject::destroy):
(JSC::JSObject::destroy):
* runtime/JSObject.h: Add trivial destructor assert for JSObject, remove vtableAnchor
from JSNonFinalObject and JSFinalObject, add static destroy for JSFinalObject and
JSNonFinalObject, add isJSFinalObject utility function similar to isJSArray, remove all VPtrStealingHack code.
(JSC::JSObject::finishCreation):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::finishCreation):
(JSC::isJSFinalObject):
* runtime/JSPropertyNameIterator.cpp: Add static destroy.
(JSC::JSPropertyNameIterator::destroy):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp: Ditto.
(JSC::JSStaticScopeObject::destroy):
* runtime/JSStaticScopeObject.h: Ditto.
* runtime/JSString.cpp:
(JSC::JSString::destroy):
* runtime/JSString.h: Ditto. Remove VPtrStealingHack code. Also remove fixupVPtr code,
since we no longer need to fixup vptrs.
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring8):
(JSC::jsSubstring):
(JSC::jsOwnedString):
(JSC::jsStringBuilder):
(JSC::isJSString):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::destroy):
* runtime/JSVariableObject.h: Ditto.
* runtime/JSWrapperObject.cpp:
* runtime/JSWrapperObject.h: Add trivial destructor assert.
* runtime/MathObject.cpp: Ditto.
* runtime/NativeErrorConstructor.cpp: Ditto.
* runtime/NumberConstructor.cpp: Ditto.
* runtime/NumberObject.cpp: Ditto.
* runtime/NumberPrototype.cpp: Ditto.
* runtime/ObjectConstructor.cpp: Ditto.
* runtime/ObjectPrototype.cpp: Ditto.
* runtime/Operations.h: Remove calls to fixupVPtr, remove first arg to isJSString.
(JSC::jsString):
(JSC::jsLess):
(JSC::jsLessEq):
* runtime/RegExp.cpp: Add static destroy.
(JSC::RegExp::destroy):
* runtime/RegExp.h:
* runtime/RegExpConstructor.cpp: Add static destroy for RegExpConstructor and RegExpMatchesArray.
(JSC::RegExpConstructor::destroy):
(JSC::RegExpMatchesArray::destroy):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp: Add static destroy.
(JSC::RegExpObject::destroy):
* runtime/RegExpObject.h:
* runtime/ScopeChain.cpp: Add trivial destructor assert.
* runtime/ScopeChain.h:
* runtime/StrictEvalActivation.cpp: Ditto.
* runtime/StringConstructor.cpp:
* runtime/StringObject.cpp: Ditto. Remove vtableAnchor.
* runtime/StringObject.h:
* runtime/StringPrototype.cpp: Ditto.
* runtime/Structure.cpp: Add static destroy.
(JSC::Structure::destroy):
* runtime/Structure.h: Move JSCell::finishCreation and JSCell constructor into Structure.h
because they need to have the full Structure type to access the ClassInfo to store in the JSCell.
(JSC::JSCell::setStructure):
(JSC::JSCell::validatedClassInfo):
(JSC::JSCell::JSCell):
(JSC::JSCell::finishCreation):
* runtime/StructureChain.cpp: Add static destroy.
(JSC::StructureChain::destroy):
* runtime/StructureChain.h:
* wtf/Assertions.h: Add new assertion ASSERT_HAS_TRIVIAL_DESTRUCTOR, which uses clangs
ability to tell us when a class has a trivial destructor. We will use this assert
more in future patches as we move toward having all JSC objects backed by GC memory,
which means moving away from using destructors/finalizers.
2011-12-15 Martin Robinson <mrobinson@igalia.com>
Fix 'make dist' in preparation for the GTK+ release.
* GNUmakefile.list.am: Add missing header.
2011-12-15 Sam Weinig <sam@webkit.org>
<rdar://problem/10552550> JavaScriptCore uses obsolete 'cpy' mnemonic in ARM assembly
Reviewed by Gavin Barraclough.
Original patch by Jim Grosbach.
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
Replace uses of the 'cpy' mnemonic with 'mov'.
2011-12-15 Filip Pizlo <fpizlo@apple.com>
Value profiling should distinguished between NaN and non-NaN doubles
https://bugs.webkit.org/show_bug.cgi?id=74682
Reviewed by Gavin Barraclough.
Added PredictDoubleReal and PredictDoubleNaN. PredictDouble is now the union
of the two.
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromValue):
* bytecode/PredictedType.h:
(JSC::isDoubleRealPrediction):
(JSC::isDoublePrediction):
2011-12-15 Anders Carlsson <andersca@apple.com>
Regression (r102866): Navigating away from or closing a page with a plugin crashes
https://bugs.webkit.org/show_bug.cgi?id=74655
<rdar://problem/10590024>
Reviewed by Sam Weinig.
Rewrite HasRefAndDeref to work if ref and deref are implemented in base classes,
using a modified version of the technique described here:
http://groups.google.com/group/comp.lang.c++.moderated/msg/e5fbc9305539f699
* wtf/Functional.h:
2011-12-15 Andy Wingo <wingo@igalia.com>
Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
https://bugs.webkit.org/show_bug.cgi?id=74624
Reviewed by Darin Adler.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Fix variables unused in
release mode.
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment): Fix
signed/unsigned comparison warning, with a cast.
2011-12-15 Andy Wingo <wingo@igalia.com>
Use more macrology in JSC::Options
https://bugs.webkit.org/show_bug.cgi?id=72938
Reviewed by Filip Pizlo.
* runtime/Options.cpp:
(JSC::Options::initializeOptions):
* runtime/Options.h: Use macros to ensure that all heuristics are
declared and have initializers.
2011-12-15 Anders Carlsson <andersca@apple.com>
Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define
https://bugs.webkit.org/show_bug.cgi?id=74639
Reviewed by Andreas Kling.
Add ENABLE_THREADED_SCROLLING #define.
* wtf/Platform.h:
2011-12-15 Anders Carlsson <andersca@apple.com>
EventDispatcher should handle wheel events on the connection queue
https://bugs.webkit.org/show_bug.cgi?id=74627
Reviewed by Andreas Kling.
Add a BoundFunctionImpl specialization that takes three parameters.
* wtf/Functional.h:
(WTF::C::):
(WTF::R):
(WTF::bind):
2011-12-14 Anders Carlsson <andersca@apple.com>
Add WTF::Function to wtf/Forward.h
https://bugs.webkit.org/show_bug.cgi?id=74576
Reviewed by Adam Roben.
* jsc.cpp:
Work around a name conflict in the readline library.
* wtf/Forward.h:
Add Function.
2011-12-15 Igor Oliveira <igor.oliveira@openbossa.org>
[Qt] Support requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=74528
Let Qt port use REQUEST_ANIMATION_FRAME_TIMER.
Reviewed by Kenneth Rohde Christiansen.
* wtf/Platform.h:
2011-12-15 Andy Wingo <wingo@igalia.com>
Minor refactor to Parser::parseTryStatement
https://bugs.webkit.org/show_bug.cgi?id=74507
Reviewed by Geoffrey Garen.
* parser/Parser.cpp (JSC::Parser::parseTryStatement): Use the
Parser's declareVariable instead of going directly to the scope.
This will facilitate future checks related to harmony block
scoping.
2011-12-15 Andy Wingo <wingo@igalia.com>
Rename JSC::Heuristics to JSC::Options
https://bugs.webkit.org/show_bug.cgi?id=72889
Reviewed by Filip Pizlo.
* runtime/Options.cpp: Renamed from Source/JavaScriptCore/runtime/Heuristics.cpp.
* runtime/Options.h: Renamed from Source/JavaScriptCore/runtime/Heuristics.h.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
* heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
* heap/MarkStack.h:
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStackArray::canDonateSomeCells):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce): Adapt callers and build systems.
* testRegExp.cpp:
(CommandLine::CommandLine):
* jsc.cpp:
(CommandLine::CommandLine):
Rename from Options, to avoid name conflict.
2011-12-14 Sam Weinig <sam@webkit.org>
Revert unintentional change to JavaScriptCore.def
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-12-14 Sam Weinig <weinig@apple.com>
Remove whitespace from InheritedPropertySheets attributes in
vsprops files to appease the Visual Studio project migrator.
Reviewed by Adam Roben.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebug.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugAll.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugCairoCFLite.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
* JavaScriptCore.vcproj/WTF/WTFDebug.vsprops:
* JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops:
* JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops:
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
* JavaScriptCore.vcproj/WTF/WTFRelease.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
* JavaScriptCore.vcproj/jsc/jscDebug.vsprops:
* JavaScriptCore.vcproj/jsc/jscDebugAll.vsprops:
* JavaScriptCore.vcproj/jsc/jscDebugCairoCFLite.vsprops:
* JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
* JavaScriptCore.vcproj/jsc/jscRelease.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpDebug.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpDebugAll.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpDebugCairoCFLite.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpProduction.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpRelease.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops:
* JavaScriptCore.vcproj/testapi/testapiDebug.vsprops:
* JavaScriptCore.vcproj/testapi/testapiDebugAll.vsprops:
* JavaScriptCore.vcproj/testapi/testapiDebugCairoCFLite.vsprops:
* JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
* JavaScriptCore.vcproj/testapi/testapiRelease.vsprops:
* JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops:
2011-12-14 Anders Carlsson <andersca@apple.com>
binding a member function should ref/deref the object pointer if needed
https://bugs.webkit.org/show_bug.cgi?id=74552
Reviewed by Sam Weinig.
Add a HasRefAndDeref helper class template which checks if a given class type has ref and deref
member functions which the right type. Use this to determine if we should ref/deref the first parameter.
* wtf/Functional.h:
(WTF::R):
(WTF::C::):
(WTF::RefAndDeref::ref):
(WTF::RefAndDeref::deref):
2011-12-14 Hajime Morrita <morrita@chromium.org>
JS_INLINE and WTF_INLINE should be visible from WebCore
https://bugs.webkit.org/show_bug.cgi?id=73191
- Moved Export related macro definitions from config.h to ExportMacros.h and JSExportMacros.h.
- Moved WTF_USE_JSC and WTF_USE_V8 from various config.h family to Platform.h.
- Replaced JS_EXPORTDATA in wtf moudule with newly introduced WTF_EXPORTDATA.
Reviewed by Kevin Ollivier.
* JavaScriptCore.xcodeproj/project.pbxproj:
* config.h:
* runtime/JSExportMacros.h: Added.
* wtf/ExportMacros.h:
* wtf/Platform.h:
* wtf/WTFThreadData.h:
* wtf/text/AtomicString.h:
* wtf/text/StringStatics.cpp:
2011-12-14 Anders Carlsson <andersca@apple.com>
Work around a bug in the MSVC2005 compiler
https://bugs.webkit.org/show_bug.cgi?id=74550
Reviewed by Sam Weinig.
Add template parameters for the return types of the partial specializations of BoundFunctionImpl.
* wtf/Functional.h:
(WTF::R):
2011-12-13 Jon Lee <jonlee@apple.com>
Enable notifications on Mac.
Reviewed by Sam Weinig.
* Configurations/FeatureDefines.xcconfig:
2011-12-14 David Kilzer <ddkilzer@apple.com>
Remove definition of old ENABLE(YARR) macro
<http://webkit.org/b/74532>
Reviewed by Darin Adler.
* wtf/Platform.h: Removed ENABLE_YARR macros.
2011-12-14 Anders Carlsson <andersca@apple.com>
bind should handle member functions
https://bugs.webkit.org/show_bug.cgi?id=74529
Reviewed by Sam Weinig.
Add FunctionWrapper partial specializations for member function pointers.
* wtf/Functional.h:
(WTF::C::):
2011-12-14 Gavin Barraclough <barraclough@apple.com>
DFG relies on returning a struct in registers
https://bugs.webkit.org/show_bug.cgi?id=74527
Reviewed by Geoff Garen.
This will not work on all platforms. Returning a uint64_t will more reliably achieve
what we want, on 32-bit platforms (on 64-bit, stick with the struct return).
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
(JSC::DFG::DFGHandler::dfgHandlerEncoded):
2011-12-14 Anders Carlsson <andersca@apple.com>
Add unary and binary bind overloads
https://bugs.webkit.org/show_bug.cgi?id=74524
Reviewed by Sam Weinig.
* wtf/Functional.h:
(WTF::R):
(WTF::FunctionWrapper::ResultType):
(WTF::bind):
2011-12-14 Anders Carlsson <andersca@apple.com>
Add back the callOnMainThread overload that takes a WTF::Function
https://bugs.webkit.org/show_bug.cgi?id=74512
Reviewed by Darin Adler.
Add back the overload; the changes to WebCore should hopefully keep Windows building.
* wtf/MainThread.cpp:
(WTF::callFunctionObject):
(WTF::callOnMainThread):
* wtf/MainThread.h:
2011-12-13 Filip Pizlo <fpizlo@apple.com>
DFG should infer when local variables are doubles
https://bugs.webkit.org/show_bug.cgi?id=74480
Reviewed by Oliver Hunt.
Introduced the notion that a local variable (though not an argument, yet!) can
be stored as a double, and will be guaranteed to always contain a double. This
requires more magic in the OSR (conversion in both entry and exit). The inference
is quite unorthodox: all uses of a variable vote on whether they think it should
be a double or a JSValue, based on how they use it. If they use it in an integer
or boxed value context, they vote JSValue. If they use it in a double context,
they vote double. This voting is interleaved in the propagator's fixpoint, so
that variables voted double then have a double prediction propagated from them.
This interleaving is needed because a variable that actually always contains an
integer that always gets used in arithmetic that involves doubles may end up
being voted double, which then means that all uses of the variable will see a
double rather than an integer.
This is worth 18% to SunSpider/3d-cube, 7% to Kraken/audio-beat-detection, 7%
to Kraken/audio-fft, 6% to Kraken/imaging-darkroom, 20% to
Kraken/imaging-gaussian-blur, and just over 1% to Kraken/json-parse-financial.
It results in a 1% speed-up on SunSpider and a 4% speed-up in Kraken. Similar
results on JSVALUE32_64, though with a bigger win on Kraken (5%) and no overall
win on SunSpider.
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedDouble):
(JSC::ValueRecovery::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::boxDouble):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::propagatePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::clearVotes):
(JSC::DFG::VariableAccessData::vote):
(JSC::DFG::VariableAccessData::doubleVoteRatio):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
* runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
2011-12-13 Anders Carlsson <andersca@apple.com>
Try to fix the Windows build.
Remove the callOnMainThread overload that takes a WTF::Function since it's not being used.
* wtf/MainThread.cpp:
* wtf/MainThread.h:
2011-12-13 Anders Carlsson <andersca@apple.com>
Add a very bare-bones implementation of bind and Function to WTF
https://bugs.webkit.org/show_bug.cgi?id=74462
Reviewed by Sam Weinig.
In order to make it easier to package up function calls and send them across
threads, add a (currently very simple) implementation of WTF::bind and WTF::Function to a new
wtf/Functional.h header.
Currently, all bind can do is bind a nullary function and return a Function object that can be called and copied,
but I'll add more as the need arises.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Functional.h: Added.
(WTF::R):
(WTF::FunctionImplBase::~FunctionImplBase):
(WTF::FunctionWrapper::ResultType):
(WTF::FunctionBase::isNull):
(WTF::FunctionBase::FunctionBase):
(WTF::FunctionBase::impl):
(WTF::bind):
* wtf/MainThread.cpp:
(WTF::callFunctionObject):
(WTF::callOnMainThread):
* wtf/MainThread.h:
* wtf/wtf.pro:
2011-12-13 Geoffrey Garen <ggaren@apple.com>
<rdar://problem/10577239> GC Crash introduced in r102545
Reviewed by Gavin Barraclough.
MarkedArgumentBuffer was still marking items in forwards order, even though
the argument order has been reversed.
I fixed this bug, and replaced address calculation code with some helper
functions -- mallocBase() and slotFor() -- so it stays fixed everywhere.
* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::markLists):
(JSC::MarkedArgumentBuffer::slowAppend):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::at):
(JSC::MarkedArgumentBuffer::append):
(JSC::MarkedArgumentBuffer::last):
(JSC::MarkedArgumentBuffer::slotFor):
(JSC::MarkedArgumentBuffer::mallocBase):
2011-12-13 Filip Pizlo <fpizlo@apple.com>
DFG OSR exit for UInt32ToNumber should roll forward, not roll backward
https://bugs.webkit.org/show_bug.cgi?id=74463
Reviewed by Gavin Barraclough.
Implements roll-forward OSR exit for UInt32ToNumber, which requires ValueRecoveries knowing
how to execute the slow path of UInt32ToNumber.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::lastOSRExit):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::operator!=):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::uint32InGPR):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::dump):
* dfg/DFGAssemblyHelpers.cpp:
* dfg/DFGAssemblyHelpers.h:
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::valueRecoveryForOperand):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compile):
2011-12-13 Oliver Hunt <oliver@apple.com>
Arguments object doesn't handle mutation of length property correctly
https://bugs.webkit.org/show_bug.cgi?id=74454
Reviewed by Gavin Barraclough.
Correct handling of arguments objects with overridden length property
* interpreter/Interpreter.cpp:
(JSC::loadVarargs):
* runtime/Arguments.cpp:
(JSC::Arguments::copyToArguments):
(JSC::Arguments::fillArgList):
2011-12-13 Filip Pizlo <fpizlo@apple.com>
DFG GetByVal CSE rule should match PutByValAlias
https://bugs.webkit.org/show_bug.cgi?id=74390
Reviewed by Geoff Garen.
Tiny win on some benchmarks. Maybe a 0.2% win on SunSpider.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):
2011-12-13 Andy Wingo <wingo@igalia.com>
Fix interpreter debug build.
https://bugs.webkit.org/show_bug.cgi?id=74439
Reviewed by Geoffrey Garen.
* bytecode/ValueRecovery.h: Include stdio.h on debug builds.
2011-12-13 Filip Pizlo <fpizlo@apple.com>
DFG should know exactly why recompilation was triggered
https://bugs.webkit.org/show_bug.cgi?id=74362
Reviewed by Oliver Hunt.
Each OSR exit is now individually counted, as well as counting the total number
of OSR exits that occurred in a code block. If recompilation is triggered, we
check to see if there are OSR exit sites that make up a sufficiently large
portion of the total OSR exits that occurred. For any such OSR exit sites, we
add a description of the site (bytecode index, kind) to a data structure in the
corresponding baseline CodeBlock. Then, when we recompile the code, we immediately
know which speculations would be unwise based on the fact that previous such
speculations proved to be fruitless.
This means 2% win on two of the SunSpider string tests, a 4% win on V8's deltablue,
and 5% on Kraken's imaging-darkroom. It is only a minor win in the averages, less
than 0.5%.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::exitProfile):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::tallyFrequentExitSites):
* bytecode/DFGExitProfile.cpp: Added.
(JSC::DFG::ExitProfile::ExitProfile):
(JSC::DFG::ExitProfile::~ExitProfile):
(JSC::DFG::ExitProfile::add):
(JSC::DFG::QueryableExitProfile::QueryableExitProfile):
(JSC::DFG::QueryableExitProfile::~QueryableExitProfile):
* bytecode/DFGExitProfile.h: Added.
(JSC::DFG::exitKindToString):
(JSC::DFG::exitKindIsCountable):
(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::FrequentExitSite::operator!):
(JSC::DFG::FrequentExitSite::operator==):
(JSC::DFG::FrequentExitSite::hash):
(JSC::DFG::FrequentExitSite::bytecodeOffset):
(JSC::DFG::FrequentExitSite::kind):
(JSC::DFG::FrequentExitSite::isHashTableDeletedValue):
(JSC::DFG::FrequentExitSiteHash::hash):
(JSC::DFG::FrequentExitSiteHash::equal):
(JSC::DFG::QueryableExitProfile::hasExitSite):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
2011-12-13 Michael Saboff <msaboff@apple.com>
Cleanup of StringImpl::equal in r102631 post commit
https://bugs.webkit.org/show_bug.cgi?id=74421
Reviewed by Darin Adler.
* wtf/text/AtomicString.h:
(WTF::operator==): Removed cast no longer needed.
* wtf/text/StringImpl.h:
(WTF::equal): Changed template to several overloaded methods.
2011-12-12 Michael Saboff <msaboff@apple.com>
Eliminate Duplicate word at a time equal code in StringImpl.cpp and StringHash.h
https://bugs.webkit.org/show_bug.cgi?id=73622
Reviewed by Oliver Hunt.
Moved equal(charType1 *, charType2, unsigned) template methods
from static StringImpl.cpp to StringImpl.h and then replaced the
processor specific character comparison code in StringHash::equal
with calls to these methods.
This change is worth 3% on SunSpider string-unpack-code as reported
by the SunSpider command line harness. No other tests appear to
have measurable performance changes.
* wtf/text/AtomicString.h:
(WTF::operator==):
* wtf/text/StringHash.h:
(WTF::StringHash::equal):
* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(WTF::LChar):
(WTF::UChar):
(WTF::equal):
2011-12-12 Filip Pizlo <fpizlo@apple.com>
ARMv7 version of DFG soft modulo does register allocation inside of control flow
https://bugs.webkit.org/show_bug.cgi?id=74354
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
2011-12-12 Andy Wingo <wingo@igalia.com>
Simplify autotools configure.ac
https://bugs.webkit.org/show_bug.cgi?id=74312
Reviewed by Martin Robinson.
* GNUmakefile.am: Add JSC_CPPFLAGS to javascriptcore_cppflags.
2011-12-12 Filip Pizlo <fpizlo@apple.com>
DFG GetByVal CSE incorrectly assumes that a non-matching PutByVal cannot clobber
https://bugs.webkit.org/show_bug.cgi?id=74329
Reviewed by Gavin Barraclough.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):
2011-12-09 Alexander Pavlov <apavlov@chromium.org>
WebKit does not enumerate over CSS properties in HTMLElement.style
https://bugs.webkit.org/show_bug.cgi?id=23946
Reviewed by Darin Adler.
Add a few exports to follow the JSCSSStyleDeclaration.cpp changes,
introduce an std::sort() comparator function.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.h:
(WTF::codePointCompareLessThan): Used by std::sort() to sort properties.
2011-12-12 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, build fix.
Revert r102570 which broke SnowLeopard builders.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.h:
2011-12-09 Alexander Pavlov <apavlov@chromium.org>
WebKit does not enumerate over CSS properties in HTMLElement.style
https://bugs.webkit.org/show_bug.cgi?id=23946
Reviewed by Darin Adler.
Add a few exports to follow the JSCSSStyleDeclaration.cpp changes,
introduce an std::sort() comparator function.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.h:
(WTF::codePointCompareLessThan): Used by std::sort() to sort properties.
2011-12-12 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck issues.
* GNUmakefile.list.am:
2011-12-11 Sam Weinig <sam@webkit.org>
Fix another signed vs. unsigned warning
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
2011-12-11 Sam Weinig <sam@webkit.org>
Fix a signed vs. unsigned warning.
* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::slowAppend):
Cast inlineCapacity to an int to appease the warning. This is known OK
since inlineCapacity is defined to be 8.
2011-12-11 Geoffrey Garen <ggaren@apple.com>
Rolled out *another* debugging change I committed accidentally.
Unreviewed.
* Configurations/Base.xcconfig:
2011-12-11 Geoffrey Garen <ggaren@apple.com>
Rolled out a debug counter I committed accidentally.
Unreviewed.
* jit/JITStubs.cpp:
(JSC::arityCheckFor):
2011-12-10 Geoffrey Garen <ggaren@apple.com>
v8 benchmark takes 12-13 million function call slow paths due to extra arguments
https://bugs.webkit.org/show_bug.cgi?id=74244
Reviewed by Filip Pizlo.
.arguments function of order the Reversed
10% speedup on v8-raytrace, 1.7% speedup on v8 overall, neutral on Kraken
and SunSpider.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfileForArgument): Clarified that the interface
to this function is an argument number.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::isArgumentNumber): Switched to using CallFrame
helper functions for computing offsets for arguments, rather than doing
the math by hand.
Switched to iterating argument offsets backwards (--) instead of forwards (++).
* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::thisRegister):
(JSC::CallArguments::argumentRegister):
(JSC::CallArguments::registerOffset): Updated for arguments being reversed.
* bytecompiler/NodesCodegen.cpp: Allocate arguments in reverse order.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack): Use abstract argument indices
that just-in-time convert to bytecode operands (i.e., indexes in the register
file) through helper functions. This means only one piece of code needs
to know how arguments are laid out in the register file.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump): Ditto.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor): Ditto.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction): The whole point of this patch:
Treat too many arguments as an arity match.
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForIndex): Use helper functions, as above.
* dfg/DFGOperands.h:
(JSC::DFG::operandToArgument):
(JSC::DFG::argumentToOperand): These are now the only two lines of code in
the DFG compiler that know how arguments are laid out in memory.
(JSC::DFG::Operands::operand):
(JSC::DFG::Operands::setOperand): Use helper functions, as above.
* dfg/DFGOperations.cpp: The whole point of this patch:
Treat too many arguments as an arity match.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall): Use helper functions, as above.
Also, don't tag the caller frame slot as a cell, because it's not a cell.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall): Use helper functions, as above.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile): Use helper functions, as above.
(JSC::DFG::SpeculativeJIT::checkArgumentTypes): Use already-computed
argument virtual register instead of recomputing by hand.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot): Added a few helper
functions for dealing with callee arguments specifically. These still
build on top of our other helper functions, and have no direct knowledge
of how arguments are laid out in the register file.
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument): Renamed argumentIndex to
argumentOffset to match CallFrame naming.
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand): Use helper
functions, as above.
* interpreter/CallFrame.h:
(JSC::ExecState::argumentOffset):
(JSC::ExecState::argumentOffsetIncludingThis):
(JSC::ExecState::argument):
(JSC::ExecState::setArgument):
(JSC::ExecState::thisArgumentOffset):
(JSC::ExecState::thisValue):
(JSC::ExecState::setThisValue):
(JSC::ExecState::offsetFor):
(JSC::ExecState::hostThisRegister):
(JSC::ExecState::hostThisValue): Added a bunch of helper functions for
computing where an argument is in the register file. Anything in the
runtime that needs to access arguments should use these helpers.
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): This stuff is a lot simpler, now
that too many arguments counts as an arity match and doesn't require
preserving two copies of our arguments.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::slideRegisterWindowForCall): Only need to do something
special if the caller provided too few arguments.
Key simplification: We never need to maintain two copies of our arguments
anymore.
(JSC::eval):
(JSC::loadVarargs): Use helper functions.
(JSC::Interpreter::unwindCallFrame): Updated for new interface.
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall): Seriously, though: use helper
functions.
(JSC::Interpreter::privateExecute): No need to check for stack overflow
when calling host functions because they have zero callee registers.
(JSC::Interpreter::retrieveArguments): Explicitly tear off the arguments
object, since there's no special constructor for this anymore.
* interpreter/Interpreter.h: Reduced the C++ re-entry depth because some
workers tests were hitting stack overflow in some of my testing. We should
make this test more exact in future.
* interpreter/RegisterFile.h: Death to all runtime knowledge of argument
location that does not belong to the CallFrame class!
* jit/JIT.cpp:
(JSC::JIT::privateCompile): I am a broken record and I use helper functions.
Also, the whole point of this patch: Treat too many arguments as an arity match.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs): Updated the argument copying math to use
helper functions, for backwards-correctness. Removed the condition
pertaining to declared argument count because, now that arguments are
always in just one place, this optimization is valid for all functions.
Standardized the if predicate for each line of the optimization. This might
fix a bug, but I couldn't get the bug to crash in practice.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_get_argument_by_val):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_get_argument_by_val): Removed cti_op_create_arguments_no_params
optimization because it's no longer an optimization, now that arguments
are always contiguous in a known location.
Updated argument access opcode math for backwards-correctness.
* jit/JITStubs.cpp:
(JSC::arityCheckFor): Updated just like slideRegisterWindowForCall. This
function is slightly different because it copies the call frame in
addition to the arguments. (In the Interpreter, the call frame is not
set up by this point.)
(JSC::lazyLinkFor): The whole point of this patch: Treat too many
arguments as an arity match.
(JSC::DEFINE_STUB_FUNCTION): Updated for new iterface to tearOff().
* jit/JITStubs.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::loadDoubleArgument):
(JSC::SpecializedThunkJIT::loadCellArgument):
(JSC::SpecializedThunkJIT::loadInt32Argument): Use helper functions! They
build strong bones and teeth!
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
(JSC::MarkedArgumentBuffer::slowAppend):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::at):
(JSC::MarkedArgumentBuffer::clear):
(JSC::MarkedArgumentBuffer::append):
(JSC::MarkedArgumentBuffer::removeLast):
(JSC::MarkedArgumentBuffer::last):
(JSC::ArgList::ArgList):
(JSC::ArgList::at): Updated for backwards-correctness. WTF::Vector doesn't
play nice with backwards-ness, so I changed to using manual allocation.
Fixed a FIXME about not all values being marked in the case of out-of-line
arguments. I had to rewrite the loop anyway, and I didn't feel like
maintaining fidelity to its old bugs.
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
(JSC::Arguments::copyToArguments):
(JSC::Arguments::fillArgList):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::tearOff):
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::Arguments):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation): Secondary benefit of this patch: deleted
lots of tricky code designed to maintain two different copies of function
arguments. Now that arguments are always contiguous in one place in memory,
this complexity can go away.
Reduced down to one create function for the Arguments class, from three.
Moved tearOff() into an out-of-line function because it's huge.
Moved logic about whether to tear off eagerly into the Arguments class,
so we didn't have to duplicate it elsewhere.
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::visitChildren): Renamed m_numParametersMinusThis to
m_numCapturedArgs because if the value really were m_numParametersMinusThis
we would be marking too much. (We shouldn't mark 'this' because it can't
be captured.) Also, use helper functions.
* runtime/JSActivation.h:
(JSC::JSActivation::tearOff): Use helper functions.
* runtime/JSArray.cpp:
(JSC::JSArray::copyToArguments):
* runtime/JSArray.h: Use helper functions, as above.
2011-12-10 Mark Hahnenberg <mhahnenberg@apple.com>
JSC testapi is crashing on Windows
https://bugs.webkit.org/show_bug.cgi?id=74233
Reviewed by Sam Weinig.
Same error we've encountered before where we are calling the wrong version of
visitChildren and objects that are still reachable aren't getting marked.
This problem will go away soon with the removal of vptrs for these sorts of
optimizations in favor of using the ClassInfo, but for now we can simply give
JSFinalObject a bogus virtual method that Visual Studio can't optimize away to
ensure that JSFinalObject will always have a unique vptr. We don't have to worry
about JSString or JSArray right now, which are the other two special cases for
visitChildren, since they already have their own virtual functions.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSObject.cpp:
(JSC::JSFinalObject::vtableAnchor):
* runtime/JSObject.h:
2011-12-10 Alexis Menard <alexis.menard@openbossa.org>
Unused variable in YarrJIT.cpp.
https://bugs.webkit.org/show_bug.cgi?id=74237
Reviewed by Andreas Kling.
Variable is set but not used so we can remove it.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
2011-12-09 Filip Pizlo <fpizlo@apple.com>
DFG ArithMul power-of-two case does not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=74230
Reviewed by Gavin Barraclough.
Disabled power-of-2 peephole optimization for multiplication, because it was wrong,
and any attempt to fix it would likely introduce code bloat and register pressure.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMul):
2011-12-09 David Levin <levin@chromium.org>
REGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBase::ref in FunctionCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=73886
Reviewed by Darin Adler.
* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable): Added deprecatedTurnOffVerifier for
another JavaScriptObject, since JavaScriptCore objects allow use on multiple threads.
Bug 58091 is about changing these deprecated calls to something else but that something
else will still need to be in all of these places.
2011-12-09 Konrad Piascik <kpiascik@rim.com>
Remove unnecessary file DissasemblerARM.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=74184
Reviewed by Daniel Bates.
* PlatformBlackBerry.cmake:
2011-12-09 Filip Pizlo <fpizlo@apple.com>
DFG's interpretation of rare case profiles should be frequency-based not count-based
https://bugs.webkit.org/show_bug.cgi?id=74170
Reviewed by Geoff Garen.
DFG optimizes for rare cases only when the rare case counter is above some threshold
and it also constitutes a large enough fraction of total function executions. Also
added some minor debug logic.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::executionEntryCount):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
2011-12-09 Oliver Hunt <oliver@apple.com>
PutByValAlias unnecessarily clobbers GetIndexedPropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=74223
Reviewed by Geoffrey Garen.
Don't clobber GetIndexedPropertyStorage when we see PutByValAlias
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
2011-12-09 David Levin <levin@chromium.org>
Hash* iterators should allow comparison between const and const versions.
https://bugs.webkit.org/show_bug.cgi?id=73370
Reviewed by Darin Adler.
* wtf/HashTable.h: Add the operators needed to do this.
(WTF::HashTableConstIterator::operator==):
(WTF::HashTableConstIterator::operator!=):
(WTF::HashTableIterator::operator==):
(WTF::HashTableIterator::operator!=):
(WTF::operator==):
(WTF::operator!=):
2011-12-09 Michael Saboff <msaboff@apple.com>
YARR: Multi-character read optimization for 8bit strings
https://bugs.webkit.org/show_bug.cgi?id=74191
Reviewed by Oliver Hunt.
Changed generatePatternCharacterOnce to generate
code for 1 to 4 characters in the 8 bit case.
This is worth 29% improvement on SunSpider regexp-dna test.
It provides no benefit to v8-regexp.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generate): Spelling fix in comment.
2011-12-09 David Levin <levin@chromium.org>
Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
https://bugs.webkit.org/show_bug.cgi?id=71695
Reviewed by Zoltan Herczeg.
* wtf/MessageQueue.h:
(WTF::MessageQueue::tryGetMessageIgnoringKilled): Added a way to get messages
even after the queue has been killed. This is useful when one wants to
kill a queue but then go through it to run clean up tasks from it.
2011-12-09 Adrienne Walker <enne@google.com>
Fix HashMap<..., OwnPtr<...> >::add compilation errors
https://bugs.webkit.org/show_bug.cgi?id=74159
Reviewed by Darin Adler.
Add a constructor to OwnPtr that takes the empty value (nullptr_t)
from HashTraits so that this function can compile.
* wtf/OwnPtr.h:
(WTF::OwnPtr::OwnPtr):
2011-12-09 Oliver Hunt <oliver@apple.com>
Avoid reloading storage pointer for indexed properties unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=74136
Reviewed by Filip Pizlo.
Add a node to represent loading property storage for indexed properties.
This allows us to reduce code generated for sequential access of arrays,
strings, etc. This results in up to 5% improvement in code that is
very heavy on indexed reads, such as matrix operations in typed arrays
and 20% faster on microbenchmarks.
Currently this is only supported by GetByVal and other similar indexed reads.
* bytecode/PredictedType.h:
(JSC::isFixedIndexedStorageObjectPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-12-08 Fady Samuel <fsamuel@chromium.org>
[Chromium] Enable viewport metatag
https://bugs.webkit.org/show_bug.cgi?id=73495
Reviewed by Darin Fisher.
* wtf/Platform.h: Added ENABLE(VIEWPORT) tag.
2011-12-08 Adam Klein <adamk@chromium.org>
Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Darin Adler.
* wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.
2011-12-08 Thouraya ANDOLSI <thouraya.andolsi@st.com>
https://bugs.webkit.org/show_bug.cgi?id=74005
fix unaligned access memory in generatePatternCharacterOnce function
for SH4 platforms.
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16Unaligned):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Unaligned):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load16Unaligned):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::branch8):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load16Unaligned):
* jit/JIT.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
2011-12-08 Michael Saboff <msaboff@apple.com>
Add 8 bit paths for StringTypeAdapter classes
https://bugs.webkit.org/show_bug.cgi?id=73882
Reviewed by Darin Adler.
Added is8Bit() method and writeTo(LChar*) methods
to StringTypeAdapter<> classes. The writeTo(LChar*)
method can be used if is8Bit() returns true. The
non-native 8 bit classes contain ASSERT(is8Bit())
in their writeTo(LChar*).
Updated all of the various versions of tryMakeString() to
use 8 bit processing in the updated StringTypeAdapter<>
classes.
This has slight if any performance improvement on kraken.
* runtime/UStringConcatenate.h:
* wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
* wtf/text/StringOperators.h:
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
2011-12-07 Filip Pizlo <fpizlo@apple.com>
DFG CSE should know that CheckFunction is pure
https://bugs.webkit.org/show_bug.cgi?id=74044
Reviewed by Oliver Hunt.
Possible slight win on V8, no regressions.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::checkFunctionElimination):
2011-12-07 Michael Saboff <msaboff@apple.com>
StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
https://bugs.webkit.org/show_bug.cgi?id=73995
Reviewed by Geoffrey Garen.
Problem was that a call to characters on an StringImpl associated
with a StringBuilder that is being appended to gets stale.
Added a new m_valid16BitShadowlen that keeps the length of
the 16 bit shadow that has been upconverted or will be up converted
with the first getCharacters(). When StringBuilder::characters or
::reifyString is called, further characters are upconverted if
we have a shadow16bit copy and the m_valid16BitShadowlen is updated.
* JavaScriptCore.exp:
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::characters):
(WTF::StringBuilder::clear): Cleaned up as part of the change.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upconvertCharacters):
* wtf/text/StringImpl.h:
2011-12-07 Filip Pizlo <fpizlo@apple.com>
Compare and Swap should be enabled on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=74023
Reviewed by Geoff Garen.
Implemented weakCompareAndSwap in terms of LDREX/STREX and enabled PARALLEL_GC.
It gives the expected speed-up on multi-core ARMv7 devices.
* wtf/Atomics.h:
(WTF::weakCompareAndSwap):
* wtf/Platform.h:
2011-12-07 Filip Pizlo <fpizlo@apple.com>
DFG CSE is overzealous with GetByVal
https://bugs.webkit.org/show_bug.cgi?id=74042
Reviewed by Oliver Hunt.
Made sure that the purity of GetByVal and the limited-clobber-itude of PutByVal
is tested in all places that matter.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValIsPure):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
2011-12-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r102267.
http://trac.webkit.org/changeset/102267
https://bugs.webkit.org/show_bug.cgi?id=74032
Breaks build on Chromium Mac Debug (Requested by aklein on
#webkit).
* wtf/HashTraits.h:
2011-12-07 Adam Klein <adamk@chromium.org>
Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Ryosuke Niwa.
* wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on an entry whose value is null.
2011-12-07 Filip Pizlo <fpizlo@apple.com>
Non-Mac devices should benefit from a larger heap
https://bugs.webkit.org/show_bug.cgi?id=74015
Reviewed by Geoff Garen.
Removed the ENABLE(LARGE_HEAP) option from Platform.h, since it was only used in
Heap.cpp, and got in the way of having more granular, per-platform control over
what the heap size should be. Bumped the heap size to 8MB on iOS (was 512KB).
* heap/Heap.cpp:
(JSC::GCTimer::heapSizeForHint):
* wtf/Platform.h:
2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] V8 build fixes.
Reviewed by Tor Arne Vestbø.
* yarr/yarr.pri: Don't rely on Source/JavaScriptCore being in
VPATH. Prefix SOURCES correctly and make sure that runtime/ is
in the include search path when building with v8.
2011-12-06 Filip Pizlo <fpizlo@apple.com>
Zapping a block that is Marked leads to dead objects being mistaken for live ones
https://bugs.webkit.org/show_bug.cgi?id=73982
Reviewed by Geoff Garen.
Changed the zapping code to ignore blocks that are Marked or Zapped. Additionally,
the code asserts that:
- If we zap a Marked or Zapped block then the free list is empty, because this
can only happen if the block was never free-listed.
- Zapping can only happen for Marked, Zapped, or FreeListed blocks, since Allocated
blocks are those that cannot be referred to by SizeClass::currentBlock (since
SizeClass::currentBlock only refers to blocks that are candidates for allocation,
and Allocated blocks are those who have been exhausted by allocation and will not
be allocated from again), and New blocks cannot be referred to by anything except
during a brief window inside the allocation slow-path.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::zapFreeList):
2011-12-06 Filip Pizlo <fpizlo@apple.com>
DFG 32_64 call linking does not handle non-cell callees correctly
https://bugs.webkit.org/show_bug.cgi?id=73965
Reviewed by Sam Weinig.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
2011-12-06 Sam Weinig <sam@webkit.org>
Remove unintentional type name shadowing in the Interpreter
https://bugs.webkit.org/show_bug.cgi?id=73963
Reviewed by Oliver Hunt.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::prepareForRepeatCall): Replace the parameter name FunctionExecutable,
which shadows the FunctionExecutable type name, with functionExecutable.
2011-12-06 Michael Saboff <msaboff@apple.com>
r102146 from 73875 broke fast/js/encode-URI-test.html
https://bugs.webkit.org/show_bug.cgi?id=73950
Reviewed by Gavin Barraclough.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncUnescape): Restructured to handle
the %uHHHH case to output the resulting character
and continue so that a failure in finding 4 hex
digits will fall through and output the '%'.
Due to style check, changed the temporary
character variable to a more descriptive name.
2011-12-06 Filip Pizlo <fpizlo@apple.com>
GC zapping logic could benefit from some more assertions
https://bugs.webkit.org/show_bug.cgi?id=73947
Reviewed by Gavin Barraclough.
- If you're in a zapped block and you're zapped, then your mark bit should
never be set.
- If you're being marked, then you should never be zapped.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::isLive):
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):
2011-12-06 Oliver Hunt <oliver@apple.com>
Don't allocate register in typedarray control flow
https://bugs.webkit.org/show_bug.cgi?id=73944
Reviewed by Gavin Barraclough.
Move a temporary allocation outside of control flow.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
2011-12-06 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=68328
The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant
Reviewed by Geoff Garen.
Move the instrinsic enum out of the DFG, into runtime. Add entires for all host functions
that have an intrinsic in the form of a generated thunk. Remove the thunk pointer from the
hashtable, and make Intrinsic field no longer ifdef on JIT/DFG. In getHostFunction select
a thunk genertaor to use based on the Intrinsic.
* JavaScriptCore.xcodeproj/project.pbxproj:
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGCapabilities.h:
* dfg/DFGIntrinsic.h: Removed.
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
* runtime/Executable.h:
(JSC::ExecutableBase::intrinsicFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/Intrinsic.h: Copied from Source/JavaScriptCore/dfg/DFGIntrinsic.h.
* runtime/JSGlobalData.cpp:
(JSC::thunkGeneratorForIntrinsic):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
2011-12-06 Michael Saboff <msaboff@apple.com>
Add 8 bit paths to global object functions
https://bugs.webkit.org/show_bug.cgi?id=73875
Added 8 bit paths for converions methods.
This is worth 1.5% on kraken audio-oscillator,
1.6% on stanford-crypto-ccm and 2.5% on
stanford-crypto-sha256-iterative. See bug for
a full report.
Reviewed by Oliver Hunt.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode): Split into a templated helper.
(JSC::parseInt): Split into a templated helper.
(JSC::parseFloat): Added an 8 bit path
(JSC::globalFuncEscape): Added 8 bit path
(JSC::globalFuncUnescape): Added 8 bit path
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append): New append for LChar
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append): New append for LChar
2011-11-21 Balazs Kelemen <kbalazs@webkit.org>
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032
Reviewed by Zoltan Herczeg.
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.
* JavaScriptCore.gypi: Add the files to the build. It was
missing for the gyp build system.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
* wtf/ParallelJobsGeneric.h:
* wtf/Platform.h:
2011-12-06 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] build-jsc script doesn't work
https://bugs.webkit.org/show_bug.cgi?id=73910
Reviewed by Tor Arne Vestbø.
* JavaScriptCore.pro: Build WTF before JavaScriptCore and JSC
(moved from top-level WebKit.pro). Also add v8 scopes to only build
WTF during v8 builds.
2011-12-05 Anders Carlsson <andersca@apple.com>
Add HashMap::keys() and HashMap::values() for easy iteration of hash map keys and values in C++11.
Reviewed by Darin Adler.
* wtf/HashMap.h:
2011-12-05 Michael Saboff <msaboff@apple.com>
Create StringImpl::empty() as an 8 bit string
https://bugs.webkit.org/show_bug.cgi?id=73871
Reviewed by Oliver Hunt.
* wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty): Changed to be an 8 bit string.
2011-12-05 Darin Adler <darin@apple.com>
Convert JSClassRef to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73780
Reviewed by Andreas Kling.
* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::getOwnPropertyNames): Use get() on the hash map
entries because the hash map now has an OwnPtr instead of a raw pointer.
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): No need to initialize m_staticValues and
m_staticFunctions since they are now OwnPtr. Use adoptPtr when allocating.
Removed the code that gets and deletes existing entries, and just use set,
which now handles deletion automatically due to it being OwnPtr.
(OpaqueJSClass::~OpaqueJSClass): Replaced code to do all the deletion
with assertion-only NDEBUG-only code.
(OpaqueJSClassContextData::OpaqueJSClassContextData): Use adoptPtr when
allocating. Use OwnPtr when adding. Removed unneeded code to set
staticValues and staticFunctions to 0. Removed unneeded destructor.
(OpaqueJSClass::staticValues): Added get call. Also removed unneeded local.
(OpaqueJSClass::staticFunctions): Ditto.
(OpaqueJSClass::prototype): Added use of adoptPtr.
* API/JSClassRef.h: Made the static values and static functions tables
use OwnPtr for the entries. Also used OwnPtr for the pointers to the
tables themselves. Also removed ~OpaqueJSClassContextData(), letting
the compiler generate it.
2011-12-05 Oliver Hunt <oliver@apple.com>
Land uncommitted bit of float array support
https://bugs.webkit.org/show_bug.cgi?id=73873
Reviewed by Filip Pizlo.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
2011-12-05 Benjamin Poulain <benjamin@webkit.org>
Update String::containsOnlyASCII() to handle 8 bits strings
https://bugs.webkit.org/show_bug.cgi?id=73799
Reviewed by Darin Adler.
Implement String::containsOnlyASCII() so that it does not
call String::characters().
* wtf/text/WTFString.h:
(WTF::String::containsOnlyASCII):
2011-12-05 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for non-DFG platforms.
* dfg/DFGRepatch.h:
2011-12-05 Filip Pizlo <fpizlo@apple.com>
Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
were compact offsets
https://bugs.webkit.org/show_bug.cgi?id=73861
Reviewed by Gavin Barraclough.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchPutById):
2011-12-05 Filip Pizlo <fpizlo@apple.com>
Unreviewed, build fixes for ARM.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::unreachableForPlatform):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):
2011-12-05 Benjamin Poulain <benjamin@webkit.org>
Update String::containsOnlyLatin1() to avoid converting to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=73797
Reviewed by Andreas Kling.
When the String use 8bits StringImpl, there is no need to iterate
over the string.
The function charactersAreAllLatin1() is removed because it is not
used anywhere.
* wtf/text/WTFString.h:
(WTF::String::containsOnlyLatin1):
2011-12-05 Michael Saboff <msaboff@apple.com>
8 bit string work slows down Kraken json-stringify-tinderbox
https://bugs.webkit.org/show_bug.cgi?id=73457
Added 8 bit path to StringBuilder. StringBuilder starts
assuming 8 bit contents and gets converted to 16 bit upon
seeing the first 16 bit character or string. Split
appendUninitialiezed into an inlined fast and function call
slow case.
Factored out the processing of the UString argument from
Stringifier::appendQuotedString() to a static templated function
based on character size.
This change eliminates 5% of the 7% slowdown to json-stringify-tinderbox.
This change introduces a 4.8% slowdown to json-parse-financial.
This slowdown will be addressed in a subsequent patch to StringImpl::equal.
Reviewed by Oliver Hunt.
* runtime/JSONObject.cpp:
(JSC::appendStringToUStringBuilder):
(JSC::Stringifier::appendQuotedString):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::LChar):
(WTF::UChar):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters8):
(WTF::StringBuilder::characters16):
(WTF::StringBuilder::charactersBlah):
(WTF::LChar):
(WTF::UChar):
2011-12-01 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=73624
JIT + INTERPRETER builds are broken
Reviewed by Geoff Garen, Sam Weinig.
These don't fallback to the interpreter correctly.
Thunk creation assumes that is the JIT is compiled in, then it is enabled.
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
2011-12-05 Zoltan Herczeg <zherczeg@webkit.org>
MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434
Reviewed by Csaba Osztrogonác.
* assembler/MacroAssemblerSH4.h: Support for SH4.
(JSC::MacroAssemblerSH4::readCallTarget):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readCallTarget):
2011-12-04 Filip Pizlo <fpizlo@apple.com>
DFG should optimize strict equality
https://bugs.webkit.org/show_bug.cgi?id=73764
Reviewed by Oliver Hunt.
1% speed-up on V8.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):
2011-12-03 Darin Adler <darin@apple.com>
Use HashMap<OwnPtr> for ScriptSampleRecordMap
https://bugs.webkit.org/show_bug.cgi?id=73758
Reviewed by Andreas Kling.
* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::notifyOfScope): Added adoptPtr.
(JSC::SamplingTool::dump): Added get.
* bytecode/SamplingTool.h: Changed the value type of ScriptSampleRecordMap to be OwnPtr.
2011-12-03 Darin Adler <darin@apple.com>
Use HashMap<OwnPtr> for the opaqueJSClassData map
https://bugs.webkit.org/show_bug.cgi?id=73759
Reviewed by Andreas Kling.
* API/JSClassRef.cpp:
(OpaqueJSClass::contextData): Update types.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Add an explicit clear of opaqueJSClassData to keep the
timing the same. If we didn't care about the order of operations, we could remove this, too.
* runtime/JSGlobalData.h: Use OwnPtr instead of raw pointer for the mapped type in the
opaqueJSClassData map.
2011-12-03 Darin Adler <darin@apple.com>
Change HashMap implementation to use the pass type and peek type from traits for the mapped value
https://bugs.webkit.org/show_bug.cgi?id=72474
Reviewed by Anders Carlsson.
* wtf/HashMap.h: Added ReferenceTypeMaker struct template. Get PassInType, PassOutType,
and PeekType from the traits of the mapped value instead of hard-coding them here.
Changed inlineAdd to take a reference to the PassInType instead of the PassInType itself,
to accomodate a PassInType that can't be copied. Use the store, peek, and passOut
functions from the traits as well.
* wtf/HashTraits.h: Updated GenericHashTraits and HashTraits for OwnPtr to include
PassInType, PassOutType, PeekType, store, passOut, and peek. Before this, the file had
an earlier version that was just PassType, PeekType, pass, and peek. Also commented
the HashTraits for RefPtr to foreshadow some work we can do there.
* wtf/RefPtrHashMap.h: Same changes as HashMap.h.
2011-12-02 David Levin <levin@chromium.org>
Rename WTF class from TemporarilyChange to TemporaryChange.
https://bugs.webkit.org/show_bug.cgi?id=73479
Reviewed by Eric Seidel.
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/TemporaryChange.h: Renamed from Source/JavaScriptCore/wtf/TemporarilyChange.h.
(WTF::TemporaryChange::TemporaryChange):
(WTF::TemporaryChange::~TemporaryChange):
2011-12-02 Mark Hahnenberg <mhahnenberg@apple.com>
REGRESSION (r99754): All layout tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=72305
Reviewed by Geoffrey Garen.
Fixes a crash in release builds on Windows. Windows was optimizing the out-of-line virtual destructor in
JSFunction away, which left it with no virtual functions. Its vtable ptr was then identical to that of
a different class, therefore the optimization in the visitChildren helper function in MarkedStack.cpp was calling an
incorrect version of visitChildren on the object, which left its children unmarked, causing them to be
collected when they were still reachable.
* runtime/JSFunction.cpp:
(JSC::JSFunction::vtableAnchor): Add a virtual function to JSFunction that Visual Studio can't optimize away.
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs): Add checks to make sure that all virtual pointers that we rely on for optimization
purposes are distinct from one another.
2011-12-02 Oliver Hunt <oliver@apple.com>
Improve float array support in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73722
Reviewed by Gavin Barraclough.
Add basic support for float typed arrays in JSC. This is currently
less optimal than it could be in the following ways:
* float32Array1[0] = float32Array2[0] (eg. an element by element copy)
promotes float to double and then back to float.
* float64Array[0] will always perform NaN tests in order to prevent
signalling NaNs from entering the engine.
We also don't support Float32Array on ARMv7
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::loadDouble):
(JSC::MacroAssemblerX86Common::loadFloat):
(JSC::MacroAssemblerX86Common::storeDouble):
(JSC::MacroAssemblerX86Common::storeFloat):
(JSC::MacroAssemblerX86Common::convertDoubleToFloat):
(JSC::MacroAssemblerX86Common::convertFloatToDouble):
* assembler/X86Assembler.h:
(JSC::X86Assembler::cvtsd2ss_rr):
(JSC::X86Assembler::cvtss2sd_rr):
(JSC::X86Assembler::movsd_rm):
(JSC::X86Assembler::movss_rm):
(JSC::X86Assembler::movsd_mr):
(JSC::X86Assembler::movss_mr):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateFloat32Array):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):
2011-12-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r101801.
http://trac.webkit.org/changeset/101801
https://bugs.webkit.org/show_bug.cgi?id=73667
Build is still broken (Requested by Ossy on #webkit).
* assembler/SH4Assembler.h:
2011-12-01 Darin Adler <darin@apple.com>
Prepare to deploy pass and peek types in the HashMap class
https://bugs.webkit.org/show_bug.cgi?id=73477
Reviewed by Adam Roben.
This patch adds private typedefs inside the HashMap class,
and uses them as appropriate. A future patch will actually
tie those typedefs to hash traits, which will allow us to
make HashMap work with OwnPtr mapped values and to optimize
how HashMap works with RefPtr mapped values.
Also changed the hash translator and adapter struct templates
to use template functions to simplify them and make them more
flexible.
Also removed some unused template arguments.
This goes out of its way to not change behavior. Future patches
will change the peek type to be a reference type, which will
reduce reference count churn a bit for hash tables with RefPtr
mapped values, and then do further optimizations for RefPtr
and OwnPtr by getting types from the hash traits.
* wtf/HashMap.h: Added MappedPassInType, MappedPassOutType,
and MappedPeekType typedefs, and used them for the arguments
and return types of the get, set, add, take, and inlineAdd
functions.
(WTF::HashMapTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashMapTranslatorAdapter): Ditto.
(WTF::HashMap::find): Updated to use new HashMapTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.
* wtf/HashSet.h:
(WTF::IdentityExtractor): Changed this to be a struct rather than
a struct template, and replaced the extract function with a function
template. This allows the compiler to deduce the type.
(WTF::HashSetTranslatorAdapter): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashSet::find): Updated to use new HashSetTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashSet::contains): Ditto.
(WTF::HashSet::add): Ditto.
* wtf/HashTable.h:
(WTF::IdentityHashTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashTable::add): Reduced arguments passed to the function template.
(WTF::HashTable::find): Ditto, also reversed the template arguments so the
translator comes first so the compiler can deduce the other type.
(WTF::HashTable::contains): Ditto.
(WTF::HashTable::lookup): Ditto.
(WTF::HashTable::lookupForWriting): Ditto.
(WTF::HashTable::checkKey): Ditto.
(WTF::HashTable::fullLookupForWriting): Ditto.
(WTF::HashTable::add): Ditto.
(WTF::HashTable::addPassingHashCode): Ditto.
(WTF::HashTable::find): Ditto.
(WTF::HashTable::contains): Ditto.
* wtf/ListHashSet.h:
(WTF::ListHashSetNodeHashFunctions): Changed this struct template to take
fewer arguments, and changed its member functions to be function templates
instead. This allows the compiler to determine types more flexibly and
also simplifies use of it.
(WTF::ListHashSet::find): Reduced the arguments passed to the HashTable
functon template.
(WTF::ListHashSetTranslatorAdapter): Changed this struct template in the
same way we changed ListHashSetNodeHashFunctions above.
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::contains):
(WTF::::add):
(WTF::::insertBefore):
* wtf/RefPtrHashMap.h: Updated comments. Removed the
RefPtrHashMapRawKeyTranslator struct template; we can use the
HashMapTranslator struct template from HashMap.h instead now that
it is more flexible. Added MappedPassInType, MappedPassOutType,
and MappedPeekType typedefs, and used them for the arguments
and return types of the get, inlineGet, set, add, take, and inlineAdd
functions. Changed the name of the RawKeyTranslator type to
Translator since it's now a class that can handle both raw keys
and conventional keys.
(WTF::HashMap::find): Changed to use Translator instead of RawKeyTranslator.
Reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.
2011-12-02 Zoltan Herczeg <zherczeg@webkit.org>
MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434
Reviewed by Csaba Osztrogonác.
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readCallTarget): Support for SH4.
2011-12-02 Hajime Morrita <morrita@chromium.org>
Unreviewed, rolling out r101751 and r101775.
http://trac.webkit.org/changeset/101751
http://trac.webkit.org/changeset/101775
https://bugs.webkit.org/show_bug.cgi?id=73191
breaks Windows build
* JavaScriptCore.xcodeproj/project.pbxproj:
* config.h:
* runtime/JSExportMacros.h: Removed.
* wtf/ExportMacros.h:
* wtf/Platform.h:
* wtf/WTFThreadData.h:
* wtf/text/AtomicString.h:
* wtf/text/StringStatics.cpp:
2011-12-01 Hajime Morrita <morrita@chromium.org>
JS_INLINE and WTF_INLINE should be visible from WebCore
https://bugs.webkit.org/show_bug.cgi?id=73191
- Moved Export related macro definitions from config.h to ExportMacros.h and JSExportMacros.h.
- Moved WTF_USE_JSC and WTF_USE_V8 from various config.h family to Platform.h.
- Replaced JS_EXPORTDATA in wtf moudule with newly introduced WTF_EXPORTDATA.
Reviewed by Kevin Ollivier.
* JavaScriptCore.xcodeproj/project.pbxproj:
* config.h:
* runtime/JSExportMacros.h: Added.
* wtf/ExportMacros.h:
* wtf/Platform.h:
* wtf/WTFThreadData.h:
* wtf/text/AtomicString.h:
* wtf/text/StringStatics.cpp:
2011-12-01 Michael Saboff <msaboff@apple.com>
Changes proposed for 73457 slow down Kraken json-parse-financial
https://bugs.webkit.org/show_bug.cgi?id=73584
Restructured StringImpl::equal to take advantage of 8 or 4 bytes
at a time when possible.
This is worth ~3% on Kraken json-parse-financial. It provides
~2% on SunSpider string-unpack-code.
Reviewed by Sam Weinig.
* wtf/text/StringImpl.cpp:
(WTF::equal):
2011-12-01 Oliver Hunt <oliver@apple.com>
Support integer typed arrays in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73608
Reviewed by Filip Pizlo.
Add support for all the integral typed arrays in the DFG JIT.
Currently this loads the contents of Uint32 arrays as doubles,
which is clearly not as efficient as it could be, but this is
still in the order of 10-20x faster than the existing behaviour.
This needed us to add support for writing 16bit values to the
macroassembler, and also to support double<->unsigned conversion.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::strh):
(JSC::ARMv7Assembler::vcvt_floatingPointToUnsigned):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store16):
(JSC::MacroAssemblerARMv7::truncateDoubleToUint32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store16):
(JSC::MacroAssemblerX86Common::truncateDoubleToUint32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movw_rm):
(JSC::X86Assembler::cvttsd2siq_rr):
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isInt8ArrayPrediction):
(JSC::isInt16ArrayPrediction):
(JSC::isInt32ArrayPrediction):
(JSC::isUint8ArrayPrediction):
(JSC::isUint16ArrayPrediction):
(JSC::isUint32ArrayPrediction):
(JSC::isFloat32ArrayPrediction):
(JSC::isFloat64ArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSGlobalData.h:
2011-12-01 Benjamin Poulain <benjamin@webkit.org>
URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758
Reviewed by Darin Adler.
Add the operator == between a String and a Vector of char. The implementation
is the same as the comparison of String and char* but adds the length as a
parameter for comparing the strings.
* JavaScriptCore.exp:
* wtf/text/StringImpl.h:
(WTF::equal):
* wtf/text/WTFString.h:
(WTF::operator==):
(WTF::operator!=):
2011-12-01 Martin Robinson <mrobinson@igalia.com>
[GTK] Read fonts from the jhbuild root
https://bugs.webkit.org/show_bug.cgi?id=73487
Reviewed by Gustavo Noronha Silva.
Read fonts from the jhbuild root instead of from the system. This will ensure
that all testers use the same fonts instead of leaving this up to luck.
* wtf/gobject/GlibUtilities.h: Add Assertions.h which was required for the WebKit2TestRunner.
2011-12-01 Martin Robinson <mrobinson@igalia.com>
[GTK] Add a helper function to find the current executable's path
https://bugs.webkit.org/show_bug.cgi?id=73473
Reviewed by Gustavo Noronha Silva.
Add a WTF helper which gets the binary path. This is currently only used
in WebKit2.
* GNUmakefile.list.am: Add the new file to the source list.
* wtf/gobject/GlibUtilities.cpp: Added.
(getCurrentExecutablePath):
* wtf/gobject/GlibUtilities.h: Added.
2011-12-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r101691.
http://trac.webkit.org/changeset/101691
https://bugs.webkit.org/show_bug.cgi?id=73588
Tests fail on Chromium bots, early warning system warned
committer, please adjust test_expectations in patch (Requested
by scheib on #webkit).
* JavaScriptCore.exp:
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:
2011-12-01 Filip Pizlo <fpizlo@apple.com>
ARMv7 only allows for one-shot patching of compact offsets, while the
JIT expects to be able to repatch
https://bugs.webkit.org/show_bug.cgi?id=73548
Reviewed by Oliver Hunt.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::setUInt7ForLoad):
2011-11-30 Benjamin Poulain <benjamin@webkit.org>
URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758
Reviewed by Darin Adler.
Add the operator == between a String and a Vector of char. The implementation
is the same as the comparison of String and char* but adds the length as a
parameter for comparing the strings.
* JavaScriptCore.exp:
* wtf/text/StringImpl.h:
(WTF::equal):
* wtf/text/WTFString.h:
(WTF::operator==):
(WTF::operator!=):
2011-11-30 Dmitry Lomov <dslomov@google.com>
https://bugs.webkit.org/show_bug.cgi?id=73503
[Chromium][V8] Implement ArrayBuffer transfer in chromium.
Portions of this patch come from Luke Zarko.
Reviewed by David Levin.
* wtf/ArrayBuffer.cpp:
(WTF::ArrayBuffer::transfer): Changed prototype from pointers to RefPtr.
* wtf/ArrayBuffer.h:
(WTF::ArrayBufferContents::transfer): Changed prototype from pointers to RefPtr.
(WTF::ArrayBuffer::isNeutered):
* wtf/TypedArrayBase.h:
(WTF::TypedArrayBase::neuter):
2011-12-01 Chao-ying Fu <fu@mips.com>
MacroAssemblerMIPS does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73432
Reviewed by Zoltan Herczeg.
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::readCallTarget):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::readCallTarget):
2011-12-01 Noel Gordon <noel.gordon@gmail.com>
[chromium] Remove wtf/qt/ThreadingQt.cpp from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=73527
Reviewed by Simon Hausmann.
wtf/qt/ThreadingQt.cpp was removed in r101477
* JavaScriptCore.gypi: remove wtf/qt/ThreadingQt.cpp
2011-12-01 Filip Pizlo <fpizlo@apple.com>
BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691
Reviewed by Gavin Barraclough.
Switch back to using the high bit as the inline marker, to make
all of the bit indexing operations simpler. Computing the size in
words and in bytes of a bitvector, using the number of bits as
input is error-prone enough; and with the current approach to
solving the X86 bug we end up getting it wrong. Making it right
seems hard.
So instead, to solve the original problem (the high bit may be
meaningful on 32-bit systems), the out-of-line storage pointer is
right-shifted by 1. Compared to the original BitVector code, this
is a much smaller change (just three lines).
This solves a bug where the DFG was corrupting its call frame
because BitVector lost track of some bits.
* wtf/BitVector.cpp:
(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):
* wtf/BitVector.h:
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):
2011-11-30 Filip Pizlo <fpizlo@apple.com>
DFG should make it easier to notice node boundaries in disassembly
https://bugs.webkit.org/show_bug.cgi?id=73509
Rubber-stamped by Gavin Barraclough
If you set XOR_DEBUG_AID to 1 in DFGCommon.h, a pair of xor's will
be emitted at node boundaries, where the immediate being xor'd is the
node index.
* dfg/DFGCommon.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-30 Geoffrey Garen <ggaren@apple.com>
Removed ArgList iterators.
Reviewed by Gavin Barraclough.
Another step toward reversing the argument order.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct): Switched from iterator to int.
* runtime/ArgList.h:
(JSC::ArgList::ArgList):
(JSC::ArgList::isEmpty): Removed iterators.
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation): Switched from iterator to int.
2011-11-30 Yuqiang Xian <yuqiang.xian@intel.com>
32 bit DFG should handle logicalNot slow case instead of simply bailing out
https://bugs.webkit.org/show_bug.cgi?id=73515
Reviewed by Filip Pizlo.
This improves Kraken performance by 14%, mainly due to ~3X improvement
on imaging-desaturate.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
2011-11-30 Max Vujovic <mvujovic@adobe.com>
Some date values not handled consistently with IE/Firefox
https://bugs.webkit.org/show_bug.cgi?id=14176
Reviewed by Gavin Barraclough.
Changed time zone offset parsing behavior to match IE/Firefox/Opera's in
implementation dependent cases like "GMT-4".
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
2011-11-30 Mark Hahnenberg <mhahnenberg@apple.com>
toStringCallback and valueOfCallback do not check the entire prototype chain for convertToType callback
https://bugs.webkit.org/show_bug.cgi?id=73368
Reviewed by Darin Adler.
We need to search the entire prototype chain for the convertToType callback, rather than just calling whatever
happens to be in the first class of the chain, which potentially could be null.
<rdar://problem/10493218>
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
2011-11-29 Sam Weinig <sam@webkit.org>
Add adoptCF and adoptNS convenience functions to RetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=73399
Reviewed by Anders Carlsson.
* wtf/RetainPtr.h:
(WTF::adoptCF):
(WTF::adoptNS):
These adoption functions match the pattern we use in other
smart pointer classes.
2011-11-30 Adam Roben <aroben@apple.com>
Fix RetainPtr's move assignment operators
Fixes <http://webkit.org/b/73449> RetainPtr's move assignment operators don't modify the
pointer being assigned to
I didn't write a test for this because we don't have a way of unit testing C++11 code (see
<http://webkit.org/b/73448>).
Reviewed by Anders Carlsson.
* wtf/RetainPtr.h:
(WTF::RetainPtr::operator=): Adopt the passed-in RetainPtr's underlying pointer, not our own
pointer.
2011-11-30 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed rolling out incorrect r101481.
* assembler/MIPSAssembler.h:
* assembler/MacroAssemblerMIPS.h:
2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
Fix compilation with MingW.
Reviewed by Csaba Osztrogonác.
* wtf/ThreadingWin.cpp:
(WTF::initializeCurrentThreadInternal): MingW doesn't support MSVC exception handling, so for
the time being make the thread name setting unimplemented for MingW.
2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed propective build fix for Qt/Windows part 2 after r101477.
* wtf/ThreadSpecific.h: Fix the OS(WINDOWS) defines for the friend declaration for ThreadSpecific<T>::Data
2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed propective build fix for Qt/Windows after r101477.
* wtf/ThreadSpecific.h: Use OS(WINDOWS) for declaring "destructor", as it's
only referenced from within another OS(WINDOWS) section.
2011-11-30 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed speculative buildfix after r101457.
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::readCallTarget):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::readCallTarget):
2011-11-30 Andrew Wason <rectalogic@rectalogic.com>
Replace Qt QThread threading back-end with pthread/Win32 threading back-ends
https://bugs.webkit.org/show_bug.cgi?id=72155
Reviewed by Simon Hausmann.
Use ThreadingPthreads and ThreadingWin instead of ThreadingQt.
* heap/MachineStackMarker.cpp:
* wtf/MainThread.cpp:
(WTF::initializeMainThread):
* wtf/Platform.h:
* wtf/ThreadSpecific.h: Drop QThreadStorage related code.
(WTF::::destroy):
* wtf/ThreadingPrimitives.h:
* wtf/qt/MainThreadQt.cpp: Drop Qt specific isMainThread().
(WTF::initializeMainThreadPlatform): Initialize MainThreadInvoker on main thread to avoid infecting secondary thread with QAdoptedThread.
(WTF::scheduleDispatchFunctionsOnMainThread):
* wtf/qt/ThreadingQt.cpp: Removed.
* wtf/wtf.pro:
2011-11-30 Csaba Osztrogonác <ossy@webkit.org>
MacroAssemblerARM does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73413
Based on Filip Pizlo's patch.
Buildfix. Rubber-stamped by Gabor Loki.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::readCallTarget):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::readCallTarget):
2011-11-29 Filip Pizlo <fpizlo@apple.com>
Resetting a put_by_id inline cache should preserve the "isDirect" bit
https://bugs.webkit.org/show_bug.cgi?id=73375
Reviewed by Gavin Barraclough.
For the replace case, we can find out if it was direct by looking at the
slow call. For the transition case, we explicitly remember if it was
direct.
* bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdTransition):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::resetPatchPutById):
(JSC::JIT::isDirectPutById):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchPutById):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
2011-11-29 Sam Weinig <sam@webkit.org>
Remove RetainPtr::releaseRef
https://bugs.webkit.org/show_bug.cgi?id=73396
Reviewed by Dan Bernstein.
* wtf/RetainPtr.h:
Be gone releaseRef! Long live leakRef!
2011-11-29 Sam Weinig <sam@webkit.org>
Add move semantics to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=73393
Reviewed by Anders Carlsson.
* wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):
Add a move constructor and move enabled assignment operators
to RetainPtr if the compiler being used supports rvalue
references. If the compiler does not support it, we fallback
to the copy semantics we have always had.
2011-11-29 Yuqiang Xian <yuqiang.xian@intel.com>
DFG local CSE may cause incorrect reference counting for a node
https://bugs.webkit.org/show_bug.cgi?id=73390
Reviewed by Filip Pizlo.
When performing a node substitution, the ref count of the replaced
child will be increased, no matter whether the user node is skipped in
code generation or not. This will cause the reference count of the
replaced child never get the chance to become zero and so the
registers occupied by it cannot be reused simply without spilling, if
it's used by a "skipped" node.
This is a 1% gain on V8 benchmark, tested on IA32 Linux.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):
2011-11-29 David Levin <levin@chromium.org>
Add a way to revert a variable to its previous value after leaving a scope.
https://bugs.webkit.org/show_bug.cgi?id=73371
Reviewed by Adam Barth.
In case anyone from Chromium sees this, it is nearly identical to AutoReset
but if the same name were used, it causes unnecessary ambiguity.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/TemporarilyChange.h: Added.
(WTF::TemporarilyChange::TemporarilyChange):
(WTF::TemporarilyChange::~TemporarilyChange):
2011-11-29 Sam Weinig <sam@webkit.org>
Add COMPILER_SUPPORTS macro to allow for compiler feature testing
https://bugs.webkit.org/show_bug.cgi?id=73386
Reviewed by Anders Carlsson.
* wtf/Compiler.h:
Add COMPILER_SUPPORTS and #defines for C++11 variadic templates and
rvalue references for Clang.
2011-11-29 Oliver Hunt <oliver@apple.com>
Allow WebCore to describe typed arrays to JSC
https://bugs.webkit.org/show_bug.cgi?id=73355
Reviewed by Gavin Barraclough.
Allow globaldata to track the structure of typed arrays.
* runtime/JSGlobalData.h:
(JSC::TypedArrayDescriptor::TypedArrayDescriptor):
2011-11-28 Filip Pizlo <fpizlo@apple.com>
DFG debugCall() mechanism only works on X86 and X86-64
https://bugs.webkit.org/show_bug.cgi?id=73282
Reviewed by Oliver Hunt.
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
2011-11-28 Filip Pizlo <fpizlo@apple.com>
DFG non-X86 ArithDiv does speculation failure after mutating state,
without a value recovery
https://bugs.webkit.org/show_bug.cgi?id=73286
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-28 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fixes for ARM.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::readCallTarget):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
2011-11-20 Roland Steiner <rolandsteiner@chromium.org>
<style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
https://bugs.webkit.org/show_bug.cgi?id=72848
Add ENABLE_STYLE_SCOPED flag.
Reviewed by Dimitri Glazkov.
* Configurations/FeatureDefines.xcconfig:
2011-11-28 Jon Lee <jonlee@apple.com>
Create skeleton framework for notifications support in WK2
https://bugs.webkit.org/show_bug.cgi?id=73253
<rdar://problem/10356943>
* Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
2011-11-28 Oliver Hunt <oliver@apple.com>
Fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-11-28 Oliver Hunt <oliver@apple.com>
Fix gyp build
* JavaScriptCore.gypi:
2011-11-28 Filip Pizlo <fpizlo@apple.com>
GetById should not always speculate cell
https://bugs.webkit.org/show_bug.cgi?id=73181
Reviewed by Gavin Barraclough.
GetById will now speculate cell if the predictions of the base are cell.
Otherwise it will do like the old JIT (and like the old non-speculative
DFG JIT): if not cell, go straight to slow-path but otherwise don't OSR
out. This is a 1% speed-up on SunSpider.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-28 Oliver Hunt <oliver@apple.com>
Move typed array implementations into wtf
https://bugs.webkit.org/show_bug.cgi?id=73248
Reviewed by Sam Weinig.
Move typed array implementation files from WebCore to wtf. Inline the
.cpp files for each of the array views to cut down on unnecessary exports
and function call overhead for trivial operations.
Added files to all the project files.
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/ArrayBuffer.cpp: Renamed from Source/WebCore/html/canvas/Float32Array.cpp.
(WTF::ArrayBuffer::transfer):
(WTF::ArrayBuffer::addView):
(WTF::ArrayBuffer::removeView):
* wtf/ArrayBuffer.h: Renamed from Source/WebCore/html/canvas/ArrayBuffer.cpp.
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::data):
(WTF::ArrayBufferContents::sizeInBytes):
(WTF::ArrayBufferContents::transfer):
(WTF::ArrayBuffer::~ArrayBuffer):
(WTF::ArrayBuffer::clampValue):
(WTF::ArrayBuffer::create):
(WTF::ArrayBuffer::ArrayBuffer):
(WTF::ArrayBuffer::data):
(WTF::ArrayBuffer::byteLength):
(WTF::ArrayBuffer::slice):
(WTF::ArrayBuffer::sliceImpl):
(WTF::ArrayBuffer::clampIndex):
(WTF::ArrayBufferContents::tryAllocate):
(WTF::ArrayBufferContents::~ArrayBufferContents):
* wtf/ArrayBufferView.cpp: Copied from Source/WebCore/bindings/js/JSArrayBufferCustom.cpp.
(WTF::ArrayBufferView::ArrayBufferView):
(WTF::ArrayBufferView::~ArrayBufferView):
(WTF::ArrayBufferView::neuter):
* wtf/ArrayBufferView.h: Renamed from Source/WebCore/html/canvas/ArrayBufferView.h.
(WTF::ArrayBufferView::isByteArray):
(WTF::ArrayBufferView::isUnsignedByteArray):
(WTF::ArrayBufferView::isShortArray):
(WTF::ArrayBufferView::isUnsignedShortArray):
(WTF::ArrayBufferView::isIntArray):
(WTF::ArrayBufferView::isUnsignedIntArray):
(WTF::ArrayBufferView::isFloatArray):
(WTF::ArrayBufferView::isDoubleArray):
(WTF::ArrayBufferView::isDataView):
(WTF::ArrayBufferView::buffer):
(WTF::ArrayBufferView::baseAddress):
(WTF::ArrayBufferView::byteOffset):
(WTF::ArrayBufferView::verifySubRange):
(WTF::ArrayBufferView::clampOffsetAndNumElements):
(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::calculateOffsetAndLength):
* wtf/CMakeLists.txt:
* wtf/Float32Array.h: Renamed from Source/WebCore/html/canvas/Float32Array.h.
(WTF::Float32Array::set):
(WTF::Float32Array::item):
(WTF::Float32Array::isFloatArray):
(WTF::Float32Array::create):
(WTF::Float32Array::Float32Array):
(WTF::Float32Array::subarray):
* wtf/Float64Array.h: Renamed from Source/WebCore/html/canvas/Float64Array.h.
(WTF::Float64Array::set):
(WTF::Float64Array::item):
(WTF::Float64Array::isDoubleArray):
(WTF::Float64Array::create):
(WTF::Float64Array::Float64Array):
(WTF::Float64Array::subarray):
* wtf/Int16Array.h: Renamed from Source/WebCore/html/canvas/Int16Array.cpp.
(WTF::Int16Array::set):
(WTF::Int16Array::isShortArray):
(WTF::Int16Array::create):
(WTF::Int16Array::Int16Array):
(WTF::Int16Array::subarray):
* wtf/Int32Array.h: Renamed from Source/WebCore/html/canvas/Int32Array.cpp.
(WTF::Int32Array::set):
(WTF::Int32Array::isIntArray):
(WTF::Int32Array::create):
(WTF::Int32Array::Int32Array):
(WTF::Int32Array::subarray):
* wtf/Int8Array.h: Renamed from Source/WebCore/html/canvas/Int8Array.cpp.
(WTF::Int8Array::set):
(WTF::Int8Array::isByteArray):
(WTF::Int8Array::create):
(WTF::Int8Array::Int8Array):
(WTF::Int8Array::subarray):
* wtf/IntegralTypedArrayBase.h: Renamed from Source/WebCore/html/canvas/IntegralTypedArrayBase.h.
(WTF::IntegralTypedArrayBase::set):
(WTF::IntegralTypedArrayBase::item):
(WTF::IntegralTypedArrayBase::IntegralTypedArrayBase):
* wtf/TypedArrayBase.h: Renamed from Source/WebCore/html/canvas/TypedArrayBase.h.
(WTF::TypedArrayBase::data):
(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):
(WTF::TypedArrayBase::length):
(WTF::TypedArrayBase::byteLength):
(WTF::TypedArrayBase::TypedArrayBase):
(WTF::TypedArrayBase::create):
(WTF::TypedArrayBase::subarrayImpl):
* wtf/Uint16Array.h: Renamed from Source/WebCore/html/canvas/Uint16Array.cpp.
(WTF::Uint16Array::set):
(WTF::Uint16Array::isUnsignedShortArray):
(WTF::Uint16Array::create):
(WTF::Uint16Array::Uint16Array):
(WTF::Uint16Array::subarray):
* wtf/Uint32Array.h: Renamed from Source/WebCore/html/canvas/Uint32Array.cpp.
(WTF::Uint32Array::set):
(WTF::Uint32Array::isUnsignedIntArray):
(WTF::Uint32Array::create):
(WTF::Uint32Array::Uint32Array):
(WTF::Uint32Array::subarray):
* wtf/Uint8Array.h: Renamed from Source/WebCore/html/canvas/Uint8Array.h.
(WTF::Uint8Array::set):
(WTF::Uint8Array::isUnsignedByteArray):
(WTF::Uint8Array::create):
(WTF::Uint8Array::Uint8Array):
(WTF::Uint8Array::subarray):
* wtf/wtf.pro:
2011-11-27 Filip Pizlo <fpizlo@apple.com>
Don't try to optimize huge code blocks
https://bugs.webkit.org/show_bug.cgi?id=73187
Reviewed by Oliver Hunt.
This unifies the heuristics used for deciding if a code block is too big
to optimize, and sets this heuristic to 1000, which is intuitively better
than numeric_limits<unsigned>::max(). It also results in what looks like
a speed-up on both SunSpider and V8 (in Tools/Scripts/bencher).
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
2011-11-28 Filip Pizlo <fpizlo@apple.com>
Either remove the GetMethod node from the DFG backend, or find a use for it
https://bugs.webkit.org/show_bug.cgi?id=73178
Reviewed by Gavin Barraclough.
More testing seemed to imply that the GetMethod code was indeed not profitable
in any major test. So, it's probably best to just remove it.
* bytecode/CodeBlock.cpp:
(JSC::MethodCallLinkInfo::reset):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGRepatch.cpp:
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
2011-11-28 Michael Saboff <msaboff@apple.com>
Change set 101187 from bug 73154 removed already lower case optimization
https://bugs.webkit.org/show_bug.cgi?id=73174
Added back the "string is already lower case" optimization.
Reviewed by Geoffrey Garen.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):
2011-11-28 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed prospective build fix. Touch the file to trigger correct
rebuild on the Qt mips/sh4/sl bot.
* wtf/unicode/qt4/UnicodeQt4.h:
2011-11-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Remove cruft from project file
Reviewed by Simon Hausmann.
* Target.pri:
2011-11-28 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] WTF should be built as separate static library
https://bugs.webkit.org/show_bug.cgi?id=73201
Reviewed by Tor Arne Vestbø.
* Target.pri: Don't claim to build WTF, as that would cause
the debug-with-shlibs build to not link in wtf.
* jsc.pro: Require wtf.
* wtf/wtf.pri: Removed.
* wtf/wtf.pro: Added. Pro file to build wtf statically.
2011-11-28 Martin Robinson <mrobinson@igalia.com>
[GTK] JavaScriptCore generated sources should build in the DerivedSources directory
https://bugs.webkit.org/show_bug.cgi?id=73197
Reviewed by Philippe Normand.
Build all JavaScriptCore generated sources in DerivedSources.
* GNUmakefile.am: Update generation rules.
* GNUmakefile.list.am: Update source lists.
2011-11-27 Filip Pizlo <fpizlo@apple.com>
DFG should not emit GetMethod node
https://bugs.webkit.org/show_bug.cgi?id=73175
Reviewed by Gavin Barraclough.
Replaces all instances of the GetMethod node with GetById. This appears to
be a slight win on V8. This patch leaves GetMethod support in the code-base,
making this decision easy to reverse, for now.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
2011-11-26 Hajime Morrita <morrita@chromium.org>
Needs WTF_INLINE and JS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=72853
Reviewed by Kevin Ollivier.
Added WTF_HIDDEN, WTF_INLINE and JS_INLINE which
indirect __attribute__((visibility("hidden"))
* config.h:
* wtf/ExportMacros.h:
2011-11-25 Michael Saboff <msaboff@apple.com>
String.prototype.toLower should be optimized for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=73154
Changed stringProtoFuncToLowerCase to use StringImpl::lower() which has
been optimized for 8 bit strings.
This is worth ~7% to sunspider string.tagcloud.
Reviewed by Filip Pizlo.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):
2011-11-25 Michael Saboff <msaboff@apple.com>
Array.toString always uses StringImpl::characters()
https://bugs.webkit.org/show_bug.cgi?id=72969
If all component strings are 8 bit, create an 8 bit result string for toString().
This appears to be performance neutral to sunspider and v8.
Reviewed by Filip Pizlo.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
2011-11-24 Michael Saboff <msaboff@apple.com>
UString methods are not character size aware
https://bugs.webkit.org/show_bug.cgi?id=72975
Changed the UString number constructors to build 8 bit strings.
Modified the other methods to check string bitness and process
with 8 bits wherre appropriate.
* runtime/UString.cpp:
(JSC::UString::number):
(JSC::operator==):
(JSC::operator<):
(JSC::UString::ascii):
2011-11-24 Michael Saboff <msaboff@apple.com>
JavaScript string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974
Change the various JS to number routines to process strings
using characters8() or characters16() as appropriate.
Implemented using static template methods.
Reviewed by Filip Pizlo.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::isInfinity):
(JSC::jsHexIntegerLiteral):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
2011-11-24 Michael Saboff <msaboff@apple.com>
Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968
Clear m_is8Bit flag for empty strings.
Reviewed by Filip Pizlo.
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
2011-11-24 Michael Saboff <msaboff@apple.com>
Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683
Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
and building continues with a 16 bit buffer.
Reviewed by Filip Pizlo.
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::upConvert):
(JSC::JSStringBuilder::build):
* runtime/UString.h:
(JSC::UString::adopt):
* wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
2011-11-24 Zeno Albisser <zeno@webkit.org>
[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets
https://bugs.webkit.org/show_bug.cgi?id=72495
Update defines to not use Unix Domain Sockets for platform Qt on Mac.
This enables Qt to reuse existing code for mach ports and Grand
Central Dispatch based IPC.
Reviewed by Simon Hausmann.
* wtf/Platform.h:
2011-11-24 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably
Reviewed by Andreas Kling.
We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
ways of doing that and this fix seems like the least intrusive one by simply pushing the
invoker to the gui thread if it's not there already.
* wtf/qt/MainThreadQt.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
2011-11-24 Patrick Gansterer <paroga@webkit.org>
[Qt] Use QEvent for dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=72704
Reviewed by Simon Hausmann.
Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
This is the same as what invokeMethod does internally, but reduces
the dependency on some internal QThread stuff.
* wtf/qt/MainThreadQt.cpp:
(WTF::MainThreadInvoker::MainThreadInvoker):
(WTF::MainThreadInvoker::event):
(WTF::scheduleDispatchFunctionsOnMainThread):
2011-11-23 George Staikos <staikos@webkit.org>
Remove BlackBerry OS support from RandomNumberSeed, making QNX=UNIX.
https://bugs.webkit.org/show_bug.cgi?id=73028
Reviewed by Daniel Bates.
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
2011-11-23 Nikolas Zimmermann <nzimmermann@rim.com>
Add flags/precision arguments to String::number(double) to allow fine-grained control over the result string
https://bugs.webkit.org/show_bug.cgi?id=72793
Reviewed by Zoltan Herczeg.
This new code will be used in follow-up patches to replace the String::format("%.2f") usage in
platform/text/TextStream.cpp, and String::format("%.6lg") usage in svg/SVGPathStringBuilder.cpp.
The String::number(double) currently calls String::format("%.6lg") in trunk. In order to replace
this by a variant that properly rounds to six significant figures, JSC code could be refactored.
JSCs Number.toPrecision/toFixed uses wtf/dtoa/double-conversion which provides all features we need,
except truncating trailing zeros, needed to mimic the "g" format, which is either f or e but with
trailing zeros removed, producing shorter results. Changed the default signature to:
"static String number(double, unsigned = ShouldRoundSignificantFigures | ShouldTruncateTrailingZeros, unsigned precision = 6);".
In WebCore we can now replace String::format() calls like this:
String::format("%.2f", f) -> String::number(f, ShouldRoundDecimalPlaces, 2)
String::format("%.6lg", f) -> String::number(f)
The default parameters for precison & flags exactly match the format of the string produced now, except that the result
is rounded according to the rounding mode / formatting mode and precision. This paves the way towards reliable results
in the d="" attribute dumps of SVG paths across platforms. The dtoa rounding code enforces a unique zero, resolving
all 0.0 vs. -0.0 issues currently seen on Windows, and some Gtk/Qt bots.
This patch needs a rebaseline of svg/dom/length-list-parser.html as we don't perfecly mimic the String::format() "lg" mode
result for exponentials, we used to return eg. "e-7" and now return "e-07" - the trailing zero truncation hasn't been
implemented for exponentials, as this really affects only this test and thus wasn't worth the trouble - in contrary the
trailing zero truncation is needed for thousands of other results in "f" notation, and thus needed to match the DRT results.
Here's a performance comparision using a JSC release build and some arbitary numbers:
Converting 123.456 using old approach took 95.527100ms. avg 0.000955ms/call.
Converting 123.456 using new approach took 28.126953ms. avg 0.000281ms/call.
Converting 123 using old approach took 85.411133ms. avg 0.000854ms/call.
Converting 123 using new approach took 24.190186ms. avg 0.000242ms/call.
Converting 0.1 using old approach took 92.622803ms. avg 0.000926ms/call.
Converting 0.1 using new approach took 23.317871ms. avg 0.000233ms/call.
Converting 1/i using old approach took 106.893066ms. avg 0.001069ms/call.
Converting 1/i using new approach took 27.164062ms. avg 0.000272ms/call.
For all numbers I've tested in RoundingSignificantFigures mode and 6 digit precision the speedup was at least 250%.
* JavaScriptCore.exp: Change String::number(double) signature.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Ditto.
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToFixed): Refactor this into numberToFixedPrecisionString(), move to wtf/dtoa.cpp.
(JSC::numberProtoFuncToPrecision): Ditto, refactor this into numberToFixedWidthString.
* wtf/dtoa.cpp: Moved fixedWidth/Precision helpers into dtoa, extend numberToFixedPrecisionString(). Add a mode which allows to truncate trailing zeros/decimal point.
to make it possible to use them to generate strings that match the output from String::format("%6.lg"), while using our dtoas rounding facilities.
* wtf/dtoa.h:
* wtf/dtoa/utils.h: Expose new helper method, which allows us to truncate the result, before generating the output const char*.
(WTF::double_conversion::StringBuilder::SetPosition):
* wtf/text/WTFString.cpp:
(WTF::String::number): Remove String::format("%6.lg") usage! Switch to rounding to six significant figures, while matching the output of String::format.
* wtf/text/WTFString.h:
2011-11-23 Hajime Morrita <morrita@chromium.org>
WTF::String has extra WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=72858
Reviewed by Kevin Ollivier.
* wtf/text/WTFString.h:
(WTF::String::String):
2011-11-23 Raphael Kubo da Costa <kubo@profusion.mobi>
[CMake] Move the top-level logic to the top-level directory.
https://bugs.webkit.org/show_bug.cgi?id=72685
Reviewed by Brent Fulgham.
* CMakeLists.txt: Point to the right Source/ directory.
* wtf/CMakeLists.txt: Ditto.
2011-11-22 Yuqiang Xian <yuqiang.xian@intel.com>
Strength reduction for Mul and Mod operations for known constants in DFG
https://bugs.webkit.org/show_bug.cgi?id=72878
Reviewed by Filip Pizlo.
Also the code should be commonly shared by both 32_64 and 64.
* dfg/DFGNode.h:
(JSC::DFG::nodeMayOverflow):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::isPowerOfTwo):
(JSC::DFG::logTwo):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-22 Daniel Bates <dbates@rim.com>
Add WTF infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72970
Reviewed by Antonio Gomes.
* wtf/Assertions.cpp: Added BlackBerry-specific logging directive.
* wtf/MathExtras.h:
(abs): Added; stdlib doesn't contain abs() on QNX.
* wtf/Platform.h: Define WTF_PLATFORM_BLACKBERRY and enable some platform features.
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator): For the BlackBerry port, we initialize
the bad pseudo random number generator using time(3) before initializing the
Mersenne Twister random number generator.
* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal): Added.
* wtf/blackberry: Added.
* wtf/blackberry/MainThreadBlackBerry.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
* wtf/text/WTFString.h: Added constructor and conversion operator for
BlackBerry WebString string object.
2011-11-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r100988.
http://trac.webkit.org/changeset/100988
https://bugs.webkit.org/show_bug.cgi?id=72941
"Broke pixel tests on Chromium-Linux" (Requested by kbalazs on
#webkit).
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
* wtf/ParallelJobsGeneric.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
* wtf/Platform.h:
2011-11-21 Balazs Kelemen <kbalazs@webkit.org>
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032
Reviewed by Zoltan Herczeg.
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.
* JavaScriptCore.gypi: Add the files to the build. It was
missing for the gyp build system.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
* wtf/ParallelJobsGeneric.h:
* wtf/Platform.h:
2011-11-21 Filip Pizlo <fpizlo@apple.com>
DFG should have richer debug output for CFA and phi processing
https://bugs.webkit.org/show_bug.cgi?id=72922
Reviewed by Gavin Barraclough.
In the default verbose mode, we now print information about variable
state at the bottom of basic blocks in addition to the top, and we
also print local variable linking. In the verbose propagation mode,
the state of phi processing is dumped more richly and CFA merging (the
most subtle part of CFA) is traced as well.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
* dfg/DFGAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::dump):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCommon.h:
(JSC::DFG::NodeIndexTraits::dump):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNode.h:
(JSC::DFG::Node::dumpChildren):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOperands.h:
(JSC::DFG::OperandValueTraits::dump):
(JSC::DFG::dumpOperands):
2011-11-21 Filip Pizlo <fpizlo@apple.com>
Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505
Reviewed by Gavin Barraclough.
It turns out that we were corrupting phi nodes in case of overflow. The bug is
really obvious, but producing a test case that causes the badness is hard. Even
when the phi nodes do get corrupt, there's more that has to happen before it
causes incorrect execution - and I wasn't able to reproduce in any kind of
sensible reduced case.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
2011-11-21 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Speed up debug builds.
https://bugs.webkit.org/show_bug.cgi?id=72882
Reviewed by Tor Arne Vestbø.
* Target.pri: Make BUILDING_JavaScriptCore available earlier, so it can be
used by the build system.
2011-11-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r100913.
http://trac.webkit.org/changeset/100913
https://bugs.webkit.org/show_bug.cgi?id=72885
"Break Windows build" (Requested by kbalazs on #webkit).
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
* wtf/ParallelJobsGeneric.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
* wtf/Platform.h:
2011-11-21 Balazs Kelemen <kbalazs@webkit.org>
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032
Reviewed by Zoltan Herczeg.
According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.
Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.
* JavaScriptCore.gypi: Add the files to the build. It was
missing for the gyp build system.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
* wtf/ParallelJobsGeneric.h:
* wtf/Platform.h:
2011-11-21 Andy Wingo <wingo@igalia.com>
Add .dir-locals.el file for better Emacs defaults
https://bugs.webkit.org/show_bug.cgi?id=72483
Reviewed by Xan Lopez.
* .dir-locals.el: Set appropriate directory-local variables for Emacs.
2011-11-21 Filip Pizlo <fpizlo@apple.com>
Another attempt at a build fix.
* dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
2011-11-20 Filip Pizlo <fpizlo@apple.com>
Unreviewed interpreter build fix.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
* dfg/DFGRepatch.h:
2011-11-20 Yuqiang Xian <yuqiang.xian@intel.com>
Improve modulo operation on 32bit platforms
https://bugs.webkit.org/show_bug.cgi?id=72501
Reviewed by Filip Pizlo.
Extend softModulo to support X86 and MIPS in baseline JIT.
Apply the same optimization to 32bit DFG JIT.
1% gain on Kraken, tested on Linux Core i7 Nehalem 32bit.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):
* wtf/Platform.h:
2011-11-18 Filip Pizlo <fpizlo@apple.com>
Inline caches that refer to otherwise dead objects should be cleared
https://bugs.webkit.org/show_bug.cgi?id=72311
Reviewed by Geoff Garen.
DFG code blocks now participate in the weak reference harvester fixpoint
so that they only consider themselves to be live if either they are
currently executing, or their owner is live and all of their weak references
are live. If not, the relevant code blocks are jettisoned.
Inline caches in both the old JIT and the DFG are now cleared if any of
their references are not marked at the end of a GC.
This is performance-neutral on SunSpider, V8, and Kraken. With the clear-
all-code-on-GC policy that we currently have, it shows a slight reduction
in memory usage. If we turn that policy off, it's pretty easy to come up
with an example program that will cause ToT to experience linear heap
growth, while with this patch, the heap stays small and remains at a
constant size.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::readCallTarget):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::readCallTarget):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::readCallTarget):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::readCallTarget):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::MethodCallLinkInfo::reset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::visitWeak):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::reset):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGOperations.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
* dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITWriteBarrier.h:
(JSC::JITWriteBarrierBase::clearToMaxUnsigned):
2011-11-20 Filip Pizlo <fpizlo@apple.com>
Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505
Reviewed by Oliver Hunt.
The bytecode generator was assuming that call_varargs never reuses the base register
(i.e. the function being called) for the result. This is no longer true.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallVarargs):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ApplyFunctionCallDotNode::emitBytecode):
2011-11-20 Filip Pizlo <fpizlo@apple.com>
DFG 32_64 should directly store double virtual registers on SetLocal
https://bugs.webkit.org/show_bug.cgi?id=72845
Reviewed by Oliver Hunt.
2% win on Kraken.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-20 Noel Gordon <noel.gordon@gmail.com>
[chromium] Remove DFG::JITCodeGenerator from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72842
Reviewed by Filip Pizlo.
dfg/DFGJITCodeGenerator.{h,cpp} were removed in r100244
* JavaScriptCore.gypi: remove dfg/DFGJITCodeGenerator.{h,cpp}
2011-11-18 Daniel Bates <dbates@rim.com>
Add CMake build infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72768
Reviewed by Antonio Gomes.
* PlatformBlackBerry.cmake: Added.
* shell/PlatformBlackBerry.cmake: Added.
* wtf/PlatformBlackBerry.cmake: Added.
2011-11-18 Filip Pizlo <fpizlo@apple.com>
DFG JIT fails speculation on InstanceOf if the base is not an object
https://bugs.webkit.org/show_bug.cgi?id=72709
Reviewed by Geoff Garen.
InstanceOf already leverages the fact that we only allow the default
hasInstance implementation. So, if the base is predicted to possibly
be not an object and the CFA has not yet proven otherwise, InstanceOf
will abstain from speculating cell and instead return false if the
base is not a cell.
This appears to be a 1% speed-up on V8 on the V8 harness. 3-4% or so
speed-up in earley-boyer. Neutral according to bencher on SunSpider,
V8, and Kraken. In 32-bit, it's a 0.5% win on SunSpider and a 1.9%
win on V8 even on my harness, due to a 12.5% win on earley-boyer.
I also took this opportunity to make the code for InstanceOf common
between the two JITs. This was partially successful, in that the
"common code" has a bunch of #if's, but overall it seems like a code
size reduction.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-18 Mark Hahnenberg <mhahnenberg@apple.com>
Forgot to completely de-virtualize isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=72763
Reviewed by Darin Adler.
* runtime/JSActivation.h: Removed virtual keyword.
2011-11-18 Filip Pizlo <fpizlo@apple.com>
Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292
Reviewed by Darin Adler.
Fix this for 32_64.
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
2011-11-18 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize ExecutableBase::intrinsic
https://bugs.webkit.org/show_bug.cgi?id=72548
Reviewed by Oliver Hunt.
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic): Dynamic cast to NativeExecutable. If successful, call intrinsic, otherwise return default value.
* runtime/Executable.h:
* runtime/JSCell.h:
(JSC::jsDynamicCast): Add jsDynamicCast that duplicates the functionality of dynamic_cast in C++ but uses ClassInfo
rather than requiring C++ RTTI.
2011-11-18 Patrick Gansterer <paroga@webkit.org>
[CMake] Remove duplicate dtoa files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72711
Reviewed by Brent Fulgham.
* wtf/CMakeLists.txt:
2011-11-17 Michael Saboff <msaboff@apple.com>
[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602
Fixed StringImpl::foldCase by adding return in the case we need to handle
folding of 8 bit strings with Latin-1 characters.
Fixed case where StringImpl::replace was using a char temp instead of an
LChar temp.
Because of the second change, I changed other uses of char or
unsigned char to LChar.
Reviewed by Zoltan Herczeg.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::replace):
2011-11-17 Patrick Gansterer <paroga@webkit.org>
[CMake] Move FAST_MALLOC specific lines from Platform*.cmake to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72644
Reviewed by Brent Fulgham.
All ports need to do the same determination about fast malloc. Move the CMake code from
platform specific files into the generic one, so that additional ports can reuse it.
* wtf/CMakeLists.txt:
* wtf/PlatformEfl.cmake:
* wtf/PlatformWinCE.cmake:
2011-11-17 Mark Hahnenberg <mhahnenberg@apple.com>
Add finalizer to JSActivation
https://bugs.webkit.org/show_bug.cgi?id=72575
Reviewed by Geoffrey Garen.
* runtime/JSActivation.cpp:
(JSC::JSActivation::finishCreation): Attach finalize function to objects during creation.
(JSC::JSActivation::finalize):
* runtime/JSActivation.h: Replaced virtual destructor with static finalize function.
2011-11-15 Filip Pizlo <fpizlo@apple.com>
Code block jettisoning should be part of the GC's transitive closure
https://bugs.webkit.org/show_bug.cgi?id=72467
Reviewed by Geoff Garen.
Replaced JettisonedCodeBlocks with DFGCodeBlocks. The latter knows about all
DFG code blocks (i.e. those that may be jettisoned, and may have inlined weak
references) and helps track what state each of those code blocks is in during
GC. The state consists of two flags; mayBeExecuting, which tells if the code block
is live from call frames; and isJettisoned, which tells if the code block is
not owned by any executable and thus should be deleted as soon as it is not
mayBeExecuting.
- Not executing, Not jettisoned: The code block may or may not be reachable from
any executables, but it is owned by an executable, and hence should be
kept alive if its executable is live and if all of its weak references are
live. Otherwise it should be deleted during the current GC cycle, and its
outgoing references should not be scanned.
- Not executing but jettisoned: The code block should be deleted as soon as
possible and none of its outgoing references should be scanned.
- Executing but not jettisoned: The code block should be kept alive during this
GC cycle, and all of its outgoing references (including the weak ones)
should be scanned and marked strongly. The mayBeExecuting bit will be cleared at
the end of the GC cycle.
- Executing and jettisoned: The code block should be kept alive during this
GC cycle, and all of its outgoing references (including the weak ones)
should be scanned and marked strongly. However, on the next GC cycle, it
will have its mayBeExecuting bit cleared and hence it will become a candidate
for immediate deletion provided it is not executing again.
This is performance-neutral.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::DFGData::DFGData):
(JSC::DFGCodeBlocks::mark):
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::add):
* heap/ConservativeRoots.h:
* heap/DFGCodeBlocks.cpp: Added.
(JSC::DFGCodeBlocks::DFGCodeBlocks):
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):
* heap/DFGCodeBlocks.h: Added.
* heap/Heap.cpp:
(JSC::Heap::jettisonDFGCodeBlock):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/JettisonedCodeBlocks.cpp: Removed.
* heap/JettisonedCodeBlocks.h: Removed.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
* interpreter/RegisterFile.h:
* runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
2011-11-16 Filip Pizlo <fpizlo@apple.com>
Unreviewed, build fix for 32-bit.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-16 Geoffrey Garen <ggaren@apple.com>
Some CachedCall cleanup, in preparation for reversing argument order.
Reviewed by Gavin Barraclough.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitWeakReferences): A build fix for the interpreter,
so I can test it.
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall): Renamed argCount to argumentCount because
we are not that desperate for character saving.
(JSC::CachedCall::setThis):
(JSC::CachedCall::setArgument): Adopted new 0-based argument indexing for
CallFrameClosure.
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Provide 0-based argument indexing,
with an explicit setter for 'this', since that's how most clients think.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::prepareForRepeatCall):
* interpreter/Interpreter.h: Change argCount to argumentCountIncludingThis,
for clarity.
2011-11-16 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize ScriptExecutable::unlinkCalls
https://bugs.webkit.org/show_bug.cgi?id=72546
Reviewed by Geoffrey Garen.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable): Added an empty explicit virtual destructor to prevent a very odd compilation error
due to the fact that the compiler was trying to generate the implicit inline destructor in every translation unit, some of which
didn't have complete type information on the things that needed to be destructed in the implicit destructor.
* runtime/Executable.h:
(JSC::EvalExecutable::createStructure): Used new type value from JSType
(JSC::ProgramExecutable::createStructure): Ditto
(JSC::FunctionExecutable::createStructure): Ditto
(JSC::ScriptExecutable::unlinkCalls): Condition upon the type value, cast and call the corresponding unlinkCalls implementation.
* runtime/JSType.h: Added new values for EvalExecutable, ProgramExecutable, and FunctionExecutable. Remove explicit numbers, since
that just adds noise to patches and they currently have no significance.
2011-11-16 Filip Pizlo <fpizlo@apple.com>
JSC::CodeBlock should know which references generated by the DFG are weak
https://bugs.webkit.org/show_bug.cgi?id=72563
Reviewed by Geoff Garen.
CodeBlock::m_dfgData now tracks weak references and weak reference transitions
(like ephemerons) generated by the DFG. The DFG makes sure to notify the
CodeBlock of all uses of weak references and weak reference transitions.
CodeBlock currently marks them strongly, since the weak marking logic is not
in place, yet.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::stronglyVisitWeakReferences):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::appendWeakReference):
(JSC::CodeBlock::shrinkWeakReferencesToFit):
(JSC::CodeBlock::appendWeakReferenceTransition):
(JSC::CodeBlock::shrinkWeakReferenceTransitionsToFit):
(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::codeOriginOwner):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::addWeakReferenceTransition):
(JSC::DFG::JITCompiler::branchWeakPtr):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::compile):
2011-11-16 Michael Saboff <msaboff@apple.com>
LayoutTests for Debug Builds Crashes in JavaScriptCore/yarr/YarrInterpreter.cpp(185)
https://bugs.webkit.org/show_bug.cgi?id=72561
Removed #if USE(JSC) and therefore the ASSERT_NOT_REACHED().
Simplified the code in the process.
Reviewed by James Robinson.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):
2011-11-16 Geoffrey Garen <ggaren@apple.com>
Interpreter build fixes.
* bytecode/CodeBlock.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2011-11-16 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for !ENABLE(JIT) after r100363.
* bytecode/CodeBlock.h:
2011-11-16 Geoffrey Garen <ggaren@apple.com>
Rolled back in r100375 and r100385 with 32-bit build fixed.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
* runtime/ArgList.h:
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSGlobalObject.h:
(JSC::constructArray):
2011-11-16 Filip Pizlo <fpizlo@apple.com>
DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542
Reviewed by Geoff Garen.
Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::globalObjectFor):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::globalObjectFor):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
2011-11-16 Michael Saboff <msaboff@apple.com>
Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71337
This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type. This change rippled into WebCore code as well.
Reviewed by Geoffrey Garen.
* JavaScriptCore.exp:
* parser/Lexer.cpp:
(JSC::::append8): Changed to use 8 bit buffers.
(JSC::::parseIdentifier): Changed to use 8 bit buffers.
(JSC::::parseString): Changed to use 8 bit buffers.
* runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::translate): 8 bit version keeps data 8 bit
(JSC::Identifier::toUInt32FromCharacters): Templated helper.
(JSC::Identifier::toUInt32): Added 8 bit optimized path.
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage): Changed to be 8 bit strings
* runtime/UString.h:
(JSC::UString::characters): Now calls StringImpl::characters()
* wtf/Forward.h:
* wtf/text/StringBuffer.h: Made StringBuffer a template base on character type.
(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::characters):
(WTF::StringBuffer::release):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase): Fixed null terminated case.
(WTF::StringImpl::removeCharacters): Added 8 bit path.
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::simplifyWhiteSpace):
(WTF::equal): Removed bug from code copied from null terminated version.
(WTF::StringImpl::adopt): Added 8 bit path.
(WTF::StringImpl::createWithTerminatingNullCharacter): Fixed 8 bi flag propagation.
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl): Added new 8 bit constructor.
(WTF::StringImpl::characters8): Removed ASSERT_NOT_REACHED().
(WTF::getCharacters<LChar>): Added templated accessor for 8 bit strings.
(WTF::getCharacters<UChar>): Added templated accessor for 16 bit strings.
* wtf/text/WTFString.h:
(WTF::String::adopt): Changed to use StringBuffer template.
2011-11-16 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize ExecutableBase::clearCodeVirtual
https://bugs.webkit.org/show_bug.cgi?id=72337
Reviewed by Darin Adler.
Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
and had the finalize functions call the corresponding clearCode methods.
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::NativeExecutable::finalize):
(JSC::EvalExecutable::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::finalize):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::finalize):
(JSC::FunctionExecutable::clearCode):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation):
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
2011-11-16 Yusuke Suzuki <utatane.tea@gmail.com>
String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
https://bugs.webkit.org/show_bug.cgi?id=71572
Reviewed by Gavin Barraclough and Darin Adler.
* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):
2011-11-16 Darin Adler <darin@apple.com>
Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
https://bugs.webkit.org/show_bug.cgi?id=72475
Reviewed by Adam Roben.
* wtf/HashTraits.h: Specialize HashTraits for OwnPtr.
Do overloads so we can pass a nullptr and also be sure to get the
raw pointer type from the OwnPtr template so we handle both forms
of OwnPtr: OwnPtr<T> and OwnPtr<T*>.
2011-11-16 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
Reviewed by Tor Arne Vestbø.
* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
2011-11-16 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed, rolling out r100266.
http://trac.webkit.org/changeset/100266
Broke WTR.
* Target.pri:
2011-11-16 Darin Adler <darin@apple.com>
Add a "pass type" and "peek type" concept to HashTraits
https://bugs.webkit.org/show_bug.cgi?id=72473
Reviewed by Filip Pizlo.
* wtf/HashTraits.h: Added the pass type and peek type.
For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.
2011-11-16 Darin Adler <darin@apple.com>
Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470
Reviewed by Filip Pizlo.
Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.
* runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from
HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.
* runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive
from HashTraits<SymbolTableEntry> and removed redundant members.
2011-11-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r100375 and r100385.
http://trac.webkit.org/changeset/100375
http://trac.webkit.org/changeset/100385
https://bugs.webkit.org/show_bug.cgi?id=72465
They broke 32 bit builds on Qt (Requested by ossy on #webkit).
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
* runtime/ArgList.h:
(JSC::ArgList::ArgList):
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSGlobalObject.h:
2011-11-15 George Staikos <staikos@webkit.org>
Remove the guard page from the addressable stack region on QNX.
https://bugs.webkit.org/show_bug.cgi?id=72455
Reviewed by Daniel Bates.
* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
2011-11-15 Michael Saboff <msaboff@apple.com>
Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=72323
Added 8 bit optimized paths for String and UString ascii() and utf8() methods.
Added String::characters8(), characters16() and is8Bit() helper methods.
Added an new Unicode::convertLatin1ToUTF8() method that works on
LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().
Reviewed by Geoff Garen.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/UString.cpp:
(JSC::UString::utf8):
* wtf/text/WTFString.cpp:
(WTF::String::ascii):
(WTF::String::utf8):
* wtf/text/WTFString.h:
(WTF::String::characters8):
(WTF::String::characters16):
(WTF::String::is8Bit):
(WTF::LChar):
(WTF::UChar):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertLatin1ToUTF8):
* wtf/unicode/UTF8.h:
* wtf/unicode/Unicode.h:
2011-11-15 Darin Adler <darin@apple.com>
REGRESSION (r98887): ParserArena and Keywords leaking
https://bugs.webkit.org/show_bug.cgi?id=72428
Reviewed by Sam Weinig.
* parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr
need to be able to destroy it.
* parser/Parser.cpp:
(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.
* runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
2011-11-15 Geoffrey Garen <ggaren@apple.com>
Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.
Reviewed by Sam Weinig.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.
* runtime/ArgList.h: Removed!
2011-11-15 Geoffrey Garen <ggaren@apple.com>
Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.
Reviewed by Sam Weinig.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use new API.
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
getSlice can do the right thing by using its rights to private data.
* runtime/ArgList.h: Removed constructor that took a forward-contiguous
set of arguments.
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSGlobalObject.h:
(JSC::constructArray): Added explicit support for creating an array from
a pre-allocated set of values, so we could stop relying on the ArgList
API we want to remove.
2011-11-15 Filip Pizlo <fpizlo@apple.com>
Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292
Reviewed by Geoff Garen.
We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().
No performance effect.
No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
2011-11-15 Geoffrey Garen <ggaren@apple.com>
Use MarkedArgumentBuffer to avoid making assumptions about argument order
https://bugs.webkit.org/show_bug.cgi?id=72418
Reviewed by Sam Weinig.
A step toward reversing the argument order.
* runtime/JSONObject.cpp:
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::callReviver): Don't assume that ArgList wants to point
at arguments in forward order. Instead, use MarkedArgumentBuffer, which
will make the decision for us.
2011-11-15 Filip Pizlo <fpizlo@apple.com>
DFG should distinguish between constants in the constant pool and weak
constants added as artifacts of code generation
https://bugs.webkit.org/show_bug.cgi?id=72367
Reviewed by Geoff Garen.
Added the notion of a WeakJSConstant, which is like a JSConstant except that
it can only refer to JSCell*. Currently all WeakJSConstants are also backed
by constants in the constant pool, since weak references originated from
machine code are not yet properly handled.
Replaced CheckMethod, and MethodCheckData, with a combination of WeakJSConstant
and CheckStructure. This results in improved CSE, leading to a 1% win on V8.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
* dfg/DFGNode.h:
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::weakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::hasIdentifier):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-15 Michael Saboff <msaboff@apple.com>
Towards 8 bit Strings - Initial JS String Tuning
https://bugs.webkit.org/show_bug.cgi?id=72326
Added 8 bit optimized paths for the methods below.
Reviewed by Geoffrey Garen.
* runtime/JSString.h:
(JSC::jsSubstring8):
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharCodeAt):
2011-11-15 Gavin Barraclough <barraclough@apple.com>
Result of Error.prototype.toString not ES5 conformant
https://bugs.webkit.org/show_bug.cgi?id=70889
Reviewed by Oliver Hunt.
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
2011-11-15 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
Reviewed by Tor Arne Vestbø.
* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
2011-11-15 Yuqiang Xian <yuqiang.xian@intel.com>
Remove DFGJITCompilerInlineMethods
https://bugs.webkit.org/show_bug.cgi?id=72366
Reviewed by Filip Pizlo.
Those methods are actually seldom used. Modify the few such places and
remove DFGJITCompilerInlineMethods stuffs totally.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
* dfg/DFGJITCompilerInlineMethods.h: Removed.
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillFPR):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
2011-11-14 Filip Pizlo <fpizlo@apple.com>
DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined
https://bugs.webkit.org/show_bug.cgi?id=72348
Reviewed by Gavin Barraclough.
Moved all of JITCodeGenerator into SpeculativeJIT.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGJITCodeGenerator.cpp: Removed.
* dfg/DFGJITCodeGenerator.h: Removed.
* dfg/DFGJITCodeGenerator32_64.cpp: Removed.
* dfg/DFGJITCodeGenerator64.cpp: Removed.
* dfg/DFGJITCompiler.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryCachePutByID):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::clearGenerationInfo):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownBoolean):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::markCellCard):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::dataFormatString):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::GPRTemporary::adopt):
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::lock):
(JSC::DFG::SpeculativeJIT::unlock):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::reuse):
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::tryAllocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
(JSC::DFG::SpeculativeJIT::silentSpillGPR):
(JSC::DFG::SpeculativeJIT::silentSpillFPR):
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::silentFillFPR):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::unboxDouble):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::identifier):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImmPtr):
(JSC::DFG::SpeculativeJIT::bitOp):
(JSC::DFG::SpeculativeJIT::shiftOp):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::addressOfCallData):
(JSC::DFG::SpeculativeJIT::tagOfCallData):
(JSC::DFG::SpeculativeJIT::payloadOfCallData):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument):
(JSC::DFG::SpeculativeJIT::setupArguments):
(JSC::DFG::SpeculativeJIT::setupArgumentsExecState):
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::setupTwoStubArgs):
(JSC::DFG::SpeculativeJIT::setupStubArguments):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::setupResults):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::block):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::~IntegerOperand):
(JSC::DFG::IntegerOperand::index):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::~DoubleOperand):
(JSC::DFG::DoubleOperand::index):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::~JSValueOperand):
(JSC::DFG::JSValueOperand::index):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::jsValueRegs):
(JSC::DFG::JSValueOperand::isDouble):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::tagGPR):
(JSC::DFG::JSValueOperand::payloadGPR):
(JSC::DFG::JSValueOperand::fpr):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::GPRTemporary::~GPRTemporary):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::~FPRTemporary):
(JSC::DFG::FPRTemporary::fpr):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::GPRResult::GPRResult):
(JSC::DFG::GPRResult2::GPRResult2):
(JSC::DFG::FPRResult::FPRResult):
(JSC::DFG::FPRResult::lockedResult):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
* runtime/JSFunction.h:
2011-11-14 Filip Pizlo <fpizlo@apple.com>
Weak reference harvesters should run to fixpoint
https://bugs.webkit.org/show_bug.cgi?id=72346
Reviewed by Oliver Hunt.
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/ListableHandler.h:
(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):
* heap/MarkStack.h:
(JSC::MarkStack::isEmpty):
2011-11-14 Oliver Hunt <oliver@apple.com>
Start migrating typed array impl types to WTF
https://bugs.webkit.org/show_bug.cgi?id=72336
Reviewed by Geoffrey Garen.
Add typed array impls to WTF forwarding header.
* wtf/Forward.h:
2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
Add --css-grid-layout to build-webkit and the build systems
https://bugs.webkit.org/show_bug.cgi?id=72320
Reviewed by Ojan Vafai.
* Configurations/FeatureDefines.xcconfig:
2011-11-14 Geoffrey Garen <ggaren@apple.com>
A little bit of arguments / activation cleanup
https://bugs.webkit.org/show_bug.cgi?id=72339
Reviewed by Gavin Barraclough.
Renamed copyRegisters => tearOff to match bytecode and other terminology.
Renamed setActivation => didTearOffActivation to indicate that this is a
notification the object may choose to ignore. Moved "Should I ignore?"
code into the arguments object to avoid duplication elsewhere.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.h:
(JSC::Arguments::createAndTearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::finishCreationButDontTearOff):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndTearOff):
(JSC::Arguments::tearOff):
* runtime/JSActivation.h:
(JSC::JSActivation::tearOff): Moved Activation's code into its own header
because that's where it belongs.
2011-11-14 Gavin Barraclough <barraclough@apple.com>
Should sign the jsc binary
https://bugs.webkit.org/show_bug.cgi?id=72332
Reviewed by David Kilzer.
* Configurations/JSC.xcconfig:
* entitlements.plist: Added.
2011-11-14 Filip Pizlo <fpizlo@apple.com>
DFG's inline references to objects should be tracked
https://bugs.webkit.org/show_bug.cgi?id=72313
Reviewed by Gavin Barraclough.
Added a pinCell() method in the parser that currently creates a
dummy constant in CodeBlock. Added calls to pinCell() wherever the
DFG would inline a constant reference that the original code would
not have referred to.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getCellConstantIndex):
(JSC::DFG::ByteCodeParser::pinCell):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
2011-11-14 Filip Pizlo <fpizlo@apple.com>
DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324
Reviewed by Gavin Barraclough.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
2011-11-14 Michael Saboff <msaboff@apple.com>
Further changes and cleanup to JSString.h and cpp.
Reviewed by Darin Adler.
* runtime/JSString.cpp:
(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr. Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.
* runtime/JSString.h:
2011-11-14 Adam Barth <abarth@webkit.org>
DateMath.cpp should not depend on JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71747
Reviewed by Darin Adler.
This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore. There shouldn't be any behavior change.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* runtime/DateConstructor.cpp:
* runtime/DateConversion.cpp:
* runtime/DateInstance.cpp:
* runtime/DateInstanceCache.h:
* runtime/DatePrototype.cpp:
* runtime/InitializeThreading.cpp:
* runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.
(JSC::timeToMS):
(JSC::msToSeconds):
* runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
* wtf/DateMath.cpp:
(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):
* wtf/DateMath.h:
2011-11-14 Michael Saboff <msaboff@apple.com>
Towards 8 bit strings - Add 8 bit handling to JSString Ropes
https://bugs.webkit.org/show_bug.cgi?id=72317
Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.
Reviewed by Oliver Hunt.
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):
2011-11-14 Geoffrey Garen <ggaren@apple.com>
A little bit of function call cleanup
https://bugs.webkit.org/show_bug.cgi?id=72314
Reviewed by Oliver Hunt.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.
(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.
(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.
(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.
* bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because
16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.
2011-11-14 Tony Chang <tony@chromium.org>
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196
Reviewed by Ojan Vafai.
* Configurations/FeatureDefines.xcconfig:
2011-11-14 Mark Rowe <mrowe@apple.com>
<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore
testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.
This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when
FORCE_TOOL_INSTALL is YES.
3) Switches the testapi target to using a script build phase to install testapi.js
so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.
4) Other random cleanup such as removing a bogus group that refers to files that do
not exist, moving testRegExp.cpp in to the tests group, etc.
Reviewed by Geoff Garen.
* Configurations/JSC.xcconfig: Added.
* Configurations/TestRegExp.xcconfig: Added.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-11-14 Michael Saboff <msaboff@apple.com>
Towards 8 bit strings - Add 8 bit paths to StringImpl methods
https://bugs.webkit.org/show_bug.cgi?id=72290
Added 8 bit patchs to StringImpl to number and find methods.
Reviewed by Oliver Hunt.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):
* wtf/text/WTFString.cpp:
(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):
* wtf/text/WTFString.h:
(WTF::find):
(WTF::reverseFind):
2011-11-14 Vincent Scheib <scheib@chromium.org>
Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
https://bugs.webkit.org/show_bug.cgi?id=72286
Reviewed by Adam Barth.
* wtf/Platform.h:
2011-11-14 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=72280
Rubber stamped by Geoff Garen.
Fix 32-bit Lion.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
2011-11-14 Geoffrey Garen <ggaren@apple.com>
32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.
For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
2011-11-14 Michael Saboff <msaboff@apple.com>
Remove unused m_data member from UStringSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=72289
Removed unused m_data member from UStringSourceProvider.
Reviewed by Oliver Hunt.
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::UStringSourceProvider):
2011-11-14 Michael Saboff <msaboff@apple.com>
Towards 8 Bit Strings: Templatize YARR Parser
https://bugs.webkit.org/show_bug.cgi?id=72288
Changed Yarr::Parser to be a template based on character type.
Reviewed by Oliver Hunt.
* yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):
2011-11-14 Geoffrey Garen <ggaren@apple.com>
32-bit build fix: Removed unused declaration.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
2011-11-12 Geoffrey Garen <ggaren@apple.com>
Standardized the JS calling convention
https://bugs.webkit.org/show_bug.cgi?id=72221
Reviewed by Oliver Hunt.
This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.
This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):
(1) 1% benchmark speedup across the board.
(2) 50% code size reduction in baseline JIT function calls.
(3) 1.5x speedup for single-dispatch .apply forwarding.
(4) 1.1x speedup for multi-dispatch .apply forwarding.
This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.
(JSC::CallLinkInfo::unlink):
* bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows
us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallVarargs):
* bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.
* bytecompiler/NodesCodegen.cpp:
(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.
Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.
* dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before
doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.
* interpreter/Interpreter.cpp: Let the true code bomb begin!
(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.
(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.
(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.
(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)
op_call_eval: Updated for new, standard eval calling convention.
op_load_varargs: Merged op_load_varargs into op_call_varargs.
op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.
* interpreter/Interpreter.h:
(JSC::Interpreter::execute): Headers are fun and educational!
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::growSlowCase):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.
* jit/JIT.cpp:
(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.
(JSC::JIT::linkFor): Link even if we miss on argument count, as above.
* jit/JIT.h:
* jit/JITCall32_64.cpp:
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)
(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.
This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.
Added a shared path for calling out to CTI helper functions for non-JS
calls.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.
* jit/JITStubs.cpp:
(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)
(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.
* runtime/Arguments.h:
(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)
2011-11-11 Jer Noble <jer.noble@apple.com>
Implement MediaController.
https://bugs.webkit.org/show_bug.cgi?id=71408
Reviewed by Eric Carlson.
Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.
* wtf/Platform.h:
2011-11-14 Patrick Gansterer <paroga@webkit.org>
[WIN] Remove dependency on pthread from FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=72098
Reviewed by Adam Roben.
All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.
* wtf/FastMalloc.cpp:
2011-11-14 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Replace use of QApplication with QGuiApplication.
Reviewed by Tor Arne Vestbø.
* wtf/qt/compat/qguiapplication.h:
(QGuiApplication::styleHints): Introduce styleHints wrapper hack.
2011-11-14 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck build.
* GNUmakefile.list.am: Add missing files.
2011-11-11 Yury Semikhatsky <yurys@chromium.org>
Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808
Exposed accessor for function source code.
Reviewed by Pavel Feldman.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSFunction.cpp:
(JSC::JSFunction::sourceCode):
* runtime/JSFunction.h:
2011-11-13 Yuqiang Xian <yuqiang.xian@intel.com>
Fix silent spilling/filling GPRs in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=72201
Reviewed by Gavin Barraclough.
Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
2011-11-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>
[Qt][Symbian] Remove support for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=70178
Reviewed by Chang Shu.
* API/JSStringRef.h:
* create_hash_table: Revert r45553.
* runtime/JSGlobalData.cpp: Revert r45553.
* runtime/LiteralParser.cpp: Remove WINSCW comment.
(JSC::LiteralParser::Lexer::lexString):
* runtime/Lookup.h: Revert r45553.
* runtime/Structure.h: Revert r48461.
* wtf/Alignment.h:
* wtf/Assertions.h: Revert r52337.
* wtf/Compiler.h:
* wtf/ListRefPtr.h: Revert r48988.
(WTF::ListRefPtr::~ListRefPtr):
* wtf/OwnArrayPtr.h: Revert r45911.
(WTF::OwnArrayPtr::operator UnspecifiedBoolType):
* wtf/PassOwnArrayPtr.h:
(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):
* wtf/PassRefPtr.h:
* wtf/StaticConstructors.h:
* wtf/unicode/qt4/UnicodeQt4.h:
2011-11-12 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.
* dfg/DFGCorrectableJumpPoint.cpp:
* dfg/DFGCorrectableJumpPoint.h:
2011-11-12 Patrick Gansterer <paroga@webkit.org>
[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212
Reviewed by Daniel Bates.
The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.
* CMakeLists.txt:
* PlatformEfl.cmake:
2011-11-12 Patrick Gansterer <paroga@webkit.org>
Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213
Reviewed by Anders Carlsson.
Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.
* runtime/JSLock.cpp:
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
2011-11-11 Gavin Barraclough <barraclough@apple.com>
Update iOS compiler version.
Reviewed by David Kilzer.
* Configurations/CompilerVersion.xcconfig:
- Update compiler version.
2011-11-11 Gavin Barraclough <barraclough@apple.com>
Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187
Reviewed by David Kilzer.
* interpreter/Interpreter.h:
- Lower the reentry depth.
* runtime/DatePrototype.cpp:
- iOS also uses CF.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::IncrementalScavenge):
- Update fastmalloc configuration for iOS.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
- Added flag.
* wtf/Platform.h:
- Update platform configuration for iOS.
2011-11-11 David Kilzer <ddkilzer@apple.com>
Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
<http://webkit.org/b/72175>
Reviewed by Joseph Pecoraro.
* wtf/Platform.h: Move the definition of the BUILDING_ON_* and
TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds. Also include
Availability.h, which is needed on iOS builds.
2011-11-11 Darin Adler <darin@apple.com>
Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423
Reviewed by Julien Chaffraix.
* API/JSRetainPtr.h: Removed releaseRef.
* wtf/PassRefPtr.h: Removed releaseRef.
2011-11-11 Darin Adler <darin@apple.com>
* JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.
2011-11-11 Mark Hahnenberg <mhahnenberg@apple.com>
Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071
Reviewed by Geoffrey Garen.
Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
* API/JSCallbackObjectFunctions.h:
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSCell.h:
(JSC::JSCell::visitChildren):
(JSC::jsCast):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):
* runtime/JSGlobalData.cpp:
(JSC::StackPreservingRecompiler::operator()):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::visitChildren):
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):
* runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSString.cpp:
(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/Structure.cpp:
(JSC::Structure::visitChildren):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
2011-11-11 Gavin Barraclough <barraclough@apple.com>
Enable DFG JIT for ARMv7/iOS.
Rubber stamped by Oliver Hunt.
* wtf/Platform.h:
- enable DFG JIT for ARMv7/iOS.
2011-11-11 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=72035
Reviewed by Geoffrey Garen.
De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.
(JSC::BytecodeGenerator::BytecodeGenerator):
* interpreter/Interpreter.cpp: Ditto.
(JSC::Interpreter::execute):
* runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
* runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.
* runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.
(JSC::TimeoutChecker::didTimeOut):
2011-11-11 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSGlobalObject::allowsAccessFrom
https://bugs.webkit.org/show_bug.cgi?id=71969
Reviewed by Darin Adler.
* runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to
JSDOMWindowBase and WebScriptObject.
2011-11-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r99950.
http://trac.webkit.org/changeset/99950
https://bugs.webkit.org/show_bug.cgi?id=72117
"Landed wrong patch by mistake" (Requested by yurys on
#webkit).
* JavaScriptCore.exp:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
2011-11-11 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for !ENABLE(JIT) after r99898.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
2011-11-10 Dan Bernstein <mitz@apple.com>
Disabling assertions breaks the debug build
https://bugs.webkit.org/show_bug.cgi?id=72091
Reviewed by Geoff Garen.
* dfg/DFGNode.h: Made hasIdentifier() available when assertions are
disabled. It is used in Graph::dump().
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Update m_isCheckingForDefaultMarkViolation
only if assertions are enabled.
* wtf/Deque.h:
(WTF::::checkIndexValidity): Changed ASSERT to ASSERT_UNUSED.
* wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::setShared): Guarded the definition of
a local variable that is only used in an assertion.
2011-11-10 Filip Pizlo <fpizlo@apple.com>
JSString forgets to clear m_fibers when resolving ropes
https://bugs.webkit.org/show_bug.cgi?id=72089
Reviewed by Geoff Garen.
* runtime/JSString.cpp:
(JSC::JSString::resolveRopeSlowCase):
2011-11-09 Filip Pizlo <fpizlo@apple.com>
DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
2011-11-10 Filip Pizlo <fpizlo@apple.com>
ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065
Reviewed by Gavin Barraclough and Geoff Garen.
Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isFunctionPrediction):
* bytecode/ValueProfile.cpp:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
2011-11-10 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR
Reviewed by Joseph Pecoraro.
* JavaScriptCore.xcodeproj/project.pbxproj: The testapi.js
script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation. Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.
2011-11-10 Gavin Barraclough <barraclough@apple.com>
Add ARMv7 support to the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72061
Reviewed by Geoff Garen.
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
- Add CPU(ARM) copies of these functions.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::spill):
- Fix matching of '}' re #if blocks, makes some tools happy.
(JSC::DFG::JITCodeGenerator::setupArguments):
(JSC::DFG::JITCodeGenerator::setupArgumentsWithExecState):
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheckSetResult):
(JSC::DFG::JITCodeGenerator::appendCallSetResult):
- Add CPU(ARM) / 4 argument register copies of these functions.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
- Should use callOperation to plant a call to a DFG_OPERATION.
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
- These methods need to plant a relinkable jump; we currently do so
using beginUninterruptedSequence() / endUninterruptedSequence().
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
- Should use callOperation to plant a call to a DFG_OPERATION.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
- This method needs to plant a relinkable jump; we currently do so
using beginUninterruptedSequence() / endUninterruptedSequence().
(JSC::DFG::JITCompiler::compileBody):
- Add abstraction to retrieve the pc after a call.
* dfg/DFGOSRExitCompiler.cpp:
- Fix a bug - CodeLocationLabel needs a data address rather than an
executable one, but can just take a MacroAssemblerCodePtr instead!
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::compileClampDoubleToByte):
- Add FIXME comment to come back to! - bug#72054.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
- Add missing method (ooops, required by bug#72047)
* dfg/DFGSpeculativeJIT32_64.cpp:
- Need to wrap fmod on ARMv7.
2011-11-10 Filip Pizlo <fpizlo@apple.com>
DFG should not reparse code that was just parsed
https://bugs.webkit.org/show_bug.cgi?id=71977
Reviewed by Geoff Garen.
The instruction stream of a code block is now kept around until
the next GC. When doing either an optimizing compilation of an
executable, or inlining of an executable, we now try to find the
already preexisting bytecode. If we find it, we don't have to parse.
If we don't find it, we parse as before. Inlining takes the extra
step of caching code blocks, so if the same executable gets inlined
multiple times into the same caller, then we parse it at most once
even if prior to inlining that executable did not have any code
blocks with an instruction stream.
Also fixed a silly bug where the strict mode for various operations
was being determined by looking at the machine code block rather
than the inlinee.
To enable the delete-on-next-GC policy, I introduced the notion
of an ultra weak finalizer, which anyone can register during
tracing. This is thread-safe (for parallel GC) and
stop-the-world-safe (so calls to free() are postponed until the
world is resumed). This required reusing some facilities previously
created for WeakReferenceHarvester, so I created a common utility
class. I also retweaked the handling of WeakReferenceHarvesters,
since they should be executed during stop-the-world since in the
future we may want to allow them to call drain().
2% win on SunSpider. 2% win on V8, when run in my harness. Neutral
elsewhere.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::copyPostParseDataFrom):
(JSC::CodeBlock::copyPostParseDataFromAlternative):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::canProduceCopyWithBytecode):
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::handleBytecodeDiscardingOpportunity):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::BytecodeDestructionBlocker::BytecodeDestructionBlocker):
(JSC::BytecodeDestructionBlocker::~BytecodeDestructionBlocker):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::strictModeFor):
* dfg/DFGByteCodeCache.h: Added.
(JSC::DFG::CodeBlockKey::CodeBlockKey):
(JSC::DFG::CodeBlockKey::operator==):
(JSC::DFG::CodeBlockKey::hash):
(JSC::DFG::CodeBlockKey::executable):
(JSC::DFG::CodeBlockKey::kind):
(JSC::DFG::CodeBlockKey::isHashTableDeletedValue):
(JSC::DFG::CodeBlockKeyHash::hash):
(JSC::DFG::CodeBlockKeyHash::equal):
(JSC::DFG::ByteCodeCache::ByteCodeCache):
(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/Heap.cpp:
(JSC::Heap::finalizeUnconditionally):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/ListableHandler.h: Added.
(JSC::ListableHandler::ListableHandler):
(JSC::ListableHandler::~ListableHandler):
(JSC::ListableHandler::List::List):
(JSC::ListableHandler::List::addNotThreadSafe):
(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::hasNext):
(JSC::ListableHandler::List::removeNext):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionally):
* heap/MarkStack.h:
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):
* heap/SlotVisitor.h:
* heap/UnconditionalFinalizer.h: Added.
(JSC::UnconditionalFinalizer::~UnconditionalFinalizer):
* heap/WeakReferenceHarvester.h:
(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::profiledCodeBlockFor):
2011-11-10 Gavin Barraclough <barraclough@apple.com>
Add ARMv7 register info for the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72050
Reviewed by Geoff Garen.
* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
2011-11-10 Gavin Barraclough <barraclough@apple.com>
#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
https://bugs.webkit.org/show_bug.cgi?id=72047
Reviewed by Geoff Garen.
We currently don't attempt to abstract divide through the macro assembler,
due to these instructions commonly having specific requirements. This means
there is architecture specific code in the JIT - #ifdef it, and provide a
common implementation.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compile):
2011-11-10 Gavin Barraclough <barraclough@apple.com>
Add ENABLE_VALUE_PROFILER support for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=72043
Reviewed by Geoff Garen.
This requires us to make a bucketCounterRegister available; to do so we'll need to spill more registers on entry to JIT code.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):
- cleanup location of UNUSED_PARAM
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
- Update JITStackFrame structure & asm code to spill more registers.
* jit/JSInterfaceJIT.h:
- Assign a bucketCounterRegister.
2011-11-10 Gavin Barraclough <barraclough@apple.com>
Fix sampling counters on ARMv7, move add64 functionality to macro assembler
https://bugs.webkit.org/show_bug.cgi?id=72040
Reviewed by Geoff Garen.
The ability to add an integer to a uint64_t in memory is poorly copied in
multiple places & ifdef'ed on architecture, addWithCarry32 is also a badly
designed interface since add32 is not required to set flags (we have no
concept of flags in the macro assembler interface).
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add64):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add64):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add64):
* dfg/DFGAssemblyHelpers.cpp:
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitCount):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitCount):
011-11-10 Ryuan Choi <ryuan.choi@samsung.com>
[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
https://bugs.webkit.org/show_bug.cgi?id=56705
Reviewed by Adam Roben.
* CMakeLists.txt:
* PlatformEfl.cmake: Renamed from Source/JavaScriptCore/CMakeListsEfl.txt.
* PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/CMakeListsWinCE.txt.
* shell/CMakeLists.txt:
* shell/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsEfl.txt.
* shell/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsWinCE.txt.
* wtf/CMakeLists.txt:
* wtf/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsEfl.txt.
* wtf/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsWinCE.txt.
2011-11-10 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck build.
* GNUmakefile.list.am: Add missing files.
2011-11-09 Michael Saboff <msaboff@apple.com>
Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type
https://bugs.webkit.org/show_bug.cgi?id=71862
Changed LiteralParser to be templatized of character type.
Moved five enums out of class definition to work around a clang compiler defect.
Added lexIdentifier templated method to break out character specific versions.
Added static setParserTokenString templated method to handle setting approriately
sized string pointer.
To keep code in LiteralParser.cpp and keep LiteralParser.h small, the two
flavors of LiteralParser are explicitly instantiated at the end of
LiteralParser.cpp.
Reviewed by Oliver Hunt.
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::isJSONWhiteSpace):
(JSC::::tryJSONPParse):
(JSC::::makeIdentifier):
(JSC::::Lexer::lex):
(JSC::::Lexer::lexIdentifier):
(JSC::::Lexer::next):
(JSC::LChar):
(JSC::UChar):
(JSC::isSafeStringCharacter):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
(JSC::LiteralParser::Lexer::currentToken):
(JSC::LiteralParser::Lexer::getErrorMessage):
* runtime/UString.h:
(JSC::LChar):
(JSC::UChar):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::append):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
2011-11-09 Filip Pizlo <fpizlo@apple.com>
Multiple CodeBlock should be able to share the same instruction
stream without copying
https://bugs.webkit.org/show_bug.cgi?id=71978
Reviewed by Oliver Hunt.
This refactors CodeBlock::m_instructions to be a Vector boxed in a
ref-counted object, but otherwise does not take advantage of this.
This is performance neutral.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::hasInstructions):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):
* jit/JIT.cpp:
(JSC::JIT::JIT):
2011-11-09 Gavin Barraclough <barraclough@apple.com>
Renovate ARMv7 assembler/macro-assembler
https://bugs.webkit.org/show_bug.cgi?id=71982
Reviewed by Geoff Garen.
ARMv7Assembler:
* add support for strb (byte stores)
* rename the VMOV_CtoS opcodes (there are currently backwards!)
* add support for adc (add with carry)
* add support for vsqrt, vabs
* add support for vmov (between FPRs, and to/from GPR pairs).
* remove '_F64' postfixes from instructions (these aren't helpful, functions can already be distinguished by their signatures).
* rename vcvt_F64_S32 to vcvt_signedToFloatingPoint, the prior postfix was unhelpful in failing to distinguish the types (S32 indicates a single precision register, but the type could be float, int32, or uint32).
* rename vcvtr_S32_F64 to vcvt_floatingPointToSigned, as for previous, also vcvtr was the incorrect name for the operation (the emitted instruction truncates).
MacroAssemblerARMv7:
* add 3-operand versions of and32, lshift32, or32, rshift32, urshift32, sub32, xor32,
* add store8, and store32 imm to base-index.
* fix load32WithCompactAddressOffsetPatch to work for all gprs (the fix is a little kludgy but functional; to do better we'll have to also fix the repatching code).
* Update supportsFloating* flags (all features now supported).
* add moveDouble, storeDouble to absolute address, addDouble to absolute address
* add 3-operand double operations.
* implement sqrtDouble/absDouble
* add branchTruncateDoubleToInt32, implement truncateDoubleToInt32
* move should do nothing if src == dest
* branchTest8-on-memory can be implemented in terms of branchTest32-on-register (branchTest8-on-register has been removed).
* add 3-operand branchAdd32, branchSub32, also branchAdd32 absolute address.
2011-11-09 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=71873
Reviewed by Geoff Garen.
Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
2011-11-09 Filip Pizlo <fpizlo@apple.com>
DFG OSR exit code should be lazily generated
https://bugs.webkit.org/show_bug.cgi?id=71744
Reviewed by Gavin Barraclough.
The OSR exit code is now generated the first time it is executed,
rather than right after speculative compilation. Because most OSR
exits are never taken, this should greatly reduce both code size
and compilation time.
This is a 1% win on SunSpider, and a 1% win on V8 when running in
my harness. No change in V8 in V8's harness (due to the long runs,
so compile time is not an issue) and no change in Kraken (again,
long runs of small code so compile time has no measurable effect).
* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::jump):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::jump):
* assembler/X86Assembler.h:
(JSC::X86Assembler::jmp_m):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::createDFGDataIfNecessary):
(JSC::CodeBlock::appendDFGOSREntryData):
(JSC::CodeBlock::numberOfDFGOSREntries):
(JSC::CodeBlock::dfgOSREntryData):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(JSC::CodeBlock::numberOfOSRExits):
(JSC::CodeBlock::numberOfSpeculationRecoveries):
(JSC::CodeBlock::osrExit):
(JSC::CodeBlock::speculationRecovery):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGCorrectableJumpPoint.cpp: Added.
(JSC::DFG::CorrectableJumpPoint::codeLocationForRepatch):
* dfg/DFGCorrectableJumpPoint.h: Added.
(JSC::DFG::CorrectableJumpPoint::CorrectableJumpPoint):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
(JSC::DFG::CorrectableJumpPoint::correctInitialJump):
(JSC::DFG::CorrectableJumpPoint::correctLateJump):
(JSC::DFG::CorrectableJumpPoint::initialJump):
(JSC::DFG::CorrectableJumpPoint::lateJump):
(JSC::DFG::CorrectableJumpPoint::correctJump):
(JSC::DFG::CorrectableJumpPoint::getJump):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp: Added.
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.cpp: Added.
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
* dfg/DFGThunks.cpp: Added.
(JSC::DFG::osrExitGenerationThunkGenerator):
* dfg/DFGThunks.h: Added.
* jit/JITCode.h:
(JSC::JITCode::dataAddressAtOffset):
* runtime/JSGlobalData.h:
2011-11-09 Mark Hahnenberg <mhahnenberg@apple.com>
Fixing build breakage
Unreviewed build fix
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-11-09 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSVariableObject::isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=71933
Reviewed by Geoffrey Garen.
* runtime/JSActivation.cpp:
* runtime/JSActivation.h: Inlined and de-virtualized isDynamicScope
(JSC::JSActivation::isDynamicScope):
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h: Inlined and de-virtualized isDynamicScope
(JSC::JSGlobalObject::isDynamicScope):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h: Inlined and de-virtualized isDynamicScope
(JSC::JSStaticScopeObject::createStructure): Changed createStructure to use new JSType
(JSC::JSStaticScopeObject::isDynamicScope):
* runtime/JSType.h: Added new type for JSStaticScopeObject
* runtime/JSVariableObject.cpp: De-virtualized and added an implementation that checks the
object's type and calls the corresponding implementation.
(JSC::JSVariableObject::isDynamicScope):
* runtime/JSVariableObject.h:
2011-11-09 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSGlobalObject::hasOwnPropertyForWrite
https://bugs.webkit.org/show_bug.cgi?id=71934
Reviewed by Geoffrey Garen.
* runtime/JSGlobalObject.h: Removed the virtual-ness of hasOwnPropertyForWrite since nobody overrides it.
2011-11-09 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=71873
Reviewed by Geoff Garen.
Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::absDouble):
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::absDouble):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::absDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::absDouble):
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::absDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):
2011-11-09 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71523
Reviewed by Sam Weinig.
Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyDescriptor):
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
* runtime/ClassInfo.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/DatePrototype.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyDescriptor):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyDescriptor):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertyDescriptor):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::vtableAnchor):
(JSC::JSObject::propertyIsEnumerable):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSString.cpp: Removed getOwnPropertyDescriptor, since this seems to be a relic from a
bygone era when getOwnPropertyDescriptor was rooted in JSCell rather than JSObject. There were
no call sites for this version of getOwnPropertyDescriptor in the entire project.
* runtime/JSString.h:
* runtime/Lookup.h:
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptor):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertyDescriptor):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::vtableAnchor): Added to prevent a weak vtable.
(JSC::StringObject::getOwnPropertyDescriptor):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/StringPrototype.h:
2011-11-09 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=71873
Reviewed by Geoff Garen.
Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):
2011-11-08 Darin Adler <darin@apple.com>
Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
https://bugs.webkit.org/show_bug.cgi?id=71875
Reviewed by Anders Carlsson.
This is a step along the path of making OwnPtr work as HashMap value types.
* wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.
Also fixed include style. To include other WTF headers inside WTF, we use "" includes.
I did not change the code to fix style checker complaints.
* wtf/HashTable.h: Added includes as needed and fixed include style.
(WTF::doubleHash): Removed the uneeeded and inappropriate "static" in this function, which
gave it internal linkage for no good reason.
(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
construction/destruction problems instead of doing the trick where we construct and destroy
an empty value twice. It's cleaner and simpler and avoids copying the empty value.
(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
empty value is zero rather than copying an empty value.
* wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.
2011-11-09 Gabor Rapcsanyi <rgabor@webkit.org>
Buildfix for 32bit debug mode.
Reviewed by Csaba Osztrogonác.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::dump):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
2011-11-09 Andy Wingo <wingo@igalia.com>
Enable the DFG JIT on X86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373
Reviewed by Csaba Osztrogonác.
* wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the
x86-64 GNU/Linux platform.
* CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.
2011-11-09 Csaba Osztrogonác <ossy@webkit.org>
Enable the DFG JIT on x86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373
Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686
Buildfix for stricter compilers: -Werror=unused-but-set-variable
Reviewed by Zoltan Herczeg.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r99678.
http://trac.webkit.org/changeset/99678
https://bugs.webkit.org/show_bug.cgi?id=71882
broke the build with -Werror=unused-but-set-variable
(Requested by tronical_ on #webkit).
* CMakeListsEfl.txt:
* wtf/Platform.h:
2011-11-09 Andy Wingo <wingo@igalia.com>
Enable the DFG JIT on X86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373
Reviewed by Filip Pizlo.
* wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the
x86-64 GNU/Linux platform.
* CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.
2011-11-09 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=71429
Reviewed by Geoffrey Garen.
Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Arguments.cpp:
(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defineOwnProperty):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperty):
(JSC::defineProperties):
2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Build system cleanup
https://bugs.webkit.org/show_bug.cgi?id=71815
Reviewed by Kenneth Rohde Christiansen.
* wtf/wtf.pri: Moved the glib dependency to javascriptcore.prf.
2011-11-08 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Replace use of QApplication with QGuiApplication
https://bugs.webkit.org/show_bug.cgi?id=71794
Reviewed by Andreas Kling.
Add compat headers for use when building with Qt 4: QGuiApplication
is typedef'ed to QApplication.
* wtf/qt/compat/QGuiApplication: Added.
* wtf/qt/compat/qguiapplication.h: Added.
2011-11-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r99647.
http://trac.webkit.org/changeset/99647
https://bugs.webkit.org/show_bug.cgi?id=71876
It broke jsc and layout tests on all bot (Requested by
Ossy_night on #webkit).
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsDoubleBitops):
(JSC::MacroAssemblerARM::andnotDouble):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsDoubleBitops):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::andnotDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsDoubleBitops):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsDoubleBitops):
(JSC::MacroAssemblerSH4::andnotDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::MacroAssemblerX86):
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsDoubleBitops):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::andnotDouble):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsDoubleBitops):
* assembler/X86Assembler.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):
* runtime/JSGlobalData.cpp:
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Better abstract 'abs' operation through the MacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=71873
Reviewed by Geoff Garen.
Currently the x86 specific instruction sequence to perform a double abs
is duplicated throughout the JITs / thunk generators.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):
(JSC::MacroAssemblerARM::absDouble):
- Renamed supportsFloatingPointAbs, make these methods static so that
we can check the JIT's capabilites before we begin compilation.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):
- Renamed supportsFloatingPointAbs, make these methods static so that
we can check the JIT's capabilites before we begin compilation.
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::absDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):
- Renamed supportsFloatingPointAbs, make these methods static so that
we can check the JIT's capabilites before we begin compilation.
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
(JSC::MacroAssemblerSH4::absDouble):
- Renamed supportsFloatingPointAbs, make these methods static so that
we can check the JIT's capabilites before we begin compilation.
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::absDouble):
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):
- Made supports* methods static so that we can check the JIT's
capabilites before we begin compilation. Added absDouble.
* assembler/MacroAssemblerX86Common.h:
- Removed andnotDouble, added s_maskSignBit.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::absDouble):
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):
- Made supports* methods static so that we can check the JIT's
capabilites before we begin compilation. Added absDouble.
* assembler/X86Assembler.h:
(JSC::X86Assembler::andpd_rr):
(JSC::X86Assembler::andpd_mr):
- Added support for andpd instruction.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- Added checks for supportsFloatingPointAbs, supportsFloatingPointSqrt.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Switched to use doubleAbs, we can now also reuse the operand register for the result.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Switched to use doubleAbs, we can now also reuse the operand register for the result.
* jit/ThunkGenerators.cpp:
- Switched to use doubleAbs.
(JSC::absThunkGenerator):
* runtime/JSGlobalData.cpp:
- Declared MacroAssemblerX86Common::s_maskSignBit here.
This is a little ugly, but it doesn't seem worth adding a whole extra .cpp
to the compile for just one constant.
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Move duplicates of SYMBOL_STRING* macros to the single location
https://bugs.webkit.org/show_bug.cgi?id=71456
Reviewed by Sam Weinig.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
* wtf/InlineASM.h: Added.
- Moved asm related macros.
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Move code to handle 8bit regs from X86Assembler to MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=71867
Reviewed by Oliver Hunt.
This code is fine, but is in the wrong place really. X86 assembler should
basically just format up exactly the instruction you request - not expand
out to a set of instructions (that is what the macro assembler layer is
for!). For other 8-bit ops, on X86 we don't guard against clients accessing
the XH registers.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movb_rm):
- moved some code.
2011-11-08 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for GTK.
* GNUmakefile.list.am:
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Build fix.
* assembler/X86Assembler.h:
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Errrk, failed to commit this in last change.
* assembler/X86Assembler.h:
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Remove an unused method.
Rubber stamped by Geoff Garen.
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBuffer.h:
- removed rewindToLabel.
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Fix OSR entry points to calculate offsets correctly WRT to branch compaction.
https://bugs.webkit.org/show_bug.cgi?id=71864
Reviewed by Filip Pizlo.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::offsetOf):
- We use this to return the offsets into the code of the entry points.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- Move the construction of the speculative JIT outside of
compileBody, such that it is still available to link the
OSR entry points at the point we are linking.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- Pass the label of the block & linkbuffer into noticeOSREntry.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
- Moved call to noticeOSREntry until we we linking.
* dfg/DFGSpeculativeJIT.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- Moved calculation of entries until we we linking.
* jit/JIT.h:
- Removed some members.
2011-11-08 Filip Pizlo <fpizlo@apple.com>
DFG OSR exit code should be generated by a separate compiler, not
related to DFG::JITCompiler
https://bugs.webkit.org/show_bug.cgi?id=71787
Reviewed by Gavin Barraclough.
Moves the exitSpeculativeWithOSR() method from JITCompiler to
OSRExitCompiler::compileExit().
* CMakeListsEfl.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
* dfg/DFGJITCompiler32_64.cpp: Removed.
* dfg/DFGOSRExitCompiler.h: Added.
(JSC::DFG::OSRExitCompiler::OSRExitCompiler):
* dfg/DFGOSRExitCompiler32_64.cpp: Added.
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp: Added.
(JSC::DFG::OSRExitCompiler::compileExit):
* runtime/JSValue.h:
2011-11-08 Filip Pizlo <fpizlo@apple.com>
Basic DFG definitions should be moved out of DFGNode.h
https://bugs.webkit.org/show_bug.cgi?id=71861
Rubber-stamped by Gavin Barraclough.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGCommon.h: Added.
(JSC::DFG::NodeIndexTraits::defaultValue):
* dfg/DFGNode.h:
* dfg/DFGOSRExit.h:
* dfg/DFGRegisterBank.h:
2011-11-08 Michael Saboff <msaboff@apple.com>
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761
Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.
Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.
To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.
Reviewed by Gavin Barraclough.
* interpreter/Interpreter.cpp:
(JSC::appendSourceToError):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::sourceCode):
* parser/Parser.cpp:
(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
* parser/Parser.h:
(JSC::::parse):
(JSC::parse):
* parser/SourceCode.h:
(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
2011-11-08 Gavin Barraclough <barraclough@apple.com>
Fix PropertyAccessRecords in DFG JIT to take account of branch compaction.
https://bugs.webkit.org/show_bug.cgi?id=71855
Reviewed by Filip Pizlo.
The DFG JIT presently calculates a set of offsets early, before branches have been compacted.
This won't work on ARMv7.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::differenceBetweenCodePtr):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::locationOf):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::JITCompiler::addPropertyAccess):
2011-11-08 Gavin Barraclough <barraclough@apple.com>
DFG JIT calculation of OSR entry points is not THUMB2 safe
https://bugs.webkit.org/show_bug.cgi?id=71852
Reviewed by Oliver Hunt.
Executable addresses are tagged with a low bit set to distinguish
between THUMB2 and traditional ARM.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* jit/JITCode.h:
(JSC::JITCode::executableAddressAtOffset):
(JSC::JITCode::start):
(JSC::JITCode::size):
2011-11-08 Michael Saboff <msaboff@apple.com>
JSC::Parser::Parser leaks Lexer member
https://bugs.webkit.org/show_bug.cgi?id=71847
Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.
Reviewed by Oliver Hunt.
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::parseFunctionBody):
* parser/Parser.h:
2011-11-08 Yuqiang Xian <yuqiang.xian@intel.com>
Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686
Reviewed by Filip Pizlo.
We can get 9% on SunSpider, 89% on Kraken and 37% on V8, on Linux X86.
* wtf/Platform.h:
2011-11-08 Yuqiang Xian <yuqiang.xian@intel.com>
DFG 32_64 - update make lists for efl, gtk, and Qt ports with DFG change r99519
https://bugs.webkit.org/show_bug.cgi?id=71768
Reviewed by Geoffrey Garen.
Also includes a fix to make the newly introduced AssemblyHelpers
friend of JSValue as we need the Tag definitions.
* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* Target.pri:
* runtime/JSValue.h:
2011-11-07 Yuqiang Xian <yuqiang.xian@intel.com>
Fix gcc 4.4 compilation warnings in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71762
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::registersMatched):
2011-11-07 Filip Pizlo <fpizlo@apple.com>
DFG code base should allow for classes not related to DFG::JITCompiler
to use DFG idioms
https://bugs.webkit.org/show_bug.cgi?id=71746
Reviewed by Gavin Barraclough.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAssemblyHelpers.cpp: Added.
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
* dfg/DFGAssemblyHelpers.h: Added.
* dfg/DFGJITCompiler.cpp:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::graph):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGOSRExit.h: Added.
(JSC::DFG::SpeculationRecovery::SpeculationRecovery):
(JSC::DFG::SpeculationRecovery::type):
(JSC::DFG::SpeculationRecovery::dest):
(JSC::DFG::SpeculationRecovery::src):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::isVariable):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):
* dfg/DFGSpeculativeJIT.h:
2011-11-07 Filip Pizlo <fpizlo@apple.com>
Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
but it appears to help on other benchmarks.
Rubber stamped by Oliver Hunt.
* bytecode/ValueProfile.h:
2011-11-07 Ariya Hidayat <ariya@sencha.com>
"use strict" can not contain escape sequences or line continuation
https://bugs.webkit.org/show_bug.cgi?id=71532
Reviewed by Darin Adler.
Store the actual literal length (before the escapes and line
continuation are encoded) while parsing the directive and use it
for the directive comparison.
* parser/Parser.cpp:
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseStatement):
* parser/Parser.h:
2011-11-06 Filip Pizlo <fpizlo@apple.com>
DFG operationCreateThis slow path may get the wrong callee in case of inlining
https://bugs.webkit.org/show_bug.cgi?id=71647
Reviewed by Oliver Hunt.
No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-07 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71716
Reviewed by Darin Adler.
Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::putWithAttributes):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putWithAttributes):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putWithAttributes):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::putWithAttributes):
* runtime/JSVariableObject.h:
2011-11-07 Dmitry Lomov <dslomov@google.com>
Unreviewed. Release build fix.
* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):
2011-11-07 Filip Pizlo <fpizlo@apple.com>
Switch the value profiler back to 8 buckets, because we suspect that while this
is more expensive it's also more stable.
Rubber stamped by Geoff Garen.
* bytecode/ValueProfile.h:
2011-11-07 Andrew Wason <rectalogic@rectalogic.com>
Uninitialized Heap member var
https://bugs.webkit.org/show_bug.cgi?id=71722
Reviewed by Filip Pizlo.
* heap/Heap.cpp:
(JSC::Heap::Heap): Initialize m_blockFreeingThreadShouldQuit
2011-11-07 Yuqiang Xian <yuqiang.xian@intel.com>
DFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible
https://bugs.webkit.org/show_bug.cgi?id=71684
Reviewed by Filip Pizlo.
Currently in DFG JIT, we try to reuse the physical register of an
operand for temporary usage if the current use of the operand is the
last use. But sometimes this can be wrong, for example if there are
possible speculation failures and we need to fallback to baseline JIT,
the value of the operand which is supposed to be hold in the physical
register can be modified by register reusing. The fixes the last
inspector failures in layout test on Mac 32-bit if switching on DFG.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
2011-11-07 Ryosuke Niwa <rniwa@webkit.org>
REGRESSION(r99436): Broke Snow Leopard debug build
https://bugs.webkit.org/show_bug.cgi?id=71713
Reviewed by Darin Adler.
Put the assertion in a template and use template specialization
to avoid warning when instantiated with UChar or LChar.
In the long term, we should have traits for unsigned integral types
and use that to specialize template instead of specializing it for UChar and LChar.
* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):
(JSC::::append8):
2011-11-07 ChangSeok Oh <shivamidow@gmail.com>
[EFL] Support requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=67112
Reviewed by Andreas Kling.
Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.
* wtf/Platform.h:
2011-11-07 Michael Saboff <msaboff@apple.com>
Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
https://bugs.webkit.org/show_bug.cgi?id=71331
Change the Lexer class to be a template class based on the character
type of the source. In the process updated the parseIdentifier()
and parseString() methods to create 8 bit strings where possible.
Also added some helper methods for accumulating temporary string
data in the 8 and 16 bit vectors.
Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.
Updated the KeywordLookup generator to create code to match keywords
for both 8 and 16 bit source strings.
Due to a compiler bug (<rdar://problem/10194295>) moved enum
definition outside of Lexer class declaration. Remove second enum
no longer needed.
Reviewed by Darin Adler.
* KeywordLookupGenerator.py:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* parser/Lexer.cpp:
(JSC::::Lexer):
(JSC::::~Lexer):
(JSC::::getInvalidCharMessage):
(JSC::::currentCharacter):
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::peek):
(JSC::::getUnicodeCharacter):
(JSC::::shiftLineTerminator):
(JSC::::lastTokenWasRestrKeyword):
(JSC::::record8):
(JSC::::append8):
(JSC::::append16):
(JSC::::record16):
(JSC::::parseIdentifier):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::parseHex):
(JSC::::parseOctal):
(JSC::::parseDecimal):
(JSC::::parseNumberAfterDecimalPoint):
(JSC::::parseNumberAfterExponentIndicator):
(JSC::::parseMultilineComment):
(JSC::::nextTokenIsColon):
(JSC::::lex):
(JSC::::scanRegExp):
(JSC::::skipRegExp):
(JSC::::clear):
(JSC::::sourceCode):
* parser/Lexer.h:
(JSC::Lexer::append16):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffsetFromCharOffset):
(JSC::::isWhiteSpace):
(JSC::::isLineTerminator):
(JSC::::convertHex):
(JSC::::convertUnicode):
(JSC::::makeIdentifier):
(JSC::::setCodeStart):
(JSC::::makeIdentifierLCharFromUChar):
(JSC::::lexExpectIdentifier):
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::parseProperty):
(JSC::Parser::parseMemberExpression):
* parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
* parser/ParserArena.h:
(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):
* parser/SourceCode.h:
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::stringData):
* parser/SourceProviderCache.h:
* parser/SyntaxChecker.h:
* runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
* runtime/Identifier.cpp:
(JSC::IdentifierTable::add):
(JSC::IdentifierLCharFromUCharTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::equal):
(JSC::IdentifierLCharFromUCharTranslator::translate):
(JSC::Identifier::add8):
* runtime/Identifier.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::createLCharFromUChar):
(JSC::Identifier::canUseSingleCharacterString):
(JSC::IdentifierCharBufferTranslator::hash):
(JSC::IdentifierCharBufferTranslator::equal):
(JSC::IdentifierCharBufferTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::equal):
(JSC::IdentifierTable::add):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode):
(JSC::parseIntOverflow):
(JSC::globalFuncUnescape):
* runtime/JSGlobalObjectFunctions.h:
(JSC::parseIntOverflow):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lexString):
* wtf/text/StringImpl.h:
2011-11-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
Allows us to not package up the whole Source/JavaScriptCore directory for the
buildbots.
Reviewed-by Simon Hausmann.
* jsc.pro:
2011-11-06 Filip Pizlo <fpizlo@apple.com>
REGRESSION(r99374): GTK+ build of the jsc binary doesn't like the call
to initializeMainThread, and crashes
https://bugs.webkit.org/show_bug.cgi?id=71643
Reviewed by Sam Weinig.
* jsc.cpp:
(main):
2011-11-06 Sam Weinig <sam@webkit.org>
Add space missing from some class declarations
https://bugs.webkit.org/show_bug.cgi?id=71632
Reviewed by Anders Carlsson.
* assembler/AssemblerBufferWithConstantPool.h:
* bytecode/CodeBlock.h:
* dfg/DFGVariableAccessData.h:
* heap/VTableSpectrum.h:
* jit/ExecutableAllocator.cpp:
* jit/ExecutableAllocatorFixedVMPool.cpp:
* wtf/MetaAllocatorHandle.h:
* wtf/UnionFind.h:
2011-11-06 Sam Weinig <sam@webkit.org>
Allow use of FINAL in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71630
Reviewed by Anders Carlsson.
* Configurations/Base.xcconfig:
Don't warn about C++11 extensions used in C++98 mode.
2011-11-05 Filip Pizlo <fpizlo@apple.com>
Value profiling should just use two buckets
https://bugs.webkit.org/show_bug.cgi?id=71619
Reviewed by Gavin Barraclough.
Added one more configuration options (like Heuristics::minimumOptimizationDelay),
improved debugging in JIT optimization support, changed the number of buckets
in the value profile from 9 to 2, and wrote a more optimal value profiling path
in the old JIT to take advantage of this. It's still possible to play around with
larger numbers of buckets, and we should probably keep this for a little while
until we convince ourselves that using just two buckets is the right call.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/ValueProfile.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
2011-11-03 Filip Pizlo <fpizlo@apple.com>
JSC should be able to sample itself in a more flexible way than just sampling flags
https://bugs.webkit.org/show_bug.cgi?id=71522
Reviewed by Gavin Barraclough.
Added a construct that looks like SamplingRegion samplingRegion("name").
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.cpp:
(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
(JSC::SamplingRegion::sample):
(JSC::SamplingRegion::dump):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingThread::threadStartFunc):
* bytecode/SamplingTool.h:
(JSC::SamplingRegion::SamplingRegion):
(JSC::SamplingRegion::~SamplingRegion):
(JSC::SamplingRegion::exchangeCurrent):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/VTableSpectrum.cpp:
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::dump):
* heap/VTableSpectrum.h:
* jsc.cpp:
(main):
(runWithScripts):
* parser/Parser.h:
(JSC::parse):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* wtf/Atomics.h:
(WTF::weakCompareAndSwap):
* wtf/Platform.h:
* wtf/Spectrum.h: Added.
(WTF::Spectrum::Spectrum):
(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::begin):
(WTF::Spectrum::end):
(WTF::Spectrum::KeyAndCount::KeyAndCount):
(WTF::Spectrum::KeyAndCount::operator<):
(WTF::Spectrum::buildList):
* wtf/wtf.pri:
2011-11-05 Sam Weinig <sam@webkit.org>
Fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-11-04 Sam Weinig <sam@webkit.org>
Reduce the number of putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71597
Reviewed by Adam Roben.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Remove exports of removed functions.
* runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
Calling the overload without the extra parameters does the same thing.
* runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
* runtime/JSObject.h:
Remove four unused JSObject::putWithAttributes overloads and make one of the remaining
two overloads not virtual, since no one overrides it.
2011-11-04 Pratik Solanki <psolanki@apple.com>
sqrtDouble and andnotDouble should be declared noreturn
https://bugs.webkit.org/show_bug.cgi?id=71592
Reviewed by Sam Weinig.
* assembler/MacroAssemblerARMv7.h:
2011-11-04 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430
Reviewed by Darin Adler.
Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:
2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Refactor and clean up the qmake build system
The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.
This is a short-list of the changes:
* The rules for how to build targets are now mostly contained as
prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
allows us to do pre- and post-processing of each project file,
which helps to clean up the actual project files.
* Derived sources are no longer generated as a separate make-step
but is part of each target's project file as a subdir. Makefile
rules are used to ensure that we run make on the derived sources
before running qmake on the actual target makefile. This makes
it easier to keep a proper dependency between derived sources
and the target.
* We use GNU make and the compiler to generate dependencies on
UNIX-based systems running Qt 5. This allows us to lessen the
need to run qmake, which should reduce compile time.
* WebKit2 is now build by default if building with Qt 5. It can
be disabled by passing --no-webkit2 to build-webkit.
The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.
https://bugs.webkit.org/show_bug.cgi?id=71222
Reviewed by Simon Hausmann.
* DerivedSources.pri: Added.
* DerivedSources.pro: Removed.
* JavaScriptCore.pro:
* Target.pri: Copied from Source/JavaScriptCore/JavaScriptCore.pro.
* headers.pri: Removed.
* jsc.pro:
* wtf/wtf.pri:
* yarr/yarr.pri:
2011-11-04 Yuqiang Xian <yuqiang.xian@intel.com>
More code clean-up in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71540
Remove unnecessary code duplications, and fix compilation warnings.
Reviewed by Gavin Barraclough.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-04 Csaba Osztrogonác <ossy@webkit.org>
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430
Unreviewed rolling out r99238, because it made a test crash on all platform.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:
2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71306
Reviewed by Darin Adler.
Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getPropertyNames):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
* runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
* runtime/Structure.h:
2011-11-03 Darin Adler <darin@apple.com>
Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422
* wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.
2011-11-02 Darin Adler <darin@apple.com>
Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422
* wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.
2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430
Reviewed by Darin Adler.
Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:
2011-11-03 Filip Pizlo <fpizlo@apple.com>
JIT-specific code should be able to refer to register types even on JIT-disabled builds
https://bugs.webkit.org/show_bug.cgi?id=71498
Reviewed by Gavin Barraclough.
* assembler/MacroAssembler.h:
(MacroAssembler::MacroAssembler):
2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::className
https://bugs.webkit.org/show_bug.cgi?id=71428
Reviewed by Sam Weinig.
Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::className):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::className):
* debugger/DebuggerActivation.h:
* jsc.cpp:
(GlobalObject::createStructure):
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::className):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::className):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* testRegExp.cpp:
(GlobalObject::createStructure):
2011-11-02 Jer Noble <jer.noble@apple.com>
Add Clock class and platform-specific implementations.
https://bugs.webkit.org/show_bug.cgi?id=71341
Reviewed by Sam Weinig.
Add WTF_USE_COREAUDIO macro for use by PlatformClockCA.
* wtf/Platform.h:
2011-11-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing win build. step2.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-11-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fix windows build, step1
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-11-03 Pavel Feldman <pfeldman@google.com>
Web Inspector: preserve script location for inline handlers.
https://bugs.webkit.org/show_bug.cgi?id=71367
Makes SourceCode factories receive TextPosition instead of the line number;
Stores consistent position values in SourceCode and SourceProvider;
Reviewed by Yury Semikhatsky.
* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* API/JSObjectRef.cpp:
(JSObjectMakeFunction):
* parser/SourceCode.h:
(JSC::makeSource):
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::startPosition):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::UStringSourceProvider):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionConstructor.h:
2011-11-03 Kentaro Hara <haraken@chromium.org>
Fixed wrong implementation of doubleValue % 2^{64}.
https://bugs.webkit.org/show_bug.cgi?id=67980
Reviewed by Hajime Morita.
fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2^{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.
* wtf/MathExtras.h:
(doubleToInteger): Implemented the spec correctly.
2011-11-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r99089.
http://trac.webkit.org/changeset/99089
https://bugs.webkit.org/show_bug.cgi?id=71448
@plt postfix for math functions cause crash on Linux 32 (the
symbol is defined but it points to NULL) (Requested by
zherczeg on #webkit).
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
* jit/ThunkGenerators.cpp:
2011-11-02 Filip Pizlo <fpizlo@apple.com>
DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436
Reviewed by Oliver Hunt.
This makes inlined arguments retrieval use some of the same machinery as
OSR to determine where from, and how, to retrieve a value that the DFG
might have somehow squirreled away while the old JIT would put it in its
obvious location, using an obvious format.
To that end, previously DFG-internal notions such as DataFormat,
VirtualRegister, and ValueRecovery are now in bytecode/ since they are
stored as part of InlineCallFrames.
* bytecode/CodeOrigin.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::inlineCallFrame):
* interpreter/Register.h:
(JSC::Register::asInlineCallFrame):
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):
* runtime/Arguments.h:
(JSC::Arguments::finishCreationAndCopyRegisters):
2011-11-02 Filip Pizlo <fpizlo@apple.com>
ValueRecovery should be moved out of the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=71439
Reviewed by Oliver Hunt.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/DataFormat.h: Added.
(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSFormat):
(JSC::isJSInteger):
(JSC::isJSDouble):
(JSC::isJSCell):
(JSC::isJSBoolean):
* bytecode/ValueRecovery.h: Added.
(JSC::ValueRecovery::ValueRecovery):
(JSC::ValueRecovery::alreadyInRegisterFile):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::technique):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::tagGPR):
(JSC::ValueRecovery::payloadGPR):
(JSC::ValueRecovery::fpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
* bytecode/VirtualRegister.h: Added.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isJSFormat):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGVariableAccessData.h:
2011-11-02 Sam Weinig <sam@webkit.org>
Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter
https://bugs.webkit.org/show_bug.cgi?id=71333
Reviewed by Gavin Barraclough.
Tested by fast/dom/getter-on-window-object2.html
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
The attributes returned from Structure::get do not include Getter or Setter, so
instead check if the value is a GetterSetter like we do elsewhere. If it is, update
the descriptor's attributes accordingly.
2011-11-02 Yuqiang Xian <yuqiang.xian@intel.com>
FunctionPtr should accept FASTCALL functions on X86
https://bugs.webkit.org/show_bug.cgi?id=71434
Reviewed by Filip Pizlo.
On X86 we sometimes use FASTCALL convention functions, for example the
cti functions, and we may need the pointers to such functions, e.g.,
in current DFG register file check and arity check, though long term
we may avoid such usage of cti calls in DFG.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
2011-11-02 Filip Pizlo <fpizlo@apple.com>
Inlined uses of the global object should use the right global object
https://bugs.webkit.org/show_bug.cgi?id=71427
Reviewed by Oliver Hunt.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::globalObjectFor):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-11-02 Yuqiang Xian <yuqiang.xian@intel.com>
Remove some unnecessary loads/stores in DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=71090
Reviewed by Filip Pizlo.
In fillSpeculateCell and OSR exit, some unnecessary loads/stores can
be eliminated.
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
2011-11-02 Adam Klein <adamk@chromium.org>
Replace usage of StringImpl with String where possible in CharacterData and Text
https://bugs.webkit.org/show_bug.cgi?id=71383
Reviewed by Darin Adler.
* wtf/text/WTFString.h:
(WTF::String::containsOnlyWhitespace): Added new method.
2011-11-02 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71307
Reviewed by Darin Adler.
Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyNames):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyNames):
* runtime/Arguments.h:
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertyNames):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertyNames):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyNames):
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyNames):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::~JSVariableObject):
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSVariableObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::defineProperties):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringObject.h:
* runtime/Structure.h:
2011-11-02 Dean Jackson <dino@apple.com>
Add ENABLE_CSS_SHADERS flag
https://bugs.webkit.org/show_bug.cgi?id=71394
Reviewed by Sam Weinig.
* Configurations/FeatureDefines.xcconfig:
2011-11-02 Alexey Shabalin <a.shabalin@gmail.com>
TEXTREL in libjavascriptcoregtk-1.0.so.0.11.0 on x86 (or i586)
https://bugs.webkit.org/show_bug.cgi?id=70610
Reviewed by Martin Robinson.
Properly annotate ASM on BSD and Linux x86 systems.
* dfg/DFGOperations.cpp: Add annotation for X86.
* jit/JITStubs.cpp: Ditto.
* jit/ThunkGenerators.cpp: Ditto.
2011-11-02 Xianzhu Wang <wangxianzhu@chromium.org>
Missing Force8BitConstructor in 8-bit version of StringImpl::reallocate()
https://bugs.webkit.org/show_bug.cgi?id=71347
Reviewed by Geoffrey Garen.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate):
2011-11-01 Darin Adler <darin@apple.com>
Cut down on malloc/free a bit in the parser arena
https://bugs.webkit.org/show_bug.cgi?id=71343
Reviewed by Oliver Hunt.
* parser/ParserArena.cpp:
(JSC::ParserArena::deallocateObjects): Call the destructors of
the deletable objects before freeing the pools. Don't call
fastFree on the deletable objects any more.
* parser/ParserArena.h:
(JSC::ParserArena::allocateDeletable): Use allocateFreeable
instead of fastMalloc here.
2011-11-01 Sam Weinig <sam@webkit.org>
Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71336
Reviewed by Darin Adler.
* debugger/DebuggerActivation.cpp:
* debugger/DebuggerActivation.h:
Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.
* runtime/JSObject.cpp:
(JSC::JSObject::lookupGetter):
(JSC::JSObject::lookupSetter):
* runtime/JSObject.h:
De-virtualize lookupGetter/lookupSetter, and implement them in terms of
getPropertyDescriptor.
2011-11-01 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::defineSetter
https://bugs.webkit.org/show_bug.cgi?id=71303
Reviewed by Darin Adler.
Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineSetter):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defineSetter):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineSetter):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineSetter):
2011-11-01 Filip Pizlo <fpizlo@apple.com>
DFG inlining breaks function.arguments
https://bugs.webkit.org/show_bug.cgi?id=71329
Reviewed by Oliver Hunt.
The DFG was forgetting to store code origin mappings for inlined
call sites. Some of the fast-path optimizations for
CallFrame::trueCallerFrame() were wrong. An assertion in Arguments
was wrong.
I also took the opportunity to decrease code duplication between
DFG64 and DFG32_64, because I didn't feel like writing the same
code twice.
* bytecode/CodeBlock.h:
(JSC::ExecState::isInlineCallFrame):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGNode.h:
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
2011-11-01 Xianzhu Wang <wangxianzhu@chromium.org>
StringImpl::reallocate() should have a 8-bit version
https://bugs.webkit.org/show_bug.cgi?id=71210
Reviewed by Geoffrey Garen.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate):
* wtf/text/StringImpl.h:
2011-10-31 Filip Pizlo <fpizlo@apple.com>
The GC should be parallel
https://bugs.webkit.org/show_bug.cgi?id=70995
Reviewed by Geoff Garen.
Added parallel tracing to the GC. This works by having local mark
stacks per thread, and a global shared one. Threads sometimes
donate cells from the mark stack to the global one if the heuristics
tell them that it's affordable to do so. Threads that have depleted
their local mark stacks try to steal some from the shared one.
Marking is now done using an atomic weak relaxed CAS (compare-and-swap).
This is a 23% speed-up on V8-splay when I use 4 marking threads,
leading to a 3.5% speed-up on V8.
It also appears that this reduces GC pause times on real websites by
more than half.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::~MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::MarkStack::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
* heap/MarkStack.h:
(JSC::MarkStackSegment::data):
(JSC::MarkStackSegment::capacityFromSize):
(JSC::MarkStackSegment::sizeFromCapacity):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::mergeOpaqueRootsIfNecessary):
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::canRemoveLast):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::canDonateSomeCells):
(JSC::MarkStackArray::size):
(JSC::ParallelModeEnabler::ParallelModeEnabler):
(JSC::ParallelModeEnabler::~ParallelModeEnabler):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::testAndSetMarked):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::SlotVisitor):
* heap/WeakReferenceHarvester.h:
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
* wtf/Atomics.h:
(WTF::weakCompareAndSwap):
* wtf/Bitmap.h:
(WTF::::Bitmap):
(WTF::::get):
(WTF::::set):
(WTF::::testAndSet):
(WTF::::testAndClear):
(WTF::::concurrentTestAndSet):
(WTF::::concurrentTestAndClear):
(WTF::::clear):
(WTF::::clearAll):
(WTF::::nextPossiblyUnset):
(WTF::::findRunOfZeros):
(WTF::::count):
(WTF::::isEmpty):
(WTF::::isFull):
* wtf/MainThread.h:
(WTF::isMainThreadOrGCThread):
* wtf/Platform.h:
* wtf/ThreadSpecific.h:
(WTF::::isSet):
* wtf/mac/MainThreadMac.mm:
(WTF::initializeGCThreads):
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146
Reviewed by Sam Weinig.
Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
* runtime/ExceptionHelpers.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defaultValue):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::defaultValue):
* runtime/JSObject.h:
(JSC::JSObject::toPrimitive):
2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com>
Interpreter build fix
Unreviewed build fix
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
2011-10-31 Filip Pizlo <fpizlo@apple.com>
DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202
Reviewed by Oliver Hunt.
Value profiles now have an extra special slot not used by the old JIT's
profiling, which is reserved for OSR exits.
The DFG's OSR exit code now knows which register, node index, and value
profiling site was responsible for the (possibly flawed) information that
led to the OSR failure. This is somewhat opportunistic and imperfect;
if there's a lot of control flow between the value profiling site and the
OSR failure point, then this mechanism simply gives up. It also gives up
if the OSR failure is caused by either known deficiencies in the DFG
(like that we always assume that the index in a strict charCodeAt access
is within bounds) or where the OSR failure would be catalogues and
profiled through other means (like slow case counters).
This patch also adds the notion of a JSValueRegs, which is either a
single register in JSVALUE64 or a pair in JSVALUE32_64. We should
probably move the 32_64 DFG towards using this, since it often makes it
easier to share code between 64 and 32_64.
Also fixed a number of pathologies that this uncovered. op_method_check
didn't have a value profiling site on the slow path. GetById should not
always force OSR exit if it never executed in the old JIT; we may be
able to infer its type if it's a array or string length get. Finally,
these changes benefit from a slight tweak to optimization delay
heuristics (profile fullness is now 0.35 instead of 0.25).
3.8% speed-up on Kraken, mostly due to ~35% on both stanford-crypto-aes
and imaging-darkroom.
* bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::specFailBucket):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::jsValueRegs):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
* dfg/DFGJITCodeGenerator.h:
(JSC::JSValueOperand::jsValueRegs):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::valueProfileFor):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_method_check):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_method_check):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/JSValue.h:
2011-10-31 Sam Weinig <sam@webkit.org>
Remove need for virtual JSObject::unwrappedObject
https://bugs.webkit.org/show_bug.cgi?id=71034
Reviewed by Geoffrey Garen.
* JavaScriptCore.exp:
Update exports.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Add JSGlobalThis.cpp.
* runtime/JSGlobalThis.cpp: Added.
(JSC::JSGlobalThis::visitChildren):
(JSC::JSGlobalThis::unwrappedObject):
* runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::createStructure):
Move underlying object from JSDOMWindowShell down to JSGlobalThis
and corresponding visitChildren method.
* runtime/JSObject.cpp:
(JSC::JSObject::unwrappedObject):
Change unwrappedObject from virtual, to just needing an if check.
* runtime/JSObject.h:
(JSC::JSObject::isGlobalThis):
* runtime/JSType.h:
Add isGlobalThis predicate and type.
2011-10-31 Xianzhu Wang <wangxianzhu@chromium.org>
WTF::StringImpl::create(const char*, unsigned) calls itself
https://bugs.webkit.org/show_bug.cgi?id=71206
The original implementation just calls itself, causing infinite recursion.
Cast the first parameter to const LChar* to fix that.
Reviewed by Ryosuke Niwa.
* wtf/text/StringImpl.h:
(WTF::StringImpl::create):
2011-10-31 Andy Wingo <wingo@igalia.com>
Fix DFG JIT compilation on Linux targets.
https://bugs.webkit.org/show_bug.cgi?id=70904
Reviewed by Darin Adler.
* jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this
macro.
* dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the
simplified definition from jit/JITStubs.cpp.
(FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue):
Use the macro to access trampoline targets through the PLT on PIC
systems, instead of introducing a text relocation. Otherwise, the
library fails to link.
2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSObject::defineGetter
https://bugs.webkit.org/show_bug.cgi?id=71134
Reviewed by Darin Adler.
Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineGetter):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defineGetter):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineGetter):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
2011-10-31 Michael Saboff <msaboff@apple.com>
Towards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=71138
Restructure and movement of Lexer and Parser code.
Moved Lexer and Parser objects out of JSGlobalData.
Added a new ParserTokens class and instance to JSGlobalData that
have JavaScript token related definitions.
Replaced JSGlobalData arguments to Node classes with lineNumber,
as that was the only use of the JSGlobalData.
Combined JSParser and Parser classes into one class,
eliminating JSParser.h and .cpp.
Various supporting #include changes.
These mostly mechanical changes are done in preparation to
making the Lexer and Parser template classes.
Reviewed by Darin Adler.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
* parser/JSParser.cpp: Removed.
* parser/JSParser.h: Removed.
* parser/Lexer.cpp:
(JSC::Keywords::Keywords):
(JSC::Lexer::Lexer):
(JSC::Lexer::~Lexer):
(JSC::Lexer::setCode):
(JSC::Lexer::parseIdentifier):
* parser/Lexer.h:
(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
(JSC::Keywords::~Keywords):
(JSC::Lexer::setIsReparsing):
(JSC::Lexer::isReparsing):
(JSC::Lexer::lineNumber):
(JSC::Lexer::setLastLineNumber):
(JSC::Lexer::lastLineNumber):
(JSC::Lexer::prevTerminator):
(JSC::Lexer::sawError):
(JSC::Lexer::getErrorMessage):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
(JSC::Lexer::convertHex):
(JSC::Lexer::convertUnicode):
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):
* parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ElementNode::ElementNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyNode::PropertyNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::ArgumentsNode::ArgumentsNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::SourceElements::SourceElements):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::ParameterNode::ParameterNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::CaseClauseNode::CaseClauseNode):
(JSC::ClauseListNode::ClauseListNode):
(JSC::CaseBlockNode::CaseBlockNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
* parser/NodeInfo.h:
* parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::Node::lineNo):
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::~Parser):
(JSC::Parser::parseInner):
(JSC::Parser::allowAutomaticSemicolon):
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseVarDeclaration):
(JSC::Parser::parseConstDeclaration):
(JSC::Parser::parseDoWhileStatement):
(JSC::Parser::parseWhileStatement):
(JSC::Parser::parseVarDeclarationList):
(JSC::Parser::parseConstDeclarationList):
(JSC::Parser::parseForStatement):
(JSC::Parser::parseBreakStatement):
(JSC::Parser::parseContinueStatement):
(JSC::Parser::parseReturnStatement):
(JSC::Parser::parseThrowStatement):
(JSC::Parser::parseWithStatement):
(JSC::Parser::parseSwitchStatement):
(JSC::Parser::parseSwitchClauses):
(JSC::Parser::parseSwitchDefaultClause):
(JSC::Parser::parseTryStatement):
(JSC::Parser::parseDebuggerStatement):
(JSC::Parser::parseBlockStatement):
(JSC::Parser::parseStatement):
(JSC::Parser::parseFormalParameters):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::Parser::parseExpressionOrLabelStatement):
(JSC::Parser::parseExpressionStatement):
(JSC::Parser::parseIfStatement):
(JSC::Parser::parseExpression):
(JSC::Parser::parseAssignmentExpression):
(JSC::Parser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::Parser::isBinaryOperator):
(JSC::Parser::parseBinaryExpression):
(JSC::Parser::parseProperty):
(JSC::Parser::parseObjectLiteral):
(JSC::Parser::parseStrictObjectLiteral):
(JSC::Parser::parseArrayLiteral):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseArguments):
(JSC::Parser::parseMemberExpression):
(JSC::Parser::parseUnaryExpression):
* parser/Parser.h:
(JSC::isEvalNode):
(JSC::EvalNode):
(JSC::DepthManager::DepthManager):
(JSC::DepthManager::~DepthManager):
(JSC::ScopeLabelInfo::ScopeLabelInfo):
(JSC::Scope::Scope):
(JSC::Scope::startSwitch):
(JSC::Scope::endSwitch):
(JSC::Scope::startLoop):
(JSC::Scope::endLoop):
(JSC::Scope::inLoop):
(JSC::Scope::breakIsValid):
(JSC::Scope::continueIsValid):
(JSC::Scope::pushLabel):
(JSC::Scope::popLabel):
(JSC::Scope::getLabel):
(JSC::Scope::setIsFunction):
(JSC::Scope::isFunction):
(JSC::Scope::isFunctionBoundary):
(JSC::Scope::declareVariable):
(JSC::Scope::declareWrite):
(JSC::Scope::preventNewDecls):
(JSC::Scope::allowsNewDecls):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::setNeedsFullActivation):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getUncapturedWrittenVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::setStrictMode):
(JSC::Scope::strictMode):
(JSC::Scope::isValidStrictMode):
(JSC::Scope::shadowsArguments):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::ScopeRef::ScopeRef):
(JSC::ScopeRef::operator->):
(JSC::ScopeRef::index):
(JSC::ScopeRef::hasContainingScope):
(JSC::ScopeRef::containingScope):
(JSC::Parser::AllowInOverride::AllowInOverride):
(JSC::Parser::AllowInOverride::~AllowInOverride):
(JSC::Parser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::setPopped):
(JSC::Parser::currentScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::declareWrite):
(JSC::Parser::findCachedFunctionInfo):
(JSC::Parser::isFunctionBodyNode):
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::nextTokenIsColon):
(JSC::Parser::consume):
(JSC::Parser::getToken):
(JSC::Parser::match):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::startLoop):
(JSC::Parser::endLoop):
(JSC::Parser::startSwitch):
(JSC::Parser::endSwitch):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::breakIsValid):
(JSC::Parser::continueIsValid):
(JSC::Parser::pushLabel):
(JSC::Parser::popLabel):
(JSC::Parser::getLabel):
(JSC::Parser::autoSemiColon):
(JSC::Parser::canRecurse):
(JSC::Parser::lastTokenEnd):
(JSC::Parser::DepthManager::DepthManager):
(JSC::Parser::DepthManager::~DepthManager):
(JSC::Parser::parse):
(JSC::parse):
* parser/ParserTokens.h: Added.
(JSC::JSTokenInfo::JSTokenInfo):
* parser/SourceCode.h:
(JSC::SourceCode::subExpression):
* parser/SourceProviderCacheItem.h:
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
2011-10-31 Filip Pizlo <fpizlo@apple.com>
REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
https://bugs.webkit.org/show_bug.cgi?id=71227
Reviewed by Oliver Hunt.
No new tests, since while I can see exactly where the DFG went wrong on the
site in question from looking at the generated machine code, and while I can
certainly believe that such a scenario would happen, I cannot visualize how
to make it happen reproducibly. It requires an odd combination of double
values getting spilled and then refilled, but then reboxed at just the right
time so that the spilled value is an unboxed double while the in-register
value is a boxed double.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
2011-10-30 Filip Pizlo <fpizlo@apple.com>
JSParser::parsePrimaryExpression should have an overflow check
https://bugs.webkit.org/show_bug.cgi?id=71197
Reviewed by Geoff Garen.
* parser/JSParser.cpp:
(JSC::JSParser::parsePrimaryExpression):
2011-10-30 Filip Pizlo <fpizlo@apple.com>
DFG ValueAdd(string, int) should not fail speculation
https://bugs.webkit.org/show_bug.cgi?id=71195
Reviewed by Geoff Garen.
1% speed-up on V8.
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):
2011-10-30 Filip Pizlo <fpizlo@apple.com>
The DFG inliner should not flush the callee
https://bugs.webkit.org/show_bug.cgi?id=71191
Reviewed by Oliver Hunt.
0.6% speed-up on V8.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeOrigin.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrameSlow):
2011-10-28 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
https://bugs.webkit.org/show_bug.cgi?id=70968
Reviewed by Geoffrey Garen.
* API/JSCallbackObject.cpp: Added two specializations for createStructure that use different JSTypes in their
TypeInfo. Had to also create a specialization for JSNonFinalObject, even JSGlobalObject was the only that
needed it because Windows wouldn't build without it.
(JSC::::createStructure):
* API/JSCallbackObject.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ErrorInstance.h: Removed virtual function and changed JSType provided to TypeInfo in createStructure.
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.h: Ditto
(JSC::ErrorPrototype::createStructure):
* runtime/JSActivation.h: Ditto
(JSC::JSActivation::createStructure):
* runtime/JSGlobalObject.h: Ditto
(JSC::JSGlobalObject::createStructure):
* runtime/JSObject.h: De-virtualized functions. They now check the JSType of the object for the corresponding type.
(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):
* runtime/JSType.h: Added new types for GlobalObject, VariableObject, ActivationObject, and ErrorInstance.
* runtime/JSVariableObject.cpp: Removed virtual function.
* runtime/JSVariableObject.h: Changed JSType provided to TypeInfo in createStructure.
(JSC::JSVariableObject::createStructure):
2011-10-28 Pavel Feldman <pfeldman@google.com>
Reset line numbers for scripts generated with document.write.
https://bugs.webkit.org/show_bug.cgi?id=71099
Reviewed by Yury Semikhatsky.
* wtf/text/TextPosition.h:
(WTF::OrdinalNumber::OrdinalNumber):
2011-10-27 Daniel Bates <dbates@rim.com>
CMake: Add support to optionally install the built JavaScript shell
https://bugs.webkit.org/show_bug.cgi?id=71062
Reviewed by Antonio Gomes.
Generate an installation rule for installing the JavaScript shell in
/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
is defined.
* shell/CMakeLists.txt:
2011-10-27 Kentaro Hara <haraken@chromium.org>
Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70215
Reviewed by Adam Barth.
Added a method that judges if a given JSValue is empty.
Tests: transforms/svg-vs-css.xhtml
transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::isEmpty):
2011-10-27 Michael Saboff <msaboff@apple.com>
ENH: Add 8 bit string support to JSC JIT
https://bugs.webkit.org/show_bug.cgi?id=71073
Changed the JIT String character access generation to create code
to check the character size and load8() or load16() as approriate.
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movzbl_mr):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadCharacterString):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::ThunkHelpers::stringImplFlagsOffset):
(JSC::ThunkHelpers::stringImpl8BitFlag):
* jit/ThunkGenerators.cpp:
(JSC::stringCharLoad):
2011-10-27 Filip Pizlo <fpizlo@apple.com>
If the bytecode generator emits code after the return in the first basic block,
DFG's inliner crashes
https://bugs.webkit.org/show_bug.cgi?id=71071
Reviewed by Gavin Barraclough.
Removed some cruft dealing with parsing failures due to unsupported functionality
(that's never reached anymore due to it being caught in DFGCapabilities). This
allowed me to repurpose the bool return from parseBlock() to mean: true if we
should continue to parse, or false if we've already parsed all live code.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
Reviewed by David Kilzer.
Make FeatureDefines Identical Across OS X Projects
https://bugs.webkit.org/show_bug.cgi?id=71051
* Configurations/FeatureDefines.xcconfig:
2011-10-27 Filip Pizlo <fpizlo@apple.com>
Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic
https://bugs.webkit.org/show_bug.cgi?id=71045
Reviewed by Geoff Garen.
Make sure that if a structure is pinned, it also has a property map.
* runtime/Structure.cpp:
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTableForPinning):
* runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
2011-10-27 Michael Saboff <msaboff@apple.com>
32bit build failure after r98624
https://bugs.webkit.org/show_bug.cgi?id=71064
Disambiguated operator overload with unsigned index (0u).
Reviewed by Sam Weinig.
* runtime/UString.h:
(JSC::operator==):
2011-10-27 Gustavo Noronha Silva <gns@gnome.org>
Fix building on GNU/kFreeBSD
https://bugs.webkit.org/show_bug.cgi?id=71005
Reviewed by Darin Adler.
* config.h:
* wtf/Platform.h:
2011-10-27 Michael Saboff <msaboff@apple.com>
Investigate storing strings in 8-bit buffers when possible
https://bugs.webkit.org/show_bug.cgi?id=66161
Investigate storing strings in 8-bit buffers when possible
https://bugs.webkit.org/show_bug.cgi?id=66161
Added support for 8 bit string data in StringImpl. Changed
(UChar*) m_data to m_data16. Added char* m_data8 as a union
with m_data16. Added UChar* m_copyData16 to the other union
to store a 16 bit copy of an 8 bit string when needed.
Added characters8() and characters16() accessor methods
that assume the caller has checked the underlying string type
via the new is8Bit() method. The characters() method will
return a UChar* of the string, materializing a 16 bit copy if the
string is an 8 bit string. Added two flags, one for 8 bit buffer
and a second for a 16 bit copy for an 8 bit string.
Fixed method name typo (StringHasher::defaultCoverter()).
Over time the goal is to eliminate calls to characters() and
us the character8() and characters16() accessors.
This patch does not include changes that actually create 8 bit
strings. This is the first of at least 8 patches. Subsequent
patches will be submitted for JIT changes, making the JSC lexer,
parser and literal parser, JavaScript string changes and
then changes in webcore to take advantage of the 8 bit strings.
This change is performance neutral for SunSpider and V8 when
run from the command line with "jsc".
Reviewed by Geoffrey Garen.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::UStringSourceProvider):
* runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::toUInt32):
* runtime/Identifier.h:
(JSC::Identifier::equal):
(JSC::operator==):
(JSC::operator!=):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::equalSlowCase):
(JSC::UString::utf8):
* runtime/UString.h:
(JSC::UString::characters):
(JSC::UString::characters8):
(JSC::UString::characters16):
(JSC::UString::is8Bit):
(JSC::UString::operator[]):
(JSC::UString::find):
(JSC::operator==):
* wtf/StringHasher.h:
(WTF::StringHasher::computeHash):
(WTF::StringHasher::defaultConverter):
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicString::add):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::contains):
(WTF::AtomicString::find):
(WTF::AtomicString::add):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):
* wtf/text/StringConcatenate.h:
* wtf/text/StringHash.h:
(WTF::StringHash::equal):
(WTF::CaseFoldingHash::hash):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::containsOnlyWhitespace):
(WTF::StringImpl::substring):
(WTF::StringImpl::characterStartingAt):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::fill):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::stripMatchedCharacters):
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::replace):
(WTF::StringImpl::defaultWritingDirection):
(WTF::StringImpl::adopt):
(WTF::StringImpl::createWithTerminatingNullCharacter):
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::create):
(WTF::StringImpl::create8):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::flagsOffset):
(WTF::StringImpl::flagIs8Bit):
(WTF::StringImpl::dataOffset):
(WTF::StringImpl::is8Bit):
(WTF::StringImpl::characters8):
(WTF::StringImpl::characters16):
(WTF::StringImpl::characters):
(WTF::StringImpl::has16BitShadow):
(WTF::StringImpl::setHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::copyChars):
(WTF::StringImpl::operator[]):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::isolatedCopy):
* wtf/text/WTFString.cpp:
(WTF::String::String):
(WTF::String::append):
(WTF::String::format):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
* wtf/text/WTFString.h:
(WTF::String::find):
(WTF::String::findIgnoringCase):
(WTF::String::contains):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):
* wtf/unicode/Unicode.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::execute):
* yarr/YarrJIT.h:
(JSC::Yarr::YarrCodeBlock::execute):
* yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
Fixing windows build
Unreviewed build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986
Reviewed by Geoffrey Garen.
Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
HAS_MEMBER_NAMED macro to use that template to check if the specified class
does indeed have a method with that name. This mechanism is not currently
used anywhere, but will be in the future when adding virtual methods from
JSObject to the MethodTable.
* runtime/ClassInfo.h:
2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958
Reviewed by Geoffrey Garen.
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::toThisObject):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::toThisObject):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::toThisObject):
* runtime/JSObject.h:
(JSC::JSValue::toThisObject):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::toThisObject):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::toThisObject):
* runtime/JSString.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::toThisObject):
* runtime/StrictEvalActivation.h:
2011-10-27 Yuqiang Xian <yuqiang.xian@intel.com>
Fix a small bug in callOperation after r98431
https://bugs.webkit.org/show_bug.cgi?id=70984
Reviewed by Geoffrey Garen.
TrustedImmPtr is not expecting "int" type parameters.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
2011-10-26 Oliver Hunt <oliver@apple.com>
Restore structure-clearing behaviour of allocateCell<>
https://bugs.webkit.org/show_bug.cgi?id=70976
Reviewed by Geoffrey Garen.
This restores the logic that allows the markstack to filter
live objects that have not yet been initialised.
* runtime/JSCell.h:
(JSC::JSCell::clearStructure):
Validation-safe method to clear a cell's structure.
(JSC::allocateCell):
Call the above method.
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):
Don't visit cells that haven't been initialised.
2011-10-26 Filip Pizlo <fpizlo@apple.com>
REGRESSION (r97030): Cannot log in to progressive.com
https://bugs.webkit.org/show_bug.cgi?id=70094
Reviewed by Oliver Hunt.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
2011-10-26 Mark Hahnenberg <mhahnenberg@apple.com>
Remove getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=70741
Reviewed by Geoffrey Garen.
Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/ErrorPrototype.cpp:
* runtime/ErrorPrototype.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotByIndex):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::hasOwnProperty):
* runtime/JSObject.h:
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSString.h:
* runtime/MathObject.cpp:
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::createStructure):
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
* runtime/StringPrototype.h:
2011-10-26 Alejandro G. Castro <alex@igalia.com>
[GTK] [WK2] Add WebKit2 distcheck support
https://bugs.webkit.org/show_bug.cgi?id=70933
Reviewed by Martin Robinson.
* GNUmakefile.list.am: Add MemoryStatistics.h to the sources list.
2011-10-26 Michael Saboff <msaboff@apple.com>
Increase StringImpl Flag Bits for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=70937
Increased the number of bits used for flags in StringImpl
from 6 to 8 bits. This frees up 2 flag bits that will be
used for 8-bit string support. Updated hash methods accordingly.
Changed hash value masking from the low bits to the high
bits.
Reviewed by Darin Adler.
* create_hash_table:
* wtf/StringHasher.h:
(WTF::StringHasher::hash):
* wtf/text/StringImpl.h:
2011-10-26 Dan Bernstein <mitz@apple.com>
Build fix.
Reverted r98488, which caused the scripts’ status messages to be included in the generated
files.
* create_hash_table:
* create_jit_stubs:
2011-10-26 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Don't print regular output to STDERR when generating hashtables and JIT stubs
Reviewed by Simon Hausmann.
* create_hash_table:
* create_jit_stubs:
2011-10-25 Gavin Barraclough <barraclough@apple.com>
Split DFGJITCodeGenerator::callOperation methods
https://bugs.webkit.org/show_bug.cgi?id=70870
Reviewed by Filip Pizlo.
The DFGJITCodeGenerator currently contains two sets of callOperation methods.
One set works with the JSVALUE64 value representation and passes arguments in
registers (suitable for use on x86-64), and one set works with the JSVALUE32_64
value representation and passes arguments in memory (suitable for use on x86).
By refactoring out the representation and calling convention specific aspects
of the code we can also configure the DFG JIT to operator on platforms that use
the JSVALUE32_64 value representation but pass arguments in registers.
On platforms supported by the JIT, the payload precedes the tag of a value in
argument/result ordering, as such, in order to make the setupResults method
generally applicable to return the results of a function that are returned in
two registers, the ordering of arguments to this function has been reversed -
as is the ordering of augments passed to setupArguments methods, with respect
to the ordering with which they are passed in to callOperation.
This inconsistency will be resolved in a later change when we combine the pairs
of arguments passed into callOperation, such that the function signatures can
be made consistent across the two value representations (the callOperation
methods will be passed a reference to a struct representing the JSValue
temporary, this will consist of two gprs on 32_64 and one on 64).
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
- moved, removed tag,payload version of this method.
(JSC::DFG::setupArguments):
(JSC::DFG::setupArgumentsExecState):
(JSC::DFG::setupArgumentsWithExecState):
- Calling convention specific portion of callOperation refactored out into these methods.
(JSC::DFG::callOperation):
- updated these methods to use setupArguments* methods.
(JSC::DFG::setupResults):
- setupResults is now passed payload,tag.
(JSC::DFG::appendCallWithExceptionCheckSetResult):
- Added fpr versions of this function.
(JSC::DFG::appendCallSetResult):
- Added versions of this function without exception check.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- setupResults is now passed payload,tag.
2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738
Reviewed by Geoffrey Garen.
Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deletePropertyByIndex):
* API/JSObjectRef.cpp:
(JSObjectDeleteProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::deleteProperty):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
* runtime/JSVariableObject.h:
* runtime/RegExpMatchesArray.h:
* runtime/StrictEvalActivation.cpp:
* runtime/StrictEvalActivation.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
Remove putVirtual
https://bugs.webkit.org/show_bug.cgi?id=70740
Reviewed by Geoffrey Garen.
Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::put):
* debugger/DebuggerActivation.h:
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* jsc.cpp:
(GlobalObject::finishCreation):
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::put):
(JSC::JSCell::putByIndex):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSValue::put):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
2011-10-25 Gavin Barraclough <barraclough@apple.com>
Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858
Reviewed by Oliver Hunt.
This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
2011-10-25 Filip Pizlo <fpizlo@apple.com>
Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854
Reviewed by Oliver Hunt.
Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.
This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
Fixing Windows build after r98367
Unreviewed build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-10-25 Yuqiang Xian <yuqiang.xian@intel.com>
Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806
Reviewed by Darin Adler.
* GNUmakefile.list.am:
* JavaScriptCore.pro:
2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807
Reviewed by Oliver Hunt.
* JavaScriptCore.exp:
* runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
* runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can
reference it in their MethodTables.
2011-10-25 Oliver Hunt <oliver@apple.com>
Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832
Reviewed by Gavin Barraclough.
When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):
2011-10-24 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798
Reviewed by Filip Pizlo.
When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
2011-10-24 Geoffrey Garen <ggaren@apple.com>
Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.
* JavaScriptCore.order:
2011-10-24 Geoffrey Garen <ggaren@apple.com>
Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698
Reviewed by David Levin.
- Removed SharedUChar because most of its functionality has moved into
other abstraction layers, and we want remaining clients to choose their
abstractions explicitly instead of relying on StringImpl to provide this
behavior implicitly, since we think they can sometimes make more efficient
choices.
- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names could give the impression that the resulting object was
thread-safe, but actually it's just an isolated copy, which is not
thread-safe by itself, but can be used to implement a thread-safe
algorithm through isolation.
* wtf/CrossThreadRefCounted.h: Removed.
* JavaScriptCore.exp: Export!
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl): Removed the stuff mentioned above.
* wtf/text/StringImpl.h:
(WTF::StringImpl::length): Ditto.
(WTF::StringImpl::isolatedCopy): Inlined this, since it's now trivial.
* wtf/text/WTFString.cpp:
(WTF::String::isolatedCopy):
* wtf/text/WTFString.h: Updated for StringImpl changes.
* API/OpaqueJSString.h:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/OwnFastMallocPtr.h:
* wtf/RefCounted.h:
* wtf/SizeLimits.cpp:
* wtf/ThreadSafeRefCounted.h:
* wtf/wtf.pri:
* yarr/YarrPattern.h: Updated these files to accomodate removal of
CrossThreadRefCounted.h.
2011-10-24 Oliver Hunt <oliver@apple.com>
Crash in void JSC::validateCell<JSC::RegExp*>(JSC::RegExp*)
https://bugs.webkit.org/show_bug.cgi?id=70689
Reviewed by Filip Pizlo.
While performing codegen we need to make the GlobalData explicitly
aware of the codeblock being compiled, as compilation may trigger GC
and CodeBlock holds GC values, but has not yet been assigned to its
owner executable.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):
2011-10-24 Filip Pizlo <fpizlo@apple.com>
Object-or-other branch speculation may corrupt the state for OSR if the child of the
branch is an integer
https://bugs.webkit.org/show_bug.cgi?id=70777
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
2011-10-24 Filip Pizlo <fpizlo@apple.com>
op_new_array_buffer is not inlined correctly
https://bugs.webkit.org/show_bug.cgi?id=70770
Reviewed by Oliver Hunt.
Disabled inlining of op_new_array_buffer, for now.
* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineOpcode):
2011-10-24 Yuqiang Xian <yuqiang.xian@intel.com>
Add boolean speculations to DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=70706
Reviewed by Filip Pizlo.
Different from the boolean speculations in DFG 64, the boolean
speculations in DFG 32_64 will use a 32bit GPR to hold the primitive
boolean instead of a JSBoolean. This choice is not only for
performance, but also to save a register as we're short of registers on
X86.
To accomplish this we make use of DataFormatBoolean, allow a value to
be represented as a primitive boolean and converted from/to a
JSBoolean.
This patch also fixes SpillOrder in 32_64, which should be different
from 64, and fixes needDataFormatConversion logic in 32_64.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTest32):
We don't expect byte test actually as it doesn't work for registers
esp..edi on X86.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::cellResult):
(JSC::DFG::booleanResult):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::gpr):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
2011-10-24 Mark Hahnenberg <mhahnenberg@apple.com>
Fixing Windows build
Unreviewed build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-10-24 Yuqiang Xian <yuqiang.xian@intel.com>
BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691
Reviewed by Geoffrey Garen.
Current BitVector uses the highest bit of m_bitsOrPointer to indicate
whether it's an inlined bit set or a pointer to an outOfLine bit set.
This check may fail in case the pointer also has the highest bit set,
which is surely possible on IA32 (Linux).
In this case the check failure can result in unexpected behaviors,
for example if the BitVector is incorrectly determined as having an
inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
modify the memory adjacent to the BitVector object.
This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
or outofline, based on the assumption that the pointer to OutOfLineBits
should be 4 or 8 byte aligned.
We could mark the lowest bit (bit 0) with 1 for inlined bit set,
and bits 1~bitsInPointer are used for bit set/test.
In this case we need do one bit more shift for bit set/test.
* wtf/BitVector.cpp:
(WTF::BitVector::resizeOutOfLine):
* wtf/BitVector.h:
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):
2011-10-24 Mark Hahnenberg <mhahnenberg@apple.com>
Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
https://bugs.webkit.org/show_bug.cgi?id=70271
Reviewed by Darin Adler.
Renaming versions of getOwnPropertySlot that use an unsigned as the property
name to "getOwnPropertySlotByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlotByIndex):
* runtime/Arguments.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlotVirtual):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlotVirtual):
(JSC::JSCell::getOwnPropertySlotByIndex):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertySlotVirtual):
(JSC::JSNotAnObject::getOwnPropertySlotByIndex):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlotByIndex):
* runtime/JSObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlotByIndex):
* runtime/JSString.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertySlotVirtual):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
* runtime/ObjectPrototype.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlotVirtual):
(JSC::StringObject::getOwnPropertySlotByIndex):
* runtime/StringObject.h:
2011-10-24 Patrick Gansterer <paroga@webkit.org>
Interpreter build fix after r98179.
* bytecode/CodeBlock.h:
Moved CodeBlock::baselineVersion() into ENABLE(JIT) block,
since it is only used there.
2011-10-23 Geoffrey Garen <ggaren@apple.com>
Fixed a typo Darin spotted.
* wtf/StringHasher.h:
(WTF::StringHasher::hash): Expelliarmus!
2011-10-23 Geoffrey Garen <ggaren@apple.com>
Removed StringImpl::createStrippingNullCharacters
https://bugs.webkit.org/show_bug.cgi?id=70700
Reviewed by David Levin.
It was unused.
* JavaScriptCore.exp:
* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
2011-10-22 Filip Pizlo <fpizlo@apple.com>
DFG should inline constructors
https://bugs.webkit.org/show_bug.cgi?id=70675
Reviewed by Oliver Hunt.
Adds support for inlining constructors. Also fixes two pathologies
uncovered along the way: CheckMethod claimed that it never returned a
result (causing CheckMethod -> SetLocal -> GetLocal sequences to
result in the GetLocal doing OSR exit), and get_by_id parsing never
checked if it was hot in slow path. Also fiddled with inlining
heuristics; it appears that for now, the more inlining, the happier
V8 is. Finally, a bug was uncovered where a silent spill of a boxed
integer that had previously been spilled unboxed causes the silent
fill to forget to unbox.
This appears to be a 4% speed-up on V8 in their harness, or a 1%
speed-up in my harness. The difference is due to warm-up: in my
harness we see significant amounts of time spent in compilation, but
in V8's harness compilation gets amortizes. Profiling indicates that
we have the potential for a 5% win from basic optimizations like
generating OSR exits lazily and holding onto bytecode longer.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::mightInlineFunctionFor):
(JSC::DFG::canInlineFunctionFor):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
* runtime/Executable.h:
(JSC::isCall):
(JSC::ExecutableBase::intrinsicFor):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
2011-10-23 Noel Gordon <noel.gordon@gmail.com>
[chromium] Remove RopeImpl.{h,cpp} from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=70703
Reviewed by Kent Tamura.
runtime/RopeImpl.{h,cpp} were removed in r97872, remove references
to these files from the gyp project files.
* JavaScriptCore.gypi:
2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com>
Add deleteProperty to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70162
Reviewed by Sam Weinig.
* JavaScriptCore.exp:
* runtime/ClassInfo.h: Added both versions of deleteProperty to the MethodTable.
* runtime/JSFunction.h: Changed JSFunction::deleteProperty to
be protected rather than private for subclasses who don't provide their own
implementation.
2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com>
Remove getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=70638
Reviewed by Darin Adler.
Removed all declarations and definitions of getConstructDataVirtual.
Also replaced all call sites to getConstructDataVirtual with a
corresponding lookup in the MethodTable.
* API/JSCallbackConstructor.cpp:
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::getConstructData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSObject.h:
(JSC::getConstructData):
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
2011-10-23 Geoffrey Garen <ggaren@apple.com>
Try to fix the SL build.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): Cast
away int vs unisgned warning.
2011-10-21 Geoffrey Garen <ggaren@apple.com>
Separated string lifetime bits from character buffer state bits
https://bugs.webkit.org/show_bug.cgi?id=70673
Reviewed by Anders Carlsson.
Moved the static/immortal bit into the bottom bit of the refcount, and
moved all other bits into the high bits of the hash code.
This is the first step toward a new Characters/PassString class, and it
makes ref/deref slightly more efficient.
* create_hash_table:
* wtf/StringHasher.h:
(WTF::StringHasher::hash): Tweaked the string hashing function to leave
the top bits clear, so they can be used as flags.
Fixed some small differences between the PERL copy of this function and
the C++ copy of this function, which could have in theory caused subtle
crashes.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::sharedBuffer):
(WTF::StringImpl::createWithTerminatingNullCharacter):
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::cost): Renamed s_refCountFlagShouldReportedCost to
s_didReportExtraCost, since the original name was both self-contradictory
and used as a double-negative.
(WTF::StringImpl::isIdentifier):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::hasTerminatingNullCharacter):
(WTF::StringImpl::isAtomic):
(WTF::StringImpl::setIsAtomic):
(WTF::StringImpl::setHash):
(WTF::StringImpl::rawHash):
(WTF::StringImpl::hasHash):
(WTF::StringImpl::existingHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::hasOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringImpl::bufferOwnership):
(WTF::StringImpl::isStatic): Moved the static/immortal bit into the bottom
bit of the refcount. Now, all lifetime information lives in the refcount
field. Moved the other bits into the hash code field.
2011-10-21 Filip Pizlo <fpizlo@apple.com>
DFG inlining sometimes fails to reset constant references
https://bugs.webkit.org/show_bug.cgi?id=70668
Reviewed by Anders Carlsson.
Reset constant references when we need to (new block created) and not
when we don't (change of inlining depth).
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
2011-10-21 Filip Pizlo <fpizlo@apple.com>
DFG should have inlining
https://bugs.webkit.org/show_bug.cgi?id=69996
Reviewed by Oliver Hunt.
Implements inlining that's hooked into the bytecode parser. Only
works for calls, for now, though nothing fundamentally prevents us
from inlining constructor calls. 2% overall speed-up on all
benchmarks. 7% speed-up on V8 (around 34% and 27% on deltablue and
richards respectively), neutral on Kraken and SunSpider.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::setInstructionCount):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::inlineDepth):
(JSC::CodeOrigin::operator==):
(JSC::CodeOrigin::inlineStack):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
(JSC::DFG::UnlinkedBlock::UnlinkedBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::handleSuccessor):
(JSC::DFG::ByteCodeParser::determineReachability):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::canInlineOpcodes):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForConstruct):
* dfg/DFGGraph.cpp:
(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::decodedCodeMapFor):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::baselineCodeBlockFor):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::shouldGenerate):
* dfg/DFGOperands.h:
(JSC::DFG::Operands::ensureLocals):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::getLocal):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrameSlow):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::profiledCodeBlockFor):
(JSC::FunctionExecutable::parameterCount):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
* runtime/JSFunction.h:
2011-10-21 Mark Hahnenberg <mhahnenberg@apple.com>
Add put to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70439
Reviewed by Oliver Hunt.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h: Added put and putByIndex to the MethodTable.
* runtime/JSFunction.h: Changed access modifier for put to protected since some
subclasses of JSFunction need to reference it in their MethodTables.
2011-10-21 Mark Hahnenberg <mhahnenberg@apple.com>
Add finalizer to JSObject
https://bugs.webkit.org/show_bug.cgi?id=70336
Reviewed by Darin Adler.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): Skip the call to the destructor
if we're a JSFinalObject, since the finalizer takes care of things.
* runtime/JSCell.h:
(JSC::JSCell::~JSCell): Remove the GC validation due to a conflict with
future changes and the fact that we no longer always call the destructor, making
the information provided less useful.
* runtime/JSObject.cpp:
(JSC::JSObject::finalize): Add finalizer for JSObject.
(JSC::JSObject::allocatePropertyStorage): The first time we need to allocate out-of-line
property storage, we add a finalizer to ourself.
* runtime/JSObject.h:
2011-10-21 Simon Hausmann <simon.hausmann@nokia.com>
Remove QtScript source code from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=64088
Reviewed by Tor Arne Vestbø.
Removed dead code that isn't developed anymore.
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* qt/api/QtScript.pro: Removed.
* qt/api/qscriptconverter_p.h: Removed.
* qt/api/qscriptengine.cpp: Removed.
* qt/api/qscriptengine.h: Removed.
* qt/api/qscriptengine_p.cpp: Removed.
* qt/api/qscriptengine_p.h: Removed.
* qt/api/qscriptfunction.cpp: Removed.
* qt/api/qscriptfunction_p.h: Removed.
* qt/api/qscriptoriginalglobalobject_p.h: Removed.
* qt/api/qscriptprogram.cpp: Removed.
* qt/api/qscriptprogram.h: Removed.
* qt/api/qscriptprogram_p.h: Removed.
* qt/api/qscriptstring.cpp: Removed.
* qt/api/qscriptstring.h: Removed.
* qt/api/qscriptstring_p.h: Removed.
* qt/api/qscriptsyntaxcheckresult.cpp: Removed.
* qt/api/qscriptsyntaxcheckresult.h: Removed.
* qt/api/qscriptsyntaxcheckresult_p.h: Removed.
* qt/api/qscriptvalue.cpp: Removed.
* qt/api/qscriptvalue.h: Removed.
* qt/api/qscriptvalue_p.h: Removed.
* qt/api/qscriptvalueiterator.cpp: Removed.
* qt/api/qscriptvalueiterator.h: Removed.
* qt/api/qscriptvalueiterator_p.h: Removed.
* qt/api/qtscriptglobal.h: Removed.
* qt/benchmarks/benchmarks.pri: Removed.
* qt/benchmarks/benchmarks.pro: Removed.
* qt/benchmarks/qscriptengine/qscriptengine.pro: Removed.
* qt/benchmarks/qscriptengine/tst_qscriptengine.cpp: Removed.
* qt/benchmarks/qscriptvalue/qscriptvalue.pro: Removed.
* qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp: Removed.
* qt/tests/qscriptengine/qscriptengine.pro: Removed.
* qt/tests/qscriptengine/tst_qscriptengine.cpp: Removed.
* qt/tests/qscriptstring/qscriptstring.pro: Removed.
* qt/tests/qscriptstring/tst_qscriptstring.cpp: Removed.
* qt/tests/qscriptvalue/qscriptvalue.pro: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue.h: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Removed.
* qt/tests/qscriptvalueiterator/qscriptvalueiterator.pro: Removed.
* qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp: Removed.
* qt/tests/tests.pri: Removed.
* qt/tests/tests.pro: Removed.
2011-10-21 Zheng Liu <zheng.z.liu@intel.com>
bytecompiler sometimes generates incorrect bytecode for put_by_id
https://bugs.webkit.org/show_bug.cgi?id=70403
Reviewed by Filip Pizlo.
* bytecompiler/NodesCodegen.cpp:
(JSC::AssignDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
2011-10-20 Filip Pizlo <fpizlo@apple.com>
DFG should not try to predict argument types by looking at the values of
argument registers at the time of compilation
https://bugs.webkit.org/show_bug.cgi?id=70578
Reviewed by Oliver Hunt.
* bytecode/CodeBlock.cpp:
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGDriver.h:
(JSC::DFG::tryCompileFunction):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):
2011-10-20 Filip Pizlo <fpizlo@apple.com>
DFG call optimization handling will fail if the call had been unlinked due
to the callee being optimized
https://bugs.webkit.org/show_bug.cgi?id=70468
Reviewed by Geoff Garen.
If a call had ever been linked, we remember this fact as well as the function
to which it was linked even if unlinkIncomingCalls() or unlinkCalls() are
called.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* jit/JIT.cpp:
(JSC::JIT::linkFor):
2011-10-20 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT 32_64 - Fix ByteArray speculation
https://bugs.webkit.org/show_bug.cgi?id=70571
Reviewed by Filip Pizlo.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-20 Vincent Scheib <scheib@chromium.org>
MouseLock compile and run time flags.
https://bugs.webkit.org/show_bug.cgi?id=70530
Reviewed by Darin Fisher.
* wtf/Platform.h:
2011-10-20 Mark Hahnenberg <mhahnenberg@apple.com>
Rename static deleteProperty to deletePropertyByIndex
https://bugs.webkit.org/show_bug.cgi?id=70257
Reviewed by Geoffrey Garen.
Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deletePropertyVirtual):
(JSC::::deletePropertyByIndex):
* runtime/Arguments.cpp:
(JSC::Arguments::deletePropertyVirtual):
(JSC::Arguments::deletePropertyByIndex):
* runtime/Arguments.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deletePropertyVirtual):
(JSC::JSArray::deletePropertyByIndex):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deletePropertyVirtual):
(JSC::JSCell::deletePropertyByIndex):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::deletePropertyVirtual):
(JSC::JSNotAnObject::deletePropertyByIndex):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::deletePropertyVirtual):
(JSC::JSObject::deletePropertyByIndex):
* runtime/JSObject.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::deletePropertyVirtual):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
2011-10-20 Filip Pizlo <fpizlo@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=70482
DFG-related stubs in the old JIT should not be built if the DFG is disabled
Reviewed by Zoltan Herczeg.
Aiming for a slight code size/build time reduction if the DFG is not in
play. This should also make further DFG development slightly easier since
the bodies of these JIT stubs can now safely refer to things that are only
declared when the DFG is enabled.
* jit/JITStubs.cpp:
* jit/JITStubs.h:
2011-10-19 Filip Pizlo <fpizlo@apple.com>
DFG ConvertThis emits slow code when the source node is known to be,
but not predicted to be, a final object
https://bugs.webkit.org/show_bug.cgi?id=70466
Reviewed by Oliver Hunt.
Added a new case in ConvertThis compilation.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-19 Filip Pizlo <fpizlo@apple.com>
Optimization triggers in the old JIT may sometimes fire repeatedly even
though there is no optimization to be done
https://bugs.webkit.org/show_bug.cgi?id=70467
Reviewed by Oliver Hunt.
If optimize_from_ret does nothing, it delays the next optimization trigger.
This is performance-neutral.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
2011-10-19 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT 32_64 - remove unnecessary double unboxings in fillDouble/fillSpeculateDouble
https://bugs.webkit.org/show_bug.cgi?id=70460
Reviewed by Filip Pizlo.
As pointed out by Gavin in bug #70418, when a value is already in memory
we can avoid loading it to two GPRs at first and then unboxing them to a FPR.
This gives 9% improvement on Kraken if without the change in bug #70418,
and 1% if based on the code with bug #70418 change.
Performance is neutral in V8 and SunSpider.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
2011-10-19 Gavin Barraclough <barraclough@apple.com>
Poisoning of strict caller,arguments inappropriately poisoning "in"
https://bugs.webkit.org/show_bug.cgi?id=63398
Reviewed by Oliver Hunt.
This fixes the problem by correctly implementing the spec -
the error should actually be being thrown from a standard JS getter/setter.
This implements spec correct behaviour for strict mode JS functions & bound
functions, I'll follow up with a patch to do the same for arguments.
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
- Add the poisoned caller/arguments properties.
* runtime/JSBoundFunction.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):
- If the caller/arguments are accessed on a strict mode function, lazily add the ThrowTypeError getter.
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::throwTypeErrorGetterSetter):
- Add a ThrowTypeError type, per ES5 13.2.3.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncThrowTypeError):
* runtime/JSGlobalObjectFunctions.h:
- Implementation of ThrowTypeError.
* runtime/JSObject.cpp:
(JSC::JSObject::initializeGetterSetterProperty):
* runtime/JSObject.h:
- This function adds a new property (must not exist already) that is an initialized getter/setter.
2011-10-19 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT 32_64 - improve double boxing/unboxing
https://bugs.webkit.org/show_bug.cgi?id=70418
Reviewed by Gavin Barraclough.
Double boxing/unboxing in DFG JIT 32_64 is currently implemented inefficiently,
which tries to exchange data through memory.
On X86 some SSE instructions can help us on such operations with better performance.
This improves 32-bit DFG performance by 29% on Kraken, 7% on SunSpider,
and 2% on V8, tested on Linux X86 (Core i7 Nehalem).
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::lshiftPacked):
(JSC::MacroAssemblerX86Common::rshiftPacked):
(JSC::MacroAssemblerX86Common::orPacked):
(JSC::MacroAssemblerX86Common::moveInt32ToPacked):
(JSC::MacroAssemblerX86Common::movePackedToInt32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movd_rr):
(JSC::X86Assembler::psllq_i8r):
(JSC::X86Assembler::psrlq_i8r):
(JSC::X86Assembler::por_rr):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compile):
2011-10-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[EFL] Fix DSO linkage of wtf_efl.
Unreviewed build fix.
Need to add -ldl to jsc_efl (requested by dladdr).
* wtf/CMakeListsEfl.txt:
2011-10-19 Geoffrey Garen <ggaren@apple.com>
Removed StringImplBase, fusing it into StringImpl
https://bugs.webkit.org/show_bug.cgi?id=70443
Reviewed by Gavin Barraclough.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::ref):
(WTF::StringImpl::length):
* wtf/text/StringImplBase.h: Removed.
* wtf/wtf.pri: Removed!
2011-10-19 Mark Hahnenberg <mhahnenberg@apple.com>
Add getConstructData to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70163
Reviewed by Geoffrey Garen.
Adding getConstructData to the MethodTable in order to be able to
remove all calls to getConstructDataVirtual soon. Part of the process
of de-virtualizing JSCell.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
2011-10-18 Oliver Hunt <oliver@apple.com>
Support CanvasPixelArray in the DFG
https://bugs.webkit.org/show_bug.cgi?id=70384
Reviewed by Filip Pizlo.
Add support for the old CanvasPixelArray optimisations to the
DFG. This removes the regression seen in the DFG when using
a CPA.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::truncateDoubleToInt32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movb_rm):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isByteArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateByteArray):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::compileClampDoubleToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSByteArray.h:
(JSC::JSByteArray::offsetOfStorage):
* wtf/ByteArray.cpp:
* wtf/ByteArray.h:
(WTF::ByteArray::offsetOfSize):
(WTF::ByteArray::offsetOfData):
2011-10-18 Geoffrey Garen <ggaren@apple.com>
Some rope cleanup following r97827
https://bugs.webkit.org/show_bug.cgi?id=70398
Reviewed by Oliver Hunt.
9% speedup on date-format-xparb, neutral overall.
- Removed RopeImpl*.
- Removed JSString::m_fiberCount, since this can be deduced from other data.
- Renamed a jsString() variant to jsStringFromArguments for clarity.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.order:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Removed RopeImpl*.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadCharacterString):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::loadJSStringArgument):
* jit/ThunkGenerators.cpp:
(JSC::stringCharLoad): Use a NULL m_value to signal rope-iness, instead
of testing m_fiberCount, since m_fiberCount is gone now.
* runtime/JSString.cpp:
(JSC::JSString::RopeBuilder::expand):
(JSC::JSString::visitChildren):
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Use a NULL fiber to indicate "last fiber
in the vector" instead of testing m_fiberCount, since m_fiberCount is gone now.
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::offsetOfLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::string): Removed m_fiberCount. Renamed
jsString => jsStringFromArguments for clarity.
* runtime/Operations.h:
(JSC::jsStringFromArguments): Renamed.
* runtime/RopeImpl.cpp: Removed.
* runtime/RopeImpl.h: Removed.
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString): Switched to StringImpl::empty,
which is slightly faster.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncConcat): Updated for rename.
* wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase): Removed the concept of an invalid
StringImpl, since this was only used by RopeImpl, which is now gone.
2011-10-19 Rafael Antognolli <antognolli@profusion.mobi>
[EFL] Fix DSO linkage of jsc_efl.
https://bugs.webkit.org/show_bug.cgi?id=70412
Unreviewed build fix.
Need to add -ldl to jsc_efl (requested by dladdr).
* shell/CMakeListsEfl.txt:
2011-10-18 Geoffrey Garen <ggaren@apple.com>
Rolled out last Windows build fix because it was wrong.
2011-10-18 Geoffrey Garen <ggaren@apple.com>
Rolled out last Windows build fix because it was wrong.
2011-10-18 Geoffrey Garen <ggaren@apple.com>
Try to fix part of the Windows build.
Export!
2011-10-18 Geoffrey Garen <ggaren@apple.com>
Switched ropes from malloc memory to GC memory
https://bugs.webkit.org/show_bug.cgi?id=70364
Reviewed by Gavin Barraclough.
~1% SunSpider speedup. Neutral elsewhere. Removes one cause for strings
having C++ destructors.
* heap/MarkStack.cpp:
(JSC::visitChildren): Call the JSString visitChildren function now,
since it's no longer a no-op.
* runtime/JSString.cpp:
(JSC::JSString::~JSString): Moved this destructor out of line because
it's called virtually, so there's no value to inlining.
(JSC::JSString::RopeBuilder::expand): Switched RopeBuilder to be a thin
initializing wrapper around JSString. JSString now represents ropes
directly, rather than relying on an underlying malloc object.
(JSC::JSString::visitChildren): Visit our rope fibers, since they're GC
objects now.
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Updated for operating on JSStrings instead
of malloc objects.
(JSC::JSString::replaceCharacter): Removed optimizations for substringing
ropes and replacing subsections of ropes. We want to reimplement versions
of these optimizations in the future, but this patch already has good
performance without them.
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString): Lots of mechanical changes here. The two important
things are: (1) The fibers in JSString::m_fibers are JSStrings now, not
malloc objects; (2) I simplified the JSString constructor interface to
only accept PassRefPtr<StringImpl>, instead of variations on that like
UString, reducing refcount churn.
* runtime/JSValue.h:
* runtime/JSValue.cpp:
(JSC::JSValue::toPrimitiveString): Updated this function to return a
JSString instead of a UString, since that's what clients want now.
* runtime/Operations.cpp:
(JSC::jsAddSlowCase):
* runtime/Operations.h:
(JSC::jsString):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString): Updated for interface changes above.
* runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
* runtime/StringObject.h:
(JSC::StringObject::create): Don't create a new JSString if we already
have a JSString.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncConcat): Updated for interface changes above.
2011-10-18 Gavin Barraclough <barraclough@apple.com>
Errrk, fix partial commit of r97825!
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
2011-10-18 Gavin Barraclough <barraclough@apple.com>
Date.prototype.toISOString fails to throw exception
https://bugs.webkit.org/show_bug.cgi?id=70394
Reviewed by Sam Weinig.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
- Should throw a range error if the internal value is not finite.
2011-10-18 Mark Hahnenberg <mhahnenberg@apple.com>
Rename static put to putByIndex
https://bugs.webkit.org/show_bug.cgi?id=70281
Reviewed by Geoffrey Garen.
Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.
* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.cpp:
(JSC::Arguments::putVirtual):
(JSC::Arguments::putByIndex):
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncMap):
* runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::putVirtual):
(JSC::JSArray::putByIndex):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::putVirtual):
(JSC::JSByteArray::putByIndex):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putVirtual):
(JSC::JSCell::putByIndex):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::putVirtual):
(JSC::JSNotAnObject::putByIndex):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putVirtual):
(JSC::JSObject::putByIndex):
* runtime/JSObject.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::fillArrayInstance):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::putVirtual):
(JSC::RegExpMatchesArray::putByIndex):
2011-10-18 Gavin Barraclough <barraclough@apple.com>
Array.prototype methods missing exception checks
https://bugs.webkit.org/show_bug.cgi?id=70360
Reviewed by Geoff Garen.
Missing exception checks after calls to the static getProperty helper,
these may result in the wrong exception being thrown (or an ASSERT being hit,
as is currently the case running test-262).
No performance impact.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
2011-10-18 Adam Barth <abarth@webkit.org>
Always enable ENABLE(XPATH)
https://bugs.webkit.org/show_bug.cgi?id=70217
Reviewed by Eric Seidel.
* Configurations/FeatureDefines.xcconfig:
2011-10-18 Gavin Barraclough <barraclough@apple.com>
Indexed arguments on the Arguments object should be enumerable.
https://bugs.webkit.org/show_bug.cgi?id=70302
Reviewed by Sam Weinig.
See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyDescriptor):
- The 'enumerable' property should be true for indexed arguments.
(JSC::Arguments::getOwnPropertyNames):
- Don't guard the adding of indexed properties with 'IncludeDontEnumProperties'.
2011-10-18 Gustavo Noronha Silva <gns@gnome.org>
Fix distcheck.
* GNUmakefile.list.am: fix a typo and add a missing header to the
list.
2011-10-18 Balazs Kelemen <kbalazs@webkit.org>
ParallelJobs: maximum number of threads should be determined dynamically
https://bugs.webkit.org/show_bug.cgi?id=68540
Reviewed by Zoltan Herczeg.
Add logic to determine the number of cores and use this as
the maximum number of threads. The implementation currently
covers Linux, Darwin, Windows, AIX, Solaris, OpenBSD and NetBSD.
The patch was tested on Linux, Mac and Windows which was enough to
cover all code path. It should work on the rest accoring to the
documentation of those OS's. The hard coded constant is still used
on uncovered OS's which should be fixed in the future.
* wtf/ParallelJobs.h: Removed the default value of the requestedJobNumber
argument because clients should always fill it and the 0 default value
was incorrect anyway.
(WTF::ParallelJobs::ParallelJobs):
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::determineMaxNumberOfParallelThreads):
* wtf/ParallelJobsGeneric.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
2011-10-17 Gavin Barraclough <barraclough@apple.com>
Reverted r997709, this caused test failures.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):
2011-10-17 Ryosuke Niwa <rniwa@webkit.org>
Rename deregister* to unregister*
https://bugs.webkit.org/show_bug.cgi?id=70272
Reviewed by Darin Adler.
Renamed deregisterWeakMap to unregisterWeakMap.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::unregisterWeakMap):
2011-10-17 Gavin Barraclough <barraclough@apple.com>
Poisoning of strict caller/arguments inappropriately poisoning "in"
https://bugs.webkit.org/show_bug.cgi?id=63398
Reviewed by Sam Weinig.
The problem here is that the has[Own]Property methods get the slot rather than
the descriptor, and getting the slot may cause the property to be eagerly accessed.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- We don't expect hasProperty to ever throw. If it does, it won't get caught
(since it is after the exception check), so ASSERT to guard against this.
* runtime/JSObject.cpp:
(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):
- These methods should not check for the presence of the descriptor; never get the value.
2011-10-17 Gavin Barraclough <barraclough@apple.com>
Exception ordering in String.prototype.replace
https://bugs.webkit.org/show_bug.cgi?id=70290
If pattern is not a regexp, it should be converted toString before the replacement value has it's toString conversion called.
Reviewed by Oliver Hunt.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
2011-10-17 Filip Pizlo <fpizlo@apple.com>
DFG bytecode parser should understand inline stacks
https://bugs.webkit.org/show_bug.cgi?id=70278
Reviewed by Oliver Hunt.
The DFG bytecode parser is now capable of parsing multiple code blocks at
once. This remains turned off since not all inlining functionality is
implemented.
This required making a few changes elsewhere in the system. The bytecode
parser now may do some of the same things that the bytecode generator does,
like allocating constants and identifiers. Basic block linking relies on
bytecode indices, which are only meaningful within the context of one basic
block. This is fine, so long as linking is done eagerly whenever switching
from one code block to another.
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::CodeOrigin):
* bytecompiler/BytecodeGenerator.h:
* dfg/DFGBasicBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::InlineStackEntry::executable):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::GetBytecodeBeginForBlock::GetBytecodeBeginForBlock):
(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
* dfg/DFGNode.h:
* runtime/Identifier.h:
(JSC::IdentifierMapIndexHashTraits::emptyValue):
* runtime/JSValue.h:
* wtf/StdLibExtras.h:
(WTF::binarySearchWithFunctor):
2011-10-17 Gavin Barraclough <barraclough@apple.com>
Incorrect behavior from String match/search & undefined pattern
https://bugs.webkit.org/show_bug.cgi?id=70286
Reviewed by Sam weinig.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
- In case of undefined, pattern is "".
(JSC::stringProtoFuncSearch):
- In case of undefined, pattern is "".
2011-10-17 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=70207
After deleting __defineSetter__, it is absent but appears in name list
Reviewed by Darin Adler.
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyNames):
- This should check whether static functions have been reified.
2011-10-17 Geoffrey Garen <ggaren@apple.com>
Mac build fix.
* JavaScriptCore.exp: Export!
2011-10-17 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export!
2011-10-17 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
* heap/HandleStack.cpp: Added a missing #include.
2011-10-17 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed no
longer existant symbol.
* heap/MarkStack.cpp:
(JSC::MarkStackArray::shrinkAllocation): Cast to the right type.
2011-10-17 Geoffrey Garen <ggaren@apple.com>
Simplified GC marking logic
https://bugs.webkit.org/show_bug.cgi?id=70258
Reviewed by Filip Pizlo.
No perf. change.
This is a first step toward GC allocating string backing stores, starting
with ropes. It also enables future simplifications and optimizations.
- Replaced some complex mark stack logic with a simple linear stack of
JSCell pointers.
- Replaced logic for short-circuiting marking based on JSType and/or
Structure flags with special cases for object, array, and string.
- Fiddled with inlining for better codegen.
* JavaScriptCore.exp:
* heap/HandleStack.cpp: Build!
* heap/Heap.cpp:
(JSC::Heap::Heap): Provide more vptrs to SlotVisitor, for use in marking.
* heap/HeapRootVisitor.h: Removed unused functions that no longer build.
* heap/MarkStack.cpp:
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::shrinkAllocation):
(JSC::MarkStack::reset):
(JSC::visitChildren):
(JSC::SlotVisitor::drain):
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):
(JSC::MarkStack::internalAppend): Replaced complex mark set logic with
simple linear stack.
* heap/SlotVisitor.h:
(JSC::SlotVisitor::SlotVisitor): Updated for above changes.
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* runtime/JSArray.h:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
* runtime/JSObject.h: Don't inline visitChildren; it's too big.
* runtime/Structure.h:
(JSC::MarkStack::internalAppend): Nixed the short-circuit for CompoundType
because it prevented strings from owning GC pointers.
* runtime/WriteBarrier.h:
(JSC::MarkStack::appendValues): No need to validate; internalAppend will
do that for us.
2011-10-17 Adam Roben <aroben@apple.com>
Windows build fix after r97536, part 3
* runtime/JSAPIValueWrapper.h:
* runtime/JSObject.h:
Use JS_EXPORTDATA to export the s_info members.
2011-10-17 Adam Roben <aroben@apple.com>
Interpreter build fix after r97564
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Moved declaration of globalData variable into ENABLE(JIT) blocks, since it is only used
there.
2011-10-17 Adam Roben <aroben@apple.com>
Windows build fix after r97536, part 2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added back
JSC::setUpStaticFunctionSlot with its new mangled name. SOrted the rest of the file while I
was at it.
2011-10-17 Adam Roben <aroben@apple.com>
Windows build fix after r97536
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed export of
JSC::setUpStaticFunctionSlot, which no longer exists. Also removed incorrect exports of
s_info members, which need to be exported via JS_EXPORTDATA instead.
2011-10-17 Patrick Gansterer <paroga@webkit.org>
Interpreter build fix after r97436, r97506, r97532 and r97537.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2011-10-16 Adam Barth <abarth@webkit.org>
Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
https://bugs.webkit.org/show_bug.cgi?id=70216
Reviewed by Eric Seidel.
* wtf/Platform.h:
2011-10-16 Noel Gordon <noel.gordon@gmail.com>
[chromium] Remove PageAllocatorSymbian.h, OSAllocatorSymbian.cpp, gtk/ThreadingGtk.cpp from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=70205
Reviewed by James Robinson.
wtf/PageAllocatorSymbian.h and wtf/OSAllocatorSymbian.cpp were removed in r97557.
wtf/gtk/ThreadingGtk.cpp was removed in r97269.
* JavaScriptCore.gypi:
2011-10-16 Adam Barth <abarth@webkit.org>
Always enable ENABLE(DOM_STORAGE)
https://bugs.webkit.org/show_bug.cgi?id=70189
Reviewed by Eric Seidel.
* Configurations/FeatureDefines.xcconfig:
2011-10-15 Dan Horák <dan@danny.cz>
The s390 and s390x architectures both use 64-bit double type
that conforms to the IEEE-754 standard.
https://bugs.webkit.org/show_bug.cgi?id=69940
Reviewed by Gavin Barraclough.
* wtf/dtoa/utils.h:
2011-10-14 Filip Pizlo <fpizlo@apple.com>
FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=70157
Reviewed by Geoff Garen.
Added FunctionExecutable::produceCodeBlockFor() and rewired compileForCallInternal()
and compileForConstructInternal() to use this method. This required more cleanly
exposing some of CodeBlock's tiering functionality and moving the CompilationKind
enum to Executable.h, as this was the easiest way to make it available to the
declarations/definitions of CodeBlock, FunctionExecutable, and BytecodeGenerator.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::copyDataFromAlternative):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setAlternative):
* bytecompiler/BytecodeGenerator.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::codeBlockFor):
2011-10-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
[Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
https://bugs.webkit.org/show_bug.cgi?id=69920
Reviewed by Kenneth Rohde Christiansen.
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* heap/MarkStack.h:
(JSC::::shrinkAllocation):
* jit/ExecutableAllocator.cpp:
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* jit/JITStubs.cpp:
* jsc.pro:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncLastIndexOf):
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/Atomics.h:
* wtf/MathExtras.h:
* wtf/OSAllocator.h:
(WTF::OSAllocator::decommitAndRelease):
* wtf/OSAllocatorSymbian.cpp: Removed.
* wtf/OSRandomSource.cpp:
(WTF::cryptographicallyRandomValuesFromOS):
* wtf/PageAllocation.h:
* wtf/PageAllocatorSymbian.h: Removed.
* wtf/PageBlock.cpp:
* wtf/Platform.h:
* wtf/StackBounds.cpp:
* wtf/wtf.pri:
2011-10-15 Yuqiang Xian <yuqiang.xian@intel.com>
Trivial fix for a missing change in r97512
https://bugs.webkit.org/show_bug.cgi?id=70166
Reviewed by Gavin Barraclough.
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::link):
2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
Rename getOwnPropertySlot to getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=69810
Reviewed by Geoffrey Garen.
Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.
Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlotVirtual):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::staticFunctionGetter):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlotVirtual):
(JSC::DebuggerActivation::getOwnPropertySlot):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlot):
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertySlotVirtual):
(JSC::ArrayConstructor::getOwnPropertySlot):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlotVirtual):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlotVirtual):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlotVirtual):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlotVirtual):
* runtime/DatePrototype.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlotVirtual):
* runtime/ErrorPrototype.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlotVirtual):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlot):
* runtime/JSArray.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::getOwnPropertySlotVirtual):
* runtime/JSBoundFunction.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlotVirtual):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlotVirtual):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlotVirtual):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertySlotVirtual):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::hasOwnPropertyForWrite):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertySlotVirtual):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONObject::getOwnPropertySlotVirtual):
(JSC::Walker::walk):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::hasOwnProperty):
* runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::getOwnPropertySlotVirtual):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlot):
* runtime/JSString.h:
* runtime/Lookup.h:
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlotVirtual):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlotVirtual):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlotVirtual):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlotVirtual):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertySlotVirtual):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlotVirtual):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlotVirtual):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlotVirtual):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlotVirtual):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlotVirtual):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlotVirtual):
* runtime/StringPrototype.h:
2011-10-14 Gavin Barraclough <baraclough@apple.com>
Most built-in properties are not deletable
https://bugs.webkit.org/show_bug.cgi?id=61014
Reviewed by Filip Pizlo.
Our static hash tables don't allow for deleting properties.
This is the cause of a bunch of expected failures in LayoutTests/sputnik.
This fixes the problem by reifying all static functions immediately prior
to the first deletion. Reification is tracked by a flag on the structure,
so properties will no longer 'bounce-back' on later access.
Theoretically there could probably also be an issue with custom accessor
properties, but we probably do not really require any of these to be
Configurable anyway. I'll follow up with a separate patch to address this.
* runtime/ClassInfo.h:
(JSC::ClassInfo::hasStaticProperties):
- detects static property tables.
* runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
- call reifyStaticFunctions before deletion.
(JSC::JSObject::reifyStaticFunctions):
- If the class has static functions, set them up now.
* runtime/JSObject.h:
(JSC::JSObject::staticFunctionsReified):
- returns true if static functions have been reified,
and as such should no longer be added.
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- If static functions have been reified do not add.
* runtime/Lookup.h:
(JSC::HashTable::ConstIterator::ConstIterator):
(JSC::HashTable::ConstIterator::operator->):
(JSC::HashTable::ConstIterator::operator*):
(JSC::HashTable::ConstIterator::operator!=):
(JSC::HashTable::ConstIterator::operator++):
(JSC::HashTable::ConstIterator::skipInvalidKeys):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):
- setUpStaticFunctionSlot may not add, returns a bool.
(JSC::lookupPut):
- remove redundant branch.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
- initialize new flag in constructors.
* runtime/Structure.h:
(JSC::Structure::staticFunctionsReified):
(JSC::Structure::setStaticFunctionsReified):
- added flag
2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
Rename virtual put to putVirtual
https://bugs.webkit.org/show_bug.cgi?id=69851
Reviewed by Darin Adler.
Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::putVirtual):
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::putVirtual):
(JSC::DebuggerActivation::put):
* debugger/DebuggerActivation.h:
* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(GlobalObject::finishCreation):
* runtime/Arguments.cpp:
(JSC::Arguments::putVirtual):
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
* runtime/JSActivation.cpp:
(JSC::JSActivation::putVirtual):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::putVirtual):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::putVirtual):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putVirtual):
(JSC::JSCell::put):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::putVirtual):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putVirtual):
(JSC::JSGlobalObject::putWithAttributes):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::putVirtual):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::putVirtual):
(JSC::JSObject::put):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSValue::put):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::putVirtual):
* runtime/JSStaticScopeObject.h:
* runtime/Lookup.h:
(JSC::lookupPut):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::putVirtual):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::putVirtual):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::putVirtual):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::putVirtual):
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
(JSC::StringObject::putVirtual):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
2011-10-13 Filip Pizlo <fpizlo@apple.com>
Reflective Arguments retrieval should be hardened for the
possibility of inlining
https://bugs.webkit.org/show_bug.cgi?id=70068
Reviewed by Oliver Hunt.
CodeBlock can now track, as part of its RareData, the virtual inline
stack at callsites. CallFrame walking can now rematerialize "inline"
CallFrames by combining the meta-data in CodeBlock with the information
already in the JS stack. Arguments can now safely retrieve the
arguments from inline CallFrames.
The DFG already had the notion of a "CodeOrigin" in preparation for
inlining. This notion will now be saved into the CodeBlock, if the DFG
had done inlining. So, CodeOrigin has been moved to bytecode/ and has
been changed to behave more like a struct since that is how it's
meant to be used.
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
(JSC::CodeBlock::inlineCallFrames):
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::codeOriginForReturn):
* bytecode/CodeOrigin.h: Added.
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):
(JSC::getCallReturnOffsetForCodeOrigin):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGNode.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::isInlineCallFrame):
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::setInlineCallFrame):
(JSC::ExecState::isInlineCallFrame):
(JSC::ExecState::trueCallerFrame):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Register.h:
(JSC::Register::operator=):
(JSC::Register::inlineCallFrame):
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):
* runtime/Executable.h:
(JSC::FunctionExecutable::parameterCount):
2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
Rename virtual deleteProperty to deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=69884
Reviewed by Darin Adler.
Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deletePropertyVirtual):
(JSC::::deleteProperty):
* API/JSObjectRef.cpp:
(JSObjectDeleteProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::deletePropertyVirtual):
(JSC::DebuggerActivation::deleteProperty):
* debugger/DebuggerActivation.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.cpp:
(JSC::Arguments::deletePropertyVirtual):
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
* runtime/JSActivation.cpp:
(JSC::JSActivation::deletePropertyVirtual):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deletePropertyVirtual):
(JSC::JSArray::deleteProperty):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deletePropertyVirtual):
(JSC::JSCell::deleteProperty):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::deletePropertyVirtual):
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::deletePropertyVirtual):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::deletePropertyVirtual):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deletePropertyVirtual):
* runtime/JSVariableObject.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::deletePropertyVirtual):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::deletePropertyVirtual):
* runtime/StrictEvalActivation.h:
* runtime/StringObject.cpp:
(JSC::StringObject::deletePropertyVirtual):
* runtime/StringObject.h:
2011-10-14 Peter Beverloo <peter@chromium.org>
[Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
https://bugs.webkit.org/show_bug.cgi?id=70028
Reviewed by Adam Barth.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-10-14 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT 32_64 - Performance fix for ResolveGlobal
https://bugs.webkit.org/show_bug.cgi?id=70096
Reviewed by Gavin Barraclough.
Structure check of global object should be a pointer comparison
instead of a tag and payload pair comparison. This fix improves
SunSpider by 7% on Linux 32, with bitops-bitwise-and improved by 4.75X.
Also two trivial fixes for successful 32-bit build are included.
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-13 Filip Pizlo <fpizlo@apple.com>
Speculation failures in ValueToInt32 are causing a 2x slow-down
in Kraken/stanford-crypto-pbkdf2
https://bugs.webkit.org/show_bug.cgi?id=70089
Reviewed by Gavin Barraclough.
If we can't truncate to Int32 using machine code, then don't fail
speculation. Just call JSC::toInt32.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-13 Mark Hahnenberg <mhahnenberg@apple.com>
Rename virtual getConstructData to getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=69872
Reviewed by Geoffrey Garen.
Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::getConstructDataVirtual):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getConstructDataVirtual):
* API/JSObjectRef.cpp:
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getConstructDataVirtual):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getConstructDataVirtual):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getConstructDataVirtual):
* runtime/DateConstructor.h:
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::getConstructDataVirtual):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getConstructDataVirtual):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getConstructDataVirtual):
* runtime/FunctionConstructor.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getConstructDataVirtual):
* runtime/JSCell.h:
(JSC::getConstructData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getConstructDataVirtual):
* runtime/JSFunction.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getConstructDataVirtual):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getConstructDataVirtual):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getConstructDataVirtual):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getConstructDataVirtual):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getConstructDataVirtual):
* runtime/StringConstructor.h:
2011-10-13 Filip Pizlo <fpizlo@apple.com>
Rubber stamped Stephanie Lewis.
DFG_ENABLE() macro was always returning false.
* dfg/DFGNode.h:
2011-10-13 Gavin Barraclough <baraclough@apple.com>
Speculative build fix for !DFG builds.
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
2011-10-13 Oliver Hunt <oliver@apple.com>
Fix performance of ValueToInt32 node when predicting double
https://bugs.webkit.org/show_bug.cgi?id=70063
Reviewed by Filip Pizlo.
Currently we fail to inline double to int conversion when
performing a ValueToInt32 operation on a value we predict
to be a double.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
Apply correct filter for the double prediction path
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
Support double parameters even when value has been spilled.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
Moved old valueToInt32 code to this function, and added
path for double prediction
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Made the two implementations of ValueToInt32 call a single
shared compileValueToInt32 function.
2011-10-13 Chris Marrin <cmarrin@apple.com>
Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911
Reviewed by Simon Fraser.
Add REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for implementations
that use the DisplayRefreshMonitor logic.
* wtf/Platform.h:
2011-10-13 Gavin Barraclough <baraclough@apple.com>
DFG JIT should not be using ENABLE macro to enable features
https://bugs.webkit.org/show_bug.cgi?id=70060
Reviewed by Oliver Hunt.
The ENABLE macro is only intended to be used to detect features that are configured
in Platform.h. Using its to detect settings defined in other headers is an error.
The problem is that the ENABLE macro checks if the value is defined, so will silently
return false if you fail to include the header defining the switch. This is not a problem
if (1) the settings are defined in the same header that defines the macro that tests them,
or (2) the header is included everywhere. In the case of ENABLE settings defined in
Platform.h, both are true! To make this clear, add an explicit DFG_ENABLE macro.
* bytecode/CodeBlock.cpp:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::makeSafe):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGNode.h:
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::propagatePredictions):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
(JSC::DFG::Propagator::globalCFA):
* dfg/DFGScoreBoard.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
2011-10-13 Gavin Barraclough <baraclough@apple.com>
terminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell
Rubber stamped by Filip Pizlo
This is breaking fast/canvas/canvas-composite-alpha.html on 32_64 DFG JIT.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
2011-10-13 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualized JSCell::toNumber
https://bugs.webkit.org/show_bug.cgi?id=69858
Reviewed by Sam Weinig.
Removed JSCallbackObject::toNumber because its no longer necessary since
JSObject::toNumber now suffices since we implicitly add valueOf to an object's
prototype whenever a convertToType callback is provided.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
De-virtualized JSCell::toNumber, JSObject::toNumber, and JSString::toNumber.
* runtime/JSCell.cpp:
(JSC::JSCell::toNumber):
* runtime/JSCell.h:
* runtime/JSObject.h:
* runtime/JSString.h:
Removed JSNotAnObject::toNumber because its result doesn't matter and it implements
defaultValue, therefore JSObject::toNumber can cover its case.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
2011-10-13 Xianzhu Wang <wangxianzhu@chromium.org>
Use realloc() to expand/shrink StringBuilder buffer
https://bugs.webkit.org/show_bug.cgi?id=69913
Reviewed by Darin Adler.
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::reallocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate): Added to allow StringBuilder to reallocate the buffer.
* wtf/text/StringImpl.h:
2011-10-12 Filip Pizlo <fpizlo@apple.com>
If an Arguments object is being used to copy the arguments, then
make this explicit
https://bugs.webkit.org/show_bug.cgi?id=69995
Reviewed by Sam Weinig.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveArguments):
* runtime/Arguments.h:
(JSC::Arguments::createAndCopyRegisters):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):
2011-10-12 Filip Pizlo <fpizlo@apple.com>
DFG CFA does not filter structures aggressively enough.
https://bugs.webkit.org/show_bug.cgi?id=69989
Reviewed by Oliver Hunt.
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::checkConsistency):
2011-10-12 Adam Barth <abarth@webkit.org>
Remove ENABLE(XHTMLMP) and associated code
https://bugs.webkit.org/show_bug.cgi?id=69729
Reviewed by David Levin.
* Configurations/FeatureDefines.xcconfig:
2011-10-12 Gavin Barraclough <baraclough@apple.com>
MacroAssemblerX86 8-bit register ops unsafe on CPU(X86)
https://bugs.webkit.org/show_bug.cgi?id=69978
Reviewed by Filip Pizlo.
Certain ops are unsafe if the register passed is esp..edi (will instead test/set the ).
compare32/test8/test32 Call setCC, which sets an 8-bit register - we can fix this by adding
a couple of xchg instructions.
branchTest8 with a register argument is also affected. In all cases this is currently used
this is testing a value that is correct to 32 or more bits, so we can simply switch these
to branchTest32 & remove the corresponding branchTest8 (this is desirable anyway, since the
32-bit form is cheaper to implement on platforms that don't have an 8-bit compare instruction).
This fixes the remaining fast/js failures with the DFG JIT 32_64.
* assembler/MacroAssemblerARMv7.h
- removed branchTest8.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::set32):
- added set32 helper that is 'h' register safe.
- removed branchTest8.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
- switch uses of branchTest8 to branchTest32.
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
- switch uses of branchTest8 to branchTest32.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
- switch uses of branchTest8 to branchTest32.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
- switch uses of branchTest8 to branchTest32.
2011-10-12 Gavin Barraclough <baraclough@apple.com>
Errrk, revert accidental commit!
* wtf/Platform.h:
2011-10-12 Gavin Barraclough <baraclough@apple.com>
Unreviewed, re-land changes from #69890, #69903.
These were reverted due to bug #69897, but #69903 fixed this problem.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
2011-10-12 Filip Pizlo <fpizlo@apple.com>
ValueProfile::computeUpdatedPrediction doesn't merge statistics correctly
https://bugs.webkit.org/show_bug.cgi?id=69906
Reviewed by Gavin Barraclough.
It turns out that the simplest fix is to switch computeUpdatedPredictions()
to using predictionFromValue() combined with mergePrediction(). Doing so
allowed me to kill off weakBuckets and visitWeakReferences(). Hence this
not only fixes a performance bug but kills off a lot of code that I never
liked to begin with.
This appears to be a 1% win on V8.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
* bytecode/PredictedType.cpp:
(JSC::predictionFromValue):
* bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::dump):
2011-10-12 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSCell::toString
https://bugs.webkit.org/show_bug.cgi?id=69677
Reviewed by Sam Weinig.
Removed toString from JSCallbackObject, since it is no
longer necessary since we now implicitly add toString and valueOf
functions to object prototypes when a convertToType callback
is provided, which is now the standard way to override toString
and valueOf in the JSC C API.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Removed toString from InterruptedExecutionError and
TerminatedExecutionError and replaced it with defaultValue,
which JSObject::toString calls. We'll probably have to de-virtualize
defaultValue eventually, but we'll cross that bridge when we
come to it.
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
* runtime/ExceptionHelpers.h:
Removed toString from JSNotAnObject, since its return value doesn't
actually matter and JSObject::toString can cover it.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
De-virtualized JSCell::toString, JSObject::toString and JSString::toString.
Added handling of all cases for JSCell to JSCell::toString.
* runtime/JSObject.h:
* runtime/JSString.h:
* runtime/JSCell.cpp:
(JSC::JSCell::toString):
* runtime/JSCell.h:
2011-10-12 Oliver Hunt <oliver@apple.com>
Global stringStructure caches its prototype chain, abandoning a web page
https://bugs.webkit.org/show_bug.cgi?id=69952
Reviewed by Filip Pizlo.
When visiting a structure, we don't keep the prototype chain
alive if we're not the structure for an object type.
* runtime/Structure.cpp:
(JSC::Structure::visitChildren):
2011-10-12 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT 32_64 - Fix ArrayPop
https://bugs.webkit.org/show_bug.cgi?id=69918
Reviewed by Filip Pizlo.
The storageLengthGPR is polluted by EmptyValueTag and later used to
index the array, which results in abnormal behaviors in execution.
This fix makes 32_64 DFG pass v8-deltablue and kraken
crypto-sha256-iterative on Linux ia32.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movl_i32m):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fix build with GLib 2.31
https://bugs.webkit.org/show_bug.cgi?id=69840
Reviewed by Martin Robinson.
* GNUmakefile.list.am: removed ThreadingGtk.cpp.
* wtf/ThreadingPrimitives.h: remove GTK+-specific definitions.
* wtf/gobject/GOwnPtr.cpp: remove GCond and GMutex specializations.
* wtf/gobject/GOwnPtr.h: ditto.
* wtf/gobject/GTypedefs.h: remove GCond and GMutex forward declarations.
* wtf/gtk/ThreadingGtk.cpp: Removed.
2011-10-12 Filip Pizlo <fpizlo@apple.com>
Layout tests crashing in DFG JIT code
https://bugs.webkit.org/show_bug.cgi?id=69897
Reviewed by Gavin Barraclough.
Abstract value filtration didn't take into account cases where a structure
set filter, combined with predicted type knowledge, could lead to a stronger
filter for the structure abstract value.
This bug would have been benign in release builds; it would have just meant
that the analysis was less precise and some optimization opportunities would
be missed. I have an ASSERT that is meant to catch such cases, and it was
triggering sporadically in one of the LayoutTests.
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::filter):
2011-10-11 Gavin Barraclough <baraclough@apple.com>
Unreviewed, temporarily reverted r97216 due to bug #69897.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
2011-10-11 Yuqiang Xian <yuqiang.xian@intel.com>
DFG 32_64 - fix silentFillGPR
https://bugs.webkit.org/show_bug.cgi?id=69903
Reviewed by Filip Pizlo.
Fix a small bug in silentFillGPR,
and add the newly introduced DFG file to CMakeListsEfl.
* CMakeListsEfl.txt:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
2011-10-08 Filip Pizlo <fpizlo@apple.com>
DFG does not have flow-sensitive intraprocedural control flow analysis
https://bugs.webkit.org/show_bug.cgi?id=69690
Reviewed by Gavin Barraclough.
Implemented a control flow analysis (CFA). It currently propagates type
proofs only. For example, if all predecessors to a basic block have
checks that variable X is a JSFinalObject with structure 0xabcdef, then
this basic block will now know this fact and will know that it does not
have to emit either JSFinalObject checks or any structure checks since
the structure is precisely known. The CFA takes heap side-effects into
account (though somewhat conservatively), so that if the object pointed
to by variable X could have possibly undergone a structure transition
then this is reflected: the analysis may simply say that X's structure
is unknown.
This also propagates a wealth of other type information which is
currently not being used. For example, we now know when a variable can
only hold doubles. Even if a variable may hold other types at different
points in its live range, we can still prove exactly when it will only
be double.
There's a bunch of stuff that the CFA could do that it still does not
do, like precise handling of PutStructure (i.e. structure transitions),
precise handling of CheckFunction and CheckMethod, etc. So this is
very much intended to be a starting point rather than an end unto
itself.
This is a 1% win on V8 (mostly due to a 3% win on richards and deltablue)
and a 1% win on Kraken (mostly due to a 6% win on imaging-desaturate).
Neutral on SunSpider.
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/ActionablePrediction.h: Removed.
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
* bytecode/PredictedType.h:
* dfg/DFGAbstractState.cpp: Added.
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::~AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
(JSC::DFG::AbstractState::dump):
* dfg/DFGAbstractState.h: Added.
(JSC::DFG::AbstractState::forNode):
(JSC::DFG::AbstractState::isValid):
* dfg/DFGAbstractValue.h: Added.
(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::addAll):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::last):
(JSC::DFG::StructureAbstractValue::predictionFromStructures):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::top):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::dump):
* dfg/DFGBasicBlock.h: Added.
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::setupPredecessors):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::block):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGNode.h:
(JSC::DFG::NodeIndexTraits::defaultValue):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::takenBytecodeOffsetDuringParsing):
(JSC::DFG::Node::notTakenBytecodeOffsetDuringParsing):
(JSC::DFG::Node::setTakenBlockIndex):
(JSC::DFG::Node::setNotTakenBlockIndex):
(JSC::DFG::Node::takenBlockIndex):
(JSC::DFG::Node::notTakenBlockIndex):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
* dfg/DFGOperands.h: Added.
(JSC::DFG::operandIsArgument):
(JSC::DFG::OperandValueTraits::defaultValue):
(JSC::DFG::Operands::Operands):
(JSC::DFG::Operands::numberOfArguments):
(JSC::DFG::Operands::numberOfLocals):
(JSC::DFG::Operands::argument):
(JSC::DFG::Operands::local):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::setArgumentFirstTime):
(JSC::DFG::Operands::setLocalFirstTime):
(JSC::DFG::Operands::operand):
(JSC::DFG::Operands::setOperand):
(JSC::DFG::Operands::clear):
(JSC::DFG::dumpOperands):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictions):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
(JSC::DFG::Propagator::globalCFA):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureSet.h:
(JSC::DFG::StructureSet::clear):
(JSC::DFG::StructureSet::predictionFromStructures):
(JSC::DFG::StructureSet::operator==):
(JSC::DFG::StructureSet::dump):
* dfg/DFGVariableAccessData.h: Added.
2011-10-11 Gavin Barraclough <baraclough@apple.com>
DFG JIT 32_64 - Fix silentFillGPR for non-integer constants.
https://bugs.webkit.org/show_bug.cgi?id=69890
Reviewed by Oliver Hunt.
Cell constants are currently hitting the valueOfInt32Constant case, there is no constant handling for JSValues.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
2011-10-11 Ryosuke Niwa <rniwa@webkit.org>
GTK build fix attempt after r97197.
* wtf/BitVector.h:
2011-10-11 Oliver Hunt <oliver@apple.com>
Remove unintentional logging.
* heap/Heap.cpp:
2011-10-11 Oliver Hunt <oliver@apple.com>
Tidy up card walking logic
https://bugs.webkit.org/show_bug.cgi?id=69883
Reviewed by Gavin Barraclough.
Special case common cell sizes when walking a block's
cards.
* heap/CardSet.h:
(JSC::::testAndClear):
* heap/Heap.cpp:
(JSC::GCTimer::GCCounter::GCCounter):
(JSC::GCTimer::GCCounter::count):
(JSC::GCTimer::GCCounter::~GCCounter):
(JSC::Heap::markRoots):
* heap/MarkStack.cpp:
(JSC::MarkStack::reset):
* heap/MarkStack.h:
(JSC::MarkStack::visitCount):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::append):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::gatherDirtyCellsWithSize):
(JSC::MarkedBlock::gatherDirtyCells):
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):
2011-10-11 Filip Pizlo <fpizlo@apple.com>
DFG virtual register allocator should be more aggressive in
reusing temporary slots
https://bugs.webkit.org/show_bug.cgi?id=69868
Reviewed by Oliver Hunt.
1.2% win on V8, neutral elsewhere. The win is probably because it
increases precision of GC conservative scans.
This required making the DFG::ScoreBoard operate over a bitvector
of preserved variables, rather than just a preserved variable
threshold. To do this, I improved the WTF::BitVector class to make
it more user-friendly. It still retains all previous functionality.
Also made changes to PackedIntVector to accomodate those changes.
Finally, this adds more debugging to the virtual register allocator
and to the OSR exit code, as this was necessary to track down bugs
in an earlier version of this patch.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getLocal):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::allocateVirtualRegisters):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::highWatermark):
(JSC::DFG::ScoreBoard::dump):
(JSC::DFG::ScoreBoard::max):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueRecovery::dump):
* wtf/BitVector.cpp:
(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::dump):
* wtf/BitVector.h:
(WTF::BitVector::BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
* wtf/PackedIntVector.h:
(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):
2011-10-11 Gavin Barraclough <baraclough@apple.com>
DFG JIT 32_64 - Switch to cdecl calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69863
Reviewed by Oliver Hunt.
This makes it easier to keep the stack correctly aligned, which is required on OS X.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- Provide default FunctionPtr constructors for CDECL functions on STDCALL platforms.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- Switch calls to poke arguments rather than pushing them.
(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
(JSC::DFG::addCallArgumentBoxed):
- Helper functions to stack up call arguments on X86.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- Don't push, poke!
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
- Don't push, poke!
* dfg/DFGOperations.cpp:
- Switch ReturnAddress wrappers to push return address last, update asm trampolines.
* dfg/DFGOperations.h:
- switch DFG_OPERATION to assert CDECL on STDCALL platforms.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::fmodWithCDecl):
(JSC::DFG::SpeculativeJIT::compile):
- On STDCALL platforms wrap fmod, since DFG_OPERATION wrappers are CDECL.
2011-10-11 Gavin Barraclough <baraclough@apple.com>
Switch RegisterSizedBoolean/dfgConvertJSValueToInt32 return type to size_t
https://bugs.webkit.org/show_bug.cgi?id=69821
Reviewed by Filip Pizlo.
Operations returning types Z (int32_t) and B (RegisterSizedBoolean - implemented as an
intptr_t) are indistinguishable on 32-bit Linux, preventing the DFG JIT from building.
dfgConvertJSValueToInt32 would be better returning a value known to be register sized, for
JSVALUE64 (we currently zero-extend in JIT code, potentially introducing an unnecessary
move), so by switching all associated operations to return a size_t we can fix the type
problem on Linux & make it a small tweak that removes an unnecessary instruction.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
- comparisons now return a size_t.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- Removed Z_DFGOperation_EJ form.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
- comparisons now return a size_t.
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
- comparisons now return a size_t.
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
- Change return types for comparison operations & dfgConvertJSValueToInt32 to size_t,
Both need to return values zero extended to fill a register.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
- comparisons now return a size_t.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
- comparisons now return a size_t.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
- comparisons now return a size_t.
2011-10-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Remove all references to QTDIR_build and standalone_package
Qt is now modularized, which means we no longer import WebKit into
the Qt source tree. Instead we use git submodules, and building
QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
To decrease the number of buildsystem configurations we also remove
the standalone_package code-path used when we were providing tarballs
with the derived sources pre-generated.
Reviewed by Simon Hausmann.
* DerivedSources.pro:
* JavaScriptCore.pri:
* JavaScriptCore.pro:
2011-10-11 Yuqiang Xian <yuqiang.xian@intel.com>
Add missing copyright notice in DFG JIT files
https://bugs.webkit.org/show_bug.cgi?id=69809
Reviewed by Gavin Barraclough.
* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGJITCompilerInlineMethods.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
2011-10-10 Filip Pizlo <fpizlo@apple.com>
DFG JSVALUE64 spill/fill code should not box integers and doubles
https://bugs.webkit.org/show_bug.cgi?id=69782
Reviewed by Oliver Hunt.
Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat.
This required changing all of the places that spill registers (both silently
and not) and filling registers (both silently and on demand). It also required
changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile)
may have the wrong format for the old JIT (unboxed int or double).
This is a slight win on Kraken (0.25%) and neutral elsewhere.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::spill):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::spill):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::virtualRegister):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
2011-10-10 Gavin Barraclough <baraclough@apple.com>
DFG JIT switch dfgConvert methods to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69806
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGOperations.h:
2011-10-10 Gavin Barraclough <baraclough@apple.com>
Remove some unused methods from the DFG JIT.
Rubber stamped by Oliver Hunt
Thee methods were only used by the non-speculative JIT, and can be removed.
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCodeGenerator64.cpp:
- removed:
nonSpeculativeAdd
nonSpeculativeArithSub
nonSpeculativeArithMod
nonSpeculativeCheckHasInstance
nonSpeculativeInstanceOf
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
- removed:
operationArithMod
operationInstanceOf
operationThrowHasInstanceError
2011-10-10 Gavin Barraclough <baraclough@apple.com>
Switch most calls in DFGJITCodeGenerator to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69802
Reviewed by Oliver Hunt.
Compares, add, mod are the easy cases.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
2011-10-10 Gavin Barraclough <baraclough@apple.com>
DFG: Switch GetById / PutById to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69795
Reviewed by Oliver Hunt.
Also make the take base as a cell, so 32_64 doesn't have to set up the cell tag.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::appropriatePutByIdFunction):
2011-10-10 Filip Pizlo <fpizlo@apple.com>
REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=69412
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
2011-10-10 Mark Hahnenberg <mhahnenberg@apple.com>
Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186
Reviewed by Geoffrey Garen.
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
* API/JSCallbackFunction.cpp:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.
* runtime/Error.cpp:
(JSC::createTypeErrorFunction):
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData. This
just makes execution fail earlier in a place where the source of the error is
easy to trace. These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
(JSC::getCallData):
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
* runtime/Structure.h:
2011-10-10 Gavin Barraclough <barraclough@apple.com>
Switch last calls from DFGSpeculativeJIT to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69780
Reviewed by Oliver Hunt.
Also, rename type in operations for booleans from Z to B, since Z is the mathematical symbol for integers.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* wtf/Platform.h:
2011-10-10 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - bug fix for V8 benchmark cases "crypto" and "raytrace"
https://bugs.webkit.org/show_bug.cgi?id=69748
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
2011-10-10 Adam Roben <aroben@apple.com>
Build fix
* wtf/MainThread.h: Pull in Platform.h since this file uses PLATFORM() macros.
2011-10-10 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - Bug fix for BranchNull
https://bugs.webkit.org/show_bug.cgi?id=69743
Reviewed by Darin Adler.
This fixes the error in access-binary-trees. All SunSpider cases passed.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
2011-10-07 Gavin Barraclough <barraclough@apple.com>
DFG JIT: callOperation should return the Call.
https://bugs.webkit.org/show_bug.cgi?id=69682
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
(JSC::DFG::appendCallWithExceptionCheckSetResult):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendCall):
* wtf/Platform.h:
2011-10-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r97045.
http://trac.webkit.org/changeset/97045
https://bugs.webkit.org/show_bug.cgi?id=69746
makes apple bots very crashy :( (Requested by kling on
#webkit).
* config.h:
2011-10-10 Andreas Kling <kling@webkit.org>
Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521
Reviewed by Antti Koivisto.
* config.h: Touch to force full rebuild.
2011-10-09 Yuqiang Xian <yuqiang.xian@intel.com>
Improve Null or Undefined test in 32_64 DFG
https://bugs.webkit.org/show_bug.cgi?id=69734
Reviewed by Darin Adler.
Currently Null or Undefined value test in 32_64 DFG will check
Null and Undefined tag separately and introduce one more branch.
It can be improved in the way how the baseline JIT is doing - by
relying on the fact that "UndefinedTag + 1 == NullTag and NullTag & 1".
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
2011-10-09 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - Bug fix for ConvertThis
https://bugs.webkit.org/show_bug.cgi?id=69721
Reviewed by Darin Adler.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-09 Yuqiang Xian <yuqiang.xian@intel.com>
Remove unused callOperation code of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69722
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
2011-10-09 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble
https://bugs.webkit.org/show_bug.cgi?id=69720
Reviewed by Filip Pizlo.
In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by
a FPR and will be used for further optimizations, though we currently
don't fully utilize it. For now when filling a JS value which was
spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat
to DataFormatJS to avoid compilation errors.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
2011-10-09 Filip Pizlo <fpizlo@apple.com>
DFG should not always speculate that a ByVal access has an integer index
https://bugs.webkit.org/show_bug.cgi?id=69716
Reviewed by Oliver Hunt.
1% win on SunSpider, neutral elsewhere.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValHasIntBase):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-09 Yuqiang Xian <yuqiang.xian@intel.com>
Fix value profiling in 32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=69717
Reviewed by Filip Pizlo.
Current value profiling for 32_64 JIT is broken and cannot record
correct predicated types, which results in many speculation failures
in the 32_64 DFG JIT, fallbacks to baseline JIT, and re-optimizations
again and again.
With this fix 32_64 DFG JIT can demonstrate real performance gains.
* bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
Empty value check should be performed on decoded JSValue,
as for 32_64 empty value is not identical to encoded 0.
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
Record the right profiling result for 32_64.
2011-10-09 Yuqiang Xian <yuqiang.xian@intel.com>
Remove 32 bit restrictions in DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69711
Reviewed by Filip Pizlo.
op_call/op_construct support was disabled for 32 bit DFG JIT because
there was regression in javascriptcore tests. Now the bugs are fixed
and there should be no regression. This makes 32 bit DFG have the same
capability as 64 bit DFG, and improves the coverage.
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
2011-10-08 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::getConstructData
https://bugs.webkit.org/show_bug.cgi?id=69673
Reviewed by Geoffrey Garen.
Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::getConstructData.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::getConstructData):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getConstructData):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getConstructData):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getConstructData):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getConstructData):
* runtime/DateConstructor.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getConstructData):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getConstructData):
* runtime/FunctionConstructor.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getConstructData):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getConstructData):
* runtime/JSFunction.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getConstructData):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getConstructData):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getConstructData):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getConstructData):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getConstructData):
* runtime/StringConstructor.h:
2011-10-08 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=69593
Reviewed by Geoffrey Garen.
Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot. The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
* runtime/Arguments.h:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
* runtime/DatePrototype.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
* runtime/ErrorPrototype.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
* runtime/JSArray.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::getOwnPropertySlot):
* runtime/JSBoundFunction.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlot):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlot):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertySlot):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertySlot):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSString.h:
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlot):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertySlot):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlot):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlot):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
* runtime/StringPrototype.h:
2011-10-08 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - GetLocal should produce a cell result for Array predictions
https://bugs.webkit.org/show_bug.cgi?id=69699
Reviewed by Filip Pizlo.
It should match SetLocal where only payload is stored for array predictions.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-08 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=69702
Reviewed by Filip Pizlo.
There are some errors in generating code for Branch and LogicalNot,
when the operand is predicted as ObjectOrOther.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
2011-10-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r96996.
http://trac.webkit.org/changeset/96996
https://bugs.webkit.org/show_bug.cgi?id=69697
It broke all tests on the Qt bot (Requested by Ossy_night on
#webkit).
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallDataVirtual):
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getCallDataVirtual):
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getCallDataVirtual):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getCallDataVirtual):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getCallDataVirtual):
* runtime/DateConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
(JSC::createTypeErrorFunction):
* runtime/Error.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getCallDataVirtual):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallDataVirtual):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::getCallDataVirtual):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getCallDataVirtual):
* runtime/JSCell.h:
(JSC::getCallData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getCallDataVirtual):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getCallDataVirtual):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getCallDataVirtual):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getCallDataVirtual):
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getCallDataVirtual):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getCallDataVirtual):
* runtime/StringConstructor.h:
* runtime/Structure.h:
2011-10-08 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT - only Array predictions can result in unboxed cells in register file
https://bugs.webkit.org/show_bug.cgi?id=69695
Reviewed by Filip Pizlo.
In current DFG JIT, only array predictions can result in unboxed cells
in register file, not for the other cell predictions.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
2011-10-07 Yuqiang Xian <yuqiang.xian@intel.com>
bug fixes for ArrayPush and ArrayPop in 32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69696
Reviewed by Filip Pizlo.
On 32-bit, we should use TimesEight (8) instead of ScalePtr (4)
to compute the address of a JS array element.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=69659
Reviewed by Geoffrey Garen.
Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deleteProperty):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::deleteProperty):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::deleteProperty):
* runtime/Arguments.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::deleteProperty):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deleteProperty):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deleteProperty):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::deleteProperty):
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::deleteProperty):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
* runtime/JSVariableObject.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::deleteProperty):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::deleteProperty):
* runtime/StrictEvalActivation.h:
* runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
* runtime/StringObject.h:
2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186
Reviewed by Geoffrey Garen.
Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.
* API/JSCallbackFunction.cpp:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/Error.cpp:
(JSC::createTypeErrorFunction):
Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData. This
just makes execution fail earlier in a place where the source of the error is
easy to trace. These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
(JSC::getCallData):
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
* runtime/Structure.h:
2011-10-07 Oliver Hunt <oliver@apple.com>
Add missing break statement.
Reviewed by Gavin Barraclough.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
2011-10-07 Oliver Hunt <oliver@apple.com>
Support some string intrinsics in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69678
Reviewed by Gavin Barraclough.
Add support for charAt and charCodeAt intrinsics in the DFG.
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::put
https://bugs.webkit.org/show_bug.cgi?id=69382
Reviewed by Geoffrey Garen.
Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::put):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::put):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::put):
* runtime/Arguments.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::put):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::put):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::put):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::put):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::put):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::put):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
* runtime/JSStaticScopeObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::put):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::put):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::put):
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
(JSC::StringObject::put):
* runtime/StringObject.h:
2011-10-07 Gavin Barraclough <barraclough@apple.com>
Refactor DFG to make for use of callOperation
https://bugs.webkit.org/show_bug.cgi?id=69672
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- Added new callOperation calls, don't ASSERT flushed (use helpers for unexpected calls, too).
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
- Switch operationNewObject/operationCreateThis to return Cells,
- Added C_DFGOperation_E/C_DFGOperation_EC/J_DFGOperation_EA/J_DFGOperation_EJA call types.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- Replace code plating calls to operations to with calls to callOperation.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- Replace code plating calls to operations to with calls to callOperation.
2011-10-07 Oliver Hunt <oliver@apple.com>
Support string indexing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69671
Reviewed by Gavin Barraclough.
Emit code to support inline indexing of strings
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
Shared code to perform string indexing.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Use compileGetByValOnString if we predict that the base object
is a string in GetByVal.
* runtime/JSString.h:
(JSC::JSString::offsetOfFiberCount):
(JSC::JSString::offsetOfValue):
2011-10-07 Filip Pizlo <fpizlo@apple.com>
DFG ConvertThis speculation logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=69663
Reviewed by Oliver Hunt.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-07 Oliver Hunt <oliver@apple.com>
Verify that our call speculation is valid.
Reviewed by Filip Pizlo.
Before specialising an intrinsic we need to verify that
we our speculation is correct.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
2011-10-07 Brent Fulgham <bfulgham@webkit.org>
[WinCairo] Unreviewed build correction for the build bot.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Add the missing
Release_Cairo_CFLite and Debug_Cairo_CFLite targets so that
build-jsc can find the target it needs to run the JSC tests.
2011-10-07 Oliver Hunt <oliver@apple.com>
Fix 32-bit build.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
2011-10-07 Oliver Hunt <oliver@apple.com>
Support direct calls to intrinsic functions
https://bugs.webkit.org/show_bug.cgi?id=69646
Reviewed by Gavin Barraclough.
Add support for optimising non-method_check calls
to intrinsic functions (eg. when Math.abs, etc are
cached in local variables).
* bytecode/CodeBlock.h:
(JSC::getCallLinkInfoBytecodeIndex):
Support searching CallLinkInfos by bytecode index
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Add support for linked calls in addition to method_check
when searching for intrinsics
* dfg/DFGNode.h:
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::function):
Add ability to store a JSFunction* in a node - this is safe
as the function will be marked by the codeblock we're compiling
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::checkFunctionElimination):
(JSC::DFG::Propagator::performNodeCSE):
Add support for new CheckFunction node, and implement CSE pass.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Rather trivial implementation of CheckFunction
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
Need to propagate bytecode index for calls now.
2011-10-07 Dominic Cooney <dominicc@chromium.org>
[JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
https://bugs.webkit.org/show_bug.cgi?id=69599
Reviewed by Sam Weinig.
DFG JIT manipulates MetaAllocatorHandles across threads, eg in
allocating JITCode buffers on a background thread to execute a
proxy autoconfiguration PAC file but garbage collecting it in
response to allocation on the main thread. Disabling
ThreadRestrictionVerification until there is a verification scheme
that understands this handoff.
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::allocate):
2011-10-06 Filip Pizlo <fpizlo@apple.com>
DFG should not always speculate that ConvertThis is operating on an object
https://bugs.webkit.org/show_bug.cgi?id=69570
Reviewed by Oliver Hunt.
Mostly neutral, but with a slight regression in Kraken since it increases
coverage in DFG and thus reveals some performance pathologies (which I
prefer to think of as performance opportunities, in a good way).
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
* bytecode/PredictedType.h:
(JSC::isOtherPrediction):
(JSC::mergePredictions):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-06 Mark Hahnenberg <mhahnenberg@apple.com>
Windows build fix
Unreviewed build fix. Weird runtime failures on Windows due to
linking issues caused by the ClassInfo struct in JSByteArray not
being declared with JS_EXPORTDATA.
* runtime/JSByteArray.h:
2011-10-06 Filip Pizlo <fpizlo@apple.com>
Structure does not reset m_previous when pinning the property map
https://bugs.webkit.org/show_bug.cgi?id=69583
Reviewed by Gavin Barraclough.
This is an 0.6% performance improvement in V8, and 0.2% overall.
* runtime/Structure.cpp:
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
* runtime/Structure.h:
2011-10-06 Anders Carlsson <andersca@apple.com>
When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
https://bugs.webkit.org/show_bug.cgi?id=69586
Reviewed by Darin Adler.
* Configurations/Base.xcconfig:
Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
* JavaScriptCore.xcodeproj/project.pbxproj:
When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.
* jsc.cpp:
(runInteractive):
Move interpreterName into runInteractive.
* wtf/StdLibExtras.h:
When building with clang, disable the -Wglobal-constructors and -Wexit-time-destructors
warnings around the variable declaration.
2011-10-06 Anders Carlsson <andersca@apple.com>
Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69584
Reviewed by Darin Adler.
Add DEFINE_DEBUG_ONLY_GLOBAL macro.
* wtf/StdLibExtras.h:
2011-10-06 Oliver Hunt <oliver@apple.com>
Write barrier shouldn't allocate temporaries inside control flow
https://bugs.webkit.org/show_bug.cgi?id=69582
Reviewed by Gavin Barraclough.
Reorder the code to avoid spill-related badness.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
2011-10-06 Filip Pizlo <fpizlo@apple.com>
DFG::shouldSpeculate methods are too complicated
https://bugs.webkit.org/show_bug.cgi?id=69560
Reviewed by Geoffrey Garen.
Moved shouldSpeculate methods to DFG::Node, and cleaned them up to
just use node predictions.
By itself this would have meant that SpeculativeJIT code would have
had to say things like m_jit.graph()[nodeIndex].shouldSpeculateXYZ().
So this adds an at(NodeIndex) method to JITCodeGenerator. I replaced
all uses of the m_jit.graph()[nodeIndex] idiom with at(nodeIndex).
This is an 0.4% progression overall that shows up in all benchmarks,
for reasons unknown.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::at):
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::detectPeepHoleBranch):
(JSC::DFG::integerResult):
(JSC::DFG::noResult):
(JSC::DFG::cellResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::storageResult):
(JSC::DFG::doubleResult):
(JSC::DFG::initConstantInfo):
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateDouble):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::shouldSpeculateArrayOrOther):
(JSC::DFG::Node::shouldSpeculateObject):
(JSC::DFG::Node::shouldSpeculateCell):
(JSC::DFG::Node::canSpeculateInteger):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::isKnownString):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
2011-10-06 Gavin Peters <gavinp@chromium.org>
REGRESSION (r96595): First frame in assertion backtraces is no longer labeled "1"
https://bugs.webkit.org/show_bug.cgi?id=69556
Reviewed by Adam Roben.
* wtf/Assertions.cpp:
2011-10-06 Filip Pizlo <fpizlo@apple.com>
DFG implementation of UInt32ToNumber is missing a break statement
https://bugs.webkit.org/show_bug.cgi?id=69552
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-06 Gavin Barraclough <barraclough@apple.com>
Unreviewed build fix for DFG JIT 32_64 release builds.
* dfg/DFGJITCompiler.cpp:
* dfg/DFGJITCompiler.h:
* dfg/DFGJITCompiler32_64.cpp:
- Remove three unused methods.
2011-10-06 Gavin Barraclough <barraclough@apple.com>
DFG JIT 32_64 should check type of values being filled by fillSpeculateInt
https://bugs.webkit.org/show_bug.cgi?id=69549
Reviewed by Oliver Hunt.
This breaks sunspider/3d-cube.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
- Speculation check on the tag.
2011-10-06 Mark Hahnenberg <mhahnenberg@apple.com>
Snow Leopard build fix
Unreviewed build fix
* JavaScriptCore.exp:
2011-10-05 Gavin Barraclough <barraclough@apple.com>
Add explicit JSGlobalThis type.
https://bugs.webkit.org/show_bug.cgi?id=69478
Reviewed by Darin Adler.
JSC supports a split global object, as used by WebCore for the Window. As a stage
of making this visible to JSC, make it so that if the global this value is not the
global object itself, it must be a subclass of JSGlobalThis.
* API/JSCallbackObjectFunctions.h:
(JSC::::finishCreation):
- Don't pass the thisValue to JSGlobalObject::finishCreation.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added JSGlobalThis.h
* jsc.cpp:
(GlobalObject::finishCreation):
- Don't pass the thisValue to JSGlobalObject::finishCreation.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::finishCreation):
- finishCreation takes a JSGlobalThis, or thisValue is implicit.
* runtime/JSGlobalThis.h: Added.
(JSC::JSGlobalThis::create):
(JSC::JSGlobalThis::JSGlobalThis):
(JSC::JSGlobalThis::finishCreation):
- Thin wrapper on JSNonFinalObject to allow type checking.
* testRegExp.cpp:
(GlobalObject::finishCreation):
- Don't pass the thisValue to JSGlobalObject::finishCreation.
2011-10-06 Mark Hahnenberg <mhahnenberg@apple.com>
JSC objects need to know their own cell size at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69390
Reviewed by Geoffrey Garen.
Added the cellSize field to ClassInfo and the static calculation of
size of each class to the CREATE_METHOD_TABLE macro, which will be
renamed in a followup patch to make its name match its broader use.
Also added a few ClassInfo structs so that each object that is allocated has its
correct size.
* JavaScriptCore.exp:
* runtime/ClassInfo.h:
Changed JSByteArray s_defaultInfo to s_info so that the template will get the
correct ClassInfo struct from it when it's allocated.
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.h:
(JSC::allocateCell):
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
(JSC::JSCell::cellSize):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/StrictEvalActivation.cpp:
* runtime/StrictEvalActivation.h:
2011-10-06 Gavin Peters <gavinp@chromium.org>
export new stack dumping method
https://bugs.webkit.org/show_bug.cgi?id=69018
The original landing of bug 69018 didn't export WTFGetBacktrace, so that when bug 69453 landed, the first use
of this function, many builds broke. So here we add the exports, so that the function is usable.
Reviewed by Adam Roben.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-10-06 Csaba Osztrogonác <ossy@webkit.org>
REGRESSION(r96347): Build is broken with MSVC compiler if !PLATFORM(WINDOWS)
https://bugs.webkit.org/show_bug.cgi?id=69413
Reviewed by Darin Adler.
* assembler/MacroAssemblerCodeRef.h: Define STDCALL for MSVC in a proper way.
2011-10-05 Filip Pizlo <fpizlo@apple.com>
SpeculativeJIT::isKnownString() is wrong
https://bugs.webkit.org/show_bug.cgi?id=69501
Reviewed by Oliver Hunt.
Removed the wrong case (GetLocal predicted String) and added a case that
works (StrCat).
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):
2011-10-05 Ryosuke Niwa <rniwa@webkit.org>
Windows build fix attempt after r96760.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-10-05 Chris Rogers <crogers@google.com>
Define a log2f() function for Windows in wtf/MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=69491
Reviewed by Darin Adler.
* wtf/MathExtras.h:
(log2f):
2011-10-05 Jer Noble <jer.noble@apple.com>
Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587
Reviewed by Simon Fraser.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2011-10-05 Filip Pizlo <fpizlo@apple.com>
Assertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
https://bugs.webkit.org/show_bug.cgi?id=69346
Reviewed by Oliver Hunt.
Removed the assertion, since it was completely wrong for op_post_inc.
Short of having specialized PostInc nodes in the DFG, there is no
robust way of asserting what this assertion was trying to assert while
also supporting op_post_inc.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-05 Geoffrey Garen <ggaren@apple.com>
Added a simpler mechanism for registering one-off finalizers
https://bugs.webkit.org/show_bug.cgi?id=69466
Reviewed by Oliver Hunt.
* heap/Heap.cpp:
(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize):
* heap/Heap.h: New function for adding an arbitrary finalizer for an
arbitrary cell without declaring any special classes or Handles yourself.
* JavaScriptCore.exp: Fix build.
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::ExecutableBase::clearCodeVirtual):
(JSC::EvalExecutable::clearCodeVirtual):
(JSC::ProgramExecutable::clearCodeVirtual):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCodeVirtual):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation): Use the new mechanism for eager
finalization of executables.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::clearRareData):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::registerWeakMap): Use the new mechanism for eager
finalization of weak maps.
2011-10-05 Adam Roben <aroben@apple.com>
Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer
RetainPtr's behavior of allowing the template parameter to be either a pointer type or a
pointed-to type confused us when we implemented hashTableDeletedValue.
Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
in HashMap/HashSet fails to compile
Reviewed by John Sullivan.
* wtf/RetainPtr.h:
(WTF::RetainPtr::hashTableDeletedValue): Changed to use the PtrType typedef rather than T*,
since T might itself be a pointer.
(WTF::PtrHash<RetainPtr<P> >): Updated this to use PtrType everywhere, even though T* didn't
seem to be causing a problem.
2011-10-05 Oliver Hunt <oliver@apple.com>
Remove last vestiges of anonymous storage.
Reviewed by Gavin Barraclough.
One anonymous storage function escaped my prior purge of
this feature, this patch removes it.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
* runtime/JSObject.h:
2011-10-04 Filip Pizlo <fpizlo@apple.com>
DFG should be capable of a broader range of speculations on branch and not
https://bugs.webkit.org/show_bug.cgi?id=69322
Reviewed by Oliver Hunt.
* bytecode/PredictedType.h:
(JSC::isFinalObjectOrOtherPrediction):
(JSC::isArrayOrOtherPrediction):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArrayOrOther):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
2011-10-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r96733.
http://trac.webkit.org/changeset/96733
https://bugs.webkit.org/show_bug.cgi?id=69454
Broke GCC for some reason (Requested by andersca on #webkit).
* wtf/ListHashSet.h:
(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):
2011-10-04 Oliver Hunt <oliver@apple.com>
Add rudimentary filtering to write barriers
https://bugs.webkit.org/show_bug.cgi?id=69392
Reviewed by Filip Pizlo.
Add approximate filtering for write barriers based on the
target's mark bit. Also add some macros to support dumping
GC phase timings.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* heap/Heap.cpp:
(JSC::GCTimer::GCTimerScope::GCTimerScope):
(JSC::GCTimer::GCTimerScope::~GCTimerScope):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
Add phase timing information.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::offsetOfMarks):
(JSC::MarkedBlock::gatherDirtyCells):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
2011-10-05 Anders Carlsson <andersca@apple.com>
Use std::reverse_iterator for ListHashSet reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=69446
Reviewed by Darin Adler.
* wtf/ListHashSet.h:
Use the std::reverse_iterator iterator adaptor for the ListHashSet reverse iterators
and get rid of the ListHashSetReverseIterator and ListHashSetConstReverseIterator classes.
2011-10-04 Gavin Barraclough <barraclough@apple.com>
Make Object.prototype getter/setter methods match ES5 behaviour
https://bugs.webkit.org/show_bug.cgi?id=69393
Reviewed by Sam Weinig.
The rest of Object.prototype no longer substitute Null/Undefined with the global object,
this is old ES3 behaviour. Remove it here too.
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
2011-10-05 Patrick Gansterer <paroga@webkit.org>
Get rid of posixThread in MachineStackMarker::Thread
https://bugs.webkit.org/show_bug.cgi?id=54836
Reviewed by Oliver Hunt.
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::getCurrentPlatformThread):
(JSC::equalThread):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):
2011-10-04 Geoffrey Garen <ggaren@apple.com>
Removed JSValue::toJSNumber
https://bugs.webkit.org/show_bug.cgi?id=69399
No perf. change.
toJSNumber() used to provide an implicit fast path for immediate numbers,
but those fast paths are all explicit now, so it's just cruft.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
2011-10-05 Gavin Peters <gavinp@chromium.org>
REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
https://bugs.webkit.org/show_bug.cgi?id=69424
Skip an extra frame in WTFReportBacktrace. As well, I now don't count skipped frames in maxFrames,
so I've updated maxFrames to 31, as with one skipped frame the previous value was effectively
31 reported frames.
Reviewed by Adam Roben.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
2011-10-05 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r96595.
* wtf/Assertions.cpp:
RtlCaptureStackBackTrace() isn't available on WinCE.
2011-10-04 Kent Tamura <tkent@chromium.org>
Introduce feature flags for incomplete input types
https://bugs.webkit.org/show_bug.cgi?id=68971
Reviewed by Hajime Morita.
* Configurations/FeatureDefines.xcconfig:
Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
2011-10-04 Geoffrey Garen <ggaren@apple.com>
Build fix.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use an explicit cast when shortening.
2011-10-04 Mark Hahnenberg <mhahnenberg@apple.com>
Add static ClassInfo structs to classes that override JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311
Reviewed by Darin Adler.
Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
Also added new createStructure methods to those classes that didn't have
them so that the new ClassInfo structs would be used when creating the Structures
in these classes.
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::createStructure):
getCallData was not marked as static in StrictModeTypeErrorFunction.
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::createStructure):
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::createStructure):
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
2011-10-03 Geoffrey Garen <ggaren@apple.com>
Some JSValue cleanup
https://bugs.webkit.org/show_bug.cgi?id=69320
Reviewed by Darin Adler.
No measurable performance change.
Removed some JSValue::get* functions. get* used to be an optimization
when every value operation was a virtual function call: get* would combine
two virtual calls into one. Now, with non-virtual, inlined functions, get*
isn't faster, and may be slightly slower.
Merged getBoolean(bool&) and getBoolean() into asBoolean().
Merged uncheckedGetNumber(), getJSNumber() and getNumber() into
asNumber().
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::asNumber):
(JSC::JSValue::asBoolean): As promised!
* runtime/NumberPrototype.cpp:
(JSC::toThisNumber):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf): Removed a bunch of uses of getJSNumber()
by switching to toThisNumber().
* API/JSCallbackObjectFunctions.h:
(JSC::::toNumber):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/DateInstance.h:
(JSC::DateInstance::internalNumber):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
* runtime/JSArray.cpp:
(JSC::compareNumbersForQSort): Replaced getNumber() => isNumber() / asNumber().
getBoolean() => isBoolean() / asBoolean(), uncheckedGetNumber() => asNumber().
* runtime/JSCell.cpp:
* runtime/JSCell.h: Nixed getJSNumber().
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
* runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
* runtime/NumberObject.cpp:
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/Operations.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd): Replaced getNumber() => isNumber() / asNumber().
getBoolean() => isBoolean() / asBoolean(), uncheckedGetNumber() => asNumber().
2011-10-04 Scott Graham <scottmg@chromium.org>
Add GAMEPAD feature flag
https://bugs.webkit.org/show_bug.cgi?id=66859
Reviewed by Darin Fisher.
* Configurations/FeatureDefines.xcconfig:
2011-10-03 Filip Pizlo <fpizlo@apple.com>
JITCodeGenerator should no longer have code that tries too hard
to be both speculative and non-speculative
https://bugs.webkit.org/show_bug.cgi?id=69321
Reviewed by Gavin Barraclough.
Removed m_isSpeculative and speculationCheck() from JITCodeGenerator.
This required moving emitBranch() to SpeculativeJIT, since it was
the main user of that field and method. Other than trvial clean-ups
in emitBranch(), the code is unchanged (and still has some disparity
between 64 and 32_64, and still lacks some obvious optimizations).
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
2011-10-04 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=69372
[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
Add support for reverse iteration to ListHashSet to support being able to walk them
backwards easily.
Reviewed by Anders Carlsson.
* wtf/ListHashSet.h:
(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):
(WTF::::makeConstIterator):
2011-10-04 Gavin Peters <gavinp@chromium.org>
fix gtk breakage caused by changeset 96595
https://bugs.webkit.org/show_bug.cgi?id=69371
ews did not catch build breakage in the gtk WebKitPluginProcess target; this patch removes
the pretty printer on gtk, which should fix the build on that platform.
Reviewed by NOBODY, this is a build fix.
* wtf/Assertions.cpp:
2011-10-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r96630.
http://trac.webkit.org/changeset/96630
https://bugs.webkit.org/show_bug.cgi?id=69368
Caused assertion failures in validateCell (Requested by
mhahnenberg on #webkit).
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
2011-10-04 Mark Hahnenberg <mhahnenberg@apple.com>
Add static ClassInfo structs to classes that override JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311
Reviewed by Darin Adler.
Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
getCallData was not marked as static is StrictModeTypeErrorFunction.
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
2011-10-04 Ryosuke Niwa <rniwa@webkit.org>
Leopard build fix after r96613.
* wtf/Platform.h:
2011-10-04 Mark Hahnenberg <mhahnenberg@apple.com>
Implicitly add toString and valueOf to prototype when convertToType callback is provided
https://bugs.webkit.org/show_bug.cgi?id=69156
Reviewed by Geoffrey Garen.
Added callbacks for toString and valueOf which are implicitly added to a client object's
prototype if they provide a convertToType callback when declaring their class through
the JSC API.
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackFunction.h:
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/tests/testapi.js:
2011-10-03 Jon Lee <jonlee@apple.com>
Extend DOM WheelEvent to differentiate between physical and logical scroll directions
https://bugs.webkit.org/show_bug.cgi?id=68959
<rdar://problem/10036688>
Reviewed by Sam Weinig.
* wtf/Platform.h: Added HAVE_INVERTED_WHEEL_EVENTS for Lion and later.
2011-10-04 Csaba Osztrogonác <ossy@webkit.org>
MinGW warning fix after r96286.
Avoid redefining STDCALL, because STDCALL is also defined in mingw32/include/windef.h:
#define __stdcall __attribute__((stdcall))
#define STDCALL __stdcall
Reviewed by Tor Arne Vestbø.
* assembler/MacroAssemblerCodeRef.h:
2011-10-04 Gavin Peters <gavinp@chromium.org>
add more stack dumping methods
https://bugs.webkit.org/show_bug.cgi?id=69018
In addition to WTFReportBacktrace, this adds the cross-platform WTFGetBacktrace, which lets
WebKit programmatically retrieve the current stack. This is useful if you need to add more
reporting to field crash report uploads, if you're tracking down an irreproducable bug,
for instance.
Reviewed by Darin Adler.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
2011-10-03 Filip Pizlo <fpizlo@apple.com>
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314
Reviewed by Geoff Garen.
Fix 32-bit.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-03 Filip Pizlo <fpizlo@apple.com>
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314
Reviewed by Oliver Hunt.
1% speed-up in V8 due to 6% speed-up in V8-deltablue.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-03 Filip Pizlo <fpizlo@apple.com>
JSC ASSERT Opening the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=69293
Reviewed by Oliver Hunt.
If a polymorphic access structure list has a duplicated structure, then
don't crash.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
2011-10-03 Gavin Barraclough <barraclough@apple.com>
On X86, switch bucketCount into a register, timeoutCheck into memory
https://bugs.webkit.org/show_bug.cgi?id=69299
Reviewed by Geoff Garen.
We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
function too frequently (regressing performance). This patch has no perf impact on sunspider.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branchAdd32):
(JSC::MacroAssemblerX86::branchSub32):
- Added branchSub32 with AbsoluteAddress.
* jit/JIT.cpp:
(JSC::JIT::emitTimeoutCheck):
- Keep timeout count in memory on X86.
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- remove X86 specific code, switch bucket count back into a register.
* jit/JITStubs.cpp:
- Stop initializing esi (it is no longer the timeoutCheck!)
* jit/JSInterfaceJIT.h:
- change definition of esi to be the bucketCountRegister.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
- Add timeoutCount as a property to global data (the counter should be per-thread).
2011-10-03 Filip Pizlo <fpizlo@apple.com>
DFG backends don't have access to per-node predictions from the propagator
https://bugs.webkit.org/show_bug.cgi?id=69291
Reviewed by Oliver Hunt.
Nodes now have two notion of predictions: the heap prediction, which is
what came directly from value profiling, and the propagator's predictions,
which arise out of abstract interpretation. Every node has a propagator
prediction, but not every node has a heap prediction; and there is no
guarantee that a node that has both will keep them consistent as the
propagator may have additional information available to it.
This is performance neutral.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
(JSC::DFG::Propagator::setReplacement):
2011-10-03 Jer Noble <jer.noble@apple.com>
Unreviewed, rolling out r96526.
http://trac.webkit.org/changeset/96526
https://bugs.webkit.org/show_bug.cgi?id=68587
WEB_AUDIO has numerous 64->32 bit casting warnings, causing
build breakages where -Wall is enabled.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2011-10-03 Gavin Barraclough <barraclough@apple.com>
Unreviewed build fix for DFG JIT 32_64.
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-10-02 Filip Pizlo <fpizlo@apple.com>
DFG should speculate more aggressively on obvious cases on
polymorphic get_by_id
https://bugs.webkit.org/show_bug.cgi?id=69235
Reviewed by Oliver Hunt.
This implements trivial polymorphic get_by_id. It also fixes
problems in the CSE for CheckStructure in the put_by_id
transition case.
Doing this required knowing whether a polymorphic get_by_id stub
was doing a direct access rather than a call of some kind.
Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
scaled mean of all benchmarks.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addStructureSet):
(JSC::DFG::Graph::addStructureTransitionData):
* dfg/DFGNode.h:
(JSC::DFG::StructureTransitionData::StructureTransitionData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::structureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::structureSet):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureSet.h: Added.
(JSC::DFG::StructureSet::StructureSet):
(JSC::DFG::StructureSet::add):
(JSC::DFG::StructureSet::addAll):
(JSC::DFG::StructureSet::remove):
(JSC::DFG::StructureSet::contains):
(JSC::DFG::StructureSet::isSubsetOf):
(JSC::DFG::StructureSet::isSupersetOf):
(JSC::DFG::StructureSet::size):
(JSC::DFG::StructureSet::at):
(JSC::DFG::StructureSet::operator[]):
(JSC::DFG::StructureSet::last):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
2011-10-03 Jer Noble <jer.noble@apple.com>
Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587
Reviewed by Simon Fraser.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2011-10-03 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69243
Reviewed by Martin Robinson.
* GNUmakefile.list.am:
2011-10-03 Pierre Rossi <pierre.rossi@gmail.com>
[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162
Use QString::toHtmlEscaped in the Qt5 case.
Reviewed by Andreas Kling.
* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Added.
(escapeHtml):
* wtf/wtf.pri:
2011-10-03 Balazs Kelemen <kbalazs@webkit.org>
libdispatch based ParallelJobs is not enough parallel
https://bugs.webkit.org/show_bug.cgi?id=66378
Reviewed by Zoltan Herczeg.
Use the appropriate libdispatch API for our use case.
Throw away the hard coded limit of parallel threads
and use dispatch_apply with the default priority normal
queue istead of using our own custom serial queue (which
was a misuse of the API). Enabling PARALLEL_JOBS is now
a 60% win (2.63x as fast) on the methanol benchmark
(https://gitorious.org/methanol) with an SVG centric test set
while the old implementation was almost identical (less than 5% win).
* wtf/ParallelJobsLibdispatch.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
2011-10-02 Zoltan Herczeg <zherczeg@webkit.org>
[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990
Reviewed by Geoffrey Garen.
Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.
* runtime/Structure.h:
(JSC::Structure::transitionCount):
2011-10-02 Filip Pizlo <fpizlo@apple.com>
DFG misses some obvious opportunities for common subexpression elimination
https://bugs.webkit.org/show_bug.cgi?id=69233
Reviewed by Oliver Hunt.
0.7% speed-up on SunSpider.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
2011-10-02 Gavin Barraclough <barraclough@apple.com>
Bug 67455 - Different regular expression result
Reviewed by Darin Adler.
Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchParentheses):
- Simplify some nested if else logic.
(JSC::Yarr::Interpreter::backtrackParentheses):
- Simplify some nested if else logic.
- Only return early from backtrackParentheses on success/error, not on failure.
2011-10-01 Geoffrey Garen <ggaren@apple.com>
Removed redundant helper functions for allocating Strong handles
https://bugs.webkit.org/show_bug.cgi?id=69218
Reviewed by Sam Weinig.
* heap/Heap.h:
(JSC::Heap::handleHeap):
* runtime/JSGlobalData.h: Removed these helper functions, since they
just created indirection.
* heap/StrongInlines.h: Added. Broke out a header for inline functions
to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Go forth and build.
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::setSingleTransition):
* heap/Local.h:
(JSC::::Local):
* heap/Strong.h:
(JSC::::Strong):
(JSC::::set):
* heap/Weak.h:
(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.
* bytecompiler/BytecodeGenerator.cpp:
* runtime/JSGlobalData.cpp:
* runtime/LiteralParser.cpp:
* runtime/RegExpCache.cpp: Updated for header changes.
2011-09-30 Filip Pizlo <fpizlo@apple.com>
All of JSC's heuristics should be in one place for easier tuning
https://bugs.webkit.org/show_bug.cgi?id=69201
Reviewed by Oliver Hunt.
This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.
It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* runtime/Heuristics.cpp: Added.
(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h: Added.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
2011-10-01 Oliver Hunt <oliver@apple.com>
Support string length in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69215
Reviewed by Geoff Garen.
Adds a GetStringLength node to the DFG so that we can support
string.length inline.
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSString.h:
(JSC::JSString::offsetOfLength):
2011-10-01 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69205
Reviewed by Gavin Barraclough.
If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
2011-10-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r96421.
http://trac.webkit.org/changeset/96421
https://bugs.webkit.org/show_bug.cgi?id=69206
It broke Qt-WK2 build (Requested by ossy on #webkit).
* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Removed.
* wtf/wtf.pri:
2011-09-30 Daniel Bates <dbates@webkit.org>
Attempt to fix the Apple Windows and WinCairo Debug builds after
<http://trac.webkit.org/changeset/96446> (https://bugs.webkit.org/show_bug.cgi?id=69203).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove the symbol
?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z since the
corresponding function, JSValue::toStrictThisObject(), was removed.
2011-09-30 Yuqiang Xian <yuqiang.xian@intel.com>
DFG operation results are not set correctly in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69126
Reviewed by Gavin Barraclough.
The setupResults routine has the bug of reversing the source and destination.
Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::setupTwoStubArgs):
(JSC::DFG::setupResults):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
2011-09-30 Gavin Barraclough <barraclough@apple.com>
Remove toStrictThisObject, toThisString, toThisJSString
https://bugs.webkit.org/show_bug.cgi?id=69203
Rubber stamped by Sam Weinig
These are no longer used.
* JavaScriptCore.exp:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSValue.h:
* runtime/StrictEvalActivation.cpp:
* runtime/StrictEvalActivation.h:
2011-09-30 Filip Pizlo <fpizlo@apple.com>
DFG does not speculate aggressively enough on put_by_id
https://bugs.webkit.org/show_bug.cgi?id=69114
Reviewed by Oliver Hunt.
This adds new nodes along with optimizations for those nodes:
GetPropertyStorage: CheckStructure used to do both the structure
check and retrieve the storage pointer. Now CheckStructure just
checks the structure, and GetPropertyStorage retrieves the
storage pointer.
PutStructure: Changes the structure, and has the expected store
to load optimization with CheckStructure.
PutByOffset: Directly sets the value. Has store to load
optimization with GetByOffset.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasStorageAccessData):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::impureCSE):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-30 Gavin Barraclough <barraclough@apple.com>
StringRecursionChecker should not work in terms of EncodedJSValue
https://bugs.webkit.org/show_bug.cgi?id=69188
Reviewed by Oliver Hunt.
0 is not the empty value on 32_64.
Code that casts literals to EncodedJSValues may be unsafe if we change our internal representation.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/StringRecursionChecker.cpp:
(JSC::StringRecursionChecker::throwStackOverflowError):
(JSC::StringRecursionChecker::emptyString):
* runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
(JSC::StringRecursionChecker::earlyReturnValue):
2011-09-30 Gavin Barraclough <barraclough@apple.com>
DFG JIT, Branch on integer can always be a 32-bit compare.
https://bugs.webkit.org/show_bug.cgi?id=69174
Reviewed by Sam Weinig.
if (shouldSpeculateInteger(node.child1()) && !isStrictInt32(node.child1())),
the JSVALUE64 JIT will currently compare all 64bits in the register, but in
these cases the DataFormat is always a JS boxed integer. In these cases we
can just compare the low 32bits anyway - no need to check the tag.
This allows the code to be unified with the JSVALUE32_64 JIT.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-30 Oliver Hunt <oliver@apple.com>
Need a sensible GGC policy
Reviewed by Geoff Garen.
This replaces the existing random collection policy
with a deterministic policy based on nursery size.
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocator):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::nurseryWaterMark):
(JSC::MarkedSpace::allocate):
2011-09-30 Filip Pizlo <fpizlo@apple.com>
DFG 32-bit support for op_call and op_construct causes
run-javascriptcore-tests to fail
https://bugs.webkit.org/show_bug.cgi?id=69171
Reviewed by Gavin Barraclough.
This fixes one obvious bug that was causing test failures (no
support for dummy slow case for op_add in 32_64), and disables
op_call and op_construct by default.
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
2011-09-30 Geoffrey Garen <ggaren@apple.com>
Crash due to out of bounds read/write in MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=69148
This was a case of being surprised by a poorly aritulcated cell size limit,
plus an incorrect ASSERT guarding the cell size limit.
Reviewed by Oliver Hunt.
* heap/MarkedSpace.h:
(JSC::MarkedSpace::sizeClassFor): Changed heap size ranges to be inclusive,
since it makes the ranges easier to understand.
Bumped up the max cell size to support the use case in this bug. Since the
atomSize is much bigger than it used to be, there isn't much accounting
cost to handling more size classes.
Switched to FixedArray, to help catch SizeClass indexing bugs in the future.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeCellLivenessData): Updated for size ranges
being inclusive.
2011-09-30 Pierre Rossi <pierre.rossi@gmail.com>
[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162
Use QString::toHtmlEscaped in the Qt5 case.
Reviewed by Andreas Kling.
* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Added.
(escapeHtml):
* wtf/wtf.pri:
2011-09-30 Yuqiang Xian <yuqiang.xian@intel.com>
Fix bug in getHostCallReturnValue of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69133
Reviewed by Gavin Barraclough.
We need to insert the additional argument in the stack slot before
return address instead of simply pushing it afterwards.
Also getHostCallReturnValue* should be attributed as stdcall
to make the stack cleaned up by the callee.
* dfg/DFGOperations.cpp:
2011-09-30 Pierre Rossi <pierre.rossi@gmail.com>
[Qt] wtf header files are unknown to Qt Creator
https://bugs.webkit.org/show_bug.cgi?id=69158
Adding the HEADERS variable in wtf.pri so that
the header files can be accessed easily.
Reviewed by Andreas Kling.
* wtf/wtf.pri:
2011-09-30 Gavin Barraclough <barraclough@apple.com>
Merge some more of DFGSpeculativeJIT 32_64/64
https://bugs.webkit.org/show_bug.cgi?id=69164
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCodeGenerator64.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
2011-09-30 Mark Hahnenberg <mhahnenberg@apple.com>
Add getCallData to MethodTable in ClassInfo
https://bugs.webkit.org/show_bug.cgi?id=69024
Reviewed by Sam Weinig.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Added the getCallData to the MethodTable in the ClassInfo struct.
* runtime/ClassInfo.h:
2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com>
Add op_call/op_constructor support to JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69120
Reviewed by Gavin Barraclough.
Improve the coverage of JSVALUE32_64 DFG JIT.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::tagOfCallData):
(JSC::DFG::payloadOfCallData):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com>
DFG JIT - register not unlocked after usage in ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=69122
Reviewed by Geoffrey Garen.
Some allocated register is not unlocked after the usage in ArithDiv.
Also there's a typo in "ENBALE_DFG_CONSISTENTCY_CHECK".
* dfg/DFGNode.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-29 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSCell::toObject
https://bugs.webkit.org/show_bug.cgi?id=68937
Reviewed by Darin Adler.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.
* runtime/JSCell.cpp:
(JSC::JSCell::toObject):
* runtime/JSCell.h:
Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
De-virtualized JSObject::toObject and JSString::toObject.
* runtime/JSString.h:
2011-09-29 Gavin Barraclough <barraclough@apple.com>
Start refactoring DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=69112
Reviewed by Oliver Hunt.
Again, move JSVALUE64 code into a DFJSpeculativeJIT64.cpp
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
* dfg/DFGSpeculativeJIT64.cpp: Copied from Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp.
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
2011-09-29 Gavin Barraclough <barraclough@apple.com>
Refactor out trivially duplicated code in DFGJITCodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=69109
Reviewed by Oliver Hunt.
Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp
Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code
in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp.
For some function differences are trivial & make more sense to ifdef individually, and some
Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCodeGenerator64.cpp: Copied from Source/JavaScriptCore/dfg/DFGJITCodeGenerator.cpp.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotCell):
* dfg/DFGJITCompilerInlineMethods.h:
2011-09-28 Filip Pizlo <fpizlo@apple.com>
DFG JIT should infer which uses of a variable are not aliased
https://bugs.webkit.org/show_bug.cgi?id=68593
Reviewed by Oliver Hunt.
This separates how a variable is stored (i.e. its virtual register)
from how it's predicted. Each variable now takes a
VariableAccessData as its operand, instead of the virtual register.
The VariableAccessData stores the operand and the prediction. If
multiple uses of a variable are aliased, their VariableAccessDatas
are unified.
This also adds tracking of which argument values are used. It
correctly observes that an argument value is not used, if the
argument is assigned to inside the function before being used.
This also adds tracking of which variables are live at the head of
a basic block, and separates that from a variable being live at the
tail.
Finally, this communicates to both OSR entry and OSR exit code how
a variable is predicted at a particular point in the code, rather
than just communicating how it was predicted in the entire code
block (since with this patch there is no longer the notion of a
variable having just one prediction for a code block).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/ActionablePrediction.h: Added.
(JSC::actionablePredictionFromPredictedType):
(JSC::valueObeysPrediction):
(JSC::actionablePredictionToString):
(JSC::ActionablePredictions::ActionablePredictions):
(JSC::ActionablePredictions::setArgument):
(JSC::ActionablePredictions::argument):
(JSC::ActionablePredictions::setVariable):
(JSC::ActionablePredictions::variable):
(JSC::ActionablePredictions::argumentUpperBound):
(JSC::ActionablePredictions::variableUpperBound):
(JSC::ActionablePredictions::pack):
(JSC::ActionablePredictions::packVector):
* bytecode/CodeBlock.h:
* bytecode/PredictionTracker.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::nameOfVariableAccessData):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::operandIsArgument):
(JSC::DFG::VariableRecord::setFirstTime):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::local):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueSource::nodeIndexFromKind):
(JSC::DFG::ValueSource::kindFromNodeIndex):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* wtf/PackedIntVector.h: Added.
(WTF::PackedIntVector::PackedIntVector):
(WTF::PackedIntVector::operator=):
(WTF::PackedIntVector::size):
(WTF::PackedIntVector::ensureSize):
(WTF::PackedIntVector::resize):
(WTF::PackedIntVector::clearAll):
(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):
(WTF::PackedIntVector::mask):
* wtf/Platform.h:
* wtf/UnionFind.h: Added.
(WTF::UnionFind::UnionFind):
(WTF::UnionFind::find):
(WTF::UnionFind::unify):
2011-09-29 Oliver Hunt <oliver@apple.com>
Build fix.
* heap/AllocationSpace.h:
2011-09-29 Oliver Hunt <oliver@apple.com>
Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100
Reviewed by Geoff Garen.
This gives us the ability to walk all the MarkedBlocks in an
AllocationSpace and collect the dirty objects, and then use
them as GC roots.
I also rearranged the order of these instructions because it
makes them smaller on some platforms with some card sizes.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* heap/AllocationSpace.cpp:
Tidy up the write barrier logic a bit.
(JSC::MarkedBlock::gatherDirtyObjects):
(JSC::TakeIfDirty::returnValue):
(JSC::TakeIfDirty::TakeIfDirty):
(JSC::TakeIfDirty::operator()):
(JSC::AllocationSpace::gatherDirtyObjects):
* heap/AllocationSpace.h:
* heap/CardSet.h:
(JSC::::isCardMarked):
(JSC::::clearCard):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC::Heap::writeBarrier):
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
* heap/SlotVisitor.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
Tidy the write barrier a bit.
2011-09-29 Gavin Barraclough <barraclough@apple.com>
Unreviewed windows build fix.
* assembler/MacroAssemblerCodeRef.h:
* dfg/DFGOperations.h:
2011-09-29 Filip Pizlo <fpizlo@apple.com>
Structure transitions involving many (> 64) properties sometimes cause structure corruption
https://bugs.webkit.org/show_bug.cgi?id=69102
Reviewed by Darin Adler.
Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
don't lead to the dictionary kind being forgotten.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com>
DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058
Reviewed by Gavin Barraclough.
Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
2011-09-29 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=68839
Reviewed by Geoffrey Garen.
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
* API/JSCallbackObject.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/Executable.cpp:
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
* runtime/GetterSetter.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
* runtime/JSPropertyNameIterator.cpp:
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSValue.h:
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/Structure.cpp:
* runtime/Structure.h:
* runtime/StructureChain.cpp:
* runtime/StructureChain.h:
Inlined the method table access and call to the visitChildren function (the only call sites
to visitChildren are here).
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
Changed the field name for the visitChildren function pointer to visitChildren (from
visitChildrenFunctionPtr) to make call sites less verbose.
* runtime/ClassInfo.h:
Discovered JSBoundFunction doesn't have its own ClassInfo (it used JSFunction's ClassInfo) but
overrides visitChildren, so it needs to have its own ClassInfo.
* runtime/JSBoundFunction.cpp:
* runtime/JSBoundFunction.h:
Had to move className up to make sure that the virtual destructor in JSObject wasn't
the first non-inline virtual method in JSObject (as per the comment in the file).
Also moved JSCell::visitChildrenVirtual into JSObject.h in order for it be inline-able
to mitigate the cost of an extra method call.
Also added a convenience accessor function methodTable() to JSCell to return the MethodTable to make
call sites more concise. Implementation is inline in JSObject.h.
* runtime/JSObject.h:
(JSC::JSCell::methodTable):
* runtime/JSCell.h:
Added an out of line virtual destructor to JSWrapperObject and ScopeChainNode to
appease the vtable gods. It refused to compile if there were no virtual methods in
both of these classes due to the presence of a weak vtable pointer.
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::~JSWrapperObject):
* runtime/JSWrapperObject.h:
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::~ScopeChainNode):
* runtime/ScopeChain.h:
2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com>
Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69075
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com>
JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054
Reviewed by Gavin Barraclough.
size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.
* dfg/DFGNode.h:
2011-09-28 Filip Pizlo <fpizlo@apple.com>
DFG checkArgumentTypes fails to check boolean predictions
https://bugs.webkit.org/show_bug.cgi?id=69059
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
2011-09-28 Gavin Barraclough <barraclough@apple.com>
Build fix pt 2 for r96286.
* assembler/MacroAssemblerCodeRef.h:
2011-09-28 Ryosuke Niwa <rniwa@webkit.org>
Build fix attempt for r96286.
* assembler/MacroAssemblerCodeRef.h:
2011-09-28 Gavin Barraclough <barraclough@apple.com>
DFG JIT Operations on 32_64 should use stdcall calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69046
Reviewed by Sam Weinig.
All calls out are expecting stdcall conventions, but the default on OS X are cdecl.
Leave D_DFGOperation_DD calls as the one exception, since we want to be able to link
directly to std library functions like fmod - leave these calls obeying the default
platform calling convention.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- Add implicit constructors for std calls.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- Make this work non-Mac platforms.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
* dfg/DFGOperations.h:
- Mark all operations as stdcalls.
2011-09-28 Filip Pizlo <fpizlo@apple.com>
DFG JIT falls back on numerical comparisons when it does not
recognize a prediction
https://bugs.webkit.org/show_bug.cgi?id=68977
Reviewed by Geoffrey Garen.
This fixes both the way comparison implementations are selected. It
also fixes a bug where comparisons other than equality (like < or >)
on objects are compiled as if the comparison was equality.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
2011-09-28 Gavin Barraclough <barraclough@apple.com>
Implement callOperation(D_DFGOperation_DD) for DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=69026
Reviewed by Sam Weinig.
* assembler/X86Assembler.h:
(JSC::X86Assembler::fstpl):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
2011-09-28 Gavin Barraclough <barraclough@apple.com>
Merge bug#68580, bug#68932 for DFG JIT with JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=69017
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
2011-09-28 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- These methods should throw if this value is undefined.
2011-09-27 Yuqiang Xian <yuqiang.xian@intel.com>
Value profiling in baseline JIT for JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=68750
Reviewed by Geoff Garen.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
* jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
2011-09-28 Yuqiang Xian <yuqiang.xian@intel.com>
Wrong integer checks in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68985
Reviewed by Geoffrey Garen.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
2011-09-28 Adam Barth <abarth@webkit.org>
Remove empty directories.
* wtf/brew: Removed.
* wtf/unicode/brew: Removed.
2011-09-27 Filip Pizlo <fpizlo@apple.com>
DFG JIT cannot compile op_new_object, op_new_array,
op_new_array_buffer, or op_new_regexp
https://bugs.webkit.org/show_bug.cgi?id=68580
Reviewed by Oliver Hunt.
This implements all four opcodes, but has op_new_regexp turns off
by default because it unveils some bad speculation logic when
compiling string-validate-input.
With op_new_regexp turned off, this is a 5% win on Kraken and a
0.7% speed-up on V8. Neutral on SunSpider.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::regexpIndex):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownArray):
2011-09-27 Filip Pizlo <fpizlo@apple.com>
DFG JIT should speculate more aggressively on reads of array.length
https://bugs.webkit.org/show_bug.cgi?id=68932
Reviewed by Oliver Hunt.
This is a 2% speed-up on Kraken, neutral elsewhere.
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-27 Gavin Barraclough <barraclough@apple.com>
DFG JIT - merge changes between 95905 - 96175
https://bugs.webkit.org/show_bug.cgi?id=68963
Reviewed by Sam Weinig.
Merge missing changes from bug#68677, bug#68784, bug#68785.
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-27 Gavin Barraclough <barraclough@apple.com>
Get JSVALUE32_64 DFG JIT building on OS X.
https://bugs.webkit.org/show_bug.cgi?id=68961
Reviewed by Geoff Garen.
* Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file).
* Forward-declare functions in DFGOperations.cpp
* UNUSED_PARAM for unused arguments
* NO_RETURN for unimplemented function that ASSERT_NOT_REACHED
* Fix argument types handled by OpInfo constructor.
* Use SYMBOL_STRING instead of STRINGIZE for asm symbols.
* Add files to Xcode project.
2011-09-27 Yuqiang Xian <yuqiang.xian@intel.com>
Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68755
Reviewed by Gavin Barraclough.
We need to load/store and repatch both tag and payload of a property
for GetById/PutById. Also reorder the loads of tag and payload for
GetByOffset as the result tag GPR could reuse the storage GPR.
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-24 Gavin Barraclough <barraclough@apple.com>
Macro assembler branch8 & 16 methods vary in treatment of upper bits
https://bugs.webkit.org/show_bug.cgi?id=68301
Reviewed by Sam Weinig.
Fix for branch16 - remove it!
No performance impact.
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerSH4.h:
* assembler/MacroAssemblerX86Common.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
2011-09-27 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallDataVirtual):
(JSC::JSCallbackFunction::getCallData):
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getCallDataVirtual):
(JSC::::getCallData):
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getCallDataVirtual):
(JSC::ArrayConstructor::getCallData):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getCallDataVirtual):
(JSC::BooleanConstructor::getCallData):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getCallDataVirtual):
(JSC::DateConstructor::getCallData):
* runtime/DateConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getCallDataVirtual):
(JSC::ErrorConstructor::getCallData):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallDataVirtual):
(JSC::FunctionConstructor::getCallData):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::getCallDataVirtual):
(JSC::FunctionPrototype::getCallData):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getCallDataVirtual):
(JSC::JSCell::getCallData):
* runtime/JSCell.h:
(JSC::getCallData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getCallDataVirtual):
(JSC::JSFunction::getCallData):
* runtime/JSFunction.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getCallDataVirtual):
(JSC::NativeErrorConstructor::getCallData):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getCallDataVirtual):
(JSC::NumberConstructor::getCallData):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getCallDataVirtual):
(JSC::ObjectConstructor::getCallData):
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getCallDataVirtual):
(JSC::RegExpConstructor::getCallData):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getCallDataVirtual):
(JSC::StringConstructor::getCallData):
* runtime/StringConstructor.h:
2011-09-27 Tim Horton <timothy_horton@apple.com>
Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
https://bugs.webkit.org/show_bug.cgi?id=68816
<rdar://problem/10186468>
Reviewed by Simon Fraser.
Add ByteArray::clear, which zeros the memory in the ByteArray.
* wtf/ByteArray.h:
(WTF::ByteArray::clear): Added.
2011-09-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r96131.
http://trac.webkit.org/changeset/96131
https://bugs.webkit.org/show_bug.cgi?id=68927
It made 18+ tests crash on all platform (Requested by
Ossy_night on #webkit).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
* jsc.cpp:
(GlobalObject::finishCreation):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
2011-09-27 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSCell::getPrimitiveNumber
https://bugs.webkit.org/show_bug.cgi?id=68851
Reviewed by Darin Adler.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Changed JSCell::getPrimitiveNumber to manually handle the dispatch for
JSCells (JSObject and JSString in this case).
* runtime/JSCell.cpp:
(JSC::JSCell::getPrimitiveNumber):
* runtime/JSCell.h:
Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't
matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
can cover the case for JSNotAnObject.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber
and changed them to be const. Also made JSString::getPrimitiveNumber public
because it needs to be called from JSCell::getPrimitiveNumber and also since it's
no longer virtual, we want people who have a more specific pointer (JSString*
instead of JSCell*) to not have to pay the cost of a virtual method call.
* runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
* runtime/JSObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getPrimitiveNumber):
* runtime/JSString.h:
2011-09-27 Juan Carlos Montemayor Elosua <j.mont@me.com>
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Reviewed by Oliver Hunt.
This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
2011-09-27 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616
Reviewed by Martin Robinson.
Install header files under $libwebkitgtkincludedir/JavaScriptCore.
* GNUmakefile.am: Use $libwebkitgtkincludedir.
* javascriptcoregtk.pc.in: Use webkitgtk-<api-version> as include dir.
2011-09-26 Geoffrey Garen <ggaren@apple.com>
REGRESSION (r95912): Conservative marking doesn't filter out pointers to
MarkedBlock metadata
https://bugs.webkit.org/show_bug.cgi?id=68860
Reviewed by Oliver Hunt.
Bencher says no performance change, maybe a 7% speedup on kraken-imaging-darkroom.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::isAtomAligned): Renamed atomMask to atomAlignment mask
because the mask doesn't produce the actual atom number.
(JSC::MarkedBlock::isLiveCell): Testing just for alignment isn't good
enough; we also need to test that a pointer is beyond the metadata section
of a MarkedBlock, to avoid treating random metadata as a JSCell.
2011-09-26 Mark Hahnenberg <mhahnenberg@apple.com>
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727
Reviewed by Geoffrey Garen.
JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
2011-09-26 Chris Marrin <cmarrin@apple.com>
Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397
Reviewed by Simon Fraser.
Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
* wtf/Platform.h:
2011-09-26 Noel Gordon <noel.gordon@gmail.com>
[Chromium] Remove DFGAliasTracker.h references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=68787
Reviewed by Geoffrey Garen.
DFG/DFGAliasTracker.h was removed in r95389. Cleanup (remove) references
to that file from the gyp project files.
* JavaScriptCore.gypi:
2011-09-26 Zoltan Herczeg <zherczeg@webkit.org>
[Qt]REGRESSION(r95865): It made 4 tests crash
https://bugs.webkit.org/show_bug.cgi?id=68780
Reviewed by Oliver Hunt.
emitJumpSlowCaseIfNotJSCell(...) cannot be moved
away since the next load depends on it.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
2011-09-25 Mark Hahnenberg <mhahnenberg@apple.com>
Add custom vtable struct to ClassInfo struct
https://bugs.webkit.org/show_bug.cgi?id=68567
Reviewed by Oliver Hunt.
Declared/defined the MethodTable struct and added it to the ClassInfo struct.
Also defined the CREATE_METHOD_TABLE macro to generate these method tables
succinctly where they need to be defined.
Also added to it the first function to use this macro, visitChildren.
This is part of the process of getting rid of all C++ virtual methods in JSCell.
Eventually all virtual functions in JSCell that can't easily be converted to
non-virtual functions will be put into this custom vtable structure.
* runtime/ClassInfo.h:
Added the CREATE_METHOD_TABLE macro call as the last argument to each of the
ClassInfo structs declared in these classes. This saves us from having to visit
each s_info definition in the future when we add more methods to the MethodTable.
* API/JSCallbackConstructor.cpp:
* API/JSCallbackFunction.cpp:
* API/JSCallbackObject.cpp:
* JavaScriptCore.exp:
* runtime/Arguments.cpp:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayPrototype.cpp:
* runtime/BooleanObject.cpp:
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/DateInstance.cpp:
* runtime/DatePrototype.cpp:
* runtime/ErrorInstance.cpp:
* runtime/ErrorPrototype.cpp:
* runtime/ExceptionHelpers.cpp:
* runtime/Executable.cpp:
* runtime/GetterSetter.cpp:
* runtime/InternalFunction.cpp:
* runtime/JSAPIValueWrapper.cpp:
* runtime/JSActivation.cpp:
* runtime/JSArray.cpp:
* runtime/JSByteArray.cpp:
* runtime/JSFunction.cpp:
* runtime/JSGlobalObject.cpp:
* runtime/JSONObject.cpp:
* runtime/JSObject.cpp:
* runtime/JSPropertyNameIterator.cpp:
* runtime/JSString.cpp:
* runtime/MathObject.cpp:
* runtime/NativeErrorConstructor.cpp:
* runtime/NumberConstructor.cpp:
* runtime/NumberObject.cpp:
* runtime/NumberPrototype.cpp:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectPrototype.cpp:
* runtime/RegExp.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.cpp:
* runtime/RegExpPrototype.cpp:
* runtime/ScopeChain.cpp:
* runtime/StringConstructor.cpp:
* runtime/StringObject.cpp:
* runtime/StringPrototype.cpp:
* runtime/Structure.cpp:
* runtime/StructureChain.cpp:
Had to make visitChildren and visitChildrenVirtual protected instead of private
because some of the subclasses of JSWrapperObject need access to JSWrapperObject's
visitChildren function pointer in their vtable since they don't provide their own
implementation. Same for RegExpObject.
* runtime/JSWrapperObject.h:
* runtime/RegExpObject.h:
2011-09-25 Adam Barth <abarth@webkit.org>
Finish removing PLATFORM(BREWMP) by removing associated code
https://bugs.webkit.org/show_bug.cgi?id=68779
Reviewed by Sam Weinig.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
* wscript:
* wtf/FastMalloc.cpp:
(WTF::fastMallocSize):
* wtf/Vector.h:
* wtf/brew: Removed.
* wtf/brew/MainThreadBrew.cpp: Removed.
* wtf/brew/OwnPtrBrew.cpp: Removed.
* wtf/brew/RefPtrBrew.h: Removed.
* wtf/brew/ShellBrew.h: Removed.
* wtf/brew/StringBrew.cpp: Removed.
* wtf/brew/SystemMallocBrew.h: Removed.
* wtf/unicode/brew: Removed.
* wtf/unicode/brew/UnicodeBrew.cpp: Removed.
* wtf/unicode/brew/UnicodeBrew.h: Removed.
2011-09-25 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not count speculation successes correctly
https://bugs.webkit.org/show_bug.cgi?id=68785
Reviewed by Geoffrey Garen.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGOperations.cpp:
2011-09-25 Filip Pizlo <fpizlo@apple.com>
DFG support for op_resolve_global is not enabled
https://bugs.webkit.org/show_bug.cgi?id=68786
Reviewed by Geoffrey Garen.
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
2011-09-25 Filip Pizlo <fpizlo@apple.com>
DFG static prediction code is no longer needed and should be removed
https://bugs.webkit.org/show_bug.cgi?id=68784
Reviewed by Oliver Hunt.
This gets rid of static prediction code, and ensures that we do not
try to compile code where dynamic predictions are not available.
This is accomplished by immediately performing an OSR exit wherever
a value is retrieved for which no predictions exist.
This also adds value profiling for this on functions used for calls.
The heuristics for deciding when to optimize code are also tweaked,
since it is now profitable to optimize sooner. This may need to be
tweaked further, but this patch only makes minimal changes.
This results in a 16% speed-up on Kraken/ai-astar, leading to a 3%
overall win on Kraken. It's neutral elsewhere.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
* bytecode/PredictedType.h:
(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::mergePredictions):
* bytecode/PredictionTracker.h:
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
* bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeUpdatedPrediction):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::emitBranch):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::valueOfJSConstantNode):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::predict):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
2011-09-25 Filip Pizlo <fpizlo@apple.com>
DFG JIT Construct opcode takes a this argument even though it's
not passed
https://bugs.webkit.org/show_bug.cgi?id=68782
Reviewed by Oliver Hunt.
This is performance-neutral, mostly. It's a slight speed-up on
v8-splay.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
2011-09-25 Filip Pizlo <fpizlo@apple.com>
DFG tracking of the value in cachedResultRegister does not handle
op_mov correctly
https://bugs.webkit.org/show_bug.cgi?id=68781
Reviewed by Oliver Hunt.
This takes the simplest approach: it makes the old JIT dumber rather
than making the DFG JIT smarter. This is performance-neutral.
* jit/JIT.h:
(JSC::JIT::canBeOptimized):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
2011-09-25 Adam Barth <abarth@webkit.org>
Remove PLATFORM(HAIKU) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68774
Reviewed by Sam Weinig.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
* heap/MachineStackMarker.cpp:
* wtf/PageAllocation.h:
* wtf/Platform.h:
* wtf/StackBounds.cpp:
* wtf/haiku: Removed.
* wtf/haiku/MainThreadHaiku.cpp: Removed.
* wtf/haiku/StringHaiku.cpp: Removed.
* wtf/text/WTFString.h:
2011-09-24 Adam Barth <abarth@webkit.org>
Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=68767
Reviewed by Eric Seidel.
* Configurations/FeatureDefines.xcconfig:
2011-09-24 Filip Pizlo <fpizlo@apple.com>
JIT implementation of put_by_val increments m_length instead of setting
it to index+1
https://bugs.webkit.org/show_bug.cgi?id=68766
Reviewed by Geoffrey Garen.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
2011-09-24 Geoffrey Garen <ggaren@apple.com>
More build fixage.
* heap/ConservativeRoots.cpp: Our system of #includes, it is chaos.
2011-09-24 Filip Pizlo <fpizlo@apple.com>
The DFG should not attempt to guess types in the absence of value
profiles
https://bugs.webkit.org/show_bug.cgi?id=68677
Reviewed by Oliver Hunt.
This adds the ForceOSRExit node, which is ignored by the propagator
and virtual register allocator (and hence ensuring that liveness analysis
works correctly), but forces terminateSpeculativeExecution() in the
back-end. This appears to be a slight speed-up on benchmark averages,
with ~5% swings on individual benchmarks, in both directions. But it's
never a regression on any average, and appears to be a ~1% progression
in the SunSpider average.
This also adds a bit better debugging support in the old JIT and in DFG,
as this was necessary to debug the much more frequent OSR transitions
that occur with this change.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
2011-09-24 Geoffrey Garen <ggaren@apple.com>
Some Windows build fixage.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::isLive): Show the compiler that all control paths
return a value. There, there, compiler. Everything's going to be OK.
* runtime/JSCell.h:
(JSC::JSCell::setVPtr): Oops! Unrename this function.
2011-09-24 Geoffrey Garen <ggaren@apple.com>
Allocate new objects unmarked
https://bugs.webkit.org/show_bug.cgi?id=68764
Reviewed by Oliver Hunt.
This is a pre-requisite to using the mark bit to determine object age.
~2% v8 speedup, mostly due to a 12% v8-splay speedup.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::isLive):
(JSC::MarkedBlock::isLiveCell): These two functions are the reason for
this patch. They can now determine object liveness without relying on
newly allocated objects having their mark bits set. Each MarkedBlock
now has a state variable that tells us how to determine whether its
cells are live. (This new state variable supercedes the old one about
destructor state. The rest of this patch is just refactoring to support
the invariants of this new state variable without introducing a
performance regression.)
(JSC::MarkedBlock::didConsumeFreeList): New function for updating interal
state when a block becomes fully allocated.
(JSC::MarkedBlock::clearMarks): Folded a state change to 'Marked' into
this function because, logically, clearing all mark bits is the first
step in saying "mark bits now exactly reflect object liveness".
(JSC::MarkedBlock::markCountIsZero): Renamed from isEmpty() to clarify
that this function only tells you about the mark bits, so it's only
meaningful if you've put the mark bits into a meaningful state before
calling it.
(JSC::MarkedBlock::forEachCell): Changed to use isLive() helper function
instead of testing mark bits, since mark bits are not always the right
way to find out if an object is live anymore. (New objects are live, but
not marked.)
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock): Folded all initialization -- even
initialization when recycling an old block -- into the MarkedBlock
constructor, for simplicity.
(JSC::MarkedBlock::callDestructor): Inlined for speed. Always check for
a zapped cell before running a destructor, and always zap after
running a destructor. This does not seem to be expensive, and the
alternative just creates a too-confusing matrix of possible cell states
((zombie undestructed cell + zombie destructed cell + zapped destructed
cell) * 5! permutations for progressing through block states = "Oh my!").
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep): Maintained and expanded a pre-existing
optimization to use template specialization to constant fold lots of
branches and elide certain operations entirely during a sweep. Merged
four or five functions that were logically about sweeping into this one
function pair, so there's only one way to do things now, it's
automatically correct, and it's always fast.
(JSC::MarkedBlock::zapFreeList): Renamed this function to be more explicit
about exactly what it does, and to honor the new block state system.
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateBlock): Updated for rename.
(JSC::AllocationSpace::freeBlocks): Updated for changed interface.
(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue): Just like isEmpty() above, renamed
to clarify that this functor only tests the mark bits, so it's only
valid if you've put the mark bits into a meaningful state before
calling it.
(JSC::AllocationSpace::shrink): Updated for rename.
* heap/AllocationSpace.h:
(JSC::AllocationSpace::canonicalizeCellLivenessData): Renamed to be a
little more specific about what we're making canonical.
(JSC::AllocationSpace::forEachCell): Updated for rename.
(JSC::AllocationSpace::forEachBlock): No need to canonicalize cell
liveness data before iterating blocks -- clients that want iterated
blocks to have valid cell lieveness data should make this call for
themselves. (And not all clients want it.)
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer): Updated for rename. Removed
obsolete comment.
* heap/Heap.cpp:
(JSC::CountFunctor::ClearMarks::operator()): Removed call to notify...()
because clearMarks() now does that implicitly.
(JSC::Heap::destroy): Make sure to canonicalize before tear-down, since
tear-down tests cell liveness when running destructors.
(JSC::Heap::markRoots):
(JSC::Heap::collect): Moved weak reference harvesting out of markRoots()
and into collect, since it strictly depends on root marking, and does
not contribute to root marking.
(JSC::Heap::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.
* heap/Heap.h:
(JSC::Heap::forEachProtectedCell): No need to canonicalize cell liveness
data before iterating protected cells, since we know they're all live,
and don't need to test for it.
* heap/Local.h:
(JSC::::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock): Updated for interface change.
(JSC::MarkedSpace::canonicalizeCellLivenessData): Renamed to be a little more
specific about what we're making canonical.
* heap/MarkedSpace.h:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::zapFreeList): Simplified this allocator
functionality a bit. We now track only one block -- "currentBlock" --
and rely on its internal state to know whether it has more cells to
allocate.
* heap/Weak.h:
(JSC::Weak::set): Can't make the same ASSERT we used to because we just don't
have the mark bits for it anymore. Perhaps we can bring this ASSERT back
in a weaker form in the future.
* runtime/JSCell.h:
(JSC::JSCell::vptr):
(JSC::JSCell::zap):
(JSC::JSCell::isZapped):
(JSC::isZapped): Made zapping a property of JSCell, for a little abstraction.
In the future, exactly how a JSCell zaps itself will change, as the
internal representation of JSCell changes.
2011-09-24 Filip Pizlo <fpizlo@apple.com>
DFG JIT should not eagerly initialize integer tags in the register file
https://bugs.webkit.org/show_bug.cgi?id=68763
Reviewed by Oliver Hunt.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
2011-09-23 Yuqiang Xian <yuqiang.xian@intel.com>
Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460
Reviewed by Gavin Barraclough.
This is the initial attempt to add JSVALUE32_64 support to DFG JIT.
It's tested on IA32 Linux EFL port currently. It still cannot run
all the test cases and benchmarks so should be turned off now.
The major work includes:
1) dealing with JSVALUE32_64 data format in DFG JIT;
2) bindings between 64-bit JS Value and 32-bit registers;
3) handling of function calls. Currently for DFG operation function
calls we follow the X86 cdecl calling convention on Linux, and the
implementation is in a naive way by pushing the arguments into stack
one by one.
The known issues include:
1) some code duplicates unnecessarily, especially in Speculative JIT
code generation, where most of the operations on SpeculataInteger /
SpeculateDouble should be identical to the JSVALUE64 code. Refactoring
is needed in the future;
2) lack of op_call and op_construct support, comparing to current
JSVALUE64 DFG;
3) currently integer speculations assume to be StrictInt32;
4) lack of JSBoolean speculations;
5) boxing and unboxing doubles could be improved;
6) DFG X86 register description is different with the baseline JIT,
the timeoutCheckRegister is used for general purpose usage;
7) calls to runtime functions with primitive double parameters (e.g.
fmod) don't work. Support needs to be added to the assembler to
implement the mechanism of passing double parameters for X86 cdecl
convention.
And there should be many other hidden bugs which should be exposed and
resolved in later debugging process.
* CMakeListsEfl.txt:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::loadDouble):
(JSC::MacroAssemblerX86::storeDouble):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movsd_rm):
* bytecode/StructureStubInfo.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::tagGPR):
(JSC::DFG::GenerationInfo::payloadGPR):
(JSC::DFG::GenerationInfo::fpr):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillDouble):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::allocate):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::registersMatched):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::addressOfDoubleConstant):
(JSC::DFG::integerResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::setupResults):
(JSC::DFG::callOperation):
(JSC::JSValueOperand::JSValueOperand):
(JSC::JSValueOperand::~JSValueOperand):
(JSC::JSValueOperand::isDouble):
(JSC::JSValueOperand::fill):
(JSC::JSValueOperand::tagGPR):
(JSC::JSValueOperand::payloadGPR):
(JSC::JSValueOperand::fpr):
(JSC::GPRTemporary::~GPRTemporary):
(JSC::GPRTemporary::gpr):
(JSC::GPRResult2::GPRResult2):
* dfg/DFGJITCodeGenerator32_64.cpp: Added.
(JSC::DFG::JITCodeGenerator::clearGenerationInfo):
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::JITCodeGenerator::useChildren):
(JSC::DFG::JITCodeGenerator::isStrictInt32):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
(JSC::DFG::JITCodeGenerator::emitCall):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::dataFormatString):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCompiler.cpp:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagForGlobalVar):
(JSC::DFG::JITCompiler::payloadForGlobalVar):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGJITCompiler32_64.cpp: Added.
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
(JSC::DFG::JITCompiler::jitAssertIsCell):
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
* dfg/DFGJITCompilerInlineMethods.h: Added.
(JSC::DFG::JITCompiler::emitLoadTag):
(JSC::DFG::JITCompiler::emitLoadPayload):
(JSC::DFG::JITCompiler::emitLoad):
(JSC::DFG::JITCompiler::emitLoad2):
(JSC::DFG::JITCompiler::emitLoadDouble):
(JSC::DFG::JITCompiler::emitLoadInt32ToDouble):
(JSC::DFG::JITCompiler::emitStore):
(JSC::DFG::JITCompiler::emitStoreInt32):
(JSC::DFG::JITCompiler::emitStoreCell):
(JSC::DFG::JITCompiler::emitStoreBool):
(JSC::DFG::JITCompiler::emitStoreDouble):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inPair):
(JSC::DFG::ValueRecovery::tagGPR):
(JSC::DFG::ValueRecovery::payloadGPR):
* dfg/DFGSpeculativeJIT32_64.cpp: Added.
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* runtime/JSValue.h:
2011-09-23 Filip Pizlo <fpizlo@apple.com>
wtf/BitVector.h has a variety of bugs which manifest when the
vector grows beyond 63 bits
https://bugs.webkit.org/show_bug.cgi?id=68746
Reviewed by Oliver Hunt.
Out-of-lined slow path code in BitVector so that not every user
of CodeBlock ends up having to compile it. Fixed a variety of
index computation and size computation bugs.
I have not seen these issues manifest themselves, but they are
blocking a patch that uses BitVector more aggressively.
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/BitVector.cpp: Added.
(BitVector::BitVector):
(BitVector::operator=):
(BitVector::resize):
(BitVector::clearAll):
(BitVector::OutOfLineBits::create):
(BitVector::OutOfLineBits::destroy):
(BitVector::resizeOutOfLine):
* wtf/BitVector.h:
(WTF::BitVector::ensureSize):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::byteCount):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::outOfLineBits):
* wtf/CMakeLists.txt:
* wtf/wtf.pri:
2011-09-23 Adam Klein <adamk@chromium.org>
Add ENABLE_MUTATION_OBSERVERS feature flag
https://bugs.webkit.org/show_bug.cgi?id=68732
Reviewed by Ojan Vafai.
This flag will guard an implementation of the "Mutation Observers" proposed in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
* Configurations/FeatureDefines.xcconfig:
2011-09-23 Mark Hahnenberg <mhahnenberg@apple.com>
De-virtualize JSCell::getJSNumber
https://bugs.webkit.org/show_bug.cgi?id=68651
Reviewed by Oliver Hunt.
Added a new JSType to check whether or not something is a
NumberObject (which includes NumberPrototype) in TypeInfo::isNumberObject because there's not
currently a better way to determine whether something is indeed a NumberObject.
Also de-virtualized JSCell::getJSNumber, having it check the TypeInfo
for whether the object is a NumberObject or not. This patch is part of
the larger process of de-virtualizing JSCell.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::getJSNumber):
* runtime/JSCell.h:
(JSC::JSValue::getJSNumber):
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::isNumberObject):
* runtime/JSValue.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::getJSNumber):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
2011-09-23 Filip Pizlo <fpizlo@apple.com>
Resolve opcodes should have value profiling.
https://bugs.webkit.org/show_bug.cgi?id=68723
Reviewed by Oliver Hunt.
This adds value profiling to all forms of op_resolve in the
old JIT, and patches that information into the DFG along with
performing the appropriate type propagation.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasPrediction):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
* jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
2011-09-23 Oliver Hunt <oliver@apple.com>
Fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-09-23 Gavin Barraclough <barraclough@apple.com>
Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740
Reviewed by Oliver Hunt.
Function-info caching does not preserve all state that it should.
* parser/JSParser.cpp:
(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::parseFunctionInfo):
* parser/SourceProviderCacheItem.h:
2011-09-23 Filip Pizlo <fpizlo@apple.com>
ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=68724
Reviewed by Oliver Hunt.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
2011-09-23 Oliver Hunt <oliver@apple.com>
Build fix.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-09-23 Filip Pizlo <fpizlo@apple.com>
DFG implementation of PutScopedVar corrupts register allocation
https://bugs.webkit.org/show_bug.cgi?id=68735
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-23 Oliver Hunt <oliver@apple.com>
Make write barriers actually do something when enabled
https://bugs.webkit.org/show_bug.cgi?id=68717
Reviewed by Geoffrey Garen.
Add a basic card marking style write barrier to JSC (currently
turned off). This requires two scratch registers in the JIT
so there was some register re-arranging to satisfy that requirement.
Happily this produced a minor perf bump in sunspider (~0.5%).
Turning the barriers on causes an overall regression of around 1.5%
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movb_i8m):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotCell):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::markCellCard):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/CardSet.h: Added.
(JSC::CardSet::CardSet):
(JSC::::cardForAtom):
(JSC::::cardMarkedForAtom):
(JSC::::markCardForAtom):
* heap/Heap.cpp:
* heap/Heap.h:
(JSC::Heap::addressOfCardFor):
(JSC::Heap::writeBarrierFastCase):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
(JSC::MarkedBlock::offsetOfCards):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
2011-09-23 Thouraya ANDOLSI <thouraya.andolsi@st.com>
https://bugs.webkit.org/show_bug.cgi?id=68077
SH4 assemblers doesn't refer to executable memory handle.
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branch8):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
2011-09-23 Oliver Hunt <oliver@apple.com>
PutScopedVar nodes should report that it has a var number
https://bugs.webkit.org/show_bug.cgi?id=68721
Reviewed by Anders Carlsson.
Another assertion fix.
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
2011-09-23 Oliver Hunt <oliver@apple.com>
Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716
Reviewed by Darin Adler.
Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
2011-09-23 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildrenVirtual):
(JSC::JSCallbackObject::visitChildren):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildrenVirtual):
(JSC::DebuggerActivation::visitChildren):
* debugger/DebuggerActivation.h:
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildrenVirtual):
(JSC::Arguments::visitChildren):
* runtime/Arguments.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildrenVirtual):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildrenVirtual):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildrenVirtual):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildrenVirtual):
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildrenVirtual):
(JSC::JSActivation::visitChildren):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildrenVirtual):
(JSC::JSArray::visitChildren):
* runtime/JSArray.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::visitChildrenVirtual):
(JSC::JSBoundFunction::visitChildren):
* runtime/JSBoundFunction.h:
* runtime/JSCell.h:
(JSC::JSCell::visitChildrenVirtual):
(JSC::JSCell::visitChildren):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildrenVirtual):
(JSC::JSFunction::visitChildren):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildrenVirtual):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildrenVirtual):
(JSC::JSObject::visitChildren):
* runtime/JSObject.h:
(JSC::JSObject::visitChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildrenVirtual):
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildrenVirtual):
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSStaticScopeObject.h:
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildrenVirtual):
(JSC::JSWrapperObject::visitChildren):
* runtime/JSWrapperObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildrenVirtual):
(JSC::NativeErrorConstructor::visitChildren):
* runtime/NativeErrorConstructor.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildrenVirtual):
(JSC::RegExpObject::visitChildren):
* runtime/RegExpObject.h:
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildrenVirtual):
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
* runtime/Structure.cpp:
(JSC::Structure::visitChildrenVirtual):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildrenVirtual):
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
2011-09-23 Oliver Hunt <oliver@apple.com>
Node propagation doesn't handle PutScopedVar
https://bugs.webkit.org/show_bug.cgi?id=68713
Reviewed by Sam Weinig.
This was causing assertion failures.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
2011-09-23 Anders Carlsson <andersca@apple.com>
Make sure to define OVERRIDE and FINAL for older builds of clang.
* wtf/Compiler.h:
2011-09-23 Gavin Barraclough <barraclough@apple.com>
Implement op_resolve_global in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68704
Reviewed by Oliver Hunt.
This is performance neutral, but increases coverage.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveInfoIndex):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-23 Mark Rowe <mrowe@apple.com>
Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h.
* wtf/Platform.h:
2011-09-22 Anders Carlsson <andersca@apple.com>
We should add support for OVERRIDE and FINAL annotations
https://bugs.webkit.org/show_bug.cgi?id=68654
Reviewed by David Hyatt.
Add OVERRIDE and FINAL macros for compilers that support them.
* wtf/Compiler.h:
2011-09-22 Filip Pizlo <fpizlo@apple.com>
GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676
Reviewed by Oliver Hunt.
Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasPrediction):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
2011-09-22 Filip Pizlo <fpizlo@apple.com>
PPC build fix, part 3.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForConstructInternal):
2011-09-22 Filip Pizlo <fpizlo@apple.com>
Another PPC build fix.
* runtime/Executable.cpp:
* runtime/Executable.h:
2011-09-22 Dean Jackson <dino@apple.com>
Add ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=68652
Reviewed by Simon Fraser.
* Configurations/FeatureDefines.xcconfig:
2011-09-22 Gavin Barraclough <barraclough@apple.com>
Incorrect this value passed to callbacks.
https://bugs.webkit.org/show_bug.cgi?id=68668
Reviewed by Oliver Hunt.
From Array/String prototype function. Should be undefined, but
global object is passed instead (this is visible for strict callbacks).
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
* runtime/JSArray.cpp:
(JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
(JSC::JSArray::sort):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
2011-09-22 Gavin Barraclough <barraclough@apple.com>
Function.prototype.bind.length shoudl be 1.
Rubber stamped by Olier Hunt.
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
2011-09-22 Filip Pizlo <fpizlo@apple.com>
PPC build fix.
* bytecode/CodeBlock.h:
2011-09-22 Gavin Barraclough <barraclough@apple.com>
Windows build fix pt. 2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-09-22 Gavin Barraclough <barraclough@apple.com>
Windows build fix pt. 1
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-09-21 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not support to_primitive or strcat
https://bugs.webkit.org/show_bug.cgi?id=68582
Reviewed by Darin Adler.
This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.
When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::scratchBufferForSize):
2011-09-22 Filip Pizlo <fpizlo@apple.com>
DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597
Reviewed by Darin Adler.
This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).
This is a 4% win on Kraken and a 1% loss on V8.
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
2011-09-22 Oliver Hunt <oliver@apple.com>
Implement put_scoped_var in the DFG jit
https://bugs.webkit.org/show_bug.cgi?id=68653
Reviewed by Gavin Barraclough.
Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-22 Gavin Barraclough <barraclough@apple.com>
Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382
Reviewed by Sam Weinig.
This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* jsc.cpp:
(GlobalObject::addFunction):
* runtime/CommonIdentifiers.h:
* runtime/ConstructData.h:
* runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
* runtime/FunctionPrototype.h:
* runtime/JSBoundFunction.cpp: Added.
(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):
* runtime/JSBoundFunction.h: Added.
(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundFunctionStructure):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
2011-09-22 Oliver Hunt <oliver@apple.com>
Implement get_scoped_var in the DFG
https://bugs.webkit.org/show_bug.cgi?id=68640
Reviewed by Gavin Barraclough.
Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-22 Adam Roben <aroben@apple.com>
Remove FindSafari from all our .sln files
It isn't used anymore, so there's no point in building it.
Part of <http://webkit.org/b/68628> Remove FindSafari
Reviewed by Steve Falkenburg.
* JavaScriptCore.vcproj/JavaScriptCore.sln:
2011-09-22 Filip Pizlo <fpizlo@apple.com>
32-bit call code clobbers the function cell tag
https://bugs.webkit.org/show_bug.cgi?id=68606
Reviewed by Csaba Osztrogonác.
This is a minimalistic fix: it simply emits code to restore the
cell tag on the slow path, if we know that we failed due to
emitCallIfNotType.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCallSlowCase):
2011-09-21 Gavin Barraclough <barraclough@apple.com>
Add missing addPtr->add32 mapping for X86.
Rubber stamped by Sam Weinig.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::addPtr):
2011-09-21 Gavin Barraclough <barraclough@apple.com>
Add missing addDouble for AbsoluteAddress to X86
Rubber stamped by Geoff Garen.
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::addDouble):
* assembler/X86Assembler.h:
(JSC::X86Assembler::addsd_mr):
(JSC::X86Assembler::cvtsi2sd_rr):
(JSC::X86Assembler::cvtsi2sd_mr):
2011-09-21 Gavin Barraclough <barraclough@apple.com>
Build fix following fix for bug #68586.
* jit/JIT.cpp:
* jit/JITInlineMethods.h:
2011-09-21 Filip Pizlo <fpizlo@apple.com>
DFG JIT should be able to compile op_throw
https://bugs.webkit.org/show_bug.cgi?id=68571
Reviewed by Geoffrey Garen.
This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-21 Filip Pizlo <fpizlo@apple.com>
DFG should support continuous optimization
https://bugs.webkit.org/show_bug.cgi?id=68329
Reviewed by Geoffrey Garen.
This adds the ability to reoptimize a code block if speculation
failures happen frequently. 6% speed-up on Kraken, 1% slow-down
on V8, neutral on SunSpider.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getStrongPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
(JSC::DFG::getOSREntryDataBytecodeIndex):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
(JSC::ConservativeRoots::add):
* heap/ConservativeRoots.h:
* heap/Heap.cpp:
(JSC::Heap::addJettisonCodeBlock):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/JettisonedCodeBlocks.cpp: Added.
(JSC::JettisonedCodeBlocks::JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::~JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::addCodeBlock):
(JSC::JettisonedCodeBlocks::clearMarks):
(JSC::JettisonedCodeBlocks::deleteUnmarkedCodeBlocks):
(JSC::JettisonedCodeBlocks::traceCodeBlocks):
* heap/JettisonedCodeBlocks.h: Added.
(JSC::JettisonedCodeBlocks::mark):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
* interpreter/RegisterFile.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):
* runtime/Executable.h:
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
* wtf/BitVector.h: Added.
(WTF::BitVector::BitVector):
(WTF::BitVector::~BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::size):
(WTF::BitVector::ensureSize):
(WTF::BitVector::resize):
(WTF::BitVector::clearAll):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::bitsInPointer):
(WTF::BitVector::maxInlineBits):
(WTF::BitVector::byteCount):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::OutOfLineBits::numBits):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::OutOfLineBits::create):
(WTF::BitVector::OutOfLineBits::destroy):
(WTF::BitVector::OutOfLineBits::OutOfLineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::bits):
2011-09-21 Gavin Barraclough <barraclough@apple.com>
Add X86 GPRInfo for DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=68586
Reviewed by Geoff Garen.
* dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
2011-09-21 Gavin Barraclough <barraclough@apple.com>
Should support value profiling on CPU(X86)
https://bugs.webkit.org/show_bug.cgi?id=68575
Reviewed by Sam Weinig.
Fix verbose profiling in ToT (SlowCaseProfile had been
partially renamed to RareCaseProfile), add in-memory
bucket counter for CPU(X86), move JIT::m_canBeOptimized
out of the DFG_JIT ifdef.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
2011-09-21 Filip Pizlo <fpizlo@apple.com>
DFG does not support compiling functions as constructors
https://bugs.webkit.org/show_bug.cgi?id=68500
Reviewed by Oliver Hunt.
This adds support for compiling constructors to the DFG. It's a
1% speed-up on V8, mostly due to a 6% speed-up on early-boyer.
It's also a 13% win on access-binary-trees, but it's neutral in
the SunSpider and Kraken averages.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):
2011-09-21 Gavin Barraclough <barraclough@apple.com>
Replace jsFunctionVPtr compares with a type check on the Structure.
https://bugs.webkit.org/show_bug.cgi?id=68557
Reviewed by Oliver Hunt.
This will permit calls to still optimize to subclasses of JSFunction
that have the correct type (but a different C++ vptr).
This patch stops passing the globalData into numerous functions.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotType):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.h:
(JSC::isHostFunction):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
* runtime/JSObject.h:
(JSC::getJSFunction):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/JSType.h:
2011-09-21 Geoffrey Garen <ggaren@apple.com>
Removed WTFTHREADDATA_MULTITHREADED, making it always true
https://bugs.webkit.org/show_bug.cgi?id=68549
Reviewed by Darin Adler.
Another part of making threads exist in WebKit.
* wtf/WTFThreadData.cpp:
* wtf/WTFThreadData.h:
(WTF::wtfThreadData):
2011-09-21 Dan Bernstein <mitz@apple.com>
JavaScriptCore Part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
https://bugs.webkit.org/show_bug.cgi?id=68451
Reviewed by Darin Adler.
* JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase that invokes
check-for-inappropriate-objc-class-names, allowing only class names prefixed with "JS".
2011-09-20 Gavin Barraclough <barraclough@apple.com>
MacroAssembler fixes.
https://bugs.webkit.org/show_bug.cgi?id=68494
Reviewed by Sam Weinig.
Add X86-64's 3 operand or32 to other MacroAssembler, fix load32's [const] void* mismatch
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::loadPtr):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::or32):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::load32):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::load32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::load32):
2011-09-20 Geoffrey Garen <ggaren@apple.com>
Some Heap cleanup.
Reviewed by Beth Dakin.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::blessNewBlock): Removed blessNewBlockForSlowPath()
because it was unused; renamed blessNewBlockForFastPath() to blessNewBlock()
since there is only one now.
* heap/MarkedBlock.h: Removed ownerSet-related stuff since it was unused.
Updated mark bit overhead calculation. Deployed atomsPerBlock in one
place where we were recalculating it.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::addBlock): Updated for rename.
2011-09-20 Filip Pizlo <fpizlo@apple.com>
DFG JIT always speculates integer on modulo
https://bugs.webkit.org/show_bug.cgi?id=68485
Reviewed by Oliver Hunt.
Added support for double modulo, which is a call to fmod().
Also added support for recording the old JIT's statistics
on op_mod and propagating them along the graph. Finally,
fixed a goof in the ArithNodeFlags propagation logic that
was made obvious when I started testing ArithMod.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-20 ChangSeok Oh <shivamidow@gmail.com>
[GTK] requestAnimationFrame support for gtk port
https://bugs.webkit.org/show_bug.cgi?id=66280
Reviewed by Martin Robinson.
Let GTK port use REQUEST_ANIMATION_FRAME_TIMER.
* wtf/Platform.h:
2011-09-20 Filip Pizlo <fpizlo@apple.com>
DFG JIT performs too many negative zero checks, and too many
overflow checks
https://bugs.webkit.org/show_bug.cgi?id=68430
Reviewed by Oliver Hunt.
This adds comprehensive support for deciding how to perform an
arithmetic operations based on a combination of overflow profiling,
negative zero profiling, value profiling, and a static analysis of
how the results of these operations get used.
This is a 72% speed-up on stanford-crypto-sha256-iterative, and a
2.5% speed-up on the Kraken average, a 1.4% speed-up on the V8
geomean, and neutral on SunSpider. It's also an 8.5% speed-up on
V8-crypto, because apparenty everything we do speeds up crypto.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isSmallInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::weaklyPredictInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
* dfg/DFGNode.h:
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::arithNodeFlagsAsString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::rawArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::arithNodeFlagsForCompare):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
2011-09-19 Oliver Hunt <oliver@apple.com>
Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409
Reviewed by Gavin Barraclough.
This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/AllocationSpace.cpp: Added.
(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):
* heap/AllocationSpace.h: Added.
(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):
* heap/Heap.h:
(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):
2011-09-19 Geoffrey Garen <ggaren@apple.com>
Removed BREWMP* platform #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68425
BREWMP* has no maintainer, and this is dead code.
Reviewed by Darin Adler.
* heap/MarkStack.h:
(JSC::::shrinkAllocation):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/CurrentTime.cpp:
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastMallocSize):
* wtf/FastMalloc.h:
* wtf/MainThread.cpp:
* wtf/MathExtras.h:
* wtf/OwnPtrCommon.h:
* wtf/Platform.h:
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
* wtf/text/WTFString.h:
* wtf/unicode/Unicode.h:
2011-09-20 Adam Roben <aroben@apple.com>
Windows build fix after r95523
* wtf/CheckedArithmetic.h: Added stdint.h so we can have int64_t defined.
2011-09-18 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not speculate aggressively enough on GetById
https://bugs.webkit.org/show_bug.cgi?id=68320
Reviewed by Oliver Hunt.
This adds the ability to access properties directly, by offset.
This optimization kicks in when at the time of DFG compilation,
it appears that the given get_by_id is self-cached by the old JIT.
Two new opcodes get introduced: CheckStructure and GetByOffset.
CheckStructure performs a speculation check on the object's
structure, and returns the storage pointer. GetByOffset performs
a direct read of the field from the storage pointer. Both
CheckStructure and GetByOffset can be CSE'd, so that we can
eliminate redundant structure checks, and redundant reads of the
same field.
This is a 4% speed-up on V8, a 2% slow-down on Kraken, and
neutral on SunSpider.
* bytecode/PredictedType.cpp:
(JSC::predictionFromClassInfo):
(JSC::predictionFromStructure):
(JSC::predictionFromCell):
* bytecode/PredictedType.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::fillStorage):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::GPRTemporary::GPRTemporary):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::storageResult):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
* dfg/DFGNode.h:
(JSC::DFG::OpInfo::OpInfo):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::structure):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::storageAccessDataIndex):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* wtf/StdLibExtras.h:
(WTF::safeCast):
2011-09-19 Mark Hahnenberg <mhahnenberg@apple.com>
Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875
Reviewed by Darin Adler.
Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
* runtime/JSCell.h:
We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
2011-09-19 Geoffrey Garen <ggaren@apple.com>
Removed ENABLE_LAZY_BLOCK_FREEING and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68424
As discussed on webkit-dev. All ports build with threads enabled in JSC now.
This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.
Reviewed by Mark Rowe.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):
* heap/Heap.h:
* wtf/Platform.h:
2011-09-19 Geoffrey Garen <ggaren@apple.com>
Removed ENABLE_WTF_MULTIPLE_THREADS and related #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68423
As discussed on webkit-dev. All ports build with threads enabled in WTF now.
This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.
Reviewed by Mark Rowe.
* wtf/CryptographicallyRandomNumber.cpp:
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
* wtf/FastMalloc.cpp:
* wtf/Platform.h:
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RefCountedLeakCounter.cpp:
(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/dtoa.cpp:
(WTF::pow5mult):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading):
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading):
2011-09-19 Geoffrey Garen <ggaren@apple.com>
Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=68422
As discussed on webkit-dev. All ports build with threads enabled in JSC now.
This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.
Reviewed by Sam Weinig.
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
* API/JSContextRef.cpp:
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::gatherConservativeRoots):
* heap/MachineStackMarker.h:
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
(JSC::initializeThreading):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::makeUsableFromMultipleThreads):
* runtime/JSLock.cpp:
* runtime/Structure.cpp:
* wtf/Platform.h:
2011-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r95493 and r95496.
http://trac.webkit.org/changeset/95493
http://trac.webkit.org/changeset/95496
https://bugs.webkit.org/show_bug.cgi?id=68418
Broke Windows build (Requested by rniwa on #webkit).
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/AllocationSpace.cpp: Removed.
* heap/AllocationSpace.h: Removed.
* heap/Heap.cpp:
(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):
* heap/Heap.h:
(JSC::Heap::markedSpace):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):
2011-09-19 Gavin Barraclough <barraclough@apple.com>
Errrk, missed stylebot comments in last commit.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
2011-09-19 Gavin Barraclough <barraclough@apple.com>
String#split is buggy
https://bugs.webkit.org/show_bug.cgi?id=68348
Reviewed by Sam Weinig.
* runtime/StringPrototype.cpp:
(JSC::jsStringWithReuse):
- added helper function to reuse original JSString value.
(JSC::stringProtoFuncSplit):
- Rewritten from the spec.
* tests/mozilla/ecma/String/15.5.4.8-2.js:
(getTestCases):
- This test is not ES5 compliant.
2011-09-19 Geoffrey Garen <ggaren@apple.com>
Removed lots of friend declarations from JSCell, so we can more
effectively make use of private and protected.
Reviewed by Sam Weinig.
* runtime/JSCell.h: Removed MSVCBugWorkaround because it was a lot of
confusion for not much safety.
(JSC::JSCell::operator new): Made this public because it is used by a
few clients, and not really dangerous.
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
* runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasCustomProperties):
(JSC::JSObject::hasGetterSetterProperties):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::finishCreation):
(JSC::JSObject::prototype):
(JSC::JSObject::setPrototype):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect): Changed all use of m_structure to
structure() / setStructure(), so we don't have to be a friend of JSCell.
* runtime/Structure.h:
(JSC::JSCell::setStructure): Added, to avoid direct access by JSObject
to JSCell::m_structure.
2011-09-19 Adam Barth <abarth@webkit.org>
Always enable ENABLE(EVENTSOURCE)
https://bugs.webkit.org/show_bug.cgi?id=68414
Reviewed by Eric Seidel.
* Configurations/FeatureDefines.xcconfig:
2011-09-19 Eli Fidler <efidler@rim.com>
Enable JSC_MULTIPLE_THREADS for OS(QNX).
https://bugs.webkit.org/show_bug.cgi?id=68047
Reviewed by Daniel Bates.
SA_RESTART was required for SIGUSR2-based debugging, but is not
present on QNX. This debugging doesn't seem critical to
JSC_MULTIPLE_THREADS, so allow it to proceed.
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):
* wtf/Platform.h: enable PTHREADS for OS(QNX)
2011-09-19 Oliver Hunt <oliver@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-09-19 Oliver Hunt <oliver@apple.com>
Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409
Reviewed by Gavin Barraclough.
This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/AllocationSpace.cpp: Added.
(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):
* heap/AllocationSpace.h: Added.
(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):
* heap/Heap.h:
(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):
2011-09-19 Adam Roben <aroben@apple.com>
Windows build fix after r95310
* JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added
include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.
2011-09-19 Filip Pizlo <fpizlo@apple.com>
DFG speculation failures should act as additional value profiles
https://bugs.webkit.org/show_bug.cgi?id=68335
Reviewed by Oliver Hunt.
This adds slow-case counters to the old JIT. It also ensures that
negative zero in multiply is handled carefully. The old JIT
previously took slow path if the result of a multiply was zero,
which, without any changes, would cause the DFG to think that
every such multiply produced a double result.
This also fixes a bug in the old JIT's handling of decrements. It
would take the slow path if the result was zero, but not if it
underflowed.
By itself, this would be a 1% slow-down on V8 and Kraken. But then
I wrote optimizations in the DFG that take advantage of this new
information. It's no longer the case that every multiply needs to
do a check for negative zero; it only happens if the negative
zero is ignored.
This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
speed-up in V8. It's mostly neutral on Kraken. I can see an
0.5% slow-down and it appears to be significant.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* bytecode/ValueProfile.h:
(JSC::RareCaseProfile::RareCaseProfile):
(JSC::getRareCaseProfileBytecodeOffset):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::linkDummySlowCase):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
* jit/JITInlineMethods.h:
(JSC::JIT::addSlowCase):
2011-09-19 Adam Roben <aroben@apple.com>
Windows build fix after r94575
* JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp
now builds just before FindSafari.
2011-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r95466.
http://trac.webkit.org/changeset/95466
https://bugs.webkit.org/show_bug.cgi?id=68389
Incorrect version of the patch. (Requested by mhahnenberg on
#webkit).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toPrimitive):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toPrimitive):
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
2011-09-19 Mark Hahnenberg <mhahnenberg@apple.com>
Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875
Reviewed by Geoffrey Garen.
Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
* runtime/JSCell.h:
We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSValue::toPrimitive):
2011-09-19 Oliver Hunt <oliver@apple.com>
Build fix.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetDirectOffset):
2011-09-19 Oliver Hunt <oliver@apple.com>
Rename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=68376
Reviewed by Gavin Barraclough.
Renamed the the MarkedSpace files to match new name, and
updated the relevant references.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.h:
* heap/MarkedSpace.cpp: Renamed from Source/JavaScriptCore/heap/NewSpace.cpp.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):
* heap/MarkedSpace.h: Renamed from Source/JavaScriptCore/heap/NewSpace.h.
(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):
* runtime/JSCell.h:
2011-09-19 Oliver Hunt <oliver@apple.com>
Rename NewSpace to MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=68375
Reviewed by Gavin Barraclough.
Rename NewSpace to a more accurate name, and update all uses.
This patch doesn't rename the files themselves as that will
just make the patch appear bigger than it is.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::isValidAllocation):
(JSC::Heap::shrink):
* heap/Heap.h:
(JSC::Heap::markedSpace):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):
* heap/NewSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):
* heap/NewSpace.h:
(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
2011-09-19 Peter Rybin <peter.rybin@gmail.com>
TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
https://bugs.webkit.org/show_bug.cgi?id=63541
Reviewed by Adam Barth.
* parser/SourceProvider.h:
(JSC::SourceProvider::startPosition):
* wtf/text/TextPosition.h:
(WTF::OrdinalNumber::fromZeroBasedInt):
(WTF::OrdinalNumber::fromOneBasedInt):
(WTF::OrdinalNumber::OrdinalNumber):
(WTF::OrdinalNumber::zeroBasedInt):
(WTF::OrdinalNumber::oneBasedInt):
(WTF::OrdinalNumber::operator==):
(WTF::OrdinalNumber::operator!=):
(WTF::OrdinalNumber::first):
(WTF::OrdinalNumber::beforeFirst):
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):
2011-09-19 Dan Bernstein <mitz@apple.com>
JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323
Reviewed by Sam Weinig.
Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):
2011-09-19 Oliver Hunt <oliver@apple.com>
Remove direct property slot pointers from the instruction stream
https://bugs.webkit.org/show_bug.cgi?id=68373
Reviewed by Gavin Barraclough.
Use an indirect load to access prototype properties rather than directly
storing the property address in the instruction stream. This should allow
further optimisations in future, and also provides a 0.5% win to sunspider.
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetDirectOffset):
* runtime/JSObject.h:
(JSC::JSObject::addressOfPropertyStorage):
2011-09-19 Oliver Hunt <oliver@apple.com>
Remove bump allocator
https://bugs.webkit.org/show_bug.cgi?id=68370
Reviewed by Sam Weinig.
Can't do anything with this allocator currently, and it's
increasing the complexity of the GC code. Slight progression
on SunSpider, slight regression (undoing the original progression)
in V8.
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
(JSC::NewSpace::allocate):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::visitChildrenDirect):
* runtime/StorageBarrier.h:
(JSC::StorageBarrier::set):
2011-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68346
Reviewed by Philippe Normand.
* GNUmakefile.list.am:
2011-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68241
Reviewed by Martin Robinson.
* GNUmakefile.list.am:
2011-09-18 Dan Bernstein <mitz@apple.com>
Removed ProfilerServer.
Reviewed by Mark Rowe.
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj:
* profiler/ProfilerServer.h: Removed.
* profiler/ProfilerServer.mm: Removed.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* wscript:
2011-09-17 Filip Pizlo <fpizlo@apple.com>
DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318
Reviewed by Gavin Barraclough.
Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
2011-09-18 Nico Weber <thakis@chromium.org>
Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327
Unreviewed, build warning fix.
* JavaScriptCore.gypi:
2011-09-17 Oliver Hunt <oliver@apple.com>
Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319
Reviewed by Gavin Barraclough.
Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage. This has no
perf impact.
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):
2011-09-17 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316
Reviewed by Oliver Hunt.
This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.
This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAliasTracker.h: Removed.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-16 Filip Pizlo <fpizlo@apple.com>
method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294
Reviewed by Gavin Barraclough.
Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.
This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/Structure.h:
(JSC::Structure::transitivelyTransitionedFrom):
2011-09-16 Ryosuke Niwa <rniwa@webkit.org>
Touch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).
* wtf/Platform.h:
2011-09-16 Sam Weinig <sam@webkit.org>
Rename APIValueWrapper type to APIValueWrapperType for consistency
https://bugs.webkit.org/show_bug.cgi?id=68306
Reviewed by Anders Carlsson.
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
Update name.
* runtime/JSType.h:
Update name and un-indent.
* runtime/Structure.h:
(JSC::JSCell::isAPIValueWrapper):
Update name.
2011-09-16 Sam Weinig <sam@webkit.org>
Remove unused isStrictModeFunction function
https://bugs.webkit.org/show_bug.cgi?id=68305
Reviewed by Anders Carlsson.
* runtime/JSObject.h:
(JSC::JSObject::isStrictModeFunction):
2011-09-16 Sam Weinig <sam@webkit.org>
Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289
Reviewed by Anders Carlsson.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.
* runtime/JSObject.h:
(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.
(JSC::TypeInfo::isFinalObject):
Added.
(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
Use new isFinalObject() predicate.
2011-09-16 Gavin Barraclough <barraclough@apple.com>
Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166
Reviewed by Geoff Garen.
The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate). The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
2011-09-16 Geoffrey Garen <ggaren@apple.com>
Removed undetectable style.filter.
Reviewed by Sam Weinig.
This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSTypeInfo.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
2011-09-15 Sam Weinig <sam@webkit.org>
Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200
Reviewed by Gavin Barraclough.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
* runtime/JSObject.h:
(JSC::JSObject::finishCreation):
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/Operations.cpp:
(JSC::jsIsObjectType):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::isObject):
(JSC::JSCell::isObject):
2011-09-16 Geoffrey Garen <ggaren@apple.com>
Rolled back in r95201 with test failure fixed.
I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.
* jit/JIT.h:
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32):
2011-09-16 Filip Pizlo <fpizlo@apple.com>
Unreviewed Windows build fix after 95318.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-09-16 Adam Roben <aroben@apple.com>
Windows build fix after r95310
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added include\private\JavaScriptCore to the
include path so DFGIntrinsic.h can be found.
2011-09-16 Gavin Barraclough <barraclough@apple.com>
Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274
Reviewed by Sam Weinig.
Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.
* JavaScriptCore.exp:
* jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
* runtime/JSObject.h:
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::lookupPut):
2011-09-16 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for Windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
2011-09-16 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for non-DFG builds.
* runtime/Executable.h:
(JSC::NativeExecutable::finishCreation):
2011-09-16 Filip Pizlo <fpizlo@apple.com>
DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227
Reviewed by Oliver Hunt.
This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.
On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.
Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h
This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.
* JavaScriptCore.xcodeproj/project.pbxproj:
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
* dfg/DFGIntrinsic.h: Added.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/DateInstanceCache.h:
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
2011-09-16 Filip Pizlo <fpizlo@apple.com>
REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220
Reviewed by Oliver Hunt.
Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.
* heap/Heap.cpp:
(JSC::Heap::markRoots):
2011-09-16 Csaba Osztrogonác <ossy@webkit.org>
REGRESSION(r95201): It made two tests fail
https://bugs.webkit.org/show_bug.cgi?id=68230
Unreviewed rolling out r95201.
* jit/JIT.h:
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
* jit/JITInlineMethods.h:
2011-09-15 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not optimize method_check
https://bugs.webkit.org/show_bug.cgi?id=68215
Reviewed by Oliver Hunt.
MethodCallLinkInfo and StructureStubInfo are now searchable by
bytecodeIndex, so that DFG::ByteCodeParser can use that information
to determine how to optimize GetMethod.
A new node op has been added to DFG: CheckMethod. This is a variant
of GetMethod that has been optimized for the case that GetMethod
always takes the fast path. CheckMethod results in only a very
small amount of code (two loads and two branches in the worst case,
one load and one branch in the best case). CheckMethod behaves as
if it were a constant.
Introduced the notion that a DFG node that is not JSConstant
behaves as a constant. CheckMethod uses this functionality.
This is a 3% speed-up on Kraken, and a small speed-up on V8.
Appears to be neutral on SunSpider.
* bytecode/CodeBlock.h:
(JSC::getStructureStubInfoBytecodeIndex):
(JSC::getMethodCallLinkInfoBytecodeIndex):
* bytecode/PredictedType.cpp:
(JSC::predictionFromCell):
(JSC::predictionFromValue):
* bytecode/PredictedType.h:
* bytecode/StructureStubInfo.h:
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordGetMethod):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfJSConstantNode):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasMethodCheckData):
(JSC::DFG::Node::methodCheckDataIndex):
(JSC::DFG::Node::valueOfJSConstant):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::structureAddress):
2011-09-15 Adam Barth <abarth@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=68205
Reviewed by Eric Seidel.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2011-09-15 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (7/7)
https://bugs.webkit.org/show_bug.cgi?id=68122
Reviewed by Geoffrey Garen.
Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
JSCallbackObject was missed in previous patches due to the fact that
it's non-obvious (at least to my script) that it is in the JSCell hierarchy, so
this is just a bit of retroactive cleanup.
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
2011-09-15 Filip Pizlo <fpizlo@apple.com>
The DFG non-speculative JIT is no longer used and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=68177
Reviewed by Geoffrey Garen.
This removes the non-speculative JIT and everything that relied on it,
including the ability to turn on DFG but not tiered compilation the,
ability to perform speculation failure into non-speculative JIT code,
and the ability to statically terminate speculation.
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGenerationInfo.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGJITCompiler.h:
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp: Removed.
* dfg/DFGNonSpeculativeJIT.h: Removed.
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGPropagator.cpp:
* dfg/DFGPropagator.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::osrExits):
(JSC::DFG::SpeculativeJIT::speculationRecovery):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITCode.h:
(JSC::JITCode::bottomTierJIT):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* wtf/Platform.h:
2011-09-15 Eric Seidel <eric@webkit.org>
Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
https://bugs.webkit.org/show_bug.cgi?id=68182
Reviewed by Adam Barth.
* Configurations/FeatureDefines.xcconfig:
2011-09-15 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT sometimes asserts that a value is not a number
even when it doesn't know anything about the number
https://bugs.webkit.org/show_bug.cgi?id=68189
Reviewed by Oliver Hunt.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isUnknownJS):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
2011-09-15 Filip Pizlo <fpizlo@apple.com>
All of the functionality in the non-speculative JIT should be
available to the speculative JIT via helper methods
https://bugs.webkit.org/show_bug.cgi?id=68186
Reviewed by Oliver Hunt.
Stole all of the goodness from NonSpeculativeJIT and placed it
in JITCodeGenerator. Left all of the badness (i.e. subtle code
duplication with SpeculativeJIT, etc). This is in preparation
for removing the NonSpeculativeJIT entirely, but having its
goodness available for reuse in the SpeculativeJIT if necessary.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::nonSpeculativeAdd):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithSub):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
2011-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r95167.
http://trac.webkit.org/changeset/95167
https://bugs.webkit.org/show_bug.cgi?id=68191
Patch needs further work. (Requested by mhahnenberg on
#webkit).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::toBoolean):
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toBoolean):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toBoolean):
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::toBoolean):
2011-09-15 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for platforms that expect a linkable symbol
for primitive static const's.
* bytecode/CodeBlock.h:
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
2011-09-15 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for assertion on existence of alternative
CodeBlock.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
2011-09-14 Filip Pizlo <fpizlo@apple.com>
Value profiles collect no information for global variables
https://bugs.webkit.org/show_bug.cgi?id=68143
Reviewed by Geoffrey Garen.
17% speed-up on string-fasta. Neutral elsewhere.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_global_var):
2011-09-15 Eric Seidel <eric@webkit.org>
Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
https://bugs.webkit.org/show_bug.cgi?id=68022
Reviewed by Ryosuke Niwa.
* Configurations/FeatureDefines.xcconfig:
2011-09-15 Gavin Barraclough <barraclough@apple.com>
Ooops, revert accidentally commited unreviewed changes.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
* jit/JSInterfaceJIT.h:
* runtime/JSValue.h:
2011-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r95163.
http://trac.webkit.org/changeset/95163
https://bugs.webkit.org/show_bug.cgi?id=68180
[Qt] The QT_GCC_X variables were removed in Qt5 by accident.
(Requested by darktears on #webkit).
* JavaScriptCore.pro:
2011-09-15 Gavin Barraclough <barraclough@apple.com>
Windows build fix p1.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
* jit/JSInterfaceJIT.h:
* runtime/JSValue.h:
2011-09-14 Filip Pizlo <fpizlo@apple.com>
Tiered compilation should be enabled by default on platforms
that support the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68136
Reviewed by Sam Weinig.
Neutral on SunSpider, 4% speed-up on V8, and 19% speed-up on
Kraken. Large progressions on some benchmarks, including
3x on imaging-desaturate.
* wtf/Platform.h:
2011-09-15 Gavin Barraclough <barraclough@apple.com>
devirtualize preventExtensions
https://bugs.webkit.org/show_bug.cgi?id=68176
Reviewed by Oliver Hunt.
This is virtual due to problems in JSFunction putting the prototype
property, but we can fix this problem a different way, just setting
the checkReadOnly flag to false in the put.
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSObject.h:
2011-09-15 Geoffrey Garen <ggaren@apple.com>
Value chaining for JSValue32_64 bitops.
Reviewed by Sam Weinig.
SunSpider says 2.3% faster, v8 ~1% faster (mostly due to crypto).
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32): New int32 helper function for stores
that can chain their results, which is the common case.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec): Deployed new function.
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec): Had to reorder these functions so they
computed their result values last, to make them elligible for chaining.
2011-09-15 Adam Roben <aroben@apple.com>
Clang build fix after r95172
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
Added parentheses to make precendence clear.
2011-09-14 Filip Pizlo <fpizlo@apple.com>
DFG does not speculate aggressively enough on comparisons
https://bugs.webkit.org/show_bug.cgi?id=68138
Reviewed by Oliver Hunt.
This is a 75% speed-up on Kraken/ai-astar. It's a 1% win on
V8 and an 8.5% win on Kraken. Neutral on SunSpider.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):
2011-09-14 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not leverage integer speculations on branches
https://bugs.webkit.org/show_bug.cgi?id=68140
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isStrictInt32):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-14 Gavin Barraclough <barraclough@apple.com>
[n]stricteq code is bogus in JSValue32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=68141
Reviewed by Sam Weinig.
The code tries to check for both ints or cells, but this check also
catches cases where values that are undefined, null, etc (probably
was incorrectly assuming cell was the 2nd highest tag?).
Also, there is no need not to handle int on the fast path.
stricteq is just a case of comparing the payloads, if we:
* handle cases of differing tags on a slow path
* handle doubles a slow path
* handle both-are-string on a slow path
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727
Reviewed by Sam Weinig.
JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
2011-09-14 Alexis Menard <alexis.menard@openbossa.org>
[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
https://bugs.webkit.org/show_bug.cgi?id=68114
Reviewed by Kenneth Rohde Christiansen.
Use the new GCC_X variables defined in WebKit.pri to replace
the usage of QT_GCC_X.
* JavaScriptCore.pro:
2011-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r95145.
http://trac.webkit.org/changeset/95145
https://bugs.webkit.org/show_bug.cgi?id=68139
The GTK+ build is working now, so revert this trial build fix.
(Requested by mrobinson on #webkit).
* GNUmakefile.list.am:
2011-09-14 Patrick Gansterer <paroga@webkit.org>
Port MachineStackMarker to Windows ARM and MIPS
https://bugs.webkit.org/show_bug.cgi?id=68068
Reviewed by Geoffrey Garen.
Use the correct memeber of the CONTEXT struct for the stackpointer for CPU(ARM) and CPU(MIPS).
Only query CONTEXT_INTEGER and CONTEXT_CONTROL, since CONTEXT_SEGMENTS isn't defined for
CPU(ARM) and CPU(MIPS) and the stackpointer is defined in the CONTEXT_CONTROL section for
CPU(ARM), CPU(X86) and CPU(X86_64) and in the CONTEXT_INTEGER section for CPU(MIPS).
* heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
2011-09-12 Filip Pizlo <fpizlo@apple.com>
DFG JIT always speculates that ValueAdd is a numeric addition
https://bugs.webkit.org/show_bug.cgi?id=67956
Reviewed by Geoffrey Garen.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
2011-09-14 Anders Carlsson <andersca@apple.com>
Stop building BinarySemaphore to see if that's what's breaking the GTK+ build.
* GNUmakefile.list.am:
2011-09-14 Anders Carlsson <andersca@apple.com>
This is getting old. Yet another build fix attempt.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
2011-09-14 Anders Carlsson <andersca@apple.com>
Yet another build fix attempt.
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
2011-09-14 Anders Carlsson <andersca@apple.com>
How I "love" Visual Studio...
Try to fix build again.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
2011-09-14 Anders Carlsson <andersca@apple.com>
Try to fix Windows build.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
2011-09-14 Anders Carlsson <andersca@apple.com>
Add BinarySemaphore class from WebKit2 to WTF
https://bugs.webkit.org/show_bug.cgi?id=68132
Reviewed by Sam Weinig.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
Update build systems.
* wtf/threads: Added.
* wtf/threads/BinarySemaphore.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
* wtf/threads/BinarySemaphore.h: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.h.
* wtf/threads/win: Added.
* wtf/threads/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/win/BinarySemaphoreWin.cpp.
2011-09-14 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for Interpreter.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2011-09-14 Anders Carlsson <andersca@apple.com>
Add wtf/threads and wtf/threads/win, so we can be sure that the EWS
bots can correctly build the patch in https://bugs.webkit.org/show_bug.cgi?id=68132
Rubber-stamped by Sam Weinig.
* wtf/threads: Added.
* wtf/threads/win: Added.
2011-09-14 Filip Pizlo <fpizlo@apple.com>
DFG JIT should not speculate integer if the value is always going to be
used as a double anyway
https://bugs.webkit.org/show_bug.cgi?id=68127
Reviewed by Oliver Hunt.
Added a ValueToDouble node, which is a variant of ValueToNumber that
hints that it will only be used as a double and never as an integer.
Thus, it turns off integer speculation even if the value profiler
told us that the value source is an int. The logic for converting a
ValueToNumber into a ValueToDouble is found in Propagator.
This appears to be a 22% speed-up in imaging-darkroom.
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
2011-09-14 Filip Pizlo <fpizlo@apple.com>
Tiered compilation heuristics do not account for value profile fullness
https://bugs.webkit.org/show_bug.cgi?id=68116
Reviewed by Oliver Hunt.
Tiered compilation avoids invoking the DFG JIT if it finds that value
profiles contain insufficient information. Instead, it produces a
prediction from the current value profile, and then clears the value
profile. This allows the value profile to heat up from scratch for
some number of additional executions. The new profiles will then be
merged with the previous prediction. Once the amount of information
in predictions is enough according to heuristics in CodeBlock.cpp,
DFG optimization is allowed to proceed.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
* bytecode/PredictedType.h:
* bytecode/ValueProfile.cpp: Added.
(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::totalNumberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
(JSC::getValueProfileBytecodeOffset):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::stronglyPredict):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2011-09-14 Filip Pizlo <fpizlo@apple.com>
DFG should not speculate that the child of LogicalNot is a boolean if
predictions tell us otherwise
https://bugs.webkit.org/show_bug.cgi?id=68118
Reviewed by Geoffrey Garen.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-09-14 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix. Turn off tiered compilation.
* wtf/Platform.h:
2011-09-13 Filip Pizlo <fpizlo@apple.com>
Prediction tracking is not precise enough
https://bugs.webkit.org/show_bug.cgi?id=67993
Reviewed by Oliver Hunt.
Added a richer set of type predictions, including JSFinalObject, JSString,
object that is not a JSFinalObject or JSArray (ObjectOther), some object
but we don't or care know what kind (SomeObject), definitely an object,
cell that is not an object or JSString, an value that is none of the above
(so either Undefined or Null). Made the propagator and value profiler work
with the new types.
Performance is neutral, because the DFG JIT does not take advantage of this
new knowledge yet.
In the process of writing predictionToString() (which is now considerably
more complex) I decided to finally add a BoundsCheckedPointer, which
should come in handy in other places, like at least the OSR scratch buffer
and the CompactJITCodeMap. It's great for cases where you want to
do pointer arithmetic, you want to have assertions about the
pointer not going out of bounds, but you don't want to write those
assertions yourself.
This also required refactoring inherits(), since the ValueProfiler may
want to do the equivalent of inherits() but given two ClassInfo's.
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/PredictedType.cpp: Added.
(JSC::predictionToString):
(JSC::makePrediction):
(JSC::predictionFromValue):
* bytecode/PredictedType.h:
(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::mergePredictions):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::probabilityOfObject):
(JSC::ValueProfile::probabilityOfFinalObject):
(JSC::ValueProfile::probabilityOfString):
(JSC::ValueProfile::dump):
(JSC::ValueProfile::Statistics::Statistics):
(JSC::ValueProfile::computeStatistics):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::stronglyPredict):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGNode.h:
(JSC::DFG::Node::predict):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
* runtime/ClassInfo.h:
(JSC::ClassInfo::isSubClassOf):
* runtime/JSObject.h:
(JSC::JSCell::inherits):
* wtf/BoundsCheckedPointer.h: Added.
(WTF::BoundsCheckedPointer::BoundsCheckedPointer):
(WTF::BoundsCheckedPointer::operator=):
(WTF::BoundsCheckedPointer::operator+=):
(WTF::BoundsCheckedPointer::operator-=):
(WTF::BoundsCheckedPointer::operator+):
(WTF::BoundsCheckedPointer::operator-):
(WTF::BoundsCheckedPointer::operator++):
(WTF::BoundsCheckedPointer::operator--):
(WTF::BoundsCheckedPointer::operator<):
(WTF::BoundsCheckedPointer::operator<=):
(WTF::BoundsCheckedPointer::operator>):
(WTF::BoundsCheckedPointer::operator>=):
(WTF::BoundsCheckedPointer::operator==):
(WTF::BoundsCheckedPointer::operator!=):
(WTF::BoundsCheckedPointer::operator!):
(WTF::BoundsCheckedPointer::get):
(WTF::BoundsCheckedPointer::operator*):
(WTF::BoundsCheckedPointer::operator[]):
(WTF::BoundsCheckedPointer::strcat):
(WTF::BoundsCheckedPointer::validate):
* wtf/CMakeLists.txt:
2011-09-14 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Win32 builds with threads turned off
https://bugs.webkit.org/show_bug.cgi?id=67864
Reviewed by Geoffrey Garen.
* JavaScriptCore.pri: Link pthread library on Windows platform.
* wtf/Platform.h: Enable multiple threads.
2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (6/7)
https://bugs.webkit.org/show_bug.cgi?id=67692
Reviewed by Geoffrey Garen.
Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::create):
* jsc.cpp:
(GlobalObject::create):
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::create):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::create):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::create):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::create):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):
* runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::create):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::create):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::create):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):
2011-09-13 Eric Seidel <eric@webkit.org>
Remove ENABLE_SVG_USE as <use> is required by HTML5
https://bugs.webkit.org/show_bug.cgi?id=68019
Reviewed by Ryosuke Niwa.
* Configurations/FeatureDefines.xcconfig:
2011-09-14 Iain Merrick <husky@google.com>
HashTraits.h should include template specialization for WTF::String
https://bugs.webkit.org/show_bug.cgi?id=67851
Ensure that the template specialization for HashTraits<String> is always
picked up. (Previously it was possible to include HashSet and String but
not the correct HashTraits, so you would get an inefficient template
instantiation.)
Reviewed by Darin Adler.
* wtf/HashTraits.h:
* wtf/text/StringHash.h:
2011-09-13 Filip Pizlo <fpizlo@apple.com>
SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
https://bugs.webkit.org/show_bug.cgi?id=67985
Reviewed by Geoffrey Garen.
This is a 17% speed-up on 3d-cube.
This required allowing us to check if a constant is double but not
integer, and making the shouldSpeculateInteger() check test for
any hints of doubly-ness in its operands. This also required
changing some terminology: previously "isDouble" often meant
"isDouble or isInt32". Now "isDouble" means exactly what the name
suggests, and "isNumber" means "isDouble or isInt32".
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::isJSFormat):
(JSC::DFG::isJSInteger):
(JSC::DFG::isJSDouble):
(JSC::DFG::isJSCell):
(JSC::DFG::isJSBoolean):
(JSC::DFG::GenerationInfo::isJSFormat):
(JSC::DFG::GenerationInfo::isJSInteger):
(JSC::DFG::GenerationInfo::isJSDouble):
(JSC::DFG::GenerationInfo::isJSCell):
(JSC::DFG::GenerationInfo::isJSBoolean):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::valueOfNumberConstant):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isNumberConstant):
(JSC::DFG::JITCodeGenerator::valueOfNumberConstant):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillToJS):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isNumberConstant):
(JSC::DFG::JITCompiler::valueOfNumberConstant):
* dfg/DFGNode.h:
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::valueOfNumberConstant):
(JSC::DFG::Node::hasNumberResult):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
2011-09-13 Anders Carlsson <andersca@apple.com>
Disable C++ exceptions when building with clang
https://bugs.webkit.org/show_bug.cgi?id=68031
<rdar://problem/9556880>
Reviewed by Mark Rowe.
* Configurations/Base.xcconfig:
2011-09-13 Eric Seidel <eric@webkit.org>
Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
https://bugs.webkit.org/show_bug.cgi?id=68018
Reviewed by Ryosuke Niwa.
* Configurations/FeatureDefines.xcconfig:
2011-09-13 Sam Weinig <sam@webkit.org>
Object.getPrototypeOf should use JSValue::get()
https://bugs.webkit.org/show_bug.cgi?id=67973
Reviewed by Darin Adler.
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
Pipe through JSValue::get() to allow overrides.
2011-09-12 Filip Pizlo <fpizlo@apple.com>
JavaScriptCore does not have baseline->speculative OSR
https://bugs.webkit.org/show_bug.cgi?id=67920
Reviewed by Oliver Hunt.
This adds the ability to on-stack-replace (OSR) from code that is
running hot in the old JIT to code compiled by the new JIT. This
ensures that long-running loops benefit from DFG optimization.
It also ensures that if code experiences a speculation failure
in DFG code, it has an opportunity to reenter the DFG once every
1,000 loop iterations or so.
This results in a 2.88x speed-up on Kraken/imaging-desaturate,
and is a pure win on the main three benchmark suites (SunSpider,
V8, Kraken), when tiered compilation is enabled.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
* bytecode/CodeBlock.h:
* bytecode/Opcode.h:
* bytecode/PredictedType.h: Added.
(JSC::isCellPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::isStrongPrediction):
(JSC::predictionToString):
(JSC::mergePredictions):
(JSC::mergePrediction):
(JSC::makePrediction):
* bytecode/PredictionTracker.h: Added.
(JSC::operandIsArgument):
(JSC::PredictionSlot::PredictionSlot):
(JSC::PredictionTracker::PredictionTracker):
(JSC::PredictionTracker::initializeSimilarTo):
(JSC::PredictionTracker::copyLocalsFrom):
(JSC::PredictionTracker::numberOfArguments):
(JSC::PredictionTracker::numberOfVariables):
(JSC::PredictionTracker::argumentOffsetForOperand):
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
(JSC::PredictionTracker::getArgumentPrediction):
(JSC::PredictionTracker::getPrediction):
(JSC::PredictionTracker::getGlobalVarPrediction):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGNode.h:
* dfg/DFGOSREntry.cpp: Added.
(JSC::DFG::predictionIsValid):
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h: Added.
(JSC::DFG::prepareOSREntry):
* dfg/DFGPredictionTracker.h: Removed.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/CompactJITCodeMap.h:
(JSC::CompactJITCodeMap::numberOfEntries):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::Decoder::Decoder):
(JSC::CompactJITCodeMap::Decoder::numberOfEntriesRemaining):
(JSC::CompactJITCodeMap::Decoder::read):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JSC::JIT::emit_op_loop_hint):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
2011-09-12 Sam Weinig <sam@webkit.org>
Don't allow setting __proto__ to be a getter or setter
https://bugs.webkit.org/show_bug.cgi?id=67982
Reviewed by Gavin Barraclough.
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
Disallow setting a getter or setter on __proto__.
2011-09-12 James Robinson <jamesr@chromium.org>
Unreviewed build fix for chromium.
Guard access to UString::latin1() with USE(JSC) since it is defined in JavaScriptCore/runtime/UString.cpp, which
is currently only compiled in by ports that use JavaScriptCore. This code is currently unreachable in builds so
no change in functionality.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::CharAccess::CharAccess):
2011-09-09 Filip Pizlo <fpizlo@apple.com>
JavaScriptCore does not have speculative->baseline OSR
https://bugs.webkit.org/show_bug.cgi?id=67826
Reviewed by Oliver Hunt.
This adds the ability to bail out of DFG speculative JIT execution by
performing an on-stack replacement (OSR) that results in the control
flow going to the equivalent code generated by the old JIT.
This required a number of new features, as well as taking advantage of
some features that happened to already be present:
We already had a policy of storing the bytecode index for which a DFG
node was generated inside the DFG::Node class. This was previously
called exceptionInfo. It's now renamed to codeOrigin to reflect that
it's used for more than just excpetions. OSR uses this to figure out
which bytecode index to use to look up the machine code location in
the code generated by the old JIT that we should be jumping to.
CodeBlock now stores a mapping between bytecode indices and machine
code offsets for code generated by the old JIT. This is implemented
by CompactJITCodeMap, which tries to compress this data a bit. The
OSR compiler decodes this and uses it to find the machine code
locations it should be jumping to.
We already had a mechanism that emitted SetLocal nodes in the DFG graph
that told us the time at which the old JIT would have stored something
into its register file, and the DFG::Node that corresponds to the value
that it would have stored. These SetLocal's were mostly dead-code-
eliminated, but our DCE leaves the nodes intact except for making them
have 0 as the ref count. This allows the OSR compiler to construct a
mapping between the state as it would have been seen by the old JIT
and the state as the DFG JIT sees it. The OSR compiler uses this to
generate code that reshapes the call frame so that it is like what the
old JIT would expect.
Finally, when DFG_OSR is enabled (the default for TIERED_COMPILATION)
we no longer emit the non-speculative path.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addToGraph):
* dfg/DFGGPRInfo.h:
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::alive):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallRecord::CallRecord):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::appendCallWithFastExceptionCheck):
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
* dfg/DFGNode.h:
(JSC::DFG::CodeOrigin::CodeOrigin):
(JSC::DFG::CodeOrigin::isSet):
(JSC::DFG::CodeOrigin::bytecodeIndex):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1Unchecked):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueRecovery::ValueRecovery):
(JSC::DFG::ValueRecovery::alreadyInRegisterFile):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inFPR):
(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::constant):
(JSC::DFG::ValueRecovery::technique):
(JSC::DFG::ValueRecovery::gpr):
(JSC::DFG::ValueRecovery::fpr):
(JSC::DFG::ValueRecovery::virtualRegister):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::osrExits):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::valueSourceForOperand):
(JSC::DFG::SpeculativeJIT::setNodeIndexForOperand):
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* jit/CompactJITCodeMap.h: Added.
(JSC::BytecodeAndMachineOffset::BytecodeAndMachineOffset):
(JSC::BytecodeAndMachineOffset::getBytecodeIndex):
(JSC::BytecodeAndMachineOffset::getMachineCodeOffset):
(JSC::CompactJITCodeMap::~CompactJITCodeMap):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::CompactJITCodeMap):
(JSC::CompactJITCodeMap::at):
(JSC::CompactJITCodeMap::decodeNumber):
(JSC::CompactJITCodeMap::Encoder::Encoder):
(JSC::CompactJITCodeMap::Encoder::~Encoder):
(JSC::CompactJITCodeMap::Encoder::append):
(JSC::CompactJITCodeMap::Encoder::finish):
(JSC::CompactJITCodeMap::Encoder::appendByte):
(JSC::CompactJITCodeMap::Encoder::encodeNumber):
(JSC::CompactJITCodeMap::Encoder::ensureCapacityFor):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::osrScratchBufferForSize):
* runtime/JSValue.cpp:
(JSC::JSValue::description):
2011-09-12 Geoffrey Garen <ggaren@apple.com>
Re-enabled ENABLE(LAZY_BLOCK_FREEING).
Reviewed by Stephanie Lewis.
I accidentally disabled this in r94890, causing a big performance regression.
* wtf/Platform.h:
2011-09-12 Michael Saboff <msaboff@apple.com>
Broken Build for ARM - lshift32() needs TrustedImm32 arg
https://bugs.webkit.org/show_bug.cgi?id=67965
Change lshift32(16, ARMRegisters::S1); to lshift32(TrustedImm32(16), ARMRegisters::S1);
Reviewed by Anders Carlsson.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch16):
2011-09-12 Michael Saboff <msaboff@apple.com>
Broken ARM build - missing semicolon in JavaScriptCore/assembler/MacroAssemblerARM.h
https://bugs.webkit.org/show_bug.cgi?id=67961
Added missing semicolon.
Reviewed by Ryosuke Niwa.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch16):
2011-09-12 Michael Saboff <msaboff@apple.com>
Update RegExp and related classes to use 8 bit strings when available
https://bugs.webkit.org/show_bug.cgi?id=67337
Modified both the Yarr interpreter and JIT to handle 8 bit subject strings.
The code paths are triggered by the UString::is8bit() method which currently
returns false. Implemented JIT changes for all current architectures.
Tested X86_64 and ARM v7.
This includes some code that will likely change as we complete the
8 bit string changes. This includes the way the raw buffer pointers
are accessed as well as replacing the CharAccess class with a
string interator returned from UString.
Fixed build breakage in testRegExp.cpp due to globalObject construction
changes.
Reviewed by Gavin Barraclough.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* testRegExp.cpp:
(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::baseIndexTransfer32):
* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ubfx):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg40Imm3Reg4Imm20Imm5):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch16):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch16):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::branch8):
(JSC::MacroAssemblerSH4::branch16):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load8):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branch8):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::extub):
(JSC::SH4Assembler::printInstr):
* assembler/X86Assembler.h:
(JSC::X86Assembler::cmpw_ir):
(JSC::X86Assembler::movzbl_mr):
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):
* runtime/RegExp.h:
* runtime/UString.h:
(JSC::UString::is8Bit):
* yarr/Yarr.h:
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):
(JSC::Yarr::Interpreter::CharAccess::operator[]):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::interpret):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
(JSC::Yarr::execute):
* yarr/YarrJIT.h:
(JSC::Yarr::YarrCodeBlock::has8BitCode):
(JSC::Yarr::YarrCodeBlock::has16BitCode):
(JSC::Yarr::YarrCodeBlock::set8BitCode):
(JSC::Yarr::YarrCodeBlock::set16BitCode):
(JSC::Yarr::YarrCodeBlock::execute):
* yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
2011-09-12 Andras Becsi <andras.becsi@nokia.com>
[Qt] Build fails after r94920 with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67928
Reviewed by Csaba Osztrogonác.
* wtf/RedBlackTree.h:
(WTF::RedBlackTree::insert): Remove dead variables updateStart and newSubTreeRoot.
2011-09-12 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix after r94871.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/FastMalloc.cpp:
* wtf/RefCountedLeakCounter.h:
2011-09-11 Filip Pizlo <fpizlo@apple.com>
DFGNode.h has macros that indicate the enabling of a feature, but
they do not use the ENABLE() idiom.
https://bugs.webkit.org/show_bug.cgi?id=67907
Reviewed by Oliver Hunt.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):
* dfg/DFGScoreBoard.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
2011-09-11 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix for chromium/mac & clang.
Fix the macro redefinition error by r94927, because chromium set
ENABLE_JSC_MULTIPLE_THREADS=0 in WebKit/chromium/features.gypi and
it is not PLATFORM(QT).
../../JavaScriptCore/wtf/Platform.h:512:9: error: 'ENABLE_JSC_MULTIPLE_THREADS' macro redefined [-Werror]
#define ENABLE_JSC_MULTIPLE_THREADS 1
<command line>:43:9: note: previous definition is here
#define ENABLE_JSC_MULTIPLE_THREADS 0
1 error generated.
* wtf/Platform.h:
2011-09-11 Sam Weinig <sam@webkit.org>
Remove JSCell::isPropertyNameIterator(), it is unused
https://bugs.webkit.org/show_bug.cgi?id=67911
Reviewed by Oliver Hunt.
* runtime/JSCell.h:
* runtime/JSPropertyNameIterator.h:
2011-09-11 Sam Weinig <sam@webkit.org>
De-virtualize JSCell::isAPIValueWrapper
https://bugs.webkit.org/show_bug.cgi?id=67909
Reviewed by Oliver Hunt.
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
Set the correct type on structure creation.
* runtime/JSCell.h:
Remove virtual keyword and default implementation.
* runtime/JSType.h:
Add type for APIValueWrapper. It must come after CompoundType since
the APIValueWrapper has children in need of marking.
* runtime/Structure.h:
(JSC::JSCell::isAPIValueWrapper):
Implement predicate using type info.
2011-09-10 Sam Weinig <sam@webkit.org>
De-virtualize JSCell::isGetterSetter, type information is available for it
https://bugs.webkit.org/show_bug.cgi?id=67902
Reviewed by Dan Bernstein.
* runtime/GetterSetter.cpp:
* runtime/GetterSetter.h:
Remove override of isGetterSetter.
* runtime/JSCell.cpp:
* runtime/JSCell.h:
De-virtualize and remove silly base implementation.
* runtime/Structure.h:
(JSC::JSCell::isGetterSetter):
Use type info to determine getter-setter-hood.
2011-09-09 Oliver Hunt <oliver@apple.com>
Remove support for anonymous storage from jsobjects
https://bugs.webkit.org/show_bug.cgi?id=67881
Reviewed by Sam Weinig.
Remove all use of anonymous slots, essentially a mechanical change
in JavaScriptCore
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* heap/MarkStack.cpp:
(JSC::MarkStack::validateValue):
* heap/MarkStack.h:
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::finishCreation):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure):
* runtime/ExceptionHelpers.h:
(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::createStructure):
* runtime/Executable.h:
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSCell.h:
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::RopeBuilder::createStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::finishCreation):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExp.h:
(JSC::RegExp::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::createStructure):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::createStructure):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::createStructure):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::checkConsistency):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
* runtime/StructureChain.h:
(JSC::StructureChain::createStructure):
2011-09-11 Jarred Nicholls <jarred@sencha.com>
[Qt] Win32 build broken due to MachineStackMarker.cpp/.o failing to link against pthreads library
https://bugs.webkit.org/show_bug.cgi?id=67864
Qt Win32 is not pthread compatible and cannot participate in multithreaded JSC or it fails to build.
Reviewed by Csaba Osztrogonác.
* wtf/Platform.h:
2011-09-11 Filip Pizlo <fpizlo@apple.com>
ARM and MIPS assemblers still refer to executable pools.
https://bugs.webkit.org/show_bug.cgi?id=67903
Reviewed by Csaba Osztrogonác.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
2011-09-08 Filip Pizlo <fpizlo@apple.com>
The executable allocator makes it difficult to free individual
chunks of executable memory
https://bugs.webkit.org/show_bug.cgi?id=66363
Reviewed by Oliver Hunt.
Introduced a best-fit, balanced-tree based allocator. The allocator
required a balanced tree that does not allocate memory and that
permits the removal of individual nodes directly (as opposed to by
key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
Changed all references to executable code to use a reference counted
handle.
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::finalizeCode):
(JSC::LinkBuffer::linkCode):
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
(JSC::MacroAssemblerCodeRef::createSelfManagedCodeRef):
(JSC::MacroAssemblerCodeRef::executableMemory):
(JSC::MacroAssemblerCodeRef::code):
(JSC::MacroAssemblerCodeRef::size):
(JSC::MacroAssemblerCodeRef::operator!):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* bytecode/CodeBlock.h:
* bytecode/Instruction.h:
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::dumpProfile):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compileCTINativeCall):
* jit/JITCode.h:
(JSC::JITCode::operator !):
(JSC::JITCode::addressForCall):
(JSC::JITCode::offsetOf):
(JSC::JITCode::execute):
(JSC::JITCode::start):
(JSC::JITCode::size):
(JSC::JITCode::getExecutableMemory):
(JSC::JITCode::HostFunction):
(JSC::JITCode::JITCode):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
* jit/ThunkGenerators.h:
* runtime/Executable.h:
(JSC::NativeExecutable::create):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::dumpSampleData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
* wtf/CMakeLists.txt:
* wtf/MetaAllocator.cpp: Added.
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::shrink):
(WTF::MetaAllocator::MetaAllocator):
(WTF::MetaAllocator::allocate):
(WTF::MetaAllocator::currentStatistics):
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::addFreeSpaceFromReleasedHandle):
(WTF::MetaAllocator::addFreshFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):
(WTF::MetaAllocator::roundUp):
(WTF::MetaAllocator::allocFreeSpaceNode):
(WTF::MetaAllocator::freeFreeSpaceNode):
(WTF::MetaAllocator::dumpProfile):
* wtf/MetaAllocator.h: Added.
(WTF::MetaAllocator::bytesAllocated):
(WTF::MetaAllocator::bytesReserved):
(WTF::MetaAllocator::bytesCommitted):
(WTF::MetaAllocator::dumpProfile):
(WTF::MetaAllocator::~MetaAllocator):
* wtf/MetaAllocatorHandle.h: Added.
* wtf/RedBlackTree.h: Added.
(WTF::RedBlackTree::Node::Node):
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::reset):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::Node::color):
(WTF::RedBlackTree::Node::setColor):
(WTF::RedBlackTree::RedBlackTree):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::isEmpty):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):
* wtf/wtf.pri:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
* yarr/YarrJIT.h:
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::getAddr):
2011-09-10 Sam Weinig <sam@webkit.org>
Remove JSC::isZombie() function, it did nothing and was called by no-one.
https://bugs.webkit.org/show_bug.cgi?id=67901
Reviewed by Andy Estes.
* JavaScriptCore.exp:
* runtime/JSCell.cpp:
* runtime/JSValue.h:
2011-09-10 Sam Weinig <sam@webkit.org>
Add isInterruptedExecutionException and isTerminatedExecutionException predicates
https://bugs.webkit.org/show_bug.cgi?id=67892
Reviewed by Andy "First Time Reviewer" Estes.
* JavaScriptCore.exp:
Add symbols.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
Use new predicates.
* runtime/ExceptionHelpers.cpp:
(JSC::createInterruptedExecutionException):
(JSC::isInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::isTerminatedExecutionException):
* runtime/ExceptionHelpers.h:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
Add predicates.
2011-09-10 Filip Pizlo <fpizlo@apple.com>
DFG JIT completely undoes speculative compilation even in the case of
a partial static speculation failure
https://bugs.webkit.org/show_bug.cgi?id=67798
Reviewed by Geoffrey Garen.
This is a regression with static speculation, so it is turned off by
default. But it is a necessary prerequisite for further work on
dynamic speculation.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::clearGenerationInfo):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
2011-09-09 Chris Marrin <cmarrin@apple.com>
requestAnimationFrame doesn't throttle on Mac
https://bugs.webkit.org/show_bug.cgi?id=67171
Reviewed by Simon Fraser.
Added WTF_USE_REQUEST_ANIMATION_FRAME_TIMER to allow any platform to run
requestAnimationFrame callbacks on a Timer defined in ScriptedAnimationController.
Currently only enabled for PLATFORM(MAC)
* wtf/Platform.h:
2011-09-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Dan Bernstein.
Removed ENABLE(SINGLE_THREADED) support, since it is always false
https://bugs.webkit.org/show_bug.cgi?id=67862
Next step toward making the baseline platform assumption that threads exist.
* wtf/wtf.pri:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Removed references to
ThreadingNone.cpp, which was only compiled in single-threaded mode.
* wtf/Platform.h:
* wtf/ThreadSpecific.h:
(WTF::::destroy):
* wtf/qt/ThreadingQt.cpp: Removed now-dead code.
* wtf/ThreadingNone.cpp: Removed.
2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (5/7)
https://bugs.webkit.org/show_bug.cgi?id=67420
Reviewed by Geoffrey Garen.
Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::create):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::finishCreation):
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::finishCreation):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::create):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
(JSC::BooleanConstructor::finishCreation):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
(JSC::BooleanObject::create):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::finishCreation):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::finishCreation):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
(JSC::DateInstance::create):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
(JSC::DatePrototype::finishCreation):
* runtime/DatePrototype.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
(JSC::ErrorConstructor::finishCreation):
* runtime/ErrorConstructor.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
(JSC::FunctionConstructor::finishCreation):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
(JSC::FunctionPrototype::finishCreation):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
(JSC::JSONObject::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSString.cpp:
(JSC::StringObject::create):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
(JSC::NumberConstructor::finishCreation):
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
(JSC::NumberObject::create):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::finishCreation):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::finishCreation):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::finishCreation):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
(JSC::StringPrototype::finishCreation):
* runtime/StringPrototype.h:
2011-09-09 Geoffrey Garen <ggaren@apple.com>
Build fix: Guard against double-#define for something already #defined
by the build system.
* wtf/Platform.h:
2011-09-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Dan Bernstein.
Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or
!ENABLE_WTF_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=67860
First step toward making the baseline platform assumption that threads
exist: Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS,
or !ENABLE_WTF_MULTIPLE_THREADS.
* wtf/Platform.h:
2011-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
[Qt] Remove common.pri
https://bugs.webkit.org/show_bug.cgi?id=67814
Reviewed by Andreas Kling.
* JavaScriptCore.pri:
2011-09-08 Mark Hahnenberg <mhahnenberg@apple.com>
REGRESSION(r94811): Assertion failure in 2 worker tests
https://bugs.webkit.org/show_bug.cgi?id=67829
Reviewed by Sam Weinig.
Fixing a couple tests that were broken due to the wrong values being
set in the parent class pointers in the ClassInfo structs for
TerminatedExecutionError and InterruptedExecutionError.
* runtime/ExceptionHelpers.cpp:
2011-09-08 Oliver Hunt <oliver@apple.com>
Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494
Reviewed by Geoffrey Garen.
Use a bump allocator for initial allocation of property storage,
and promote to fastMalloc memory only if it survives a GC pass.
Comes out as a 1% win on v8, and is a useful step on the way to
GC allocation of all property storage.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursery):
* heap/MarkedBlock.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
(JSC::NewSpace::resetPropertyStorageNursery):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursery):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
(JSC::JSObject::propertyStorage):
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):
* runtime/StorageBarrier.h: Added.
(JSC::StorageBarrier::StorageBarrier):
(JSC::StorageBarrier::set):
(JSC::StorageBarrier::operator->):
(JSC::StorageBarrier::operator*):
(JSC::StorageBarrier::operator[]):
(JSC::StorageBarrier::get):
2011-09-08 Sam Weinig <sam@webkit.org>
Remove the Completion object from JSC, I have never liked it
https://bugs.webkit.org/show_bug.cgi?id=67755
Reviewed by Gavin Barraclough.
- Removes the Completion object and replaces its use with out parameter exceptions.
- Remove ComplType and virtual exceptionType() function on JSObject. Replace with
ClassInfo for InterruptedExecutionError and TerminatedExecutionError.
* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
* jsc.cpp:
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Completion.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::toString):
(JSC::TerminatedExecutionError::toString):
(JSC::createInterruptedExecutionException):
* runtime/ExceptionHelpers.h:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
(JSC::TerminatedExecutionError::createStructure):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSObject.h:
2011-09-08 Ryosuke Niwa <rniwa@webkit.org>
Build fix.
* dfg/DFGCapabilities.cpp:
2011-09-08 Filip Pizlo <fpizlo@apple.com>
Value profling and execution count profiling is performed even for
code that cannot be optimized
https://bugs.webkit.org/show_bug.cgi?id=67694
Reviewed by Gavin Barraclough.
This is a 2% speed-up on V8 when tiered compilation is enabled.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::canCompileWithDFG):
(JSC::EvalCodeBlock::canCompileWithDFG):
(JSC::FunctionCodeBlock::canCompileWithDFG):
* bytecode/CodeBlock.h:
* dfg/DFGCapabilities.cpp: Added.
(JSC::DFG::canCompileOpcodes):
* dfg/DFGCapabilities.h: Added.
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::shouldEmitProfiling):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
2011-09-08 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT does not initialize integer tags for PredictInt32 temporaries
https://bugs.webkit.org/show_bug.cgi?id=67840
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
2011-09-08 Thouraya ANDOLSI <thouraya.andolsi@st.com>
https://bugs.webkit.org/show_bug.cgi?id=67771
Fix sequenceGetByIdSlowCaseInstructionSpace, sequenceGetByIdSlowCaseConstantSpace
and patchOffsetGetByIdSlowCaseCall
and enables DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS flag for SH4 platforms.
Reviewed by Gavin Barraclough.
* jit/JIT.h:
* wtf/dtoa/utils.h:
2011-09-08 Mark Hahnenberg <mhahnenberg@apple.com>
Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691
Reviewed by Oliver Hunt.
We don't use JSCell::getUInt32 anymore, so it has been removed.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
2011-09-07 Filip Pizlo <fpizlo@apple.com>
PPC build fix.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
2011-09-07 Oliver Hunt <oliver@apple.com>
Release mode build fix.
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
2011-09-06 Oliver Hunt <oliver@apple.com>
Remove JSObjectWithGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=67689
Reviewed by Geoff Garen.
Remove JSObjectWithGlobalObject, and update code to stop using anonymous
storage to access the global object that a JSObject comes from. Largely
mechanical change to remove the use of anonymous storage and JSObjectWithGlobalObject.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.cpp:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
(JSC::::staticFunctionGetter):
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
* API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
* API/JSWeakObjectMapRefPrivate.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSFunction):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/DatePrototype.cpp:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
* runtime/JSONObject.h:
* runtime/JSObject.h:
(JSC::JSObject::globalObject):
* runtime/JSObjectWithGlobalObject.cpp: Removed.
* runtime/JSObjectWithGlobalObject.h: Removed.
* runtime/JSValue.cpp:
(JSC::JSValue::isValidCallee):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
* runtime/MathObject.h:
* runtime/NumberPrototype.cpp:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
* runtime/RegExpObject.h:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::globalObject):
2011-09-07 Gavin Barraclough <barraclough@apple.com>
Refactor JIT checks for ObjectType into helper functions.
Rubber stamped by Sam Weinig.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.h:
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):
2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r94627 and r94632.
http://trac.webkit.org/changeset/94627
http://trac.webkit.org/changeset/94632
https://bugs.webkit.org/show_bug.cgi?id=67698
It broke tests on GTK and Qt (Requested by Ossy on #webkit).
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::create):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
* API/JSCallbackFunction.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::create):
* debugger/DebuggerActivation.h:
* jsc.cpp:
(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::create):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
(JSC::BooleanObject::create):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
(JSC::DateInstance::create):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
(JSC::JSONObject::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSString.cpp:
(JSC::StringObject::create):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
(JSC::NumberObject::create):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
2011-09-06 Xianzhu Wang <wangxianzhu@chromium.org>
Replace usages of Vector<UChar> with existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67079
Reviewed by Gavin Barraclough.
This is part of work to support 8-bit string buffers.
Adds StringBuilder::characters() because the original Vector<UChar>::data()
is widely used.
Sets the minimum size of buffer to 16 to prevent possible performance
regression. Further performance investigation should be done in
https://bugs.webkit.org/show_bug.cgi?id=67084.
* wtf/Forward.h:
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::appendUninitialized): Sets minimum buffer size to 16 bytes.
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters): Added.
2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
Fix broken snow leopard build
https://bugs.webkit.org/show_bug.cgi?id=67693
Reviewed by Daniel Bates.
Removed unnecessary symbol export.
* JavaScriptCore.exp:
2011-09-06 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not optimize booleans
https://bugs.webkit.org/show_bug.cgi?id=67670
Reviewed by Gavin Barraclough.
This adds boolean value profiling, boolean prediction in the DFG,
boolean forward flow propagation in the DFGPropagator, boolean
data format in DFG generation info, and comprehensive optimizations
based on both boolean prediction and boolean generation info.
This is brings the speed-up on v8-richards to 12%, and gives slight
speed-ups elsewhere as well.
Making this work right required navigating some subtleties in
value profiling. Some functions get compiled with insufficient
information because some important path of the function never
executed. In these cases, we wish to fall back on static
speculation. But to do so, we need to ensure that predictions that
are inherent in the code (like that GetById almost certainly takes
a cell operand) are reflected in predictions that we make in
DFGPropagator. Thus, DFGPropagator now does both backward and
forward flow, using a both forward and backward fixpoint.
The backward flow in DFGPropagator is a separate static analysis,
and needs to keep a set of backward flow abstract values for
variables, arguments, and globals. To make this easy, this patch
factors out DFGGraph's prediction tracking capability into
DFGPredictionTracker, which now gets used by both DFGGraph (for
forward flow predictions) and DFGPropagator (for backward flow
predictions). Backward flow predictions eventually get merged
into forward flow ones, but the two are not equivalent: a forward
flow prediction is a superset of the backward flow prediction.
Debugging these prediction issues required a better understanding
of where we fail speculation, and what our value predictions look
like. This patch also adds optional verbose speculation failure
(so an informative printf fires whenever speculation failure occurs)
and slight improvements to the verbosity in other places.
* bytecode/ValueProfile.h:
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::probabilityOfBoolean):
(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predictions):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::GPRTemporary::GPRTemporary):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isBooleanConstant):
(JSC::DFG::JITCodeGenerator::valueOfBooleanConstant):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::isBooleanConstant):
(JSC::DFG::JITCompiler::valueOfBooleanConstant):
* dfg/DFGNode.h:
(JSC::DFG::isBooleanPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePredictions):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::valueOfBooleanConstant):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::hasNumericResult):
(JSC::DFG::Node::predict):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionTracker.h: Added.
(JSC::DFG::operandIsArgument):
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::PredictionTracker::PredictionTracker):
(JSC::DFG::PredictionTracker::initializeSimilarTo):
(JSC::DFG::PredictionTracker::numberOfArguments):
(JSC::DFG::PredictionTracker::numberOfVariables):
(JSC::DFG::PredictionTracker::argumentOffsetForOperand):
(JSC::DFG::PredictionTracker::predictArgument):
(JSC::DFG::PredictionTracker::predict):
(JSC::DFG::PredictionTracker::predictGlobalVar):
(JSC::DFG::PredictionTracker::getArgumentPrediction):
(JSC::DFG::PredictionTracker::getPrediction):
(JSC::DFG::PredictionTracker::getGlobalVarPrediction):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::~SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::index):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):
* runtime/JSGlobalData.h:
* runtime/JSValue.cpp:
(JSC::JSValue::description):
2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (5/7)
https://bugs.webkit.org/show_bug.cgi?id=67420
Reviewed by Geoffrey Garen.
Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::create):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::finishCreation):
* API/JSCallbackFunction.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::finishCreation):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::create):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
(JSC::BooleanConstructor::finishCreation):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
(JSC::BooleanObject::create):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::finishCreation):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::finishCreation):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
(JSC::DateInstance::create):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
(JSC::DatePrototype::finishCreation):
* runtime/DatePrototype.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
(JSC::ErrorConstructor::finishCreation):
* runtime/ErrorConstructor.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
(JSC::FunctionConstructor::finishCreation):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
(JSC::FunctionPrototype::finishCreation):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
(JSC::JSONObject::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSString.cpp:
(JSC::StringObject::create):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
(JSC::NumberConstructor::finishCreation):
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
(JSC::NumberObject::create):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::finishCreation):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::finishCreation):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::finishCreation):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
(JSC::StringPrototype::finishCreation):
* runtime/StringPrototype.h:
2011-09-06 Filip Pizlo <fpizlo@apple.com>
Accessibility tests crashing in BasicRawSentinelNode code
https://bugs.webkit.org/show_bug.cgi?id=67682
Reviewed by Geoffrey Garen.
A CodeBlock should ensure that no other CodeBlocks have references to it after
it is destroyed.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
2011-09-06 Yong Li <yoli@rim.com>
https://bugs.webkit.org/show_bug.cgi?id=67486
This reverts r65993 which gives wrong results for rshift
in some corner cases (see the test).
Reviewed by Gavin Barraclough.
New test: fast/js/floating-point-truncate-rshift.html
* assembler/ARMAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
2011-09-06 Filip Pizlo <fpizlo@apple.com>
Unreviewed build fix for r94559.
Marked the relevant parameters as unused if !ENABLE(JIT), and surrounded
new out-of-line JIT-specific method definitions with !ENABLE(JIT).
* bytecode/CodeBlock.cpp:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
Fix broken PPC build due to new dtoa library
https://bugs.webkit.org/show_bug.cgi?id=67654
Reviewed by Dan Bernstein.
Added condition for PPC in the new dtoa compatibility check so that
building won't fail.
* wtf/dtoa/utils.h:
2011-09-05 Oliver Hunt <oliver@apple.com>
An object's structure should reference the global object responsible for its creation
https://bugs.webkit.org/show_bug.cgi?id=67624
Reviewed by Gavin Barraclough.
Add a reference to a GlobalObject to Structure, and update all calls to
Structure::create() to pass the global object that is the origin for that
structure. For objects where the appropriate global object isn't available
at construction time (global object prototypes, etc), or objects that
logically don't have a global object (strings, etc) we just pass null.
This change is largely mechanical (passing a new globalObject parameter
around).
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure):
* runtime/Executable.h:
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSByteArray.h:
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):
(JSC::createEmptyObjectStructure):
* runtime/JSObjectWithGlobalObject.h:
(JSC::JSObjectWithGlobalObject::createStructure):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::RopeBuilder::createStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::createStructure):
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExp.h:
(JSC::RegExp::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::createStructure):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::createStructure):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/StringPrototype.h:
(JSC::StringPrototype::createStructure):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::globalObject):
(JSC::Structure::setGlobalObject):
* runtime/StructureChain.h:
(JSC::StructureChain::createStructure):
2011-09-06 Michael Saboff <msaboff@apple.com>
Add windows changes for JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67521
Windows build changes for regular expression functional test.
Rubber-stamped by Gavin Barraclough.
* JavaScriptCore.vcproj/JavaScriptCore.sln:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/testRegExp: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExp.vcproj: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpDebug.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpPostBuild.cmd: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpPreBuild.cmd: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpPreLink.cmd: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpProduction.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpRelease.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops: Added.
2011-09-06 Filip Pizlo <fpizlo@apple.com>
JavaScriptCore does not have tiered compilation
https://bugs.webkit.org/show_bug.cgi?id=67176
Reviewed by Gavin Barraclough.
This adds the ability to have multiple CodeBlocks associated with
a particular role in an Executable. These are stored in
descending order of compiler tier. CodeBlocks are optimized when
a counter (m_executeCounter) that is incremented in loops and
epilogues becomes positive. Optimizing means that all calls to
the old CodeBlock are unlinked.
The DFG can now pull in predictions from ValueProfiles, and
propagate them along the graph. To support the new phase while
maintaing some level of abstraction, a DFGDriver was introduced
that encapsulates how to run the DFG compiler.
This is turned off by default because it's not yet a performance
win on all benchmarks. It speeds up crypto and richards by
10% and 6% respectively, but still does not do as good of a job
as it could. Notably, the DFG backend has not changed, and
is largely oblivious to the new information being made available
to it.
When turned off (the default), this patch is performance neutral.
* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branchAdd32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchAdd32):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CallLinkInfo::unlink):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::clearEvalCache):
(JSC::replaceExistingEntries):
(JSC::CodeBlock::copyDataFromAlternative):
(JSC::ProgramCodeBlock::replacement):
(JSC::EvalCodeBlock::replacement):
(JSC::FunctionCodeBlock::replacement):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
* bytecode/CodeBlock.h:
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::dynamicallyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::parse):
* dfg/DFGDriver.cpp: Added.
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGDriver.h: Added.
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfDoubleConstant):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isConstant):
(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):
* dfg/DFGNode.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::valueOfInt32Constant):
(JSC::DFG::Node::valueOfDoubleConstant):
(JSC::DFG::Node::predict):
* dfg/DFGPropagation.cpp: Added.
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):
* dfg/DFGPropagation.h: Added.
(JSC::DFG::propagate):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* heap/HandleHeap.h:
(JSC::HandleHeap::Node::Node):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):
* jit/JIT.h:
(JSC::JIT::emitOptimizationCheck):
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITCode.h:
(JSC::JITCode::JITCode):
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileOptimizedFor):
* wtf/Platform.h:
* wtf/SentinelLinkedList.h:
(WTF::BasicRawSentinelNode::BasicRawSentinelNode):
(WTF::BasicRawSentinelNode::setPrev):
(WTF::BasicRawSentinelNode::setNext):
(WTF::BasicRawSentinelNode::prev):
(WTF::BasicRawSentinelNode::next):
(WTF::BasicRawSentinelNode::isOnList):
(WTF::::remove):
(WTF::::SentinelLinkedList):
(WTF::::begin):
(WTF::::end):
(WTF::::push):
2011-09-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r94445 and r94448.
http://trac.webkit.org/changeset/94445
http://trac.webkit.org/changeset/94448
https://bugs.webkit.org/show_bug.cgi?id=67595
It broke everything (Requested by ossy on #webkit).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):
2011-09-05 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for r94452.
Add config.h as the first header to the cc files as required by the coding style.
Reuse macros from Assertions.h instead of adding addional #ifdefs.
* wtf/dtoa/bignum-dtoa.cc:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/diy-fp.cc:
* wtf/dtoa/double-conversion.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/fixed-dtoa.cc:
* wtf/dtoa/strtod.cc:
* wtf/dtoa/utils.h:
2011-09-05 Andras Becsi <andras.becsi@nokia.com>
[Qt][WK2] Fix the build
Rubber-stamped by Csaba Osztrogonác.
* wtf/dtoa/double-conversion.cc: Remove dead variable in file added in r94452.
The variable fractional_part is only set but never used.
2011-09-04 Mark Hahnenberg <mhahnenberg@apple.com>
REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562
Reviewed by Darin Adler.
Fixing the build (again which was broken by the dtoa patch. Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/utils.h:
2011-09-03 Filip Pizlo <fpizlo@apple.com>
ThunkGenerators does not convert positive double zero into integer zero
https://bugs.webkit.org/show_bug.cgi?id=67553
Reviewed by Gavin Barraclough.
This is an 0.5% speed-up on V8 and neutral elsewhere.
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnDouble):
2011-09-03 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fix. Add wtf/dtoa directory to build.
* wscript:
2011-09-03 Filip Pizlo <fpizlo@apple.com>
DFG variable predictions only work for local variables, not temporaries
https://bugs.webkit.org/show_bug.cgi?id=67554
Reviewed by Gavin Barraclough.
This appears to be a slight speed-up in Kraken (0.3% but significant)
and neutral elsewhere.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
2011-09-02 Filip Pizlo <fpizlo@apple.com>
DFG JIT speculation failure does recovery of additions in reverse and
doesn't rebox
https://bugs.webkit.org/show_bug.cgi?id=67551
Reviewed by Sam Weinig.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
2011-09-02 Filip Pizlo <fpizlo@apple.com>
ValueProfile does not make it safe to introspect cell values
after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=67354
Reviewed by Gavin Barraclough.
ValueProfile buckets are now weak references, implemented using a
light-weight weak reference mechanism that this patch also adds (the
WeakReferenceHarvester). If a cell stored in a ValueProfile bucket
is not marked, then the bucket is transformed into a Structure
pointer. If the Structure is not marked either, then it is turned
into a ClassInfo pointer.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):
* bytecode/CodeBlock.h:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::probabilityOfArray):
(JSC::ValueProfile::WeakBucket::WeakBucket):
(JSC::ValueProfile::WeakBucket::operator!):
(JSC::ValueProfile::WeakBucket::isEmpty):
(JSC::ValueProfile::WeakBucket::isClassInfo):
(JSC::ValueProfile::WeakBucket::isStructure):
(JSC::ValueProfile::WeakBucket::asStructure):
(JSC::ValueProfile::WeakBucket::asClassInfo):
(JSC::ValueProfile::WeakBucket::getClassInfo):
* heap/Heap.cpp:
(JSC::Heap::harvestWeakReferences):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::harvestWeakReferences):
* heap/MarkStack.h:
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::appendUnbarrieredPointer):
* heap/SlotVisitor.h:
* heap/WeakReferenceHarvester.h: Added.
(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):
2011-09-02 Michael Saboff <msaboff@apple.com>
Replace local implementation of string equals() methods with UString versions
https://bugs.webkit.org/show_bug.cgi?id=67342
In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Change the uses of characters()
that are used to implement redundant equals() methods.
Reviewed by Gavin Barraclough.
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
* runtime/Identifier.h:
(JSC::Identifier::equal):
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::equal): Moved an optimized method to here.
(WTF::operator==):
* wtf/text/StringImpl.cpp:
(WTF::equal):
* wtf/text/StringImpl.h:
2011-09-02 Michael Saboff <msaboff@apple.com>
Add JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67339
Added new test driver program (testRegExp) and corresponding data file
along with build scripts changes.
Reviewed by Gavin Barraclough.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* testRegExp.cpp: Added.
(Options::Options):
(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(RegExpTest::RegExpTest):
(GlobalObject::create):
(GlobalObject::className):
(GlobalObject::GlobalObject):
(main):
(cleanupGlobalData):
(testOneRegExp):
(scanString):
(parseRegExpLine):
(parseTestLine):
(runFromFiles):
(printUsageStatement):
(parseArguments):
(realMain):
* tests/regexp: Added.
* tests/regexp/RegExpTest.data: Added.
2011-09-02 Michael Saboff <msaboff@apple.com>
Add JSC:RegExp functional test data generator
https://bugs.webkit.org/show_bug.cgi?id=67519
Add a data generator for regular expressions. To enable, change the
#undef REGEXP_FUNC_TEST_DATA_GEN to #define. Then compile and use
regular expressions. The resulting data will be in /tmp/RegExpTestsData.
Reviewed by Gavin Barraclough.
* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::clearRegExp):
(JSC::RegExpFunctionalTestCollector::get):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):
2011-09-02 Mark Hahnenberg <mhahnenberg@apple.com>
Fix the broken build due to dtoa patch
https://bugs.webkit.org/show_bug.cgi?id=67534
Reviewed by Oliver Hunt.
Fixing the build.
* GNUmakefile.list.am:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/utils.h:
2011-09-02 Oliver Hunt <oliver@apple.com>
Remove OldSpace classes
https://bugs.webkit.org/show_bug.cgi?id=67533
Reviewed by Gavin Barraclough.
Remove the unused OldSpace classes
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::writeBarrierSlowCase):
* heap/MarkedBlock.h:
* heap/OldSpace.cpp: Removed.
* heap/OldSpace.h: Removed.
2011-09-02 James Robinson <jamesr@chromium.org>
Compile fix for mac build.
* wtf/CheckedArithmetic.h:
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):
2011-08-30 Matthew Delaney <mdelaney@apple.com>
Read out of bounds in sUnpremultiplyData_RGBA8888 / ImageBufferData::getData
https://bugs.webkit.org/show_bug.cgi?id=65352
Reviewed by Simon Fraser.
New test: fast/canvas/canvas-getImageData-large-crash.html
This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207. The change to JSC
is just to add a new helper method described below.
* wtf/MathExtras.h:
(isWithinIntRange): Reports if a float's value is within the range expressible by an int.
2011-09-02 Mark Hahnenberg <mhahnenberg@apple.com>
Incorporate newer, faster dtoa library
https://bugs.webkit.org/show_bug.cgi?id=66346
Reviewed by Oliver Hunt.
Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa. The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/InitializeThreading.cpp:
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
* runtime/UString.cpp:
(JSC::UString::number):
* wtf/CMakeLists.txt:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/dtoa.cpp:
(WTF::dtoa):
* wtf/dtoa.h:
* wtf/dtoa/COPYING: Added.
* wtf/dtoa/LICENSE: Added.
* wtf/dtoa/README: Added.
* wtf/dtoa/bignum-dtoa.cc: Added.
* wtf/dtoa/bignum-dtoa.h: Added.
* wtf/dtoa/bignum.cc: Added.
* wtf/dtoa/bignum.h: Added.
(WTF::double_conversion::Bignum::Times10):
(WTF::double_conversion::Bignum::Equal):
(WTF::double_conversion::Bignum::LessEqual):
(WTF::double_conversion::Bignum::Less):
(WTF::double_conversion::Bignum::PlusEqual):
(WTF::double_conversion::Bignum::PlusLessEqual):
(WTF::double_conversion::Bignum::PlusLess):
(WTF::double_conversion::Bignum::EnsureCapacity):
(WTF::double_conversion::Bignum::BigitLength):
* wtf/dtoa/cached-powers.cc: Added.
* wtf/dtoa/cached-powers.h: Added.
* wtf/dtoa/diy-fp.cc: Added.
* wtf/dtoa/diy-fp.h: Added.
(WTF::double_conversion::DiyFp::DiyFp):
(WTF::double_conversion::DiyFp::Subtract):
(WTF::double_conversion::DiyFp::Minus):
(WTF::double_conversion::DiyFp::Times):
(WTF::double_conversion::DiyFp::Normalize):
(WTF::double_conversion::DiyFp::f):
(WTF::double_conversion::DiyFp::e):
(WTF::double_conversion::DiyFp::set_f):
(WTF::double_conversion::DiyFp::set_e):
* wtf/dtoa/double-conversion.cc: Added.
* wtf/dtoa/double-conversion.h: Added.
(WTF::double_conversion::DoubleToStringConverter::DoubleToStringConverter):
(WTF::double_conversion::StringToDoubleConverter::StringToDoubleConverter):
* wtf/dtoa/double.h: Added.
(WTF::double_conversion::double_to_uint64):
(WTF::double_conversion::uint64_to_double):
(WTF::double_conversion::Double::Double):
(WTF::double_conversion::Double::AsDiyFp):
(WTF::double_conversion::Double::AsNormalizedDiyFp):
(WTF::double_conversion::Double::AsUint64):
(WTF::double_conversion::Double::NextDouble):
(WTF::double_conversion::Double::Exponent):
(WTF::double_conversion::Double::Significand):
(WTF::double_conversion::Double::IsDenormal):
(WTF::double_conversion::Double::IsSpecial):
(WTF::double_conversion::Double::IsNan):
(WTF::double_conversion::Double::IsInfinite):
(WTF::double_conversion::Double::Sign):
(WTF::double_conversion::Double::UpperBoundary):
(WTF::double_conversion::Double::NormalizedBoundaries):
(WTF::double_conversion::Double::value):
(WTF::double_conversion::Double::SignificandSizeForOrderOfMagnitude):
(WTF::double_conversion::Double::Infinity):
(WTF::double_conversion::Double::NaN):
(WTF::double_conversion::Double::DiyFpToUint64):
* wtf/dtoa/fast-dtoa.cc: Added.
* wtf/dtoa/fast-dtoa.h: Added.
* wtf/dtoa/fixed-dtoa.cc: Added.
* wtf/dtoa/fixed-dtoa.h: Added.
* wtf/dtoa/strtod.cc: Added.
* wtf/dtoa/strtod.h: Added.
* wtf/dtoa/utils.h: Added.
(WTF::double_conversion::Max):
(WTF::double_conversion::Min):
(WTF::double_conversion::StrLength):
(WTF::double_conversion::Vector::Vector):
(WTF::double_conversion::Vector::SubVector):
(WTF::double_conversion::Vector::length):
(WTF::double_conversion::Vector::is_empty):
(WTF::double_conversion::Vector::start):
(WTF::double_conversion::Vector::operator[]):
(WTF::double_conversion::Vector::first):
(WTF::double_conversion::Vector::last):
(WTF::double_conversion::StringBuilder::StringBuilder):
(WTF::double_conversion::StringBuilder::~StringBuilder):
(WTF::double_conversion::StringBuilder::size):
(WTF::double_conversion::StringBuilder::position):
(WTF::double_conversion::StringBuilder::Reset):
(WTF::double_conversion::StringBuilder::AddCharacter):
(WTF::double_conversion::StringBuilder::AddString):
(WTF::double_conversion::StringBuilder::AddSubstring):
(WTF::double_conversion::StringBuilder::AddPadding):
(WTF::double_conversion::StringBuilder::Finalize):
(WTF::double_conversion::StringBuilder::is_finalized):
(WTF::double_conversion::BitCast):
* wtf/wtf.pri:
2011-09-02 Filip Pizlo <fpizlo@apple.com>
DFG graph has no way of distinguishing or reconciling between static
and dynamic predictions
https://bugs.webkit.org/show_bug.cgi?id=67343
Reviewed by Gavin Barraclough.
PredictedType now stores the source of the prediction. Merging predictions,
which was previously done with a bitwise or, is now done via the
mergePredictions (equivalent to |) and mergePrediction (equivalent to |=)
functions, which correctly handle combinations of static and dynamic.
This is performance-neutral, since all predictions are currently static and
so the code has no visible effects.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::staticallyPredictArray):
(JSC::DFG::ByteCodeParser::staticallyPredictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
* dfg/DFGNode.h:
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isDynamicPrediction):
(JSC::DFG::mergePredictions):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::predict):
2011-09-02 Oliver Hunt <oliver@apple.com>
Fix 32bit build.
* heap/NewSpace.h:
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursery):
2011-09-02 Oliver Hunt <oliver@apple.com>
Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494
Reviewed by Gavin Barraclough.
Switch to a bump allocator for the initial out of line
property storage. This gives us slightly faster allocation
for short lived objects that need out of line storage at
the cost of an additional memcpy when the object survives
a GC pass.
No performance impact.
* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursary):
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
(JSC::NewSpace::resetPropertyStorageNursary):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursary):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):
2011-09-01 Mark Rowe <mrowe@apple.com>
Fix the build.
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
2011-09-01 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174
Reviewed by Oliver Hunt.
Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::create):
* debugger/DebuggerActivation.h:
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::ArrayPrototype::finishCreation):
* runtime/ArrayPrototype.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
(JSC::BooleanObject::finishCreation):
* runtime/BooleanObject.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
(JSC::DateInstance::finishCreation):
* runtime/DateInstance.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::create):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::create):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::create):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
* runtime/JSONObject.h:
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
* runtime/MathObject.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
(JSC::NumberObject::finishCreation):
* runtime/NumberObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::create):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
* runtime/RegExpObject.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
(JSC::StringObject::finishCreation):
* runtime/StringObject.h:
2011-09-01 Daniel Bates <dbates@rim.com>
QNX GCC distribution doesn't support vasprintf()
https://bugs.webkit.org/show_bug.cgi?id=67423
Reviewed by Antonio Gomes.
* wtf/Platform.h: Don't enable HAVE_VASPRINTF when building with GCC on QNX.
2011-09-01 Michael Saboff <msaboff@apple.com>
Remove simple usage of UString::characters() from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=67340
In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Most of the changes below
change s->characters()[0] to s[0].
Reviewed by Geoffrey Garen.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
* bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::jsToNumber):
(JSC::parseFloat):
* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* runtime/RegExp.cpp:
(JSC::regExpFlags):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::operator[]):
2011-09-01 Ada Chan <adachan@apple.com>
Export fastMallocStatistics and Heap::objectTypeCounts for https://bugs.webkit.org/show_bug.cgi?id=67160.
Reviewed by Darin Adler.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-09-01 Hao Zheng <zhenghao@chromium.org>
Define PTHREAD_KEYS_MAX to fix Android port build.
https://bugs.webkit.org/show_bug.cgi?id=67362
Reviewed by Adam Barth.
PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it.
* wtf/ThreadIdentifierDataPthreads.cpp:
2011-08-31 Oliver Hunt <oliver@apple.com>
Fix build.
* wtf/CheckedArithmetic.h:
(WTF::Checked::Checked):
(WTF::Checked::operator=):
2011-08-31 Oliver Hunt <oliver@apple.com>
fast/regex/overflow.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=67326
Reviewed by Gavin Barraclough.
The deliberate overflows in these expressions don't interact nicely
with Checked<32bit-type> so we just bump up to Checked<int64_t> for the
intermediate calculations.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
2011-08-31 Jeff Miller <jeffm@apple.com>
REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316
Move the definition of WTF_USE_AVFOUNDATION on the Mac back to JavaScriptCore/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.
Reviewed by Darin Adler.
* wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.
2011-08-31 Peter Beverloo <peter@chromium.org>
Add Android's platform specification and the right atomic functions.
https://bugs.webkit.org/show_bug.cgi?id=66687
Reviewed by Adam Barth.
* wtf/Atomics.h:
(WTF::atomicIncrement):
(WTF::atomicDecrement):
* wtf/Platform.h:
2011-08-30 Oliver Hunt <oliver@apple.com>
Add support for checked arithmetic
https://bugs.webkit.org/show_bug.cgi?id=67095
Reviewed by Sam Weinig.
Add a checked arithmetic class Checked<T> that provides overflow-safe
arithmetic over all integral types. Checked<T> supports addition, subtraction
and multiplication, along with "bool" conversions and equality operators.
Checked<> can be used in either CRASH() on overflow or delayed failure modes,
although the default is to CRASH().
To ensure the code is actually in use (rather than checking in dead code) I've
made a couple of properties in YARR use Checked<int> and Checked<unsigned>
instead of raw value arithmetic. This has resulted in a moderate set of changes,
to YARR - mostly adding .get() calls, but a couple of casts from unsigned long
to unsigned for some uses of sizeof, as Checked<> currently does not support
mixed signed-ness of types wider that 32 bits.
Happily the increased type safety of Checked<> means that it's not possible to
accidentally assign away precision, nor accidentally call integer overload of
a function instead of the bool version.
No measurable regression in performance, and SunSpider claims this patch to be
a progression of 0.3%.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CheckedArithmetic.h: Added.
(WTF::CrashOnOverflow::overflowed):
(WTF::CrashOnOverflow::clearOverflow):
(WTF::CrashOnOverflow::hasOverflowed):
(WTF::RecordOverflow::RecordOverflow):
(WTF::RecordOverflow::overflowed):
(WTF::RecordOverflow::clearOverflow):
(WTF::RecordOverflow::hasOverflowed):
(WTF::isInBounds):
(WTF::safeAdd):
(WTF::safeSub):
(WTF::safeMultiply):
(WTF::safeEquals):
(WTF::workAroundClangBug):
(WTF::Checked::Checked):
(WTF::Checked::operator=):
(WTF::Checked::operator++):
(WTF::Checked::operator--):
(WTF::Checked::operator!):
(WTF::Checked::operator UnspecifiedBoolType*):
(WTF::Checked::get):
(WTF::Checked::operator+=):
(WTF::Checked::operator-=):
(WTF::Checked::operator*=):
(WTF::Checked::operator==):
(WTF::Checked::operator!=):
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
* yarr/YarrInterpreter.h:
(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::UncheckInput):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
* yarr/YarrPattern.h:
2011-08-31 Andrei Popescu <andreip@google.com>
Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761
Unreviewed, build fix for ARM platforms.
* wtf/Platform.h:
2011-08-31 Andrei Popescu <andreip@google.com>
Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761
Reviewed by Darin Adler.
Remove the last legacy Android code.
No new tests needed as the code wasn't tested in the first place.
* wtf/Atomics.h:
* wtf/Platform.h:
* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
2011-08-30 Aaron Colwell <acolwell@chromium.org>
Add MediaSource API to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=64731
Reviewed by Eric Carlson.
* Configurations/FeatureDefines.xcconfig:
2011-08-30 Oliver Hunt <oliver@apple.com>
TypedArrays don't ensure that denormalised values are normalised
https://bugs.webkit.org/show_bug.cgi?id=67178
Reviewed by Gavin Barraclough.
Add a couple of assertions to jsNumber() to ensure that
we block signaling NaNs
* runtime/JSValue.h:
(JSC::jsDoubleNumber):
(JSC::jsNumber):
2011-08-30 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
[Qt] Do not unconditionally use pkg-config in .pro files
https://bugs.webkit.org/show_bug.cgi?id=67055
Reviewed by Andreas Kling.
Original patch from Rohan McGovern <rohan.mcgovern@nokia.com>
Using the first pkg-config in PATH is prone to errors when cross
compiling inside the Qt repository (using Qt's build-system).
This patch protect calls for pkg-config with
!contains(QT_CONFIG, no-pkg-config). no-pkg-config is added to
QT_CONFIG by Qt's 'configure' when cross-compiling on systems
without pkg-config.
The respective change in Qt's configure has been submited already.
No new tests as this is just a build change.
* wtf/wtf.pri: protect pkg-config calls
2011-08-29 Daniel Bates <dbates@webkit.org>
Add HAVE(VASPRINTF) macro to test for vasprintf() support
https://bugs.webkit.org/show_bug.cgi?id=67156
Reviewed by Darin Adler.
Encapsulate testing of vasprintf() support in a HAVE macro
instead of hardcoding the list of supported/unsupported
compilers at the call site.
* wtf/Platform.h:
2011-08-29 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (3/7)
https://bugs.webkit.org/show_bug.cgi?id=67064
Reviewed by Darin Adler.
Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::finishCreation):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
(JSC::Arguments::finishCreation):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::finishCreation):
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
Moved the assignment of m_firstLine and m_lastLine into the
FunctionExecutable::finishCreation() method in Executable.h
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::finishCreation):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::finishCreation):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
* runtime/JSObject.h:
(JSC::JSNonFinalObject::JSNonFinalObject):
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::finishCreation):
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::finishCreation):
* runtime/ObjectPrototype.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
2011-08-29 Andreas Kling <kling@webkit.org>
Unreviewed build fix after r93990.
* wtf/HashTable.h:
2011-08-29 Andreas Kling <kling@webkit.org>
Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133
Reviewed by Darin Adler.
Add a minimum table size to the HashTraits, instead of having it hard coded.
The default value remains at 64, but can now be specialized.
* runtime/StructureTransitionTable.h:
* wtf/HashTable.h:
(WTF::HashTable::shouldShrink):
(WTF::::expand):
(WTF::::checkTableConsistencyExceptSize):
* wtf/HashTraits.h:
2011-08-28 Jonathan Liu <net147@gmail.com>
Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
https://bugs.webkit.org/show_bug.cgi?id=61235
Reviewed by Gavin Barraclough.
The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.
* wtf/Platform.h:
2011-08-27 Filip Pizlo <fpizlo@apple.com>
JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
https://bugs.webkit.org/show_bug.cgi?id=67072
Reviewed by Darin Adler.
Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode(). This also means that the finalizer is now enabled even
when the JIT is turned off. This is performance neutral on SunSpider,
V8, and Kraken.
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation):
2011-08-26 Gavin Barraclough <barraclough@apple.com>
DFG JIT - ArithMod may clobber operands.
https://bugs.webkit.org/show_bug.cgi?id=67085
Reviewed by Sam Weinig.
unboxDouble must be called on a temporary.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
2011-08-26 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (2/7)
https://bugs.webkit.org/show_bug.cgi?id=66957
Reviewed by Darin Adler.
Completed the second level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
* runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::create):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSObject.h:
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::JSObject):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::create):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::create):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::finishCreation):
(JSC::Structure::createStructure):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
2011-08-26 Filip Pizlo <fpizlo@apple.com>
The GC does not have a facility for profiling the kinds of objects
that occupy the heap
https://bugs.webkit.org/show_bug.cgi?id=66849
Reviewed by Geoffrey Garen.
Destructor calls and object scans are now optionally counted, per
vtable. When the heap is destroyed and profiling is enabled, the
counts are dumped, with care taken to print the names of classes
(modulo C++ mangling) sorted in descending commonality.
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::destroy):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):
* heap/MarkStack.h:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
* heap/MarkedBlock.h:
* heap/VTableSpectrum.cpp: Added.
(JSC::VTableSpectrum::VTableSpectrum):
(JSC::VTableSpectrum::~VTableSpectrum):
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::count):
(JSC::VTableAndCount::VTableAndCount):
(JSC::VTableAndCount::operator<):
(JSC::VTableSpectrum::dump):
* heap/VTableSpectrum.h: Added.
* wtf/Platform.h:
2011-08-26 Juan C. Montemayor <jmont@apple.com>
Update topCallFrame when calling host functions in the JIT
https://bugs.webkit.org/show_bug.cgi?id=67010
Reviewed by Oliver Hunt.
The topCallFrame is not being updated when a host function is
called by the JIT. This causes problems when trying to create a
stack trace (https://bugs.webkit.org/show_bug.cgi?id=66994).
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
2011-08-26 Alexey Proskuryakov <ap@apple.com>
Get rid of frame life support timer
https://bugs.webkit.org/show_bug.cgi?id=66874
Reviewed by Geoff Garen.
* runtime/JSGlobalObject.h:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
globalExec() no longer needs to be virtual, its only override was in JSDOMWindowBase.
2011-08-26 Chao-ying Fu <fu@mips.com>
Fix MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=67046
Reviewed by Gavin Barraclough.
* jit/JIT.h:
2011-08-25 Mark Hahnenberg <mhahnenberg@apple.com>
Fixing broken build due to unused variables in release mode
https://bugs.webkit.org/show_bug.cgi?id=67004
Unreviewed, release build fix.
Fixing broken build due to unused variables in ASSERTs in release build.
* runtime/JSObject.h:
(JSC::JSObject::finishCreation):
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::finishCreation):
2011-08-25 Mark Hahnenberg <mhahnenberg@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (1/7)
https://bugs.webkit.org/show_bug.cgi?id=66827
Reviewed by Geoffrey Garen.
Added finishCreation() methods to all immediately subclasses of JSCell with
non-empty constructors. Part of a larger refactoring to "unzip" initialization
lists and constructor bodies. Also renamed JSCell's constructorBody() method
to finishCreation().
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::constructorBody):
* runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::constructorBody):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::constructorBody):
* runtime/JSObject.h:
(JSC::JSObject::constructorBody):
(JSC::JSObject::JSObject):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::constructorBody):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::constructorBody):
* runtime/RegExp.h:
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::constructorBody):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::constructorBody):
2011-08-25 Gabor Loki <loki@webkit.org>
REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
https://bugs.webkit.org/show_bug.cgi?id=66956
Rebaseline constants for patching GetByIdSlowCaseCall on ARM.
Reviewed by Oliver Hunt.
* jit/JIT.h:
2011-08-24 Juan C. Montemayor <jmont@apple.com>
Keep track of topCallFrame for Stack traces
https://bugs.webkit.org/show_bug.cgi?id=66571
Reviewed by Geoffrey Garen.
This patch adds a TopCallFrame to JSC in order to have that information
when an error is thrown to create a stack trace. The TopCallFrame is
updated throughout select points in the Interpreter and the JSC.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):
* jit/JITStubCall.h:
(JSC::JITStubCall::call):
* jit/JITStubs.cpp:
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::arityCheckFor):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
2011-08-24 Filip Pizlo <fpizlo@apple.com>
ErrorInstance::create sometimes has two heap object constructions
in flight at once
https://bugs.webkit.org/show_bug.cgi?id=66845
Reviewed by Darin Adler.
The fix is simple since there is already a second create() method
that takes a UString.
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::create):
2011-08-24 Filip Pizlo <fpizlo@apple.com>
There is no facility for profiling how the write barrier is used
https://bugs.webkit.org/show_bug.cgi?id=66747
Reviewed by Geoffrey Garen.
Added facilities for the JIT to specify the kind of write barrier
being executed. Added code for profiling the number of each kind
of barrier encountered.
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::emitCount):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::emitCount):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/Heap.h:
(JSC::Heap::writeBarrier):
* heap/WriteBarrierSupport.cpp: Added.
(JSC::WriteBarrierCounters::initialize):
* heap/WriteBarrierSupport.h: Added.
(JSC::WriteBarrierCounters::WriteBarrierCounters):
(JSC::WriteBarrierCounters::jitCounterFor):
(JSC::WriteBarrierCounters::countWriteBarrier):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-08-23 Mark Hahnenberg <mhahnenberg@apple.com>
Add checks to ensure allocation does not take place during initialization of GC-managed objects
https://bugs.webkit.org/show_bug.cgi?id=65288
Reviewed by Darin Adler.
Adding the new validation functionality. In its current state, it will performs checks,
but they don't fail unless you do allocation in the arguments to the parent constructor in the
initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
allowed in constructor bodies while other refactoring efforts continue.
* runtime/JSCell.h:
(JSC::JSCell::JSCell::constructorBody):
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::allocateCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObject):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
2011-08-23 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype
Reviewed by Sam Weinig.
The default value of a NativeErrorPrototype's message
property is "", not the name of the error.
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
* runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):
2011-08-23 Steve Block <steveblock@google.com>
Remove last occurrences of PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66763
Reviewed by Tony Gentilcore.
* wtf/Platform.h:
2011-08-23 Steve Block <steveblock@google.com>
Remove all mention of removed Android files from build scripts
https://bugs.webkit.org/show_bug.cgi?id=66755
Reviewed by Tony Gentilcore.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-08-23 Adam Barth <abarth@webkit.org>
Remove WebCore/editing/android and other Android-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66739
Reviewed by Steve Block.
Now that Android shares more code with Chromium, we don't need these
Android-specific files.
* wtf/android: Removed.
* wtf/android/AndroidThreading.h: Removed.
* wtf/android/MainThreadAndroid.cpp: Removed.
2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for compile error on Windows for r93560.
* runtime/SamplingCounter.h:
2011-08-22 Filip Pizlo <fpizlo@apple.com>
Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724
Reviewed by Darin Adler.
Moved SamplingCounter to a separate header in runtime/.
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.cpp:
* bytecode/SamplingTool.h:
* runtime/SamplingCounter.cpp: Added.
(JSC::AbstractSamplingCounter::dump):
* runtime/SamplingCounter.h: Added.
(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
2011-08-21 Martin Robinson <mrobinson@igalia.com>
Fix 'make dist' for WebKitGTK+.
* GNUmakefile.list.am: Add a missing header to the sources list.
2011-08-20 Filip Pizlo <fpizlo@apple.com>
JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572
Reviewed by Oliver Hunt.
Changed the handling of const to add the dynamic scope depth.
* bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
2011-08-19 Daniel Bates <dbates@webkit.org>
Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=66617
Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
But we cause a compile error if the platform doesn't support SA_RESTART regardless of
whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.
Reviewed by Antonio Gomes.
* heap/MachineStackMarker.cpp:
2011-08-19 Filip Pizlo <fpizlo@apple.com>
The JSC JIT currently has no facility to profile and report
the types of values
https://bugs.webkit.org/show_bug.cgi?id=65901
Reviewed by Gavin Barraclough.
Added the ability to profile the values seen at function calls (both
arguments and results) and heap loads. This is done with emphasis
on performance. A value profiling site consists of: add, and,
move, and store; no branching is necessary. Each value profiling
site (called a ValueProfile) has a ring buffer of 8 recently-seen
values. ValueProfiles are stored in the CodeBlock; there will be
one for each argument (excluding this) and each heap load or callsite.
Each time a value profiling site executes, it stores the value into
a pseudo-random element in the ValueProfile buffer. The point is
that for frequently executed code, we will have 8 somewhat recent
values in the buffer and will be able to not only figure out what
type it is, but also to be able to reason about the actual values
if we wish to do so.
This feature is currently disabled by default. When enabled, it
results in a 3.7% slow-down on SunSpider.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::numberOfValueProfiles):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
* bytecode/ValueProfile.h: Added.
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::computeProbability):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::probabilityOfInt32):
(JSC::ValueProfile::probabilityOfDouble):
(JSC::ValueProfile::probabilityOfCell):
(JSC::getValueProfileBytecodeOffset):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
* jit/JSInterfaceJIT.h:
* wtf/Platform.h:
* wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::genericBinarySearch):
2011-08-19 Daniel Bates <dbates@webkit.org>
Don't include DisallowCType.h when building on QNX
https://bugs.webkit.org/show_bug.cgi?id=66616
Reviewed by Antonio Gomes.
* config.h:
2011-08-19 Daniel Bates <dbates@webkit.org>
Implement ExecutableAllocator::cacheFlush() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66611
Reviewed by Antonio Gomes.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2011-08-19 Daniel Bates <dbates@webkit.org>
Implement WTF::atomic{Increment, Decrement}() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66605
Reviewed by Darin Adler.
* wtf/Atomics.h:
(WTF::atomicIncrement):
(WTF::atomicDecrement):
2011-08-19 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=66590
Re-name scrollbar painter types
Reviewed by Sam Weinig.
WTF_USE_WK_SCROLLBAR_PAINTER is now WTF_USE_SCROLLBAR_PAINTER since WK no longer
applies.
* wtf/Platform.h:
2011-08-18 Mark Hahnenberg <mhahnenberg@apple.com>
Move allocation in constructors into separate constructorBody() methods
https://bugs.webkit.org/show_bug.cgi?id=66265
Reviewed by Oliver Hunt.
Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jsc.cpp:
(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::constructorBody):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::constructorBody):
* runtime/ErrorPrototype.h:
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::FunctionExecutable::constructorBody):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
(JSC::InternalFunction::constructorBody):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::constructorBody):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::constructorBody):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::constructorBody):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::constructorBody):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
* runtime/NativeErrorPrototype.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):
2011-08-10 Filip Pizlo <fpizlo@apple.com>
DFG non-speculative JIT does not inline the double case of ValueAdd
https://bugs.webkit.org/show_bug.cgi?id=66025
Reviewed by Gavin Barraclough.
This is a 1.3% win on Kraken overall, with >=8% speed-ups on a few
benchmarks (imaging-darkroom, stanford-crypto-pbkdf2,
stanford-crypto-sha256-iterative). It looks like it might have
a speed-up in SunSpider (though not statistically significant or
particularly reproducible) and a slight slow-down in V8 (0.14%,
not statistically significant). It does slow down v8-crypto by
1.5%.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
* dfg/DFGOperations.cpp:
2011-08-18 Filip Pizlo <fpizlo@apple.com>
[jsfunfuzz] DFG speculative JIT does divide-by-zero checks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66426
Reviewed by Oliver Hunt.
Changed the branchTestPtr to branchTest32.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-08-17 Thouraya ANDOLSI <thouraya.andolsi@st.com>
https://bugs.webkit.org/show_bug.cgi?id=66379
implements load32WithCompactAddressOffsetPatch function
and fixes store32 and moveWithPatch functions for SH4 platforms.
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::store32):
(JSC::MacroAssemblerSH4::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerSH4::moveWithPatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::movlMemRegCompact):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::repatchCompact):
* jit/JIT.h:
2011-08-17 Filip Pizlo <fpizlo@apple.com>
JSC verbose debugging output sometimes doesn't work as expected.
https://bugs.webkit.org/show_bug.cgi?id=66107
Reviewed by Gavin Barraclough.
Hardened the CodeBlock::dump() code so that it no longer crashes. Improved
the DFG verbose code so that it prints slightly more useful information.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::debugSize):
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfRegExps):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
2011-08-16 Michael Saboff <msaboff@apple.com>
Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=66351
JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively. In some cases,
we may get to this generated code with one or both of these
registers trash. One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress(). This patch uses the
values on the stack. A longer term solution is to work out all
cases so that the register entry assumptions can assured.
While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.
Reviewed by Gavin Barraclough.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
2011-08-15 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations
Reviewed by Sam Weinig.
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
- Change bool return values to a 64-bit type.
2011-08-15 Gavin Barraclough <barraclough@apple.com>
Crash accessing static property on sealed object
https://bugs.webkit.org/show_bug.cgi?id=66242
Reviewed by Sam Weinig.
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
- should only check isExtensible if checkReadOnly.
2011-08-15 Sam Weinig <sam@webkit.org>
Fix release build when building with Clang.
Reviewed by Anders Carlsson.
* runtime/Identifier.cpp:
(JSC::Identifier::checkCurrentIdentifierTable):
Add NO_RETURN_DUE_TO_CRASH.
2011-08-15 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025
Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.
* wtf/StdLibExtras.h:
(WTF::binarySearch):
2011-08-13 Sam Weinig <sam@webkit.org>
Add back 0xbbadbeef to CRASH to allow for old habits
https://bugs.webkit.org/show_bug.cgi?id=66190
Reviewed by David Kilzer.
* wtf/Assertions.h:
Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.
2011-08-13 Sam Weinig <sam@webkit.org>
Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=66182
Reviewed by Dan Bernstein.
Fixes 10 warnings in JavaScriptCore and 2 in testapi.
* API/tests/testapi.c:
(main):
Remove dead variables.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).
* wtf/dtoa.cpp:
(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.
2011-08-12 Sam Weinig <sam@webkit.org>
Use __builtin_trap() for CRASH when building with clang
https://bugs.webkit.org/show_bug.cgi?id=66152
Reviewed by Anders Carlsson.
* wtf/Assertions.h:
Add Clang specific CRASH macro that calls __builtin_trap() instead
of silly techniques to crash. This allows the static analyzer to understand
that we are intentionally crashing. As a result, we need to mark some functions
as not returning.
Also adds a macros that annotates a function as never returning due to ASSERT or CRASH.
* wtf/Compiler.h:
Add COMPILIER(CLANG) and fix some formatting and spelling mistakes.
* wtf/FastMalloc.cpp:
(WTF::Internal::fastMallocMatchFailed):
Add NO_RETURN_DUE_TO_CRASH.
* yarr/YarrParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
Add NO_RETURN_DUE_TO_ASSERT.
2011-08-12 Filip Pizlo <fpizlo@apple.com>
DFG JIT has inconsistent use of boxDouble and unboxDouble,
inconsistent use of assertions regarding doubles, and those
assertions are not turned on in debug builds
https://bugs.webkit.org/show_bug.cgi?id=66160
Reviewed by Gavin Barraclough.
JIT assertions are now turned on in debug builds. JIT
assertions are now used for boxing and unboxing doubles, and boxing
and unboxing no longer involves code duplication.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):
2011-08-12 Mark Rowe <mrowe@apple.com>
Be more forward-looking in the choice of compiler.
Rubber-stamped by Jon Honeycutt.
* Configurations/CompilerVersion.xcconfig:
2011-08-12 Kalev Lember <kalevlember@gmail.com>
[GTK] Fix non-pthreads build after r91906.
https://bugs.webkit.org/show_bug.cgi?id=66151
Reviewed by David Levin.
r91906 broke the non-pthreads GTK+ build by including a header which
doesn't exist. Fix it by including DateMath.h instead of DateMap.h.
* wtf/gtk/ThreadingGtk.cpp:
2011-08-12 Mark Rowe <mrowe@apple.com>
Update some configuration settings that were missed back in r92432.
* Configurations/CompilerVersion.xcconfig:
2011-08-12 Filip Pizlo <fpizlo@apple.com>
REGRESSION (r91610?): Bing Maps fail to initialize (InvalidOperation:
Matrix3D.invert)
https://bugs.webkit.org/show_bug.cgi?id=66038
Reviewed by Gavin Barraclough.
Simplest and lowest-impact fix for the case where the spilled format
of a DFG node differs from the register format: if the format is
converted then indicate that the spilled value is no longer valid
("kill the spill").
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::killSpilled):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
2011-08-12 Sam Weinig <sam@webkit.org>
Move compiler specific macros to their own header
https://bugs.webkit.org/show_bug.cgi?id=66119
Reviewed by Anders Carlsson.
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
Add Compiler.h
* wtf/AlwaysInline.h:
Move the contents of this file (which no longer was just about ALWAYS_INLINE) to
Compiler.h. We can remove this file in a later commit.
* wtf/Compiler.h: Added.
Put all compiler specific checks and features in this file.
* wtf/Platform.h:
Move COMPILER macro and definitions (and the odd WARN_UNUSED_RETURN compiler feature)
to Compiler.h. Include Compiler.h since it is necessary.
2011-08-11 Filip Pizlo <fpizlo@apple.com>
DFG JIT-specific structure stub info code offset fields are signed
8-bit, but it is possible for the offsets to be greater than 127
https://bugs.webkit.org/show_bug.cgi?id=66122
Reviewed by Gavin Barraclough.
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
2011-08-11 Filip Pizlo <fpizlo@apple.com>
DFG JIT speculation failure code sometimes picks the wrong register
as a scratch register.
https://bugs.webkit.org/show_bug.cgi?id=66104
Reviewed by Gavin Barraclough.
Hardened the code with more assertions and fixed the bug. Now a
spilled register is only used for scratch if it also isn't being
used for shuffling.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
2011-08-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r92880.
http://trac.webkit.org/changeset/92880
https://bugs.webkit.org/show_bug.cgi?id=66123
Breaks compile in VS2010 (Requested by jamesr_ on #webkit).
* wtf/PassRefPtr.h:
2011-08-11 Mark Rowe <mrowe@apple.com>
Don't conditionalize the use of -fomit-frame-pointer on compiler version as
all of our supported compilers are now new enough to have the same, sane behavior.
Rubber-stamped by Sam Weinig.
* Configurations/JavaScriptCore.xcconfig:
2011-08-11 Filip Pizlo <fpizlo@apple.com>
DFG JIT verbose mode does not report the generated types of nodes
https://bugs.webkit.org/show_bug.cgi?id=65830
Reviewed by Sam Weinig.
Added code that prints the type selected for each node's result.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::dataFormatToString):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-08-11 James Robinson <jamesr@chromium.org>
nullptr can't be used for PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=66024
Reviewed by Anders Carlsson.
* wtf/PassRefPtr.h:
(WTF::PassRefPtr::PassRefPtr):
2011-08-11 Daniel Bates <dbates@rim.com>
Removed unused variable in StackBounds::initialize() to resolve
compiler warning when building on QNX.
https://bugs.webkit.org/show_bug.cgi?id=66072
Reviewed by Antonio Gomes.
* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
2011-08-11 Devdatta Deshpande <pwjd73@motorola.com>
Implementation of monotonically increasing clock on GTK
https://bugs.webkit.org/show_bug.cgi?id=62175
Reviewed by Martin Robinson.
* wtf/CurrentTime.cpp:
(WTF::monotonicallyIncreasingTime):
The default implementation of monotonicallyIncreasingTime only
guarantees the result to be non-decreasing.
If the system time is changed to past then default implementation will
still fail and WebCore timers will not fire.
2011-08-10 Geoffrey Garen <ggaren@apple.com>
Removed some incorrect code that was dead.
Reviewed by Oliver Hunt.
clearSingleTransition() wasn't resetting m_data. Luckily,
no one cares, because its caller was unused. Removed both.
* runtime/Structure.cpp:
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::~StructureTransitionTable):
2011-08-10 Filip Pizlo <fpizlo@apple.com>
REGRESSION(r92670-r92744): WebKit crashes when opening Gmail
https://bugs.webkit.org/show_bug.cgi?id=66010
Reviewed by Oliver Hunt.
Made sure that Construct calls use() on the this argument.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
2011-08-10 Mark Hahnenberg <mhahnenberg@apple.com>
JSC should always throw when function arg list is too long
https://bugs.webkit.org/show_bug.cgi?id=65869
Reviewed by Oliver Hunt.
Changed the behavior of the interpreter and JIT to throw an exception
when too many arguments are passed rather than truncating the list. Added
a new method to create a "Too many arguments." exception used by this
new functionality.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ExceptionHelpers.cpp:
(JSC::createTooManyParamsError):
* runtime/ExceptionHelpers.h:
2011-08-10 Oliver Hunt <oliver@apple.com>
Make GC checks more aggressive in release builds
https://bugs.webkit.org/show_bug.cgi?id=66001
Reviewed by Gavin Barraclough.
* heap/HandleHeap.cpp:
(JSC::HandleHeap::visitStrongHandles):
(JSC::HandleHeap::visitWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):
(JSC::HandleHeap::isValidWeakNode):
Increase handle heap validation logic, and make some of
the crashes trigger in release builds as well as debug.
* heap/HandleHeap.h:
(JSC::HandleHeap::allocate):
(JSC::HandleHeap::makeWeak):
Ditto
* runtime/JSGlobalData.cpp:
(WTF::Recompiler::operator()):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
Fix GC bugs found while testing this patch
2011-08-10 Oliver Hunt <oliver@apple.com>
JSEvaluteScript does not return the correct object when given JSONP data
https://bugs.webkit.org/show_bug.cgi?id=66003
Reviewed by Gavin Barraclough.
Make sure we propagate the result of the function call rather than the
argument.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
2011-08-10 Filip Pizlo <fpizlo@apple.com>
DFG JIT heap prediction causes regressions when combined with
aggressive integer prediction
https://bugs.webkit.org/show_bug.cgi?id=65954
Reviewed by Gavin Barraclough.
Disabled heap prediction, but did not remove the capability.
This improves V8 crypto performance by 20%.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
2011-08-09 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not speculative integers as aggressively as it should
https://bugs.webkit.org/show_bug.cgi?id=65949
Reviewed by Gavin Barraclough.
Added a tree walk to propagate integer predictions through arithmetic
expressions.
This is a 71% speed-up on Kraken's imaging-gaussian-blur, which
translates to a 19% speed-up on Kraken overall. It's neutral on
other benchmarks.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::predictInt32):
2011-08-09 Filip Pizlo <fpizlo@apple.com>
DFG JIT has no way of propagating predictions to loads and calls
https://bugs.webkit.org/show_bug.cgi?id=65883
Reviewed by Gavin Barraclough.
This introduces the capability to store predictions on graph
nodes. To save space while being somewhat consistent, the
prediction is always stored in the second OpInfo slot (since
a GetById will use the first one for the identifier). This
change is a natural extension of r92593 (global variable
prediction).
This is a 1.5% win on V8 in the arithmetic mean, and a 0.6%
win on V8 in the geometric mean. It is neutral on SunSpider
and Kraken. Interestingly, on V8 it regresses crypto by 3%
while progressing deltablue and richards by 2.6% and 4.3%,
respectively.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::getPrediction):
(JSC::DFG::Node::predict):
2011-08-09 Filip Pizlo <fpizlo@apple.com>
DFG JIT passes the this argument to constructors even though
it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=65943
Reviewed by Gavin Barraclough.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
2011-08-09 Chao-ying Fu <fu@mips.com>
Fix one MIPS instruction to call JITStubThunked_##op
https://bugs.webkit.org/show_bug.cgi?id=65942
Reviewed by Gavin Barraclough.
Changed "bal" to "jalr" for a possible processor mode change from
MIPS32 to MIPS16.
* jit/JITStubs.cpp:
2011-08-09 Filip Pizlo <fpizlo@apple.com>
DFG JIT failure loading web site
https://bugs.webkit.org/show_bug.cgi?id=65930
Reviewed by Oliver Hunt.
Put the use() call after the fpr()/gpr() calls, since doing otherwise
breaks the register allocator.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
2011-08-09 Mark Hahnenberg <mhahnenberg@apple.com>
Add ParentClass typedef in all JSC classes
https://bugs.webkit.org/show_bug.cgi?id=65731
Reviewed by Oliver Hunt.
Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.
* API/JSCallbackConstructor.h:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
(JSC::JSCallbackObject::visitChildren):
* API/JSCallbackObjectFunctions.h:
(JSC::::asCallbackObject):
(JSC::::JSCallbackObject):
(JSC::::init):
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getConstructData):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::setPrivate):
(JSC::::getPrivate):
(JSC::::inherits):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* debugger/DebuggerActivation.h:
* jsc.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.h:
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.h:
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.h:
* runtime/DateInstance.h:
* runtime/DatePrototype.h:
* runtime/Error.cpp:
* runtime/ErrorConstructor.h:
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
* runtime/Executable.h:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.h:
* runtime/GetterSetter.h:
* runtime/InternalFunction.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSActivation.h:
* runtime/JSArray.h:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.h:
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.h:
* runtime/JSVariableObject.h:
* runtime/JSWrapperObject.h:
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.h:
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.h:
* runtime/NumberObject.h:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.h:
* runtime/RegExp.h:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.h:
* runtime/ScopeChain.h:
* runtime/StrictEvalActivation.h:
* runtime/StringConstructor.h:
* runtime/StringObject.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
* runtime/StringPrototype.h:
* runtime/Structure.h:
* runtime/StructureChain.h:
2011-08-08 Oliver Hunt <oliver@apple.com>
Using mprotect to create guard pages breaks our use of madvise to release executable memory
https://bugs.webkit.org/show_bug.cgi?id=65870
Reviewed by Gavin Barraclough.
Use mmap rather than mprotect to clear guard page permissions.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
2011-08-08 Oliver Hunt <oliver@apple.com>
Non-extensibility does not prevent mutating [[Prototype]]
https://bugs.webkit.org/show_bug.cgi?id=65832
Reviewed by Gavin Barraclough.
Disallow mutation of __proto__ on objects that are not extensible.
* runtime/JSObject.cpp:
(JSC::JSObject::put):
2011-08-08 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not track speculation decisions for global variables
https://bugs.webkit.org/show_bug.cgi?id=65825
Reviewed by Gavin Barraclough.
Added the capability to track predictions for global variables, and
ensured that code can abstract over the source of prediction (local
versus global variable) wherever it is appropriate to do so. Also
cleaned up the code in SpeculativeJIT that decides how to speculate
based on recorded predictions (for example instead of using isInteger,
which makes sense for local predictions where the GetLocal would
return an integer value, we now tend to use shouldSpeculateInteger,
which checks if the value is either already an integer or should be
speculated to be an integer).
This is an 0.8% win on SunSpider, almost entirely thanks to a 25%
win on controlflow-recursive. It's also a 4.8% win on v8-crypto.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
2011-08-07 Martin Robinson <mrobinson@igalia.com>
Distribution fix for GTK+.
* GNUmakefile.list.am: Strip removed files from the source list.
2011-08-06 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.
Reviewed by Oliver Hunt.
This is a 1% win on SunSpider.
* dfg/DFGOperations.cpp:
- Use fastGetOwnProperty.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Use fastGetOwnProperty.
* runtime/JSCell.h:
* runtime/JSObject.h:
(JSC::JSCell::fastGetOwnProperty):
- Fast call to get a property without creating an identifier the first time.
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):
- Add interface to look up by either strinsg or identifiers.
* runtime/Structure.h:
(JSC::Structure::get):
- Add a get() call that takes a UString, not an Identifier.
* wtf/text/StringImpl.h:
(WTF::StringImpl::hasHash):
- Add a call to check if the has has been set (to detect the first use as a property name).
2011-08-06 Aron Rosenberg <arosenberg@logitech.com>
Reviewed by Benjamin Poulain.
[Qt] Fix build with Intel compiler on Windows
https://bugs.webkit.org/show_bug.cgi?id=65088
Intel compiler needs .lib suffixes instead of .a
Intel compiler doesn't support nullptr
Intel compiler supports unsized arrays
* JavaScriptCore.pri:
* jsc.cpp:
* wtf/ByteArray.h:
* wtf/NullPtr.h:
2011-08-05 Gavin Barraclough <barraclough@apple.com>
String replace with the empty string means string removal
https://bugs.webkit.org/show_bug.cgi?id=65799
Reviewed by Sam Weinig.
Optimization for String.prototype.replace([RegExp], ""), this improves v8-regexp by ~3%.
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::stringProtoFuncReplace):
2011-08-05 Noel Gordon <noel.gordon@gmail.com>
[Chromium] Remove JSZombie references from gyp project files.
https://bugs.webkit.org/show_bug.cgi?id=65798
JSC runtime/JSZombie.{cpp,h} were removed in r92046. Remove references to these
file names from the gyp projects.
Reviewed by Darin Adler.
* JavaScriptCore.gypi: zombies be gone.
2011-08-05 Mark Rowe <mrowe@apple.com>
<http://webkit.org/b/65785> ThreadRestrictionVerifier needs a mode where an object
is tied to a particular dispatch queue
A RefCounted object can be opted in to this mode by calling setDispatchQueueForVerifier
with the dispatch queue it will be tied to. This will cause ThreadRestrictionVerifier
to ensure that all operations are performed on the given dispatch queue.
Reviewed by Anders Carlsson.
* wtf/RefCounted.h:
(WTF::RefCountedBase::setDispatchQueueForVerifier):
* wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::~ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::setShared):
(WTF::ThreadRestrictionVerifier::isSafeToUse):
2011-08-05 Oliver Hunt <oliver@apple.com>
Inline allocation of function objects
https://bugs.webkit.org/show_bug.cgi?id=65779
Reviewed by Gavin Barraclough.
Inline allocation and initilisation of function objects
in generated code. This ended up being a 60-70% improvement
in function allocation performance. This improvement shows
up as a ~2% improvement in 32bit sunspider and V8, but is a
wash on 64-bit.
We currently don't inline the allocation of named function
expressions, as that requires being able to gc allocate a
variable object.
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::emitStoreCell):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):
* jit/JITOpcodes32_64.cpp:
Removed duplicate implementation of op_new_func and op_new_func_exp
* runtime/JSFunction.h:
(JSC::JSFunction::offsetOfScopeChain):
(JSC::JSFunction::offsetOfExecutable):
2011-08-04 David Levin <levin@chromium.org>
CStringBuffer should have thread safety checks turned on.
https://bugs.webkit.org/show_bug.cgi?id=58093
Reviewed by Dmitry Titov.
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Removed the ifdef that
turned this off for Chromium.
2011-08-04 Mark Rowe <mrowe@apple.com>
Future-proof Xcode configuration settings.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* Configurations/Version.xcconfig:
2011-08-04 Mark Hahnenberg <mhahnenberg@apple.com>
Interpreter can potentially GC in the middle of initializing a structure chain
https://bugs.webkit.org/show_bug.cgi?id=65638
Reviewed by Oliver Hunt.
Moved the allocation of a prototype StructureChain before the initialization of
the structure chain within the interpreter that was causing intermittent GC crashes.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
* wtf/Platform.h:
2011-08-04 Filip Pizlo <fpizlo@apple.com>
Eval handling attempts literal parsing even when the eval
string is in the cache
https://bugs.webkit.org/show_bug.cgi?id=65675
Reviewed by Oliver Hunt.
This is a 25% speed-up on date-format-tofte and a 1.5% speed-up overall
in SunSpider. It's neutral on V8.
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
2011-08-03 Mark Rowe <mrowe@apple.com>
Bring some order to FeatureDefines.xcconfig to make it easier to follow.
Reviewed by Sam Weinig.
* Configurations/FeatureDefines.xcconfig:
2011-08-03 Mark Rowe <mrowe@apple.com>
Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
Reviewed by Dave Kilzer.
* Configurations/FeatureDefines.xcconfig:
2011-08-03 Filip Pizlo <fpizlo@apple.com>
JSC GC heap size improvement breaks build on some platforms due to
unused parameter
https://bugs.webkit.org/show_bug.cgi?id=65641
Reviewed by Darin Adler.
Fix build on non-x86 platforms, by ensuring that the relevant
parameter always appears to be used even when it isn't.
* heap/Heap.cpp:
2011-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Reorganize pkg-config files
https://bugs.webkit.org/show_bug.cgi?id=65548
Reviewed by Martin Robinson.
* GNUmakefile.am:
* javascriptcoregtk.pc.in: Renamed from Source/WebKit/gtk/javascriptcoregtk.pc.in.
2011-08-01 David Levin <levin@chromium.org>
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639
Reviewed by Dmitry Titov.
* GNUmakefile.list.am: Added new files to the build.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider): Ditto.
* wtf/CMakeLists.txt: Added new files to the build.
* wtf/ThreadRestrictionVerifier.h: Added.
Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):
* wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium (bug 58093).
2011-08-02 Filip Pizlo <fpizlo@apple.com>
JSC GC may not be able to reuse partially-free blocks after a
full collection
https://bugs.webkit.org/show_bug.cgi?id=65585
Reviewed by Darin Adler.
This fixes the linked list management bug. This fix is performance
neutral on SunSpider.
* heap/NewSpace.cpp:
(JSC::NewSpace::removeBlock):
2011-07-30 Oliver Hunt <oliver@apple.com>
Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422
Reviewed by Gavin Barraclough.
Remove hash lookups used to write name property and transition
function structure by caching the resultant structure and property
offset in JSGlobalObject. This doesn't impact performance, but
we can use this change to make other improvements later.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::jsName):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::namedFunctionStructure):
(JSC::JSGlobalObject::functionNameOffset):
2011-08-02 Filip Pizlo <fpizlo@apple.com>
JSC GC uses dummy cells to avoid having to remember which cells
it has already destroyed
https://bugs.webkit.org/show_bug.cgi?id=65556
Reviewed by Oliver Hunt.
This gets rid of dummy cells, and ensures that it's not necessary
to invoke a destructor on cells that have already been swept. In
the common case, a block knows that either all of its free cells
still need to have destructors called, or none of them do, which
minimizes the amount of branching that needs to happen per cell
when performing a sweep.
This is performance neutral on SunSpider and V8. It is meant as
a stepping stone to simplify the implementation of more
sophisticated sweeping algorithms.
* heap/Heap.cpp:
(JSC::CountFunctor::ClearMarks::operator()):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedReset):
(JSC::MarkedBlock::reset):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::produceFreeList):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::FreeCell::setNoObject):
(JSC::MarkedBlock::setDestructorState):
(JSC::MarkedBlock::destructorState):
(JSC::MarkedBlock::notifyMayHaveFreshFreeCells):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
* runtime/JSGlobalData.h:
* runtime/Structure.h:
2011-08-01 Michael Saboff <msaboff@apple.com>
Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
https://bugs.webkit.org/show_bug.cgi?id=65502
Reviewed by Anders Carlsson.
With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
added an assert to the return code of madvise to catch any regressions.
* wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease):
2011-08-02 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-08-02 Anders Carlsson <andersca@apple.com>
Fix a Windows build error.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-08-02 Filip Pizlo <fpizlo@apple.com>
JSC GC is far too conservative about growing the heap size, particularly
on desktop platforms
https://bugs.webkit.org/show_bug.cgi?id=65438
Reviewed by Oliver Hunt.
The minimum heap size is now 16MB instead of 512KB, provided all of the
following are true:
a) ENABLE(LARGE_HEAP) is set, which currently only happens on
x86 targets, but could reasonably happen on any platform that is
known to have a decent amount of RAM.
b) JSGlobalData is initialized with HeapSize = LargeHeap, which
currently only happens when it's the JSDOMWindowBase in WebCore or
in the jsc command-line tool.
This is a 4.1% speed-up on SunSpider.
* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
* heap/Heap.h:
* jsc.cpp:
(main):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
* wtf/Platform.h:
2011-08-02 Filip Pizlo <fpizlo@apple.com>
JSC does a GC even when the heap still has free pages
https://bugs.webkit.org/show_bug.cgi?id=65445
Reviewed by Oliver Hunt.
If the high watermark is not reached, then we allocate new blocks as
before. If the current watermark does reach (or exceed) the high
watermark, then we check if there is a block on the free block pool.
If there is, we simply allocation from it. If there isn't, we
invoke a collectin as before. This effectively couples the elastic
scavenging to the collector's decision function. That is, if an
application rapidly varies its heap usage (sometimes using more and
sometimes less) then the collector will not thrash as it used to.
But if heap usage drops and stays low then the scavenger thread and
the GC will eventually reach a kind of consensus: the GC will set
the watermark low because of low heap usage, and the scavenger thread
will steadily eliminate pages from the free page pool, until the size
of the free pool is below the high watermark.
On command-line, this is neutral on SunSpider and Kraken and a 3% win
on V8. In browser, this is a 1% win on V8 and neutral on the other
two.
* heap/Heap.cpp:
(JSC::Heap::allocateSlowCase):
(JSC::Heap::allocateBlock):
* heap/Heap.h:
2011-08-02 Jeff Miller <jeffm@apple.com>
Move WTF_USE_AVFOUNDATION from JavaScriptCore/wtf/platform.h to WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=65552
Since this is a WebCore feature, there's no need to define it in JavaScriptCore/wtf/platform.h.
Reviewed by Adam Roben.
* wtf/Platform.h: Removed WTF_USE_AVFOUNDATION.
2011-08-01 Jean-luc Brouillet <jeanluc@chromium.org>
Removing old source files in gyp files that slow build
https://bugs.webkit.org/show_bug.cgi?id=65503
Reviewed by Adam Barth.
A number of stale files are listed in the gyp files. These slow the
build on Visual Studio 2010. Removing them.
* JavaScriptCore.gypi:
2011-07-14 David Levin <levin@chromium.org>
currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577
Reviewed by Darin Adler and Dmitry Titov.
The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Acquire the pthread key here.
2011-08-01 Filip Pizlo <fpizlo@apple.com>
DFG JIT sometimes creates speculation check data structures that have
invalid information about the format of a register
https://bugs.webkit.org/show_bug.cgi?id=65490
Reviewed by Gavin Barraclough.
The code now makes sure to (1) always have correct and up-to-date
information about register format at the time that a speculation
check is emitted, (2) assert that speculation data is correct
inside the speculation check implementation, and (3) avoid creating
speculation data altogether if compilation has already failed, since
at that point the format data is almost guaranteed to be bogus.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
2011-08-01 Filip Pizlo <fpizlo@apple.com>
REGRESSION(r92092): Build fails on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=65458
Reviewed by Oliver Hunt.
The build was broken because some compilers were smart enough to see
an array index out of bounds due to the decision fuction for when to
go from precise size classes to imprecise size classes being broken:
it would assume that sizes in the range 97..128 belonged to a precise
size class when in fact they belonged to an imprecise one.
In fact, the code would have run correctly, by way of a fluke, because
though the 4th precise size class (for 97..128) didn't exist, the next
array over from m_preciseSizeClasses was m_impreciseSizeClasses, and
its first entry would have been a size class that is appropriate for
allocations in the range 97..128. However, this relies on specific
ordering of fields in NewSpace, so it's still a bug.
This fixes the bug by ensuring that allocations larger than 96 use
the imprecise size classes.
* heap/NewSpace.h:
(JSC::NewSpace::sizeClassFor):
2011-07-31 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Unreviewed - rolling out r91290.
Looks like the wild wild web isn't ready for this yet.
This change broke http://slides.html5rocks.com/#landing-slide.
Interestingly, this might only be due to our lack of bind support -
it looks like this site is calling Array.prototype.slice as a part
of its bind implementation.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
2011-07-31 Filip Pizlo <fpizlo@apple.com>
JSC GC lays out size classes under wrong assumptions about expected
object size.
https://bugs.webkit.org/show_bug.cgi?id=65437
Reviewed by Oliver Hunt.
Changed the atom size - which is both the smallest allocation size and
the smallest possible stepping unit for size class spacing - from
8 bytes to 4 pointer-size words. This is a 1% win on SunSpider.
* heap/MarkedBlock.h:
2011-07-31 Filip Pizlo <fpizlo@apple.com>
DFG non-speculative JIT does not optimize PutByVal
https://bugs.webkit.org/show_bug.cgi?id=65424
Reviewed by Gavin Barraclough.
Added code to emit PutByVal inline fast path.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
2011-07-31 Filip Pizlo <fpizlo@apple.com>
The JSC garbage collector returns memory to the operating system too
eagerly.
https://bugs.webkit.org/show_bug.cgi?id=65382
Reviewed by Oliver Hunt.
This introduces a memory reuse model similar to the one in FastMalloc.
A periodic scavenger thread runs in the background and returns half the
free memory to the OS on each timer fire. New block allocations first
attempt to get the memory from the collector's internal pool, reverting
to OS allocation only when this pool is empty.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::waitForRelativeTimeWhileHoldingLock):
(JSC::Heap::waitForRelativeTime):
(JSC::Heap::blockFreeingThreadStartFunc):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):
* heap/Heap.h:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::reset):
* heap/MarkedBlock.h:
* wtf/Platform.h:
2011-07-30 Filip Pizlo <fpizlo@apple.com>
DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421
Reviewed by Oliver Hunt.
Restructured the offending loops (for gprs and fprs). It's once again
possible to use spreadsheets on docs.google.com.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
2011-07-30 Patrick Gansterer <paroga@webkit.org>
Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081
Reviewed by Darin Adler.
Add missing and remove unneeded include statements for MainThread.
* wtf/CryptographicallyRandomNumber.cpp:
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
* wtf/text/StringStatics.cpp:
2011-07-30 Oliver Hunt <oliver@apple.com>
Reduce the size of JSGlobalObject slightly
https://bugs.webkit.org/show_bug.cgi?id=65417
Reviewed by Dan Bernstein.
Push a few members that either aren't commonly used,
or aren't frequently accessed into a separate struct.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::WeakMapsFinalizer::finalize):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::setProfileGroup):
(JSC::JSGlobalObject::profileGroup):
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):
2011-07-30 Balazs Kelemen <kbalazs@webkit.org>
MessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=65263
Reviewed by Dmitry Titov.
* wtf/Deque.h:
(WTF::::operator): Don't check the validity of an iterator
that will be reassigned right now.
* wtf/MessageQueue.h:
(WTF::::removeIf): Revert r51198 as I beleave this is the better
solution for the problem that was solved by that.
2011-07-29 Filip Pizlo <fpizlo@apple.com>
JSC GC zombie support no longer works, and is likely no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=65404
Reviewed by Darin Adler.
This removes zombies, because they no longer work, are not tested, are
probably not needed, and are getting in the way of GC optimization
work.
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Handle.h:
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::isValidWeakNode):
* heap/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::collect):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::clearMarks):
* interpreter/Register.h:
(JSC::Register::Register):
(JSC::Register::operator=):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):
* runtime/JSCell.cpp:
(JSC::isZombie):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
* runtime/JSGlobalData.h:
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::JSValue):
* runtime/JSZombie.cpp: Removed.
* runtime/JSZombie.h: Removed.
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
* wtf/Platform.h:
2011-07-29 Filip Pizlo <fpizlo@apple.com>
DFG JIT verbose mode provides no details about predictions
https://bugs.webkit.org/show_bug.cgi?id=65389
Reviewed by Darin Adler.
Added a print-out of the predictions to the IR dump, with names as follows:
"p-bottom" = the parser made no predictions
"p-int32" = the parser predicted int32
... (same for array, cell, double, number)
"p-top" = the parser made conflicting predictions which will be ignored.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::predictionToString):
2011-07-29 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not have any way of undoing double speculation.
https://bugs.webkit.org/show_bug.cgi?id=65334
Reviewed by Gavin Barraclough.
This adds code to do a branchConvertDoubleToInt on specualtion failure.
This is performance-neutral on most benchmarks but does result in
a slight improvement in Kraken.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
2011-07-29 Filip Pizlo <fpizlo@apple.com>
Crash when opening docs.google.com
https://bugs.webkit.org/show_bug.cgi?id=65327
Reviewed by Gavin Barraclough.
The speculative JIT was only checking whether a value is an array when
we had already checked that it was, rather then when we hadn't.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-28 Oliver Hunt <oliver@apple.com>
*_list instructions are only used in one place, where the code is wrong.
https://bugs.webkit.org/show_bug.cgi?id=65348
Reviewed by Darin Adler.
Simply remove the instructions and all users. Speeds up the interpreter
slightly due to code motion, but otherwise has no effect (because none
of the _list instructions are ever used).
* bytecode/CodeBlock.cpp:
(JSC::isPropertyAccess):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitStructures):
* bytecode/Instruction.h:
* bytecode/Opcode.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
2011-07-28 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt
Reviewed by Oliver Hunt.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
- This change may an existing optimization redundant,
cleanup from Darin's comments, plus fix existing bugs.
2011-07-28 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt
Reviewed by Oliver Hunt.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
- parseInt applied to small positive numbers = floor.
2011-07-28 Dan Bernstein <mitz@apple.com>
Build fix.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
2011-07-28 Kent Tamura <tkent@chromium.org>
Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
https://bugs.webkit.org/show_bug.cgi?id=65300
Reviewed by Darin Adler.
r91837 had performance regression of StringImpl::stripWhiteSpace()
and simplifyWhiteSpace(). This changes the code so that compilers
generates code equivalent to r91836 or piror.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripMatchedCharacters):
A template member function for stripWhiteSpace(). This function takes a functor.
(WTF::UCharPredicate):
A functor for generic predicate for single UChar argument.
(WTF::SpaceOrNewlinePredicate):
A special functor for isSpaceOrNewline().
(WTF::StringImpl::stripWhiteSpace):
Use stripmatchedCharacters().
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
A template member function for simplifyWhiteSpace().
(WTF::StringImpl::simplifyWhiteSpace):
Use simplifyMatchedCharactersToSpace().
* wtf/text/StringImpl.h:
2011-07-27 Dmitry Lomov <dslomov@google.com>
[chromium] Turn on WTF_MULTIPLE_THREADS.
https://bugs.webkit.org/show_bug.cgi?id=61017
The patch turns on WTF_MULTIPLE_THREADS in chromium and
pushes some relevant initializations from JSC::initializeThreading
to WTF::initializeThreading.
Reviewed by David Levin.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/FastMalloc.cpp:
(WTF::isForbidden):
(WTF::fastMallocForbid):
(WTF::fastMallocAllow):
* wtf/Platform.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading):
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading):
2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
Remove operator new from JSCell
https://bugs.webkit.org/show_bug.cgi?id=64999
Reviewed by Oliver Hunt.
Removed the implementation of operator new in JSCell, so any further uses
will not successfully link. Also removed any remaining uses of operator new.
* API/JSContextRef.cpp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
2011-07-27 Filip Pizlo <fpizlo@apple.com>
DFG graph has no notion of double prediction.
https://bugs.webkit.org/show_bug.cgi?id=65234
Reviewed by Gavin Barraclough.
Added the notion of PredictDouble, and PredictNumber, which is the least
upper bound of PredictInt32 and PredictDouble. Least upper bound is
defined as the bitwise-or of two predictions. Bottom is defined as 0,
and Top is defined as all bits being set. Added the ability to explicitly
distinguish between a node having had a prediction associated with it,
and that prediction still being valid (i.e. no conflicting predictions
have also been added). Used this to guard the speculative JIT from
speculating Int32 in cases where the graph knows that the value is
double, which currently only happens for GetLocal nodes on arguments
which were double at compile-time.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
2011-07-27 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65294
DFG JIT - may speculate based on wrong arguments.
Reviewed by Oliver Hunt
In the case of a DFG compiled function calling to and compiling a second function that
also compiles through the DFG JIT (i.e. compilation triggered with DFGOperations.cpp),
we call compileFor passing the caller functions exec state, rather than the callee's.
This may lead to mis-optimization, since the DFG compiler will example the exec state's
arguments on the assumption that these will be passed to the callee - it is wanting the
callee exec state, not the caller's exec state.
Fixing this for all cases of compilation is tricksy, due to the way the numeric sort
function is compiled, & the structure of the calls in the Interpreter::execute methods.
Only fix for compilation from the JIT, in other calls don't speculate based on arguments
for now.
* dfg/DFGOperations.cpp:
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::FunctionExecutable::compileForCallInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileFor):
2011-07-27 Oliver Hunt <oliver@apple.com>
Handle callback oriented JSONP
https://bugs.webkit.org/show_bug.cgi?id=65271
Reviewed by Gavin Barraclough.
Handle the callback oriented versions of JSONP. The Literal parser
now handles <Identifier> (. <Identifier>)* (jsonData).
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lex):
* runtime/LiteralParser.h:
2011-07-27 Stephanie Lewis <slewis@apple.com>
Revert http://trac.webkit.org/changeset/90415.
Caused a 5% sunspider regression in-browser.
Unreviewed rollout.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
2011-07-27 Shinya Kawanaka <shinyak@google.com>
Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746
Reviewed by Kent Tamura.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripWhiteSpace):
Added an interface to take IsWhiteSpaceFunctionPtr.
(WTF::StringImpl::simplifyWhiteSpace): ditto.
* wtf/text/StringImpl.h:
* wtf/text/WTFString.cpp:
(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.
* wtf/text/WTFString.h:
2011-07-27 Filip Pizlo <fpizlo@apple.com>
DFG JIT speculation failure code performs incorrect conversions in
the case where two registers need to be swapped.
https://bugs.webkit.org/show_bug.cgi?id=65233
Reviewed by Gavin Barraclough.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::GeneralizedRegister::swapWith):
2011-07-26 Mark Hahnenberg <mhahnenberg@apple.com>
reduce and reduceRight bind callback's this to null rather than undefined
https://bugs.webkit.org/show_bug.cgi?id=62264
Reviewed by Oliver Hunt.
Fixed Array.prototype.reduce and Array.prototype.reduceRight so that they behave correctly
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
2011-07-26 Filip Pizlo <fpizlo@apple.com>
JSC command-line tool does not come with any facility for
measuring time precisely.
https://bugs.webkit.org/show_bug.cgi?id=65223
Reviewed by Gavin Barraclough.
Exposed WTF::currentTime() as currentTimePrecise().
* jsc.cpp:
(GlobalObject::GlobalObject):
(functionPreciseTime):
2011-07-26 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT never emits inline double comparisons, even when it
would be obvious more efficient to do so.
https://bugs.webkit.org/show_bug.cgi?id=65212
Reviewed by Gavin Barraclough.
This handles the obvious case of inlining double comparisons: it only addresses
the speculative JIT, and only for fused compare/branch sequences. But it does
handle the case where both operands are double (and there is no slow path),
or where one operand is double and the other is unknown type (in which case it
attempts to unbox the double, otherwise taking slow path). This is an 0.8%
speed-up on SunSpider.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
2011-07-26 Filip Pizlo <fpizlo@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64969
DFG JIT generates inefficient code for speculation failures.
Reviewed by Gavin Barraclough.
This implements a speculation failure strategy where (1) values spilled on
non-speculative but not spilled on speculative are spilled, (2) values that
are in registers on both paths are rearranged without ever touching memory,
and (3) values spilled on speculative but not spilled on non-speculative are
filled.
The register shuffling is the most interesting part of this patch. It
constructs a permutation graph for registers. Each node represents a
register, and each directed edge corresponds to the register's value having
to be moved to a different register as part of the shuffling. This is a
directed graph where each node may only have 0 or 1 incoming edges, and
0 or 1 outgoing edges. The algorithm then first finds maximal non-cyclic
subgraphs where all nodes in the subgraph are reachable from a start node.
Such subgraphs always resemble linked lists, and correspond to simply
moving the value in the second-to-last register into the last register, and
then moving the value in the third-to-last register into the second-to-last
register, and so on. Once these subgraphs are taken care of, the remaining
subgraphs are cycles, and are handled using either (a) conversion or no-op
if the cycle involves one node, (b) swap if it involves two nodes, or (c)
a cyclic shuffle involving a scratch register if there are three or more
nodes.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::needDataFormatConversion):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::GeneralizedRegister::GeneralizedRegister):
(JSC::DFG::GeneralizedRegister::createGPR):
(JSC::DFG::GeneralizedRegister::createFPR):
(JSC::DFG::GeneralizedRegister::dump):
(JSC::DFG::GeneralizedRegister::findInSpeculationCheck):
(JSC::DFG::GeneralizedRegister::findInEntryLocation):
(JSC::DFG::GeneralizedRegister::previousDataFormat):
(JSC::DFG::GeneralizedRegister::nextDataFormat):
(JSC::DFG::GeneralizedRegister::convert):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::ShuffledRegister):
(JSC::DFG::ShuffledRegister::isEndOfNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::ShuffledRegister::lookup):
(JSC::DFG::lookupForRegister):
(JSC::DFG::NodeToRegisterMap::Tuple::Tuple):
(JSC::DFG::NodeToRegisterMap::NodeToRegisterMap):
(JSC::DFG::NodeToRegisterMap::set):
(JSC::DFG::NodeToRegisterMap::end):
(JSC::DFG::NodeToRegisterMap::find):
(JSC::DFG::NodeToRegisterMap::clear):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::linkSpeculationChecks):
* dfg/DFGJITCompiler.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculationCheck::SpeculationCheck):
* dfg/DFGSpeculativeJIT.h:
2011-07-26 Oliver Hunt <oliver@apple.com>
Buffer overflow creating error messages for JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=65211
Reviewed by Darin Adler.
Parse string length to the UString constructor.
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::parse):
2011-07-26 Mark Hahnenberg <mhahnenberg@apple.com>
Refactor automatically generated JS DOM bindings to replace operator new with static create methods
https://bugs.webkit.org/show_bug.cgi?id=64732
Reviewed by Oliver Hunt.
Replacing the public constructors in the automatically generated JS DOM bindings with static
create methods. JSByteArray is used by several of these bindings in WebCore.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::create):
* runtime/JSByteArray.h:
2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Qt/Linux.
On platforms with no glib and gstreamer we should not build javascriptcore
with the Glib support. This is related to http://trac.webkit.org/changeset/91752.
* wtf/wtf.pri:
2011-07-26 Juan C. Montemayor <jmont@apple.com>
JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339
Added error messages to the JSON Parser.
Reviewed by Oliver Hunt.
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):
2011-07-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r91746.
http://trac.webkit.org/changeset/91746
https://bugs.webkit.org/show_bug.cgi?id=65180
It broke SL build (Requested by Ossy on #webkit).
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripWhiteSpace):
(WTF::StringImpl::simplifyWhiteSpace):
* wtf/text/StringImpl.h:
* wtf/text/WTFString.cpp:
* wtf/text/WTFString.h:
2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
https://bugs.webkit.org/show_bug.cgi?id=63472
Enable the bits needed for GStreamer only when QtMultimedia is not used.
* wtf/wtf.pri:
2011-07-26 Shinya Kawanaka <shinyak@google.com>
Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746
Reviewed by Kent Tamura.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripWhiteSpace):
Added an interface to take IsWhiteSpaceFunctionPtr.
(WTF::StringImpl::simplifyWhiteSpace): ditto.
* wtf/text/StringImpl.h:
* wtf/text/WTFString.cpp:
(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.
* wtf/text/WTFString.h:
2011-07-25 Filip Pizlo <fpizlo@apple.com>
DFG non-speculative JIT emits inefficient code for arithmetic
involving two registers
https://bugs.webkit.org/show_bug.cgi?id=65160
Reviewed by Gavin Barraclough.
The non-speculative JIT now emits inline code for double arithmetic, but
still attempts integer arithmetic first. This is a speed-up on SunSpider
(albeit a small one), and a large speed-up on Kraken.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
2011-07-25 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Build break with --debug after r89153.
https://bugs.webkit.org/show_bug.cgi?id=65150
Unreviewed build fix.
* wtf/CMakeListsEfl.txt: Add missing libraries.
2011-07-25 Filip Pizlo <fpizlo@apple.com>
DFG non-speculative JIT emits obviously inefficient code for arithmetic
where one operand is a constant.
https://bugs.webkit.org/show_bug.cgi?id=65146
Reviewed by Gavin Barraclough.
Changed the code to emit double arithmetic inline.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
2011-07-25 Filip Pizlo <fpizlo@apple.com>
DFG JIT bytecode parser misuses pointers into objects allocated as part of a
WTF::Vector.
https://bugs.webkit.org/show_bug.cgi?id=65128
Reviewed by Gavin Barraclough.
The bytecode parser code seems to be right to have a DFGNode& phiNode reference
into the graph, since this makes the code greatly more readable. This patch
thus makes the minimal change necessary to make the code right: it uses a
pointer (to disambiguate between reloading the pointer and performing a
copy from one location of the vector to another) and reloads it after the
calls to addToGraph().
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
2011-07-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r91686.
http://trac.webkit.org/changeset/91686
https://bugs.webkit.org/show_bug.cgi?id=65144
1.5% regression in JSC (Requested by jmontemayor on #webkit).
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
2011-07-25 Jon Lee <jonlee@apple.com>
Assertion called in ExecutableBase::generatedJITCodeForCall() when JIT is not available
https://bugs.webkit.org/show_bug.cgi?id=65132
<rdar://problem/9836297>
Reviewed by Oliver Hunt.
Make sure the JIT is available to use before running the following calls:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkCalls): Added check, return early if JIT is not available.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addMethodCallLinkInfos): Added assertion.
2011-07-25 Juan C. Montemayor <jmont@apple.com>
JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339
Added error messages to the JSON Parser.
Reviewed by Oliver Hunt.
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):
2011-07-25 Filip Pizlo <fpizlo@apple.com>
X86-64 assembler emits three instructions instead of two for certain
loads and stores.
https://bugs.webkit.org/show_bug.cgi?id=65095
Reviewed by Gavin Barraclough.
Simply made these four methods in the assembler use the scratch register,
which they were previously avoiding. It still optimizes for the case where
an absolute address memory accesses is using EAX. This results in a slight
performance improvement.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::load32):
(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::storePtr):
2011-07-25 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
https://bugs.webkit.org/show_bug.cgi?id=64354
Use ecore_time_unix_get which returns unix time as double type for currentTime
and ecore_time_get which uses monotonic clock for monotonicallyIncreasingTime.
Reviewed by Kent Tamura.
* wtf/CurrentTime.cpp:
(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):
2011-07-22 Sommer Panage <panage@apple.com>
Reviewed by Oliver Hunt.
export JSContextCreateBacktrace as SPI in JSContextRefPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=64981
UIAutomation for iOS would like to support a Javascript backtrace in our error logs.
Currently, the C API does not provide the tools to do this. However, the private API
does expose the necessary functionality to get a backtrace
(via Interpreter::retrieveLastCaller). We recognize this information may result in
failure in the cases of programs run by 'eval', stack frames beneath host function
call frames, and in programs run from other programs. Thus, we propose exporting our
JSContextCreateBacktrace in JSContextRefPrivate.h. This will provide us with the tools
we need while not advertising an API that isn't really ready for full use.
* API/JSContextRef.cpp:
* API/JSContextRefPrivate.h:
* JavaScriptCore.exp:
2011-07-22 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65051
DFG JIT - Enable by default for mac platform on x86-64.
Rubber Stamped by Geoff Garen.
This is now a performance progression.
* wtf/Platform.h:
- Removed definition of ENABLE_DFG_JIT_RESTRICTIONS.
2011-07-22 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65047
DFG JIT - Add support for op_resolve/op_resolve_base
Reviewed by Sam Weinig.
These are necessary for any significant eval code coverage
(and as such increase LayoutTest coverage).
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordResolve):
- Conservatively blow aliasing optimizations for now.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- Add support for op_resolve/op_resolve_base.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
- Add call with exec, identifer aguments.
* dfg/DFGNode.h:
- Add new node types.
(JSC::DFG::Node::hasIdentifier):
- Resolve nodes have identifiers, too!
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- Add generation for new Nodes.
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
- Added new operations.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Add generation for new Nodes.
2011-07-22 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65036
Messing with the register allocation within flow control = badness.
Reviewed by Sam Weinig.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- Fix register allocation.
2011-07-22 Mark Hahnenberg <mhahnenberg@apple.com>
Date.prototype.toISOString doesn't handle negative years or years > 9999 correctly.
https://bugs.webkit.org/show_bug.cgi?id=63986
Reviewed by Geoffrey Garen.
Changed the implementation of Date.prototype.toISOString() to use the extended year
format (+/-yyyyyy) for years outside of [0,9999] to be in compliance with ES 15.9.1.15.1.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
2011-07-21 Gavin Barraclough <barraclough@apple.com>
Windows build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-07-21 Ryosuke Niwa <rniwa@webkit.org>
Build fix after r91555.
* JavaScriptCore.exp:
2011-07-21 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=19271
eliminate PIC branches by changing NaN handling in JSValue::toNumber
Reviewed by Sam Weinig.
Moving the non-numeric cases out of line seems to be a consistent
win on SunSpider for me, to the order of about 0.5%.
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toNumber):
- Changed to only handle values that are already numbers, moce non-numeric cases out of line.
* runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
- Added toNumberSlowCase, handling non-numeric cases.
* runtime/JSValue.h:
- Add declaration of toNumberSlowCase.
2011-07-21 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64875
Use of `yield` keyword is broken
Reviewed by Sam Weinig.
* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
- The bug here is that a successful match of a RESERVED_IF_STRICT token from
parseKeyword is being nullified back to IDENT. The problem is that in the
case of IDENT matches parseKeyword should not move the lexer's input
position, but in the case of RESERVED_IF_STRICT it has done so.
2011-07-21 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64900
Function.prototype.apply should accept an array-like object as its second argument
Reviewed by Sam Weinig.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncApply):
- Remove the type error if object is not an array.
2011-07-21 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64964
DFG JIT - Enable support for eval code
Reviewed by Sam Weinig.
This is basically the same as program code, to the JIT!
* bytecode/Opcode.cpp:
* bytecode/Opcode.h:
- Enable opcodeNames in !NDEBUG builds.
* dfg/DFGOperations.cpp:
- Fix a bug exposed by eval support, throw correct type error for new.
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
- Enable DFG JIT for eval code.
2011-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r91380.
http://trac.webkit.org/changeset/91380
https://bugs.webkit.org/show_bug.cgi?id=64924
Caused assertion failures in Chromium's IndexedDB tests
(Requested by rniwa on #webkit).
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
2011-07-20 Filip Pizlo <fpizlo@apple.com>
DFG non-speculative JIT does not use() the aliased GetByVal,
resulting in bloated use counts.
https://bugs.webkit.org/show_bug.cgi?id=64911
Reviewed by Gavin Barraclough.
Inserted a call to use() for the aliased GetByVal.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
2011-07-20 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64909
DFG JIT - Missing ToInt32 conversions for double constants.
Reviewed by Sam Weinig.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
- We cannot trivially omit ToInt32 conversions on double constants.
2011-07-20 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT sometimes claims to use compare operands twice, leading to
use count corruption.
https://bugs.webkit.org/show_bug.cgi?id=64903
Reviewed by Gavin Barraclough.
Move the calls to use() in SpeculativeJIT::compare() so that they only happen
if the JITCodeGenerator's helper method (which also calls use()) is not called.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
2011-07-20 Oliver Hunt <oliver@apple.com>
Don't throw away code when JSGarbageCollect API is called
https://bugs.webkit.org/show_bug.cgi?id=64894
Reviewed by Sam Weinig.
Just call collectAllGarbage. That will clean up all unneeded
code without causing any pathological recompilation problems.
* API/JSBase.cpp:
(JSGarbageCollect):
2011-07-20 Oliver Hunt <oliver@apple.com>
Codeblock doesn't visit cached structures in global resolve instructions
https://bugs.webkit.org/show_bug.cgi?id=64889
Reviewed by Sam Weinig.
Visit the global resolve instructions. This fixes a couple
of random crashes seen in the jquery tests when using the
interpreter.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
2011-07-20 James Robinson <jamesr@chromium.org>
Revert worker and WebKit2 runloops to use currentTime() for scheduling instead of the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64841
Reviewed by Mark Rowe.
http://trac.webkit.org/changeset/91206 converted most of WebKit's deferred work scheduling to using the
monotonic clock instead of WTF::currentTime(). This broke many plugin tests on WebKit2 for reasons that are
unclear. This reverts everything except for WebCore::ThreadTimers back to the previous behavior.
* wtf/ThreadingPthreads.cpp:
(WTF::ThreadCondition::timedWait):
* wtf/ThreadingWin.cpp:
(WTF::absoluteTimeToWaitTimeoutInterval):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::ThreadCondition::timedWait):
* wtf/qt/ThreadingQt.cpp:
(WTF::ThreadCondition::timedWait):
2011-07-14 David Levin <levin@chromium.org>
currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577
Reviewed by Darin Adler and Dmitry Titov.
The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Acquire the pthread key here.
2011-07-20 Mark Rowe <mrowe@apple.com>
Fix the 32-bit build.
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
2011-07-19 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.
Reviewed by Darin Adler.
Fix ES5.1 correctness issues identified by Mads Ager.
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- ES5.1 expects toString of undefined/null to produce "[object Undefined]"/"[object Null]".
2011-07-19 Mark Hahnenberg <mhahnenberg@apple.com>
[JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918
Reviewed by Darin Adler.
When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):
2011-07-19 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- These methods should throw if this value is undefined.
2011-07-19 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64677
Fix bugs in String.prototype this handling.
Reviewed by Oliver Hunt.
undefined/null this values should throw TypeErrors, not convert to
the global object, and primitive values should not be converted via
object types.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString):
- These methods should throw if this value is undefined,
convert ToString directly, not via ToObject.
2011-07-19 Filip Pizlo <fpizlo@apple.com>
DFG JIT sometimes emits spill code even when the respective values
are never needed.
https://bugs.webkit.org/show_bug.cgi?id=64774
Reviewed by Gavin Barraclough.
The main high-level change is that it is now easier to call use() on a
virtual register. JSValueOperand and its other-typed relatives now have
a handy use() method, and jsValueResult() and friends now make it easier to
pass UseChildrenCalledExplicitly.
The rest of this patch hoists the call to use() as high as possible for
all of those cases where either flushRegisters() or silentSpillAllRegisters()
may be called.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::use):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateCellOperand::use):
2011-07-19 Xan Lopez <xlopez@igalia.com>
ARMv7 backend broken, lacks 3 parameter rshift32 method
https://bugs.webkit.org/show_bug.cgi?id=64571
Reviewed by Zoltan Herczeg.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method.
2011-07-18 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not optimize strict equality as effectively as the old JIT does.
https://bugs.webkit.org/show_bug.cgi?id=64759
Reviewed by Gavin Barraclough.
This adds a more complete set of strict equality optimizations. If either
operand is known numeric, then the code reverts to the old style of optimizing
(first try integer comparison). Otherwise it uses the old JIT's trick of
first simultaneously checking if both operands are either numbers or cells;
if not then a fast path is taken.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-18 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64760
DFG JIT - Should be able to compile program code.
Reviewed by Geoff Garen.
Add support for op_end, hooks to compile program code in Executable.cpp.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- Add support for op_end
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
- Added, separate out steps of compileFunction.
(JSC::DFG::JITCompiler::compile):
- Added, compile program code.
(JSC::DFG::JITCompiler::compileFunction):
- Sections separated out to helper functions.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
- Added m_exceptionCheckCount.
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
- Renamed tryDFGCompile to tryDFGCompileFunction, added tryDFGCompile to compile program code.
2011-07-18 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.
Reviewed by Oliver Hunt.
undefined/null this values should throw TypeErrors, not convert to the global object,
also, to toLocaleString should be calling the ToObject & invoking the object's toString
function, even for values that are already strings.
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):
2011-07-18 Filip Pizlo <fpizlo@apple.com>
JSC GC lazy sweep does not inline the common cases of cell destruction.
https://bugs.webkit.org/show_bug.cgi?id=64745
Reviewed by Oliver Hunt.
This inlines the case of JSFinalObject destruction.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::lazySweep):
2011-07-18 Oliver Hunt <oliver@apple.com>
Interpreter build-fix
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2011-07-18 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not optimize equal-null comparisons and branches.
https://bugs.webkit.org/show_bug.cgi?id=64659
Reviewed by Gavin Barraclough.
Added a peephole-aware compare-to-null implementation to JITCodeGenerator,
which is used by both the speculative and non-speculative JIT. Through
the use of the new isNullConstant helper, the two JITs invoke the
nonSpecualtiveCompareNull() helper instead of their regular comparison
helpers when compiling CompareEq. Through the use of the new isKnownCell
helper, the compare-null code will skip the is-a-cell check if the
speculative JIT had been speculating cell.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isNullConstant):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-18 James Robinson <jamesr@chromium.org>
Timer scheduling should be based off the monotonic clock
https://bugs.webkit.org/show_bug.cgi?id=64544
Reviewed by Darin Adler.
Switches ThreadCondition::timedWait and related utility functions from currentTime() to
monotonicallyIncreasingTime().
Add WTF::monotonicallyIncreasingTime() to list of exported functions so it can be accessed from WebCore/WebKit.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/ThreadingPthreads.cpp:
(WTF::ThreadCondition::timedWait):
* wtf/ThreadingWin.cpp:
(WTF::absoluteTimeToWaitTimeoutInterval):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::ThreadCondition::timedWait):
* wtf/qt/ThreadingQt.cpp:
(WTF::ThreadCondition::timedWait):
2011-07-18 Filip Pizlo <fpizlo@apple.com>
JSC JIT does not inline GC allocation fast paths
https://bugs.webkit.org/show_bug.cgi?id=64582
Reviewed by Oliver Hunt.
This addresses inlining allocation for the easiest-to-allocate cases:
op_new_object and op_create_this. Inlining GC allocation fast paths
required three changes. First, the JSGlobalData now saves the vtable
pointer of JSFinalObject, since that's what op_new_object and
op_create_this allocate. Second, the Heap exposes a reference to
the appropriate SizeClass, so that the JIT may inline accesses
directly to the SizeClass for JSFinalObject allocations. And third,
the JIT is extended with code to emit inline fast paths for GC
allocation. A stub call is emitted in the case where the inline fast
path fails.
* heap/Heap.h:
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSFinalObject):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
* runtime/JSGlobalData.h:
* runtime/JSObject.h:
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfInheritorID):
2011-07-18 Mark Hahnenberg <mhahnenberg@apple.com>
Refactor JSC to replace JSCell::operator new with static create method
https://bugs.webkit.org/show_bug.cgi?id=64466
Reviewed by Oliver Hunt (oliver@apple.com) and Darin Adler (darin@apple.com).
First step in a longer refactoring process to remove the use of
operator new overloading in order to allocate GC objects and to replace
this method with static create methods for each individual type of heap-allocated
JS object. This particular patch only deals with replacing uses of
operator new within JSC proper. Future patches will remove it from the
parts that interface with the DOM. Due to the DOM's continued dependence
on it, operator new has not actually been removed from JSCell.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::create):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::create):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::operator new):
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::staticFunctionGetter):
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::createActivation):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(GlobalObject::create):
(GlobalObject::GlobalObject):
(functionRun):
(jscmain):
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::create):
* runtime/BooleanConstructor.cpp:
(JSC::constructBoolean):
(JSC::constructBooleanFromImmediateBoolean):
* runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::create):
* runtime/BooleanObject.h:
(JSC::BooleanObject::create):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::create):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateConstructor.h:
(JSC::DateConstructor::create):
* runtime/DateInstance.h:
(JSC::DateInstance::create):
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/Error.cpp:
(JSC::createError):
(JSC::createEvalError):
(JSC::createRangeError):
(JSC::createReferenceError):
(JSC::createSyntaxError):
(JSC::createTypeError):
(JSC::createURIError):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::createTypeErrorFunction):
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::create):
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::createInterruptedExecutionException):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
(JSC::createTerminatedExecutionException):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/Executable.h:
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::make):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::create):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
* runtime/GetterSetter.h:
(JSC::GetterSetter::create):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::create):
(JSC::jsAPIValueWrapper):
* runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSCell.h:
(JSC::JSCell::allocateCell):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::constructEmptyArray):
(JSC::constructArray):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::create):
* runtime/JSONObject.h:
(JSC::JSONObject::create):
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
* runtime/JSObject.h:
(JSC::JSFinalObject::create):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::create):
* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
(JSC::JSString::replaceCharacter):
(JSC::StringObject::create):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* runtime/JSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
* runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
* runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::create):
* runtime/NumberObject.cpp:
(JSC::constructNumber):
* runtime/NumberObject.h:
(JSC::NumberObject::create):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::create):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::create):
* runtime/Operations.h:
(JSC::jsString):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):
(JSC::RegExp::create):
* runtime/RegExp.h:
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::arrayOfMatches):
(JSC::constructRegExp):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::create):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::create):
(JSC::ScopeChainNode::push):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
* runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::create):
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::createStructure):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
2011-07-17 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Refactor scheduleDispatchFunctionsOnMainThread to fix crash.
https://bugs.webkit.org/show_bug.cgi?id=64337
Replace ecore_timer_add to Ecore_Pipe.
This is needed because ecore_timer should not be called in a child thread,
but in the main thread.
Reviewed by Antonio Gomes.
* wtf/efl/MainThreadEfl.cpp:
(WTF::pipeObject):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
2011-07-17 Filip Pizlo <fpizlo@apple.com>
DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline.
https://bugs.webkit.org/show_bug.cgi?id=64637
Reviewed by Gavin Barraclough.
* dfg/DFGOperations.cpp:
2011-07-16 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64657
Converted this value not preserved when accessed via direct eval.
Reviewed by Oliver Hunt.
Upon entry into a non-strict function, primitive this values should be boxed as Object types
(or substituted with the global object) - which is done by op_convert_this. However we only
do so where this is used lexically within the function (we omit the conversion op if not).
The problem comes if a direct eval (running within the function's scope) accesses the this
value.
We are safe in the case of a single eval, since the this object will be converted within
callEval, however the converted value is not preserved, and a new wrapper object is allocated
each time eval is invoked. This is inefficient and incorrect, since any changes to the wrapper
object will be lost between eval statements.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- If a function uses eval, we always need to convert this.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- Don't convert primitive values here - this is too late!
(JSC::Interpreter::privateExecute):
- Changed op_convert_this to call new isPrimitive method.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Changed op_convert_this to call new isPrimitive method.
* runtime/JSCell.h:
(JSC::JSCell::JSValue::isPrimitive):
- Added JSValue::isPrimitive.
* runtime/JSValue.h:
- Added JSValue::isPrimitive.
2011-07-16 Filip Pizlo <fpizlo@apple.com>
DFG JIT compare/branch code emits is-integer tests even when a value is
definitely not an integer.
https://bugs.webkit.org/show_bug.cgi?id=64654
Reviewed by Gavin Barraclough.
Added the isKnownNotInteger() method, which returns true if a node is
definitely not an integer and will always fail any is-integer test. Then
modified the compare and branch code to use this method; if it returns
true then is-int tests are omitted and the compiler always emits a slow
call.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
2011-07-16 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT has dead code for slow calls for branches.
https://bugs.webkit.org/show_bug.cgi?id=64653
Reviewed by Gavin Barraclough.
Removed SpeculativeJIT::compilePeepHoleCall.
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
2011-07-15 Mark Rowe <mrowe@apple.com>
Fix the build.
* dfg/DFGGraph.h:
2011-07-15 Gavin Barraclough <barraclough@apple.com>
NativeError.prototype objects have [[Class]] of "Object" but should be "Error"
https://bugs.webkit.org/show_bug.cgi?id=55346
Reviewed by Sam Weinig.
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
- Switch to putDirect since we're not the only ones tranitioning this Structure now.
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
- Switch base class to ErrorPrototype.
2011-07-15 Gavin Barraclough <barraclough@apple.com>
DFG JIT - Where arguments passed are integers, speculate this.
https://bugs.webkit.org/show_bug.cgi?id=64630
Reviewed by Sam Weinig.
Presently the DFG JIT is overly aggressively predicting double.
Use a bit of dynamic information, and curtail this a little.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- Check for integer arguments.
* dfg/DFGGraph.h:
- Function declaration.
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
(JSC::FunctionExecutable::compileForCallInternal):
- Add call to predictArgumentTypes.
2011-07-15 Filip Pizlo <fpizlo@apple.com>
DFG JIT is inconsistent about fusing branches and speculating
integer comparisons for branches.
https://bugs.webkit.org/show_bug.cgi?id=64573
Reviewed by Gavin Barraclough.
This patch moves some of NonSpeculativeJIT's functionality up into the
JITCodeGenerator superclass so that it can be used from both JITs. Now,
in cases where the speculative JIT doesn't want to speculate but still
wants to emit good code, it can reliably emit the same code sequence as
the non-speculative JIT. This patch also extends the non-speculative
JIT's compare optimizations to include compare/branch fusing, and
extends the speculative JIT's compare optimizations to cover StrictEqual.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::detectPeepHoleBranch):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
* wtf/Platform.h:
2011-07-14 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64250
Global strict mode function leaking global object as "this".
Reviewed by Oliver Hunt.
The root problem here is that we pass the wrong values into
calls, and then try to fix them up in the callee. Correct
behaviour per the spec is to pass in the value undefined,
as this unless either (1) the function call is based on an
explicit property access or (2) the base of the call comes
directly from a 'with'.
This change does away with the need for this conversion of
objects (non strict code should only box primitives), and
does away with all this conversion for strict functions.
This patch may have web compatibility ramifications, and may
require some advocacy.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- Removed op_convert_this_strict, added op_resolve_with_this.
* bytecode/Opcode.h:
- Removed op_convert_this_strict, added op_resolve_with_this.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitResolveWithThis):
- Removed op_convert_this_strict, added op_resolve_with_this.
* bytecompiler/BytecodeGenerator.h:
- Removed op_convert_this_strict, added op_resolve_with_this.
* bytecompiler/NodesCodegen.cpp:
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
- Removed op_convert_this_strict, added op_resolve_with_this.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Change NeedsThisConversion check to test for JSString's vptr
(objects no longer need conversion).
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveThisAndProperty):
- Based on resolveBaseAndProperty, but produce correct this value.
(JSC::Interpreter::privateExecute):
- Removed op_convert_this_strict, added op_resolve_with_this.
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- Removed op_convert_this_strict, added op_resolve_with_this.
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_with_this):
- Removed op_convert_this_strict, added op_resolve_with_this.
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
- Change NeedsThisConversion check to test for JSString's vptr
(objects no longer need conversion).
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_with_this):
- Removed op_convert_this_strict, added op_resolve_with_this.
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
- Change NeedsThisConversion check to test for JSString's vptr
(objects no longer need conversion).
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Removed op_convert_this_strict, added op_resolve_with_this.
* jit/JITStubs.h:
- Removed op_convert_this_strict, added op_resolve_with_this.
* runtime/JSActivation.h:
- removed NeedsThisConversion flag, added IsEnvironmentRecord.
* runtime/JSStaticScopeObject.h:
- removed NeedsThisConversion flag, added IsEnvironmentRecord.
* runtime/JSString.h:
(JSC::RopeBuilder::createStructure):
- removed NeedsThisConversion.
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
- removed NeedsThisConversion flag, added IsEnvironmentRecord.
* runtime/JSValue.h:
- removed NeedsThisConversion.
* runtime/JSVariableObject.h:
- Corrected StructureFlags inheritance.
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::createStructure):
- Added IsEnvironmentRecord to StructureFlags, addded createStructure.
* runtime/Structure.h:
- removed NeedsThisConversion.
* tests/mozilla/ecma/String/15.5.4.6-2.js:
(getTestCases):
- Removed invalid test case.
2011-07-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r91082, r91087, and r91089.
http://trac.webkit.org/changeset/91082
http://trac.webkit.org/changeset/91087
http://trac.webkit.org/changeset/91089
https://bugs.webkit.org/show_bug.cgi?id=64616
gtk tests are failing a lot after this change. (Requested by
dave_levin on #webkit).
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
2011-07-15 David Levin <levin@chromium.org>
Another attempted build fix.
* wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick
up the definition of PTHREAD_KEYS_MAX.
2011-07-15 David Levin <levin@chromium.org>
Chromium build fix.
* wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick
up the definition of PTHREAD_KEYS_MAX.
2011-07-14 David Levin <levin@chromium.org>
currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577
Reviewed by Darin Adler and Dmitry Titov.
The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Acquire the pthread key here.
2011-07-14 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not optimize Branch as well as it could.
https://bugs.webkit.org/show_bug.cgi?id=64574
Reviewed by Gavin Barraclough.
This creates a common code path for emitting unfused branches, which does
no speculation, and only performs a slow call if absolutely necessary.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitBranch):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-14 Filip Pizlo <fpizlo@apple.com>
GC allocation fast path has too many operations.
https://bugs.webkit.org/show_bug.cgi?id=64493
Reviewed by Darin Adler.
Changed the timing of the lazy sweep so that it occurs when we land on
a previously-unsweeped block, rather than whenever we land on an unsweeped
cell. After the per-block lazy sweep occurs, the block is turned into a
singly linked list of free cells. The allocation fast path is now just a
load-branch-store to remove a cell from the head of the list.
Additionally, this changes the way new blocks are allocated. Previously,
they would be populated with dummy cells. With this patch, they are
turned into a free list, which means that there will never be destructor
calls for allocations in fresh blocks.
These changes result in a 1.9% speed-up on V8, and a 0.6% speed-up on
SunSpider. There are no observed statistically significant slow-downs
on any individual benchmark.
* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
* heap/Heap.h:
(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::allocate):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):
* heap/MarkedBlock.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::addBlock):
(JSC::NewSpace::canonicalizeBlocks):
* heap/NewSpace.h:
(JSC::NewSpace::allocate):
(JSC::NewSpace::SizeClass::SizeClass):
(JSC::NewSpace::SizeClass::canonicalizeBlock):
* heap/OldSpace.cpp:
(JSC::OldSpace::addBlock):
2011-07-14 Filip Pizlo <fpizlo@apple.com>
DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562
Reviewed by Gavin Barraclough.
Fixed the relevant ASSERT.
* dfg/DFGOperations.cpp:
2011-07-14 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT contains a FIXME for rewinding speculative code generation that
has already been fixed.
https://bugs.webkit.org/show_bug.cgi?id=64022
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
2011-07-14 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Add OwnPtr specialization for Ecore_Pipe.
https://bugs.webkit.org/show_bug.cgi?id=64515
Add an overload for deleteOwnedPtr(Ecore_Pipe*) on EFL port.
Reviewed by Xan Lopez.
* wtf/OwnPtrCommon.h:
* wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
2011-07-14 Filip Pizlo <fpizlo@apple.com>
DFG JIT unnecessarily boxes and unboxes values during silent spilling.
https://bugs.webkit.org/show_bug.cgi?id=64068
Reviewed by Gavin Barraclough.
Silent spilling and filling of registers is done during slow-path C
function calls. The silent spill/fill logic does not affect register
allocation on paths that don't involve the C function call.
This changes the silent spilling code to spill in unboxed form. The
silent fill will refill in whatever form the register was spilled in.
For example, the silent spill code may choose not to spill the register
because it was already spilled previously, which would imply that it
was spilled in boxed form. The filling code detects this and either
unboxes, or not, depending on what is appropriate.
This change also results in a simplification of the silent spill/fill
API: silent spilling no longer needs to know about the set of registers
that cannot be trampled, since it never does boxing and hence does not
need a temporary register.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-13 Michael Saboff <msaboff@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64202
Enh: Improve handling of RegExp in the form of /.*blah.*/
Reviewed by Gavin Barraclough.
Added code to both the Yarr interpreter and JIT to handle
these expressions a little differently. First off, the terms
in between the leading and trailing .*'s cannot capture and
also this enhancement is limited to single alternative expressions.
If an expression is of the right form with the aforementioned
restrictions, we process the inner terms and then look for the
beginning of the string and end of the string. There is handling
for multiline expressions to allow the beginning and end to be
right after and right before newlines.
This enhancement speeds up expressions of this type 12x on
a MacBookPro.
Cleaned up 'case' statement indentation.
A new set of tests was added as LayoutTests/fast/regex/dotstar.html
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::end):
(JSC::Yarr::Interpreter::matchDotStarEnclosure):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::assertionDotStarEnclosure):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/YarrInterpreter.h:
(JSC::Yarr::ByteTerm::DotStarEnclosure):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::backtrackDotStarEnclosure):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
(JSC::Yarr::YarrPattern::compile):
* yarr/YarrPattern.h:
(JSC::Yarr::PatternTerm::PatternTerm):
2011-07-13 Xan Lopez <xlopez@igalia.com>
[GTK] Fix distcheck
Reviewed by Martin Robinson.
* GNUmakefile.list.am: add missing files.
2011-07-13 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not implement prototype chain or list caching for get_by_id.
https://bugs.webkit.org/show_bug.cgi?id=64147
Reviewed by Gavin Barraclough.
This implements unified support for prototype caching, prototype chain
caching, and polymorphic (i.e. list) prototype and prototype chain
caching. This is done by creating common code for emitting prototype
or chain access stubs, and having it factored out into
generateProtoChainAccessStub(). This function is called by
tryCacheGetByID once the latter determines that some form of prototype
access caching is necessary (i.e. the slot being accessed is not on the
base value but on some other object).
Direct prototype list, and prototype chain list, caching is implemented by
linking the slow path to operationGetByIdProtoBuildList(), which uses the
same helper function (generateProtoChainAccessStub()) as tryCacheGetByID.
This change required ensuring that the value in the scratchGPR field in
StructureStubInfo is preserved even after the stub info is in the
chain, or proto_list, states. Hence scratchGPR was moved out of the union
and into the top-level of StructureStubInfo.
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::dfgBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
* dfg/DFGRepatch.h:
2011-07-12 Brent Fulgham <bfulgham@webkit.org>
Standardize WinCairo conditionalized code under PLATFORM macro.
https://bugs.webkit.org/show_bug.cgi?id=64377
Reviewed by Maciej Stachowiak.
* wtf/Platform.h: Update to use PLATFORM(WIN_CAIRO) for tests.
2011-07-13 David Levin <levin@chromium.org>
Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger.
https://bugs.webkit.org/show_bug.cgi?id=64465
Reviewed by Dmitry Titov.
There isn't a good way to test this as it is very highly unlikely to occur.
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
isn't thread-safe, change the initialization to be global.
2011-07-12 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64424
Our direct eval behaviour deviates slightly from the spec.
Reviewed by Oliver Hunt.
The ES5 spec defines a concept of 'Direct Call to Eval' (see section 15.1.2.1.1), where
behaviour will differ from that of an indirect call (e.g. " { eval: window.eval }.eval();"
or "var a = eval; a();" are indirect calls), particularly in non-strict scopes variables
may be introduced into the caller's environment.
ES5 direct calls are any call where the callee function is provided by a reference, a base
of that Reference is an EnvironmentRecord (this corresponds to all productions
"PrimaryExpression: Identifier", see 10.2.2.1 GetIdentifierReference), and where the name
of the reference is "eval". This means any expression of the form "eval(...)", and that
calls the standard built in eval method from on the Global Object, is considered to be
direct.
In JavaScriptCore we are currently overly restrictive. We also check that the
EnvironmentRecord that is the base of the reference is the Declaractive Environment Record
at the root of the scope chain, corresponding to the Global Object - an "eval(..)" statement
that hits a var eval in a nested scope is not considered to be direct. This behaviour does
not emanate from the spec, and is incorrect.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- Fixed direct eval check in op_call_eval.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Fixed direct eval check in op_call_eval.
* runtime/Executable.h:
(JSC::isHostFunction):
- Added check for host function with specific NativeFunction.
2011-07-13 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717
QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.
Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
tested by him on QNX v6.5 (x86)
* wtf/DateMath.cpp: fix usage of abs/labs
* wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
* wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)
2011-07-12 Anders Carlsson <andersca@apple.com>
If a compiler has nullptr support, include <cstddef> to get the nullptr_t definition
https://bugs.webkit.org/show_bug.cgi?id=64429
Include the cstddef which has the nullptr_t typedef according to the C++0x standard.
* wtf/NullPtr.h:
2011-07-13 MORITA Hajime <morrita@google.com>
Refactoring: Ignored ExceptionCode value should be less annoying.
https://bugs.webkit.org/show_bug.cgi?id=63688
Added ASSERT_AT macro.
Reviewed by Darin Adler.
* wtf/Assertions.h:
2011-07-12 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066
Reviewed by Gavin Barraclough.
This is a fixed implementation of op_construct. Constructor calls are implemented
by reusing almost all of the code for Call, with care taken to make sure that
where the are differences (like selecting different code blocks), those differences
are respected. The two fixes over the last patch are: (1) make sure the
CodeBlock::unlinkCalls respects differences between Call and Construct, and (2)
make sure that virtualFor() in DFGOperations respects the CodeSpecializationKind
(either CodeForCall or CodeForConstruct) when invoking the compiler.
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordConstruct):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/CodeBlock.cpp:
(JSC::CodeBlock::unlinkCalls):
2011-07-12 Oliver Hunt <oliver@apple.com>
Overzealous type validation in method_check
https://bugs.webkit.org/show_bug.cgi?id=64415
Reviewed by Gavin Barraclough.
method_check is essentially just a value look up
optimisation, but it internally stores the value
as a JSFunction, even though it never relies on
this fact. Under GC validation however we end up
trying to enforce that assumption. The fix is
simply to store the value as a correct supertype.
* bytecode/CodeBlock.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2011-07-12 Filip Pizlo <fpizlo@apple.com>
COLLECT_ON_EVERY_ALLOCATION no longer works.
https://bugs.webkit.org/show_bug.cgi?id=64388
Reviewed by Oliver Hunt.
Added a flag to Heap that determines if it's safe to collect (which for now means that
JSGlobalObject has actually been initialized, but it should work for other things, too).
This allows JSGlobalObject to allocate even if the allocator wants to GC; instead of
GCing it just grows the heap, if necessary.
Then changed Heap::allocate() to not recurse ad infinitum when
COLLECT_ON_EVERY_ALLOCATION is set. This also makes the allocator generally more
resilient against bugs; this change allowed me to put in handy assertions, such as that
an allocation must succeed after either a collection or after a new block was added.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::notifyIsSafeToCollect):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
2011-07-12 Filip Pizlo <fpizlo@apple.com>
DFG JIT put_by_id transition caching does not inform the GC about the structure and
prototype chain that it is referencing.
https://bugs.webkit.org/show_bug.cgi?id=64387
Reviewed by Gavin Barraclough.
Fixed the relevant code in DFGRepatch to call StructureStubInfo::initPutByIdTransition().
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):
2011-07-12 Adam Roben <aroben@apple.com>
Ensure no intermediate WTF::Strings are created when concatenating with string literals
Fixes <http://webkit.org/b/63330> Concatenating string literals and WTF::Strings using
operator+ is suboptimal
Reviewed by Darin Adler.
* wtf/text/StringConcatenate.h:
(WTF::StringTypeAdapter<String>::writeTo): Added a macro that can be used for testing how
many WTF::Strings get copied while evaluating an operator+ expression.
* wtf/text/StringOperators.h:
(WTF::operator+): Changed the overload that takes a StringAppend to take it on the left-hand
side, since operator+ is left-associative. Having the StringAppend on the right-hand side
was causing us to make intermediate WTF::Strings when evaluating expressions that contained
multiple calls to operator+. Added some more overloads for that take a left-hand side of
const char* to resolve overload ambiguity for certain expressions. Added overloads that take
a left-hand side of const UChar* (matching the const char* overloads) so that wide string
literals don't first have to be converted to a WTF::String in operator+ expressions.
2011-07-12 Adam Roben <aroben@apple.com>
Unreviewed, rolling out r90811.
http://trac.webkit.org/changeset/90811
https://bugs.webkit.org/show_bug.cgi?id=61025
Several svg tests failing assertions beneath
SVGSMILElement::findInstanceTime
* wtf/StdLibExtras.h:
(WTF::binarySearch):
2011-07-12 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025
Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.
* wtf/StdLibExtras.h:
(WTF::binarySearch):
2011-07-11 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT does not guard itself against floating point speculation
failures on non-floating-point constants.
https://bugs.webkit.org/show_bug.cgi?id=64330
Reviewed by Gavin Barraclough.
Made fillSpeculateDouble immediate invoke terminateSpeculativeExecution() as
soon as it notices that it's speculating on something that is a non-numeric
JSConstant.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
2011-07-11 Filip Pizlo <fpizlo@apple.com>
DFG Speculative JIT does not always insert speculation checks when speculating
arrays.
https://bugs.webkit.org/show_bug.cgi?id=64254
Reviewed by Gavin Barraclough.
Changed the SetLocal instruction to always validate that the value being stored
into the local variable is an array, if that variable was marked PredictArray.
This is necessary since uses of arrays assume that if a PredictArray value is
in a local variable then the speculation check validating that the value is an
array was already performed.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-11 Gabor Loki <loki@webkit.org>
Fix the condition of the optimized code in doubleTransfer
https://bugs.webkit.org/show_bug.cgi?id=64261
Reviewed by Zoltan Herczeg.
The condition of the optimized code in doubleTransfer is wrong. The
data transfer should be executed with four bytes aligned address.
VFP cannot perform unaligned memory access.
Reported by Jacob Bramley.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::doubleTransfer):
2011-07-11 Gabor Loki <loki@webkit.org>
Signed arithmetic bug in dataTransfer32.
https://bugs.webkit.org/show_bug.cgi?id=64257
Reviewed by Zoltan Herczeg.
An arithmetic bug is fixed. If the offset of dataTransfer is half of the
addressable memory space on a 32-bit machine (-2147483648 = 0x80000000)
a load instruction is emitted with a wrong zero offset.
Inspired by Jacob Bramley's patch from JaegerMonkey.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::dataTransfer32):
2011-07-09 Thouraya Andolsi <thouraya.andolsi@st.com>
Fix unaligned userspace access for SH4 platforms.
https://bugs.webkit.org/show_bug.cgi?id=62993
* wtf/Platform.h:
2011-07-09 Chao-ying Fu <fu@mips.com>
Fix MIPS build due to readInt32 and readPointer
https://bugs.webkit.org/show_bug.cgi?id=63962
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::readInt32):
(JSC::MIPSAssembler::readPointer):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::rshift32):
2011-07-08 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64181
REGRESSION (r90602): Gmail doesn't load
Rolling out r90601, r90602.
* dfg/DFGAliasTracker.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::dfgLinkCall):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
2011-07-08 Kalev Lember <kalev@smartlink.ee>
Reviewed by Adam Roben.
Add missing _WIN32_WINNT and WINVER definitions
https://bugs.webkit.org/show_bug.cgi?id=59702
Moved _WIN32_WINNT and WINVER definitions to config.h so that they are
available for all source files.
In particular, wtf/FastMalloc.cpp uses CreateTimerQueueTimer and
DeleteTimerQueueTimer which are both guarded by
#if (_WIN32_WINNT >= 0x0500)
in MinGW headers.
* config.h:
* wtf/Assertions.cpp:
2011-07-08 Chang Shu <cshu@webkit.org>
Rename "makeSecure" to "fill" and remove the support for displaying last character
to avoid layering violatation.
https://bugs.webkit.org/show_bug.cgi?id=59114
Reviewed by Alexey Proskuryakov.
* JavaScriptCore.exp:
* JavaScriptCore.order:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::fill):
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:
(WTF::String::fill):
2011-07-08 Benjamin Poulain <benjamin@webkit.org>
[WK2] Do not forward touch events to the web process when it does not need them
https://bugs.webkit.org/show_bug.cgi?id=64164
Reviewed by Kenneth Rohde Christiansen.
Add a convenience function to obtain a reference to the last element of a Deque.
* wtf/Deque.h:
(WTF::Deque::last):
2011-07-07 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066
Reviewed by Gavin Barraclough.
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordConstruct):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-07 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not implement get_by_id prototype caching.
https://bugs.webkit.org/show_bug.cgi?id=64077
Reviewed by Gavin Barraclough.
* dfg/DFGRepatch.cpp:
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::tryCacheGetByID):
* runtime/JSObject.h:
(JSC::JSObject::addressOfPropertyAtOffset):
2011-07-07 Filip Pizlo <fpizlo@apple.com>
DFG JIT method_check implementation does not link to optimized get_by_id
slow path.
https://bugs.webkit.org/show_bug.cgi?id=64073
Reviewed by Gavin Barraclough.
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
2011-07-07 Oliver Hunt <oliver@apple.com>
Encode jump and link sizes into the appropriate enums
https://bugs.webkit.org/show_bug.cgi?id=64123
Reviewed by Sam Weinig.
Finally kill off the out of line jump and link size arrays,
so we can avoid icky loads and constant fold the linking arithmetic.
* assembler/ARMv7Assembler.cpp:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::computeJumpType):
2011-07-06 Juan C. Montemayor <jmont@apple.com>
ASSERT_NOT_REACHED running test 262
https://bugs.webkit.org/show_bug.cgi?id=63951
Added a case to the switch statement where the code was failing. Fixed
some logic as well that gave faulty error messages.
Reviewed by Gavin Barraclough.
* parser/JSParser.cpp:
(JSC::JSParser::getTokenName):
(JSC::JSParser::updateErrorMessageSpecialCase):
(JSC::JSParser::updateErrorMessage):
2011-07-06 Filip Pizlo <fpizlo@apple.com>
DFG JIT implementation of op_call results in regressions on sunspider
controlflow-recursive.
https://bugs.webkit.org/show_bug.cgi?id=64039
Reviewed by Gavin Barraclough.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::isSmallInt32Constant):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
2011-07-06 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not support method_check
https://bugs.webkit.org/show_bug.cgi?id=63972
Reviewed by Gavin Barraclough.
* assembler/CodeLocation.h:
(JSC::CodeLocationPossiblyNearCall::CodeLocationPossiblyNearCall):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordGetMethod):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addMethodGet):
(JSC::DFG::JITCompiler::MethodGetRecord::MethodGetRecord):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):
(JSC::DFG::dfgRepatchGetMethod):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITWriteBarrier.h:
(JSC::JITWriteBarrier::set):
2011-07-06 Filip Pizlo <fpizlo@apple.com>
DFG JIT op_call implementation will flush registers even when those registers are dead
https://bugs.webkit.org/show_bug.cgi?id=64023
Reviewed by Gavin Barraclough.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-06 Filip Pizlo <fpizlo@apple.com>
DFG speculative JIT may crash when speculating int on a non-int JSConstant.
https://bugs.webkit.org/show_bug.cgi?id=64017
Reviewed by Gavin Barraclough.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):
2011-07-06 Dmitriy Vyukov <dvyukov@google.com>
Reviewed by David Levin.
Allow substitution of dynamic annotations and prevent identical code folding by the linker.
https://bugs.webkit.org/show_bug.cgi?id=62443
* wtf/DynamicAnnotations.cpp:
(WTFAnnotateBenignRaceSized):
(WTFAnnotateHappensBefore):
(WTFAnnotateHappensAfter):
2011-07-06 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Calls on 32 bit machines are failed after r90423
https://bugs.webkit.org/show_bug.cgi?id=63980
Reviewed by Gavin Barraclough.
Copy the necessary lines from JITCall.cpp.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
2011-07-05 Filip Pizlo <fpizlo@apple.com>
DFG JIT virtual call implementation is inefficient.
https://bugs.webkit.org/show_bug.cgi?id=63974
Reviewed by Gavin Barraclough.
* dfg/DFGOperations.cpp:
* runtime/Executable.h:
(JSC::ExecutableBase::generatedJITCodeForCallWithArityCheck):
(JSC::ExecutableBase::generatedJITCodeForConstructWithArityCheck):
(JSC::ExecutableBase::generatedJITCodeWithArityCheckFor):
(JSC::ExecutableBase::hasJITCodeForCall):
(JSC::ExecutableBase::hasJITCodeForConstruct):
(JSC::ExecutableBase::hasJITCodeFor):
* runtime/JSFunction.h:
(JSC::JSFunction::scopeUnchecked):
2011-07-05 Oliver Hunt <oliver@apple.com>
Force inlining of simple functions that show up as not being inlined
https://bugs.webkit.org/show_bug.cgi?id=63964
Reviewed by Gavin Barraclough.
Looking at profile data indicates the gcc is failing to inline a
number of trivial functions. This patch hits the ones that show
up in profiles with the ALWAYS_INLINE hammer.
We also replace the memcpy() call in linking with a manual loop.
Apparently memcpy() is almost never faster than an inlined loop.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::add):
(JSC::ARMv7Assembler::add_S):
(JSC::ARMv7Assembler::ARM_and):
(JSC::ARMv7Assembler::asr):
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::clz):
(JSC::ARMv7Assembler::cmn):
(JSC::ARMv7Assembler::cmp):
(JSC::ARMv7Assembler::eor):
(JSC::ARMv7Assembler::it):
(JSC::ARMv7Assembler::ldr):
(JSC::ARMv7Assembler::ldrCompact):
(JSC::ARMv7Assembler::ldrh):
(JSC::ARMv7Assembler::ldrb):
(JSC::ARMv7Assembler::lsl):
(JSC::ARMv7Assembler::lsr):
(JSC::ARMv7Assembler::movT3):
(JSC::ARMv7Assembler::mov):
(JSC::ARMv7Assembler::movt):
(JSC::ARMv7Assembler::mvn):
(JSC::ARMv7Assembler::neg):
(JSC::ARMv7Assembler::orr):
(JSC::ARMv7Assembler::orr_S):
(JSC::ARMv7Assembler::ror):
(JSC::ARMv7Assembler::smull):
(JSC::ARMv7Assembler::str):
(JSC::ARMv7Assembler::sub):
(JSC::ARMv7Assembler::sub_S):
(JSC::ARMv7Assembler::tst):
(JSC::ARMv7Assembler::linkRecordSourceComparator):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp5Reg3Imm8):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp5Imm5Reg3Reg3):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp7Reg3Reg3Reg3):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp8Imm8):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp8RegReg143):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp9Imm7):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp10Reg3Reg3):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4FourFours):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16FourFours):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16Op16):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4Reg4Imm12):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::branchPtrWithPatch):
(JSC::MacroAssemblerARMv7::storePtrWithPatch):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeTailRecursiveCall):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):
2011-07-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Make "Add optimised paths for a few maths functions" work on Qt
https://bugs.webkit.org/show_bug.cgi?id=63893
Reviewed by Oliver Hunt.
Move the generated code to the .text section instead of .data section.
Fix alignment for the 32 bit thunk code.
* jit/ThunkGenerators.cpp:
2011-07-05 Filip Pizlo <fpizlo@apple.com>
DFG JIT does not implement op_call.
https://bugs.webkit.org/show_bug.cgi?id=63858
Reviewed by Gavin Barraclough.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkCalls):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setNumberOfCallLinkInfos):
(JSC::CodeBlock::numberOfCallLinkInfos):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::lookupGetByVal):
(JSC::DFG::AliasTracker::recordCall):
(JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::opName):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):
* dfg/DFGGraph.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::useChildren):
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::addressOfCallData):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallRecord::CallRecord):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCallWithFastExceptionCheck):
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkCall):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
* interpreter/CallFrame.h:
(JSC::ExecState::calleeAsValue):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkCall):
(JSC::JIT::linkConstruct):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCode.h:
(JSC::JITCode::JITCode):
(JSC::JITCode::jitType):
(JSC::JITCode::HostFunction):
* runtime/JSFunction.h:
* runtime/JSGlobalData.h:
2011-07-05 Oliver Hunt <oliver@apple.com>
Initialize new MarkStack member
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
2011-07-05 Oliver Hunt <oliver@apple.com>
Don't throw out compiled code repeatedly
https://bugs.webkit.org/show_bug.cgi?id=63960
Reviewed by Gavin Barraclough.
Stop throwing away all compiled code every time
we're told to do a full GC. Instead unlink all
callsites during such GC passes to maximise the
number of collectable functions, but otherwise
leave compiled functions alone.
* API/JSBase.cpp:
(JSGarbageCollect):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/MarkStack.h:
(JSC::MarkStack::shouldUnlinkCalls):
(JSC::MarkStack::setShouldUnlinkCalls):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
2011-07-05 Filip Pizlo <fpizlo@apple.com>
JSC JIT has code duplication for the handling of call and construct
https://bugs.webkit.org/show_bug.cgi?id=63957
Reviewed by Gavin Barraclough.
* jit/JIT.cpp:
(JSC::JIT::linkFor):
* jit/JIT.h:
* jit/JITStubs.cpp:
(JSC::jitCompileFor):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::arityCheckFor):
(JSC::lazyLinkFor):
* runtime/Executable.h:
(JSC::ExecutableBase::generatedJITCodeFor):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::isGeneratedFor):
(JSC::FunctionExecutable::generatedBytecodeFor):
(JSC::FunctionExecutable::generatedJITCodeWithArityCheckFor):
2011-07-05 Gavin Barraclough <barraclough@apple.com>
Build fix following last patch.
* runtime/JSFunction.cpp:
(JSC::createPrototypeProperty):
2011-07-05 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=63947
ASSERT running Object.preventExtensions(Math.sin)
Reviewed by Oliver Hunt.
This is due to calling scope() on a hostFunction as a part of
calling createPrototypeProperty to reify the prototype property.
But host functions don't have a prototype property anyway!
Prevent callling createPrototypeProperty on a host function.
* runtime/JSFunction.cpp:
(JSC::JSFunction::createPrototypeProperty):
(JSC::JSFunction::preventExtensions):
2011-07-04 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=63880
Evaluation order of conversions of operands to >, >= incorrect.
Reviewed by Sam Weinig.
Add 'leftFirst' parameter to jsLess, jsLessEq matching that described in the ES5
spec. This allows these methods to be reused to perform >, >= relational compares
with correct ordering of type conversions.
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Operations.h:
(JSC::jsLess):
(JSC::jsLessEq):
2011-07-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)
Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.
* runtime/NumberPrototype.cpp:
(JSC::decomposeDouble):
- helper function to extract sign, exponent, mantissa from IEEE doubles.
(JSC::Uint16WithFraction::Uint16WithFraction):
- helper class, u16int with infinite precision fraction, used to convert
the fractional part of the number to a string.
(JSC::Uint16WithFraction::operator*=):
- Multiply by a uint16.
(JSC::Uint16WithFraction::operator<):
- Compare two Uint16WithFractions.
(JSC::Uint16WithFraction::floorAndSubtract):
- Extract the integer portion of the number, and subtract it (clears the integer portion).
(JSC::Uint16WithFraction::comparePoint5):
- Compare to 0.5.
(JSC::Uint16WithFraction::sumGreaterThanOne):
- Passed a second Uint16WithFraction, returns true if the result of adding
the two values would be greater than one.
(JSC::Uint16WithFraction::isNormalized):
- Used by ASSERTs to consistency check internal representation.
(JSC::BigInteger::BigInteger):
- helper class, unbounded integer value, used to convert the integer part
of the number to a string.
(JSC::BigInteger::divide):
- Divide this value through by a uint32.
(JSC::BigInteger::operator!):
- test for zero.
(JSC::toStringWithRadix):
- Performs number to string conversion, with the given radix (2..36).
(JSC::numberProtoFuncToString):
- Changed to use toStringWithRadix.
2011-07-04 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=63881
Need separate bytecodes for handling >, >= comparisons.
Reviewed by Oliver Hunt.
This clears the way to fix Bug#63880. We currently handle greater-than comparisons
as being using the corresponding op_less, etc opcodes. This is incorrect with
respect to evaluation ordering of the implicit conversions performed on operands -
we should be calling ToPrimitive on the LHS and RHS operands to the greater than,
but instead convert RHS then LHS.
This patch adds opcodes for greater-than comparisons mirroring existing ones used
for less-than.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
* bytecompiler/NodesCodegen.cpp:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::emit_op_loop_if_greater):
(JSC::JIT::emitSlow_op_loop_if_greater):
(JSC::JIT::emit_op_loop_if_greatereq):
(JSC::JIT::emitSlow_op_loop_if_greatereq):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jgreater):
(JSC::JIT::emit_op_jgreatereq):
(JSC::JIT::emit_op_jngreater):
(JSC::JIT::emit_op_jngreatereq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitBinaryDoubleOp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* parser/NodeConstructors.h:
(JSC::GreaterNode::GreaterNode):
(JSC::GreaterEqNode::GreaterEqNode):
* parser/Nodes.h:
2011-07-03 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=63879
Reduce code duplication for op_jless, op_jlesseq, op_jnless, op_jnlesseq.
Reviewed by Sam Weinig.
There is a lot of copy & paste code here; we can reduce duplication by making
a shared implementation.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::commute):
- Make these function platform agnostic.
* assembler/MacroAssemblerX86Common.h:
- Moved branch32/commute up to MacroAssembler.
* jit/JIT.h:
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
- Add an implementation matching that for op_loop_if_less, which just calls op_jless.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
- Common implmentations of these methods for JSVALUE64 & JSVALUE32_64.
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
- Internal implmementation of jless etc for JSVALUE64.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
- Internal implmementation of jless etc for JSVALUE32_64.
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
- Remove old implementation of emit_op_loop_if_lesseq.
2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90347.
http://trac.webkit.org/changeset/90347
https://bugs.webkit.org/show_bug.cgi?id=63886
Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
(Requested by tkent on #webkit).
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/BigInteger.h: Removed.
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
* runtime/Uint16WithFraction.h: Removed.
* wtf/MathExtras.h:
2011-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)
Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.
* runtime/NumberPrototype.cpp:
(JSC::decomposeDouble):
- helper function to extract sign, exponent, mantissa from IEEE doubles.
(JSC::Uint16WithFraction::Uint16WithFraction):
- helper class, u16int with infinite precision fraction, used to convert
the fractional part of the number to a string.
(JSC::Uint16WithFraction::operator*=):
- Multiply by a uint16.
(JSC::Uint16WithFraction::operator<):
- Compare two Uint16WithFractions.
(JSC::Uint16WithFraction::floorAndSubtract):
- Extract the integer portion of the number, and subtract it (clears the integer portion).
(JSC::Uint16WithFraction::comparePoint5):
- Compare to 0.5.
(JSC::Uint16WithFraction::sumGreaterThanOne):
- Passed a second Uint16WithFraction, returns true if the result of adding
the two values would be greater than one.
(JSC::Uint16WithFraction::isNormalized):
- Used by ASSERTs to consistency check internal representation.
(JSC::BigInteger::BigInteger):
- helper class, unbounded integer value, used to convert the integer part
of the number to a string.
(JSC::BigInteger::divide):
- Divide this value through by a uint32.
(JSC::BigInteger::operator!):
- test for zero.
(JSC::toStringWithRadix):
- Performs number to string conversion, with the given radix (2..36).
(JSC::numberProtoFuncToString):
- Changed to use toStringWithRadix.
2011-07-02 Gavin Barraclough <barraclough@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=63866
DFG JIT - implement instanceof
Reviewed by Sam Weinig.
Add ops CheckHasInstance & InstanceOf to implement bytecodes
op_check_has_instance & op_instanceof. This is an initial
functional implementation, performance is a wash. We can
follow up with changes to fuse the InstanceOf node with
a subsequant branch, as we do with other comparisons.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-07-01 Oliver Hunt <oliver@apple.com>
IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren()
https://bugs.webkit.org/show_bug.cgi?id=63732
Reviewed by Gavin Barraclough.
Initialise the memory at the head of the new storage so that
GC is safe if triggered by reportExtraMemoryCost.
* runtime/JSArray.cpp:
(JSC::JSArray::increaseVectorPrefixLength):
2011-07-01 Oliver Hunt <oliver@apple.com>
GC sweep can occur before an object is completely initialised
https://bugs.webkit.org/show_bug.cgi?id=63836
Reviewed by Gavin Barraclough.
In rare cases it's possible for a GC sweep to occur while a
live, but not completely initialised object is on the stack.
In such a case we may incorrectly choose to mark it, even
though it has no children that need marking.
We resolve this by always zeroing out the structure of any
value returned from JSCell::operator new(), and making the
markstack tolerant of a null structure.
* runtime/JSCell.h:
(JSC::JSCell::JSCell::~JSCell):
(JSC::JSCell::JSCell::operator new):
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):
2011-07-01 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG non-speculative JIT always performs slow C calls for div and mod.
https://bugs.webkit.org/show_bug.cgi?id=63684
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
2011-07-01 Juan C. Montemayor <jmont@apple.com>
Reviewed by Oliver Hunt.
Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340
Added error messages for the Lexer. These messages will be displayed
instead of the lexer error messages from the parser that are currently
shown.
* parser/Lexer.cpp:
(JSC::Lexer::getInvalidCharMessage):
(JSC::Lexer::setCode):
(JSC::Lexer::parseString):
(JSC::Lexer::lex):
(JSC::Lexer::clear):
* parser/Lexer.h:
(JSC::Lexer::getErrorMessage):
(JSC::Lexer::setOffset):
* parser/Parser.cpp:
(JSC::Parser::parse):
2011-07-01 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)
http://bugs.webkit.org/show_bug.cgi?id=20797
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* icu/unicode/uscript.h: Added for UScriptCode enum.
* wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
* wtf/unicode/icu/UnicodeIcu.h:
* wtf/unicode/brew/UnicodeBrew.h:
* wtf/unicode/glib/UnicodeGLib.h:
* wtf/unicode/qt4/UnicodeQt4.h:
* wtf/unicode/wince/UnicodeWinCE.h:
2011-07-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=63819
Escaping of forwardslashes in strings incorrect if multiple exist.
The bug is in the parameters passed to a substring - should be
start & length, but we're passing start & end indices!
* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):
2011-07-01 Adam Roben <aroben@apple.com>
Roll out r90194
http://trac.webkit.org/changeset/90194
https://bugs.webkit.org/show_bug.cgi?id=63778
Fixes <http://webkit.org/b/63812> REGRESSION (r90194): Multiple tests intermittently failing
assertions in WriteBarrierBase<JSC::Structure>::get
* runtime/JSCell.h:
(JSC::JSCell::JSCell::~JSCell):
2011-06-30 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757
Relanding as a Mac only patch.
This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsDoubleBitops):
(JSC::MacroAssemblerARM::andnotDouble):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsDoubleBitops):
(JSC::MacroAssemblerARMv7::andnotDouble):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::andnotDouble):
(JSC::MacroAssemblerMIPS::supportsDoubleBitops):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsDoubleBitops):
(JSC::MacroAssemblerSH4::andnotDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::supportsDoubleBitops):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::andnotDouble):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::supportsDoubleBitops):
* assembler/X86Assembler.h:
(JSC::X86Assembler::andnpd_rr):
* create_hash_table:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
(JSC::SpecializedThunkJIT::callDoubleToDouble):
* jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
* jit/ThunkGenerators.h:
2011-07-01 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp
Fixes the following build error in clang:
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
^
( )
fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary expression evaluate first.
2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90177 and r90179.
http://trac.webkit.org/changeset/90177
http://trac.webkit.org/changeset/90179
https://bugs.webkit.org/show_bug.cgi?id=63790
It caused crashes on Qt in debug mode (Requested by Ossy on
#webkit).
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::sqrtDouble):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::sqrtDouble):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::sqrtDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::sqrtDouble):
* assembler/MacroAssemblerX86.h:
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
* create_hash_table:
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitLoadDouble):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
* jit/ThunkGenerators.h:
2011-06-30 Oliver Hunt <oliver@apple.com>
Reviewed by Beth Dakin.
Make GC validation clear cell structure on destruction
https://bugs.webkit.org/show_bug.cgi?id=63778
* runtime/JSCell.h:
(JSC::JSCell::JSCell::~JSCell):
2011-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Added write barrier that was missing from put_by_id_transition
https://bugs.webkit.org/show_bug.cgi?id=63775
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier): Made this static with a
MacroAssembler& argument so our patching functions could use it.
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile): Updated for signature change.
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID): Missing barrier!
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile): Updated for signature change.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
* jit/JSInterfaceJIT.h: Same game here. Removed storePtrWithWriteBarrier
because its meaning isn't clear -- maybe in the future we'll have a
clear way to pass all stores through a common function that guarantees
a write barrier, but that's not the case right now.
2011-06-30 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG non-speculative JIT does not reuse registers when compiling comparisons.
https://bugs.webkit.org/show_bug.cgi?id=63565
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compare):
2011-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Added empty write barrier stubs in all the right places in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=63764
SunSpider thinks this might be a 0.5% speedup. Meh.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier): Le stub.
(JSC::DFG::JITCodeGenerator::cachedPutById): Don't do anything special
for the case where base == scratch, since we now require base and scratch
to be not equal, for the sake of the write barrier.
* dfg/DFGJITCodeGenerator.h: Le stub.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile): Don't reuse the base register
as the scratch register, since that's incompatible with the write barrier,
which needs a distinct base and scratch.
Do put the global object into a register before loading its var storage,
since it needs to be in a register for the write barrier to operate on it.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier): Second verse, same as the first.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more
places.
(JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
is a little more than meaningless.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more
places.
(JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
is a little more than meaningless.
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::offsetOfRegisters): Now used by the JIT, since
we put the global object in a register and only then load its var storage
by offset.
(JSC::JIT::emitWriteBarrier):
2011-06-30 Oliver Hunt <oliver@apple.com>
Fix ARMv6 build
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::rshift32):
2011-06-30 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757
This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsDoubleBitops):
(JSC::MacroAssemblerARM::andnotDouble):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsDoubleBitops):
(JSC::MacroAssemblerARMv7::andnotDouble):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::andnotDouble):
(JSC::MacroAssemblerMIPS::supportsDoubleBitops):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsDoubleBitops):
(JSC::MacroAssemblerSH4::andnotDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::supportsDoubleBitops):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::andnotDouble):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::supportsDoubleBitops):
* assembler/X86Assembler.h:
(JSC::X86Assembler::andnpd_rr):
* create_hash_table:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
(JSC::SpecializedThunkJIT::callDoubleToDouble):
* jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
* jit/ThunkGenerators.h:
2011-06-30 Cary Clark <caryclark@google.com>
Reviewed by James Robinson.
Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999
* wtf/Platform.h:
Add switch to use Skia if, externally,
Skia has been enabled by a gyp define.
2011-06-30 Juan C. Montemayor <jmont@apple.com>
Reviewed by Geoffrey Garen.
Web Inspector fails to display source for eval with syntax error
https://bugs.webkit.org/show_bug.cgi?id=63583
Web Inspector now displays a link to an eval statement that contains
a syntax error.
* parser/Parser.h:
(JSC::isEvalNode):
(JSC::EvalNode):
(JSC::Parser::parse):
2011-06-30 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
X86Assembler does not encode byte registers in 64-bit mode correctly.
https://bugs.webkit.org/show_bug.cgi?id=63665
* assembler/X86Assembler.h:
(JSC::X86Assembler::testb_rr):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):
2011-06-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r90102.
http://trac.webkit.org/changeset/90102
https://bugs.webkit.org/show_bug.cgi?id=63714
Lots of tests asserting beneath
SVGSMILElement::findInstanceTime (Requested by aroben on
#webkit).
* wtf/StdLibExtras.h:
(WTF::binarySearch):
2011-06-30 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025
Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.
* wtf/StdLibExtras.h:
(WTF::binarySearch):
2011-06-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=63669
DFG JIT - fix spectral-norm regression
The problem is a mis-speculation leading to us falling off the speculative path.
Make the speculation logic slightly smarter, don't predict int if one of the
operands is already loaded as a double (we use this logic already for compares).
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
2011-06-29 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG JIT does not do put_by_id transition caching.
https://bugs.webkit.org/show_bug.cgi?id=63662
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
* dfg/DFGRepatch.cpp:
(JSC::DFG::testPrototype):
(JSC::DFG::tryCachePutByID):
2011-06-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a dummy write barrier emitting function in all the right places in the old JIT
https://bugs.webkit.org/show_bug.cgi?id=63667
SunSpider reports no change.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_put_scoped_var): Do it.
(JSC::JIT::emit_op_put_global_var): Global object needs to be in a register
for the sake of the write barrier.
(JSC::JIT::emitWriteBarrier): Empty for now. Not for long!
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_put_scoped_var): Do it.
(JSC::JIT::emit_op_put_global_var): Global object needs to be in a register
for the sake of the write barrier.
(JSC::JIT::emitWriteBarrier): Empty for now. Not for long!
2011-06-29 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG JIT does not perform get_by_id self list caching.
https://bugs.webkit.org/show_bug.cgi?id=63605
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::dfgBuildGetByIDList):
* dfg/DFGRepatch.h:
2011-06-28 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG JIT lacks array.length caching.
https://bugs.webkit.org/show_bug.cgi?id=63505
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::tryAllocate):
(JSC::DFG::JITCodeGenerator::selectScratchGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::tryAllocate):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
2011-06-28 Pierre Rossi <pierre.rossi@gmail.com>
Reviewed by Eric Seidel.
Warnings in JSC's JIT on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=63259
Fairly straightforward, just use ASSERT_JIT_OFFSET_UNUSED when it applies.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581
Broke chromium windows compile (Requested by jamesr on
#webkit).
* wtf/Platform.h:
2011-06-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix sampling build
https://bugs.webkit.org/show_bug.cgi?id=63579
Gets opcode sampling building again, doesn't seem to work alas
* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::notifyOfScope):
* bytecode/SamplingTool.h:
(JSC::SamplingTool::SamplingTool):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::enableSampler):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
2011-06-28 Cary Clark <caryclark@google.com>
Reviewed by James Robinson.
Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999
* wtf/Platform.h:
Add switch to use Skia if, externally,
Skia has been enabled by a gyp define.
2011-06-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
ASSERT when launching debug builds with interpreter and jit enabled
https://bugs.webkit.org/show_bug.cgi?id=63566
Add appropriate guards to the various Executable's memory reporting
logic.
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
2011-06-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=63563
DFG JIT - add support for double arith to speculative path
Add integer support for div & mod, add double support for div, mod,
add, sub & mul, dynamically selecting based on operand types.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::assembler):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::~SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::index):
(JSC::DFG::SpeculateDoubleOperand::fpr):
2011-06-28 Oliver Hunt <oliver@apple.com>
Fix interpreter build.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2011-06-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=63561
DFG JIT - don't always assume integer in relational compare
If neither operand is known integer, or either is in double representation,
then at least use a function call (don't bail off the speculative path).
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDataFormatDouble):
(JSC::DFG::SpeculativeJIT::compareIsInteger):
2011-06-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554
Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addConstantBuffer):
(JSC::CodeBlock::constantBuffer):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantBuffer):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2011-06-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=63560
DFG_JIT allow allocation of specific machine registers
This allow us to allocate the registers necessary to perform x86
idiv instructions for div/mod, and may be useful for shifts, too.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::allocate):
(JSC::DFG::GPRResult::GPRResult):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::allocateSpecific):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
2011-06-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=55040
RegExp constructor returns the argument regexp instead of a new object
Per 15.10.3.1, our current behaviour is correct if called as a function,
but incorrect when called as a constructor.
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):
* runtime/RegExpConstructor.h:
2011-06-28 Luke Macpherson <macpherson@chromium.org>
Reviewed by Darin Adler.
Clean up integer clamping functions in MathExtras.h and support arbitrary numeric types and limits.
https://bugs.webkit.org/show_bug.cgi?id=63469
* wtf/MathExtras.h:
(defaultMinimumForClamp):
Version of std::numeric_limits::min() that returns the largest negative value for floating point types.
(defaultMaximumForClamp):
Symmetric alias for std::numeric_limits::max()
(clampTo):
New templated clamping function that supports arbitrary output types.
(clampToInteger):
Use new clampTo template.
(clampToFloat):
Use new clampTo template.
(clampToPositiveInteger):
Use new clampTo template.
2011-06-28 Adam Roben <aroben@apple.com>
Windows Debug build fix after r89885
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Exported
JSGlobalData::releaseExecutableMemory for jsc.exe's benefit.
2011-06-28 Shinya Kawanaka <shinyak@google.com>
Reviewed by Kent Tamura.
Add const to show() method in WTFString and AtomicString.
https://bugs.webkit.org/show_bug.cgi?id=63515
The lack of const in show() method is painful when
doing something like printf-debug.
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::show):
* wtf/text/AtomicString.h:
* wtf/text/WTFString.cpp:
(String::show):
* wtf/text/WTFString.h:
2011-06-27 Ryosuke Niwa <rniwa@webkit.org>
Build fix attempt after r89885.
* JavaScriptCore.exp:
* jsc.cpp:
2011-06-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Support throwing away non-running code even while other code is running
https://bugs.webkit.org/show_bug.cgi?id=63485
Add a function to CodeBlock to support unlinking direct linked callsites,
and then with that in place add logic to discard code from any function
that is not currently on the stack.
The unlinking completely reverts any optimized call sites, such that they
may be relinked again in future.
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::clearEvalCache):
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::unlink):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::clear):
* heap/Heap.cpp:
(JSC::Heap::getConservativeRegisterRoots):
* heap/Heap.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITWriteBarrier.h:
(JSC::JITWriteBarrierBase::clear):
* jsc.cpp:
(GlobalObject::GlobalObject):
(functionReleaseExecutableMemory):
* runtime/Executable.cpp:
(JSC::EvalExecutable::unlinkCalls):
(JSC::ProgramExecutable::unlinkCalls):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::unlinkCalls):
* runtime/Executable.h:
* runtime/JSGlobalData.cpp:
(JSC::SafeRecompiler::returnValue):
(JSC::SafeRecompiler::operator()):
(JSC::JSGlobalData::releaseExecutableMemory):
2011-06-27 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler & Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=50554
RegExp.prototype.toString does not escape slashes
The problem here is that we don't escape forwards slashes when converting
a RegExp to a string. This means that RegExp("/").toString() is "///",
which is not a valid RegExp literal. Also, we return an invalid literal
for RegExp.prototype.toString() ("//", which is an empty single-line comment).
From ES5:
"NOTE: The returned String has the form of a RegularExpressionLiteral that
evaluates to another RegExp object with the same behaviour as this object."
* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):
- Escape forward slashes when getting the source of a RegExp.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
- Remove unnecessary and erroneous hack to return "//" as the string
representation of RegExp.prototype. This is not a valid RegExp literal
(it is an empty single-line comment).
2011-06-27 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=63497
Add DEBUG_WITH_BREAKPOINT support to the DFG JIT.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-06-27 Juan C. Montemayor <jmont@apple.com>
Reviewed by Mark Rowe.
Indirectly including TextPosition.h and XPathGrammar.h causes compile errors
https://bugs.webkit.org/show_bug.cgi?id=63392
When both TextPosition.h and XPathGrammar.h are included a compile-error
is caused, since XPathGrammar.h defines a macro called NUMBER and
TextPosition has a typedef named NUMBER.
* wtf/text/TextPosition.h:
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):
2011-06-27 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG JIT does not perform put_by_id caching.
https://bugs.webkit.org/show_bug.cgi?id=63409
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::appropriatePutByIdFunction):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgRepatchPutByID):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-06-27 Gustavo Noronha Silva <gns@gnome.org>
Unreviewed build fix. One more filed missing during distcheck, for
the MIPS build.
* GNUmakefile.list.am:
2011-06-26 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations.
https://bugs.webkit.org/show_bug.cgi?id=63347
* dfg/DFGNonSpeculativeJIT.cpp:
- Changed arithmetic operations to speculate in favor of integers.
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGOperations.cpp:
- Added slow-path routines for arithmetic that perform no speculation; the
non-speculative JIT will generate calls to these in cases where its
speculation fails.
* dfg/DFGOperations.h:
2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
* wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.
2011-06-24 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
https://bugs.webkit.org/show_bug.cgi?id=63345
The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
return 9 and 10 bit quantities, therefore changed their return type from
uint8_t to uint16_t. Also casted the places where they are used as they
are currently shifted and used as 7 or 8 bit values.
These methods are currently used for literals for stack offsets,
including creating and destroying stack frames. The prior truncation of
the upper bits caused stack frames to be too small, thus allowing a
JIT'ed function to access and overwrite stack space outside of the
incorrectly sized stack frame.
* assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::getUInt9):
(JSC::ARMThumbImmediate::getUInt10):
(JSC::ARMv7Assembler::add):
(JSC::ARMv7Assembler::ldr):
(JSC::ARMv7Assembler::str):
(JSC::ARMv7Assembler::sub):
(JSC::ARMv7Assembler::sub_S):
2011-06-24 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
https://bugs.webkit.org/show_bug.cgi?id=63015
Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList(). These
adjustments are a bug. These need to reflect the pages that are released
in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
Made ReleaseFreeList a member of TCMalloc_PageHeap in the process. Updated
Check() and helper method CheckList() to check the number of actual free pages
with free_committed_pages_.
The symptom of the problem of the existing code is that the scavenger may
run unneccesarily without any real work to do, i.e. pages on the free lists.
The scanvenger would also end up freeing too many pages, that is going below
the current 528 target free pages.
Note that the style of the changes was kept consistent with the
existing style.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::TCMalloc_PageHeap::ReleaseFreeList):
2011-06-24 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Match other clampTo* functions in style with clampToInteger(float)
function.
https://bugs.webkit.org/show_bug.cgi?id=53449
* wtf/MathExtras.h:
(clampToInteger):
(clampToFloat):
(clampToPositiveInteger):
2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89594.
http://trac.webkit.org/changeset/89594
https://bugs.webkit.org/show_bug.cgi?id=63316
It broke 5 tests on the Qt bot (Requested by Ossy_DC on
#webkit).
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* icu/unicode/uscript.h: Removed.
* wtf/unicode/ScriptCodesFromICU.h: Removed.
* wtf/unicode/brew/UnicodeBrew.h:
* wtf/unicode/glib/UnicodeGLib.h:
* wtf/unicode/icu/UnicodeIcu.h:
* wtf/unicode/qt4/UnicodeQt4.h:
* wtf/unicode/wince/UnicodeWinCE.h:
2011-06-23 Filip Pizlo <fpizlo@apple.com>
Reviewed by Gavin Barraclough.
DFG non-speculative JIT should have obvious optimizations for GetById and GetByVal
https://bugs.webkit.org/show_bug.cgi?id=63173
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-06-23 Oliver Hunt <oliver@apple.com>
Fix Qt again.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::readPointer):
2011-06-23 Oliver Hunt <oliver@apple.com>
Fix Qt Build
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::readPointer):
2011-06-23 Stephanie Lewis <slewis@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=63298
Replace Malloc with FastMalloc to match the rest of wtf.
* wtf/BlockStack.h:
(WTF::::~BlockStack):
(WTF::::grow):
(WTF::::shrink):
2011-06-23 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add the ability to dynamically modify linked call sites
https://bugs.webkit.org/show_bug.cgi?id=63291
Add JITWriteBarrier as a writebarrier class that allows
reading and writing directly into the code stream.
This required adding logic to all the assemblers to allow
us to read values back out of the instruction stream.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::readPointer):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::readPointer):
(JSC::ARMv7Assembler::readInt32):
(JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmSecond):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::readPointer):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::readInt32):
(JSC::MIPSAssembler::readPointer):
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::operator!):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readPCrelativeAddress):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::readInt32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::readPointer):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* heap/MarkStack.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkCall):
(JSC::JIT::linkConstruct):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITPropertyAccess32_64.cpp:
* jit/JITWriteBarrier.h: Added.
(JSC::JITWriteBarrierBase::operator UnspecifiedBoolType*):
(JSC::JITWriteBarrierBase::operator!):
(JSC::JITWriteBarrierBase::setFlagOnBarrier):
(JSC::JITWriteBarrierBase::isFlagged):
(JSC::JITWriteBarrierBase::setLocation):
(JSC::JITWriteBarrierBase::location):
(JSC::JITWriteBarrierBase::JITWriteBarrierBase):
(JSC::JITWriteBarrierBase::set):
(JSC::JITWriteBarrierBase::get):
(JSC::JITWriteBarrier::JITWriteBarrier):
(JSC::JITWriteBarrier::set):
(JSC::JITWriteBarrier::get):
(JSC::MarkStack::append):
2011-06-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=61585
Crash running regexp /(?:(?=g))|(?:m).{2147483648,}/
This is due to use of int instead of unsigned, bad math around
the 2^31 boundary.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):
- Change some uses of int to unsigned, refactor compare logic to
restrict to the range 0..2^32-1 (rather than -2^32-1..2^32-1).
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
- Ditto.
2011-06-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=63218
DFG JIT - remove machine type guarantees from graph
The DFG JIT currently makes assumptions about the types of machine registers
that certain nodes will be loaded into. This will be broken as we generate
nodes to produce both integer and double code paths. Remove int<->double
conversions nodes. This design decision also gave rise to multiple types of
constant nodes, requiring separate handling for each type. Merge these back
into JSConstant.
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getToNumber):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isInt32Constant):
(JSC::DFG::ByteCodeParser::isDoubleConstant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfDoubleConstant):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::predictInt32):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isJSConstant):
(JSC::DFG::JITCodeGenerator::isDoubleConstant):
(JSC::DFG::JITCodeGenerator::valueOfJSConstantAsImmPtr):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::notTakenBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
2011-06-23 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Add ScriptCodesFromICU.h to wtf/unicode and make necessary changes in
build files for ports not using ICU.
Add icu/unicode/uscript.h for ports using ICU. It's taken from
ICU 3.6 (the version used on Mac OS 10.5)
http://bugs.webkit.org/show_bug.cgi?id=20797
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* icu/unicode/uscript.h: Added for UScriptCode enum.
* wtf/unicode/ScriptCodesFromICU.h: UScriptCode enum added.
* wtf/unicode/icu/UnicodeIcu.h:
* wtf/unicode/brew/UnicodeBrew.h:
* wtf/unicode/glib/UnicodeGLib.h:
* wtf/unicode/qt4/UnicodeQt4.h:
* wtf/unicode/wince/UnicodeWinCE.h:
2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Andreas Kling.
[EFL][WK2] Add PLATFORM(EFL) to use UNIX_DOMAIN_SOCKETS.
https://bugs.webkit.org/show_bug.cgi?id=63228
* wtf/Platform.h: Add PLATFORM(EFL) guard.
2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89547.
http://trac.webkit.org/changeset/89547
https://bugs.webkit.org/show_bug.cgi?id=63252
"Chrmium crash on start" (Requested by yurys on #webkit).
* wtf/DynamicAnnotations.cpp:
(WTFAnnotateBenignRaceSized):
(WTFAnnotateHappensBefore):
(WTFAnnotateHappensAfter):
* wtf/DynamicAnnotations.h:
2011-06-23 Timur Iskhodzhanov <timurrrr@google.com>
Reviewed by David Levin.
Make dynamic annotations weak symbols and prevent identical code folding by the linker
https://bugs.webkit.org/show_bug.cgi?id=62443
* wtf/DynamicAnnotations.cpp:
(WTFAnnotateBenignRaceSized):
(WTFAnnotateHappensBefore):
(WTFAnnotateHappensAfter):
* wtf/DynamicAnnotations.h:
2011-06-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
* wtf/Platform.h:
2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89489.
http://trac.webkit.org/changeset/89489
https://bugs.webkit.org/show_bug.cgi?id=63203
Broke chromium mac build on build.webkit.org (Requested by
abarth on #webkit).
* wtf/Platform.h:
2011-06-22 Cary Clark <caryclark@google.com>
Reviewed by Darin Fisher.
Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999
* wtf/Platform.h:
Add switch to use Skia if, externally,
Skia has been enabled by a gyp define.
2011-06-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
* interpreter/RegisterFile.h: Removed unnecessary #include <stdio.h>.
2011-06-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed the conceit that global variables are local variables when running global code
https://bugs.webkit.org/show_bug.cgi?id=63106
This is required for write barrier correctness.
SunSpider reports about a 0.5% regression, mostly from bitops-bitwise-and.js.
I was able to reduce the regression with a tiny peephole optimization in
the bytecompiler, but not eliminate it. I'm committing this assuming
that turning on generational GC will win back at least 0.5%.
(FWIW, the DFG JIT can easily eliminate any regression by sharing loads of
the global object's var storage. I considered doing the same kind of
optimization in the existing JIT, but it seemed like moving in the wrong
direction.)
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator): Don't give global variables
negative indices, since they're no longer negatively offset from the
current stack frame.
Do give global variables monotonically increasing positive indices, since
that's much easier to work with.
Don't limit the number of optimizable global variables, since it's no
longer limited by the register file, since they're no longer stored in
the register file.
(JSC::BytecodeGenerator::registerFor): Global code never has any local
registers because a var in global code is actually a property of the
global object.
(JSC::BytecodeGenerator::constRegisterFor): Ditto.
(JSC::BytecodeGenerator::emitResolve): Did a tiny bit of constant
propagation and dead code elimination to speed up our compiles and
reduce WTFs / minute.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor): Removed special handling of globals.
(JSC::BytecodeGenerator::shouldOptimizeLocals): Don't optimize locals in
global code, since there are none.
(JSC::BytecodeGenerator::canOptimizeNonLocals): Do optimize non-locals
in global code (i.e., global vars), since there are some.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
* interpreter/Interpreter.h: Updated for deleted / renamed code.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
(JSC::RegisterFile::releaseExcessCapacity): Updated for deleted / renamed
data members.
* interpreter/RegisterFile.h:
(JSC::RegisterFile::begin):
(JSC::RegisterFile::size):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink): Removed all code and comments dealing with
global variables stored in the register file.
(JSC::RegisterFile::grow): Updated for same.
Also, a slight correctness fix: Test the VM commit end, and not just the
in-use end, when checking for stack overflow. In theory, it's invalid to
commit past the end of your allocation, even if you never touch that
memory. This makes the usable size of the stack slightly smaller. No test
because we don't know of any case in practice where this crashes.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Updated for changes above.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::resizeRegisters):
(JSC::JSGlobalObject::addStaticGlobals):
* runtime/JSGlobalObject.h: Simplified globals to have monotonically
increasing indexes, always located in our external storage.
2011-06-21 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r89401 and r89403.
http://trac.webkit.org/changeset/89401
http://trac.webkit.org/changeset/89403
https://bugs.webkit.org/show_bug.cgi?id=62970
Breaks mac build and mistakenly enables the spellcheck API
* Configurations/FeatureDefines.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-21 Kent Tamura <tkent@chromium.org>
[Mac] Sort Xcode project files.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck API should be build-able.
https://bugs.webkit.org/show_bug.cgi?id=62970
No new tests, changing only build related files
* Configurations/FeatureDefines.xcconfig:
2011-06-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved 'const' off the global-variable-as-local-variable crack pipe
https://bugs.webkit.org/show_bug.cgi?id=63105
This is necessary for moving the rest of the code off of same.
Many problems remain in our handling of const. I have fixed none of them.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::scopeChain): New accessor, needed to enable
const to directly implement its unique scoping rules.
* bytecompiler/NodesCodegen.cpp:
(JSC::PrefixResolveNode::emitBytecode): Do specify that our resolve is
for writing, so we don't overwrite const variables.
(JSC::ConstDeclNode::emitCodeSingle): Don't assume that all declared const
variables are available as local variables, since this won't be the case
once global variables are not available as local variables. Instead, use
put_scoped_var in the case where there is no local variable. Like a local
variable, put_scoped_var succeeds even though const properties are
read-only, since put_scoped_var skips read-only checks. (Yay?)
2011-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=63052
Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.
* parser/JSParser.cpp:
(JSC::JSParser::updateErrorMessage):
(JSC::JSParser::updateErrorWithNameAndMessage):
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed.
Rolled out r89233 and r89235 because of crashes in http/tests/misc/acid3.html on Snow Leopard and other platforms
https://bugs.webkit.org/show_bug.cgi?id=63022
* wtf/Platform.h:
2011-06-18 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Disallow assigning into PassOwnArrayPtr, PassOwnPtr and PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=62940
Remove clear() and all assignment operators except one which now has a COMPILE_ASSERT.
* wtf/PassOwnArrayPtr.h:
(WTF::PassOwnArrayPtr::operator=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator=):
* wtf/PassRefPtr.h:
(WTF::PassRefPtr::operator=):
(WTF::NonNullPassRefPtr::operator=):
2011-06-20 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION (r79060): Searching for a flight at united.com fails
https://bugs.webkit.org/show_bug.cgi?id=63003
This original change also broke Twitter, and we attempted to refine the fix to
address that problem (http://trac.webkit.org/changeset/80542), but since it still breaks United,
we need to revert the change until we understand the problem better.
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
2011-06-20 Juan C. Montemayor <jmont@apple.com>
Reviewed by Oliver Hunt.
No context for javascript parse errors.
https://bugs.webkit.org/show_bug.cgi?id=62613
Parse errors now show more details like:
"Unexpected token: ]"
or
"Expected token: while"
For reserved names, numbers, indentifiers, strings, lexer errors,
and EOFs, the following error messages are printed:
"Use of reserved word: super"
"Unexpected number: 42"
"Unexpected identifier: "
"Unexpected string: "foobar""
"Invalid token character sequence: \u4023"
"Unexpected EOF"
* parser/JSParser.cpp:
(JSC::JSParser::consume):
(JSC::JSParser::getToken):
(JSC::JSParser::getTokenName):
(JSC::JSParser::updateErrorMessageSpecialCase):
(JSC::JSParser::updateErrorMessage):
(JSC::JSParser::updateErrorWithNameAndMessage):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseForStatement):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseStatement):
(JSC::JSParser::parseFormalParameters):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parsePrimaryExpression):
(JSC::JSParser::parseMemberExpression):
(JSC::JSParser::parseUnaryExpression):
* parser/JSParser.h:
* parser/Lexer.cpp:
(JSC::Lexer::lex):
* parser/Parser.cpp:
(JSC::Parser::parse):
2011-06-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
* wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.
2011-06-19 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Correct logic for putting errors on the correct line when handling JSONP
https://bugs.webkit.org/show_bug.cgi?id=62962
Minor fix for the minor fix. *sigh*
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
2011-06-19 Oliver Hunt <oliver@apple.com>
Minor fix to correct layout test results.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
2011-06-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920
JSONP has unfortunately become a fairly common idiom online, yet
it triggers very poor performance in JSC as we end up doing codegen
for a large number of property accesses that will
* only be run once, so the vast amount of logic we dump to handle
caching of accesses is unnecessary.
* We are doing codegen that is directly proportional to just
creating the object in the first place.
This patch extends the use of the literal parser to JSONP-like structures
in global code, handling a number of different forms I have seen online.
In an extreme case this improves performance of JSONP by more than 2x
due to removal of code generation and execution time, and a few optimisations
that I made to the parser itself.
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
(JSC::Lexer::isKeyword):
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::makeIdentifier):
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::next):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89184.
http://trac.webkit.org/changeset/89184
https://bugs.webkit.org/show_bug.cgi?id=62927
It broke 22 tests on all bot (Requested by Ossy_weekend on
#webkit).
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
(JSC::LiteralParser::Lexer::next):
2011-06-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920
JSONP has unfortunately become a fairly common idiom online, yet
it triggers very poor performance in JSC as we end up doing codegen
for a large number of property accesses that will
* only be run once, so the vast amount of logic we dump to handle
caching of accesses is unnecessary.
* We are doing codegen that is directly proportional to just
creating the object in the first place.
This patch extends the use of the literal parser to JSONP-like structures
in global code, handling a number of different forms I have seen online.
In an extreme case this improves performance of JSONP by more than 2x
due to removal of code generation and execution time, and a few optimisations
that I made to the parser itself.
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
(JSC::Lexer::isKeyword):
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::makeIdentifier):
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::next):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
2011-06-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved some property access JIT code into property access JIT files
https://bugs.webkit.org/show_bug.cgi?id=62906
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
2011-06-17 Anders Carlsson <andersca@apple.com>
Build fix.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-17 Geoffrey Garen <ggaren@apple.com>
Try to fix the Leopard build?
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added some write barrier action, compiled out by default
https://bugs.webkit.org/show_bug.cgi?id=62844
* JavaScriptCore.exp: Build!
* JavaScriptCore.xcodeproj/project.pbxproj: Fixed an incremental build
issue with Heap.cpp.
* heap/Heap.cpp:
(JSC::Heap::writeBarrierSlowCase):
* heap/Heap.h:
(JSC::Heap::writeBarrier):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::isAtomAligned):
(JSC::MarkedBlock::blockFor):
(JSC::MarkedBlock::atomNumber):
(JSC::MarkedBlock::ownerSetNumber):
(JSC::MarkedBlock::addOldSpaceOwner):
(JSC::MarkedBlock::OwnerSet::OwnerSet):
(JSC::MarkedBlock::OwnerSet::add):
(JSC::MarkedBlock::OwnerSet::clear):
(JSC::MarkedBlock::OwnerSet::size):
(JSC::MarkedBlock::OwnerSet::didOverflow):
(JSC::MarkedBlock::OwnerSet::owners): Added a basic write barrier that
tracks owners for regions within blocks. Currently unused.
2011-06-17 Raphael Kubo da Costa <kubo@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Add some OwnPtr specializations for EFL types.
For now there are specializations for Ecore_Evas and Evas_Object.
https://bugs.webkit.org/show_bug.cgi?id=62877
* wtf/CMakeListsEfl.txt:
* wtf/OwnPtrCommon.h:
* wtf/efl/OwnPtrEfl.cpp: Added.
(WTF::deleteOwnedPtr):
2011-06-17 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Replace GdkRectangle by cairo_rectangle_int_t
https://bugs.webkit.org/show_bug.cgi?id=60687
Replace GdkRectangle by cairo_rectangle_int_t.
* wtf/gobject/GTypedefs.h: Replace GdkRectangle by cairo_rectangle_int_t.
2011-06-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=53014
ES5 strict mode keyword restrictions aren't implemented
The following are future restricted words is strict mode code:
implements, interface, let, package, private, protected, public, static, yield
* parser/JSParser.h:
- Add RESERVED_IF_STRICT token.
* parser/Keywords.table:
- Add new future restricted words.
* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
- Check for RESERVED_IF_STRICT; in nonstrict code this is converted to IDENT.
(JSC::Lexer::lex):
- Pass strictMode flag to parseIdentifier.
* parser/Lexer.h:
- parseIdentifier needs a strictMode flag.
* runtime/CommonIdentifiers.h:
- Add identifiers for new reserved words.
2011-06-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23611
Multiline Javascript comments cause incorrect parsing of following script.
From the spec:
"A MultiLineComment [is] simply discarded if it contains no line terminator,
but if a MultiLineComment contains one or more line terminators, then it is
replaced with a single line terminator, which becomes part of the stream of
inputs for the syntactic grammar."
This may result in behavioural changes, due to automatic semicolon insertion.
* parser/Lexer.cpp:
(JSC::Lexer::parseMultilineComment):
- Set m_terminator is we see a line terminator in a multiline comment.
2011-06-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=62824
DFG JIT - add support for branch-fusion of compareEq, JSValue comparisons in SpeculativeJIT
CompareEq of non-integer values is the most common cause of speculation failure.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
- Support Equals.
(JSC::DFG::SpeculativeJIT::compilePeepHoleEq):
- new! - peephole optimized Eq of JSValues.
(JSC::DFG::SpeculativeJIT::compile):
- Add peephole optimization for CompareEq.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
- Add support for dead nodes between compare & branch.
(JSC::DFG::SpeculativeJIT::isInteger):
- Added to determine which form of peephole to do in CompareEq.
2011-06-16 Geoffrey Garen <ggaren@apple.com>
Try to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export another
symbol.
* bytecode/EvalCodeCache.h:
* heap/HandleHeap.h:
* heap/HeapRootVisitor.h:
* heap/NewSpace.h:
* runtime/ArgList.h:
* runtime/ScopeChain.h:
* runtime/SmallStrings.h:
* runtime/Structure.h: Stop forward-declaring things that don't really
exist anymore.
2011-06-16 Geoffrey Garen <ggaren@apple.com>
Try to fix the Mac build: Removed and re-added SlotVisitor.h to the Xcode
project while crossing my fingers and facing west.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-16 Geoffrey Garen <ggaren@apple.com>
Build fix: Removed an incorrect symbol on Windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-06-16 Geoffrey Garen <ggaren@apple.com>
Build fix: Removed an accidental commit from the future.
* CMakeLists.txt:
2011-06-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Introduced SlotVisitor into the project
https://bugs.webkit.org/show_bug.cgi?id=62820
This resolves a class vs typedef forward declaration issue, and gives all
exported symbols the correct names.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj: Build!
* bytecode/EvalCodeCache.h:
* heap/HandleHeap.h:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/HeapRootVisitor.h: Replaced MarkStack with SlotVisitor. Now no
clients operate on a MarkStack.
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):
* heap/SlotVisitor.h: Added.
(JSC::SlotVisitor::SlotVisitor): Used 'protected' and a little cheesy
inheritance to give SlotVisitor all the attributes of MarkStack without
making this change giant. Over time, we will move more behavior into
SlotVisitor and its subclasses.
* heap/MarkStack.h:
* heap/NewSpace.h: Replaced MarkStack with SlotVisitor. Now no
clients operate on a MarkStack.
* runtime/ArgList.h:
* runtime/JSCell.h:
* runtime/JSObject.h:
* runtime/ScopeChain.h:
* runtime/SmallStrings.h:
* runtime/Structure.h: Replaced MarkStack with SlotVisitor. Now no
clients operate on a MarkStack.
2011-06-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Reduce memory usage of resolve_global
https://bugs.webkit.org/show_bug.cgi?id=62765
If we have a large number of resolve_globals in a single
block start planting plain resolve instructions instead
whenever we aren't in a loop. This allows us to reduce
the code size for extremely large functions without
losing the performance benefits of op_resolve_global.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::globalResolveInfoCount):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::shouldAvoidResolveGlobal):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
* bytecompiler/BytecodeGenerator.h:
2011-06-16 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix building with CONFIG(use_system_icu)
https://bugs.webkit.org/show_bug.cgi?id=62744
Do not define WTF_USE_QT4_UNICODE if WTF_USE_ICU_UNICODE is set.
* wtf/Platform.h:
2011-06-15 Darin Adler <darin@apple.com>
Reviewed by Adam Barth.
Remove obsolete LOOSE_OWN_PTR code
https://bugs.webkit.org/show_bug.cgi?id=59909
The internal Apple dependency on this is gone now.
* wtf/OwnArrayPtr.h: Removed constructor that takes a raw pointer,
set function that takes a raw pointer.
* wtf/OwnPtr.h: Removed constructor that takes a raw pointer,
set functino that takes a raw pointer.
* wtf/PassOwnArrayPtr.h: Made constructor that takes a nullptr
and assignment operator that takes a nullptr unconditional.
Made constructor that takes a raw pointer private and explicit,
and removed assignment operator that takes a raw pointer.
* wtf/PassOwnPtr.h: Made assignment operator that takes a nullptr
unconditional. Made constructor that takes a raw pointer private
and explicit, and removed assignment operator that takes a raw pointer.
2011-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Gavin Barraclough.
Make access-nseive ~9x faster on the non-speculative path by
adding special casing for doubles that can lossless-ly be converted
to a uint32_t in getByVal and putByVal. This avoids calls to stringification
and the hash lookup. Long term, we should try and get property of a getByVal
and putByVal to be an integer immediate even in the non-speculative path.
* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):
2011-06-15 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION (r88719): 5by5.tv schedule is not visible
https://bugs.webkit.org/show_bug.cgi?id=62720
Problem here is that the lexer wasn't considering '$' to be
a valid character in an identifier.
* parser/Lexer.h:
(JSC::Lexer::lexExpectIdentifier):
2011-06-15 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Reduce the size of global_resolve
https://bugs.webkit.org/show_bug.cgi?id=62738
Reduce the code size of global_resolve in the JIT by replacing
multiple pointer loads with a single pointer move + two offset
loads.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global):
2011-06-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Dan Bernstein.
Fixed an inavlid ASSERT I found while investigating
<rdar://problem/9580254> Crash in JSC::HandleHeap::finalizeWeakHandles + 92
https://bugs.webkit.org/show_bug.cgi?id=62699
No test since we don't know of a way to get WebCore to deallocate the
next-to-finalize handle, which is also the last handle in the list,
while finalizing the second-to-last handle in the list.
* heap/HandleHeap.h:
(JSC::HandleHeap::deallocate): Don't ASSERT that m_nextToFinalize has a
non-0 next() after updating it, since it is valid to update m_nextToFinalize
to point to the tail sentinel.
Do ASSERT that m_nextToFinalize has a non-0 next() before updating it,
since it is not valid to update m_nextToFinalize to point past the tail
sentinel.
Also, use m_nextToFinalize consistently for clarity.
2011-06-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=43841
SegmentedVector::operator== typo
* wtf/SegmentedVector.h:
(WTF::SegmentedVectorIterator::operator==):
(WTF::SegmentedVectorIterator::operator!=):
2011-06-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658
Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addImmediateBuffer):
(JSC::CodeBlock::immediateBuffer):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addImmediateBuffer):
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_buffer):
* jit/JITOpcodes32_64.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88841.
http://trac.webkit.org/changeset/88841
https://bugs.webkit.org/show_bug.cgi?id=62672
Caused many tests to crash (Requested by rniwa on #webkit).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_new_array):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
2011-06-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658
Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addImmediateBuffer):
(JSC::CodeBlock::immediateBuffer):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addImmediateBuffer):
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_buffer):
* jit/JITOpcodes32_64.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
2011-06-14 Stephanie Lewis <slewis@apple.com>
Rubber stamped by Oliver Hunt.
<rdar://problem/9511169>
Update order files.
* JavaScriptCore.order:
2011-06-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix dumping of constants to have the correct constant number.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
2011-06-14 Benjamin Poulain <benjamin@webkit.org>
Reviewed by Eric Seidel.
KeywordLookupGenerator's Trie does not work with Python 3
https://bugs.webkit.org/show_bug.cgi?id=62635
With Python 3, dict.items() return an iterator. Since the iterator
protocol changed between Python 2 and 3, the easiest way to get the
values is to have something that use the iterator implicitely, like a
for() loop.
* KeywordLookupGenerator.py:
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix llocp and lvalp names in the lexer to something more meaningful
https://bugs.webkit.org/show_bug.cgi?id=62605
A simple rename
* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseString):
(JSC::Lexer::lex):
* parser/Lexer.h:
(JSC::Lexer::lexExpectIdentifier):
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make it possible to inline the common case of identifier lexing
https://bugs.webkit.org/show_bug.cgi?id=62600
Add a lexing function that expects to lex an "normal" alpha numeric
identifier (that ignores keywords) so it's possible to inline the
common parsing cases. This comes out as a reasonable parsing speed
boost.
* parser/JSParser.cpp:
(JSC::JSParser::nextExpectIdentifier):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):
* parser/Lexer.cpp:
* parser/Lexer.h:
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
* GNUmakefile.am:
* GNUmakefile.list.am:
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Make it possible to inline Identifier::equal
https://bugs.webkit.org/show_bug.cgi?id=62584
Move Identifier::equal to the Identifier header file.
* runtime/Identifier.cpp:
* runtime/Identifier.h:
(JSC::Identifier::equal):
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
* Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
* Configurations/FeatureDefines.xcconfig:
2011-06-12 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for !ENABLE(JIT) after r88604.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
2011-06-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=16777
Remove #define NaN per Darin's comments.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):
* wtf/DateMath.cpp:
(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):
2011-06-11 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches
The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):
* jit/JIT.h:
* jit/JITCall.cpp:
* jit/JITCall32_64.cpp:
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
* wtf/Platform.h:
2011-06-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf
There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.
Remove JSC::Inf, JSC::NaN, switch some cases of (isnan || isinf) to !isfinite.
* API/JSCallbackObjectFunctions.h:
(JSC::::toNumber):
* API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
* JavaScriptCore.exp:
* runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toNumber):
* runtime/JSValue.cpp:
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
* runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
* runtime/NumberConstructor.cpp:
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
* runtime/UString.cpp:
* wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
* wtf/dtoa.cpp:
(WTF::dtoa):
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
* Configurations/FeatureDefines.xcconfig:
2011-06-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype
This arises from chapter 15 of the spec:
"Every other property described in this clause has the attributes
{ [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }
unless otherwise specified."
Standardized properties are not enumerable.
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Build fix: Corrected header spelling.
* heap/OldSpace.h:
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added OldSpace to the project
https://bugs.webkit.org/show_bug.cgi?id=62417
Currently unused.
Added OldSpace, the ability to iterate NewSpace vs OldSpace, and a
per-block flag for testing whether you're in NewSpace vs OldSpace.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Build!
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::inNewSpace):
(JSC::MarkedBlock::setInNewSpace): Added inNewSpace flag, for use in
write barrier.
* heap/NewSpace.cpp:
(JSC::NewSpace::addBlock):
(JSC::NewSpace::removeBlock):
* heap/NewSpace.h:
(JSC::NewSpace::forEachBlock): Added forEachBlock, to use for
NewSpace-specific operations.
* heap/OldSpace.cpp: Added.
(JSC::OldSpace::OldSpace):
(JSC::OldSpace::addBlock):
(JSC::OldSpace::removeBlock):
* heap/OldSpace.h: Added.
(JSC::OldSpace::forEachBlock): New class for holding promoted blocks.
Not in use yet.
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add PLATFORM(EFL) to enable ACCELERATED_COMPOSITING on EFL port.
* wtf/Platform.h:
2011-06-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 62405 - Fix integer overflow in Array.prototype.push
Fix geoff's review comments re static_cast.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Factored MarkedBlock set management into a helper class with a fast case Bloom filter
https://bugs.webkit.org/show_bug.cgi?id=62413
SunSpider reports a small speedup.
This is in preparation for having ConservativeSet operate on arbitrary
sets of MarkedBlocks, and in preparation for conservative scanning
becoming proportionally more important than other GC activities.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj: Build-o.
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::add):
* heap/ConservativeRoots.h:
(JSC::ConservativeRoots::ConservativeRoots): Operate on a MarkedBlockSet
directly, instead of a Heap, so we can operate on subsets of the Heap
instead.
Use a TinyBloomFilter for single-cycle exclusion of most pointers. This
is particularly important since we expect not to find our subject pointer
in the MarkedBlock hash, and hash misses are more expensive than typical
hash lookups because they have high collision rates.
No need for single-pointer add() to be public anymore, since nobody uses it.
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock): Use MarkedBlockSet since that's what
ConservativeRoots relies on.
Nixed contains(), since nobody uses it anymore.
* heap/MarkedBlock.h:
(WTF::MarkedBlockHash::hash): Added a faster hash taking advantage of
the VM layout properties of MarkedBlocks.
* heap/MarkedBlockSet.h: Added.
(JSC::MarkedBlockSet::add):
(JSC::MarkedBlockSet::remove):
(JSC::MarkedBlockSet::recomputeFilter):
(JSC::MarkedBlockSet::filter):
(JSC::MarkedBlockSet::set):
* heap/TinyBloomFilter.h: Added.
(JSC::TinyBloomFilter::TinyBloomFilter):
(JSC::TinyBloomFilter::add):
(JSC::TinyBloomFilter::ruleOut): New helper class, used above.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots): No need to specifically
exclude values by tag -- the tiny bloom filter is already a register-register
compare, so adding another "rule out" factor just slows things down.
2011-06-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 62405 - Fix integer overflow in Array.prototype.push
There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.
Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.
These errors result in three test-262 failures.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
* runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::push):
2011-06-09 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Add Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393
* wtf/Vector.h:
(WTF::Vector::reverse): Added
2011-06-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Factored a bunch of Heap functionality into stand-alone functors
https://bugs.webkit.org/show_bug.cgi?id=62337
This is in preparation for making these functors operate on arbitrary
sets of MarkedBlocks.
* JavaScriptCore.exp: This file is a small tragedy.
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated for type change and rename.
* heap/HandleHeap.h:
(JSC::HandleHeap::forEachStrongHandle): New function for iterating all
strong handles, so we can play along in the functor game.
* heap/Heap.cpp:
(JSC::CountFunctor::CountFunctor::CountFunctor):
(JSC::CountFunctor::CountFunctor::count):
(JSC::CountFunctor::CountFunctor::returnValue):
(JSC::CountFunctor::ClearMarks::operator()):
(JSC::CountFunctor::ResetAllocator::operator()):
(JSC::CountFunctor::Sweep::operator()):
(JSC::CountFunctor::MarkCount::operator()):
(JSC::CountFunctor::Size::operator()):
(JSC::CountFunctor::Capacity::operator()):
(JSC::CountFunctor::Count::operator()):
(JSC::CountFunctor::CountIfGlobalObject::operator()):
(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::CountFunctor::RecordType::RecordType):
(JSC::CountFunctor::RecordType::typeName):
(JSC::CountFunctor::RecordType::operator()):
(JSC::CountFunctor::RecordType::returnValue): These functors factor out
behavior that used to be in the functions below.
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink): Factored out behavior into the functors above.
* heap/Heap.h:
(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock): Added forEach* iteration templates. I chose
functor-based templates instead of plain iterators because they're simpler
to implement in this case and they require a lot less code at the call site.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::VoidFunctor::returnValue): Default parent class for
trivial functors.
(JSC::MarkedBlock::forEachCell): Renamed forEach to forEachCell because
we have a few different kind of "for each" now.
* runtime/JSGlobalData.cpp:
(WTF::Recompile::operator()):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::recompileAllJSFunctions): Updated for type change and rename.
* runtime/JSGlobalData.h: Removed globalObjectCount because it was unused.
2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Pavel Feldman.
Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791
No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
export 2 functions DecimalNumber::bufferLengthForStringExponential and
DecimalNumber::toStringExponential.
2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88404.
http://trac.webkit.org/changeset/88404
https://bugs.webkit.org/show_bug.cgi?id=62342
broke win and mac build (Requested by tony^work on #webkit).
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-06-08 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
[chromium] use gyp 'settings' type for settings target
https://bugs.webkit.org/show_bug.cgi?id=62323
The 'settings' gyp target type is for targets that exist solely
for their settings (no build rules). The comment above this target
says it's for this, but it incorrectly uses 'none'.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-06-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Mihai Parparita.
Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756
Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.
* wtf/Platform.h:
2011-06-08 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add faster lookup cache for multi character identifiers
https://bugs.webkit.org/show_bug.cgi?id=62327
Add a non-hash lookup for mutiple character identifiers. This saves us from
adding repeated identifiers to the ParserArena's identifier list as people
tend to not start all their variables and properties with the same character
and happily identifier locality works in our favour.
* parser/ParserArena.h:
(JSC::IdentifierArena::isEmpty):
(JSC::IdentifierArena::clear):
(JSC::IdentifierArena::makeIdentifier):
2011-06-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Took some responsibilities away from NewSpace
https://bugs.webkit.org/show_bug.cgi?id=62325
NewSpace is basically just an allocator now.
Heap acts as a controller, responsible for managing the set of all
MarkedBlocks.
This is in preparation for moving parts of the controller logic into
separate helper classes that can act on arbitrary sets of MarkedBlocks
that may or may not be in NewSpace.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocate):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::collect):
(JSC::Heap::resetAllocator):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink): Moved the set of MarkedBlocks from NewSpace to Heap,
along with all functions that operate on the set of MarkedBlocks. Also
moved responsibility for deciding whether to allocate a new MarkedBlock,
and for allocating it.
* heap/Heap.h:
(JSC::Heap::contains):
(JSC::Heap::forEach): Ditto.
* heap/NewSpace.cpp:
(JSC::NewSpace::addBlock):
(JSC::NewSpace::removeBlock):
(JSC::NewSpace::resetAllocator):
* heap/NewSpace.h:
(JSC::NewSpace::waterMark):
(JSC::NewSpace::allocate): Ditto.
2011-06-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Some more MarkedSpace => NewSpace renaming
https://bugs.webkit.org/show_bug.cgi?id=62305
* JavaScriptCore.exp:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::allocate):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::collect):
(JSC::Heap::isValidAllocation):
* heap/Heap.h:
(JSC::Heap::markedSpace):
(JSC::Heap::contains):
(JSC::Heap::forEach):
(JSC::Heap::allocate):
* runtime/JSCell.h:
2011-06-08 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Add export macros to profiler headers.
https://bugs.webkit.org/show_bug.cgi?id=27551
* profiler/Profiler.h:
2011-06-08 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Add export symbols to parser headers.
https://bugs.webkit.org/show_bug.cgi?id=27551
* parser/SourceProviderCache.h:
2011-06-08 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Add export symbols to interpreter headers.
https://bugs.webkit.org/show_bug.cgi?id=27551
* interpreter/Interpreter.h:
2011-06-08 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Add export symbols to debugger headers.
https://bugs.webkit.org/show_bug.cgi?id=27551
* debugger/Debugger.h:
* debugger/DebuggerCallFrame.h:
2011-06-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved MarkedSpace.* to NewSpace.* in preparation for more renaming
https://bugs.webkit.org/show_bug.cgi?id=62268
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.h:
* heap/MarkedBlock.h:
* heap/MarkedSpace.cpp: Removed.
* heap/MarkedSpace.h: Removed.
* heap/NewSpace.cpp: Copied from Source/JavaScriptCore/heap/MarkedSpace.cpp.
* heap/NewSpace.h: Copied from Source/JavaScriptCore/heap/MarkedSpace.h.
2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88365.
http://trac.webkit.org/changeset/88365
https://bugs.webkit.org/show_bug.cgi?id=62301
windows bots broken (Requested by loislo_ on #webkit).
* JavaScriptCore.exp:
2011-06-08 Ryan Sleevi <rsleevi@chromium.org>
Reviewed by Tony Chang.
Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-06-08 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
Webkit on SPARC Solaris has wrong endian
https://bugs.webkit.org/show_bug.cgi?id=29407
Bug 57256 fixed one crash on misaligned reads on sparc/solaris, but
there are more ocurrences of the same code pattern in webkit.
This patch includes the check on these other parts of the code.
This is a speculative fix, I don't have a sparc machine to test and
don't know which kind of test would trigger a crash (but it's quite
obvious that it's the same code duplicated in different files).
* runtime/UString.h:
(JSC::UStringHash::equal):
* wtf/text/StringHash.h:
(WTF::StringHash::equal):
2011-06-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280
Remove CONFIG=staticlib, because it causes the configure script to add -ljavascriptcore
into QtWebKit.prl.
No new tests, as this is just a build fix.
* JavaScriptCore.pri:
2011-06-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split 'reset' into 'collect' and 'resetAllocator'
https://bugs.webkit.org/show_bug.cgi?id=62267
* heap/Heap.cpp:
(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/MarkedBlock.h:
(JSC::MarkedBlock::resetAllocator):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::resetAllocator):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::SizeClass::resetAllocator):
2011-06-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Renamed some more marks to visits
https://bugs.webkit.org/show_bug.cgi?id=62254
* heap/HandleHeap.cpp:
(JSC::HandleHeap::visitStrongHandles):
(JSC::HandleHeap::visitWeakHandles):
* heap/HandleHeap.h:
* heap/HandleStack.cpp:
(JSC::HandleStack::visit):
* heap/HandleStack.h:
* heap/Heap.cpp:
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markRoots):
* heap/HeapRootVisitor.h:
(JSC::HeapRootVisitor::visit):
* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::markLists):
2011-06-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=55537
Functions claim to have 'callee' which they actually don't (and shouldn't)
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyNames):
2011-06-07 Juan C. Montemayor <jmont@apple.com>
Reviewed by Darin Adler.
Make JSStaticFunction and JSStaticValue less "const"
https://bugs.webkit.org/show_bug.cgi?id=62222
* API/JSObjectRef.h:
* API/tests/testapi.c:
(checkConstnessInJSObjectNames):
(main):
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=62240
DFG JIT - add support for for-loop array initialization.
Support put by val beyond vector length.
Add a operationPutByValBeyondArrayBounds operation, make
PutValVal call this if the vector length check fails.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::isDoubleConstantWithInt32Value):
(JSC::DFG::JITCodeGenerator::isJSConstantWithInt32Value):
(JSC::DFG::JITCodeGenerator::isIntegerConstant):
(JSC::DFG::JITCodeGenerator::valueOfIntegerConstant):
* dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
2011-06-06 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743
* wtf/CurrentTime.cpp: Add monotonicallyIncreasingTime() for mac and a fallback implementation that just wraps currentTime().
(WTF::monotonicallyIncreasingTime):
* wtf/CurrentTime.h: Add monotonicallyIncreasingTime().
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
* Configurations/FeatureDefines.xcconfig:
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
* Configurations/FeatureDefines.xcconfig:
2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix the GTK+ build.
* GNUmakefile.am: Add javascriptcore_cflags variable.
2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
to build on Mac.
* wtf/Platform.h:
2011-06-04 Gustavo Noronha Silva <gns@gnome.org>
Unreviewed, MIPS build fix.
WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691
* GNUmakefile.list.am: Add missing MIPS-related file to the list
of files that are added to the tarball on make dist, and fix
sorting.
2011-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix formatting of the output generated by KeywordLookupGenerator.py
https://bugs.webkit.org/show_bug.cgi?id=62083
- Uses correct year for copyright.
- Puts ending brace on same line as "else if"
- Puts starting brace of function on its own line.
- Adds some tasteful whitespace.
- Adds comments to make clear that scopes are ending
- Make macros actually split on two lines.
* KeywordLookupGenerator.py:
2011-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
KeywordLookupGenerator.py spams stdout in Chromium Linux build
https://bugs.webkit.org/show_bug.cgi?id=62087
This action does not appear to be needed.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Lexer needs to provide Identifier for reserved words
https://bugs.webkit.org/show_bug.cgi?id=62086
Alas it is necessary to provide an Identifier reference for keywords
so that we can do the right thing when they're used in object literals.
We now keep Identifiers for all reserved words in the CommonIdentifiers
structure so that we can access them without a hash lookup.
* KeywordLookupGenerator.py:
* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
* parser/Lexer.h:
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
* runtime/CommonIdentifiers.h:
2011-06-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Add debug code to break on speculation failures.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGNode.h:
2011-06-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=62082
DFG JIT - bug passing arguments that need swap
This is really just a typo.
When setting up the arguments for a call out to a C operation, we'll
fail to swap arguments where this is necessary. For example, in the
case of 2 arg calls, where the first argument is in %rdx & the second
is in %rsi we should swap (exec will be passed in %rdi), but we don't.
This can also affect function calls passing three arguments.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
- Call swap with the correct arguments.
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Force inlining of some hot lexer functions
https://bugs.webkit.org/show_bug.cgi?id=62079
Fix more GCC stupidity
* parser/Lexer.h:
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
GCC not inlining some functions that it really should be
https://bugs.webkit.org/show_bug.cgi?id=62075
Add ALWAYS_INLINE to a number of parsing and lexing functions
that should always be inlined. This gets us ~1.4% on my ad hoc
parser test.
* KeywordLookupGenerator.py:
* parser/JSParser.cpp:
(JSC::JSParser::next):
(JSC::JSParser::nextTokenIsColon):
(JSC::JSParser::consume):
(JSC::JSParser::match):
(JSC::JSParser::tokenStart):
(JSC::JSParser::tokenLine):
(JSC::JSParser::tokenEnd):
* parser/Lexer.cpp:
(JSC::isIdentPart):
2011-06-03 Oliver Hunt <oliver@apple.com>
Whoops, fix last minute bug.
* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Try to fix the GTK+ build.
* GNUmakefile.am: Clean up some spaces that should be tabs.
* GNUmakefile.list.am: Add KeywordLookup.h to the source list
and clean up some spaces that should be tabs.
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve keyword lookup
https://bugs.webkit.org/show_bug.cgi?id=61913
Rather than doing multiple hash lookups as we currently
do when trying to identify keywords we now use an
automatically generated decision tree (essentially it's
a hard coded patricia trie). We still use the regular
lookup table for the last few characters of an input as
this allows us to completely skip all bounds checks.
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pro:
* GNUmakefile.am:
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* KeywordLookupGenerator.py: Added.
* make-generated-sources.sh:
* parser/Lexer.cpp:
(JSC::Lexer::internalShift):
(JSC::Lexer::shift):
(JSC::Lexer::parseIdentifier):
* parser/Lexer.h:
2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786
Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.
* JavaScriptCore.pri: Support for use_system_icu CONFIG flag.
* wtf/unicode/qt4/UnicodeQt4.h: Guard an include file with USE(ICU_UNICODE).
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957
When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=. This patch unbreak r87950 on Mac for Qt port.
* JavaScriptCore.pro:
2011-06-02 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Added a method to generate RFC 2822 compliant date strings.
https://bugs.webkit.org/show_bug.cgi?id=7169
* wtf/DateMath.cpp:
(WTF::twoDigitStringFromNumber):
(WTF::makeRFC2822DateString):
* wtf/DateMath.h:
2011-06-02 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957
When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks.
* JavaScriptCore.pro:
2011-06-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add single character lookup cache to IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=61879
Add a simple lookup cache for single ascii character
identifiers. Produces around a 2% improvement in parse
time for my adhoc parser test.
* parser/ParserArena.h:
(JSC::IdentifierArena::IdentifierArena):
(JSC::IdentifierArena::clear):
(JSC::IdentifierArena::makeIdentifier):
2011-05-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Freezing a function and its prototype causes browser to crash.
https://bugs.webkit.org/show_bug.cgi?id=61758
Make JSObject::preventExtensions virtual so that we can override it
and instantiate all lazy
* JavaScriptCore.exp:
* runtime/JSFunction.cpp:
(JSC::createPrototypeProperty):
(JSC::JSFunction::preventExtensions):
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::seal):
(JSC::JSObject::seal):
2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856
breaks windows chromium canary (Requested by jknotten on
#webkit).
* wtf/DateMath.cpp:
(WTF::timeClip):
* wtf/DateMath.h:
2011-06-01 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Added a method to generate RFC 2822 compliant date strings.
https://bugs.webkit.org/show_bug.cgi?id=7169
* wtf/DateMath.cpp:
(WTF::twoDigitStringFromNumber):
(WTF::makeRFC2822DateString):
* wtf/DateMath.h:
2011-05-31 Yong Li <yoli@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.
No new test added because this change is not known to fix any issue.
* bytecode/StructureStubInfo.h:
2011-05-30 Hojong Han <hojong.han@samsung.com>
Reviewed by Geoffrey Garen.
[JSC] malfunction during arithmetic condition check with negative number (-2147483648)
https://bugs.webkit.org/show_bug.cgi?id=61416
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch32):
* tests/mozilla/ecma/Expressions/11.12-1.js:
(getTestCases):
2011-05-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Some heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=61704
SunSpider says no change.
* JavaScriptCore.exp: Export!
* heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.
(JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.
(JSC::Heap::allocate): Changed inline allocation code to only select the
size class, since this can be optimized out at compile time -- everything
else is now inlined into this out-of-line function.
No need to duplicate ASSERTs made in our caller.
* heap/Heap.h:
(JSC::Heap::heap):
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::testAndClearMarked):
(JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding
a layer of indirection through MarkedSpace.
(JSC::Heap::allocate): See above.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::allocateBlock):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::allocate): Updated to match changes above.
2011-05-28 David Kilzer <ddkilzer@apple.com>
BUILD FIX when building only the interpreter
Fixes the following compiler warning:
JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]
void releaseExecutableMemory(JSGlobalData& globalData)
^
* jit/ExecutableAllocator.h: Moved declaration of
JSC::releaseExecutableMemory().
2011-05-28 David Kilzer <ddkilzer@apple.com>
BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode): Added missing argument.
2011-05-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
JS API is too aggressive about throwing exceptions for NULL get or set operations
https://bugs.webkit.org/show_bug.cgi?id=61678
* API/JSCallbackObject.h: Changed our staticValueGetter to a regular
function that returns a JSValue, so it can fail and still forward to
normal property lookup.
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot): Don't throw an exception when failing to
access a static property -- just forward the access. This allows objects
to observe get/set operations but still let the JS object manage lifetime.
(JSC::::put): Ditto.
(JSC::::getStaticValue): Same as JSCallbackObject.h.
* API/tests/testapi.c:
(MyObject_set_nullGetForwardSet):
* API/tests/testapi.js: Updated tests to reflect slightly less strict
behavior, which matches headerdoc claims.
2011-05-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Property caching is too aggressive for API objects
https://bugs.webkit.org/show_bug.cgi?id=61677
* API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our
callback APIs allow the client to change its mind about our propertis at
any time.
* API/tests/testapi.c:
(PropertyCatchalls_getProperty):
(PropertyCatchalls_setProperty):
(PropertyCatchalls_getPropertyNames):
(PropertyCatchalls_class):
(main):
* API/tests/testapi.js: Some tests for dynamic API objects.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client
requires it.
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::flags): Added a flag to track opting out of property
caching. Fixed an "&&" vs "&" typo that was previously harmless, but
is now harmful since m_flags2 can have more than one bit set.
2011-05-27 Stephanie Lewis <slewis@apple.com>
Unreviewed.
Fix a typo in the order_file flag.
* Configurations/Base.xcconfig:
2011-05-27 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.
* runtime/JSGlobalData.cpp:
(JSGlobalData::JSGlobalData):
2011-05-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add a few validity assertions to JSCallbackObject
https://bugs.webkit.org/show_bug.cgi?id=61659
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
2011-05-27 Oliver Hunt <oliver@apple.com>
Build fix
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::invalidateCode):
2011-05-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Try to release unused executable memory when the FixedVMPool allocator is under pressure
https://bugs.webkit.org/show_bug.cgi?id=61651
Rather than crashing when full the FixedVMPool allocator now returns a null
allocation. We replace the code that used to CRASH() on null allocations
with logic that asks the provided globalData to release any executable memory
that it can. Currently this just means throwing away all regexp code, but
in future we'll try to be more aggressive.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::create):
(JSC::ExecutablePool::alloc):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::poolForSize):
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::alloc):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::releaseExecutableMemory):
(JSC::releaseExecutableMemory):
* runtime/JSGlobalData.h:
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::invalidateCode):
* runtime/RegExpCache.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Optimized ConservativeSet to avoid double-visiting objects
https://bugs.webkit.org/show_bug.cgi?id=61592
SunSpider thinks this might be a 1% speedup
* heap/ConservativeRoots.h:
(JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting
an object.
* heap/Heap.h:
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::testAndClearMarked):
(JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type
to void*, since clients want to ask questions about arbitrary pointers
into the heap, even when they aren't known to be JSCells.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::testAndClearMarked):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::isMarked):
(JSC::MarkedSpace::testAndSetMarked):
(JSC::MarkedSpace::testAndClearMarked):
(JSC::MarkedSpace::setMarked):
(JSC::MarkedSpace::contains): Ditto.
* wtf/Bitmap.h:
(WTF::::testAndClear): New function for ConservativeRoots's inverted
marking pass.
2011-05-27 Stephanie Lewis <slewis@apple.com>
Rubber Stamped by Adam Roben.
Update Order Files. Use -order_file flag since it can order more of the binary.
* Configurations/Base.xcconfig:
* JavaScriptCore.order:
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed heapRootMarker to heapRootVisitor to match its class name
https://bugs.webkit.org/show_bug.cgi?id=61584
* heap/Heap.cpp:
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markRoots):
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed some interdependency between Heap and SmallStrings by simplifying
the SmallStrings lifetime model
https://bugs.webkit.org/show_bug.cgi?id=61579
SunSpider reports no change.
Using Weak<T> could accomplish this too, but we're not sure it will give
us the performance we need. This is a first step, and it accomplishes
most of the value of using Weak<T>.
* heap/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots):
(JSC::Heap::reset): Finalize small strings just like other weak handles.
* runtime/SmallStrings.cpp:
(JSC::finalize):
(JSC::SmallStrings::finalizeSmallStrings):
* runtime/SmallStrings.h: Make all small strings trivially weak, instead
of having an "all for one, one for all" memory model.
2011-05-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make RegExpCache a weak map
https://bugs.webkit.org/show_bug.cgi?id=61554
Switch to a weak map for the regexp cache, and hide that
behaviour behind RegExp::create.
When a RegExp is compiled it attempts to add itself to
the "strong" cache. This cache is a simple round-robin
buffer as was the old strong cache. Happily this can
be smaller than the old strong cache as RegExps are only
added when they're compiled so it is under less pressure
to evict.
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::match):
* runtime/RegExp.h:
(JSC::RegExp::gcShouldInvalidateCode):
(JSC::RegExp::hasCode):
(JSC::RegExp::key):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::RegExpCache):
(JSC::RegExpCache::isReachableFromOpaqueRoots):
(JSC::RegExpCache::finalize):
* runtime/RegExpCache.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved Heap-related functions out of JSCell.h and into respective header files
https://bugs.webkit.org/show_bug.cgi?id=61567
* heap/Heap.h:
(JSC::Heap::allocate):
(JSC::Heap::heap):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::allocate):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
* runtime/JSCell.h:
(JSC::JSCell::destructor):
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Try to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
[debug feature] WTFString should have show() method
https://bugs.webkit.org/show_bug.cgi?id=61149
Added String::show and AtomicString::show in NDEBUG.
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::show):
* wtf/text/AtomicString.h:
* wtf/text/WTFString.cpp:
(String::show):
* wtf/text/WTFString.h:
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Factored out some Heap ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=61565
* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::isValidSharedInstanceThreadState):
(JSC::isValidThreadState):
(JSC::Heap::markRoots):
(JSC::Heap::isValidAllocation):
* heap/Heap.h:
* runtime/JSCell.h:
(JSC::JSCell::Heap::allocate):
2011-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=61508
DFG JIT - Add support for get by id self caching.
Change the call out to be an unexpected call (using silent spill/fill functions),
add a structure check & compact load to the JIT code, and add repatching mechanisms.
Since DFGOperations may want to be be implemented in asm, make these symbols be extern
"C". Add an asm wrapper to pass the return address to the optimizing get-by-id operation,
so that it can look up its StructureStubInfo.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added new files.
* bytecode/StructureStubInfo.h:
- Added 'unset' entries to union.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):
- Return the call, we need this to populate the StructureStubInfo.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- Populate the CodebBlock's StructureStubInfo Vector.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
- Return the call, we need this to populate the StructureStubInfo.
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
- Add structures to record property access info during compilation.
* dfg/DFGOperations.cpp:
- Made all external methods extern "C".
(JSC::DFG::operationPutByValInternal):
- Moved outside of the extern "C" block.
* dfg/DFGOperations.h:
- Made all external methods extern "C".
* dfg/DFGRepatch.cpp: Added.
(JSC::DFG::dfgRepatchCall):
- repatch a call to link to a new callee function.
(JSC::DFG::dfgRepatchGetByIdSelf):
- Modify the JIT code to optimize self accesses.
(JSC::DFG::tryCacheGetByID):
- Internal implementation of dfgRepatchGetByID (factor out failing cases).
(JSC::DFG::dfgRepatchGetByID):
- Used to optimize 'operationGetByIdOptimize' - repatches to 'operationGetById', and tries to optimize self accesses!
* dfg/DFGRepatch.h: Added.
- Expose dfgRepatchGetByID.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Changed implementation of GetById ops.
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Rolled back in http://trac.webkit.org/changeset/87408 with Windows build fixed.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
* wtf/DoublyLinkedList.h:
(WTF::::DoublyLinkedListNode):
(WTF::::setPrev):
(WTF::::setNext):
(WTF::::prev):
(WTF::::next):
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead):
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Rolled out http://trac.webkit.org/changeset/87408 because it broke the
Windows build.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::setPrev):
(JSC::MarkedBlock::setNext):
(JSC::MarkedBlock::prev):
(JSC::MarkedBlock::next):
* wtf/DoublyLinkedList.h:
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Provide a real owner when copying a property table, for the sake of
write barriers.
https://bugs.webkit.org/show_bug.cgi?id=61547
No test because we can't enable the writeBarrier() ASSERT just yet.
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
2011-05-26 Adam Roben <aroben@apple.com>
Windows build fix after r87346
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Fixed up exports to match
reality.
2011-05-26 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
ASSERT(isMainThread()) when using single threaded jsc executable
https://bugs.webkit.org/show_bug.cgi?id=60846
Remove the ASSERT since we do not have the concept of MainThread in JSC.
* wtf/CryptographicallyRandomNumber.cpp:
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
2011-05-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=61506
Move the silent spill/fill methods in the DFG JIT to the JITCodeGenerator
so that they are available to the SpeculativeJIT.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
* dfg/DFGNonSpeculativeJIT.h:
2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
An attempt to revive Windows bots.
* runtime/RegExp.cpp:
* runtime/RegExp.h:
2011-05-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 61503 - Move population of CodeBlock::m_structureStubInfos into JIT
This data structure, used at runtime by the JIT, is currently unnecessarily populated
with default entries during byte compilation.
Aside from meaning that there is JIT specific code in the bytecompiler, this also ties
us to one entry per corresponding bytecode op, which may be undesirable. Instead,
populate this array from the JIT.
The type StructureStubInfo has two unused states, one for gets & one for puts. Unify
these, so that the class can have a default constructor (and to simply switch statements
in code walking over the table).
This change has ramification for the DFG JIT, in that the DFG JIT used this datastructure
to check for functions containing property access. Instead do so in the DFGByteCodeParser.
* bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setNumberOfStructureStubInfos):
(JSC::CodeBlock::numberOfStructureStubInfos):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emitSlow_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
2011-05-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Call::fromTailJump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::Jump::isSet):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::linkCall):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::linkCall):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::linkCall):
* assembler/MacroAssemblerSH4.cpp:
(JSC::MacroAssemblerSH4::linkCall):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::linkCall):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):
2011-05-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=61500
Add JSObject::offsetOfPropertyStorage
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
* runtime/JSObject.h:
(JSC::JSObject::offsetOfPropertyStorage):
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490
Make RegExp GC allocated. Basically mechanical change to replace
most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
where actual ownership happens.
Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
(JSC::JSGlobalData::addRegExpToTrace):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
(JSC::RegExp::createStructure):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
* runtime/RegExpObject.h:
(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::regExpProtoFuncCompile):
* runtime/RegExpPrototype.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Generate regexp code lazily
https://bugs.webkit.org/show_bug.cgi?id=61476
RegExp construction now simply validates the RegExp, it does
not perform actual codegen.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::recompile):
(JSC::RegExp::compile):
(JSC::RegExp::match):
* runtime/RegExp.h:
(JSC::RegExp::recompileIfNecessary):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::performMatch):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Removed MarkSetProperties because it was unused
https://bugs.webkit.org/show_bug.cgi?id=61418
* heap/MarkStack.h:
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::append):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSArray.h:
(JSC::JSArray::visitChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/WriteBarrier.h:
(JSC::MarkStack::appendValues):
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make allocations with guard pages ensure that the allocation succeeded
https://bugs.webkit.org/show_bug.cgi?id=61453
Add null checks, and make PageBlock's operator bool() use
the realbase, rather than the start of usable memory.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/PageBlock.h:
(WTF::PageBlock::operator bool):
(WTF::PageBlock::PageBlock):
2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.
https://bugs.webkit.org/show_bug.cgi?id=27551
* bytecompiler/BytecodeGenerator.h:
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
* Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
2011-05-24 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Add export macros to WTFString.h.
https://bugs.webkit.org/show_bug.cgi?id=27551
* wtf/text/WTFString.h:
(WTF::String::String):
(WTF::String::findIgnoringCase):
(WTF::String::isHashTableDeletedValue):
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Maybe fix the Mac build now?
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Maybe fix the Mac build?
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split HeapRootVisitor into its own class
https://bugs.webkit.org/show_bug.cgi?id=61399
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/HandleHeap.cpp:
* heap/HandleStack.cpp:
* heap/Heap.cpp:
* heap/HeapRootVisitor.h: Copied from Source/JavaScriptCore/heap/MarkStack.h.
* heap/MarkStack.h:
* runtime/ArgList.cpp:
* runtime/SmallStrings.cpp:
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Rubberstamped by David Kilzer.
Updated some files that I forgot in my previous MHTML CL.
* Configurations/FeatureDefines.xcconfig:
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Fix the Mac build: Yes, please do remove these files, svn.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Let's just have one way to get the system page size, bokay?
https://bugs.webkit.org/show_bug.cgi?id=61384
* CMakeListsEfl.txt:
* CMakeListsWinCE.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: MarkStack[Platform].cpp
is gone completely now, since it only existed to provide a duplicate way
to access the system page size.
* heap/MarkStack.cpp:
(JSC::MarkStack::reset):
* heap/MarkStack.h:
(JSC::::MarkStackArray):
(JSC::::shrinkAllocation): Use WTF::pageSize.
* heap/MarkStackPosix.cpp:
* heap/MarkStackSymbian.cpp:
* heap/MarkStackWin.cpp: Removed now-empty files.
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::reprotectRegion):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp: Use WTF::pageSize.
* wscript: Removed now-empty files.
* wtf/PageBlock.cpp:
(WTF::systemPageSize): Integrated questionable Symbian page size rule
from ExecutableAllocator, because that seems like what the original
author should have done.
2011-05-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Interpreter crashes with gc validation enabled due to failure to mark initial cache structure
https://bugs.webkit.org/show_bug.cgi?id=61385
The interpreter uses the structure slot of get_by_id and put_by_id to hold
the initial structure it encountered so that it can identify whether a
given access is stable.
When marking though we only visit the slot when we've decided to cache, and
so this value could die. This was "safe" as the value was only used for a
pointer compare, but it was incorrect. We now just mark the slot like we
should have been doing already.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):
2011-05-24 Adam Roben <aroben@apple.com>
Windows build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed now-inline functions.
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Windows build fix: update the #if OS(WINDOWS) section to match my last patch.
* heap/MarkStack.h:
(JSC::::shrinkAllocation):
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Oliver Hunt.
Split out function definitions and class definitions from class
declarations in MarkStack.h, for readability.
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
(JSC::MarkStack::pageSize):
(JSC::::MarkStackArray):
(JSC::::~MarkStackArray):
(JSC::::expand):
(JSC::::append):
(JSC::::removeLast):
(JSC::::last):
(JSC::::isEmpty):
(JSC::::size):
(JSC::::shrinkAllocation):
2011-05-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Avoid creating unnecessary identifiers and strings in the syntax checker
https://bugs.webkit.org/show_bug.cgi?id=61378
Selectively tell the lexer that there are some places it does not need to
do the real work of creating Identifiers for IDENT and STRING tokens.
Make parseString and parseIdentifier templatized on whether they should
do real work, or merely validate the tokens.
SunSpider --parse-only reports ~5-8% win depending on hardware.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createDotAccess):
* parser/JSParser.cpp:
(JSC::JSParser::next):
(JSC::JSParser::consume):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseConstDeclarationList):
(JSC::JSParser::parseExpression):
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parseConditionalExpression):
(JSC::JSParser::parseBinaryExpression):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseObjectLiteral):
(JSC::JSParser::parseArrayLiteral):
(JSC::JSParser::parseArguments):
(JSC::JSParser::parseMemberExpression):
* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseString):
(JSC::Lexer::lex):
* parser/Lexer.h:
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createProperty):
2011-05-23 Michael Saboff <msaboff@apple.com>
Reviewed by Mark Rowe.
Safari often freezes when clicking "Return free memory" in Caches dialog
https://bugs.webkit.org/show_bug.cgi?id=61325
There are two fixes and improvement in instrumentation code used to find
one of the problems.
Changed ReleaseFreeList() to set the "decommitted" bit when releasing
pages to the system and moving Spans from the normal list to the returned
list.
Added a "not making forward progress" check to TCMalloc_PageHeap::scavenge
to eliminate an infinite loop if we can't meet the pagesToRelease target.
Added a check for the decommitted bit being set properly in
TCMalloc_PageHeap::CheckList.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::ReleaseFreeList):
2011-05-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=61306
The begin characters optimization currently has issues (#61129),
and does not appear to still be a performance win. The prudent
next step seems to be to disable while we ascertain whether this
is still a useful performance optimization.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
* yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
* yarr/YarrPattern.h:
(JSC::Yarr::YarrPattern::reset):
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
* wtf/MathExtras.h:
(clampToInteger):
(clampToPositiveInteger):
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-05-23 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
[SH4] AssemblerLabel does not name a type
https://bugs.webkit.org/show_bug.cgi?id=59927
SH4Assembler.h file shoold be included before AbstractMacroAssembler.h.
* assembler/MacroAssemblerSH4.h:
2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>
Rubber stamped by Eric Seidel.
[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146
Move wtf-files to Source/JavaScriptCore/wtf/CMakeLists.txt.
* CMakeLists.txt:
* CMakeListsEfl.txt:
* wtf/CMakeLists.txt:
* wtf/CMakeListsEfl.txt:
2011-05-22 Adam Barth <abarth@webkit.org>
Enable strict PassOwnPtr for everyone. I expect this patch will need
some followups to make the GTK and EFL bots green again.
* wtf/PassOwnPtr.h:
2011-05-20 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Reduce size of inline cache path of get_by_id on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=61221
This reduces the code size of get_by_id by 20 bytes
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ldrCompact):
(JSC::ARMv7Assembler::repatchCompact):
(JSC::ARMv7Assembler::setUInt7ForLoad):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
* jit/JIT.h:
2011-05-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Zombies should "live" forever
https://bugs.webkit.org/show_bug.cgi?id=61170
Reusing zombie cells could still hide garbage
collected cell related bugs.
* JavaScriptCore.pro:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearMarks):
* heap/MarkedBlock.h:
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::destroy):
* runtime/JSCell.h:
(JSC::JSCell::JSValue::isZombie):
* runtime/JSZombie.h:
(JSC::JSZombie::~JSZombie):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/9472883> and https://bugs.webkit.org/show_bug.cgi?id=61203
Horrendous bug in callOnMainThreadAndWait
* wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread): Before signaling the background thread with the
syncFlag condition, reacquire the mutex first.
2011-05-20 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Remove unnecessary double->int conversion at the end of op_div
https://bugs.webkit.org/show_bug.cgi?id=61198
We don't attempt this conversion on 64bit, removing it actually speeds
up sunspider and v8 slightly, and it reduces code size.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_div):
2011-05-19 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158
This was for a build experiment; we can just use the correct value now.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-05-20 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Interpreter uses wrong bytecode offset for determining exception handler
https://bugs.webkit.org/show_bug.cgi?id=61191
The bytecode offset given for the returnPC from the JIT is
actually the offset for the start of the instruction triggering
the call, whereas in the interpreter it is the actual return
VPC. This means if the next instruction following a call was
in an exception region we would incorrectly redirect to its
handler. Long term we want to completely redo how exceptions
are handled anyway so the simplest and lowest risk fix here is
to simply subtract one from the return vPC so that we have an
offset in the triggering instruction.
It turns out this is caught by a couple of tests already.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
2011-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Oliver Hunt.
JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756
Use the MAP_NORESERVE flag for mmap on Linux to skip the kernel
check of the available memory. This should give us an
overcommit-like behavior in most systems, which is what we want.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit): pass MAP_NORSERVE to mmap.
2011-05-19 Gabor Loki <loki@webkit.org>
Fix ARM build after r86919
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::nop):
2011-05-19 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Randomise code starting location a little
https://bugs.webkit.org/show_bug.cgi?id=61161
Add a nop() function to the Assemblers so that we
can randomise code offsets slightly at no real cost.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::nop):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::nop):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::nop):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::nop):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::nop):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::nop):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::nop):
* assembler/X86Assembler.h:
(JSC::X86Assembler::nop):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* runtime/WeakRandom.h:
(JSC::WeakRandom::getUint32):
2011-05-19 Oliver Hunt <oliver@apple.com>
Fix windows build.
* wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::reserveAndCommit):
2011-05-19 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add guard pages to each end of the memory region used by the fixedvm allocator
https://bugs.webkit.org/show_bug.cgi?id=61150
Add mechanism to notify the OSAllocator that pages at either end of an
allocation should be considered guard pages. Update PageReservation,
PageAllocation, etc to handle this.
* JavaScriptCore.exp:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
* wtf/OSAllocator.h:
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::reserveAndCommit):
* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation):
* wtf/PageAllocationAligned.h:
(WTF::PageAllocationAligned::PageAllocationAligned):
* wtf/PageBlock.h:
(WTF::PageBlock::PageBlock):
* wtf/PageReservation.h:
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveWithGuardPages):
Add a new function to make a reservation that will add guard
pages to the ends of an allocation.
(WTF::PageReservation::PageReservation):
2011-05-19 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Executables release their JIT code as soon as they become dead
https://bugs.webkit.org/show_bug.cgi?id=61134
Add an ability to clear an Executable's jit code without requiring
it to be destroyed, and then call that from a finalizer.
* heap/Weak.h:
(JSC::Weak::Weak):
(JSC::Weak::leak):
* jit/JITCode.h:
(JSC::JITCode::clear):
* runtime/Executable.cpp:
(JSC::ExecutableFinalizer::finalize):
(JSC::ExecutableBase::executableFinalizer):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::clearExecutableCode):
2011-05-19 Adam Roben <aroben@apple.com>
Remove a redundant and broken data export
Data can't be exported from JavaScriptCore.dll by listing it in the .def file. The
JS_EXPORTDATA macro must be used instead. (In this case it was already being used, leading
to a linker warning about multiple definitions.)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSGlobalData::s_info.
2011-05-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=61064
Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
for its inline storage. This resolves the problem of GC occurring before
a subclass has initialised its anonymous storage.
* runtime/JSObject.h:
2011-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Delete WTFURL
https://bugs.webkit.org/show_bug.cgi?id=61084
It's been a year and we've failed to complete this project. It's time
to throw in the towel.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/url: Removed.
* wtf/url/api: Removed.
* wtf/url/api/ParsedURL.cpp: Removed.
* wtf/url/api/ParsedURL.h: Removed.
* wtf/url/api/URLString.h: Removed.
* wtf/url/src: Removed.
* wtf/url/src/RawURLBuffer.h: Removed.
* wtf/url/src/URLBuffer.h: Removed.
* wtf/url/src/URLCharacterTypes.cpp: Removed.
* wtf/url/src/URLCharacterTypes.h: Removed.
* wtf/url/src/URLComponent.h: Removed.
* wtf/url/src/URLEscape.cpp: Removed.
* wtf/url/src/URLEscape.h: Removed.
* wtf/url/src/URLParser.h: Removed.
* wtf/url/src/URLQueryCanonicalizer.h: Removed.
* wtf/url/src/URLSegments.cpp: Removed.
* wtf/url/src/URLSegments.h: Removed.
* wtf/url/wtfurl.gyp: Removed.
2011-05-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
https://bugs.webkit.org/show_bug.cgi?id=61090
Remove the Structure-free JSGlobalObject constructor and instead always
pass the structure into the JSGlobalObject constructor.
Stop DebuggerActivation creating a new structure every time, and simply
use a single shared structure held by the GlobalData.
* API/JSContextRef.cpp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
* jsc.cpp:
(GlobalObject::GlobalObject):
(functionRun):
(jscmain):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.h:
2011-05-18 Oliver Hunt <oliver@apple.com>
Reviewed by Adam Roben.
Disable gc validation in release builds
https://bugs.webkit.org/show_bug.cgi?id=60680
Add back the NDEBUG check
* wtf/Platform.h:
2011-05-17 Geoffrey Garen <ggaren@apple.com>
Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:
2011-05-17 Geoffrey Garen <ggaren@apple.com>
More attempts to work around the EFL build system being borken.
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:
2011-05-17 Geoffrey Garen <ggaren@apple.com>
Try to fix the EFL build.
* runtime/BooleanPrototype.cpp:
2011-05-16 Geoffrey Garen <ggaren@apple.com>
Rolling back in r86653 with build fixed.
Reviewed by Gavin Barraclough and Oliver Hunt.
Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933
Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.
This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.
Large patch, but it's all mechanical.
* DerivedSources.make:
* JavaScriptCore.exp: Build!
* create_hash_table: Added a special case for fromCharCode, since it uses
a custom "thunk generator".
* heap/Heap.cpp:
(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.
* interpreter/CallFrame.h:
(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h: Added new tables.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a
static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.
Even more global object properties can be made lazy, but that requires
more in-depth changes.
* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.
2011-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
JSGlobalContextRelease should not trigger a synchronous garbage collection
https://bugs.webkit.org/show_bug.cgi?id=60990
* API/JSContextRef.cpp:
Change synchronous call to collectAllGarbage to a call to trigger the
activityCallback.
2011-05-16 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Reduce code size for inline cache
https://bugs.webkit.org/show_bug.cgi?id=60942
This patch introduces the concept of a "compact" address that
allows individual architectures to control the maximum offset
used for the inline path of get_by_id. This reduces the code
size of get_by_id by 3 bytes on x86 and x86_64 and slightly
improves performance on v8 tests.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::repatchCompact):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchCompact):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::repatchCompact):
* assembler/CodeLocation.h:
(JSC::CodeLocationDataLabelCompact::CodeLocationDataLabelCompact):
(JSC::CodeLocationCommon::dataLabelCompactAtOffset):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::locationOf):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::repatchCompact):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load32WithAddressOffsetPatch):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::repatchCompact):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
* assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::repatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::repatchCompact):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movl_mr_disp8):
(JSC::X86Assembler::movq_mr_disp8):
(JSC::X86Assembler::repatchCompact):
(JSC::X86Assembler::setInt8):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
2011-05-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86653.
http://trac.webkit.org/changeset/86653
https://bugs.webkit.org/show_bug.cgi?id=60944
"Caused regressions on Windows, OSX and EFL" (Requested by
yutak on #webkit).
* DerivedSources.make:
* DerivedSources.pro:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* create_hash_table:
* heap/Heap.cpp:
(JSC::TypeCounter::operator()):
* interpreter/CallFrame.h:
(JSC::ExecState::arrayTable):
(JSC::ExecState::numberTable):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncJSCPrint):
* runtime/JSGlobalObjectFunctions.h:
* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
* runtime/ObjectPrototype.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
2011-05-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933
Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.
This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.
Large patch, but it's all mechanical.
* DerivedSources.make:
* JavaScriptCore.exp: Build!
* create_hash_table: Added a special case for fromCharCode, since it uses
a custom "thunk generator".
* heap/Heap.cpp:
(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.
* interpreter/CallFrame.h:
(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h: Added new tables.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a
static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.
Even more global object properties can be made lazy, but that requires
more in-depth changes.
* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.
2011-05-16 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
<rdar://problem/9446430>
Reviewed by Mark Rowe.
* Configurations/Base.xcconfig: Fixed typo.
2011-05-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSWeakObjectMap finalisation may occur while gc is in inconsistent state
https://bugs.webkit.org/show_bug.cgi?id=60908
<rdar://problem/9409491>
We need to ensure that we have called all the weak map finalizers while
the global object (and hence global context) is still in a consistent
state. The best way to achieve this is to simply use a weak handle and
finalizer on the global object.
* JavaScriptCore.exp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::WeakMapFinalizer::finalize):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::registerWeakMap):
2011-05-16 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][WK2][Symbian] Shared memory implementation for Symbian
https://bugs.webkit.org/show_bug.cgi?id=55875
* wtf/Platform.h: Exclude Symbian OS from USE(UNIX_DOMAIN_SOCKETS) users
2011-05-16 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=60866
Evaluation order broken for empty alternatives in subpatterns
Reverting https://bugs.webkit.org/show_bug.cgi?id=51395
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
2011-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen & Michael Saboff.
https://bugs.webkit.org/show_bug.cgi?id=60860
Simplify backtracking in YARR JIT
YARR JIT currently performs a single pass of code generation over the pattern,
with special handling to allow the code generation for some backtracking code
out of line. We can simplify things by moving to a common mechanism whereby all
forwards matching code is generated in one pass, and all backtracking code is
generated in another. Backtracking code can be generated in reverse order, to
optimized the common fall-through case.
To make it easier to walk over the pattern, we can first convert to a more
byte-code like format before JIT generating. In time we should unify this with
the YARR interpreter to more closely unify the two.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::YarrOp::YarrOp):
(JSC::Yarr::YarrGenerator::BacktrackingState::BacktrackingState):
(JSC::Yarr::YarrGenerator::BacktrackingState::append):
(JSC::Yarr::YarrGenerator::BacktrackingState::fallthrough):
(JSC::Yarr::YarrGenerator::BacktrackingState::link):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkTo):
(JSC::Yarr::YarrGenerator::BacktrackingState::takeBacktracksToJumpList):
(JSC::Yarr::YarrGenerator::BacktrackingState::isEmpty):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkDataLabels):
(JSC::Yarr::YarrGenerator::BacktrackingState::ReturnAddressRecord::ReturnAddressRecord):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::backtrackAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileAlternative):
(JSC::Yarr::YarrGenerator::opCompileBody):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
2011-05-15 Adam Barth <abarth@webkit.org>
Enable strict PassOwnPtr on Qt. (Build fixes to follow.)
* wtf/PassOwnPtr.h:
2011-05-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line
This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.
This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.
Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/JSFunction.cpp: Made the host function stub cache weak --
otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.
2011-05-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802
This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedSpace.cpp:
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* runtime/JSCell.cpp:
(JSC::slowValidateCell):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::unvalidatedStructure):
(JSC::JSCell::JSCell::JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
(JSC::slowValidateCell):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
(JSC::JSCell::classInfo):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
* runtime/WriteBarrier.h:
(JSC::validateCell):
(JSC::JSCell):
(JSC::JSGlobalObject):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::setMayBeNull):
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrierBase::unvalidatedGet):
(JSC::WriteBarrier::WriteBarrier):
* wtf/Assertions.h:
2011-05-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802
This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedSpace.cpp:
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* runtime/JSCell.cpp:
(JSC::slowValidateCell):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::unvalidatedStructure):
(JSC::JSCell::JSCell::JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
(JSC::slowValidateCell):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
(JSC::JSCell::classInfo):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
* runtime/WriteBarrier.h:
(JSC::validateCell):
(JSC::JSCell):
(JSC::JSGlobalObject):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::setMayBeNull):
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrierBase::unvalidatedGet):
(JSC::WriteBarrier::WriteBarrier):
* wtf/Assertions.h:
2011-05-14 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r86469 and r86471, because they made hundreds tests crash on Qt.
Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedSpace.cpp:
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSString.h:
(JSC::RopeBuilder::createStructure):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
(JSC::Structure::createStructure):
(JSC::JSCell::classInfo):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrier::WriteBarrier):
* wtf/Assertions.h:
2011-05-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802
This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedSpace.cpp:
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* runtime/JSCell.cpp:
(JSC::slowValidateCell):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::unvalidatedStructure):
(JSC::JSCell::JSCell::JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
(JSC::slowValidateCell):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
(JSC::JSCell::classInfo):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
* runtime/WriteBarrier.h:
(JSC::validateCell):
(JSC::JSCell):
(JSC::JSGlobalObject):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::setMayBeNull):
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrierBase::unvalidatedGet):
(JSC::WriteBarrier::WriteBarrier):
* wtf/Assertions.h:
2011-05-01 Holger Hans Peter Freyther <holger@moiji-mobile.com>
Reviewed by Steve Block.
[android] OS(ANDROID) does not imply PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=59888
It is possible to build QtWebKit and others for OS(ANDROID). Let
the buildsystem decide which platform is to be build.
* wtf/Platform.h:
2011-05-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394
This portion of the change introduces a PassTraits template, which
is used to enable takeFirst() to work for a Deque holding OwnPtrs,
and optimize it for a Deque holding RefPtrs. In the future it can
be deployed elsewhere to make our data structures work better with
our smart pointers.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/Deque.h:
(WTF::::takeFirst):
* wtf/PassTraits.h: Added.
(WTF::PassTraits::transfer):
2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Revert r86334, it broke the win build. WinCE build is fixed even without this patch. WinCairo remains broken atm, everything else works.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420
Try to fix WinCE/WinCairo linking by exporting three symbols, not sure whether it's correct though. Win worked just fine before.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Darin Adler.
String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420
Provide a faster String append operator.
Up until now, "String operator+(const String& a, const String& b)" copied String a into a temporary
object, and used a.append(b), which reallocates a new buffer of aLength+bLength. When concatting
N strings using operator+, this leads to N-1 reallocations.
Replace this with a flexible operator+ implementation, that avoids these reallocations.
When concatting a 'String' with any string type (char*, UChar, Vector<char>, String, AtomicString, etc..)
a StringAppend<String, T> object is created, which holds the intermediate string objects, and delays
creation of the final string, until operator String() is invoked.
template<typename T>
StringAppend<String, T> operator+(const String& string1, T string2)
{
return StringAppend<String, T>(string1, string2);
}
template<typename U, typename V, typename W>
StringAppend<U, StringAppend<V, W> > operator+(U string1, const StringAppend<V, W>& string2)
{
return StringAppend<U, StringAppend<V, W> >(string1, string2);
}
When concatting three strings - "String a, b, c; String result = a + b + c;" following happens:
first a StringAppend<String, String> object is created by operator+(const String& string1, String string2).
Then operator+(String string1, const StringAppend<String, String>& string2) is invoked, which returns
a StringAppend<String, StringAppend<String, String> > object.
Then operator String() is invoked, which allocates a StringImpl object, once, large enough to hold the
final string - it uses tryMakeString provided by StringConcatenate.h under the hoods, which guards us
against too big string allocations, etc.
Note that the second template, defines a recursive way to concat an arbitary number of strings
into a single String with just one allocation.
* GNUmakefile.list.am: Add StringOperators.h to build.
* JavaScriptCore.exp: Export WTF::emptyString(). Remove no longer needed symbols.
* JavaScriptCore.gypi: Add StringOperators.h to build.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* wtf/text/AtomicString.h: Pull in StringConcatenate.h at the end of the file.
* wtf/text/StringConcatenate.h: Conditionally include AtomicString.h to avoid a cyclic dependency. Pull in StringOperators.h at the end of the file.
* wtf/text/StringOperators.h: Added. This is never meant to be included directly, including either WTFString.h or AtomicString.h automatically pulls in this file.
(WTF::StringAppend::StringAppend):
(WTF::StringAppend::operator String):
(WTF::StringAppend::operator AtomicString):
(WTF::StringAppend::writeTo):
(WTF::StringAppend::length):
(WTF::operator+):
* wtf/text/WTFString.cpp: Remove operator+ implementations that use String::append().
(WTF::emptyString): Add new shared empty string free function.
* wtf/text/WTFString.h: Replace operator+ implementations by StringAppend template solution. Pull in AtomicString.h at the end of the file.
2011-05-12 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix.
* wtf/Platform.h:
2011-05-12 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Arm debug build failing on ARMAssembler::debugOffset()
https://bugs.webkit.org/show_bug.cgi?id=60688
Related to svn rev 85523
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::debugOffset):
2011-05-11 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Eric Seidel.
WebKit does not build with GCCE
https://bugs.webkit.org/show_bug.cgi?id=60667
Allow compile WebKit with GCCE
* wtf/Alignment.h:
* wtf/Platform.h:
2011-05-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Enable strict PassOwnPtr on Mac
https://bugs.webkit.org/show_bug.cgi?id=60684
This should build cleanly now.
* wtf/PassOwnPtr.h:
2011-05-11 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Protect JSC from WebCore executing JS during JS wrapper finalization
https://bugs.webkit.org/show_bug.cgi?id=60672
<rdar://problem/9350997>
Detect when we're trying to execute JS during GC and prevent the
execution from happening. We also assert that this isn't happening
as it implies incorrect behaviour of an object's destructor.
* JavaScriptCore.exp:
* heap/Heap.cpp:
* heap/Heap.h:
(JSC::Heap::isBusy):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::isCollectorBusy):
2011-05-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Enable gc mark validation in temporarily in release builds
https://bugs.webkit.org/show_bug.cgi?id=60678
Make it easier to turn the gc mark validation on and off, and
temporarily turn it on for all builds.
* heap/MarkStack.cpp:
* heap/MarkStack.h:
(JSC::MarkStack::append):
(JSC::MarkStack::internalAppend):
* runtime/WriteBarrier.h:
(JSC::MarkStack::appendValues):
* wtf/Platform.h:
2011-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/9331651> REGRESSION: RPRVT grows by 1MB / sec @ dvd2blu.com
SunSpider reports no change.
This bug was caused by changing Structure and Executable to being GC
objects, and by a long-standing bug that would thrash the global object
between dictionary and non-dictionary states.
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): Don't
eagerly transition to dictionary -- this can cause pathological dictionary
churn, and it's not necessary, since objects know how to automatically
transition to dictionary when necessary.
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Be sure to report
extra cost from compilation, because it can be quite high. This is especially
important for program code, since DOM timers can repeatedly allocate
program code without allocating any other objects.
* runtime/JSObject.cpp:
(JSC::JSObject::removeDirect): Don't transition to the uncacheable state
if the thing we're trying to remove doesn't exist. This can happen during
compilation, since the compiler needs to ensure that no pre-existing
conflicting definitions exist for certain declarations.
2011-05-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make mark stack validation functions do something useful in a release build
https://bugs.webkit.org/show_bug.cgi?id=60645
Turn ASSERTs into actual if(...) CRASH(); statements.
* heap/MarkStack.cpp:
(JSC::MarkStack::validateValue):
2011-05-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix copy&paste error in comment.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator): the value is stored in
regT2, not regT1.
2011-05-11 Adam Roben <aroben@apple.com>
WinCE build fixes for strict PassOwnPtr
* wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Use adoptPtr.
2011-05-11 Holger Hans Peter Freyther <holger@moiji-mobile.com>
Unreviewed build fix.
[MIPS] Fix compilation of the MIPS JIT
Include the MIPSAssembler.h first to indirectly include
AssemblerBuffer.h before the AbstractMacroAssembler.h. This
order is used for the ARM and X86 MacroAssembler*.h
* assembler/MacroAssemblerMIPS.h:
2011-05-11 Adam Roben <aroben@apple.com>
Turn on strict PassOwnPtr on Windows
Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled
Reviewed by Adam Barth.
* wtf/PassOwnPtr.h:
2011-05-10 Stephanie Lewis <slewis@apple.com>
Unreviewed.
Revert accidental JavaScriptCore change in http://trac.webkit.org/changeset/86130
* Configurations/JavaScriptCore.xcconfig:
2011-05-10 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict PassOwnPtr on Chromium
https://bugs.webkit.org/show_bug.cgi?id=60502
Other platforms to follow.
* wtf/PassOwnPtr.h:
2011-05-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed up some #include dependencies so the WriteBarrier class can actually call Heap::writeBarrier
https://bugs.webkit.org/show_bug.cgi?id=60532
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj: Build!
* heap/Handle.h: Moved HandleTypes to its own header because that's the
WebKit style, and it was necessary to resolve a circular dependency
between Handle.h and WriteBarrier.h.
* heap/Heap.h:
(JSC::Heap::writeBarrier): Added an inline no-op writeBarrier(), to
verify that all the code is in the right place.
* heap/MarkStack.h: Moved WriteBarrier operations to WriteBarrier.h to
resolve a circular dependency.
* runtime/ArgList.h:
* runtime/JSCell.h: #include WriteBarrier.h since we don't get it for
free anymore.
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::PropertyTable): Call the real writeBarrier()
function, now that it exists.
* runtime/SmallStrings.h: Removed a stray #include to resolve a circular
dependency.
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::set):
(JSC::MarkStack::append):
(JSC::MarkStack::appendValues): Updated to match the changes above.
2011-05-10 Oliver Hunt <oliver@apple.com>
Build fix.
* heap/MarkStack.cpp:
(JSC::MarkStack::validateValue):
2011-05-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add some aggressive GC validation to debug builds.
https://bugs.webkit.org/show_bug.cgi?id=60601
When assertions are enabled we now do some validity checking
of objects being added to the mark stack.
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::visitAggregate):
* heap/MarkStack.cpp:
(JSC::MarkStack::validateSet):
(JSC::MarkStack::validateValue):
* heap/MarkStack.h:
(JSC::MarkStack::appendValues):
(JSC::MarkStack::append):
(JSC::MarkStack::internalAppend):
2011-05-09 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
http://bugs.webkit.org/show_bug.cgi?id=60509
Wrong type used for return value from strlen
* wtf/FastMalloc.cpp:
(WTF::fastStrDup): Use size_t. Also don't bother checking for failure since
fastMalloc won't return if it fails.
2011-05-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240
When eval is disabled, we need to block the use of the function
constructor. However, the WebCore JSC bindings call the function
constructor directly to create inline event listeners. To support that
use, this patch adds an entrypoint that bypasses the check for whether
eval is enabled.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionConstructor.h:
2011-05-09 Adam Roben <aroben@apple.com>
Automatically touch WebKit.idl whenever any other WebKit1 IDL file changes
Fixes <http://webkit.org/b/60468> WebKit.idl needs to be manually touched whenever any other
WebKit1 IDL file changes to avoid build errors
Reviewed by Tim Hatcher.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
Updated for script rename.
* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Removed.
* JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Renamed
from react-to-vsprops-changes.py.
(top level): Moved a constant here from main.
(main): Moved most code from here to react_to_vsprops_changes. Added a call to the new
react_to_webkit1_interface_changes function.
(react_to_vsprops_changes): Moved code here from main. Updated to use the
TOP_LEVEL_DIRECTORY global. Moved some code from here to mtime_of_newest_file_matching_globa
and touch_if_older_than.
(react_to_webkit1_interface_changes): Added. Touches WebKit.idl if any other WebKit1 IDL
file has changed.
(mtime_of_newest_file_matching_glob): Added. Code came from main.
(touch_if_older_than): Added. Code came from main.
2011-05-08 Jessie Berlin <jberlin@apple.com>
Reviewed by Dan Bernstein.
Make JSRetainPtr work with JSGlobalContextRefs.
https://bugs.webkit.org/show_bug.cgi?id=60452
Add specialized functions for JSRetain and JSRelease when dealing with JSGlobalContextRefs.
* API/JSRetainPtr.h:
(JSRetain):
(JSRelease):
2011-05-07 Dawit Alemayehu <adawit@kde.org>
Reviewed by Daniel Bates.
Fix compile with GCC 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60380
Remove unused local variable from code.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix with gcc 4.6.0 on linux and c++0x support.
std::tr1::has_trivial_constructor is in <tr1/memory>.
* wtf/TypeTraits.h:
2011-05-05 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Added convenience methods to convert from a byte to hex ASCII digit
characters and vice-versa.
https://bugs.webkit.org/show_bug.cgi?id=59834
* wtf/ASCIICType.h:
(WTF::toASCIIHexValue):
(WTF::lowerNibbleToASCIIHexDigit):
(WTF::upperNibbleToASCIIHexDigit):
2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Make QtWebKit build when using gcc 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60265
If QtWebKit is compiled with gcc 4.6.0 or later we don't want to deactivate
the c++0x support because it works.
* JavaScriptCore.pro:
2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Geoffrey Garen.
Port MachineStackMarker.cpp to Windows x64
https://bugs.webkit.org/show_bug.cgi?id=60216
* heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters): the CONTEXT struct is usable also
on 64-bit Windows.
(JSC::otherThreadStackPointer): return the Rsp register on Windows x64.
2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Link libjavascriptcoregtk on Windows with winmm.dll
https://bugs.webkit.org/show_bug.cgi?id=60215
* GNUmakefile.am:
2011-05-04 Tao Bai <michaelbai@chromium.org>
Reviewed by David Kilzer.
Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143
* Configurations/FeatureDefines.xcconfig:
2011-05-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9366557> Various crashes due to bad DFG codegen at canalplus.fr
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes): Removed a stray line of
code that accidentally survived the conversion to a switch statement,
causing a lot of important code not to run most of the time.
Since this is not a trivial finger-picking mistake, I will not call it a
typo.
2011-05-04 Adam Roben <aroben@apple.com>
Another attempted build fix
* wtf/OwnPtr.h:
(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added a return statement. And made a tweak based on a suggestion from Anders Carlsson.
2011-05-04 Adam Roben <aroben@apple.com>
Try to fix Leopard, Qt, and probably others
* wtf/OwnPtr.h:
(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Try to get the compiler not to instantiate these function templates unnecessarily.
2011-05-03 Adam Roben <aroben@apple.com>
Disallow equality comparisons between [Pass]OwnPtrs
If you have two OwnPtrs that are equal, you've already lost. (Unless you're doing something
really sneaky, in which case you should stop!)
Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
Reviewed by Anders Carlsson and Antti Koivisto.
* wtf/OwnPtr.h:
(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added private equality operators that fail to compile when used. (When not used, the
compiler will skip over them because they are function templates.)
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Gavin Barraclough.
JITArithmetic.cpp produces a warning on a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=60060
Just properly use what we already have converted.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Geoffrey Garen.
JITPropertyAccess produces a unused but set variable warning in gcc 4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=60050
This patch fix a compilation warning. The new warning scenario -Wunused-but-set-variable
in gcc 4.6.0 is included in -Wall and therefore stops the compilation when warnings are treated
as errors. The patch introduces a new macro ASSERT_JIT_OFFSET_UNUSED and ASSERT_WITH_MESSAGE_UNUSED
which copy the idea of ASSERT_UNUSED.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
* wtf/Assertions.h:
(assertWithMessageUnused):
2011-04-29 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Seidel.
Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798
* wtf/Platform.h: Set ENABLE_FULLSCREEN_API on win.
2011-05-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Eric Seidel.
Unused but set variable warning in MacroAssemberX86_64
https://bugs.webkit.org/show_bug.cgi?id=59482
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::call):
(JSC::MacroAssemblerX86_64::tailRecursiveCall):
(JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
2011-05-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make malloc validation useful
https://bugs.webkit.org/show_bug.cgi?id=57502
Reland this patch (rolled out in 82905) without
turning it on by default.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::fastMallocSize):
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMallocStats::malloc):
(WTF::TCMallocStats::free):
(WTF::TCMallocStats::fastCalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::calloc):
(WTF::TCMallocStats::fastRealloc):
(WTF::TCMallocStats::tryFastRealloc):
(WTF::TCMallocStats::realloc):
(WTF::TCMallocStats::fastMallocSize):
* wtf/FastMalloc.h:
(WTF::Internal::fastMallocValidationHeader):
(WTF::Internal::fastMallocValidationSuffix):
(WTF::Internal::fastMallocMatchValidationType):
(WTF::Internal::setFastMallocMatchValidationType):
(WTF::fastMallocMatchValidateFree):
(WTF::fastMallocValidate):
2011-05-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Anders Carlsson.
Compile error with GCC 4.6.0, tries to assign unsigned& to bitfield
https://bugs.webkit.org/show_bug.cgi?id=59261
Use unary '+' to force proper type detection in template arguments
with GCC 4.6.0. See bug report for more details.
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::remove): Use '+' to force precise type detection.
(JSC::StructureTransitionTable::add): ditto.
* runtime/Structure.h:
(JSC::StructureTransitionTable::keyForWeakGCMapFinalizer): ditto.
2011-05-03 Jessie Berlin <jberlin@apple.com>
Rubber-stamped by Adam Roben.
Revert r85550 and r85575.
Variables cannot be exported via the .def file. Instead, they should be annotated with
JS_EXPORTDATA.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):
2011-05-02 Adam Roben <aroben@apple.com>
Allow implicit conversion from nullptr_t to PassOwnPtr
This makes it a lot easier to write code that just wants a null PassOwnPtr, especially in
strict PassOwnPtr mode.
Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should
Reviewed by Adam Barth.
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::PassOwnPtr): Added a non-explicit constructor that takes a nullptr_t.
* wtf/MessageQueue.h:
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
Use the new implicit conversion.
2011-05-02 Jessie Berlin <jberlin@apple.com>
Rubber-stamped by Oliver Hunt.
Remove an assertion that Windows was hitting on launch.
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):
2011-05-02 Mark Rowe <mrowe@apple.com>
Reviewed by Geoff Garen.
<rdar://problem/9371948> JavaScriptCore should build with GCC 4.2
* Configurations/CompilerVersion.xcconfig:
2011-05-02 Gavin Barraclough <barraclough@apple.com>
ARMv7 build fix.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
2011-05-02 Oliver Hunt <oliver@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-05-02 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
crash in JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=58922
Cleared chained backtrack data label when linking label even if that
label doesn't chain itself. This is needed so that subsequent
backtrack data labels point to the next outer paren and not within
the current paren.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
2011-05-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Tiny bit of heap cleanup.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::contains): Tightened up an assertion and a comment.
* heap/MarkedSpace.h:
(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark): Moved inlines out of the class
definition, for better clarity.
2011-05-02 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Correct marking of interpreter data in mixed mode builds
https://bugs.webkit.org/show_bug.cgi?id=59962
We had a few places in mixed mode builds where we would not
track data used by the interpreter for marking. This patch
corrects the problem and adds a number of assertions to catch
live Structures being collected.
* JavaScriptCore.exp:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):
2011-05-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Alexey Proskuryakov.
Use native NullPtr when using GCC 4.6.0 and C++0x
https://bugs.webkit.org/show_bug.cgi?id=59252
GCC 4.6.0 has nullptr support, use it when possible.
* wtf/NullPtr.cpp: include config.h to pull in Platform.h before
NullPtr.h, since we need the GCC_VERSION_AT_LEAST definition.
* wtf/NullPtr.h: check for GCC >= 4.6.0 and C++0x in order to
use native nullptr.
2011-05-02 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=59950
Clean up AssemblerBuffer to use a Vector internally.
AssemblerBuffer handles reallocing a byte array itself - stop that.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::~AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::isAligned):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::putByteUnchecked):
(JSC::AssemblerBuffer::putByte):
(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putShort):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt):
(JSC::AssemblerBuffer::putInt64Unchecked):
(JSC::AssemblerBuffer::putInt64):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::executableCopy):
(JSC::AssemblerBuffer::rewindToLabel):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):
* assembler/X86Assembler.h:
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
2011-05-02 Jeff Miller <jeffm@apple.com>
Reviewed by Alexy Proskuryakov.
Avoid potential buffer overflow in WTFLog() and WTFLogVerbose()
https://bugs.webkit.org/show_bug.cgi?id=59949
* wtf/Assertions.cpp: Check for 0 or empty format string in WTFLog() and WTFLogVerbose().
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
StringImpl::endsWith has some insane code
https://bugs.webkit.org/show_bug.cgi?id=59900
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::endsWith):
- m_data shadows a member variable of the same name.
2011-05-02 Gabor Loki <loki@webkit.org>
Buildfix for ARM after r85448
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::loadBranchTarget):
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Strict-mode only reserved words not reserved
https://bugs.webkit.org/show_bug.cgi?id=55342
Fix line number tracking when we rollback the lexer.
* parser/JSParser.cpp:
(JSC::JSParser::parseSourceElements):
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295
Simplify and correct the logic for strict mode object literals.
* parser/JSParser.cpp:
(JSC::JSParser::parseStrictObjectLiteral):
2011-05-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289
Add logic to StaticScopeObject to ensure we don't silently consume
writes to constant properties.
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
2011-05-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=59903
Use AssemblerLabel throughout Assembler classes, AssemblerBuffer
Creating a lable() into the AssemblerBuffer should return an AssemblerLabel,
not an unsigned int.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::ARMInstructionFormatter::label):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::label):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::relocateJumps):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::oneShortOp):
* assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::label):
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
* wtf/OwnPtr.h:
2011-05-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Enable strict OwnPtr for PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=59881
* wtf/OwnPtr.h:
2011-05-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=59896
Remove JmpSrc/JmpDst types.
The JmpSrc/JmpDst classes predate the MacroAssembler interface. Having these
object be per-assembler in unhelpful, causes unnecessary code duplication,
and prevents the AssemblerBuffer from providing a richer type for labels.
The limited semantic meaning that they did convey is undermined by the manner
in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst
for data labels).
Jumps on ARMv7 have had additional information added to the object via the
ARMv7 JmpSrc. This data should probably be in the instruction stream. This
patch does not fix the problem, and moves the data (ifdefed) to
AbstractMacroAssembler::Jump (which is effectively where it was before!).
This at least closes the hole such that no further data may be added to JmpSrc,
but this is unfortunate, and should be cleaned up.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkPointer):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::align):
(JSC::ARMv7Assembler::getRelocatedAddress):
(JSC::ARMv7Assembler::getDifferenceBetweenLabels):
(JSC::ARMv7Assembler::getCallReturnOffset):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::isSet):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::patch):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeBranch):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::align):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::linkCall):
(JSC::SH4Assembler::linkPointer):
(JSC::SH4Assembler::getCallReturnOffset):
(JSC::SH4Assembler::getRelocatedAddress):
(JSC::SH4Assembler::getDifferenceBetweenLabels):
(JSC::SH4Assembler::patchPointer):
* assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::jnz):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jz):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jCC):
(JSC::X86Assembler::label):
(JSC::X86Assembler::labelFor):
(JSC::X86Assembler::align):
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::getCallReturnOffset):
(JSC::X86Assembler::getRelocatedAddress):
(JSC::X86Assembler::getDifferenceBetweenLabels):
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::atJumpTarget):
(JSC::JIT::emitGetVirtualRegister):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jmp_scopes):
2011-05-01 Chao-ying Fu <fu@mips.com>
Reviewed by Eric Seidel.
Fix MIPS build due to the split of "Condition" enum
https://bugs.webkit.org/show_bug.cgi?id=59407
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::debugOffset):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::compare32):
2011-04-30 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
Enable strict OwnPtr for GTK
https://bugs.webkit.org/show_bug.cgi?id=59861
* wtf/OwnPtr.h:
2011-04-30 Gavin Barraclough <barraclough@apple.com>
ARMv7 build fix.
* assembler/AssemblerBufferWithConstantPool.h:
2011-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 59869 - AssemblerBuffer cleanup - disambiguate size()
The method size() is called on the AssemblerBuffer both to acquire
the complete size of the code, and to get a position to use as a
label into the code. Instead, add an explicit 'label' method.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::codeSize):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::data):
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::newJmpSrc):
(JSC::MIPSAssembler::appendJump):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::codeSize):
(JSC::MIPSAssembler::relocateJumps):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::executableCopy):
(JSC::SH4Assembler::oneShortOp):
(JSC::SH4Assembler::codeSize):
* assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::codeSize):
(JSC::X86Assembler::X86InstructionFormatter::label):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
2011-04-29 Adam Barth <abarth@webkit.org>
Attempt to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP script-src should block eval
https://bugs.webkit.org/show_bug.cgi?id=59850
ggaren recommend a different approach to this patch, essentially
installing a new function for function-eval and changing the AST
representation of operator-eval to call function-eval. However, I'm
not sure that approach is workable because the ASTBuilder doesn't know
about global objects, and there is added complication due to the cache.
This approach is more dynamic, adding a branch in EvalExecutable to
detect whether eval is current disabled in the lexical scope. The spec
is slightly unclear about whether we should return undefined or throw
an exception. I've asked Brandon to clarify the spec, but throwing an
exception seems natural.
* JavaScriptCore.exp:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::disableEval):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::isEvalEnabled):
2011-04-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=59847
Remove linkOffset from LinkBuffer
This is redundant since removal of recompilation for exception info.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compile):
(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compileCTINativeCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
2011-04-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt & Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=59221
[RegexFuzz] Regression blocking testing
Okay, so the bug here is that when, in the case of a TypeParentheticalAssertion
node, emitDisjunction recursively calls to itself to emit the nested disjunction
the value of parenthesesInputCountAlreadyChecked is bogus (doesn't take into
account the uncheck that has just taken place).
Also, the special handling given to countToCheck in the case of parenthetical
assertions is nonsense, delete it, along with the isParentheticalAssertion argument.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):
2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Adam Barth.
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
* wtf/OwnPtr.h:
2011-04-29 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add ENABLE macro for WebKitAnimation
https://bugs.webkit.org/show_bug.cgi?id=59729
Add new feature to toggle WebKit Animation API.
* Configurations/FeatureDefines.xcconfig:
2011-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Install testapi.js along side testapi
https://bugs.webkit.org/show_bug.cgi?id=59773
* JavaScriptCore.xcodeproj/project.pbxproj:
Add new build phase to copy testapi.js to install path of testapi
on install.
2011-04-28 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Remove IMAGE_RESIZER related code.
https://bugs.webkit.org/show_bug.cgi?id=59735
* Configurations/FeatureDefines.xcconfig:
2011-04-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=59763
DFG JIT - Unify FPRReg & FPRegisterID
(Following on from GPRReg/RegisterID unification).
* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::flushRegisters):
(JSC::DFG::JITCodeGenerator::isFlushed):
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
(JSC::DFG::JITCodeGenerator::setupStubArguments):
(JSC::DFG::JITCodeGenerator::callOperation):
(JSC::DFG::GPRResult::lockedResult):
(JSC::DFG::FPRResult::lockedResult):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::iterator::regID):
(JSC::DFG::RegisterBank::iterator::debugName):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
2011-04-28 David Kilzer <ddkilzer@apple.com>
Revert "<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called"
This reverts commit r85195. It was crashing DumpRenderTree on Lion.
* wtf/mac/MainThreadMac.mm:
(WTF::postTimer):
2011-04-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678
Remove the WML configuration option from the Mac build system.
* Configurations/FeatureDefines.xcconfig:
2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85233 and r85235.
http://trac.webkit.org/changeset/85233
http://trac.webkit.org/changeset/85235
https://bugs.webkit.org/show_bug.cgi?id=59754
Causes issues with jsc. (Requested by dave_levin on #webkit).
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* wtf/CMakeLists.txt:
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):
* wtf/SizeLimits.cpp:
* wtf/ThreadRestrictionVerifier.h: Removed.
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer):
2011-04-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 59740 - DFG JIT - Unify GPRReg & RegisterID
Currently we use a mix of enum values throughout the DFG JIT to represent
gpr registers - the RegisterID provided by the MacroAssembler, and the
GPRReg enum giving the sequential register set over which the RegisterBank
allocates. Unify the two.
Patch to unify FPRReg in a similar fashion will follow.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGFPRInfo.h: Added.
(JSC::DFG::next):
(JSC::DFG::FPRBankInfo::toRegister):
(JSC::DFG::FPRBankInfo::toIndex):
* dfg/DFGGPRInfo.h: Added.
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::flushRegisters):
(JSC::DFG::JITCodeGenerator::isFlushed):
(JSC::DFG::JITCodeGenerator::bitOp):
(JSC::DFG::JITCodeGenerator::shiftOp):
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
(JSC::DFG::JITCodeGenerator::setupStubArguments):
(JSC::DFG::JITCodeGenerator::callOperation):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::DoubleOperand::gpr):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::gpr):
(JSC::DFG::GPRResult::lockedResult):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::preserveReturnAddressAfterCall):
(JSC::DFG::JITCompiler::restoreReturnAddressBeforeReturn):
(JSC::DFG::JITCompiler::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::JITCompiler::emitPutToCallFrameHeader):
(JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
(JSC::DFG::JITCompiler::addressForGlobalVar):
(JSC::DFG::JITCompiler::addressFor):
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
(JSC::DFG::NonSpeculativeJIT::silentSpillGPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillFPR):
(JSC::DFG::NonSpeculativeJIT::silentFillGPR):
(JSC::DFG::NonSpeculativeJIT::silentFillFPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::allocate):
(JSC::DFG::RegisterBank::retain):
(JSC::DFG::RegisterBank::release):
(JSC::DFG::RegisterBank::lock):
(JSC::DFG::RegisterBank::unlock):
(JSC::DFG::RegisterBank::isLocked):
(JSC::DFG::RegisterBank::name):
(JSC::DFG::RegisterBank::iterator::name):
(JSC::DFG::RegisterBank::iterator::isLocked):
(JSC::DFG::RegisterBank::iterator::release):
(JSC::DFG::RegisterBank::iterator::gpr):
(JSC::DFG::RegisterBank::iterator::debugName):
(JSC::DFG::RegisterBank::iterator::operator++):
(JSC::DFG::RegisterBank::iterator::operator!=):
(JSC::DFG::RegisterBank::iterator::index):
(JSC::DFG::RegisterBank::iterator::iterator):
(JSC::DFG::RegisterBank::begin):
(JSC::DFG::RegisterBank::end):
(JSC::DFG::RegisterBank::isLockedAtIndex):
(JSC::DFG::RegisterBank::nameAtIndex):
(JSC::DFG::RegisterBank::releaseAtIndex):
(JSC::DFG::RegisterBank::allocateInternal):
(JSC::DFG::RegisterBank::MapEntry::MapEntry):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateIntegerOperand::gpr):
2011-04-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove evil addressOfStructure() function
https://bugs.webkit.org/show_bug.cgi?id=59739
Remove the addressOfStructure function from JSCell, and update
callsites to use the same logic as testPrototype()
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
* runtime/JSCell.h:
2011-04-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Clean up testPrototype()
https://bugs.webkit.org/show_bug.cgi?id=59734
Remove direct pointer to the inside of a GC object and just do
the indirect load manually. Doesn't effect sunspider but does
clean up the code quite a bit, and simplifies the handling of
GC values.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::testPrototype):
2011-04-28 David Levin <levin@chromium.org>
Build fix.
* wtf/RefCounted.h: Fix inverted ifdef.
2011-04-07 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639
* GNUmakefile.list.am: Added new files to the build.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider): Ditto.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp): Ditto.
* wtf/CMakeLists.txt: Added new files to the build.
* wtf/ThreadRestrictionVerifier.h: Added.
Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):
* wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium's test_shell (bug 58093).
2011-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed attempt to fix the build.
* GNUmakefile.am: add -lpthread.
2011-04-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Only need a single implementation of testPrototype
https://bugs.webkit.org/show_bug.cgi?id=59724
Remove excess copy of identical testPrototype() code
* jit/JITPropertyAccess.cpp:
(JSC::JIT::testPrototype):
* jit/JITPropertyAccess32_64.cpp:
2011-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428
Build JavaScriptCore as a libtool shared library instead of a
private convenience library.
* GNUmakefile.am: define new jsc library and adapt to new name for
javascriptcore target.
* GNUmakefile.list.am: ditto.
2011-04-28 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called
Reviewed by Simon Fraser.
* wtf/mac/MainThreadMac.mm:
(WTF::postTimer): Use RetainPtr to plug the leak.
2011-04-27 Sam Weinig <sam@webkit.org>
Reviewed by David Kilzer.
Add way to install testapi in production builds
https://bugs.webkit.org/show_bug.cgi?id=59674
* Configurations/TestAPI.xcconfig: Copied from Configurations/JavaScriptCore.xcconfig.
Add configuration file for TestAPI. In addition to name, we now specify an install path
and allow SKIP_INSTALL to be overridden by setting FORCE_TOOL_INSTALL.
* JavaScriptCore.xcodeproj/project.pbxproj:
Remove in-project build settings and add missing configuration files. Added missing CompilerVersion.xcconfig
file.
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict OwnPtrs for Chromium
https://bugs.webkit.org/show_bug.cgi?id=59666
* wtf/OwnPtr.h:
2011-04-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add ability to remove keys from weakmap API
https://bugs.webkit.org/show_bug.cgi?id=59645
Add JSWeakObjectMapRemove API
* API/JSWeakObjectMapRefPrivate.cpp:
* API/JSWeakObjectMapRefPrivate.h:
* JavaScriptCore.exp:
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict mode for OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
This patch enables strict mode for OwnPtr on PLATFORM(MAC) only.
* wtf/OwnPtr.h:
2011-04-27 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111
This is to avoid the maintenance burden until the Android port is
fully upstreamed.
* Android.mk: Removed.
* Android.v8.wtf.mk: Removed.
2011-04-27 Mark Rowe <mrowe@apple.com>
Fix 32-bit build after r85036.
* wtf/Platform.h: USE(PLUGIN_HOST_PROCESS) is only true for 64-bit.
2011-04-27 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r85036.
Readd non-dead code.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
OwnPtr assignment operator should be private
https://bugs.webkit.org/show_bug.cgi?id=59487
Unfortunately we can't remove the copy constructor because of some
detail about gcc. (The issue is documented in a comment already.)
* wtf/OwnPtr.h:
2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84977.
http://trac.webkit.org/changeset/84977
https://bugs.webkit.org/show_bug.cgi?id=59568
caused crashes on the SL WK2 bots (Requested by jessieberlin
on #webkit).
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::call):
(JSC::MacroAssemblerX86_64::tailRecursiveCall):
(JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
2011-04-26 Kevin Ollivier <kevino@theolliviers.com>
Rubberstamped by Eric Seidel.
Enable waf to be used to build other ports
https://bugs.webkit.org/show_bug.cgi?id=58213
* wscript:
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
* Configurations/FeatureDefines.xcconfig:
Remove feature.
2011-04-26 Adrienne Walker <enne@google.com>
Reviewed by Geoffrey Garen.
Fix incorrect use of OwnPtr<T*> in GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=59559
* runtime/GCActivityCallback.h:
2011-04-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Daniel Bates.
Unused but set variable warning in MacroAssembelX86_64
https://bugs.webkit.org/show_bug.cgi?id=59482
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::call): do not declare the label
variable if we are not going to use it.
(JSC::MacroAssemblerX86_64::tailRecursiveCall): ditto.
(JSC::MacroAssemblerX86_64::makeTailRecursiveCall): ditto.
2011-04-26 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
Choose the compiler based on the Xcode version for Snow Leopard debug builds.
* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Nixed special finalizer handling for WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=59425
SunSpider reports no change.
Not needed anymore, since weak handles have finalizers.
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory):
(JSC::JSString::substringFromRope):
(JSC::JSString::replaceCharacter): Updated for removal of union.
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength): No need for
union or special constructor anymore.
2011-04-26 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Speeding up SVG filters with multicore (SMP) support
https://bugs.webkit.org/show_bug.cgi?id=43903
Some SVG filters execute a huge number of pixel manipulations, which
cannot be sped up by graphics accelerators, since their algorithm is
too complex. Using the power of Symmetric Multi Processing (SMP) we
can split up a task to smaller (data independent) tasks, which can be
executed independently.
The ParallelJobs framework provides a simple way for distributed
programming. The framework is based on WebKit's threading infrastructure,
Open Multi-Processing's (OpenMP) API, and libdispatch API.
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/ParallelJobs.h: Added.
(WTF::ParallelJobs::ParallelJobs):
(WTF::ParallelJobs::numberOfJobs):
(WTF::ParallelJobs::parameterForJob):
(WTF::ParallelJobs::executeJobs):
* wtf/ParallelJobsGeneric.cpp: Added.
(WTF::ParallelEnvironment::ThreadPrivate::tryLockFor):
(WTF::ParallelEnvironment::ThreadPrivate::executeJob):
(WTF::ParallelEnvironment::ThreadPrivate::waitForFinish):
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):
* wtf/ParallelJobsGeneric.h: Added.
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::numberOfJobs):
(WTF::ParallelEnvironment::parameterForJob):
(WTF::ParallelEnvironment::executeJobs):
(WTF::ParallelEnvironment::ThreadPrivate::ThreadPrivate):
(WTF::ParallelEnvironment::ThreadPrivate::create):
* wtf/ParallelJobsLibdispatch.h: Added.
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::numberOfJobs):
(WTF::ParallelEnvironment::parameterForJob):
(WTF::ParallelEnvironment::executeJobs):
* wtf/ParallelJobsOpenMP.h: Added.
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::numberOfJobs):
(WTF::ParallelEnvironment::parameterForJob):
(WTF::ParallelEnvironment::executeJobs):
* wtf/Platform.h:
* wtf/wtf.pri:
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418
We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.
* JavaScriptCore.xcodeproj/project.pbxproj:
* gyp/generate-derived-sources.sh:
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
SunSpider reports no change.
The hasCustomProperties() check didn't check for a custom prototype.
* runtime/JSObject.h:
(JSC::JSObject::hasCustomProperties): Changed to delegate to Structure
because it is the "truth" about an object's pedigree.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::didTransition): Track whether a Structure has ever
transitioned for any reason. If so, we have to assume that the object
holding it is custom in some way.
2011-04-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=59405
DFG JIT - add type speculation for integer & array types, for vars & args.
If a var or argument is used as the base for a GetByVal or PutByVal access
we are speculating that it is of type Array (we only generate code on the
speculative path to perform array accesses). By typing the var or args slot
as Array, and checking on entry to the function (in the case of args), and
each time the local is written to, we can avoid a type check at each point
the array is accessed. This will typically hoist type checks out of loops.
Similarly, any local that is incremented or decremented, or is the input or
output or a bitwise operator, is likely to be an integer. By typing the
local as int32 we can avoid speculation checks on access, and tagging when
writing to the slot. All accesses can become 32bit instead of 64.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
2011-04-25 David Levin <levin@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict mode violation in MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=59400
* wtf/MessageQueue.h:
(WTF::::waitForMessage):
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
JavaScriptCore should play nice strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59401
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* heap/Heap.cpp:
(JSC::TypeCounter::TypeCounter):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* parser/JSParser.cpp:
(JSC::JSParser::Scope::Scope):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
2011-04-25 Mark Rowe <mrowe@apple.com>
Build fix.
* wtf/ListHashSet.h:
2011-04-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 59370 - DFG JIT - fix leak of BlocksBlocks
(put the blocks immediately into an OwnPtr).
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
* wtf/ListHashSet.h:
(WTF::::ListHashSet):
2011-04-25 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Fix PassOwnPtr issues in Structure and JSGlobalData.cpp
https://bugs.webkit.org/show_bug.cgi?id=59347
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/Structure.cpp:
(JSC::Structure::copyPropertyTable):
(JSC::Structure::createPropertyMap):
* runtime/Structure.h:
2011-04-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make ClassInfo required when creating a Structure
https://bugs.webkit.org/show_bug.cgi?id=59340
Add ClassInfo to all those types which currently don't
have it, and add an assertion to Structure::create to
ensure that the provided classInfo is not null.
* runtime/Executable.h:
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/GetterSetter.cpp:
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/JSAPIValueWrapper.cpp:
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSString.cpp:
* runtime/JSString.h:
(JSC::RopeBuilder::createStructure):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::JSCell::createDummyStructure):
2011-04-25 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
PropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=59342
This patch is to prepare for the strict OwnPtr hack-a-thon.
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):
2011-04-25 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950
split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'
and apply related changes (only for SH4 platforms).
* assembler/MacroAssemblerSH4.cpp:
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::compare32):
(JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branch32):
(JSC::MacroAssemblerSH4::branchTest8):
(JSC::MacroAssemblerSH4::branch8):
(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerSH4::test8):
(JSC::MacroAssemblerSH4::branch16):
(JSC::MacroAssemblerSH4::branchTest32):
(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchMul32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::branchOr32):
(JSC::MacroAssemblerSH4::branchConvertDoubleToInt32):
(JSC::MacroAssemblerSH4::branchPtrWithPatch):
(JSC::MacroAssemblerSH4::SH4Condition):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::cmpEqImmR0):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PropertyMapHashTable should work with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59337
This patch is in preparation for the strict OwnPtr hack-a-thon.
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::addDeletedOffset):
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Nixed MarkStack::deprecatedAppend, since it has no clients left.
* heap/MarkStack.h:
2011-04-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:
SetLocals to temporaries will only be generated if they are used within other
blocks, due to the SSA based DCE.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig & Geoff Garen.
Bug 59266 - DFG JIT - Add SSA style DCE
This works by making GetLocal nodes reference SetLocal nodes from prior blocks,
via intermediate Phi nodes. Whenever we add a GetLocal to the graph, also add a
matching child Phi, and add the Phi to a work queue to add references to prior
definitions once we have the full CFG & can determine predecessors. This process
is iterative, inserting new phis into predecessors as necessary.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processWorkQueue):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
* dfg/DFGNode.h:
(JSC::DFG::Node::ref):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::dump):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-04-22 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
Add missing default constructors for HashMap iterator specializations.
https://bugs.webkit.org/show_bug.cgi?id=59250
* wtf/HashIterators.h:
* wtf/HashTable.h:
(WTF::HashTableConstIterator::HashTableConstIterator): Added cast
to help compiler find the function template.
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 59262 - DFG JIT - reduce size of VariableRecord
We never need both the get & set node, only the most recent
(which is always a set, if both exist).
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Bug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
such that this information is available for DCE. Also, since this enlarges the
size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a
vector of blocks.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
(JSC::DFG::Graph::blockForBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Errk, build fix.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Quick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
move out the call to checkConsistency().
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
2011-04-21 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
Provide default constructors for HashMap iterators.
https://bugs.webkit.org/show_bug.cgi?id=59151
These will be used to implement an iterator over EventTarget's
listeners.
* wtf/HashTable.h:
(WTF::HashTableConstIteratorAdapter::HashTableConstIteratorAdapter):
(WTF::HashTableIteratorAdapter::HashTableIteratorAdapter):
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 59232 - DFG JIT - Add predecessor links to BasicBlocks
These will be necessary for DCE support.
Also factor allocateVirtualRegisters out into its own method.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::blockForBytecodeOffset):
* dfg/DFGNode.h:
(JSC::DFG::Node::isTerminal):
2011-04-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Object.create creates uncachable objects
https://bugs.webkit.org/show_bug.cgi?id=59164
Use the prototype object's inheritorID, as we
should always have done
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::nullPrototypeObjectStructure):
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorCreate):
2011-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result
We currently allocate virtual registers to nodes which have no result - these are
clearly unused, and may result in us allocating a larger than necessary stack frame.
Encapsulate Node::virtualRegister such that we can ASSERT this is only called on
nodes that have results, and improve the quality of output from the consistency check.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
(JSC::DFG::Node::refCount):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::adjustedRefCount):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
* runtime/JSGlobalObject.h:
(JSC::constructEmptyArray):
(JSC::constructArray):
Add variants of constructArray that take a global object.
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84650 and r84654.
http://trac.webkit.org/changeset/84650
http://trac.webkit.org/changeset/84654
https://bugs.webkit.org/show_bug.cgi?id=59218
Broke Windows build (Requested by bweinstein on #webkit).
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Handle.h:
(JSC::HandleBase::operator!):
(JSC::HandleBase::operator UnspecifiedBoolType*):
(JSC::HandleTypes::getFromSlot):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::markStrongHandles):
(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::protectedGlobalObjectCount):
(JSC::HandleHeap::isValidWeakNode):
* heap/HandleHeap.h:
(JSC::HandleHeap::copyWeak):
(JSC::HandleHeap::makeWeak):
(JSC::HandleHeap::Node::slot):
* heap/HandleStack.cpp:
(JSC::HandleStack::mark):
(JSC::HandleStack::grow):
* heap/HandleStack.h:
(JSC::HandleStack::zapTo):
(JSC::HandleStack::push):
* heap/Heap.cpp:
(JSC::HandleHeap::protectedObjectTypeCounts):
* heap/Local.h:
(JSC::::set):
* heap/Strong.h:
(JSC::Strong::set):
* heap/Weak.h:
(JSC::Weak::set):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
* runtime/WriteBarrier.h:
2011-04-22 Brian Weinstein <bweinstein@apple.com>
Part of Windows build fix from r84650.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-04-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make it harder to use HandleSlot incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59205
Just add a little type fudging to make it harder to
incorrectly assign through a HandleSlot.
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* JavaScriptCore.exp:
* heap/Handle.h:
(JSC::HandleBase::operator!):
(JSC::HandleBase::operator UnspecifiedBoolType*):
(JSC::HandleTypes::getFromSlot):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::markStrongHandles):
(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::protectedGlobalObjectCount):
(JSC::HandleHeap::isValidWeakNode):
* heap/HandleHeap.h:
(JSC::HandleHeap::copyWeak):
(JSC::HandleHeap::makeWeak):
(JSC::HandleHeap::Node::slot):
* heap/HandleStack.cpp:
(JSC::HandleStack::mark):
(JSC::HandleStack::grow):
* heap/HandleStack.h:
(JSC::HandleStack::zapTo):
(JSC::HandleStack::push):
* heap/Heap.cpp:
(JSC::HandleHeap::protectedObjectTypeCounts):
* heap/Local.h:
(JSC::::set):
* heap/Strong.h:
(JSC::Strong::set):
* heap/Weak.h:
(JSC::Weak::set):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
* runtime/WriteBarrier.h:
(JSC::OpaqueJSValue::toJSValue):
(JSC::OpaqueJSValue::toJSValueRef):
(JSC::OpaqueJSValue::fromJSValue):
2011-04-22 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for ENABLE(INTERPRETER) after r84556.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84583.
http://trac.webkit.org/changeset/84583
https://bugs.webkit.org/show_bug.cgi?id=59173
"broke
http://trac.webkit.org/export/84593/trunk/LayoutTests/fast/js
/Object-create.html" (Requested by ggaren on #webkit).
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorCreate):
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
* Configurations/FeatureDefines.xcconfig:
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Object.create creates uncachable objects
https://bugs.webkit.org/show_bug.cgi?id=59164
Use the prototype object's inheritorID, as we
should always have done
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorCreate):
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141
This is just a rename:
markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor
* API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::visitChildren):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):
(JSC::JSCallbackObject::visitChildren):
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
* bytecode/EvalCodeCache.h:
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::visitAggregate):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitAggregate):
* bytecode/StructureStubInfo.h:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
* debugger/DebuggerActivation.h:
* heap/HandleHeap.cpp:
(JSC::WeakHandleOwner::isReachableFromOpaqueRoots):
(JSC::HandleHeap::markStrongHandles):
(JSC::HandleHeap::markWeakHandles):
* heap/HandleHeap.h:
* heap/HandleStack.cpp:
(JSC::HandleStack::mark):
* heap/HandleStack.h:
* heap/Heap.cpp:
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::MarkStack::visitChildren):
(JSC::MarkStack::drain):
* heap/MarkStack.h:
(JSC::HeapRootVisitor::HeapRootVisitor):
(JSC::HeapRootVisitor::mark):
(JSC::HeapRootVisitor::visitor):
* heap/MarkedSpace.h:
* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::markLists):
* runtime/ArgList.h:
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
* runtime/Arguments.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* runtime/JSArray.h:
(JSC::JSArray::visitDirect):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::visitChildren):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::visitIfNeeded):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
* runtime/JSONObject.cpp:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
* runtime/JSObject.h:
(JSC::JSObject::visitDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSStaticScopeObject.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::overridesVisitChildren):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/JSWrapperObject.h:
* runtime/JSZombie.h:
(JSC::JSZombie::visitChildren):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/NativeErrorConstructor.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
* runtime/RegExpObject.h:
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::visitChildren):
* runtime/SmallStrings.h:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
(JSC::StructureChain::createStructure):
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84548.
http://trac.webkit.org/changeset/84548
https://bugs.webkit.org/show_bug.cgi?id=59144
Broke chromium-win build (Requested by aklein on #webkit).
* wtf/Platform.h:
2011-04-21 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
[fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion
https://bugs.webkit.org/show_bug.cgi?id=55728
Enable WTF_MULTIPLE_THREADS for Chromium.
* wtf/Platform.h:
2011-04-20 Michael Saboff <msaboff@apple.com>
Reviewed by Geoff Garen.
JSString::resolveRope inefficient for common 2 fiber case
https://bugs.webkit.org/show_bug.cgi?id=58994
Split JSString::resolveRope into three routines.
resolveRope allocates the new buffer and handles the 1 or 2
fiber case with single level fibers.
resolveRopeSlowCase handles the general case.
outOfMemory handles the rare out of memory exception case.
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory):
* runtime/JSString.h:
2011-04-20 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
Rename all uses of JSC_MULTIPLE_THREADS under wtf/... to WTF_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=59040
This will be used to fix https://bugs.webkit.org/show_bug.cgi?id=55728
by enabling WTF_MULTIPLE_THREADS for Chromium.
* wtf/CryptographicallyRandomNumber.cpp:
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
* wtf/FastMalloc.cpp:
* wtf/Platform.h:
Enable WTF_MULTIPLE_THREADS whenever JSC_MULTIPLE_THREADS is enabled.
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RefCountedLeakCounter.cpp:
(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):
* wtf/dtoa.cpp:
(WTF::pow5mult):
2011-04-20 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff Garen
Bug 59069 - DFG JIT - register allocate r8, r9, r10
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::gprToRegisterID):
2011-04-20 Gavin Barraclough <barraclough@apple.com>
Build fix - revert accidental change.
* wtf/Platform.h:
2011-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Add SAMPLING_FLAGS tool to DFG JIT.
* bytecode/SamplingTool.h:
(JSC::SamplingFlags::addressOfFlags):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
* dfg/DFGJITCompiler.h:
* jit/JITInlineMethods.h:
(JSC::JIT::setSamplingFlag):
(JSC::JIT::clearSamplingFlag):
* wtf/Platform.h:
2011-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 59022 - DFG JIT - Optimize branch-on-relational-compare
If a relational compare (< or <=) is immediately followed by a branch,
we can combine the two, avoiding generation of a boolean into a register.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::invert):
(JSC::MacroAssemblerX86Common::commute):
* dfg/DFGNode.h:
(JSC::DFG::Node::adjustedRefCount):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isJSConstantWithInt32Value):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
2011-04-20 Gavin Barraclough <barraclough@apple.com>
ARMv7 build fix II.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):
2011-04-20 Gavin Barraclough <barraclough@apple.com>
ARMv7 build fix.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::test8):
2011-04-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950
The MacroAssembler currently exposes x86's weird behaviour that the 'setcc'
instruction only sets the low 8 bits of a register. Stop that.
Having done so, to clarify remove the 'set32' prefix from test & compare
instructions - these methods all now set a full 32/64 bit register (Ptr size).
The size in the function name should indicate the amount of data being compared.
Also split out the 'Condition' enum into 'RelationalCondition' and
'ResultCondition'. The former is used in binary comparison, the latter is a unary
condition check on the result of an operation.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branch16):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::comparePtr):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::branchTest8):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARM::branch16):
(JSC::MacroAssemblerARM::branchTest8):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::branchNeg32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::test8):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ARMCondition):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branch32):
(JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest32):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::branchAdd32):
(JSC::MacroAssemblerARMv7::branchMul32):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::branchSub32):
(JSC::MacroAssemblerARMv7::compare32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::test8):
(JSC::MacroAssemblerARMv7::branchPtrWithPatch):
(JSC::MacroAssemblerARMv7::makeBranch):
(JSC::MacroAssemblerARMv7::armV7Condition):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::branch16):
(JSC::MacroAssemblerMIPS::branchTest32):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchOr32):
(JSC::MacroAssemblerMIPS::compare32):
(JSC::MacroAssemblerMIPS::test8):
(JSC::MacroAssemblerMIPS::test32):
(JSC::MacroAssemblerMIPS::branchPtrWithPatch):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branch32):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch8):
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
(JSC::MacroAssemblerX86Common::branchNeg32):
(JSC::MacroAssemblerX86Common::branchOr32):
(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::x86Condition):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::comparePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr):
(JSC::MacroAssemblerX86_64::branchSubPtr):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::branchTest8):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Cleanup includepath adjustment for generated files
https://bugs.webkit.org/show_bug.cgi?id=58869
* JavaScriptCore.pri: Add the directory of generated files to the include
path with absolute path to make it valid in the final build step.
2011-04-19 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove unneeded deprecated methods from MarkStack
https://bugs.webkit.org/show_bug.cgi?id=58853
Remove deprecated methods
* heap/MarkStack.h:
2011-04-19 Mark Rowe <mrowe@apple.com>
Things work best when the Xcode project refers to the file at a path that exists.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-04-19 Renata Hodovan <reni@webkit.org>
Reviewed by Eric Seidel.
Move the alignment related macros in Vector.h to new Alignment.h.
https://bugs.webkit.org/show_bug.cgi?id=56000
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Alignment.h: Added.
* wtf/CMakeLists.txt:
* wtf/Vector.h:
2011-04-19 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
Remove the class an all functions that still exist to support it.
* heap/MarkStack.h:
(JSC::MarkStack::append):
* runtime/JSValue.h:
* runtime/WriteBarrier.h:
2011-04-19 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin
Add U+FEFF (Zero width no-break space) to CharacterNames.h.
It's added to the list of characters to treat as zero-width
in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=48860
* wtf/unicode/CharacterNames.h:
2011-04-19 Csaba Osztrogonác <ossy@webkit.org>
[Qt] REGRESSION(84176): http/tests/xmlhttprequest/event-listener-gc.html fails
https://bugs.webkit.org/show_bug.cgi?id=58871
Unreviewed, rolling out r84176, r84178, r84186, r84212 and r84231.
http://trac.webkit.org/changeset/84176 (original patch)
http://trac.webkit.org/changeset/84178 (original patch - part 2)
http://trac.webkit.org/changeset/84186 (build fix)
http://trac.webkit.org/changeset/84212
http://trac.webkit.org/changeset/84231 (skip failing test)
original bugs:
- https://bugs.webkit.org/show_bug.cgi?id=58718
- https://bugs.webkit.org/show_bug.cgi?id=58853
* heap/MarkStack.h:
(JSC::MarkStack::deprecatedAppendValues):
(JSC::MarkStack::append):
(JSC::MarkStack::deprecatedAppend):
* runtime/JSValue.h:
* runtime/WriteBarrier.h:
(JSC::DeprecatedPtr::DeprecatedPtr):
(JSC::DeprecatedPtr::get):
(JSC::DeprecatedPtr::operator*):
(JSC::DeprecatedPtr::operator->):
(JSC::DeprecatedPtr::slot):
(JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
(JSC::DeprecatedPtr::operator!):
(JSC::operator==):
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove unneeded deprecated methods from MarkStack
https://bugs.webkit.org/show_bug.cgi?id=58853
Remove deprecated methods
* heap/MarkStack.h:
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Adam Roben.
Off by one initialising repeat callframe
https://bugs.webkit.org/show_bug.cgi?id=58838
<rdar://problem/8756810>
If the end of a callframe made for a repeat call landed on
a page boundary the following page may not have been committed
which means that the off by one could lead to a crash. However
it could only happen in this case and only on windows which is
why it was so hard to repro. Alas given the steps needed to
reproduce are such that it's not really possible to make a
testcase.
This fix makes the code a little less squirrely by not trying
to avoid the unnecessary initialisation of |this|.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::prepareForRepeatCall):
2011-04-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 58829 - DFG JIT - Optimize add/sub immediate, multiply.
Add code generation for add/subtract instruction with immediate operands
(where a child is a constant), and don't bail to non-speculative if an
integer multiple results in a +0 result (only if it should be generating -0).
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDoubleConstantWithInt32Value):
2011-04-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 58817 - DFG JIT - if speculative compilation fails, throw away code.
If we detect a logical conflict, throw away generated code,
and only compile through the NonSpeculativeJIT.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::rewindToLabel):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::rewindToOffset):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchSub32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkSpeculationChecks):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
As simple as it sounds.
* runtime/JSValue.h:
* runtime/WriteBarrier.h:
2011-04-17 Cameron Zwarich <zwarich@apple.com>
Reviewed by Dan Bernstein.
JSC no longer builds with Clang due to -Woverloaded-virtual warning
https://bugs.webkit.org/show_bug.cgi?id=58760
Rename Structure's specificValue overload of put to putSpecificValue to avoid
Clang's warning for overloading a virtual function.
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::putSpecificValue):
* runtime/Structure.h:
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Remove WTF_PLATFORM_SGL
https://bugs.webkit.org/show_bug.cgi?id=58743
WTF_PLATFORM_SGL and PLATFORM(SGL) are not used in the code anywhere.
* wtf/Platform.h:
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
* wtf/Platform.h:
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
* wtf/Platform.h:
2011-04-16 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
* wtf/Platform.h:
* wtf/gobject/GTypedefs.h:
2011-04-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84067.
http://trac.webkit.org/changeset/84067
https://bugs.webkit.org/show_bug.cgi?id=58724
qt build are failing. (Requested by loislo2 on #webkit).
* heap/MarkStack.h:
(JSC::MarkStack::append):
* runtime/JSValue.h:
* runtime/WriteBarrier.h:
(JSC::DeprecatedPtr::DeprecatedPtr):
(JSC::DeprecatedPtr::get):
(JSC::DeprecatedPtr::operator*):
(JSC::DeprecatedPtr::operator->):
(JSC::DeprecatedPtr::slot):
(JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
(JSC::DeprecatedPtr::operator!):
(JSC::operator==):
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
* Configurations/FeatureDefines.xcconfig:
2011-04-15 Gavin Barraclough <barraclough@apple.com>
Errrk! - build fix from !x86-64.
* dfg/DFGNode.h:
2011-04-15 David Levin <levin@chromium.org>
Revert of r83974.
JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=58716
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/tests/RunAllWtfTests.cpp: Removed.
* wtf/tests/StringTests.cpp: Removed.
2011-04-15 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
As simple as it sounds.
* heap/MarkStack.h:
(JSC::MarkStack::append):
* runtime/JSValue.h:
* runtime/WriteBarrier.h:
2011-04-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add a simple tool to gather statistics on whether functions
are completed through the new or old JIT.
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
2011-04-15 Oliver Hunt <oliver@apple.com>
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Rolling r83894 r83827 r83810 r83809 r83808 back in with
a workaround for the gcc bug seen by the gtk bots
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
* API/JSContextRef.cpp:
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::markStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/CodeBlock.h:
(JSC::MethodCallLinkInfo::setSeen):
(JSC::GlobalResolveInfo::GlobalResolveInfo):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::markAggregate):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::markAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* heap/Handle.h:
* heap/MarkStack.cpp:
(JSC::MarkStack::markChildren):
(JSC::MarkStack::drain):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
* heap/Strong.h:
(JSC::Strong::Strong):
(JSC::Strong::set):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::uncachePutByID):
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::uncacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::storePtrWithWriteBarrier):
* jsc.cpp:
(cleanupGlobalData):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::constructArrayWithSizeQuirk):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::arrayProtoFuncSplice):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::create):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
* runtime/Executable.cpp:
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::createStructure):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
(JSC::JSByteArray::createStructure):
* runtime/JSByteArray.h:
(JSC::JSByteArray::JSByteArray):
* runtime/JSCell.cpp:
(JSC::isZombie):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::addressOfStructure):
(JSC::JSCell::JSCell::structure):
(JSC::JSCell::JSCell::markChildren):
(JSC::JSCell::JSValue::isZombie):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
(JSC::JSGlobalData::createLeaked):
* runtime/JSGlobalData.h:
(JSC::allocateGlobalHandle):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::markChildren):
(JSC::JSGlobalObject::copyGlobalsFrom):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::createStructure):
(JSC::Structure::prototypeChain):
(JSC::Structure::isValid):
(JSC::constructEmptyArray):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSObject::JSObject):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::createStructure):
(JSC::JSFinalObject::JSFinalObject):
(JSC::constructEmptyObject):
(JSC::createEmptyObjectStructure):
(JSC::JSObject::~JSObject):
(JSC::JSObject::setPrototype):
(JSC::JSObject::setStructure):
(JSC::JSObject::inheritorID):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::transitionTo):
(JSC::JSObject::markChildrenDirect):
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSObjectWithGlobalObject.h:
(JSC::JSObjectWithGlobalObject::createStructure):
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::Structure::setEnumerationCache):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::JSStaticScopeObject):
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::createStructure):
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
* runtime/JSValue.h:
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::copyRegisterArray):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/JSZombie.cpp:
* runtime/JSZombie.h:
(JSC::JSZombie::JSZombie):
(JSC::JSZombie::createStructure):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
(JSC::NativeErrorConstructor::markChildren):
(JSC::constructWithNativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::createStructure):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::PropertyTable):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::createStructure):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::createStructure):
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::put):
(JSC::Structure::markChildren):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::setPrototypeWithoutTransition):
(JSC::Structure::createStructure):
(JSC::JSCell::createDummyStructure):
(JSC::StructureTransitionTable::keyForWeakGCMapFinalizer):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
(JSC::StructureChain::markChildren):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::head):
(JSC::StructureChain::createStructure):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::finalizerContextFor):
(JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::slot):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::clearSingleTransition):
(JSC::StructureTransitionTable::setSingleTransition):
* runtime/WeakGCMap.h:
(JSC::DefaultWeakGCMapFinalizerCallback::finalizerContextFor):
(JSC::DefaultWeakGCMapFinalizerCallback::keyForFinalizer):
(JSC::WeakGCMap::contains):
(JSC::WeakGCMap::find):
(JSC::WeakGCMap::remove):
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
(JSC::WeakGCMap::finalize):
* runtime/WriteBarrier.h:
(JSC::writeBarrier):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Gavin Barraclough.
Correctly prefix symbols. Since gcc 4.5.0, Windows x64 symbols
are not prefixed by underscore anymore. This is consistent with
what MSVC does.
https://bugs.webkit.org/show_bug.cgi?id=58573
* jit/JITStubs.cpp:
2011-04-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 58705 - DFG JIT Add support for flow control (branch, jump).
Add support for control flow by breaking the CodeBlock up into multiple
basic blocks, generating code for each basic block in turn through the
speculative JIT & then the non-speculative JIT.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeOffset):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
(JSC::DFG::JITCodeGenerator::addBranch):
(JSC::DFG::JITCodeGenerator::linkBranches):
(JSC::DFG::JITCodeGenerator::BranchRecord::BranchRecord):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::takenBytecodeOffset):
(JSC::DFG::Node::notTakenBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
2011-04-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 58701 - DFG JIT - add GetLocal/SetLocal nodes
Use these for both access to arguments & local variables, adds ability
to set locals, such that values will persist between basic blocks.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::VariableRecord::VariableRecord):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::derefChildren):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::local):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-04-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 58696 - DFG JIT split handling of vars/temporaries
Presently all callee registers are treated as having single block scope,
since the DFG JIT can only compile single block functions. In order to
expand the JIT to support control flow we will need to change to retaining
locals (but not temporaries) across basic block boundaries.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getTemporary):
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::getInt32Constant):
(JSC::DFG::ByteCodeParser::getDoubleConstant):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::constantUndefined):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
* dfg/DFGNode.h:
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
2011-04-15 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
https://bugs.webkit.org/show_bug.cgi?id=58677
Moved JSObjectWithGlobalObject::globalObject() to
runtime/JSObjectWithGlobalObject.h to allow the compiler to inline
it for a performance benefit. An equivalent instance had been in
a header file before r60057.
* JavaScriptCore.exp:
* runtime/JSObjectWithGlobalObject.cpp:
* runtime/JSObjectWithGlobalObject.h:
(JSC::JSObjectWithGlobalObject::globalObject):
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make JSNodeFilterCondition handle its lifetime correctly
https://bugs.webkit.org/show_bug.cgi?id=58622
Add export
* JavaScriptCore.exp:
2011-04-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Password field input does not switch to ASCII-compatible source
https://bugs.webkit.org/show_bug.cgi?id=58583
<rdar://problem/9059651>
* wtf/Platform.h: Removed WTF_USE_CARBON_SECURE_INPUT_MODE. It's now only used by Chromium,
and shouldn't be enabled on any other platforms, so there is no reason to make it
configurable via Platform.h.
2011-04-15 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
Add a sample test case for GTest framework
https://bugs.webkit.org/show_bug.cgi?id=58509
Add an example of GTest testcase, complete with a runner, to JavaScriptCore.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/tests/RunAllWtfTests.cpp: Added.
(main):
* wtf/tests/StringTests.cpp: Added.
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-14 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoffrey Garen.
Hide DFG_JIT_RESTRICTIONS behind ARITHMETIC_OP() macro, and rename
m_regressionGuard to m_parseFailed, such that it can be reused for
other failure cases.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
2011-04-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Bug 58620 - DFG JIT - loading of arguments should not be lazy
This optimization is overly simplistic. It only works because we never
write out definitions to arguments (since we currently only compile
single block functions). Revert this for now, we may want to reintroduce
something like this again in the future, but it will need to be aware
how to schedule definitions to arguments versus lazy loads that have not
yet been performed.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::needsSpill):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::initConstantInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
2011-04-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Bug 58600 - DFG JIT bugs in ValueToInt, PutByVal
The bug in PutByVal is that an operand is in JSValueOperand - when this
locks an integer into a register it will always retag the value without
checking if the register is already locked. This is a problem where the
value being stored by a PutByVal is the same as the subscript.
The subscript is locked into a register first, as a strict integer.
Locking the value results in the subscript being modified.
The bug in ValueToInt related to the function of sillentFillAllRegisters.
The problem is that this method will restore all register values from
prior to the call, overwriting the result of the call out. Allow a
register to be passed to specifically be excluded from being preserved.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::debugOffset):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::debugOffset):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::debugOffset):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::debugAddress):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::debugOffset):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::orPtr):
* assembler/X86Assembler.h:
(JSC::X86Assembler::debugOffset):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGenerationInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isConstant):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isConstant):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
(JSC::DFG::NonSpeculativeJIT::silentSpillGPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillFPR):
(JSC::DFG::NonSpeculativeJIT::silentFillGPR):
(JSC::DFG::NonSpeculativeJIT::silentFillFPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
2011-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Drain the mark stack while marking weak handles, not after.
https://bugs.webkit.org/show_bug.cgi?id=58574
Otherwise, items that would have caused more weak handle marking are
processed after all weak handle marking has finished, and referenced
weak handles get recycled.
* heap/HandleHeap.cpp:
(JSC::HandleHeap::markWeakHandles): Removed looping from here, since we
want Heap::markRoots to be responsible for draining the mark stack.
* heap/Heap.cpp:
(JSC::Heap::markRoots): Moved looping to here, as explained above.
For efficiency's sake, drain the mark stack before starting to mark weak
handles. Otherwise, items drained while marking weak handles may force
an extra trip through the weak handle list.
For correctness's sake, drain the mark stack each time through the weak
handle list. Otherwise, opaque roots that would make weak handles reachable
are not discovered until after weak handle marking is over.
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make protected object list in caches window reflect reality
https://bugs.webkit.org/show_bug.cgi?id=58565
Make sure the heap includes objects protected by Strong handles
in its list of protected objects.
* heap/HandleHeap.h:
* heap/Heap.cpp:
(JSC::HandleHeap::protectedObjectTypeCounts):
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Anders Carlsson.
Don't emit RegExp tables for chromium where they are not used
https://bugs.webkit.org/show_bug.cgi?id=58544
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* create_regex_tables: Added the "--notables" command line argument.
2011-04-13 Geoffrey Garen <ggaren@apple.com>
Try to fix ASSERTs seen on Windows bots.
* wtf/HashTable.h:
(WTF::hashTableSwap): Force MSVC to use the right version of swap.
2011-04-13 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[CMAKE] Separate DerivedSources.
https://bugs.webkit.org/show_bug.cgi?id=58427
* CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_JAVASCRIPTCORE_DIR.
2011-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
https://bugs.webkit.org/show_bug.cgi?id=58482
This will allow wrappers to make individual decisions about their lifetimes.
* heap/HandleHeap.h:
(JSC::HandleHeap::copyWeak): New function for copying a weak handle.
It's wasn't previously possible to perform this operation using HandleHeap
API because the HandleHeap doesn't expose its underlying Node structure.
* heap/Local.h:
(JSC::::set):
* heap/Strong.h:
(JSC::Strong::set): Added ASSERTs to verify that dead objects are not
resurrected by placement into handles.
(JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
is efficient.
* heap/Weak.h:
(JSC::Weak::Weak): Fixed a bug where copying a weak pointer would not
copy its weak callback and context.
(JSC::Weak::operator=): Added an assignment operator, since the default
C++ assignment operator did the wrong thing.
(JSC::Weak::set): Added ASSERTs to verify that dead objects are not
resurrected by placement into handles.
(JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
is efficient, and can be done without copying, which is illegal during
the handle finalization phase.
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make PropertyMapEntry use a WriteBarrier for specificValue
https://bugs.webkit.org/show_bug.cgi?id=58407
Make PropertyMapEntry use a WriteBarrier for specificValue, and then
propagate the required JSGlobalData through all the methods it ends
up being needed.
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectSetPrototype):
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* interpreter/Interpreter.cpp:
(JSC::appendSourceToError):
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot):
* runtime/JSFunction.cpp:
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::resetPrototype):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::lookupGetter):
(JSC::JSObject::lookupSetter):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::setPrototype):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
* runtime/Operations.h:
(JSC::normalizePrototypeChain):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::copy):
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::put):
(JSC::Structure::getPropertyNames):
* runtime/Structure.h:
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):
2011-04-13 Paul Knight <pknight@apple.com>
Reviewed by Gavin Barraclough.
BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition
https://bugs.webkit.org/show_bug.cgi?id=58405
The BACKTRACE() macro requires JavaScriptCore be built with a Debug
configuration in order for it to be enabled. Move the NDEBUG check to
the header so it will be enabled when the calling framework or
application is built with a Debug configuration, similar to how
ASSERT() and friends work.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
2011-04-12 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=58131
Provide a workaround for an obscure Studio 12 compiler bug, which
couldn't call src->~T() on a const T *src.
* wtf/Vector.h:
2011-04-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=58395
Exceptions thrown from property getters called from Array prototype functions can be missed
This is caught by an ASSERT in the top of Interpreter::executeCall.
Check for exceptions after accessing properties that could be getters.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
- Add exception checks.
2011-04-12 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make API callback objects use weak handles to run their finalizers
https://bugs.webkit.org/show_bug.cgi?id=58389
Make the API object's private data struct act as a finalizer for
an api object if the callback object has a API defined finalizer.
* API/JSCallbackObject.cpp:
(JSC::JSCallbackObjectData::finalize):
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* heap/Handle.h:
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Cleaned up hash traits, and added hash traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58381
* heap/Handle.h:
(JSC::HandleBase::swap):
(JSC::Handle::Handle):
(JSC::Handle::swap): Implemented swap, so we can rehash efficiently, and
without creating new handles (which is not allowed during handle finalization).
* heap/Strong.h:
(JSC::Strong::swap): Use new SimpleClassHashTraits to avoid duplication.
* heap/Weak.h:
(JSC::Weak::isHashTableDeletedValue):
(JSC::Weak::Weak):
(JSC::Weak::swap):
(JSC::Weak::hashTableDeletedValue): Ditto.
* wtf/HashTraits.h:
(WTF::SimpleClassHashTraits::constructDeletedValue):
(WTF::SimpleClassHashTraits::isDeletedValue): Added SimpleClassHashTraits,
which are analogous to SimpleClassVectorTraits, since they are used in a
bunch of places.
* wtf/RetainPtr.h: Use new SimpleClassHashTraits to avoid duplication.
* wtf/text/StringHash.h: Use new SimpleClassHashTraits to avoid duplication.
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Cleaned up some Vector traits, and added missing Vector traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58372
* heap/Local.h: Inherit from SimpleClassVectorTraits to avoid duplication.
* heap/Strong.h: Ditto.
* heap/Weak.h: Ditto.
* parser/JSParser.cpp: Fixed a traits error. No test case because this
particular trait is not currently exercised by the parser.
* runtime/UString.h: No need to override canInitializeWithMemset, since
our base class sets it to true.
* wtf/VectorTraits.h: Inherit from VectorTraitsBase to avoid duplication.
* wtf/text/WTFString.h: No need to override canInitializeWithMemset, since
our base class sets it to true.
2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Eric Seidel.
[Qt] Enable JIT build for SH4 platforms.
https://bugs.webkit.org/show_bug.cgi?id=58317
enable JIT build for QT backend for SH4 platforms.
* JavaScriptCore.pro:
* wtf/Platform.h:
2011-04-11 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=58289
Fix compilation on Solaris/Studio 12 C++ in wtf/FastMalloc.cpp,
WTF::TCMalloc_PageHeap::runScavengerThread(void*) expected to return a value.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::runScavengerThread):
2011-04-11 Mark Rowe <mrowe@apple.com>
Fix the build.
* JavaScriptCore.xcodeproj/project.pbxproj: Headers used outside of JavaScriptCore need to be marked as private.
2011-04-11 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-11 Geoffrey Garen <ggaren@apple.com>
Try to fix a few builds.
Updated a few more build configurations for file moves.
* CMakeListsWinCE.txt:
2011-04-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 58263 - Use EncodedValueDescriptor on both JSVALUE32_64, JSVALUE64
The JSJITInterface already uses EncodedValueDescriptor to access the tag/payload
separately on JSVALUE64, even though EncodedValueDescriptor is not used in
JSVALUE64's implementation of JSValue. Remove the separate definition for m_ptr
on X86_64. Using the union allows us to remove a layer of makeImmediate()/
immedaiteValue() methods.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITInlineMethods.h:
(JSC::JIT::emitTagAsBoolImmediate):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emitSlow_op_not):
* runtime/JSCell.h:
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::encode):
(JSC::JSValue::decode):
(JSC::JSValue::operator==):
(JSC::JSValue::operator!=):
(JSC::JSValue::JSValue):
(JSC::JSValue::operator bool):
(JSC::JSValue::asInt32):
(JSC::JSValue::isUndefinedOrNull):
(JSC::JSValue::isBoolean):
(JSC::JSValue::isCell):
(JSC::JSValue::isInt32):
(JSC::JSValue::asDouble):
(JSC::JSValue::isNumber):
(JSC::JSValue::asCell):
2011-04-11 Geoffrey Garen <ggaren@apple.com>
Try to fix a few builds.
Updated a few more build configurations for file moves.
* CMakeListsEfl.txt:
* wscript:
2011-04-11 Geoffrey Garen <ggaren@apple.com>
Build fix: Updated a file name.
* CMakeLists.txt:
2011-04-11 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Sam Weinig.
Moved remaining heap implementation files to the heap folder.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/ConservativeRoots.cpp: Copied from runtime/ConservativeSet.cpp.
* heap/ConservativeRoots.h: Copied from runtime/ConservativeSet.h.
* heap/Handle.h:
* heap/Heap.cpp:
* heap/MachineStackMarker.cpp: Copied from runtime/MachineStackMarker.cpp.
* heap/MachineStackMarker.h: Copied from runtime/MachineStackMarker.h.
* heap/MarkStack.cpp: Copied from runtime/MarkStack.cpp.
* heap/MarkStack.h: Copied from runtime/MarkStack.h.
* heap/MarkStackPosix.cpp: Copied from runtime/MarkStackPosix.cpp.
* heap/MarkStackSymbian.cpp: Copied from runtime/MarkStackSymbian.cpp.
* heap/MarkStackWin.cpp: Copied from runtime/MarkStackWin.cpp.
* heap/MarkedBlock.cpp: Copied from runtime/MarkedBlock.cpp.
* heap/MarkedBlock.h: Copied from runtime/MarkedBlock.h.
* heap/MarkedSpace.cpp: Copied from runtime/MarkedSpace.cpp.
* heap/MarkedSpace.h: Copied from runtime/MarkedSpace.h.
* interpreter/RegisterFile.cpp:
* runtime/ConservativeSet.cpp: Removed.
* runtime/ConservativeSet.h: Removed.
* runtime/MachineStackMarker.cpp: Removed.
* runtime/MachineStackMarker.h: Removed.
* runtime/MarkStack.cpp: Removed.
* runtime/MarkStack.h: Removed.
* runtime/MarkStackPosix.cpp: Removed.
* runtime/MarkStackSymbian.cpp: Removed.
* runtime/MarkStackWin.cpp: Removed.
* runtime/MarkedBlock.cpp: Removed.
* runtime/MarkedBlock.h: Removed.
* runtime/MarkedSpace.cpp: Removed.
* runtime/MarkedSpace.h: Removed.
2011-04-11 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-04-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 58198 - Clean up JSValue implementation for JSVALUE64
Remove JSNumberCell, JSImmediate, unify some methods between JSVALUE32_64/JSVALUE64
JSNumberCell.h largely just contained the constructors for JSValue on JSVALUE64,
which should not have been here. JSImmediate mostly contained uncalled methods,
along with the internal implementation of the JSValue constructors split unnecessarily
across a number of layers of function calls. These could largely be merged back
together. Many methods and constructors from JSVALUE32_64 and JSVALUE64 can by unified.
The .cpp files were empty.
Moving all these methods into JSValue.h seems to be a repro measurable regression, so
I have kept these methods in a separate JSValueInlineMethods.h. Adding the 64-bit tag
values as static const members of JSValue also measures as a repro regression, so I
have made these #defines.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
- Removed JSImmediate.h, JSNumberCell.h.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
- Removed class JSImmediate.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- Removed class JSImmediate.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Removed class JSImmediate.
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOpSlowCase):
- Removed class JSImmediate.
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfJSCell):
(JSC::JIT::emitJumpIfNotJSCell):
(JSC::JIT::emitJumpIfImmediateInteger):
(JSC::JIT::emitJumpIfNotImmediateInteger):
(JSC::JIT::emitFastArithDeTagImmediate):
(JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
(JSC::JIT::emitFastArithReTagImmediate):
(JSC::JIT::emitTagAsBoolImmediate):
- Removed class JSImmediate.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emitSlow_op_not):
- Removed class JSImmediate.
* jit/JSInterfaceJIT.h:
- Removed class JSImmediate.
* runtime/JSCell.h:
- Removed JSImmediate.h, JSNumberCell.h.
* runtime/JSImmediate.cpp: Removed.
* runtime/JSImmediate.h: Removed.
* runtime/JSNumberCell.cpp: Removed.
* runtime/JSNumberCell.h: Removed.
- Removed.
* runtime/JSObject.h:
- Removed JSImmediate.h, JSNumberCell.h.
* runtime/JSString.h:
- Removed JSImmediate.h, JSNumberCell.h.
* runtime/JSValue.h:
- Added tags for JSVALUE64, moved out some JSVALUE32_64 methods, unified with JSVALUE64.
* runtime/JSValueInlineMethods.h: Added.
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):
(JSC::JSValue::uncheckedGetNumber):
(JSC::JSValue::toJSNumber):
(JSC::jsNaN):
(JSC::JSValue::getNumber):
(JSC::JSValue::getBoolean):
(JSC::JSValue::JSValue):
(JSC::JSValue::encode):
(JSC::JSValue::decode):
(JSC::JSValue::operator bool):
(JSC::JSValue::operator==):
(JSC::JSValue::operator!=):
(JSC::JSValue::isUndefined):
(JSC::JSValue::isNull):
(JSC::JSValue::isUndefinedOrNull):
(JSC::JSValue::isCell):
(JSC::JSValue::isInt32):
(JSC::JSValue::isDouble):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::tag):
(JSC::JSValue::payload):
(JSC::JSValue::asInt32):
(JSC::JSValue::asDouble):
(JSC::JSValue::asCell):
(JSC::JSValue::isNumber):
(JSC::JSValue::isBoolean):
(JSC::JSValue::makeImmediate):
(JSC::JSValue::immediateValue):
(JSC::reinterpretDoubleToIntptr):
(JSC::reinterpretIntptrToDouble):
- Methods moved here from JSImmediate.h/JSNumberCell.h/JSValue.h.
* runtime/Operations.h:
- Removed JSImmediate.h, JSNumberCell.h.
* wtf/StdLibExtras.h:
- Export bitwise_cast.
2011-04-11 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Oliver Hunt.
SH4 JIT SUPPORT.
https://bugs.webkit.org/show_bug.cgi?id=44329
Add JIT remaining part for SH4 platforms.
* assembler/MacroAssemblerSH4.h:
* jit/JIT.h:
* jit/JITInlineMethods.h:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess32_64.cpp:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* jit/JSInterfaceJIT.h:
2011-04-10 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Beth Dakin.
Moved Heap.h and Heap.cpp to the heap folder, because anything less
would be uncivilized.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp: Copied from JavaScriptCore/runtime/Heap.cpp.
* heap/Heap.h: Copied from JavaScriptCore/runtime/Heap.h.
* runtime/Heap.cpp: Removed.
* runtime/Heap.h: Removed.
2011-04-10 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Remove duplicated code from AtomicString::fromUTF8()
https://bugs.webkit.org/show_bug.cgi?id=53711
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::fromUTF8Internal):
* wtf/text/AtomicString.h:
(WTF::AtomicString::fromUTF8):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::calculateStringHashAndLengthFromUTF8):
* wtf/unicode/UTF8.h:
2011-04-10 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
Fix build (at least on Lion) by adding some newish header files to
PrivateHeaders.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-04-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try recommitting some things svn left out of its last commit.
* heap/Handle.h:
(JSC::HandleBase::operator!):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::isValidWeakNode):
* heap/HandleHeap.h:
(JSC::HandleHeap::globalData):
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* API/JSClassRef.h:
* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.h:
* bytecompiler/BytecodeGenerator.h:
* collector: Removed.
* collector/handles: Removed.
* collector/handles/Global.h: Removed.
* collector/handles/Handle.h: Removed.
* collector/handles/HandleHeap.cpp: Removed.
* collector/handles/HandleHeap.h: Removed.
* collector/handles/HandleStack.cpp: Removed.
* collector/handles/HandleStack.h: Removed.
* collector/handles/Local.h: Removed.
* collector/handles/LocalScope.h: Removed.
* heap: Copied from collector.
* heap/Handle.h: Copied from collector/handles/Handle.h.
* heap/HandleHeap.cpp: Copied from collector/handles/HandleHeap.cpp.
* heap/HandleHeap.h: Copied from collector/handles/HandleHeap.h.
* heap/HandleStack.cpp: Copied from collector/handles/HandleStack.cpp.
* heap/HandleStack.h: Copied from collector/handles/HandleStack.h.
* heap/Local.h: Copied from collector/handles/Local.h.
* heap/LocalScope.h: Copied from collector/handles/LocalScope.h.
* heap/Strong.h: Copied from collector/handles/Global.h.
(JSC::Strong::Strong):
(JSC::Strong::~Strong):
(JSC::Strong::operator=):
* heap/Weak.h: Copied from runtime/WeakGCPtr.h.
(JSC::Weak::Weak):
(JSC::Weak::~Weak):
* heap/handles: Removed.
* interpreter/RegisterFile.h:
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/Structure.h:
* runtime/WeakGCPtr.h: Removed.
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* Configurations/FeatureDefines.xcconfig:
2011-04-08 Gavin Barraclough <barraclough@apple.com>
Ooops, typo, build fix.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
2011-04-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 58154 - Add support for comparison operators to the DFG JIT.
Add support for <, <=, ==, ===, and also !. Add support for all corresponding
bytecode ops, including the not- and -null forms. Initially add functionally
correct support, we'll revisit the performance.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::parse):
- Add support for parsing of bytecode opcodes,
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
- Add new operation call types, return bool values.
* dfg/DFGNode.h:
- Add new node types.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- Add code generation for new nodes.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationCompareLess):
(JSC::DFG::operationCompareLessEq):
(JSC::DFG::operationCompareEq):
(JSC::DFG::operationCompareStrictEq):
(JSC::DFG::dfgConvertJSValueToBoolean):
* dfg/DFGOperations.h:
- Add operation callbacks to implement new ops.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Add code generation for new nodes.
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePatchGetArrayLength):
- Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
* runtime/JSImmediate.h:
- Make tag values public, rather than relying on a friend - this matches JSVALUE32_64.
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
https://bugs.webkit.org/show_bug.cgi?id=58030
* wtf/Platform.h: Introduce USE(UNIX_DOMAIN_SOCKETS) for WebKit2.
2011-04-08 Adam Roben <aroben@apple.com>
Clean build fix
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Don't try to delete directories that
don't exist. Also switched from del /s to rmdir /s, which has the benefit of deleting the
directory itself in addition to the files it contains.
2011-04-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Some Handle<T> cleanup
https://bugs.webkit.org/show_bug.cgi?id=58109
* bytecode/SamplingTool.h: Sorted alphabetically because that's the
WebKit style. Added a Global.h #include that was previously missing
but harmless.
* collector/handles/Global.h:
(JSC::Global::Global): Added a null constructor. No need for a special
tag, and the tag is incompatible with some data structures.
(JSC::Global::isHashTableDeletedValue):
(JSC::Global::~Global):
(JSC::Global::set):
(JSC::Global::operator=):
(JSC::Global::clear):
(JSC::Global::hashTableDeletedValue): Reordered constructors to be near
each other.
(JSC::Global::setWithWriteBarrier): Renamed internalSet to
setWithWriteBarrier for clarity, and funneled more code into using set
and setWithWriteBarrier to reduce duplication.
* collector/handles/Handle.h:
(JSC::HandleBase::operator!):
(JSC::HandleBase::HandleBase): Removed isEmpty(), since we already have
boolean and ! operators.
(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle): Added general support for null Handles. This was
previously outlawed by ASSERTs, but our code has grown to support and
rely on null Handles.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::isValidWeakNode): Migrated from isValidWeakHandle,
and beefed this up a bit.
* collector/handles/HandleHeap.h:
(JSC::HandleHeap::globalData): Added accessor, used by some new set functions.
* collector/handles/Local.h: Moved hash traits to the bottom of the file,
since this file is about the Local class, not the traits.
(JSC::::Local): Updated for removal of invalidate().
(JSC::::operator): Deployed "using" to avoid a lot of this->
template funny business.
(JSC::::setWithSlotCheck): Renamed from internalSet, more specific now.
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile): Updated to use null constructor.
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/JSPropertyNameIterator.h:
(JSC::Structure::setEnumerationCache):
* runtime/Structure.h: Removed clearEnumerationCache
because it was an unused holdover from when the enumeration cache was
not a handle.
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::set): Finish initializing our handle before putting it
in the table. This seemed more logical, and at one point was required
to avoid triggering an ASSERT.
* runtime/WeakGCPtr.h: Inherit from Handle instead of rolling our own
handle-like behavior, to avoid duplication.
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::~WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::set):
(JSC::WeakGCPtr::setWithWriteBarrier): Removed duplicate code and
standardized on Handle idioms.
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Martin Robinson.
Refactor Gtk build system to separate list of files
https://bugs.webkit.org/show_bug.cgi?id=58090
This is the first step towards generating part of the GTK build system
using GYP. In the first iteration, our plan is to just generate the
list of files. This patch is the first step, which is to separate out
the part of JavaScriptCore build system that we intend to generate from
the rest of the build system.
* GNUmakefile.am:
* GNUmakefile.list.am: Added.
2011-04-07 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Gavin Barraclough.
Mapping booleans the same way as integers
https://bugs.webkit.org/show_bug.cgi?id=56913
Instead of having a seperate tag field for booleans,
the logical values are stored in the payload field
(for JSValue32_64 representation).
1.007x speedup on SunSpider.
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreBool):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JSInterfaceJIT.h:
* runtime/JSValue.h:
(JSC::JSValue::JSValue):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::getBoolean):
2011-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add stub support for generating Gtk build system from gyp
https://bugs.webkit.org/show_bug.cgi?id=58086
This does not produce a buildable JavaScriptCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.
* gyp/gtk.gyp: Added.
2011-04-07 Andrew Scherkus <scherkus@chromium.org>
Revert ENABLE_TRACK patch due to compile failures.
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Adam Barth <abarth@webkit.org>
Fix whitespace in GNUmakefile.am.
* GNUmakefile.am:
2011-04-07 Gavin Barraclough <barraclough@apple.com>
Fix a couple of typos in comments that Darin spotted.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
* runtime/JSImmediate.h:
2011-04-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 58057 - Store boolean payload in low bit of JSImmediate
And remove some uncalled functions from JSImmediate.h
* jit/JITInlineMethods.h:
(JSC::JIT::emitTagAsBoolImmediate):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
* runtime/JSImmediate.h:
(JSC::JSImmediate::makeInt):
(JSC::JSImmediate::makeBool):
(JSC::JSImmediate::intValue):
(JSC::JSImmediate::boolValue):
(JSC::JSImmediate::asInt32):
(JSC::JSImmediate::toDouble):
(JSC::JSValue::asInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):
2011-04-07 Liang Qi <liang.qi@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Enable webkit build with GCCE on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=57841
* wtf/MathExtras.h: GCCE compiler doesn't support those std static functions.
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
2011-04-06 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Darin Adler.
Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
https://bugs.webkit.org/show_bug.cgi?id=27551
* config.h:
2011-04-06 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Stop JSObject::isUsingInlineStorage() from using the structure
https://bugs.webkit.org/show_bug.cgi?id=57986
Make the isUsingInlineStorage() implementation just look at
whether the property storage is inside the object.
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
2011-04-06 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff Garen.
Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.
* runtime/JSImmediate.h:
* runtime/JSValue.h:
2011-04-06 Lucas De Marchi <lucas.demarchi@profusion.mobi>
cmake: Fix build for ARMv7
* CMakeLists.txt: add missing file.
2011-04-06 Liang Qi <liang.qi@nokia.com>
Reviewed by Benjamin Poulain.
Correct a include file name.
https://bugs.webkit.org/show_bug.cgi?id=57839
* wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix
builds on Unix hosts.
2011-04-06 Adam Roben <aroben@apple.com>
Build fix after r83056
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.
2011-04-06 Adam Roben <aroben@apple.com>
Move JavaScriptCoreGenerated's file-copying logic out to a new script
Hopefully this will make it easier to modify this logic in the future. I also made the
script much quieter than the old logic, since it didn't seem helpful to see long lists of
filenames during the copying phase.
If we like this new style, we could copy it for our other projects.
Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
modify and noisy
Reviewed by Steve Falkenburg.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy
files from here...
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd
for convenience.
2011-04-05 Geoffrey Garen <ggaren@apple.com>
Try to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Who likes export files? I do!
2011-04-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Introduced the concept of opaque roots, in preparation for marking the DOM with them
https://bugs.webkit.org/show_bug.cgi?id=57903
* JavaScriptCore.exp: Who likes export files? I do!
* collector/handles/HandleHeap.cpp:
(JSC::isValidWeakHandle): Factored out a helper function for ASSERTs.
(JSC::WeakHandleOwner::~WeakHandleOwner): Moved from header to avoid
weak linkage problems.
(JSC::WeakHandleOwner::isReachableFromOpaqueRoots): New callback.
Currently unused.
(JSC::WeakHandleOwner::finalize): Switched from pure virtual to a
default empty implementation, since not all clients necessarily want
or need non-trivial finalizers.
(JSC::HandleHeap::markWeakHandles): Split updateWeakHandles into two
passes. The first pass marks all reachable weak handles. The second pass
finalizes all unreachable weak handles. This must be two passes because
we don't know the set of finalizable weak handles until we're done
marking all weak handles.
(JSC::HandleHeap::finalizeWeakHandles): Use new helper function.
* collector/handles/HandleHeap.h: Ditto.
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots):
(JSC::Heap::reset): Split out handle marking from handle finalization.
* runtime/MarkStack.cpp:
(JSC::MarkStack::reset):
* runtime/MarkStack.h:
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::HeapRootMarker::markStack): New helper functions for managing the
set of opaque roots.
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::finalize): Renamed to match parent class declaration.
2011-04-05 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Darin Adler.
Build fix for YarrParser.h
https://bugs.webkit.org/show_bug.cgi?id=57822
* yarr/YarrParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
2011-04-05 Steve Falkenburg <sfalken@apple.com>
Follow-up Windows build fix.
Don't skip react-to-vsprops-changes.py for all production builds,
only those initiated via JavaScriptCore.make.
* JavaScriptCore.vcproj/JavaScriptCore.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
2011-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION (r82849): 85,000+ JSC-related leaks seen on SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=57857
Whoops, accidentally removed a deref().
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
2011-04-05 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add per-configuration vsprops files.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Removed inheritance from common.vsprops.
Set production environment variable before calling make.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops: Added.
2011-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make caches window show more info about non-jsobject GC values
https://bugs.webkit.org/show_bug.cgi?id=57874
Add ClassInfo to the various internal JS types that currently
don't have any, and make the text for caches window show the
classname for non-JSObject instances.
* runtime/Executable.cpp:
* runtime/Executable.h:
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/Heap.cpp:
(JSC::TypeCounter::typeName):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/ScopeChain.cpp:
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::createStructure):
* runtime/StructureChain.cpp:
* runtime/StructureChain.h:
(JSC::StructureChain::createStructure):
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Cleanup StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=57836
Don't use PassRefPtr in local variables, properly store in RefPtrs and release on return.
Add a makeString() variant taking 9 arguments, needed by a follow-up patch.
* wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
(WTF::makeString):
2011-04-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82876.
http://trac.webkit.org/changeset/82876
https://bugs.webkit.org/show_bug.cgi?id=57816
Caused a lot of test crashes (Requested by tkent on #webkit).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::fastMallocSize):
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMallocStats::malloc):
(WTF::TCMallocStats::free):
(WTF::TCMallocStats::fastCalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::calloc):
(WTF::TCMallocStats::fastRealloc):
(WTF::TCMallocStats::tryFastRealloc):
(WTF::TCMallocStats::realloc):
(WTF::TCMallocStats::fastMallocSize):
* wtf/FastMalloc.h:
(WTF::Internal::fastMallocMatchValidationType):
(WTF::Internal::fastMallocMatchValidationValue):
(WTF::Internal::setFastMallocMatchValidationType):
(WTF::fastMallocMatchValidateFree):
* wtf/Platform.h:
2011-04-04 Oliver Hunt <oliver@apple.com>
Reviewed by Antti Koivisto.
Stop JSCell.h from including Structure.h
https://bugs.webkit.org/show_bug.cgi?id=57809
* runtime/GetterSetter.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toThisObject):
* runtime/JSString.h:
* runtime/ScopeChain.h:
* runtime/Structure.h:
(JSC::JSCell::isObject):
(JSC::JSCell::isString):
(JSC::JSCell::classInfo):
(JSC::JSCell::createDummyStructure):
(JSC::JSValue::needsThisConversion):
(JSC::MarkStack::internalAppend):
* runtime/StructureChain.h:
2011-04-04 Oliver Hunt <oliver@apple.com>
Fix clang build.
* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastRealloc):
2011-04-04 Oliver Hunt <oliver@apple.com>
Remove accidental change to Platform.h
* wtf/Platform.h:
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed a weak-handle-related leak in RegisterFile
https://bugs.webkit.org/show_bug.cgi?id=57793
* interpreter/RegisterFile.cpp: Nixed leaky GlobalObjectNotifier.
* interpreter/RegisterFile.h:
(JSC::RegisterFile::GlobalObjectOwner::finalize):
(JSC::RegisterFile::RegisterFile): Replaced GlobalObjectNotifier with
a per-RegisterFile weak handle owner, which does not leak.
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::set): Allow set() to take a context argument, since
RegisterFile now needs this. (Seems like it was an accidental omission
all along.)
2011-04-04 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make malloc validation useful
https://bugs.webkit.org/show_bug.cgi?id=57502
This patch changes FAST_MALLOC_MATCH_VALIDATION with a general
corruption check that tags the beginning and end of all allocations
to check for write overflows and overwrites the contents of
memory on free in order to (hopefully) show up use-after-free issues
sooner.
We also turn it on by default for debug builds.
* JavaScriptCore.exp:
* wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMallocStats::malloc):
(WTF::TCMallocStats::free):
(WTF::TCMallocStats::fastCalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::calloc):
(WTF::TCMallocStats::fastRealloc):
(WTF::TCMallocStats::tryFastRealloc):
(WTF::TCMallocStats::realloc):
* wtf/FastMalloc.h:
(WTF::Internal::fastMallocValidationHeader):
(WTF::Internal::fastMallocValidationSuffix):
(WTF::Internal::fastMallocMatchValidationType):
(WTF::Internal::setFastMallocMatchValidationType):
(WTF::fastMallocMatchValidateFree):
(WTF::fastMallocValidate):
* wtf/Platform.h:
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
https://bugs.webkit.org/show_bug.cgi?id=57790
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::updateWeakHandles): Updated for rename.
* collector/handles/HandleHeap.h: Removed comment claiming that this
function should only be called during teardown, because it's actually
called after every GC pass.
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots): Updated for rename.
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Standardized handling of handles for immediate values
https://bugs.webkit.org/show_bug.cgi?id=57788
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::clearWeakPointers): Don't check for null or non-cell
values here, because our write barrier guarantees that such values are
not in the weak list.
(JSC::HandleHeap::writeBarrier): Standardized on checking for null before
checking for cell, and on using early return instead of if/else.
* collector/handles/HandleHeap.h:
(JSC::HandleHeap::deallocate):
(JSC::HandleHeap::makeWeak): Ditto.
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Removed a redundant variable from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57786
Forgot to commit the file that actually removes the data member!
* collector/handles/HandleHeap.h:
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a redundant variable from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57786
We don't need a specific variable to indicate that we're in the middle
of the finalization phase, since m_nextToFinalize already does this.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::HandleHeap):
(JSC::HandleHeap::clearWeakPointers):
(JSC::HandleHeap::writeBarrier):
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed Finalizer => WeakHandleOwner (in preparation for adding a reachability callback)
https://bugs.webkit.org/show_bug.cgi?id=57775
Also renamed noFinalizer => emptyWeakOwner, since this is really an
optimization for a weak owner with empty callbacks.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::clearWeakPointers): Updated for renames. Removed
redundant initialization of m_nextToFinalize. Moved deletion check inside
weak owner check, since the weak owner can't delete the node if there is
no weak owner!
* collector/handles/HandleHeap.h:
(JSC::WeakHandleOwner::~WeakHandleOwner):
(JSC::HandleHeap::makeWeak): Updated for renames.
(JSC::HandleHeap::hasWeakOwner): Changed getFinalizer to hasWeakOwner,
to clarify this function's role in assertions.
(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::weakOwner):
(JSC::HandleHeap::Node::weakOwnerContext):
(JSC::HandleHeap::Node::emptyWeakOwner):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::globalObjectCollectedNotifier):
* interpreter/RegisterFile.h:
* runtime/WeakGCMap.h:
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::set): Updated for renames.
2011-04-04 Oliver Hunt <oliver@apple.com>
Fix WinCE build.
* bytecode/Instruction.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID):
2011-04-04 Adam Roben <aroben@apple.com>
Delete mt.dep files when doing a clean build due to .vsprops file changes
Apparently this is yet another file that Visual Studio can't figure out it needs to rebuild.
Fixes <http://webkit.org/b/57777> r82850 failed to build on Windows Debug (Build)
Reviewed by Brian Weinstein.
* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Added dep to the list of extensions we look for when choosing files to delete.
2011-04-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Make StructureChain GC allocated, and make the various owners
mark it correctly.
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::derefStructures):
(JSC::PolymorphicAccessStructureList::markAggregate):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::markAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
* collector/handles/Handle.h:
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeChain):
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::markChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
(JSC::JSPropertyNameIterator::markChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
* runtime/JSZombie.cpp:
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h:
* runtime/MarkStack.h:
(JSC::MarkStack::append):
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::markAggregate):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
(JSC::StructureChain::~StructureChain):
(JSC::StructureChain::markChildren):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::createStructure):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
2011-04-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed some complexity from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57650
Eliminated pointer-tagging flags.
Tied being weak to having a finalizer (or at least a finalizer sentinel).
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::clearWeakPointers): Removed the special self-destroying
flag. It was unused. If we bring it back, we'll probably use a shared
autodeallocating finalizer instead.
* collector/handles/HandleHeap.h:
(JSC::HandleHeap::makeWeak): makeWeak and adding a finalizer are now
a single, atomic operation -- this makes the relationship between
finalizers and weak pointers clearer, and impossible to get wrong.
(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::handleHeap): No more flags.
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak): Ditto above. We use a special sentienl
value in the finalizer slot to indicate that a handle is weak but doesn't
require an external function call for finalization.
2011-04-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed WeakGCMap::deprecatedRemove because it was deprecated and unused
https://bugs.webkit.org/show_bug.cgi?id=57648
* runtime/WeakGCMap.h:
2011-04-01 Adam Roben <aroben@apple.com>
Maintain the invariant that Lexer::m_current is set to -1 when at the end of the code buffer
Covered by existing tests.
Fixes <http://webkit.org/b/56699>.
Reviewed by Oliver Hunt.
* parser/Lexer.h:
(JSC::Lexer::setOffset): Copied code from Lexer::shift to update m_current, because
supposedly the idiom that function uses is fast.
2011-03-31 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Oliver Hunt.
SH4 JIT SUPPORT.
https://bugs.webkit.org/show_bug.cgi?id=44329
Add YARR support for SH4 platforms (disabled by default).
* GNUmakefile.am:
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerSH4.cpp: Added.
* assembler/MacroAssemblerSH4.h: Added.
* assembler/SH4Assembler.h: Added.
* yarr/YarrJIT.cpp:
2011-03-30 Adam Roben <aroben@apple.com>
Clean build fix
* JavaScriptCore.vcproj/JavaScriptCore.sln: Serialized project dependencies so projects
don't try to build in parallel (which doesn't mesh with our buildfailed mechanism).
2011-03-30 Oliver Hunt <oliver@apple.com>
Rollout r82500
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::derefStructures):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeChain):
* runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
(JSC::JSPropertyNameIterator::markChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
* runtime/MarkStack.h:
(JSC::MarkStack::append):
* runtime/Structure.h:
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
2011-03-29 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG
https://bugs.webkit.org/show_bug.cgi?id=53134
* wtf/Platform.h: Added in WTF flag for using the Accelerate framework
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
* JavaScriptCore.vcproj/WTF/WTFRelease.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
* JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
* JavaScriptCore.vcproj/jsc/jscRelease.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
* JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
* JavaScriptCore.vcproj/testapi/testapiRelease.vsprops:
* JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops:
2011-03-30 Mark Rowe <mrowe@apple.com>
Reviewed by Adam Roben.
Explicitly prevent testapi and minidom from being installed rather than relying
on Xcode's current behavior of not installing if INSTALL_PATH is not explicitly
set at the target level.
<rdar://problem/9206357>
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-03-30 Timur Iskhodzhanov <timurrrr@google.com>
Reviewed by Alexey Proskuryakov.
Add some dynamic annotations to JavaScriptCore/wtf
https://bugs.webkit.org/show_bug.cgi?id=53747
By using these annotations we can improve the precision of finding
WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
These files don't add new functionality, so don't need extra tests.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/DynamicAnnotations.cpp: Added.
(WTFAnnotateBenignRaceSized):
(WTFAnnotateHappensBefore):
(WTFAnnotateHappensAfter):
* wtf/DynamicAnnotations.h: Added.
* wtf/ThreadSafeRefCounted.h:
(WTF::ThreadSafeRefCountedBase::derefBase):
* wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
2011-03-30 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Make StructureChain GC allocated, and make the various owners
mark it correctly.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::derefStructures):
(JSC::PolymorphicAccessStructureList::markAggregate):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::markAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeChain):
* runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
(JSC::JSPropertyNameIterator::markChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
* runtime/MarkStack.h:
(JSC::MarkStack::append):
* runtime/Structure.h:
(JSC::Structure::cachedPrototypeChainSlot):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::createStructure):
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494
* JavaScriptCore.vcproj/JavaScriptCore.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
* JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
* JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465
* JavaScriptCore.vcproj/JavaScriptCore.sln:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops: Removed.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops.
* JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops: Removed.
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/jsc/jscProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops.
* JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops: Removed.
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
* JavaScriptCore.vcproj/testapi/testapiProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops.
* JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops: Removed.
2011-03-30 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Add the NEXT_OPCODE() macro to the DFG-JIT parser
https://bugs.webkit.org/show_bug.cgi?id=57322
In JavaScriptCore we use macros to jump to the next opcode
(both in interpreter and JIT). This macro is added to the
DFG-JIT parser as well.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
2011-03-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
~25% regression on v8-splay in the SunSpider harness
https://bugs.webkit.org/show_bug.cgi?id=56128
I'm not sure if this is the root cause of the regression Stephanie
measured, but it seems to get us back to previous v8-splay times.
SunSpider reports no change. v8-splay says 41% faster.
* runtime/Heap.cpp:
(JSC::Heap::reset): Make marking proportional to 1X the size of the heap,
not .5X the size of the heap. When the heap is large, this makes a big
difference. (Our old heap growth policy matched this. You can see by
looking at resizeBlocks in revisions prior to r77699.)
2011-03-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Use per-configuration vsprops in JavaScriptCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57350
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebug.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/WTF/WTFDebug.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTFRelease.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops: Added.
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/jsc/jscDebug.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jscDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jscDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jscRelease.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops: Added.
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops: Added.
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
* JavaScriptCore.vcproj/testapi/testapiDebug.vsprops: Added.
* JavaScriptCore.vcproj/testapi/testapiDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/testapi/testapiDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/testapi/testapiRelease.vsprops: Added.
* JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops: Added.
2011-03-29 Oliver Hunt <oliver@apple.com>
Reviewed by Eric Seidel.
REGRESSION(r82173): Causes assertion and test failures in run-javascriptcore-tests on Windows (Requested by aroben on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57333
constructDate now takes the global object explicitly as it may be called
by functions other than the constructor itself.
* API/JSObjectRef.cpp:
(JSObjectMakeDate):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
(JSC::constructWithDateConstructor):
* runtime/DateConstructor.h:
2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Benjamin Poulain.
https://bugs.webkit.org/show_bug.cgi?id=41953
Fix compile error on Solaris 10/Sun Studio 12 CC emanating from MathExtras.h
* wtf/MathExtras.h:
2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57231
Add conditional for SUNCC supporting alignment macros
Compile fix for Solaris 10/Sun Studio 12 CC
* wtf/Vector.h:
2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57256
Fix crash on misaligned reads on Solaris 10/Sparc
* wtf/text/AtomicString.cpp:
(WTF::equal):
2011-03-28 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
instanceof Array test fails when using iframes
https://bugs.webkit.org/show_bug.cgi?id=17250
This is a problem with all built in constructors, the use of
lexicalGlobalObject rather than the constructors own
global object reference means that a builtin will always use
the prototype from the lexical global object rather than that
of the constructors origin.
* API/JSObjectRef.cpp:
(JSObjectMakeFunction):
(JSObjectMakeRegExp):
* JavaScriptCore.exp:
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
* runtime/BooleanConstructor.cpp:
(JSC::constructBoolean):
(JSC::constructBooleanFromImmediateBoolean):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstance.cpp:
* runtime/DateInstance.h:
* runtime/ErrorConstructor.cpp:
(JSC::constructWithErrorConstructor):
(JSC::callErrorConstructor):
* runtime/FunctionConstructor.cpp:
(JSC::constructWithFunctionConstructor):
(JSC::callFunctionConstructor):
(JSC::constructFunction):
* runtime/FunctionConstructor.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlot):
(JSC::JSCell::put):
(JSC::JSCell::deleteProperty):
(JSC::JSCell::toThisObject):
(JSC::JSCell::toObject):
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toObject):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toObject):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::toObject):
* runtime/JSObject.h:
* runtime/JSString.cpp:
(JSC::StringObject::create):
(JSC::JSString::toObject):
(JSC::JSString::toThisObject):
* runtime/JSString.h:
* runtime/JSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::toThisObjectSlowCase):
(JSC::JSValue::synthesizeObject):
* runtime/JSValue.h:
* runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor):
* runtime/NumberObject.cpp:
(JSC::constructNumber):
* runtime/NumberObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::constructObject):
(JSC::constructWithObjectConstructor):
(JSC::callObjectConstructor):
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):
(JSC::callRegExpConstructor):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
* runtime/StringObject.h:
2011-03-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION [r78794-r79249] Allocation of memory is slow when number of active objects is large
https://bugs.webkit.org/show_bug.cgi?id=56823
Partial fix for most of the problem. (TOT still shows a regression, though.)
* runtime/Heap.cpp:
(JSC::Heap::reportExtraMemoryCostSlowCase): Use highWaterMark(), instead of
capacity(), since capacity() is O(n) relative to the size of the heap.
In limited circumstances, capacity() is also worse than highWaterMark()
for measuring extra cost relative to heap size, since capacity() only
measures the *current* capacity of the heap, but the heap will grow if
necessary to attain highWaterMark().
2011-03-28 Oliver Hunt <oliver@apple.com>
REGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57251
Build fix, had remnant of another patch in r82130
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
2011-03-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Add additional immediate types to allow us to distinguish the source of a JIT immediate
https://bugs.webkit.org/show_bug.cgi?id=57190
Allow us to distinguish whether a JIT immediate is a value that we
control (TrustedImm32 and TrustedImmPtr) vs. ones that can be controlled
or influenced by code we are compiling. Currently we do nothing with this
information -- this change is large and mechanical but would obscure any
logic changes that we would have made.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
(JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(JSC::AbstractMacroAssembler::Imm32::Imm32):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::pop):
(JSC::MacroAssembler::poke):
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::addPtr):
(JSC::MacroAssembler::andPtr):
(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::subPtr):
(JSC::MacroAssembler::xorPtr):
(JSC::MacroAssembler::setPtr):
(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::branchTest8):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::push):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARM::branch16):
(JSC::MacroAssemblerARM::branchTest8):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::set32Compare32):
(JSC::MacroAssemblerARM::set8Compare32):
(JSC::MacroAssemblerARM::set32Test32):
(JSC::MacroAssemblerARM::set32Test8):
(JSC::MacroAssemblerARM::moveWithPatch):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::storePtrWithPatch):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add32):
(JSC::MacroAssemblerARMv7::and32):
(JSC::MacroAssemblerARMv7::lshift32):
(JSC::MacroAssemblerARMv7::mul32):
(JSC::MacroAssemblerARMv7::or32):
(JSC::MacroAssemblerARMv7::rshift32):
(JSC::MacroAssemblerARMv7::urshift32):
(JSC::MacroAssemblerARMv7::sub32):
(JSC::MacroAssemblerARMv7::xor32):
(JSC::MacroAssemblerARMv7::load32):
(JSC::MacroAssemblerARMv7::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARMv7::load16):
(JSC::MacroAssemblerARMv7::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARMv7::store32):
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::push):
(JSC::MacroAssemblerARMv7::move):
(JSC::MacroAssemblerARMv7::compare32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::branch32):
(JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest32):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::branchAdd32):
(JSC::MacroAssemblerARMv7::branchMul32):
(JSC::MacroAssemblerARMv7::branchSub32):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::set32Compare32):
(JSC::MacroAssemblerARMv7::set8Compare32):
(JSC::MacroAssemblerARMv7::set32Test32):
(JSC::MacroAssemblerARMv7::set32Test8):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::branchPtrWithPatch):
(JSC::MacroAssemblerARMv7::storePtrWithPatch):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
(JSC::MacroAssemblerARMv7::setupArmAddress):
(JSC::MacroAssemblerARMv7::makeBaseIndexBase):
(JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::lshift32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::rshift32):
(JSC::MacroAssemblerMIPS::urshift32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::xor32):
(JSC::MacroAssemblerMIPS::load32):
(JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::push):
(JSC::MacroAssemblerMIPS::move):
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::branch16):
(JSC::MacroAssemblerMIPS::branchTest32):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::set8Compare32):
(JSC::MacroAssemblerMIPS::set32Compare32):
(JSC::MacroAssemblerMIPS::set32Test8):
(JSC::MacroAssemblerMIPS::set32Test32):
(JSC::MacroAssemblerMIPS::moveWithPatch):
(JSC::MacroAssemblerMIPS::branchPtrWithPatch):
(JSC::MacroAssemblerMIPS::storePtrWithPatch):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::storeDouble):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::addWithCarry32):
(JSC::MacroAssemblerX86::and32):
(JSC::MacroAssemblerX86::or32):
(JSC::MacroAssemblerX86::sub32):
(JSC::MacroAssemblerX86::store32):
(JSC::MacroAssemblerX86::branch32):
(JSC::MacroAssemblerX86::moveWithPatch):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
(JSC::MacroAssemblerX86::storePtrWithPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::mul32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::sub32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::store32):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::push):
(JSC::MacroAssemblerX86Common::move):
(JSC::MacroAssemblerX86Common::branch8):
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
(JSC::MacroAssemblerX86Common::set8Compare32):
(JSC::MacroAssemblerX86Common::set32Compare32):
(JSC::MacroAssemblerX86Common::set32Test8):
(JSC::MacroAssemblerX86Common::set32Test32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::and32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::sub32):
(JSC::MacroAssemblerX86_64::loadDouble):
(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::call):
(JSC::MacroAssemblerX86_64::tailRecursiveCall):
(JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
(JSC::MacroAssemblerX86_64::addPtr):
(JSC::MacroAssemblerX86_64::andPtr):
(JSC::MacroAssemblerX86_64::orPtr):
(JSC::MacroAssemblerX86_64::subPtr):
(JSC::MacroAssemblerX86_64::xorPtr):
(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::setPtr):
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
(JSC::MacroAssemblerX86_64::branchSubPtr):
(JSC::MacroAssemblerX86_64::moveWithPatch):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::storePtrWithPatch):
(JSC::MacroAssemblerX86_64::branchTest8):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::emitCount):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emit_op_mod):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mod):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
(JSC::JIT::emitPutImmediateToCallFrameHeader):
(JSC::JIT::emitLoadCharacterString):
(JSC::JIT::restoreArgumentReferenceForTrampoline):
(JSC::JIT::checkStructure):
(JSC::JIT::setSamplingFlag):
(JSC::JIT::clearSamplingFlag):
(JSC::JIT::emitCount):
(JSC::JIT::sampleInstruction):
(JSC::JIT::sampleCodeBlock):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
(JSC::JIT::emitInitRegister):
(JSC::JIT::emitJumpIfJSCell):
(JSC::JIT::emitJumpIfNotJSCell):
(JSC::JIT::emitJumpIfImmediateInteger):
(JSC::JIT::emitJumpIfNotImmediateInteger):
(JSC::JIT::emitFastArithDeTagImmediate):
(JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
(JSC::JIT::emitFastArithReTagImmediate):
(JSC::JIT::emitTagAsBoolImmediate):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_ensure_property_exists):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_push_new_scope):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_init_lazy_reg):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emit_op_convert_this_strict):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emitSlow_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
(JSC::JIT::emit_op_new_regexp):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
(JSC::JIT::emit_op_new_func):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_ensure_property_exists):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_push_new_scope):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emit_op_convert_this_strict):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emitSlow_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::softModulo):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter):
(JSC::JIT::emit_op_put_setter):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_getter):
(JSC::JIT::emit_op_put_setter):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):
* jit/JITStubCall.h:
(JSC::JITStubCall::addArgument):
* jit/JITStubs.cpp:
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::DEFINE_STUB_FUNCTION):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitLoadInt32):
(JSC::JSInterfaceJIT::emitLoadDouble):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::loadJSStringArgument):
(JSC::SpecializedThunkJIT::tagReturnAsInt32):
(JSC::SpecializedThunkJIT::tagReturnAsJSCell):
* jit/ThunkGenerators.cpp:
(JSC::charToString):
(JSC::powThunkGenerator):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::matchCharacterClass):
(JSC::Yarr::YarrGenerator::storeToFrame):
(JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
(JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
(JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateParenthesesSingle):
(JSC::Yarr::YarrGenerator::generateDisjunction):
2011-03-28 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix the linking of jsc with MinGW after r81963.
* jsc.pro: add -l and remove the lib suffix.
2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.
Compile fix only, no actual code change.
* wtf/MessageQueue.h:
2011-03-25 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Allow defineOwnProperty to work on DOMObjects
https://bugs.webkit.org/show_bug.cgi?id=57129
Fix a couple of places where we uses getter()/setter() rather
than [gs]etterPresent().
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
2011-03-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Crash when paused at a breakpoint caused by inaccurate Activation records.
https://bugs.webkit.org/show_bug.cgi?id=57120
* runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
2011-03-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Crash in debugger beneath MarkStack::drain @ me.com, ibm.com
https://bugs.webkit.org/show_bug.cgi?id=57080
<rdar://problem/8525907>
The crash was caused by changes in the executable after recompilation.
The fix is for the activation to copy the data it needs instead of
relying on the data in the executable.
SunSpider and v8 report no change.
* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters): Use our own data members instead of
reading data out of the executable.
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation): Initialize our data members.
(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter): Use our own data members instead of
reading data out of the executable.
* runtime/JSActivation.h: Added new data members to track data previously
tracked by the executable. Since I've removed the executable pointer,
on a 64bit system, I've only made activations bigger by an int.
2011-03-25 David Kilzer <ddkilzer@apple.com>
Remove duplicate entry from JavaScriptCore.exp
JSC::createStackOverflowError(JSC::ExecState*) was originally
exported in r60057, then duplicated in r60392.
* JavaScriptCore.exp: Removed duplicate entry.
2011-03-25 Jarred Nicholls <jarred@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe
https://bugs.webkit.org/show_bug.cgi?id=56098
Need to link advapi32.lib for jsc.exe since wtf/OSRandomSource.cpp uses the Win32 Crypto API
* jsc.pro:
2011-03-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Darin Adler.
Introduce WTF HexNumber.h
https://bugs.webkit.org/show_bug.cgi?id=56099
Introduce a set of functions that ease converting from a bye or a number to a hex string,
replacing several of these conversions and String::format("%x") usages all over WebCore.
* GNUmakefile.am: Add HexNumber.h to build.
* JavaScriptCore.exp: Export StringBuilder::reserveCapacity.
* JavaScriptCore.gypi: Add HexNumber.h to build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export StringBuilder::reserveCapacity.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add HexNumber.h to build.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* wtf/CMakeLists.txt: Ditto.
* wtf/HexNumber.h: Added.
(WTF::Internal::hexDigitsForMode): Internal helper.
(WTF::appendByteAsHex): Free function, that appends a byte as hex string into a destination.
(WTF::placeByteAsHex): Ditto, but places the result using *foo++ = '..' or foo[index++] = '..'
(WTF::appendUnsignedAsHex): Free function, that appends a number as hex string into a destination.
2011-03-24 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 2: Add new symobl.
(I should have used the EWS bots for this!)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-03-24 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 1: Removed old symobl.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-03-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Ensure that all compilation takes place within a dynamic global object scope
https://bugs.webkit.org/show_bug.cgi?id=57054
<rdar://problem/9083011>
Otherwise, entry to the global object scope might throw away the code
we just compiled, causing a crash.
* JavaScriptCore.exp: Updated for signature change.
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate): Removed explicit compilation calls
here because (a) they took place outside a dynamic global object scope
and (b) they were redundant.
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall): Updated for signature change.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct): Declare our dynamic global object
scope earlier, to ensure that compilation takes place within it.
* runtime/Completion.cpp:
(JSC::evaluate): Removed explicit compilation calls here because (a)
they took place outside a dynamic global object scope and (b) they were
redundant.
* runtime/Executable.h:
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct): Added an ASSERT to
verify our new invariant that all compilation takes place within a
dynamic global object scope.
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
* runtime/JSGlobalObject.h: Changed the signature of DynamicGlobalObjectScope
to require a JSGlobalData instead of an ExecState* since it is often
easier to provide the former, and the latter was not necessary.
2011-03-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
REGRESSION (r79987-r80210): Crash in JSWeakObjectMapClear
https://bugs.webkit.org/show_bug.cgi?id=55671
This is no longer necessary, and it seems that with the new weakmap
model it's simply unsafe, so this reduces it to a no-op.
* API/JSWeakObjectMapRefPrivate.cpp:
2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20302
Correct implementation of signbit on Solaris
* wtf/MathExtras.h:
(signbit):
2011-03-23 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7959320> Threads that use APIs above the BSD layer must be registered with the Obj-C GC.
* wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
2011-03-23 Mark Rowe <mrowe@apple.com>
Stop setting OTHER_OPTIONS in JavaScriptCore's Makefile.
It's not necessary to pass "-target All" as xcodebuild always builds the
first target in the project unless otherwise specified. The presence of
that option also breaks "make clean" since that results in both the
-target and -alltargets options being passed to xcodebuild.
* Makefile:
2011-03-23 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: bring back Vector::contains that was removed as a part of roll back.
* wtf/Vector.h:
(WTF::::contains):
2011-03-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81686.
http://trac.webkit.org/changeset/81686
https://bugs.webkit.org/show_bug.cgi?id=56914
Breaks webkit_tests in Chromium again. (Requested by pfeldman
on #webkit).
* wtf/Vector.h:
2011-03-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
JavaScriptCore GYP build should work on a case-sensitive file system
https://bugs.webkit.org/show_bug.cgi?id=56911
The issue is that there are two UString.h headers, one named UString.h
and one named ustring.h. This patch excludes ustring.h from the header
map to avoid confusion. While I was editing this part of the GYP file,
I cleaned up the exclude rules to be more modern.
* gyp/JavaScriptCore.gyp:
2011-03-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts
panel on Windows, and many inspector regression tests are failing
https://bugs.webkit.org/show_bug.cgi?id=54490
The bug was caused by two different classes using the same name (Recompiler).
* debugger/Debugger.cpp:
* runtime/JSGlobalData.cpp:
(WTF::Recompiler::operator()): Put Recompiler in an anonymous namespace,
so our two recompilers' inline functions don't stomp each other at
link time.
2011-03-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
<rdar://problem/8944718>
* DerivedSources.make:
Remove generation of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
2011-03-22 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Add DFG module to build system (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=56845
* JavaScriptCore.pri:
* JavaScriptCore.pro:
2011-03-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add support to build-webkit for building with gyp-generated project files
https://bugs.webkit.org/show_bug.cgi?id=56877
Found a couple missing Private headers while trying to make WebCore build.
* JavaScriptCore.gypi:
2011-03-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867
This should make it possible to build the gyp-generated JavaScriptCore.xcodeproj
from a JavaScriptCore directory outside of Source.
* gyp/JavaScriptCore.gyp:
* gyp/run-if-exists.sh: Added.
* gyp/update-info-plist.sh: Added.
2011-03-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Profiling Configuration to JavaScriptCore gyp build
https://bugs.webkit.org/show_bug.cgi?id=56862
It appears this is identical to Release, but I suspect
there is someone/thing who uses the Profiling target
so we're adding it for completeness.
* gyp/JavaScriptCore.gyp:
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove os_win32_files variable from the GYP build
https://bugs.webkit.org/show_bug.cgi?id=56804
Now that our understanding of GYP is sufficiently advanced, we don't
need os_win32_files any more. (Turns out Eric was right, as he always
is.)
* JavaScriptCore.gypi:
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
GYP build of JavaScriptCore should be able to link from an empty WebKitBuild directory
https://bugs.webkit.org/show_bug.cgi?id=56803
Previously, we thought we should generate the derived source files in
the shared intermediate build products directory, but there are
assumptions built into other parts of the Mac build system that the
derived source files will be generated in a particular subdirectory of
the build products directory.
This patch is a partial revert of the change that moved the derived
source files to the shared intermediate directory. After this patch,
the GYP build can build JavaScriptCore without help from the main
normal build system.
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
* gyp/generate-derived-sources.sh:
* gyp/generate-dtrace-header.sh:
2011-03-22 Jay Civelli <jcivelli@chromium.org>
Reviewed by David Levin.
Adding a contains method to Vector.
https://bugs.webkit.org/show_bug.cgi?id=55859
* wtf/Vector.h:
(WTF::Vector::contains):
2011-03-22 Gabor Loki <loki@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix a bunch of typos in DFG.
https://bugs.webkit.org/show_bug.cgi?id=56813
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::parse):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::setSpilled):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::setupStubArguments):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGOperations.h:
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::allocate):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Production configuration in GYP isn't set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786
Update JavaScriptCore.gyp with information mined from
JavaScriptCore.xcodeproj.
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-22 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
REGRESSION(r80096): Number type input unexpectedly rounds fractional values
https://bugs.webkit.org/show_bug.cgi?id=56367
Introduce clampToInteger(unsigned).
* wtf/MathExtras.h:
(clampToInteger): Added.
2011-03-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
GYP build should not have include paths that point within the source tree
https://bugs.webkit.org/show_bug.cgi?id=56788
Turns out we don't need these include paths anymore now that we have
header maps working properly.
* gyp/JavaScriptCore.gyp:
- Also, remove jsc.cpp from the excluded list because it's not part
of the jsc_files variable instead of the javascriptcore_files
variable.
2011-03-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
https://bugs.webkit.org/show_bug.cgi?id=56780
The reason we couldn't resolve this warning in the GYP build was that
the normal build disables this warning specifically for this file.
This patch takes the same approach as the previous patch to
WebCoreObjCExtras.mm in that it uses a pragma to suppress the warning
(rather than a build system configuration).
* JavaScriptCore.xcodeproj/project.pbxproj:
- Remove the special-case for this file.
* gyp/JavaScriptCore.gyp:
- Remove the work-around for this issue.
* wtf/Assertions.cpp:
- Add a pragma disabling this warning for this file.
2011-03-21 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build shouldn't crash on startup
https://bugs.webkit.org/show_bug.cgi?id=56776
Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.
* gyp/JavaScriptCore.gyp:
2011-03-21 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Antonio Gomes.
Flag to enable/disable a GestureReocognizer framework
https://bugs.webkit.org/show_bug.cgi?id=49345
* wtf/Platform.h:
2011-03-21 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add new files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=56766
* JavaScriptCore.gypi:
2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81377.
http://trac.webkit.org/changeset/81377
https://bugs.webkit.org/show_bug.cgi?id=56765
WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).
* wtf/Vector.h:
2011-03-21 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Extend constant pool to be able to store 16 bit instructions with a constant
https://bugs.webkit.org/show_bug.cgi?id=46796
The putShortWithConstantInt function inserts a 16 bit instruction which
refers a 32 bits constant or literal. This is a vital function for those
target which loads a PC relative value with a 16 bit instruction (like
Thumb-2 instruction set and SH4 architecture).
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
* assembler/AssemblerBufferWithConstantPool.h:
2011-03-21 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK distcheck build fix.
* GNUmakefile.am:
2011-03-20 Bill Budge <bbudge@chromium.org>
Reviewed by Adam Barth.
Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714
No new tests. Exposes no new functionality.
* API/JSClassRef.h:
* API/OpaqueJSString.h:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Atomics.h:
* wtf/CMakeLists.txt:
* wtf/CrossThreadRefCounted.h:
(WTF::CrossThreadRefCounted::CrossThreadRefCounted):
(WTF::::crossThreadCopy):
* wtf/ThreadSafeRefCounted.h: Copied from wtf/ThreadSafeShared.h.
(WTF::ThreadSafeRefCountedBase::ThreadSafeRefCountedBase):
(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):
(WTF::ThreadSafeRefCounted::ThreadSafeRefCounted):
* wtf/ThreadSafeShared.h: Removed.
* wtf/Threading.h:
2011-03-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Remove StringImpl::computeHash()
https://bugs.webkit.org/show_bug.cgi?id=49894
Replace remainig StringImpl::computeHash with StringImpl::computeHashStringHasher.
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::hash):
(WTF::UCharBufferTranslator::hash):
(WTF::HashAndCharactersTranslator::hash):
* wtf/text/StringImpl.h:
(WTF::StringImpl::setHash):
(WTF::StringImpl::hash):
2011-03-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Rename WTF::StringHasher methods
https://bugs.webkit.org/show_bug.cgi?id=53532
Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.
* profiler/CallIdentifier.h:
(JSC::CallIdentifier::Hash::hash):
* runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::hash):
* wtf/StringHasher.h:
(WTF::StringHasher::computeHash):
(WTF::StringHasher::hashMemory):
* wtf/text/StringHash.h:
(WTF::CaseFoldingHash::hash):
* wtf/text/StringImpl.h:
(WTF::StringImpl::computeHash):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):
2011-03-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180
The crash was caused by referencing GC memory from a GC destructor. This
is not safe because destruction time / order is not guaranteed.
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
* profiler/ProfileGenerator.h:
(JSC::ProfileGenerator::origin): Made ExecState* the first argument,
to match the rest of this class and JSC.
Use a JSGlobalObject* instead of an ExecState* with an indirect reference
to a JSGlobalObject* to track our origin. This is simpler and more
efficient, and it removes the destruction order dependency that was causing
our crash.
* profiler/Profiler.cpp:
(JSC::Profiler::startProfiling): Updated for change to JSGlobalObject*.
(JSC::Profiler::stopProfiling): New function for stopping all profiles
for a given global object. This is more straight-forward than multiplexing
through the old function.
(JSC::dispatchFunctionToProfiles): Updated for change to JSGlobalObject*.
* profiler/Profiler.h: Ditto.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject): Ditto.
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
1 Structure leaked beneath JSGlobalData::storeVPtrs()
https://bugs.webkit.org/show_bug.cgi?id=56595
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::NativeExecutable::NativeExecutable):
(JSC::VPtrHackExecutable::VPtrHackExecutable):
(JSC::ScriptExecutable::ScriptExecutable): Use a raw pointer instead of
PassRefPtr, like JSString does, since JSGlobalData owns the singleton
exectuable structure.
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Fixed some string leaks seen on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=56619
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::~PropertyTable): DEref!
2011-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash in JSC::MarkStack::drain Under Stress
https://bugs.webkit.org/show_bug.cgi?id=56470
We perform a number of gc allocations while when
we are setting up new globals in a piece of global
code. We do this by adding new properties to the
symbol table, and then expanding the storage to fit
at the end.
If a GC happens during this time we will report an
incorrect size for the global object's symbol table
storage.
This patch corrects this by growing the storage size
before we starting adding entries to the symbol table.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::resizeRegisters):
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
1 Structure leaked beneath JSGlobalData::storeVPtrs()
https://bugs.webkit.org/show_bug.cgi?id=56595
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs): Take local ownership of the Structure
we're using, since the Executable is not designed to own the Structure.
2011-03-17 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Add missing register-register branchTest8 to MacroAssemblerX86Common/X86Assembler.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTest8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::testb_rr):
2011-03-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 56603 - DFG JIT related cleanup
Move node generation out to separate function, move binarySearch algorithm out
to StdLibExtras, fix Graph::dump() to print comma between non-node children,
even if there are no node children.
* bytecode/CodeBlock.h:
(JSC::getCallReturnOffset):
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::getMethodCallLinkInfo):
(JSC::CodeBlock::bytecodeOffset):
- Move binaryChop to binarySearch in StdLibExtras
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
- Make m_noArithmetic a member, initialize m_currentIndex in the constructor.
* dfg/DFGByteCodeParser.h:
- Change parse() to not take a start index (always 0).
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- Fix Graph::dump() to print comma between non-node children, even if there are no node children.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
- Initialize m_compileIndex in constructor.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
- Spilt out compilation of individual node.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationConvertThis):
* dfg/DFGOperations.h:
- Cleanup parameter name.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
- Spilt out compilation of individual node.
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
- Change parse() to not take a start index (always 0).
* wtf/StdLibExtras.h:
(WTF::binarySearch):
- Move binaryChop to binarySearch in StdLibExtras
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Geoffrey Garen.
Fix clang build.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
1 Structure leaked beneath JSGlobalData::storeVPtrs()
https://bugs.webkit.org/show_bug.cgi?id=56595
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs): Now that we have an executable, we need
to explicitly run its destructor.
2011-03-17 Jeff Miller <jeffm@apple.com>
Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata
* JavaScriptCore.xcodeproj: Modified property svn:ignore.
2011-03-17 Gavin Barraclough <barraclough@apple.com>
Reverting r81197, breaks JIT + INTERPRETER build.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):
* bytecode/Opcode.h:
* bytecode/StructureStubInfo.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):
2011-03-17 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
Add a COMPILER(SUNCC) define for Sun Studio 12.
https://bugs.webkit.org/show_bug.cgi?56444
derived from patch 1 of 16 originally from https://bugs.webkit.org/show_bug.cgi?id=24932
* wtf/Platform.h:
2011-03-17 Jay Civelli <jcivelli@chromium.org>
Reviewed by David Levin.
Adding a contains method to Vector.
https://bugs.webkit.org/show_bug.cgi?id=55859
* wtf/Vector.h:
(WTF::::operator):
(WTF::::contains):
2011-03-17 Patrick Gansterer <paroga@webkit.org>
Fix the interpreter build.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Added globalData to inheritorID().
2011-03-16 Sam Weinig <sam@webkit.org>
Fix the interpreter build.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::privateExecute):
Remove .get()s.
2011-03-16 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Remove USE(BUILTIN_UTF8_CODEC)
https://bugs.webkit.org/show_bug.cgi?id=56508
We added this recently when we were unsure about the stability of the
built-in UTF-8 codec. However, the codec seems to be stable, so we
don't need the macro.
* wtf/Platform.h:
2011-03-16 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Make JIT build for ARM Thumb-2 with RVCT
https://bugs.webkit.org/show_bug.cgi?id=56440
Derived from a patch by Dave Tapuska.
Also, modify the RVCT stub template to indicate that it preserves 8 byte stack alignment.
* jit/JITStubs.cpp:
2011-03-16 Chao-ying Fu <fu@mips.com>
Reviewed by Darin Adler.
Fix MIPS build with const *void
https://bugs.webkit.org/show_bug.cgi?id=56513
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load32):
(JSC::MacroAssemblerMIPS::store32):
2011-03-16 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Remove unnecessary caller tracking shenanigans from CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=56483
This removes some leftover cruft from when we made CodeBlock
mark its callees. Removing it gives us a 0.7% progression,
reducing the overall regression to ~1.3%.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::CallLinkInfo):
* jit/JIT.cpp:
(JSC::JIT::linkCall):
(JSC::JIT::linkConstruct):
2011-03-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Structure creation require a JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=56438
Mechanical change to make Structure::create require JSGlobalData&, and
require all users to provide the globalData.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(GlobalObject::GlobalObject):
(functionRun):
(jscmain):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::createStructure):
* runtime/Executable.h:
(JSC::ExecutableBase::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSByteArray.h:
(JSC::JSByteArray::JSByteArray):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::createDummyStructure):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):
(JSC::createEmptyObjectStructure):
(JSC::JSObject::inheritorID):
* runtime/JSObjectWithGlobalObject.h:
(JSC::JSObjectWithGlobalObject::createStructure):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::RopeBuilder::createStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/JSZombie.h:
(JSC::JSZombie::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/StringPrototype.h:
(JSC::StringPrototype::createStructure):
* runtime/Structure.h:
(JSC::Structure::create):
2011-03-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Some conservative root gathering cleanup
https://bugs.webkit.org/show_bug.cgi?id=56447
SunSpider says 0.5% - 1.8% faster.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
* interpreter/RegisterFile.h: New helper function for doing the
conservative gathering of the register file. It's still conservative,
since the register file may contain uninitialized values, but it's
moving-safe, because it only visits values tagged as pointers, so there's
no risk of mistaking an integer for a pointer and accidentally changing it.
* runtime/ConservativeSet.cpp:
(JSC::ConservativeRoots::add):
* runtime/ConservativeSet.h: Added a single-value add function, used above.
* runtime/Heap.cpp:
(JSC::Heap::markRoots): Separated machine stack conservative roots from
register file conservative roots because machine stack roots must be
pinned, but register file roots need not be pinned.
Adopted new interface for passing the current stack extent to the machine
stack root gathering routine. This allows us to exclude marking-related
data structures on the stack, and thus avoid double-marking the set of
machine roots.
* runtime/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):
* runtime/MachineStackMarker.h: Added new interface, described above.
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::firstAtom):
* wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf): Moved roundUpToMultipleOf so it could be used
by MachineStacks.
2011-03-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little bit of MarkStack cleanup
https://bugs.webkit.org/show_bug.cgi?id=56443
Moved MarkStack functions into MarkStack.h/.cpp.
SunSpider reports no change.
* runtime/JSArray.h:
* runtime/JSCell.h: Moved from here...
* runtime/MarkStack.cpp:
(JSC::MarkStack::markChildren):
(JSC::MarkStack::drain): ...to here. Also, no need to inline drain. It's
a huge function, and not called many times.
* runtime/MarkStack.h:
(JSC::MarkStack::~MarkStack): Moved near constructor, per style guide.
(JSC::MarkStack::append):
(JSC::MarkStack::deprecatedAppend):
(JSC::MarkStack::internalAppend): Moved to here.
2011-03-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed another deprecatedAppend
https://bugs.webkit.org/show_bug.cgi?id=56429
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::markStrongHandles):
* collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are
marked directly by the Heap.
* runtime/Heap.cpp:
(JSC::Heap::markRoots): Ditto.
2011-03-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed some more deprecated / unsafe append
https://bugs.webkit.org/show_bug.cgi?id=56428
* collector/handles/HandleStack.cpp:
(JSC::HandleStack::mark):
* collector/handles/HandleStack.h: Mark the handle stack using a HeapRoot
marker, since it's a heap root.
* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::markLists):
(JSC::MarkedArgumentBuffer::slowAppend):
* runtime/ArgList.h: Ditto.
* runtime/Heap.cpp:
(JSC::Heap::markRoots): Added a mark call for marking the handle stack.
It seems like Oliver forgot this in his last patch. (!)
* runtime/MarkStack.h: Removed appendSlots, since it would allow an
object to embed JSValues directly instead of using WriteBarrier.
(JSC::MarkStack::append): Added a private append for a list of values.
(JSC::HeapRootMarker::mark): Access to the above.
2011-03-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a few more deprecatedAppends, and removed HeapRoot<T>
https://bugs.webkit.org/show_bug.cgi?id=56422
Added HeapRootMarker, a privileged class for marking direct heap roots
that are iterated during each garbage collection. This is easier to use
and more reliable than HeapRoot<T>, so I've removed HeapRoot<T>.
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/CallFrame.h:
(JSC::ExecState::exception):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Completion.cpp:
(JSC::evaluate): exception is no longer a HeapRoot<T>, so no need to
call .get() on it.
* runtime/Heap.cpp:
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markRoots):
* runtime/Heap.h: Updated to use HeapRootMarker.
* runtime/JSCell.h:
(JSC::JSCell::MarkStack::append): Added private functions for
HeapRootMarker to use.
* runtime/JSGlobalData.h: exception is no longer a HeapRoot<T>.
* runtime/MarkStack.h:
(JSC::HeapRootMarker::HeapRootMarker):
(JSC::HeapRootMarker::mark): Added private functions for
HeapRootMarker to use.
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::markChildren): Updated to use HeapRootMarker.
* runtime/SmallStrings.h:
(JSC::SmallStrings::emptyString):
(JSC::SmallStrings::singleCharacterString):
(JSC::SmallStrings::singleCharacterStrings): Updated to use HeapRootMarker.
* runtime/WriteBarrier.h: Removed HeapRoot<T>.
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made the global object moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56348
SunSpider reports no change.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::markChildren): Removed a dubious comment that
suggested we do not need to visit all our references during GC, since
that is not true in a moving GC.
Re-sorted data members by type, removed one duplicate, and added back
the one missing mark I found.
* runtime/JSGlobalObject.h: Re-sorted data members by type.
2011-03-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Introduce Local<T> to allow us to start moving to precise marking of locals
https://bugs.webkit.org/show_bug.cgi?id=56394
Introduce a new handle type, Local<T> and a scoping mechanism
LocalScope to allow us to start moving towards precise marking
of temporaries and local variables.
We also start to use the new Local<> type in the JSON stringifier
so that we can have some coverage of their behaviour in the initial
checkin.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* collector/handles/Handle.h:
(JSC::::asObject):
* collector/handles/HandleStack.cpp: Added.
(JSC::HandleStack::HandleStack):
(JSC::HandleStack::mark):
(JSC::HandleStack::grow):
* collector/handles/HandleStack.h: Added.
(JSC::HandleStack::enterScope):
(JSC::HandleStack::zapTo):
(JSC::HandleStack::leaveScope):
(JSC::HandleStack::push):
* collector/handles/Local.h: Added.
(JSC::Local::internalSet):
(JSC::::Local):
(JSC::::operator):
(JSC::LocalStack::LocalStack):
(JSC::LocalStack::peek):
(JSC::LocalStack::pop):
(JSC::LocalStack::push):
(JSC::LocalStack::isEmpty):
(JSC::LocalStack::size):
* collector/handles/LocalScope.h: Added.
(JSC::LocalScope::LocalScope):
(JSC::LocalScope::~LocalScope):
(JSC::LocalScope::release):
* runtime/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/Heap.h:
(JSC::Heap::allocateLocalHandle):
(JSC::Heap::handleStack):
* runtime/JSCell.h:
(JSC::JSCell::::getString):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::allocateLocalHandle):
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::stringify):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::Holder):
(JSC::Walker::Walker):
(JSC::Walker::walk):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
(JSC::JSONStringify):
* runtime/JSONObject.h:
* runtime/MarkStack.h:
(JSC::MarkStack::appendValues):
(JSC::MarkStack::appendSlots):
2011-03-15 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Bug 56420 - Remove ENABLE(JIT) code from ByteCompiler
Some methods have unnecessary differences in name/arguments for interpreter/JIT.
* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:
(JSC::HandlerInfo::HandlerInfo):
(JSC::CodeBlock::addPropertyAccessInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::addCallLinkInfo):
(JSC::CodeBlock::globalResolveInfo):
* bytecode/Opcode.h:
* bytecode/StructureStubInfo.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):
2011-03-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Fix broken assert in new code.
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordPutByVal):
- recordPutByVal is called for both PutByVal & PutByValAlias.
2011-03-15 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig.
Removed redundant code from BytecodeGenerator.
* bytecompiler/BytecodeGenerator.cpp:
* bytecompiler/BytecodeGenerator.h:
- delete uncalled code missed when reparsing was removed.
2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Darin Adler.
Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.
https://bugs.webkit.org/show_bug.cgi?id=27551
* API/JSBase.h:
* config.h:
* wtf/Assertions.h:
* wtf/ExportMacros.h: Added.
* wtf/Platform.h:
2011-03-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix.
Buildfix when JIT is not enabled after r81079
https://bugs.webkit.org/show_bug.cgi?id=56361
* runtime/Executable.cpp:
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made the global object moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56348
SunSpider reports no change.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::markChildren): Removed a dubious comment that
suggested we do not need to visit all our references during GC, since
that is not true in a moving GC.
Re-sorted data members by type, removed one duplicate, and added back
the one missing mark I found.
* runtime/JSGlobalObject.h: Re-sorted data members by type.
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made JSWrapperObject and subclasses moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56346
SunSpider reports no change.
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance): No more need for JSGlobalData, since
we don't initialize the wrapped value in our constructor.
* runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because
we do not in fact override markChildren.
* runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object
no longer does so for us. Also added an ASSERT to catch a latent bug,
where DatePrototype stomped on its base class's anonymous slot. Hard-coded
anonymous slots are a plague on our code. This doesn't cause any problems
in our existing code since the base class never reads the anonymous slot
it declares, but it caused crashes when I tried to start using the slot
in an initial version of this patch.
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
(JSC::JSWrapperObject::internalValue):
(JSC::JSWrapperObject::setInternalValue): Resolved a problem where
our internal value was stored in two places: an anonymous slot, and a
data member which was not always visited during GC. Now, we only use the
data member, and we always visit it. (Instead of relying on certain
subclasses to set the OverridesMarkChildren bit, we set it ourselves.)
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject): No more need for JSGlobalData, since
we don't initialize the wrapped value in our constructor.
* runtime/NumberObject.h: Removed meaningless declaration.
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject): No more need for JSGlobalData, since
we don't initialize the wrapped value in our constructor.
* runtime/StringObject.h: Don't set the OverridesMarkChildren flag because
we do not in fact override markChildren.
* runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object
no longer does so for us. Also added an ASSERT to catch a latent bug,
where DatePrototype stomped on its base class's anonymous slot. Hard-coded
anonymous slots are a plague on our code.
2011-03-14 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Look-ahead assertions with back references don’t work as expected
https://bugs.webkit.org/show_bug.cgi?id=56082
Changed parentheses assertion processing to temporarily back out the
number of known characters after the assertion while processing the
assertion. This was done so that assertions don't fail due to
checking the number of required characters as additional to the
rest of the express since assertions don't "consume" input.
Added a byte code to uncheck characters to support the change.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::uncheckInput):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/YarrInterpreter.h:
(JSC::Yarr::ByteTerm::UncheckInput):
2011-03-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
https://bugs.webkit.org/show_bug.cgi?id=56133
Add condition to not compile webkit internal math round functions on RVCT compiler versions
from 3.0.0 because they are already defined in compiler math library.
* wtf/MathExtras.h:
2011-03-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen & Oliver Hunt.
Bug 56284 - Add a dataflow intermediate representation for use in JIT generation.
The JSC JIT presently generates code directly from the bytecode used by the interpreter.
This is not an optimal intermediate representation for JIT code generation, since it does
not capture liveness information of values, and provides little opportunity to perform
any static analysis for even primitive types. The JIT currently generates two code paths,
a fast path handling common cases, and a slower path handling less common operand types.
However the slow path jumps back into the fast path, meaning that information arising
from the earlier type checks cannot be propagated to later operations.
This patch adds:
* a dataflow intermediate representation capable of describing a single basic block
of operations,
* a mechanism to convert a simple, single-block bytecode functions to the new IR,
* and a JIT code generator capable of generating code from this representation.
The JIT generates two code paths, with the slower path not reentering the fast path
mid-block, allowing speculative optimizations to be made on the hot path, with type
information arising from these speculative decisions able to be propagated through the
dataflow. Code generation of both speculative and non-speculative paths exploits the type
and liveness information represented in the dataflow graph to attempt to avoid redundant
boxing and type-checking of values, and to remove unnecessary spills of temporary values
to the RegisterFile.
The dataflow JIT currently can only support a subset of bytecode operations, limited to
arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
expanded to include, control-flow, function calls, and then the long-tail of remaining
bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
this only supports x86-64.
The status of the dataflow JIT is currently work-in-progress. Limitations of the present
JIT code generation may cause performance regressions, particularly:
* the policy to only generate arithmetic code on the speculative path using integer
instructions, never using floating point.
* the policy to only generate arithmetic code on the non-speculative path using
floating point instructions, never using integer.
* always generating JSValue adds on the non-speculative path as a call out to a
C-function, never handling this in JIT code.
* always assuming by-Value property accesses on the speculative path to be array
accesses.
* generating all by-Value property accesses from the non-speculative path as a call
out to a C-function.
* generating all by-Indentifer property accesses as a call out to a C-function.
Due to these regressions, the code is landed in a state where it is disabled in most
cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
addressed, the JIT will be allowed to trigger in more cases.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added new files to Xcode project.
* dfg: Added.
- Added directory for new code.
* dfg/DFGByteCodeParser.cpp: Added.
* dfg/DFGByteCodeParser.h: Added.
- Contruct a DFG::Graph representation from a bytecode CodeBlock.
* dfg/DFGGenerationInfo.h: Added.
- Track type & register information for VirtualRegisters during JIT code generation.
* dfg/DFGGraph.cpp: Added.
* dfg/DFGGraph.h: Added.
- Dataflow graph intermediate representation for code generation.
* dfg/DFGJITCodeGenerator.cpp: Added.
* dfg/DFGJITCodeGenerator.h: Added.
- Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
* dfg/DFGJITCompiler.cpp: Added.
* dfg/DFGJITCompiler.h: Added.
- Class responsible for driving code generation of speculativeJIT & non-speculative
code paths from the dataflow graph.
* dfg/DFGNonSpeculativeJIT.cpp: Added.
* dfg/DFGNonSpeculativeJIT.h: Added.
- Used to generate the non-speculative code path, this make no assumptions
about operand types.
* dfg/DFGOperations.cpp: Added.
* dfg/DFGOperations.h: Added.
- Helper functions called from the JIT generated code.
* dfg/DFGRegisterBank.h: Added.
- Used to track contents of physical registers during JIT code generation.
* dfg/DFGSpeculativeJIT.cpp: Added.
* dfg/DFGSpeculativeJIT.h: Added.
- Used to generate the speculative code path, this make assumptions about
operand types to enable optimization.
* runtime/Executable.cpp:
- Add code to attempt to use the DFG JIT to compile a function, with fallback
to the existing JIT.
* wtf/Platform.h:
- Added compile guards to enable the DFG JIT.
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed more cases of DeprecatedPtr (exception, SmallStrings)
https://bugs.webkit.org/show_bug.cgi?id=56332
* runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded
constant, to make this code less brittle.
* runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because
this reference is owned and managed directly by the heap.
* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
* runtime/JSString.h:
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsStringWithFinalizer):
(JSC::jsSubstring):
(JSC::jsOwnedString): Use a variable instead of a hard-coded
constant, to make this code less brittle.
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::rep):
(JSC::SmallStringsStorage::SmallStringsStorage):
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::markChildren):
(JSC::SmallStrings::clear):
(JSC::SmallStrings::count): Use a variable instead of a hard-coded
constant, to make this code less brittle.
* runtime/SmallStrings.h:
(JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of
DeprecatedPtr because these references are owned and managed directly by
the heap.
Stop using FixedArray because we only want a very limited set
of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.)
* runtime/WriteBarrier.h:
(JSC::operator==):
(JSC::WriteBarrier::WriteBarrier):
(JSC::HeapRoot::HeapRoot):
(JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set
without write barrier because we assume all HeapRoots are scanned during
all GC passes.
2011-03-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben and Gavin Barraclough.
FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>
Give StringConcatenate the ability to deal with const UChar*'s as a String type to append.
* wtf/text/StringConcatenate.h:
2011-03-14 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
<http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.
2011-03-14 Oliver Hunt <oliver@apple.com>
Fix windows build
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitLoadInt32):
(JSC::JSInterfaceJIT::tagFor):
(JSC::JSInterfaceJIT::payloadFor):
(JSC::JSInterfaceJIT::intPayloadFor):
(JSC::JSInterfaceJIT::intTagFor):
(JSC::JSInterfaceJIT::addressFor):
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.
For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::intPayloadFor):
(JSC::JSInterfaceJIT::intTagFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A few Heap-related renames (sans file moves, which should come next)
https://bugs.webkit.org/show_bug.cgi?id=56283
ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.
MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.
registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.
"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.
"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
* JavaScriptCore.exp:
* runtime/ConservativeSet.cpp:
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):
* runtime/ConservativeSet.h:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
* runtime/Heap.h:
(JSC::Heap::machineThreads):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::makeUsableFromMultipleThreads):
* runtime/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):
* runtime/MachineStackMarker.h:
* runtime/MarkStack.h:
(JSC::MarkStack::append):
2011-03-13 David Kilzer <ddkilzer@apple.com>
BUILD FIX for armv7 after r80969
Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<https://bugs.webkit.org/show_bug.cgi?id=56270>
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix the Mac build.
* JavaScriptCore.xcodeproj/project.pbxproj: Make sure to forward
ConervativeSet.h, since it's now visible when compiling other projects.
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed another case of DeprecatedPtr (ConservativeSet)
https://bugs.webkit.org/show_bug.cgi?id=56281
The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.
* runtime/ConservativeSet.cpp:
(JSC::ConservativeSet::grow):
* runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append.
(JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated
the size of the set based on sizeof(DeprecatedPtr<T>*) instead of
sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not.
(JSC::ConservativeSet::size):
(JSC::ConservativeSet::set): Use direct pointers, as stated above.
* runtime/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/MarkStack.h:
(JSC::MarkStack::append): Created a special case of append for
ConservativeSet. I didn't want to add back a generic "append JSCell*"
function, since other class might start using that wrong. (In the end,
this function might go away, since the Heap will want to do something
slightly more interesting with the conservative set, but this is OK for
now.)
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed another case of DeprecatedPtr (PutPropertySlot)
https://bugs.webkit.org/show_bug.cgi?id=56278
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setExistingProperty):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot,
since it's a stack-allocated temporary.
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed one case of DeprecatedPtr (ScopeChainIterator)
https://bugs.webkit.org/show_bug.cgi?id=56277
* runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator,
since it's a stack-allocated temporary.
2011-03-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 56273 - Add three operand forms to MacroAssember operations.
Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
- marked these methods const.
(JSC::AbstractMacroAssembler::Jump::isSet):
- add a method to check whether a Jump object has been set to
reference an instruction, or is in a null, unset state.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- add non-explicit constructor, for FunctionPtr's to C/C++ functions.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
- add three operand forms of these instructions.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpSrc::isSet):
- add a method to check whether a JmpSrc object has been set to
reference an instruction, or is in a null, unset state.
(JSC::X86Assembler::movsd_rr):
- added FP register-register move.
(JSC::X86Assembler::linkJump):
- Add an assert to check jumps aren't linked more than once.
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadInt32ToDouble):
- load integers to the FPU via regsiters on x86-64.
2011-03-13 Gavin Barraclough <barraclough@apple.com>
ARM build fix.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32):
2011-03-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.
Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.
* bytecode/SamplingTool.h:
* interpreter/Register.h:
* interpreter/RegisterFile.h:
* runtime/JSArray.h:
* runtime/JSCell.h:
* runtime/JSTypeInfo.h:
* runtime/JSVariableObject.h:
* runtime/Structure.h:
* wtf/RefCounted.h:
- Change these classes to no longer friend the JIT, add accessors for member offsets.
* jit/JIT.cpp:
* jit/JITCall32_64.cpp:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
- Change the JIT to use class accessors, rather than taking object ofsets directly.
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
- Since the accessors for objects members return const pointers to retain encapsulation,
methods generating code with absolute addresses must be able to handle const pointers
(the JIT doesn't write to these values, do dies treat the pointer to value as const
from within the C++ code of the JIT, if not at runtime!).
2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251
all windows bots failed to compile this change (Requested by
loislo on #webkit).
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/StructureStubInfo.cpp:
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::payloadFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
* runtime/ArgList.cpp:
* runtime/DateConversion.cpp:
* runtime/GCActivityCallbackCF.cpp:
* runtime/Identifier.cpp:
* runtime/JSActivation.h:
(JSC::asActivation):
* runtime/JSLock.cpp:
* runtime/JSNumberCell.cpp:
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSValue.h:
* runtime/JSZombie.cpp:
* runtime/MarkedBlock.cpp:
* runtime/MarkedSpace.cpp:
* runtime/PropertyNameArray.cpp:
* runtime/ScopeChain.h:
(JSC::ExecState::globalThisValue):
* wtf/DateMath.cpp:
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.
For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::intPayloadFor):
(JSC::JSInterfaceJIT::intTagFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
https://bugs.webkit.org/show_bug.cgi?id=56231
* JavaScriptCore.gypi: Added project_dir variable.
* gyp/JavaScriptCore.gyp: Changed to use project_dir, rather than DEPTH/JavaScriptCore.
* gyp/generate-dtrace-header.sh: Changed to use project_dir.
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56217
* gyp/JavaScriptCore.gyp: Added derived source files and passing of shared directory
to the scripts.
* gyp/generate-derived-sources.sh: Changed to use passed directory.
* gyp/generate-dtrace-header.sh: Ditto.
2011-03-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8955589> Adopt AVFoundation media back end on Lion.
No new tests, existing media tests cover this.
* JavaScriptCore.exp: Export cancelCallOnMainThread
* wtf/Platform.h: Define WTF_USE_AVFOUNDATION.
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56207
* JavaScriptCore.gypi: Added Tracing.d to the sources.
* gyp/generate-dtrace-header.sh: Added.
* gyp/JavaScriptCore.gyp: Updated dylib paths (now the project can see them),
and added DTrace header generating step.
2011-03-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix allocation of native function with a cached thunk
https://bugs.webkit.org/show_bug.cgi?id=56127
Fix this race condition found while fixing zombies.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::clearWeakPointers):
* runtime/Heap.cpp:
(JSC::Heap::reset):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::markChildren):
* runtime/JSValue.h:
(JSC::JSValue::decode):
* runtime/JSZombie.cpp:
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h:
(JSC::JSZombie::createStructure):
* runtime/MarkedBlock.cpp:
2011-03-10 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] fast/workers/stress-js-execution.html is crashing on Qt bot (intermittently)
https://bugs.webkit.org/show_bug.cgi?id=33008
Defining WTF_USE_PTHREAD_BASED_QT=1 for platforms where QThread uses pthread internally.
Symbian is excluded because pthread_kill does not work on it. Mac is excluded because
it has its own ways to do JSC threading.
Defining WTF_USE_PTHREADS inside MachineStackMarker.cpp if USE(PTHREAD_BASED_QT) is true.
* runtime/MachineStackMarker.cpp:
* wtf/Platform.h:
2011-03-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 56077 - ES5 conformance issues with RegExp.prototype
There are three issues causing test failures in sputnik.
(1) lastIndex should be converted at the point it is used, not the point it is set (this is visible if valueOf is overridden).
(2) The 'length' property of the test/exec functions should be 1.
(3) If no input is specified, the input to test()/exec() is "undefined" (i.e. ToString(undefined)) - not RegExp.input.
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::markChildren):
- Added to mark lastIndex
(JSC::regExpObjectLastIndex):
(JSC::setRegExpObjectLastIndex):
- lastIndex is now stored as a JSValue.
(JSC::RegExpObject::match):
- Use accessor methods to get/set lastIndex, add fast case for isUInt32 (don't convert to double).
* runtime/RegExpObject.h:
(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::setLastIndex):
- Set lastIndex, either from a size_t or a JSValue.
(JSC::RegExpObject::getLastIndex):
- Get lastIndex.
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
- Initialize as a JSValue.
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
- Add test/exec properties with length 1.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
- Do not read RegExp.input if none is provided.
* tests/mozilla/js1_2/regexp/RegExp_input.js:
* tests/mozilla/js1_2/regexp/RegExp_input_as_array.js:
- Update these tests (they relied on non-ES5 behaviour).
2011-03-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Rolled back in 80277 and 80280 with event handler layout test failures fixed.
https://bugs.webkit.org/show_bug.cgi?id=55653
The failures were caused by a last minute typo: assigning to currentEvent
instead of m_currentEvent.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/BytecodeGenerator.cpp:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* runtime/Arguments.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.h:
* runtime/MarkedSpace.cpp:
* runtime/MarkedSpace.h:
2011-03-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019
When linking a call, codeblock now takes ownership of the linked function
This removes the need for unlinking, and thus the incorrectness that was
showing up in these tests.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::markAggregate):
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::setUnlinked):
(JSC::CodeBlock::addCaller):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkCall):
(JSC::JIT::linkConstruct):
* jit/JIT.h:
* runtime/Executable.cpp:
* runtime/Executable.h:
2011-03-09 Daniel Bates <dbates@rim.com>
Attempt to fix the WinCE build after changeset 80684 <http://trac.webkit.org/changeset/80684>
(Bug #56041<https://bugs.webkit.org/show_bug.cgi?id=56041>).
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Substitute variable callFrame for exec in call to createSyntaxError().
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 56041 - RexExp constructor should only accept flags "gim"
Fix for issues introduced in r80667.
Invalid flags to a RegExp literal are a late syntax error!
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
- Pass a PassRefPtr<RegExp>
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
- Pass a PassRefPtr<RegExp>
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
- Should not be ASSERTing that the flags are valid - this is a late(er) error.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- Need to check for error from RegExp constructor.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Need to check for error from RegExp constructor.
* runtime/RegExp.h:
(JSC::RegExp::isValid):
- Make isValid check that the regexp was created with valid flags.
* runtime/RegExpKey.h:
- Since we'll not create RegExp objects with invalid flags, separate out the deleted value.
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Windows build fix part 2.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Windows build fix part 1.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Bug 56041 - RexExp constructor should only accept flags "gim"
We also should be passing the flags around as a bitfield rather than a string,
and should not have redundant, incompatible code for converting the string to a bitfield!
* JavaScriptCore.exp:
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
- Need to parse flags string to enum.
* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
- Add method to parse flags string to enum, change constructor/create args to take enum.
* runtime/RegExp.h:
(JSC::RegExp::global):
(JSC::RegExp::ignoreCase):
(JSC::RegExp::multiline):
- Change to use new enum values.
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:
- Changed to use regExpFlags enum instead of int/const UString&.
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- Add use new enum parsing, check for error.
* runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
- Pass NoFlags value instead of empty string.
(JSC::regExpProtoFuncCompile):
- Add use new enum parsing, check for error.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
- Pass NoFlags value instead of empty string.
2011-03-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig
Bug 55994 - Functions on Array.prototype should check length first.
These methods are designed to work on generic objects too, and if 'length'
is a getter that throws an exception, ensure this is correctly thrown
(even if other exceptions would be thrown, too).
Make the length check the first thing we do.
This change shows a progression on SunSpider on my machine, but this is likely bogus.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
2011-03-07 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make CodeBlock GC write barrier safe
https://bugs.webkit.org/show_bug.cgi?id=55910
In order to make CodeBlock WriteBarrier safe it was necessary
to make it have a single GC owner, and for that reason I have
made ExecutableBase a GC allocated object. This required
updating their creation routines as well as all sites that hold
a reference to them. GC objects that held Executable's have been
converted to WriteBarriers, and all other sites now use Global<>.
As an added benefit this gets rid of JSGlobalData's list of
GlobalCodeBlocks.
Perf testing shows a 0.5% progression on v8, vs. a 0.3% regression
on SunSpider. Given none of the tests that show regressions
demonstrate a regression on their own, and sampling shows up nothing.
I suspect we're just getting one or two additional gc passes at
the end of the run.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::EvalCodeCache::markAggregate):
(JSC::CodeBlock::markAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::constantRegister):
(JSC::CodeBlock::getConstant):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ExecState::r):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* bytecode/SamplingTool.h:
(JSC::ScriptSampleRecord::ScriptSampleRecord):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitEqualityOp):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs):
* jit/JITStubs.h:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::markChildren):
(JSC::ProgramExecutable::markChildren):
(JSC::FunctionExecutable::markChildren):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::VPtrHackExecutable::VPtrHackExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::create):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots):
* runtime/Heap.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSObject.cpp:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::markChildren):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::JSStaticScopeObjectData::JSStaticScopeObjectData):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSZombie.cpp:
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h:
(JSC::JSZombie::createStructure):
* runtime/MarkedSpace.h:
2011-03-07 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228
A change to the date parser to handle the case where the year is
specified before the time zone inadvertently started accepting strings
such as '+0000' as valid years. Those strings actually represent time
zones in an offset of hours and minutes from UTC, not years.
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters): If the current character
in dateString is '+' or '-', do not try to parse the next token as a
year.
2011-03-06 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039
The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/MD5.cpp:
(WTF::MD5::MD5):
* wtf/SHA1.cpp: Added.
(WTF::testSHA1): This function will be run the first time SHA1
constructor is called. This function computes a few hash values
and checks the results in debug builds. However, constructor is
probably not a good place to run these tests, so we need to find
a good place for it (bug 55853).
(WTF::expectSHA1):
(WTF::f):
(WTF::k):
(WTF::rotateLeft):
(WTF::SHA1::SHA1):
(WTF::SHA1::addBytes):
(WTF::SHA1::computeHash):
(WTF::SHA1::finalize):
(WTF::SHA1::processBlock):
(WTF::SHA1::reset):
* wtf/SHA1.h: Added.
(WTF::SHA1::addBytes):
* wtf/wtf.pri:
2011-03-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813
Rename the action to be friendlier.
* gyp/JavaScriptCore.gyp:
2011-03-04 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Need symbian version of cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=55782
Implement Symbian version of cryptographicallyRandomValuesFromOS
* wtf/OSRandomSource.cpp:
(WTF::cryptographicallyRandomValuesFromOS):
2011-03-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Bug 55815 - Should throw an exception from JSObject::defineOwnProperty if !isExtensible().
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
Add missing check.
2011-03-04 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by olliej.
Bug 54945 - The web page hangs towards the end of page load in Interpreter enabled javascript code in the latest webkit trunk.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
(1) don't infinite loop.
(2) goto 1.
2011-03-04 Gavin Barraclough <barraclough@apple.com>
cmake build fix.
* CMakeLists.txt:
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add Copy Files step to JavaScriptCore GYP build for apitest and minidom
https://bugs.webkit.org/show_bug.cgi?id=55798
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790
Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.
* gyp/JavaScriptCore.gyp:
2011-03-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 55736 - Implement seal/freeze/preventExtensions for normal object types.
Provide basic functionallity from section 15.2.4 of ECMA-262.
This support will need expanding to cover arrays, too.
Shows a 0.5% progression on SunSpidey, this seems to be due to changing
ObjectConstructor to use a static table.
* DerivedSources.make:
* JavaScriptCore.exp:
* interpreter/CallFrame.h:
(JSC::ExecState::objectConstructorTable):
Add a static table for ObjectConstructor.
* runtime/CommonIdentifiers.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
Add a static table for ObjectConstructor.
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
Add a static table for ObjectConstructor.
* runtime/JSObject.cpp:
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
Transition the object's structure.
(JSC::JSObject::defineOwnProperty):
Check isExtensible.
* runtime/JSObject.h:
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):
These wrap method on structure.
(JSC::JSObject::putDirectInternal):
Check isExtensible.
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
Change ObjectConstructor to use a static table.
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):
Add new methods on Object.
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
init/propagate m_preventExtensions
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
transition the structure, materializing the property map, setting m_preventExtensions & changing attributes.
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
check attributes to detect if object is sealed/frozen.
* runtime/Structure.h:
(JSC::Structure::isExtensible):
checks the m_preventExtensions flag.
2011-03-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Jon Honeycutt.
Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021273>
We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Removed.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
JavaScriptCore GYP build should use a header map
https://bugs.webkit.org/show_bug.cgi?id=55712
This patch moves the os-win32 files into their own variable so that we
can use a header map in the Apple Mac Xcode build. The problem is that
the header map searches the whole project rather than just the files
included in a given target. Another solution to this problem is to
make GYP smarter about filtering out what files are added to the
project file.
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::copyGlobalsTo): Pass nullptr instead of 0.
(JSC::JSGlobalObject::resizeRegisters): Ditto; also use OwnArrayPtr instead of a raw pointer.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::addStaticGlobals): Ditto.
* wtf/PassOwnArrayPtr.h: Removed #define LOOSE_PASS_OWN_ARRAY_PTR
(WTF::PassOwnArrayPtr::PassOwnArrayPtr): Added a constructor that takes nullptr_t.
2011-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add jsc to JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55711
* JavaScriptCore.gypi:
- Move jsc.cpp into jsc_files because it's really part of the jsc
target.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Remove extraneous files from the normal jsc build. I probably
added these by mistake at some point.
* gyp/JavaScriptCore.gyp:
- Add the jsc target to the GYP file.
2011-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add testapi to JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55707
The new testapi target is slightly incomplete. There's a resource
copying step that we don't quite have yet.
This patch also cleans up some of the configuration issues in
JavaScriptCore.xcodeproj. It seems kind of wordy to repeat these for
each target. I suspect there's a more compact way of defining the
configurations, but this removes the "Default" configuration, which is
progress.
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach JavaScriptCore GYP build about private headers
https://bugs.webkit.org/show_bug.cgi?id=55532
This patch distinguishes between public and private framework headers
so that public headers are copied into the Headers directory and
private headers are copied into the PrivateHeaders directory.
* gyp/JavaScriptCore.gyp:
2011-03-03 Geoffrey Garen <ggaren@apple.com>
Rolled out 80277 and 80280 because they caused event handler layout test
failures.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/BytecodeGenerator.cpp:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* runtime/Arguments.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.h:
* runtime/MarkedSpace.cpp:
* runtime/MarkedSpace.h:
2011-03-03 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix. Alter order of headers included to make sure windows.h
is configured by wx, and skip Posix implementation file we don't use on Win.
* wscript:
* wtf/wx/StringWx.cpp:
2011-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698
Replace the direct usage of Register in JSVariableObject (and descendents)
with WriteBarrier. This requires updating the Arguments object to use
WriteBarrier as well.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::initialize):
* runtime/Arguments.cpp:
(JSC::Arguments::markChildren):
(JSC::Arguments::copyToRegisters):
(JSC::Arguments::fillArgList):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
* runtime/Arguments.h:
(JSC::Arguments::setActivation):
(JSC::Arguments::Arguments):
(JSC::Arguments::copyRegisters):
(JSC::JSActivation::copyRegisters):
* runtime/JSActivation.cpp:
(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::markChildren):
(JSC::JSGlobalObject::copyGlobalsFrom):
(JSC::JSGlobalObject::copyGlobalsTo):
(JSC::JSGlobalObject::resizeRegisters):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::setRegisters):
(JSC::JSGlobalObject::addStaticGlobals):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::symbolTableGet):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::registerAt):
(JSC::JSVariableObject::JSVariableObjectData::JSVariableObjectData):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):
(JSC::JSVariableObject::copyRegisterArray):
(JSC::JSVariableObject::setRegisters):
2011-03-03 Geoffrey Garen <ggaren@apple.com>
Try to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed obsolete symbol.
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::getOwnPropertySlot): Don't mark this function
inline -- it's virtual.
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.cpp:
* jit/JITOpcodes.cpp:
* runtime/Arguments.h:
* runtime/JSActivation.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/JSCell.h:
(JSC::JSCell::MarkedSpace::sizeClassFor): Added an imprecise size class
to accomodate objects up to 1K.
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/JSObject.cpp: Don't ASSERT that JSFinalObject fills the maximum
object size, since it doesn't anymore.
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h: Added an imprecise size class to accomodate objects up to 1K.
2011-03-03 Timothy Hatcher <timothy@apple.com>
Make APIShims usable from WebCore.
Reviewed by Oliver Hunt.
* ForwardingHeaders/JavaScriptCore/APIShims.h: Added.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-03-03 Peter Varga <pvarga@webkit.org>
Reviewed by Oliver Hunt.
Begin Characters Optimization Causes YARR Interpreter Errors
https://bugs.webkit.org/show_bug.cgi?id=55479
The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.
Reenable the Beginning Character Optimization in the YARR Interpreter again.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms):
(JSC::Yarr::YarrPattern::compile):
2011-03-02 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Add the ability to create a Private Browsing storage session.
* wtf/Platform.h:
Add a new #define for using CF Storage Sessions.
2011-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove "register slot" concept from PropertySlot
https://bugs.webkit.org/show_bug.cgi?id=55621
PropertySlot had already stopped storing Register "slots"
so this patch is simply removing that api entirely.
This exposed a problem in the ProgramNode constructor for
BytecodeGenerator where it reads from the registerfile
before it has initialised it.
This bug wasn't a problem before as we were merely testing
for property existence rather than the actual value, and
used to work because setRegisterSlot didn't check that the
provided slot contained an initialised value.
To get around this issue we now use symbolTableHasProperty
to do the symbol table check without trying to read the
RegisterFile.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
* runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTableGet):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::symbolTableHasProperty):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::symbolTableGet):
* runtime/PropertySlot.h:
2011-03-02 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2011-03-02 Adam Roben <aroben@apple.com>
Delete old .res files whenever any .vsprops file changes
Prospective fix for <http://webkit.org/b/55599> r80079 caused incremental Windows builds to
fail
Reviewed by Tony Chang.
* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Restructured code to loop over a set of file extensions, deleting any old files that
have that extension. Now deletes .res files, too. (We previously deleted any file matching
*.manifest*, but that turned out to just be the union of *.manifest and *.res.)
2011-03-02 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Teach JavaScriptCore GYP build how to build minidom
https://bugs.webkit.org/show_bug.cgi?id=55536
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
JavaScriptCore GYP build should copy some headers into the target framework
https://bugs.webkit.org/show_bug.cgi?id=55524
After this patch, all the framework headers are exported as public
headers. We need to teach GYP how to handle private headers.
I struggled to determine how to store the information about whether a
header was public, private, or project (i.e., not exported).
Generally, the GYPI should just list the files, but it seemed siliy to
have an almost duplicated list of files in the GYP file itself. If
this design doesn't scale, we might have to revisit it in the future.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
* wtf/Platform.h:
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
* wtf/Platform.h:
2011-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Joseph Pecoraro.
Misaligned memory access in CloneDeserializer on all ARM arch.
https://bugs.webkit.org/show_bug.cgi?id=48742
Add a CPU class for architectures that need aligned addresses
for memory access.
* wtf/Platform.h:
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add pre- and post-build actions for JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55507
After this patch, we have all the steps for building the main
JavaScriptCore framework except the "copy headers" step, which I'll do
next.
* gyp/JavaScriptCore.gyp:
2011-03-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Rolled back in r79627 now that the underlying cause for it crashing is fixed.
https://bugs.webkit.org/show_bug.cgi?id=55159
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Heap.cpp:
(JSC::Heap::allocateSlowCase):
* runtime/Heap.h:
* runtime/JSCell.h:
(JSC::JSCell::MarkedSpace::sizeClassFor):
(JSC::JSCell::Heap::allocate):
(JSC::JSCell::JSCell::operator new):
* runtime/MarkedBlock.h:
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::SizeClass::SizeClass):
2011-03-01 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Replace two script phases that do nothing but copy files with copy files build phases.
This speeds up the build by a few seconds on high-end Mac Pros.
* JavaScriptCore.xcodeproj/project.pbxproj:
2011-03-01 David Kilzer <ddkilzer@apple.com>
Spring cleaning!
Rubber-stamped by Mark Rowe.
* JavaScriptCore.xcodeproj/project.pbxproj:
(Copy Into Framework): Remove "set -x" and its comment.
2011-03-01 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
TinyMCE not working in nightlies
https://bugs.webkit.org/show_bug.cgi?id=54978
Disabling setupBeginChars() to temporarily work arround the test
failure. Filed https://bugs.webkit.org/show_bug.cgi?id=55479
to track fixing the issue.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPattern::compile):
2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
Include a didReadNumber parameter to String -> float / double
conversion functions. This way, if the "ok" boolean out
parameter is false, you can check to see if there in fact
was a valid number parsed with garbage at the end. Examples
of that would be parsing "123x456" would have ok = false,
but didReadNumber = true.
* JavaScriptCore.exp:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
* wtf/text/StringImpl.h:
* wtf/text/WTFString.cpp:
(WTF::String::toDouble):
(WTF::String::toFloat):
(WTF::charactersToDouble):
(WTF::charactersToFloat):
* wtf/text/WTFString.h:
2011-02-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Past-the-end writes in VM exceptions (caused crashes in r79627)
https://bugs.webkit.org/show_bug.cgi?id=55448
Some exceptions had the wrong structures, so they misoverestimated their
inline storage sizes.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Use the right structure.
* runtime/JSObject.h:
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSFinalObject::JSFinalObject): ASSERT that our structure capacity
is correct to verify this doesn't happen again.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
* JavaScriptCore.pri: Move options also needed in WebCore into WebKit.pri.
* JavaScriptCore.pro: Deduplicate options.
* jsc.pro: Ditto.
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach JavaScriptCore GYP build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55425
In addition to teaching the JavaScriptCore GYP build about DEPTH, this
change overrides the GCC warning configuration to disable a warning
that's causing probems in Assertions.cpp. With that warning disabled,
JavaScriptCore builds again.
* gyp/JavaScriptCore.gyp:
2011-02-28 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79948.
http://trac.webkit.org/changeset/79948
https://bugs.webkit.org/show_bug.cgi?id=55439
"caused crashes on the SL release bot" (Requested by ggaren on
#webkit).
* runtime/JSGlobalData.h:
* runtime/WriteBarrier.h:
2011-02-28 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig & Darin Adler.
Bug 55423 - Clean up property tables in Structure
Encapsulate, reduce duplication of table search code,
and reduce the size of the tables (remove the index,
just maintain the tables in the correct order).
Shows a 0.5% - 1% progression on sunspider.
* JavaScriptCore.exp:
* runtime/PropertyMapHashTable.h:
(JSC::isPowerOf2):
(JSC::nextPowerOf2):
bit ops used to calculate table size.
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::ordered_iterator::operator++):
(JSC::PropertyTable::ordered_iterator::operator==):
(JSC::PropertyTable::ordered_iterator::operator!=):
(JSC::PropertyTable::ordered_iterator::operator*):
(JSC::PropertyTable::ordered_iterator::operator->):
(JSC::PropertyTable::ordered_iterator::ordered_iterator):
implementation of the iterator types
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::~PropertyTable):
constructors take an initial capacity for the table,
a table to copy, or both.
(JSC::PropertyTable::begin):
(JSC::PropertyTable::end):
create in-order iterators.
(JSC::PropertyTable::find):
search the hash table
(JSC::PropertyTable::add):
add a value to the hash table
(JSC::PropertyTable::remove):
remove a value from the hash table
(JSC::PropertyTable::size):
(JSC::PropertyTable::isEmpty):
accessors.
(JSC::PropertyTable::propertyStorageSize):
(JSC::PropertyTable::clearDeletedOffsets):
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
cache deleted (available) offsets in the property storage array.
(JSC::PropertyTable::copy):
take a copy of the PropertyTable, potentially expanding the capacity.
(JSC::PropertyTable::sizeInMemory):
used for DEBUG build statistics
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
(JSC::PropertyTable::tableCapacity):
(JSC::PropertyTable::deletedEntryIndex):
(JSC::PropertyTable::skipDeletedEntries):
(JSC::PropertyTable::table):
(JSC::PropertyTable::usedCount):
(JSC::PropertyTable::dataSize):
(JSC::PropertyTable::sizeForCapacity):
(JSC::PropertyTable::canInsert):
these methods provide internal implementation.
* runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNames):
(JSC::PropertyTable::checkConsistency):
(JSC::Structure::checkConsistency):
factored out code to PropertyMapHashTable.h
* runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
(JSC::Structure::isEmpty):
(JSC::Structure::get):
factored out code to PropertyMapHashTable.h
2011-02-28 Xan Lopez <xlopez@igalia.com>
Another fix build :(
Fix typo.
* runtime/MachineStackMarker.cpp:
(JSC::freePlatformThreadRegisters):
2011-02-28 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix for Snow Leopard.
* runtime/MachineStackMarker.cpp:
(JSC::freePlatformThreadRegisters):
2011-02-28 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fix SnowLeopard compilation after r79952.
* runtime/MachineStackMarker.cpp:
(JSC::freePlatformThreadRegisters):
2011-02-28 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<http://webkit.org/b/55430> OwnArrayPtr.h's LOOSE_OWN_ARRAY_PTR results in link errors.
* wtf/OwnArrayPtr.h:
(WTF::::set): Implement OwnArrayPtr::set.
2011-02-28 Martin Zoubek <martin.zoubek@acision.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838
Implement suspendThread() and resumeThread() for systems with
pthread.h using thread signal handler.
* runtime/MachineStackMarker.cpp:
(JSC::pthreadSignalHandlerSuspendResume):
(JSC::MachineStackMarker::Thread::Thread):
(JSC::getCurrentPlatformThread):
(JSC::suspendThread):
(JSC::resumeThread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):
(JSC::MachineStackMarker::markOtherThreadConservatively):
* wtf/Platform.h: Added Gtk port to use
ENABLE_JSC_MULTIPLE_THREADS.
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Stop using DeprecatedPtr for the global exception slot
https://bugs.webkit.org/show_bug.cgi?id=55424
Create GCRootPtr to signify that the exception slot is
a gcroot, and so is exempt from the usual writebarrier
restrictions.
* runtime/JSGlobalData.h:
* runtime/WriteBarrier.h:
(JSC::GCRootPtr::GCRootPtr):
(JSC::GCRootPtr::operator=):
2011-02-28 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Use more xcconfig files in JavaScriptCore gyp build
https://bugs.webkit.org/show_bug.cgi?id=55391
The GYP experts tell me that we have have a total of two xcconfig
files: one for the xcodeproj as a whole and one for each target. This
patch uses that technique to re-use the existing xcconfig files and
eliminate the duplication.
Technically, this patch introduces some build errors because the
xcconfig files assume that the xcodeproj file is one level higher in
the directory hierarchy. Specifically, the xcodeproj file can no
longer find the Info.plist or the prefix header. I plan to fix that in
a subsequent patch.
Also, this patch introduces the Release and Production configurations,
which should work correctly now.
* gyp/JavaScriptCore.gyp:
2011-02-28 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Add symbol to export.
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make ScopeChainNode GC allocated
https://bugs.webkit.org/show_bug.cgi?id=55283
Simplify lifetime and other issues with the scopechain
by making it gc allocated. This allows us to simplify
function exit and unwinding, as well as making the
current iterative refcounting go away.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::createActivation):
* bytecode/StructureStubInfo.cpp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
* bytecompiler/BytecodeGenerator.h:
* debugger/Debugger.cpp:
(JSC::Recompiler::operator()):
* debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::scopeChain):
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/CallFrame.h:
* interpreter/Interpreter.cpp:
(JSC::depth):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_end):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/ArgList.cpp:
* runtime/Completion.cpp:
(JSC::evaluate):
* runtime/Completion.h:
* runtime/DateConversion.cpp:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/GCActivityCallbackCF.cpp:
* runtime/Identifier.cpp:
* runtime/JSCell.h:
* runtime/JSChunk.cpp: Added.
* runtime/JSChunk.h: Added.
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
* runtime/JSFunction.h:
(JSC::JSFunction::scope):
(JSC::JSFunction::setScope):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::markChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::globalScopeChain):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSLock.cpp:
* runtime/JSNumberCell.cpp:
* runtime/JSZombie.cpp:
* runtime/MarkedBlock.cpp:
* runtime/MarkedSpace.cpp:
* runtime/PropertyNameArray.cpp:
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
(JSC::ScopeChainNode::localDepth):
(JSC::ScopeChainNode::markChildren):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::createStructure):
(JSC::ScopeChainNode::push):
(JSC::ScopeChainNode::pop):
(JSC::ScopeChainIterator::ScopeChainIterator):
(JSC::ScopeChainIterator::operator*):
(JSC::ScopeChainIterator::operator->):
(JSC::ScopeChainIterator::operator++):
(JSC::ScopeChainNode::begin):
(JSC::ScopeChainNode::end):
(JSC::ExecState::globalData):
(JSC::ExecState::lexicalGlobalObject):
(JSC::ExecState::globalThisValue):
* runtime/ScopeChainMark.h:
* wtf/DateMath.cpp:
2011-02-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement WTF::randomNumber in terms of WTF::cryptographicallyRandomNumber when possible
https://bugs.webkit.org/show_bug.cgi?id=55326
Currently, randomNumber does a bunch of platform-specific work that to
get a cryptographic randomness when available. Instead, we should use
cryptographicallyRandomNumber, which abstracts this work.
Unfortunately, we can't remove all of the WTF::randomNumber
implementation because not every port has access to cryptographically
random numbers.
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
2011-02-27 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Darin Adler.
Eliminate DeprecatedPtrList from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=54972
Add methods find() and contains() using an adaptor to ListHashSet.
Those method are like the one of HashSet, they allow to find objects
based on a different key than the one used to define the set.
Add convenience methods for direct access to the head and tail of the list.
Those methods are providing similar API/behavior as Vector.
* wtf/ListHashSet.h:
(WTF::::first):
(WTF::::last):
(WTF::::removeLast):
(WTF::ListHashSetTranslatorAdapter::hash):
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::find):
(WTF::::contains):
2011-02-26 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Add support for DragonFly BSD
https://bugs.webkit.org/show_bug.cgi?id=54407
DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.
* wtf/Platform.h:
2011-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
JavaScriptCore should use the xcconfig file instead of importing that information into GYP
https://bugs.webkit.org/show_bug.cgi?id=55282
Technically, this breaks the build because I had removed one of the
warnings in this config file, but this change seems like an
improvement.
* gyp/JavaScriptCore.gyp:
2011-02-26 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Nikolas Zimmermann.
SH4 JIT SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=44329
Provide an ExecutableAllocater::cacheFlush() implementation for
Linux/SH4.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79627.
http://trac.webkit.org/changeset/79627
https://bugs.webkit.org/show_bug.cgi?id=55274
broke worker tests (Requested by olliej on #webkit).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Heap.cpp:
(JSC::Heap::allocate):
* runtime/Heap.h:
* runtime/JSCell.h:
(JSC::JSCell::JSCell::operator new):
(JSC::JSCell::MarkedSpace::sizeClassFor):
(JSC::JSCell::MarkedSpace::allocate):
* runtime/MarkedBlock.h:
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::SizeClass::SizeClass):
2011-02-25 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Leak in JSParser::Scope of ScopeLabelInfo Vector
https://bugs.webkit.org/show_bug.cgi?id=55249
Changed m_labels to be an OwnPtr<>. Added VectorTraits
and Scope copy constructor to support this change.
* parser/JSParser.cpp:
(JSC::JSParser::Scope::~Scope):
2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
* JavaScriptCore.exp: Export WTF::cryptographicallyRandomNumber()
2011-02-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Move timeBeginPeriod into OS(WINDOWS) section
https://bugs.webkit.org/show_bug.cgi?id=55247
* jsc.cpp:
(main): timeBeginPeriod is available on all Windows versions and not compiler specific.
2011-02-25 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r79695.
* jsc.cpp:
(main): SetErrorMode isn't available on WinCE.
2011-02-25 Adam Roben <aroben@apple.com>
Work around Cygwin's crash-suppression behavior
Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
when our test apps launch to work around Cygwin's behavior.
Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
debugger) when launched from Cygwin 1.7
Reviewed by Darin Adler.
* API/tests/testapi.c: Added a now-needed #include.
(main):
* jsc.cpp:
(main):
Call ::SetErrorMode(0) to undo Cygwin's folly.
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our
other projects do so that windows.h won't define min/max macros that interfere with
std::numeric_limits<T>::min/max.
2011-02-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add GYP project for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=55027
Again, this GYP files is very rough, but it succeeds in building
JavaScriptCore. There's a lot more work to do here, especially in the
area of sharing with JavaScriptGlue.gyp. This patch is more of a
checkpoint so that other folks can help out if they wish.
* gyp: Added.
* gyp/JavaScriptCore.gyp: Added.
* gyp/generate-derived-sources.sh: Added.
2011-02-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add missing files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55193
I forgot to add mm files in my previous patch.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
2011-02-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove unused parameter name in GCActivityCallback.cpp
https://bugs.webkit.org/show_bug.cgi?id=55194
This change is not strictly required for the GYP-based build system,
but I noticed this error when working on the new build system.
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
2011-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Add a USE() macro to control use of the built-in UTF8 codec
https://bugs.webkit.org/show_bug.cgi?id=55189
Defaults USE(BUILTIN_UTF8_CODEC) to true for all platforms except chromium, which controls the flag via features.gypi.
* wtf/Platform.h:
2011-02-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Variable-sized allocation (but still capped at 64 bytes)
https://bugs.webkit.org/show_bug.cgi?id=55159
SunSpider reports no change.
* JavaScriptCore.exp: Some day, I hope not to have to edit this file.
* runtime/Heap.cpp:
(JSC::Heap::allocateSlowCase): Split allocation into a fast and slow
case, so the fast case can inline size class selection and turn it into
a compile-time constant.
Changed the collect-on-every allocation debugging switch to collect only
on every slow allocation, so you can still flip the switch without
recompiling the world. This may also be preferable for debugging purposes,
since collecting after every single allocation can be unusably slow,
and can mask problems by running destructors early.
* runtime/Heap.h: Ditto.
* runtime/JSCell.h:
(JSC::JSCell::MarkedSpace::sizeClassFor):
(JSC::JSCell::Heap::allocate):
(JSC::JSCell::JSCell::operator new): The inlining mentioned above.
* runtime/MarkedBlock.h: Dropped the block size from 256KB to 16KB. With
multiple size classes, allocating a full 256KB for the first allocation
in a given class can be pathologically wasteful. (8KB, or 4KB Mac and
8KB Windows, would be even better, but that seems to be a peformance
regression for now.)
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::reset): There's more than one size class now, and its
cell size is not constant.
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::SizeClass::SizeClass): Ditto.
2011-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make WeakGCMap use new handle infrastructure
https://bugs.webkit.org/show_bug.cgi?id=55100
Remove old WeakGCMap implementation and move over to new handle
based logic.
This has a number of benefits, most notably it makes a WeakGCMap
always reflect the true state of the world by as all entries are
removed at the first gc cycle that makes them dead. This allows
us to get rid of code in a wide variety of objects where the only
purpose was to remove themselves from maps.
It also means that we no longer need to have special "unchecked"
versions of any functions on WeakGCMap. Alas in order to maintain
compatibility with the JSWeakObjectMapClear API it is still
necessary to have an api that resembles uncheckedRemove, this is
now deprecatedRemove and will be dealt with in a later patch.
In order to get correct semantics in WeakGCMap we need more
contextual information in the finalizer, so we've added an
abstract class based finaliser and a context parameter to the
calls.
The new an improved WeakGCMap also results in sigificantly more
churn in the weak handle lists so exposed some potential problems
during the post mark phase which have been rectified as well.
* API/JSWeakObjectMapRefPrivate.cpp:
* API/JSWeakObjectMapRefPrivate.h:
* runtime/Heap.cpp:
(JSC::Heap::globalObjectCount):
(JSC::Heap::protectedGlobalObjectCount):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::init):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::iterator::iterator):
(JSC::WeakGCMap::iterator::get):
(JSC::WeakGCMap::iterator::getSlot):
(JSC::WeakGCMap::iterator::operator++):
(JSC::WeakGCMap::iterator::operator==):
(JSC::WeakGCMap::iterator::operator!=):
(JSC::WeakGCMap::WeakGCMap):
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::get):
(JSC::WeakGCMap::getSlot):
(JSC::WeakGCMap::set):
(JSC::WeakGCMap::take):
(JSC::WeakGCMap::size):
(JSC::WeakGCMap::deprecatedRemove):
(JSC::WeakGCMap::begin):
(JSC::WeakGCMap::end):
(JSC::WeakGCMap::~WeakGCMap):
(JSC::WeakGCMap::finalize):
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::set):
2011-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make weaklist processing deal with weak handles being removed during the iteration
https://bugs.webkit.org/show_bug.cgi?id=55105
It is possible for the handle heap to end up in a broken state if
a handle's finalizer removes either the current or next handle
to be visited during the post-gc cleanup. This patch removes that
problem by allowing the deallocate(Node*) routine to update the
iterator if it is called during finalization.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::HandleHeap):
(JSC::HandleHeap::updateAfterMark):
(JSC::HandleHeap::clearWeakPointers):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::protectedGlobalObjectCount):
* collector/handles/HandleHeap.h:
(JSC::Finalizer::~Finalizer):
(JSC::HandleHeap::getFinalizer):
(JSC::HandleHeap::deallocate):
(JSC::HandleHeap::makeWeak):
(JSC::HandleHeap::makeSelfDestroying):
(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::setFinalizer):
(JSC::HandleHeap::Node::finalizer):
(JSC::HandleHeap::Node::finalizerContext):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::setGlobalObject):
(JSC::GlobalObjectNotifier::finalize):
(JSC::RegisterFile::globalObjectCollectedNotifier):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
* runtime/Heap.cpp:
(JSC::Heap::destroy):
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::set):
2011-02-24 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
PatternAlternative leaked in YarrPatternConstructor::atomParenthesesEnd()
https://bugs.webkit.org/show_bug.cgi?id=55156
Added code to delete unneeded PatternAlternative after it is removed
from m_alternatives Vector.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
2011-02-24 Eric Seidel <eric@webkit.org>
Reviewed by Anders Carlsson.
VectorBuffer should not call malloc(0)
https://bugs.webkit.org/show_bug.cgi?id=55091
Turns out the malloc() call which was so hot in:
https://bugs.webkit.org/show_bug.cgi?id=55005
was actually just malloc(0).
We shouldn't be calling malloc(0) anyway, since there is no need to
and it might actually do work on some systems.
I believe on Mac it ends up taking the standard spinlocks (expensive)
and the code on Brew actually does a malloc(1) instead. Neither is desirable.
* wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
2011-02-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Remove obsolete PLATFORM(CI)
https://bugs.webkit.org/show_bug.cgi?id=55082
* wtf/Platform.h:
2011-02-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove the GFile GOwnPtr specialization
https://bugs.webkit.org/show_bug.cgi?id=55154
Remove the GFile specialization of GOwnPtr. It's sufficient to use GRefPtr
to track GFiles since they are just regular reference-counted GObjects.
* wtf/gobject/GOwnPtr.cpp: Remove GFile specialization.
* wtf/gobject/GOwnPtr.h: Ditto.
2011-02-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Rename PLATFORM(SKIA) to USE(SKIA)
https://bugs.webkit.org/show_bug.cgi?id=55090
* wtf/Platform.h:
2011-02-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove pthreads dependecy for JSLock
https://bugs.webkit.org/show_bug.cgi?id=54832
JSLock is only needed to support an obsolete execution model where JavaScriptCore
automatically protected against concurrent access from multiple threads.
So it's safe to disable it on non-mac platforms where we don't have native pthreads.
* runtime/JSLock.cpp:
2011-02-24 Chao-ying Fu <fu@mips.com>
Reviewed by Eric Seidel.
Fix MIPS build with new patchOffsetPut/GetByIdPropertyMapOffset1/2 values
https://bugs.webkit.org/show_bug.cgi?id=54997
* jit/JIT.h:
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
2011-02-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050
Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries
* JavaScriptCore.pri: rename addJavaScriptCore to prependJavaScriptCore
* jsc.pro: ditto
2011-02-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Deque<T> should support inline capacity
https://bugs.webkit.org/show_bug.cgi?id=55032
The title says it all. There are currently no places
which use this code yet, however it's been tested in conjunction
with code for bug 55005.
This also adds an ASSERT that capacity is never 1. If you were able
to set the capacity equal to 1, the Deque would just get confused
and happily append your item but still think it had size 0.
* wtf/Deque.h:
(WTF::DequeIterator::DequeIterator):
(WTF::DequeConstIterator::DequeConstIterator):
(WTF::DequeReverseIterator::DequeReverseIterator):
(WTF::DequeConstReverseIterator::DequeConstReverseIterator):
(WTF::::checkValidity):
(WTF::::checkIndexValidity):
(WTF::::invalidateIterators):
(WTF::::Deque):
(WTF::deleteAllValues):
(WTF::::operator):
(WTF::::destroyAll):
(WTF::::~Deque):
(WTF::::swap):
(WTF::::clear):
(WTF::::findIf):
(WTF::::expandCapacityIfNeeded):
(WTF::::expandCapacity):
(WTF::::takeFirst):
(WTF::::append):
(WTF::::prepend):
(WTF::::removeFirst):
(WTF::::remove):
(WTF::::addToIteratorsList):
(WTF::::removeFromIteratorsList):
(WTF::::DequeIteratorBase):
(WTF::::~DequeIteratorBase):
(WTF::::isEqual):
(WTF::::increment):
(WTF::::decrement):
(WTF::::after):
(WTF::::before):
* wtf/Vector.h:
2011-02-22 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
Add missing files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55020
gypi files are supposed to list every file under the sun. This patch
adds some missing files and sorts the rest.
* JavaScriptCore.gypi:
2011-02-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Refactored MarkedSpace to operate in terms of size classes
https://bugs.webkit.org/show_bug.cgi?id=55106
SunSpider reports no change.
* runtime/JSCell.h:
(JSC::JSCell::MarkedSpace::sizeClassFor):
(JSC::JSCell::MarkedSpace::allocate): Delegate allocation based on size
class. Since these functions are inline, the compiler can constant fold
them.
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::cellSize):
(JSC::MarkedBlock::size): Factored out a cellSize() helper.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::allocateFromSizeClass):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::reset): Changed to operate in terms of
abstract SizeClass objects, which are independent linked lists of blocks
of a certain size class, instead of a single m_heap object.
2011-02-23 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
[Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
https://bugs.webkit.org/show_bug.cgi?id=55093
Exclude OSRandomSource.cpp from the Chromium build. This function is
implemented in WebKit/chromium/src instead.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-02-23 Oliver Hunt <oliver@apple.com>
Roll out r64156 as it introduces incorrect behaviour.
* runtime/JSByteArray.h:
(JSC::JSByteArray::setIndex):
2011-02-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved the "nextAtom" allocation pointer into MarkedBlock for better encapsulation
https://bugs.webkit.org/show_bug.cgi?id=55079
SunSpider reports no change.
* runtime/Heap.cpp:
(JSC::Heap::reset): Moved Zombie sweeping here, up from MarkedSpace,
since we want Heap to logically control MarkedSpace. MarkedSpace should
never choose to sweep itself.
* runtime/JSCell.h:
(JSC::JSCell::MarkedBlock::allocate): Updated for nextAtom becoming a
member of MarkedBlock. No need to reset nextAtom to firstAtom() when
we reach the end of a block, since there's now an explicit reset pass
during GC.
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::reset): Added the nextAtom data member, and reordered
some data members to improve cache locality.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::CollectorHeap::CollectorHeap): Removed nextAtom, and added an
explicit reset pass.
2011-02-23 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r79428.
http://trac.webkit.org/changeset/79428
https://bugs.webkit.org/show_bug.cgi?id=54714
Does not work in the Chromium sandbox
* JavaScriptCore.exp:
2011-02-23 Adam Roben <aroben@apple.com>
Fix an off-by-one error in JSC::appendSourceToError
Looks like this bug has been around since the code was first added in r35245.
Fixes <http://webkit.org/b/55052> <rdar://problem/9043512> Crash in JSC::appendSourceToError
when running fast/dom/objc-big-method-name.html on Windows with full page heap enabled
Reviewed by Darin Adler.
* interpreter/Interpreter.cpp:
(JSC::appendSourceToError): When trimming whitespace off the end of the string, examine the
character at stop-1 rather than at stop. At this point in the code, stop represents the
index just past the end of the characters we care about, and can even be just past the end
of the entire data buffer.
2011-02-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Rolled back in r79367 with SnowLeopard Release bot crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=54999
The crash was caused by failure to update the "nextBlock" pointer when
removing a block from the list while shrinking. The fix is to update the
"nextBlock" pointer.
This crash was very rare because it only happened in cases where the very
first block in the heap contained no marked cells.
2011-02-23 Dan Bernstein <mitz@apple.com>
Reviewed by Gavin Barraclough.
Include frame numbers in backtraces.
https://bugs.webkit.org/show_bug.cgi?id=55060
* wtf/Assertions.cpp:
2011-02-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
latest jsc for armv7 crashes in sunspider tests
https://bugs.webkit.org/show_bug.cgi?id=54667
Update JIT offset values in ARMv7 after r78732. Fixes crashes in
SunSpider and JavaScript tests.
* jit/JIT.h: update values.
2011-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79418.
http://trac.webkit.org/changeset/79418
https://bugs.webkit.org/show_bug.cgi?id=55043
"breaks shlib linux build" (Requested by morrita on #webkit).
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Alexey Proskuryakov.
Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp
https://bugs.webkit.org/show_bug.cgi?id=54831
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/Structure.cpp:
(JSC::ignoreSetMutex):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::initializeThreading):
* runtime/Structure.h:
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540
* runtime/DatePrototype.cpp:
* runtime/GCActivityCallbackCF.cpp:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* wtf/CurrentTime.cpp:
* wtf/Platform.h:
* wtf/text/AtomicString.h:
* wtf/text/StringImpl.h:
(WTF::StringImpl::computeHash):
* wtf/text/WTFString.h:
* wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
2011-02-23 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix for Windows.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export WTF::cryptographicallyRandomNumber()
2011-02-23 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
* JavaScriptCore.exp: Export WTF::cryptographicallyRandomNumber()
2011-02-22 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
Add missing files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55020
gypi files are supposed to list every file under the sun. This patch
adds some missing files and sorts the rest.
* JavaScriptCore.gypi:
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012
all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* runtime/MarkedBlock.h:
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::destroy):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::CollectorHeap::collectorBlock):
* wtf/CMakeLists.txt:
* wtf/DoublyLinkedList.h: Removed.
2011-02-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999
SunSpider reports no change.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: So many build systems, so little time.
* wtf/CMakeLists.txt:
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::setPrev):
(JSC::MarkedBlock::setNext):
(JSC::MarkedBlock::prev):
(JSC::MarkedBlock::next): Added linked list data members and accessors.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::destroy):
(JSC::MarkedSpace::allocateBlock): Stop using vector, since it doesn't exist anymore.
(JSC::MarkedSpace::freeBlocks): New helper function for updating relevant
data structures when freeing blocks.
(JSC::MarkedSpace::allocate): Updated for nextBlock being a pointer and
not a vector index.
(JSC::MarkedSpace::shrink): Construct a temporary list of empties and
then free them, to avoid modifying our hash table while iterating it.
This wasn't a concern before because we were using indirect array
indexing, not direct pointer indexing.
(JSC::MarkedSpace::reset): Updated for nextBlock being a pointer and
not a vector index.
* runtime/MarkedSpace.h:
(JSC::CollectorHeap::CollectorHeap): Changed data type from vector to linked list.
* wtf/DoublyLinkedList.h: Added. New linked list class.
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
2011-02-22 Gavin Barraclough <barraclough@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54988 - Re-create StructureTransitionTable class, encapsulate transition table
The Structure class keeps a table of transitions to derived Structure types. Since
this table commonly contains a single entry we employ an optimization where instead
of holding a map, we may hold a pointer directly to a single instance of the mapped
type. We use an additional bit of data to flag whether the pointer is currently
pointing to a table of transitions, or a singleton transition. Previously we had
commonly used a pattern of storing data in the low bits of pointers, but had moved
away from this since it causes false leaks to be reported by the leaks tool. However
in this case, the entries in the map are weak links - this pointer will never be
responsible for keeping an object alive. As such we can use this approach provided
that the bit is set when a table is not in use (otherwise the table would appear to
be leaked).
Additionally, the transition table currently allows two entries to exist for a given
key - one specialized to a particular value, and one not specialized. This is
unnecessary, wasteful, and a little inconsistent. (If you create an entry for a
specialized value, then a non-specialized entry, both will exist. If you create an
entry for a non-specialized value, then try to create a specialized entry, only a
non-specialized form will be allowed.)
This shows a small progression on v8.
* JavaScriptCore.exp:
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::get):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):
(JSC::StructureTransitionTable::Hash::equal):
(JSC::StructureTransitionTable::HashTraits::emptyValue):
(JSC::StructureTransitionTable::HashTraits::constructDeletedValue):
(JSC::StructureTransitionTable::HashTraits::isDeletedValue):
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::isUsingSingleSlot):
(JSC::StructureTransitionTable::map):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* JavaScriptCore.pri: Remove the workaround.
2011-02-21 Adam Roben <aroben@apple.com>
Fix linker warning on Windows
r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.
Rubber-stamped by Anders Carlsson.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.
2011-02-21 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Add a new use flag for using the CFURLCache.
* wtf/Platform.h:
2011-02-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=54901
* jit/JIT.h: swap actual and expected values in message, they were
reversed.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of
a simple ASSERT.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check): ditto.
(JSC::JIT::compileGetByIdHotPath): ditto.
(JSC::JIT::compileGetByIdSlowCase): ditto.
(JSC::JIT::emit_op_put_by_id): ditto.
2011-02-21 Gavin Barraclough <barraclough@apple.com>
Ruber stamped by Sam Weinig
Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
2011-02-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.
* API/JSCallbackConstructor.cpp:
* API/JSCallbackFunction.cpp:
* API/JSCallbackObjectFunctions.h:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
* runtime/BooleanObject.cpp:
* runtime/DateInstance.cpp:
* runtime/DatePrototype.cpp:
* runtime/ErrorInstance.cpp:
* runtime/InternalFunction.cpp:
* runtime/JSActivation.cpp:
* runtime/JSArray.cpp:
* runtime/JSFunction.cpp:
* runtime/JSONObject.cpp:
* runtime/JSObject.h:
* runtime/JSZombie.h:
* runtime/MathObject.cpp:
* runtime/NativeErrorConstructor.cpp:
* runtime/NumberConstructor.cpp:
* runtime/NumberObject.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.cpp:
* runtime/StringObject.cpp:
* runtime/StringPrototype.cpp:
2011-02-21 Adam Roben <aroben@apple.com>
Export JSObject::s_info from JavaScriptCore.dll
This matches what we do for all other ClassInfo objects that WebCore needs access to.
Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows
Reviewed by Sam Weinig.
* runtime/JSObject.h: Added JS_EXPORTDATA to s_info.
2011-02-21 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Switched to compiler based detection, where the error actually is.
It is not the platform that needs the workaround, it is the compiler.
QtWebKit fails to compile on Windows XP with msvc-2008
https://bugs.webkit.org/show_bug.cgi?id=54746
* bytecode/CodeBlock.h:
* runtime/RegExpObject.h:
2011-02-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.
Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.
NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.
GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
Removed symbols / references to files.
* runtime/GlobalEvalFunction.cpp: Removed.
* runtime/GlobalEvalFunction.h: Removed.
* runtime/NativeFunctionWrapper.h: Removed.
* runtime/PrototypeFunction.cpp: Removed.
* runtime/PrototypeFunction.h: Removed.
Removed.
* runtime/Executable.cpp:
(JSC::NativeExecutable::~NativeExecutable):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):
* runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
Added interpreter-friendly constructors for NativeExecutables.
* bytecompiler/BytecodeGenerator.cpp:
* interpreter/Interpreter.cpp:
* jit/JITStubs.cpp:
* jsc.cpp:
* runtime/ArrayConstructor.cpp:
* runtime/BooleanPrototype.cpp:
* runtime/BooleanPrototype.h:
* runtime/CallData.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/ErrorPrototype.cpp:
* runtime/ErrorPrototype.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/Lookup.cpp:
* runtime/NumberPrototype.cpp:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpPrototype.cpp:
* runtime/RegExpPrototype.h:
* runtime/SmallStrings.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
Removed use of redundant classes.
2011-02-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix for Symbian.
[Symbian] Revert the removal of linking
against hal after r79126.
Dependency on the hal library can not be removed
as it is still used (e.g. in MarkStackSymbian.cpp).
* JavaScriptCore.pri:
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Interpreter build fix.
* runtime/ArrayConstructor.cpp:
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:
* runtime/FunctionPrototype.cpp:
* runtime/Lookup.cpp:
* runtime/NumberPrototype.cpp:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectPrototype.cpp:
* runtime/RegExpPrototype.cpp:
* runtime/StringConstructor.cpp:
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Build fix!!
* JavaScriptCore.exp:
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Windows build fix!!
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Windows build fix!
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Build fix!
* JavaScriptCore.exp:
2011-02-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54786 - Devirtualize JSCell::classInfo()
Instead of making a virtual function call, add a pointer to the ClassInfo
onto Structure.
This removes a virtual function call, and paves the way towards removing all
the createStructure methods, and StructureFlags/AnonymousSlotCount properties
(these should be able to move onto ClassInfo).
Calls to Structure::create must now pass a pointer to the ClassInfo for the
structure. All objects now have a ClassInfo pointer, non-object cell types
still do not.
Changes are most mechanical, involving three steps:
* Remove virtual classInfo() methods.
* Add &s_info parameter to calls to Structure::create.
* Rename ClassInfo static members on classes from 'info' to 's_info',
for consistency.
* API/JSCallbackConstructor.cpp:
* API/JSCallbackConstructor.h:
* API/JSCallbackFunction.cpp:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.cpp:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
* API/JSValueRef.cpp:
* API/JSWeakObjectMapRefPrivate.cpp:
* JavaScriptCore.exp:
* debugger/Debugger.cpp:
* debugger/DebuggerActivation.h:
* debugger/DebuggerCallFrame.cpp:
* interpreter/Interpreter.cpp:
* jit/JITCall32_64.cpp:
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
* profiler/Profiler.cpp:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/BooleanObject.cpp:
* runtime/BooleanObject.h:
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/DateInstance.cpp:
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
* runtime/DatePrototype.h:
* runtime/ErrorInstance.cpp:
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.cpp:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
* runtime/GetterSetter.h:
* runtime/GlobalEvalFunction.h:
* runtime/InternalFunction.cpp:
* runtime/InternalFunction.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.h:
* runtime/JSVariableObject.h:
* runtime/JSWrapperObject.h:
* runtime/JSZombie.cpp:
* runtime/JSZombie.h:
* runtime/Lookup.cpp:
* runtime/MathObject.cpp:
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
* runtime/NumberObject.h:
* runtime/NumberPrototype.cpp:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectPrototype.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
* runtime/ScopeChain.cpp:
* runtime/StringConstructor.cpp:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
* runtime/StringPrototype.cpp:
* runtime/StringPrototype.h:
* runtime/Structure.cpp:
* runtime/Structure.h:
2011-02-19 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/54808> Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc
Reviewed by Dan Bernstein.
* Configurations/Base.xcconfig: Added
JAVASCRIPTCORE_FRAMEWORKS_DIR variable.
* Configurations/JavaScriptCore.xcconfig: Used
JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH.
* JavaScriptCore.xcodeproj/project.pbxproj: Set the INSTALL_PATH
for Production configuration of jsc target.
(Copy Into Framework): Removed old build phase.
(Fix Framework Reference): Renamed build phase to "Copy Into
Framework". Added "set -x" call to make the script print the
commands it is running. Added code to exit early for Production
builds since this was never intended for them. Added code to
copy jsc into the JavaScriptCore.framework/Resources directory.
2011-02-19 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] OSAllocator implementation for Symbian OS.
Manages both data and code region requests. V8 and Sunspider tested
OK with interpreter. Not tested with JSC JIT yet as it has unrelated
failures. Also no thread safety yet.
https://bugs.webkit.org/show_bug.cgi?id=51128
* JavaScriptCore.pri: removed HAL linkage
* wtf/Bitmap.h:
(WTF::::findRunOfZeros): find run of zeros in a bitmap. quick n dirty
* wtf/OSAllocator.h:
(WTF::OSAllocator::decommitAndRelease): decommit explicitly
* wtf/OSAllocatorSymbian.cpp: Impl. of OSAllocator interface
(WTF::allocateCodeChunk): utility for code chunks
(WTF::deallocateCodeChunk): utility for code chunks
(WTF::dataAllocatorInstance): getter for data allocator instance
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::releaseDecommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::reserveAndCommit):
(WTF::PageAllocatorSymbian::PageAllocatorSymbian): maps requests
to one underlying Symbian chunk
(WTF::PageAllocatorSymbian::~PageAllocatorSymbian):
(WTF::PageAllocatorSymbian::reserve):
(WTF::PageAllocatorSymbian::release):
(WTF::PageAllocatorSymbian::commit):
(WTF::PageAllocatorSymbian::decommit):
(WTF::PageAllocatorSymbian::contains):
* wtf/PageAllocatorSymbian.h: Added.
(WTF::SymbianChunk::SymbianChunk): wrapper around RChunk
(WTF::SymbianChunk::~SymbianChunk):
(WTF::SymbianChunk::contains):
2011-02-19 Yong Li <yoli@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=54687
When being built with armcc, "int" bit fields are treated as
unsigned integers, which will fail the comparisons like "m_offset == -1".
Using "signed" fixes the problem.
* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
2011-02-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Made MarkedSpace block iteration size-class agnostic
https://bugs.webkit.org/show_bug.cgi?id=54792
SunSpider reports no change.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity):
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::forEach): Iterate blocks in hashing order instead of
size class list order. This is a much simpler convention in a world
of many different size classes.
2011-02-18 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Added friend exception to Qt platform, which also compiles Windows.
QtWebKit fails to compile on Windows XP with msvc-2008
https://bugs.webkit.org/show_bug.cgi?id=54746
* bytecode/CodeBlock.h:
* runtime/RegExpObject.h:
2011-02-18 Geoffrey Garen <ggaren@apple.com>
(Rolled back in r79022 with crash fixed.)
Reviewed by Sam Weinig.
Use hashing instead of linear search in the conservative pointer test
https://bugs.webkit.org/show_bug.cgi?id=54767
SunSpider reports no change.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::destroy): No need to explicitly clear the blocks array,
since freeBlock removes items for us.
(JSC::MarkedSpace::freeBlock): Fixed a typo that always removed the last
block from the block set instead of the block being freed. Changed to
remove a block from our data structures before deallocating it, since
this is slightly cleaner.
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::contains): Variable-sized objects will use more,
smaller blocks, so it's important for the contains check not to be O(n)
in the number of blocks.
2011-02-18 chris reiss <christopher.reiss@nokia.com>
Reviewed by Andreas Kling.
REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989
updated test fast/js/script-tests/date-parse-test.js
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
2011-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79022.
http://trac.webkit.org/changeset/79022
https://bugs.webkit.org/show_bug.cgi?id=54775
It broke the whole world (Requested by Ossy on #webkit).
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::contains):
2011-02-18 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Dave Hyatt.
Add support for dir=auto
https://bugs.webkit.org/show_bug.cgi?id=50916
Change defaultWritingDirection() to return if the writing direction
was determined from a letter with strong directionality or not.
* JavaScriptCore.exp:
* JavaScriptCore.order:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::defaultWritingDirection):
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:
(WTF::String::defaultWritingDirection):
2011-02-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Use hashing instead of linear search in the conservative pointer test
https://bugs.webkit.org/show_bug.cgi?id=54767
SunSpider reports no change.
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::contains): Variable-sized objects will use more,
smaller blocks, so it's important for the contains check not to be O(n)
in the number of blocks.
2011-02-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Tightened some usage accounting code in MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=54761
SunSpider reports no change.
* runtime/Heap.cpp:
(JSC::Heap::Heap): Initialize the marked space high water mark on
construction, instead of relying on some implicit subtleties to make
not initializing it work out OK.
* runtime/Heap.h: Fixed up includes.
* runtime/MarkedBlock.h: Made firstAtom() static so clients can call it
even without having allocated a block.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace): Don't pre-allocate a block, since this
would be prohibitively expensive with multiple size classes.
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): Track allocated blocks in a hash set,
since linear search in the contains check will be prohibitively
expensive once we're using lots of smaller blocks.
(JSC::MarkedSpace::allocate): Don't assume that we always have a block
allocated, since we don't anymore. (See above.)
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h: Updated for changes mentioned above.
2011-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Made object allocation secretly variable-sized (Shhhh!)
https://bugs.webkit.org/show_bug.cgi?id=54721
SunSpider reports no change.
Internally, MarkedBlock now makes variable-sized allocations, even
though MarkedSpace doesn't take advantage of this yet.
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock): No need to ASSERT that allocations are
fixed-sized.
* runtime/MarkedBlock.h: Shrunk the atom size so we can allocate things
that are not multiples of 64 bytes.
2011-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some math errors when when using variable-sized cells
https://bugs.webkit.org/show_bug.cgi?id=54717
SunSpider reports no change.
Computer Science Barbie says, "Math is not so hard afterall!"
* runtime/JSCell.h:
(JSC::JSCell::MarkedBlock::allocate): Round up when calculating the
minimum number of atoms required for a cell, since rounding down
will get you splinched.
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::forEach): Changed a bunch of != tests to < tests
because m_endAtom is actually a fuzzy end -- iterating from firstAtom()
may not hit m_endAtom exactly.
2011-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more abstraction for MarkedSpace::contains
https://bugs.webkit.org/show_bug.cgi?id=54715
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::contains): Added a contains function, so MarkedSpace
doesn't have to know how MarkedBlock tracks containment internally.
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::contains): Call through to MarkedBlock to figure out
if a cell that seems to be in a block is valid.
2011-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed the invariant that the last cell in a block is always marked
https://bugs.webkit.org/show_bug.cgi?id=54713
SunSpider reports no change.
This adds one branch to allocation, but simplifies the mark invariant,
especially in a world of variable-sized cells. Now, it really is true
that any cell whose mark bit is set is a valid, live cell whose
constructor has run and whose destructor has not run.
* runtime/JSCell.h:
(JSC::JSCell::MarkedBlock::allocate): Changed this do-while into a while
since we can no longer rely on a set mark bit to break out of this loop
before it reaches the end of the block.
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::forEach): No need to set a special last mark bit.
2011-02-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78856 and r78907.
http://trac.webkit.org/changeset/78856
http://trac.webkit.org/changeset/78907
https://bugs.webkit.org/show_bug.cgi?id=54705
These seem to break tests on 32-bit builds. (Requested by
aroben on #webkit).
* JavaScriptCore.xcodeproj/project.pbxproj:
* collector/handles/Global.h:
(JSC::Global::internalSet):
* collector/handles/Handle.h:
(JSC::HandleTypes::getFromSlot):
(JSC::HandleTypes::toJSValue):
(JSC::HandleTypes::validateUpcast):
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
(JSC::Handle::Handle):
(JSC::Handle::get):
* runtime/JSArray.cpp:
(JSC::JSArray::sortNumeric):
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
* runtime/SlotAccessor.h: Removed.
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::internalSet):
* runtime/WriteBarrier.h:
(JSC::DeprecatedPtr::DeprecatedPtr):
(JSC::DeprecatedPtr::get):
(JSC::DeprecatedPtr::operator*):
(JSC::DeprecatedPtr::operator->):
(JSC::DeprecatedPtr::slot):
(JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
(JSC::DeprecatedPtr::operator!):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrierBase::clear):
(JSC::WriteBarrierBase::slot):
(JSC::WriteBarrierBase::operator UnspecifiedBoolType*):
(JSC::WriteBarrierBase::operator!):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
(JSC::WriteBarrier::WriteBarrier):
2011-02-17 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed.
[Qt] Buildfix.
* wtf/RetainPtr.h: Add missing PLATFORM(CF) guard.
2011-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made MarkedBlock variable-sized
https://bugs.webkit.org/show_bug.cgi?id=54692
SunSpider reports no change.
Each MarkedBlock is now composed of a set of fixed-sized atoms, with one
mark bit per atom. A given cell may be composed of one or more atoms.
* runtime/Heap.cpp:
(JSC::Heap::allocate): Made fixed-sizedness a property of MarkedSpace,
bubbling it up from MarkedBlock, since MarkedBlock now supports variable-
sizedness.
* runtime/JSCell.h:
(JSC::JSCell::MarkedBlock::allocate): Removed use of CELLS_PER_BLOCK and
(implicit) one constants -- these quantities are not constant anymore.
Updated for switch from cell to atom.
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::firstAtom):
(JSC::MarkedBlock::atoms):
(JSC::MarkedBlock::isAtomAligned):
(JSC::MarkedBlock::blockFor):
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::size):
(JSC::MarkedBlock::capacity):
(JSC::MarkedBlock::atomNumber):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::forEach): Same as above. Also removed use of CELL_SIZE
and BLOCK_SIZE, and switched away from calling arbitrary pointers cells.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::CollectorHeap::CollectorHeap):
(JSC::MarkedSpace::contains): Updated for renames. Made fixed-sizedness
a property of MarkedSpace.
2011-02-17 Oliver Hunt <oliver@apple.com>
Attempt to fix windows build
* runtime/WriteBarrier.h:
2011-02-17 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Refactor WriteBarrier and DeprecatedPtr to have less code duplication.
https://bugs.webkit.org/show_bug.cgi?id=54608
Make use of the tricks used for Handle, et al to avoid duplicating all
of the logic for DeprecatedPtr and WriteBarrier simply to support known
vs. unknown types.
* JavaScriptCore.xcodeproj/project.pbxproj:
* collector/handles/Global.h:
(JSC::Global::internalSet):
* collector/handles/Handle.h:
(JSC::Handle::Handle):
(JSC::Handle::get):
* runtime/JSArray.cpp:
(JSC::JSArray::sortNumeric):
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
* runtime/SlotAccessor.h: Added.
(JSC::SlotTypes::getFromBaseType):
(JSC::SlotTypes::convertToBaseType):
(JSC::SlotTypes::getFromSlot):
(JSC::SlotTypes::toJSValue):
(JSC::SlotTypes::validateUpcast):
(JSC::SlotAccessor::operator->):
(JSC::SlotAccessor::operator*):
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::internalSet):
* runtime/WriteBarrier.h:
(JSC::DeprecatedPtr::DeprecatedPtr):
(JSC::DeprecatedPtr::get):
(JSC::DeprecatedPtr::slot):
(JSC::DeprecatedPtr::operator=):
(JSC::WriteBarrierTranslator::convertToStorage):
(JSC::WriteBarrierTranslator::convertFromStorage):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::clear):
(JSC::WriteBarrierBase::slot):
(JSC::WriteBarrierBase::operator UnspecifiedBoolType*):
(JSC::WriteBarrierBase::operator!):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
(JSC::WriteBarrier::WriteBarrier):
2011-02-17 Kevin Ollivier <kevino@theolliviers.com>
[wx] Revert incorrect blind fix and restore previous working code.
* wtf/wx/StringWx.cpp:
(WTF::String::String):
2011-02-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Intermittent crashes beneath MarkStack::drain
https://bugs.webkit.org/show_bug.cgi?id=54614
<rdar://problem/8971070>
The crashes were caused by a GC happening after the global object's
property table had grown (due to compilation), but before the properties
had been fully initialized by program execution.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Explicitly resize the global
object's register storage immediately, without waiting for program
execution to do it for us. This ensures that the global object's count
of global variables is consistent with the size of its global variable
storage at all times, and it ensures that all global variables are
properly initialized from the get-go.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::resizeRegisters):
* runtime/JSGlobalObject.h: Added a helper function for growing the
global object's register storage, and initializing new registers.
== Rolled over to ChangeLog-2011-02-16 ==
|