1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249
|
/*
* Copyright (C) 2017 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
* THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "MarkingConstraintSet.h"
#include "Options.h"
#include <wtf/TimeWithDynamicClockType.h>
namespace JSC {
class MarkingConstraintSet::ExecutionContext {
public:
ExecutionContext(MarkingConstraintSet& set, SlotVisitor& visitor, MonotonicTime timeout)
: m_set(set)
, m_visitor(visitor)
, m_timeout(timeout)
{
}
bool didVisitSomething() const
{
return m_didVisitSomething;
}
bool shouldTimeOut() const
{
return didVisitSomething() && hasElapsed(m_timeout);
}
// Returns false if it times out.
bool drain(BitVector& unexecuted)
{
for (size_t index : unexecuted) {
execute(index);
unexecuted.clear(index);
if (shouldTimeOut())
return false;
}
return true;
}
bool didExecute(size_t index) const { return m_executed.get(index); }
void execute(size_t index)
{
m_set.m_set[index]->execute(m_visitor, m_didVisitSomething, m_timeout);
m_executed.set(index);
}
private:
MarkingConstraintSet& m_set;
SlotVisitor& m_visitor;
MonotonicTime m_timeout;
BitVector m_executed;
bool m_didVisitSomething { false };
};
MarkingConstraintSet::MarkingConstraintSet()
{
}
MarkingConstraintSet::~MarkingConstraintSet()
{
}
void MarkingConstraintSet::didStartMarking()
{
m_unexecutedRoots.clearAll();
m_unexecutedOutgrowths.clearAll();
for (auto& constraint : m_set) {
constraint->resetStats();
switch (constraint->volatility()) {
case ConstraintVolatility::GreyedByExecution:
m_unexecutedRoots.set(constraint->index());
break;
case ConstraintVolatility::GreyedByMarking:
m_unexecutedOutgrowths.set(constraint->index());
break;
case ConstraintVolatility::SeldomGreyed:
break;
}
}
m_iteration = 1;
}
void MarkingConstraintSet::add(CString abbreviatedName, CString name, Function<void(SlotVisitor&, const VisitingTimeout&)> function, ConstraintVolatility volatility)
{
add(std::make_unique<MarkingConstraint>(WTFMove(abbreviatedName), WTFMove(name), WTFMove(function), volatility));
}
void MarkingConstraintSet::add(
CString abbreviatedName, CString name,
Function<void(SlotVisitor&, const VisitingTimeout&)> executeFunction,
Function<double(SlotVisitor&)> quickWorkEstimateFunction,
ConstraintVolatility volatility)
{
add(std::make_unique<MarkingConstraint>(WTFMove(abbreviatedName), WTFMove(name), WTFMove(executeFunction), WTFMove(quickWorkEstimateFunction), volatility));
}
void MarkingConstraintSet::add(
std::unique_ptr<MarkingConstraint> constraint)
{
constraint->m_index = m_set.size();
m_ordered.append(constraint.get());
if (constraint->volatility() == ConstraintVolatility::GreyedByMarking)
m_outgrowths.append(constraint.get());
m_set.append(WTFMove(constraint));
}
bool MarkingConstraintSet::executeConvergence(SlotVisitor& visitor, MonotonicTime timeout)
{
bool result = executeConvergenceImpl(visitor, timeout);
if (Options::logGC())
dataLog(" ");
return result;
}
bool MarkingConstraintSet::isWavefrontAdvancing(SlotVisitor& visitor)
{
for (MarkingConstraint* outgrowth : m_outgrowths) {
if (outgrowth->workEstimate(visitor))
return true;
}
return false;
}
bool MarkingConstraintSet::executeConvergenceImpl(SlotVisitor& visitor, MonotonicTime timeout)
{
ExecutionContext executionContext(*this, visitor, timeout);
unsigned iteration = m_iteration++;
if (Options::logGC())
dataLog("i#", iteration, ":");
// If there are any constraints that we have not executed at all during this cycle, then
// we should execute those now.
if (!executionContext.drain(m_unexecutedRoots))
return false;
// First iteration is before any visitor draining, so it's unlikely to trigger any constraints other
// than roots.
if (iteration == 1)
return false;
if (!executionContext.drain(m_unexecutedOutgrowths))
return false;
// We want to keep preferring the outgrowth constraints - the ones that need to be fixpointed
// even in a stop-the-world GC - until they stop producing. They have a tendency to go totally
// silent at some point during GC, at which point it makes sense not to run them again until
// the end. Outgrowths producing new information corresponds almost exactly to the wavefront
// advancing: it usually means that we are marking objects that should be marked based on
// other objects that we would have marked anyway. Once the wavefront is no longer advancing,
// we want to run mostly the root constraints (based on their predictions of how much work
// they will have) because at this point we are just trying to outpace the retreating
// wavefront.
//
// Note that this function (executeConvergenceImpl) only returns true if it runs all
// constraints. So, all we are controlling are the heuristics that say which constraints to
// run first. Choosing the constraints that are the most likely to produce means running fewer
// constraints before returning.
bool isWavefrontAdvancing = this->isWavefrontAdvancing(visitor);
std::sort(
m_ordered.begin(), m_ordered.end(),
[&] (MarkingConstraint* a, MarkingConstraint* b) -> bool {
// Remember: return true if a should come before b.
auto volatilityScore = [] (MarkingConstraint* constraint) -> unsigned {
return constraint->volatility() == ConstraintVolatility::GreyedByMarking ? 1 : 0;
};
unsigned aVolatilityScore = volatilityScore(a);
unsigned bVolatilityScore = volatilityScore(b);
if (aVolatilityScore != bVolatilityScore) {
if (isWavefrontAdvancing)
return aVolatilityScore > bVolatilityScore;
else
return aVolatilityScore < bVolatilityScore;
}
double aWorkEstimate = a->workEstimate(visitor);
double bWorkEstimate = b->workEstimate(visitor);
if (aWorkEstimate != bWorkEstimate)
return aWorkEstimate > bWorkEstimate;
// This causes us to use SeldomGreyed vs GreyedByExecution as a final tie-breaker.
return a->volatility() > b->volatility();
});
for (MarkingConstraint* constraint : m_ordered) {
size_t i = constraint->index();
if (executionContext.didExecute(i))
continue;
executionContext.execute(i);
// Once we're in convergence, it makes the most sense to let some marking happen anytime
// we find work.
// FIXME: Maybe this should execute all constraints until timeout? Not clear if that's
// better or worse. Maybe even better is this:
// - If the visitor is empty, keep running.
// - If the visitor is has at least N things, return.
// - Else run until timeout.
// https://bugs.webkit.org/show_bug.cgi?id=166832
if (executionContext.didVisitSomething())
return false;
}
return true;
}
void MarkingConstraintSet::executeAll(SlotVisitor& visitor)
{
bool didVisitSomething = false;
for (auto& constraint : m_set)
constraint->execute(visitor, didVisitSomething, MonotonicTime::infinity());
if (Options::logGC())
dataLog(" ");
}
} // namespace JSC
|