1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954
|
/*
* Copyright (C) 2018 Igalia S.L.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
*/
#include "config.h"
#include "BubblewrapLauncher.h"
#if ENABLE(BUBBLEWRAP_SANDBOX)
#include "XDGDBusProxy.h"
#include <WebCore/PlatformDisplay.h>
#include <fcntl.h>
#include <glib.h>
#include <seccomp.h>
#include <sys/ioctl.h>
#include <sys/mman.h>
#include <wtf/FileSystem.h>
#include <wtf/NeverDestroyed.h>
#include <wtf/UUID.h>
#include <wtf/UniStdExtras.h>
#include <wtf/glib/GRefPtr.h>
#include <wtf/glib/GUniquePtr.h>
#if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
#include <linux/memfd.h>
#endif
#include "Syscalls.h"
#if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
// These defines were added in glibc 2.27, the same release that added memfd_create.
// But the kernel added all of this in Linux 3.17. So it's totally safe for us to
// depend on, as long as we define it all ourselves. Remove this once we depend on
// glibc 2.27.
#define F_ADD_SEALS 1033
#define F_GET_SEALS 1034
#define F_SEAL_SEAL 0x0001
#define F_SEAL_SHRINK 0x0002
#define F_SEAL_GROW 0x0004
#define F_SEAL_WRITE 0x0008
static int memfd_create(const char* name, unsigned flags)
{
return syscall(__NR_memfd_create, name, flags);
}
#endif // #if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
#if PLATFORM(GTK)
#define BASE_DIRECTORY "webkitgtk"
#elif PLATFORM(WPE)
#define BASE_DIRECTORY "wpe"
#endif
namespace WebKit {
using namespace WebCore;
static int createSealedMemFdWithData(const char* name, gconstpointer data, size_t size)
{
int fd = memfd_create(name, MFD_ALLOW_SEALING);
if (fd == -1) {
g_warning("memfd_create failed: %s", g_strerror(errno));
return -1;
}
ssize_t bytesWritten = write(fd, data, size);
if (bytesWritten < 0) {
g_warning("Writing args to memfd failed: %s", g_strerror(errno));
close(fd);
return -1;
}
if (static_cast<size_t>(bytesWritten) != size) {
g_warning("Failed to write all args to memfd");
close(fd);
return -1;
}
if (lseek(fd, 0, SEEK_SET) == -1) {
g_warning("lseek failed: %s", g_strerror(errno));
close(fd);
return -1;
}
if (fcntl(fd, F_ADD_SEALS, F_SEAL_SHRINK | F_SEAL_GROW | F_SEAL_WRITE | F_SEAL_SEAL) == -1) {
g_warning("Failed to seal memfd: %s", g_strerror(errno));
close(fd);
return -1;
}
return fd;
}
int argumentsToFileDescriptor(const Vector<CString>& args, const char* name)
{
GString* buffer = g_string_new(nullptr);
for (const auto& arg : args)
g_string_append_len(buffer, arg.data(), arg.length() + 1); // Include NUL
GRefPtr<GBytes> bytes = adoptGRef(g_string_free_to_bytes(buffer));
size_t size;
gconstpointer data = g_bytes_get_data(bytes.get(), &size);
int memfd = createSealedMemFdWithData(name, data, size);
if (memfd == -1)
g_error("Failed to write memfd");
return memfd;
}
static String effectiveApplicationId()
{
if (auto* app = g_application_get_default()) {
if (const char* appID = g_application_get_application_id(app))
return String::fromUTF8(appID);
}
const char* programName = g_get_prgname();
if (programName && g_application_id_is_valid(programName))
return String::fromUTF8(programName);
// There must be some id for xdg-desktop-portal to function.
// xdg-desktop-portal uses this id for permissions.
// This creates a somewhat reliable id based on the executable path
// which will avoid potentially gaining permissions from another app
// and won't flood xdg-desktop-portal with new ids.
if (auto executablePath = FileSystem::currentExecutablePath(); !executablePath.isNull()) {
GUniquePtr<char> digest(g_compute_checksum_for_data(G_CHECKSUM_SHA256, reinterpret_cast<const uint8_t*>(executablePath.data()), executablePath.length()));
return makeString("org.webkit.app-", digest.get());
}
// If it is not possible to obtain the executable path, generate
// a random identifier as a fallback.
auto uuid = WTF::UUID::createVersion4Weak();
return makeString("org.webkit.app-", uuid.toString());
}
static int createFlatpakInfo()
{
static NeverDestroyed<GUniquePtr<char>> data;
static size_t size;
if (!data.get()) {
GUniquePtr<GKeyFile> keyFile(g_key_file_new());
g_key_file_set_string(keyFile.get(), "Application", "name", effectiveApplicationId().utf8().data());
data->reset(g_key_file_to_data(keyFile.get(), &size, nullptr));
}
return createSealedMemFdWithData("flatpak-info", data->get(), size);
}
enum class BindFlags {
ReadOnly,
ReadWrite,
Device,
};
static void bindSymlinksRealPath(Vector<CString>& args, const String& path, const char* bindOption = "--ro-bind")
{
auto realPath = FileSystem::realPath(path);
if (path != realPath) {
CString rpath = realPath.utf8();
args.appendVector(Vector<CString>({ bindOption, rpath.data(), rpath.data() }));
}
}
static void bindIfExists(Vector<CString>& args, const char* path, BindFlags bindFlags = BindFlags::ReadOnly)
{
if (!path || path[0] == '\0')
return;
const char* bindType;
if (bindFlags == BindFlags::Device)
bindType = "--dev-bind-try";
else if (bindFlags == BindFlags::ReadOnly)
bindType = "--ro-bind-try";
else
bindType = "--bind-try";
// Canonicalize the source path, otherwise a symbolic link could
// point to a location outside of the namespace.
bindSymlinksRealPath(args, String::fromUTF8(path), bindType);
// As /etc is exposed wholesale, do not layer extraneous bind
// directives on top, which could fail in the presence of symbolic
// links.
if (!g_str_has_prefix(path, "/etc/"))
args.appendVector(Vector<CString>({ bindType, path, path }));
}
static const char* dbusProxyDirectory()
{
static GUniquePtr<char> path(g_build_filename(g_get_user_runtime_dir(), BASE_DIRECTORY, nullptr));
return path.get();
}
static void bindDBusSession(Vector<CString>& args, XDGDBusProxy& dbusProxy, bool allowPortals)
{
auto dbusSessionProxyPath = dbusProxy.dbusSessionProxy(BASE_DIRECTORY, allowPortals ? XDGDBusProxy::AllowPortals::Yes : XDGDBusProxy::AllowPortals::No);
if (!dbusSessionProxyPath)
return;
GUniquePtr<char> sandboxedSessionBusPath(g_build_filename(dbusProxyDirectory(), "bus", nullptr));
GUniquePtr<char> proxyAddress(g_strdup_printf("unix:path=%s", sandboxedSessionBusPath.get()));
args.appendVector(Vector<CString> {
"--ro-bind", *dbusSessionProxyPath, sandboxedSessionBusPath.get(),
"--setenv", "DBUS_SESSION_BUS_ADDRESS", proxyAddress.get()
});
}
#if PLATFORM(X11)
static void bindX11(Vector<CString>& args)
{
const char* display = g_getenv("DISPLAY");
if (display && display[0] == ':' && g_ascii_isdigit(const_cast<char*>(display)[1])) {
const char* displayNumber = &display[1];
const char* displayNumberEnd = displayNumber;
while (g_ascii_isdigit(*displayNumberEnd))
displayNumberEnd++;
GUniquePtr<char> displayString(g_strndup(displayNumber, displayNumberEnd - displayNumber));
GUniquePtr<char> x11File(g_strdup_printf("/tmp/.X11-unix/X%s", displayString.get()));
bindIfExists(args, x11File.get(), BindFlags::ReadWrite);
}
const char* xauth = g_getenv("XAUTHORITY");
if (!xauth) {
const char* homeDir = g_get_home_dir();
GUniquePtr<char> xauthFile(g_build_filename(homeDir, ".Xauthority", nullptr));
bindIfExists(args, xauthFile.get());
} else
bindIfExists(args, xauth);
}
#endif
#if PLATFORM(WAYLAND)
static void bindWayland(Vector<CString>& args)
{
const char* display = g_getenv("WAYLAND_DISPLAY");
if (!display)
display = "wayland-0";
const char* runtimeDir = g_get_user_runtime_dir();
GUniquePtr<char> waylandRuntimeFile(g_build_filename(runtimeDir, display, nullptr));
bindIfExists(args, waylandRuntimeFile.get(), BindFlags::ReadWrite);
}
#endif
static void bindPulse(Vector<CString>& args)
{
// FIXME: The server can be defined in config files we'd have to parse.
// They can also be set as X11 props but that is getting a bit ridiculous.
const char* pulseServer = g_getenv("PULSE_SERVER");
if (pulseServer) {
if (g_str_has_prefix(pulseServer, "unix:"))
bindIfExists(args, pulseServer + 5, BindFlags::ReadWrite);
// else it uses tcp
} else {
const char* runtimeDir = g_get_user_runtime_dir();
GUniquePtr<char> pulseRuntimeDir(g_build_filename(runtimeDir, "pulse", nullptr));
bindIfExists(args, pulseRuntimeDir.get(), BindFlags::ReadWrite);
}
const char* pulseConfig = g_getenv("PULSE_CLIENTCONFIG");
if (pulseConfig)
bindIfExists(args, pulseConfig);
const char* configDir = g_get_user_config_dir();
GUniquePtr<char> pulseConfigDir(g_build_filename(configDir, "pulse", nullptr));
bindIfExists(args, pulseConfigDir.get());
const char* homeDir = g_get_home_dir();
GUniquePtr<char> pulseHomeConfigDir(g_build_filename(homeDir, ".pulse", nullptr));
GUniquePtr<char> asoundHomeConfigDir(g_build_filename(homeDir, ".asoundrc", nullptr));
bindIfExists(args, pulseHomeConfigDir.get());
bindIfExists(args, asoundHomeConfigDir.get());
// This is the ultimate fallback to raw ALSA
bindIfExists(args, "/dev/snd", BindFlags::Device);
}
static void bindSndio(Vector<CString>& args)
{
bindIfExists(args, "/tmp/sndio", BindFlags::ReadWrite);
GUniquePtr<char> sndioUidDir(g_strdup_printf("/tmp/sndio-%d", getuid()));
bindIfExists(args, sndioUidDir.get(), BindFlags::ReadWrite);
const char* homeDir = g_get_home_dir();
GUniquePtr<char> sndioHomeDir(g_build_filename(homeDir, ".sndio", nullptr));
bindIfExists(args, sndioHomeDir.get(), BindFlags::ReadWrite);
}
static void bindFonts(Vector<CString>& args)
{
const char* configDir = g_get_user_config_dir();
const char* homeDir = g_get_home_dir();
const char* dataDir = g_get_user_data_dir();
const char* cacheDir = g_get_user_cache_dir();
const char* const * dataDirs = g_get_system_data_dirs();
// Configs can include custom dirs but then we have to parse them...
GUniquePtr<char> fontConfig(g_build_filename(configDir, "fontconfig", nullptr));
GUniquePtr<char> fontConfigHome(g_build_filename(homeDir, ".fontconfig", nullptr));
GUniquePtr<char> fontCache(g_build_filename(cacheDir, "fontconfig", nullptr));
GUniquePtr<char> fontHomeConfig(g_build_filename(homeDir, ".fonts.conf", nullptr));
GUniquePtr<char> fontHomeConfigDir(g_build_filename(configDir, ".fonts.conf.d", nullptr));
GUniquePtr<char> fontData(g_build_filename(dataDir, "fonts", nullptr));
GUniquePtr<char> fontHomeData(g_build_filename(homeDir, ".fonts", nullptr));
bindIfExists(args, fontConfig.get());
bindIfExists(args, fontConfigHome.get());
bindIfExists(args, fontCache.get(), BindFlags::ReadWrite);
bindIfExists(args, fontHomeConfig.get());
bindIfExists(args, fontHomeConfigDir.get());
bindIfExists(args, fontData.get());
bindIfExists(args, fontHomeData.get());
for (auto* dataDir = dataDirs; dataDir && *dataDir; dataDir++) {
GUniquePtr<char> fontDataDir(g_build_filename(*dataDir, "fonts", nullptr));
bindIfExists(args, fontDataDir.get());
}
bindIfExists(args, "/var/cache/fontconfig"); // Used by Debian.
}
#if PLATFORM(GTK)
static void bindGtkData(Vector<CString>& args)
{
const char* configDir = g_get_user_config_dir();
const char* dataDir = g_get_user_data_dir();
const char* homeDir = g_get_home_dir();
GUniquePtr<char> gtkConfig(g_build_filename(configDir, "gtk-3.0", nullptr));
GUniquePtr<char> themeData(g_build_filename(dataDir, "themes", nullptr));
GUniquePtr<char> themeHomeData(g_build_filename(homeDir, ".themes", nullptr));
GUniquePtr<char> iconHomeData(g_build_filename(homeDir, ".icons", nullptr));
bindIfExists(args, gtkConfig.get());
bindIfExists(args, themeData.get());
bindIfExists(args, themeHomeData.get());
bindIfExists(args, iconHomeData.get());
}
#endif
#if ENABLE(ACCESSIBILITY)
static void bindA11y(Vector<CString>& args, XDGDBusProxy& dbusProxy)
{
GUniquePtr<char> sandboxedAccessibilityBusPath(g_build_filename(dbusProxyDirectory(), "at-spi-bus", nullptr));
auto accessibilityProxyPath = dbusProxy.accessibilityProxy(BASE_DIRECTORY, sandboxedAccessibilityBusPath.get());
if (!accessibilityProxyPath)
return;
GUniquePtr<char> proxyAddress(g_strdup_printf("unix:path=%s", sandboxedAccessibilityBusPath.get()));
args.appendVector(Vector<CString> {
"--ro-bind", *accessibilityProxyPath, sandboxedAccessibilityBusPath.get(),
"--setenv", "AT_SPI_BUS_ADDRESS", proxyAddress.get()
});
}
#endif
static bool bindPathVar(Vector<CString>& args, const char* varname)
{
const char* pathValue = g_getenv(varname);
if (!pathValue)
return false;
GUniquePtr<char*> splitPaths(g_strsplit(pathValue, ":", -1));
for (size_t i = 0; splitPaths.get()[i]; ++i)
bindIfExists(args, splitPaths.get()[i]);
return true;
}
static const char* environmentVariableValue(const char* name, const char* defaultValue)
{
const char* value = g_getenv(name);
return value ? value : defaultValue;
}
static void bindGStreamerData(Vector<CString>& args)
{
if (!bindPathVar(args, "GST_PLUGIN_PATH_1_0"))
bindPathVar(args, "GST_PLUGIN_PATH");
if (!bindPathVar(args, "GST_PLUGIN_SYSTEM_PATH_1_0"))
bindPathVar(args, "GST_PLUGIN_SYSTEM_PATH");
// The plugin scanner needs write permissions in the parent directory of GST_REGISTRY in order to
// write the registry file.
if (const char* registryPath = g_getenv("GST_REGISTRY")) {
auto registryDir = FileSystem::parentPath(FileSystem::stringFromFileSystemRepresentation(registryPath));
bindIfExists(args, registryDir.utf8().data(), BindFlags::ReadWrite);
}
bindPathVar(args, "GST_PRESET_PATH");
// GST_DEBUG_FILE points to an absolute file path, so we need write permissions for its parent directory.
if (const char* debugFilePath = g_getenv("GST_DEBUG_FILE")) {
auto parentDir = FileSystem::parentPath(FileSystem::stringFromFileSystemRepresentation(debugFilePath));
bindIfExists(args, parentDir.utf8().data(), BindFlags::ReadWrite);
}
// GST_DEBUG_DUMP_DOT_DIR might not exist when the application starts, so we need write
// permissions for its parent directory.
if (const char* dotDir = g_getenv("GST_DEBUG_DUMP_DOT_DIR")) {
auto parentDir = FileSystem::parentPath(FileSystem::stringFromFileSystemRepresentation(dotDir));
bindIfExists(args, parentDir.utf8().data(), BindFlags::ReadWrite);
}
// /usr/lib is already added so this is only requried for other dirs
const char* scannerPath = environmentVariableValue("GST_PLUGIN_SCANNER", "/usr/libexec/gstreamer-1.0/gst-plugin-scanner");
const char* installPluginsHelperPath = environmentVariableValue("GST_INSTALL_PLUGINS_HELPER", "/usr/libexec/gstreamer-1.0/gst-install-plugins-helper");
const char* ptpHelperPath = environmentVariableValue("GST_PTP_HELPER", "/usr/libexec/gstreamer-1.0/gst-ptp-helper");
bindIfExists(args, scannerPath);
bindIfExists(args, installPluginsHelperPath);
bindIfExists(args, ptpHelperPath);
}
static void bindOpenGL(Vector<CString>& args)
{
args.appendVector(Vector<CString>({
"--dev-bind-try", "/dev/dri", "/dev/dri",
// Mali
"--dev-bind-try", "/dev/mali", "/dev/mali",
"--dev-bind-try", "/dev/mali0", "/dev/mali0",
"--dev-bind-try", "/dev/umplock", "/dev/umplock",
// Nvidia
"--dev-bind-try", "/dev/nvidiactl", "/dev/nvidiactl",
"--dev-bind-try", "/dev/nvidia0", "/dev/nvidia0",
"--dev-bind-try", "/dev/nvidia", "/dev/nvidia",
// Adreno
"--dev-bind-try", "/dev/kgsl-3d0", "/dev/kgsl-3d0",
"--dev-bind-try", "/dev/ion", "/dev/ion",
#if PLATFORM(WPE)
"--dev-bind-try", "/dev/fb0", "/dev/fb0",
"--dev-bind-try", "/dev/fb1", "/dev/fb1",
#endif
}));
}
static void bindV4l(Vector<CString>& args)
{
args.appendVector(Vector<CString>({
"--dev-bind-try", "/dev/v4l", "/dev/v4l",
// Not pretty but a stop-gap for pipewire anyway.
"--dev-bind-try", "/dev/video0", "/dev/video0",
"--dev-bind-try", "/dev/video1", "/dev/video1",
"--dev-bind-try", "/dev/video2", "/dev/video2",
"--dev-bind-try", "/dev/media0", "/dev/media0",
}));
}
static bool enableDebugPermissions()
{
static int enabled = -1;
if (enabled == -1) {
const char* env = g_getenv("WEBKIT_ENABLE_DEBUG_PERMISSIONS_IN_SANDBOX");
enabled = !g_strcmp0(env, "1");
}
return enabled;
}
// Translate a libseccomp error code into an error message. libseccomp
// mostly returns negative errno values such as -ENOMEM, but some
// standard errno values are used for non-standard purposes where their
// strerror() would be misleading.
static const char* seccompStrerror(int negativeErrno)
{
RELEASE_ASSERT_WITH_MESSAGE(negativeErrno < 0, "Non-negative error value from libseccomp?");
RELEASE_ASSERT_WITH_MESSAGE(negativeErrno > INT_MIN, "Out of range error value from libseccomp?");
switch (negativeErrno) {
case -EDOM:
return "Architecture-specific failure";
case -EFAULT:
return "Internal libseccomp failure (unknown syscall?)";
case -ECANCELED:
return "System failure beyond the control of libseccomp";
}
// e.g. -ENOMEM: the result of strerror() is good enough
return g_strerror(-negativeErrno);
}
static int setupSeccomp()
{
// NOTE: This is shared code (flatpak-run.c - LGPLv2.1+)
// There are today a number of different Linux container
// implementations. That will likely continue for long into the
// future. But we can still try to share code, and it's important
// to do so because it affects what library and application writers
// can do, and we should support code portability between different
// container tools.
//
// This syscall block list is copied from linux-user-chroot, which was in turn
// clearly influenced by the Sandstorm.io block list.
//
// If you make any changes here, I suggest sending the changes along
// to other sandbox maintainers. Using the libseccomp list is also
// an appropriate venue:
// https://groups.google.com/forum/#!topic/libseccomp
//
// A non-exhaustive list of links to container tooling that might
// want to share this block list:
//
// https://github.com/sandstorm-io/sandstorm
// in src/sandstorm/supervisor.c++
// http://cgit.freedesktop.org/xdg-app/xdg-app/
// in common/flatpak-run.c
// https://git.gnome.org/browse/linux-user-chroot
// in src/setup-seccomp.c
//
// Other useful resources:
// https://github.com/systemd/systemd/blob/HEAD/src/shared/seccomp-util.c
// https://github.com/moby/moby/blob/HEAD/profiles/seccomp/default.json
#if defined(__s390__) || defined(__s390x__) || defined(__CRIS__)
// Architectures with CONFIG_CLONE_BACKWARDS2: the child stack
// and flags arguments are reversed so the flags come second.
struct scmp_arg_cmp cloneArg = SCMP_A1(SCMP_CMP_MASKED_EQ, CLONE_NEWUSER, CLONE_NEWUSER);
#else
// Normally the flags come first.
struct scmp_arg_cmp cloneArg = SCMP_A0(SCMP_CMP_MASKED_EQ, CLONE_NEWUSER, CLONE_NEWUSER);
#endif
struct scmp_arg_cmp tiocstiArg = SCMP_A1(SCMP_CMP_MASKED_EQ, 0xFFFFFFFFu, TIOCSTI);
struct scmp_arg_cmp tioclinuxArg = SCMP_A1(SCMP_CMP_MASKED_EQ, 0xFFFFFFFFu, TIOCLINUX);
struct {
int scall;
int errnum;
struct scmp_arg_cmp* arg;
} syscallBlockList[] = {
// Block dmesg
{ SCMP_SYS(syslog), EPERM, nullptr },
// Useless old syscall.
{ SCMP_SYS(uselib), EPERM, nullptr },
// Don't allow disabling accounting.
{ SCMP_SYS(acct), EPERM, nullptr },
// 16-bit code is unnecessary in the sandbox, and modify_ldt is a
// historic source of interesting information leaks.
{ SCMP_SYS(modify_ldt), EPERM, nullptr },
// Don't allow reading current quota use.
{ SCMP_SYS(quotactl), EPERM, nullptr },
// Don't allow access to the kernel keyring.
{ SCMP_SYS(add_key), EPERM, nullptr },
{ SCMP_SYS(keyctl), EPERM, nullptr },
{ SCMP_SYS(request_key), EPERM, nullptr },
// Scary VM/NUMA ops
{ SCMP_SYS(move_pages), EPERM, nullptr },
{ SCMP_SYS(mbind), EPERM, nullptr },
{ SCMP_SYS(get_mempolicy), EPERM, nullptr },
{ SCMP_SYS(set_mempolicy), EPERM, nullptr },
{ SCMP_SYS(migrate_pages), EPERM, nullptr },
// Don't allow subnamespace setups:
{ SCMP_SYS(unshare), EPERM, nullptr },
{ SCMP_SYS(setns), EPERM, nullptr },
{ SCMP_SYS(mount), EPERM, nullptr },
{ SCMP_SYS(umount), EPERM, nullptr },
{ SCMP_SYS(umount2), EPERM, nullptr },
{ SCMP_SYS(pivot_root), EPERM, nullptr },
{ SCMP_SYS(chroot), EPERM, nullptr },
{ SCMP_SYS(clone), EPERM, &cloneArg },
// Don't allow faking input to the controlling tty (CVE-2017-5226)
{ SCMP_SYS(ioctl), EPERM, &tiocstiArg },
// In the unlikely event that the controlling tty is a Linux virtual
// console (/dev/tty2 or similar), copy/paste operations have an effect
// similar to TIOCSTI (CVE-2023-28100).
{ SCMP_SYS(ioctl), EPERM, &tioclinuxArg },
// seccomp can't look into clone3()'s struct clone_args to check whether
// the flags are OK, so we have no choice but to block clone3().
// Return ENOSYS so user-space will fall back to clone().
// (GHSA-67h7-w3jq-vh4q; see also https://github.com/moby/moby/commit/9f6b562d)
{ SCMP_SYS(clone3), ENOSYS, nullptr },
// New mount manipulation APIs can also change our VFS. There's no
// legitimate reason to do these in the sandbox, so block all of them
// rather than thinking about which ones might be dangerous.
// (GHSA-67h7-w3jq-vh4q)
{ SCMP_SYS(open_tree), ENOSYS, nullptr },
{ SCMP_SYS(move_mount), ENOSYS, nullptr },
{ SCMP_SYS(fsopen), ENOSYS, nullptr },
{ SCMP_SYS(fsconfig), ENOSYS, nullptr },
{ SCMP_SYS(fsmount), ENOSYS, nullptr },
{ SCMP_SYS(fspick), ENOSYS, nullptr },
{ SCMP_SYS(mount_setattr), ENOSYS, nullptr },
};
struct {
int scall;
int errnum;
struct scmp_arg_cmp* arg;
} nonDebugSyscallBlockList[] = {
// Profiling operations; we expect these to be done by tools from outside
// the sandbox. In particular perf has been the source of many CVEs.
{ SCMP_SYS(perf_event_open), EPERM, nullptr },
// Don't allow you to switch to bsd emulation or whatnot.
{ SCMP_SYS(personality), EPERM, nullptr },
{ SCMP_SYS(ptrace), EPERM, nullptr }
};
scmp_filter_ctx seccomp = seccomp_init(SCMP_ACT_ALLOW);
if (!seccomp)
g_error("Failed to init seccomp");
for (auto& rule : syscallBlockList) {
int r;
if (rule.arg)
r = seccomp_rule_add(seccomp, SCMP_ACT_ERRNO(rule.errnum), rule.scall, 1, *rule.arg);
else
r = seccomp_rule_add(seccomp, SCMP_ACT_ERRNO(rule.errnum), rule.scall, 0);
// EFAULT means "internal libseccomp error", but in practice we get
// this for syscall numbers added via Syscalls.h (flatpak-syscalls-private.h)
// when trying to filter them on a non-native architecture, because
// libseccomp cannot map the syscall number to a name and back to a
// number for the non-native architecture.
if (r == -EFAULT)
g_info("Unable to block syscall %d: syscall not known to libseccomp?", rule.scall);
else if (r < 0)
g_error("Failed to block syscall %d: %s", rule.scall, seccompStrerror(r));
}
if (!enableDebugPermissions()) {
for (auto& rule : nonDebugSyscallBlockList) {
int r;
if (rule.arg)
r = seccomp_rule_add(seccomp, SCMP_ACT_ERRNO(rule.errnum), rule.scall, 1, *rule.arg);
else
r = seccomp_rule_add(seccomp, SCMP_ACT_ERRNO(rule.errnum), rule.scall, 0);
if (r == -EFAULT)
g_info("Unable to block syscall %d: syscall not known to libseccomp?", rule.scall);
else if (r < 0)
g_error("Failed to block syscall %d: %s", rule.scall, seccompStrerror(r));
}
}
int tmpfd = memfd_create("seccomp-bpf", 0);
if (tmpfd == -1)
g_error("Failed to create memfd: %s", g_strerror(errno));
if (int r = seccomp_export_bpf(seccomp, tmpfd))
g_error("Failed to export seccomp bpf: %s", seccompStrerror(r));
if (lseek(tmpfd, 0, SEEK_SET) < 0)
g_error("lseek failed: %s", g_strerror(errno));
seccomp_release(seccomp);
return tmpfd;
}
static bool shouldUnshareNetwork(ProcessLauncher::ProcessType processType, char** argv)
{
// gdbserver requires network access for remote debugging.
if (enableDebugPermissions() && g_str_has_suffix(argv[0], "gdbserver"))
return false;
// xdg-dbus-proxy needs access to host abstract sockets to connect to the a11y bus. Secure
// host services must not use abstract sockets.
if (processType == ProcessLauncher::ProcessType::DBusProxy)
return false;
#if PLATFORM(X11)
// Also, the web process needs access to host networking if the X server is running over TCP or
// on a different host's Unix socket; this is likely the case if the first character of DISPLAY
// is not a colon.
if (processType == ProcessLauncher::ProcessType::Web && PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::X11) {
const char* display = g_getenv("DISPLAY");
if (display && display[0] != ':')
return false;
}
#endif
// Otherwise, only the network process should have network access. If we are the network
// process, then we are not sandboxed and have already bailed out before this point.
return true;
}
static std::optional<CString> directoryContainingDBusSocket(const char* dbusAddress)
{
if (!dbusAddress || !g_str_has_prefix(dbusAddress, "unix:"))
return std::nullopt;
if (const char* pathStart = strstr(dbusAddress, "path=")) {
pathStart += strlen("path=");
const char* pathEnd = pathStart;
while (*pathEnd && *pathEnd != ',')
pathEnd++;
CString path(pathStart, pathEnd - pathStart);
GRefPtr<GFile> file = adoptGRef(g_file_new_for_path(path.data()));
GRefPtr<GFile> parent = adoptGRef(g_file_get_parent(file.get()));
if (!parent)
return std::nullopt;
return { g_file_peek_path(parent.get()) };
}
return std::nullopt;
}
static void addExtraPaths(const HashMap<CString, SandboxPermission>& paths, Vector<CString>& args)
{
for (const auto& pathAndPermission : paths) {
args.appendVector(Vector<CString>({
pathAndPermission.value == SandboxPermission::ReadOnly ? "--ro-bind-try": "--bind-try",
pathAndPermission.key, pathAndPermission.key
}));
}
}
GRefPtr<GSubprocess> bubblewrapSpawn(GSubprocessLauncher* launcher, const ProcessLauncher::LaunchOptions& launchOptions, char** argv, GError **error)
{
ASSERT(launcher);
// For now we are just considering the network process trusted as it
// requires a lot of access but doesn't execute arbitrary code like
// the WebProcess where our focus lies.
if (launchOptions.processType == ProcessLauncher::ProcessType::Network)
return adoptGRef(g_subprocess_launcher_spawnv(launcher, argv, error));
const char* runDir = g_get_user_runtime_dir();
Vector<CString> sandboxArgs = {
"--die-with-parent",
"--unshare-uts",
// We assume /etc has safe permissions.
// At a later point we can start masking privacy-concerning files.
"--ro-bind", "/etc", "/etc",
"--dev", "/dev",
"--proc", "/proc",
"--tmpfs", "/tmp",
"--unsetenv", "TMPDIR",
"--dir", runDir,
"--setenv", "XDG_RUNTIME_DIR", runDir,
"--symlink", "../run", "/var/run",
"--symlink", "../tmp", "/var/tmp",
"--ro-bind", "/sys/block", "/sys/block",
"--ro-bind", "/sys/bus", "/sys/bus",
"--ro-bind", "/sys/class", "/sys/class",
"--ro-bind", "/sys/dev", "/sys/dev",
"--ro-bind", "/sys/devices", "/sys/devices",
"--ro-bind-try", "/usr/share", "/usr/share",
"--ro-bind-try", "/usr/local/share", "/usr/local/share",
"--ro-bind-try", DATADIR, DATADIR,
// We only grant access to the libdirs webkit is built with and
// guess system libdirs. This will always have some edge cases.
"--ro-bind-try", "/lib", "/lib",
"--ro-bind-try", "/usr/lib", "/usr/lib",
"--ro-bind-try", "/usr/local/lib", "/usr/local/lib",
"--ro-bind-try", LIBDIR, LIBDIR,
#if CPU(ADDRESS64)
"--ro-bind-try", "/lib64", "/lib64",
"--ro-bind-try", "/usr/lib64", "/usr/lib64",
"--ro-bind-try", "/usr/local/lib64", "/usr/local/lib64",
#else
"--ro-bind-try", "/lib32", "/lib32",
"--ro-bind-try", "/usr/lib32", "/usr/lib32",
"--ro-bind-try", "/usr/local/lib32", "/usr/local/lib32",
#endif
"--ro-bind-try", PKGLIBEXECDIR, PKGLIBEXECDIR,
};
if (enableDebugPermissions()) {
const char* dataDir = g_get_user_data_dir();
GUniquePtr<char> rrOutputDir(g_build_filename(dataDir, "rr", nullptr));
sandboxArgs.appendVector(Vector<CString>({
// Other binaries are helpful for debugging such as gdbserver.
"--ro-bind-try", "/bin", "/bin",
"--ro-bind-try", "/usr/bin", "/usr/bin",
// rr writes to this directory.
"--bind-try", rrOutputDir.get(), rrOutputDir.get(),
}));
} else {
sandboxArgs.appendVector(Vector<CString>({
// In some configurations cross pid namespace debugging has issues.
"--unshare-pid",
}));
}
addExtraPaths(launchOptions.extraSandboxPaths, sandboxArgs);
if (launchOptions.processType == ProcessLauncher::ProcessType::DBusProxy) {
sandboxArgs.appendVector(Vector<CString>({
"--ro-bind", DBUS_PROXY_EXECUTABLE, DBUS_PROXY_EXECUTABLE,
"--bind", dbusProxyDirectory(), dbusProxyDirectory(),
}));
// xdg-dbus-proxy is trusted, so it's OK to mount the directories that contain the session
// bus and a11y bus sockets wherever they may be. xdg-dbus-proxy is sandboxed only because
// we have to mount .flatpak-info in its mount namespace so that portals may use it as a
// trusted way to get the app ID of the process that is using it.
if (auto sessionBusDirectory = directoryContainingDBusSocket(g_getenv("DBUS_SESSION_BUS_ADDRESS"))) {
sandboxArgs.appendVector(Vector<CString>({
"--bind", *sessionBusDirectory, *sessionBusDirectory,
}));
}
#if ENABLE(ACCESSIBILITY)
if (auto a11yBusDirectory = directoryContainingDBusSocket(PlatformDisplay::sharedDisplay().accessibilityBusAddress().utf8().data())) {
sandboxArgs.appendVector(Vector<CString>({
"--bind", *a11yBusDirectory, *a11yBusDirectory,
}));
}
#endif
}
if (shouldUnshareNetwork(launchOptions.processType, argv))
sandboxArgs.append("--unshare-net");
// We would have to parse ld config files for more info.
bindPathVar(sandboxArgs, "LD_LIBRARY_PATH");
const char* libraryPath = g_getenv("LD_LIBRARY_PATH");
if (libraryPath && libraryPath[0]) {
// On distros using a suid bwrap it drops this env var
// so we have to pass it through to the children.
sandboxArgs.appendVector(Vector<CString>({
"--setenv", "LD_LIBRARY_PATH", libraryPath,
}));
}
bindSymlinksRealPath(sandboxArgs, "/etc/resolv.conf"_s);
bindSymlinksRealPath(sandboxArgs, "/etc/localtime"_s);
// xdg-desktop-portal defaults to assuming you are host application with
// full permissions unless it can identify you as a snap or flatpak.
// The easiest method is for us to pretend to be a flatpak and if that
// fails just blocking portals entirely as it just becomes a sandbox escape.
int flatpakInfoFd = createFlatpakInfo();
if (flatpakInfoFd != -1) {
g_subprocess_launcher_take_fd(launcher, flatpakInfoFd, flatpakInfoFd);
GUniquePtr<char> flatpakInfoFdStr(g_strdup_printf("%d", flatpakInfoFd));
sandboxArgs.appendVector(Vector<CString>({
"--ro-bind-data", flatpakInfoFdStr.get(), "/.flatpak-info"
}));
}
if (launchOptions.processType == ProcessLauncher::ProcessType::Web) {
#if PLATFORM(WAYLAND)
if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland) {
bindWayland(sandboxArgs);
sandboxArgs.append("--unshare-ipc");
}
#endif
#if PLATFORM(X11)
if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::X11)
bindX11(sandboxArgs);
#endif
Vector<String> extraPaths = { "applicationCacheDirectory"_s, "mediaKeysDirectory"_s, "waylandSocket"_s };
for (const auto& path : extraPaths) {
String extraPath = launchOptions.extraInitializationData.get(path);
if (!extraPath.isEmpty())
sandboxArgs.appendVector(Vector<CString>({ "--bind-try", extraPath.utf8(), extraPath.utf8() }));
}
static std::unique_ptr<XDGDBusProxy> dbusProxy = makeUnique<XDGDBusProxy>();
if (dbusProxy)
bindDBusSession(sandboxArgs, *dbusProxy, flatpakInfoFd != -1);
// FIXME: We should move to Pipewire as soon as viable, Pulse doesn't restrict clients atm.
bindPulse(sandboxArgs);
bindSndio(sandboxArgs);
bindFonts(sandboxArgs);
bindGStreamerData(sandboxArgs);
bindOpenGL(sandboxArgs);
// FIXME: This is also fixed by Pipewire once in use.
bindV4l(sandboxArgs);
#if ENABLE(ACCESSIBILITY)
if (dbusProxy)
bindA11y(sandboxArgs, *dbusProxy);
#endif
#if PLATFORM(GTK)
bindGtkData(sandboxArgs);
#endif
if (dbusProxy && !dbusProxy->launch())
dbusProxy = nullptr;
} else {
// Only X11 users need this for XShm which is only the Web process.
sandboxArgs.append("--unshare-ipc");
}
#if ENABLE(DEVELOPER_MODE)
const char* execDirectory = g_getenv("WEBKIT_EXEC_PATH");
if (execDirectory) {
String parentDir = FileSystem::parentPath(FileSystem::stringFromFileSystemRepresentation(execDirectory));
bindIfExists(sandboxArgs, parentDir.utf8().data());
}
CString executablePath = FileSystem::currentExecutablePath();
if (!executablePath.isNull()) {
// Our executable is `/foo/bar/bin/Process`, we want `/foo/bar` as a usable prefix
String parentDir = FileSystem::parentPath(FileSystem::parentPath(FileSystem::stringFromFileSystemRepresentation(executablePath.data())));
bindIfExists(sandboxArgs, parentDir.utf8().data());
}
#endif
int seccompFd = setupSeccomp();
GUniquePtr<char> fdStr(g_strdup_printf("%d", seccompFd));
g_subprocess_launcher_take_fd(launcher, seccompFd, seccompFd);
sandboxArgs.appendVector(Vector<CString>({ "--seccomp", fdStr.get() }));
int bwrapFd = argumentsToFileDescriptor(sandboxArgs, "bwrap");
GUniquePtr<char> bwrapFdStr(g_strdup_printf("%d", bwrapFd));
g_subprocess_launcher_take_fd(launcher, bwrapFd, bwrapFd);
Vector<CString> bwrapArgs = {
BWRAP_EXECUTABLE,
"--args",
bwrapFdStr.get(),
"--",
};
char** newArgv = g_newa(char*, g_strv_length(argv) + bwrapArgs.size() + 1);
size_t i = 0;
for (auto& arg : bwrapArgs)
newArgv[i++] = const_cast<char*>(arg.data());
for (size_t x = 0; argv[x]; x++)
newArgv[i++] = argv[x];
newArgv[i++] = nullptr;
return adoptGRef(g_subprocess_launcher_spawnv(launcher, newArgv, error));
}
};
#endif // ENABLE(BUBBLEWRAP_SANDBOX)
|