1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586
|
/*
* Copyright (C) 2015-2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "PropertyCondition.h"
#include "GetterSetter.h"
#include "JSCInlines.h"
#include "TrackedReferences.h"
namespace JSC {
namespace PropertyConditionInternal {
static constexpr bool verbose = false;
}
void PropertyCondition::dumpInContext(PrintStream& out, DumpContext* context) const
{
if (!*this) {
out.print("<invalid>");
return;
}
switch (m_header.type()) {
case Presence:
case Replacement:
out.print(m_header.type(), " of ", m_header.pointer(), " at ", offset(), " with attributes ", attributes());
return;
case Absence:
case AbsenceOfSetEffect:
case AbsenceOfIndexedProperties:
out.print(m_header.type(), " of ", m_header.pointer(), " with prototype ", inContext(JSValue(prototype()), context));
return;
case Equivalence:
out.print(m_header.type(), " of ", m_header.pointer(), " with ", inContext(requiredValue(), context));
return;
case HasStaticProperty:
out.print(m_header.type(), " of ", m_header.pointer());
return;
case HasPrototype:
out.print(m_header.type(), " with prototype ", inContext(JSValue(prototype()), context));
return;
}
RELEASE_ASSERT_NOT_REACHED();
}
void PropertyCondition::dump(PrintStream& out) const
{
dumpInContext(out, nullptr);
}
bool PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint(
Concurrency concurrency, Structure* structure, JSObject* base) const
{
if (PropertyConditionInternal::verbose) {
dataLog(
"Determining validity of ", *this, " with structure ", pointerDump(structure), " and base ",
JSValue(base), " assuming impure property watchpoints are set.\n");
}
if (!*this) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because unset.\n");
return false;
}
switch (m_header.type()) {
case Presence:
case Replacement:
case Absence:
case AbsenceOfSetEffect:
case AbsenceOfIndexedProperties:
case Equivalence:
case HasStaticProperty:
if (!structure->propertyAccessesAreCacheable()) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because property accesses are not cacheable.\n");
return false;
}
break;
case HasPrototype:
if (!structure->prototypeQueriesAreCacheable()) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because prototype queries are not cacheable.\n");
return false;
}
break;
}
switch (m_header.type()) {
case Presence:
case Replacement: {
unsigned currentAttributes;
PropertyOffset currentOffset = structure->get(structure->vm(), concurrency, uid(), currentAttributes);
if (currentOffset != offset() || currentAttributes != attributes()) {
if (PropertyConditionInternal::verbose) {
dataLogLn(
"Invalid because we need offset, attributes to be ", offset(), ", ", attributes(),
" but they are ", currentOffset, ", ", currentAttributes);
}
return false;
}
if (m_header.type() == Replacement) {
auto* watchpointSet = structure->propertyReplacementWatchpointSet(currentOffset);
if (!watchpointSet || watchpointSet->isStillValid()) {
dataLogLnIf(PropertyConditionInternal::verbose, "Invalid because the replacement watchpoint needs to be fired but is not");
return false;
}
}
return true;
}
case Absence: {
if (structure->isDictionary()) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because it's a dictionary.\n");
return false;
}
if (structure->hasPolyProto()) {
// FIXME: I think this is too conservative. We can probably prove this if
// we have the base. Anyways, we should make this work when integrating
// OPC and poly proto.
// https://bugs.webkit.org/show_bug.cgi?id=177339
return false;
}
PropertyOffset currentOffset = structure->get(structure->vm(), concurrency, uid());
if (currentOffset != invalidOffset) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because the property exists at offset: ", currentOffset, "\n");
return false;
}
if (structure->storedPrototypeObject() != prototype()) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because the prototype is ", structure->storedPrototype(), " even though "
"it should have been ", JSValue(prototype()), "\n");
}
return false;
}
return true;
}
case AbsenceOfSetEffect: {
if (structure->isDictionary()) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because it's a dictionary.\n");
return false;
}
if (structure->typeInfo().overridesPut() && JSObject::mightBeSpecialProperty(structure->vm(), structure->typeInfo().type(), uid())) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because its put() override may treat ", uid(), " property as special non-structure one.\n");
return false;
}
unsigned currentAttributes;
PropertyOffset currentOffset = structure->get(structure->vm(), concurrency, uid(), currentAttributes);
if (currentOffset != invalidOffset) {
if (currentAttributes & (PropertyAttribute::ReadOnly | PropertyAttribute::Accessor | PropertyAttribute::CustomAccessorOrValue)) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because we expected not to have a setter, but we have one at offset ",
currentOffset, " with attributes ", currentAttributes, "\n");
}
return false;
}
} else if (structure->hasNonReifiedStaticProperties()) {
if (auto entry = structure->findPropertyHashEntry(uid())) {
if (entry->value->attributes() & PropertyAttribute::ReadOnlyOrAccessorOrCustomAccessorOrValue) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because we expected not to have a setter, but we have one in non-reified static property table: ", uid(), ".\n");
return false;
}
}
}
if (structure->hasPolyProto()) {
// FIXME: I think this is too conservative. We can probably prove this if
// we have the base. Anyways, we should make this work when integrating
// OPC and poly proto.
// https://bugs.webkit.org/show_bug.cgi?id=177339
return false;
}
if (structure->storedPrototypeObject() != prototype()) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because the prototype is ", structure->storedPrototype(), " even though "
"it should have been ", JSValue(prototype()), "\n");
}
return false;
}
return true;
}
case AbsenceOfIndexedProperties: {
if (structure->hasPolyProto()) {
// FIXME: I think this is too conservative. We can probably prove this if
// we have the base. Anyways, we should make this work when integrating
// OPC and poly proto.
// https://bugs.webkit.org/show_bug.cgi?id=177339
return false;
}
if (hasIndexedProperties(structure->indexingType())) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because the indexed properties exist: ", structure->indexingType(), "\n");
return false;
}
if (structure->mayInterceptIndexedAccesses() || structure->typeInfo().interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero()) {
if (PropertyConditionInternal::verbose)
dataLog("Invalid because structure intercepts index access.\n");
return false;
}
if (structure->storedPrototypeObject() != prototype()) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because the prototype is ", structure->storedPrototype(), " even though "
"it should have been ", JSValue(prototype()), "\n");
}
return false;
}
return true;
}
case HasPrototype: {
if (structure->hasPolyProto()) {
// FIXME: I think this is too conservative. We can probably prove this if
// we have the base. Anyways, we should make this work when integrating
// OPC and poly proto.
// https://bugs.webkit.org/show_bug.cgi?id=177339
return false;
}
if (structure->storedPrototypeObject() != prototype()) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because the prototype is ", structure->storedPrototype(), " even though "
"it should have been ", JSValue(prototype()), "\n");
}
return false;
}
return true;
}
case Equivalence: {
Locker<JSCellLock> cellLocker { NoLockingNecessary };
if (concurrency != Concurrency::MainThread && base)
cellLocker = Locker { base->cellLock() };
if (!base || base->structure() != structure) {
// Conservatively return false, since we cannot verify this one without having the
// object.
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because we don't have a base or the base has the wrong structure: ",
RawPointer(base), "\n");
}
return false;
}
// FIXME: This is somewhat racy, and maybe more risky than we want.
// https://bugs.webkit.org/show_bug.cgi?id=134641
PropertyOffset currentOffset = structure->get(structure->vm(), concurrency, uid());
if (currentOffset == invalidOffset) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because the base no long appears to have ", uid(), " on its structure: ",
RawPointer(base), "\n");
}
return false;
}
JSValue currentValue = base->getDirect(cellLocker, concurrency, structure, currentOffset);
if (currentValue != requiredValue() || !currentValue) {
if (PropertyConditionInternal::verbose) {
dataLog(
"Invalid because the value is ", currentValue, " but we require ", requiredValue(),
"\n");
}
return false;
}
return true;
}
case HasStaticProperty: {
if (isValidOffset(structure->get(structure->vm(), concurrency, uid())))
return false;
if (structure->staticPropertiesReified())
return false;
return !!structure->findPropertyHashEntry(uid());
}
}
RELEASE_ASSERT_NOT_REACHED();
}
IGNORE_RETURN_TYPE_WARNINGS_BEGIN
static ALWAYS_INLINE Concurrency watchabilityToConcurrency(PropertyCondition::WatchabilityEffort effort)
{
switch (effort) {
case PropertyCondition::WatchabilityEffort::EnsureWatchability:
return Concurrency::MainThread;
case PropertyCondition::WatchabilityEffort::MakeNoChanges:
return Concurrency::ConcurrentThread;
}
}
IGNORE_RETURN_TYPE_WARNINGS_END
bool PropertyCondition::validityRequiresImpurePropertyWatchpoint(Structure* structure) const
{
if (!*this)
return false;
switch (m_header.type()) {
case Presence:
case Replacement:
case Absence:
case Equivalence:
case HasStaticProperty:
return structure->needImpurePropertyWatchpoint();
case AbsenceOfSetEffect:
case AbsenceOfIndexedProperties:
case HasPrototype:
return false;
}
RELEASE_ASSERT_NOT_REACHED();
}
bool PropertyCondition::isStillValid(Concurrency concurrency, Structure* structure, JSObject* base) const
{
if (!isStillValidAssumingImpurePropertyWatchpoint(concurrency, structure, base))
return false;
// Currently we assume that an impure property can cause a property to appear, and can also
// "shadow" an existing JS property on the same object. Hence it affects presence, replacement, and
// absence. It doesn't affect AbsenceOfSetEffect because impure properties aren't ever setters.
switch (m_header.type()) {
case Absence:
if (structure->typeInfo().getOwnPropertySlotIsImpure() || structure->typeInfo().getOwnPropertySlotIsImpureForPropertyAbsence())
return false;
break;
case Presence:
case Replacement:
case Equivalence:
case HasStaticProperty:
if (structure->typeInfo().getOwnPropertySlotIsImpure())
return false;
break;
case AbsenceOfIndexedProperties:
default:
break;
}
return true;
}
bool PropertyCondition::isWatchableWhenValid(Structure* structure, WatchabilityEffort effort, Concurrency concurrency) const
{
if (structure->transitionWatchpointSetHasBeenInvalidated())
return false;
switch (m_header.type()) {
case Replacement: {
VM& vm = structure->vm();
PropertyOffset offset = structure->get(vm, concurrency, uid());
// This method should only be called when some variant of isValid returned true, which
// implies that we already confirmed that the structure knows of the property. We should
// also have verified that the Structure is a cacheable dictionary, which means we
// shouldn't have a TOCTOU race either.
RELEASE_ASSERT(offset != invalidOffset);
WatchpointSet* set = nullptr;
switch (effort) {
case MakeNoChanges:
set = structure->propertyReplacementWatchpointSet(offset);
break;
case EnsureWatchability:
set = structure->firePropertyReplacementWatchpointSet(structure->vm(), offset, "Firing replacement to ensure validity");
break;
}
if (!set || set->isStillValid())
return false;
break;
}
case Equivalence: {
PropertyOffset offset = structure->get(structure->vm(), concurrency, uid());
// This method should only be called when some variant of isValid returned true, which
// implies that we already confirmed that the structure knows of the property. We should
// also have verified that the Structure is a cacheable dictionary, which means we
// shouldn't have a TOCTOU race either.
RELEASE_ASSERT(offset != invalidOffset);
WatchpointSet* set = nullptr;
switch (effort) {
case MakeNoChanges:
set = structure->propertyReplacementWatchpointSet(offset);
break;
case EnsureWatchability:
set = structure->ensurePropertyReplacementWatchpointSet(structure->vm(), offset);
break;
}
if (!set || !set->isStillValid())
return false;
break;
}
case HasStaticProperty: {
// We just use the structure transition watchpoint for this. A structure S starts
// off with a property P in the static property hash table. If S transitions to
// S', either P remains in the static property table or not. If not, then we
// are no longer valid. So the above check of transitionWatchpointSetHasBeenInvalidated
// is sufficient.
//
// We could make this smarter in the future, since we sometimes reify static properties.
// We could make this adapt to looking at the object's storage for such reified custom
// functions, but we don't do that right now. We just allow this property condition to
// invalidate and create an Equivalence watchpoint for the materialized property sometime
// in the future.
break;
}
default:
break;
}
return true;
}
bool PropertyCondition::isWatchableAssumingImpurePropertyWatchpoint(Structure* structure, JSObject* base, WatchabilityEffort effort, Concurrency concurrency) const
{
return isStillValidAssumingImpurePropertyWatchpoint(concurrency, structure, base) && isWatchableWhenValid(structure, effort, concurrency);
}
bool PropertyCondition::isWatchableAssumingImpurePropertyWatchpoint(Structure* structure, JSObject* base, WatchabilityEffort effort) const
{
return isWatchableAssumingImpurePropertyWatchpoint(structure, base, effort, watchabilityToConcurrency(effort));
}
bool PropertyCondition::isWatchable(Structure* structure, JSObject* base, WatchabilityEffort effort) const
{
return isWatchable(structure, base, effort, watchabilityToConcurrency(effort));
}
bool PropertyCondition::isWatchable(Structure* structure, JSObject* base, WatchabilityEffort effort, Concurrency concurrency) const
{
return isStillValid(concurrency, structure, base) && isWatchableWhenValid(structure, effort, concurrency);
}
void PropertyCondition::validateReferences(const TrackedReferences& tracked) const
{
if (hasPrototype())
tracked.check(prototype());
if (hasRequiredValue())
tracked.check(requiredValue());
}
bool PropertyCondition::isValidValueForAttributes(JSValue value, unsigned attributes)
{
if (!value)
return false;
if (value.inherits<GetterSetter>())
return attributes & PropertyAttribute::Accessor;
if (value.inherits<CustomGetterSetter>())
return attributes & PropertyAttribute::CustomAccessorOrValue;
return !(attributes & PropertyAttribute::AccessorOrCustomAccessorOrValue);
}
bool PropertyCondition::isValidValueForPresence(JSValue value) const
{
return isValidValueForAttributes(value, attributes());
}
PropertyCondition PropertyCondition::attemptToMakeEquivalenceWithoutBarrier(JSObject* base) const
{
JSValue value;
{
Locker cellLocker { base->cellLock() };
Structure* structure = base->structure();
value = base->getDirectConcurrently(cellLocker, structure, offset());
}
if (!isValidValueForPresence(value))
return PropertyCondition();
return equivalenceWithoutBarrier(uid(), value);
}
PropertyCondition PropertyCondition::attemptToMakeReplacementWithoutBarrier(JSObject* base) const
{
if (kind() != Presence)
return PropertyCondition();
// Let's check the validity of this condition with the live object to see whether this is worth using Replacement PropertyCondition.
Structure* structure = base->structure();
unsigned attributes = 0;
PropertyOffset offset = structure->getConcurrently(uid(), attributes);
if (offset != this->offset())
return PropertyCondition();
if (attributes != this->attributes())
return PropertyCondition();
if (attributes & PropertyAttribute::ReadOnly)
return PropertyCondition();
return replacementWithoutBarrier(uid(), offset, attributes);
}
} // namespace JSC
namespace WTF {
void printInternal(PrintStream& out, JSC::PropertyCondition::Kind condition)
{
switch (condition) {
case JSC::PropertyCondition::Presence:
out.print("Presence");
return;
case JSC::PropertyCondition::Replacement:
out.print("Replacement");
return;
case JSC::PropertyCondition::Absence:
out.print("Absence");
return;
case JSC::PropertyCondition::AbsenceOfSetEffect:
out.print("AbsenceOfSetEffect");
return;
case JSC::PropertyCondition::AbsenceOfIndexedProperties:
out.print("AbsenceOfIndexedProperties");
return;
case JSC::PropertyCondition::Equivalence:
out.print("Equivalence");
return;
case JSC::PropertyCondition::HasStaticProperty:
out.print("HasStaticProperty");
return;
case JSC::PropertyCondition::HasPrototype:
out.print("HasPrototype");
return;
}
RELEASE_ASSERT_NOT_REACHED();
}
} // namespace WTF
|